[ViewVC] Diff of: cvs/AnyEvent-Fork-RPC/RPC.pm

Comparing AnyEvent-Fork-RPC/RPC.pm (file contents):
Revision 1.36 by root, Sat Nov 30 17:41:46 2013 UTC vs.
Revision 1.45 by root, Thu Sep 12 15:15:49 2019 UTC

 There is an important twist - the C<AnyEvent::Fork::RPC::event> function
 is only defined when the child is fully initialised. If you redirect the
 log messages in your C<init> function for example, then the C<event>
 function might not yet be available. This is why the log callback checks
-whether the fucntion is there using C<defined>, and only then uses it to
+whether the function is there using C<defined>, and only then uses it to
 log the message.
 =head1 PARENT PROCESS USAGE
 This module exports nothing, and only implements a single function:
 use Errno ();
 use Guard ();
 use AnyEvent;
-our $VERSION = 1.21;
+our $VERSION = 1.25;
 =item my $rpc = AnyEvent::Fork::RPC::run $fork, $function, [key => value...]
 The traditional way to call it. But it is way cooler to call it in the
 following way:
 been successfully handled. This is useful when you queue some requests and
 want the child to go away after it has handled them. The problem is that
 the parent must not exit either until all requests have been handled, and
 this can be accomplished by waiting for this callback.
-=item init => $function (default none)
+=item init => $function (default: none)
 When specified (by name), this function is called in the child as the very
 first thing when taking over the process, with all the arguments normally
 passed to the C<AnyEvent::Fork::run> function, except the communications
 socket.
 It is called very early - before the serialisers are created or the
 C<$function> name is resolved into a function reference, so it could be
 used to load any modules that provide the serialiser or function. It can
 not, however, create events.
-=item done => $function (default C<CORE::exit>)
+=item done => $function (default: C<CORE::exit>)
 The function to call when the asynchronous backend detects an end of file
 condition when reading from the communications socket I<and> there are no
 outstanding requests. It's ignored by the synchronous backend.
 By overriding this you can prolong the life of a RPC process after e.g.
 the parent has exited by running the event loop in the provided function
 (or simply calling it, for example, when your child process uses L<EV> you
-could provide L<EV::loop> as C<done> function).
+could provide L<EV::run> as C<done> function).
 Of course, in that case you are responsible for exiting at the appropriate
 time and not returning from
-=item async => $boolean (default: 0)
+=item async => $boolean (default: C<0>)
 The default server used in the child does all I/O blockingly, and only
 allows a single RPC call to execute concurrently.
 Setting C<async> to a true value switches to another implementation that
 synchronous, and C<AnyEvent::Fork::RPC::Async> for asynchronous mode.
 If you use a template process and want to fork both sync and async
 children, then it is permissible to load both modules.
-=item serialiser => $string (default: $AnyEvent::Fork::RPC::STRING_SERIALISER)
+=item serialiser => $string (default: C<$AnyEvent::Fork::RPC::STRING_SERIALISER>)
 All arguments, result data and event data have to be serialised to be
 transferred between the processes. For this, they have to be frozen and
 thawed in both parent and child processes.
 If you need an external module for serialisation, then you can either
 pre-load it into your L<AnyEvent::Fork> process, or you can add a C<use>
 or C<require> statement into the serialiser string. Or both.
-Here are some examples - some of them are also available as global
+Here are some examples - all of them are also available as global
 variables that make them easier to use.
 =over 4
-=item octet strings - C<$AnyEvent::Fork::RPC::STRING_SERIALISER>
+=item C<$AnyEvent::Fork::RPC::STRING_SERIALISER> - octet strings only
-This serialiser concatenates length-prefixes octet strings, and is the
+This serialiser (currently the default) concatenates length-prefixes octet
-default. That means you can only pass (and return) strings containing
+strings, and is the default. That means you can only pass (and return)
-character codes 0-255.
+strings containing character codes 0-255.
+The main advantages of this serialiser are the high speed and that it
+doesn't need another module. The main disadvantage is that you are very
+limited in what you can pass - only octet strings.
 Implementation:
    (
       sub { pack   "(w/a*)*", @_ },
       sub { unpack "(w/a*)*", shift }
    )
-=item cbor - C<$AnyEvent::Fork::RPC::CBOR_XS_SERIALISER>
+=item C<$AnyEvent::Fork::RPC::CBOR_XS_SERIALISER> - uses L<CBOR::XS>
 This serialiser creates CBOR::XS arrays - you have to make sure the
 L<CBOR::XS> module is installed for this serialiser to work. It can be
 beneficial for sharing when you preload the L<CBOR::XS> module in a template
 process.
    (
       sub {    CBOR::XS::encode_cbor_sharing \@_ },
       sub { @{ CBOR::XS::decode_cbor shift } }
    )
-=item json - C<$AnyEvent::Fork::RPC::JSON_SERIALISER>
+=item C<$AnyEvent::Fork::RPC::JSON_SERIALISER> - uses L<JSON::XS> or L<JSON>
 This serialiser creates JSON arrays - you have to make sure the L<JSON>
 module is installed for this serialiser to work. It can be beneficial for
 sharing when you preload the L<JSON> module in a template process.
    (
       sub {    JSON::encode_json \@_ },
       sub { @{ JSON::decode_json shift } }
    )
-=item storable - C<$AnyEvent::Fork::RPC::STORABLE_SERIALISER>
+=item C<$AnyEvent::Fork::RPC::STORABLE_SERIALISER> - L<Storable>
 This serialiser uses L<Storable>, which means it has high chance of
 serialising just about anything you throw at it, at the cost of having
 very high overhead per operation. It also comes with perl. It should be
 used when you need to serialise complex data structures.
    (
       sub {    Storable::freeze \@_ },
       sub { @{ Storable::thaw shift } }
    )
-=item portable storable - C<$AnyEvent::Fork::RPC::NSTORABLE_SERIALISER>
+=item C<$AnyEvent::Fork::RPC::NSTORABLE_SERIALISER> - portable Storable
 This serialiser also uses L<Storable>, but uses it's "network" format
 to serialise data, which makes it possible to talk to different
 perl binaries (for example, when talking to a process created with
 L<AnyEvent::Fork::Remote>).
       sub {    Storable::nfreeze \@_ },
       sub { @{ Storable::thaw shift } }
    )
 =back
+=item buflen => $bytes (default: C<512 - 16>)
+The starting size of the read buffer for request and response data.
+C<AnyEvent::Fork::RPC> ensures that the buffer for reeading request and
+response data is large enough for at leats aingle request or response, and
+will dynamically enlarge the buffer if needed.
+While this ensures that memory is not overly wasted, it typically leads
+to having to do one syscall per request, which can be inefficient in some
+cases. In such cases, it can be beneficient to increase the buffer size to
+hold more than one request.
+=item buflen_req => $bytes (default: same as C<buflen>)
+Overrides C<buflen> for request data (as read by the forked process).
+=item buflen_res => $bytes (default: same as C<buflen>)
+Overrides C<buflen> for response data (replies read by the parent process).
 =back
 See the examples section earlier in this document for some actual
 examples.
    $on_event ||= sub { $on_error->("event received, but no on_event handler") };
    my ($f, $t) = eval $serialiser; die $@ if $@;
    my (@rcb, %rcb, $fh, $shutdown, $wbuf, $ww);
-   my ($rlen, $rbuf, $rw) = 512 - 16;
+   my ($rlen, $rbuf, $rw) = $arg{buflen_res} || $arg{buflen} || 512 - 16;
    my $wcb = sub {
       my $len = syswrite $fh, $wbuf;
       unless (defined $len) {
       }
    };
    my $module = "AnyEvent::Fork::RPC::" . ($arg{async} ? "Async" : "Sync");
-   $self->require ($module)
+   $self->eval ("use $module 2 ()")
-        ->send_arg ($function, $arg{init}, $serialiser, $arg{done} || "$module\::do_exit")
+        ->send_arg (
+             function   => $function,
+             init       => $arg{init},
+             serialiser => $serialiser,
+             done       => $arg{done} || "$module\::do_exit",
+             rlen       => $arg{buflen_req} || $arg{buflen} || 512 - 16,
+             -10 # the above are 10 arguments
+          )
         ->run ("$module\::run", sub {
-      $fh = shift;
+      $fh = shift
+         or return $on_error->("connection failed");
       my ($id, $len);
       $rw = AE::io $fh, 0, sub {
          $rlen = $rlen * 2 + 16 if $rlen - 128 < length $rbuf;
          $len = sysread $fh, $rbuf, $rlen - length $rbuf, length $rbuf;
 values.
 See the examples section earlier in this document for some actual
 examples.
+Note: the event data, like any data send to the parent, might not be sent
+immediatelly but queued for later sending, so there is no guarantee that
+the event has been sent to the parent when the call returns - when you
+e.g. exit directly after calling this function, the parent might never
+receive the event.
 =back
 =head2 PROCESS EXIT
 If and when the child process exits depends on the backend and
 are queued and the jobs are slow, they will all run concurrently. The
 child must implement some queueing/limiting mechanism if this causes
 problems. Alternatively, the parent could limit the amount of rpc calls
 that are outstanding.
-Blocking use of condvars is not supported.
+Blocking use of condvars is not supported (in the main thread, outside of
+e.g. L<Coro> threads).
 Using event-based modules such as L<IO::AIO>, L<Gtk2>, L<Tk> and so on is
 easy.
 =back
 gory details.
 =head1 EXCEPTIONS
 There are no provisions whatsoever for catching exceptions at this time -
-in the child, exeptions might kill the process, causing calls to be lost
+in the child, exceptions might kill the process, causing calls to be lost
 and the parent encountering a fatal error. In the parent, exceptions in
 the result callback will not be caught and cause undefined behaviour.
 =head1 SEE ALSO

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing AnyEvent-Fork-RPC/RPC.pm (file contents): Revision 1.36 by root, Sat Nov 30 17:41:46 2013 UTC vs. Revision 1.45 by root, Thu Sep 12 15:15:49 2019 UTC

Diff Legend

Comparing AnyEvent-Fork-RPC/RPC.pm (file contents):
Revision 1.36 by root, Sat Nov 30 17:41:46 2013 UTC vs.
Revision 1.45 by root, Thu Sep 12 15:15:49 2019 UTC