[ViewVC] Diff of: cvs/AnyEvent-Fork/Fork.pm

Comparing AnyEvent-Fork/Fork.pm (file contents):
Revision 1.18 by root, Sat Apr 6 01:33:56 2013 UTC vs.
Revision 1.57 by root, Sun Aug 25 17:38:43 2013 UTC

…		…
4		4
5	=head1 SYNOPSIS	5	=head1 SYNOPSIS
6		6
7	use AnyEvent::Fork;	7	use AnyEvent::Fork;
8		8
9	##################################################################	9	AnyEvent::Fork
		10	->new
		11	->require ("MyModule")
		12	->run ("MyModule::server", my $cv = AE::cv);
		13
		14	my $fh = $cv->recv;
		15
		16	=head1 DESCRIPTION
		17
		18	This module allows you to create new processes, without actually forking
		19	them from your current process (avoiding the problems of forking), but
		20	preserving most of the advantages of fork.
		21
		22	It can be used to create new worker processes or new independent
		23	subprocesses for short- and long-running jobs, process pools (e.g. for use
		24	in pre-forked servers) but also to spawn new external processes (such as
		25	CGI scripts from a web server), which can be faster (and more well behaved)
		26	than using fork+exec in big processes.
		27
		28	Special care has been taken to make this module useful from other modules,
		29	while still supporting specialised environments such as L<App::Staticperl>
		30	or L<PAR::Packer>.
		31
		32	=head2 WHAT THIS MODULE IS NOT
		33
		34	This module only creates processes and lets you pass file handles and
		35	strings to it, and run perl code. It does not implement any kind of RPC -
		36	there is no back channel from the process back to you, and there is no RPC
		37	or message passing going on.
		38
		39	If you need some form of RPC, you could use the L<AnyEvent::Fork::RPC>
		40	companion module, which adds simple RPC/job queueing to a process created
		41	by this module.
		42
		43	And if you need some automatic process pool management on top of
		44	L<AnyEvent::Fork::RPC>, you can look at the L<AnyEvent::Fork::Pool>
		45	companion module.
		46
		47	Or you can implement it yourself in whatever way you like: use some
		48	message-passing module such as L<AnyEvent::MP>, some pipe such as
		49	L<AnyEvent::ZeroMQ>, use L<AnyEvent::Handle> on both sides to send
		50	e.g. JSON or Storable messages, and so on.
		51
		52	=head2 COMPARISON TO OTHER MODULES
		53
		54	There is an abundance of modules on CPAN that do "something fork", such as
		55	L<Parallel::ForkManager>, L<AnyEvent::ForkManager>, L<AnyEvent::Worker>
		56	or L<AnyEvent::Subprocess>. There are modules that implement their own
		57	process management, such as L<AnyEvent::DBI>.
		58
		59	The problems that all these modules try to solve are real, however, none
		60	of them (from what I have seen) tackle the very real problems of unwanted
		61	memory sharing, efficiency, not being able to use event processing or
		62	similar modules in the processes they create.
		63
		64	This module doesn't try to replace any of them - instead it tries to solve
		65	the problem of creating processes with a minimum of fuss and overhead (and
		66	also luxury). Ideally, most of these would use AnyEvent::Fork internally,
		67	except they were written before AnyEvent:Fork was available, so obviously
		68	had to roll their own.
		69
		70	=head2 PROBLEM STATEMENT
		71
		72	There are two traditional ways to implement parallel processing on UNIX
		73	like operating systems - fork and process, and fork+exec and process. They
		74	have different advantages and disadvantages that I describe below,
		75	together with how this module tries to mitigate the disadvantages.
		76
		77	=over 4
		78
		79	=item Forking from a big process can be very slow.
		80
		81	A 5GB process needs 0.05s to fork on my 3.6GHz amd64 GNU/Linux box. This
		82	overhead is often shared with exec (because you have to fork first), but
		83	in some circumstances (e.g. when vfork is used), fork+exec can be much
		84	faster.
		85
		86	This module can help here by telling a small(er) helper process to fork,
		87	which is faster then forking the main process, and also uses vfork where
		88	possible. This gives the speed of vfork, with the flexibility of fork.
		89
		90	=item Forking usually creates a copy-on-write copy of the parent
		91	process.
		92
		93	For example, modules or data files that are loaded will not use additional
		94	memory after a fork. When exec'ing a new process, modules and data files
		95	might need to be loaded again, at extra CPU and memory cost. But when
		96	forking, literally all data structures are copied - if the program frees
		97	them and replaces them by new data, the child processes will retain the
		98	old version even if it isn't used, which can suddenly and unexpectedly
		99	increase memory usage when freeing memory.
		100
		101	The trade-off is between more sharing with fork (which can be good or
		102	bad), and no sharing with exec.
		103
		104	This module allows the main program to do a controlled fork, and allows
		105	modules to exec processes safely at any time. When creating a custom
		106	process pool you can take advantage of data sharing via fork without
		107	risking to share large dynamic data structures that will blow up child
		108	memory usage.
		109
		110	In other words, this module puts you into control over what is being
		111	shared and what isn't, at all times.
		112
		113	=item Exec'ing a new perl process might be difficult.
		114
		115	For example, it is not easy to find the correct path to the perl
		116	interpreter - C<$^X> might not be a perl interpreter at all.
		117
		118	This module tries hard to identify the correct path to the perl
		119	interpreter. With a cooperative main program, exec'ing the interpreter
		120	might not even be necessary, but even without help from the main program,
		121	it will still work when used from a module.
		122
		123	=item Exec'ing a new perl process might be slow, as all necessary modules
		124	have to be loaded from disk again, with no guarantees of success.
		125
		126	Long running processes might run into problems when perl is upgraded
		127	and modules are no longer loadable because they refer to a different
		128	perl version, or parts of a distribution are newer than the ones already
		129	loaded.
		130
		131	This module supports creating pre-initialised perl processes to be used as
		132	a template for new processes.
		133
		134	=item Forking might be impossible when a program is running.
		135
		136	For example, POSIX makes it almost impossible to fork from a
		137	multi-threaded program while doing anything useful in the child - in
		138	fact, if your perl program uses POSIX threads (even indirectly via
		139	e.g. L<IO::AIO> or L<threads>), you cannot call fork on the perl level
		140	anymore without risking corruption issues on a number of operating
		141	systems.
		142
		143	This module can safely fork helper processes at any time, by calling
		144	fork+exec in C, in a POSIX-compatible way (via L<Proc::FastSpawn>).
		145
		146	=item Parallel processing with fork might be inconvenient or difficult
		147	to implement. Modules might not work in both parent and child.
		148
		149	For example, when a program uses an event loop and creates watchers it
		150	becomes very hard to use the event loop from a child program, as the
		151	watchers already exist but are only meaningful in the parent. Worse, a
		152	module might want to use such a module, not knowing whether another module
		153	or the main program also does, leading to problems.
		154
		155	Apart from event loops, graphical toolkits also commonly fall into the
		156	"unsafe module" category, or just about anything that communicates with
		157	the external world, such as network libraries and file I/O modules, which
		158	usually don't like being copied and then allowed to continue in two
		159	processes.
		160
		161	With this module only the main program is allowed to create new processes
		162	by forking (because only the main program can know when it is still safe
		163	to do so) - all other processes are created via fork+exec, which makes it
		164	possible to use modules such as event loops or window interfaces safely.
		165
		166	=back
		167
		168	=head1 EXAMPLES
		169
10	# create a single new process, tell it to run your worker function	170	=head2 Create a single new process, tell it to run your worker function.
11		171
12	AnyEvent::Fork	172	AnyEvent::Fork
13	->new	173	->new
14	->require ("MyModule")	174	->require ("MyModule")
15	->run ("MyModule::worker, sub {	175	->run ("MyModule::worker, sub {
…		…
17		177
18	# now $master_filehandle is connected to the	178	# now $master_filehandle is connected to the
19	# $slave_filehandle in the new process.	179	# $slave_filehandle in the new process.
20	});	180	});
21		181
22	# MyModule::worker might look like this	182	C<MyModule> might look like this:
		183
		184	package MyModule;
		185
23	sub MyModule::worker {	186	sub worker {
24	my ($slave_filehandle) = @_;	187	my ($slave_filehandle) = @_;
25		188
26	# now $slave_filehandle is connected to the $master_filehandle	189	# now $slave_filehandle is connected to the $master_filehandle
27	# in the original prorcess. have fun!	190	# in the original prorcess. have fun!
28	}	191	}
29		192
30	##################################################################
31	# create a pool of server processes all accepting on the same socket	193	=head2 Create a pool of server processes all accepting on the same socket.
32		194
33	# create listener socket	195	# create listener socket
34	my $listener = ...;	196	my $listener = ...;
35		197
36	# create a pool template, initialise it and give it the socket	198	# create a pool template, initialise it and give it the socket
…		…
48	}	210	}
49		211
50	# now do other things - maybe use the filehandle provided by run	212	# now do other things - maybe use the filehandle provided by run
51	# to wait for the processes to die. or whatever.	213	# to wait for the processes to die. or whatever.
52		214
53	# My::Server::run might look like this	215	C<My::Server> might look like this:
54	sub My::Server::run {	216
		217	package My::Server;
		218
		219	sub run {
55	my ($slave, $listener, $id) = @_;	220	my ($slave, $listener, $id) = @_;
56		221
57	close $slave; # we do not use the socket, so close it to save resources	222	close $slave; # we do not use the socket, so close it to save resources
58		223
59	# we could go ballistic and use e.g. AnyEvent here, or IO::AIO,	224	# we could go ballistic and use e.g. AnyEvent here, or IO::AIO,
…		…
61	while (my $socket = $listener->accept) {	226	while (my $socket = $listener->accept) {
62	# do sth. with new socket	227	# do sth. with new socket
63	}	228	}
64	}	229	}
65		230
66	=head1 DESCRIPTION	231	=head2 use AnyEvent::Fork as a faster fork+exec
67		232
68	This module allows you to create new processes, without actually forking	233	This runs C</bin/echo hi>, with standard output redirected to F</tmp/log>
69	them from your current process (avoiding the problems of forking), but	234	and standard error redirected to the communications socket. It is usually
70	preserving most of the advantages of fork.	235	faster than fork+exec, but still lets you prepare the environment.
71		236
72	It can be used to create new worker processes or new independent	237	open my $output, ">/tmp/log" or die "$!";
73	subprocesses for short- and long-running jobs, process pools (e.g. for use
74	in pre-forked servers) but also to spawn new external processes (such as
75	CGI scripts from a web server), which can be faster (and more well behaved)
76	than using fork+exec in big processes.
77		238
78	Special care has been taken to make this module useful from other modules,	239	AnyEvent::Fork
79	while still supporting specialised environments such as L<App::Staticperl>	240	->new
80	or L<PAR::Packer>.	241	->eval ('
		242	# compile a helper function for later use
		243	sub run {
		244	my ($fh, $output, @cmd) = @_;
81		245
82	=head1 WHAT THIS MODULE IS NOT	246	# perl will clear close-on-exec on STDOUT/STDERR
		247	open STDOUT, ">&", $output or die;
		248	open STDERR, ">&", $fh or die;
83		249
84	This module only creates processes and lets you pass file handles and	250	exec @cmd;
85	strings to it, and run perl code. It does not implement any kind of RPC -	251	}
86	there is no back channel from the process back to you, and there is no RPC	252	')
87	or message passing going on.	253	->send_fh ($output)
		254	->send_arg ("/bin/echo", "hi")
		255	->run ("run", my $cv = AE::cv);
88		256
89	If you need some form of RPC, you can either implement it yourself	257	my $stderr = $cv->recv;
90	in whatever way you like, use some message-passing module such
91	as L<AnyEvent::MP>, some pipe such as L<AnyEvent::ZeroMQ>, use
92	L<AnyEvent::Handle> on both sides to send e.g. JSON or Storable messages,
93	and so on.
94		258
95	=head1 PROBLEM STATEMENT	259	=head2 For stingy users: put the worker code into a C<DATA> section.
96		260
97	There are two ways to implement parallel processing on UNIX like operating	261	When you want to be stingy with files, you cna put your code into the
98	systems - fork and process, and fork+exec and process. They have different	262	C<DATA> section of your module (or program):
99	advantages and disadvantages that I describe below, together with how this
100	module tries to mitigate the disadvantages.
101		263
102	=over 4	264	use AnyEvent::Fork;
103		265
104	=item Forking from a big process can be very slow (a 5GB process needs	266	AnyEvent::Fork
105	0.05s to fork on my 3.6GHz amd64 GNU/Linux box for example). This overhead	267	->new
106	is often shared with exec (because you have to fork first), but in some	268	->eval (do { local $/; <DATA> })
107	circumstances (e.g. when vfork is used), fork+exec can be much faster.	269	->run ("doit", sub { ... });
108		270
109	This module can help here by telling a small(er) helper process to fork,	271	__DATA__
110	or fork+exec instead.
111		272
112	=item Forking usually creates a copy-on-write copy of the parent	273	sub doit {
113	process. Memory (for example, modules or data files that have been	274	... do something!
114	will not take additional memory). When exec'ing a new process, modules	275	}
115	and data files might need to be loaded again, at extra CPU and memory
116	cost. Likewise when forking, all data structures are copied as well - if
117	the program frees them and replaces them by new data, the child processes
118	will retain the memory even if it isn't used.
119		276
120	This module allows the main program to do a controlled fork, and allows	277	=head2 For stingy standalone programs: do not rely on external files at
121	modules to exec processes safely at any time. When creating a custom	278	all.
122	process pool you can take advantage of data sharing via fork without
123	risking to share large dynamic data structures that will blow up child
124	memory usage.
125		279
126	=item Exec'ing a new perl process might be difficult and slow. For	280	For single-file scripts it can be inconvenient to rely on external
127	example, it is not easy to find the correct path to the perl interpreter,	281	files - even when using < C<DATA> section, you still need to C<exec>
128	and all modules have to be loaded from disk again. Long running processes	282	an external perl interpreter, which might not be available when using
129	might run into problems when perl is upgraded for example.	283	L<App::Staticperl>, L<Urlader> or L<PAR::Packer> for example.
130		284
131	This module supports creating pre-initialised perl processes to be used	285	Two modules help here - L<AnyEvent::Fork::Early> forks a template process
132	as template, and also tries hard to identify the correct path to the perl	286	for all further calls to C<new_exec>, and L<AnyEvent::Fork::Template>
133	interpreter. With a cooperative main program, exec'ing the interpreter	287	forks the main program as a template process.
134	might not even be necessary.
135		288
136	=item Forking might be impossible when a program is running. For example,	289	Here is how your main program should look like:
137	POSIX makes it almost impossible to fork from a multi-threaded program and
138	do anything useful in the child - strictly speaking, if your perl program
139	uses posix threads (even indirectly via e.g. L<IO::AIO> or L<threads>),
140	you cannot call fork on the perl level anymore, at all.
141		290
142	This module can safely fork helper processes at any time, by calling	291	#! perl
143	fork+exec in C, in a POSIX-compatible way.
144		292
145	=item Parallel processing with fork might be inconvenient or difficult	293	# optional, as the very first thing.
146	to implement. For example, when a program uses an event loop and creates	294	# in case modules want to create their own processes.
147	watchers it becomes very hard to use the event loop from a child	295	use AnyEvent::Fork::Early;
148	program, as the watchers already exist but are only meaningful in the
149	parent. Worse, a module might want to use such a system, not knowing
150	whether another module or the main program also does, leading to problems.
151		296
152	This module only lets the main program create pools by forking (because	297	# next, load all modules you need in your template process
153	only the main program can know when it is still safe to do so) - all other	298	use Example::My::Module
154	pools are created by fork+exec, after which such modules can again be	299	use Example::Whatever;
155	loaded.
156		300
157	=back	301	# next, put your run function definition and anything else you
		302	# need, but do not use code outside of BEGIN blocks.
		303	sub worker_run {
		304	my ($fh, @args) = @_;
		305	...
		306	}
		307
		308	# now preserve everything so far as AnyEvent::Fork object
		309	# in §TEMPLATE.
		310	use AnyEvent::Fork::Template;
		311
		312	# do not put code outside of BEGIN blocks until here
		313
		314	# now use the $TEMPLATE process in any way you like
		315
		316	# for example: create 10 worker processes
		317	my @worker;
		318	my $cv = AE::cv;
		319	for (1..10) {
		320	$cv->begin;
		321	$TEMPLATE->fork->send_arg ($_)->run ("worker_run", sub {
		322	push @worker, shift;
		323	$cv->end;
		324	});
		325	}
		326	$cv->recv;
158		327
159	=head1 CONCEPTS	328	=head1 CONCEPTS
160		329
161	This module can create new processes either by executing a new perl	330	This module can create new processes either by executing a new perl
162	process, or by forking from an existing "template" process.	331	process, or by forking from an existing "template" process.
		332
		333	All these processes are called "child processes" (whether they are direct
		334	children or not), while the process that manages them is called the
		335	"parent process".
163		336
164	Each such process comes with its own file handle that can be used to	337	Each such process comes with its own file handle that can be used to
165	communicate with it (it's actually a socket - one end in the new process,	338	communicate with it (it's actually a socket - one end in the new process,
166	one end in the main process), and among the things you can do in it are	339	one end in the main process), and among the things you can do in it are
167	load modules, fork new processes, send file handles to it, and execute	340	load modules, fork new processes, send file handles to it, and execute
…		…
241	my ($fork_fh) = @_;	414	my ($fork_fh) = @_;
242	});	415	});
243		416
244	=back	417	=back
245		418
246	=head1 FUNCTIONS	419	=head1 THE C<AnyEvent::Fork> CLASS
		420
		421	This module exports nothing, and only implements a single class -
		422	C<AnyEvent::Fork>.
		423
		424	There are two class constructors that both create new processes - C<new>
		425	and C<new_exec>. The C<fork> method creates a new process by forking an
		426	existing one and could be considered a third constructor.
		427
		428	Most of the remaining methods deal with preparing the new process, by
		429	loading code, evaluating code and sending data to the new process. They
		430	usually return the process object, so you can chain method calls.
		431
		432	If a process object is destroyed before calling its C<run> method, then
		433	the process simply exits. After C<run> is called, all responsibility is
		434	passed to the specified function.
		435
		436	As long as there is any outstanding work to be done, process objects
		437	resist being destroyed, so there is no reason to store them unless you
		438	need them later - configure and forget works just fine.
247		439
248	=over 4	440	=over 4
249		441
250	=cut	442	=cut
251		443
…		…
258	use AnyEvent;	450	use AnyEvent;
259	use AnyEvent::Util ();	451	use AnyEvent::Util ();
260		452
261	use IO::FDPass;	453	use IO::FDPass;
262		454
263	our $VERSION = 0.2;	455	our $VERSION = 1.1;
264
265	our $PERL; # the path to the perl interpreter, deduces with various forms of magic
266
267	=item my $pool = new AnyEvent::Fork key => value...
268
269	Create a new process pool. The following named parameters are supported:
270
271	=over 4
272
273	=back
274
275	=cut
276		456
277	# the early fork template process	457	# the early fork template process
278	our $EARLY;	458	our $EARLY;
279		459
280	# the empty template process	460	# the empty template process
281	our $TEMPLATE;	461	our $TEMPLATE;
		462
		463	sub QUEUE() { 0 }
		464	sub FH() { 1 }
		465	sub WW() { 2 }
		466	sub PID() { 3 }
		467	sub CB() { 4 }
		468
		469	sub _new {
		470	my ($self, $fh, $pid) = @_;
		471
		472	AnyEvent::Util::fh_nonblocking $fh, 1;
		473
		474	$self = bless [
		475	[], # write queue - strings or fd's
		476	$fh,
		477	undef, # AE watcher
		478	$pid,
		479	], $self;
		480
		481	$self
		482	}
282		483
283	sub _cmd {	484	sub _cmd {
284	my $self = shift;	485	my $self = shift;
285		486
286	# ideally, we would want to use "a (w/a)*" as format string, but perl	487	# ideally, we would want to use "a (w/a)*" as format string, but perl
287	# versions from at least 5.8.9 to 5.16.3 are all buggy and can't unpack	488	# versions from at least 5.8.9 to 5.16.3 are all buggy and can't unpack
288	# it.	489	# it.
289	push @{ $self->[2] }, pack "L/a", pack "(w/a)*", @_;	490	push @{ $self->[QUEUE] }, pack "a L/a*", $_[0], $_[1];
290		491
291	unless ($self->[3]) {	492	$self->[WW] \|\|= AE::io $self->[FH], 1, sub {
292	my $wcb = sub {
293	do {	493	do {
294	# send the next "thing" in the queue - either a reference to an fh,	494	# send the next "thing" in the queue - either a reference to an fh,
295	# or a plain string.	495	# or a plain string.
296		496
297	if (ref $self->[2][0]) {	497	if (ref $self->[QUEUE][0]) {
298	# send fh	498	# send fh
299	unless (IO::FDPass::send fileno $self->[1], fileno ${ $self->[2][0] }) {	499	unless (IO::FDPass::send fileno $self->[FH], fileno ${ $self->[QUEUE][0] }) {
300	return if $! == Errno::EAGAIN \|\| $! == Errno::EWOULDBLOCK;	500	return if $! == Errno::EAGAIN \|\| $! == Errno::EWOULDBLOCK;
301	undef $self->[3];	501	undef $self->[WW];
302	die "AnyEvent::Fork: file descriptor send failure: $!";	502	die "AnyEvent::Fork: file descriptor send failure: $!";
303	}
304
305	shift @{ $self->[2] };
306
307	} else {
308	# send string
309	my $len = syswrite $self->[1], $self->[2][0];
310
311	unless ($len) {
312	return if $! == Errno::EAGAIN \|\| $! == Errno::EWOULDBLOCK;
313	undef $self->[3];
314	die "AnyEvent::Fork: command write failure: $!";
315	}
316
317	substr $self->[2][0], 0, $len, "";
318	shift @{ $self->[2] } unless length $self->[2][0];
319	}	503	}
		504
		505	shift @{ $self->[QUEUE] };
		506
		507	} else {
		508	# send string
		509	my $len = syswrite $self->[FH], $self->[QUEUE][0];
		510
		511	unless ($len) {
		512	return if $! == Errno::EAGAIN \|\| $! == Errno::EWOULDBLOCK;
		513	undef $self->[WW];
		514	die "AnyEvent::Fork: command write failure: $!";
		515	}
		516
		517	substr $self->[QUEUE][0], 0, $len, "";
		518	shift @{ $self->[QUEUE] } unless length $self->[QUEUE][0];
		519	}
320	} while @{ $self->[2] };	520	} while @{ $self->[QUEUE] };
321		521
322	# everything written	522	# everything written
323	undef $self->[3];	523	undef $self->[WW];
		524
324	# invoke run callback	525	# invoke run callback, if any
		526	if ($self->[CB]) {
325	$self->[0]->($self->[1]) if $self->[0];	527	$self->[CB]->($self->[FH]);
		528	@$self = ();
326	};	529	}
327
328	$wcb->();
329
330	$self->[3] \|\|= AE::io $self->[1], 1, $wcb
331	if @{ $self->[2] };
332	}	530	};
333		531
334	() # make sure we don't leak the watcher	532	() # make sure we don't leak the watcher
335	}
336
337	sub _new {
338	my ($self, $fh) = @_;
339
340	AnyEvent::Util::fh_nonblocking $fh, 1;
341
342	$self = bless [
343	undef, # run callback
344	$fh,
345	[], # write queue - strings or fd's
346	undef, # AE watcher
347	], $self;
348
349	$self
350	}	533	}
351		534
352	# fork template from current process, used by AnyEvent::Fork::Early/Template	535	# fork template from current process, used by AnyEvent::Fork::Early/Template
353	sub _new_fork {	536	sub _new_fork {
354	my ($fh, $slave) = AnyEvent::Util::portable_socketpair;	537	my ($fh, $slave) = AnyEvent::Util::portable_socketpair;
…		…
359	if ($pid eq 0) {	542	if ($pid eq 0) {
360	require AnyEvent::Fork::Serve;	543	require AnyEvent::Fork::Serve;
361	$AnyEvent::Fork::Serve::OWNER = $parent;	544	$AnyEvent::Fork::Serve::OWNER = $parent;
362	close $fh;	545	close $fh;
363	$0 = "$_[1] of $parent";	546	$0 = "$_[1] of $parent";
364	$SIG{CHLD} = 'IGNORE';
365	AnyEvent::Fork::Serve::serve ($slave);	547	AnyEvent::Fork::Serve::serve ($slave);
366	exit 0;	548	exit 0;
367	} elsif (!$pid) {	549	} elsif (!$pid) {
368	die "AnyEvent::Fork::Early/Template: unable to fork template process: $!";	550	die "AnyEvent::Fork::Early/Template: unable to fork template process: $!";
369	}	551	}
370		552
371	AnyEvent::Fork->_new ($fh)	553	AnyEvent::Fork->_new ($fh, $pid)
372	}	554	}
373		555
374	=item my $proc = new AnyEvent::Fork	556	=item my $proc = new AnyEvent::Fork
375		557
376	Create a new "empty" perl interpreter process and returns its process	558	Create a new "empty" perl interpreter process and returns its process
377	object for further manipulation.	559	object for further manipulation.
378		560
379	The new process is forked from a template process that is kept around	561	The new process is forked from a template process that is kept around
380	for this purpose. When it doesn't exist yet, it is created by a call to	562	for this purpose. When it doesn't exist yet, it is created by a call to
381	C<new_exec> and kept around for future calls.	563	C<new_exec> first and then stays around for future calls.
382
383	When the process object is destroyed, it will release the file handle
384	that connects it with the new process. When the new process has not yet
385	called C<run>, then the process will exit. Otherwise, what happens depends
386	entirely on the code that is executed.
387		564
388	=cut	565	=cut
389		566
390	sub new {	567	sub new {
391	my $class = shift;	568	my $class = shift;
…		…
428		605
429	You should use C<new> whenever possible, except when having a template	606	You should use C<new> whenever possible, except when having a template
430	process around is unacceptable.	607	process around is unacceptable.
431		608
432	The path to the perl interpreter is divined using various methods - first	609	The path to the perl interpreter is divined using various methods - first
433	C<$^X> is investigated to see if the path ends with something that sounds	610	C<$^X> is investigated to see if the path ends with something that looks
434	as if it were the perl interpreter. Failing this, the module falls back to	611	as if it were the perl interpreter. Failing this, the module falls back to
435	using C<$Config::Config{perlpath}>.	612	using C<$Config::Config{perlpath}>.
436		613
		614	The path to perl can also be overriden by setting the global variable
		615	C<$AnyEvent::Fork::PERL> - it's value will be used for all subsequent
		616	invocations.
		617
437	=cut	618	=cut
		619
		620	our $PERL;
438		621
439	sub new_exec {	622	sub new_exec {
440	my ($self) = @_;	623	my ($self) = @_;
441		624
442	return $EARLY->fork	625	return $EARLY->fork
443	if $EARLY;	626	if $EARLY;
444		627
		628	unless (defined $PERL) {
445	# first find path of perl	629	# first find path of perl
446	my $perl = $;	630	my $perl = $;
447		631
448	# first we try $^X, but the path must be absolute (always on win32), and end in sth.	632	# first we try $^X, but the path must be absolute (always on win32), and end in sth.
449	# that looks like perl. this obviously only works for posix and win32	633	# that looks like perl. this obviously only works for posix and win32
450	unless (	634	unless (
451	($^O eq "MSWin32" \|\| $perl =~ m%^/%)	635	($^O eq "MSWin32" \|\| $perl =~ m%^/%)
452	&& $perl =~ m%[/\\]perl(?:[0-9]+(\.[0-9]+)+)?(\.exe)?$%i	636	&& $perl =~ m%[/\\]perl(?:[0-9]+(\.[0-9]+)+)?(\.exe)?$%i
453	) {	637	) {
454	# if it doesn't look perlish enough, try Config	638	# if it doesn't look perlish enough, try Config
455	require Config;	639	require Config;
456	$perl = $Config::Config{perlpath};	640	$perl = $Config::Config{perlpath};
457	$perl =~ s/(?:\Q$Config::Config{_exe}\E)?$/$Config::Config{_exe}/;	641	$perl =~ s/(?:\Q$Config::Config{_exe}\E)?$/$Config::Config{_exe}/;
		642	}
		643
		644	$PERL = $perl;
458	}	645	}
459		646
460	require Proc::FastSpawn;	647	require Proc::FastSpawn;
461		648
462	my ($fh, $slave) = AnyEvent::Util::portable_socketpair;	649	my ($fh, $slave) = AnyEvent::Util::portable_socketpair;
…		…
469	# quick. also doesn't work in win32. of course. what did you expect	656	# quick. also doesn't work in win32. of course. what did you expect
470	#local $ENV{PERL5LIB} = join ":", grep !ref, @INC;	657	#local $ENV{PERL5LIB} = join ":", grep !ref, @INC;
471	my %env = %ENV;	658	my %env = %ENV;
472	$env{PERL5LIB} = join +($^O eq "MSWin32" ? ";" : ":"), grep !ref, @INC;	659	$env{PERL5LIB} = join +($^O eq "MSWin32" ? ";" : ":"), grep !ref, @INC;
473		660
474	Proc::FastSpawn::spawn (	661	my $pid = Proc::FastSpawn::spawn (
475	$perl,	662	$PERL,
476	["perl", "-MAnyEvent::Fork::Serve", "-e", "AnyEvent::Fork::Serve::me", fileno $slave, $$],	663	["perl", "-MAnyEvent::Fork::Serve", "-e", "AnyEvent::Fork::Serve::me", fileno $slave, $$],
477	[map "$_=$env{$_}", keys %env],	664	[map "$_=$env{$_}", keys %env],
478	) or die "unable to spawn AnyEvent::Fork server: $!";	665	) or die "unable to spawn AnyEvent::Fork server: $!";
479		666
480	$self->_new ($fh)	667	$self->_new ($fh, $pid)
		668	}
		669
		670	=item $pid = $proc->pid
		671
		672	Returns the process id of the process I<iff it is a direct child of the
		673	process running AnyEvent::Fork>, and C<undef> otherwise.
		674
		675	Normally, only processes created via C<< AnyEvent::Fork->new_exec >> and
		676	L<AnyEvent::Fork::Template> are direct children, and you are responsible
		677	to clean up their zombies when they die.
		678
		679	All other processes are not direct children, and will be cleaned up by
		680	AnyEvent::Fork itself.
		681
		682	=cut
		683
		684	sub pid {
		685	$_[0][PID]
481	}	686	}
482		687
483	=item $proc = $proc->eval ($perlcode, @args)	688	=item $proc = $proc->eval ($perlcode, @args)
484		689
485	Evaluates the given C<$perlcode> as ... perl code, while setting C<@_> to	690	Evaluates the given C<$perlcode> as ... Perl code, while setting C<@_> to
486	the strings specified by C<@args>.	691	the strings specified by C<@args>, in the "main" package.
487		692
488	This call is meant to do any custom initialisation that might be required	693	This call is meant to do any custom initialisation that might be required
489	(for example, the C<require> method uses it). It's not supposed to be used	694	(for example, the C<require> method uses it). It's not supposed to be used
490	to completely take over the process, use C<run> for that.	695	to completely take over the process, use C<run> for that.
491		696
492	The code will usually be executed after this call returns, and there is no	697	The code will usually be executed after this call returns, and there is no
493	way to pass anything back to the calling process. Any evaluation errors	698	way to pass anything back to the calling process. Any evaluation errors
494	will be reported to stderr and cause the process to exit.	699	will be reported to stderr and cause the process to exit.
495		700
		701	If you want to execute some code (that isn't in a module) to take over the
		702	process, you should compile a function via C<eval> first, and then call
		703	it via C<run>. This also gives you access to any arguments passed via the
		704	C<send_xxx> methods, such as file handles. See the L<use AnyEvent::Fork as
		705	a faster fork+exec> example to see it in action.
		706
496	Returns the process object for easy chaining of method calls.	707	Returns the process object for easy chaining of method calls.
497		708
498	=cut	709	=cut
499		710
500	sub eval {	711	sub eval {
501	my ($self, $code, @args) = @_;	712	my ($self, $code, @args) = @_;
502		713
503	$self->_cmd (e => $code, @args);	714	$self->_cmd (e => pack "(w/a)", $code, @args);
504		715
505	$self	716	$self
506	}	717	}
507		718
508	=item $proc = $proc->require ($module, ...)	719	=item $proc = $proc->require ($module, ...)
…		…
525	=item $proc = $proc->send_fh ($handle, ...)	736	=item $proc = $proc->send_fh ($handle, ...)
526		737
527	Send one or more file handles (I<not> file descriptors) to the process,	738	Send one or more file handles (I<not> file descriptors) to the process,
528	to prepare a call to C<run>.	739	to prepare a call to C<run>.
529		740
530	The process object keeps a reference to the handles until this is done,	741	The process object keeps a reference to the handles until they have
531	so you must not explicitly close the handles. This is most easily	742	been passed over to the process, so you must not explicitly close the
532	accomplished by simply not storing the file handles anywhere after passing	743	handles. This is most easily accomplished by simply not storing the file
533	them to this method.	744	handles anywhere after passing them to this method - when AnyEvent::Fork
		745	is finished using them, perl will automatically close them.
534		746
535	Returns the process object for easy chaining of method calls.	747	Returns the process object for easy chaining of method calls.
536		748
537	Example: pass a file handle to a process, and release it without	749	Example: pass a file handle to a process, and release it without
538	closing. It will be closed automatically when it is no longer used.	750	closing. It will be closed automatically when it is no longer used.
…		…
545	sub send_fh {	757	sub send_fh {
546	my ($self, @fh) = @_;	758	my ($self, @fh) = @_;
547		759
548	for my $fh (@fh) {	760	for my $fh (@fh) {
549	$self->_cmd ("h");	761	$self->_cmd ("h");
550	push @{ $self->[2] }, \$fh;	762	push @{ $self->[QUEUE] }, \$fh;
551	}	763	}
552		764
553	$self	765	$self
554	}	766	}
555		767
556	=item $proc = $proc->send_arg ($string, ...)	768	=item $proc = $proc->send_arg ($string, ...)
557		769
558	Send one or more argument strings to the process, to prepare a call to	770	Send one or more argument strings to the process, to prepare a call to
559	C<run>. The strings can be any octet string.	771	C<run>. The strings can be any octet strings.
560		772
561	The protocol is optimised to pass a moderate number of relatively short	773	The protocol is optimised to pass a moderate number of relatively short
562	strings - while you can pass up to 4GB of data in one go, this is more	774	strings - while you can pass up to 4GB of data in one go, this is more
563	meant to pass some ID information or other startup info, not big chunks of	775	meant to pass some ID information or other startup info, not big chunks of
564	data.	776	data.
…		…
568	=cut	780	=cut
569		781
570	sub send_arg {	782	sub send_arg {
571	my ($self, @arg) = @_;	783	my ($self, @arg) = @_;
572		784
573	$self->_cmd (a => @arg);	785	$self->_cmd (a => pack "(w/a)", @arg);
574		786
575	$self	787	$self
576	}	788	}
577		789
578	=item $proc->run ($func, $cb->($fh))	790	=item $proc->run ($func, $cb->($fh))
579		791
580	Enter the function specified by the fully qualified name in C<$func> in	792	Enter the function specified by the function name in C<$func> in the
581	the process. The function is called with the communication socket as first	793	process. The function is called with the communication socket as first
582	argument, followed by all file handles and string arguments sent earlier	794	argument, followed by all file handles and string arguments sent earlier
583	via C<send_fh> and C<send_arg> methods, in the order they were called.	795	via C<send_fh> and C<send_arg> methods, in the order they were called.
584		796
585	If the called function returns, the process exits.
586
587	Preparing the process can take time - when the process is ready, the
588	callback is invoked with the local communications socket as argument.
589
590	The process object becomes unusable on return from this function.	797	The process object becomes unusable on return from this function - any
		798	further method calls result in undefined behaviour.
		799
		800	The function name should be fully qualified, but if it isn't, it will be
		801	looked up in the C<main> package.
		802
		803	If the called function returns, doesn't exist, or any error occurs, the
		804	process exits.
		805
		806	Preparing the process is done in the background - when all commands have
		807	been sent, the callback is invoked with the local communications socket
		808	as argument. At this point you can start using the socket in any way you
		809	like.
591		810
592	If the communication socket isn't used, it should be closed on both sides,	811	If the communication socket isn't used, it should be closed on both sides,
593	to save on kernel memory.	812	to save on kernel memory.
594		813
595	The socket is non-blocking in the parent, and blocking in the newly	814	The socket is non-blocking in the parent, and blocking in the newly
596	created process. The close-on-exec flag is set on both. Even if not used	815	created process. The close-on-exec flag is set in both.
		816
597	otherwise, the socket can be a good indicator for the existence of the	817	Even if not used otherwise, the socket can be a good indicator for the
598	process - if the other process exits, you get a readable event on it,	818	existence of the process - if the other process exits, you get a readable
599	because exiting the process closes the socket (if it didn't create any	819	event on it, because exiting the process closes the socket (if it didn't
600	children using fork).	820	create any children using fork).
601		821
602	Example: create a template for a process pool, pass a few strings, some	822	Example: create a template for a process pool, pass a few strings, some
603	file handles, then fork, pass one more string, and run some code.	823	file handles, then fork, pass one more string, and run some code.
604		824
605	my $pool = AnyEvent::Fork	825	my $pool = AnyEvent::Fork
…		…
613	->send_arg ("str3")	833	->send_arg ("str3")
614	->run ("Some::function", sub {	834	->run ("Some::function", sub {
615	my ($fh) = @_;	835	my ($fh) = @_;
616		836
617	# fh is nonblocking, but we trust that the OS can accept these	837	# fh is nonblocking, but we trust that the OS can accept these
618	# extra 3 octets anyway.	838	# few octets anyway.
619	syswrite $fh, "hi #$_\n";	839	syswrite $fh, "hi #$_\n";
620		840
621	# $fh is being closed here, as we don't store it anywhere	841	# $fh is being closed here, as we don't store it anywhere
622	});	842	});
623	}	843	}
…		…
625	# Some::function might look like this - all parameters passed before fork	845	# Some::function might look like this - all parameters passed before fork
626	# and after will be passed, in order, after the communications socket.	846	# and after will be passed, in order, after the communications socket.
627	sub Some::function {	847	sub Some::function {
628	my ($fh, $str1, $str2, $fh1, $fh2, $str3) = @_;	848	my ($fh, $str1, $str2, $fh1, $fh2, $str3) = @_;
629		849
630	print scalar <$fh>; # prints "hi 1\n" and "hi 2\n"	850	print scalar <$fh>; # prints "hi #1\n" and "hi #2\n" in any order
631	}	851	}
632		852
633	=cut	853	=cut
634		854
635	sub run {	855	sub run {
636	my ($self, $func, $cb) = @_;	856	my ($self, $func, $cb) = @_;
637		857
638	$self->[0] = $cb;	858	$self->[CB] = $cb;
639	$self->_cmd (r => $func);	859	$self->_cmd (r => $func);
		860	}
		861
		862	=back
		863
		864	=head2 EXPERIMENTAL METHODS
		865
		866	These methods might go away completely or change behaviour, at any time.
		867
		868	=over 4
		869
		870	=item $proc->to_fh ($cb->($fh)) # EXPERIMENTAL, MIGHT BE REMOVED
		871
		872	Flushes all commands out to the process and then calls the callback with
		873	the communications socket.
		874
		875	The process object becomes unusable on return from this function - any
		876	further method calls result in undefined behaviour.
		877
		878	The point of this method is to give you a file handle thta you cna pass
		879	to another process. In that other process, you can call C<new_from_fh
		880	AnyEvent::Fork> to create a new C<AnyEvent::Fork> object from it, thereby
		881	effectively passing a fork object to another process.
		882
		883	=cut
		884
		885	sub to_fh {
		886	my ($self, $cb) = @_;
		887
		888	$self->[CB] = $cb;
		889
		890	unless ($self->[WW]) {
		891	$self->[CB]->($self->[FH]);
		892	@$self = ();
		893	}
		894	}
		895
		896	=item new_from_fh AnyEvent::Fork $fh # EXPERIMENTAL, MIGHT BE REMOVED
		897
		898	Takes a file handle originally rceeived by the C<to_fh> method and creates
		899	a new C<AnyEvent:Fork> object. The child process itself will not change in
		900	any way, i.e. it will keep all the modifications done to it before calling
		901	C<to_fh>.
		902
		903	The new object is very much like the original object, except that the
		904	C<pid> method will return C<undef> even if the process is a direct child.
		905
		906	=cut
		907
		908	sub new_from_fh {
		909	my ($class, $fh) = @_;
		910
		911	$class->_new ($fh)
640	}	912	}
641		913
642	=back	914	=back
643		915
644	=head1 PERFORMANCE	916	=head1 PERFORMANCE
…		…
654		926
655	2079 new processes per second, using manual socketpair + fork	927	2079 new processes per second, using manual socketpair + fork
656		928
657	Then I did the same thing, but instead of calling fork, I called	929	Then I did the same thing, but instead of calling fork, I called
658	AnyEvent::Fork->new->run ("CORE::exit") and then again waited for the	930	AnyEvent::Fork->new->run ("CORE::exit") and then again waited for the
659	socket form the child to close on exit. This does the same thing as manual	931	socket from the child to close on exit. This does the same thing as manual
660	socket pair + fork, except that what is forked is the template process	932	socket pair + fork, except that what is forked is the template process
661	(2440kB), and the socket needs to be passed to the server at the other end	933	(2440kB), and the socket needs to be passed to the server at the other end
662	of the socket first.	934	of the socket first.
663		935
664	2307 new processes per second, using AnyEvent::Fork->new	936	2307 new processes per second, using AnyEvent::Fork->new
…		…
669	479 vfork+execs per second, using AnyEvent::Fork->new_exec	941	479 vfork+execs per second, using AnyEvent::Fork->new_exec
670		942
671	So how can C<< AnyEvent->new >> be faster than a standard fork, even	943	So how can C<< AnyEvent->new >> be faster than a standard fork, even
672	though it uses the same operations, but adds a lot of overhead?	944	though it uses the same operations, but adds a lot of overhead?
673		945
674	The difference is simply the process size: forking the 6MB process takes	946	The difference is simply the process size: forking the 5MB process takes
675	so much longer than forking the 2.5MB template process that the overhead	947	so much longer than forking the 2.5MB template process that the extra
676	introduced is canceled out.	948	overhead is canceled out.
677		949
678	If the benchmark process grows, the normal fork becomes even slower:	950	If the benchmark process grows, the normal fork becomes even slower:
679		951
680	1340 new processes, manual fork in a 20MB process	952	1340 new processes, manual fork of a 20MB process
681	731 new processes, manual fork in a 200MB process	953	731 new processes, manual fork of a 200MB process
682	235 new processes, manual fork in a 2000MB process	954	235 new processes, manual fork of a 2000MB process
683		955
684	What that means (to me) is that I can use this module without having a	956	What that means (to me) is that I can use this module without having a bad
685	very bad conscience because of the extra overhead required to start new	957	conscience because of the extra overhead required to start new processes.
686	processes.
687		958
688	=head1 TYPICAL PROBLEMS	959	=head1 TYPICAL PROBLEMS
689		960
690	This section lists typical problems that remain. I hope by recognising	961	This section lists typical problems that remain. I hope by recognising
691	them, most can be avoided.	962	them, most can be avoided.
692		963
693	=over 4	964	=over 4
694		965
695	=item exit runs destructors
696
697	=item "leaked" file descriptors for exec'ed processes	966	=item leaked file descriptors for exec'ed processes
698		967
699	POSIX systems inherit file descriptors by default when exec'ing a new	968	POSIX systems inherit file descriptors by default when exec'ing a new
700	process. While perl itself laudably sets the close-on-exec flags on new	969	process. While perl itself laudably sets the close-on-exec flags on new
701	file handles, most C libraries don't care, and even if all cared, it's	970	file handles, most C libraries don't care, and even if all cared, it's
702	often not possible to set the flag in a race-free manner.	971	often not possible to set the flag in a race-free manner.
…		…
722	libraries or the code that leaks those file descriptors.	991	libraries or the code that leaks those file descriptors.
723		992
724	Fortunately, most of these leaked descriptors do no harm, other than	993	Fortunately, most of these leaked descriptors do no harm, other than
725	sitting on some resources.	994	sitting on some resources.
726		995
727	=item "leaked" file descriptors for fork'ed processes	996	=item leaked file descriptors for fork'ed processes
728		997
729	Normally, L<AnyEvent::Fork> does start new processes by exec'ing them,	998	Normally, L<AnyEvent::Fork> does start new processes by exec'ing them,
730	which closes file descriptors not marked for being inherited.	999	which closes file descriptors not marked for being inherited.
731		1000
732	However, L<AnyEvent::Fork::Early> and L<AnyEvent::Fork::Template> offer	1001	However, L<AnyEvent::Fork::Early> and L<AnyEvent::Fork::Template> offer
…		…
740	trouble with a fork.	1009	trouble with a fork.
741		1010
742	The solution is to either not load these modules before use'ing	1011	The solution is to either not load these modules before use'ing
743	L<AnyEvent::Fork::Early> or L<AnyEvent::Fork::Template>, or to delay	1012	L<AnyEvent::Fork::Early> or L<AnyEvent::Fork::Template>, or to delay
744	initialising them, for example, by calling C<init Gtk2> manually.	1013	initialising them, for example, by calling C<init Gtk2> manually.
		1014
		1015	=item exiting calls object destructors
		1016
		1017	This only applies to users of L<AnyEvent::Fork:Early> and
		1018	L<AnyEvent::Fork::Template>, or when initialising code creates objects
		1019	that reference external resources.
		1020
		1021	When a process created by AnyEvent::Fork exits, it might do so by calling
		1022	exit, or simply letting perl reach the end of the program. At which point
		1023	Perl runs all destructors.
		1024
		1025	Not all destructors are fork-safe - for example, an object that represents
		1026	the connection to an X display might tell the X server to free resources,
		1027	which is inconvenient when the "real" object in the parent still needs to
		1028	use them.
		1029
		1030	This is obviously not a problem for L<AnyEvent::Fork::Early>, as you used
		1031	it as the very first thing, right?
		1032
		1033	It is a problem for L<AnyEvent::Fork::Template> though - and the solution
		1034	is to not create objects with nontrivial destructors that might have an
		1035	effect outside of Perl.
745		1036
746	=back	1037	=back
747		1038
748	=head1 PORTABILITY NOTES	1039	=head1 PORTABILITY NOTES
749		1040
…		…
752	to make it so, mostly due to the bloody broken perl that nobody seems to	1043	to make it so, mostly due to the bloody broken perl that nobody seems to
753	care about. The fork emulation is a bad joke - I have yet to see something	1044	care about. The fork emulation is a bad joke - I have yet to see something
754	useful that you can do with it without running into memory corruption	1045	useful that you can do with it without running into memory corruption
755	issues or other braindamage. Hrrrr.	1046	issues or other braindamage. Hrrrr.
756		1047
757	Cygwin perl is not supported at the moment, as it should implement fd	1048	Since fork is endlessly broken on win32 perls (it doesn't even remotely
758	passing, but doesn't, and rolling my own is hard, as cygwin doesn't	1049	work within it's documented limits) and quite obviously it's not getting
759	support enough functionality to do it.	1050	improved any time soon, the best way to proceed on windows would be to
		1051	always use C<new_exec> and thus never rely on perl's fork "emulation".
		1052
		1053	Cygwin perl is not supported at the moment due to some hilarious
		1054	shortcomings of its API - see L<IO::FDPoll> for more details. If you never
		1055	use C<send_fh> and always use C<new_exec> to create processes, it should
		1056	work though.
760		1057
761	=head1 SEE ALSO	1058	=head1 SEE ALSO
762		1059
763	L<AnyEvent::Fork::Early> (to avoid executing a perl interpreter),	1060	L<AnyEvent::Fork::Early>, to avoid executing a perl interpreter at all
		1061	(part of this distribution).
		1062
764	L<AnyEvent::Fork::Template> (to create a process by forking the main	1063	L<AnyEvent::Fork::Template>, to create a process by forking the main
765	program at a convenient time).	1064	program at a convenient time (part of this distribution).
766		1065
767	=head1 AUTHOR	1066	L<AnyEvent::Fork::Remote>, for another way to create processes that is
		1067	mostly compatible to this module and modules building on top of it, but
		1068	works better with remote processes.
		1069
		1070	L<AnyEvent::Fork::RPC>, for simple RPC to child processes (on CPAN).
		1071
		1072	L<AnyEvent::Fork::Pool>, for simple worker process pool (on CPAN).
		1073
		1074	=head1 AUTHOR AND CONTACT INFORMATION
768		1075
769	Marc Lehmann <schmorp@schmorp.de>	1076	Marc Lehmann <schmorp@schmorp.de>
770	http://home.schmorp.de/	1077	http://software.schmorp.de/pkg/AnyEvent-Fork
771		1078
772	=cut	1079	=cut
773		1080
774	1	1081	1
775		1082

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing AnyEvent-Fork/Fork.pm (file contents): Revision 1.18 by root, Sat Apr 6 01:33:56 2013 UTC vs. Revision 1.57 by root, Sun Aug 25 17:38:43 2013 UTC

Diff Legend

Comparing AnyEvent-Fork/Fork.pm (file contents):
Revision 1.18 by root, Sat Apr 6 01:33:56 2013 UTC vs.
Revision 1.57 by root, Sun Aug 25 17:38:43 2013 UTC