--- AnyEvent-HTTP/HTTP.pm 2008/07/02 01:23:41 1.23 +++ AnyEvent-HTTP/HTTP.pm 2008/09/29 13:50:39 1.28 @@ -50,7 +50,7 @@ use base Exporter::; -our $VERSION = '1.03'; +our $VERSION = '1.05'; our @EXPORT = qw(http_get http_post http_head http_request); @@ -82,7 +82,7 @@ =item http_post $url, $body, key => value..., $cb->($data, $headers) -Executes an HTTP-POST request with a request body of C<$bod>. See the +Executes an HTTP-POST request with a request body of C<$body>. See the http_request function for details on additional parameters. =item http_request $method => $url, key => value..., $cb->($data, $headers) @@ -357,7 +357,7 @@ # status line $state{handle}->push_read (line => qr/\015?\012/, sub { - $_[1] =~ /^HTTP\/([0-9\.]+) \s+ ([0-9]{3}) \s+ ([^\015\012]+)/ix + $_[1] =~ /^HTTP\/([0-9\.]+) \s+ ([0-9]{3}) (?: \s+ ([^\015\012]*) )?/ix or return (%state = (), $cb->(undef, { Status => 599, Reason => "invalid server response ($_[1])", URL => $url })); my %hdr = ( # response headers @@ -400,7 +400,7 @@ my $cdom = (delete $kv{domain}) || $uhost; my $cpath = (delete $kv{path}) || "/"; - $cdom =~ s/^.?/./; # make sure it starts with a "." + $cdom =~ s/^\.?/./; # make sure it starts with a "." next if $cdom =~ /\.$/; @@ -414,19 +414,31 @@ } } - if ($_[1]{Status} =~ /^30[12]$/ && $recurse && $method ne "POST") { - # microsoft and other assholes don't give a shit for following standards, - # try to support a common form of broken Location header. - $_[1]{location} =~ s%^/%$scheme://$uhost:$uport/%; + # microsoft and other shitheads don't give a shit for following standards, + # try to support some common forms of broken Location headers. + if ($_[1]{location} !~ /^(?: $ | [^:\/?\#]+ : )/x) { + $_[1]{location} =~ s/^\.\/+//; + + my $url = "$scheme://$uhost:$uport"; + + unless ($_[1]{location} =~ s/^\///) { + $url .= $upath; + $url =~ s/\/[^\/]*$//; + } + + $_[1]{location} = "$url/$_[1]{location}"; + } + if ($_[1]{Status} =~ /^30[12]$/ && $recurse && $method ne "POST") { # apparently, mozilla et al. just change POST to GET here # more research is needed before we do the same - http_request ($method, $_[1]{location}, %arg, recurse => $recurse - 1, $cb); } elsif ($_[1]{Status} == 303 && $recurse) { - $_[1]{location} =~ s%^/%$scheme://$uhost:$uport/%; - - http_request (GET => $_[1]{location}, %arg, recurse => $recurse - 1, $cb); + # even http/1.1 is unlear on how to mutate the method + $method = "GET" unless $method eq "HEAD"; + http_request ($method => $_[1]{location}, %arg, recurse => $recurse - 1, $cb); + } elsif ($_[1]{Status} == 307 && $recurse && $method =~ /^(?:GET|HEAD)$/) { + http_request ($method => $_[1]{location}, %arg, recurse => $recurse - 1, $cb); } else { $cb->($_[0], $_[1]); }