[ViewVC] Diff of: cvs/AnyEvent/lib/AnyEvent.pm

Comparing AnyEvent/lib/AnyEvent.pm (file contents):
Revision 1.195 by root, Wed Mar 25 17:33:11 2009 UTC vs.
Revision 1.204 by root, Thu Apr 16 08:15:25 2009 UTC

 These watchers are normal Perl objects with normal Perl lifetime. After
 creating a watcher it will immediately "watch" for events and invoke the
 callback when the event occurs (of course, only when the event model
 is in control).
+Note that B<callbacks must not permanently change global variables>
+potentially in use by the event loop (such as C<$_> or C<$[>) and that B<<
+callbacks must not C<die> >>. The former is good programming practise in
+Perl and the latter stems from the fact that exception handling differs
+widely between event loops.
 To disable the watcher you have to destroy it (e.g. by setting the
 variable you store it in to C<undef> or otherwise deleting all references
 to it).
 All watchers are created by calling a method on the C<AnyEvent> class.
 =head2 I/O WATCHERS
 You can create an I/O watcher by calling the C<< AnyEvent->io >> method
 with the following mandatory key-value pairs as arguments:
-C<fh> the Perl I<file handle> (I<not> file descriptor) to watch for events
+C<fh> is the Perl I<file handle> (I<not> file descriptor) to watch
-(AnyEvent might or might not keep a reference to this file handle). C<poll>
+for events (AnyEvent might or might not keep a reference to this file
+handle). Note that only file handles pointing to things for which
+non-blocking operation makes sense are allowed. This includes sockets,
+most character devices, pipes, fifos and so on, but not for example files
+or block devices.
-must be a string that is either C<r> or C<w>, which creates a watcher
+C<poll> must be a string that is either C<r> or C<w>, which creates a
-waiting for "r"eadable or "w"ritable events, respectively. C<cb> is the
+watcher waiting for "r"eadable or "w"ritable events, respectively.
-callback to invoke each time the file handle becomes ready.
+C<cb> is the callback to invoke each time the file handle becomes ready.
 Although the callback might get passed parameters, their value and
 presence is undefined and you cannot rely on them. Portable AnyEvent
 callbacks cannot use arguments passed to I/O watcher callbacks.
 no warnings;
 use strict qw(vars subs);
 use Carp;
-our $VERSION = 4.341;
+our $VERSION = 4.351;
 our $MODEL;
 our $AUTOLOAD;
 our @ISA;
                   last;
                }
             }
             $MODEL
-              or die "No event module selected for AnyEvent and autodetect failed. Install any one of these modules: EV, Event or Glib.";
+              or die "No event module selected for AnyEvent and autodetect failed. Install any one of these modules: EV, Event or Glib.\n";
          }
       }
       push @{"$MODEL\::ISA"}, "AnyEvent::Base";
    my ($rw, $mode) = $poll eq "r" ? ($r, "<")
                    : $poll eq "w" ? ($w, ">")
                    : Carp::croak "AnyEvent->io requires poll set to either 'r' or 'w'";
    open my $fh2, "$mode&" . fileno $fh
-      or die "cannot dup() filehandle: $!";
+      or die "cannot dup() filehandle: $!,";
    # we assume CLOEXEC is already set by perl in all important cases
    ($fh2, $rw)
 }
 # default implementation for ->signal
 our ($SIGPIPE_R, $SIGPIPE_W, %SIG_CB, %SIG_EV, $SIG_IO);
 sub _signal_exec {
+   sysread $SIGPIPE_R, my $dummy, 4;
    while (%SIG_EV) {
-      sysread $SIGPIPE_R, my $dummy, 4;
       for (keys %SIG_EV) {
          delete $SIG_EV{$_};
          $_->() for values %{ $SIG_CB{$_} || {} };
       }
    }
 sub signal {
    my (undef, %arg) = @_;
    unless ($SIGPIPE_R) {
+      require Fcntl;
       if (AnyEvent::WIN32) {
+         require AnyEvent::Util;
          ($SIGPIPE_R, $SIGPIPE_W) = AnyEvent::Util::portable_pipe ();
          AnyEvent::Util::fh_nonblocking ($SIGPIPE_R) if $SIGPIPE_R;
          AnyEvent::Util::fh_nonblocking ($SIGPIPE_W) if $SIGPIPE_W; # just in case
       } else {
          pipe $SIGPIPE_R, $SIGPIPE_W;
-         require Fcntl;
          fcntl $SIGPIPE_R, &Fcntl::F_SETFL, &Fcntl::O_NONBLOCK if $SIGPIPE_R;
          fcntl $SIGPIPE_W, &Fcntl::F_SETFL, &Fcntl::O_NONBLOCK if $SIGPIPE_W; # just in case
       }
       $SIGPIPE_R
          or Carp::croak "AnyEvent: unable to create a signal reporting pipe: $!\n";
+      # not strictly required, as $^F is normally 2, but let's make sure...
+      fcntl $SIGPIPE_R, &Fcntl::F_SETFD, &Fcntl::FD_CLOEXEC;
+      fcntl $SIGPIPE_W, &Fcntl::F_SETFD, &Fcntl::FD_CLOEXEC;
       $SIG_IO = AnyEvent->io (fh => $SIGPIPE_R, poll => "r", cb => \&_signal_exec);
    }
    my $signal = uc $arg{signal}
       or Carp::croak "required option 'signal' is missing";
    $SIG_CB{$signal}{$arg{cb}} = $arg{cb};
    $SIG{$signal} ||= sub {
+      local $!;
       syswrite $SIGPIPE_W, "\x00", 1 unless %SIG_EV;
       undef $SIG_EV{$signal};
    };
    bless [$signal, $arg{cb}], "AnyEvent::Base::Signal"
 =head1 BUGS
 Perl 5.8 has numerous memleaks that sometimes hit this module and are hard
 to work around. If you suffer from memleaks, first upgrade to Perl 5.10
 and check wether the leaks still show up. (Perl 5.10.0 has other annoying
-mamleaks, such as leaking on C<map> and C<grep> but it is usually not as
+memleaks, such as leaking on C<map> and C<grep> but it is usually not as
 pronounced).
 =head1 SEE ALSO

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing AnyEvent/lib/AnyEvent.pm (file contents): Revision 1.195 by root, Wed Mar 25 17:33:11 2009 UTC vs. Revision 1.204 by root, Thu Apr 16 08:15:25 2009 UTC

Diff Legend

Comparing AnyEvent/lib/AnyEvent.pm (file contents):
Revision 1.195 by root, Wed Mar 25 17:33:11 2009 UTC vs.
Revision 1.204 by root, Thu Apr 16 08:15:25 2009 UTC