[ViewVC] Diff of: cvs/AnyEvent/lib/AnyEvent/Handle.pm

Comparing AnyEvent/lib/AnyEvent/Handle.pm (file contents):
Revision 1.223 by root, Thu Sep 1 04:07:18 2011 UTC vs.
Revision 1.231 by root, Tue Mar 27 23:47:57 2012 UTC

    my $hdl; $hdl = new AnyEvent::Handle
       fh => \*STDIN,
       on_error => sub {
          my ($hdl, $fatal, $msg) = @_;
-         AE::log warn => "got error $msg\n";
+         AE::log error => "Got error $msg!";
          $hdl->destroy;
          $cv->send;
       };
    # send some request line
    $hdl->push_write ("getinfo\015\012");
    # read the response line
    $hdl->push_read (line => sub {
       my ($hdl, $line) = @_;
-      AE::log warn => "got line <$line>\n";
+      say "got line <$line>";
       $cv->send;
    });
    $cv->recv;
 =item on_connect => $cb->($handle, $host, $port, $retry->())
 This callback is called when a connection has been successfully established.
 The peer's numeric host and port (the socket peername) are passed as
-parameters, together with a retry callback.
+parameters, together with a retry callback. At the time it is called the
+read and write queues, EOF status, TLS status and similar properties of
+the handle will have been reset.
+It is not allowed to use the read or write queues while the handle object
+is connecting.
-If, for some reason, the handle is not acceptable, calling C<$retry>
+If, for some reason, the handle is not acceptable, calling C<$retry> will
-will continue with the next connection target (in case of multi-homed
+continue with the next connection target (in case of multi-homed hosts or
-hosts or SRV records there can be multiple connection endpoints). At the
+SRV records there can be multiple connection endpoints). The C<$retry>
-time it is called the read and write queues, eof status, tls status and
+callback can be invoked after the connect callback returns, i.e. one can
-similar properties of the handle will have been reset.
+start a handshake and then decide to retry with the next host if the
+handshake fails.
 In most cases, you should ignore the C<$retry> parameter.
 =item on_connect_error => $cb->($handle, $message)
 If an EOF condition has been detected but no C<on_eof> callback has been
 set, then a fatal error will be raised with C<$!> set to <0>.
 =item on_drain => $cb->($handle)
-This sets the callback that is called when the write buffer becomes empty
+This sets the callback that is called once when the write buffer becomes
-(or immediately if the buffer is empty already).
+empty (and immediately when the handle object is created).
 To append to the write buffer, use the C<< ->push_write >> method.
 This callback is useful when you don't want to put all of your write data
 into the queue at once, for example, when you want to write the contents
 The write queue is very simple: you can add data to its end, and
 AnyEvent::Handle will automatically try to get rid of it for you.
 When data could be written and the write buffer is shorter then the low
-water mark, the C<on_drain> callback will be invoked.
+water mark, the C<on_drain> callback will be invoked once.
 =over 4
 =item $handle->on_drain ($cb)
 =cut
 register_write_type storable => sub {
    my ($self, $ref) = @_;
-   require Storable;
+   require Storable unless $Storable::VERSION;
    pack "w/a*", Storable::nfreeze ($ref)
 };
 =back
 data.
 Example: read 2 bytes.
    $handle->push_read (chunk => 2, sub {
-      AE::log debug => "yay " . unpack "H*", $_[1];
+      say "yay " . unpack "H*", $_[1];
    });
 =cut
 register_read_type chunk => sub {
    if (@_ < 3) {
       # this is more than twice as fast as the generic code below
       sub {
          $_[0]{rbuf} =~ s/^([^\015\012]*)(\015?\012)// or return;
-         $cb->($_[0], $1, $2);
+         $cb->($_[0], "$1", "$2");
          1
       }
    } else {
       $eol = quotemeta $eol unless ref $eol;
       $eol = qr|^(.*?)($eol)|s;
       sub {
          $_[0]{rbuf} =~ s/$eol// or return;
-         $cb->($_[0], $1, $2);
+         $cb->($_[0], "$1", "$2");
          1
       }
    }
 };
 =cut
 register_read_type storable => sub {
    my ($self, $cb) = @_;
-   require Storable;
+   require Storable unless $Storable::VERSION;
    sub {
       # when we can use 5.10 we can use ".", but for 5.8 we use the re-pack method
       defined (my $len = eval { unpack "w", $_[0]{rbuf} })
          or return;
 some readings of the the SSL/TLS specifications basically require this
 attack to be working, as SSL/TLS implementations might stall sending data
 during a rehandshake.
 As a guideline, during the initial handshake, you should not stop reading,
-and as a client, it might cause problems, depending on your applciation.
+and as a client, it might cause problems, depending on your application.
 =cut
 sub stop_read {
    my ($self) = @_;
 C<low_water_mark> this will be called precisely when all data has been
 written to the socket:
    $handle->push_write (...);
    $handle->on_drain (sub {
-      AE::log debug => "all data submitted to the kernel\n";
+      AE::log debug => "All data submitted to the kernel.";
       undef $handle;
    });
 If you just want to queue some data and then signal EOF to the other side,
 consider using C<< ->push_shutdown >> instead.
 When you have intermediate CA certificates that your clients might not
 know about, just append them to the C<cert_file>.
 =back
 =head1 SUBCLASSING AnyEvent::Handle
 In many cases, you might want to subclass AnyEvent::Handle.
 To make this easier, a given version of AnyEvent::Handle uses these
 Robin Redeker C<< <elmex at ta-sa.org> >>, Marc Lehmann <schmorp@schmorp.de>.
 =cut
-1; # End of AnyEvent::Handle
+1

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing AnyEvent/lib/AnyEvent/Handle.pm (file contents): Revision 1.223 by root, Thu Sep 1 04:07:18 2011 UTC vs. Revision 1.231 by root, Tue Mar 27 23:47:57 2012 UTC

Diff Legend

Comparing AnyEvent/lib/AnyEvent/Handle.pm (file contents):
Revision 1.223 by root, Thu Sep 1 04:07:18 2011 UTC vs.
Revision 1.231 by root, Tue Mar 27 23:47:57 2012 UTC