ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/AnyEvent/lib/AnyEvent/Strict.pm
(Generate patch)

Comparing AnyEvent/lib/AnyEvent/Strict.pm (file contents):
Revision 1.12 by root, Thu Apr 23 22:44:30 2009 UTC vs.
Revision 1.35 by root, Fri Sep 2 04:35:03 2011 UTC

… …
11 11
12This module implements AnyEvent's strict mode. 12This module implements AnyEvent's strict mode.
13 13
14Loading it makes AnyEvent check all arguments to AnyEvent-methods, at the 14Loading it makes AnyEvent check all arguments to AnyEvent-methods, at the
15expense of being slower (often the argument checking takes longer than the 15expense of being slower (often the argument checking takes longer than the
16actual function). 16actual function). It also wraps all callbacks to check for modifications
17of C<$_>, which indicates a programming bug inside the watcher callback.
17 18
18Normally, you don't load this module yourself but instead use it 19Normally, you don't load this module yourself but instead use it
19indirectly via the C<PERL_ANYEVENT_STRICT> environment variable (see 20indirectly via the C<PERL_ANYEVENT_STRICT> environment variable (see
20L<AnyEvent>). However, this module can be loaded at any time. 21L<AnyEvent>). However, this module can be loaded manually at any time.
21 22
22=cut 23=cut
23 24
24package AnyEvent::Strict; 25package AnyEvent::Strict;
25 26
26no warnings; # *sigh*
27
28use Carp qw(croak); 27use Carp qw(croak);
28use Errno ();
29use POSIX ();
29 30
30use AnyEvent (); 31use AnyEvent (); BEGIN { AnyEvent::common_sense }
31 32
32AnyEvent::post_detect { 33AnyEvent::_isa_hook 1 => "AnyEvent::Strict", 1;
33 # assume the first ISA member is the implementation 34
34 # # and link us in before it in the chain. 35BEGIN {
35 my $MODEL = shift @AnyEvent::ISA; 36 if (defined &Internals::SvREADONLY) {
36 unshift @ISA, $MODEL; 37 # readonly available (at least 5.8.9+, working better in 5.10.1+)
37 unshift @AnyEvent::ISA, AnyEvent::Strict:: 38 *wrap = sub {
39 my $cb = shift;
40
41 sub {
42 Internals::SvREADONLY $_, 1;
43 &$cb;
44 Internals::SvREADONLY $_, 0;
45 }
46 };
47 } else {
48 # or not :/
49 my $magic = []; # a unique magic value
50
51 *wrap = sub {
52 my $cb = shift;
53
54 sub {
55 local $_ = $magic;
56
57 &$cb;
58
59 if (!ref $_ || $_ != $magic) {
60 require AnyEvent::Debug;
61 die "callback $cb (" . AnyEvent::Debug::cb2str ($cb) . ") modified \$_ without restoring it.\n";
62 }
63 }
64 };
65 }
66}
67
68our (@FD_INUSE, $FD_I);
69our $FD_CHECK_W = AE::timer 4, 4, sub {
70 my $cnt = (@FD_INUSE < 100 * 10 ? int @FD_INUSE * 0.1 : 100) || 10;
71
72 if ($FD_I <= 0) {
73 #pop @FD_INUSE while @FD_INUSE && !$FD_INUSE[-1];
74 ($FD_I = @FD_INUSE) >= 0
75 or return; # empty
76 }
77
78 $cnt = $FD_I if $cnt > $FD_I;
79
80 eval {
81 do {
82 !$FD_INUSE[--$FD_I]
83 or (POSIX::lseek $FD_I, 0, 1) != -1
84 or $! != Errno::EBADF
85 or die;
86 } while --$cnt;
87 1
88 } or AE::log crit => "file descriptor $FD_I registered with AnyEvent but prematurely closed, event loop might malfunction.\n";
38}; 89};
39 90
40sub io { 91sub io {
41 my $class = shift; 92 my $class = shift;
42 my %arg = @_; 93 my (%arg, $fh, $cb, $fd) = @_;
43 94
44 ref $arg{cb} 95 ref $arg{cb}
45 or croak "AnyEvent->io called with illegal cb argument '$arg{cb}'"; 96 or croak "AnyEvent->io called with illegal cb argument '$arg{cb}'";
46 delete $arg{cb}; 97 $cb = wrap delete $arg{cb};
47
48 defined fileno $arg{fh}
49 or croak "AnyEvent->io called with illegal fh argument '$arg{fh}'";
50 -f $arg{fh}
51 and croak "AnyEvent->io called with fh argument pointing to a file";
52 delete $arg{fh};
53 98
54 $arg{poll} =~ /^[rw]$/ 99 $arg{poll} =~ /^[rw]$/
55 or croak "AnyEvent->io called with illegal poll argument '$arg{poll}'"; 100 or croak "AnyEvent->io called with illegal poll argument '$arg{poll}'";
101
102 $fh = delete $arg{fh};
103
104 if ($fh =~ /^\s*\d+\s*$/) {
105 $fd = $fh;
106 $fh = AnyEvent::_dupfh $arg{poll}, $fh;
107 } else {
108 defined eval { $fd = fileno $fh }
109 or croak "AnyEvent->io called with illegal fh argument '$fh'";
110 }
111
112 -f $fh
113 and croak "AnyEvent->io called with fh argument pointing to a file";
114
56 delete $arg{poll}; 115 delete $arg{poll};
57 116
58 croak "AnyEvent->io called with unsupported parameter(s) " . join ", ", keys %arg 117 croak "AnyEvent->io called with unsupported parameter(s) " . join ", ", keys %arg
59 if keys %arg; 118 if keys %arg;
60 119
120 ++$FD_INUSE[$fd];
121
122 bless [
123 $fd,
61 $class->SUPER::io (@_) 124 $class->SUPER::io (@_, cb => $cb)
125 ], "AnyEvent::Strict::io";
126}
127
128sub AnyEvent::Strict::io::DESTROY {
129 --$FD_INUSE[$_[0][0]];
62} 130}
63 131
64sub timer { 132sub timer {
65 my $class = shift; 133 my $class = shift;
66 my %arg = @_; 134 my %arg = @_;
67 135
68 ref $arg{cb} 136 ref $arg{cb}
69 or croak "AnyEvent->timer called with illegal cb argument '$arg{cb}'"; 137 or croak "AnyEvent->timer called with illegal cb argument '$arg{cb}'";
70 delete $arg{cb}; 138 my $cb = wrap delete $arg{cb};
71 139
72 exists $arg{after} 140 exists $arg{after}
73 or croak "AnyEvent->timer called without mandatory 'after' parameter"; 141 or croak "AnyEvent->timer called without mandatory 'after' parameter";
74 delete $arg{after}; 142 delete $arg{after};
75 143
… …
78 delete $arg{interval}; 146 delete $arg{interval};
79 147
80 croak "AnyEvent->timer called with unsupported parameter(s) " . join ", ", keys %arg 148 croak "AnyEvent->timer called with unsupported parameter(s) " . join ", ", keys %arg
81 if keys %arg; 149 if keys %arg;
82 150
83 $class->SUPER::timer (@_) 151 $class->SUPER::timer (@_, cb => $cb)
84} 152}
85 153
86sub signal { 154sub signal {
87 my $class = shift; 155 my $class = shift;
88 my %arg = @_; 156 my %arg = @_;
89 157
90 ref $arg{cb} 158 ref $arg{cb}
91 or croak "AnyEvent->signal called with illegal cb argument '$arg{cb}'"; 159 or croak "AnyEvent->signal called with illegal cb argument '$arg{cb}'";
92 delete $arg{cb}; 160 my $cb = wrap delete $arg{cb};
93 161
94 eval "require POSIX; 0 < &POSIX::SIG$arg{signal}" 162 defined AnyEvent::Base::sig2num $arg{signal} and $arg{signal} == 0
95 or croak "AnyEvent->signal called with illegal signal name '$arg{signal}'"; 163 or croak "AnyEvent->signal called with illegal signal name '$arg{signal}'";
96 delete $arg{signal}; 164 delete $arg{signal};
97 165
98 croak "AnyEvent->signal called with unsupported parameter(s) " . join ", ", keys %arg 166 croak "AnyEvent->signal called with unsupported parameter(s) " . join ", ", keys %arg
99 if keys %arg; 167 if keys %arg;
100 168
101 $class->SUPER::signal (@_) 169 $class->SUPER::signal (@_, cb => $cb)
102} 170}
103 171
104sub child { 172sub child {
105 my $class = shift; 173 my $class = shift;
106 my %arg = @_; 174 my %arg = @_;
107 175
108 ref $arg{cb} 176 ref $arg{cb}
109 or croak "AnyEvent->child called with illegal cb argument '$arg{cb}'"; 177 or croak "AnyEvent->child called with illegal cb argument '$arg{cb}'";
110 delete $arg{cb}; 178 my $cb = wrap delete $arg{cb};
111 179
112 $arg{pid} =~ /^-?\d+$/ 180 $arg{pid} =~ /^-?\d+$/
113 or croak "AnyEvent->child called with malformed pid value '$arg{pid}'"; 181 or croak "AnyEvent->child called with malformed pid value '$arg{pid}'";
114 delete $arg{pid}; 182 delete $arg{pid};
115 183
116 croak "AnyEvent->child called with unsupported parameter(s) " . join ", ", keys %arg 184 croak "AnyEvent->child called with unsupported parameter(s) " . join ", ", keys %arg
117 if keys %arg; 185 if keys %arg;
118 186
119 $class->SUPER::child (@_) 187 $class->SUPER::child (@_, cb => $cb)
120} 188}
121 189
122sub idle { 190sub idle {
123 my $class = shift; 191 my $class = shift;
124 my %arg = @_; 192 my %arg = @_;
125 193
126 ref $arg{cb} 194 ref $arg{cb}
127 or croak "AnyEvent->idle called with illegal cb argument '$arg{cb}'"; 195 or croak "AnyEvent->idle called with illegal cb argument '$arg{cb}'";
128 delete $arg{cb}; 196 my $cb = wrap delete $arg{cb};
129 197
130 croak "AnyEvent->idle called with unsupported parameter(s) " . join ", ", keys %arg 198 croak "AnyEvent->idle called with unsupported parameter(s) " . join ", ", keys %arg
131 if keys %arg; 199 if keys %arg;
132 200
133 $class->SUPER::idle (@_) 201 $class->SUPER::idle (@_, cb => $cb)
134} 202}
135 203
136sub condvar { 204sub condvar {
137 my $class = shift; 205 my $class = shift;
138 my %arg = @_; 206 my %arg = @_;
139 207
140 !exists $arg{cb} or ref $arg{cb} 208 !exists $arg{cb} or ref $arg{cb}
141 or croak "AnyEvent->condvar called with illegal cb argument '$arg{cb}'"; 209 or croak "AnyEvent->condvar called with illegal cb argument '$arg{cb}'";
142 delete $arg{cb}; 210 my @cb = exists $arg{cb} ? (cb => wrap delete $arg{cb}) : ();
143 211
144 croak "AnyEvent->condvar called with unsupported parameter(s) " . join ", ", keys %arg 212 croak "AnyEvent->condvar called with unsupported parameter(s) " . join ", ", keys %arg
145 if keys %arg; 213 if keys %arg;
146 214
147 $class->SUPER::condvar (@_) 215 $class->SUPER::condvar (@cb);
148} 216}
149 217
150sub time { 218sub time {
151 my $class = shift; 219 my $class = shift;
152 220

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines