ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/CBOR-XS/XS.xs
(Generate patch)

Comparing CBOR-XS/XS.xs (file contents):
Revision 1.50 by root, Thu Feb 25 02:29:22 2016 UTC vs.
Revision 1.66 by root, Sun Nov 29 21:32:01 2020 UTC

… …
6#include <string.h> 6#include <string.h>
7#include <stdlib.h> 7#include <stdlib.h>
8#include <stdio.h> 8#include <stdio.h>
9#include <limits.h> 9#include <limits.h>
10#include <float.h> 10#include <float.h>
11#include <inttypes.h>
11 12
12#define ECB_NO_THREADS 1 13#define ECB_NO_THREADS 1
13#include "ecb.h" 14#include "ecb.h"
14 15
15// compatibility with perl <5.18 16// compatibility with perl <5.18
… …
20# define HvNAMELEN(hv) HvNAMELEN_get (hv) 21# define HvNAMELEN(hv) HvNAMELEN_get (hv)
21#endif 22#endif
22#ifndef HvNAMEUTF8 23#ifndef HvNAMEUTF8
23# define HvNAMEUTF8(hv) 0 24# define HvNAMEUTF8(hv) 0
24#endif 25#endif
26#ifndef SvREFCNT_inc_NN
27# define SvREFCNT_inc_NN(sv) SvREFCNT_inc (sv)
28#endif
25#ifndef SvREFCNT_dec_NN 29#ifndef SvREFCNT_dec_NN
26# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv) 30# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv)
27#endif 31#endif
28 32
29// known major and minor types 33// known major and minor types
… …
95 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8 99 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8
96 100
97 CBOR_TAG_MAGIC = 55799, // self-describe cbor 101 CBOR_TAG_MAGIC = 55799, // self-describe cbor
98}; 102};
99 103
104// known forced types, also hardcoded in CBOR.pm
105enum
106{
107 AS_CBOR = 0,
108 AS_BYTES = 1,
109 AS_TEXT = 2,
110 AS_FLOAT16 = 3,
111 AS_FLOAT32 = 4,
112 AS_FLOAT64 = 5,
113 // possibly future enhancements: float, integer
114};
115
100#define F_SHRINK 0x00000001UL 116#define F_SHRINK 0x00000001UL
101#define F_ALLOW_UNKNOWN 0x00000002UL 117#define F_ALLOW_UNKNOWN 0x00000002UL
102#define F_ALLOW_SHARING 0x00000004UL 118#define F_ALLOW_SHARING 0x00000004UL
103#define F_ALLOW_CYCLES 0x00000008UL 119#define F_ALLOW_CYCLES 0x00000008UL
120#define F_FORBID_OBJECTS 0x00000010UL
104#define F_PACK_STRINGS 0x00000010UL 121#define F_PACK_STRINGS 0x00000020UL
122#define F_TEXT_KEYS 0x00000040UL
123#define F_TEXT_STRINGS 0x00000080UL
105#define F_VALIDATE_UTF8 0x00000020UL 124#define F_VALIDATE_UTF8 0x00000100UL
106 125
107#define INIT_SIZE 32 // initial scalar size to be allocated 126#define INIT_SIZE 32 // initial scalar size to be allocated
108 127
109#define SB do { 128#define SB do {
110#define SE } while (0) 129#define SE } while (0)
… …
183 202
184// minimum length of a string to be registered for stringref 203// minimum length of a string to be registered for stringref
185ecb_inline int 204ecb_inline int
186minimum_string_length (UV idx) 205minimum_string_length (UV idx)
187{ 206{
188 return idx > 23 207 return idx <= 23 ? 3
189 ? idx > 0xffU 208 : idx <= 0xffU ? 4
190 ? idx > 0xffffU 209 : idx <= 0xffffU ? 5
191 ? idx > 0xffffffffU 210 : idx <= 0xffffffffU ? 7
192 ? 11 211 : 11;
193 : 7
194 : 5
195 : 4
196 : 3;
197} 212}
198 213
199///////////////////////////////////////////////////////////////////////////// 214/////////////////////////////////////////////////////////////////////////////
200// encoder 215// encoder
201 216
… …
214} enc_t; 229} enc_t;
215 230
216ecb_inline void 231ecb_inline void
217need (enc_t *enc, STRLEN len) 232need (enc_t *enc, STRLEN len)
218{ 233{
219 if (ecb_expect_false (enc->cur + len >= enc->end)) 234 if (ecb_expect_false ((uintptr_t)(enc->end - enc->cur) < len))
220 { 235 {
221 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv); 236 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv);
222 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1); 237 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1);
223 enc->cur = SvPVX (enc->sv) + cur; 238 enc->cur = SvPVX (enc->sv) + cur;
224 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1; 239 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1;
… …
230{ 245{
231 need (enc, 1); 246 need (enc, 1);
232 *enc->cur++ = ch; 247 *enc->cur++ = ch;
233} 248}
234 249
250// used for tags, intregers, element counts and so on
235static void 251static void
236encode_uint (enc_t *enc, int major, UV len) 252encode_uint (enc_t *enc, int major, UV len)
237{ 253{
238 need (enc, 9); 254 need (enc, 9);
239 255
… …
270 *enc->cur++ = len >> 8; 286 *enc->cur++ = len >> 8;
271 *enc->cur++ = len; 287 *enc->cur++ = len;
272 } 288 }
273} 289}
274 290
291// encodes a perl value into a CBOR integer
292ecb_inline
293encode_int (enc_t *enc, SV *sv)
294{
295 if (SvIsUV (sv))
296 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
297 else if (SvIVX (sv) >= 0)
298 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
299 else
300 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
301}
302
275ecb_inline void 303ecb_inline void
276encode_tag (enc_t *enc, UV tag) 304encode_tag (enc_t *enc, UV tag)
277{ 305{
278 encode_uint (enc, MAJOR_TAG, tag); 306 encode_uint (enc, MAJOR_TAG, tag);
279} 307}
280 308
309// exceptional (hopefully) slow path for byte strings that need to be utf8-encoded
310ecb_noinline static void
311encode_str_utf8 (enc_t *enc, int utf8, char *str, STRLEN len)
312{
313 STRLEN ulen = len;
314 U8 *p, *pend = (U8 *)str + len;
315
316 for (p = (U8 *)str; p < pend; ++p)
317 ulen += *p >> 7; // count set high bits
318
319 encode_uint (enc, MAJOR_TEXT, ulen);
320
321 need (enc, ulen);
322 for (p = (U8 *)str; p < pend; ++p)
323 if (*p < 0x80)
324 *enc->cur++ = *p;
325 else
326 {
327 *enc->cur++ = 0xc0 + (*p >> 6);
328 *enc->cur++ = 0x80 + (*p & 63);
329 }
330}
331
281ecb_inline void 332ecb_inline void
282encode_str (enc_t *enc, int utf8, char *str, STRLEN len) 333encode_str (enc_t *enc, int upgrade_utf8, int utf8, char *str, STRLEN len)
283{ 334{
335 if (ecb_expect_false (upgrade_utf8))
336 if (!utf8)
337 {
338 encode_str_utf8 (enc, utf8, str, len);
339 return;
340 }
341
284 encode_uint (enc, utf8 ? MAJOR_TEXT : MAJOR_BYTES, len); 342 encode_uint (enc, utf8 ? MAJOR_TEXT : MAJOR_BYTES, len);
285 need (enc, len); 343 need (enc, len);
286 memcpy (enc->cur, str, len); 344 memcpy (enc->cur, str, len);
287 enc->cur += len; 345 enc->cur += len;
288} 346}
289 347
290static void 348ecb_inline void
291encode_strref (enc_t *enc, int utf8, char *str, STRLEN len) 349encode_strref (enc_t *enc, int upgrade_utf8, int utf8, char *str, STRLEN len)
292{ 350{
293 if (ecb_expect_false (enc->cbor.flags & F_PACK_STRINGS)) 351 if (ecb_expect_false (enc->cbor.flags & F_PACK_STRINGS))
294 { 352 {
295 SV **svp = hv_fetch (enc->stringref[!!utf8], str, len, 1); 353 SV **svp = hv_fetch (enc->stringref[!!utf8], str, len, 1);
296 354
… …
307 sv_setuv (*svp, enc->stringref_idx); 365 sv_setuv (*svp, enc->stringref_idx);
308 ++enc->stringref_idx; 366 ++enc->stringref_idx;
309 } 367 }
310 } 368 }
311 369
312 encode_str (enc, utf8, str, len); 370 encode_str (enc, upgrade_utf8, utf8, str, len);
371}
372
373ecb_inline void
374encode_float16 (enc_t *enc, NV nv)
375{
376 need (enc, 1+2);
377
378 *enc->cur++ = MAJOR_MISC | MISC_FLOAT16;
379
380 uint16_t fp = ecb_float_to_binary16 (nv);
381
382 if (!ecb_big_endian ())
383 fp = ecb_bswap16 (fp);
384
385 memcpy (enc->cur, &fp, 2);
386 enc->cur += 2;
387}
388
389ecb_inline void
390encode_float32 (enc_t *enc, NV nv)
391{
392 need (enc, 1+4);
393
394 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
395
396 uint32_t fp = ecb_float_to_binary32 (nv);
397
398 if (!ecb_big_endian ())
399 fp = ecb_bswap32 (fp);
400
401 memcpy (enc->cur, &fp, 4);
402 enc->cur += 4;
403}
404
405ecb_inline void
406encode_float64 (enc_t *enc, NV nv)
407{
408 need (enc, 1+8);
409
410 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
411
412 uint64_t fp = ecb_double_to_binary64 (nv);
413
414 if (!ecb_big_endian ())
415 fp = ecb_bswap64 (fp);
416
417 memcpy (enc->cur, &fp, 8);
418 enc->cur += 8;
419}
420
421ecb_inline void
422encode_forced (enc_t *enc, UV type, SV *sv)
423{
424 switch (type)
425 {
426 case AS_CBOR:
427 {
428 STRLEN len;
429 char *str = SvPVbyte (sv, len);
430
431 need (enc, len);
432 memcpy (enc->cur, str, len);
433 enc->cur += len;
434 }
435 break;
436
437 case AS_BYTES:
438 {
439 STRLEN len;
440 char *str = SvPVbyte (sv, len);
441 encode_strref (enc, 0, 0, str, len);
442 }
443 break;
444
445 case AS_TEXT:
446 {
447 STRLEN len;
448 char *str = SvPVutf8 (sv, len);
449 encode_strref (enc, 1, 1, str, len);
450 }
451 break;
452
453 case AS_FLOAT16: encode_float16 (enc, SvNV (sv)); break;
454 case AS_FLOAT32: encode_float32 (enc, SvNV (sv)); break;
455 case AS_FLOAT64: encode_float64 (enc, SvNV (sv)); break;
456
457 default:
458 croak ("encountered malformed CBOR::XS::Tagged object");
459 }
313} 460}
314 461
315static void encode_sv (enc_t *enc, SV *sv); 462static void encode_sv (enc_t *enc, SV *sv);
316 463
317static void 464static void
… …
324 471
325 ++enc->depth; 472 ++enc->depth;
326 473
327 encode_uint (enc, MAJOR_ARRAY, len + 1); 474 encode_uint (enc, MAJOR_ARRAY, len + 1);
328 475
329 if (SvMAGICAL (av)) 476 if (ecb_expect_false (SvMAGICAL (av)))
330 for (i = 0; i <= len; ++i) 477 for (i = 0; i <= len; ++i)
331 { 478 {
332 SV **svp = av_fetch (av, i, 0); 479 SV **svp = av_fetch (av, i, 0);
333 encode_sv (enc, svp ? *svp : &PL_sv_undef); 480 encode_sv (enc, svp ? *svp : &PL_sv_undef);
334 } 481 }
… …
353 ++enc->depth; 500 ++enc->depth;
354 501
355 int pairs = hv_iterinit (hv); 502 int pairs = hv_iterinit (hv);
356 int mg = SvMAGICAL (hv); 503 int mg = SvMAGICAL (hv);
357 504
358 if (mg) 505 if (ecb_expect_false (mg))
359 encode_ch (enc, MAJOR_MAP | MINOR_INDEF); 506 encode_ch (enc, MAJOR_MAP | MINOR_INDEF);
360 else 507 else
361 encode_uint (enc, MAJOR_MAP, pairs); 508 encode_uint (enc, MAJOR_MAP, pairs);
362 509
363 while ((he = hv_iternext (hv))) 510 while ((he = hv_iternext (hv)))
364 { 511 {
365 if (HeKLEN (he) == HEf_SVKEY) 512 if (HeKLEN (he) == HEf_SVKEY)
366 encode_sv (enc, HeSVKEY (he)); 513 encode_sv (enc, HeSVKEY (he));
367 else 514 else
368 encode_strref (enc, HeKUTF8 (he), HeKEY (he), HeKLEN (he)); 515 encode_strref (enc, enc->cbor.flags & (F_TEXT_KEYS | F_TEXT_STRINGS), HeKUTF8 (he), HeKEY (he), HeKLEN (he));
369 516
370 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he)); 517 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he));
371 } 518 }
372 519
373 if (mg) 520 if (ecb_expect_false (mg))
374 encode_ch (enc, MAJOR_MISC | MINOR_INDEF); 521 encode_ch (enc, MAJOR_MISC | MINOR_INDEF);
375 522
376 --enc->depth; 523 --enc->depth;
377} 524}
378 525
… …
411 else if (stash == tagged_stash) 558 else if (stash == tagged_stash)
412 { 559 {
413 if (svt != SVt_PVAV) 560 if (svt != SVt_PVAV)
414 croak ("encountered CBOR::XS::Tagged object that isn't an array"); 561 croak ("encountered CBOR::XS::Tagged object that isn't an array");
415 562
563 switch (av_len ((AV *)sv))
564 {
565 case 2-1:
566 // actually a tagged value
416 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1))); 567 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1)));
417 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1)); 568 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1));
569 break;
570
571 case 3-1:
572 // a forced type [value, type, undef]
573 encode_forced (enc, SvUV (*av_fetch ((AV *)sv, 1, 1)), *av_fetch ((AV *)sv, 0, 1));
574 break;
575
576 default:
577 croak ("encountered malformed CBOR::XS::Tagged object");
578 }
418 579
419 return; 580 return;
420 } 581 }
421 } 582 }
422 583
423 if (ecb_expect_false (SvREFCNT (sv) > 1) 584 if (ecb_expect_false (SvREFCNT (sv) > 1)
424 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING)) 585 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING))
425 { 586 {
426 if (!enc->shareable) 587 if (ecb_expect_false (!enc->shareable))
427 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ()); 588 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ());
428 589
429 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1); 590 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1);
430 591
431 if (SvOK (*svp)) 592 if (SvOK (*svp))
… …
445 if (ecb_expect_false (SvOBJECT (sv))) 606 if (ecb_expect_false (SvOBJECT (sv)))
446 { 607 {
447 HV *stash = SvSTASH (sv); 608 HV *stash = SvSTASH (sv);
448 GV *method; 609 GV *method;
449 610
611 if (enc->cbor.flags & F_FORBID_OBJECTS)
612 croak ("encountered object '%s', but forbid_objects is enabled",
613 SvPV_nolen (sv_2mortal (newRV_inc (sv))));
450 if ((method = gv_fetchmethod_autoload (stash, "TO_CBOR", 0))) 614 else if ((method = gv_fetchmethod_autoload (stash, "TO_CBOR", 0)))
451 { 615 {
452 dSP; 616 dSP;
453 617
454 ENTER; SAVETMPS; 618 ENTER; SAVETMPS;
455 PUSHMARK (SP); 619 PUSHMARK (SP);
… …
474 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0) 638 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0)
475 { 639 {
476 dSP; 640 dSP;
477 641
478 ENTER; SAVETMPS; 642 ENTER; SAVETMPS;
479 SAVESTACK_POS ();
480 PUSHMARK (SP); 643 PUSHMARK (SP);
481 EXTEND (SP, 2); 644 EXTEND (SP, 2);
482 // we re-bless the reference to get overload and other niceties right 645 // we re-bless the reference to get overload and other niceties right
483 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash)); 646 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash));
484 PUSHs (sv_cbor); 647 PUSHs (sv_cbor);
… …
491 if (count == 1 && SvROK (TOPs) && SvRV (TOPs) == sv) 654 if (count == 1 && SvROK (TOPs) && SvRV (TOPs) == sv)
492 croak ("%s::FREEZE(CBOR) method returned same object as was passed instead of a new one", HvNAME (stash)); 655 croak ("%s::FREEZE(CBOR) method returned same object as was passed instead of a new one", HvNAME (stash));
493 656
494 encode_tag (enc, CBOR_TAG_PERL_OBJECT); 657 encode_tag (enc, CBOR_TAG_PERL_OBJECT);
495 encode_uint (enc, MAJOR_ARRAY, count + 1); 658 encode_uint (enc, MAJOR_ARRAY, count + 1);
496 encode_strref (enc, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash)); 659 encode_strref (enc, 0, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash));
497 660
498 while (count) 661 {
662 int i;
663
664 for (i = 0; i < count; ++i)
499 encode_sv (enc, SP[1 - count--]); 665 encode_sv (enc, SP[i + 1 - count]);
666
667 SP -= count;
668 }
500 669
501 PUTBACK; 670 PUTBACK;
502 671
503 FREETMPS; LEAVE; 672 FREETMPS; LEAVE;
504 } 673 }
… …
526 695
527 if (ecb_expect_false (nv == (NV)(U32)nv)) 696 if (ecb_expect_false (nv == (NV)(U32)nv))
528 encode_uint (enc, MAJOR_POS_INT, (U32)nv); 697 encode_uint (enc, MAJOR_POS_INT, (U32)nv);
529 //TODO: maybe I32? 698 //TODO: maybe I32?
530 else if (ecb_expect_false (nv == (float)nv)) 699 else if (ecb_expect_false (nv == (float)nv))
531 { 700 encode_float32 (enc, nv);
532 uint32_t fp = ecb_float_to_binary32 (nv);
533
534 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
535
536 if (!ecb_big_endian ())
537 fp = ecb_bswap32 (fp);
538
539 memcpy (enc->cur, &fp, 4);
540 enc->cur += 4;
541 }
542 else 701 else
543 { 702 encode_float64 (enc, nv);
544 uint64_t fp = ecb_double_to_binary64 (nv);
545
546 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
547
548 if (!ecb_big_endian ())
549 fp = ecb_bswap64 (fp);
550
551 memcpy (enc->cur, &fp, 8);
552 enc->cur += 8;
553 }
554} 703}
555 704
556static void 705static void
557encode_sv (enc_t *enc, SV *sv) 706encode_sv (enc_t *enc, SV *sv)
558{ 707{
… …
560 709
561 if (SvPOKp (sv)) 710 if (SvPOKp (sv))
562 { 711 {
563 STRLEN len; 712 STRLEN len;
564 char *str = SvPV (sv, len); 713 char *str = SvPV (sv, len);
565 encode_strref (enc, SvUTF8 (sv), str, len); 714 encode_strref (enc, enc->cbor.flags & F_TEXT_STRINGS, SvUTF8 (sv), str, len);
566 } 715 }
567 else if (SvNOKp (sv)) 716 else if (SvNOKp (sv))
568 encode_nv (enc, sv); 717 encode_nv (enc, sv);
569 else if (SvIOKp (sv)) 718 else if (SvIOKp (sv))
570 { 719 encode_int (e,v sv);
571 if (SvIsUV (sv))
572 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
573 else if (SvIVX (sv) >= 0)
574 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
575 else
576 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
577 }
578 else if (SvROK (sv)) 720 else if (SvROK (sv))
579 encode_rv (enc, SvRV (sv)); 721 encode_rv (enc, SvRV (sv));
580 else if (!SvOK (sv)) 722 else if (!SvOK (sv))
581 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL); 723 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL);
582 else if (enc->cbor.flags & F_ALLOW_UNKNOWN) 724 else if (enc->cbor.flags & F_ALLOW_UNKNOWN)
… …
589static SV * 731static SV *
590encode_cbor (SV *scalar, CBOR *cbor) 732encode_cbor (SV *scalar, CBOR *cbor)
591{ 733{
592 enc_t enc = { 0 }; 734 enc_t enc = { 0 };
593 735
594 enc.cbor = *cbor; 736 enc.cbor = *cbor;
595 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE)); 737 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE));
596 enc.cur = SvPVX (enc.sv); 738 enc.cur = SvPVX (enc.sv);
597 enc.end = SvEND (enc.sv); 739 enc.end = SvEND (enc.sv);
598 740
599 SvPOK_only (enc.sv); 741 SvPOK_only (enc.sv);
600 742
601 if (cbor->flags & F_PACK_STRINGS) 743 if (cbor->flags & F_PACK_STRINGS)
602 { 744 {
… …
629 U32 depth; // recursion depth 771 U32 depth; // recursion depth
630 U32 maxdepth; // recursion depth limit 772 U32 maxdepth; // recursion depth limit
631 AV *shareable; 773 AV *shareable;
632 AV *stringref; 774 AV *stringref;
633 SV *decode_tagged; 775 SV *decode_tagged;
776 SV *err_sv; // optional sv for error, needs to be freed
634} dec_t; 777} dec_t;
635 778
636#define ERR(reason) SB if (!dec->err) dec->err = reason; goto fail; SE 779// set dec->err to ERRSV
780ecb_cold static void
781err_errsv (dec_t *dec)
782{
783 if (!dec->err)
784 {
785 dec->err_sv = newSVsv (ERRSV);
637 786
638#define WANT(len) if (ecb_expect_false (dec->cur + len > dec->end)) ERR ("unexpected end of CBOR data") 787 // chop off the trailing \n
788 SvCUR_set (dec->err_sv, SvCUR (dec->err_sv) - 1);
789 *SvEND (dec->err_sv) = 0;
639 790
791 dec->err = SvPVutf8_nolen (dec->err_sv);
792 }
793}
794
795// the following functions are used to reduce code size and help the compiler to optimise
796ecb_cold static void
797err_set (dec_t *dec, const char *reason)
798{
799 if (!dec->err)
800 dec->err = reason;
801}
802
803ecb_cold static void
804err_unexpected_end (dec_t *dec)
805{
806 err_set (dec, "unexpected end of CBOR data");
807}
808
809#define ERR_DO(do) SB do; goto fail; SE
810#define ERR(reason) ERR_DO (err_set (dec, reason))
811#define ERR_ERRSV ERR_DO (err_errsv (dec))
812
813#define WANT(len) if (ecb_expect_false ((uintptr_t)(dec->end - dec->cur) < (STRLEN)len)) ERR_DO (err_unexpected_end (dec))
814
640#define DEC_INC_DEPTH if (++dec->depth > dec->cbor.max_depth) ERR (ERR_NESTING_EXCEEDED) 815#define DEC_INC_DEPTH if (ecb_expect_false (++dec->depth > dec->cbor.max_depth)) ERR (ERR_NESTING_EXCEEDED)
641#define DEC_DEC_DEPTH --dec->depth 816#define DEC_DEC_DEPTH --dec->depth
642 817
643static UV 818static UV
644decode_uint (dec_t *dec) 819decode_uint (dec_t *dec)
645{ 820{
… …
711 886
712 for (;;) 887 for (;;)
713 { 888 {
714 WANT (1); 889 WANT (1);
715 890
716 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 891 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
717 { 892 {
718 ++dec->cur; 893 ++dec->cur;
719 break; 894 break;
720 } 895 }
721 896
722 av_push (av, decode_sv (dec)); 897 av_push (av, decode_sv (dec));
723 } 898 }
724 } 899 }
725 else 900 else
726 { 901 {
727 int i, len = decode_uint (dec); 902 UV i, len = decode_uint (dec);
728 903
729 WANT (len); // complexity check for av_fill - need at least one byte per value, do not allow supersize arrays 904 WANT (len); // complexity check for av_fill - need at least one byte per value, do not allow supersize arrays
730 av_fill (av, len - 1); 905 av_fill (av, len - 1);
731 906
732 for (i = 0; i < len; ++i) 907 for (i = 0; i < len; ++i)
… …
735 910
736 DEC_DEC_DEPTH; 911 DEC_DEC_DEPTH;
737 return newRV_noinc ((SV *)av); 912 return newRV_noinc ((SV *)av);
738 913
739fail: 914fail:
740 SvREFCNT_dec (av); 915 SvREFCNT_dec_NN (av);
741 DEC_DEC_DEPTH; 916 DEC_DEC_DEPTH;
742 return &PL_sv_undef; 917 return &PL_sv_undef;
743} 918}
744 919
745static void 920static void
… …
749 // byte or utf-8 strings as keys, but only when !stringref 924 // byte or utf-8 strings as keys, but only when !stringref
750 925
751 if (ecb_expect_true (!dec->stringref)) 926 if (ecb_expect_true (!dec->stringref))
752 if (ecb_expect_true ((U8)(*dec->cur - MAJOR_BYTES) <= LENGTH_EXT8)) 927 if (ecb_expect_true ((U8)(*dec->cur - MAJOR_BYTES) <= LENGTH_EXT8))
753 { 928 {
754 I32 len = decode_uint (dec); 929 STRLEN len = decode_uint (dec);
755 char *key = (char *)dec->cur; 930 char *key = (char *)dec->cur;
756 931
757 WANT (len); 932 WANT (len);
758 dec->cur += len; 933 dec->cur += len;
759 934
… …
761 936
762 return; 937 return;
763 } 938 }
764 else if (ecb_expect_true ((U8)(*dec->cur - MAJOR_TEXT) <= LENGTH_EXT8)) 939 else if (ecb_expect_true ((U8)(*dec->cur - MAJOR_TEXT) <= LENGTH_EXT8))
765 { 940 {
766 I32 len = decode_uint (dec); 941 STRLEN len = decode_uint (dec);
767 char *key = (char *)dec->cur; 942 char *key = (char *)dec->cur;
768 943
769 WANT (len); 944 WANT (len);
770 dec->cur += len; 945 dec->cur += len;
771 946
… …
779 } 954 }
780 955
781 SV *k = decode_sv (dec); 956 SV *k = decode_sv (dec);
782 SV *v = decode_sv (dec); 957 SV *v = decode_sv (dec);
783 958
959 // we leak memory if uncaught exceptions are thrown by random magical
960 // methods, and this is hopefully the only place where it can happen,
961 // so if there is a chance of an exception, take the very slow path.
962 // since catching exceptions is "undocumented/internal/forbidden" by
963 // the new p5p powers, we need to call out to a perl function :/
964 if (ecb_expect_false (SvAMAGIC (k)))
965 {
966 dSP;
967
968 ENTER; SAVETMPS;
969 PUSHMARK (SP);
970 EXTEND (SP, 3);
971 PUSHs (sv_2mortal (newRV_inc ((SV *)hv)));
972 PUSHs (sv_2mortal (k));
973 PUSHs (sv_2mortal (v));
974
975 PUTBACK;
976 call_pv ("CBOR::XS::_hv_store", G_VOID | G_DISCARD | G_EVAL);
977 SPAGAIN;
978
979 FREETMPS; LEAVE;
980
981 if (SvTRUE (ERRSV))
982 ERR_ERRSV;
983
984 return;
985 }
986
784 hv_store_ent (hv, k, v, 0); 987 hv_store_ent (hv, k, v, 0);
785 SvREFCNT_dec (k); 988 SvREFCNT_dec_NN (k);
786 989
787fail: 990fail:
788 ; 991 ;
789} 992}
790 993
… …
801 1004
802 for (;;) 1005 for (;;)
803 { 1006 {
804 WANT (1); 1007 WANT (1);
805 1008
806 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 1009 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
807 { 1010 {
808 ++dec->cur; 1011 ++dec->cur;
809 break; 1012 break;
810 } 1013 }
811 1014
812 decode_he (dec, hv); 1015 decode_he (dec, hv);
813 } 1016 }
814 } 1017 }
815 else 1018 else
816 { 1019 {
817 int pairs = decode_uint (dec); 1020 UV pairs = decode_uint (dec);
1021
1022 WANT (pairs); // complexity check - need at least one byte per value, do not allow supersize hashes
818 1023
819 while (pairs--) 1024 while (pairs--)
820 decode_he (dec, hv); 1025 decode_he (dec, hv);
821 } 1026 }
822 1027
823 DEC_DEC_DEPTH; 1028 DEC_DEC_DEPTH;
824 return newRV_noinc ((SV *)hv); 1029 return newRV_noinc ((SV *)hv);
825 1030
826fail: 1031fail:
827 SvREFCNT_dec (hv); 1032 SvREFCNT_dec_NN (hv);
828 DEC_DEC_DEPTH; 1033 DEC_DEC_DEPTH;
829 return &PL_sv_undef; 1034 return &PL_sv_undef;
830} 1035}
831 1036
832static SV * 1037static SV *
833decode_str (dec_t *dec, int utf8) 1038decode_str (dec_t *dec, int utf8)
834{ 1039{
835 SV *sv = 0; 1040 SV *sv = 0;
836 1041
837 if ((*dec->cur & MINOR_MASK) == MINOR_INDEF) 1042 if (ecb_expect_false ((*dec->cur & MINOR_MASK) == MINOR_INDEF))
838 { 1043 {
839 // indefinite length strings 1044 // indefinite length strings
840 ++dec->cur; 1045 ++dec->cur;
841 1046
842 U8 major = *dec->cur & MAJOR_MISC; 1047 U8 major = *dec->cur & MAJOR_MISC;
… …
910 sv = newRV_noinc (decode_sv (dec)); 1115 sv = newRV_noinc (decode_sv (dec));
911 break; 1116 break;
912 1117
913 case CBOR_TAG_STRINGREF_NAMESPACE: 1118 case CBOR_TAG_STRINGREF_NAMESPACE:
914 { 1119 {
1120 // do not use SAVETMPS/FREETMPS, as these will
1121 // erase mortalised caches, e.g. "shareable"
915 ENTER; SAVETMPS; 1122 ENTER;
916 1123
917 SAVESPTR (dec->stringref); 1124 SAVESPTR (dec->stringref);
918 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ()); 1125 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ());
919 1126
920 sv = decode_sv (dec); 1127 sv = decode_sv (dec);
921 1128
922 FREETMPS; LEAVE; 1129 LEAVE;
923 } 1130 }
924 break; 1131 break;
925 1132
926 case CBOR_TAG_STRINGREF: 1133 case CBOR_TAG_STRINGREF:
927 { 1134 {
928 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1135 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
929 ERR ("corrupted CBOR data (stringref index not an unsigned integer)"); 1136 ERR ("corrupted CBOR data (stringref index not an unsigned integer)");
930 1137
931 UV idx = decode_uint (dec); 1138 UV idx = decode_uint (dec);
932 1139
933 if (!dec->stringref || (int)idx > AvFILLp (dec->stringref)) 1140 if (!dec->stringref || idx >= (UV)(1 + AvFILLp (dec->stringref)))
934 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)"); 1141 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)");
935 1142
936 sv = newSVsv (AvARRAY (dec->stringref)[idx]); 1143 sv = newSVsv (AvARRAY (dec->stringref)[idx]);
937 } 1144 }
938 break; 1145 break;
… …
966 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1173 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
967 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)"); 1174 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)");
968 1175
969 UV idx = decode_uint (dec); 1176 UV idx = decode_uint (dec);
970 1177
971 if (!dec->shareable || (int)idx > AvFILLp (dec->shareable)) 1178 if (!dec->shareable || idx >= (UV)(1 + AvFILLp (dec->shareable)))
972 ERR ("corrupted CBOR data (sharedref index out of bounds)"); 1179 ERR ("corrupted CBOR data (sharedref index out of bounds)");
973 1180
974 sv = SvREFCNT_inc_NN (AvARRAY (dec->shareable)[idx]); 1181 sv = SvREFCNT_inc_NN (AvARRAY (dec->shareable)[idx]);
975 1182
976 if (sv == &PL_sv_undef) 1183 if (sv == &PL_sv_undef)
… …
978 } 1185 }
979 break; 1186 break;
980 1187
981 case CBOR_TAG_PERL_OBJECT: 1188 case CBOR_TAG_PERL_OBJECT:
982 { 1189 {
1190 if (dec->cbor.flags & F_FORBID_OBJECTS)
1191 goto filter;
1192
983 sv = decode_sv (dec); 1193 sv = decode_sv (dec);
984 1194
985 if (!SvROK (sv) || SvTYPE (SvRV (sv)) != SVt_PVAV) 1195 if (!SvROK (sv) || SvTYPE (SvRV (sv)) != SVt_PVAV)
986 ERR ("corrupted CBOR data (non-array perl object)"); 1196 ERR ("corrupted CBOR data (non-array perl object)");
987 1197
… …
1016 SPAGAIN; 1226 SPAGAIN;
1017 1227
1018 if (SvTRUE (ERRSV)) 1228 if (SvTRUE (ERRSV))
1019 { 1229 {
1020 FREETMPS; LEAVE; 1230 FREETMPS; LEAVE;
1021 ERR (SvPVutf8_nolen (sv_2mortal (SvREFCNT_inc (ERRSV)))); 1231 ERR_ERRSV;
1022 } 1232 }
1023 1233
1024 SvREFCNT_dec (sv); 1234 SvREFCNT_dec_NN (sv);
1025 sv = SvREFCNT_inc (POPs); 1235 sv = SvREFCNT_inc (POPs);
1026 1236
1027 PUTBACK; 1237 PUTBACK;
1028 1238
1029 FREETMPS; LEAVE; 1239 FREETMPS; LEAVE;
1030 } 1240 }
1031 break; 1241 break;
1032 1242
1033 default: 1243 default:
1244 filter:
1034 { 1245 {
1246 SV *tag_sv = newSVuv (tag);
1247
1035 sv = decode_sv (dec); 1248 sv = decode_sv (dec);
1036 1249
1037 dSP; 1250 dSP;
1038 ENTER; SAVETMPS; 1251 ENTER; SAVETMPS;
1039 SAVESTACK_POS ();
1040 PUSHMARK (SP); 1252 PUSHMARK (SP);
1041 EXTEND (SP, 2); 1253 EXTEND (SP, 2);
1042 PUSHs (newSVuv (tag)); 1254 PUSHs (tag_sv);
1043 PUSHs (sv); 1255 PUSHs (sv);
1044 1256
1045 PUTBACK; 1257 PUTBACK;
1046 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL); 1258 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL);
1047 SPAGAIN; 1259 SPAGAIN;
1048 1260
1049 if (SvTRUE (ERRSV)) 1261 if (SvTRUE (ERRSV))
1050 { 1262 {
1263 SvREFCNT_dec_NN (tag_sv);
1051 FREETMPS; LEAVE; 1264 FREETMPS; LEAVE;
1052 ERR (SvPVutf8_nolen (sv_2mortal (SvREFCNT_inc (ERRSV)))); 1265 ERR_ERRSV;
1053 } 1266 }
1054 1267
1055 if (count) 1268 if (count)
1056 { 1269 {
1270 SvREFCNT_dec_NN (tag_sv);
1057 SvREFCNT_dec (sv); 1271 SvREFCNT_dec_NN (sv);
1058 sv = SvREFCNT_inc (POPs); 1272 sv = SvREFCNT_inc_NN (TOPs);
1273 SP -= count;
1059 } 1274 }
1060 else 1275 else
1061 { 1276 {
1062 AV *av = newAV (); 1277 AV *av = newAV ();
1063 av_push (av, newSVuv (tag)); 1278 av_push (av, tag_sv);
1064 av_push (av, sv); 1279 av_push (av, sv);
1065 1280
1066 HV *tagged_stash = !CBOR_SLOW || cbor_tagged_stash 1281 HV *tagged_stash = !CBOR_SLOW || cbor_tagged_stash
1067 ? cbor_tagged_stash 1282 ? cbor_tagged_stash
1068 : gv_stashpv ("CBOR::XS::Tagged" , 1); 1283 : gv_stashpv ("CBOR::XS::Tagged" , 1);
… …
1197 1412
1198 if (dec.err) 1413 if (dec.err)
1199 { 1414 {
1200 if (dec.shareable) 1415 if (dec.shareable)
1201 { 1416 {
1202 // need to break cyclic links, which whould all be in shareable 1417 // need to break cyclic links, which would all be in shareable
1203 int i; 1418 int i;
1204 SV **svp; 1419 SV **svp;
1205 1420
1206 for (i = av_len (dec.shareable) + 1; i--; ) 1421 for (i = av_len (dec.shareable) + 1; i--; )
1207 if ((svp = av_fetch (dec.shareable, i, 0))) 1422 if ((svp = av_fetch (dec.shareable, i, 0)))
1208 sv_setsv (*svp, &PL_sv_undef); 1423 sv_setsv (*svp, &PL_sv_undef);
1209 } 1424 }
1210 1425
1211 SvREFCNT_dec (sv); 1426 SvREFCNT_dec_NN (sv);
1427
1428 if (dec.err_sv)
1429 sv_2mortal (dec.err_sv);
1430
1212 croak ("%s, at offset %d (octet 0x%02x)", dec.err, dec.cur - (U8 *)data, (int)(uint8_t)*dec.cur); 1431 croak ("%s, at offset %d (octet 0x%02x)", dec.err, dec.cur - (U8 *)data, (int)(uint8_t)*dec.cur);
1213 } 1432 }
1214 1433
1215 sv = sv_2mortal (sv); 1434 sv = sv_2mortal (sv);
1216 1435
… …
1360 1579
1361 default_filter = newSVpv ("CBOR::XS::default_filter", 0); 1580 default_filter = newSVpv ("CBOR::XS::default_filter", 0);
1362 1581
1363 sv_cbor = newSVpv ("CBOR", 0); 1582 sv_cbor = newSVpv ("CBOR", 0);
1364 SvREADONLY_on (sv_cbor); 1583 SvREADONLY_on (sv_cbor);
1584
1585 assert (("STRLEN must be an unsigned type", 0 <= (STRLEN)-1));
1365} 1586}
1366 1587
1367PROTOTYPES: DISABLE 1588PROTOTYPES: DISABLE
1368 1589
1369void CLONE (...) 1590void CLONE (...)
… …
1389 ALIAS: 1610 ALIAS:
1390 shrink = F_SHRINK 1611 shrink = F_SHRINK
1391 allow_unknown = F_ALLOW_UNKNOWN 1612 allow_unknown = F_ALLOW_UNKNOWN
1392 allow_sharing = F_ALLOW_SHARING 1613 allow_sharing = F_ALLOW_SHARING
1393 allow_cycles = F_ALLOW_CYCLES 1614 allow_cycles = F_ALLOW_CYCLES
1615 forbid_objects = F_FORBID_OBJECTS
1394 pack_strings = F_PACK_STRINGS 1616 pack_strings = F_PACK_STRINGS
1617 text_keys = F_TEXT_KEYS
1618 text_strings = F_TEXT_STRINGS
1395 validate_utf8 = F_VALIDATE_UTF8 1619 validate_utf8 = F_VALIDATE_UTF8
1396 PPCODE: 1620 PPCODE:
1397{ 1621{
1398 if (enable) 1622 if (enable)
1399 self->flags |= ix; 1623 self->flags |= ix;
… …
1407 ALIAS: 1631 ALIAS:
1408 get_shrink = F_SHRINK 1632 get_shrink = F_SHRINK
1409 get_allow_unknown = F_ALLOW_UNKNOWN 1633 get_allow_unknown = F_ALLOW_UNKNOWN
1410 get_allow_sharing = F_ALLOW_SHARING 1634 get_allow_sharing = F_ALLOW_SHARING
1411 get_allow_cycles = F_ALLOW_CYCLES 1635 get_allow_cycles = F_ALLOW_CYCLES
1636 get_forbid_objects = F_FORBID_OBJECTS
1412 get_pack_strings = F_PACK_STRINGS 1637 get_pack_strings = F_PACK_STRINGS
1638 get_text_keys = F_TEXT_KEYS
1639 get_text_strings = F_TEXT_STRINGS
1413 get_validate_utf8 = F_VALIDATE_UTF8 1640 get_validate_utf8 = F_VALIDATE_UTF8
1414 PPCODE: 1641 PPCODE:
1415 XPUSHs (boolSV (self->flags & ix)); 1642 XPUSHs (boolSV (self->flags & ix));
1416 1643
1417void max_depth (CBOR *self, U32 max_depth = 0x80000000UL) 1644void max_depth (CBOR *self, U32 max_depth = 0x80000000UL)
… …
1547 cbor_init (&cbor); 1774 cbor_init (&cbor);
1548 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN; 1775 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN;
1549 XPUSHs (cborstr); 1776 XPUSHs (cborstr);
1550} 1777}
1551 1778
1779#ifdef __AFL_COMPILER
1780
1781void
1782afl_init ()
1783 CODE:
1784 __AFL_INIT ();
1785
1786int
1787afl_loop (unsigned int count = 10000)
1788 CODE:
1789 RETVAL = __AFL_LOOP (count);
1790 OUTPUT:
1791 RETVAL
1792
1793#endif
1794

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines