ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/CBOR-XS/XS.xs
(Generate patch)

Comparing CBOR-XS/XS.xs (file contents):
Revision 1.55 by root, Fri Nov 25 06:13:16 2016 UTC vs.
Revision 1.66 by root, Sun Nov 29 21:32:01 2020 UTC

… …
6#include <string.h> 6#include <string.h>
7#include <stdlib.h> 7#include <stdlib.h>
8#include <stdio.h> 8#include <stdio.h>
9#include <limits.h> 9#include <limits.h>
10#include <float.h> 10#include <float.h>
11#include <inttypes.h>
11 12
12#define ECB_NO_THREADS 1 13#define ECB_NO_THREADS 1
13#include "ecb.h" 14#include "ecb.h"
14 15
15// compatibility with perl <5.18 16// compatibility with perl <5.18
… …
20# define HvNAMELEN(hv) HvNAMELEN_get (hv) 21# define HvNAMELEN(hv) HvNAMELEN_get (hv)
21#endif 22#endif
22#ifndef HvNAMEUTF8 23#ifndef HvNAMEUTF8
23# define HvNAMEUTF8(hv) 0 24# define HvNAMEUTF8(hv) 0
24#endif 25#endif
26#ifndef SvREFCNT_inc_NN
27# define SvREFCNT_inc_NN(sv) SvREFCNT_inc (sv)
28#endif
25#ifndef SvREFCNT_dec_NN 29#ifndef SvREFCNT_dec_NN
26# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv) 30# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv)
27#endif 31#endif
28 32
29// known major and minor types 33// known major and minor types
… …
95 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8 99 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8
96 100
97 CBOR_TAG_MAGIC = 55799, // self-describe cbor 101 CBOR_TAG_MAGIC = 55799, // self-describe cbor
98}; 102};
99 103
104// known forced types, also hardcoded in CBOR.pm
105enum
106{
107 AS_CBOR = 0,
108 AS_BYTES = 1,
109 AS_TEXT = 2,
110 AS_FLOAT16 = 3,
111 AS_FLOAT32 = 4,
112 AS_FLOAT64 = 5,
113 // possibly future enhancements: float, integer
114};
115
100#define F_SHRINK 0x00000001UL 116#define F_SHRINK 0x00000001UL
101#define F_ALLOW_UNKNOWN 0x00000002UL 117#define F_ALLOW_UNKNOWN 0x00000002UL
102#define F_ALLOW_SHARING 0x00000004UL 118#define F_ALLOW_SHARING 0x00000004UL
103#define F_ALLOW_CYCLES 0x00000008UL 119#define F_ALLOW_CYCLES 0x00000008UL
120#define F_FORBID_OBJECTS 0x00000010UL
104#define F_PACK_STRINGS 0x00000010UL 121#define F_PACK_STRINGS 0x00000020UL
105#define F_TEXT_KEYS 0x00000020UL 122#define F_TEXT_KEYS 0x00000040UL
106#define F_TEXT_STRINGS 0x00000040UL 123#define F_TEXT_STRINGS 0x00000080UL
107#define F_VALIDATE_UTF8 0x00000080UL 124#define F_VALIDATE_UTF8 0x00000100UL
108 125
109#define INIT_SIZE 32 // initial scalar size to be allocated 126#define INIT_SIZE 32 // initial scalar size to be allocated
110 127
111#define SB do { 128#define SB do {
112#define SE } while (0) 129#define SE } while (0)
… …
185 202
186// minimum length of a string to be registered for stringref 203// minimum length of a string to be registered for stringref
187ecb_inline int 204ecb_inline int
188minimum_string_length (UV idx) 205minimum_string_length (UV idx)
189{ 206{
190 return idx > 23 207 return idx <= 23 ? 3
191 ? idx > 0xffU 208 : idx <= 0xffU ? 4
192 ? idx > 0xffffU 209 : idx <= 0xffffU ? 5
193 ? idx > 0xffffffffU 210 : idx <= 0xffffffffU ? 7
194 ? 11 211 : 11;
195 : 7
196 : 5
197 : 4
198 : 3;
199} 212}
200 213
201///////////////////////////////////////////////////////////////////////////// 214/////////////////////////////////////////////////////////////////////////////
202// encoder 215// encoder
203 216
… …
216} enc_t; 229} enc_t;
217 230
218ecb_inline void 231ecb_inline void
219need (enc_t *enc, STRLEN len) 232need (enc_t *enc, STRLEN len)
220{ 233{
221 if (ecb_expect_false (enc->cur + len >= enc->end)) 234 if (ecb_expect_false ((uintptr_t)(enc->end - enc->cur) < len))
222 { 235 {
223 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv); 236 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv);
224 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1); 237 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1);
225 enc->cur = SvPVX (enc->sv) + cur; 238 enc->cur = SvPVX (enc->sv) + cur;
226 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1; 239 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1;
… …
232{ 245{
233 need (enc, 1); 246 need (enc, 1);
234 *enc->cur++ = ch; 247 *enc->cur++ = ch;
235} 248}
236 249
250// used for tags, intregers, element counts and so on
237static void 251static void
238encode_uint (enc_t *enc, int major, UV len) 252encode_uint (enc_t *enc, int major, UV len)
239{ 253{
240 need (enc, 9); 254 need (enc, 9);
241 255
… …
272 *enc->cur++ = len >> 8; 286 *enc->cur++ = len >> 8;
273 *enc->cur++ = len; 287 *enc->cur++ = len;
274 } 288 }
275} 289}
276 290
291// encodes a perl value into a CBOR integer
292ecb_inline
293encode_int (enc_t *enc, SV *sv)
294{
295 if (SvIsUV (sv))
296 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
297 else if (SvIVX (sv) >= 0)
298 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
299 else
300 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
301}
302
277ecb_inline void 303ecb_inline void
278encode_tag (enc_t *enc, UV tag) 304encode_tag (enc_t *enc, UV tag)
279{ 305{
280 encode_uint (enc, MAJOR_TAG, tag); 306 encode_uint (enc, MAJOR_TAG, tag);
281} 307}
… …
342 } 368 }
343 369
344 encode_str (enc, upgrade_utf8, utf8, str, len); 370 encode_str (enc, upgrade_utf8, utf8, str, len);
345} 371}
346 372
373ecb_inline void
374encode_float16 (enc_t *enc, NV nv)
375{
376 need (enc, 1+2);
377
378 *enc->cur++ = MAJOR_MISC | MISC_FLOAT16;
379
380 uint16_t fp = ecb_float_to_binary16 (nv);
381
382 if (!ecb_big_endian ())
383 fp = ecb_bswap16 (fp);
384
385 memcpy (enc->cur, &fp, 2);
386 enc->cur += 2;
387}
388
389ecb_inline void
390encode_float32 (enc_t *enc, NV nv)
391{
392 need (enc, 1+4);
393
394 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
395
396 uint32_t fp = ecb_float_to_binary32 (nv);
397
398 if (!ecb_big_endian ())
399 fp = ecb_bswap32 (fp);
400
401 memcpy (enc->cur, &fp, 4);
402 enc->cur += 4;
403}
404
405ecb_inline void
406encode_float64 (enc_t *enc, NV nv)
407{
408 need (enc, 1+8);
409
410 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
411
412 uint64_t fp = ecb_double_to_binary64 (nv);
413
414 if (!ecb_big_endian ())
415 fp = ecb_bswap64 (fp);
416
417 memcpy (enc->cur, &fp, 8);
418 enc->cur += 8;
419}
420
421ecb_inline void
422encode_forced (enc_t *enc, UV type, SV *sv)
423{
424 switch (type)
425 {
426 case AS_CBOR:
427 {
428 STRLEN len;
429 char *str = SvPVbyte (sv, len);
430
431 need (enc, len);
432 memcpy (enc->cur, str, len);
433 enc->cur += len;
434 }
435 break;
436
437 case AS_BYTES:
438 {
439 STRLEN len;
440 char *str = SvPVbyte (sv, len);
441 encode_strref (enc, 0, 0, str, len);
442 }
443 break;
444
445 case AS_TEXT:
446 {
447 STRLEN len;
448 char *str = SvPVutf8 (sv, len);
449 encode_strref (enc, 1, 1, str, len);
450 }
451 break;
452
453 case AS_FLOAT16: encode_float16 (enc, SvNV (sv)); break;
454 case AS_FLOAT32: encode_float32 (enc, SvNV (sv)); break;
455 case AS_FLOAT64: encode_float64 (enc, SvNV (sv)); break;
456
457 default:
458 croak ("encountered malformed CBOR::XS::Tagged object");
459 }
460}
461
347static void encode_sv (enc_t *enc, SV *sv); 462static void encode_sv (enc_t *enc, SV *sv);
348 463
349static void 464static void
350encode_av (enc_t *enc, AV *av) 465encode_av (enc_t *enc, AV *av)
351{ 466{
… …
356 471
357 ++enc->depth; 472 ++enc->depth;
358 473
359 encode_uint (enc, MAJOR_ARRAY, len + 1); 474 encode_uint (enc, MAJOR_ARRAY, len + 1);
360 475
361 if (SvMAGICAL (av)) 476 if (ecb_expect_false (SvMAGICAL (av)))
362 for (i = 0; i <= len; ++i) 477 for (i = 0; i <= len; ++i)
363 { 478 {
364 SV **svp = av_fetch (av, i, 0); 479 SV **svp = av_fetch (av, i, 0);
365 encode_sv (enc, svp ? *svp : &PL_sv_undef); 480 encode_sv (enc, svp ? *svp : &PL_sv_undef);
366 } 481 }
… …
385 ++enc->depth; 500 ++enc->depth;
386 501
387 int pairs = hv_iterinit (hv); 502 int pairs = hv_iterinit (hv);
388 int mg = SvMAGICAL (hv); 503 int mg = SvMAGICAL (hv);
389 504
390 if (mg) 505 if (ecb_expect_false (mg))
391 encode_ch (enc, MAJOR_MAP | MINOR_INDEF); 506 encode_ch (enc, MAJOR_MAP | MINOR_INDEF);
392 else 507 else
393 encode_uint (enc, MAJOR_MAP, pairs); 508 encode_uint (enc, MAJOR_MAP, pairs);
394 509
395 while ((he = hv_iternext (hv))) 510 while ((he = hv_iternext (hv)))
… …
400 encode_strref (enc, enc->cbor.flags & (F_TEXT_KEYS | F_TEXT_STRINGS), HeKUTF8 (he), HeKEY (he), HeKLEN (he)); 515 encode_strref (enc, enc->cbor.flags & (F_TEXT_KEYS | F_TEXT_STRINGS), HeKUTF8 (he), HeKEY (he), HeKLEN (he));
401 516
402 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he)); 517 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he));
403 } 518 }
404 519
405 if (mg) 520 if (ecb_expect_false (mg))
406 encode_ch (enc, MAJOR_MISC | MINOR_INDEF); 521 encode_ch (enc, MAJOR_MISC | MINOR_INDEF);
407 522
408 --enc->depth; 523 --enc->depth;
409} 524}
410 525
… …
443 else if (stash == tagged_stash) 558 else if (stash == tagged_stash)
444 { 559 {
445 if (svt != SVt_PVAV) 560 if (svt != SVt_PVAV)
446 croak ("encountered CBOR::XS::Tagged object that isn't an array"); 561 croak ("encountered CBOR::XS::Tagged object that isn't an array");
447 562
563 switch (av_len ((AV *)sv))
564 {
565 case 2-1:
566 // actually a tagged value
448 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1))); 567 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1)));
449 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1)); 568 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1));
569 break;
570
571 case 3-1:
572 // a forced type [value, type, undef]
573 encode_forced (enc, SvUV (*av_fetch ((AV *)sv, 1, 1)), *av_fetch ((AV *)sv, 0, 1));
574 break;
575
576 default:
577 croak ("encountered malformed CBOR::XS::Tagged object");
578 }
450 579
451 return; 580 return;
452 } 581 }
453 } 582 }
454 583
455 if (ecb_expect_false (SvREFCNT (sv) > 1) 584 if (ecb_expect_false (SvREFCNT (sv) > 1)
456 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING)) 585 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING))
457 { 586 {
458 if (!enc->shareable) 587 if (ecb_expect_false (!enc->shareable))
459 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ()); 588 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ());
460 589
461 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1); 590 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1);
462 591
463 if (SvOK (*svp)) 592 if (SvOK (*svp))
… …
477 if (ecb_expect_false (SvOBJECT (sv))) 606 if (ecb_expect_false (SvOBJECT (sv)))
478 { 607 {
479 HV *stash = SvSTASH (sv); 608 HV *stash = SvSTASH (sv);
480 GV *method; 609 GV *method;
481 610
611 if (enc->cbor.flags & F_FORBID_OBJECTS)
612 croak ("encountered object '%s', but forbid_objects is enabled",
613 SvPV_nolen (sv_2mortal (newRV_inc (sv))));
482 if ((method = gv_fetchmethod_autoload (stash, "TO_CBOR", 0))) 614 else if ((method = gv_fetchmethod_autoload (stash, "TO_CBOR", 0)))
483 { 615 {
484 dSP; 616 dSP;
485 617
486 ENTER; SAVETMPS; 618 ENTER; SAVETMPS;
487 PUSHMARK (SP); 619 PUSHMARK (SP);
… …
506 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0) 638 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0)
507 { 639 {
508 dSP; 640 dSP;
509 641
510 ENTER; SAVETMPS; 642 ENTER; SAVETMPS;
511 SAVESTACK_POS ();
512 PUSHMARK (SP); 643 PUSHMARK (SP);
513 EXTEND (SP, 2); 644 EXTEND (SP, 2);
514 // we re-bless the reference to get overload and other niceties right 645 // we re-bless the reference to get overload and other niceties right
515 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash)); 646 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash));
516 PUSHs (sv_cbor); 647 PUSHs (sv_cbor);
… …
525 656
526 encode_tag (enc, CBOR_TAG_PERL_OBJECT); 657 encode_tag (enc, CBOR_TAG_PERL_OBJECT);
527 encode_uint (enc, MAJOR_ARRAY, count + 1); 658 encode_uint (enc, MAJOR_ARRAY, count + 1);
528 encode_strref (enc, 0, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash)); 659 encode_strref (enc, 0, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash));
529 660
530 while (count) 661 {
662 int i;
663
664 for (i = 0; i < count; ++i)
531 encode_sv (enc, SP[1 - count--]); 665 encode_sv (enc, SP[i + 1 - count]);
666
667 SP -= count;
668 }
532 669
533 PUTBACK; 670 PUTBACK;
534 671
535 FREETMPS; LEAVE; 672 FREETMPS; LEAVE;
536 } 673 }
… …
558 695
559 if (ecb_expect_false (nv == (NV)(U32)nv)) 696 if (ecb_expect_false (nv == (NV)(U32)nv))
560 encode_uint (enc, MAJOR_POS_INT, (U32)nv); 697 encode_uint (enc, MAJOR_POS_INT, (U32)nv);
561 //TODO: maybe I32? 698 //TODO: maybe I32?
562 else if (ecb_expect_false (nv == (float)nv)) 699 else if (ecb_expect_false (nv == (float)nv))
563 { 700 encode_float32 (enc, nv);
564 uint32_t fp = ecb_float_to_binary32 (nv);
565
566 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
567
568 if (!ecb_big_endian ())
569 fp = ecb_bswap32 (fp);
570
571 memcpy (enc->cur, &fp, 4);
572 enc->cur += 4;
573 }
574 else 701 else
575 { 702 encode_float64 (enc, nv);
576 uint64_t fp = ecb_double_to_binary64 (nv);
577
578 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
579
580 if (!ecb_big_endian ())
581 fp = ecb_bswap64 (fp);
582
583 memcpy (enc->cur, &fp, 8);
584 enc->cur += 8;
585 }
586} 703}
587 704
588static void 705static void
589encode_sv (enc_t *enc, SV *sv) 706encode_sv (enc_t *enc, SV *sv)
590{ 707{
… …
597 encode_strref (enc, enc->cbor.flags & F_TEXT_STRINGS, SvUTF8 (sv), str, len); 714 encode_strref (enc, enc->cbor.flags & F_TEXT_STRINGS, SvUTF8 (sv), str, len);
598 } 715 }
599 else if (SvNOKp (sv)) 716 else if (SvNOKp (sv))
600 encode_nv (enc, sv); 717 encode_nv (enc, sv);
601 else if (SvIOKp (sv)) 718 else if (SvIOKp (sv))
602 { 719 encode_int (e,v sv);
603 if (SvIsUV (sv))
604 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
605 else if (SvIVX (sv) >= 0)
606 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
607 else
608 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
609 }
610 else if (SvROK (sv)) 720 else if (SvROK (sv))
611 encode_rv (enc, SvRV (sv)); 721 encode_rv (enc, SvRV (sv));
612 else if (!SvOK (sv)) 722 else if (!SvOK (sv))
613 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL); 723 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL);
614 else if (enc->cbor.flags & F_ALLOW_UNKNOWN) 724 else if (enc->cbor.flags & F_ALLOW_UNKNOWN)
… …
621static SV * 731static SV *
622encode_cbor (SV *scalar, CBOR *cbor) 732encode_cbor (SV *scalar, CBOR *cbor)
623{ 733{
624 enc_t enc = { 0 }; 734 enc_t enc = { 0 };
625 735
626 enc.cbor = *cbor; 736 enc.cbor = *cbor;
627 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE)); 737 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE));
628 enc.cur = SvPVX (enc.sv); 738 enc.cur = SvPVX (enc.sv);
629 enc.end = SvEND (enc.sv); 739 enc.end = SvEND (enc.sv);
630 740
631 SvPOK_only (enc.sv); 741 SvPOK_only (enc.sv);
632 742
633 if (cbor->flags & F_PACK_STRINGS) 743 if (cbor->flags & F_PACK_STRINGS)
634 { 744 {
… …
661 U32 depth; // recursion depth 771 U32 depth; // recursion depth
662 U32 maxdepth; // recursion depth limit 772 U32 maxdepth; // recursion depth limit
663 AV *shareable; 773 AV *shareable;
664 AV *stringref; 774 AV *stringref;
665 SV *decode_tagged; 775 SV *decode_tagged;
776 SV *err_sv; // optional sv for error, needs to be freed
666} dec_t; 777} dec_t;
667 778
668#define ERR(reason) SB if (!dec->err) dec->err = reason; goto fail; SE 779// set dec->err to ERRSV
780ecb_cold static void
781err_errsv (dec_t *dec)
782{
783 if (!dec->err)
784 {
785 dec->err_sv = newSVsv (ERRSV);
669 786
670#define WANT(len) if (ecb_expect_false (dec->cur + len > dec->end)) ERR ("unexpected end of CBOR data") 787 // chop off the trailing \n
788 SvCUR_set (dec->err_sv, SvCUR (dec->err_sv) - 1);
789 *SvEND (dec->err_sv) = 0;
671 790
791 dec->err = SvPVutf8_nolen (dec->err_sv);
792 }
793}
794
795// the following functions are used to reduce code size and help the compiler to optimise
796ecb_cold static void
797err_set (dec_t *dec, const char *reason)
798{
799 if (!dec->err)
800 dec->err = reason;
801}
802
803ecb_cold static void
804err_unexpected_end (dec_t *dec)
805{
806 err_set (dec, "unexpected end of CBOR data");
807}
808
809#define ERR_DO(do) SB do; goto fail; SE
810#define ERR(reason) ERR_DO (err_set (dec, reason))
811#define ERR_ERRSV ERR_DO (err_errsv (dec))
812
813#define WANT(len) if (ecb_expect_false ((uintptr_t)(dec->end - dec->cur) < (STRLEN)len)) ERR_DO (err_unexpected_end (dec))
814
672#define DEC_INC_DEPTH if (++dec->depth > dec->cbor.max_depth) ERR (ERR_NESTING_EXCEEDED) 815#define DEC_INC_DEPTH if (ecb_expect_false (++dec->depth > dec->cbor.max_depth)) ERR (ERR_NESTING_EXCEEDED)
673#define DEC_DEC_DEPTH --dec->depth 816#define DEC_DEC_DEPTH --dec->depth
674 817
675static UV 818static UV
676decode_uint (dec_t *dec) 819decode_uint (dec_t *dec)
677{ 820{
… …
743 886
744 for (;;) 887 for (;;)
745 { 888 {
746 WANT (1); 889 WANT (1);
747 890
748 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 891 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
749 { 892 {
750 ++dec->cur; 893 ++dec->cur;
751 break; 894 break;
752 } 895 }
753 896
754 av_push (av, decode_sv (dec)); 897 av_push (av, decode_sv (dec));
755 } 898 }
756 } 899 }
757 else 900 else
758 { 901 {
759 int i, len = decode_uint (dec); 902 UV i, len = decode_uint (dec);
760 903
761 WANT (len); // complexity check for av_fill - need at least one byte per value, do not allow supersize arrays 904 WANT (len); // complexity check for av_fill - need at least one byte per value, do not allow supersize arrays
762 av_fill (av, len - 1); 905 av_fill (av, len - 1);
763 906
764 for (i = 0; i < len; ++i) 907 for (i = 0; i < len; ++i)
… …
767 910
768 DEC_DEC_DEPTH; 911 DEC_DEC_DEPTH;
769 return newRV_noinc ((SV *)av); 912 return newRV_noinc ((SV *)av);
770 913
771fail: 914fail:
772 SvREFCNT_dec (av); 915 SvREFCNT_dec_NN (av);
773 DEC_DEC_DEPTH; 916 DEC_DEC_DEPTH;
774 return &PL_sv_undef; 917 return &PL_sv_undef;
775} 918}
776 919
777static void 920static void
… …
781 // byte or utf-8 strings as keys, but only when !stringref 924 // byte or utf-8 strings as keys, but only when !stringref
782 925
783 if (ecb_expect_true (!dec->stringref)) 926 if (ecb_expect_true (!dec->stringref))
784 if (ecb_expect_true ((U8)(*dec->cur - MAJOR_BYTES) <= LENGTH_EXT8)) 927 if (ecb_expect_true ((U8)(*dec->cur - MAJOR_BYTES) <= LENGTH_EXT8))
785 { 928 {
786 I32 len = decode_uint (dec); 929 STRLEN len = decode_uint (dec);
787 char *key = (char *)dec->cur; 930 char *key = (char *)dec->cur;
788 931
789 WANT (len); 932 WANT (len);
790 dec->cur += len; 933 dec->cur += len;
791 934
… …
793 936
794 return; 937 return;
795 } 938 }
796 else if (ecb_expect_true ((U8)(*dec->cur - MAJOR_TEXT) <= LENGTH_EXT8)) 939 else if (ecb_expect_true ((U8)(*dec->cur - MAJOR_TEXT) <= LENGTH_EXT8))
797 { 940 {
798 I32 len = decode_uint (dec); 941 STRLEN len = decode_uint (dec);
799 char *key = (char *)dec->cur; 942 char *key = (char *)dec->cur;
800 943
801 WANT (len); 944 WANT (len);
802 dec->cur += len; 945 dec->cur += len;
803 946
… …
811 } 954 }
812 955
813 SV *k = decode_sv (dec); 956 SV *k = decode_sv (dec);
814 SV *v = decode_sv (dec); 957 SV *v = decode_sv (dec);
815 958
959 // we leak memory if uncaught exceptions are thrown by random magical
960 // methods, and this is hopefully the only place where it can happen,
961 // so if there is a chance of an exception, take the very slow path.
962 // since catching exceptions is "undocumented/internal/forbidden" by
963 // the new p5p powers, we need to call out to a perl function :/
964 if (ecb_expect_false (SvAMAGIC (k)))
965 {
966 dSP;
967
968 ENTER; SAVETMPS;
969 PUSHMARK (SP);
970 EXTEND (SP, 3);
971 PUSHs (sv_2mortal (newRV_inc ((SV *)hv)));
972 PUSHs (sv_2mortal (k));
973 PUSHs (sv_2mortal (v));
974
975 PUTBACK;
976 call_pv ("CBOR::XS::_hv_store", G_VOID | G_DISCARD | G_EVAL);
977 SPAGAIN;
978
979 FREETMPS; LEAVE;
980
981 if (SvTRUE (ERRSV))
982 ERR_ERRSV;
983
984 return;
985 }
986
816 hv_store_ent (hv, k, v, 0); 987 hv_store_ent (hv, k, v, 0);
817 SvREFCNT_dec (k); 988 SvREFCNT_dec_NN (k);
818 989
819fail: 990fail:
820 ; 991 ;
821} 992}
822 993
… …
833 1004
834 for (;;) 1005 for (;;)
835 { 1006 {
836 WANT (1); 1007 WANT (1);
837 1008
838 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 1009 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
839 { 1010 {
840 ++dec->cur; 1011 ++dec->cur;
841 break; 1012 break;
842 } 1013 }
843 1014
844 decode_he (dec, hv); 1015 decode_he (dec, hv);
845 } 1016 }
846 } 1017 }
847 else 1018 else
848 { 1019 {
849 int pairs = decode_uint (dec); 1020 UV pairs = decode_uint (dec);
1021
1022 WANT (pairs); // complexity check - need at least one byte per value, do not allow supersize hashes
850 1023
851 while (pairs--) 1024 while (pairs--)
852 decode_he (dec, hv); 1025 decode_he (dec, hv);
853 } 1026 }
854 1027
855 DEC_DEC_DEPTH; 1028 DEC_DEC_DEPTH;
856 return newRV_noinc ((SV *)hv); 1029 return newRV_noinc ((SV *)hv);
857 1030
858fail: 1031fail:
859 SvREFCNT_dec (hv); 1032 SvREFCNT_dec_NN (hv);
860 DEC_DEC_DEPTH; 1033 DEC_DEC_DEPTH;
861 return &PL_sv_undef; 1034 return &PL_sv_undef;
862} 1035}
863 1036
864static SV * 1037static SV *
865decode_str (dec_t *dec, int utf8) 1038decode_str (dec_t *dec, int utf8)
866{ 1039{
867 SV *sv = 0; 1040 SV *sv = 0;
868 1041
869 if ((*dec->cur & MINOR_MASK) == MINOR_INDEF) 1042 if (ecb_expect_false ((*dec->cur & MINOR_MASK) == MINOR_INDEF))
870 { 1043 {
871 // indefinite length strings 1044 // indefinite length strings
872 ++dec->cur; 1045 ++dec->cur;
873 1046
874 U8 major = *dec->cur & MAJOR_MISC; 1047 U8 major = *dec->cur & MAJOR_MISC;
… …
942 sv = newRV_noinc (decode_sv (dec)); 1115 sv = newRV_noinc (decode_sv (dec));
943 break; 1116 break;
944 1117
945 case CBOR_TAG_STRINGREF_NAMESPACE: 1118 case CBOR_TAG_STRINGREF_NAMESPACE:
946 { 1119 {
947 // do nmot use SAVETMPS/FREETMPS, as these will 1120 // do not use SAVETMPS/FREETMPS, as these will
948 // erase mortalised caches, e.g. "shareable" 1121 // erase mortalised caches, e.g. "shareable"
949 ENTER; 1122 ENTER;
950 1123
951 SAVESPTR (dec->stringref); 1124 SAVESPTR (dec->stringref);
952 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ()); 1125 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ());
… …
962 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1135 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
963 ERR ("corrupted CBOR data (stringref index not an unsigned integer)"); 1136 ERR ("corrupted CBOR data (stringref index not an unsigned integer)");
964 1137
965 UV idx = decode_uint (dec); 1138 UV idx = decode_uint (dec);
966 1139
967 if (!dec->stringref || (int)idx > AvFILLp (dec->stringref)) 1140 if (!dec->stringref || idx >= (UV)(1 + AvFILLp (dec->stringref)))
968 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)"); 1141 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)");
969 1142
970 sv = newSVsv (AvARRAY (dec->stringref)[idx]); 1143 sv = newSVsv (AvARRAY (dec->stringref)[idx]);
971 } 1144 }
972 break; 1145 break;
… …
1000 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1173 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
1001 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)"); 1174 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)");
1002 1175
1003 UV idx = decode_uint (dec); 1176 UV idx = decode_uint (dec);
1004 1177
1005 if (!dec->shareable || (int)idx > AvFILLp (dec->shareable)) 1178 if (!dec->shareable || idx >= (UV)(1 + AvFILLp (dec->shareable)))
1006 ERR ("corrupted CBOR data (sharedref index out of bounds)"); 1179 ERR ("corrupted CBOR data (sharedref index out of bounds)");
1007 1180
1008 sv = SvREFCNT_inc_NN (AvARRAY (dec->shareable)[idx]); 1181 sv = SvREFCNT_inc_NN (AvARRAY (dec->shareable)[idx]);
1009 1182
1010 if (sv == &PL_sv_undef) 1183 if (sv == &PL_sv_undef)
… …
1012 } 1185 }
1013 break; 1186 break;
1014 1187
1015 case CBOR_TAG_PERL_OBJECT: 1188 case CBOR_TAG_PERL_OBJECT:
1016 { 1189 {
1190 if (dec->cbor.flags & F_FORBID_OBJECTS)
1191 goto filter;
1192
1017 sv = decode_sv (dec); 1193 sv = decode_sv (dec);
1018 1194
1019 if (!SvROK (sv) || SvTYPE (SvRV (sv)) != SVt_PVAV) 1195 if (!SvROK (sv) || SvTYPE (SvRV (sv)) != SVt_PVAV)
1020 ERR ("corrupted CBOR data (non-array perl object)"); 1196 ERR ("corrupted CBOR data (non-array perl object)");
1021 1197
… …
1050 SPAGAIN; 1226 SPAGAIN;
1051 1227
1052 if (SvTRUE (ERRSV)) 1228 if (SvTRUE (ERRSV))
1053 { 1229 {
1054 FREETMPS; LEAVE; 1230 FREETMPS; LEAVE;
1055 ERR (SvPVutf8_nolen (sv_2mortal (SvREFCNT_inc (ERRSV)))); 1231 ERR_ERRSV;
1056 } 1232 }
1057 1233
1058 SvREFCNT_dec (sv); 1234 SvREFCNT_dec_NN (sv);
1059 sv = SvREFCNT_inc (POPs); 1235 sv = SvREFCNT_inc (POPs);
1060 1236
1061 PUTBACK; 1237 PUTBACK;
1062 1238
1063 FREETMPS; LEAVE; 1239 FREETMPS; LEAVE;
1064 } 1240 }
1065 break; 1241 break;
1066 1242
1067 default: 1243 default:
1244 filter:
1068 { 1245 {
1246 SV *tag_sv = newSVuv (tag);
1247
1069 sv = decode_sv (dec); 1248 sv = decode_sv (dec);
1070 1249
1071 dSP; 1250 dSP;
1072 ENTER; SAVETMPS; 1251 ENTER; SAVETMPS;
1073 SAVESTACK_POS ();
1074 PUSHMARK (SP); 1252 PUSHMARK (SP);
1075 EXTEND (SP, 2); 1253 EXTEND (SP, 2);
1076 PUSHs (newSVuv (tag)); 1254 PUSHs (tag_sv);
1077 PUSHs (sv); 1255 PUSHs (sv);
1078 1256
1079 PUTBACK; 1257 PUTBACK;
1080 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL); 1258 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL);
1081 SPAGAIN; 1259 SPAGAIN;
1082 1260
1083 if (SvTRUE (ERRSV)) 1261 if (SvTRUE (ERRSV))
1084 { 1262 {
1263 SvREFCNT_dec_NN (tag_sv);
1085 FREETMPS; LEAVE; 1264 FREETMPS; LEAVE;
1086 ERR (SvPVutf8_nolen (sv_2mortal (SvREFCNT_inc (ERRSV)))); 1265 ERR_ERRSV;
1087 } 1266 }
1088 1267
1089 if (count) 1268 if (count)
1090 { 1269 {
1270 SvREFCNT_dec_NN (tag_sv);
1091 SvREFCNT_dec (sv); 1271 SvREFCNT_dec_NN (sv);
1092 sv = SvREFCNT_inc (POPs); 1272 sv = SvREFCNT_inc_NN (TOPs);
1273 SP -= count;
1093 } 1274 }
1094 else 1275 else
1095 { 1276 {
1096 AV *av = newAV (); 1277 AV *av = newAV ();
1097 av_push (av, newSVuv (tag)); 1278 av_push (av, tag_sv);
1098 av_push (av, sv); 1279 av_push (av, sv);
1099 1280
1100 HV *tagged_stash = !CBOR_SLOW || cbor_tagged_stash 1281 HV *tagged_stash = !CBOR_SLOW || cbor_tagged_stash
1101 ? cbor_tagged_stash 1282 ? cbor_tagged_stash
1102 : gv_stashpv ("CBOR::XS::Tagged" , 1); 1283 : gv_stashpv ("CBOR::XS::Tagged" , 1);
… …
1231 1412
1232 if (dec.err) 1413 if (dec.err)
1233 { 1414 {
1234 if (dec.shareable) 1415 if (dec.shareable)
1235 { 1416 {
1236 // need to break cyclic links, which whould all be in shareable 1417 // need to break cyclic links, which would all be in shareable
1237 int i; 1418 int i;
1238 SV **svp; 1419 SV **svp;
1239 1420
1240 for (i = av_len (dec.shareable) + 1; i--; ) 1421 for (i = av_len (dec.shareable) + 1; i--; )
1241 if ((svp = av_fetch (dec.shareable, i, 0))) 1422 if ((svp = av_fetch (dec.shareable, i, 0)))
1242 sv_setsv (*svp, &PL_sv_undef); 1423 sv_setsv (*svp, &PL_sv_undef);
1243 } 1424 }
1244 1425
1245 SvREFCNT_dec (sv); 1426 SvREFCNT_dec_NN (sv);
1427
1428 if (dec.err_sv)
1429 sv_2mortal (dec.err_sv);
1430
1246 croak ("%s, at offset %d (octet 0x%02x)", dec.err, dec.cur - (U8 *)data, (int)(uint8_t)*dec.cur); 1431 croak ("%s, at offset %d (octet 0x%02x)", dec.err, dec.cur - (U8 *)data, (int)(uint8_t)*dec.cur);
1247 } 1432 }
1248 1433
1249 sv = sv_2mortal (sv); 1434 sv = sv_2mortal (sv);
1250 1435
… …
1394 1579
1395 default_filter = newSVpv ("CBOR::XS::default_filter", 0); 1580 default_filter = newSVpv ("CBOR::XS::default_filter", 0);
1396 1581
1397 sv_cbor = newSVpv ("CBOR", 0); 1582 sv_cbor = newSVpv ("CBOR", 0);
1398 SvREADONLY_on (sv_cbor); 1583 SvREADONLY_on (sv_cbor);
1584
1585 assert (("STRLEN must be an unsigned type", 0 <= (STRLEN)-1));
1399} 1586}
1400 1587
1401PROTOTYPES: DISABLE 1588PROTOTYPES: DISABLE
1402 1589
1403void CLONE (...) 1590void CLONE (...)
… …
1423 ALIAS: 1610 ALIAS:
1424 shrink = F_SHRINK 1611 shrink = F_SHRINK
1425 allow_unknown = F_ALLOW_UNKNOWN 1612 allow_unknown = F_ALLOW_UNKNOWN
1426 allow_sharing = F_ALLOW_SHARING 1613 allow_sharing = F_ALLOW_SHARING
1427 allow_cycles = F_ALLOW_CYCLES 1614 allow_cycles = F_ALLOW_CYCLES
1615 forbid_objects = F_FORBID_OBJECTS
1428 pack_strings = F_PACK_STRINGS 1616 pack_strings = F_PACK_STRINGS
1429 text_keys = F_TEXT_KEYS 1617 text_keys = F_TEXT_KEYS
1430 text_strings = F_TEXT_STRINGS 1618 text_strings = F_TEXT_STRINGS
1431 validate_utf8 = F_VALIDATE_UTF8 1619 validate_utf8 = F_VALIDATE_UTF8
1432 PPCODE: 1620 PPCODE:
… …
1443 ALIAS: 1631 ALIAS:
1444 get_shrink = F_SHRINK 1632 get_shrink = F_SHRINK
1445 get_allow_unknown = F_ALLOW_UNKNOWN 1633 get_allow_unknown = F_ALLOW_UNKNOWN
1446 get_allow_sharing = F_ALLOW_SHARING 1634 get_allow_sharing = F_ALLOW_SHARING
1447 get_allow_cycles = F_ALLOW_CYCLES 1635 get_allow_cycles = F_ALLOW_CYCLES
1636 get_forbid_objects = F_FORBID_OBJECTS
1448 get_pack_strings = F_PACK_STRINGS 1637 get_pack_strings = F_PACK_STRINGS
1449 get_text_keys = F_TEXT_KEYS 1638 get_text_keys = F_TEXT_KEYS
1450 get_text_strings = F_TEXT_STRINGS 1639 get_text_strings = F_TEXT_STRINGS
1451 get_validate_utf8 = F_VALIDATE_UTF8 1640 get_validate_utf8 = F_VALIDATE_UTF8
1452 PPCODE: 1641 PPCODE:
… …
1585 cbor_init (&cbor); 1774 cbor_init (&cbor);
1586 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN; 1775 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN;
1587 XPUSHs (cborstr); 1776 XPUSHs (cborstr);
1588} 1777}
1589 1778
1779#ifdef __AFL_COMPILER
1780
1781void
1782afl_init ()
1783 CODE:
1784 __AFL_INIT ();
1785
1786int
1787afl_loop (unsigned int count = 10000)
1788 CODE:
1789 RETVAL = __AFL_LOOP (count);
1790 OUTPUT:
1791 RETVAL
1792
1793#endif
1794

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines