ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/CBOR-XS/XS.xs
(Generate patch)

Comparing CBOR-XS/XS.xs (file contents):
Revision 1.60 by root, Sat Nov 26 00:47:02 2016 UTC vs.
Revision 1.66 by root, Sun Nov 29 21:32:01 2020 UTC

… …
6#include <string.h> 6#include <string.h>
7#include <stdlib.h> 7#include <stdlib.h>
8#include <stdio.h> 8#include <stdio.h>
9#include <limits.h> 9#include <limits.h>
10#include <float.h> 10#include <float.h>
11#include <inttypes.h>
11 12
12#define ECB_NO_THREADS 1 13#define ECB_NO_THREADS 1
13#include "ecb.h" 14#include "ecb.h"
14 15
15// compatibility with perl <5.18 16// compatibility with perl <5.18
… …
20# define HvNAMELEN(hv) HvNAMELEN_get (hv) 21# define HvNAMELEN(hv) HvNAMELEN_get (hv)
21#endif 22#endif
22#ifndef HvNAMEUTF8 23#ifndef HvNAMEUTF8
23# define HvNAMEUTF8(hv) 0 24# define HvNAMEUTF8(hv) 0
24#endif 25#endif
26#ifndef SvREFCNT_inc_NN
27# define SvREFCNT_inc_NN(sv) SvREFCNT_inc (sv)
28#endif
25#ifndef SvREFCNT_dec_NN 29#ifndef SvREFCNT_dec_NN
26# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv) 30# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv)
27#endif 31#endif
28 32
29// known major and minor types 33// known major and minor types
… …
93 CBOR_TAG_B64 = 34, // base6 rfc46484, utf-8 97 CBOR_TAG_B64 = 34, // base6 rfc46484, utf-8
94 CBOR_TAG_REGEX = 35, // regex pcre/ecma262, utf-8 98 CBOR_TAG_REGEX = 35, // regex pcre/ecma262, utf-8
95 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8 99 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8
96 100
97 CBOR_TAG_MAGIC = 55799, // self-describe cbor 101 CBOR_TAG_MAGIC = 55799, // self-describe cbor
102};
103
104// known forced types, also hardcoded in CBOR.pm
105enum
106{
107 AS_CBOR = 0,
108 AS_BYTES = 1,
109 AS_TEXT = 2,
110 AS_FLOAT16 = 3,
111 AS_FLOAT32 = 4,
112 AS_FLOAT64 = 5,
113 // possibly future enhancements: float, integer
98}; 114};
99 115
100#define F_SHRINK 0x00000001UL 116#define F_SHRINK 0x00000001UL
101#define F_ALLOW_UNKNOWN 0x00000002UL 117#define F_ALLOW_UNKNOWN 0x00000002UL
102#define F_ALLOW_SHARING 0x00000004UL 118#define F_ALLOW_SHARING 0x00000004UL
… …
186 202
187// minimum length of a string to be registered for stringref 203// minimum length of a string to be registered for stringref
188ecb_inline int 204ecb_inline int
189minimum_string_length (UV idx) 205minimum_string_length (UV idx)
190{ 206{
191 return idx > 23 207 return idx <= 23 ? 3
192 ? idx > 0xffU 208 : idx <= 0xffU ? 4
193 ? idx > 0xffffU 209 : idx <= 0xffffU ? 5
194 ? idx > 0xffffffffU 210 : idx <= 0xffffffffU ? 7
195 ? 11 211 : 11;
196 : 7
197 : 5
198 : 4
199 : 3;
200} 212}
201 213
202///////////////////////////////////////////////////////////////////////////// 214/////////////////////////////////////////////////////////////////////////////
203// encoder 215// encoder
204 216
… …
217} enc_t; 229} enc_t;
218 230
219ecb_inline void 231ecb_inline void
220need (enc_t *enc, STRLEN len) 232need (enc_t *enc, STRLEN len)
221{ 233{
222 if (ecb_expect_false (enc->cur + len >= enc->end)) 234 if (ecb_expect_false ((uintptr_t)(enc->end - enc->cur) < len))
223 { 235 {
224 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv); 236 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv);
225 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1); 237 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1);
226 enc->cur = SvPVX (enc->sv) + cur; 238 enc->cur = SvPVX (enc->sv) + cur;
227 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1; 239 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1;
… …
233{ 245{
234 need (enc, 1); 246 need (enc, 1);
235 *enc->cur++ = ch; 247 *enc->cur++ = ch;
236} 248}
237 249
250// used for tags, intregers, element counts and so on
238static void 251static void
239encode_uint (enc_t *enc, int major, UV len) 252encode_uint (enc_t *enc, int major, UV len)
240{ 253{
241 need (enc, 9); 254 need (enc, 9);
242 255
… …
273 *enc->cur++ = len >> 8; 286 *enc->cur++ = len >> 8;
274 *enc->cur++ = len; 287 *enc->cur++ = len;
275 } 288 }
276} 289}
277 290
291// encodes a perl value into a CBOR integer
292ecb_inline
293encode_int (enc_t *enc, SV *sv)
294{
295 if (SvIsUV (sv))
296 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
297 else if (SvIVX (sv) >= 0)
298 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
299 else
300 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
301}
302
278ecb_inline void 303ecb_inline void
279encode_tag (enc_t *enc, UV tag) 304encode_tag (enc_t *enc, UV tag)
280{ 305{
281 encode_uint (enc, MAJOR_TAG, tag); 306 encode_uint (enc, MAJOR_TAG, tag);
282} 307}
… …
343 } 368 }
344 369
345 encode_str (enc, upgrade_utf8, utf8, str, len); 370 encode_str (enc, upgrade_utf8, utf8, str, len);
346} 371}
347 372
373ecb_inline void
374encode_float16 (enc_t *enc, NV nv)
375{
376 need (enc, 1+2);
377
378 *enc->cur++ = MAJOR_MISC | MISC_FLOAT16;
379
380 uint16_t fp = ecb_float_to_binary16 (nv);
381
382 if (!ecb_big_endian ())
383 fp = ecb_bswap16 (fp);
384
385 memcpy (enc->cur, &fp, 2);
386 enc->cur += 2;
387}
388
389ecb_inline void
390encode_float32 (enc_t *enc, NV nv)
391{
392 need (enc, 1+4);
393
394 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
395
396 uint32_t fp = ecb_float_to_binary32 (nv);
397
398 if (!ecb_big_endian ())
399 fp = ecb_bswap32 (fp);
400
401 memcpy (enc->cur, &fp, 4);
402 enc->cur += 4;
403}
404
405ecb_inline void
406encode_float64 (enc_t *enc, NV nv)
407{
408 need (enc, 1+8);
409
410 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
411
412 uint64_t fp = ecb_double_to_binary64 (nv);
413
414 if (!ecb_big_endian ())
415 fp = ecb_bswap64 (fp);
416
417 memcpy (enc->cur, &fp, 8);
418 enc->cur += 8;
419}
420
421ecb_inline void
422encode_forced (enc_t *enc, UV type, SV *sv)
423{
424 switch (type)
425 {
426 case AS_CBOR:
427 {
428 STRLEN len;
429 char *str = SvPVbyte (sv, len);
430
431 need (enc, len);
432 memcpy (enc->cur, str, len);
433 enc->cur += len;
434 }
435 break;
436
437 case AS_BYTES:
438 {
439 STRLEN len;
440 char *str = SvPVbyte (sv, len);
441 encode_strref (enc, 0, 0, str, len);
442 }
443 break;
444
445 case AS_TEXT:
446 {
447 STRLEN len;
448 char *str = SvPVutf8 (sv, len);
449 encode_strref (enc, 1, 1, str, len);
450 }
451 break;
452
453 case AS_FLOAT16: encode_float16 (enc, SvNV (sv)); break;
454 case AS_FLOAT32: encode_float32 (enc, SvNV (sv)); break;
455 case AS_FLOAT64: encode_float64 (enc, SvNV (sv)); break;
456
457 default:
458 croak ("encountered malformed CBOR::XS::Tagged object");
459 }
460}
461
348static void encode_sv (enc_t *enc, SV *sv); 462static void encode_sv (enc_t *enc, SV *sv);
349 463
350static void 464static void
351encode_av (enc_t *enc, AV *av) 465encode_av (enc_t *enc, AV *av)
352{ 466{
… …
357 471
358 ++enc->depth; 472 ++enc->depth;
359 473
360 encode_uint (enc, MAJOR_ARRAY, len + 1); 474 encode_uint (enc, MAJOR_ARRAY, len + 1);
361 475
362 if (SvMAGICAL (av)) 476 if (ecb_expect_false (SvMAGICAL (av)))
363 for (i = 0; i <= len; ++i) 477 for (i = 0; i <= len; ++i)
364 { 478 {
365 SV **svp = av_fetch (av, i, 0); 479 SV **svp = av_fetch (av, i, 0);
366 encode_sv (enc, svp ? *svp : &PL_sv_undef); 480 encode_sv (enc, svp ? *svp : &PL_sv_undef);
367 } 481 }
… …
386 ++enc->depth; 500 ++enc->depth;
387 501
388 int pairs = hv_iterinit (hv); 502 int pairs = hv_iterinit (hv);
389 int mg = SvMAGICAL (hv); 503 int mg = SvMAGICAL (hv);
390 504
391 if (mg) 505 if (ecb_expect_false (mg))
392 encode_ch (enc, MAJOR_MAP | MINOR_INDEF); 506 encode_ch (enc, MAJOR_MAP | MINOR_INDEF);
393 else 507 else
394 encode_uint (enc, MAJOR_MAP, pairs); 508 encode_uint (enc, MAJOR_MAP, pairs);
395 509
396 while ((he = hv_iternext (hv))) 510 while ((he = hv_iternext (hv)))
… …
401 encode_strref (enc, enc->cbor.flags & (F_TEXT_KEYS | F_TEXT_STRINGS), HeKUTF8 (he), HeKEY (he), HeKLEN (he)); 515 encode_strref (enc, enc->cbor.flags & (F_TEXT_KEYS | F_TEXT_STRINGS), HeKUTF8 (he), HeKEY (he), HeKLEN (he));
402 516
403 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he)); 517 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he));
404 } 518 }
405 519
406 if (mg) 520 if (ecb_expect_false (mg))
407 encode_ch (enc, MAJOR_MISC | MINOR_INDEF); 521 encode_ch (enc, MAJOR_MISC | MINOR_INDEF);
408 522
409 --enc->depth; 523 --enc->depth;
410} 524}
411 525
… …
444 else if (stash == tagged_stash) 558 else if (stash == tagged_stash)
445 { 559 {
446 if (svt != SVt_PVAV) 560 if (svt != SVt_PVAV)
447 croak ("encountered CBOR::XS::Tagged object that isn't an array"); 561 croak ("encountered CBOR::XS::Tagged object that isn't an array");
448 562
563 switch (av_len ((AV *)sv))
564 {
565 case 2-1:
566 // actually a tagged value
449 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1))); 567 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1)));
450 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1)); 568 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1));
569 break;
570
571 case 3-1:
572 // a forced type [value, type, undef]
573 encode_forced (enc, SvUV (*av_fetch ((AV *)sv, 1, 1)), *av_fetch ((AV *)sv, 0, 1));
574 break;
575
576 default:
577 croak ("encountered malformed CBOR::XS::Tagged object");
578 }
451 579
452 return; 580 return;
453 } 581 }
454 } 582 }
455 583
456 if (ecb_expect_false (SvREFCNT (sv) > 1) 584 if (ecb_expect_false (SvREFCNT (sv) > 1)
457 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING)) 585 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING))
458 { 586 {
459 if (!enc->shareable) 587 if (ecb_expect_false (!enc->shareable))
460 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ()); 588 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ());
461 589
462 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1); 590 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1);
463 591
464 if (SvOK (*svp)) 592 if (SvOK (*svp))
… …
510 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0) 638 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0)
511 { 639 {
512 dSP; 640 dSP;
513 641
514 ENTER; SAVETMPS; 642 ENTER; SAVETMPS;
515 SAVESTACK_POS ();
516 PUSHMARK (SP); 643 PUSHMARK (SP);
517 EXTEND (SP, 2); 644 EXTEND (SP, 2);
518 // we re-bless the reference to get overload and other niceties right 645 // we re-bless the reference to get overload and other niceties right
519 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash)); 646 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash));
520 PUSHs (sv_cbor); 647 PUSHs (sv_cbor);
… …
529 656
530 encode_tag (enc, CBOR_TAG_PERL_OBJECT); 657 encode_tag (enc, CBOR_TAG_PERL_OBJECT);
531 encode_uint (enc, MAJOR_ARRAY, count + 1); 658 encode_uint (enc, MAJOR_ARRAY, count + 1);
532 encode_strref (enc, 0, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash)); 659 encode_strref (enc, 0, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash));
533 660
534 while (count) 661 {
662 int i;
663
664 for (i = 0; i < count; ++i)
535 encode_sv (enc, SP[1 - count--]); 665 encode_sv (enc, SP[i + 1 - count]);
666
667 SP -= count;
668 }
536 669
537 PUTBACK; 670 PUTBACK;
538 671
539 FREETMPS; LEAVE; 672 FREETMPS; LEAVE;
540 } 673 }
… …
562 695
563 if (ecb_expect_false (nv == (NV)(U32)nv)) 696 if (ecb_expect_false (nv == (NV)(U32)nv))
564 encode_uint (enc, MAJOR_POS_INT, (U32)nv); 697 encode_uint (enc, MAJOR_POS_INT, (U32)nv);
565 //TODO: maybe I32? 698 //TODO: maybe I32?
566 else if (ecb_expect_false (nv == (float)nv)) 699 else if (ecb_expect_false (nv == (float)nv))
567 { 700 encode_float32 (enc, nv);
568 uint32_t fp = ecb_float_to_binary32 (nv);
569
570 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
571
572 if (!ecb_big_endian ())
573 fp = ecb_bswap32 (fp);
574
575 memcpy (enc->cur, &fp, 4);
576 enc->cur += 4;
577 }
578 else 701 else
579 { 702 encode_float64 (enc, nv);
580 uint64_t fp = ecb_double_to_binary64 (nv);
581
582 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
583
584 if (!ecb_big_endian ())
585 fp = ecb_bswap64 (fp);
586
587 memcpy (enc->cur, &fp, 8);
588 enc->cur += 8;
589 }
590} 703}
591 704
592static void 705static void
593encode_sv (enc_t *enc, SV *sv) 706encode_sv (enc_t *enc, SV *sv)
594{ 707{
… …
601 encode_strref (enc, enc->cbor.flags & F_TEXT_STRINGS, SvUTF8 (sv), str, len); 714 encode_strref (enc, enc->cbor.flags & F_TEXT_STRINGS, SvUTF8 (sv), str, len);
602 } 715 }
603 else if (SvNOKp (sv)) 716 else if (SvNOKp (sv))
604 encode_nv (enc, sv); 717 encode_nv (enc, sv);
605 else if (SvIOKp (sv)) 718 else if (SvIOKp (sv))
606 { 719 encode_int (e,v sv);
607 if (SvIsUV (sv))
608 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
609 else if (SvIVX (sv) >= 0)
610 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
611 else
612 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
613 }
614 else if (SvROK (sv)) 720 else if (SvROK (sv))
615 encode_rv (enc, SvRV (sv)); 721 encode_rv (enc, SvRV (sv));
616 else if (!SvOK (sv)) 722 else if (!SvOK (sv))
617 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL); 723 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL);
618 else if (enc->cbor.flags & F_ALLOW_UNKNOWN) 724 else if (enc->cbor.flags & F_ALLOW_UNKNOWN)
… …
625static SV * 731static SV *
626encode_cbor (SV *scalar, CBOR *cbor) 732encode_cbor (SV *scalar, CBOR *cbor)
627{ 733{
628 enc_t enc = { 0 }; 734 enc_t enc = { 0 };
629 735
630 enc.cbor = *cbor; 736 enc.cbor = *cbor;
631 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE)); 737 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE));
632 enc.cur = SvPVX (enc.sv); 738 enc.cur = SvPVX (enc.sv);
633 enc.end = SvEND (enc.sv); 739 enc.end = SvEND (enc.sv);
634 740
635 SvPOK_only (enc.sv); 741 SvPOK_only (enc.sv);
636 742
637 if (cbor->flags & F_PACK_STRINGS) 743 if (cbor->flags & F_PACK_STRINGS)
638 { 744 {
… …
698err_unexpected_end (dec_t *dec) 804err_unexpected_end (dec_t *dec)
699{ 805{
700 err_set (dec, "unexpected end of CBOR data"); 806 err_set (dec, "unexpected end of CBOR data");
701} 807}
702 808
703ecb_cold static void
704err_nesting_exceeded (dec_t *dec)
705{
706 err_set (dec, ERR_NESTING_EXCEEDED);
707}
708
709#define ERR_DO(do) SB do; goto fail; SE 809#define ERR_DO(do) SB do; goto fail; SE
710#define ERR(reason) ERR_DO (err_set (dec, reason)) 810#define ERR(reason) ERR_DO (err_set (dec, reason))
711#define ERR_ERRSV ERR_DO (err_errsv (dec)) 811#define ERR_ERRSV ERR_DO (err_errsv (dec))
712 812
713#define WANT(len) if (ecb_expect_false ((UV)(dec->end - dec->cur) < (UV)len)) ERR_DO (err_unexpected_end (dec)) 813#define WANT(len) if (ecb_expect_false ((uintptr_t)(dec->end - dec->cur) < (STRLEN)len)) ERR_DO (err_unexpected_end (dec))
714 814
715#define DEC_INC_DEPTH if (ecb_expect_false (++dec->depth > dec->cbor.max_depth)) ERR (ERR_NESTING_EXCEEDED) 815#define DEC_INC_DEPTH if (ecb_expect_false (++dec->depth > dec->cbor.max_depth)) ERR (ERR_NESTING_EXCEEDED)
716#define DEC_DEC_DEPTH --dec->depth 816#define DEC_DEC_DEPTH --dec->depth
717 817
718static UV 818static UV
… …
786 886
787 for (;;) 887 for (;;)
788 { 888 {
789 WANT (1); 889 WANT (1);
790 890
791 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 891 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
792 { 892 {
793 ++dec->cur; 893 ++dec->cur;
794 break; 894 break;
795 } 895 }
796 896
… …
810 910
811 DEC_DEC_DEPTH; 911 DEC_DEC_DEPTH;
812 return newRV_noinc ((SV *)av); 912 return newRV_noinc ((SV *)av);
813 913
814fail: 914fail:
815 SvREFCNT_dec (av); 915 SvREFCNT_dec_NN (av);
816 DEC_DEC_DEPTH; 916 DEC_DEC_DEPTH;
817 return &PL_sv_undef; 917 return &PL_sv_undef;
818} 918}
819 919
820static void 920static void
… …
883 983
884 return; 984 return;
885 } 985 }
886 986
887 hv_store_ent (hv, k, v, 0); 987 hv_store_ent (hv, k, v, 0);
888 SvREFCNT_dec (k); 988 SvREFCNT_dec_NN (k);
889 989
890fail: 990fail:
891 ; 991 ;
892} 992}
893 993
… …
904 1004
905 for (;;) 1005 for (;;)
906 { 1006 {
907 WANT (1); 1007 WANT (1);
908 1008
909 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 1009 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
910 { 1010 {
911 ++dec->cur; 1011 ++dec->cur;
912 break; 1012 break;
913 } 1013 }
914 1014
… …
927 1027
928 DEC_DEC_DEPTH; 1028 DEC_DEC_DEPTH;
929 return newRV_noinc ((SV *)hv); 1029 return newRV_noinc ((SV *)hv);
930 1030
931fail: 1031fail:
932 SvREFCNT_dec (hv); 1032 SvREFCNT_dec_NN (hv);
933 DEC_DEC_DEPTH; 1033 DEC_DEC_DEPTH;
934 return &PL_sv_undef; 1034 return &PL_sv_undef;
935} 1035}
936 1036
937static SV * 1037static SV *
938decode_str (dec_t *dec, int utf8) 1038decode_str (dec_t *dec, int utf8)
939{ 1039{
940 SV *sv = 0; 1040 SV *sv = 0;
941 1041
942 if ((*dec->cur & MINOR_MASK) == MINOR_INDEF) 1042 if (ecb_expect_false ((*dec->cur & MINOR_MASK) == MINOR_INDEF))
943 { 1043 {
944 // indefinite length strings 1044 // indefinite length strings
945 ++dec->cur; 1045 ++dec->cur;
946 1046
947 U8 major = *dec->cur & MAJOR_MISC; 1047 U8 major = *dec->cur & MAJOR_MISC;
… …
1015 sv = newRV_noinc (decode_sv (dec)); 1115 sv = newRV_noinc (decode_sv (dec));
1016 break; 1116 break;
1017 1117
1018 case CBOR_TAG_STRINGREF_NAMESPACE: 1118 case CBOR_TAG_STRINGREF_NAMESPACE:
1019 { 1119 {
1020 // do nmot use SAVETMPS/FREETMPS, as these will 1120 // do not use SAVETMPS/FREETMPS, as these will
1021 // erase mortalised caches, e.g. "shareable" 1121 // erase mortalised caches, e.g. "shareable"
1022 ENTER; 1122 ENTER;
1023 1123
1024 SAVESPTR (dec->stringref); 1124 SAVESPTR (dec->stringref);
1025 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ()); 1125 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ());
… …
1035 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1135 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
1036 ERR ("corrupted CBOR data (stringref index not an unsigned integer)"); 1136 ERR ("corrupted CBOR data (stringref index not an unsigned integer)");
1037 1137
1038 UV idx = decode_uint (dec); 1138 UV idx = decode_uint (dec);
1039 1139
1040 if (!dec->stringref || (int)idx > AvFILLp (dec->stringref)) 1140 if (!dec->stringref || idx >= (UV)(1 + AvFILLp (dec->stringref)))
1041 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)"); 1141 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)");
1042 1142
1043 sv = newSVsv (AvARRAY (dec->stringref)[idx]); 1143 sv = newSVsv (AvARRAY (dec->stringref)[idx]);
1044 } 1144 }
1045 break; 1145 break;
… …
1073 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1173 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
1074 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)"); 1174 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)");
1075 1175
1076 UV idx = decode_uint (dec); 1176 UV idx = decode_uint (dec);
1077 1177
1078 if (!dec->shareable || (int)idx > AvFILLp (dec->shareable)) 1178 if (!dec->shareable || idx >= (UV)(1 + AvFILLp (dec->shareable)))
1079 ERR ("corrupted CBOR data (sharedref index out of bounds)"); 1179 ERR ("corrupted CBOR data (sharedref index out of bounds)");
1080 1180
1081 sv = SvREFCNT_inc_NN (AvARRAY (dec->shareable)[idx]); 1181 sv = SvREFCNT_inc_NN (AvARRAY (dec->shareable)[idx]);
1082 1182
1083 if (sv == &PL_sv_undef) 1183 if (sv == &PL_sv_undef)
… …
1129 { 1229 {
1130 FREETMPS; LEAVE; 1230 FREETMPS; LEAVE;
1131 ERR_ERRSV; 1231 ERR_ERRSV;
1132 } 1232 }
1133 1233
1134 SvREFCNT_dec (sv); 1234 SvREFCNT_dec_NN (sv);
1135 sv = SvREFCNT_inc (POPs); 1235 sv = SvREFCNT_inc (POPs);
1136 1236
1137 PUTBACK; 1237 PUTBACK;
1138 1238
1139 FREETMPS; LEAVE; 1239 FREETMPS; LEAVE;
… …
1147 1247
1148 sv = decode_sv (dec); 1248 sv = decode_sv (dec);
1149 1249
1150 dSP; 1250 dSP;
1151 ENTER; SAVETMPS; 1251 ENTER; SAVETMPS;
1152 SAVESTACK_POS ();
1153 PUSHMARK (SP); 1252 PUSHMARK (SP);
1154 EXTEND (SP, 2); 1253 EXTEND (SP, 2);
1155 PUSHs (tag_sv); 1254 PUSHs (tag_sv);
1156 PUSHs (sv); 1255 PUSHs (sv);
1157 1256
… …
1159 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL); 1258 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL);
1160 SPAGAIN; 1259 SPAGAIN;
1161 1260
1162 if (SvTRUE (ERRSV)) 1261 if (SvTRUE (ERRSV))
1163 { 1262 {
1164 SvREFCNT_dec (tag_sv); 1263 SvREFCNT_dec_NN (tag_sv);
1165 FREETMPS; LEAVE; 1264 FREETMPS; LEAVE;
1166 ERR_ERRSV; 1265 ERR_ERRSV;
1167 } 1266 }
1168 1267
1169 if (count) 1268 if (count)
1170 { 1269 {
1171 SvREFCNT_dec (tag_sv); 1270 SvREFCNT_dec_NN (tag_sv);
1172 SvREFCNT_dec (sv); 1271 SvREFCNT_dec_NN (sv);
1173 sv = SvREFCNT_inc (POPs); 1272 sv = SvREFCNT_inc_NN (TOPs);
1273 SP -= count;
1174 } 1274 }
1175 else 1275 else
1176 { 1276 {
1177 AV *av = newAV (); 1277 AV *av = newAV ();
1178 av_push (av, tag_sv); 1278 av_push (av, tag_sv);
… …
1321 for (i = av_len (dec.shareable) + 1; i--; ) 1421 for (i = av_len (dec.shareable) + 1; i--; )
1322 if ((svp = av_fetch (dec.shareable, i, 0))) 1422 if ((svp = av_fetch (dec.shareable, i, 0)))
1323 sv_setsv (*svp, &PL_sv_undef); 1423 sv_setsv (*svp, &PL_sv_undef);
1324 } 1424 }
1325 1425
1326 SvREFCNT_dec (sv); 1426 SvREFCNT_dec_NN (sv);
1327 1427
1328 if (dec.err_sv) 1428 if (dec.err_sv)
1329 sv_2mortal (dec.err_sv); 1429 sv_2mortal (dec.err_sv);
1330 1430
1331 croak ("%s, at offset %d (octet 0x%02x)", dec.err, dec.cur - (U8 *)data, (int)(uint8_t)*dec.cur); 1431 croak ("%s, at offset %d (octet 0x%02x)", dec.err, dec.cur - (U8 *)data, (int)(uint8_t)*dec.cur);
… …
1674 cbor_init (&cbor); 1774 cbor_init (&cbor);
1675 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN; 1775 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN;
1676 XPUSHs (cborstr); 1776 XPUSHs (cborstr);
1677} 1777}
1678 1778
1779#ifdef __AFL_COMPILER
1780
1781void
1782afl_init ()
1783 CODE:
1784 __AFL_INIT ();
1785
1786int
1787afl_loop (unsigned int count = 10000)
1788 CODE:
1789 RETVAL = __AFL_LOOP (count);
1790 OUTPUT:
1791 RETVAL
1792
1793#endif
1794

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines