ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/CBOR-XS/XS.xs
(Generate patch)

Comparing CBOR-XS/XS.xs (file contents):
Revision 1.57 by root, Fri Nov 25 12:16:12 2016 UTC vs.
Revision 1.68 by root, Mon Nov 30 18:30:29 2020 UTC

… …
6#include <string.h> 6#include <string.h>
7#include <stdlib.h> 7#include <stdlib.h>
8#include <stdio.h> 8#include <stdio.h>
9#include <limits.h> 9#include <limits.h>
10#include <float.h> 10#include <float.h>
11#include <inttypes.h>
11 12
12#define ECB_NO_THREADS 1 13#define ECB_NO_THREADS 1
13#include "ecb.h" 14#include "ecb.h"
14 15
15// compatibility with perl <5.18 16// compatibility with perl <5.18
… …
20# define HvNAMELEN(hv) HvNAMELEN_get (hv) 21# define HvNAMELEN(hv) HvNAMELEN_get (hv)
21#endif 22#endif
22#ifndef HvNAMEUTF8 23#ifndef HvNAMEUTF8
23# define HvNAMEUTF8(hv) 0 24# define HvNAMEUTF8(hv) 0
24#endif 25#endif
26#ifndef SvREFCNT_inc_NN
27# define SvREFCNT_inc_NN(sv) SvREFCNT_inc (sv)
28#endif
25#ifndef SvREFCNT_dec_NN 29#ifndef SvREFCNT_dec_NN
26# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv) 30# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv)
27#endif 31#endif
28 32
29// known major and minor types 33// known major and minor types
… …
95 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8 99 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8
96 100
97 CBOR_TAG_MAGIC = 55799, // self-describe cbor 101 CBOR_TAG_MAGIC = 55799, // self-describe cbor
98}; 102};
99 103
104// known forced types, also hardcoded in CBOR.pm
105enum
106{
107 AS_CBOR = 0,
108 AS_INT = 1,
109 AS_BYTES = 2,
110 AS_TEXT = 3,
111 AS_FLOAT16 = 4,
112 AS_FLOAT32 = 5,
113 AS_FLOAT64 = 6,
114 // possibly future enhancements: (generic) float, (generic) string
115};
116
100#define F_SHRINK 0x00000001UL 117#define F_SHRINK 0x00000001UL
101#define F_ALLOW_UNKNOWN 0x00000002UL 118#define F_ALLOW_UNKNOWN 0x00000002UL
102#define F_ALLOW_SHARING 0x00000004UL 119#define F_ALLOW_SHARING 0x00000004UL
103#define F_ALLOW_CYCLES 0x00000008UL 120#define F_ALLOW_CYCLES 0x00000008UL
121#define F_FORBID_OBJECTS 0x00000010UL
104#define F_PACK_STRINGS 0x00000010UL 122#define F_PACK_STRINGS 0x00000020UL
105#define F_TEXT_KEYS 0x00000020UL 123#define F_TEXT_KEYS 0x00000040UL
106#define F_TEXT_STRINGS 0x00000040UL 124#define F_TEXT_STRINGS 0x00000080UL
107#define F_VALIDATE_UTF8 0x00000080UL 125#define F_VALIDATE_UTF8 0x00000100UL
108 126
109#define INIT_SIZE 32 // initial scalar size to be allocated 127#define INIT_SIZE 32 // initial scalar size to be allocated
110 128
111#define SB do { 129#define SB do {
112#define SE } while (0) 130#define SE } while (0)
… …
185 203
186// minimum length of a string to be registered for stringref 204// minimum length of a string to be registered for stringref
187ecb_inline int 205ecb_inline int
188minimum_string_length (UV idx) 206minimum_string_length (UV idx)
189{ 207{
190 return idx > 23 208 return idx <= 23 ? 3
191 ? idx > 0xffU 209 : idx <= 0xffU ? 4
192 ? idx > 0xffffU 210 : idx <= 0xffffU ? 5
193 ? idx > 0xffffffffU 211 : idx <= 0xffffffffU ? 7
194 ? 11 212 : 11;
195 : 7
196 : 5
197 : 4
198 : 3;
199} 213}
200 214
201///////////////////////////////////////////////////////////////////////////// 215/////////////////////////////////////////////////////////////////////////////
202// encoder 216// encoder
203 217
… …
216} enc_t; 230} enc_t;
217 231
218ecb_inline void 232ecb_inline void
219need (enc_t *enc, STRLEN len) 233need (enc_t *enc, STRLEN len)
220{ 234{
221 if (ecb_expect_false (enc->cur + len >= enc->end)) 235 if (ecb_expect_false ((uintptr_t)(enc->end - enc->cur) < len))
222 { 236 {
223 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv); 237 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv);
224 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1); 238 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1);
225 enc->cur = SvPVX (enc->sv) + cur; 239 enc->cur = SvPVX (enc->sv) + cur;
226 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1; 240 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1;
… …
232{ 246{
233 need (enc, 1); 247 need (enc, 1);
234 *enc->cur++ = ch; 248 *enc->cur++ = ch;
235} 249}
236 250
251// used for tags, intregers, element counts and so on
237static void 252static void
238encode_uint (enc_t *enc, int major, UV len) 253encode_uint (enc_t *enc, int major, UV len)
239{ 254{
240 need (enc, 9); 255 need (enc, 9);
241 256
… …
272 *enc->cur++ = len >> 8; 287 *enc->cur++ = len >> 8;
273 *enc->cur++ = len; 288 *enc->cur++ = len;
274 } 289 }
275} 290}
276 291
292// encodes a perl value into a CBOR integer
293ecb_inline void
294encode_int (enc_t *enc, SV *sv)
295{
296 if (SvIsUV (sv))
297 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
298 else if (SvIVX (sv) >= 0)
299 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
300 else
301 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
302}
303
277ecb_inline void 304ecb_inline void
278encode_tag (enc_t *enc, UV tag) 305encode_tag (enc_t *enc, UV tag)
279{ 306{
280 encode_uint (enc, MAJOR_TAG, tag); 307 encode_uint (enc, MAJOR_TAG, tag);
281} 308}
… …
342 } 369 }
343 370
344 encode_str (enc, upgrade_utf8, utf8, str, len); 371 encode_str (enc, upgrade_utf8, utf8, str, len);
345} 372}
346 373
374ecb_inline void
375encode_float16 (enc_t *enc, NV nv)
376{
377 need (enc, 1+2);
378
379 *enc->cur++ = MAJOR_MISC | MISC_FLOAT16;
380
381 uint16_t fp = ecb_float_to_binary16 (nv);
382
383 if (!ecb_big_endian ())
384 fp = ecb_bswap16 (fp);
385
386 memcpy (enc->cur, &fp, 2);
387 enc->cur += 2;
388}
389
390ecb_inline void
391encode_float32 (enc_t *enc, NV nv)
392{
393 need (enc, 1+4);
394
395 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
396
397 uint32_t fp = ecb_float_to_binary32 (nv);
398
399 if (!ecb_big_endian ())
400 fp = ecb_bswap32 (fp);
401
402 memcpy (enc->cur, &fp, 4);
403 enc->cur += 4;
404}
405
406ecb_inline void
407encode_float64 (enc_t *enc, NV nv)
408{
409 need (enc, 1+8);
410
411 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
412
413 uint64_t fp = ecb_double_to_binary64 (nv);
414
415 if (!ecb_big_endian ())
416 fp = ecb_bswap64 (fp);
417
418 memcpy (enc->cur, &fp, 8);
419 enc->cur += 8;
420}
421
422ecb_inline void
423encode_forced (enc_t *enc, UV type, SV *sv)
424{
425 switch (type)
426 {
427 case AS_CBOR:
428 {
429 STRLEN len;
430 char *str = SvPVbyte (sv, len);
431
432 need (enc, len);
433 memcpy (enc->cur, str, len);
434 enc->cur += len;
435 }
436 break;
437
438 case AS_BYTES:
439 {
440 STRLEN len;
441 char *str = SvPVbyte (sv, len);
442 encode_strref (enc, 0, 0, str, len);
443 }
444 break;
445
446 case AS_TEXT:
447 {
448 STRLEN len;
449 char *str = SvPVutf8 (sv, len);
450 encode_strref (enc, 1, 1, str, len);
451 }
452 break;
453
454 case AS_INT: encode_int (enc, sv); break;
455 case AS_FLOAT16: encode_float16 (enc, SvNV (sv)); break;
456 case AS_FLOAT32: encode_float32 (enc, SvNV (sv)); break;
457 case AS_FLOAT64: encode_float64 (enc, SvNV (sv)); break;
458
459 default:
460 croak ("encountered malformed CBOR::XS::Tagged object");
461 }
462}
463
347static void encode_sv (enc_t *enc, SV *sv); 464static void encode_sv (enc_t *enc, SV *sv);
348 465
349static void 466static void
350encode_av (enc_t *enc, AV *av) 467encode_av (enc_t *enc, AV *av)
351{ 468{
… …
356 473
357 ++enc->depth; 474 ++enc->depth;
358 475
359 encode_uint (enc, MAJOR_ARRAY, len + 1); 476 encode_uint (enc, MAJOR_ARRAY, len + 1);
360 477
361 if (SvMAGICAL (av)) 478 if (ecb_expect_false (SvMAGICAL (av)))
362 for (i = 0; i <= len; ++i) 479 for (i = 0; i <= len; ++i)
363 { 480 {
364 SV **svp = av_fetch (av, i, 0); 481 SV **svp = av_fetch (av, i, 0);
365 encode_sv (enc, svp ? *svp : &PL_sv_undef); 482 encode_sv (enc, svp ? *svp : &PL_sv_undef);
366 } 483 }
… …
385 ++enc->depth; 502 ++enc->depth;
386 503
387 int pairs = hv_iterinit (hv); 504 int pairs = hv_iterinit (hv);
388 int mg = SvMAGICAL (hv); 505 int mg = SvMAGICAL (hv);
389 506
390 if (mg) 507 if (ecb_expect_false (mg))
391 encode_ch (enc, MAJOR_MAP | MINOR_INDEF); 508 encode_ch (enc, MAJOR_MAP | MINOR_INDEF);
392 else 509 else
393 encode_uint (enc, MAJOR_MAP, pairs); 510 encode_uint (enc, MAJOR_MAP, pairs);
394 511
395 while ((he = hv_iternext (hv))) 512 while ((he = hv_iternext (hv)))
… …
400 encode_strref (enc, enc->cbor.flags & (F_TEXT_KEYS | F_TEXT_STRINGS), HeKUTF8 (he), HeKEY (he), HeKLEN (he)); 517 encode_strref (enc, enc->cbor.flags & (F_TEXT_KEYS | F_TEXT_STRINGS), HeKUTF8 (he), HeKEY (he), HeKLEN (he));
401 518
402 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he)); 519 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he));
403 } 520 }
404 521
405 if (mg) 522 if (ecb_expect_false (mg))
406 encode_ch (enc, MAJOR_MISC | MINOR_INDEF); 523 encode_ch (enc, MAJOR_MISC | MINOR_INDEF);
407 524
408 --enc->depth; 525 --enc->depth;
409} 526}
410 527
… …
443 else if (stash == tagged_stash) 560 else if (stash == tagged_stash)
444 { 561 {
445 if (svt != SVt_PVAV) 562 if (svt != SVt_PVAV)
446 croak ("encountered CBOR::XS::Tagged object that isn't an array"); 563 croak ("encountered CBOR::XS::Tagged object that isn't an array");
447 564
565 switch (av_len ((AV *)sv))
566 {
567 case 2-1:
568 // actually a tagged value
448 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1))); 569 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1)));
449 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1)); 570 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1));
571 break;
572
573 case 3-1:
574 // a forced type [value, type, undef]
575 encode_forced (enc, SvUV (*av_fetch ((AV *)sv, 1, 1)), *av_fetch ((AV *)sv, 0, 1));
576 break;
577
578 default:
579 croak ("encountered malformed CBOR::XS::Tagged object");
580 }
450 581
451 return; 582 return;
452 } 583 }
453 } 584 }
454 585
455 if (ecb_expect_false (SvREFCNT (sv) > 1) 586 if (ecb_expect_false (SvREFCNT (sv) > 1)
456 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING)) 587 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING))
457 { 588 {
458 if (!enc->shareable) 589 if (ecb_expect_false (!enc->shareable))
459 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ()); 590 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ());
460 591
461 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1); 592 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1);
462 593
463 if (SvOK (*svp)) 594 if (SvOK (*svp))
… …
477 if (ecb_expect_false (SvOBJECT (sv))) 608 if (ecb_expect_false (SvOBJECT (sv)))
478 { 609 {
479 HV *stash = SvSTASH (sv); 610 HV *stash = SvSTASH (sv);
480 GV *method; 611 GV *method;
481 612
613 if (enc->cbor.flags & F_FORBID_OBJECTS)
614 croak ("encountered object '%s', but forbid_objects is enabled",
615 SvPV_nolen (sv_2mortal (newRV_inc (sv))));
482 if ((method = gv_fetchmethod_autoload (stash, "TO_CBOR", 0))) 616 else if ((method = gv_fetchmethod_autoload (stash, "TO_CBOR", 0)))
483 { 617 {
484 dSP; 618 dSP;
485 619
486 ENTER; SAVETMPS; 620 ENTER; SAVETMPS;
487 PUSHMARK (SP); 621 PUSHMARK (SP);
… …
506 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0) 640 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0)
507 { 641 {
508 dSP; 642 dSP;
509 643
510 ENTER; SAVETMPS; 644 ENTER; SAVETMPS;
511 SAVESTACK_POS ();
512 PUSHMARK (SP); 645 PUSHMARK (SP);
513 EXTEND (SP, 2); 646 EXTEND (SP, 2);
514 // we re-bless the reference to get overload and other niceties right 647 // we re-bless the reference to get overload and other niceties right
515 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash)); 648 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash));
516 PUSHs (sv_cbor); 649 PUSHs (sv_cbor);
… …
525 658
526 encode_tag (enc, CBOR_TAG_PERL_OBJECT); 659 encode_tag (enc, CBOR_TAG_PERL_OBJECT);
527 encode_uint (enc, MAJOR_ARRAY, count + 1); 660 encode_uint (enc, MAJOR_ARRAY, count + 1);
528 encode_strref (enc, 0, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash)); 661 encode_strref (enc, 0, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash));
529 662
530 while (count) 663 {
664 int i;
665
666 for (i = 0; i < count; ++i)
531 encode_sv (enc, SP[1 - count--]); 667 encode_sv (enc, SP[i + 1 - count]);
668
669 SP -= count;
670 }
532 671
533 PUTBACK; 672 PUTBACK;
534 673
535 FREETMPS; LEAVE; 674 FREETMPS; LEAVE;
536 } 675 }
… …
558 697
559 if (ecb_expect_false (nv == (NV)(U32)nv)) 698 if (ecb_expect_false (nv == (NV)(U32)nv))
560 encode_uint (enc, MAJOR_POS_INT, (U32)nv); 699 encode_uint (enc, MAJOR_POS_INT, (U32)nv);
561 //TODO: maybe I32? 700 //TODO: maybe I32?
562 else if (ecb_expect_false (nv == (float)nv)) 701 else if (ecb_expect_false (nv == (float)nv))
563 { 702 encode_float32 (enc, nv);
564 uint32_t fp = ecb_float_to_binary32 (nv);
565
566 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
567
568 if (!ecb_big_endian ())
569 fp = ecb_bswap32 (fp);
570
571 memcpy (enc->cur, &fp, 4);
572 enc->cur += 4;
573 }
574 else 703 else
575 { 704 encode_float64 (enc, nv);
576 uint64_t fp = ecb_double_to_binary64 (nv);
577
578 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
579
580 if (!ecb_big_endian ())
581 fp = ecb_bswap64 (fp);
582
583 memcpy (enc->cur, &fp, 8);
584 enc->cur += 8;
585 }
586} 705}
587 706
588static void 707static void
589encode_sv (enc_t *enc, SV *sv) 708encode_sv (enc_t *enc, SV *sv)
590{ 709{
… …
597 encode_strref (enc, enc->cbor.flags & F_TEXT_STRINGS, SvUTF8 (sv), str, len); 716 encode_strref (enc, enc->cbor.flags & F_TEXT_STRINGS, SvUTF8 (sv), str, len);
598 } 717 }
599 else if (SvNOKp (sv)) 718 else if (SvNOKp (sv))
600 encode_nv (enc, sv); 719 encode_nv (enc, sv);
601 else if (SvIOKp (sv)) 720 else if (SvIOKp (sv))
602 { 721 encode_int (enc, sv);
603 if (SvIsUV (sv))
604 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
605 else if (SvIVX (sv) >= 0)
606 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
607 else
608 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
609 }
610 else if (SvROK (sv)) 722 else if (SvROK (sv))
611 encode_rv (enc, SvRV (sv)); 723 encode_rv (enc, SvRV (sv));
612 else if (!SvOK (sv)) 724 else if (!SvOK (sv))
613 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL); 725 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL);
614 else if (enc->cbor.flags & F_ALLOW_UNKNOWN) 726 else if (enc->cbor.flags & F_ALLOW_UNKNOWN)
… …
621static SV * 733static SV *
622encode_cbor (SV *scalar, CBOR *cbor) 734encode_cbor (SV *scalar, CBOR *cbor)
623{ 735{
624 enc_t enc = { 0 }; 736 enc_t enc = { 0 };
625 737
626 enc.cbor = *cbor; 738 enc.cbor = *cbor;
627 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE)); 739 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE));
628 enc.cur = SvPVX (enc.sv); 740 enc.cur = SvPVX (enc.sv);
629 enc.end = SvEND (enc.sv); 741 enc.end = SvEND (enc.sv);
630 742
631 SvPOK_only (enc.sv); 743 SvPOK_only (enc.sv);
632 744
633 if (cbor->flags & F_PACK_STRINGS) 745 if (cbor->flags & F_PACK_STRINGS)
634 { 746 {
… …
661 U32 depth; // recursion depth 773 U32 depth; // recursion depth
662 U32 maxdepth; // recursion depth limit 774 U32 maxdepth; // recursion depth limit
663 AV *shareable; 775 AV *shareable;
664 AV *stringref; 776 AV *stringref;
665 SV *decode_tagged; 777 SV *decode_tagged;
778 SV *err_sv; // optional sv for error, needs to be freed
666} dec_t; 779} dec_t;
667 780
668#define ERR(reason) SB if (!dec->err) dec->err = reason; goto fail; SE 781// set dec->err to ERRSV
782ecb_cold static void
783err_errsv (dec_t *dec)
784{
785 if (!dec->err)
786 {
787 dec->err_sv = newSVsv (ERRSV);
669 788
789 // chop off the trailing \n
790 SvCUR_set (dec->err_sv, SvCUR (dec->err_sv) - 1);
791 *SvEND (dec->err_sv) = 0;
792
793 dec->err = SvPVutf8_nolen (dec->err_sv);
794 }
795}
796
797// the following functions are used to reduce code size and help the compiler to optimise
798ecb_cold static void
799err_set (dec_t *dec, const char *reason)
800{
801 if (!dec->err)
802 dec->err = reason;
803}
804
805ecb_cold static void
806err_unexpected_end (dec_t *dec)
807{
808 err_set (dec, "unexpected end of CBOR data");
809}
810
811#define ERR_DO(do) SB do; goto fail; SE
812#define ERR(reason) ERR_DO (err_set (dec, reason))
813#define ERR_ERRSV ERR_DO (err_errsv (dec))
814
670#define WANT(len) if (ecb_expect_false ((UV)(dec->end - dec->cur) < (UV)len)) ERR ("unexpected end of CBOR data") 815#define WANT(len) if (ecb_expect_false ((uintptr_t)(dec->end - dec->cur) < (STRLEN)len)) ERR_DO (err_unexpected_end (dec))
671 816
672#define DEC_INC_DEPTH if (ecb_expect_false (++dec->depth > dec->cbor.max_depth)) ERR (ERR_NESTING_EXCEEDED) 817#define DEC_INC_DEPTH if (ecb_expect_false (++dec->depth > dec->cbor.max_depth)) ERR (ERR_NESTING_EXCEEDED)
673#define DEC_DEC_DEPTH --dec->depth 818#define DEC_DEC_DEPTH --dec->depth
674 819
675static UV 820static UV
… …
743 888
744 for (;;) 889 for (;;)
745 { 890 {
746 WANT (1); 891 WANT (1);
747 892
748 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 893 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
749 { 894 {
750 ++dec->cur; 895 ++dec->cur;
751 break; 896 break;
752 } 897 }
753 898
… …
767 912
768 DEC_DEC_DEPTH; 913 DEC_DEC_DEPTH;
769 return newRV_noinc ((SV *)av); 914 return newRV_noinc ((SV *)av);
770 915
771fail: 916fail:
772 SvREFCNT_dec (av); 917 SvREFCNT_dec_NN (av);
773 DEC_DEC_DEPTH; 918 DEC_DEC_DEPTH;
774 return &PL_sv_undef; 919 return &PL_sv_undef;
775} 920}
776 921
777static void 922static void
… …
811 } 956 }
812 957
813 SV *k = decode_sv (dec); 958 SV *k = decode_sv (dec);
814 SV *v = decode_sv (dec); 959 SV *v = decode_sv (dec);
815 960
961 // we leak memory if uncaught exceptions are thrown by random magical
962 // methods, and this is hopefully the only place where it can happen,
963 // so if there is a chance of an exception, take the very slow path.
964 // since catching exceptions is "undocumented/internal/forbidden" by
965 // the new p5p powers, we need to call out to a perl function :/
966 if (ecb_expect_false (SvAMAGIC (k)))
967 {
968 dSP;
969
970 ENTER; SAVETMPS;
971 PUSHMARK (SP);
972 EXTEND (SP, 3);
973 PUSHs (sv_2mortal (newRV_inc ((SV *)hv)));
974 PUSHs (sv_2mortal (k));
975 PUSHs (sv_2mortal (v));
976
977 PUTBACK;
978 call_pv ("CBOR::XS::_hv_store", G_VOID | G_DISCARD | G_EVAL);
979 SPAGAIN;
980
981 FREETMPS; LEAVE;
982
983 if (SvTRUE (ERRSV))
984 ERR_ERRSV;
985
986 return;
987 }
988
816 hv_store_ent (hv, k, v, 0); 989 hv_store_ent (hv, k, v, 0);
817 SvREFCNT_dec (k); 990 SvREFCNT_dec_NN (k);
818 991
819fail: 992fail:
820 ; 993 ;
821} 994}
822 995
… …
833 1006
834 for (;;) 1007 for (;;)
835 { 1008 {
836 WANT (1); 1009 WANT (1);
837 1010
838 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 1011 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
839 { 1012 {
840 ++dec->cur; 1013 ++dec->cur;
841 break; 1014 break;
842 } 1015 }
843 1016
… …
856 1029
857 DEC_DEC_DEPTH; 1030 DEC_DEC_DEPTH;
858 return newRV_noinc ((SV *)hv); 1031 return newRV_noinc ((SV *)hv);
859 1032
860fail: 1033fail:
861 SvREFCNT_dec (hv); 1034 SvREFCNT_dec_NN (hv);
862 DEC_DEC_DEPTH; 1035 DEC_DEC_DEPTH;
863 return &PL_sv_undef; 1036 return &PL_sv_undef;
864} 1037}
865 1038
866static SV * 1039static SV *
867decode_str (dec_t *dec, int utf8) 1040decode_str (dec_t *dec, int utf8)
868{ 1041{
869 SV *sv = 0; 1042 SV *sv = 0;
870 1043
871 if ((*dec->cur & MINOR_MASK) == MINOR_INDEF) 1044 if (ecb_expect_false ((*dec->cur & MINOR_MASK) == MINOR_INDEF))
872 { 1045 {
873 // indefinite length strings 1046 // indefinite length strings
874 ++dec->cur; 1047 ++dec->cur;
875 1048
876 U8 major = *dec->cur & MAJOR_MISC; 1049 U8 major = *dec->cur & MAJOR_MISC;
… …
944 sv = newRV_noinc (decode_sv (dec)); 1117 sv = newRV_noinc (decode_sv (dec));
945 break; 1118 break;
946 1119
947 case CBOR_TAG_STRINGREF_NAMESPACE: 1120 case CBOR_TAG_STRINGREF_NAMESPACE:
948 { 1121 {
949 // do nmot use SAVETMPS/FREETMPS, as these will 1122 // do not use SAVETMPS/FREETMPS, as these will
950 // erase mortalised caches, e.g. "shareable" 1123 // erase mortalised caches, e.g. "shareable"
951 ENTER; 1124 ENTER;
952 1125
953 SAVESPTR (dec->stringref); 1126 SAVESPTR (dec->stringref);
954 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ()); 1127 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ());
… …
964 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1137 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
965 ERR ("corrupted CBOR data (stringref index not an unsigned integer)"); 1138 ERR ("corrupted CBOR data (stringref index not an unsigned integer)");
966 1139
967 UV idx = decode_uint (dec); 1140 UV idx = decode_uint (dec);
968 1141
969 if (!dec->stringref || (int)idx > AvFILLp (dec->stringref)) 1142 if (!dec->stringref || idx >= (UV)(1 + AvFILLp (dec->stringref)))
970 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)"); 1143 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)");
971 1144
972 sv = newSVsv (AvARRAY (dec->stringref)[idx]); 1145 sv = newSVsv (AvARRAY (dec->stringref)[idx]);
973 } 1146 }
974 break; 1147 break;
… …
1002 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1175 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
1003 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)"); 1176 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)");
1004 1177
1005 UV idx = decode_uint (dec); 1178 UV idx = decode_uint (dec);
1006 1179
1007 if (!dec->shareable || (int)idx > AvFILLp (dec->shareable)) 1180 if (!dec->shareable || idx >= (UV)(1 + AvFILLp (dec->shareable)))
1008 ERR ("corrupted CBOR data (sharedref index out of bounds)"); 1181 ERR ("corrupted CBOR data (sharedref index out of bounds)");
1009 1182
1010 sv = SvREFCNT_inc_NN (AvARRAY (dec->shareable)[idx]); 1183 sv = SvREFCNT_inc_NN (AvARRAY (dec->shareable)[idx]);
1011 1184
1012 if (sv == &PL_sv_undef) 1185 if (sv == &PL_sv_undef)
… …
1014 } 1187 }
1015 break; 1188 break;
1016 1189
1017 case CBOR_TAG_PERL_OBJECT: 1190 case CBOR_TAG_PERL_OBJECT:
1018 { 1191 {
1192 if (dec->cbor.flags & F_FORBID_OBJECTS)
1193 goto filter;
1194
1019 sv = decode_sv (dec); 1195 sv = decode_sv (dec);
1020 1196
1021 if (!SvROK (sv) || SvTYPE (SvRV (sv)) != SVt_PVAV) 1197 if (!SvROK (sv) || SvTYPE (SvRV (sv)) != SVt_PVAV)
1022 ERR ("corrupted CBOR data (non-array perl object)"); 1198 ERR ("corrupted CBOR data (non-array perl object)");
1023 1199
… …
1052 SPAGAIN; 1228 SPAGAIN;
1053 1229
1054 if (SvTRUE (ERRSV)) 1230 if (SvTRUE (ERRSV))
1055 { 1231 {
1056 FREETMPS; LEAVE; 1232 FREETMPS; LEAVE;
1057 ERR (SvPVutf8_nolen (sv_2mortal (SvREFCNT_inc (ERRSV)))); 1233 ERR_ERRSV;
1058 } 1234 }
1059 1235
1060 SvREFCNT_dec (sv); 1236 SvREFCNT_dec_NN (sv);
1061 sv = SvREFCNT_inc (POPs); 1237 sv = SvREFCNT_inc (POPs);
1062 1238
1063 PUTBACK; 1239 PUTBACK;
1064 1240
1065 FREETMPS; LEAVE; 1241 FREETMPS; LEAVE;
1066 } 1242 }
1067 break; 1243 break;
1068 1244
1069 default: 1245 default:
1246 filter:
1070 { 1247 {
1248 SV *tag_sv = newSVuv (tag);
1249
1071 sv = decode_sv (dec); 1250 sv = decode_sv (dec);
1072 1251
1073 dSP; 1252 dSP;
1074 ENTER; SAVETMPS; 1253 ENTER; SAVETMPS;
1075 SAVESTACK_POS ();
1076 PUSHMARK (SP); 1254 PUSHMARK (SP);
1077 EXTEND (SP, 2); 1255 EXTEND (SP, 2);
1078 PUSHs (newSVuv (tag)); 1256 PUSHs (tag_sv);
1079 PUSHs (sv); 1257 PUSHs (sv);
1080 1258
1081 PUTBACK; 1259 PUTBACK;
1082 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL); 1260 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL);
1083 SPAGAIN; 1261 SPAGAIN;
1084 1262
1085 if (SvTRUE (ERRSV)) 1263 if (SvTRUE (ERRSV))
1086 { 1264 {
1265 SvREFCNT_dec_NN (tag_sv);
1087 FREETMPS; LEAVE; 1266 FREETMPS; LEAVE;
1088 ERR (SvPVutf8_nolen (sv_2mortal (SvREFCNT_inc (ERRSV)))); 1267 ERR_ERRSV;
1089 } 1268 }
1090 1269
1091 if (count) 1270 if (count)
1092 { 1271 {
1272 SvREFCNT_dec_NN (tag_sv);
1093 SvREFCNT_dec (sv); 1273 SvREFCNT_dec_NN (sv);
1094 sv = SvREFCNT_inc (POPs); 1274 sv = SvREFCNT_inc_NN (TOPs);
1275 SP -= count;
1095 } 1276 }
1096 else 1277 else
1097 { 1278 {
1098 AV *av = newAV (); 1279 AV *av = newAV ();
1099 av_push (av, newSVuv (tag)); 1280 av_push (av, tag_sv);
1100 av_push (av, sv); 1281 av_push (av, sv);
1101 1282
1102 HV *tagged_stash = !CBOR_SLOW || cbor_tagged_stash 1283 HV *tagged_stash = !CBOR_SLOW || cbor_tagged_stash
1103 ? cbor_tagged_stash 1284 ? cbor_tagged_stash
1104 : gv_stashpv ("CBOR::XS::Tagged" , 1); 1285 : gv_stashpv ("CBOR::XS::Tagged" , 1);
… …
1233 1414
1234 if (dec.err) 1415 if (dec.err)
1235 { 1416 {
1236 if (dec.shareable) 1417 if (dec.shareable)
1237 { 1418 {
1238 // need to break cyclic links, which whould all be in shareable 1419 // need to break cyclic links, which would all be in shareable
1239 int i; 1420 int i;
1240 SV **svp; 1421 SV **svp;
1241 1422
1242 for (i = av_len (dec.shareable) + 1; i--; ) 1423 for (i = av_len (dec.shareable) + 1; i--; )
1243 if ((svp = av_fetch (dec.shareable, i, 0))) 1424 if ((svp = av_fetch (dec.shareable, i, 0)))
1244 sv_setsv (*svp, &PL_sv_undef); 1425 sv_setsv (*svp, &PL_sv_undef);
1245 } 1426 }
1246 1427
1247 SvREFCNT_dec (sv); 1428 SvREFCNT_dec_NN (sv);
1429
1430 if (dec.err_sv)
1431 sv_2mortal (dec.err_sv);
1432
1248 croak ("%s, at offset %d (octet 0x%02x)", dec.err, dec.cur - (U8 *)data, (int)(uint8_t)*dec.cur); 1433 croak ("%s, at offset %d (octet 0x%02x)", dec.err, dec.cur - (U8 *)data, (int)(uint8_t)*dec.cur);
1249 } 1434 }
1250 1435
1251 sv = sv_2mortal (sv); 1436 sv = sv_2mortal (sv);
1252 1437
… …
1427 ALIAS: 1612 ALIAS:
1428 shrink = F_SHRINK 1613 shrink = F_SHRINK
1429 allow_unknown = F_ALLOW_UNKNOWN 1614 allow_unknown = F_ALLOW_UNKNOWN
1430 allow_sharing = F_ALLOW_SHARING 1615 allow_sharing = F_ALLOW_SHARING
1431 allow_cycles = F_ALLOW_CYCLES 1616 allow_cycles = F_ALLOW_CYCLES
1617 forbid_objects = F_FORBID_OBJECTS
1432 pack_strings = F_PACK_STRINGS 1618 pack_strings = F_PACK_STRINGS
1433 text_keys = F_TEXT_KEYS 1619 text_keys = F_TEXT_KEYS
1434 text_strings = F_TEXT_STRINGS 1620 text_strings = F_TEXT_STRINGS
1435 validate_utf8 = F_VALIDATE_UTF8 1621 validate_utf8 = F_VALIDATE_UTF8
1436 PPCODE: 1622 PPCODE:
… …
1447 ALIAS: 1633 ALIAS:
1448 get_shrink = F_SHRINK 1634 get_shrink = F_SHRINK
1449 get_allow_unknown = F_ALLOW_UNKNOWN 1635 get_allow_unknown = F_ALLOW_UNKNOWN
1450 get_allow_sharing = F_ALLOW_SHARING 1636 get_allow_sharing = F_ALLOW_SHARING
1451 get_allow_cycles = F_ALLOW_CYCLES 1637 get_allow_cycles = F_ALLOW_CYCLES
1638 get_forbid_objects = F_FORBID_OBJECTS
1452 get_pack_strings = F_PACK_STRINGS 1639 get_pack_strings = F_PACK_STRINGS
1453 get_text_keys = F_TEXT_KEYS 1640 get_text_keys = F_TEXT_KEYS
1454 get_text_strings = F_TEXT_STRINGS 1641 get_text_strings = F_TEXT_STRINGS
1455 get_validate_utf8 = F_VALIDATE_UTF8 1642 get_validate_utf8 = F_VALIDATE_UTF8
1456 PPCODE: 1643 PPCODE:
… …
1589 cbor_init (&cbor); 1776 cbor_init (&cbor);
1590 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN; 1777 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN;
1591 XPUSHs (cborstr); 1778 XPUSHs (cborstr);
1592} 1779}
1593 1780
1781#ifdef __AFL_COMPILER
1782
1783void
1784afl_init ()
1785 CODE:
1786 __AFL_INIT ();
1787
1788int
1789afl_loop (unsigned int count = 10000)
1790 CODE:
1791 RETVAL = __AFL_LOOP (count);
1792 OUTPUT:
1793 RETVAL
1794
1795#endif
1796

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines