ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/CBOR-XS/XS.xs
(Generate patch)

Comparing CBOR-XS/XS.xs (file contents):
Revision 1.48 by root, Sun Sep 20 23:25:53 2015 UTC vs.
Revision 1.80 by root, Fri Sep 8 20:03:06 2023 UTC

6#include <string.h> 6#include <string.h>
7#include <stdlib.h> 7#include <stdlib.h>
8#include <stdio.h> 8#include <stdio.h>
9#include <limits.h> 9#include <limits.h>
10#include <float.h> 10#include <float.h>
11#include <inttypes.h>
11 12
12#define ECB_NO_THREADS 1 13#define ECB_NO_THREADS 1
13#include "ecb.h" 14#include "ecb.h"
14 15
15// compatibility with perl <5.18 16// compatibility with perl <5.18
20# define HvNAMELEN(hv) HvNAMELEN_get (hv) 21# define HvNAMELEN(hv) HvNAMELEN_get (hv)
21#endif 22#endif
22#ifndef HvNAMEUTF8 23#ifndef HvNAMEUTF8
23# define HvNAMEUTF8(hv) 0 24# define HvNAMEUTF8(hv) 0
24#endif 25#endif
26#ifndef SvREFCNT_inc_NN
27# define SvREFCNT_inc_NN(sv) SvREFCNT_inc (sv)
28#endif
25#ifndef SvREFCNT_dec_NN 29#ifndef SvREFCNT_dec_NN
26# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv) 30# define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv)
27#endif 31#endif
32
33// perl's is_utf8_string interprets len=0 as "calculate len", but we want it to mean 0
34#define cbor_is_utf8_string(str,len) (!(len) || is_utf8_string ((str), (len)))
28 35
29// known major and minor types 36// known major and minor types
30enum cbor_type 37enum cbor_type
31{ 38{
32 MAJOR_SHIFT = 5, 39 MAJOR_SHIFT = 5,
95 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8 102 CBOR_TAG_MIME = 36, // mime message rfc2045, utf-8
96 103
97 CBOR_TAG_MAGIC = 55799, // self-describe cbor 104 CBOR_TAG_MAGIC = 55799, // self-describe cbor
98}; 105};
99 106
107// known forced types, also hardcoded in CBOR.pm
108enum
109{
110 AS_CBOR = 0,
111 AS_INT = 1,
112 AS_BYTES = 2,
113 AS_TEXT = 3,
114 AS_FLOAT16 = 4,
115 AS_FLOAT32 = 5,
116 AS_FLOAT64 = 6,
117 AS_MAP = 7,
118 // possibly future enhancements: (generic) float, (generic) string
119};
120
100#define F_SHRINK 0x00000001UL 121#define F_SHRINK 0x00000001UL
101#define F_ALLOW_UNKNOWN 0x00000002UL 122#define F_ALLOW_UNKNOWN 0x00000002UL
102#define F_ALLOW_SHARING 0x00000004UL 123#define F_ALLOW_SHARING 0x00000004UL
103#define F_ALLOW_CYCLES 0x00000008UL 124#define F_ALLOW_CYCLES 0x00000008UL
125#define F_ALLOW_WEAK_CYCLES 0x00000010UL
126#define F_FORBID_OBJECTS 0x00000020UL
104#define F_PACK_STRINGS 0x00000010UL 127#define F_PACK_STRINGS 0x00000040UL
128#define F_TEXT_KEYS 0x00000080UL
129#define F_TEXT_STRINGS 0x00000100UL
105#define F_VALIDATE_UTF8 0x00000020UL 130#define F_VALIDATE_UTF8 0x00000200UL
106 131
107#define INIT_SIZE 32 // initial scalar size to be allocated 132#define INIT_SIZE 32 // initial scalar size to be allocated
108 133
109#define SB do { 134#define SB do {
110#define SE } while (0) 135#define SE } while (0)
180#endif 205#endif
181 } 206 }
182} 207}
183 208
184// minimum length of a string to be registered for stringref 209// minimum length of a string to be registered for stringref
185ecb_inline int 210ecb_inline STRLEN
186minimum_string_length (UV idx) 211minimum_string_length (UV idx)
187{ 212{
188 return idx > 23 213 return idx <= 23 ? 3
189 ? idx > 0xffU 214 : idx <= 0xffU ? 4
190 ? idx > 0xffffU 215 : idx <= 0xffffU ? 5
191 ? idx > 0xffffffffU 216 : idx <= 0xffffffffU ? 7
192 ? 11 217 : 11;
193 : 7
194 : 5
195 : 4
196 : 3;
197} 218}
198 219
199///////////////////////////////////////////////////////////////////////////// 220/////////////////////////////////////////////////////////////////////////////
200// encoder 221// encoder
201 222
214} enc_t; 235} enc_t;
215 236
216ecb_inline void 237ecb_inline void
217need (enc_t *enc, STRLEN len) 238need (enc_t *enc, STRLEN len)
218{ 239{
219 if (ecb_expect_false (enc->cur + len >= enc->end)) 240 if (ecb_expect_false ((uintptr_t)(enc->end - enc->cur) < len))
220 { 241 {
221 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv); 242 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv);
222 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1); 243 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1);
223 enc->cur = SvPVX (enc->sv) + cur; 244 enc->cur = SvPVX (enc->sv) + cur;
224 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1; 245 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1;
225 } 246 }
226} 247}
227 248
249static void encode_sv (enc_t *enc, SV *sv);
250
228ecb_inline void 251ecb_inline void
229encode_ch (enc_t *enc, char ch) 252encode_ch (enc_t *enc, char ch)
230{ 253{
231 need (enc, 1); 254 need (enc, 1);
232 *enc->cur++ = ch; 255 *enc->cur++ = ch;
233} 256}
234 257
258// used for tags, intregers, element counts and so on
235static void 259static void
236encode_uint (enc_t *enc, int major, UV len) 260encode_uint (enc_t *enc, int major, UV len)
237{ 261{
238 need (enc, 9); 262 need (enc, 9);
239 263
270 *enc->cur++ = len >> 8; 294 *enc->cur++ = len >> 8;
271 *enc->cur++ = len; 295 *enc->cur++ = len;
272 } 296 }
273} 297}
274 298
299// encodes a perl value into a CBOR integer
300ecb_inline void
301encode_int (enc_t *enc, SV *sv)
302{
303 if (SvIsUV (sv))
304 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
305 else if (SvIVX (sv) >= 0)
306 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
307 else
308 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
309}
310
275ecb_inline void 311ecb_inline void
276encode_tag (enc_t *enc, UV tag) 312encode_tag (enc_t *enc, UV tag)
277{ 313{
278 encode_uint (enc, MAJOR_TAG, tag); 314 encode_uint (enc, MAJOR_TAG, tag);
279} 315}
280 316
317// exceptional (hopefully) slow path for byte strings that need to be utf8-encoded
318ecb_noinline static void
319encode_str_utf8 (enc_t *enc, int utf8, char *str, STRLEN len)
320{
321 STRLEN ulen = len;
322 U8 *p, *pend = (U8 *)str + len;
323
324 for (p = (U8 *)str; p < pend; ++p)
325 ulen += *p >> 7; // count set high bits
326
327 encode_uint (enc, MAJOR_TEXT, ulen);
328
329 need (enc, ulen);
330 for (p = (U8 *)str; p < pend; ++p)
331 if (*p < 0x80)
332 *enc->cur++ = *p;
333 else
334 {
335 *enc->cur++ = 0xc0 + (*p >> 6);
336 *enc->cur++ = 0x80 + (*p & 63);
337 }
338}
339
281ecb_inline void 340ecb_inline void
282encode_str (enc_t *enc, int utf8, char *str, STRLEN len) 341encode_str (enc_t *enc, int upgrade_utf8, int utf8, char *str, STRLEN len)
283{ 342{
343 if (ecb_expect_false (upgrade_utf8))
344 if (!utf8)
345 {
346 encode_str_utf8 (enc, utf8, str, len);
347 return;
348 }
349
284 encode_uint (enc, utf8 ? MAJOR_TEXT : MAJOR_BYTES, len); 350 encode_uint (enc, utf8 ? MAJOR_TEXT : MAJOR_BYTES, len);
285 need (enc, len); 351 need (enc, len);
286 memcpy (enc->cur, str, len); 352 memcpy (enc->cur, str, len);
287 enc->cur += len; 353 enc->cur += len;
288} 354}
289 355
290static void 356ecb_inline void
291encode_strref (enc_t *enc, int utf8, char *str, STRLEN len) 357encode_strref (enc_t *enc, int upgrade_utf8, int utf8, char *str, STRLEN len)
292{ 358{
293 if (ecb_expect_false (enc->cbor.flags & F_PACK_STRINGS)) 359 if (ecb_expect_false (enc->cbor.flags & F_PACK_STRINGS))
294 { 360 {
295 SV **svp = hv_fetch (enc->stringref[!!utf8], str, len, 1); 361 SV **svp = hv_fetch (enc->stringref[!!utf8], str, len, 1);
296 362
307 sv_setuv (*svp, enc->stringref_idx); 373 sv_setuv (*svp, enc->stringref_idx);
308 ++enc->stringref_idx; 374 ++enc->stringref_idx;
309 } 375 }
310 } 376 }
311 377
312 encode_str (enc, utf8, str, len); 378 encode_str (enc, upgrade_utf8, utf8, str, len);
313} 379}
314 380
315static void encode_sv (enc_t *enc, SV *sv); 381ecb_inline void
382encode_float16 (enc_t *enc, NV nv)
383{
384 need (enc, 1+2);
385
386 *enc->cur++ = MAJOR_MISC | MISC_FLOAT16;
387
388 uint16_t fp = ecb_float_to_binary16 (nv);
389
390 if (!ecb_big_endian ())
391 fp = ecb_bswap16 (fp);
392
393 memcpy (enc->cur, &fp, 2);
394 enc->cur += 2;
395}
396
397ecb_inline void
398encode_float32 (enc_t *enc, NV nv)
399{
400 need (enc, 1+4);
401
402 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
403
404 uint32_t fp = ecb_float_to_binary32 (nv);
405
406 if (!ecb_big_endian ())
407 fp = ecb_bswap32 (fp);
408
409 memcpy (enc->cur, &fp, 4);
410 enc->cur += 4;
411}
412
413ecb_inline void
414encode_float64 (enc_t *enc, NV nv)
415{
416 need (enc, 1+8);
417
418 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
419
420 uint64_t fp = ecb_double_to_binary64 (nv);
421
422 if (!ecb_big_endian ())
423 fp = ecb_bswap64 (fp);
424
425 memcpy (enc->cur, &fp, 8);
426 enc->cur += 8;
427}
428
429ecb_inline void
430encode_bool (enc_t *enc, int istrue)
431{
432 encode_ch (enc, istrue ? MAJOR_MISC | SIMPLE_TRUE : MAJOR_MISC | SIMPLE_FALSE);
433}
434
435// encodes an arrayref containing key-value pairs as CBOR map
436ecb_inline void
437encode_array_as_map (enc_t *enc, SV *sv)
438{
439 if (enc->depth >= enc->cbor.max_depth)
440 croak (ERR_NESTING_EXCEEDED);
441
442 ++enc->depth;
443
444 // as_map does error checking for us, but we re-check in case
445 // things have changed.
446
447 if (!SvROK (sv) || SvTYPE (SvRV (sv)) != SVt_PVAV)
448 croak ("CBOR::XS::as_map requires an array reference (did you change the array after calling as_map?)");
449
450 AV *av = (AV *)SvRV (sv);
451 int i, len = av_len (av);
452
453 if (!(len & 1))
454 croak ("CBOR::XS::as_map requires an even number of elements (did you change the array after calling as_map?)");
455
456 encode_uint (enc, MAJOR_MAP, (len + 1) >> 1);
457
458 for (i = 0; i <= len; ++i)
459 {
460 SV **svp = av_fetch (av, i, 0);
461 encode_sv (enc, svp ? *svp : &PL_sv_undef);
462 }
463
464 --enc->depth;
465}
466
467ecb_inline void
468encode_forced (enc_t *enc, UV type, SV *sv)
469{
470 switch (type)
471 {
472 case AS_CBOR:
473 {
474 STRLEN len;
475 char *str = SvPVbyte (sv, len);
476
477 need (enc, len);
478 memcpy (enc->cur, str, len);
479 enc->cur += len;
480 }
481 break;
482
483 case AS_BYTES:
484 {
485 STRLEN len;
486 char *str = SvPVbyte (sv, len);
487 encode_strref (enc, 0, 0, str, len);
488 }
489 break;
490
491 case AS_TEXT:
492 {
493 STRLEN len;
494 char *str = SvPVutf8 (sv, len);
495 encode_strref (enc, 1, 1, str, len);
496 }
497 break;
498
499 case AS_INT: encode_int (enc, sv); break;
500
501 case AS_FLOAT16: encode_float16 (enc, SvNV (sv)); break;
502 case AS_FLOAT32: encode_float32 (enc, SvNV (sv)); break;
503 case AS_FLOAT64: encode_float64 (enc, SvNV (sv)); break;
504
505 case AS_MAP: encode_array_as_map (enc, sv); break;
506
507 default:
508 croak ("encountered malformed CBOR::XS::Tagged object");
509 }
510}
316 511
317static void 512static void
318encode_av (enc_t *enc, AV *av) 513encode_av (enc_t *enc, AV *av)
319{ 514{
320 int i, len = av_len (av); 515 int i, len = av_len (av);
324 519
325 ++enc->depth; 520 ++enc->depth;
326 521
327 encode_uint (enc, MAJOR_ARRAY, len + 1); 522 encode_uint (enc, MAJOR_ARRAY, len + 1);
328 523
329 if (SvMAGICAL (av)) 524 if (ecb_expect_false (SvMAGICAL (av)))
330 for (i = 0; i <= len; ++i) 525 for (i = 0; i <= len; ++i)
331 { 526 {
332 SV **svp = av_fetch (av, i, 0); 527 SV **svp = av_fetch (av, i, 0);
333 encode_sv (enc, svp ? *svp : &PL_sv_undef); 528 encode_sv (enc, svp ? *svp : &PL_sv_undef);
334 } 529 }
353 ++enc->depth; 548 ++enc->depth;
354 549
355 int pairs = hv_iterinit (hv); 550 int pairs = hv_iterinit (hv);
356 int mg = SvMAGICAL (hv); 551 int mg = SvMAGICAL (hv);
357 552
358 if (mg) 553 if (ecb_expect_false (mg))
359 encode_ch (enc, MAJOR_MAP | MINOR_INDEF); 554 encode_ch (enc, MAJOR_MAP | MINOR_INDEF);
360 else 555 else
361 encode_uint (enc, MAJOR_MAP, pairs); 556 encode_uint (enc, MAJOR_MAP, pairs);
362 557
363 while ((he = hv_iternext (hv))) 558 while ((he = hv_iternext (hv)))
364 { 559 {
365 if (HeKLEN (he) == HEf_SVKEY) 560 if (HeKLEN (he) == HEf_SVKEY)
366 encode_sv (enc, HeSVKEY (he)); 561 encode_sv (enc, HeSVKEY (he));
367 else 562 else
368 encode_strref (enc, HeKUTF8 (he), HeKEY (he), HeKLEN (he)); 563 encode_strref (enc, enc->cbor.flags & (F_TEXT_KEYS | F_TEXT_STRINGS), HeKUTF8 (he), HeKEY (he), HeKLEN (he));
369 564
370 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he)); 565 encode_sv (enc, ecb_expect_false (mg) ? hv_iterval (hv, he) : HeVAL (he));
371 } 566 }
372 567
373 if (mg) 568 if (ecb_expect_false (mg))
374 encode_ch (enc, MAJOR_MISC | MINOR_INDEF); 569 encode_ch (enc, MAJOR_MISC | MINOR_INDEF);
375 570
376 --enc->depth; 571 --enc->depth;
377} 572}
378 573
398 593
399 HV *stash = SvSTASH (sv); 594 HV *stash = SvSTASH (sv);
400 595
401 if (stash == boolean_stash) 596 if (stash == boolean_stash)
402 { 597 {
403 encode_ch (enc, SvIV (sv) ? MAJOR_MISC | SIMPLE_TRUE : MAJOR_MISC | SIMPLE_FALSE); 598 encode_bool (enc, SvIV (sv));
404 return; 599 return;
405 } 600 }
406 else if (stash == error_stash) 601 else if (stash == error_stash)
407 { 602 {
408 encode_ch (enc, MAJOR_MISC | SIMPLE_UNDEF); 603 encode_ch (enc, MAJOR_MISC | SIMPLE_UNDEF);
411 else if (stash == tagged_stash) 606 else if (stash == tagged_stash)
412 { 607 {
413 if (svt != SVt_PVAV) 608 if (svt != SVt_PVAV)
414 croak ("encountered CBOR::XS::Tagged object that isn't an array"); 609 croak ("encountered CBOR::XS::Tagged object that isn't an array");
415 610
611 switch (av_len ((AV *)sv))
612 {
613 case 2-1:
614 // actually a tagged value
416 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1))); 615 encode_uint (enc, MAJOR_TAG, SvUV (*av_fetch ((AV *)sv, 0, 1)));
417 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1)); 616 encode_sv (enc, *av_fetch ((AV *)sv, 1, 1));
617 break;
618
619 case 3-1:
620 // a forced type [value, type, undef]
621 encode_forced (enc, SvUV (*av_fetch ((AV *)sv, 1, 1)), *av_fetch ((AV *)sv, 0, 1));
622 break;
623
624 default:
625 croak ("encountered malformed CBOR::XS::Tagged object");
626 }
418 627
419 return; 628 return;
420 } 629 }
421 } 630 }
422 631
423 if (ecb_expect_false (SvREFCNT (sv) > 1) 632 if (ecb_expect_false (SvREFCNT (sv) > 1)
424 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING)) 633 && ecb_expect_false (enc->cbor.flags & F_ALLOW_SHARING))
425 { 634 {
426 if (!enc->shareable) 635 if (ecb_expect_false (!enc->shareable))
427 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ()); 636 enc->shareable = (HV *)sv_2mortal ((SV *)newHV ());
428 637
429 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1); 638 SV **svp = hv_fetch (enc->shareable, (char *)&sv, sizeof (sv), 1);
430 639
431 if (SvOK (*svp)) 640 if (SvOK (*svp))
445 if (ecb_expect_false (SvOBJECT (sv))) 654 if (ecb_expect_false (SvOBJECT (sv)))
446 { 655 {
447 HV *stash = SvSTASH (sv); 656 HV *stash = SvSTASH (sv);
448 GV *method; 657 GV *method;
449 658
659 if (enc->cbor.flags & F_FORBID_OBJECTS)
660 croak ("encountered object '%s', but forbid_objects is enabled",
661 SvPV_nolen (sv_2mortal (newRV_inc (sv))));
450 if ((method = gv_fetchmethod_autoload (stash, "TO_CBOR", 0))) 662 else if ((method = gv_fetchmethod_autoload (stash, "TO_CBOR", 0)))
451 { 663 {
452 dSP; 664 dSP;
453 665
454 ENTER; SAVETMPS; PUSHMARK (SP); 666 ENTER; SAVETMPS;
667 PUSHMARK (SP);
455 // we re-bless the reference to get overload and other niceties right 668 // we re-bless the reference to get overload and other niceties right
456 XPUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash)); 669 XPUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash));
457 670
458 PUTBACK; 671 PUTBACK;
459 // G_SCALAR ensures that return value is 1 672 // G_SCALAR ensures that return value is 1
472 } 685 }
473 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0) 686 else if ((method = gv_fetchmethod_autoload (stash, "FREEZE", 0)) != 0)
474 { 687 {
475 dSP; 688 dSP;
476 689
477 ENTER; SAVETMPS; PUSHMARK (SP); 690 ENTER; SAVETMPS;
691 PUSHMARK (SP);
478 EXTEND (SP, 2); 692 EXTEND (SP, 2);
479 // we re-bless the reference to get overload and other niceties right 693 // we re-bless the reference to get overload and other niceties right
480 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash)); 694 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash));
481 PUSHs (sv_cbor); 695 PUSHs (sv_cbor);
482 696
488 if (count == 1 && SvROK (TOPs) && SvRV (TOPs) == sv) 702 if (count == 1 && SvROK (TOPs) && SvRV (TOPs) == sv)
489 croak ("%s::FREEZE(CBOR) method returned same object as was passed instead of a new one", HvNAME (stash)); 703 croak ("%s::FREEZE(CBOR) method returned same object as was passed instead of a new one", HvNAME (stash));
490 704
491 encode_tag (enc, CBOR_TAG_PERL_OBJECT); 705 encode_tag (enc, CBOR_TAG_PERL_OBJECT);
492 encode_uint (enc, MAJOR_ARRAY, count + 1); 706 encode_uint (enc, MAJOR_ARRAY, count + 1);
493 encode_strref (enc, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash)); 707 encode_strref (enc, 0, HvNAMEUTF8 (stash), HvNAME (stash), HvNAMELEN (stash));
494 708
495 while (count) 709 {
710 int i;
711
712 for (i = 0; i < count; ++i)
496 encode_sv (enc, SP[1 - count--]); 713 encode_sv (enc, SP[i + 1 - count]);
714
715 SP -= count;
716 }
497 717
498 PUTBACK; 718 PUTBACK;
499 719
500 FREETMPS; LEAVE; 720 FREETMPS; LEAVE;
501 } 721 }
523 743
524 if (ecb_expect_false (nv == (NV)(U32)nv)) 744 if (ecb_expect_false (nv == (NV)(U32)nv))
525 encode_uint (enc, MAJOR_POS_INT, (U32)nv); 745 encode_uint (enc, MAJOR_POS_INT, (U32)nv);
526 //TODO: maybe I32? 746 //TODO: maybe I32?
527 else if (ecb_expect_false (nv == (float)nv)) 747 else if (ecb_expect_false (nv == (float)nv))
528 { 748 encode_float32 (enc, nv);
529 uint32_t fp = ecb_float_to_binary32 (nv);
530
531 *enc->cur++ = MAJOR_MISC | MISC_FLOAT32;
532
533 if (!ecb_big_endian ())
534 fp = ecb_bswap32 (fp);
535
536 memcpy (enc->cur, &fp, 4);
537 enc->cur += 4;
538 }
539 else 749 else
540 { 750 encode_float64 (enc, nv);
541 uint64_t fp = ecb_double_to_binary64 (nv);
542
543 *enc->cur++ = MAJOR_MISC | MISC_FLOAT64;
544
545 if (!ecb_big_endian ())
546 fp = ecb_bswap64 (fp);
547
548 memcpy (enc->cur, &fp, 8);
549 enc->cur += 8;
550 }
551} 751}
552 752
553static void 753static void
554encode_sv (enc_t *enc, SV *sv) 754encode_sv (enc_t *enc, SV *sv)
555{ 755{
557 757
558 if (SvPOKp (sv)) 758 if (SvPOKp (sv))
559 { 759 {
560 STRLEN len; 760 STRLEN len;
561 char *str = SvPV (sv, len); 761 char *str = SvPV (sv, len);
562 encode_strref (enc, SvUTF8 (sv), str, len); 762 encode_strref (enc, enc->cbor.flags & F_TEXT_STRINGS, SvUTF8 (sv), str, len);
563 } 763 }
564 else if (SvNOKp (sv)) 764 else if (SvNOKp (sv))
565 encode_nv (enc, sv); 765 encode_nv (enc, sv);
566 else if (SvIOKp (sv)) 766 else if (SvIOKp (sv))
567 { 767 encode_int (enc, sv);
568 if (SvIsUV (sv))
569 encode_uint (enc, MAJOR_POS_INT, SvUVX (sv));
570 else if (SvIVX (sv) >= 0)
571 encode_uint (enc, MAJOR_POS_INT, SvIVX (sv));
572 else
573 encode_uint (enc, MAJOR_NEG_INT, -(SvIVX (sv) + 1));
574 }
575 else if (SvROK (sv)) 768 else if (SvROK (sv))
576 encode_rv (enc, SvRV (sv)); 769 encode_rv (enc, SvRV (sv));
577 else if (!SvOK (sv)) 770 else if (!SvOK (sv))
578 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL); 771 encode_ch (enc, MAJOR_MISC | SIMPLE_NULL);
579 else if (enc->cbor.flags & F_ALLOW_UNKNOWN) 772 else if (enc->cbor.flags & F_ALLOW_UNKNOWN)
586static SV * 779static SV *
587encode_cbor (SV *scalar, CBOR *cbor) 780encode_cbor (SV *scalar, CBOR *cbor)
588{ 781{
589 enc_t enc = { 0 }; 782 enc_t enc = { 0 };
590 783
591 enc.cbor = *cbor; 784 enc.cbor = *cbor;
592 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE)); 785 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE));
593 enc.cur = SvPVX (enc.sv); 786 enc.cur = SvPVX (enc.sv);
594 enc.end = SvEND (enc.sv); 787 enc.end = SvEND (enc.sv);
595 788
596 SvPOK_only (enc.sv); 789 SvPOK_only (enc.sv);
597 790
598 if (cbor->flags & F_PACK_STRINGS) 791 if (cbor->flags & F_PACK_STRINGS)
599 { 792 {
626 U32 depth; // recursion depth 819 U32 depth; // recursion depth
627 U32 maxdepth; // recursion depth limit 820 U32 maxdepth; // recursion depth limit
628 AV *shareable; 821 AV *shareable;
629 AV *stringref; 822 AV *stringref;
630 SV *decode_tagged; 823 SV *decode_tagged;
824 SV *err_sv; // optional sv for error, needs to be freed
631} dec_t; 825} dec_t;
632 826
633#define ERR(reason) SB if (!dec->err) dec->err = reason; goto fail; SE 827// set dec->err to ERRSV
828ecb_cold static void
829err_errsv (dec_t *dec)
830{
831 if (!dec->err)
832 {
833 dec->err_sv = newSVsv (ERRSV);
634 834
635#define WANT(len) if (ecb_expect_false (dec->cur + len > dec->end)) ERR ("unexpected end of CBOR data") 835 // chop off the trailing \n
836 SvCUR_set (dec->err_sv, SvCUR (dec->err_sv) - 1);
837 *SvEND (dec->err_sv) = 0;
636 838
839 dec->err = SvPVutf8_nolen (dec->err_sv);
840 }
841}
842
843// the following functions are used to reduce code size and help the compiler to optimise
844ecb_cold static void
845err_set (dec_t *dec, const char *reason)
846{
847 if (!dec->err)
848 dec->err = reason;
849}
850
851ecb_cold static void
852err_unexpected_end (dec_t *dec)
853{
854 err_set (dec, "unexpected end of CBOR data");
855}
856
857#define ERR_DO(do) SB do; goto fail; SE
858#define ERR(reason) ERR_DO (err_set (dec, reason))
859#define ERR_ERRSV ERR_DO (err_errsv (dec))
860
861#define WANT(len) if (ecb_expect_false ((uintptr_t)(dec->end - dec->cur) < (STRLEN)len)) ERR_DO (err_unexpected_end (dec))
862
637#define DEC_INC_DEPTH if (++dec->depth > dec->cbor.max_depth) ERR (ERR_NESTING_EXCEEDED) 863#define DEC_INC_DEPTH if (ecb_expect_false (++dec->depth > dec->cbor.max_depth)) ERR (ERR_NESTING_EXCEEDED)
638#define DEC_DEC_DEPTH --dec->depth 864#define DEC_DEC_DEPTH --dec->depth
639 865
640static UV 866static UV
641decode_uint (dec_t *dec) 867decode_uint (dec_t *dec)
642{ 868{
708 934
709 for (;;) 935 for (;;)
710 { 936 {
711 WANT (1); 937 WANT (1);
712 938
713 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 939 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
714 { 940 {
715 ++dec->cur; 941 ++dec->cur;
716 break; 942 break;
717 } 943 }
718 944
719 av_push (av, decode_sv (dec)); 945 av_push (av, decode_sv (dec));
720 } 946 }
721 } 947 }
722 else 948 else
723 { 949 {
724 int i, len = decode_uint (dec); 950 UV i, len = decode_uint (dec);
725 951
726 WANT (len); // complexity check for av_fill - need at least one byte per value, do not allow supersize arrays 952 WANT (len); // complexity check for av_fill - need at least one byte per value, do not allow supersize arrays
727 av_fill (av, len - 1); 953 av_fill (av, len - 1);
728 954
729 for (i = 0; i < len; ++i) 955 for (i = 0; i < len; ++i)
732 958
733 DEC_DEC_DEPTH; 959 DEC_DEC_DEPTH;
734 return newRV_noinc ((SV *)av); 960 return newRV_noinc ((SV *)av);
735 961
736fail: 962fail:
737 SvREFCNT_dec (av); 963 SvREFCNT_dec_NN (av);
738 DEC_DEC_DEPTH; 964 DEC_DEC_DEPTH;
739 return &PL_sv_undef; 965 return &PL_sv_undef;
740} 966}
741 967
742static void 968static void
746 // byte or utf-8 strings as keys, but only when !stringref 972 // byte or utf-8 strings as keys, but only when !stringref
747 973
748 if (ecb_expect_true (!dec->stringref)) 974 if (ecb_expect_true (!dec->stringref))
749 if (ecb_expect_true ((U8)(*dec->cur - MAJOR_BYTES) <= LENGTH_EXT8)) 975 if (ecb_expect_true ((U8)(*dec->cur - MAJOR_BYTES) <= LENGTH_EXT8))
750 { 976 {
751 I32 len = decode_uint (dec); 977 STRLEN len = decode_uint (dec);
752 char *key = (char *)dec->cur; 978 char *key = (char *)dec->cur;
753 979
980 WANT (len);
754 dec->cur += len; 981 dec->cur += len;
755 982
756 hv_store (hv, key, len, decode_sv (dec), 0); 983 hv_store (hv, key, len, decode_sv (dec), 0);
757 984
758 return; 985 return;
759 } 986 }
760 else if (ecb_expect_true ((U8)(*dec->cur - MAJOR_TEXT) <= LENGTH_EXT8)) 987 else if (ecb_expect_true ((U8)(*dec->cur - MAJOR_TEXT) <= LENGTH_EXT8))
761 { 988 {
762 I32 len = decode_uint (dec); 989 STRLEN len = decode_uint (dec);
763 char *key = (char *)dec->cur; 990 char *key = (char *)dec->cur;
764 991
992 WANT (len);
765 dec->cur += len; 993 dec->cur += len;
766 994
767 if (ecb_expect_false (dec->cbor.flags & F_VALIDATE_UTF8)) 995 if (ecb_expect_false (dec->cbor.flags & F_VALIDATE_UTF8))
768 if (!is_utf8_string (key, len)) 996 if (!cbor_is_utf8_string ((U8 *)key, len))
769 ERR ("corrupted CBOR data (invalid UTF-8 in map key)"); 997 ERR ("corrupted CBOR data (invalid UTF-8 in map key)");
770 998
771 hv_store (hv, key, -len, decode_sv (dec), 0); 999 hv_store (hv, key, -len, decode_sv (dec), 0);
772 1000
773 return; 1001 return;
774 } 1002 }
775 1003
776 SV *k = decode_sv (dec); 1004 SV *k = decode_sv (dec);
777 SV *v = decode_sv (dec); 1005 SV *v = decode_sv (dec);
778 1006
1007 // we leak memory if uncaught exceptions are thrown by random magical
1008 // methods, and this is hopefully the only place where it can happen,
1009 // so if there is a chance of an exception, take the very slow path.
1010 // since catching exceptions is "undocumented/internal/forbidden" by
1011 // the new p5p powers, we need to call out to a perl function :/
1012 if (ecb_expect_false (SvAMAGIC (k)))
1013 {
1014 dSP;
1015
1016 ENTER; SAVETMPS;
1017 PUSHMARK (SP);
1018 EXTEND (SP, 3);
1019 PUSHs (sv_2mortal (newRV_inc ((SV *)hv)));
1020 PUSHs (sv_2mortal (k));
1021 PUSHs (sv_2mortal (v));
1022
1023 PUTBACK;
1024 call_pv ("CBOR::XS::_hv_store", G_VOID | G_DISCARD | G_EVAL);
1025 SPAGAIN;
1026
1027 FREETMPS; LEAVE;
1028
1029 if (SvTRUE (ERRSV))
1030 ERR_ERRSV;
1031
1032 return;
1033 }
1034
779 hv_store_ent (hv, k, v, 0); 1035 hv_store_ent (hv, k, v, 0);
780 SvREFCNT_dec (k); 1036 SvREFCNT_dec_NN (k);
781 1037
782fail: 1038fail:
783 ; 1039 ;
784} 1040}
785 1041
796 1052
797 for (;;) 1053 for (;;)
798 { 1054 {
799 WANT (1); 1055 WANT (1);
800 1056
801 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF)) 1057 if (*dec->cur == (MAJOR_MISC | MINOR_INDEF) || dec->err)
802 { 1058 {
803 ++dec->cur; 1059 ++dec->cur;
804 break; 1060 break;
805 } 1061 }
806 1062
807 decode_he (dec, hv); 1063 decode_he (dec, hv);
808 } 1064 }
809 } 1065 }
810 else 1066 else
811 { 1067 {
812 int pairs = decode_uint (dec); 1068 UV pairs = decode_uint (dec);
1069
1070 WANT (pairs); // complexity check - need at least one byte per value, do not allow supersize hashes
813 1071
814 while (pairs--) 1072 while (pairs--)
815 decode_he (dec, hv); 1073 decode_he (dec, hv);
816 } 1074 }
817 1075
818 DEC_DEC_DEPTH; 1076 DEC_DEC_DEPTH;
819 return newRV_noinc ((SV *)hv); 1077 return newRV_noinc ((SV *)hv);
820 1078
821fail: 1079fail:
822 SvREFCNT_dec (hv); 1080 SvREFCNT_dec_NN (hv);
823 DEC_DEC_DEPTH; 1081 DEC_DEC_DEPTH;
824 return &PL_sv_undef; 1082 return &PL_sv_undef;
825} 1083}
826 1084
827static SV * 1085static SV *
828decode_str (dec_t *dec, int utf8) 1086decode_str (dec_t *dec, int utf8)
829{ 1087{
830 SV *sv = 0; 1088 SV *sv = 0;
831 1089
832 if ((*dec->cur & MINOR_MASK) == MINOR_INDEF) 1090 if (ecb_expect_false ((*dec->cur & MINOR_MASK) == MINOR_INDEF))
833 { 1091 {
834 // indefinite length strings 1092 // indefinite length strings
835 ++dec->cur; 1093 ++dec->cur;
836 1094
837 U8 major = *dec->cur & MAJOR_MISC; 1095 U8 major = *dec->cur & MAJOR_MISC;
872 } 1130 }
873 1131
874 if (utf8) 1132 if (utf8)
875 { 1133 {
876 if (ecb_expect_false (dec->cbor.flags & F_VALIDATE_UTF8)) 1134 if (ecb_expect_false (dec->cbor.flags & F_VALIDATE_UTF8))
877 if (!is_utf8_string (SvPVX (sv), SvCUR (sv))) 1135 if (!cbor_is_utf8_string (SvPVX (sv), SvCUR (sv)))
878 ERR ("corrupted CBOR data (invalid UTF-8 in text string)"); 1136 ERR ("corrupted CBOR data (invalid UTF-8 in text string)");
879 1137
880 SvUTF8_on (sv); 1138 SvUTF8_on (sv);
881 } 1139 }
882 1140
905 sv = newRV_noinc (decode_sv (dec)); 1163 sv = newRV_noinc (decode_sv (dec));
906 break; 1164 break;
907 1165
908 case CBOR_TAG_STRINGREF_NAMESPACE: 1166 case CBOR_TAG_STRINGREF_NAMESPACE:
909 { 1167 {
1168 // do not use SAVETMPS/FREETMPS, as these will
1169 // erase mortalised caches, e.g. "shareable"
910 ENTER; SAVETMPS; 1170 ENTER;
911 1171
912 SAVESPTR (dec->stringref); 1172 SAVESPTR (dec->stringref);
913 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ()); 1173 dec->stringref = (AV *)sv_2mortal ((SV *)newAV ());
914 1174
915 sv = decode_sv (dec); 1175 sv = decode_sv (dec);
916 1176
917 FREETMPS; LEAVE; 1177 LEAVE;
918 } 1178 }
919 break; 1179 break;
920 1180
921 case CBOR_TAG_STRINGREF: 1181 case CBOR_TAG_STRINGREF:
922 { 1182 {
923 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1183 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
924 ERR ("corrupted CBOR data (stringref index not an unsigned integer)"); 1184 ERR ("corrupted CBOR data (stringref index not an unsigned integer)");
925 1185
926 UV idx = decode_uint (dec); 1186 UV idx = decode_uint (dec);
927 1187
928 if (!dec->stringref || (int)idx > AvFILLp (dec->stringref)) 1188 if (!dec->stringref || idx >= (UV)(1 + AvFILLp (dec->stringref)))
929 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)"); 1189 ERR ("corrupted CBOR data (stringref index out of bounds or outside namespace)");
930 1190
931 sv = newSVsv (AvARRAY (dec->stringref)[idx]); 1191 sv = newSVsv (AvARRAY (dec->stringref)[idx]);
932 } 1192 }
933 break; 1193 break;
935 case CBOR_TAG_VALUE_SHAREABLE: 1195 case CBOR_TAG_VALUE_SHAREABLE:
936 { 1196 {
937 if (ecb_expect_false (!dec->shareable)) 1197 if (ecb_expect_false (!dec->shareable))
938 dec->shareable = (AV *)sv_2mortal ((SV *)newAV ()); 1198 dec->shareable = (AV *)sv_2mortal ((SV *)newAV ());
939 1199
940 if (dec->cbor.flags & F_ALLOW_CYCLES) 1200 if (ecb_expect_false (dec->cbor.flags & (F_ALLOW_CYCLES | F_ALLOW_WEAK_CYCLES)))
941 { 1201 {
1202 // if cycles are allowed, then we store an AV as value
1203 // while it is being decoded, and gather unresolved
1204 // references in it, to be re4solved after decoding.
1205 int idx, i;
942 sv = newSV (0); 1206 AV *av = newAV ();
943 av_push (dec->shareable, SvREFCNT_inc_NN (sv)); 1207 av_push (dec->shareable, (SV *)av);
1208 idx = AvFILLp (dec->shareable);
944 1209
945 SV *osv = decode_sv (dec); 1210 sv = decode_sv (dec);
946 sv_setsv (sv, osv); 1211
1212 // the AV now contains \undef for all unresolved references,
1213 // so we fix them up here.
1214 for (i = 0; i <= AvFILLp (av); ++i)
1215 SvRV_set (AvARRAY (av)[i], SvREFCNT_inc_NN (SvRV (sv)));
1216
1217 // weaken all recursive references
1218 if (dec->cbor.flags & F_ALLOW_WEAK_CYCLES)
1219 for (i = 0; i <= AvFILLp (av); ++i)
1220 sv_rvweaken (AvARRAY (av)[i]);
1221
1222 // now replace the AV by a reference to the completed value
947 SvREFCNT_dec_NN (osv); 1223 SvREFCNT_dec_NN ((SV *)av);
1224 AvARRAY (dec->shareable)[idx] = SvREFCNT_inc_NN (sv);
948 } 1225 }
949 else 1226 else
950 { 1227 {
951 av_push (dec->shareable, &PL_sv_undef); 1228 av_push (dec->shareable, &PL_sv_undef);
952 int idx = AvFILLp (dec->shareable); 1229 int idx = AvFILLp (dec->shareable);
953 sv = decode_sv (dec); 1230 sv = decode_sv (dec);
954 av_store (dec->shareable, idx, SvREFCNT_inc_NN (sv)); 1231 AvARRAY (dec->shareable)[idx] = SvREFCNT_inc_NN (sv);
955 } 1232 }
956 } 1233 }
957 break; 1234 break;
958 1235
959 case CBOR_TAG_VALUE_SHAREDREF: 1236 case CBOR_TAG_VALUE_SHAREDREF:
961 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT)) 1238 if ((*dec->cur >> MAJOR_SHIFT) != (MAJOR_POS_INT >> MAJOR_SHIFT))
962 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)"); 1239 ERR ("corrupted CBOR data (sharedref index not an unsigned integer)");
963 1240
964 UV idx = decode_uint (dec); 1241 UV idx = decode_uint (dec);
965 1242
966 if (!dec->shareable || (int)idx > AvFILLp (dec->shareable)) 1243 if (!dec->shareable || idx >= (UV)(1 + AvFILLp (dec->shareable)))
967 ERR ("corrupted CBOR data (sharedref index out of bounds)"); 1244 ERR ("corrupted CBOR data (sharedref index out of bounds)");
968 1245
969 sv = SvREFCNT_inc_NN (AvARRAY (dec->shareable)[idx]); 1246 sv = AvARRAY (dec->shareable)[idx];
970 1247
971 if (sv == &PL_sv_undef) 1248 // reference to cycle, we create a new \undef and use that, and also
1249 // registerr it in the AV for later fixing
1250 if (ecb_expect_false (SvTYPE (sv) == SVt_PVAV))
1251 {
1252 AV *av = (AV *)sv;
1253 sv = newRV_noinc (&PL_sv_undef);
1254 av_push (av, SvREFCNT_inc_NN (sv));
1255 }
1256 else if (ecb_expect_false (sv == &PL_sv_undef)) // not yet decoded, but cycles not allowed
972 ERR ("cyclic CBOR data structure found, but allow_cycles is not enabled"); 1257 ERR ("cyclic CBOR data structure found, but allow_cycles is not enabled");
1258 else // we decoded the object earlier, no cycle
1259 sv = newSVsv (sv);
973 } 1260 }
974 break; 1261 break;
975 1262
976 case CBOR_TAG_PERL_OBJECT: 1263 case CBOR_TAG_PERL_OBJECT:
977 { 1264 {
1265 if (dec->cbor.flags & F_FORBID_OBJECTS)
1266 goto filter;
1267
978 sv = decode_sv (dec); 1268 sv = decode_sv (dec);
979 1269
980 if (!SvROK (sv) || SvTYPE (SvRV (sv)) != SVt_PVAV) 1270 if (!SvROK (sv) || SvTYPE (SvRV (sv)) != SVt_PVAV)
981 ERR ("corrupted CBOR data (non-array perl object)"); 1271 ERR ("corrupted CBOR data (non-array perl object)");
982 1272
992 if (!method) 1282 if (!method)
993 ERR ("cannot decode perl-object (package does not have a THAW method)"); 1283 ERR ("cannot decode perl-object (package does not have a THAW method)");
994 1284
995 dSP; 1285 dSP;
996 1286
997 ENTER; SAVETMPS; PUSHMARK (SP); 1287 ENTER; SAVETMPS;
1288 PUSHMARK (SP);
998 EXTEND (SP, len + 1); 1289 EXTEND (SP, len + 1);
999 // we re-bless the reference to get overload and other niceties right 1290 // we re-bless the reference to get overload and other niceties right
1000 PUSHs (*av_fetch (av, 0, 1)); 1291 PUSHs (*av_fetch (av, 0, 1));
1001 PUSHs (sv_cbor); 1292 PUSHs (sv_cbor);
1002 1293
1010 SPAGAIN; 1301 SPAGAIN;
1011 1302
1012 if (SvTRUE (ERRSV)) 1303 if (SvTRUE (ERRSV))
1013 { 1304 {
1014 FREETMPS; LEAVE; 1305 FREETMPS; LEAVE;
1015 ERR (SvPVutf8_nolen (sv_2mortal (SvREFCNT_inc (ERRSV)))); 1306 ERR_ERRSV;
1016 } 1307 }
1017 1308
1018 SvREFCNT_dec (sv); 1309 SvREFCNT_dec_NN (sv);
1019 sv = SvREFCNT_inc (POPs); 1310 sv = SvREFCNT_inc (POPs);
1020 1311
1021 PUTBACK; 1312 PUTBACK;
1022 1313
1023 FREETMPS; LEAVE; 1314 FREETMPS; LEAVE;
1024 } 1315 }
1025 break; 1316 break;
1026 1317
1027 default: 1318 default:
1319 filter:
1028 { 1320 {
1321 SV *tag_sv = newSVuv (tag);
1322
1029 sv = decode_sv (dec); 1323 sv = decode_sv (dec);
1030 1324
1031 dSP; 1325 dSP;
1032 ENTER; SAVETMPS; PUSHMARK (SP); 1326 ENTER; SAVETMPS;
1327 PUSHMARK (SP);
1033 EXTEND (SP, 2); 1328 EXTEND (SP, 2);
1034 PUSHs (newSVuv (tag)); 1329 PUSHs (tag_sv);
1035 PUSHs (sv); 1330 PUSHs (sv);
1036 1331
1037 PUTBACK; 1332 PUTBACK;
1038 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL); 1333 int count = call_sv (dec->cbor.filter ? dec->cbor.filter : default_filter, G_ARRAY | G_EVAL);
1039 SPAGAIN; 1334 SPAGAIN;
1040 1335
1041 if (SvTRUE (ERRSV)) 1336 if (SvTRUE (ERRSV))
1042 { 1337 {
1338 SvREFCNT_dec_NN (tag_sv);
1043 FREETMPS; LEAVE; 1339 FREETMPS; LEAVE;
1044 ERR (SvPVutf8_nolen (sv_2mortal (SvREFCNT_inc (ERRSV)))); 1340 ERR_ERRSV;
1045 } 1341 }
1046 1342
1047 if (count) 1343 if (count)
1048 { 1344 {
1345 SvREFCNT_dec_NN (tag_sv);
1049 SvREFCNT_dec (sv); 1346 SvREFCNT_dec_NN (sv);
1050 sv = SvREFCNT_inc (POPs); 1347 sv = SvREFCNT_inc_NN (TOPs);
1348 SP -= count;
1051 } 1349 }
1052 else 1350 else
1053 { 1351 {
1054 AV *av = newAV (); 1352 AV *av = newAV ();
1055 av_push (av, newSVuv (tag)); 1353 av_push (av, tag_sv);
1056 av_push (av, sv); 1354 av_push (av, sv);
1057 1355
1058 HV *tagged_stash = !CBOR_SLOW || cbor_tagged_stash 1356 HV *tagged_stash = !CBOR_SLOW || cbor_tagged_stash
1059 ? cbor_tagged_stash 1357 ? cbor_tagged_stash
1060 : gv_stashpv ("CBOR::XS::Tagged" , 1); 1358 : gv_stashpv ("CBOR::XS::Tagged" , 1);
1189 1487
1190 if (dec.err) 1488 if (dec.err)
1191 { 1489 {
1192 if (dec.shareable) 1490 if (dec.shareable)
1193 { 1491 {
1194 // need to break cyclic links, which whould all be in shareable 1492 // need to break cyclic links, which would all be in shareable
1195 int i; 1493 int i;
1196 SV **svp; 1494 SV **svp;
1197 1495
1198 for (i = av_len (dec.shareable) + 1; i--; ) 1496 for (i = av_len (dec.shareable) + 1; i--; )
1199 if ((svp = av_fetch (dec.shareable, i, 0))) 1497 if ((svp = av_fetch (dec.shareable, i, 0)))
1200 sv_setsv (*svp, &PL_sv_undef); 1498 sv_setsv (*svp, &PL_sv_undef);
1201 } 1499 }
1202 1500
1203 SvREFCNT_dec (sv); 1501 SvREFCNT_dec_NN (sv);
1502
1503 if (dec.err_sv)
1504 sv_2mortal (dec.err_sv);
1505
1204 croak ("%s, at offset %d (octet 0x%02x)", dec.err, dec.cur - (U8 *)data, (int)(uint8_t)*dec.cur); 1506 croak ("%s, at offset %ld (octet 0x%02x)", dec.err, (long)(dec.cur - (U8 *)data), (int)(uint8_t)*dec.cur);
1205 } 1507 }
1206 1508
1207 sv = sv_2mortal (sv); 1509 sv = sv_2mortal (sv);
1208 1510
1209 return sv; 1511 return sv;
1298 1600
1299 break; 1601 break;
1300 1602
1301 case MAJOR_MAP >> MAJOR_SHIFT: 1603 case MAJOR_MAP >> MAJOR_SHIFT:
1302 len <<= 1; 1604 len <<= 1;
1605 /* FALLTHROUGH */
1303 case MAJOR_ARRAY >> MAJOR_SHIFT: 1606 case MAJOR_ARRAY >> MAJOR_SHIFT:
1304 if (len) 1607 if (len)
1305 { 1608 {
1306 av_push (self->incr_count, newSViv (len + 1)); //TODO: nest 1609 av_push (self->incr_count, newSViv (len + 1)); //TODO: nest
1307 count = len + 1; 1610 count = len + 1;
1352 1655
1353 default_filter = newSVpv ("CBOR::XS::default_filter", 0); 1656 default_filter = newSVpv ("CBOR::XS::default_filter", 0);
1354 1657
1355 sv_cbor = newSVpv ("CBOR", 0); 1658 sv_cbor = newSVpv ("CBOR", 0);
1356 SvREADONLY_on (sv_cbor); 1659 SvREADONLY_on (sv_cbor);
1660
1661 assert (("STRLEN must be an unsigned type", 0 <= (STRLEN)-1));
1357} 1662}
1358 1663
1359PROTOTYPES: DISABLE 1664PROTOTYPES: DISABLE
1360 1665
1361void CLONE (...) 1666void CLONE (...)
1377 ))); 1682 )));
1378} 1683}
1379 1684
1380void shrink (CBOR *self, int enable = 1) 1685void shrink (CBOR *self, int enable = 1)
1381 ALIAS: 1686 ALIAS:
1382 shrink = F_SHRINK 1687 shrink = F_SHRINK
1383 allow_unknown = F_ALLOW_UNKNOWN 1688 allow_unknown = F_ALLOW_UNKNOWN
1384 allow_sharing = F_ALLOW_SHARING 1689 allow_sharing = F_ALLOW_SHARING
1385 allow_cycles = F_ALLOW_CYCLES 1690 allow_cycles = F_ALLOW_CYCLES
1691 allow_weak_cycles = F_ALLOW_WEAK_CYCLES
1692 forbid_objects = F_FORBID_OBJECTS
1386 pack_strings = F_PACK_STRINGS 1693 pack_strings = F_PACK_STRINGS
1694 text_keys = F_TEXT_KEYS
1695 text_strings = F_TEXT_STRINGS
1387 validate_utf8 = F_VALIDATE_UTF8 1696 validate_utf8 = F_VALIDATE_UTF8
1388 PPCODE: 1697 PPCODE:
1389{ 1698{
1390 if (enable) 1699 if (enable)
1391 self->flags |= ix; 1700 self->flags |= ix;
1392 else 1701 else
1395 XPUSHs (ST (0)); 1704 XPUSHs (ST (0));
1396} 1705}
1397 1706
1398void get_shrink (CBOR *self) 1707void get_shrink (CBOR *self)
1399 ALIAS: 1708 ALIAS:
1400 get_shrink = F_SHRINK 1709 get_shrink = F_SHRINK
1401 get_allow_unknown = F_ALLOW_UNKNOWN 1710 get_allow_unknown = F_ALLOW_UNKNOWN
1402 get_allow_sharing = F_ALLOW_SHARING 1711 get_allow_sharing = F_ALLOW_SHARING
1403 get_allow_cycles = F_ALLOW_CYCLES 1712 get_allow_cycles = F_ALLOW_CYCLES
1713 get_allow_weak_cycles = F_ALLOW_WEAK_CYCLES
1714 get_forbid_objects = F_FORBID_OBJECTS
1404 get_pack_strings = F_PACK_STRINGS 1715 get_pack_strings = F_PACK_STRINGS
1716 get_text_keys = F_TEXT_KEYS
1717 get_text_strings = F_TEXT_STRINGS
1405 get_validate_utf8 = F_VALIDATE_UTF8 1718 get_validate_utf8 = F_VALIDATE_UTF8
1406 PPCODE: 1719 PPCODE:
1407 XPUSHs (boolSV (self->flags & ix)); 1720 XPUSHs (boolSV (self->flags & ix));
1408 1721
1409void max_depth (CBOR *self, U32 max_depth = 0x80000000UL) 1722void max_depth (CBOR *self, U32 max_depth = 0x80000000UL)
1410 PPCODE: 1723 PPCODE:
1539 cbor_init (&cbor); 1852 cbor_init (&cbor);
1540 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN; 1853 PUTBACK; cborstr = decode_cbor (cborstr, &cbor, 0); SPAGAIN;
1541 XPUSHs (cborstr); 1854 XPUSHs (cborstr);
1542} 1855}
1543 1856
1857#ifdef __AFL_COMPILER
1858
1859void
1860afl_init ()
1861 CODE:
1862 __AFL_INIT ();
1863
1864int
1865afl_loop (unsigned int count = 10000)
1866 CODE:
1867 RETVAL = __AFL_LOOP (count);
1868 OUTPUT:
1869 RETVAL
1870
1871#endif
1872

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines