[ViewVC] Diff of: cvs/Convert-BER-XS/XS.xs

Comparing Convert-BER-XS/XS.xs (file contents):
Revision 1.11 by root, Sat Apr 20 12:25:23 2019 UTC vs.
Revision 1.15 by root, Sat Apr 20 15:23:26 2019 UTC

 #include "EXTERN.h"
 #include "perl.h"
 #include "XSUB.h"
-// C99 required
+// C99 required!
+// this is not just for comments, but also for
+// integer constant semantics,
+// sscanf format modifiers and more.
 enum {
   // ASN_TAG
   ASN_BOOLEAN           = 0x01,
-  ASN_INTEGER32         = 0x02,
+  ASN_INTEGER           = 0x02,
   ASN_BIT_STRING        = 0x03,
   ASN_OCTET_STRING      = 0x04,
   ASN_NULL              = 0x05,
   ASN_OBJECT_IDENTIFIER = 0x06,
   ASN_OID               = 0x06,
   SvPVX (sv)[idx] = type;
 }
 static SV *
-profile_new ()
+profile_new (void)
 {
   SV *sv = newSVpvn ("", 0);
   static const struct {
     int klass;
     int tag;
     int type;
   } *celem, default_map[] = {
       { ASN_UNIVERSAL, ASN_BOOLEAN          , BER_TYPE_BOOL },
-      { ASN_UNIVERSAL, ASN_INTEGER32        , BER_TYPE_INT  },
+      { ASN_UNIVERSAL, ASN_INTEGER          , BER_TYPE_INT  },
       { ASN_UNIVERSAL, ASN_NULL             , BER_TYPE_NULL },
       { ASN_UNIVERSAL, ASN_OBJECT_IDENTIFIER, BER_TYPE_OID  },
-      { ASN_UNIVERSAL, ASN_OBJECT_DESCRIPTOR, BER_TYPE_OID  },
       { ASN_UNIVERSAL, ASN_RELATIVE_OID     , BER_TYPE_RELOID },
       { ASN_UNIVERSAL, ASN_REAL             , BER_TYPE_REAL },
+      { ASN_UNIVERSAL, ASN_ENUMERATED       , BER_TYPE_INT },
       { ASN_UNIVERSAL, ASN_UTF8_STRING      , BER_TYPE_UTF8 },
       { ASN_UNIVERSAL, ASN_BMP_STRING       , BER_TYPE_UCS2 },
       { ASN_UNIVERSAL, ASN_UNIVERSAL_STRING , BER_TYPE_UCS4 },
   };
   return *cur++;
 }
 // get ber-encoded integer (i.e. pack "w")
-static U32
+static UV
 get_w (void)
 {
-  U32 res = 0;
+  UV res = 0;
   for (;;)
     {
       U8 c = get_u8 ();
       res = (res << 7) | (c & 0x7f);
       if (!(c & 0x80))
         return res;
     }
 }
-static U32
+static UV
 get_length (void)
 {
-  U32 res = get_u8 ();
+  UV res = get_u8 ();
   if (res & 0x80)
     {
       int cnt = res & 0x7f;
       res = 0;
           default:
             error ("ASN.1 length too long");
             return 0;
+          case 8: res = (res << 8) | get_u8 ();
+          case 7: res = (res << 8) | get_u8 ();
+          case 6: res = (res << 8) | get_u8 ();
+          case 5: res = (res << 8) | get_u8 ();
           case 4: res = (res << 8) | get_u8 ();
           case 3: res = (res << 8) | get_u8 ();
           case 2: res = (res << 8) | get_u8 ();
           case 1: res = (res << 8) | get_u8 ();
         }
   return res;
 }
 static SV *
-decode_int ()
+decode_int (void)
 {
-  int len = get_length ();
+  UV len = get_length ();
-  if (len <= 0)
+  if (!len)
     {
-      error ("integer length equal to zero");
+      error ("invalid integer length equal to zero");
       return 0;
     }
   U8 *data = get_n (len);
 }
 static SV *
 decode_data (void)
 {
-  U32 len = get_length ();
+  UV len = get_length ();
-  U8 *data = get_n (len);
-  return newSVpvn ((char *)data, len);
+  return newSVpvn ((char *)get_n (len), len);
 }
-// gelper for decode_object_identifier
+// helper for decode_object_identifier
 static char *
-write_uv (char *buf, U32 u)
+write_uv (char *buf, UV u)
 {
   // the one-digit case is absolutely predominant, so this pays off (hopefully)
   if (expect_true (u < 10))
     *buf++ = u + '0';
   else
     {
+      // this *could* be done much faster using branchless fixed-point arithmetics
       char *beg = buf;
       do
         {
           *buf++ = u % 10 + '0';
         }
       while (u);
       // reverse digits
       char *ptr = buf;
-      while (--ptr != beg)
+      while (--ptr > beg)
         {
           char c = *ptr;
           *ptr = *beg;
           *beg = c;
           ++beg;
 }
 static SV *
 decode_oid (int relative)
 {
-  U32 len = get_length ();
+  UV len = get_length ();
   if (len <= 0)
     {
       error ("OBJECT IDENTIFIER length equal to zero");
       return &PL_sv_undef;
     }
   U8 *end = cur + len;
-  U32 w = get_w ();
+  UV w = get_w ();
-  static char oid[MAX_OID_STRLEN]; // must be static
+  static char oid[MAX_OID_STRLEN]; // static, becaueds too large for stack
   char *app = oid;
   if (relative)
     app = write_uv (app, w);
   else
       app = write_uv (app, (U8)w / 40);
       *app++ = '.';
       app = write_uv (app, (U8)w % 40);
     }
+  while (cur < end)
+    {
-  // we assume an oid component is never > 64 bytes
+      // we assume an oid component is never > 64 digits
-  while (cur < end && oid + sizeof (oid) - app > 64)
+      if (oid + sizeof (oid) - app < 64)
-    {
+        croak ("BER_TYPE_OID to long to decode");
       w = get_w ();
       *app++ = '.';
       app = write_uv (app, w);
     }
 static SV *
 decode_ucs (int chrsize)
 {
   SV *res = NEWSV (0, 0);
-  U32 len = get_length ();
+  UV len = get_length ();
   if (len & (chrsize - 1))
     croak ("BER_TYPE_UCS has an invalid number of octets (%d)", len);
   while (len)
   return res;
 }
 static SV *
-decode_ber ()
+decode_ber (void)
 {
   int identifier = get_u8 ();
   SV *res;
   if (tag == ASN_TAG_BER)
     tag = get_w ();
   if (constructed)
     {
-      U32 len = get_length ();
+      UV len = get_length ();
-      U32 seqend = (cur - buf) + len;
+      UV seqend = (cur - buf) + len;
       AV *av = (AV *)sv_2mortal ((SV *)newAV ());
       while (cur < buf + seqend)
         av_push (av, decode_ber ());
     }
   else
     switch (profile_lookup (cur_profile, klass, tag))
       {
         case BER_TYPE_NULL:
+          {
+            UV len = get_length ();
+            if (len)
+              croak ("BER_TYPE_NULL value with non-zero length %d encountered", len);
-          res = &PL_sv_undef;
+            res = &PL_sv_undef;
+          }
           break;
         case BER_TYPE_BOOL:
           {
-            U32 len = get_length ();
+            UV len = get_length ();
             if (len != 1)
-              croak ("BER_TYPE_BOOLEAN type with invalid length %d encountered", len);
+              croak ("BER_TYPE_BOOLEAN value with invalid length %d encountered", len);
-            res = newSVcacheint (get_u8 () ? 0 : 1);
+            res = newSVcacheint (!!get_u8 ());
           }
           break;
         case BER_TYPE_OID:
           res = decode_oid (0);
           res = decode_data ();
           break;
         case BER_TYPE_IPADDRESS:
           {
-            U32 len = get_length ();
+            UV len = get_length ();
             if (len != 4)
               croak ("BER_TYPE_IPADDRESS type with invalid length %d encountered", len);
             U8 c1 = get_u8 ();
   need (1);
   *cur++ = val;
 }
 static void
-put_w_nocheck (U32 val)
+put_w_nocheck (UV val)
 {
+#if UVSIZE > 4
+  *cur = (val >> 7 * 9) | 0x80; cur += val >= ((UV)1 << (7 * 9));
+  *cur = (val >> 7 * 8) | 0x80; cur += val >= ((UV)1 << (7 * 8));
+  *cur = (val >> 7 * 7) | 0x80; cur += val >= ((UV)1 << (7 * 7));
+  *cur = (val >> 7 * 6) | 0x80; cur += val >= ((UV)1 << (7 * 6));
+  *cur = (val >> 7 * 5) | 0x80; cur += val >= ((UV)1 << (7 * 5));
+#endif
-  *cur = (val >> 7 * 4) | 0x80; cur += val >= (1 << (7 * 4));
+  *cur = (val >> 7 * 4) | 0x80; cur += val >= ((UV)1 << (7 * 4));
-  *cur = (val >> 7 * 3) | 0x80; cur += val >= (1 << (7 * 3));
+  *cur = (val >> 7 * 3) | 0x80; cur += val >= ((UV)1 << (7 * 3));
-  *cur = (val >> 7 * 2) | 0x80; cur += val >= (1 << (7 * 2));
+  *cur = (val >> 7 * 2) | 0x80; cur += val >= ((UV)1 << (7 * 2));
-  *cur = (val >> 7 * 1) | 0x80; cur += val >= (1 << (7 * 1));
+  *cur = (val >> 7 * 1) | 0x80; cur += val >= ((UV)1 << (7 * 1));
   *cur =  val           & 0x7f; cur += 1;
 }
 static void
-put_w (U32 val)
+put_w (UV val)
 {
   need (5); // we only handle up to 5 bytes
   put_w_nocheck (val);
 }
 static U8 *
-put_length_at (U32 val, U8 *cur)
+put_length_at (UV val, U8 *cur)
 {
   if (val < 0x7fU)
     *cur++ = val;
   else
     {
       U8 *lenb = cur++;
+#if UVSIZE > 4
+      *cur = val >> 56; cur += *cur > 0;
+      *cur = val >> 48; cur += *cur > 0;
+      *cur = val >> 40; cur += *cur > 0;
+      *cur = val >> 32; cur += *cur > 0;
+#endif
       *cur = val >> 24; cur += *cur > 0;
       *cur = val >> 16; cur += *cur > 0;
       *cur = val >>  8; cur += *cur > 0;
       *cur = val      ; cur += 1;
   return cur;
 }
 static void
-put_length (U32 val)
+put_length (UV val)
 {
   need (5 + val);
   cur = put_length_at (val, cur);
 }
 // return how many bytes the encoded length requires
-static int length_length (U32 val)
+static int length_length (UV val)
 {
   return val < 0x7fU
     ? 1
-    : 2 + (val > 0xffU) + (val > 0xffffU) + (val > 0xffffffU);
+    : 2
+      + (val > 0xffU)
+      + (val > 0xffffU)
+      + (val > 0xffffffU)
+#if UVSIZE > 4
+      + (val > 0xffffffffU)
+      + (val > 0xffffffffffU)
+      + (val > 0xffffffffffffU)
+      + (val > 0xffffffffffffffU)
+#endif
+    ;
 }
 static void
 encode_data (const char *ptr, STRLEN len)
 {
   *lenb = cur - lenb - 1;
 }
 // we don't know the length yet, so we optimistically
-// assume the length will need one octet later. if that
+// assume the length will need one octet later. If that
-// turns out to be wrong, we memove as needed.
+// turns out to be wrong, we memmove as needed.
 // mark the beginning
 static STRLEN
-len_fixup_mark ()
+len_fixup_mark (void)
 {
   return cur++ - buf;
 }
 // patch up the length
     const char *name;
     IV iv;
   } *civ, const_iv[] = {
 #define const_iv(name) { # name, name },
     const_iv (ASN_BOOLEAN)
-    const_iv (ASN_INTEGER32)
+    const_iv (ASN_INTEGER)
     const_iv (ASN_BIT_STRING)
     const_iv (ASN_OCTET_STRING)
     const_iv (ASN_NULL)
     const_iv (ASN_OBJECT_IDENTIFIER)
     const_iv (ASN_OBJECT_DESCRIPTOR)
           && SvIV (AvARRAY (av)[BER_CONSTRUCTED])
           ? AvARRAY (av)[BER_DATA] : &PL_sv_undef);
 }
 void
-ber_is_i32 (SV *tuple, SV *value = &PL_sv_undef)
+ber_is_int (SV *tuple, SV *value = &PL_sv_undef)
 	PPCODE:
 {
 	if (!SvOK (tuple))
           XSRETURN_NO;
         AV *av = ber_tuple (tuple);
-        IV data = SvIV (AvARRAY (av)[BER_DATA]);
+        UV data = SvUV (AvARRAY (av)[BER_DATA]);
         XPUSHs (
                SvIV (AvARRAY (av)[BER_CLASS      ]) == ASN_UNIVERSAL
-          &&   SvIV (AvARRAY (av)[BER_TAG        ]) == ASN_INTEGER32
+          &&   SvIV (AvARRAY (av)[BER_TAG        ]) == ASN_INTEGER
           &&  !SvIV (AvARRAY (av)[BER_CONSTRUCTED])
-          &&  (!SvOK (value) || data == SvIV (value))
+          &&  (!SvOK (value) || data == SvUV (value))
-          ? sv_2mortal (data ? newSViv (data) : newSVpv ("0 but true", 0))
+          ? sv_2mortal (data ? newSVsv (AvARRAY (av)[BER_DATA]) : newSVpv ("0 but true", 0))
           : &PL_sv_undef);
 }
 void
 ber_is_oid (SV *tuple, SV *oid = &PL_sv_undef)
         SvCUR_set (buf_sv, cur - buf);
         XPUSHs (buf_sv);
 }
 SV *
-ber_i32 (IV iv)
+ber_int (SV *sv)
 	CODE:
 {
 	AV *av = newAV ();
         av_fill (av, BER_ARRAYSIZE - 1);
         AvARRAY (av)[BER_CLASS      ] = newSVcacheint (ASN_UNIVERSAL);
-        AvARRAY (av)[BER_TAG        ] = newSVcacheint (ASN_INTEGER32);
+        AvARRAY (av)[BER_TAG        ] = newSVcacheint (ASN_INTEGER);
         AvARRAY (av)[BER_CONSTRUCTED] = newSVcacheint (0);
-        AvARRAY (av)[BER_DATA       ] = newSViv (iv);
+        AvARRAY (av)[BER_DATA       ] = newSVsv (sv);
         RETVAL = newRV_noinc ((SV *)av);
 }
 	OUTPUT: RETVAL
 # TODO: not arrayref, but elements?

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing Convert-BER-XS/XS.xs (file contents): Revision 1.11 by root, Sat Apr 20 12:25:23 2019 UTC vs. Revision 1.15 by root, Sat Apr 20 15:23:26 2019 UTC

Diff Legend

Comparing Convert-BER-XS/XS.xs (file contents):
Revision 1.11 by root, Sat Apr 20 12:25:23 2019 UTC vs.
Revision 1.15 by root, Sat Apr 20 15:23:26 2019 UTC