| 1 | Revision history for Perl extension Coro. |
1 | Revision history for Perl extension Coro. |
| 2 | |
2 | |
| 3 | TODO: better (earlier) error messages on broken transfer's |
3 | TODO: should explore PerlIO::coroaio (perl leaks like hell). |
| 4 | TODO: destroy gets only called on cancel: fix(?) |
4 | TODO: maybe implement a default message channel, very much like Erlang's |
|
|
5 | actor model (which is cool in a lot of important aspects (failures!), |
|
|
6 | but very lacking in others (higher level ipc)). |
| 5 | |
7 | |
| 6 | 3.52 |
8 | - minor cleanups. |
|
|
9 | - use much larger stacks on linux and perl < 5.8.8. |
|
|
10 | |
|
|
11 | 4.911 Tue Nov 11 04:26:17 CET 2008 |
|
|
12 | - "port" to threaded perls. |
|
|
13 | |
|
|
14 | 4.91 Mon Nov 10 05:36:38 CET 2008 |
|
|
15 | - the ->throw exception object no longer leaks. |
|
|
16 | - creating a new cctx leaked a scopestack entry (memleak). |
|
|
17 | - new coroutines didn't get created with a zero flags field |
|
|
18 | (unknown impact). |
|
|
19 | - calling ->throw on a not-yet-started coroutine should now work |
|
|
20 | instead of being ignored. |
|
|
21 | - ->throw is now supported on Coro::State objects. |
|
|
22 | - clean up cctx creation code a bit. |
|
|
23 | - entersub is actually a UNOP, not a LOGOP (not a bugfix). |
|
|
24 | |
|
|
25 | 4.9 Sat Nov 8 17:45:27 CET 2008 |
|
|
26 | - (libcoro) did not preserve rbp with CORO_ASM (we are getting there). |
|
|
27 | - (libcoro) no longer leak threads in the experimental pthread backend, |
|
|
28 | also speed it up considerably. |
|
|
29 | - (libcoro) do not rely on makecontext passing void *'s unscathed. |
|
|
30 | - fix compiletime dependencies on libcoro in the Makefile. |
|
|
31 | - cctx_count wasn't always updated properly. |
|
|
32 | - Coro::State::cctx_stacksize wasn't applied correctly. |
|
|
33 | - new function Coro::State::cctx_max_idle. |
|
|
34 | - the default max number of idle C contexts is now 4. |
|
|
35 | - (libcoro) try harder to get _setjmp/_longjmp. |
|
|
36 | - (libcoro) cleanup and extend the libcoro API to officially |
|
|
37 | allow the creation of empty source contexts. |
|
|
38 | - very experimental workaround for the totally broken netbsd platform. |
|
|
39 | - tried to hack around openbsd bugs. |
|
|
40 | |
|
|
41 | 4.804 Wed Nov 5 16:36:00 CET 2008 |
|
|
42 | - Coro::Debug::new_unix_server would not create a non-blocking listening |
|
|
43 | socket, sometimes causing freezes. |
|
|
44 | - (libcoro) fix misaligned stack points for setjmp and assembly |
|
|
45 | methods, which can cause crashes on x86/x86_64 with a sufficiently |
|
|
46 | aggressive compiler. |
|
|
47 | - new function: Coro::Debug::new_tcp_server. |
|
|
48 | - move ->throw into the Coro class because it only works on coro objects. |
|
|
49 | |
|
|
50 | 4.803 Mon Nov 3 17:16:12 CET 2008 |
|
|
51 | - (libcoro) use a global asm statement to become independent of gcc |
|
|
52 | otpimisations for CORO_ASM (thanks to pippijn for the idea). |
|
|
53 | - try to workaround yet another broken bsd, this time dragonfly. |
|
|
54 | |
|
|
55 | 4.802 Thu Oct 30 10:56:12 CET 2008 |
|
|
56 | - support -fno-omit-frame-pointer on x86 with the assembly method. |
|
|
57 | - tune 01_unblock.t tests a bit. |
|
|
58 | |
|
|
59 | 4.801 Wed Oct 22 18:33:37 CEST 2008 |
|
|
60 | - improve readline speed for very long "lines". |
|
|
61 | - backport to 5.8.8. |
|
|
62 | |
|
|
63 | 4.8 Thu Oct 2 13:34:40 CEST 2008 |
|
|
64 | - new function Coro::AIO::aio_wait. |
|
|
65 | - Coro.:AIO and Coro::BDB now "use Coro::AnyEvent". |
|
|
66 | - greatly speed up and reduce memory usage of Coro::AIO requests. |
|
|
67 | - implement some other µ-optimisations. |
|
|
68 | |
|
|
69 | 4.749 Mon Sep 29 14:40:12 CEST 2008 |
|
|
70 | - port to slow and broken pseudo-threaded perls. (courtesy pippijn). |
|
|
71 | |
|
|
72 | 4.748 Sat Sep 27 14:03:19 CEST 2008 |
|
|
73 | - implement, but do not document, PerlIO::cede(granularity). |
|
|
74 | - Coro::Storable forgot to wrap Storable::pstore. |
|
|
75 | - work around the multitude of leaks and memory corruption |
|
|
76 | bugs in PerlIO::via by using our own C-level perliol. As a side |
|
|
77 | effect, Coro::Storable is now much, much, much faster. |
|
|
78 | |
|
|
79 | 4.747 Tue Sep 23 01:59:41 CEST 2008 |
|
|
80 | - fix a per-cv memleak (one empty array was leaked per |
|
|
81 | code reference). |
|
|
82 | - avoid a crash in coro->call|rss when the coroutine was already |
|
|
83 | destroyed (most noticably when using Coro::Debug::ps :) |
|
|
84 | - also protect *Storable::FILE. |
|
|
85 | - push up default storable granularity to 20ms. |
|
|
86 | |
|
|
87 | 4.746 Sun Sep 21 03:22:20 CEST 2008 |
|
|
88 | - be more insistent on locking Storable against reentrancy |
|
|
89 | in Coro::Storable. |
|
|
90 | - move swap_def?v and throw to Coro::State, as documented. |
|
|
91 | |
|
|
92 | 4.745 Thu Jul 24 00:14:38 CEST 2008 |
|
|
93 | - remove debugging code related to MgPV_nolen_const, also try to |
|
|
94 | make it compile with perl 5.8.6 (yes, apple apparently loves |
|
|
95 | outdated software). Reported by John S. |
|
|
96 | |
|
|
97 | 4.744 Tue Jul 8 22:06:35 CEST 2008 |
|
|
98 | - correctly provide default DIE/WARN handlers as documented. |
|
|
99 | - also overwrite PL_vtbl_sigelem.svt_clear, even though current |
|
|
100 | implementations inside perl work fine for us. |
|
|
101 | |
|
|
102 | 4.743 Mon Jun 16 00:21:57 CEST 2008 |
|
|
103 | - when using Coro::EV without running EV::loop it could |
|
|
104 | result in busy-waiting for events, this has been fixed. |
|
|
105 | - reduce codesize and improve performance by using EV_DEFAULT_UC. |
|
|
106 | |
|
|
107 | 4.742 Sat May 31 14:10:21 CEST 2008 |
|
|
108 | - implement a workaround for (some) perl <5.8.8 versions. |
|
|
109 | - require EV 3.3+. |
|
|
110 | |
|
|
111 | 4.741 Fri May 30 23:33:09 CEST 2008 |
|
|
112 | - tell netbsd how utterly broken their imitation of an OS is |
|
|
113 | and refuse to build by default if pthreads are in use. |
|
|
114 | - switch to "s" method on all bsd's by default, as their ucontext |
|
|
115 | stuff seems just too broken. |
|
|
116 | - fix a bug in Coro::Select. |
|
|
117 | |
|
|
118 | 4.74 Thu May 29 20:05:31 CEST 2008 |
|
|
119 | - do not test Coro::LWP for lack of dependencies. |
|
|
120 | - do not test Coro::Select for lack of working perls. |
|
|
121 | |
|
|
122 | 4.73 Thu May 29 2008 |
|
|
123 | - fix a bug in Coro::EV which would cause it to block despite |
|
|
124 | there being runnable coroutines. |
|
|
125 | - sprinkle "no warnings" freely over everything, also suppress |
|
|
126 | warnings for some other modules. |
|
|
127 | - fix typo in WSAEWOULDBLOCK. |
|
|
128 | |
|
|
129 | 4.72 Sun May 25 05:14:36 CEST 2008 |
|
|
130 | - tweak META.yaml a bit, unfortunately, there is no documented way |
|
|
131 | to have optional dependencies with CPAN. doh :( |
|
|
132 | - avoid running some tests on windows because they would fail due to |
|
|
133 | perl bug (broken fork, broken pipes...). |
|
|
134 | - work around perl on windows bugs where perl returns undocumented |
|
|
135 | error codes for sysread, syswrite etc. by taking advantage |
|
|
136 | of AnyEvent's workaround for that problem. |
|
|
137 | - use AnyEvent::Util::fh_nonblocking in Coro::Handle to work around |
|
|
138 | a common perl implementation bug on windows. |
|
|
139 | - use unix domain sockets in testsuite to work around |
|
|
140 | common perl implementation bugs on widows (they are emulated by |
|
|
141 | tcp sockets on windows. ugh.) |
|
|
142 | |
|
|
143 | 4.71 Sat May 24 20:01:27 CEST 2008 |
|
|
144 | - fix a bug in Coro::AnyEvent ("Usage: Coro::AnyEvent::_schedule()"). |
|
|
145 | - take advantage of async name resolution of AnyEvent::Util. |
|
|
146 | - work around brutal inet_aton override in Coro::LWP. |
|
|
147 | - take advantage of the readyhook in Coro::EV, for smoother |
|
|
148 | scheduling. |
|
|
149 | |
|
|
150 | 4.7 Sun May 11 00:32:19 CEST 2008 |
|
|
151 | - completely reworked the Coro manpage. |
|
|
152 | - added Coro::AnyEvent, generic event loop integration. |
|
|
153 | - implement cancel, ready and kill commands in Coro::Debug. |
|
|
154 | - document find_coro in Coro::Debug. |
|
|
155 | - incompatible change: rename has_stack to has_cctx. |
|
|
156 | - Coro::AIO and Coro::BDB no longer force event model detection, |
|
|
157 | use AnyEvent::AIO and AnyEvent::BDB. |
|
|
158 | |
|
|
159 | 4.6 Sat Apr 26 10:05:14 CEST 2008 |
|
|
160 | - INCOMPATIBLE CHANGE: sub/code attributes are no longer supported |
|
|
161 | by the Coro module. It was a mistake to have it in the first place. |
|
|
162 | - (experimental) support for activestate perl 5.10 (method "w"). |
|
|
163 | - (experimental) support for strawberry perl (method "a"). |
|
|
164 | - coro_sigelem_set did not return a value although it had to, |
|
|
165 | actual impact unknown. |
|
|
166 | |
|
|
167 | 4.51 Mon Apr 14 13:28:27 CEST 2008 |
|
|
168 | - make it compile again on 5.8. |
|
|
169 | |
|
|
170 | 4.50 Thu Apr 10 09:43:17 CEST 2008 |
|
|
171 | - I did it twice! (see 4.49). |
|
|
172 | |
|
|
173 | 4.49 Sun Apr 6 21:23:31 CEST 2008 |
|
|
174 | - grr, instead of compiling the recent changes on 5.10 only they |
|
|
175 | were compiled on 5.8 only. |
|
|
176 | |
|
|
177 | 4.48 Sun Apr 6 20:36:46 CEST 2008 |
|
|
178 | - allow coroutine switches during eval's under 5.10.x, as it seems |
|
|
179 | the parser is a per-interpreter option now, so this is safe |
|
|
180 | (this might fix the odd crashing bug). |
|
|
181 | - drop support for 5.9.x versions: they are dead, jim. |
|
|
182 | |
|
|
183 | 4.47 Sun Apr 6 00:37:52 CEST 2008 |
|
|
184 | - force cctx allocation on API calls: we know we need to force one |
|
|
185 | and gcc actually manages to confuse our heuristic nowadays, |
|
|
186 | leading to crashes and worse. |
|
|
187 | - document force_cctx. |
|
|
188 | |
|
|
189 | 4.46 Fri Apr 4 22:05:43 CEST 2008 |
|
|
190 | - upgrade libcoro, resulting in pthread-backend (which was only created |
|
|
191 | to fulfill the rules of the programming languages shootout). |
|
|
192 | |
|
|
193 | 4.45 Thu Mar 13 11:55:36 CET 2008 |
|
|
194 | - fix a file leaking bug in eg/mhyttpd that would allow |
|
|
195 | downloading of any file (reported by oesi). |
|
|
196 | - fix deadlock bug in Coro::Channel (reported by Richard Hundt) |
|
|
197 | (also add testcase). |
|
|
198 | - support Broadcast option in Coro::Socket (patch by Richard Hundt, |
|
|
199 | apparently having loads of fun with that). |
|
|
200 | - implement $state->swap_defsv, ->swap_defav and document ->throw. |
|
|
201 | |
|
|
202 | 4.4 Wed Feb 13 16:44:29 CET 2008 |
|
|
203 | - only assume .cfi pseudo isns exist on GNU/Linux. |
|
|
204 | - add get_timed method to Coro::Channels. |
|
|
205 | - fixed Coro::Debug manpage. |
|
|
206 | - perl 5.11 compatbility improvement based on patch by |
|
|
207 | Andreas König. |
|
|
208 | |
|
|
209 | 4.37 Sun Jan 20 11:25:23 CET 2008 |
|
|
210 | - soften the check for an active parser for perl 5.10 (avoiding |
|
|
211 | "Coro::State::transfer called while parsing" in many cases). |
|
|
212 | |
|
|
213 | 4.36 Sun Jan 13 10:53:56 CET 2008 |
|
|
214 | - reset diehook when terminating from an async_pool as to not |
|
|
215 | trigger any __DIE__ handlers. |
|
|
216 | |
|
|
217 | 4.35 Sun Jan 13 04:14:13 CET 2008 |
|
|
218 | - "bt" debug command now displays any exceptions |
|
|
219 | from longmess and also skips the innermost |
|
|
220 | stackframes, giving more useufl output. |
|
|
221 | - allow backtraces in coroutines blocked in Coro::EV, |
|
|
222 | at a <1% speed hit. |
|
|
223 | - handle localising of $SIG{__WARN__} and __DIE__ |
|
|
224 | properly (with a proper amount of dirty hacking). |
|
|
225 | |
|
|
226 | 4.34 Sat Dec 22 17:49:53 CET 2007 |
|
|
227 | - upgrade to EV version 2.0 API. |
|
|
228 | |
|
|
229 | 4.33 Mon Dec 17 08:36:12 CET 2007 |
|
|
230 | - make Coro::AIO etc. loadable in the absence of EV. |
|
|
231 | |
|
|
232 | 4.32 Mon Dec 17 07:46:02 CET 2007 |
|
|
233 | - majorly improved Coro::Handle's performance with Coro::EV. |
|
|
234 | - implemented the until now mythical Coro::BDB module. |
|
|
235 | - specialcase EV in Coro::AIO and Coro::BDB for extra speed. |
|
|
236 | |
|
|
237 | 4.31 Wed Dec 5 12:32:39 CET 2007 |
|
|
238 | - remove warn statement form Coro::Util. |
|
|
239 | |
|
|
240 | 4.3 Tue Dec 4 20:33:14 CET 2007 |
|
|
241 | - calls to the idle function could cause stack corruption |
|
|
242 | when the stack changed. |
|
|
243 | - do no longer rely on the presence of EV::DNS if EV is used |
|
|
244 | (because it is gone), but instead take avdantage of EV::ADNS |
|
|
245 | if available. |
|
|
246 | - add ($) prototypes to all functions in Coro::Storable. |
|
|
247 | - use a conventional (safer) idle callback in Coro::EV. |
|
|
248 | - do accept quickly in Coro::Debug to avoid endless loops. |
|
|
249 | |
|
|
250 | 4.22 Fri Nov 30 16:04:04 CET 2007 |
|
|
251 | - really use optimised versions for Event and EV in Coro::Util |
|
|
252 | and Coro::Handle. |
|
|
253 | |
|
|
254 | 4.21 Sun Nov 25 10:48:59 CET 2007 |
|
|
255 | - fix a spurious memory read. |
|
|
256 | - Coro::EV no longer keeps the eventloop "alive". |
|
|
257 | |
|
|
258 | 4.2 Fri Nov 9 20:47:05 CET 2007 |
|
|
259 | - enable/disable tracing from a new coroutine, not a pooled one. |
|
|
260 | - fix a memleak in Coro::Event. |
|
|
261 | - removed killall call from fork_eval. |
|
|
262 | - made sure store_fd is already loaded so that fork_eval |
|
|
263 | does not have to parse autoload in each subprocess. |
|
|
264 | - only use assembly method if -O switch is in $Config{optimize}. |
|
|
265 | - add (optional) Coro::EV module, so far the best event loop module |
|
|
266 | directly supported by Coro. |
|
|
267 | - if the event model is EV, use EV::DNS to resolve |
|
|
268 | stuff in Coro::Util. |
|
|
269 | - don't get confused by multiple event notifications in Coro::Handle. |
|
|
270 | - initial support for EV (libevent interface). |
|
|
271 | - require Event and EV using configure_requires, to force their existance. |
|
|
272 | |
|
|
273 | 4.13 Wed Oct 24 07:26:45 CEST 2007 |
|
|
274 | - add Coro::Storable::blocking_thaw. |
|
|
275 | - use a vastly more complicated technique to localise |
|
|
276 | $SIG{__WARN/DIE__} that also works on perls <= 5.8.8. |
|
|
277 | - use a coroutine for the idle callback Coro::Event, |
|
|
278 | instead of running Event in the current coroutine context. |
|
|
279 | This also catches recursive invocations. |
|
|
280 | - actually report fork errors in gethostbyname and inet_aton. |
|
|
281 | |
|
|
282 | 4.11 Thu Oct 11 02:40:24 CEST 2007 |
|
|
283 | - port to threaded perls. |
|
|
284 | |
|
|
285 | 4.1 Thu Oct 11 02:38:16 CEST 2007 |
|
|
286 | - incompatible change: $SIG{__DIE__} and $SIG{__WARN__} will now |
|
|
287 | be local to each coro (see Coro::State). |
|
|
288 | - incompatible change: for very deep reasons, cede and cede_notself |
|
|
289 | cannot return anything, so nothing will be returned. |
|
|
290 | - possibly bring back 5.10 compatibility (untested). |
|
|
291 | - work around stupid (and wrong) warning on 5.10 :(. |
|
|
292 | - overlay the saved state over the context stack. This saves |
|
|
293 | a few hundred bytes per coroutine on average and also |
|
|
294 | speeds up context switching a bit. |
|
|
295 | - further tune default stack sizes. |
|
|
296 | - (more) correctly calculate stack usage in coro_rss. |
|
|
297 | - Coro::Storable::blocking_* did not properly lock |
|
|
298 | resulting in races between coroutines. |
|
|
299 | - added Coro::Storable::guard. |
|
|
300 | - stopping to trace a coroutine could destroy the cctx of |
|
|
301 | an unrelated coroutine. |
|
|
302 | - explain the relationship between Perl and C coroutines in |
|
|
303 | more detail in Coro::State. |
|
|
304 | - Coro::Util::inet_aton did not short-circuit dotted quad forms, |
|
|
305 | causing a fork per resolve. This also affected Coro::Socket. |
|
|
306 | - switch to a separate stack in $coro->call/eval to avoid |
|
|
307 | invalidating pointers. |
|
|
308 | |
|
|
309 | 4.03 Sat Oct 6 21:24:00 CEST 2007 |
|
|
310 | - added Coro::throw method. |
|
|
311 | - minor code cleanups. |
|
|
312 | |
|
|
313 | 4.02 Sat Oct 6 02:36:47 CEST 2007 |
|
|
314 | - fix a very minor per-coroutine memleak (a single codereference). |
|
|
315 | - fixed a bug where the currently in-use c context would be freed |
|
|
316 | prematurely (can happen only when programs change the stacksize |
|
|
317 | or use tracing). |
|
|
318 | - tracing can no longer keep a coro alive after it terminated. |
|
|
319 | - do static branch prediction in the common path for gcc. gives |
|
|
320 | about 2-5% speed improvement here. |
|
|
321 | |
|
|
322 | 4.01 Fri Oct 5 22:10:49 CEST 2007 |
|
|
323 | - instead of recreating *a* standard output handle we simply |
|
|
324 | use STDOUT, which is faster and hopefully more robust. |
|
|
325 | |
|
|
326 | 4.0 Fri Oct 5 12:56:00 CEST 2007 |
|
|
327 | - incompatibly changed Coro::Storable::freeze. |
|
|
328 | - major new feature: added Coro::Debug, for interactive coroutine |
|
|
329 | debugging, tracing and much more. |
|
|
330 | - major bug fix: unbelievable, but true: $_, $/ and many other |
|
|
331 | "saved" variables actually weren't being saved. This has been fixed, |
|
|
332 | of course, while increasing performance while losing all the save |
|
|
333 | flags. |
|
|
334 | - save flags are gone, and all the api functions dealing with them. |
|
|
335 | - added Coro::Semaphore::adjust. |
|
|
336 | - added Coro::Util::fork_eval. |
|
|
337 | - added Coro::Storable::{nfreeze,blocking_{freeze,nfreeze}}. |
|
|
338 | - added Coro::killall. |
|
|
339 | - reduce initial stack sizes to allow for "micro-coroutines". |
|
|
340 | - better async_pool resource management, moved parts of async_pool |
|
|
341 | handling to XS (major speed improvement). |
|
|
342 | - actually croak before modifying important data structures. |
|
|
343 | - refuse to transfer while compiling. |
|
|
344 | - possibly support eval EXPR better now. |
|
|
345 | - enable assembly per default on linux+bsd x86+amd64. |
|
|
346 | - all internal members were renamed _something for easier subclassing. |
|
|
347 | - many minor tweaks. |
|
|
348 | |
|
|
349 | 3.63 Wed May 16 14:10:06 CEST 2007 |
|
|
350 | - implement handcoded assembly for x86/amd64 SVR ABI. |
|
|
351 | |
|
|
352 | 3.62 Fri Apr 27 21:36:06 CEST 2007 |
|
|
353 | - upgrade libcoro (which might set unwind info correctly). |
|
|
354 | - change default on linux to setjmp/longjmp. |
|
|
355 | |
|
|
356 | 3.61 Thu Apr 19 12:36:18 CEST 2007 |
|
|
357 | - Coro::Storable caused an endless loop when thawing invalid |
|
|
358 | pst's sometimes. |
|
|
359 | - use a Semaphore in Coro::Storable, as Storable doesn't |
|
|
360 | seem to be reentrant (although it is documented to |
|
|
361 | be threadsafe...). |
|
|
362 | - fix Coro::Signal to bring back the original unreliable |
|
|
363 | but stateful semantics. |
|
|
364 | - fixed a lot of typos in Coro.pm (patch submitted by David |
|
|
365 | Steinbrunner, which applied flawlessly). |
|
|
366 | |
|
|
367 | 3.6 Sat Apr 14 17:13:31 CEST 2007 |
|
|
368 | - added some bugfixes to get eg/myhttpd working again. |
|
|
369 | - added Coro::Storable for often-cede'ing freeze/thaw. |
|
|
370 | - try to do a clean exit when a coroutine calls exit |
|
|
371 | (EXPERIMENTAL). |
|
|
372 | - got rid of indirect call through _coro_init. |
|
|
373 | - updated the partly antique examples in eg/ to |
|
|
374 | work again and be a bit less magic, too. |
|
|
375 | - fixed Coro::Signal semantics to work as documented again. |
|
|
376 | |
|
|
377 | 3.55 Sun Mar 25 01:20:47 CET 2007 |
|
|
378 | - add SAVE_DEFFH to save the default filehandle and enable |
|
|
379 | it by default. |
|
|
380 | - finally move socket-operations from Coro::Socket to Coro::Handle |
|
|
381 | to be able to unblock foreign sockets. |
|
|
382 | - add Coro::State::save_also and guarded_save. |
| 7 | - add count accessor to Coro::Semaphore. |
383 | - add count accessor to Coro::Semaphore. |
| 8 | - add Coro::State::cctx_stacksize. |
384 | - add Coro::State::cctx_stacksize. |
|
|
385 | - just for the fun of it, do not rely on implicit context, |
|
|
386 | which can dramatically improve performance, but people |
|
|
387 | using windows-process-emulation perls do not care much about |
|
|
388 | performance. |
| 9 | |
389 | |
| 10 | 3.51 Sun Mar 4 14:18:04 CET 2007 |
390 | 3.51 Sun Mar 4 14:18:04 CET 2007 |
| 11 | - fixed a problem when you weakened references to Coro::State's |
391 | - fixed a problem when you weakened references to Coro::State's |
| 12 | (patch by Yuval Kogman). |
392 | (patch by Yuval Kogman). |
| 13 | |
393 | |
