ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/Coro/Changes
(Generate patch)

Comparing Coro/Changes (file contents):
Revision 1.498 by root, Tue Jun 23 00:56:14 2009 UTC vs.
Revision 1.626 by root, Tue Mar 4 06:13:23 2014 UTC

1Revision history for Perl extension Coro. 1Revision history for Perl extension Coro.
2 2
3TODO: should explore PerlIO::coroaio (perl leaks like hell). 3TODO: should explore PerlIO::coroaio (perl leaks like hell).
4TODO: maybe implement a default message channel, very much like Erlang's
5 actor model (which is cool in a lot of important aspects (failures!),
6 but very lacking in others (higher level ipc)).
7TODO: unready_all
8TODO: myhttpd header parsing
9TODO: channel->maxsize(newsize)? 4TODO: channel->maxsize(newsize)?
5TODO: __GCC_HAVE_DWARF2_CFI_ASM
6TODO: swap_sv, maybe add scope_swap_sv, andallow to unswap by repeat?
7TODO: swap_sv not undone in pool
10 8
96.36 Tue Mar 4 07:11:59 CET 2014
10 - semaphores would not clear the destroy hook when interrupted
11 by ->throw, causing segfaults or worse.
12 - ->throw on a thread waiting for a semaphore did not acquire
13 the semaphore, but also didn't wake up other waiters,
14 possibly causing a deadlock.
15 - "FATAL: $Coro::IDLE blocked itself" will now use Carp::confess
16 to report a full stacktrace, which should help find out
17 where the actual call is.
18 - "atomically" destroy data in slf_destroy, because it is
19 the right thing to do, just in case.
20 - disable ecb.h libm dependency, to compile on ancient systems
21 or under adverse conditions.
22
236.33 Mon Nov 18 11:26:27 CET 2013
24 - do not crash when freeing padlists with holes (in 5.18).
25 - tentative SVt_BIND 5.19 port/fix.
26
276.32 Tue Nov 5 15:35:35 CET 2013
28 - use a new algorithm to derive padlists for perl 5.18. The old
29 one could lead to 0-pointer accesses inside perl (reported
30 by Darin McBride).
31
326.31 Thu May 9 07:39:48 CEST 2013
33 - Coro::AIO requests would crash if the thread was ready'd
34 while the request was ongoing.
35
366.29 Wed May 8 02:55:18 CEST 2013
37 - when an on_destroy handler destructs the coro currently being
38 destructed a perl scalar could be accessed after being freed,
39 likely causing a crash.
40
416.28 Wed Mar 6 06:58:02 CET 2013
42 - clean remnants of existing __DIE__ and __WARN__ handlers so
43 they lose their magic and will not cause segfaults later
44 (testcase by Andrey Sagulin).
45 - improved Coro::State documentation a bit.
46 - Coro::Debug::command now flushes the output.
47 - add hack detection code for x32 abi, because the braindead slugs
48 who designed that made it look exactly like x86_64 without
49 providing proper compile time symbols to test for it. as a result,
50 this detection cannot work reliably.
51 - valgrind stack registering was broken.
52 - do not rely on Time::HiRes anymore in Coro::Debug.
53
546.23 Fri Dec 7 23:36:37 CET 2012
55 - use experimental fiber implementation on native windows
56 perls.
57 - use sizeof (void *) as multiplication factor for stack sizes,
58 to accomodate the totally braindamaged microsoft 64 bit "os".
59 - changed verifier host from win2k-ap510-32 to win7-sp516-32/64.
60 activeperl 5.16 crashes when PerlIO_define_layer is called due
61 to some bug in the perl dll, strawberry perl at least passes
62 the testsuite.
63 - implement Coro::Handle->peeraddr/host/port, for slightly
64 improved compatibility with LWP.
65 - implement 5.17 compatibility by almost blindly applying a
66 good-looking patch by Father Chrysostomos.
67 - move stack management functions into libcoro 3.
68 - libcoro version 3 "released".
69 - support magic values as timed_io_once args.
70 - recommend AnyEvent 7+ or EV 4+, also require EV
71 version 4 or newer for Coro::EV.
72
736.10 Tue Oct 9 01:14:27 CEST 2012
74 - updated ecb.h, it had a typo that caused it to not compile on many
75 big endian systems (reported by many people).
76 - disable memory fences in ecb.h to improve portability.
77
786.09 Sat Oct 6 23:25:02 CEST 2012
79 - Coro::EV I/O watchers were not interruptible by exceptions
80 (Coro::State::throw) (testcase by sten).
81 - ->throw now puts threads into the ready queue, as this seems to
82 be expected by existing code, and code that doesn't cope with spurious
83 wakeups needs fixing anyway.
84 - use fd -1 in mmap.
85 - cast I32 to int in error message printf.
86 - warn about broken so-called "hardened" kernels.
87
886.08 Fri Apr 13 12:05:47 CEST 2012
89 - be more aggressive about exiting like perl does - formerly,
90 exiting from the non-main thread would not execute END blocks.
91
926.07 Fri Nov 11 21:21:48 CET 2011
93 - work around a bug in PerlIO (setting $SIG{__WARN__} to a PVCV).
94 - update ecb.h.
95
966.06 Mon Aug 8 23:59:48 CEST 2011
97 - cygwin unfortunately patches the stack at runtime, so we use the pthreads
98 backend, which is an order of magnitude slower. unfortunately, cygwins
99 pthread implementation isn't very complete either, so allocate the stack
100 twice just to be sure.
101 (note: cygwin also enables mymalloc, which is NOT THREADSAFE ON WINDOWS,
102 in its ithreaded perl - best recompile cygwin and use the 'w'indows
103 backend for much better performance. also disable ithreads for
104 even better performance...).
105
1066.05 Thu Aug 4 21:36:36 CEST 2011
107 - blush, condvar values would not be propagated from send to recv anymore
108 (reported by Chip Salzenberg).
109 - use exponential increase for the readline buffer length in
110 Coro::Handle. also reduce initial allocation to 1020 from 4096 bytes.
111
1126.04 Wed Aug 3 17:15:45 CEST 2011
113 - use even more efficient and more compatible condvars for
114 compatibility to AnyEvent 6.x :)
115 - more inconsequential ecb.h updates.
116
1176.03 Wed Aug 3 11:41:30 CEST 2011
118 - change how Coro patches AnyEvent condvars for compatibility to
119 AnyEvent 6.x.
120 - update ecb.h, to no longer include <pthread.h> in case WinNT.h
121 hasn't been included.
122
1236.02 Wed Jul 13 04:35:19 CEST 2011
124 - "improve portability to Gentoo" - gentoo manages to put perl variables
125 in memory areas that are farther than 2gb apart, which the jit couldn't
126 handle and barfed. now it's just a bit slower on gentoo and similar
127 systems.
128
1296.01 Sun Jul 3 12:31:14 CEST 2011
130 - workarounds are good, but the test for whether pthreads are used
131 was not good. thisone should be better.
132 - check differently whether gcc generates cfi instructions itself.
133
1346.0 Wed Jun 29 19:43:35 CEST 2011
135 - INCOMPATIBLE CHANGE: unreferenced coro objects will now be
136 destroyed and cleaned up automatically (e.g. async { schedule }).
137 - implement a JIT compiler for part of the thread switch code,
138 which gives a 50% speed improvement on threaded perls, and
139 about 4% on non-thraeded perls (so threaded perls now finally
140 reach about half the speed of non-threaded perls).
141 - slightly modernise Coro::Intro, add section about rouse functions.
142 - avoid DEFSV and ERRSV, giving another 10% improvement
143 in thread switching.
144 - Coro::State->is_destroyed is now called is_zombie.
145 - implement a Coro->safe_cancel method that might fail, but
146 cancels in a "safer" way if it succeeds.
147 - add preliminary support for DEBUGGING perls.
148 - get rid of two hash-accesses when initialising a new Coro - this
149 speeds up coro creation by almost a factor of two.
150 - croak when a coro that is being cancelled tries to block
151 (e.g. while executing a guard block), instead of crashing or
152 deadlocking.
153 - use a more robust and also faster method to identify Coro::State
154 objects - speeds up everything a bit.
155 - implement Coro->cancel in XS for a 20% speed improvement, and to
156 be able to implement mutual cancellation.
157 - speed up context switches by a percent or two by more efficiently
158 allocating context stack entries.
159 - implement Coro->join and Coro->on_destroy in XS for a speedup and
160 a reduction in memory use.
161 - cancelling a coro while it itself is cancelling another coro is
162 now supported and working, instead of triggering an assertion.
163 - be a bit more crash-resistant when calling (buggy) on_destroy
164 callbacks (best effort).
165 - move on_destroy into the slf_frame, to allow extension slf
166 functions to have destructors.
167 - get rid if coro refcounting - simply crash in other interpreter
168 threads by nulling the pointers on clone.
169 - simplify warn/die hook handling when loading Coro - the convoluted
170 logic seems to be no longer neccessary.
171 - use libecb instead of our own home-grown gcc hacks.
172 - document alternatives to Coro::LWP. Please use them :)
173 - work around another mindless idiotic NEEDLESS bug in openbsd/mirbsds
174 sigaltstack. Really. wine suffers from it, erlang suffers from it,
175 and it's known since at least 2006.
176
1775.372 Wed Feb 23 06:14:30 CET 2011
178 - apparently mingw doesn't provide a working gettimeofday, try to
179 work around that by relying on Time::HiRes (indirectly brought to
180 my attention by Max Maischein).
181 - fix some portability issues when Time::HiRes was used.
182
1835.371 Mon Feb 21 14:36:08 CET 2011
184 - backport to windows process emulation code again.
185
1865.37 Sat Feb 19 07:49:44 CET 2011
187 - add a big "Coro thread life cycle" section to "man Coro".
188 - try a tentative workaround against the breakage that 5.13 has
189 introduced without depreciation period. sigh.
190 - no longer use Time::HiRes if gettimeofday is available, which
191 saves quite a lot of memory.
192
1935.36 Sun Feb 13 05:33:41 CET 2011
194 - automatically load Coro::Channel, Coro::RWLock, Coro::Semaphore,
195 Coro::SemaphoreSet, Coro::Signal and Coro::Specific on first "new"
196 method call.
197 - undocument Coro::Timer::sleep and obsolete whole module.
198 - optimise Coro::Timer::timeout memory and cpu usage.
199 - slightly updated Coro::Intro for recent changes.
200 - do not initialise PL_dirty anymore.
201
2025.25 Thu Nov 11 01:08:39 CET 2010
203 - try a different approach on netbsd - netbsd 5 finally has marginally
204 working pthreads, but still broken ucontext/sigaltstack.
205 - openbsd 4.8 finally got their act together, Coro works out of the box
206 with asm, setjmp and pthreads (no change, just informational).
207
2085.24 Sat Oct 23 11:27:12 CEST 2010
209 - port to the EV 4.0 API.
210 - work around bugs in mingw32, making strawberry perl work
211 out of the box.
212 - correctly modify Coro::AIO function prototypes
213 so that they reflect the "no optional parameters" rule.
214 - "ported" libcoro to C++.
215
2165.23 Mon May 17 18:50:42 CEST 2010
217 - be more resistant to ordering changes when initialising
218 Coro::AnyEvent, Coro::EV and Coro::Event (reported by Matthias
219 Waldorf).
220 - document that perl 5.12 deliberately removed support for cloning.
221
2225.22 Wed Apr 14 03:55:35 CEST 2010
223 - correctly return udnef on errors in Coro::Handle::read/write
224 (testcase by Marc Mims).
225 - convert Coro::Util into a "perl compatibility wrapper" - the functions
226 are less useful now, but are drop-in replacements for existing
227 functions, listing better alternatives in the documentation. This also
228 fixes a bug in Coro::LWP which naively substituted Socket::inet_aton
229 with Coro::Util::inet_aton.
230 - do not override $Coro::idle unconditionally in Coro.pm, as other
231 modules could have provided their own idle coro already
232 (for exmaple, Coro::AnyEvent).
233 - fix Coro::Util::gethost* functions.
234 - Coro::Timer corretcly exports it's symbols (reported by Hideki Yamamura).
235
2365.21 Wed Dec 16 07:19:51 CET 2009
237 - automatically load Coro::AnyEvent when AnyEvent and Coro are used
238 together.
239 - add some examples on how to combine other event loops with Coro in
240 Coro::AnyEvent, and how to run it (and not to block). Seems to be
241 the most common source of confusion.
242 - try to catch people naively blocking in an event callback.
243 - work around the perl filehandle bug issue in conjunction with
244 older common::sense (as indirectly pointed out by ZSystem).
245 - clarify the "not from signal handlers" section.
246
2475.2 Sun Oct 4 14:54:24 CEST 2009
248 - Coro::Storable destroyed the prototypes of the functions it wrapped.
249 - export rouse_cb and rouse_wait by default now.
250 - fix various prototype mismatches in Coro::AnyEvent and Coro::Handle.
251 - new method $state->swap_sv.
252 - added section on "windows process emulation" to the manpage,
253 after a not-so-fruitful (nor-friendly) "discussion" with chip
254 salzenberg (discussion implies arguments, but his only arguments
255 were ad-hominems, one wonders why he started it in the first
256 place). I hope this explains it well enough for him to understand,
257 and maybe well enough for others to understand.
258 - use common::sense everywhere now.
259 - idle callbacks are no longer supported, use idle coros instead.
260 - print a thread listing when a deadlock is detected.
261
2625.17 Sat Aug 22 23:09:31 CEST 2009
263 - work around a bug in the perl debugger causing crashes
264 when running under the debugger by marking _pool_handler as nodebug.
265 - speed up Coro::async considerably.
266 - try some hacks to get netbsd to work "more often" - their broken
267 setjmp/longjmp, ucontext *and* phtreads are really hard on Coro.
268 - convert Coro to AE 5.0 API.
269
2705.162 Tue Jul 28 04:04:03 CEST 2009
271 - perl 5.8.2 is now minimum requirement.
272 - skip t/19_handle.t on broken windows perls.
273
2745.161 Wed Jul 22 04:47:38 CEST 2009
275 - Coro::AnyEvent::poll could have a different prototype when EV was
276 used as backend (analyzed by Tatsuhiko Miyagawa).
277 - Coro::AnyEvent errornously initialised the event loop when loaded,
278 not on demand.
279 - try to workaround rare */t/01_unblock.t failures.
280
2815.16 Tue Jul 21 01:44:37 CEST 2009
282 - Coro::AnyEvent failed to hook into the event loop
283 when no threads had been readied between detecting
284 the event loop and actually running it.
285 - considerably speed up Coro::Select by taking avdantage
286 of AnyEvent > 4.8 and some other optimisations.
287 - implement paragraph readline mode in Coro::Handle
288 (based on patches by Zsbán Ambrus).
289 - replace WSAEINPROGRESS by WSAEWOULDBLOCK (reported
290 and analyzed by Yasuhiro MATSUMOTO).
291 - clarified libcoro license and copyright.
292 - someone stole my EXTRA_META!!!
293 - implement Coro::Select::patch_pp_sselect and it's brother,
294 for hardcode select overriding.
295
2965.151 Mon Jul 6 05:41:57 CEST 2009
297 - backport to windows process emulation code again (patch by
298 Yasuhiro MATSUMOTO).
299 - slightly update Coro::MakeMaker.
300
3015.15 Tue Jun 30 10:28:06 CEST 2009
302 - deprecate Coro::Socket, document how to get ipv6 support via
303 AnyEvent::Socket instead.
304 - implement signal->wait ($cb) interface, similar to semaphores.
305 - work around SvOK not supporting getmagic, so we have to getmagic
306 to test for undef :/ (reported by Matthias Waldorf).
307 - load Coro::AnyEvent in all modules using AnyEvent.
308 - work around perl corrupting our internal data structures,
309 reported by Tokuhiro Matsuno.
310 - enable per-coroutine real and cpu time gathering
311 (Coro::State::enable_times).
312
3135.14 Wed Jun 24 01:37:48 CEST 2009
11 - provide explicit functions to "cede" to the event loop in Coro::AnyEvent, 314 - provide explicit functions to "cede" to the event loop in Coro::AnyEvent,
12 as this seems to have been a difficult concept (poll, sleep, idle, 315 as this seems to have been a difficult concept (poll, sleep, idle,
13 idle_upto). 316 idle_upto).
14 - add Coro::AnyEvent::readable/writable functions. 317 - add Coro::AnyEvent::readable/writable functions.
15 - clarify Coro::EV/Event/AnyEvent manpages. 318 - clarify Coro::EV/Event/AnyEvent manpages.
16 - free per-thread global scalars in the thread calling ->cancel, to 319 - free per-thread global scalars in the thread calling ->cancel, to
17 avoid crashes when $_, $@ etc., are magical but some of those 320 avoid crashes when $_, $@ etc., are magical but some of those
18 had already been freed. 321 had already been freed.
19 - "unexperimentalize" the callback interface for Coro::Semaphore. 322 - "unexperimentalise" the callback interface for Coro::Semaphore.
20 - speed up ready queue management/context switching by using a linked 323 - speed up ready queue management/context switching by using a linked
21 list instead of an array (~5-10%). 324 list instead of an array (~5-10%).
22 - implement "watch" command in Coro::Debug shells. 325 - implement "watch" command in Coro::Debug shells.
23 - for fun, implement time-slicing as an example in the manpage. 326 - for fun, implement time-slicing as an example in the manpage.
24 - if AnyEvent detects EV or Event, but we don't have Coro::EV or 327 - if AnyEvent detects EV or Event, but we don't have Coro::EV or
195 - ->throw is now supported on Coro::State objects. 498 - ->throw is now supported on Coro::State objects.
196 - clean up cctx creation code a bit. 499 - clean up cctx creation code a bit.
197 - entersub is actually a UNOP, not a LOGOP (not a bugfix). 500 - entersub is actually a UNOP, not a LOGOP (not a bugfix).
198 501
1994.9 Sat Nov 8 17:45:27 CET 2008 5024.9 Sat Nov 8 17:45:27 CET 2008
200 - (libcoro) did not preserve rbp with CORO_ASM (we are getting there). 503 - (libcoro) did not preserve rbp with CORO_ASM (we are getting there).
201 - (libcoro) no longer leak threads in the experimental pthread backend, 504 - (libcoro) no longer leak threads in the experimental pthread backend,
202 also speed it up considerably. 505 also speed it up considerably.
203 - (libcoro) do not rely on makecontext passing void *'s unscathed. 506 - (libcoro) do not rely on makecontext passing void *'s unscathed.
204 - fix compiletime dependencies on libcoro in the Makefile. 507 - fix compiletime dependencies on libcoro in the Makefile.
205 - cctx_count wasn't always updated properly. 508 - cctx_count wasn't always updated properly.
267 - remove debugging code related to MgPV_nolen_const, also try to 570 - remove debugging code related to MgPV_nolen_const, also try to
268 make it compile with perl 5.8.6 (yes, apple apparently loves 571 make it compile with perl 5.8.6 (yes, apple apparently loves
269 outdated software). Reported by John S. 572 outdated software). Reported by John S.
270 573
2714.744 Tue Jul 8 22:06:35 CEST 2008 5744.744 Tue Jul 8 22:06:35 CEST 2008
272 - correctly provide default DIE/WARN handlers as documented. 575 - correctly provide default DIE/WARN handlers as documented.
273 - also overwrite PL_vtbl_sigelem.svt_clear, even though current 576 - also overwrite PL_vtbl_sigelem.svt_clear, even though current
274 implementations inside perl work fine for us. 577 implementations inside perl work fine for us.
275 578
2764.743 Mon Jun 16 00:21:57 CEST 2008 5794.743 Mon Jun 16 00:21:57 CEST 2008
277 - when using Coro::EV without running EV::loop it could 580 - when using Coro::EV without running EV::loop it could
299 - sprinkle "no warnings" freely over everything, also suppress 602 - sprinkle "no warnings" freely over everything, also suppress
300 warnings for some other modules. 603 warnings for some other modules.
301 - fix typo in WSAEWOULDBLOCK. 604 - fix typo in WSAEWOULDBLOCK.
302 605
3034.72 Sun May 25 05:14:36 CEST 2008 6064.72 Sun May 25 05:14:36 CEST 2008
304 - tweak META.yaml a bit, unfortunately, there is no documented way 607 - tweak META.yaml a bit, unfortunately, there is no documented way
305 to have optional dependencies with CPAN. doh :( 608 to have optional dependencies with CPAN. doh :(
306 - avoid running some tests on windows because they would fail due to 609 - avoid running some tests on windows because they would fail due to
307 perl bug (broken fork, broken pipes...). 610 perl bug (broken fork, broken pipes...).
308 - work around perl on windows bugs where perl returns undocumented 611 - work around perl on windows bugs where perl returns undocumented
309 error codes for sysread, syswrite etc. by taking advantage 612 error codes for sysread, syswrite etc. by taking advantage
313 - use unix domain sockets in testsuite to work around 616 - use unix domain sockets in testsuite to work around
314 common perl implementation bugs on widows (they are emulated by 617 common perl implementation bugs on widows (they are emulated by
315 tcp sockets on windows. ugh.) 618 tcp sockets on windows. ugh.)
316 619
3174.71 Sat May 24 20:01:27 CEST 2008 6204.71 Sat May 24 20:01:27 CEST 2008
318 - fix a bug in Coro::AnyEvent ("Usage: Coro::AnyEvent::_schedule()"). 621 - fix a bug in Coro::AnyEvent ("Usage: Coro::AnyEvent::_schedule()").
319 - take advantage of async name resolution of AnyEvent::Util. 622 - take advantage of async name resolution of AnyEvent::Util.
320 - work around brutal inet_aton override in Coro::LWP. 623 - work around brutal inet_aton override in Coro::LWP.
321 - take advantage of the readyhook in Coro::EV, for smoother 624 - take advantage of the readyhook in Coro::EV, for smoother
322 scheduling. 625 scheduling.
323 626
3244.7 Sun May 11 00:32:19 CEST 2008 6274.7 Sun May 11 00:32:19 CEST 2008
325 - completely reworked the Coro manpage. 628 - completely reworked the Coro manpage.
326 - added Coro::AnyEvent, generic event loop integration. 629 - added Coro::AnyEvent, generic event loop integration.
327 - implement cancel, ready and kill commands in Coro::Debug. 630 - implement cancel, ready and kill commands in Coro::Debug.
328 - document find_coro in Coro::Debug. 631 - document find_coro in Coro::Debug.
329 - incompatible change: rename has_stack to has_cctx. 632 - incompatible change: rename has_stack to has_cctx.
330 - Coro::AIO and Coro::BDB no longer force event model detection, 633 - Coro::AIO and Coro::BDB no longer force event model detection,
331 use AnyEvent::AIO and AnyEvent::BDB. 634 use AnyEvent::AIO and AnyEvent::BDB.
455 758
4564.11 Thu Oct 11 02:40:24 CEST 2007 7594.11 Thu Oct 11 02:40:24 CEST 2007
457 - port to threaded perls. 760 - port to threaded perls.
458 761
4594.1 Thu Oct 11 02:38:16 CEST 2007 7624.1 Thu Oct 11 02:38:16 CEST 2007
460 - incompatible change: $SIG{__DIE__} and $SIG{__WARN__} will now 763 - incompatible change: $SIG{__DIE__} and $SIG{__WARN__} will now
461 be local to each coro (see Coro::State). 764 be local to each coro (see Coro::State).
462 - incompatible change: for very deep reasons, cede and cede_notself 765 - incompatible change: for very deep reasons, cede and cede_notself
463 cannot return anything, so nothing will be returned. 766 cannot return anything, so nothing will be returned.
464 - possibly bring back 5.10 compatibility (untested). 767 - possibly bring back 5.10 compatibility (untested).
465 - work around stupid (and wrong) warning on 5.10 :(. 768 - work around stupid (and wrong) warning on 5.10 :(.
537 but stateful semantics. 840 but stateful semantics.
538 - fixed a lot of typos in Coro.pm (patch submitted by David 841 - fixed a lot of typos in Coro.pm (patch submitted by David
539 Steinbrunner, which applied flawlessly). 842 Steinbrunner, which applied flawlessly).
540 843
5413.6 Sat Apr 14 17:13:31 CEST 2007 8443.6 Sat Apr 14 17:13:31 CEST 2007
542 - added some bugfixes to get eg/myhttpd working again. 845 - added some bugfixes to get eg/myhttpd working again.
543 - added Coro::Storable for often-cede'ing freeze/thaw. 846 - added Coro::Storable for often-cede'ing freeze/thaw.
544 - try to do a clean exit when a coroutine calls exit 847 - try to do a clean exit when a coroutine calls exit
545 (EXPERIMENTAL). 848 (EXPERIMENTAL).
546 - got rid of indirect call through _coro_init. 849 - got rid of indirect call through _coro_init.
547 - updated the partly antique examples in eg/ to 850 - updated the partly antique examples in eg/ to

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines