ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/Coro/Changes
(Generate patch)

Comparing Coro/Changes (file contents):
Revision 1.293 by root, Sun Nov 25 13:53:48 2007 UTC vs.
Revision 1.525 by root, Thu Oct 1 23:50:23 2009 UTC

1Revision history for Perl extension Coro. 1Revision history for Perl extension Coro.
2 2
3TODO: should explore PerlIO::via::CoroCede and PerlIO::via::CoroAIO. 3TODO: should explore PerlIO::coroaio (perl leaks like hell).
4TODO: maybe implement a default message channel, very much like Erlang 4TODO: maybe implement a default message channel, very much like Erlang's
5 (which is cool in a lot of important aspects (failures!), 5 actor model (which is cool in a lot of important aspects (failures!),
6 but very lacking in others (higher level ipc)). 6 but very lacking in others (higher level ipc)).
7TODO: unready_all
8TODO: myhttpd header parsing
9TODO: channel->maxsize(newsize)?
7 10
84.22 11 - Coro::Storable destroyed the prototypes of the functions it wrapped.
12 - fix various prototype mismatches in Coro::AnyEvent and Coro::Handle.
13 - added section on "windows process emulation" to the manpage,
14 after a not-so-fruitful (nor-friendly) "discussion" with chip
15 salzenberg (discussion implies arguments, but his only arguments
16 were ad-hominems, one wonders why he started it in the first
17 place). I hope this explains it well enough for him to understand,
18 and maybe well enough for others to understand.
19 - use common::sense everywhere now.
20 - mark all SLF functions as nodebug, to avoid more debugger bugs.
21 - idle callbacks are no longer supported, use idle coros instead.
22 - print a thread listing when a deadlock is detected.
23
245.17 Sat Aug 22 23:09:31 CEST 2009
25 - work around a bug in the perl debugger causing crashes
26 when running under the debugger by marking _pool_handler as nodebug.
27 - speed up Coro::async considerably.
28 - try some hacks to get netbsd to work "more often" - their broken
29 setjmp/longjmp, ucontext *and* phtreads are really hard on Coro.
30 - convert Coro to AE 5.0 API.
31
325.162 Tue Jul 28 04:04:03 CEST 2009
33 - perl 5.8.2 is now minimum requirement.
34 - skip t/19_handle.t on broken windows perls.
35
365.161 Wed Jul 22 04:47:38 CEST 2009
37 - Coro::AnyEvent::poll could have a different prototype when EV was
38 used as backend (analyzed by Tatsuhiko Miyagawa).
39 - Coro::AnyEvent errornously initialised the event loop when loaded,
40 not on demand.
41 - try to workaround rare */t/01_unblock.t failures.
42
435.16 Tue Jul 21 01:44:37 CEST 2009
44 - Coro::AnyEvent failed to hook into the event loop
45 when no threads had been readied between detecting
46 the event loop and actually running it.
47 - considerably speed up Coro::Select by taking avdantage
48 of AnyEvent > 4.8 and some other optimisations.
49 - implement paragraph readline mode in Coro::Handle
50 (based on patches by Zsbán Ambrus).
51 - replace WSAEINPROGRESS by WSAEWOULDBLOCK (reported
52 and analyzed by Yasuhiro MATSUMOTO).
53 - clarified libcoro license and copyright.
54 - someone stole my EXTRA_META!!!
55 - implement Coro::Select::patch_pp_sselect and it's brother,
56 for hardcode select overriding.
57
585.151 Mon Jul 6 05:41:57 CEST 2009
59 - backport to windows process emulation code again (patch by
60 Yasuhiro MATSUMOTO).
61 - slightly update Coro::MakeMaker.
62
635.15 Tue Jun 30 10:28:06 CEST 2009
64 - deprecate Coro::Socket, document how to get ipv6 support via
65 AnyEvent::Socket instead.
66 - implement signal->wait ($cb) interface, similar to semaphores.
67 - work around SvOK not supporting getmagic, so we have to getmagic
68 to test for undef :/ (reported by Matthias Waldorf).
69 - load Coro::AnyEvent in all modules using AnyEvent.
70 - work around perl corrupting our internal data structures,
71 reported by Tokuhiro Matsuno.
72 - enable per-coroutine real and cpu time gathering
73 (Coro::State::enable_times).
74
755.14 Wed Jun 24 01:37:48 CEST 2009
76 - provide explicit functions to "cede" to the event loop in Coro::AnyEvent,
77 as this seems to have been a difficult concept (poll, sleep, idle,
78 idle_upto).
79 - add Coro::AnyEvent::readable/writable functions.
80 - clarify Coro::EV/Event/AnyEvent manpages.
81 - free per-thread global scalars in the thread calling ->cancel, to
82 avoid crashes when $_, $@ etc., are magical but some of those
83 had already been freed.
84 - "unexperimentalise" the callback interface for Coro::Semaphore.
85 - speed up ready queue management/context switching by using a linked
86 list instead of an array (~5-10%).
87 - implement "watch" command in Coro::Debug shells.
88 - for fun, implement time-slicing as an example in the manpage.
89 - if AnyEvent detects EV or Event, but we don't have Coro::EV or
90 Coro::Event, use the normal AnyEvent handling instead of dieing
91 (the same is true for Coro::Handle).
92 - properly document Coro::EV::timed_io_once.
93 - avoid unneccessary ->cancel calls in Coro::Handle.
94 - maybe make it work on mingw32 with win32 backend
95 (based on patch by Yasuhiro Matsumoto).
96
975.132 Fri May 29 09:00:39 CEST 2009
98 - do not keep a reference to the argument itself in
99 Coro::Semaphore::guard, as it could change later.
100 - support SO_RCVBUF/SO_SNDBUF nonstandard Coro::Socket options,
101 should support a prepare callback.
102
1035.131 Mon Mar 16 23:20:37 CET 2009
104 - implement and document Coro->suspend, Coro->resume.
105 - fix Coro::Select implementation to not (often) close
106 the passed file descriptors (testcase provided by pippijn).
107
1085.13 Mon Dec 15 21:51:42 CET 2008
109 - EXPERIMENTAL: implement dynamic winds (on_enter/on_leave).
110 - don't set diehook to C<undef> but instead to NULL, to avoid
111 spurious warnings.
112 - fix a lot of bugs in Coro::SemaphoreSet.
113 - Coro::SemaphoreSet will less often create a semaphore needlessly.
114 - add Coro::SemaphoreSet::count and wait methods.
115 - take advantage of the new Guard module.
116 - deprecate Coro::guard.
117 - try to fix the dreaded 01_unblock tests once more. I hate it when
118 testsuites need more fixing than the code they are supposed to test.
119 - croak in more cases when a required callback isn't resolvable.
120 - fix some minor issues in Coro::State->call/eval.
121 - use current coroutine context instead of a temporary one
122 when temporarily switching to another coroutine.
123 - do not call C-level on_destroy handlers during global destruction,
124 to avoid needless segfaults.
125
1265.12 Sun Dec 7 13:30:38 CET 2008
127 - add default config for MirOS, which seems to be a bug-to-bug
128 compatible fork of openbsd ("world domination by releasing
129 openbsd cvs before the openbsd folks do it" or so :).
130 - free_padlist did destroy the names pad, not good, but didn't
131 seem to bother perl - this could fix issues such as eval ""
132 inside a function called from multiple coroutines.
133 - use a different method to detect destruction time.
134 - be more careful when freeing padlists just before global
135 destruction.
136 - fixed and expanded the call/cc example.
137 - renamed _terminate to _coro_run.
138 - new method Coro::Channel->shutdown.
139 - try pthreads on openbsd <4.4 (broken sigaltstack, will
140 pthreads fare better?).
141 - be less picky about destroying "a" running coroutine.
142
1435.11 Tue Nov 25 21:49:05 CET 2008
144 - DEBUGGING in 5.10.0 is a mess: it constantly flags perfectly
145 working code with failed assertions, introducing more bugs than
146 it fixes, requiring elaborate workarounds :(
147
1485.1 Mon Nov 24 08:54:59 CET 2008
149 - wrote a small introductory tutorial - Coro::Intro.
150 - convert Coro::Timer, Coro::Select and Coro::Util to rouse API.
151 - Coro::Select did errornously dup the file descriptors
152 and didn't work with all AnyEvent backends.
153 - Coro::Select wasn't imported correctly form Coro::LWP, causing blocking
154 LWP data transfers.
155 - disassociate c contexts from coro objects - this is agruably more
156 correct, but mostly allows sharing of cctxs between coro and state
157 objects, for added memory savings and speed increases.
158 - bumped $Coro::POOL_RSS up to 32kb by default.
159 - no longer set the optype to OP_CUSTOM, as B::* understandably
160 doesn't like this very much (and we *are* a type of entersub).
161 - implement state cloning, just to prove that call/cc can be done.
162 - automatically load Coro::AnyEvent in Coro::Handle.
163 - wrap ->cancel calls in eval inside Coro::Handle as EV watchers
164 do not have this method (and don't need it either).
165 - speed up generic anyevent methods in Coro::Handle by using rouse
166 callbacks.
167 - allow coroutines in $Coro::IDLE, speeding up Coro::AnyEvent and
168 others. It also makes the debugger happier, as you can trace
169 through the idle threads now.
170 - add comppad_name* and hints ($^H, %^H) to per-thread variables.
171 - eg/event was pretty broken.
172 - better 5.8.6 compatibility.
173
1745.0 Thu Nov 20 10:35:05 CET 2008
175 - NEW ARCHITECTURE: use the latest 4.x version if you experience
176 stability issues.
177 - bump API version to 7 - all dependents must be recompiled.
178 - removed timed_* functions - they were not being used anyways
179 and should be replaced by a more generic mechanism -
180 and were annoying to support anyways :)
181 - removed SemaphoreSet's waiter method - use sem method instead.
182 - Coro::Semaphore->adjust didn't correctly wake up enough waiters.
183 - async_pool did free a scalar value twice
184 ("Attempt to unreference...").
185 - fix a longstanding bug where calling terminate on a coro that
186 was waiting for a semaphore that was just becoming available
187 would cause a deadlock (semaphore would get into a state where
188 it was available but waiters were still blocked).
189 - calling throw on a coroutine that is waiting for a semaphore will
190 no longer make it acquire the semaphore (and thus leak a count).
191 - perl's process emulation is now not even theoretically supported
192 anymore.
193 - new functions Coro::rouse_cb and Coro::rouse_wait for easier
194 conversion of callback-style to blocking-style.
195 - new methods $coro->schedule_to and ->cede_to, to specifically
196 schedule or cede to a specific coroutine.
197 - new function Coro::Semaphore::wait.
198 - use named constants in Coro::Channel (Richard Hundt).
199 - directly patch the entersub opcode calling SLF functions (cede,
200 transfer and so on). this does speed up context switching, but
201 more importanly, it frees us from the hardcoded behaviour of
202 entersub, so we might actually be able to return something from
203 those functions and atcually create new ones.
204 - take advantage of __builtin_frame_address on gcc.
205 - expose THX in coroapi (not sure whether this was a wise decision,
206 as "threaded" perls are running at half speed anyways).
207 - implement execute_slf (schedule-like-function) interface that makes
208 it possible to implement schedule-like-functions in XS.
209 - use new SLF interface to massively speed up Coro::EV by roughly a
210 factor of two.
211 - used new SLF interface to massively speed up Coro::Semaphore by a
212 factor of three.
213 - used new SLF interface to speed up Coro::AIO by roughly a factor of
214 four and reduce its memory usage considerably.
215 - implement Coro::SemaphoreSet purely in terms of Coro::Semaphore,
216 for a nice speedup and vastly more correct behaviour. Also implement
217 a new method "sem" to get at the underlying semaphore object.
218 - implement Coro::Channel in terms of Coro::Semaphore, for a moderate
219 (in comparison) 20-40% speedup.
220 - used new SLF interface to reimplement Coro::Signal gaining
221 some unknown (because I was too lazy), but certain, speedup, and also
222 making signals reliable for the first time.
223 - used new SLF interface and other optimisations to speed up async_pool
224 by a factor of two. It also doesn't rely on perl's exception mechanism
225 to exit anymore. The overhead for terminating an async_pool, coro over
226 a normal async is now very small.
227 - sped up coroutine creation/destruction by 40%.
228 - forgot to include Coro/libcoro/README in the dist for all these years.
229 - work around a freebsd pthreads bug (manual testcancel is required as
230 pthread_cond_wait isn't a cancellation point on freebsd).
231 - use new rouse functions to speed up and simplify Coro::BDB.
232 - make "prefer perl native functions" work with threaded perls.
233 - condense Coro::Debug ps output, hint at v and w flags.
234 - (libcoro) lots of minor cleanups and portability improvements.
235
2364.914 Wed Nov 19 12:54:18 CET 2008
237 - fix a disastrous bug in the readline optimisation
238 introduced in 4.801.
239
2404.913 Sat Nov 15 07:58:28 CET 2008
241 - async_pool did free a scalar value twice
242 ("Attempt to unreference...").
243
2444.912 Thu Nov 13 18:31:23 CET 2008
245 - minor cleanups.
246 - use much larger stacks on linux and perl < 5.8.8.
247 - Coro::Debug::new_unix_server did not unlink the socket
248 when destroyed.
249
2504.911 Tue Nov 11 04:26:17 CET 2008
251 - "port" to threaded perls.
252
2534.91 Mon Nov 10 05:36:38 CET 2008
254 - the ->throw exception object no longer leaks.
255 - creating a new cctx leaked a scopestack entry (memleak).
256 - new coroutines didn't get created with a zero flags field
257 (unknown impact).
258 - calling ->throw on a not-yet-started coroutine should now work
259 instead of being ignored.
260 - ->throw is now supported on Coro::State objects.
261 - clean up cctx creation code a bit.
262 - entersub is actually a UNOP, not a LOGOP (not a bugfix).
263
2644.9 Sat Nov 8 17:45:27 CET 2008
265 - (libcoro) did not preserve rbp with CORO_ASM (we are getting there).
266 - (libcoro) no longer leak threads in the experimental pthread backend,
267 also speed it up considerably.
268 - (libcoro) do not rely on makecontext passing void *'s unscathed.
269 - fix compiletime dependencies on libcoro in the Makefile.
270 - cctx_count wasn't always updated properly.
271 - Coro::State::cctx_stacksize wasn't applied correctly.
272 - new function Coro::State::cctx_max_idle.
273 - the default max number of idle C contexts is now 4.
274 - (libcoro) try harder to get _setjmp/_longjmp.
275 - (libcoro) cleanup and extend the libcoro API to officially
276 allow the creation of empty source contexts.
277 - very experimental workaround for the totally broken netbsd platform.
278 - tried to hack around openbsd bugs.
279
2804.804 Wed Nov 5 16:36:00 CET 2008
281 - Coro::Debug::new_unix_server would not create a non-blocking listening
282 socket, sometimes causing freezes.
283 - (libcoro) fix misaligned stack points for setjmp and assembly
284 methods, which can cause crashes on x86/x86_64 with a sufficiently
285 aggressive compiler.
286 - new function: Coro::Debug::new_tcp_server.
287 - move ->throw into the Coro class because it only works on coro objects.
288
2894.803 Mon Nov 3 17:16:12 CET 2008
290 - (libcoro) use a global asm statement to become independent of gcc
291 otpimisations for CORO_ASM (thanks to pippijn for the idea).
292 - try to workaround yet another broken bsd, this time dragonfly.
293
2944.802 Thu Oct 30 10:56:12 CET 2008
295 - support -fno-omit-frame-pointer on x86 with the assembly method.
296 - tune 01_unblock.t tests a bit.
297
2984.801 Wed Oct 22 18:33:37 CEST 2008
299 - improve readline speed for very long "lines".
300 - backport to 5.8.8.
301
3024.8 Thu Oct 2 13:34:40 CEST 2008
303 - new function Coro::AIO::aio_wait.
304 - Coro.:AIO and Coro::BDB now "use Coro::AnyEvent".
305 - greatly speed up and reduce memory usage of Coro::AIO requests.
306 - implement some other µ-optimisations.
307
3084.749 Mon Sep 29 14:40:12 CEST 2008
309 - port to slow and broken pseudo-threaded perls. (courtesy pippijn).
310
3114.748 Sat Sep 27 14:03:19 CEST 2008
312 - implement, but do not document, PerlIO::cede(granularity).
313 - Coro::Storable forgot to wrap Storable::pstore.
314 - work around the multitude of leaks and memory corruption
315 bugs in PerlIO::via by using our own C-level perliol. As a side
316 effect, Coro::Storable is now much, much, much faster.
317
3184.747 Tue Sep 23 01:59:41 CEST 2008
319 - fix a per-cv memleak (one empty array was leaked per
320 code reference).
321 - avoid a crash in coro->call|rss when the coroutine was already
322 destroyed (most noticably when using Coro::Debug::ps :)
323 - also protect *Storable::FILE.
324 - push up default storable granularity to 20ms.
325
3264.746 Sun Sep 21 03:22:20 CEST 2008
327 - be more insistent on locking Storable against reentrancy
328 in Coro::Storable.
329 - move swap_def?v and throw to Coro::State, as documented.
330
3314.745 Thu Jul 24 00:14:38 CEST 2008
332 - remove debugging code related to MgPV_nolen_const, also try to
333 make it compile with perl 5.8.6 (yes, apple apparently loves
334 outdated software). Reported by John S.
335
3364.744 Tue Jul 8 22:06:35 CEST 2008
337 - correctly provide default DIE/WARN handlers as documented.
338 - also overwrite PL_vtbl_sigelem.svt_clear, even though current
339 implementations inside perl work fine for us.
340
3414.743 Mon Jun 16 00:21:57 CEST 2008
342 - when using Coro::EV without running EV::loop it could
343 result in busy-waiting for events, this has been fixed.
344 - reduce codesize and improve performance by using EV_DEFAULT_UC.
345
3464.742 Sat May 31 14:10:21 CEST 2008
347 - implement a workaround for (some) perl <5.8.8 versions.
348 - require EV 3.3+.
349
3504.741 Fri May 30 23:33:09 CEST 2008
351 - tell netbsd how utterly broken their imitation of an OS is
352 and refuse to build by default if pthreads are in use.
353 - switch to "s" method on all bsd's by default, as their ucontext
354 stuff seems just too broken.
355 - fix a bug in Coro::Select.
356
3574.74 Thu May 29 20:05:31 CEST 2008
358 - do not test Coro::LWP for lack of dependencies.
359 - do not test Coro::Select for lack of working perls.
360
3614.73 Thu May 29 2008
362 - fix a bug in Coro::EV which would cause it to block despite
363 there being runnable coroutines.
364 - sprinkle "no warnings" freely over everything, also suppress
365 warnings for some other modules.
366 - fix typo in WSAEWOULDBLOCK.
367
3684.72 Sun May 25 05:14:36 CEST 2008
369 - tweak META.yaml a bit, unfortunately, there is no documented way
370 to have optional dependencies with CPAN. doh :(
371 - avoid running some tests on windows because they would fail due to
372 perl bug (broken fork, broken pipes...).
373 - work around perl on windows bugs where perl returns undocumented
374 error codes for sysread, syswrite etc. by taking advantage
375 of AnyEvent's workaround for that problem.
376 - use AnyEvent::Util::fh_nonblocking in Coro::Handle to work around
377 a common perl implementation bug on windows.
378 - use unix domain sockets in testsuite to work around
379 common perl implementation bugs on widows (they are emulated by
380 tcp sockets on windows. ugh.)
381
3824.71 Sat May 24 20:01:27 CEST 2008
383 - fix a bug in Coro::AnyEvent ("Usage: Coro::AnyEvent::_schedule()").
384 - take advantage of async name resolution of AnyEvent::Util.
385 - work around brutal inet_aton override in Coro::LWP.
386 - take advantage of the readyhook in Coro::EV, for smoother
387 scheduling.
388
3894.7 Sun May 11 00:32:19 CEST 2008
390 - completely reworked the Coro manpage.
391 - added Coro::AnyEvent, generic event loop integration.
392 - implement cancel, ready and kill commands in Coro::Debug.
393 - document find_coro in Coro::Debug.
394 - incompatible change: rename has_stack to has_cctx.
395 - Coro::AIO and Coro::BDB no longer force event model detection,
396 use AnyEvent::AIO and AnyEvent::BDB.
397
3984.6 Sat Apr 26 10:05:14 CEST 2008
399 - INCOMPATIBLE CHANGE: sub/code attributes are no longer supported
400 by the Coro module. It was a mistake to have it in the first place.
401 - (experimental) support for activestate perl 5.10 (method "w").
402 - (experimental) support for strawberry perl (method "a").
403 - coro_sigelem_set did not return a value although it had to,
404 actual impact unknown.
405
4064.51 Mon Apr 14 13:28:27 CEST 2008
407 - make it compile again on 5.8.
408
4094.50 Thu Apr 10 09:43:17 CEST 2008
410 - I did it twice! (see 4.49).
411
4124.49 Sun Apr 6 21:23:31 CEST 2008
413 - grr, instead of compiling the recent changes on 5.10 only they
414 were compiled on 5.8 only.
415
4164.48 Sun Apr 6 20:36:46 CEST 2008
417 - allow coroutine switches during eval's under 5.10.x, as it seems
418 the parser is a per-interpreter option now, so this is safe
419 (this might fix the odd crashing bug).
420 - drop support for 5.9.x versions: they are dead, jim.
421
4224.47 Sun Apr 6 00:37:52 CEST 2008
423 - force cctx allocation on API calls: we know we need to force one
424 and gcc actually manages to confuse our heuristic nowadays,
425 leading to crashes and worse.
426 - document force_cctx.
427
4284.46 Fri Apr 4 22:05:43 CEST 2008
429 - upgrade libcoro, resulting in pthread-backend (which was only created
430 to fulfill the rules of the programming languages shootout).
431
4324.45 Thu Mar 13 11:55:36 CET 2008
433 - fix a file leaking bug in eg/mhyttpd that would allow
434 downloading of any file (reported by oesi).
435 - fix deadlock bug in Coro::Channel (reported by Richard Hundt)
436 (also add testcase).
437 - support Broadcast option in Coro::Socket (patch by Richard Hundt,
438 apparently having loads of fun with that).
439 - implement $state->swap_defsv, ->swap_defav and document ->throw.
440
4414.4 Wed Feb 13 16:44:29 CET 2008
442 - only assume .cfi pseudo isns exist on GNU/Linux.
443 - add get_timed method to Coro::Channels.
444 - fixed Coro::Debug manpage.
445 - perl 5.11 compatbility improvement based on patch by
446 Andreas König.
447
4484.37 Sun Jan 20 11:25:23 CET 2008
449 - soften the check for an active parser for perl 5.10 (avoiding
450 "Coro::State::transfer called while parsing" in many cases).
451
4524.36 Sun Jan 13 10:53:56 CET 2008
453 - reset diehook when terminating from an async_pool as to not
454 trigger any __DIE__ handlers.
455
4564.35 Sun Jan 13 04:14:13 CET 2008
457 - "bt" debug command now displays any exceptions
458 from longmess and also skips the innermost
459 stackframes, giving more useufl output.
460 - allow backtraces in coroutines blocked in Coro::EV,
461 at a <1% speed hit.
462 - handle localising of $SIG{__WARN__} and __DIE__
463 properly (with a proper amount of dirty hacking).
464
4654.34 Sat Dec 22 17:49:53 CET 2007
466 - upgrade to EV version 2.0 API.
467
4684.33 Mon Dec 17 08:36:12 CET 2007
469 - make Coro::AIO etc. loadable in the absence of EV.
470
4714.32 Mon Dec 17 07:46:02 CET 2007
472 - majorly improved Coro::Handle's performance with Coro::EV.
473 - implemented the until now mythical Coro::BDB module.
474 - specialcase EV in Coro::AIO and Coro::BDB for extra speed.
475
4764.31 Wed Dec 5 12:32:39 CET 2007
477 - remove warn statement form Coro::Util.
478
4794.3 Tue Dec 4 20:33:14 CET 2007
480 - calls to the idle function could cause stack corruption
481 when the stack changed.
482 - do no longer rely on the presence of EV::DNS if EV is used
483 (because it is gone), but instead take avdantage of EV::ADNS
484 if available.
485 - add ($) prototypes to all functions in Coro::Storable.
486 - use a conventional (safer) idle callback in Coro::EV.
487 - do accept quickly in Coro::Debug to avoid endless loops.
488
4894.22 Fri Nov 30 16:04:04 CET 2007
9 - really use optimised versions for Event and EV in Coro::Util 490 - really use optimised versions for Event and EV in Coro::Util
10 and Coro::Handle. 491 and Coro::Handle.
11 492
124.21 Sun Nov 25 10:48:59 CET 2007 4934.21 Sun Nov 25 10:48:59 CET 2007
13 - fix a spurious memory read. 494 - fix a spurious memory read.

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines