ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/Coro/Changes
(Generate patch)

Comparing Coro/Changes (file contents):
Revision 1.88 by pcg, Sat Feb 14 12:39:41 2004 UTC vs.
Revision 1.358 by root, Fri May 30 21:34:52 2008 UTC

1Revision history for Perl extension Coro. 1Revision history for Perl extension Coro.
2 2
30.95 Fri Dec 12 20:50:57 CET 2003 3TODO: should explore PerlIO::via::CoroCede and PerlIO::via::CoroAIO.
4TODO: maybe implement a default message channel, very much like Erlang's
5 actor model (which is cool in a lot of important aspects (failures!),
6 but very lacking in others (higher level ipc)).
7
84.741 Fri May 30 23:33:09 CEST 2008
9 - tell netbsd how utterly broken their imitation of an OS is
10 and refuse to build by default if pthreads are in use.
11 - switch to "s" method on all bsd's by default, as their ucontext
12 stuff seems just too broken.
13 - fix a bug in Coro::Select.
14
154.74 Thu May 29 20:05:31 CEST 2008
16 - do not test Coro::LWP for lack of dependencies.
17 - do not test Coro::Select for lack of working perls.
18
194.73 Thu May 29 2008
20 - fix a bug in Coro::EV which would cause it to block despite
21 there being runnable coroutines.
22 - sprinkle "no warnings" freely over everything, also suppress
23 warnings for some other modules.
24 - fix typo in WSAEWOULDBLOCK.
25
264.72 Sun May 25 05:14:36 CEST 2008
27 - tweak META.yaml a bit, unfortunately, there is no documented way
28 to have optional dependencies with CPAN. doh :(
29 - avoid running some tests on windows because they would fail due to
30 perl bug (broken fork, broken pipes...).
31 - work around perl on windows bugs where perl returns undocumented
32 error codes for sysread, syswrite etc. by taking advantage
33 of AnyEvent's workaround for that problem.
34 - use AnyEvent::Util::fh_nonblocking in Coro::Handle to work around
35 a common perl implementation bug on windows.
36 - use unix domain sockets in testsuite to work around
37 common perl implementation bugs on widows (they are emulated by
38 tcp sockets on windows. ugh.)
39
404.71 Sat May 24 20:01:27 CEST 2008
41 - fix a bug in Coro::AnyEvent ("Usage: Coro::AnyEvent::_schedule()").
42 - take advantage of async name resolution of AnyEvent::Util.
43 - work around brutal inet_aton override in Coro::LWP.
44 - take advantage of the readyhook in Coro::EV, for smoother
45 scheduling.
46
474.7 Sun May 11 00:32:19 CEST 2008
48 - completely reworked the Coro manpage.
49 - added Coro::AnyEvent, generic event loop integration.
50 - implement cancel, ready and kill commands in Coro::Debug.
51 - document find_coro in Coro::Debug.
52 - incompatible change: rename has_stack to has_cctx.
53 - Coro::AIO and Coro::BDB no longer force event model detection,
54 use AnyEvent::AIO and AnyEvent::BDB.
55
564.6 Sat Apr 26 10:05:14 CEST 2008
57 - INCOMPATIBLE CHANGE: sub/code attributes are no longer supported
58 by the Coro module. It was a mistake to have it in the first place.
59 - (experimental) support for activestate perl 5.10 (method "w").
60 - (experimental) support for strawberry perl (method "a").
61 - coro_sigelem_set did not return a value although it had to,
62 actual impact unknown.
63
644.51 Mon Apr 14 13:28:27 CEST 2008
65 - make it compile again on 5.8.
66
674.50 Thu Apr 10 09:43:17 CEST 2008
68 - I did it twice! (see 4.49).
69
704.49 Sun Apr 6 21:23:31 CEST 2008
71 - grr, instead of compiling the recent changes on 5.10 only they
72 were compiled on 5.8 only.
73
744.48 Sun Apr 6 20:36:46 CEST 2008
75 - allow coroutine switches during eval's under 5.10.x, as it seems
76 the parser is a per-interpreter option now, so this is safe
77 (this might fix the odd crashing bug).
78 - drop support for 5.9.x versions: they are dead, jim.
79
804.47 Sun Apr 6 00:37:52 CEST 2008
81 - force cctx allocation on API calls: we know we need to force one
82 and gcc actually manages to confuse our heuristic nowadays,
83 leading to crashes and worse.
84 - document force_cctx.
85
864.46 Fri Apr 4 22:05:43 CEST 2008
87 - upgrade libcoro, resulting in pthread-backend (which was only created
88 to fulfill the rules of the programming languages shootout).
89
904.45 Thu Mar 13 11:55:36 CET 2008
91 - fix a file leaking bug in eg/mhyttpd that would allow
92 downloading of any file (reported by oesi).
93 - fix deadlock bug in Coro::Channel (reported by Richard Hundt)
94 (also add testcase).
95 - support Broadcast option in Coro::Socket (patch by Richard Hundt,
96 apparently having loads of fun with that).
97 - implement $state->swap_defsv, ->swap_defav and document ->throw.
98
994.4 Wed Feb 13 16:44:29 CET 2008
100 - only assume .cfi pseudo isns exist on GNU/Linux.
101 - add get_timed method to Coro::Channels.
102 - fixed Coro::Debug manpage.
103 - perl 5.11 compatbility improvement based on patch by
104 Andreas König.
105
1064.37 Sun Jan 20 11:25:23 CET 2008
107 - soften the check for an active parser for perl 5.10 (avoiding
108 "Coro::State::transfer called while parsing" in many cases).
109
1104.36 Sun Jan 13 10:53:56 CET 2008
111 - reset diehook when terminating from an async_pool as to not
112 trigger any __DIE__ handlers.
113
1144.35 Sun Jan 13 04:14:13 CET 2008
115 - "bt" debug command now displays any exceptions
116 from longmess and also skips the innermost
117 stackframes, giving more useufl output.
118 - allow backtraces in coroutines blocked in Coro::EV,
119 at a <1% speed hit.
120 - handle localising of $SIG{__WARN__} and __DIE__
121 properly (with a proper amount of dirty hacking).
122
1234.34 Sat Dec 22 17:49:53 CET 2007
124 - upgrade to EV version 2.0 API.
125
1264.33 Mon Dec 17 08:36:12 CET 2007
127 - make Coro::AIO etc. loadable in the absence of EV.
128
1294.32 Mon Dec 17 07:46:02 CET 2007
130 - majorly improved Coro::Handle's performance with Coro::EV.
131 - implemented the until now mythical Coro::BDB module.
132 - specialcase EV in Coro::AIO and Coro::BDB for extra speed.
133
1344.31 Wed Dec 5 12:32:39 CET 2007
135 - remove warn statement form Coro::Util.
136
1374.3 Tue Dec 4 20:33:14 CET 2007
138 - calls to the idle function could cause stack corruption
139 when the stack changed.
140 - do no longer rely on the presence of EV::DNS if EV is used
141 (because it is gone), but instead take avdantage of EV::ADNS
142 if available.
143 - add ($) prototypes to all functions in Coro::Storable.
144 - use a conventional (safer) idle callback in Coro::EV.
145 - do accept quickly in Coro::Debug to avoid endless loops.
146
1474.22 Fri Nov 30 16:04:04 CET 2007
148 - really use optimised versions for Event and EV in Coro::Util
149 and Coro::Handle.
150
1514.21 Sun Nov 25 10:48:59 CET 2007
152 - fix a spurious memory read.
153 - Coro::EV no longer keeps the eventloop "alive".
154
1554.2 Fri Nov 9 20:47:05 CET 2007
156 - enable/disable tracing from a new coroutine, not a pooled one.
157 - fix a memleak in Coro::Event.
158 - removed killall call from fork_eval.
159 - made sure store_fd is already loaded so that fork_eval
160 does not have to parse autoload in each subprocess.
161 - only use assembly method if -O switch is in $Config{optimize}.
162 - add (optional) Coro::EV module, so far the best event loop module
163 directly supported by Coro.
164 - if the event model is EV, use EV::DNS to resolve
165 stuff in Coro::Util.
166 - don't get confused by multiple event notifications in Coro::Handle.
167 - initial support for EV (libevent interface).
168 - require Event and EV using configure_requires, to force their existance.
169
1704.13 Wed Oct 24 07:26:45 CEST 2007
171 - add Coro::Storable::blocking_thaw.
172 - use a vastly more complicated technique to localise
173 $SIG{__WARN/DIE__} that also works on perls <= 5.8.8.
174 - use a coroutine for the idle callback Coro::Event,
175 instead of running Event in the current coroutine context.
176 This also catches recursive invocations.
177 - actually report fork errors in gethostbyname and inet_aton.
178
1794.11 Thu Oct 11 02:40:24 CEST 2007
180 - port to threaded perls.
181
1824.1 Thu Oct 11 02:38:16 CEST 2007
183 - incompatible change: $SIG{__DIE__} and $SIG{__WARN__} will now
184 be local to each coro (see Coro::State).
185 - incompatible change: for very deep reasons, cede and cede_notself
186 cannot return anything, so nothing will be returned.
187 - possibly bring back 5.10 compatibility (untested).
188 - work around stupid (and wrong) warning on 5.10 :(.
189 - overlay the saved state over the context stack. This saves
190 a few hundred bytes per coroutine on average and also
191 speeds up context switching a bit.
192 - further tune default stack sizes.
193 - (more) correctly calculate stack usage in coro_rss.
194 - Coro::Storable::blocking_* did not properly lock
195 resulting in races between coroutines.
196 - added Coro::Storable::guard.
197 - stopping to trace a coroutine could destroy the cctx of
198 an unrelated coroutine.
199 - explain the relationship between Perl and C coroutines in
200 more detail in Coro::State.
201 - Coro::Util::inet_aton did not short-circuit dotted quad forms,
202 causing a fork per resolve. This also affected Coro::Socket.
203 - switch to a separate stack in $coro->call/eval to avoid
204 invalidating pointers.
205
2064.03 Sat Oct 6 21:24:00 CEST 2007
207 - added Coro::throw method.
208 - minor code cleanups.
209
2104.02 Sat Oct 6 02:36:47 CEST 2007
211 - fix a very minor per-coroutine memleak (a single codereference).
212 - fixed a bug where the currently in-use c context would be freed
213 prematurely (can happen only when programs change the stacksize
214 or use tracing).
215 - tracing can no longer keep a coro alive after it terminated.
216 - do static branch prediction in the common path for gcc. gives
217 about 2-5% speed improvement here.
218
2194.01 Fri Oct 5 22:10:49 CEST 2007
220 - instead of recreating *a* standard output handle we simply
221 use STDOUT, which is faster and hopefully more robust.
222
2234.0 Fri Oct 5 12:56:00 CEST 2007
224 - incompatibly changed Coro::Storable::freeze.
225 - major new feature: added Coro::Debug, for interactive coroutine
226 debugging, tracing and much more.
227 - major bug fix: unbelievable, but true: $_, $/ and many other
228 "saved" variables actually weren't being saved. This has been fixed,
229 of course, while increasing performance while losing all the save
230 flags.
231 - save flags are gone, and all the api functions dealing with them.
232 - added Coro::Semaphore::adjust.
233 - added Coro::Util::fork_eval.
234 - added Coro::Storable::{nfreeze,blocking_{freeze,nfreeze}}.
235 - added Coro::killall.
236 - reduce initial stack sizes to allow for "micro-coroutines".
237 - better async_pool resource management, moved parts of async_pool
238 handling to XS (major speed improvement).
239 - actually croak before modifying important data structures.
240 - refuse to transfer while compiling.
241 - possibly support eval EXPR better now.
242 - enable assembly per default on linux+bsd x86+amd64.
243 - all internal members were renamed _something for easier subclassing.
244 - many minor tweaks.
245
2463.63 Wed May 16 14:10:06 CEST 2007
247 - implement handcoded assembly for x86/amd64 SVR ABI.
248
2493.62 Fri Apr 27 21:36:06 CEST 2007
250 - upgrade libcoro (which might set unwind info correctly).
251 - change default on linux to setjmp/longjmp.
252
2533.61 Thu Apr 19 12:36:18 CEST 2007
254 - Coro::Storable caused an endless loop when thawing invalid
255 pst's sometimes.
256 - use a Semaphore in Coro::Storable, as Storable doesn't
257 seem to be reentrant (although it is documented to
258 be threadsafe...).
259 - fix Coro::Signal to bring back the original unreliable
260 but stateful semantics.
261 - fixed a lot of typos in Coro.pm (patch submitted by David
262 Steinbrunner, which applied flawlessly).
263
2643.6 Sat Apr 14 17:13:31 CEST 2007
265 - added some bugfixes to get eg/myhttpd working again.
266 - added Coro::Storable for often-cede'ing freeze/thaw.
267 - try to do a clean exit when a coroutine calls exit
268 (EXPERIMENTAL).
269 - got rid of indirect call through _coro_init.
270 - updated the partly antique examples in eg/ to
271 work again and be a bit less magic, too.
272 - fixed Coro::Signal semantics to work as documented again.
273
2743.55 Sun Mar 25 01:20:47 CET 2007
275 - add SAVE_DEFFH to save the default filehandle and enable
276 it by default.
277 - finally move socket-operations from Coro::Socket to Coro::Handle
278 to be able to unblock foreign sockets.
279 - add Coro::State::save_also and guarded_save.
280 - add count accessor to Coro::Semaphore.
281 - add Coro::State::cctx_stacksize.
282 - just for the fun of it, do not rely on implicit context,
283 which can dramatically improve performance, but people
284 using windows-process-emulation perls do not care much about
285 performance.
286
2873.51 Sun Mar 4 14:18:04 CET 2007
288 - fixed a problem when you weakened references to Coro::State's
289 (patch by Yuval Kogman).
290
2913.501 Wed Feb 28 12:44:07 CET 2007
292 - rename some global symbols as macosx from hell redefines
293 them without asking.
294
2953.5 Tue Feb 13 20:22:53 CET 2007
296 - do AnyEvent model detection earlier, avoiding problems
297 caused by first using AnyEvent and later Coro::Event.
298 - implement and document Coro::Event event objects.
299 - fix a potential problem in Coro::Event causing crashes.
300 - initialise PL_comppad when creating a new coroutine,
301 avoids crashes on early coro destruction.
302
3033.41 Mon Jan 22 19:19:49 CET 2007
304 - readline on Coro::Handle did not support undefined $/,
305 nor did it deliver partial lines on EOF or error.
306 - implement malloc fallback for stack allocation because
307 stupid broken idiotic OSX has a stupid broken
308 idiotic fits-the-whole-os mmap "implementation" and
309 my dick feels longer if Coro is portable even to
310 obsolete platforms.
311
3123.4 Fri Jan 19 21:52:54 CET 2007
313 - remove t/09_timer.t, as it isn't really testing much
314 but was rather flaky in practise.
315 - async_pool coro would keep arguments and callback alive until
316 it was reused.
317 - cancellation of a coroutine could cause spurious idle calls
318 in cede_notself.
319
3203.3 Sat Jan 6 03:45:00 CET 2007
321 - implement $coro->on_destroy.
322 - Coro::Event blocking semantics have been changed,
323 documented and - hopefully - improved.
324 - fix nice adding, not subtracting, from priority.
325 - fix ->prio and api_is_ready (patch by Mark Hinds).
326 - fixed an assert ("... == prev__cctx->idle_te")
327 that could errronously trigger.
328 - fix various large and small memleaks.
329 - use a (hopefully) more stable cancel implementation
330 that immediately frees the coroutine data.
331 - cede/cede_notself return a status now.
332 - added Coro::guard function.
333 - added a global coroutine pool for jobs (on my machine,
334 I can create and execute 48k simple coros/s with async,
335 and 128k coros with async_pool).
336 - Coro::AIO now uses the coroutine priority as io priority.
337
3383.2 Fri Dec 22 05:07:09 CET 2006
339 - improve portability to slightly older perls.
340 - use cleaner coroutine destruction.
341 - simplify configuration for users.
342 - optionally (unrecommended) prefer perl functions over
343 their coro replacements.
344
3453.11 Tue Dec 5 13:11:24 CET 2006
346 - fixed some bogus assert's, but as perl.h disables assert even
347 without NDEBUG (thank you very much), not too many people should
348 notice (that did include myself). Andreas König noticed, though :)
349 - do not save/restore PL_sortcxix on >= 5.9.x, it doesn't seem to have
350 it. Also noticed by Andreas König :)
351 - save/restore tainted status.
352 - verified to pass the testsuite on my 5.9.5.
353
3543.1 Mon Dec 4 23:03:40 CET 2006
355 - INCOMPATIBLE CHANGE: $/ is now per-coroutine (but slow).
356 - incompatible change: transfer flags are now per-state.
357 - give a better error message on deadlock.
358 - document Coro::nready.
359 - enhanced testsuite.
360
3613.01 Sun Dec 3 23:47:42 CET 2006
362 - forgot to include Coro::Timer.
363
3643.0 Sun Dec 3 22:57:25 CET 2006
365 - the "FINALLY COMPLETELY STABLE" release (coming soon:
366 the "FAMOUS LAST WORDS" release).
367 - implement a new stack sharing algorithm, which uses a stack
368 pool (size currently hardcoded).
369 - make stack sharing mandatory (it no longer uses a heuristic).
370 - eval/die no longer cause weird problems under heavy use.
371 - Coro::Event could cause livelocks if it was used but
372 no Coro::Event watchers were used.
373 - Coro::Event now uses asynccheck as prepare does not
374 check for changed watchers.
375 - Coro::Event allows multiple waiting coros and will wake up one
376 per event.
377 - Coro::Event should be cleaner and more efficient now.
378 - new utility function Coro::unblock_sub.
379 - document the sad fact that Event is no longer reentrant.
380 - putting a coroutine into the ready queue twice could under
381 some circumstances lead to stack corruption.
382 - minor incompatibility: subclassing Coro::State is supported
383 directly now without going through a _coro_state member.
384 - state/coro switching is much faster now.
385 - very minor optimisations and code/documentation cleanup.
386 - avoid problems due to compiler inlining.
387 - removed timers from Coro::Timer -> use AnyEvent instead.
388 - replaced Coro::idle coroutine by (cleaner) idle handler.
389 - updated to newest libcoro.
390 - implement enhanced support for valgrind.
391 - implement is_ready and return value for ready.
392 - removed Coro::Cont, it was a misnomer (it's generators),
393 and it was somewhat annoying to get it right. Will come back
394 if somebody asks for it :)
395 - many ->wait methods and Coro::Event could return
396 spuriously without the event having happened.
397
3982.5 Tue Nov 7 12:22:33 CET 2006
399 - made Coro::Util, Coro::Select, Coro::Handle and Coro::Socket
400 use AnyEvent, moved them to Coro/.
401 - added Coro::LWP which contains all the uglyness required to
402 make LWP non-blocking.
403 - should work with perl 5.9.x now (Andreas König made me do it).
404 - fixed another bug in Coro::Select when the timeout was undef.
405 - reuse PL_start_env for all coros, saves some memory per coroutine.
406 - manage PL_top_env differently, hopefully to avoid panic: top_env.
407 - timeout argument was not properly used in Coro::Socket.
408 - allow limited forms of subclassing in Coro::Handle/Coro::Socket.
409 - emulate undocumented(!) functionality of IO::Socket required
410 by LWP(!!).
411 - updated eg/lwp to work with newer lwp's.
412 - remove "FATAL: uncaught exception" prefix. Coroutines that die
413 kill the whole process, just as exceptions in the main "coroutine"
414 did already.
415
4162.1 Wed Nov 1 23:01:13 CET 2006
417 - fix a long-standing bug in Coro::Select where select with
418 zero timeout would instead change the current default filehandle.
419 - use a simpler and hopefully more robust way to clone padlists
420 (uses less memory and a perl function instead of our own).
421 - coro can now create a stack guard area on many architectures.
422 - Coro::AIO properly reexports additional functions from IO::AIO.
423 - updated libcoro with a workaround for OS X,
424 pach and testing by Michael Schwern.
425
4262.0 Tue Oct 24 05:47:17 CEST 2006
427 - support additional aio requests in Coro::AIO.
428
4291.9 (never properly released due to a glitch)
430
4311.8 Thu Feb 2 00:59:06 CET 2006
432 - applied suggested patch by SAMV to avoid problems during stupid
433 mark & sweep gc run.
434 - applied patch by Scott Walters for 5.9.3 compatibility.
435
4361.7 Tue Dec 27 01:41:58 CET 2005
437 - added Coro::AIO, a thin wrapper around IO::AIO.
438 - improved Makefile.PL explanations.
439
4401.6 Mon Dec 12 21:30:05 CET 2005
441 - additionally save PM_curpm might fix as-of-yet
442 unseen problems with regex matches being attributed to the
443 wrong package.
444 - add t/10_bugs.t, which currently checks against imho broken
445 perls that use 0.26MB of stack space per Perl_magic_get
446 invocation (newer linuxes) as opposed to the 0.0002MB perl
447 normally uses.
448 - make stacksize configurable for the ultimate debian experience.
449
4501.51 Mon Dec 12 18:48:36 CET 2005
451 - remove debugging warn() accidentally left in Coro::Select.
452
4531.5 Tue Nov 29 13:32:44 CET 2005
454 - use Coro::Event inside Coro::Select to avoid spurious deadlocks.
455 - fix Coro::Select 'select'.
456 - strict'ify some modules.
457 - libcoro errornously restored the SIGUSR2 handler to SIGUSR1.
458 - use XSLoader in selected modules.
459 - remove some 5.6 compatibility cruft.
460
4611.4 Tue Sep 6 00:11:05 CEST 2005
462 - libcoro did not take into account the trampoline on amd64,
463 when 'l'inux method was used.
464
4651.31 Tue Aug 30 23:31:33 CEST 2005
466 - some portability fixes/workarounds.
467
4681.3 Sat Aug 20 03:08:56 CEST 2005
469 - no code changes. module seems to work fine.
470 - improve Coro::State docs, remove reference to nonexisting
471 Coro::State::flush method.
472 - no longer autodetect windows, present it as an option instead.
473
4741.2 Mon May 16 02:00:55 CEST 2005
475 - included libcoro.c earlier in State.xs, might improve portability.
476 - use a faster and possibly more stable Coro::Cont implementation.
477 - accept x86_64 in addition to amd64 for optimized linux-amd64 support.
478 - fix bugs Coro::SemaphoreSet that could cause locks never to be freed.
479 - fix bugs in CoroAPI.h and document it in Coro::MakeMaker.
480
4811.11 Thu Mar 3 18:00:52 CET 2005
482 - change of contact address.
483
4841.1 Tue Feb 22 20:51:16 CET 2005
485 - support [l]inux method on amd64.
486 - allow some context switches while compiling/eval'ing.
487
4881.0 Tue Aug 10 03:47:27 CEST 2004
489 - Event 0.89 fixes the bug again.
490 - fix the remaining(??) memleak. I didn't free the cache-AV for
491 padlists, so one AV per created anon-sub leaked.
492
4930.97 Fri May 14 15:23:32 CEST 2004
494 - remove stupid gcc extension that was an experiment only anyway.
495
4960.96 Thu May 13 18:09:29 CEST 2004
497 - tell people if they have yet another broken Event variant.
498 - made Coro to work _better_ with threads (it seems that, as long
499 as you use Coros in one thread only everything will work fine.
500 Looking at the perl source the problem might be missing locking
501 between Coro and some perl internal routines. That's not easily
502 fixable).
503 - (hopefully) got rid of the static xnext inside transfer.
504
5050.95 Sun Feb 15 03:20:28 CET 2004
4 - removed Coro::State::flush, implemented a new and much 506 - removed Coro::State::flush, implemented a new and much
5 faster caching mechanism by attaching magic to the CV. 507 faster caching mechanism by attaching magic to the CV.
6 - a memleak with (real) closures remains. 508 - a memleak with (real) closures remains.
7 - dramatically reduced size of stacks to 65536 (linux/x86), after 509 - dramatically reduced size of stacks to 65536 (linux/x86), after
8 observing that even myhttpd never had more than a kilobyte 510 observing that even myhttpd never had more than a kilobyte
9 of stack in use (stack is still only physically allocated in 511 of stack in use (stack is still only physically allocated in
10 pagesize increments for systems suporting mmap). 512 pagesize increments for systems suporting mmap).
513 - fix for a "cygwin-64" architecture added, proposed by Stefan Traby.
514 - fix for threaded perl.
11 515
120.9 Sun Nov 23 04:32:39 CET 2003 5160.9 Sun Nov 23 04:32:39 CET 2003
13 - fix a few very hard to track down but (of course) stupid 517 - fix a few very hard to track down but (of course) stupid
14 memory leaks. 518 memory leaks.
15 - stringify version number to avoid locale problems :(. 519 - stringify version number to avoid locale problems :(.

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines