ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/Coro/Coro/State.xs
(Generate patch)

Comparing Coro/Coro/State.xs (file contents):
Revision 1.187 by root, Fri Oct 5 20:31:18 2007 UTC vs.
Revision 1.195 by root, Sat Oct 6 00:35:41 2007 UTC

… …
75/* 5.8.7 */ 75/* 5.8.7 */
76#ifndef SvRV_set 76#ifndef SvRV_set
77# define SvRV_set(s,v) SvRV(s) = (v) 77# define SvRV_set(s,v) SvRV(s) = (v)
78#endif 78#endif
79 79
80/* 5.8.8 */
81#ifndef GV_NOTQUAL
82# define GV_NOTQUAL 0
83#endif
84#ifndef newSV
85# define newSV(l) NEWSV(0,l)
86#endif
87
80#if !__i386 && !__x86_64 && !__powerpc && !__m68k && !__alpha && !__mips && !__sparc64 88#if !__i386 && !__x86_64 && !__powerpc && !__m68k && !__alpha && !__mips && !__sparc64
81# undef CORO_STACKGUARD 89# undef CORO_STACKGUARD
82#endif 90#endif
83 91
84#ifndef CORO_STACKGUARD 92#ifndef CORO_STACKGUARD
… …
98#define IN_DESTRUCT (PL_main_cv == Nullcv) 106#define IN_DESTRUCT (PL_main_cv == Nullcv)
99 107
100#if __GNUC__ >= 3 108#if __GNUC__ >= 3
101# define attribute(x) __attribute__(x) 109# define attribute(x) __attribute__(x)
102# define BARRIER __asm__ __volatile__ ("" : : : "memory") 110# define BARRIER __asm__ __volatile__ ("" : : : "memory")
111# define expect(expr,value) __builtin_expect ((expr),(value))
103#else 112#else
104# define attribute(x) 113# define attribute(x)
105# define BARRIER 114# define BARRIER
115# define expect(expr,value) (expr)
106#endif 116#endif
117
118#define expect_false(expr) expect ((expr) != 0, 0)
119#define expect_true(expr) expect ((expr) != 0, 1)
107 120
108#define NOINLINE attribute ((noinline)) 121#define NOINLINE attribute ((noinline))
109 122
110#include "CoroAPI.h" 123#include "CoroAPI.h"
111 124
… …
132static AV *main_mainstack; /* used to differentiate between $main and others */ 145static AV *main_mainstack; /* used to differentiate between $main and others */
133static JMPENV *main_top_env; 146static JMPENV *main_top_env;
134static HV *coro_state_stash, *coro_stash; 147static HV *coro_state_stash, *coro_stash;
135static SV *coro_mortal; /* will be freed after next transfer */ 148static SV *coro_mortal; /* will be freed after next transfer */
136 149
137static GV *irsgv; /* $/ */ 150static GV *irsgv; /* $/ */
151static GV *stdoutgv; /* *STDOUT */
138 152
139/* async_pool helper stuff */ 153/* async_pool helper stuff */
140static SV *sv_pool_rss; 154static SV *sv_pool_rss;
141static SV *sv_pool_size; 155static SV *sv_pool_size;
142static AV *av_async_pool; 156static AV *av_async_pool;
… …
316 MAGIC *mg; 330 MAGIC *mg;
317 331
318 if (SvROK (coro)) 332 if (SvROK (coro))
319 coro = SvRV (coro); 333 coro = SvRV (coro);
320 334
321 if (SvTYPE (coro) != SVt_PVHV) 335 if (expect_false (SvTYPE (coro) != SVt_PVHV))
322 croak ("Coro::State object required"); 336 croak ("Coro::State object required");
323 337
324 stash = SvSTASH (coro); 338 stash = SvSTASH (coro);
325 if (stash != coro_stash && stash != coro_state_stash) 339 if (expect_false (stash != coro_stash && stash != coro_state_stash))
326 { 340 {
327 /* very slow, but rare, check */ 341 /* very slow, but rare, check */
328 if (!sv_derived_from (sv_2mortal (newRV_inc (coro)), "Coro::State")) 342 if (!sv_derived_from (sv_2mortal (newRV_inc (coro)), "Coro::State"))
329 croak ("Coro::State object required"); 343 croak ("Coro::State object required");
330 } 344 }
… …
340get_padlist (pTHX_ CV *cv) 354get_padlist (pTHX_ CV *cv)
341{ 355{
342 MAGIC *mg = CORO_MAGIC (cv); 356 MAGIC *mg = CORO_MAGIC (cv);
343 AV *av; 357 AV *av;
344 358
345 if (mg && AvFILLp ((av = (AV *)mg->mg_obj)) >= 0) 359 if (expect_true (mg && AvFILLp ((av = (AV *)mg->mg_obj)) >= 0))
346 CvPADLIST (cv) = (AV *)AvARRAY (av)[AvFILLp (av)--]; 360 CvPADLIST (cv) = (AV *)AvARRAY (av)[AvFILLp (av)--];
347 else 361 else
348 { 362 {
349#if CORO_PREFER_PERL_FUNCTIONS 363#if CORO_PREFER_PERL_FUNCTIONS
350 /* this is probably cleaner, but also slower? */ 364 /* this is probably cleaner, but also slower? */
… …
362put_padlist (pTHX_ CV *cv) 376put_padlist (pTHX_ CV *cv)
363{ 377{
364 MAGIC *mg = CORO_MAGIC (cv); 378 MAGIC *mg = CORO_MAGIC (cv);
365 AV *av; 379 AV *av;
366 380
367 if (!mg) 381 if (expect_false (!mg))
368 { 382 {
369 sv_magic ((SV *)cv, 0, PERL_MAGIC_coro, 0, 0); 383 sv_magic ((SV *)cv, 0, PERL_MAGIC_coro, 0, 0);
370 mg = mg_find ((SV *)cv, PERL_MAGIC_coro); 384 mg = mg_find ((SV *)cv, PERL_MAGIC_coro);
371 mg->mg_virtual = &vtbl_coro; 385 mg->mg_virtual = &vtbl_coro;
372 mg->mg_obj = (SV *)newAV (); 386 mg->mg_obj = (SV *)newAV ();
373 } 387 }
374 388
375 av = (AV *)mg->mg_obj; 389 av = (AV *)mg->mg_obj;
376 390
377 if (AvFILLp (av) >= AvMAX (av)) 391 if (expect_false (AvFILLp (av) >= AvMAX (av)))
378 av_extend (av, AvMAX (av) + 1); 392 av_extend (av, AvMAX (av) + 1);
379 393
380 AvARRAY (av)[++AvFILLp (av)] = (SV *)CvPADLIST (cv); 394 AvARRAY (av)[++AvFILLp (av)] = (SV *)CvPADLIST (cv);
381} 395}
382 396
… …
397 { 411 {
398 dSP; 412 dSP;
399 CV *cv; 413 CV *cv;
400 414
401 /* now do the ugly restore mess */ 415 /* now do the ugly restore mess */
402 while ((cv = (CV *)POPs)) 416 while (expect_true (cv = (CV *)POPs))
403 { 417 {
404 put_padlist (aTHX_ cv); /* mark this padlist as available */ 418 put_padlist (aTHX_ cv); /* mark this padlist as available */
405 CvDEPTH (cv) = PTR2IV (POPs); 419 CvDEPTH (cv) = PTR2IV (POPs);
406 CvPADLIST (cv) = (AV *)POPs; 420 CvPADLIST (cv) = (AV *)POPs;
407 } 421 }
… …
426 440
427 XPUSHs (Nullsv); 441 XPUSHs (Nullsv);
428 /* this loop was inspired by pp_caller */ 442 /* this loop was inspired by pp_caller */
429 for (;;) 443 for (;;)
430 { 444 {
431 while (cxix >= 0) 445 while (expect_true (cxix >= 0))
432 { 446 {
433 PERL_CONTEXT *cx = &ccstk[cxix--]; 447 PERL_CONTEXT *cx = &ccstk[cxix--];
434 448
435 if (CxTYPE (cx) == CXt_SUB || CxTYPE (cx) == CXt_FORMAT) 449 if (expect_true (CxTYPE (cx) == CXt_SUB || CxTYPE (cx) == CXt_FORMAT))
436 { 450 {
437 CV *cv = cx->blk_sub.cv; 451 CV *cv = cx->blk_sub.cv;
438 452
439 if (CvDEPTH (cv)) 453 if (expect_true (CvDEPTH (cv)))
440 { 454 {
441 EXTEND (SP, 3); 455 EXTEND (SP, 3);
442 PUSHs ((SV *)CvPADLIST (cv)); 456 PUSHs ((SV *)CvPADLIST (cv));
443 PUSHs (INT2PTR (SV *, CvDEPTH (cv))); 457 PUSHs (INT2PTR (SV *, CvDEPTH (cv)));
444 PUSHs ((SV *)cv); 458 PUSHs ((SV *)cv);
… …
447 get_padlist (aTHX_ cv); 461 get_padlist (aTHX_ cv);
448 } 462 }
449 } 463 }
450 } 464 }
451 465
452 if (top_si->si_type == PERLSI_MAIN) 466 if (expect_true (top_si->si_type == PERLSI_MAIN))
453 break; 467 break;
454 468
455 top_si = top_si->si_prev; 469 top_si = top_si->si_prev;
456 ccstk = top_si->si_cxstack; 470 ccstk = top_si->si_cxstack;
457 cxix = top_si->si_cxix; 471 cxix = top_si->si_cxix;
… …
594 PL_runops = RUNOPS_DEFAULT; 608 PL_runops = RUNOPS_DEFAULT;
595 PL_curcop = &PL_compiling; 609 PL_curcop = &PL_compiling;
596 PL_in_eval = EVAL_NULL; 610 PL_in_eval = EVAL_NULL;
597 PL_comppad = 0; 611 PL_comppad = 0;
598 PL_curpm = 0; 612 PL_curpm = 0;
613 PL_curpad = 1;
599 PL_localizing = 0; 614 PL_localizing = 0;
600 PL_dirty = 0; 615 PL_dirty = 0;
601 PL_restartop = 0; 616 PL_restartop = 0;
602 617
603 GvSV (PL_defgv) = NEWSV (0, 0); 618 GvSV (PL_defgv) = newSV (0);
604 GvAV (PL_defgv) = coro->args; coro->args = 0; 619 GvAV (PL_defgv) = coro->args; coro->args = 0;
605 GvSV (PL_errgv) = NEWSV (0, 0); 620 GvSV (PL_errgv) = newSV (0);
606 GvSV (irsgv) = newSVpvn ("\n", 1); sv_magic (GvSV (irsgv), (SV *)irsgv, PERL_MAGIC_sv, "/", 0); 621 GvSV (irsgv) = newSVpvn ("\n", 1); sv_magic (GvSV (irsgv), (SV *)irsgv, PERL_MAGIC_sv, "/", 0);
607 PL_rs = newSVsv (GvSV (irsgv)); 622 PL_rs = newSVsv (GvSV (irsgv));
608 623 PL_defoutgv = SvREFCNT_inc (stdoutgv);
609 SvREFCNT_inc (PL_defoutgv);
610 624
611 { 625 {
612 dSP; 626 dSP;
613 LOGOP myop; 627 LOGOP myop;
614 628
615 Zero (&myop, 1, LOGOP); 629 Zero (&myop, 1, LOGOP);
616 myop.op_next = Nullop; 630 myop.op_next = Nullop;
617 myop.op_flags = OPf_WANT_VOID; 631 myop.op_flags = OPf_WANT_VOID;
618 632
619 PUSHMARK (SP); 633 PUSHMARK (SP);
620 XPUSHs (av_shift (GvAV (PL_defgv))); 634 XPUSHs (sv_2mortal (av_shift (GvAV (PL_defgv))));
621 PUTBACK; 635 PUTBACK;
622 PL_op = (OP *)&myop; 636 PL_op = (OP *)&myop;
623 PL_op = PL_ppaddr[OP_ENTERSUB](aTHX); 637 PL_op = PL_ppaddr[OP_ENTERSUB](aTHX);
624 SPAGAIN; 638 SPAGAIN;
625 } 639 }
626 640
627 ENTER; /* necessary e.g. for dounwind */ 641 ENTER; /* necessary e.g. for dounwind and to balance the xsub-entersub */
628} 642}
629 643
630static void 644static void
631coro_destroy (pTHX_ struct coro *coro) 645coro_destroy (pTHX_ struct coro *coro)
632{ 646{
… …
661} 675}
662 676
663static void 677static void
664free_coro_mortal (pTHX) 678free_coro_mortal (pTHX)
665{ 679{
666 if (coro_mortal) 680 if (expect_true (coro_mortal))
667 { 681 {
668 SvREFCNT_dec (coro_mortal); 682 SvREFCNT_dec (coro_mortal);
669 coro_mortal = 0; 683 coro_mortal = 0;
670 } 684 }
671} 685}
… …
700 bot = PL_stack_base + cx->blk_oldsp + 1; 714 bot = PL_stack_base + cx->blk_oldsp + 1;
701 top = cx->blk_gimme == G_ARRAY ? SP + 1 715 top = cx->blk_gimme == G_ARRAY ? SP + 1
702 : cx->blk_gimme == G_SCALAR ? bot + 1 716 : cx->blk_gimme == G_SCALAR ? bot + 1
703 : bot; 717 : bot;
704 718
719 av_extend (av, top - bot);
705 while (bot < top) 720 while (bot < top)
706 av_push (av, SvREFCNT_inc (*bot++)); 721 av_push (av, SvREFCNT_inc (*bot++));
707 722
708 PL_runops = RUNOPS_DEFAULT; 723 PL_runops = RUNOPS_DEFAULT;
709 ENTER; 724 ENTER;
… …
921 Safefree (cctx->sptr); 936 Safefree (cctx->sptr);
922 937
923 Safefree (cctx); 938 Safefree (cctx);
924} 939}
925 940
941/* wether this cctx should be destructed */
942#define CCTX_EXPIRED(cctx) ((cctx)->ssize < coro_stacksize || ((cctx)->flags & CC_NOREUSE))
943
926static coro_cctx * 944static coro_cctx *
927cctx_get (pTHX) 945cctx_get (pTHX)
928{ 946{
929 while (cctx_first) 947 while (expect_true (cctx_first))
930 { 948 {
931 coro_cctx *cctx = cctx_first; 949 coro_cctx *cctx = cctx_first;
932 cctx_first = cctx->next; 950 cctx_first = cctx->next;
933 --cctx_idle; 951 --cctx_idle;
934 952
935 if (cctx->ssize >= coro_stacksize && !(cctx->flags & CC_NOREUSE)) 953 if (expect_true (!CCTX_EXPIRED (cctx)))
936 return cctx; 954 return cctx;
937 955
938 cctx_destroy (cctx); 956 cctx_destroy (cctx);
939 } 957 }
940 958
… …
943 961
944static void 962static void
945cctx_put (coro_cctx *cctx) 963cctx_put (coro_cctx *cctx)
946{ 964{
947 /* free another cctx if overlimit */ 965 /* free another cctx if overlimit */
948 if (cctx_idle >= MAX_IDLE_CCTX) 966 if (expect_false (cctx_idle >= MAX_IDLE_CCTX))
949 { 967 {
950 coro_cctx *first = cctx_first; 968 coro_cctx *first = cctx_first;
951 cctx_first = first->next; 969 cctx_first = first->next;
952 --cctx_idle; 970 --cctx_idle;
953 971
… …
959 cctx_first = cctx; 977 cctx_first = cctx;
960} 978}
961 979
962/** coroutine switching *****************************************************/ 980/** coroutine switching *****************************************************/
963 981
964static void NOINLINE 982static void
965transfer_check (pTHX_ struct coro *prev, struct coro *next) 983transfer_check (pTHX_ struct coro *prev, struct coro *next)
966{ 984{
967 if (prev != next) 985 if (expect_true (prev != next))
968 { 986 {
969 if (!(prev->flags & (CF_RUNNING | CF_NEW))) 987 if (expect_false (!(prev->flags & (CF_RUNNING | CF_NEW))))
970 croak ("Coro::State::transfer called with non-running/new prev Coro::State, but can only transfer from running or new states"); 988 croak ("Coro::State::transfer called with non-running/new prev Coro::State, but can only transfer from running or new states");
971 989
972 if (next->flags & CF_RUNNING) 990 if (expect_false (next->flags & CF_RUNNING))
973 croak ("Coro::State::transfer called with running next Coro::State, but can only transfer to inactive states"); 991 croak ("Coro::State::transfer called with running next Coro::State, but can only transfer to inactive states");
974 992
975 if (next->flags & CF_DESTROYED) 993 if (expect_false (next->flags & CF_DESTROYED))
976 croak ("Coro::State::transfer called with destroyed next Coro::State, but can only transfer to inactive states"); 994 croak ("Coro::State::transfer called with destroyed next Coro::State, but can only transfer to inactive states");
977 995
978 if (PL_lex_state != LEX_NOTPARSING) 996 if (expect_false (PL_lex_state != LEX_NOTPARSING))
979 croak ("Coro::State::transfer called while parsing, but this is not supported"); 997 croak ("Coro::State::transfer called while parsing, but this is not supported");
980 } 998 }
981} 999}
982 1000
983/* always use the TRANSFER macro */ 1001/* always use the TRANSFER macro */
… …
985transfer (pTHX_ struct coro *prev, struct coro *next) 1003transfer (pTHX_ struct coro *prev, struct coro *next)
986{ 1004{
987 dSTACKLEVEL; 1005 dSTACKLEVEL;
988 1006
989 /* sometimes transfer is only called to set idle_sp */ 1007 /* sometimes transfer is only called to set idle_sp */
990 if (!next) 1008 if (expect_false (!next))
991 { 1009 {
992 ((coro_cctx *)prev)->idle_sp = STACKLEVEL; 1010 ((coro_cctx *)prev)->idle_sp = STACKLEVEL;
993 assert (((coro_cctx *)prev)->idle_te = PL_top_env); /* just for the side-effect when asserts are enabled */ 1011 assert (((coro_cctx *)prev)->idle_te = PL_top_env); /* just for the side-effect when asserts are enabled */
994 } 1012 }
995 else if (prev != next) 1013 else if (expect_true (prev != next))
996 { 1014 {
997 coro_cctx *prev__cctx; 1015 coro_cctx *prev__cctx;
998 1016
999 if (prev->flags & CF_NEW) 1017 if (expect_false (prev->flags & CF_NEW))
1000 { 1018 {
1001 /* create a new empty context */ 1019 /* create a new empty context */
1002 Newz (0, prev->cctx, 1, coro_cctx); 1020 Newz (0, prev->cctx, 1, coro_cctx);
1003 prev->flags &= ~CF_NEW; 1021 prev->flags &= ~CF_NEW;
1004 prev->flags |= CF_RUNNING; 1022 prev->flags |= CF_RUNNING;
… …
1007 prev->flags &= ~CF_RUNNING; 1025 prev->flags &= ~CF_RUNNING;
1008 next->flags |= CF_RUNNING; 1026 next->flags |= CF_RUNNING;
1009 1027
1010 LOCK; 1028 LOCK;
1011 1029
1012 if (next->flags & CF_NEW) 1030 if (expect_false (next->flags & CF_NEW))
1013 { 1031 {
1014 /* need to start coroutine */ 1032 /* need to start coroutine */
1015 next->flags &= ~CF_NEW; 1033 next->flags &= ~CF_NEW;
1016 /* first get rid of the old state */ 1034 /* first get rid of the old state */
1017 save_perl (aTHX_ prev); 1035 save_perl (aTHX_ prev);
… …
1026 } 1044 }
1027 1045
1028 prev__cctx = prev->cctx; 1046 prev__cctx = prev->cctx;
1029 1047
1030 /* possibly "free" the cctx */ 1048 /* possibly "free" the cctx */
1031 if (prev__cctx->idle_sp == STACKLEVEL && !(prev__cctx->flags & CC_TRACE)) 1049 if (expect_true (prev__cctx->idle_sp == STACKLEVEL && !(prev__cctx->flags & CC_TRACE)))
1032 { 1050 {
1033 /* I assume that STACKLEVEL is a stronger indicator than PL_top_env changes */ 1051 /* I assume that STACKLEVEL is a stronger indicator than PL_top_env changes */
1034 assert (("ERROR: current top_env must equal previous top_env", PL_top_env == prev__cctx->idle_te)); 1052 assert (("ERROR: current top_env must equal previous top_env", PL_top_env == prev__cctx->idle_te));
1035 1053
1036 prev->cctx = 0; 1054 prev->cctx = 0;
1037 1055
1056 /* if the cctx is about to be destroyed we need to make sure we won't see it in cctx_get */
1057 /* without this the next cctx_get might destroy the prev__cctx while still in use */
1058 if (expect_false (CCTX_EXPIRED (prev__cctx)))
1059 next->cctx = cctx_get (aTHX);
1060
1038 cctx_put (prev__cctx); 1061 cctx_put (prev__cctx);
1039 } 1062 }
1040 1063
1041 ++next->usecount; 1064 ++next->usecount;
1042 1065
1043 if (!next->cctx) 1066 if (expect_true (!next->cctx))
1044 next->cctx = cctx_get (aTHX); 1067 next->cctx = cctx_get (aTHX);
1045 1068
1046 if (prev__cctx != next->cctx) 1069 if (expect_false (prev__cctx != next->cctx))
1047 { 1070 {
1048 prev__cctx->top_env = PL_top_env; 1071 prev__cctx->top_env = PL_top_env;
1049 PL_top_env = next->cctx->top_env; 1072 PL_top_env = next->cctx->top_env;
1050 coro_transfer (&prev__cctx->cctx, &next->cctx->cctx); 1073 coro_transfer (&prev__cctx->cctx, &next->cctx->cctx);
1051 } 1074 }
… …
1231 { 1254 {
1232 LOCK; 1255 LOCK;
1233 next_sv = coro_deq (aTHX_ PRIO_MIN); 1256 next_sv = coro_deq (aTHX_ PRIO_MIN);
1234 1257
1235 /* nothing to schedule: call the idle handler */ 1258 /* nothing to schedule: call the idle handler */
1236 if (!next_sv) 1259 if (expect_false (!next_sv))
1237 { 1260 {
1238 dSP; 1261 dSP;
1239 UNLOCK; 1262 UNLOCK;
1240 1263
1241 ENTER; 1264 ENTER;
… …
1251 } 1274 }
1252 1275
1253 ta->next = SvSTATE (next_sv); 1276 ta->next = SvSTATE (next_sv);
1254 1277
1255 /* cannot transfer to destroyed coros, skip and look for next */ 1278 /* cannot transfer to destroyed coros, skip and look for next */
1256 if (ta->next->flags & CF_DESTROYED) 1279 if (expect_false (ta->next->flags & CF_DESTROYED))
1257 { 1280 {
1258 UNLOCK; 1281 UNLOCK;
1259 SvREFCNT_dec (next_sv); 1282 SvREFCNT_dec (next_sv);
1260 /* coro_nready is already taken care of by destroy */ 1283 /* coro_nready is already taken care of by destroy */
1261 continue; 1284 continue;
… …
1317 dTHX; 1340 dTHX;
1318 struct transfer_args ta; 1341 struct transfer_args ta;
1319 1342
1320 prepare_cede (aTHX_ &ta); 1343 prepare_cede (aTHX_ &ta);
1321 1344
1322 if (ta.prev != ta.next) 1345 if (expect_true (ta.prev != ta.next))
1323 { 1346 {
1324 TRANSFER (ta); 1347 TRANSFER (ta);
1325 return 1; 1348 return 1;
1326 } 1349 }
1327 else 1350 else
… …
1378#ifdef USE_ITHREADS 1401#ifdef USE_ITHREADS
1379 MUTEX_INIT (&coro_mutex); 1402 MUTEX_INIT (&coro_mutex);
1380#endif 1403#endif
1381 BOOT_PAGESIZE; 1404 BOOT_PAGESIZE;
1382 1405
1383 irsgv = gv_fetchpv ("/", 1, SVt_PV); 1406 irsgv = gv_fetchpv ("/" , GV_ADD|GV_NOTQUAL, SVt_PV);
1407 stdoutgv = gv_fetchpv ("STDOUT", GV_ADD|GV_NOTQUAL, SVt_PVIO);
1384 1408
1385 coro_state_stash = gv_stashpv ("Coro::State", TRUE); 1409 coro_state_stash = gv_stashpv ("Coro::State", TRUE);
1386 1410
1387 newCONSTSUB (coro_state_stash, "CC_TRACE" , newSViv (CC_TRACE)); 1411 newCONSTSUB (coro_state_stash, "CC_TRACE" , newSViv (CC_TRACE));
1388 newCONSTSUB (coro_state_stash, "CC_TRACE_SUB" , newSViv (CC_TRACE_SUB)); 1412 newCONSTSUB (coro_state_stash, "CC_TRACE_SUB" , newSViv (CC_TRACE_SUB));
… …
1419 1443
1420 coro->hv = hv = newHV (); 1444 coro->hv = hv = newHV ();
1421 sv_magicext ((SV *)hv, 0, PERL_MAGIC_ext, &coro_state_vtbl, (char *)coro, 0)->mg_flags |= MGf_DUP; 1445 sv_magicext ((SV *)hv, 0, PERL_MAGIC_ext, &coro_state_vtbl, (char *)coro, 0)->mg_flags |= MGf_DUP;
1422 RETVAL = sv_bless (newRV_noinc ((SV *)hv), gv_stashpv (klass, 1)); 1446 RETVAL = sv_bless (newRV_noinc ((SV *)hv), gv_stashpv (klass, 1));
1423 1447
1448 av_extend (coro->args, items - 1);
1424 for (i = 1; i < items; i++) 1449 for (i = 1; i < items; i++)
1425 av_push (coro->args, newSVsv (ST (i))); 1450 av_push (coro->args, newSVsv (ST (i)));
1426} 1451}
1427 OUTPUT: 1452 OUTPUT:
1428 RETVAL 1453 RETVAL
… …
1471 } 1496 }
1472 1497
1473 BARRIER; 1498 BARRIER;
1474 TRANSFER (ta); 1499 TRANSFER (ta);
1475 1500
1476 if (GIMME_V != G_VOID && ta.next != ta.prev) 1501 if (expect_false (GIMME_V != G_VOID && ta.next != ta.prev))
1477 XSRETURN_YES; 1502 XSRETURN_YES;
1478} 1503}
1479 1504
1480bool 1505bool
1481_destroy (SV *coro_sv) 1506_destroy (SV *coro_sv)

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines