ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/Coro/Coro/State.xs
(Generate patch)

Comparing Coro/Coro/State.xs (file contents):
Revision 1.343 by root, Mon Dec 15 16:41:43 2008 UTC vs.
Revision 1.356 by root, Sat Jun 27 14:06:59 2009 UTC

137 137
138#define IN_DESTRUCT PL_dirty 138#define IN_DESTRUCT PL_dirty
139 139
140#if __GNUC__ >= 3 140#if __GNUC__ >= 3
141# define attribute(x) __attribute__(x) 141# define attribute(x) __attribute__(x)
142# define expect(expr,value) __builtin_expect ((expr),(value)) 142# define expect(expr,value) __builtin_expect ((expr), (value))
143# define INLINE static inline 143# define INLINE static inline
144#else 144#else
145# define attribute(x) 145# define attribute(x)
146# define expect(expr,value) (expr) 146# define expect(expr,value) (expr)
147# define INLINE static 147# define INLINE static
261/* this is a structure representing a perl-level coroutine */ 261/* this is a structure representing a perl-level coroutine */
262struct coro { 262struct coro {
263 /* the C coroutine allocated to this perl coroutine, if any */ 263 /* the C coroutine allocated to this perl coroutine, if any */
264 coro_cctx *cctx; 264 coro_cctx *cctx;
265 265
266 /* ready queue */
267 struct coro *next_ready;
268
266 /* state data */ 269 /* state data */
267 struct CoroSLF slf_frame; /* saved slf frame */ 270 struct CoroSLF slf_frame; /* saved slf frame */
268 AV *mainstack; 271 AV *mainstack;
269 perl_slots *slot; /* basically the saved sp */ 272 perl_slots *slot; /* basically the saved sp */
270 273
314#define PRIO_MIN -4 317#define PRIO_MIN -4
315 318
316/* for Coro.pm */ 319/* for Coro.pm */
317static SV *coro_current; 320static SV *coro_current;
318static SV *coro_readyhook; 321static SV *coro_readyhook;
319static AV *coro_ready [PRIO_MAX - PRIO_MIN + 1]; 322static struct coro *coro_ready [PRIO_MAX - PRIO_MIN + 1][2]; /* head|tail */
320static CV *cv_coro_run, *cv_coro_terminate; 323static CV *cv_coro_run, *cv_coro_terminate;
321static struct coro *coro_first; 324static struct coro *coro_first;
322#define coro_nready coroapi.nready 325#define coro_nready coroapi.nready
323 326
324/** lowlevel stuff **********************************************************/ 327/** lowlevel stuff **********************************************************/
612 { 615 {
613 while (expect_true (cxix >= 0)) 616 while (expect_true (cxix >= 0))
614 { 617 {
615 PERL_CONTEXT *cx = &ccstk[cxix--]; 618 PERL_CONTEXT *cx = &ccstk[cxix--];
616 619
617 if (expect_true (CxTYPE (cx) == CXt_SUB || CxTYPE (cx) == CXt_FORMAT)) 620 if (expect_true (CxTYPE (cx) == CXt_SUB) || expect_false (CxTYPE (cx) == CXt_FORMAT))
618 { 621 {
619 CV *cv = cx->blk_sub.cv; 622 CV *cv = cx->blk_sub.cv;
620 623
621 if (expect_true (CvDEPTH (cv))) 624 if (expect_true (CvDEPTH (cv)))
622 { 625 {
987} 990}
988 991
989static void 992static void
990coro_destruct_perl (pTHX_ struct coro *coro) 993coro_destruct_perl (pTHX_ struct coro *coro)
991{ 994{
995 SV *svf [9];
996
997 {
998 struct coro *current = SvSTATE_current;
999
1000 assert (("FATAL: tried to destroy currently running coroutine", coro->mainstack != PL_mainstack));
1001
1002 save_perl (aTHX_ current);
1003 load_perl (aTHX_ coro);
1004
992 coro_unwind_stacks (aTHX); 1005 coro_unwind_stacks (aTHX);
1006 coro_destruct_stacks (aTHX);
993 1007
994 SvREFCNT_dec (GvSV (PL_defgv)); 1008 // now save some sv's to be free'd later
995 SvREFCNT_dec (GvAV (PL_defgv)); 1009 svf [0] = GvSV (PL_defgv);
996 SvREFCNT_dec (GvSV (PL_errgv)); 1010 svf [1] = (SV *)GvAV (PL_defgv);
997 SvREFCNT_dec (PL_defoutgv); 1011 svf [2] = GvSV (PL_errgv);
998 SvREFCNT_dec (PL_rs); 1012 svf [3] = (SV *)PL_defoutgv;
999 SvREFCNT_dec (GvSV (irsgv)); 1013 svf [4] = PL_rs;
1000 SvREFCNT_dec (GvHV (PL_hintgv)); 1014 svf [5] = GvSV (irsgv);
1015 svf [6] = (SV *)GvHV (PL_hintgv);
1016 svf [7] = PL_diehook;
1017 svf [8] = PL_warnhook;
1018 assert (9 == sizeof (svf) / sizeof (*svf));
1001 1019
1002 SvREFCNT_dec (PL_diehook); 1020 load_perl (aTHX_ current);
1003 SvREFCNT_dec (PL_warnhook);
1004 1021 }
1022
1023 {
1024 int i;
1025
1026 for (i = 0; i < sizeof (svf) / sizeof (*svf); ++i)
1027 SvREFCNT_dec (svf [i]);
1028
1005 SvREFCNT_dec (coro->saved_deffh); 1029 SvREFCNT_dec (coro->saved_deffh);
1006 SvREFCNT_dec (coro->rouse_cb); 1030 SvREFCNT_dec (coro->rouse_cb);
1007 SvREFCNT_dec (coro->invoke_cb); 1031 SvREFCNT_dec (coro->invoke_cb);
1008 SvREFCNT_dec (coro->invoke_av); 1032 SvREFCNT_dec (coro->invoke_av);
1009 1033 }
1010 coro_destruct_stacks (aTHX);
1011} 1034}
1012 1035
1013INLINE void 1036INLINE void
1014free_coro_mortal (pTHX) 1037free_coro_mortal (pTHX)
1015{ 1038{
1484coro_state_destroy (pTHX_ struct coro *coro) 1507coro_state_destroy (pTHX_ struct coro *coro)
1485{ 1508{
1486 if (coro->flags & CF_DESTROYED) 1509 if (coro->flags & CF_DESTROYED)
1487 return 0; 1510 return 0;
1488 1511
1489 if (coro->on_destroy) 1512 if (coro->on_destroy && !PL_dirty)
1490 coro->on_destroy (aTHX_ coro); 1513 coro->on_destroy (aTHX_ coro);
1491 1514
1492 coro->flags |= CF_DESTROYED; 1515 coro->flags |= CF_DESTROYED;
1493 1516
1494 if (coro->flags & CF_READY) 1517 if (coro->flags & CF_READY)
1502 1525
1503 if (coro->mainstack 1526 if (coro->mainstack
1504 && coro->mainstack != main_mainstack 1527 && coro->mainstack != main_mainstack
1505 && coro->slot 1528 && coro->slot
1506 && !PL_dirty) 1529 && !PL_dirty)
1507 {
1508 struct coro *current = SvSTATE_current;
1509
1510 assert (("FATAL: tried to destroy currently running coroutine", coro->mainstack != PL_mainstack));
1511
1512 save_perl (aTHX_ current);
1513 load_perl (aTHX_ coro);
1514
1515 coro_destruct_perl (aTHX_ coro); 1530 coro_destruct_perl (aTHX_ coro);
1516
1517 load_perl (aTHX_ current);
1518
1519 coro->slot = 0;
1520 }
1521 1531
1522 cctx_destroy (coro->cctx); 1532 cctx_destroy (coro->cctx);
1523 SvREFCNT_dec (coro->startcv); 1533 SvREFCNT_dec (coro->startcv);
1524 SvREFCNT_dec (coro->args); 1534 SvREFCNT_dec (coro->args);
1525 SvREFCNT_dec (CORO_THROW); 1535 SvREFCNT_dec (CORO_THROW);
1612/** Coro ********************************************************************/ 1622/** Coro ********************************************************************/
1613 1623
1614INLINE void 1624INLINE void
1615coro_enq (pTHX_ struct coro *coro) 1625coro_enq (pTHX_ struct coro *coro)
1616{ 1626{
1617 av_push (coro_ready [coro->prio - PRIO_MIN], SvREFCNT_inc_NN (coro->hv)); 1627 struct coro **ready = coro_ready [coro->prio - PRIO_MIN];
1618}
1619 1628
1620INLINE SV * 1629 SvREFCNT_inc_NN (coro->hv);
1630
1631 coro->next_ready = 0;
1632 *(ready [0] ? &ready [1]->next_ready : &ready [0]) = coro;
1633 ready [1] = coro;
1634}
1635
1636INLINE struct coro *
1621coro_deq (pTHX) 1637coro_deq (pTHX)
1622{ 1638{
1623 int prio; 1639 int prio;
1624 1640
1625 for (prio = PRIO_MAX - PRIO_MIN + 1; --prio >= 0; ) 1641 for (prio = PRIO_MAX - PRIO_MIN + 1; --prio >= 0; )
1626 if (AvFILLp (coro_ready [prio]) >= 0) 1642 {
1627 return av_shift (coro_ready [prio]); 1643 struct coro **ready = coro_ready [prio];
1644
1645 if (ready [0])
1646 {
1647 struct coro *coro = ready [0];
1648 ready [0] = coro->next_ready;
1649 return coro;
1650 }
1651 }
1628 1652
1629 return 0; 1653 return 0;
1630} 1654}
1631 1655
1632static int 1656static int
1696static void 1720static void
1697prepare_schedule (pTHX_ struct coro_transfer_args *ta) 1721prepare_schedule (pTHX_ struct coro_transfer_args *ta)
1698{ 1722{
1699 for (;;) 1723 for (;;)
1700 { 1724 {
1701 SV *next_sv = coro_deq (aTHX); 1725 struct coro *next = coro_deq (aTHX);
1702 1726
1703 if (expect_true (next_sv)) 1727 if (expect_true (next))
1704 { 1728 {
1705 struct coro *next = SvSTATE_hv (next_sv);
1706
1707 /* cannot transfer to destroyed coros, skip and look for next */ 1729 /* cannot transfer to destroyed coros, skip and look for next */
1708 if (expect_false (next->flags & (CF_DESTROYED | CF_SUSPENDED))) 1730 if (expect_false (next->flags & (CF_DESTROYED | CF_SUSPENDED)))
1709 SvREFCNT_dec (next_sv); /* coro_nready has already been taken care of by destroy */ 1731 SvREFCNT_dec (next->hv); /* coro_nready has already been taken care of by destroy */
1710 else 1732 else
1711 { 1733 {
1712 next->flags &= ~CF_READY; 1734 next->flags &= ~CF_READY;
1713 --coro_nready; 1735 --coro_nready;
1714 1736
1988 SV *data = (SV *)GENSUB_ARG; 2010 SV *data = (SV *)GENSUB_ARG;
1989 2011
1990 if (SvTYPE (SvRV (data)) != SVt_PVAV) 2012 if (SvTYPE (SvRV (data)) != SVt_PVAV)
1991 { 2013 {
1992 /* first call, set args */ 2014 /* first call, set args */
2015 SV *coro = SvRV (data);
1993 AV *av = newAV (); 2016 AV *av = newAV ();
1994 SV *coro = SvRV (data);
1995 2017
1996 SvRV_set (data, (SV *)av); 2018 SvRV_set (data, (SV *)av);
1997 api_ready (aTHX_ coro);
1998 SvREFCNT_dec (coro);
1999 2019
2000 /* better take a full copy of the arguments */ 2020 /* better take a full copy of the arguments */
2001 while (items--) 2021 while (items--)
2002 av_store (av, items, newSVsv (ST (items))); 2022 av_store (av, items, newSVsv (ST (items)));
2023
2024 api_ready (aTHX_ coro);
2025 SvREFCNT_dec (coro);
2003 } 2026 }
2004 2027
2005 XSRETURN_EMPTY; 2028 XSRETURN_EMPTY;
2006} 2029}
2007 2030
2024 2047
2025 EXTEND (SP, AvFILLp (av) + 1); 2048 EXTEND (SP, AvFILLp (av) + 1);
2026 for (i = 0; i <= AvFILLp (av); ++i) 2049 for (i = 0; i <= AvFILLp (av); ++i)
2027 PUSHs (sv_2mortal (AvARRAY (av)[i])); 2050 PUSHs (sv_2mortal (AvARRAY (av)[i]));
2028 2051
2029 /* we have stolen the elements, so ste length to zero and free */ 2052 /* we have stolen the elements, so set length to zero and free */
2030 AvFILLp (av) = -1; 2053 AvFILLp (av) = -1;
2031 av_undef (av); 2054 av_undef (av);
2032 2055
2033 PUTBACK; 2056 PUTBACK;
2034 } 2057 }
2454/* Coro::Semaphore & Coro::Signal */ 2477/* Coro::Semaphore & Coro::Signal */
2455 2478
2456static SV * 2479static SV *
2457coro_waitarray_new (pTHX_ int count) 2480coro_waitarray_new (pTHX_ int count)
2458{ 2481{
2459 /* a semaphore contains a counter IV in $sem->[0] and any waiters after that */ 2482 /* a waitarray=semaphore contains a counter IV in $sem->[0] and any waiters after that */
2460 AV *av = newAV (); 2483 AV *av = newAV ();
2461 SV **ary; 2484 SV **ary;
2462 2485
2463 /* unfortunately, building manually saves memory */ 2486 /* unfortunately, building manually saves memory */
2464 Newx (ary, 2, SV *); 2487 Newx (ary, 2, SV *);
2608 { 2631 {
2609 /* callback form */ 2632 /* callback form */
2610 AV *av = (AV *)SvRV (arg [0]); 2633 AV *av = (AV *)SvRV (arg [0]);
2611 CV *cb_cv = coro_sv_2cv (aTHX_ arg [1]); 2634 CV *cb_cv = coro_sv_2cv (aTHX_ arg [1]);
2612 2635
2613 av_push (av, (SV *)SvREFCNT_inc_NN (cb_cv)); 2636 av_push (av, SvREFCNT_inc_NN (cb_cv));
2614 2637
2615 if (SvIVX (AvARRAY (av)[0]) > 0) 2638 if (SvIVX (AvARRAY (av)[0]) > 0)
2616 coro_semaphore_adjust (aTHX_ av, 0); 2639 coro_semaphore_adjust (aTHX_ av, 0);
2617 2640
2618 frame->prepare = prepare_nop; 2641 frame->prepare = prepare_nop;
2642 AvARRAY (av)[0] = AvARRAY (av)[1]; 2665 AvARRAY (av)[0] = AvARRAY (av)[1];
2643 AvARRAY (av)[1] = cb; 2666 AvARRAY (av)[1] = cb;
2644 2667
2645 cb = av_shift (av); 2668 cb = av_shift (av);
2646 2669
2670 if (SvTYPE (cb) == SVt_PVCV)
2671 {
2672 dSP;
2673 PUSHMARK (SP);
2674 XPUSHs (sv_2mortal (newRV_inc ((SV *)av)));
2675 PUTBACK;
2676 call_sv (cb, G_VOID | G_DISCARD | G_EVAL | G_KEEPERR);
2677 }
2678 else
2679 {
2647 api_ready (aTHX_ cb); 2680 api_ready (aTHX_ cb);
2648 sv_setiv (cb, 0); /* signal waiter */ 2681 sv_setiv (cb, 0); /* signal waiter */
2682 }
2683
2649 SvREFCNT_dec (cb); 2684 SvREFCNT_dec (cb);
2650 2685
2651 --count; 2686 --count;
2652 } 2687 }
2653} 2688}
2662static void 2697static void
2663slf_init_signal_wait (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2698slf_init_signal_wait (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2664{ 2699{
2665 AV *av = (AV *)SvRV (arg [0]); 2700 AV *av = (AV *)SvRV (arg [0]);
2666 2701
2702 if (items >= 2)
2703 {
2704 CV *cb_cv = coro_sv_2cv (aTHX_ arg [1]);
2705 av_push (av, SvREFCNT_inc_NN (cb_cv));
2706
2667 if (SvIVX (AvARRAY (av)[0])) 2707 if (SvIVX (AvARRAY (av)[0]))
2708 coro_signal_wake (aTHX_ av, 1); /* ust be the only waiter */
2709
2710 frame->prepare = prepare_nop;
2711 frame->check = slf_check_nop;
2712 }
2713 else if (SvIVX (AvARRAY (av)[0]))
2668 { 2714 {
2669 SvIVX (AvARRAY (av)[0]) = 0; 2715 SvIVX (AvARRAY (av)[0]) = 0;
2670 frame->prepare = prepare_nop; 2716 frame->prepare = prepare_nop;
2671 frame->check = slf_check_nop; 2717 frame->check = slf_check_nop;
2672 } 2718 }
2673 else 2719 else
2674 { 2720 {
2675 SV *waiter = newRV_inc (SvRV (coro_current)); /* owned by signal av */ 2721 SV *waiter = newSVsv (coro_current); /* owned by signal av */
2676 2722
2677 av_push (av, waiter); 2723 av_push (av, waiter);
2678 2724
2679 frame->data = (void *)sv_2mortal (SvREFCNT_inc_NN (waiter)); /* owned by process */ 2725 frame->data = (void *)sv_2mortal (SvREFCNT_inc_NN (waiter)); /* owned by process */
2680 frame->prepare = prepare_schedule; 2726 frame->prepare = prepare_schedule;
3205 3251
3206MODULE = Coro::State PACKAGE = Coro 3252MODULE = Coro::State PACKAGE = Coro
3207 3253
3208BOOT: 3254BOOT:
3209{ 3255{
3210 int i;
3211
3212 sv_pool_rss = coro_get_sv (aTHX_ "Coro::POOL_RSS" , TRUE); 3256 sv_pool_rss = coro_get_sv (aTHX_ "Coro::POOL_RSS" , TRUE);
3213 sv_pool_size = coro_get_sv (aTHX_ "Coro::POOL_SIZE" , TRUE); 3257 sv_pool_size = coro_get_sv (aTHX_ "Coro::POOL_SIZE" , TRUE);
3214 cv_coro_run = get_cv ( "Coro::_coro_run" , GV_ADD); 3258 cv_coro_run = get_cv ( "Coro::_coro_run" , GV_ADD);
3215 cv_coro_terminate = get_cv ( "Coro::terminate" , GV_ADD); 3259 cv_coro_terminate = get_cv ( "Coro::terminate" , GV_ADD);
3216 coro_current = coro_get_sv (aTHX_ "Coro::current" , FALSE); SvREADONLY_on (coro_current); 3260 coro_current = coro_get_sv (aTHX_ "Coro::current" , FALSE); SvREADONLY_on (coro_current);
3231 newCONSTSUB (coro_stash, "PRIO_NORMAL", newSViv (PRIO_NORMAL)); 3275 newCONSTSUB (coro_stash, "PRIO_NORMAL", newSViv (PRIO_NORMAL));
3232 newCONSTSUB (coro_stash, "PRIO_LOW", newSViv (PRIO_LOW)); 3276 newCONSTSUB (coro_stash, "PRIO_LOW", newSViv (PRIO_LOW));
3233 newCONSTSUB (coro_stash, "PRIO_IDLE", newSViv (PRIO_IDLE)); 3277 newCONSTSUB (coro_stash, "PRIO_IDLE", newSViv (PRIO_IDLE));
3234 newCONSTSUB (coro_stash, "PRIO_MIN", newSViv (PRIO_MIN)); 3278 newCONSTSUB (coro_stash, "PRIO_MIN", newSViv (PRIO_MIN));
3235 3279
3236 for (i = PRIO_MAX - PRIO_MIN + 1; i--; )
3237 coro_ready[i] = newAV ();
3238
3239 { 3280 {
3240 SV *sv = coro_get_sv (aTHX_ "Coro::API", TRUE); 3281 SV *sv = coro_get_sv (aTHX_ "Coro::API", TRUE);
3241 3282
3242 coroapi.schedule = api_schedule; 3283 coroapi.schedule = api_schedule;
3243 coroapi.schedule_to = api_schedule_to; 3284 coroapi.schedule_to = api_schedule_to;
3334 PROTOTYPE: 3375 PROTOTYPE:
3335 CODE: 3376 CODE:
3336 RETVAL = coro_nready; 3377 RETVAL = coro_nready;
3337 OUTPUT: 3378 OUTPUT:
3338 RETVAL 3379 RETVAL
3380
3381void
3382suspend (Coro::State self)
3383 PROTOTYPE: $
3384 CODE:
3385 self->flags |= CF_SUSPENDED;
3386
3387void
3388resume (Coro::State self)
3389 PROTOTYPE: $
3390 CODE:
3391 self->flags &= ~CF_SUSPENDED;
3339 3392
3340void 3393void
3341_pool_handler (...) 3394_pool_handler (...)
3342 CODE: 3395 CODE:
3343 CORO_EXECUTE_SLF_XS (slf_init_pool_handler); 3396 CORO_EXECUTE_SLF_XS (slf_init_pool_handler);
3418 av_push (*avp, SvREFCNT_inc (block)); 3471 av_push (*avp, SvREFCNT_inc (block));
3419 3472
3420 if (!ix) 3473 if (!ix)
3421 on_enterleave_call (aTHX_ block); 3474 on_enterleave_call (aTHX_ block);
3422 3475
3423 LEAVE; /* pp_entersub unfortunately forces an ENTER/LEAVE around xs calls */ 3476 LEAVE; /* pp_entersub unfortunately forces an ENTER/LEAVE around XS calls */
3424 SAVEDESTRUCTOR_X (ix ? coro_pop_on_leave : coro_pop_on_enter, (void *)coro); 3477 SAVEDESTRUCTOR_X (ix ? coro_pop_on_leave : coro_pop_on_enter, (void *)coro);
3425 ENTER; /* pp_entersub unfortunately forces an ENTER/LEAVE around xs calls */ 3478 ENTER; /* pp_entersub unfortunately forces an ENTER/LEAVE around XS calls */
3426} 3479}
3427 3480
3428 3481
3429MODULE = Coro::State PACKAGE = PerlIO::cede 3482MODULE = Coro::State PACKAGE = PerlIO::cede
3430 3483
3435MODULE = Coro::State PACKAGE = Coro::Semaphore 3488MODULE = Coro::State PACKAGE = Coro::Semaphore
3436 3489
3437SV * 3490SV *
3438new (SV *klass, SV *count = 0) 3491new (SV *klass, SV *count = 0)
3439 CODE: 3492 CODE:
3493{
3494 int semcnt = 1;
3495
3496 if (count)
3497 {
3498 SvGETMAGIC (count);
3499
3500 if (SvOK (count))
3501 semcnt = SvIV (count);
3502 }
3503
3440 RETVAL = sv_bless ( 3504 RETVAL = sv_bless (
3441 coro_waitarray_new (aTHX_ count && SvOK (count) ? SvIV (count) : 1), 3505 coro_waitarray_new (aTHX_ semcnt),
3442 GvSTASH (CvGV (cv)) 3506 GvSTASH (CvGV (cv))
3443 ); 3507 );
3508}
3444 OUTPUT: 3509 OUTPUT:
3445 RETVAL 3510 RETVAL
3446 3511
3447# helper for Coro::Channel and others 3512# helper for Coro::Channel and others
3448SV * 3513SV *
3510 for (i = 1; i <= wcount; ++i) 3575 for (i = 1; i <= wcount; ++i)
3511 PUSHs (sv_2mortal (newRV_inc (AvARRAY (av)[i]))); 3576 PUSHs (sv_2mortal (newRV_inc (AvARRAY (av)[i])));
3512 } 3577 }
3513} 3578}
3514 3579
3580MODULE = Coro::State PACKAGE = Coro::SemaphoreSet
3581
3582void
3583_may_delete (SV *sem, int count, int extra_refs)
3584 PPCODE:
3585{
3586 AV *av = (AV *)SvRV (sem);
3587
3588 if (SvREFCNT ((SV *)av) == 1 + extra_refs
3589 && AvFILLp (av) == 0 /* no waiters, just count */
3590 && SvIV (AvARRAY (av)[0]) == count)
3591 XSRETURN_YES;
3592
3593 XSRETURN_NO;
3594}
3595
3515MODULE = Coro::State PACKAGE = Coro::Signal 3596MODULE = Coro::State PACKAGE = Coro::Signal
3516 3597
3517SV * 3598SV *
3518new (SV *klass) 3599new (SV *klass)
3519 CODE: 3600 CODE:

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines