ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/Coro/Coro/State.xs
(Generate patch)

Comparing Coro/Coro/State.xs (file contents):
Revision 1.365 by root, Mon Jul 20 16:18:30 2009 UTC vs.
Revision 1.394 by root, Sat Apr 30 05:17:43 2011 UTC

1/* this works around a bug in mingw32 providing a non-working setjmp */
2#define USE_NO_MINGW_SETJMP_TWO_ARGS
3
4#define NDEBUG 1
5
1#include "libcoro/coro.c" 6#include "libcoro/coro.c"
2 7
3#define PERL_NO_GET_CONTEXT 8#define PERL_NO_GET_CONTEXT
4#define PERL_EXT 9#define PERL_EXT
5 10
… …
12 17
13#include <stdio.h> 18#include <stdio.h>
14#include <errno.h> 19#include <errno.h>
15#include <assert.h> 20#include <assert.h>
16 21
17#ifdef WIN32 22#ifndef SVs_PADSTALE
23# define SVs_PADSTALE 0
24#endif
25
26#if defined(_WIN32)
27# undef HAS_GETTIMEOFDAY
18# undef setjmp 28# undef setjmp
19# undef longjmp 29# undef longjmp
20# undef _exit 30# undef _exit
21# define setjmp _setjmp /* deep magic */ 31# define setjmp _setjmp /* deep magic */
22#else 32#else
… …
142static SV *sv_pool_size; 152static SV *sv_pool_size;
143static SV *sv_async_pool_idle; /* description string */ 153static SV *sv_async_pool_idle; /* description string */
144static AV *av_async_pool; /* idle pool */ 154static AV *av_async_pool; /* idle pool */
145static SV *sv_Coro; /* class string */ 155static SV *sv_Coro; /* class string */
146static CV *cv_pool_handler; 156static CV *cv_pool_handler;
147static CV *cv_coro_state_new;
148 157
149/* Coro::AnyEvent */ 158/* Coro::AnyEvent */
150static SV *sv_activity; 159static SV *sv_activity;
151 160
152/* enable processtime/realtime profiling */ 161/* enable processtime/realtime profiling */
… …
187 int valgrind_id; 196 int valgrind_id;
188#endif 197#endif
189 unsigned char flags; 198 unsigned char flags;
190} coro_cctx; 199} coro_cctx;
191 200
192coro_cctx *cctx_current; /* the currently running cctx */ 201static coro_cctx *cctx_current; /* the currently running cctx */
193 202
194/*****************************************************************************/ 203/*****************************************************************************/
195 204
196enum { 205enum {
197 CF_RUNNING = 0x0001, /* coroutine is running */ 206 CF_RUNNING = 0x0001, /* coroutine is running */
198 CF_READY = 0x0002, /* coroutine is ready */ 207 CF_READY = 0x0002, /* coroutine is ready */
199 CF_NEW = 0x0004, /* has never been switched to */ 208 CF_NEW = 0x0004, /* has never been switched to */
200 CF_DESTROYED = 0x0008, /* coroutine data has been freed */ 209 CF_DESTROYED = 0x0008, /* coroutine data has been freed */
201 CF_SUSPENDED = 0x0010, /* coroutine can't be scheduled */ 210 CF_SUSPENDED = 0x0010, /* coroutine can't be scheduled */
211 CF_NOCANCEL = 0x0020, /* cannot cancel, set slf_frame.data to 1 (hackish) */
202}; 212};
203 213
204/* the structure where most of the perl state is stored, overlaid on the cxstack */ 214/* the structure where most of the perl state is stored, overlaid on the cxstack */
205typedef struct 215typedef struct
206{ 216{
… …
232 CV *startcv; /* the CV to execute */ 242 CV *startcv; /* the CV to execute */
233 AV *args; /* data associated with this coroutine (initial args) */ 243 AV *args; /* data associated with this coroutine (initial args) */
234 int refcnt; /* coroutines are refcounted, yes */ 244 int refcnt; /* coroutines are refcounted, yes */
235 int flags; /* CF_ flags */ 245 int flags; /* CF_ flags */
236 HV *hv; /* the perl hash associated with this coro, if any */ 246 HV *hv; /* the perl hash associated with this coro, if any */
237 void (*on_destroy)(pTHX_ struct coro *coro); 247 void (*on_destroy)(pTHX_ struct coro *coro); /* for temporary use by xs in critical sections */
238 248
239 /* statistics */ 249 /* statistics */
240 int usecount; /* number of transfers to this coro */ 250 int usecount; /* number of transfers to this coro */
241 251
242 /* coro process data */ 252 /* coro process data */
… …
251 261
252 /* on_enter/on_leave */ 262 /* on_enter/on_leave */
253 AV *on_enter; 263 AV *on_enter;
254 AV *on_leave; 264 AV *on_leave;
255 265
266 /* swap_sv */
267 AV *swap_sv;
268
256 /* times */ 269 /* times */
257 coro_ts t_cpu, t_real; 270 coro_ts t_cpu, t_real;
258 271
259 /* linked list */ 272 /* linked list */
260 struct coro *next, *prev; 273 struct coro *next, *prev;
… …
263typedef struct coro *Coro__State; 276typedef struct coro *Coro__State;
264typedef struct coro *Coro__State_or_hashref; 277typedef struct coro *Coro__State_or_hashref;
265 278
266/* the following variables are effectively part of the perl context */ 279/* the following variables are effectively part of the perl context */
267/* and get copied between struct coro and these variables */ 280/* and get copied between struct coro and these variables */
268/* the mainr easonw e don't support windows process emulation */ 281/* the main reason we don't support windows process emulation */
269static struct CoroSLF slf_frame; /* the current slf frame */ 282static struct CoroSLF slf_frame; /* the current slf frame */
270 283
271/** Coro ********************************************************************/ 284/** Coro ********************************************************************/
272 285
273#define CORO_PRIO_MAX 3 286#define CORO_PRIO_MAX 3
… …
290static OP *(*coro_old_pp_sselect) (pTHX); 303static OP *(*coro_old_pp_sselect) (pTHX);
291static SV *coro_select_select; 304static SV *coro_select_select;
292 305
293/* horrible hack, but if it works... */ 306/* horrible hack, but if it works... */
294static OP * 307static OP *
295coro_pp_sselect (aTHX) 308coro_pp_sselect (pTHX)
296{ 309{
297 dSP; 310 dSP;
298 PUSHMARK (SP - 4); /* fake argument list */ 311 PUSHMARK (SP - 4); /* fake argument list */
299 XPUSHs (coro_select_select); 312 XPUSHs (coro_select_select);
300 PUTBACK; 313 PUTBACK;
… …
302 /* entersub is an UNOP, select a LISTOP... keep your fingers crossed */ 315 /* entersub is an UNOP, select a LISTOP... keep your fingers crossed */
303 PL_op->op_flags |= OPf_STACKED; 316 PL_op->op_flags |= OPf_STACKED;
304 PL_op->op_private = 0; 317 PL_op->op_private = 0;
305 return PL_ppaddr [OP_ENTERSUB](aTHX); 318 return PL_ppaddr [OP_ENTERSUB](aTHX);
306} 319}
320
321/** time stuff **************************************************************/
322
323#ifdef HAS_GETTIMEOFDAY
324
325static void
326coro_u2time (pTHX_ UV ret[2])
327{
328 struct timeval tv;
329 gettimeofday (&tv, 0);
330
331 ret [0] = tv.tv_sec;
332 ret [1] = tv.tv_usec;
333}
334
335static double
336coro_nvtime ()
337{
338 struct timeval tv;
339 gettimeofday (&tv, 0);
340
341 return tv.tv_sec + tv.tv_usec * 1e-6;
342}
343
344static void
345time_init (pTHX)
346{
347 nvtime = coro_nvtime;
348 u2time = coro_u2time;
349}
350
351#else
352
353static void
354time_init (pTHX)
355{
356 SV **svp;
357
358 require_pv ("Time/HiRes.pm");
359
360 svp = hv_fetch (PL_modglobal, "Time::NVtime", 12, 0);
361
362 if (!svp) croak ("Time::HiRes is required, but missing. Caught");
363 if (!SvIOK (*svp)) croak ("Time::NVtime isn't a function pointer. Caught");
364
365 nvtime = INT2PTR (double (*)(), SvIV (*svp));
366
367 svp = hv_fetch (PL_modglobal, "Time::U2time", 12, 0);
368 u2time = INT2PTR (void (*)(pTHX_ UV ret[2]), SvIV (*svp));
369}
370
371#endif
307 372
308/** lowlevel stuff **********************************************************/ 373/** lowlevel stuff **********************************************************/
309 374
310static SV * 375static SV *
311coro_get_sv (pTHX_ const char *name, int create) 376coro_get_sv (pTHX_ const char *name, int create)
… …
551 AvARRAY (av)[++AvFILLp (av)] = (SV *)CvPADLIST (cv); 616 AvARRAY (av)[++AvFILLp (av)] = (SV *)CvPADLIST (cv);
552} 617}
553 618
554/** load & save, init *******************************************************/ 619/** load & save, init *******************************************************/
555 620
621/* swap sv heads, at least logically */
622static void
623swap_svs (pTHX_ Coro__State c)
624{
625 int i;
626
627 for (i = 0; i <= AvFILLp (c->swap_sv); )
628 {
629 SV *a = AvARRAY (c->swap_sv)[i++];
630 SV *b = AvARRAY (c->swap_sv)[i++];
631
632 const U32 keep = SVs_PADSTALE | SVs_PADTMP | SVs_PADMY; /* keep these flags */
633 SV tmp;
634
635 /* swap sv_any */
636 SvANY (&tmp) = SvANY (a); SvANY (a) = SvANY (b); SvANY (b) = SvANY (&tmp);
637
638 /* swap sv_flags */
639 SvFLAGS (&tmp) = SvFLAGS (a);
640 SvFLAGS (a) = (SvFLAGS (a) & keep) | (SvFLAGS (b ) & ~keep);
641 SvFLAGS (b) = (SvFLAGS (b) & keep) | (SvFLAGS (&tmp) & ~keep);
642
643#if PERL_VERSION_ATLEAST (5,10,0)
644 /* perl 5.10 complicates this _quite_ a bit, but it also is
645 * much faster, so no quarrels here. alternatively, we could
646 * sv_upgrade to avoid this.
647 */
648 {
649 /* swap sv_u */
650 tmp.sv_u = a->sv_u; a->sv_u = b->sv_u; b->sv_u = tmp.sv_u;
651
652 /* if SvANY points to the head, we need to adjust the pointers,
653 * as the pointer for a still points to b, and maybe vice versa.
654 */
655 #define svany_in_head(type) \
656 (((1 << SVt_NULL) | (1 << SVt_BIND) | (1 << SVt_IV) | (1 << SVt_RV)) & (1 << (type)))
657
658 if (svany_in_head (SvTYPE (a)))
659 SvANY (a) = (void *)((PTRV)SvANY (a) - (PTRV)b + (PTRV)a);
660
661 if (svany_in_head (SvTYPE (b)))
662 SvANY (b) = (void *)((PTRV)SvANY (b) - (PTRV)a + (PTRV)b);
663 }
664#endif
665 }
666}
667
668#define SWAP_SVS(coro) \
669 if (expect_false ((coro)->swap_sv)) \
670 swap_svs (aTHX_ (coro))
671
556static void 672static void
557on_enterleave_call (pTHX_ SV *cb); 673on_enterleave_call (pTHX_ SV *cb);
558 674
559static void 675static void
560load_perl (pTHX_ Coro__State c) 676load_perl (pTHX_ Coro__State c)
… …
606 int i; 722 int i;
607 723
608 for (i = 0; i <= AvFILLp (c->on_enter); ++i) 724 for (i = 0; i <= AvFILLp (c->on_enter); ++i)
609 on_enterleave_call (aTHX_ AvARRAY (c->on_enter)[i]); 725 on_enterleave_call (aTHX_ AvARRAY (c->on_enter)[i]);
610 } 726 }
727
728 SWAP_SVS (c);
611} 729}
612 730
613static void 731static void
614save_perl (pTHX_ Coro__State c) 732save_perl (pTHX_ Coro__State c)
615{ 733{
734 SWAP_SVS (c);
735
616 if (expect_false (c->on_leave)) 736 if (expect_false (c->on_leave))
617 { 737 {
618 int i; 738 int i;
619 739
620 for (i = AvFILLp (c->on_leave); i >= 0; --i) 740 for (i = AvFILLp (c->on_leave); i >= 0; --i)
… …
927slf_check_repeat (pTHX_ struct CoroSLF *frame) 1047slf_check_repeat (pTHX_ struct CoroSLF *frame)
928{ 1048{
929 return 1; 1049 return 1;
930} 1050}
931 1051
932static UNOP coro_setup_op; 1052static UNOP init_perl_op;
933 1053
934static void NOINLINE /* noinline to keep it out of the transfer fast path */ 1054static void NOINLINE /* noinline to keep it out of the transfer fast path */
935coro_setup (pTHX_ struct coro *coro) 1055init_perl (pTHX_ struct coro *coro)
936{ 1056{
937 /* 1057 /*
938 * emulate part of the perl startup here. 1058 * emulate part of the perl startup here.
939 */ 1059 */
940 coro_init_stacks (aTHX); 1060 coro_init_stacks (aTHX);
… …
947 PL_comppad_name_fill = 0; 1067 PL_comppad_name_fill = 0;
948 PL_comppad_name_floor = 0; 1068 PL_comppad_name_floor = 0;
949 PL_curpm = 0; 1069 PL_curpm = 0;
950 PL_curpad = 0; 1070 PL_curpad = 0;
951 PL_localizing = 0; 1071 PL_localizing = 0;
952 PL_dirty = 0;
953 PL_restartop = 0; 1072 PL_restartop = 0;
954#if PERL_VERSION_ATLEAST (5,10,0) 1073#if PERL_VERSION_ATLEAST (5,10,0)
955 PL_parser = 0; 1074 PL_parser = 0;
956#endif 1075#endif
957 PL_hints = 0; 1076 PL_hints = 0;
… …
989 */ 1108 */
990 slf_frame.prepare = prepare_nop; /* provide a nop function for an eventual pp_slf */ 1109 slf_frame.prepare = prepare_nop; /* provide a nop function for an eventual pp_slf */
991 slf_frame.check = slf_check_nop; /* signal pp_slf to not repeat */ 1110 slf_frame.check = slf_check_nop; /* signal pp_slf to not repeat */
992 1111
993 /* and we have to provide the pp_slf op in any case, so pp_slf can skip it */ 1112 /* and we have to provide the pp_slf op in any case, so pp_slf can skip it */
994 coro_setup_op.op_next = PL_op; 1113 init_perl_op.op_next = PL_op;
995 coro_setup_op.op_type = OP_ENTERSUB; 1114 init_perl_op.op_type = OP_ENTERSUB;
996 coro_setup_op.op_ppaddr = pp_slf; 1115 init_perl_op.op_ppaddr = pp_slf;
997 /* no flags etc. required, as an init function won't be called */ 1116 /* no flags etc. required, as an init function won't be called */
998 1117
999 PL_op = (OP *)&coro_setup_op; 1118 PL_op = (OP *)&init_perl_op;
1000 1119
1001 /* copy throw, in case it was set before coro_setup */ 1120 /* copy throw, in case it was set before init_perl */
1002 CORO_THROW = coro->except; 1121 CORO_THROW = coro->except;
1122
1123 SWAP_SVS (coro);
1003 1124
1004 if (expect_false (enable_times)) 1125 if (expect_false (enable_times))
1005 { 1126 {
1006 coro_times_update (); 1127 coro_times_update ();
1007 coro_times_sub (coro); 1128 coro_times_sub (coro);
… …
1028 dounwind (-1); 1149 dounwind (-1);
1029 } 1150 }
1030} 1151}
1031 1152
1032static void 1153static void
1033coro_destruct_perl (pTHX_ struct coro *coro) 1154destroy_perl (pTHX_ struct coro *coro)
1034{ 1155{
1035 SV *svf [9]; 1156 SV *svf [9];
1036 1157
1037 { 1158 {
1038 struct coro *current = SvSTATE_current; 1159 struct coro *current = SvSTATE_current;
… …
1042 save_perl (aTHX_ current); 1163 save_perl (aTHX_ current);
1043 load_perl (aTHX_ coro); 1164 load_perl (aTHX_ coro);
1044 1165
1045 coro_unwind_stacks (aTHX); 1166 coro_unwind_stacks (aTHX);
1046 coro_destruct_stacks (aTHX); 1167 coro_destruct_stacks (aTHX);
1168
1169 /* restore swapped sv's */
1170 SWAP_SVS (coro);
1047 1171
1048 // now save some sv's to be free'd later 1172 // now save some sv's to be free'd later
1049 svf [0] = GvSV (PL_defgv); 1173 svf [0] = GvSV (PL_defgv);
1050 svf [1] = (SV *)GvAV (PL_defgv); 1174 svf [1] = (SV *)GvAV (PL_defgv);
1051 svf [2] = GvSV (PL_errgv); 1175 svf [2] = GvSV (PL_errgv);
… …
1275 /* somebody or something will hit me for both perl_run and PL_restartop */ 1399 /* somebody or something will hit me for both perl_run and PL_restartop */
1276 PL_restartop = PL_op; 1400 PL_restartop = PL_op;
1277 perl_run (PL_curinterp); 1401 perl_run (PL_curinterp);
1278 /* 1402 /*
1279 * Unfortunately, there is no way to get at the return values of the 1403 * Unfortunately, there is no way to get at the return values of the
1280 * coro body here, as perl_run destroys these 1404 * coro body here, as perl_run destroys these. Likewise, we cannot catch
1405 * runtime errors here, as this is just a random interpreter, not a thread.
1281 */ 1406 */
1282 1407
1283 /* 1408 /*
1284 * If perl-run returns we assume exit() was being called or the coro 1409 * If perl-run returns we assume exit() was being called or the coro
1285 * fell off the end, which seems to be the only valid (non-bug) 1410 * fell off the end, which seems to be the only valid (non-bug)
… …
1372cctx_destroy (coro_cctx *cctx) 1497cctx_destroy (coro_cctx *cctx)
1373{ 1498{
1374 if (!cctx) 1499 if (!cctx)
1375 return; 1500 return;
1376 1501
1377 assert (("FATAL: tried to destroy current cctx", cctx != cctx_current));//D temporary? 1502 assert (("FATAL: tried to destroy current cctx", cctx != cctx_current));
1378 1503
1379 --cctx_count; 1504 --cctx_count;
1380 coro_destroy (&cctx->cctx); 1505 coro_destroy (&cctx->cctx);
1381 1506
1382 /* coro_transfer creates new, empty cctx's */ 1507 /* coro_transfer creates new, empty cctx's */
… …
1492 if (expect_false (next->flags & CF_NEW)) 1617 if (expect_false (next->flags & CF_NEW))
1493 { 1618 {
1494 /* need to start coroutine */ 1619 /* need to start coroutine */
1495 next->flags &= ~CF_NEW; 1620 next->flags &= ~CF_NEW;
1496 /* setup coroutine call */ 1621 /* setup coroutine call */
1497 coro_setup (aTHX_ next); 1622 init_perl (aTHX_ next);
1498 } 1623 }
1499 else 1624 else
1500 load_perl (aTHX_ next); 1625 load_perl (aTHX_ next);
1501 1626
1502 /* possibly untie and reuse the cctx */ 1627 /* possibly untie and reuse the cctx */
… …
1541#define TRANSFER(ta, force_cctx) transfer (aTHX_ (ta).prev, (ta).next, (force_cctx)) 1666#define TRANSFER(ta, force_cctx) transfer (aTHX_ (ta).prev, (ta).next, (force_cctx))
1542#define TRANSFER_CHECK(ta) transfer_check (aTHX_ (ta).prev, (ta).next) 1667#define TRANSFER_CHECK(ta) transfer_check (aTHX_ (ta).prev, (ta).next)
1543 1668
1544/** high level stuff ********************************************************/ 1669/** high level stuff ********************************************************/
1545 1670
1546static int 1671static void
1547coro_state_destroy (pTHX_ struct coro *coro) 1672coro_state_destroy (pTHX_ struct coro *coro)
1548{ 1673{
1549 if (coro->flags & CF_DESTROYED) 1674 if (coro->flags & CF_DESTROYED)
1550 return 0; 1675 return;
1551 1676
1677 /* this callback is reserved for slf functions needing to do cleanup */
1552 if (coro->on_destroy && !PL_dirty) 1678 if (coro->on_destroy && !PL_dirty)
1553 coro->on_destroy (aTHX_ coro); 1679 coro->on_destroy (aTHX_ coro);
1680
1681 /*
1682 * The on_destroy above most likely is from an SLF call.
1683 * Since by definition the SLF call will not finish when we destroy
1684 * the coro, we will have to force-finish it here, otherwise
1685 * cleanup functions cannot call SLF functions.
1686 */
1687 coro->slf_frame.prepare = 0;
1554 1688
1555 coro->flags |= CF_DESTROYED; 1689 coro->flags |= CF_DESTROYED;
1556 1690
1557 if (coro->flags & CF_READY) 1691 if (coro->flags & CF_READY)
1558 { 1692 {
… …
1565 1699
1566 if (coro->mainstack 1700 if (coro->mainstack
1567 && coro->mainstack != main_mainstack 1701 && coro->mainstack != main_mainstack
1568 && coro->slot 1702 && coro->slot
1569 && !PL_dirty) 1703 && !PL_dirty)
1570 coro_destruct_perl (aTHX_ coro); 1704 destroy_perl (aTHX_ coro);
1705
1706 if (coro->next) coro->next->prev = coro->prev;
1707 if (coro->prev) coro->prev->next = coro->next;
1708 if (coro == coro_first) coro_first = coro->next;
1571 1709
1572 cctx_destroy (coro->cctx); 1710 cctx_destroy (coro->cctx);
1573 SvREFCNT_dec (coro->startcv); 1711 SvREFCNT_dec (coro->startcv);
1574 SvREFCNT_dec (coro->args); 1712 SvREFCNT_dec (coro->args);
1713 SvREFCNT_dec (coro->swap_sv);
1575 SvREFCNT_dec (CORO_THROW); 1714 SvREFCNT_dec (CORO_THROW);
1576
1577 if (coro->next) coro->next->prev = coro->prev;
1578 if (coro->prev) coro->prev->next = coro->next;
1579 if (coro == coro_first) coro_first = coro->next;
1580
1581 return 1;
1582} 1715}
1583 1716
1584static int 1717static int
1585coro_state_free (pTHX_ SV *sv, MAGIC *mg) 1718coro_state_free (pTHX_ SV *sv, MAGIC *mg)
1586{ 1719{
… …
1754 { 1887 {
1755 /* nothing to schedule: call the idle handler */ 1888 /* nothing to schedule: call the idle handler */
1756 if (SvROK (sv_idle) 1889 if (SvROK (sv_idle)
1757 && SvOBJECT (SvRV (sv_idle))) 1890 && SvOBJECT (SvRV (sv_idle)))
1758 { 1891 {
1892 if (SvRV (sv_idle) == SvRV (coro_current))
1893 croak ("FATAL: $Coro::IDLE blocked itself - did you try to block inside an event loop callback? Caught");
1894
1759 ++coro_nready; /* hack so that api_ready doesn't invoke ready hook */ 1895 ++coro_nready; /* hack so that api_ready doesn't invoke ready hook */
1760 api_ready (aTHX_ SvRV (sv_idle)); 1896 api_ready (aTHX_ SvRV (sv_idle));
1761 --coro_nready; 1897 --coro_nready;
1762 } 1898 }
1763 else 1899 else
1764 { 1900 {
1901 /* TODO: deprecated, remove, cannot work reliably *//*D*/
1765 dSP; 1902 dSP;
1766 1903
1767 ENTER; 1904 ENTER;
1768 SAVETMPS; 1905 SAVETMPS;
1769 1906
… …
1879 2016
1880static void 2017static void
1881coro_call_on_destroy (pTHX_ struct coro *coro) 2018coro_call_on_destroy (pTHX_ struct coro *coro)
1882{ 2019{
1883 SV **on_destroyp = hv_fetch (coro->hv, "_on_destroy", sizeof ("_on_destroy") - 1, 0); 2020 SV **on_destroyp = hv_fetch (coro->hv, "_on_destroy", sizeof ("_on_destroy") - 1, 0);
1884 SV **statusp = hv_fetch (coro->hv, "_status", sizeof ("_status") - 1, 0);
1885 2021
1886 if (on_destroyp) 2022 if (on_destroyp)
1887 { 2023 {
1888 AV *on_destroy = (AV *)SvRV (*on_destroyp); 2024 SV **statusp = hv_fetch (coro->hv, "_status", sizeof ("_status") - 1, 0);
2025 AV *on_destroy = sv_2mortal (SvREFCNT_inc ((AV *)SvRV (*on_destroyp)));
2026 AV *status = statusp ? sv_2mortal (SvREFCNT_inc ((AV *)SvRV (*statusp))) : 0;
1889 2027
1890 while (AvFILLp (on_destroy) >= 0) 2028 while (AvFILLp (on_destroy) >= 0)
1891 { 2029 {
1892 dSP; /* don't disturb outer sp */ 2030 dSP; /* don't disturb outer sp */
1893 SV *cb = av_pop (on_destroy); 2031 SV *cb = av_pop (on_destroy);
… …
1895 PUSHMARK (SP); 2033 PUSHMARK (SP);
1896 2034
1897 if (statusp) 2035 if (statusp)
1898 { 2036 {
1899 int i; 2037 int i;
1900 AV *status = (AV *)SvRV (*statusp);
1901 EXTEND (SP, AvFILLp (status) + 1); 2038 EXTEND (SP, AvFILLp (status) + 1);
1902 2039
1903 for (i = 0; i <= AvFILLp (status); ++i) 2040 for (i = 0; i <= AvFILLp (status); ++i)
1904 PUSHs (AvARRAY (status)[i]); 2041 PUSHs (AvARRAY (status)[i]);
1905 } 2042 }
… …
1909 } 2046 }
1910 } 2047 }
1911} 2048}
1912 2049
1913static void 2050static void
1914slf_init_terminate (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2051coro_set_status (HV *coro_hv, SV **arg, int items)
1915{ 2052{
1916 int i;
1917 HV *hv = (HV *)SvRV (coro_current);
1918 AV *av = newAV (); 2053 AV *av = newAV ();
1919 2054
2055 /* items are actually not so common, so optimise for this case */
2056 if (items)
2057 {
2058 int i;
2059
1920 av_extend (av, items - 1); 2060 av_extend (av, items - 1);
2061
1921 for (i = 0; i < items; ++i) 2062 for (i = 0; i < items; ++i)
1922 av_push (av, SvREFCNT_inc_NN (arg [i])); 2063 av_push (av, SvREFCNT_inc_NN (arg [i]));
2064 }
1923 2065
1924 hv_store (hv, "_status", sizeof ("_status") - 1, newRV_noinc ((SV *)av), 0); 2066 hv_store (coro_hv, "_status", sizeof ("_status") - 1, newRV_noinc ((SV *)av), 0);
2067}
1925 2068
2069static void
2070slf_init_terminate_cancel_common (pTHX_ struct CoroSLF *frame, HV *coro_hv)
2071{
1926 av_push (av_destroy, (SV *)newRV_inc ((SV *)hv)); /* RVinc for perl */ 2072 av_push (av_destroy, (SV *)newRV_inc ((SV *)coro_hv)); /* RVinc for perl */
1927 api_ready (aTHX_ sv_manager); 2073 api_ready (aTHX_ sv_manager);
1928 2074
1929 frame->prepare = prepare_schedule; 2075 frame->prepare = prepare_schedule;
1930 frame->check = slf_check_repeat; 2076 frame->check = slf_check_repeat;
1931 2077
1932 /* as a minor optimisation, we could unwind all stacks here */ 2078 /* as a minor optimisation, we could unwind all stacks here */
1933 /* but that puts extra pressure on pp_slf, and is not worth much */ 2079 /* but that puts extra pressure on pp_slf, and is not worth much */
1934 /*coro_unwind_stacks (aTHX);*/ 2080 /*coro_unwind_stacks (aTHX);*/
2081}
2082
2083static void
2084slf_init_terminate (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2085{
2086 HV *coro_hv = (HV *)SvRV (coro_current);
2087
2088 coro_set_status (coro_hv, arg, items);
2089 slf_init_terminate_cancel_common (frame, coro_hv);
2090}
2091
2092static void
2093slf_init_cancel (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2094{
2095 HV *coro_hv;
2096 struct coro *coro;
2097
2098 if (items <= 0)
2099 croak ("Coro::cancel called without coro object,");
2100
2101 coro = SvSTATE (arg [0]);
2102 coro_hv = coro->hv;
2103
2104 coro_set_status (coro_hv, arg + 1, items - 1);
2105
2106 if (expect_false (coro->flags & CF_NOCANCEL))
2107 {
2108 /* coro currently busy cancelling something, so just notify it */
2109 coro->slf_frame.data = (void *)coro;
2110
2111 frame->prepare = prepare_nop;
2112 frame->check = slf_check_nop;
2113 }
2114 else if (coro_hv == (HV *)SvRV (coro_current))
2115 {
2116 /* cancelling the current coro is allowed, and equals terminate */
2117 slf_init_terminate_cancel_common (frame, coro_hv);
2118 }
2119 else
2120 {
2121 struct coro *self = SvSTATE_current;
2122
2123 /* otherwise we cancel directly, purely for speed reasons
2124 * unfortunately, this requires some magic trickery, as
2125 * somebody else could cancel us, so we have to fight the cancellation.
2126 * this is ugly, and hopefully fully worth the extra speed.
2127 * besides, I can't get the slow-but-safe version working...
2128 */
2129 slf_frame.data = 0;
2130 self->flags |= CF_NOCANCEL;
2131
2132 coro_state_destroy (aTHX_ coro);
2133 coro_call_on_destroy (aTHX_ coro);
2134
2135 self->flags &= ~CF_NOCANCEL;
2136
2137 if (slf_frame.data)
2138 {
2139 /* while we were busy we have been cancelled, so terminate */
2140 slf_init_terminate_cancel_common (frame, self->hv);
2141 }
2142 else
2143 {
2144 frame->prepare = prepare_nop;
2145 frame->check = slf_check_nop;
2146 }
2147 }
1935} 2148}
1936 2149
1937/*****************************************************************************/ 2150/*****************************************************************************/
1938/* async pool handler */ 2151/* async pool handler */
1939 2152
… …
2343 if (PL_op->op_flags & OPf_STACKED) 2556 if (PL_op->op_flags & OPf_STACKED)
2344 { 2557 {
2345 if (items > slf_arga) 2558 if (items > slf_arga)
2346 { 2559 {
2347 slf_arga = items; 2560 slf_arga = items;
2348 free (slf_argv); 2561 Safefree (slf_argv);
2349 slf_argv = malloc (slf_arga * sizeof (SV *)); 2562 New (0, slf_argv, slf_arga, SV *);
2350 } 2563 }
2351 2564
2352 slf_argc = items; 2565 slf_argc = items;
2353 2566
2354 for (i = 0; i < items; ++i) 2567 for (i = 0; i < items; ++i)
… …
2715 { 2928 {
2716 SV *cb_cv = s_get_cv_croak (arg [1]); 2929 SV *cb_cv = s_get_cv_croak (arg [1]);
2717 av_push (av, SvREFCNT_inc_NN (cb_cv)); 2930 av_push (av, SvREFCNT_inc_NN (cb_cv));
2718 2931
2719 if (SvIVX (AvARRAY (av)[0])) 2932 if (SvIVX (AvARRAY (av)[0]))
2720 coro_signal_wake (aTHX_ av, 1); /* ust be the only waiter */ 2933 coro_signal_wake (aTHX_ av, 1); /* must be the only waiter */
2721 2934
2722 frame->prepare = prepare_nop; 2935 frame->prepare = prepare_nop;
2723 frame->check = slf_check_nop; 2936 frame->check = slf_check_nop;
2724 } 2937 }
2725 else if (SvIVX (AvARRAY (av)[0])) 2938 else if (SvIVX (AvARRAY (av)[0]))
… …
2887 /* now call the AIO function - we assume our request is uncancelable */ 3100 /* now call the AIO function - we assume our request is uncancelable */
2888 PUTBACK; 3101 PUTBACK;
2889 call_sv ((SV *)req, G_VOID | G_DISCARD); 3102 call_sv ((SV *)req, G_VOID | G_DISCARD);
2890 } 3103 }
2891 3104
2892 /* now that the requets is going, we loop toll we have a result */ 3105 /* now that the request is going, we loop till we have a result */
2893 frame->data = (void *)state; 3106 frame->data = (void *)state;
2894 frame->prepare = prepare_schedule; 3107 frame->prepare = prepare_schedule;
2895 frame->check = slf_check_aio_req; 3108 frame->check = slf_check_aio_req;
2896} 3109}
2897 3110
… …
2908/*****************************************************************************/ 3121/*****************************************************************************/
2909 3122
2910#if CORO_CLONE 3123#if CORO_CLONE
2911# include "clone.c" 3124# include "clone.c"
2912#endif 3125#endif
3126
3127/*****************************************************************************/
3128
3129static SV *
3130coro_new (pTHX_ HV *stash, SV **argv, int argc, int is_coro)
3131{
3132 SV *coro_sv;
3133 struct coro *coro;
3134 MAGIC *mg;
3135 HV *hv;
3136 SV *cb;
3137 int i;
3138
3139 if (argc > 0)
3140 {
3141 cb = s_get_cv_croak (argv [0]);
3142
3143 if (!is_coro)
3144 {
3145 if (CvISXSUB (cb))
3146 croak ("Coro::State doesn't support XS functions as coroutine start, caught");
3147
3148 if (!CvROOT (cb))
3149 croak ("Coro::State doesn't support autoloaded or undefined functions as coroutine start, caught");
3150 }
3151 }
3152
3153 Newz (0, coro, 1, struct coro);
3154 coro->args = newAV ();
3155 coro->flags = CF_NEW;
3156
3157 if (coro_first) coro_first->prev = coro;
3158 coro->next = coro_first;
3159 coro_first = coro;
3160
3161 coro->hv = hv = newHV ();
3162 mg = sv_magicext ((SV *)hv, 0, CORO_MAGIC_type_state, &coro_state_vtbl, (char *)coro, 0);
3163 mg->mg_flags |= MGf_DUP;
3164 coro_sv = sv_bless (newRV_noinc ((SV *)hv), stash);
3165
3166 if (argc > 0)
3167 {
3168 av_extend (coro->args, argc + is_coro - 1);
3169
3170 if (is_coro)
3171 {
3172 av_push (coro->args, SvREFCNT_inc_NN ((SV *)cb));
3173 cb = (SV *)cv_coro_run;
3174 }
3175
3176 coro->startcv = (CV *)SvREFCNT_inc_NN ((SV *)cb);
3177
3178 for (i = 1; i < argc; i++)
3179 av_push (coro->args, newSVsv (argv [i]));
3180 }
3181
3182 return coro_sv;
3183}
2913 3184
2914MODULE = Coro::State PACKAGE = Coro::State PREFIX = api_ 3185MODULE = Coro::State PACKAGE = Coro::State PREFIX = api_
2915 3186
2916PROTOTYPES: DISABLE 3187PROTOTYPES: DISABLE
2917 3188
… …
2970 coroapi.prepare_nop = prepare_nop; 3241 coroapi.prepare_nop = prepare_nop;
2971 coroapi.prepare_schedule = prepare_schedule; 3242 coroapi.prepare_schedule = prepare_schedule;
2972 coroapi.prepare_cede = prepare_cede; 3243 coroapi.prepare_cede = prepare_cede;
2973 coroapi.prepare_cede_notself = prepare_cede_notself; 3244 coroapi.prepare_cede_notself = prepare_cede_notself;
2974 3245
2975 { 3246 time_init (aTHX);
2976 SV **svp = hv_fetch (PL_modglobal, "Time::NVtime", 12, 0);
2977
2978 if (!svp) croak ("Time::HiRes is required");
2979 if (!SvIOK (*svp)) croak ("Time::NVtime isn't a function pointer");
2980
2981 nvtime = INT2PTR (double (*)(), SvIV (*svp));
2982
2983 svp = hv_fetch (PL_modglobal, "Time::U2time", 12, 0);
2984 u2time = INT2PTR (void (*)(pTHX_ UV ret[2]), SvIV (*svp));
2985 }
2986 3247
2987 assert (("PRIO_NORMAL must be 0", !CORO_PRIO_NORMAL)); 3248 assert (("PRIO_NORMAL must be 0", !CORO_PRIO_NORMAL));
2988} 3249}
2989 3250
2990SV * 3251SV *
2991new (char *klass, ...) 3252new (SV *klass, ...)
2992 ALIAS: 3253 ALIAS:
2993 Coro::new = 1 3254 Coro::new = 1
2994 CODE: 3255 CODE:
2995{ 3256 RETVAL = coro_new (aTHX_ ix ? coro_stash : coro_state_stash, &ST (1), items - 1, ix);
2996 struct coro *coro; 3257 OUTPUT:
2997 MAGIC *mg;
2998 HV *hv;
2999 SV *cb;
3000 int i;
3001
3002 if (items > 1)
3003 {
3004 cb = s_get_cv_croak (ST (1));
3005
3006 if (!ix)
3007 {
3008 if (CvISXSUB (cb))
3009 croak ("Coro::State doesn't support XS functions as coroutine start, caught");
3010
3011 if (!CvROOT (cb))
3012 croak ("Coro::State doesn't support autoloaded or undefined functions as coroutine start, caught");
3013 }
3014 }
3015
3016 Newz (0, coro, 1, struct coro);
3017 coro->args = newAV ();
3018 coro->flags = CF_NEW;
3019
3020 if (coro_first) coro_first->prev = coro;
3021 coro->next = coro_first;
3022 coro_first = coro;
3023
3024 coro->hv = hv = newHV ();
3025 mg = sv_magicext ((SV *)hv, 0, CORO_MAGIC_type_state, &coro_state_vtbl, (char *)coro, 0);
3026 mg->mg_flags |= MGf_DUP;
3027 RETVAL = sv_bless (newRV_noinc ((SV *)hv), gv_stashpv (klass, 1));
3028
3029 if (items > 1)
3030 {
3031 av_extend (coro->args, items - 1 + ix - 1);
3032
3033 if (ix)
3034 {
3035 av_push (coro->args, SvREFCNT_inc_NN ((SV *)cb));
3036 cb = (SV *)cv_coro_run;
3037 }
3038
3039 coro->startcv = (CV *)SvREFCNT_inc_NN ((SV *)cb);
3040
3041 for (i = 2; i < items; i++)
3042 av_push (coro->args, newSVsv (ST (i)));
3043 }
3044}
3045 OUTPUT:
3046 RETVAL 3258 RETVAL
3047 3259
3048void 3260void
3049transfer (...) 3261transfer (...)
3050 PROTOTYPE: $$ 3262 PROTOTYPE: $$
3051 CODE: 3263 CODE:
3052 CORO_EXECUTE_SLF_XS (slf_init_transfer); 3264 CORO_EXECUTE_SLF_XS (slf_init_transfer);
3053
3054bool
3055_destroy (SV *coro_sv)
3056 CODE:
3057 RETVAL = coro_state_destroy (aTHX_ SvSTATE (coro_sv));
3058 OUTPUT:
3059 RETVAL
3060 3265
3061void 3266void
3062_exit (int code) 3267_exit (int code)
3063 PROTOTYPE: $ 3268 PROTOTYPE: $
3064 CODE: 3269 CODE:
… …
3140 CODE: 3345 CODE:
3141{ 3346{
3142 if (coro->mainstack && ((coro->flags & CF_RUNNING) || coro->slot)) 3347 if (coro->mainstack && ((coro->flags & CF_RUNNING) || coro->slot))
3143 { 3348 {
3144 struct coro *current = SvSTATE_current; 3349 struct coro *current = SvSTATE_current;
3350 struct CoroSLF slf_save;
3145 3351
3146 if (current != coro) 3352 if (current != coro)
3147 { 3353 {
3148 PUTBACK; 3354 PUTBACK;
3149 save_perl (aTHX_ current); 3355 save_perl (aTHX_ current);
3150 load_perl (aTHX_ coro); 3356 load_perl (aTHX_ coro);
3357 /* the coro is most likely in an active SLF call.
3358 * while not strictly required (the code we execute is
3359 * not allowed to call any SLF functions), it's cleaner
3360 * to reinitialise the slf_frame and restore it later.
3361 * This might one day allow us to actually do SLF calls
3362 * from code executed here.
3363 */
3364 slf_save = slf_frame;
3365 slf_frame.prepare = 0;
3151 SPAGAIN; 3366 SPAGAIN;
3152 } 3367 }
3153 3368
3154 PUSHSTACK; 3369 PUSHSTACK;
3155 3370
… …
3165 SPAGAIN; 3380 SPAGAIN;
3166 3381
3167 if (current != coro) 3382 if (current != coro)
3168 { 3383 {
3169 PUTBACK; 3384 PUTBACK;
3385 slf_frame = slf_save;
3170 save_perl (aTHX_ coro); 3386 save_perl (aTHX_ coro);
3171 load_perl (aTHX_ current); 3387 load_perl (aTHX_ current);
3172 SPAGAIN; 3388 SPAGAIN;
3173 } 3389 }
3174 } 3390 }
… …
3187 RETVAL = boolSV (coro->flags & ix); 3403 RETVAL = boolSV (coro->flags & ix);
3188 OUTPUT: 3404 OUTPUT:
3189 RETVAL 3405 RETVAL
3190 3406
3191void 3407void
3192throw (Coro::State self, SV *throw = &PL_sv_undef) 3408throw (Coro::State self, SV *exception = &PL_sv_undef)
3193 PROTOTYPE: $;$ 3409 PROTOTYPE: $;$
3194 CODE: 3410 CODE:
3195{ 3411{
3196 struct coro *current = SvSTATE_current; 3412 struct coro *current = SvSTATE_current;
3197 SV **throwp = self == current ? &CORO_THROW : &self->except; 3413 SV **exceptionp = self == current ? &CORO_THROW : &self->except;
3198 SvREFCNT_dec (*throwp); 3414 SvREFCNT_dec (*exceptionp);
3199 SvGETMAGIC (throw); 3415 SvGETMAGIC (exception);
3200 *throwp = SvOK (throw) ? newSVsv (throw) : 0; 3416 *exceptionp = SvOK (exception) ? newSVsv (exception) : 0;
3201} 3417}
3202 3418
3203void 3419void
3204api_trace (SV *coro, int flags = CC_TRACE | CC_TRACE_SUB) 3420api_trace (SV *coro, int flags = CC_TRACE | CC_TRACE_SUB)
3205 PROTOTYPE: $;$ 3421 PROTOTYPE: $;$
… …
3260 3476
3261void 3477void
3262cancel (Coro::State self) 3478cancel (Coro::State self)
3263 CODE: 3479 CODE:
3264 coro_state_destroy (aTHX_ self); 3480 coro_state_destroy (aTHX_ self);
3265 coro_call_on_destroy (aTHX_ self); /* actually only for Coro objects */
3266
3267 3481
3268SV * 3482SV *
3269enable_times (int enabled = enable_times) 3483enable_times (int enabled = enable_times)
3270 CODE: 3484 CODE:
3271{ 3485{
… …
3299 PUSHs (sv_2mortal (newSVnv (self->t_cpu [0] + self->t_cpu [1] * 1e-9))); 3513 PUSHs (sv_2mortal (newSVnv (self->t_cpu [0] + self->t_cpu [1] * 1e-9)));
3300 3514
3301 if (expect_false (current == self)) 3515 if (expect_false (current == self))
3302 coro_times_sub (SvSTATE (coro_current)); 3516 coro_times_sub (SvSTATE (coro_current));
3303} 3517}
3518
3519void
3520swap_sv (Coro::State coro, SV *sv, SV *swapsv)
3521 CODE:
3522{
3523 struct coro *current = SvSTATE_current;
3524
3525 if (current == coro)
3526 SWAP_SVS (current);
3527
3528 if (!coro->swap_sv)
3529 coro->swap_sv = newAV ();
3530
3531 av_push (coro->swap_sv, SvREFCNT_inc_NN (SvRV (sv )));
3532 av_push (coro->swap_sv, SvREFCNT_inc_NN (SvRV (swapsv)));
3533
3534 if (current == coro)
3535 SWAP_SVS (current);
3536}
3537
3304 3538
3305MODULE = Coro::State PACKAGE = Coro 3539MODULE = Coro::State PACKAGE = Coro
3306 3540
3307BOOT: 3541BOOT:
3308{ 3542{
… …
3317 sv_idle = coro_get_sv (aTHX_ "Coro::idle" , TRUE); 3551 sv_idle = coro_get_sv (aTHX_ "Coro::idle" , TRUE);
3318 3552
3319 sv_async_pool_idle = newSVpv ("[async pool idle]", 0); SvREADONLY_on (sv_async_pool_idle); 3553 sv_async_pool_idle = newSVpv ("[async pool idle]", 0); SvREADONLY_on (sv_async_pool_idle);
3320 sv_Coro = newSVpv ("Coro", 0); SvREADONLY_on (sv_Coro); 3554 sv_Coro = newSVpv ("Coro", 0); SvREADONLY_on (sv_Coro);
3321 cv_pool_handler = get_cv ("Coro::pool_handler", GV_ADD); SvREADONLY_on (cv_pool_handler); 3555 cv_pool_handler = get_cv ("Coro::pool_handler", GV_ADD); SvREADONLY_on (cv_pool_handler);
3322 cv_coro_state_new = get_cv ("Coro::State::new", 0); SvREADONLY_on (cv_coro_state_new); 3556 CvNODEBUG_on (get_cv ("Coro::_pool_handler", 0)); /* work around a debugger bug */
3323 3557
3324 coro_stash = gv_stashpv ("Coro", TRUE); 3558 coro_stash = gv_stashpv ("Coro", TRUE);
3325 3559
3326 newCONSTSUB (coro_stash, "PRIO_MAX", newSViv (CORO_PRIO_MAX)); 3560 newCONSTSUB (coro_stash, "PRIO_MAX", newSViv (CORO_PRIO_MAX));
3327 newCONSTSUB (coro_stash, "PRIO_HIGH", newSViv (CORO_PRIO_HIGH)); 3561 newCONSTSUB (coro_stash, "PRIO_HIGH", newSViv (CORO_PRIO_HIGH));
3328 newCONSTSUB (coro_stash, "PRIO_NORMAL", newSViv (CORO_PRIO_NORMAL)); 3562 newCONSTSUB (coro_stash, "PRIO_NORMAL", newSViv (CORO_PRIO_NORMAL));
… …
3346 sv_setiv (sv, (IV)&coroapi); 3580 sv_setiv (sv, (IV)&coroapi);
3347 SvREADONLY_on (sv); 3581 SvREADONLY_on (sv);
3348 } 3582 }
3349} 3583}
3350 3584
3585SV *
3586async (...)
3587 PROTOTYPE: &@
3588 CODE:
3589 RETVAL = coro_new (aTHX_ coro_stash, &ST (0), items, 1);
3590 api_ready (aTHX_ RETVAL);
3591 OUTPUT:
3592 RETVAL
3593
3594void
3595_destroy (Coro::State coro)
3596 CODE:
3597 /* used by the manager thread */
3598 coro_state_destroy (aTHX_ coro);
3599 coro_call_on_destroy (aTHX_ coro);
3600
3351void 3601void
3352terminate (...) 3602terminate (...)
3353 CODE: 3603 CODE:
3354 CORO_EXECUTE_SLF_XS (slf_init_terminate); 3604 CORO_EXECUTE_SLF_XS (slf_init_terminate);
3605
3606void
3607cancel (...)
3608 CODE:
3609 CORO_EXECUTE_SLF_XS (slf_init_cancel);
3355 3610
3356void 3611void
3357schedule (...) 3612schedule (...)
3358 CODE: 3613 CODE:
3359 CORO_EXECUTE_SLF_XS (slf_init_schedule); 3614 CORO_EXECUTE_SLF_XS (slf_init_schedule);
… …
3393 SvGETMAGIC (hook); 3648 SvGETMAGIC (hook);
3394 if (SvOK (hook)) 3649 if (SvOK (hook))
3395 { 3650 {
3396 coro_readyhook = newSVsv (hook); 3651 coro_readyhook = newSVsv (hook);
3397 CORO_READYHOOK = invoke_sv_ready_hook_helper; 3652 CORO_READYHOOK = invoke_sv_ready_hook_helper;
3398 CORO_READYHOOK ();
3399 } 3653 }
3400 else 3654 else
3401 { 3655 {
3402 coro_readyhook = 0; 3656 coro_readyhook = 0;
3403 CORO_READYHOOK = 0; 3657 CORO_READYHOOK = 0;
… …
3473 for (i = 1; i < items; ++i) 3727 for (i = 1; i < items; ++i)
3474 av_push (av, SvREFCNT_inc_NN (ST (i))); 3728 av_push (av, SvREFCNT_inc_NN (ST (i)));
3475 3729
3476 if ((SV *)hv == &PL_sv_undef) 3730 if ((SV *)hv == &PL_sv_undef)
3477 { 3731 {
3478 PUSHMARK (SP); 3732 SV *sv = coro_new (aTHX_ coro_stash, (SV **)&cv_pool_handler, 1, 1);
3479 EXTEND (SP, 2);
3480 PUSHs (sv_Coro);
3481 PUSHs ((SV *)cv_pool_handler);
3482 PUTBACK;
3483 call_sv ((SV *)cv_coro_state_new, G_SCALAR);
3484 SPAGAIN;
3485
3486 hv = (HV *)SvREFCNT_inc_NN (SvRV (POPs)); 3733 hv = (HV *)SvREFCNT_inc_NN (SvRV (sv));
3734 SvREFCNT_dec (sv);
3487 } 3735 }
3488 3736
3489 { 3737 {
3490 struct coro *coro = SvSTATE_hv (hv); 3738 struct coro *coro = SvSTATE_hv (hv);
3491 3739
… …
3763 { 4011 {
3764 PL_ppaddr [OP_SSELECT] = coro_old_pp_sselect; 4012 PL_ppaddr [OP_SSELECT] = coro_old_pp_sselect;
3765 coro_old_pp_sselect = 0; 4013 coro_old_pp_sselect = 0;
3766 } 4014 }
3767 4015
3768

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines