ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/Coro/Coro/State.xs
(Generate patch)

Comparing Coro/Coro/State.xs (file contents):
Revision 1.395 by root, Fri May 6 07:22:14 2011 UTC vs.
Revision 1.407 by root, Sat Jun 11 15:30:21 2011 UTC

12#include "perl.h" 12#include "perl.h"
13#include "XSUB.h" 13#include "XSUB.h"
14#include "perliol.h" 14#include "perliol.h"
15 15
16#include "schmorp.h" 16#include "schmorp.h"
17#include "ecb.h"
17 18
19#include <stddef.h>
18#include <stdio.h> 20#include <stdio.h>
19#include <errno.h> 21#include <errno.h>
20#include <assert.h> 22#include <assert.h>
21 23
22#ifndef SVs_PADSTALE 24#ifndef SVs_PADSTALE
86# define STACKLEVEL ((void *)&stacklevel) 88# define STACKLEVEL ((void *)&stacklevel)
87#endif 89#endif
88 90
89#define IN_DESTRUCT PL_dirty 91#define IN_DESTRUCT PL_dirty
90 92
91#if __GNUC__ >= 3
92# define attribute(x) __attribute__(x)
93# define expect(expr,value) __builtin_expect ((expr), (value))
94# define INLINE static inline
95#else
96# define attribute(x)
97# define expect(expr,value) (expr)
98# define INLINE static
99#endif
100
101#define expect_false(expr) expect ((expr) != 0, 0)
102#define expect_true(expr) expect ((expr) != 0, 1)
103
104#define NOINLINE attribute ((noinline))
105
106#include "CoroAPI.h" 93#include "CoroAPI.h"
107#define GCoroAPI (&coroapi) /* very sneaky */ 94#define GCoroAPI (&coroapi) /* very sneaky */
108 95
109#ifdef USE_ITHREADS 96#ifdef USE_ITHREADS
110# if CORO_PTHREAD 97# if CORO_PTHREAD
111static void *coro_thx; 98static void *coro_thx;
112# endif 99# endif
113#endif 100#endif
101
102/* used in state.h */
103#define VAR(name,type) VARx(name, PL_ ## name, type)
114 104
115#ifdef __linux 105#ifdef __linux
116# include <time.h> /* for timespec */ 106# include <time.h> /* for timespec */
117# include <syscall.h> /* for SYS_* */ 107# include <syscall.h> /* for SYS_* */
118# ifdef SYS_clock_gettime 108# ifdef SYS_clock_gettime
126static void (*u2time)(pTHX_ UV ret[2]); 116static void (*u2time)(pTHX_ UV ret[2]);
127 117
128/* we hijack an hopefully unused CV flag for our purposes */ 118/* we hijack an hopefully unused CV flag for our purposes */
129#define CVf_SLF 0x4000 119#define CVf_SLF 0x4000
130static OP *pp_slf (pTHX); 120static OP *pp_slf (pTHX);
121static void slf_destroy (pTHX_ struct coro *coro);
131 122
132static U32 cctx_gen; 123static U32 cctx_gen;
133static size_t cctx_stacksize = CORO_STACKSIZE; 124static size_t cctx_stacksize = CORO_STACKSIZE;
134static struct CoroAPI coroapi; 125static struct CoroAPI coroapi;
135static AV *main_mainstack; /* used to differentiate between $main and others */ 126static AV *main_mainstack; /* used to differentiate between $main and others */
165static char times_valid; 156static char times_valid;
166 157
167static struct coro_cctx *cctx_first; 158static struct coro_cctx *cctx_first;
168static int cctx_count, cctx_idle; 159static int cctx_count, cctx_idle;
169 160
170enum { 161enum
162{
171 CC_MAPPED = 0x01, 163 CC_MAPPED = 0x01,
172 CC_NOREUSE = 0x02, /* throw this away after tracing */ 164 CC_NOREUSE = 0x02, /* throw this away after tracing */
173 CC_TRACE = 0x04, 165 CC_TRACE = 0x04,
174 CC_TRACE_SUB = 0x08, /* trace sub calls */ 166 CC_TRACE_SUB = 0x08, /* trace sub calls */
175 CC_TRACE_LINE = 0x10, /* trace each statement */ 167 CC_TRACE_LINE = 0x10, /* trace each statement */
200 192
201static coro_cctx *cctx_current; /* the currently running cctx */ 193static coro_cctx *cctx_current; /* the currently running cctx */
202 194
203/*****************************************************************************/ 195/*****************************************************************************/
204 196
197static MGVTBL coro_state_vtbl;
198
205enum { 199enum
200{
206 CF_RUNNING = 0x0001, /* coroutine is running */ 201 CF_RUNNING = 0x0001, /* coroutine is running */
207 CF_READY = 0x0002, /* coroutine is ready */ 202 CF_READY = 0x0002, /* coroutine is ready */
208 CF_NEW = 0x0004, /* has never been switched to */ 203 CF_NEW = 0x0004, /* has never been switched to */
209 CF_DESTROYED = 0x0008, /* coroutine data has been freed */ 204 CF_ZOMBIE = 0x0008, /* coroutine data has been freed */
210 CF_SUSPENDED = 0x0010, /* coroutine can't be scheduled */ 205 CF_SUSPENDED = 0x0010, /* coroutine can't be scheduled */
211 CF_NOCANCEL = 0x0020, /* cannot cancel, set slf_frame.data to 1 (hackish) */ 206 CF_NOCANCEL = 0x0020, /* cannot cancel, set slf_frame.data to 1 (hackish) */
212}; 207};
213 208
214/* the structure where most of the perl state is stored, overlaid on the cxstack */ 209/* the structure where most of the perl state is stored, overlaid on the cxstack */
215typedef struct 210typedef struct
216{ 211{
217 SV *defsv;
218 AV *defav;
219 SV *errsv;
220 SV *irsgv;
221 HV *hinthv;
222#define VAR(name,type) type name; 212#define VARx(name,expr,type) type name;
223# include "state.h" 213# include "state.h"
224#undef VAR 214#undef VARx
225} perl_slots; 215} perl_slots;
226 216
217// how many context stack entries do we need for perl_slots
227#define SLOT_COUNT ((sizeof (perl_slots) + sizeof (PERL_CONTEXT) - 1) / sizeof (PERL_CONTEXT)) 218#define SLOT_COUNT ((sizeof (perl_slots) + sizeof (PERL_CONTEXT) - 1) / sizeof (PERL_CONTEXT))
228 219
229/* this is a structure representing a perl-level coroutine */ 220/* this is a structure representing a perl-level coroutine */
230struct coro { 221struct coro
222{
231 /* the C coroutine allocated to this perl coroutine, if any */ 223 /* the C coroutine allocated to this perl coroutine, if any */
232 coro_cctx *cctx; 224 coro_cctx *cctx;
233 225
234 /* ready queue */ 226 /* ready queue */
235 struct coro *next_ready; 227 struct coro *next_ready;
237 /* state data */ 229 /* state data */
238 struct CoroSLF slf_frame; /* saved slf frame */ 230 struct CoroSLF slf_frame; /* saved slf frame */
239 AV *mainstack; 231 AV *mainstack;
240 perl_slots *slot; /* basically the saved sp */ 232 perl_slots *slot; /* basically the saved sp */
241 233
242 CV *startcv; /* the CV to execute */ 234 CV *startcv; /* the CV to execute */
243 AV *args; /* data associated with this coroutine (initial args) */ 235 AV *args; /* data associated with this coroutine (initial args) */
244 int refcnt; /* coroutines are refcounted, yes */
245 int flags; /* CF_ flags */ 236 int flags; /* CF_ flags */
246 HV *hv; /* the perl hash associated with this coro, if any */ 237 HV *hv; /* the perl hash associated with this coro, if any */
247 void (*on_destroy)(pTHX_ struct coro *coro); /* for temporary use by xs in critical sections */
248 238
249 /* statistics */ 239 /* statistics */
250 int usecount; /* number of transfers to this coro */ 240 int usecount; /* number of transfers to this coro */
251 241
252 /* coro process data */ 242 /* coro process data */
253 int prio; 243 int prio;
254 SV *except; /* exception to be thrown */ 244 SV *except; /* exception to be thrown */
255 SV *rouse_cb; 245 SV *rouse_cb; /* last rouse callback */
246 AV *on_destroy; /* callbacks or coros to notify on destroy */
247 AV *status; /* the exit status list */
256 248
257 /* async_pool */ 249 /* async_pool */
258 SV *saved_deffh; 250 SV *saved_deffh;
259 SV *invoke_cb; 251 SV *invoke_cb;
260 AV *invoke_av; 252 AV *invoke_av;
292 284
293/* for Coro.pm */ 285/* for Coro.pm */
294static SV *coro_current; 286static SV *coro_current;
295static SV *coro_readyhook; 287static SV *coro_readyhook;
296static struct coro *coro_ready [CORO_PRIO_MAX - CORO_PRIO_MIN + 1][2]; /* head|tail */ 288static struct coro *coro_ready [CORO_PRIO_MAX - CORO_PRIO_MIN + 1][2]; /* head|tail */
297static CV *cv_coro_run, *cv_coro_terminate; 289static CV *cv_coro_run;
298static struct coro *coro_first; 290static struct coro *coro_first;
299#define coro_nready coroapi.nready 291#define coro_nready coroapi.nready
292
293/** JIT *********************************************************************/
294
295#if CORO_JIT
296 #ifndef CORO_JIT_TYPE
297 #if __x86_64 && (__linux || __FreeBSD__ || __OpenBSD__ || __NetBSD__ || __solaris)
298 #define CORO_JIT_TYPE "amd64-unix"
299 typedef void (*load_save_perl_slots_type)(perl_slots *);
300 #elif __i386 && (__linux || __FreeBSD__ || __OpenBSD__ || __NetBSD__ || __solaris)
301 #define CORO_JIT_TYPE "x86-unix"
302 typedef void (*load_save_perl_slots_type)(perl_slots *);
303 #else
304 #undef CORO_JIT
305 #endif
306 #endif
307#endif
308
309#if CORO_JIT
310static load_save_perl_slots_type load_perl_slots, save_perl_slots;
311#endif
300 312
301/** Coro::Select ************************************************************/ 313/** Coro::Select ************************************************************/
302 314
303static OP *(*coro_old_pp_sselect) (pTHX); 315static OP *(*coro_old_pp_sselect) (pTHX);
304static SV *coro_select_select; 316static SV *coro_select_select;
320 332
321/** time stuff **************************************************************/ 333/** time stuff **************************************************************/
322 334
323#ifdef HAS_GETTIMEOFDAY 335#ifdef HAS_GETTIMEOFDAY
324 336
325static void 337ECB_INLINE void
326coro_u2time (pTHX_ UV ret[2]) 338coro_u2time (pTHX_ UV ret[2])
327{ 339{
328 struct timeval tv; 340 struct timeval tv;
329 gettimeofday (&tv, 0); 341 gettimeofday (&tv, 0);
330 342
331 ret [0] = tv.tv_sec; 343 ret [0] = tv.tv_sec;
332 ret [1] = tv.tv_usec; 344 ret [1] = tv.tv_usec;
333} 345}
334 346
335static double 347ECB_INLINE double
336coro_nvtime () 348coro_nvtime ()
337{ 349{
338 struct timeval tv; 350 struct timeval tv;
339 gettimeofday (&tv, 0); 351 gettimeofday (&tv, 0);
340 352
341 return tv.tv_sec + tv.tv_usec * 1e-6; 353 return tv.tv_sec + tv.tv_usec * 1e-6;
342} 354}
343 355
344static void 356ECB_INLINE void
345time_init (pTHX) 357time_init (pTHX)
346{ 358{
347 nvtime = coro_nvtime; 359 nvtime = coro_nvtime;
348 u2time = coro_u2time; 360 u2time = coro_u2time;
349} 361}
350 362
351#else 363#else
352 364
353static void 365ECB_INLINE void
354time_init (pTHX) 366time_init (pTHX)
355{ 367{
356 SV **svp; 368 SV **svp;
357 369
358 require_pv ("Time/HiRes.pm"); 370 require_pv ("Time/HiRes.pm");
370 382
371#endif 383#endif
372 384
373/** lowlevel stuff **********************************************************/ 385/** lowlevel stuff **********************************************************/
374 386
375static SV * 387static SV * ecb_noinline
376coro_get_sv (pTHX_ const char *name, int create) 388coro_get_sv (pTHX_ const char *name, int create)
377{ 389{
378#if PERL_VERSION_ATLEAST (5,10,0) 390#if PERL_VERSION_ATLEAST (5,10,0)
379 /* silence stupid and wrong 5.10 warning that I am unable to switch off */ 391 /* silence stupid and wrong 5.10 warning that I am unable to switch off */
380 get_sv (name, create); 392 get_sv (name, create);
381#endif 393#endif
382 return get_sv (name, create); 394 return get_sv (name, create);
383} 395}
384 396
385static AV * 397static AV * ecb_noinline
386coro_get_av (pTHX_ const char *name, int create) 398coro_get_av (pTHX_ const char *name, int create)
387{ 399{
388#if PERL_VERSION_ATLEAST (5,10,0) 400#if PERL_VERSION_ATLEAST (5,10,0)
389 /* silence stupid and wrong 5.10 warning that I am unable to switch off */ 401 /* silence stupid and wrong 5.10 warning that I am unable to switch off */
390 get_av (name, create); 402 get_av (name, create);
391#endif 403#endif
392 return get_av (name, create); 404 return get_av (name, create);
393} 405}
394 406
395static HV * 407static HV * ecb_noinline
396coro_get_hv (pTHX_ const char *name, int create) 408coro_get_hv (pTHX_ const char *name, int create)
397{ 409{
398#if PERL_VERSION_ATLEAST (5,10,0) 410#if PERL_VERSION_ATLEAST (5,10,0)
399 /* silence stupid and wrong 5.10 warning that I am unable to switch off */ 411 /* silence stupid and wrong 5.10 warning that I am unable to switch off */
400 get_hv (name, create); 412 get_hv (name, create);
401#endif 413#endif
402 return get_hv (name, create); 414 return get_hv (name, create);
403} 415}
404 416
405INLINE void 417ECB_INLINE void
406coro_times_update () 418coro_times_update ()
407{ 419{
408#ifdef coro_clock_gettime 420#ifdef coro_clock_gettime
409 struct timespec ts; 421 struct timespec ts;
410 422
423 time_real [0] = tv [0]; 435 time_real [0] = tv [0];
424 time_real [1] = tv [1] * 1000; 436 time_real [1] = tv [1] * 1000;
425#endif 437#endif
426} 438}
427 439
428INLINE void 440ECB_INLINE void
429coro_times_add (struct coro *c) 441coro_times_add (struct coro *c)
430{ 442{
431 c->t_real [1] += time_real [1]; 443 c->t_real [1] += time_real [1];
432 if (c->t_real [1] > 1000000000) { c->t_real [1] -= 1000000000; ++c->t_real [0]; } 444 if (c->t_real [1] > 1000000000) { c->t_real [1] -= 1000000000; ++c->t_real [0]; }
433 c->t_real [0] += time_real [0]; 445 c->t_real [0] += time_real [0];
435 c->t_cpu [1] += time_cpu [1]; 447 c->t_cpu [1] += time_cpu [1];
436 if (c->t_cpu [1] > 1000000000) { c->t_cpu [1] -= 1000000000; ++c->t_cpu [0]; } 448 if (c->t_cpu [1] > 1000000000) { c->t_cpu [1] -= 1000000000; ++c->t_cpu [0]; }
437 c->t_cpu [0] += time_cpu [0]; 449 c->t_cpu [0] += time_cpu [0];
438} 450}
439 451
440INLINE void 452ECB_INLINE void
441coro_times_sub (struct coro *c) 453coro_times_sub (struct coro *c)
442{ 454{
443 if (c->t_real [1] < time_real [1]) { c->t_real [1] += 1000000000; --c->t_real [0]; } 455 if (c->t_real [1] < time_real [1]) { c->t_real [1] += 1000000000; --c->t_real [0]; }
444 c->t_real [1] -= time_real [1]; 456 c->t_real [1] -= time_real [1];
445 c->t_real [0] -= time_real [0]; 457 c->t_real [0] -= time_real [0];
453/* magic glue */ 465/* magic glue */
454 466
455#define CORO_MAGIC_type_cv 26 467#define CORO_MAGIC_type_cv 26
456#define CORO_MAGIC_type_state PERL_MAGIC_ext 468#define CORO_MAGIC_type_state PERL_MAGIC_ext
457 469
458#define CORO_MAGIC_NN(sv, type) \ 470#define CORO_MAGIC_NN(sv, type) \
459 (expect_true (SvMAGIC (sv)->mg_type == type) \ 471 (ecb_expect_true (SvMAGIC (sv)->mg_type == type) \
460 ? SvMAGIC (sv) \ 472 ? SvMAGIC (sv) \
461 : mg_find (sv, type)) 473 : mg_find (sv, type))
462 474
463#define CORO_MAGIC(sv, type) \ 475#define CORO_MAGIC(sv, type) \
464 (expect_true (SvMAGIC (sv)) \ 476 (ecb_expect_true (SvMAGIC (sv)) \
465 ? CORO_MAGIC_NN (sv, type) \ 477 ? CORO_MAGIC_NN (sv, type) \
466 : 0) 478 : 0)
467 479
468#define CORO_MAGIC_cv(cv) CORO_MAGIC (((SV *)(cv)), CORO_MAGIC_type_cv) 480#define CORO_MAGIC_cv(cv) CORO_MAGIC (((SV *)(cv)), CORO_MAGIC_type_cv)
469#define CORO_MAGIC_state(sv) CORO_MAGIC_NN (((SV *)(sv)), CORO_MAGIC_type_state) 481#define CORO_MAGIC_state(sv) CORO_MAGIC_NN (((SV *)(sv)), CORO_MAGIC_type_state)
470 482
483ECB_INLINE MAGIC *
484SvSTATEhv_p (pTHX_ SV *coro)
485{
486 MAGIC *mg;
487
488 if (ecb_expect_true (
489 SvTYPE (coro) == SVt_PVHV
490 && (mg = CORO_MAGIC_state (coro))
491 && mg->mg_virtual == &coro_state_vtbl
492 ))
493 return mg;
494
495 return 0;
496}
497
471INLINE struct coro * 498ECB_INLINE struct coro *
472SvSTATE_ (pTHX_ SV *coro) 499SvSTATE_ (pTHX_ SV *coro)
473{ 500{
474 HV *stash;
475 MAGIC *mg; 501 MAGIC *mg;
476 502
477 if (SvROK (coro)) 503 if (SvROK (coro))
478 coro = SvRV (coro); 504 coro = SvRV (coro);
479 505
480 if (expect_false (SvTYPE (coro) != SVt_PVHV)) 506 mg = SvSTATEhv_p (aTHX_ coro);
507 if (!mg)
481 croak ("Coro::State object required"); 508 croak ("Coro::State object required");
482 509
483 stash = SvSTASH (coro);
484 if (expect_false (stash != coro_stash && stash != coro_state_stash))
485 {
486 /* very slow, but rare, check */
487 if (!sv_derived_from (sv_2mortal (newRV_inc (coro)), "Coro::State"))
488 croak ("Coro::State object required");
489 }
490
491 mg = CORO_MAGIC_state (coro);
492 return (struct coro *)mg->mg_ptr; 510 return (struct coro *)mg->mg_ptr;
493} 511}
494 512
495#define SvSTATE(sv) SvSTATE_ (aTHX_ (sv)) 513#define SvSTATE(sv) SvSTATE_ (aTHX_ (sv))
496 514
499#define SvSTATE_current SvSTATE_hv (SvRV (coro_current)) 517#define SvSTATE_current SvSTATE_hv (SvRV (coro_current))
500 518
501/*****************************************************************************/ 519/*****************************************************************************/
502/* padlist management and caching */ 520/* padlist management and caching */
503 521
504static AV * 522ECB_INLINE AV *
505coro_derive_padlist (pTHX_ CV *cv) 523coro_derive_padlist (pTHX_ CV *cv)
506{ 524{
507 AV *padlist = CvPADLIST (cv); 525 AV *padlist = CvPADLIST (cv);
508 AV *newpadlist, *newpad; 526 AV *newpadlist, *newpad;
509 527
521 av_store (newpadlist, 1, (SV *)newpad); 539 av_store (newpadlist, 1, (SV *)newpad);
522 540
523 return newpadlist; 541 return newpadlist;
524} 542}
525 543
526static void 544ECB_INLINE void
527free_padlist (pTHX_ AV *padlist) 545free_padlist (pTHX_ AV *padlist)
528{ 546{
529 /* may be during global destruction */ 547 /* may be during global destruction */
530 if (!IN_DESTRUCT) 548 if (!IN_DESTRUCT)
531 { 549 {
574 0, 0, 0, 0, 592 0, 0, 0, 0,
575 coro_cv_free 593 coro_cv_free
576}; 594};
577 595
578/* the next two functions merely cache the padlists */ 596/* the next two functions merely cache the padlists */
579static void 597ECB_INLINE void
580get_padlist (pTHX_ CV *cv) 598get_padlist (pTHX_ CV *cv)
581{ 599{
582 MAGIC *mg = CORO_MAGIC_cv (cv); 600 MAGIC *mg = CORO_MAGIC_cv (cv);
583 AV *av; 601 AV *av;
584 602
585 if (expect_true (mg && AvFILLp ((av = (AV *)mg->mg_obj)) >= 0)) 603 if (ecb_expect_true (mg && AvFILLp ((av = (AV *)mg->mg_obj)) >= 0))
586 CvPADLIST (cv) = (AV *)AvARRAY (av)[AvFILLp (av)--]; 604 CvPADLIST (cv) = (AV *)AvARRAY (av)[AvFILLp (av)--];
587 else 605 else
588 { 606 {
589#if CORO_PREFER_PERL_FUNCTIONS 607#if CORO_PREFER_PERL_FUNCTIONS
590 /* this is probably cleaner? but also slower! */ 608 /* this is probably cleaner? but also slower! */
597 CvPADLIST (cv) = coro_derive_padlist (aTHX_ cv); 615 CvPADLIST (cv) = coro_derive_padlist (aTHX_ cv);
598#endif 616#endif
599 } 617 }
600} 618}
601 619
602static void 620ECB_INLINE void
603put_padlist (pTHX_ CV *cv) 621put_padlist (pTHX_ CV *cv)
604{ 622{
605 MAGIC *mg = CORO_MAGIC_cv (cv); 623 MAGIC *mg = CORO_MAGIC_cv (cv);
606 AV *av; 624 AV *av;
607 625
608 if (expect_false (!mg)) 626 if (ecb_expect_false (!mg))
609 mg = sv_magicext ((SV *)cv, (SV *)newAV (), CORO_MAGIC_type_cv, &coro_cv_vtbl, 0, 0); 627 mg = sv_magicext ((SV *)cv, (SV *)newAV (), CORO_MAGIC_type_cv, &coro_cv_vtbl, 0, 0);
610 628
611 av = (AV *)mg->mg_obj; 629 av = (AV *)mg->mg_obj;
612 630
613 if (expect_false (AvFILLp (av) >= AvMAX (av))) 631 if (ecb_expect_false (AvFILLp (av) >= AvMAX (av)))
614 av_extend (av, AvFILLp (av) + 1); 632 av_extend (av, AvFILLp (av) + 1);
615 633
616 AvARRAY (av)[++AvFILLp (av)] = (SV *)CvPADLIST (cv); 634 AvARRAY (av)[++AvFILLp (av)] = (SV *)CvPADLIST (cv);
617} 635}
618 636
663 } 681 }
664#endif 682#endif
665 } 683 }
666} 684}
667 685
668#define SWAP_SVS(coro) \ 686#define SWAP_SVS(coro) \
669 if (expect_false ((coro)->swap_sv)) \ 687 if (ecb_expect_false ((coro)->swap_sv)) \
670 swap_svs (aTHX_ (coro)) 688 swap_svs (aTHX_ (coro))
671 689
672static void 690static void
673on_enterleave_call (pTHX_ SV *cb); 691on_enterleave_call (pTHX_ SV *cb);
674 692
678 perl_slots *slot = c->slot; 696 perl_slots *slot = c->slot;
679 c->slot = 0; 697 c->slot = 0;
680 698
681 PL_mainstack = c->mainstack; 699 PL_mainstack = c->mainstack;
682 700
683 GvSV (PL_defgv) = slot->defsv; 701#if CORO_JIT
684 GvAV (PL_defgv) = slot->defav; 702 load_perl_slots (slot);
685 GvSV (PL_errgv) = slot->errsv; 703#else
686 GvSV (irsgv) = slot->irsgv;
687 GvHV (PL_hintgv) = slot->hinthv;
688
689 #define VAR(name,type) PL_ ## name = slot->name; 704 #define VARx(name,expr,type) expr = slot->name;
690 # include "state.h" 705 # include "state.h"
691 #undef VAR 706 #undef VARx
707#endif
692 708
693 { 709 {
694 dSP; 710 dSP;
695 711
696 CV *cv; 712 CV *cv;
697 713
698 /* now do the ugly restore mess */ 714 /* now do the ugly restore mess */
699 while (expect_true (cv = (CV *)POPs)) 715 while (ecb_expect_true (cv = (CV *)POPs))
700 { 716 {
701 put_padlist (aTHX_ cv); /* mark this padlist as available */ 717 put_padlist (aTHX_ cv); /* mark this padlist as available */
702 CvDEPTH (cv) = PTR2IV (POPs); 718 CvDEPTH (cv) = PTR2IV (POPs);
703 CvPADLIST (cv) = (AV *)POPs; 719 CvPADLIST (cv) = (AV *)POPs;
704 } 720 }
707 } 723 }
708 724
709 slf_frame = c->slf_frame; 725 slf_frame = c->slf_frame;
710 CORO_THROW = c->except; 726 CORO_THROW = c->except;
711 727
712 if (expect_false (enable_times)) 728 if (ecb_expect_false (enable_times))
713 { 729 {
714 if (expect_false (!times_valid)) 730 if (ecb_expect_false (!times_valid))
715 coro_times_update (); 731 coro_times_update ();
716 732
717 coro_times_sub (c); 733 coro_times_sub (c);
718 } 734 }
719 735
720 if (expect_false (c->on_enter)) 736 if (ecb_expect_false (c->on_enter))
721 { 737 {
722 int i; 738 int i;
723 739
724 for (i = 0; i <= AvFILLp (c->on_enter); ++i) 740 for (i = 0; i <= AvFILLp (c->on_enter); ++i)
725 on_enterleave_call (aTHX_ AvARRAY (c->on_enter)[i]); 741 on_enterleave_call (aTHX_ AvARRAY (c->on_enter)[i]);
731static void 747static void
732save_perl (pTHX_ Coro__State c) 748save_perl (pTHX_ Coro__State c)
733{ 749{
734 SWAP_SVS (c); 750 SWAP_SVS (c);
735 751
736 if (expect_false (c->on_leave)) 752 if (ecb_expect_false (c->on_leave))
737 { 753 {
738 int i; 754 int i;
739 755
740 for (i = AvFILLp (c->on_leave); i >= 0; --i) 756 for (i = AvFILLp (c->on_leave); i >= 0; --i)
741 on_enterleave_call (aTHX_ AvARRAY (c->on_leave)[i]); 757 on_enterleave_call (aTHX_ AvARRAY (c->on_leave)[i]);
742 } 758 }
743 759
744 times_valid = 0; 760 times_valid = 0;
745 761
746 if (expect_false (enable_times)) 762 if (ecb_expect_false (enable_times))
747 { 763 {
748 coro_times_update (); times_valid = 1; 764 coro_times_update (); times_valid = 1;
749 coro_times_add (c); 765 coro_times_add (c);
750 } 766 }
751 767
765 781
766 XPUSHs (Nullsv); 782 XPUSHs (Nullsv);
767 /* this loop was inspired by pp_caller */ 783 /* this loop was inspired by pp_caller */
768 for (;;) 784 for (;;)
769 { 785 {
770 while (expect_true (cxix >= 0)) 786 while (ecb_expect_true (cxix >= 0))
771 { 787 {
772 PERL_CONTEXT *cx = &ccstk[cxix--]; 788 PERL_CONTEXT *cx = &ccstk[cxix--];
773 789
774 if (expect_true (CxTYPE (cx) == CXt_SUB) || expect_false (CxTYPE (cx) == CXt_FORMAT)) 790 if (ecb_expect_true (CxTYPE (cx) == CXt_SUB) || ecb_expect_false (CxTYPE (cx) == CXt_FORMAT))
775 { 791 {
776 CV *cv = cx->blk_sub.cv; 792 CV *cv = cx->blk_sub.cv;
777 793
778 if (expect_true (CvDEPTH (cv))) 794 if (ecb_expect_true (CvDEPTH (cv)))
779 { 795 {
780 EXTEND (SP, 3); 796 EXTEND (SP, 3);
781 PUSHs ((SV *)CvPADLIST (cv)); 797 PUSHs ((SV *)CvPADLIST (cv));
782 PUSHs (INT2PTR (SV *, (IV)CvDEPTH (cv))); 798 PUSHs (INT2PTR (SV *, (IV)CvDEPTH (cv)));
783 PUSHs ((SV *)cv); 799 PUSHs ((SV *)cv);
786 get_padlist (aTHX_ cv); 802 get_padlist (aTHX_ cv);
787 } 803 }
788 } 804 }
789 } 805 }
790 806
791 if (expect_true (top_si->si_type == PERLSI_MAIN)) 807 if (ecb_expect_true (top_si->si_type == PERLSI_MAIN))
792 break; 808 break;
793 809
794 top_si = top_si->si_prev; 810 top_si = top_si->si_prev;
795 ccstk = top_si->si_cxstack; 811 ccstk = top_si->si_cxstack;
796 cxix = top_si->si_cxix; 812 cxix = top_si->si_cxix;
798 814
799 PUTBACK; 815 PUTBACK;
800 } 816 }
801 817
802 /* allocate some space on the context stack for our purposes */ 818 /* allocate some space on the context stack for our purposes */
803 /* we manually unroll here, as usually 2 slots is enough */ 819 if (ecb_expect_false (cxstack_ix + SLOT_COUNT >= cxstack_max))
804 if (SLOT_COUNT >= 1) CXINC;
805 if (SLOT_COUNT >= 2) CXINC;
806 if (SLOT_COUNT >= 3) CXINC;
807 { 820 {
808 unsigned int i; 821 unsigned int i;
822
809 for (i = 3; i < SLOT_COUNT; ++i) 823 for (i = 0; i < SLOT_COUNT; ++i)
810 CXINC; 824 CXINC;
811 } 825
812 cxstack_ix -= SLOT_COUNT; /* undo allocation */ 826 cxstack_ix -= SLOT_COUNT; /* undo allocation */
827 }
813 828
814 c->mainstack = PL_mainstack; 829 c->mainstack = PL_mainstack;
815 830
816 { 831 {
817 perl_slots *slot = c->slot = (perl_slots *)(cxstack + cxstack_ix + 1); 832 perl_slots *slot = c->slot = (perl_slots *)(cxstack + cxstack_ix + 1);
818 833
819 slot->defav = GvAV (PL_defgv); 834#if CORO_JIT
820 slot->defsv = DEFSV; 835 save_perl_slots (slot);
821 slot->errsv = ERRSV; 836#else
822 slot->irsgv = GvSV (irsgv);
823 slot->hinthv = GvHV (PL_hintgv);
824
825 #define VAR(name,type) slot->name = PL_ ## name; 837 #define VARx(name,expr,type) slot->name = expr;
826 # include "state.h" 838 # include "state.h"
827 #undef VAR 839 #undef VARx
840#endif
828 } 841 }
829} 842}
830 843
831/* 844/*
832 * allocate various perl stacks. This is almost an exact copy 845 * allocate various perl stacks. This is almost an exact copy
838# define coro_init_stacks(thx) init_stacks () 851# define coro_init_stacks(thx) init_stacks ()
839#else 852#else
840static void 853static void
841coro_init_stacks (pTHX) 854coro_init_stacks (pTHX)
842{ 855{
843 PL_curstackinfo = new_stackinfo(32, 8); 856 PL_curstackinfo = new_stackinfo(32, 4 + SLOT_COUNT); /* 3 is minimum due to perl rounding down in scope.c:GROW() */
844 PL_curstackinfo->si_type = PERLSI_MAIN; 857 PL_curstackinfo->si_type = PERLSI_MAIN;
845 PL_curstack = PL_curstackinfo->si_stack; 858 PL_curstack = PL_curstackinfo->si_stack;
846 PL_mainstack = PL_curstack; /* remember in case we switch stacks */ 859 PL_mainstack = PL_curstack; /* remember in case we switch stacks */
847 860
848 PL_stack_base = AvARRAY(PL_curstack); 861 PL_stack_base = AvARRAY(PL_curstack);
955#endif 968#endif
956 969
957/* 970/*
958 * This overrides the default magic get method of %SIG elements. 971 * This overrides the default magic get method of %SIG elements.
959 * The original one doesn't provide for reading back of PL_diehook/PL_warnhook 972 * The original one doesn't provide for reading back of PL_diehook/PL_warnhook
960 * and instead of trying to save and restore the hash elements, we just provide 973 * and instead of trying to save and restore the hash elements (extremely slow),
961 * readback here. 974 * we just provide our own readback here.
962 */ 975 */
963static int 976static int ecb_cold
964coro_sigelem_get (pTHX_ SV *sv, MAGIC *mg) 977coro_sigelem_get (pTHX_ SV *sv, MAGIC *mg)
965{ 978{
966 const char *s = MgPV_nolen_const (mg); 979 const char *s = MgPV_nolen_const (mg);
967 980
968 if (*s == '_') 981 if (*s == '_')
980 } 993 }
981 994
982 return orig_sigelem_get ? orig_sigelem_get (aTHX_ sv, mg) : 0; 995 return orig_sigelem_get ? orig_sigelem_get (aTHX_ sv, mg) : 0;
983} 996}
984 997
985static int 998static int ecb_cold
986coro_sigelem_clr (pTHX_ SV *sv, MAGIC *mg) 999coro_sigelem_clr (pTHX_ SV *sv, MAGIC *mg)
987{ 1000{
988 const char *s = MgPV_nolen_const (mg); 1001 const char *s = MgPV_nolen_const (mg);
989 1002
990 if (*s == '_') 1003 if (*s == '_')
1004 } 1017 }
1005 1018
1006 return orig_sigelem_clr ? orig_sigelem_clr (aTHX_ sv, mg) : 0; 1019 return orig_sigelem_clr ? orig_sigelem_clr (aTHX_ sv, mg) : 0;
1007} 1020}
1008 1021
1009static int 1022static int ecb_cold
1010coro_sigelem_set (pTHX_ SV *sv, MAGIC *mg) 1023coro_sigelem_set (pTHX_ SV *sv, MAGIC *mg)
1011{ 1024{
1012 const char *s = MgPV_nolen_const (mg); 1025 const char *s = MgPV_nolen_const (mg);
1013 1026
1014 if (*s == '_') 1027 if (*s == '_')
1049 return 1; 1062 return 1;
1050} 1063}
1051 1064
1052static UNOP init_perl_op; 1065static UNOP init_perl_op;
1053 1066
1054static void NOINLINE /* noinline to keep it out of the transfer fast path */ 1067ecb_noinline static void /* noinline to keep it out of the transfer fast path */
1055init_perl (pTHX_ struct coro *coro) 1068init_perl (pTHX_ struct coro *coro)
1056{ 1069{
1057 /* 1070 /*
1058 * emulate part of the perl startup here. 1071 * emulate part of the perl startup here.
1059 */ 1072 */
1074 PL_parser = 0; 1087 PL_parser = 0;
1075#endif 1088#endif
1076 PL_hints = 0; 1089 PL_hints = 0;
1077 1090
1078 /* recreate the die/warn hooks */ 1091 /* recreate the die/warn hooks */
1079 PL_diehook = 0; SvSetMagicSV (*hv_fetch (hv_sig, "__DIE__" , sizeof ("__DIE__" ) - 1, 1), rv_diehook ); 1092 PL_diehook = SvREFCNT_inc (rv_diehook);
1080 PL_warnhook = 0; SvSetMagicSV (*hv_fetch (hv_sig, "__WARN__", sizeof ("__WARN__") - 1, 1), rv_warnhook); 1093 PL_warnhook = SvREFCNT_inc (rv_warnhook);
1081 1094
1082 GvSV (PL_defgv) = newSV (0); 1095 GvSV (PL_defgv) = newSV (0);
1083 GvAV (PL_defgv) = coro->args; coro->args = 0; 1096 GvAV (PL_defgv) = coro->args; coro->args = 0;
1084 GvSV (PL_errgv) = newSV (0); 1097 GvSV (PL_errgv) = newSV (0);
1085 GvSV (irsgv) = newSVpvn ("\n", 1); sv_magic (GvSV (irsgv), (SV *)irsgv, PERL_MAGIC_sv, "/", 0); 1098 GvSV (irsgv) = newSVpvn ("\n", 1); sv_magic (GvSV (irsgv), (SV *)irsgv, PERL_MAGIC_sv, "/", 0);
1106 /* this newly created coroutine might be run on an existing cctx which most 1119 /* this newly created coroutine might be run on an existing cctx which most
1107 * likely was suspended in pp_slf, so we have to emulate entering pp_slf here. 1120 * likely was suspended in pp_slf, so we have to emulate entering pp_slf here.
1108 */ 1121 */
1109 slf_frame.prepare = prepare_nop; /* provide a nop function for an eventual pp_slf */ 1122 slf_frame.prepare = prepare_nop; /* provide a nop function for an eventual pp_slf */
1110 slf_frame.check = slf_check_nop; /* signal pp_slf to not repeat */ 1123 slf_frame.check = slf_check_nop; /* signal pp_slf to not repeat */
1124 slf_frame.destroy = 0;
1111 1125
1112 /* and we have to provide the pp_slf op in any case, so pp_slf can skip it */ 1126 /* and we have to provide the pp_slf op in any case, so pp_slf can skip it */
1113 init_perl_op.op_next = PL_op; 1127 init_perl_op.op_next = PL_op;
1114 init_perl_op.op_type = OP_ENTERSUB; 1128 init_perl_op.op_type = OP_ENTERSUB;
1115 init_perl_op.op_ppaddr = pp_slf; 1129 init_perl_op.op_ppaddr = pp_slf;
1120 /* copy throw, in case it was set before init_perl */ 1134 /* copy throw, in case it was set before init_perl */
1121 CORO_THROW = coro->except; 1135 CORO_THROW = coro->except;
1122 1136
1123 SWAP_SVS (coro); 1137 SWAP_SVS (coro);
1124 1138
1125 if (expect_false (enable_times)) 1139 if (ecb_expect_false (enable_times))
1126 { 1140 {
1127 coro_times_update (); 1141 coro_times_update ();
1128 coro_times_sub (coro); 1142 coro_times_sub (coro);
1129 } 1143 }
1130} 1144}
1154destroy_perl (pTHX_ struct coro *coro) 1168destroy_perl (pTHX_ struct coro *coro)
1155{ 1169{
1156 SV *svf [9]; 1170 SV *svf [9];
1157 1171
1158 { 1172 {
1173 SV *old_current = SvRV (coro_current);
1159 struct coro *current = SvSTATE_current; 1174 struct coro *current = SvSTATE (old_current);
1160 1175
1161 assert (("FATAL: tried to destroy currently running coroutine", coro->mainstack != PL_mainstack)); 1176 assert (("FATAL: tried to destroy currently running coroutine", coro->mainstack != PL_mainstack));
1162 1177
1163 save_perl (aTHX_ current); 1178 save_perl (aTHX_ current);
1179
1180 /* this will cause transfer_check to croak on block*/
1164 /*SvRV_set (coro_current, (SV *)coro->hv);*/ 1181 SvRV_set (coro_current, (SV *)coro->hv);
1182
1165 load_perl (aTHX_ coro); 1183 load_perl (aTHX_ coro);
1166 1184
1167 coro_unwind_stacks (aTHX); 1185 coro_unwind_stacks (aTHX);
1168 coro_destruct_stacks (aTHX);
1169 1186
1170 /* restore swapped sv's */ 1187 /* restore swapped sv's */
1171 SWAP_SVS (coro); 1188 SWAP_SVS (coro);
1189
1190 coro_destruct_stacks (aTHX);
1172 1191
1173 // now save some sv's to be free'd later 1192 // now save some sv's to be free'd later
1174 svf [0] = GvSV (PL_defgv); 1193 svf [0] = GvSV (PL_defgv);
1175 svf [1] = (SV *)GvAV (PL_defgv); 1194 svf [1] = (SV *)GvAV (PL_defgv);
1176 svf [2] = GvSV (PL_errgv); 1195 svf [2] = GvSV (PL_errgv);
1180 svf [6] = (SV *)GvHV (PL_hintgv); 1199 svf [6] = (SV *)GvHV (PL_hintgv);
1181 svf [7] = PL_diehook; 1200 svf [7] = PL_diehook;
1182 svf [8] = PL_warnhook; 1201 svf [8] = PL_warnhook;
1183 assert (9 == sizeof (svf) / sizeof (*svf)); 1202 assert (9 == sizeof (svf) / sizeof (*svf));
1184 1203
1185 /*SvRV_set (coro_current, (SV *)current->hv);*/ 1204 SvRV_set (coro_current, old_current);
1205
1186 load_perl (aTHX_ current); 1206 load_perl (aTHX_ current);
1187 } 1207 }
1188 1208
1189 { 1209 {
1190 unsigned int i; 1210 unsigned int i;
1197 SvREFCNT_dec (coro->invoke_cb); 1217 SvREFCNT_dec (coro->invoke_cb);
1198 SvREFCNT_dec (coro->invoke_av); 1218 SvREFCNT_dec (coro->invoke_av);
1199 } 1219 }
1200} 1220}
1201 1221
1202INLINE void 1222ECB_INLINE void
1203free_coro_mortal (pTHX) 1223free_coro_mortal (pTHX)
1204{ 1224{
1205 if (expect_true (coro_mortal)) 1225 if (ecb_expect_true (coro_mortal))
1206 { 1226 {
1207 SvREFCNT_dec (coro_mortal); 1227 SvREFCNT_dec ((SV *)coro_mortal);
1208 coro_mortal = 0; 1228 coro_mortal = 0;
1209 } 1229 }
1210} 1230}
1211 1231
1212static int 1232static int
1345 1365
1346 return frame->check (aTHX_ frame); /* execute the restored frame - there must be one */ 1366 return frame->check (aTHX_ frame); /* execute the restored frame - there must be one */
1347} 1367}
1348 1368
1349/* initialises PL_top_env and injects a pseudo-slf-call to set the stacklevel */ 1369/* initialises PL_top_env and injects a pseudo-slf-call to set the stacklevel */
1350static void NOINLINE 1370static void ecb_noinline
1351cctx_prepare (pTHX) 1371cctx_prepare (pTHX)
1352{ 1372{
1353 PL_top_env = &PL_start_env; 1373 PL_top_env = &PL_start_env;
1354 1374
1355 if (cctx_current->flags & CC_TRACE) 1375 if (cctx_current->flags & CC_TRACE)
1366 slf_frame.prepare = slf_prepare_set_stacklevel; 1386 slf_frame.prepare = slf_prepare_set_stacklevel;
1367 slf_frame.check = slf_check_set_stacklevel; 1387 slf_frame.check = slf_check_set_stacklevel;
1368} 1388}
1369 1389
1370/* the tail of transfer: execute stuff we can only do after a transfer */ 1390/* the tail of transfer: execute stuff we can only do after a transfer */
1371INLINE void 1391ECB_INLINE void
1372transfer_tail (pTHX) 1392transfer_tail (pTHX)
1373{ 1393{
1374 free_coro_mortal (aTHX); 1394 free_coro_mortal (aTHX);
1375} 1395}
1376 1396
1528#define CCTX_EXPIRED(cctx) ((cctx)->gen != cctx_gen || ((cctx)->flags & CC_NOREUSE)) 1548#define CCTX_EXPIRED(cctx) ((cctx)->gen != cctx_gen || ((cctx)->flags & CC_NOREUSE))
1529 1549
1530static coro_cctx * 1550static coro_cctx *
1531cctx_get (pTHX) 1551cctx_get (pTHX)
1532{ 1552{
1533 while (expect_true (cctx_first)) 1553 while (ecb_expect_true (cctx_first))
1534 { 1554 {
1535 coro_cctx *cctx = cctx_first; 1555 coro_cctx *cctx = cctx_first;
1536 cctx_first = cctx->next; 1556 cctx_first = cctx->next;
1537 --cctx_idle; 1557 --cctx_idle;
1538 1558
1539 if (expect_true (!CCTX_EXPIRED (cctx))) 1559 if (ecb_expect_true (!CCTX_EXPIRED (cctx)))
1540 return cctx; 1560 return cctx;
1541 1561
1542 cctx_destroy (cctx); 1562 cctx_destroy (cctx);
1543 } 1563 }
1544 1564
1549cctx_put (coro_cctx *cctx) 1569cctx_put (coro_cctx *cctx)
1550{ 1570{
1551 assert (("FATAL: cctx_put called on non-initialised cctx in Coro (please report)", cctx->sptr)); 1571 assert (("FATAL: cctx_put called on non-initialised cctx in Coro (please report)", cctx->sptr));
1552 1572
1553 /* free another cctx if overlimit */ 1573 /* free another cctx if overlimit */
1554 if (expect_false (cctx_idle >= cctx_max_idle)) 1574 if (ecb_expect_false (cctx_idle >= cctx_max_idle))
1555 { 1575 {
1556 coro_cctx *first = cctx_first; 1576 coro_cctx *first = cctx_first;
1557 cctx_first = first->next; 1577 cctx_first = first->next;
1558 --cctx_idle; 1578 --cctx_idle;
1559 1579
1570static void 1590static void
1571transfer_check (pTHX_ struct coro *prev, struct coro *next) 1591transfer_check (pTHX_ struct coro *prev, struct coro *next)
1572{ 1592{
1573 /* TODO: throwing up here is considered harmful */ 1593 /* TODO: throwing up here is considered harmful */
1574 1594
1575 if (expect_true (prev != next)) 1595 if (ecb_expect_true (prev != next))
1576 { 1596 {
1577 if (expect_false (!(prev->flags & (CF_RUNNING | CF_NEW)))) 1597 if (ecb_expect_false (!(prev->flags & (CF_RUNNING | CF_NEW))))
1578 croak ("Coro::State::transfer called with a blocked prev Coro::State, but can only transfer from running or new states,"); 1598 croak ("Coro::State::transfer called with a blocked prev Coro::State, but can only transfer from running or new states,");
1579 1599
1580 if (expect_false (next->flags & (CF_RUNNING | CF_DESTROYED | CF_SUSPENDED))) 1600 if (ecb_expect_false (next->flags & (CF_RUNNING | CF_ZOMBIE | CF_SUSPENDED)))
1581 croak ("Coro::State::transfer called with running, destroyed or suspended next Coro::State, but can only transfer to inactive states,"); 1601 croak ("Coro::State::transfer called with running, destroyed or suspended next Coro::State, but can only transfer to inactive states,");
1582 1602
1583#if !PERL_VERSION_ATLEAST (5,10,0) 1603#if !PERL_VERSION_ATLEAST (5,10,0)
1584 if (expect_false (PL_lex_state != LEX_NOTPARSING)) 1604 if (ecb_expect_false (PL_lex_state != LEX_NOTPARSING))
1585 croak ("Coro::State::transfer called while parsing, but this is not supported in your perl version,"); 1605 croak ("Coro::State::transfer called while parsing, but this is not supported in your perl version,");
1586#endif 1606#endif
1587 } 1607 }
1588} 1608}
1589 1609
1590/* always use the TRANSFER macro */ 1610/* always use the TRANSFER macro */
1591static void NOINLINE /* noinline so we have a fixed stackframe */ 1611static void ecb_noinline /* noinline so we have a fixed stackframe */
1592transfer (pTHX_ struct coro *prev, struct coro *next, int force_cctx) 1612transfer (pTHX_ struct coro *prev, struct coro *next, int force_cctx)
1593{ 1613{
1594 dSTACKLEVEL; 1614 dSTACKLEVEL;
1595 1615
1596 /* sometimes transfer is only called to set idle_sp */ 1616 /* sometimes transfer is only called to set idle_sp */
1597 if (expect_false (!prev)) 1617 if (ecb_expect_false (!prev))
1598 { 1618 {
1599 cctx_current->idle_sp = STACKLEVEL; 1619 cctx_current->idle_sp = STACKLEVEL;
1600 assert (cctx_current->idle_te = PL_top_env); /* just for the side-effect when asserts are enabled */ 1620 assert (cctx_current->idle_te = PL_top_env); /* just for the side-effect when asserts are enabled */
1601 } 1621 }
1602 else if (expect_true (prev != next)) 1622 else if (ecb_expect_true (prev != next))
1603 { 1623 {
1604 coro_cctx *cctx_prev; 1624 coro_cctx *cctx_prev;
1605 1625
1606 if (expect_false (prev->flags & CF_NEW)) 1626 if (ecb_expect_false (prev->flags & CF_NEW))
1607 { 1627 {
1608 /* create a new empty/source context */ 1628 /* create a new empty/source context */
1609 prev->flags &= ~CF_NEW; 1629 prev->flags &= ~CF_NEW;
1610 prev->flags |= CF_RUNNING; 1630 prev->flags |= CF_RUNNING;
1611 } 1631 }
1614 next->flags |= CF_RUNNING; 1634 next->flags |= CF_RUNNING;
1615 1635
1616 /* first get rid of the old state */ 1636 /* first get rid of the old state */
1617 save_perl (aTHX_ prev); 1637 save_perl (aTHX_ prev);
1618 1638
1619 if (expect_false (next->flags & CF_NEW)) 1639 if (ecb_expect_false (next->flags & CF_NEW))
1620 { 1640 {
1621 /* need to start coroutine */ 1641 /* need to start coroutine */
1622 next->flags &= ~CF_NEW; 1642 next->flags &= ~CF_NEW;
1623 /* setup coroutine call */ 1643 /* setup coroutine call */
1624 init_perl (aTHX_ next); 1644 init_perl (aTHX_ next);
1625 } 1645 }
1626 else 1646 else
1627 load_perl (aTHX_ next); 1647 load_perl (aTHX_ next);
1628 1648
1629 /* possibly untie and reuse the cctx */ 1649 /* possibly untie and reuse the cctx */
1630 if (expect_true ( 1650 if (ecb_expect_true (
1631 cctx_current->idle_sp == STACKLEVEL 1651 cctx_current->idle_sp == STACKLEVEL
1632 && !(cctx_current->flags & CC_TRACE) 1652 && !(cctx_current->flags & CC_TRACE)
1633 && !force_cctx 1653 && !force_cctx
1634 )) 1654 ))
1635 { 1655 {
1636 /* I assume that stacklevel is a stronger indicator than PL_top_env changes */ 1656 /* I assume that stacklevel is a stronger indicator than PL_top_env changes */
1637 assert (("FATAL: current top_env must equal previous top_env in Coro (please report)", PL_top_env == cctx_current->idle_te)); 1657 assert (("FATAL: current top_env must equal previous top_env in Coro (please report)", PL_top_env == cctx_current->idle_te));
1638 1658
1639 /* if the cctx is about to be destroyed we need to make sure we won't see it in cctx_get. */ 1659 /* if the cctx is about to be destroyed we need to make sure we won't see it in cctx_get. */
1640 /* without this the next cctx_get might destroy the running cctx while still in use */ 1660 /* without this the next cctx_get might destroy the running cctx while still in use */
1641 if (expect_false (CCTX_EXPIRED (cctx_current))) 1661 if (ecb_expect_false (CCTX_EXPIRED (cctx_current)))
1642 if (expect_true (!next->cctx)) 1662 if (ecb_expect_true (!next->cctx))
1643 next->cctx = cctx_get (aTHX); 1663 next->cctx = cctx_get (aTHX);
1644 1664
1645 cctx_put (cctx_current); 1665 cctx_put (cctx_current);
1646 } 1666 }
1647 else 1667 else
1648 prev->cctx = cctx_current; 1668 prev->cctx = cctx_current;
1649 1669
1650 ++next->usecount; 1670 ++next->usecount;
1651 1671
1652 cctx_prev = cctx_current; 1672 cctx_prev = cctx_current;
1653 cctx_current = expect_false (next->cctx) ? next->cctx : cctx_get (aTHX); 1673 cctx_current = ecb_expect_false (next->cctx) ? next->cctx : cctx_get (aTHX);
1654 1674
1655 next->cctx = 0; 1675 next->cctx = 0;
1656 1676
1657 if (expect_false (cctx_prev != cctx_current)) 1677 if (ecb_expect_false (cctx_prev != cctx_current))
1658 { 1678 {
1659 cctx_prev->top_env = PL_top_env; 1679 cctx_prev->top_env = PL_top_env;
1660 PL_top_env = cctx_current->top_env; 1680 PL_top_env = cctx_current->top_env;
1661 coro_transfer (&cctx_prev->cctx, &cctx_current->cctx); 1681 coro_transfer (&cctx_prev->cctx, &cctx_current->cctx);
1662 } 1682 }
1668#define TRANSFER(ta, force_cctx) transfer (aTHX_ (ta).prev, (ta).next, (force_cctx)) 1688#define TRANSFER(ta, force_cctx) transfer (aTHX_ (ta).prev, (ta).next, (force_cctx))
1669#define TRANSFER_CHECK(ta) transfer_check (aTHX_ (ta).prev, (ta).next) 1689#define TRANSFER_CHECK(ta) transfer_check (aTHX_ (ta).prev, (ta).next)
1670 1690
1671/** high level stuff ********************************************************/ 1691/** high level stuff ********************************************************/
1672 1692
1693/* this function is actually Coro, not Coro::State, but we call it from here */
1694/* because it is convenient - but it hasn't been declared yet for that reason */
1695static void
1696coro_call_on_destroy (pTHX_ struct coro *coro);
1697
1673static void 1698static void
1674coro_state_destroy (pTHX_ struct coro *coro) 1699coro_state_destroy (pTHX_ struct coro *coro)
1675{ 1700{
1676 if (coro->flags & CF_DESTROYED) 1701 if (coro->flags & CF_ZOMBIE)
1677 return; 1702 return;
1678 1703
1679 /* this callback is reserved for slf functions needing to do cleanup */
1680 if (coro->on_destroy && !PL_dirty)
1681 coro->on_destroy (aTHX_ coro); 1704 slf_destroy (aTHX_ coro);
1682 1705
1683 /*
1684 * The on_destroy above most likely is from an SLF call.
1685 * Since by definition the SLF call will not finish when we destroy
1686 * the coro, we will have to force-finish it here, otherwise
1687 * cleanup functions cannot call SLF functions.
1688 */
1689 coro->slf_frame.prepare = 0;
1690
1691 coro->flags |= CF_DESTROYED; 1706 coro->flags |= CF_ZOMBIE;
1692 1707
1693 if (coro->flags & CF_READY) 1708 if (coro->flags & CF_READY)
1694 { 1709 {
1695 /* reduce nready, as destroying a ready coro effectively unreadies it */ 1710 /* reduce nready, as destroying a ready coro effectively unreadies it */
1696 /* alternative: look through all ready queues and remove the coro */ 1711 /* alternative: look through all ready queues and remove the coro */
1697 --coro_nready; 1712 --coro_nready;
1698 } 1713 }
1699 else 1714 else
1700 coro->flags |= CF_READY; /* make sure it is NOT put into the readyqueue */ 1715 coro->flags |= CF_READY; /* make sure it is NOT put into the readyqueue */
1716
1717 if (coro->next) coro->next->prev = coro->prev;
1718 if (coro->prev) coro->prev->next = coro->next;
1719 if (coro == coro_first) coro_first = coro->next;
1701 1720
1702 if (coro->mainstack 1721 if (coro->mainstack
1703 && coro->mainstack != main_mainstack 1722 && coro->mainstack != main_mainstack
1704 && coro->slot 1723 && coro->slot
1705 && !PL_dirty) 1724 && !PL_dirty)
1706 destroy_perl (aTHX_ coro); 1725 destroy_perl (aTHX_ coro);
1707 1726
1708 if (coro->next) coro->next->prev = coro->prev;
1709 if (coro->prev) coro->prev->next = coro->next;
1710 if (coro == coro_first) coro_first = coro->next;
1711
1712 cctx_destroy (coro->cctx); 1727 cctx_destroy (coro->cctx);
1713 SvREFCNT_dec (coro->startcv); 1728 SvREFCNT_dec (coro->startcv);
1714 SvREFCNT_dec (coro->args); 1729 SvREFCNT_dec (coro->args);
1715 SvREFCNT_dec (coro->swap_sv); 1730 SvREFCNT_dec (coro->swap_sv);
1716 SvREFCNT_dec (CORO_THROW); 1731 SvREFCNT_dec (CORO_THROW);
1732
1733 coro_call_on_destroy (aTHX_ coro);
1734
1735 /* more destruction mayhem in coro_state_free */
1717} 1736}
1718 1737
1719static int 1738static int
1720coro_state_free (pTHX_ SV *sv, MAGIC *mg) 1739coro_state_free (pTHX_ SV *sv, MAGIC *mg)
1721{ 1740{
1722 struct coro *coro = (struct coro *)mg->mg_ptr; 1741 struct coro *coro = (struct coro *)mg->mg_ptr;
1723 mg->mg_ptr = 0; 1742 mg->mg_ptr = 0;
1724 1743
1725 coro->hv = 0;
1726
1727 if (--coro->refcnt < 0)
1728 {
1729 coro_state_destroy (aTHX_ coro); 1744 coro_state_destroy (aTHX_ coro);
1745 SvREFCNT_dec (coro->on_destroy);
1746 SvREFCNT_dec (coro->status);
1747
1730 Safefree (coro); 1748 Safefree (coro);
1731 }
1732 1749
1733 return 0; 1750 return 0;
1734} 1751}
1735 1752
1736static int 1753static int ecb_cold
1737coro_state_dup (pTHX_ MAGIC *mg, CLONE_PARAMS *params) 1754coro_state_dup (pTHX_ MAGIC *mg, CLONE_PARAMS *params)
1738{ 1755{
1739 struct coro *coro = (struct coro *)mg->mg_ptr; 1756 /* called when perl clones the current process the slow way (windows process emulation) */
1740 1757 /* WE SIMply nuke the pointers in the copy, causing perl to croak */
1741 ++coro->refcnt; 1758 mg->mg_ptr = 0;
1759 mg->mg_virtual = 0;
1742 1760
1743 return 0; 1761 return 0;
1744} 1762}
1745 1763
1746static MGVTBL coro_state_vtbl = { 1764static MGVTBL coro_state_vtbl = {
1771 TRANSFER (ta, 1); 1789 TRANSFER (ta, 1);
1772} 1790}
1773 1791
1774/** Coro ********************************************************************/ 1792/** Coro ********************************************************************/
1775 1793
1776INLINE void 1794ECB_INLINE void
1777coro_enq (pTHX_ struct coro *coro) 1795coro_enq (pTHX_ struct coro *coro)
1778{ 1796{
1779 struct coro **ready = coro_ready [coro->prio - CORO_PRIO_MIN]; 1797 struct coro **ready = coro_ready [coro->prio - CORO_PRIO_MIN];
1780 1798
1781 SvREFCNT_inc_NN (coro->hv); 1799 SvREFCNT_inc_NN (coro->hv);
1783 coro->next_ready = 0; 1801 coro->next_ready = 0;
1784 *(ready [0] ? &ready [1]->next_ready : &ready [0]) = coro; 1802 *(ready [0] ? &ready [1]->next_ready : &ready [0]) = coro;
1785 ready [1] = coro; 1803 ready [1] = coro;
1786} 1804}
1787 1805
1788INLINE struct coro * 1806ECB_INLINE struct coro *
1789coro_deq (pTHX) 1807coro_deq (pTHX)
1790{ 1808{
1791 int prio; 1809 int prio;
1792 1810
1793 for (prio = CORO_PRIO_MAX - CORO_PRIO_MIN + 1; --prio >= 0; ) 1811 for (prio = CORO_PRIO_MAX - CORO_PRIO_MIN + 1; --prio >= 0; )
1846{ 1864{
1847 return !!(SvSTATE (coro_sv)->flags & CF_READY); 1865 return !!(SvSTATE (coro_sv)->flags & CF_READY);
1848} 1866}
1849 1867
1850/* expects to own a reference to next->hv */ 1868/* expects to own a reference to next->hv */
1851INLINE void 1869ECB_INLINE void
1852prepare_schedule_to (pTHX_ struct coro_transfer_args *ta, struct coro *next) 1870prepare_schedule_to (pTHX_ struct coro_transfer_args *ta, struct coro *next)
1853{ 1871{
1854 SV *prev_sv = SvRV (coro_current); 1872 SV *prev_sv = SvRV (coro_current);
1855 1873
1856 ta->prev = SvSTATE_hv (prev_sv); 1874 ta->prev = SvSTATE_hv (prev_sv);
1869{ 1887{
1870 for (;;) 1888 for (;;)
1871 { 1889 {
1872 struct coro *next = coro_deq (aTHX); 1890 struct coro *next = coro_deq (aTHX);
1873 1891
1874 if (expect_true (next)) 1892 if (ecb_expect_true (next))
1875 { 1893 {
1876 /* cannot transfer to destroyed coros, skip and look for next */ 1894 /* cannot transfer to destroyed coros, skip and look for next */
1877 if (expect_false (next->flags & (CF_DESTROYED | CF_SUSPENDED))) 1895 if (ecb_expect_false (next->flags & (CF_ZOMBIE | CF_SUSPENDED)))
1878 SvREFCNT_dec (next->hv); /* coro_nready has already been taken care of by destroy */ 1896 SvREFCNT_dec (next->hv); /* coro_nready has already been taken care of by destroy */
1879 else 1897 else
1880 { 1898 {
1881 next->flags &= ~CF_READY; 1899 next->flags &= ~CF_READY;
1882 --coro_nready; 1900 --coro_nready;
1915 } 1933 }
1916 } 1934 }
1917 } 1935 }
1918} 1936}
1919 1937
1920INLINE void 1938ECB_INLINE void
1921prepare_cede (pTHX_ struct coro_transfer_args *ta) 1939prepare_cede (pTHX_ struct coro_transfer_args *ta)
1922{ 1940{
1923 api_ready (aTHX_ coro_current); 1941 api_ready (aTHX_ coro_current);
1924 prepare_schedule (aTHX_ ta); 1942 prepare_schedule (aTHX_ ta);
1925} 1943}
1926 1944
1927INLINE void 1945ECB_INLINE void
1928prepare_cede_notself (pTHX_ struct coro_transfer_args *ta) 1946prepare_cede_notself (pTHX_ struct coro_transfer_args *ta)
1929{ 1947{
1930 SV *prev = SvRV (coro_current); 1948 SV *prev = SvRV (coro_current);
1931 1949
1932 if (coro_nready) 1950 if (coro_nready)
1962{ 1980{
1963 struct coro_transfer_args ta; 1981 struct coro_transfer_args ta;
1964 1982
1965 prepare_cede (aTHX_ &ta); 1983 prepare_cede (aTHX_ &ta);
1966 1984
1967 if (expect_true (ta.prev != ta.next)) 1985 if (ecb_expect_true (ta.prev != ta.next))
1968 { 1986 {
1969 TRANSFER (ta, 1); 1987 TRANSFER (ta, 1);
1970 return 1; 1988 return 1;
1971 } 1989 }
1972 else 1990 else
2015 coro->slot->runops = RUNOPS_DEFAULT; 2033 coro->slot->runops = RUNOPS_DEFAULT;
2016 } 2034 }
2017} 2035}
2018 2036
2019static void 2037static void
2038coro_push_av (pTHX_ AV *av, I32 gimme_v)
2039{
2040 if (AvFILLp (av) >= 0 && gimme_v != G_VOID)
2041 {
2042 dSP;
2043
2044 if (gimme_v == G_SCALAR)
2045 XPUSHs (AvARRAY (av)[AvFILLp (av)]);
2046 else
2047 {
2048 int i;
2049 EXTEND (SP, AvFILLp (av) + 1);
2050
2051 for (i = 0; i <= AvFILLp (av); ++i)
2052 PUSHs (AvARRAY (av)[i]);
2053 }
2054
2055 PUTBACK;
2056 }
2057}
2058
2059static void
2060coro_push_on_destroy (pTHX_ struct coro *coro, SV *cb)
2061{
2062 if (!coro->on_destroy)
2063 coro->on_destroy = newAV ();
2064
2065 av_push (coro->on_destroy, cb);
2066}
2067
2068static void
2069slf_destroy_join (pTHX_ struct CoroSLF *frame)
2070{
2071 SvREFCNT_dec ((SV *)((struct coro *)frame->data)->hv);
2072}
2073
2074static int
2075slf_check_join (pTHX_ struct CoroSLF *frame)
2076{
2077 struct coro *coro = (struct coro *)frame->data;
2078
2079 if (!coro->status)
2080 return 1;
2081
2082 frame->destroy = 0;
2083
2084 coro_push_av (aTHX_ coro->status, GIMME_V);
2085
2086 SvREFCNT_dec ((SV *)coro->hv);
2087
2088 return 0;
2089}
2090
2091static void
2092slf_init_join (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2093{
2094 struct coro *coro = SvSTATE (items > 0 ? arg [0] : &PL_sv_undef);
2095
2096 if (items > 1)
2097 croak ("join called with too many arguments");
2098
2099 if (coro->status)
2100 frame->prepare = prepare_nop;
2101 else
2102 {
2103 coro_push_on_destroy (aTHX_ coro, SvREFCNT_inc_NN (SvRV (coro_current)));
2104 frame->prepare = prepare_schedule;
2105 }
2106
2107 frame->check = slf_check_join;
2108 frame->destroy = slf_destroy_join;
2109 frame->data = (void *)coro;
2110 SvREFCNT_inc (coro->hv);
2111}
2112
2113static void
2020coro_call_on_destroy (pTHX_ struct coro *coro) 2114coro_call_on_destroy (pTHX_ struct coro *coro)
2021{ 2115{
2022 SV **on_destroyp = hv_fetch (coro->hv, "_on_destroy", sizeof ("_on_destroy") - 1, 0); 2116 AV *od = coro->on_destroy;
2023 2117
2024 if (on_destroyp) 2118 if (!od)
2025 { 2119 return;
2026 SV **statusp = hv_fetch (coro->hv, "_status", sizeof ("_status") - 1, 0);
2027 AV *on_destroy = sv_2mortal (SvREFCNT_inc ((AV *)SvRV (*on_destroyp)));
2028 AV *status = statusp ? sv_2mortal (SvREFCNT_inc ((AV *)SvRV (*statusp))) : 0;
2029 2120
2030 while (AvFILLp (on_destroy) >= 0) 2121 while (AvFILLp (od) >= 0)
2122 {
2123 SV *cb = sv_2mortal (av_pop (od));
2124
2125 /* coro hv's (and only hv's at the moment) are supported as well */
2126 if (SvSTATEhv_p (aTHX_ cb))
2127 api_ready (aTHX_ cb);
2128 else
2031 { 2129 {
2032 dSP; /* don't disturb outer sp */ 2130 dSP; /* don't disturb outer sp */
2033 SV *cb = av_pop (on_destroy);
2034
2035 PUSHMARK (SP); 2131 PUSHMARK (SP);
2036 2132
2037 if (statusp) 2133 if (coro->status)
2038 { 2134 {
2039 int i; 2135 PUTBACK;
2040 EXTEND (SP, AvFILLp (status) + 1); 2136 coro_push_av (aTHX_ coro->status, G_ARRAY);
2041 2137 SPAGAIN;
2042 for (i = 0; i <= AvFILLp (status); ++i)
2043 PUSHs (AvARRAY (status)[i]);
2044 } 2138 }
2045 2139
2046 PUTBACK; 2140 PUTBACK;
2047 call_sv (sv_2mortal (cb), G_VOID | G_DISCARD); 2141 call_sv (cb, G_VOID | G_DISCARD);
2048 } 2142 }
2049 } 2143 }
2050} 2144}
2051 2145
2052static void 2146static void
2053coro_set_status (HV *coro_hv, SV **arg, int items) 2147coro_set_status (pTHX_ struct coro *coro, SV **arg, int items)
2054{ 2148{
2055 AV *av = newAV (); 2149 AV *av;
2150
2151 if (coro->status)
2152 {
2153 av = coro->status;
2154 av_clear (av);
2155 }
2156 else
2157 av = coro->status = newAV ();
2056 2158
2057 /* items are actually not so common, so optimise for this case */ 2159 /* items are actually not so common, so optimise for this case */
2058 if (items) 2160 if (items)
2059 { 2161 {
2060 int i; 2162 int i;
2062 av_extend (av, items - 1); 2164 av_extend (av, items - 1);
2063 2165
2064 for (i = 0; i < items; ++i) 2166 for (i = 0; i < items; ++i)
2065 av_push (av, SvREFCNT_inc_NN (arg [i])); 2167 av_push (av, SvREFCNT_inc_NN (arg [i]));
2066 } 2168 }
2067
2068 hv_store (coro_hv, "_status", sizeof ("_status") - 1, newRV_noinc ((SV *)av), 0);
2069} 2169}
2070 2170
2071static void 2171static void
2072slf_init_terminate_cancel_common (pTHX_ struct CoroSLF *frame, HV *coro_hv) 2172slf_init_terminate_cancel_common (pTHX_ struct CoroSLF *frame, HV *coro_hv)
2073{ 2173{
2085static void 2185static void
2086slf_init_terminate (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2186slf_init_terminate (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2087{ 2187{
2088 HV *coro_hv = (HV *)SvRV (coro_current); 2188 HV *coro_hv = (HV *)SvRV (coro_current);
2089 2189
2090 coro_set_status (coro_hv, arg, items); 2190 coro_set_status (aTHX_ SvSTATE ((SV *)coro_hv), arg, items);
2091 slf_init_terminate_cancel_common (frame, coro_hv); 2191 slf_init_terminate_cancel_common (aTHX_ frame, coro_hv);
2092} 2192}
2093 2193
2094static void 2194static void
2095slf_init_cancel (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2195slf_init_cancel (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2096{ 2196{
2101 croak ("Coro::cancel called without coro object,"); 2201 croak ("Coro::cancel called without coro object,");
2102 2202
2103 coro = SvSTATE (arg [0]); 2203 coro = SvSTATE (arg [0]);
2104 coro_hv = coro->hv; 2204 coro_hv = coro->hv;
2105 2205
2106 coro_set_status (coro_hv, arg + 1, items - 1); 2206 coro_set_status (aTHX_ coro, arg + 1, items - 1);
2107 2207
2108 if (expect_false (coro->flags & CF_NOCANCEL)) 2208 if (ecb_expect_false (coro->flags & CF_NOCANCEL))
2109 { 2209 {
2110 /* coro currently busy cancelling something, so just notify it */ 2210 /* coro currently busy cancelling something, so just notify it */
2111 coro->slf_frame.data = (void *)coro; 2211 coro->slf_frame.data = (void *)coro;
2112 2212
2113 frame->prepare = prepare_nop; 2213 frame->prepare = prepare_nop;
2114 frame->check = slf_check_nop; 2214 frame->check = slf_check_nop;
2115 } 2215 }
2116 else if (coro_hv == (HV *)SvRV (coro_current)) 2216 else if (coro_hv == (HV *)SvRV (coro_current))
2117 { 2217 {
2118 /* cancelling the current coro is allowed, and equals terminate */ 2218 /* cancelling the current coro is allowed, and equals terminate */
2119 slf_init_terminate_cancel_common (frame, coro_hv); 2219 slf_init_terminate_cancel_common (aTHX_ frame, coro_hv);
2120 } 2220 }
2121 else 2221 else
2122 { 2222 {
2123 struct coro *self = SvSTATE_current; 2223 struct coro *self = SvSTATE_current;
2124 2224
2128 * this is ugly, and hopefully fully worth the extra speed. 2228 * this is ugly, and hopefully fully worth the extra speed.
2129 * besides, I can't get the slow-but-safe version working... 2229 * besides, I can't get the slow-but-safe version working...
2130 */ 2230 */
2131 slf_frame.data = 0; 2231 slf_frame.data = 0;
2132 self->flags |= CF_NOCANCEL; 2232 self->flags |= CF_NOCANCEL;
2133
2134 coro_state_destroy (aTHX_ coro); 2233 coro_state_destroy (aTHX_ coro);
2135 coro_call_on_destroy (aTHX_ coro);
2136
2137 self->flags &= ~CF_NOCANCEL; 2234 self->flags &= ~CF_NOCANCEL;
2138 2235
2139 if (slf_frame.data) 2236 if (slf_frame.data)
2140 { 2237 {
2141 /* while we were busy we have been cancelled, so terminate */ 2238 /* while we were busy we have been cancelled, so terminate */
2142 slf_init_terminate_cancel_common (frame, self->hv); 2239 slf_init_terminate_cancel_common (aTHX_ frame, self->hv);
2143 } 2240 }
2144 else 2241 else
2145 { 2242 {
2146 frame->prepare = prepare_nop; 2243 frame->prepare = prepare_nop;
2147 frame->check = slf_check_nop; 2244 frame->check = slf_check_nop;
2148 } 2245 }
2149 } 2246 }
2150} 2247}
2151 2248
2249static int
2250slf_check_safe_cancel (pTHX_ struct CoroSLF *frame)
2251{
2252 frame->prepare = 0;
2253 coro_unwind_stacks (aTHX);
2254
2255 slf_init_terminate_cancel_common (aTHX_ frame, (HV *)SvRV (coro_current));
2256
2257 return 1;
2258}
2259
2260static int
2261safe_cancel (pTHX_ struct coro *coro, SV **arg, int items)
2262{
2263 if (coro->cctx)
2264 croak ("coro inside C callback, unable to cancel at this time, caught");
2265
2266 if (coro->flags & CF_NEW)
2267 {
2268 coro_set_status (aTHX_ coro, arg, items);
2269 coro_state_destroy (aTHX_ coro);
2270 }
2271 else
2272 {
2273 if (!coro->slf_frame.prepare)
2274 croak ("coro outside an SLF function, unable to cancel at this time, caught");
2275
2276 slf_destroy (aTHX_ coro);
2277
2278 coro_set_status (aTHX_ coro, arg, items);
2279 coro->slf_frame.prepare = prepare_nop;
2280 coro->slf_frame.check = slf_check_safe_cancel;
2281
2282 api_ready (aTHX_ (SV *)coro->hv);
2283 }
2284
2285 return 1;
2286}
2287
2152/*****************************************************************************/ 2288/*****************************************************************************/
2153/* async pool handler */ 2289/* async pool handler */
2154 2290
2155static int 2291static int
2156slf_check_pool_handler (pTHX_ struct CoroSLF *frame) 2292slf_check_pool_handler (pTHX_ struct CoroSLF *frame)
2185slf_init_pool_handler (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2321slf_init_pool_handler (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2186{ 2322{
2187 HV *hv = (HV *)SvRV (coro_current); 2323 HV *hv = (HV *)SvRV (coro_current);
2188 struct coro *coro = SvSTATE_hv ((SV *)hv); 2324 struct coro *coro = SvSTATE_hv ((SV *)hv);
2189 2325
2190 if (expect_true (coro->saved_deffh)) 2326 if (ecb_expect_true (coro->saved_deffh))
2191 { 2327 {
2192 /* subsequent iteration */ 2328 /* subsequent iteration */
2193 SvREFCNT_dec ((SV *)PL_defoutgv); PL_defoutgv = (GV *)coro->saved_deffh; 2329 SvREFCNT_dec ((SV *)PL_defoutgv); PL_defoutgv = (GV *)coro->saved_deffh;
2194 coro->saved_deffh = 0; 2330 coro->saved_deffh = 0;
2195 2331
2196 if (coro_rss (aTHX_ coro) > SvUV (sv_pool_rss) 2332 if (coro_rss (aTHX_ coro) > SvUV (sv_pool_rss)
2197 || av_len (av_async_pool) + 1 >= SvIV (sv_pool_size)) 2333 || av_len (av_async_pool) + 1 >= SvIV (sv_pool_size))
2198 { 2334 {
2199 coro->invoke_cb = SvREFCNT_inc_NN ((SV *)cv_coro_terminate); 2335 slf_init_terminate_cancel_common (aTHX_ frame, hv);
2200 coro->invoke_av = newAV (); 2336 return;
2201
2202 frame->prepare = prepare_nop;
2203 } 2337 }
2204 else 2338 else
2205 { 2339 {
2206 av_clear (GvAV (PL_defgv)); 2340 av_clear (GvAV (PL_defgv));
2207 hv_store (hv, "desc", sizeof ("desc") - 1, SvREFCNT_inc_NN (sv_async_pool_idle), 0); 2341 hv_store (hv, "desc", sizeof ("desc") - 1, SvREFCNT_inc_NN (sv_async_pool_idle), 0);
2430static void 2564static void
2431slf_init_cede_notself (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2565slf_init_cede_notself (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2432{ 2566{
2433 frame->prepare = prepare_cede_notself; 2567 frame->prepare = prepare_cede_notself;
2434 frame->check = slf_check_nop; 2568 frame->check = slf_check_nop;
2569}
2570
2571/* "undo"/cancel a running slf call - used when cancelling a coro, mainly */
2572static void
2573slf_destroy (pTHX_ struct coro *coro)
2574{
2575 /* this callback is reserved for slf functions needing to do cleanup */
2576 if (coro->slf_frame.destroy && coro->slf_frame.prepare && !PL_dirty)
2577 coro->slf_frame.destroy (aTHX_ &coro->slf_frame);
2578
2579 /*
2580 * The on_destroy above most likely is from an SLF call.
2581 * Since by definition the SLF call will not finish when we destroy
2582 * the coro, we will have to force-finish it here, otherwise
2583 * cleanup functions cannot call SLF functions.
2584 */
2585 coro->slf_frame.prepare = 0;
2435} 2586}
2436 2587
2437/* 2588/*
2438 * these not obviously related functions are all rolled into one 2589 * these not obviously related functions are all rolled into one
2439 * function to increase chances that they all will call transfer with the same 2590 * function to increase chances that they all will call transfer with the same
2446 I32 checkmark; /* mark SP to see how many elements check has pushed */ 2597 I32 checkmark; /* mark SP to see how many elements check has pushed */
2447 2598
2448 /* set up the slf frame, unless it has already been set-up */ 2599 /* set up the slf frame, unless it has already been set-up */
2449 /* the latter happens when a new coro has been started */ 2600 /* the latter happens when a new coro has been started */
2450 /* or when a new cctx was attached to an existing coroutine */ 2601 /* or when a new cctx was attached to an existing coroutine */
2451 if (expect_true (!slf_frame.prepare)) 2602 if (ecb_expect_true (!slf_frame.prepare))
2452 { 2603 {
2453 /* first iteration */ 2604 /* first iteration */
2454 dSP; 2605 dSP;
2455 SV **arg = PL_stack_base + TOPMARK + 1; 2606 SV **arg = PL_stack_base + TOPMARK + 1;
2456 int items = SP - arg; /* args without function object */ 2607 int items = SP - arg; /* args without function object */
2497 while (slf_frame.check (aTHX_ &slf_frame)); 2648 while (slf_frame.check (aTHX_ &slf_frame));
2498 2649
2499 slf_frame.prepare = 0; /* invalidate the frame, we are done processing it */ 2650 slf_frame.prepare = 0; /* invalidate the frame, we are done processing it */
2500 2651
2501 /* exception handling */ 2652 /* exception handling */
2502 if (expect_false (CORO_THROW)) 2653 if (ecb_expect_false (CORO_THROW))
2503 { 2654 {
2504 SV *exception = sv_2mortal (CORO_THROW); 2655 SV *exception = sv_2mortal (CORO_THROW);
2505 2656
2506 CORO_THROW = 0; 2657 CORO_THROW = 0;
2507 sv_setsv (ERRSV, exception); 2658 sv_setsv (ERRSV, exception);
2508 croak (0); 2659 croak (0);
2509 } 2660 }
2510 2661
2511 /* return value handling - mostly like entersub */ 2662 /* return value handling - mostly like entersub */
2512 /* make sure we put something on the stack in scalar context */ 2663 /* make sure we put something on the stack in scalar context */
2513 if (GIMME_V == G_SCALAR) 2664 if (GIMME_V == G_SCALAR
2665 && ecb_expect_false (PL_stack_sp != PL_stack_base + checkmark + 1))
2514 { 2666 {
2515 dSP; 2667 dSP;
2516 SV **bot = PL_stack_base + checkmark; 2668 SV **bot = PL_stack_base + checkmark;
2517 2669
2518 if (sp == bot) /* too few, push undef */ 2670 if (sp == bot) /* too few, push undef */
2519 bot [1] = &PL_sv_undef; 2671 bot [1] = &PL_sv_undef;
2520 else if (sp != bot + 1) /* too many, take last one */ 2672 else /* too many, take last one */
2521 bot [1] = *sp; 2673 bot [1] = *sp;
2522 2674
2523 SP = bot + 1; 2675 SP = bot + 1;
2524 2676
2525 PUTBACK; 2677 PUTBACK;
2632{ 2784{
2633 PerlIOBuf base; 2785 PerlIOBuf base;
2634 NV next, every; 2786 NV next, every;
2635} PerlIOCede; 2787} PerlIOCede;
2636 2788
2637static IV 2789static IV ecb_cold
2638PerlIOCede_pushed (pTHX_ PerlIO *f, const char *mode, SV *arg, PerlIO_funcs *tab) 2790PerlIOCede_pushed (pTHX_ PerlIO *f, const char *mode, SV *arg, PerlIO_funcs *tab)
2639{ 2791{
2640 PerlIOCede *self = PerlIOSelf (f, PerlIOCede); 2792 PerlIOCede *self = PerlIOSelf (f, PerlIOCede);
2641 2793
2642 self->every = SvCUR (arg) ? SvNV (arg) : 0.01; 2794 self->every = SvCUR (arg) ? SvNV (arg) : 0.01;
2643 self->next = nvtime () + self->every; 2795 self->next = nvtime () + self->every;
2644 2796
2645 return PerlIOBuf_pushed (aTHX_ f, mode, Nullsv, tab); 2797 return PerlIOBuf_pushed (aTHX_ f, mode, Nullsv, tab);
2646} 2798}
2647 2799
2648static SV * 2800static SV * ecb_cold
2649PerlIOCede_getarg (pTHX_ PerlIO *f, CLONE_PARAMS *param, int flags) 2801PerlIOCede_getarg (pTHX_ PerlIO *f, CLONE_PARAMS *param, int flags)
2650{ 2802{
2651 PerlIOCede *self = PerlIOSelf (f, PerlIOCede); 2803 PerlIOCede *self = PerlIOSelf (f, PerlIOCede);
2652 2804
2653 return newSVnv (self->every); 2805 return newSVnv (self->every);
2765 SvREFCNT_dec (cb); 2917 SvREFCNT_dec (cb);
2766 } 2918 }
2767} 2919}
2768 2920
2769static void 2921static void
2770coro_semaphore_on_destroy (pTHX_ struct coro *coro) 2922coro_semaphore_destroy (pTHX_ struct CoroSLF *frame)
2771{ 2923{
2772 /* call $sem->adjust (0) to possibly wake up some other waiters */ 2924 /* call $sem->adjust (0) to possibly wake up some other waiters */
2773 coro_semaphore_adjust (aTHX_ (AV *)coro->slf_frame.data, 0); 2925 coro_semaphore_adjust (aTHX_ (AV *)frame->data, 0);
2774} 2926}
2775 2927
2776static int 2928static int
2777slf_check_semaphore_down_or_wait (pTHX_ struct CoroSLF *frame, int acquire) 2929slf_check_semaphore_down_or_wait (pTHX_ struct CoroSLF *frame, int acquire)
2778{ 2930{
2779 AV *av = (AV *)frame->data; 2931 AV *av = (AV *)frame->data;
2780 SV *count_sv = AvARRAY (av)[0]; 2932 SV *count_sv = AvARRAY (av)[0];
2933 SV *coro_hv = SvRV (coro_current);
2781 2934
2782 /* if we are about to throw, don't actually acquire the lock, just throw */ 2935 /* if we are about to throw, don't actually acquire the lock, just throw */
2783 if (CORO_THROW) 2936 if (CORO_THROW)
2784 return 0; 2937 return 0;
2785 else if (SvIVX (count_sv) > 0) 2938 else if (SvIVX (count_sv) > 0)
2786 { 2939 {
2787 SvSTATE_current->on_destroy = 0; 2940 frame->destroy = 0;
2788 2941
2789 if (acquire) 2942 if (acquire)
2790 SvIVX (count_sv) = SvIVX (count_sv) - 1; 2943 SvIVX (count_sv) = SvIVX (count_sv) - 1;
2791 else 2944 else
2792 coro_semaphore_adjust (aTHX_ av, 0); 2945 coro_semaphore_adjust (aTHX_ av, 0);
2797 { 2950 {
2798 int i; 2951 int i;
2799 /* if we were woken up but can't down, we look through the whole */ 2952 /* if we were woken up but can't down, we look through the whole */
2800 /* waiters list and only add us if we aren't in there already */ 2953 /* waiters list and only add us if we aren't in there already */
2801 /* this avoids some degenerate memory usage cases */ 2954 /* this avoids some degenerate memory usage cases */
2802 2955 for (i = AvFILLp (av); i > 0; --i) // i > 0 is not an off-by-one bug
2803 for (i = 1; i <= AvFILLp (av); ++i)
2804 if (AvARRAY (av)[i] == SvRV (coro_current)) 2956 if (AvARRAY (av)[i] == coro_hv)
2805 return 1; 2957 return 1;
2806 2958
2807 av_push (av, SvREFCNT_inc (SvRV (coro_current))); 2959 av_push (av, SvREFCNT_inc (coro_hv));
2808 return 1; 2960 return 1;
2809 } 2961 }
2810} 2962}
2811 2963
2812static int 2964static int
2835 { 2987 {
2836 av_push (av, SvREFCNT_inc (SvRV (coro_current))); 2988 av_push (av, SvREFCNT_inc (SvRV (coro_current)));
2837 2989
2838 frame->data = (void *)sv_2mortal (SvREFCNT_inc ((SV *)av)); 2990 frame->data = (void *)sv_2mortal (SvREFCNT_inc ((SV *)av));
2839 frame->prepare = prepare_schedule; 2991 frame->prepare = prepare_schedule;
2840
2841 /* to avoid race conditions when a woken-up coro gets terminated */ 2992 /* to avoid race conditions when a woken-up coro gets terminated */
2842 /* we arrange for a temporary on_destroy that calls adjust (0) */ 2993 /* we arrange for a temporary on_destroy that calls adjust (0) */
2843 SvSTATE_current->on_destroy = coro_semaphore_on_destroy; 2994 frame->destroy = coro_semaphore_destroy;
2844 } 2995 }
2845} 2996}
2846 2997
2847static void 2998static void
2848slf_init_semaphore_down (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2999slf_init_semaphore_down (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
3066 dSP; 3217 dSP;
3067 3218
3068 static SV *prio_cv; 3219 static SV *prio_cv;
3069 static SV *prio_sv; 3220 static SV *prio_sv;
3070 3221
3071 if (expect_false (!prio_cv)) 3222 if (ecb_expect_false (!prio_cv))
3072 { 3223 {
3073 prio_cv = (SV *)get_cv ("IO::AIO::aioreq_pri", 0); 3224 prio_cv = (SV *)get_cv ("IO::AIO::aioreq_pri", 0);
3074 prio_sv = newSViv (0); 3225 prio_sv = newSViv (0);
3075 } 3226 }
3076 3227
3182 } 3333 }
3183 3334
3184 return coro_sv; 3335 return coro_sv;
3185} 3336}
3186 3337
3338#ifndef __cplusplus
3339ecb_cold XS(boot_Coro__State);
3340#endif
3341
3342#if CORO_JIT
3343
3344static void ecb_noinline ecb_cold
3345pushav_3uv (pTHX_ UV a, UV b, UV c)
3346{
3347 dSP;
3348 AV *av = newAV ();
3349
3350 av_store (av, 2, newSVuv (c));
3351 av_store (av, 1, newSVuv (b));
3352 av_store (av, 0, newSVuv (a));
3353
3354 XPUSHs (sv_2mortal (newRV_noinc ((SV *)av)));
3355
3356 PUTBACK;
3357}
3358
3359static void ecb_noinline ecb_cold
3360jit_init (pTHX)
3361{
3362 dSP;
3363 SV *load, *save;
3364 char *map_base;
3365 char *load_ptr, *save_ptr;
3366 STRLEN load_len, save_len;
3367 int count;
3368
3369 PUSHMARK (SP);
3370 PUTBACK;
3371#define VARx(name,expr,type) pushav_3uv (aTHX_ (UV)&(expr), offsetof (perl_slots, name), sizeof (type));
3372# include "state.h"
3373#undef VARx
3374 count = call_pv ("Coro::State::_jit", G_ARRAY);
3375 SPAGAIN;
3376
3377 save = POPs; save_ptr = SvPVbyte (save, save_len);
3378 load = POPs; load_ptr = SvPVbyte (load, load_len);
3379
3380 map_base = mmap (0, load_len + save_len + 16, PROT_EXEC | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
3381
3382 assert (("Coro: unable mmap jit code page, cannot continue.", map_base != (char *)MAP_FAILED));
3383
3384 load_perl_slots = (load_save_perl_slots_type)map_base;
3385 memcpy (map_base, load_ptr, load_len);
3386
3387 map_base += (load_len + 15) & ~15;
3388
3389 save_perl_slots = (load_save_perl_slots_type)map_base;
3390 memcpy (map_base, save_ptr, save_len);
3391}
3392
3393#endif
3394
3187MODULE = Coro::State PACKAGE = Coro::State PREFIX = api_ 3395MODULE = Coro::State PACKAGE = Coro::State PREFIX = api_
3188 3396
3189PROTOTYPES: DISABLE 3397PROTOTYPES: DISABLE
3190 3398
3191BOOT: 3399BOOT:
3195 coro_thx = PERL_GET_CONTEXT; 3403 coro_thx = PERL_GET_CONTEXT;
3196# endif 3404# endif
3197#endif 3405#endif
3198 BOOT_PAGESIZE; 3406 BOOT_PAGESIZE;
3199 3407
3408 /* perl defines these to check for existance first, but why it doesn't */
3409 /* just create them one at init time is not clear to me, except for */
3410 /* programs trying to delete them, but... */
3411 /* anyway, we declare this as invalid and make sure they are initialised here */
3412 DEFSV;
3413 ERRSV;
3414
3200 cctx_current = cctx_new_empty (); 3415 cctx_current = cctx_new_empty ();
3201 3416
3202 irsgv = gv_fetchpv ("/" , GV_ADD|GV_NOTQUAL, SVt_PV); 3417 irsgv = gv_fetchpv ("/" , GV_ADD|GV_NOTQUAL, SVt_PV);
3203 stdoutgv = gv_fetchpv ("STDOUT", GV_ADD|GV_NOTQUAL, SVt_PVIO); 3418 stdoutgv = gv_fetchpv ("STDOUT", GV_ADD|GV_NOTQUAL, SVt_PVIO);
3204 3419
3246 coroapi.prepare_cede_notself = prepare_cede_notself; 3461 coroapi.prepare_cede_notself = prepare_cede_notself;
3247 3462
3248 time_init (aTHX); 3463 time_init (aTHX);
3249 3464
3250 assert (("PRIO_NORMAL must be 0", !CORO_PRIO_NORMAL)); 3465 assert (("PRIO_NORMAL must be 0", !CORO_PRIO_NORMAL));
3466#if CORO_JIT
3467 PUTBACK;
3468 eval_pv ("require 'Coro/jit-" CORO_JIT_TYPE ".pl'", 1);
3469 jit_init (aTHX);
3470 perl_eval_pv ("undef &Coro::State::_jit", 1);
3471 SPAGAIN;
3472#endif
3251} 3473}
3252 3474
3253SV * 3475SV *
3254new (SV *klass, ...) 3476new (SV *klass, ...)
3255 ALIAS: 3477 ALIAS:
3397 PROTOTYPE: $ 3619 PROTOTYPE: $
3398 ALIAS: 3620 ALIAS:
3399 is_ready = CF_READY 3621 is_ready = CF_READY
3400 is_running = CF_RUNNING 3622 is_running = CF_RUNNING
3401 is_new = CF_NEW 3623 is_new = CF_NEW
3402 is_destroyed = CF_DESTROYED 3624 is_destroyed = CF_ZOMBIE
3625 is_zombie = CF_ZOMBIE
3403 is_suspended = CF_SUSPENDED 3626 is_suspended = CF_SUSPENDED
3404 CODE: 3627 CODE:
3405 RETVAL = boolSV (coro->flags & ix); 3628 RETVAL = boolSV (coro->flags & ix);
3406 OUTPUT: 3629 OUTPUT:
3407 RETVAL 3630 RETVAL
3502times (Coro::State self) 3725times (Coro::State self)
3503 PPCODE: 3726 PPCODE:
3504{ 3727{
3505 struct coro *current = SvSTATE (coro_current); 3728 struct coro *current = SvSTATE (coro_current);
3506 3729
3507 if (expect_false (current == self)) 3730 if (ecb_expect_false (current == self))
3508 { 3731 {
3509 coro_times_update (); 3732 coro_times_update ();
3510 coro_times_add (SvSTATE (coro_current)); 3733 coro_times_add (SvSTATE (coro_current));
3511 } 3734 }
3512 3735
3513 EXTEND (SP, 2); 3736 EXTEND (SP, 2);
3514 PUSHs (sv_2mortal (newSVnv (self->t_real [0] + self->t_real [1] * 1e-9))); 3737 PUSHs (sv_2mortal (newSVnv (self->t_real [0] + self->t_real [1] * 1e-9)));
3515 PUSHs (sv_2mortal (newSVnv (self->t_cpu [0] + self->t_cpu [1] * 1e-9))); 3738 PUSHs (sv_2mortal (newSVnv (self->t_cpu [0] + self->t_cpu [1] * 1e-9)));
3516 3739
3517 if (expect_false (current == self)) 3740 if (ecb_expect_false (current == self))
3518 coro_times_sub (SvSTATE (coro_current)); 3741 coro_times_sub (SvSTATE (coro_current));
3519} 3742}
3520 3743
3521void 3744void
3522swap_sv (Coro::State coro, SV *sv, SV *swapsv) 3745swap_sv (Coro::State coro, SV *sv, SV *swapsv)
3543BOOT: 3766BOOT:
3544{ 3767{
3545 sv_pool_rss = coro_get_sv (aTHX_ "Coro::POOL_RSS" , TRUE); 3768 sv_pool_rss = coro_get_sv (aTHX_ "Coro::POOL_RSS" , TRUE);
3546 sv_pool_size = coro_get_sv (aTHX_ "Coro::POOL_SIZE" , TRUE); 3769 sv_pool_size = coro_get_sv (aTHX_ "Coro::POOL_SIZE" , TRUE);
3547 cv_coro_run = get_cv ( "Coro::_coro_run" , GV_ADD); 3770 cv_coro_run = get_cv ( "Coro::_coro_run" , GV_ADD);
3548 cv_coro_terminate = get_cv ( "Coro::terminate" , GV_ADD);
3549 coro_current = coro_get_sv (aTHX_ "Coro::current" , FALSE); SvREADONLY_on (coro_current); 3771 coro_current = coro_get_sv (aTHX_ "Coro::current" , FALSE); SvREADONLY_on (coro_current);
3550 av_async_pool = coro_get_av (aTHX_ "Coro::async_pool", TRUE); 3772 av_async_pool = coro_get_av (aTHX_ "Coro::async_pool", TRUE);
3551 av_destroy = coro_get_av (aTHX_ "Coro::destroy" , TRUE); 3773 av_destroy = coro_get_av (aTHX_ "Coro::destroy" , TRUE);
3552 sv_manager = coro_get_sv (aTHX_ "Coro::manager" , TRUE); 3774 sv_manager = coro_get_sv (aTHX_ "Coro::manager" , TRUE);
3553 sv_idle = coro_get_sv (aTHX_ "Coro::idle" , TRUE); 3775 sv_idle = coro_get_sv (aTHX_ "Coro::idle" , TRUE);
3596void 3818void
3597_destroy (Coro::State coro) 3819_destroy (Coro::State coro)
3598 CODE: 3820 CODE:
3599 /* used by the manager thread */ 3821 /* used by the manager thread */
3600 coro_state_destroy (aTHX_ coro); 3822 coro_state_destroy (aTHX_ coro);
3823
3824void
3825on_destroy (Coro::State coro, SV *cb)
3826 CODE:
3601 coro_call_on_destroy (aTHX_ coro); 3827 coro_push_on_destroy (aTHX_ coro, newSVsv (cb));
3828
3829void
3830join (...)
3831 CODE:
3832 CORO_EXECUTE_SLF_XS (slf_init_join);
3602 3833
3603void 3834void
3604terminate (...) 3835terminate (...)
3605 CODE: 3836 CODE:
3606 CORO_EXECUTE_SLF_XS (slf_init_terminate); 3837 CORO_EXECUTE_SLF_XS (slf_init_terminate);
3607 3838
3608void 3839void
3609cancel (...) 3840cancel (...)
3610 CODE: 3841 CODE:
3611 CORO_EXECUTE_SLF_XS (slf_init_cancel); 3842 CORO_EXECUTE_SLF_XS (slf_init_cancel);
3843
3844int
3845safe_cancel (Coro::State self, ...)
3846 C_ARGS: aTHX_ self, &ST (1), items - 1
3612 3847
3613void 3848void
3614schedule (...) 3849schedule (...)
3615 CODE: 3850 CODE:
3616 CORO_EXECUTE_SLF_XS (slf_init_schedule); 3851 CORO_EXECUTE_SLF_XS (slf_init_schedule);

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines