ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/Coro/Coro/State.xs
(Generate patch)

Comparing Coro/Coro/State.xs (file contents):
Revision 1.375 by root, Fri Oct 2 19:58:02 2009 UTC vs.
Revision 1.423 by root, Mon Oct 8 23:13:36 2012 UTC

1/* this works around a bug in mingw32 providing a non-working setjmp */
2#define USE_NO_MINGW_SETJMP_TWO_ARGS
3
1#define NDEBUG 1 4#define NDEBUG 1
2 5
3#include "libcoro/coro.c" 6#include "libcoro/coro.c"
4 7
5#define PERL_NO_GET_CONTEXT 8#define PERL_NO_GET_CONTEXT
… …
10#include "XSUB.h" 13#include "XSUB.h"
11#include "perliol.h" 14#include "perliol.h"
12 15
13#include "schmorp.h" 16#include "schmorp.h"
14 17
18#define ECB_NO_THREADS 1
19#include "ecb.h"
20
21#include <stddef.h>
15#include <stdio.h> 22#include <stdio.h>
16#include <errno.h> 23#include <errno.h>
17#include <assert.h> 24#include <assert.h>
18 25
19#ifndef SVs_PADSTALE 26#ifndef SVs_PADSTALE
20# define SVs_PADSTALE 0 27# define SVs_PADSTALE 0
21#endif 28#endif
22 29
23#ifdef WIN32 30#if defined(_WIN32)
31# undef HAS_GETTIMEOFDAY
24# undef setjmp 32# undef setjmp
25# undef longjmp 33# undef longjmp
26# undef _exit 34# undef _exit
27# define setjmp _setjmp /* deep magic */ 35# define setjmp _setjmp /* deep magic */
28#else 36#else
29# include <inttypes.h> /* most portable stdint.h */ 37# include <inttypes.h> /* most portable stdint.h */
30#endif 38#endif
31 39
32#ifdef HAVE_MMAP 40#if HAVE_MMAP
33# include <unistd.h> 41# include <unistd.h>
34# include <sys/mman.h> 42# include <sys/mman.h>
35# ifndef MAP_ANONYMOUS 43# ifndef MAP_ANONYMOUS
36# ifdef MAP_ANON 44# ifdef MAP_ANON
37# define MAP_ANONYMOUS MAP_ANON 45# define MAP_ANONYMOUS MAP_ANON
… …
57#endif 65#endif
58 66
59/* the maximum number of idle cctx that will be pooled */ 67/* the maximum number of idle cctx that will be pooled */
60static int cctx_max_idle = 4; 68static int cctx_max_idle = 4;
61 69
70#if defined(DEBUGGING) && PERL_VERSION_ATLEAST(5,12,0)
71# define HAS_SCOPESTACK_NAME 1
72#endif
73
62#if !__i386 && !__x86_64 && !__powerpc && !__m68k && !__alpha && !__mips && !__sparc64 74#if !__i386 && !__x86_64 && !__powerpc && !__m68k && !__alpha && !__mips && !__sparc64
63# undef CORO_STACKGUARD 75# undef CORO_STACKGUARD
64#endif 76#endif
65 77
66#ifndef CORO_STACKGUARD 78#ifndef CORO_STACKGUARD
… …
82# define STACKLEVEL ((void *)&stacklevel) 94# define STACKLEVEL ((void *)&stacklevel)
83#endif 95#endif
84 96
85#define IN_DESTRUCT PL_dirty 97#define IN_DESTRUCT PL_dirty
86 98
87#if __GNUC__ >= 3
88# define attribute(x) __attribute__(x)
89# define expect(expr,value) __builtin_expect ((expr), (value))
90# define INLINE static inline
91#else
92# define attribute(x)
93# define expect(expr,value) (expr)
94# define INLINE static
95#endif
96
97#define expect_false(expr) expect ((expr) != 0, 0)
98#define expect_true(expr) expect ((expr) != 0, 1)
99
100#define NOINLINE attribute ((noinline))
101
102#include "CoroAPI.h" 99#include "CoroAPI.h"
103#define GCoroAPI (&coroapi) /* very sneaky */ 100#define GCoroAPI (&coroapi) /* very sneaky */
104 101
105#ifdef USE_ITHREADS 102#ifdef USE_ITHREADS
106# if CORO_PTHREAD 103# if CORO_PTHREAD
… …
122static void (*u2time)(pTHX_ UV ret[2]); 119static void (*u2time)(pTHX_ UV ret[2]);
123 120
124/* we hijack an hopefully unused CV flag for our purposes */ 121/* we hijack an hopefully unused CV flag for our purposes */
125#define CVf_SLF 0x4000 122#define CVf_SLF 0x4000
126static OP *pp_slf (pTHX); 123static OP *pp_slf (pTHX);
124static void slf_destroy (pTHX_ struct coro *coro);
127 125
128static U32 cctx_gen; 126static U32 cctx_gen;
129static size_t cctx_stacksize = CORO_STACKSIZE; 127static size_t cctx_stacksize = CORO_STACKSIZE;
130static struct CoroAPI coroapi; 128static struct CoroAPI coroapi;
131static AV *main_mainstack; /* used to differentiate between $main and others */ 129static AV *main_mainstack; /* used to differentiate between $main and others */
… …
161static char times_valid; 159static char times_valid;
162 160
163static struct coro_cctx *cctx_first; 161static struct coro_cctx *cctx_first;
164static int cctx_count, cctx_idle; 162static int cctx_count, cctx_idle;
165 163
166enum { 164enum
165{
167 CC_MAPPED = 0x01, 166 CC_MAPPED = 0x01,
168 CC_NOREUSE = 0x02, /* throw this away after tracing */ 167 CC_NOREUSE = 0x02, /* throw this away after tracing */
169 CC_TRACE = 0x04, 168 CC_TRACE = 0x04,
170 CC_TRACE_SUB = 0x08, /* trace sub calls */ 169 CC_TRACE_SUB = 0x08, /* trace sub calls */
171 CC_TRACE_LINE = 0x10, /* trace each statement */ 170 CC_TRACE_LINE = 0x10, /* trace each statement */
… …
181 void *sptr; 180 void *sptr;
182 size_t ssize; 181 size_t ssize;
183 182
184 /* cpu state */ 183 /* cpu state */
185 void *idle_sp; /* sp of top-level transfer/schedule/cede call */ 184 void *idle_sp; /* sp of top-level transfer/schedule/cede call */
185#ifndef NDEBUG
186 JMPENV *idle_te; /* same as idle_sp, but for top_env, TODO: remove once stable */ 186 JMPENV *idle_te; /* same as idle_sp, but for top_env */
187#endif
187 JMPENV *top_env; 188 JMPENV *top_env;
188 coro_context cctx; 189 coro_context cctx;
189 190
190 U32 gen; 191 U32 gen;
191#if CORO_USE_VALGRIND 192#if CORO_USE_VALGRIND
192 int valgrind_id; 193 int valgrind_id;
193#endif 194#endif
194 unsigned char flags; 195 unsigned char flags;
195} coro_cctx; 196} coro_cctx;
196 197
197coro_cctx *cctx_current; /* the currently running cctx */ 198static coro_cctx *cctx_current; /* the currently running cctx */
198 199
199/*****************************************************************************/ 200/*****************************************************************************/
200 201
202static MGVTBL coro_state_vtbl;
203
201enum { 204enum
205{
202 CF_RUNNING = 0x0001, /* coroutine is running */ 206 CF_RUNNING = 0x0001, /* coroutine is running */
203 CF_READY = 0x0002, /* coroutine is ready */ 207 CF_READY = 0x0002, /* coroutine is ready */
204 CF_NEW = 0x0004, /* has never been switched to */ 208 CF_NEW = 0x0004, /* has never been switched to */
205 CF_DESTROYED = 0x0008, /* coroutine data has been freed */ 209 CF_ZOMBIE = 0x0008, /* coroutine data has been freed */
206 CF_SUSPENDED = 0x0010, /* coroutine can't be scheduled */ 210 CF_SUSPENDED = 0x0010, /* coroutine can't be scheduled */
211 CF_NOCANCEL = 0x0020, /* cannot cancel, set slf_frame.data to 1 (hackish) */
207}; 212};
208 213
209/* the structure where most of the perl state is stored, overlaid on the cxstack */ 214/* the structure where most of the perl state is stored, overlaid on the cxstack */
210typedef struct 215typedef struct
211{ 216{
212 SV *defsv;
213 AV *defav;
214 SV *errsv;
215 SV *irsgv;
216 HV *hinthv;
217#define VAR(name,type) type name; 217 #define VARx(name,expr,type) type name;
218# include "state.h" 218 #include "state.h"
219#undef VAR
220} perl_slots; 219} perl_slots;
221 220
221/* how many context stack entries do we need for perl_slots */
222#define SLOT_COUNT ((sizeof (perl_slots) + sizeof (PERL_CONTEXT) - 1) / sizeof (PERL_CONTEXT)) 222#define SLOT_COUNT ((sizeof (perl_slots) + sizeof (PERL_CONTEXT) - 1) / sizeof (PERL_CONTEXT))
223 223
224/* this is a structure representing a perl-level coroutine */ 224/* this is a structure representing a perl-level coroutine */
225struct coro { 225struct coro
226{
226 /* the C coroutine allocated to this perl coroutine, if any */ 227 /* the C coroutine allocated to this perl coroutine, if any */
227 coro_cctx *cctx; 228 coro_cctx *cctx;
228 229
229 /* ready queue */ 230 /* ready queue */
230 struct coro *next_ready; 231 struct coro *next_ready;
… …
232 /* state data */ 233 /* state data */
233 struct CoroSLF slf_frame; /* saved slf frame */ 234 struct CoroSLF slf_frame; /* saved slf frame */
234 AV *mainstack; 235 AV *mainstack;
235 perl_slots *slot; /* basically the saved sp */ 236 perl_slots *slot; /* basically the saved sp */
236 237
237 CV *startcv; /* the CV to execute */ 238 CV *startcv; /* the CV to execute */
238 AV *args; /* data associated with this coroutine (initial args) */ 239 AV *args; /* data associated with this coroutine (initial args) */
239 int refcnt; /* coroutines are refcounted, yes */
240 int flags; /* CF_ flags */ 240 int flags; /* CF_ flags */
241 HV *hv; /* the perl hash associated with this coro, if any */ 241 HV *hv; /* the perl hash associated with this coro, if any */
242 void (*on_destroy)(pTHX_ struct coro *coro);
243 242
244 /* statistics */ 243 /* statistics */
245 int usecount; /* number of transfers to this coro */ 244 int usecount; /* number of transfers to this coro */
246 245
247 /* coro process data */ 246 /* coro process data */
248 int prio; 247 int prio;
249 SV *except; /* exception to be thrown */ 248 SV *except; /* exception to be thrown */
250 SV *rouse_cb; 249 SV *rouse_cb; /* last rouse callback */
250 AV *on_destroy; /* callbacks or coros to notify on destroy */
251 AV *status; /* the exit status list */
251 252
252 /* async_pool */ 253 /* async_pool */
253 SV *saved_deffh; 254 SV *saved_deffh;
254 SV *invoke_cb; 255 SV *invoke_cb;
255 AV *invoke_av; 256 AV *invoke_av;
… …
271typedef struct coro *Coro__State; 272typedef struct coro *Coro__State;
272typedef struct coro *Coro__State_or_hashref; 273typedef struct coro *Coro__State_or_hashref;
273 274
274/* the following variables are effectively part of the perl context */ 275/* the following variables are effectively part of the perl context */
275/* and get copied between struct coro and these variables */ 276/* and get copied between struct coro and these variables */
276/* the mainr easonw e don't support windows process emulation */ 277/* the main reason we don't support windows process emulation */
277static struct CoroSLF slf_frame; /* the current slf frame */ 278static struct CoroSLF slf_frame; /* the current slf frame */
278 279
279/** Coro ********************************************************************/ 280/** Coro ********************************************************************/
280 281
281#define CORO_PRIO_MAX 3 282#define CORO_PRIO_MAX 3
… …
287 288
288/* for Coro.pm */ 289/* for Coro.pm */
289static SV *coro_current; 290static SV *coro_current;
290static SV *coro_readyhook; 291static SV *coro_readyhook;
291static struct coro *coro_ready [CORO_PRIO_MAX - CORO_PRIO_MIN + 1][2]; /* head|tail */ 292static struct coro *coro_ready [CORO_PRIO_MAX - CORO_PRIO_MIN + 1][2]; /* head|tail */
292static CV *cv_coro_run, *cv_coro_terminate; 293static CV *cv_coro_run;
293static struct coro *coro_first; 294static struct coro *coro_first;
294#define coro_nready coroapi.nready 295#define coro_nready coroapi.nready
296
297/** JIT *********************************************************************/
298
299#if CORO_JIT
300 /* APPLE doesn't have HAVE_MMAP though */
301 #define CORO_JIT_UNIXY (__linux || __FreeBSD__ || __OpenBSD__ || __NetBSD__ || __solaris || __APPLE__)
302 #ifndef CORO_JIT_TYPE
303 #if __x86_64 && CORO_JIT_UNIXY
304 #define CORO_JIT_TYPE "amd64-unix"
305 #elif __i386 && CORO_JIT_UNIXY
306 #define CORO_JIT_TYPE "x86-unix"
307 #endif
308 #endif
309#endif
310
311#if !defined(CORO_JIT_TYPE) || !HAVE_MMAP
312 #undef CORO_JIT
313#endif
314
315#if CORO_JIT
316 typedef void (*load_save_perl_slots_type)(perl_slots *);
317 static load_save_perl_slots_type load_perl_slots, save_perl_slots;
318#endif
295 319
296/** Coro::Select ************************************************************/ 320/** Coro::Select ************************************************************/
297 321
298static OP *(*coro_old_pp_sselect) (pTHX); 322static OP *(*coro_old_pp_sselect) (pTHX);
299static SV *coro_select_select; 323static SV *coro_select_select;
… …
311 PL_op->op_flags |= OPf_STACKED; 335 PL_op->op_flags |= OPf_STACKED;
312 PL_op->op_private = 0; 336 PL_op->op_private = 0;
313 return PL_ppaddr [OP_ENTERSUB](aTHX); 337 return PL_ppaddr [OP_ENTERSUB](aTHX);
314} 338}
315 339
340/** time stuff **************************************************************/
341
342#ifdef HAS_GETTIMEOFDAY
343
344ecb_inline void
345coro_u2time (pTHX_ UV ret[2])
346{
347 struct timeval tv;
348 gettimeofday (&tv, 0);
349
350 ret [0] = tv.tv_sec;
351 ret [1] = tv.tv_usec;
352}
353
354ecb_inline double
355coro_nvtime (void)
356{
357 struct timeval tv;
358 gettimeofday (&tv, 0);
359
360 return tv.tv_sec + tv.tv_usec * 1e-6;
361}
362
363ecb_inline void
364time_init (pTHX)
365{
366 nvtime = coro_nvtime;
367 u2time = coro_u2time;
368}
369
370#else
371
372ecb_inline void
373time_init (pTHX)
374{
375 SV **svp;
376
377 require_pv ("Time/HiRes.pm");
378
379 svp = hv_fetch (PL_modglobal, "Time::NVtime", 12, 0);
380
381 if (!svp) croak ("Time::HiRes is required, but missing. Caught");
382 if (!SvIOK (*svp)) croak ("Time::NVtime isn't a function pointer. Caught");
383
384 nvtime = INT2PTR (double (*)(), SvIV (*svp));
385
386 svp = hv_fetch (PL_modglobal, "Time::U2time", 12, 0);
387 u2time = INT2PTR (void (*)(pTHX_ UV ret[2]), SvIV (*svp));
388}
389
390#endif
391
316/** lowlevel stuff **********************************************************/ 392/** lowlevel stuff **********************************************************/
317 393
318static SV * 394static SV * ecb_noinline
319coro_get_sv (pTHX_ const char *name, int create) 395coro_get_sv (pTHX_ const char *name, int create)
320{ 396{
321#if PERL_VERSION_ATLEAST (5,10,0) 397#if PERL_VERSION_ATLEAST (5,10,0)
322 /* silence stupid and wrong 5.10 warning that I am unable to switch off */ 398 /* silence stupid and wrong 5.10 warning that I am unable to switch off */
323 get_sv (name, create); 399 get_sv (name, create);
324#endif 400#endif
325 return get_sv (name, create); 401 return get_sv (name, create);
326} 402}
327 403
328static AV * 404static AV * ecb_noinline
329coro_get_av (pTHX_ const char *name, int create) 405coro_get_av (pTHX_ const char *name, int create)
330{ 406{
331#if PERL_VERSION_ATLEAST (5,10,0) 407#if PERL_VERSION_ATLEAST (5,10,0)
332 /* silence stupid and wrong 5.10 warning that I am unable to switch off */ 408 /* silence stupid and wrong 5.10 warning that I am unable to switch off */
333 get_av (name, create); 409 get_av (name, create);
334#endif 410#endif
335 return get_av (name, create); 411 return get_av (name, create);
336} 412}
337 413
338static HV * 414static HV * ecb_noinline
339coro_get_hv (pTHX_ const char *name, int create) 415coro_get_hv (pTHX_ const char *name, int create)
340{ 416{
341#if PERL_VERSION_ATLEAST (5,10,0) 417#if PERL_VERSION_ATLEAST (5,10,0)
342 /* silence stupid and wrong 5.10 warning that I am unable to switch off */ 418 /* silence stupid and wrong 5.10 warning that I am unable to switch off */
343 get_hv (name, create); 419 get_hv (name, create);
344#endif 420#endif
345 return get_hv (name, create); 421 return get_hv (name, create);
346} 422}
347 423
348INLINE void 424ecb_inline void
349coro_times_update () 425coro_times_update (void)
350{ 426{
351#ifdef coro_clock_gettime 427#ifdef coro_clock_gettime
352 struct timespec ts; 428 struct timespec ts;
353 429
354 ts.tv_sec = ts.tv_nsec = 0; 430 ts.tv_sec = ts.tv_nsec = 0;
… …
366 time_real [0] = tv [0]; 442 time_real [0] = tv [0];
367 time_real [1] = tv [1] * 1000; 443 time_real [1] = tv [1] * 1000;
368#endif 444#endif
369} 445}
370 446
371INLINE void 447ecb_inline void
372coro_times_add (struct coro *c) 448coro_times_add (struct coro *c)
373{ 449{
374 c->t_real [1] += time_real [1]; 450 c->t_real [1] += time_real [1];
375 if (c->t_real [1] > 1000000000) { c->t_real [1] -= 1000000000; ++c->t_real [0]; } 451 if (c->t_real [1] > 1000000000) { c->t_real [1] -= 1000000000; ++c->t_real [0]; }
376 c->t_real [0] += time_real [0]; 452 c->t_real [0] += time_real [0];
… …
378 c->t_cpu [1] += time_cpu [1]; 454 c->t_cpu [1] += time_cpu [1];
379 if (c->t_cpu [1] > 1000000000) { c->t_cpu [1] -= 1000000000; ++c->t_cpu [0]; } 455 if (c->t_cpu [1] > 1000000000) { c->t_cpu [1] -= 1000000000; ++c->t_cpu [0]; }
380 c->t_cpu [0] += time_cpu [0]; 456 c->t_cpu [0] += time_cpu [0];
381} 457}
382 458
383INLINE void 459ecb_inline void
384coro_times_sub (struct coro *c) 460coro_times_sub (struct coro *c)
385{ 461{
386 if (c->t_real [1] < time_real [1]) { c->t_real [1] += 1000000000; --c->t_real [0]; } 462 if (c->t_real [1] < time_real [1]) { c->t_real [1] += 1000000000; --c->t_real [0]; }
387 c->t_real [1] -= time_real [1]; 463 c->t_real [1] -= time_real [1];
388 c->t_real [0] -= time_real [0]; 464 c->t_real [0] -= time_real [0];
… …
396/* magic glue */ 472/* magic glue */
397 473
398#define CORO_MAGIC_type_cv 26 474#define CORO_MAGIC_type_cv 26
399#define CORO_MAGIC_type_state PERL_MAGIC_ext 475#define CORO_MAGIC_type_state PERL_MAGIC_ext
400 476
401#define CORO_MAGIC_NN(sv, type) \ 477#define CORO_MAGIC_NN(sv, type) \
402 (expect_true (SvMAGIC (sv)->mg_type == type) \ 478 (ecb_expect_true (SvMAGIC (sv)->mg_type == type) \
403 ? SvMAGIC (sv) \ 479 ? SvMAGIC (sv) \
404 : mg_find (sv, type)) 480 : mg_find (sv, type))
405 481
406#define CORO_MAGIC(sv, type) \ 482#define CORO_MAGIC(sv, type) \
407 (expect_true (SvMAGIC (sv)) \ 483 (ecb_expect_true (SvMAGIC (sv)) \
408 ? CORO_MAGIC_NN (sv, type) \ 484 ? CORO_MAGIC_NN (sv, type) \
409 : 0) 485 : 0)
410 486
411#define CORO_MAGIC_cv(cv) CORO_MAGIC (((SV *)(cv)), CORO_MAGIC_type_cv) 487#define CORO_MAGIC_cv(cv) CORO_MAGIC (((SV *)(cv)), CORO_MAGIC_type_cv)
412#define CORO_MAGIC_state(sv) CORO_MAGIC_NN (((SV *)(sv)), CORO_MAGIC_type_state) 488#define CORO_MAGIC_state(sv) CORO_MAGIC_NN (((SV *)(sv)), CORO_MAGIC_type_state)
413 489
414INLINE struct coro * 490ecb_inline MAGIC *
491SvSTATEhv_p (pTHX_ SV *coro)
492{
493 MAGIC *mg;
494
495 if (ecb_expect_true (
496 SvTYPE (coro) == SVt_PVHV
497 && (mg = CORO_MAGIC_state (coro))
498 && mg->mg_virtual == &coro_state_vtbl
499 ))
500 return mg;
501
502 return 0;
503}
504
505ecb_inline struct coro *
415SvSTATE_ (pTHX_ SV *coro) 506SvSTATE_ (pTHX_ SV *coro)
416{ 507{
417 HV *stash;
418 MAGIC *mg; 508 MAGIC *mg;
419 509
420 if (SvROK (coro)) 510 if (SvROK (coro))
421 coro = SvRV (coro); 511 coro = SvRV (coro);
422 512
423 if (expect_false (SvTYPE (coro) != SVt_PVHV)) 513 mg = SvSTATEhv_p (aTHX_ coro);
514 if (!mg)
424 croak ("Coro::State object required"); 515 croak ("Coro::State object required");
425 516
426 stash = SvSTASH (coro);
427 if (expect_false (stash != coro_stash && stash != coro_state_stash))
428 {
429 /* very slow, but rare, check */
430 if (!sv_derived_from (sv_2mortal (newRV_inc (coro)), "Coro::State"))
431 croak ("Coro::State object required");
432 }
433
434 mg = CORO_MAGIC_state (coro);
435 return (struct coro *)mg->mg_ptr; 517 return (struct coro *)mg->mg_ptr;
436} 518}
437 519
438#define SvSTATE(sv) SvSTATE_ (aTHX_ (sv)) 520#define SvSTATE(sv) SvSTATE_ (aTHX_ (sv))
439 521
… …
442#define SvSTATE_current SvSTATE_hv (SvRV (coro_current)) 524#define SvSTATE_current SvSTATE_hv (SvRV (coro_current))
443 525
444/*****************************************************************************/ 526/*****************************************************************************/
445/* padlist management and caching */ 527/* padlist management and caching */
446 528
447static AV * 529ecb_inline AV *
448coro_derive_padlist (pTHX_ CV *cv) 530coro_derive_padlist (pTHX_ CV *cv)
449{ 531{
450 AV *padlist = CvPADLIST (cv); 532 AV *padlist = CvPADLIST (cv);
451 AV *newpadlist, *newpad; 533 AV *newpadlist, *newpad;
452 534
… …
464 av_store (newpadlist, 1, (SV *)newpad); 546 av_store (newpadlist, 1, (SV *)newpad);
465 547
466 return newpadlist; 548 return newpadlist;
467} 549}
468 550
469static void 551ecb_inline void
470free_padlist (pTHX_ AV *padlist) 552free_padlist (pTHX_ AV *padlist)
471{ 553{
472 /* may be during global destruction */ 554 /* may be during global destruction */
473 if (!IN_DESTRUCT) 555 if (!IN_DESTRUCT)
474 { 556 {
… …
517 0, 0, 0, 0, 599 0, 0, 0, 0,
518 coro_cv_free 600 coro_cv_free
519}; 601};
520 602
521/* the next two functions merely cache the padlists */ 603/* the next two functions merely cache the padlists */
522static void 604ecb_inline void
523get_padlist (pTHX_ CV *cv) 605get_padlist (pTHX_ CV *cv)
524{ 606{
525 MAGIC *mg = CORO_MAGIC_cv (cv); 607 MAGIC *mg = CORO_MAGIC_cv (cv);
526 AV *av; 608 AV *av;
527 609
528 if (expect_true (mg && AvFILLp ((av = (AV *)mg->mg_obj)) >= 0)) 610 if (ecb_expect_true (mg && AvFILLp ((av = (AV *)mg->mg_obj)) >= 0))
529 CvPADLIST (cv) = (AV *)AvARRAY (av)[AvFILLp (av)--]; 611 CvPADLIST (cv) = (AV *)AvARRAY (av)[AvFILLp (av)--];
530 else 612 else
531 { 613 {
532#if CORO_PREFER_PERL_FUNCTIONS 614#if CORO_PREFER_PERL_FUNCTIONS
533 /* this is probably cleaner? but also slower! */ 615 /* this is probably cleaner? but also slower! */
… …
540 CvPADLIST (cv) = coro_derive_padlist (aTHX_ cv); 622 CvPADLIST (cv) = coro_derive_padlist (aTHX_ cv);
541#endif 623#endif
542 } 624 }
543} 625}
544 626
545static void 627ecb_inline void
546put_padlist (pTHX_ CV *cv) 628put_padlist (pTHX_ CV *cv)
547{ 629{
548 MAGIC *mg = CORO_MAGIC_cv (cv); 630 MAGIC *mg = CORO_MAGIC_cv (cv);
549 AV *av; 631 AV *av;
550 632
551 if (expect_false (!mg)) 633 if (ecb_expect_false (!mg))
552 mg = sv_magicext ((SV *)cv, (SV *)newAV (), CORO_MAGIC_type_cv, &coro_cv_vtbl, 0, 0); 634 mg = sv_magicext ((SV *)cv, (SV *)newAV (), CORO_MAGIC_type_cv, &coro_cv_vtbl, 0, 0);
553 635
554 av = (AV *)mg->mg_obj; 636 av = (AV *)mg->mg_obj;
555 637
556 if (expect_false (AvFILLp (av) >= AvMAX (av))) 638 if (ecb_expect_false (AvFILLp (av) >= AvMAX (av)))
557 av_extend (av, AvFILLp (av) + 1); 639 av_extend (av, AvFILLp (av) + 1);
558 640
559 AvARRAY (av)[++AvFILLp (av)] = (SV *)CvPADLIST (cv); 641 AvARRAY (av)[++AvFILLp (av)] = (SV *)CvPADLIST (cv);
560} 642}
561 643
562/** load & save, init *******************************************************/ 644/** load & save, init *******************************************************/
563 645
646ecb_inline void
647swap_sv (SV *a, SV *b)
648{
649 const U32 keep = SVs_PADSTALE | SVs_PADTMP | SVs_PADMY; /* keep these flags */
650 SV tmp;
651
652 /* swap sv_any */
653 SvANY (&tmp) = SvANY (a); SvANY (a) = SvANY (b); SvANY (b) = SvANY (&tmp);
654
655 /* swap sv_flags */
656 SvFLAGS (&tmp) = SvFLAGS (a);
657 SvFLAGS (a) = (SvFLAGS (a) & keep) | (SvFLAGS (b ) & ~keep);
658 SvFLAGS (b) = (SvFLAGS (b) & keep) | (SvFLAGS (&tmp) & ~keep);
659
660#if PERL_VERSION_ATLEAST (5,10,0)
661 /* perl 5.10 and later complicates this _quite_ a bit, but it also
662 * is much faster, so no quarrels here. alternatively, we could
663 * sv_upgrade to avoid this.
664 */
665 {
666 /* swap sv_u */
667 tmp.sv_u = a->sv_u; a->sv_u = b->sv_u; b->sv_u = tmp.sv_u;
668
669 /* if SvANY points to the head, we need to adjust the pointers,
670 * as the pointer for a still points to b, and maybe vice versa.
671 */
672 #define svany_in_head(type) \
673 (((1 << SVt_NULL) | (1 << SVt_BIND) | (1 << SVt_IV) | (1 << SVt_RV)) & (1 << (type)))
674
675 if (svany_in_head (SvTYPE (a)))
676 SvANY (a) = (void *)((PTRV)SvANY (a) - (PTRV)b + (PTRV)a);
677
678 if (svany_in_head (SvTYPE (b)))
679 SvANY (b) = (void *)((PTRV)SvANY (b) - (PTRV)a + (PTRV)b);
680 }
681#endif
682}
683
564/* swap sv heads, at least logically */ 684/* swap sv heads, at least logically */
565static void 685static void
566swap_svs (pTHX_ Coro__State c) 686swap_svs (pTHX_ Coro__State c)
567{ 687{
568 int i; 688 int i;
569 689
570 for (i = 0; i <= AvFILLp (c->swap_sv); ) 690 for (i = 0; i <= AvFILLp (c->swap_sv); i += 2)
571 { 691 swap_sv (AvARRAY (c->swap_sv)[i], AvARRAY (c->swap_sv)[i + 1]);
572 SV *a = AvARRAY (c->swap_sv)[i++];
573 SV *b = AvARRAY (c->swap_sv)[i++];
574
575 const U32 keep = SVs_PADSTALE | SVs_PADTMP | SVs_PADMY; /* keep these flags */
576 SV tmp;
577
578 /* swap sv_any */
579 SvANY (&tmp) = SvANY (a); SvANY (a) = SvANY (b); SvANY (b) = SvANY (&tmp);
580
581 /* swap sv_flags */
582 SvFLAGS (&tmp) = SvFLAGS (a);
583 SvFLAGS (a) = (SvFLAGS (a) & keep) | (SvFLAGS (b ) & ~keep);
584 SvFLAGS (b) = (SvFLAGS (b) & keep) | (SvFLAGS (&tmp) & ~keep);
585
586#if PERL_VERSION_ATLEAST (5,10,0)
587 /* perl 5.10 complicates this _quite_ a bit, but it also is
588 * is much faster, so no quarrels here. alternatively, we could
589 * sv_upgrade to avoid this.
590 */
591 {
592 /* swap sv_u */
593 tmp.sv_u = a->sv_u; a->sv_u = b->sv_u; b->sv_u = tmp.sv_u;
594
595 /* if SvANY points to the head, we need to adjust the pointers,
596 * as the pointer for a still points to b, and maybe vice versa.
597 */
598 #define svany_in_head(type) \
599 (((1 << SVt_NULL) | (1 << SVt_BIND) | (1 << SVt_IV) | (1 << SVt_RV)) & (1 << (type)))
600
601 if (svany_in_head (SvTYPE (a)))
602 SvANY (a) = (void *)((PTRV)SvANY (a) - (PTRV)b + (PTRV)a);
603
604 if (svany_in_head (SvTYPE (b)))
605 SvANY (b) = (void *)((PTRV)SvANY (b) - (PTRV)a + (PTRV)b);
606 }
607#endif
608 }
609} 692}
610 693
611#define SWAP_SVS(coro) \ 694#define SWAP_SVS(coro) \
612 if (expect_false ((coro)->swap_sv)) \ 695 if (ecb_expect_false ((coro)->swap_sv)) \
613 swap_svs (aTHX_ (coro)) 696 swap_svs (aTHX_ (coro))
614 697
615static void 698static void
616on_enterleave_call (pTHX_ SV *cb); 699on_enterleave_call (pTHX_ SV *cb);
617 700
… …
621 perl_slots *slot = c->slot; 704 perl_slots *slot = c->slot;
622 c->slot = 0; 705 c->slot = 0;
623 706
624 PL_mainstack = c->mainstack; 707 PL_mainstack = c->mainstack;
625 708
626 GvSV (PL_defgv) = slot->defsv; 709#if CORO_JIT
627 GvAV (PL_defgv) = slot->defav; 710 load_perl_slots (slot);
628 GvSV (PL_errgv) = slot->errsv; 711#else
629 GvSV (irsgv) = slot->irsgv;
630 GvHV (PL_hintgv) = slot->hinthv;
631
632 #define VAR(name,type) PL_ ## name = slot->name; 712 #define VARx(name,expr,type) expr = slot->name;
633 # include "state.h" 713 #include "state.h"
634 #undef VAR 714#endif
635 715
636 { 716 {
637 dSP; 717 dSP;
638 718
639 CV *cv; 719 CV *cv;
640 720
641 /* now do the ugly restore mess */ 721 /* now do the ugly restore mess */
642 while (expect_true (cv = (CV *)POPs)) 722 while (ecb_expect_true (cv = (CV *)POPs))
643 { 723 {
644 put_padlist (aTHX_ cv); /* mark this padlist as available */ 724 put_padlist (aTHX_ cv); /* mark this padlist as available */
645 CvDEPTH (cv) = PTR2IV (POPs); 725 CvDEPTH (cv) = PTR2IV (POPs);
646 CvPADLIST (cv) = (AV *)POPs; 726 CvPADLIST (cv) = (AV *)POPs;
647 } 727 }
… …
650 } 730 }
651 731
652 slf_frame = c->slf_frame; 732 slf_frame = c->slf_frame;
653 CORO_THROW = c->except; 733 CORO_THROW = c->except;
654 734
655 if (expect_false (enable_times)) 735 if (ecb_expect_false (enable_times))
656 { 736 {
657 if (expect_false (!times_valid)) 737 if (ecb_expect_false (!times_valid))
658 coro_times_update (); 738 coro_times_update ();
659 739
660 coro_times_sub (c); 740 coro_times_sub (c);
661 } 741 }
662 742
663 if (expect_false (c->on_enter)) 743 if (ecb_expect_false (c->on_enter))
664 { 744 {
665 int i; 745 int i;
666 746
667 for (i = 0; i <= AvFILLp (c->on_enter); ++i) 747 for (i = 0; i <= AvFILLp (c->on_enter); ++i)
668 on_enterleave_call (aTHX_ AvARRAY (c->on_enter)[i]); 748 on_enterleave_call (aTHX_ AvARRAY (c->on_enter)[i]);
… …
674static void 754static void
675save_perl (pTHX_ Coro__State c) 755save_perl (pTHX_ Coro__State c)
676{ 756{
677 SWAP_SVS (c); 757 SWAP_SVS (c);
678 758
679 if (expect_false (c->on_leave)) 759 if (ecb_expect_false (c->on_leave))
680 { 760 {
681 int i; 761 int i;
682 762
683 for (i = AvFILLp (c->on_leave); i >= 0; --i) 763 for (i = AvFILLp (c->on_leave); i >= 0; --i)
684 on_enterleave_call (aTHX_ AvARRAY (c->on_leave)[i]); 764 on_enterleave_call (aTHX_ AvARRAY (c->on_leave)[i]);
685 } 765 }
686 766
687 times_valid = 0; 767 times_valid = 0;
688 768
689 if (expect_false (enable_times)) 769 if (ecb_expect_false (enable_times))
690 { 770 {
691 coro_times_update (); times_valid = 1; 771 coro_times_update (); times_valid = 1;
692 coro_times_add (c); 772 coro_times_add (c);
693 } 773 }
694 774
… …
708 788
709 XPUSHs (Nullsv); 789 XPUSHs (Nullsv);
710 /* this loop was inspired by pp_caller */ 790 /* this loop was inspired by pp_caller */
711 for (;;) 791 for (;;)
712 { 792 {
713 while (expect_true (cxix >= 0)) 793 while (ecb_expect_true (cxix >= 0))
714 { 794 {
715 PERL_CONTEXT *cx = &ccstk[cxix--]; 795 PERL_CONTEXT *cx = &ccstk[cxix--];
716 796
717 if (expect_true (CxTYPE (cx) == CXt_SUB) || expect_false (CxTYPE (cx) == CXt_FORMAT)) 797 if (ecb_expect_true (CxTYPE (cx) == CXt_SUB) || ecb_expect_false (CxTYPE (cx) == CXt_FORMAT))
718 { 798 {
719 CV *cv = cx->blk_sub.cv; 799 CV *cv = cx->blk_sub.cv;
720 800
721 if (expect_true (CvDEPTH (cv))) 801 if (ecb_expect_true (CvDEPTH (cv)))
722 { 802 {
803 EXTEND (SP, 3);
723 PUSHs ((SV *)CvPADLIST (cv)); 804 PUSHs ((SV *)CvPADLIST (cv));
724 PUSHs (INT2PTR (SV *, (IV)CvDEPTH (cv))); 805 PUSHs (INT2PTR (SV *, (IV)CvDEPTH (cv)));
725 PUSHs ((SV *)cv); 806 PUSHs ((SV *)cv);
726 807
727 CvDEPTH (cv) = 0; 808 CvDEPTH (cv) = 0;
728 get_padlist (aTHX_ cv); 809 get_padlist (aTHX_ cv);
729 } 810 }
730 } 811 }
731 } 812 }
732 813
733 if (expect_true (top_si->si_type == PERLSI_MAIN)) 814 if (ecb_expect_true (top_si->si_type == PERLSI_MAIN))
734 break; 815 break;
735 816
736 top_si = top_si->si_prev; 817 top_si = top_si->si_prev;
737 ccstk = top_si->si_cxstack; 818 ccstk = top_si->si_cxstack;
738 cxix = top_si->si_cxix; 819 cxix = top_si->si_cxix;
… …
740 821
741 PUTBACK; 822 PUTBACK;
742 } 823 }
743 824
744 /* allocate some space on the context stack for our purposes */ 825 /* allocate some space on the context stack for our purposes */
745 /* we manually unroll here, as usually 2 slots is enough */ 826 if (ecb_expect_false (cxstack_ix + (int)SLOT_COUNT >= cxstack_max))
746 if (SLOT_COUNT >= 1) CXINC;
747 if (SLOT_COUNT >= 2) CXINC;
748 if (SLOT_COUNT >= 3) CXINC;
749 { 827 {
750 unsigned int i; 828 unsigned int i;
829
751 for (i = 3; i < SLOT_COUNT; ++i) 830 for (i = 0; i < SLOT_COUNT; ++i)
752 CXINC; 831 CXINC;
753 } 832
754 cxstack_ix -= SLOT_COUNT; /* undo allocation */ 833 cxstack_ix -= SLOT_COUNT; /* undo allocation */
834 }
755 835
756 c->mainstack = PL_mainstack; 836 c->mainstack = PL_mainstack;
757 837
758 { 838 {
759 perl_slots *slot = c->slot = (perl_slots *)(cxstack + cxstack_ix + 1); 839 perl_slots *slot = c->slot = (perl_slots *)(cxstack + cxstack_ix + 1);
760 840
761 slot->defav = GvAV (PL_defgv); 841#if CORO_JIT
762 slot->defsv = DEFSV; 842 save_perl_slots (slot);
763 slot->errsv = ERRSV; 843#else
764 slot->irsgv = GvSV (irsgv);
765 slot->hinthv = GvHV (PL_hintgv);
766
767 #define VAR(name,type) slot->name = PL_ ## name; 844 #define VARx(name,expr,type) slot->name = expr;
768 # include "state.h" 845 #include "state.h"
769 #undef VAR 846#endif
770 } 847 }
771} 848}
772 849
773/* 850/*
774 * allocate various perl stacks. This is almost an exact copy 851 * allocate various perl stacks. This is almost an exact copy
… …
780# define coro_init_stacks(thx) init_stacks () 857# define coro_init_stacks(thx) init_stacks ()
781#else 858#else
782static void 859static void
783coro_init_stacks (pTHX) 860coro_init_stacks (pTHX)
784{ 861{
785 PL_curstackinfo = new_stackinfo(32, 8); 862 PL_curstackinfo = new_stackinfo(32, 4 + SLOT_COUNT); /* 3 is minimum due to perl rounding down in scope.c:GROW() */
786 PL_curstackinfo->si_type = PERLSI_MAIN; 863 PL_curstackinfo->si_type = PERLSI_MAIN;
787 PL_curstack = PL_curstackinfo->si_stack; 864 PL_curstack = PL_curstackinfo->si_stack;
788 PL_mainstack = PL_curstack; /* remember in case we switch stacks */ 865 PL_mainstack = PL_curstack; /* remember in case we switch stacks */
789 866
790 PL_stack_base = AvARRAY(PL_curstack); 867 PL_stack_base = AvARRAY(PL_curstack);
… …
805#endif 882#endif
806 883
807 New(54,PL_scopestack,8,I32); 884 New(54,PL_scopestack,8,I32);
808 PL_scopestack_ix = 0; 885 PL_scopestack_ix = 0;
809 PL_scopestack_max = 8; 886 PL_scopestack_max = 8;
887#if HAS_SCOPESTACK_NAME
888 New(54,PL_scopestack_name,8,const char*);
889#endif
810 890
811 New(54,PL_savestack,24,ANY); 891 New(54,PL_savestack,24,ANY);
812 PL_savestack_ix = 0; 892 PL_savestack_ix = 0;
813 PL_savestack_max = 24; 893 PL_savestack_max = 24;
814 894
… …
842 } 922 }
843 923
844 Safefree (PL_tmps_stack); 924 Safefree (PL_tmps_stack);
845 Safefree (PL_markstack); 925 Safefree (PL_markstack);
846 Safefree (PL_scopestack); 926 Safefree (PL_scopestack);
927#if HAS_SCOPESTACK_NAME
928 Safefree (PL_scopestack_name);
929#endif
847 Safefree (PL_savestack); 930 Safefree (PL_savestack);
848#if !PERL_VERSION_ATLEAST (5,10,0) 931#if !PERL_VERSION_ATLEAST (5,10,0)
849 Safefree (PL_retstack); 932 Safefree (PL_retstack);
850#endif 933#endif
851} 934}
… …
897#endif 980#endif
898 981
899/* 982/*
900 * This overrides the default magic get method of %SIG elements. 983 * This overrides the default magic get method of %SIG elements.
901 * The original one doesn't provide for reading back of PL_diehook/PL_warnhook 984 * The original one doesn't provide for reading back of PL_diehook/PL_warnhook
902 * and instead of trying to save and restore the hash elements, we just provide 985 * and instead of trying to save and restore the hash elements (extremely slow),
903 * readback here. 986 * we just provide our own readback here.
904 */ 987 */
905static int 988static int ecb_cold
906coro_sigelem_get (pTHX_ SV *sv, MAGIC *mg) 989coro_sigelem_get (pTHX_ SV *sv, MAGIC *mg)
907{ 990{
908 const char *s = MgPV_nolen_const (mg); 991 const char *s = MgPV_nolen_const (mg);
909 992
910 if (*s == '_') 993 if (*s == '_')
… …
914 if (strEQ (s, "__DIE__" )) svp = &PL_diehook; 997 if (strEQ (s, "__DIE__" )) svp = &PL_diehook;
915 if (strEQ (s, "__WARN__")) svp = &PL_warnhook; 998 if (strEQ (s, "__WARN__")) svp = &PL_warnhook;
916 999
917 if (svp) 1000 if (svp)
918 { 1001 {
919 sv_setsv (sv, *svp ? *svp : &PL_sv_undef); 1002 SV *ssv;
1003
1004 if (!*svp)
1005 ssv = &PL_sv_undef;
1006 else if (SvTYPE (*svp) == SVt_PVCV) /* perlio directly stores a CV in warnhook. ugh. */
1007 ssv = sv_2mortal (newRV_inc (*svp));
1008 else
1009 ssv = *svp;
1010
1011 sv_setsv (sv, ssv);
920 return 0; 1012 return 0;
921 } 1013 }
922 } 1014 }
923 1015
924 return orig_sigelem_get ? orig_sigelem_get (aTHX_ sv, mg) : 0; 1016 return orig_sigelem_get ? orig_sigelem_get (aTHX_ sv, mg) : 0;
925} 1017}
926 1018
927static int 1019static int ecb_cold
928coro_sigelem_clr (pTHX_ SV *sv, MAGIC *mg) 1020coro_sigelem_clr (pTHX_ SV *sv, MAGIC *mg)
929{ 1021{
930 const char *s = MgPV_nolen_const (mg); 1022 const char *s = MgPV_nolen_const (mg);
931 1023
932 if (*s == '_') 1024 if (*s == '_')
… …
946 } 1038 }
947 1039
948 return orig_sigelem_clr ? orig_sigelem_clr (aTHX_ sv, mg) : 0; 1040 return orig_sigelem_clr ? orig_sigelem_clr (aTHX_ sv, mg) : 0;
949} 1041}
950 1042
951static int 1043static int ecb_cold
952coro_sigelem_set (pTHX_ SV *sv, MAGIC *mg) 1044coro_sigelem_set (pTHX_ SV *sv, MAGIC *mg)
953{ 1045{
954 const char *s = MgPV_nolen_const (mg); 1046 const char *s = MgPV_nolen_const (mg);
955 1047
956 if (*s == '_') 1048 if (*s == '_')
… …
991 return 1; 1083 return 1;
992} 1084}
993 1085
994static UNOP init_perl_op; 1086static UNOP init_perl_op;
995 1087
996static void NOINLINE /* noinline to keep it out of the transfer fast path */ 1088ecb_noinline static void /* noinline to keep it out of the transfer fast path */
997init_perl (pTHX_ struct coro *coro) 1089init_perl (pTHX_ struct coro *coro)
998{ 1090{
999 /* 1091 /*
1000 * emulate part of the perl startup here. 1092 * emulate part of the perl startup here.
1001 */ 1093 */
… …
1009 PL_comppad_name_fill = 0; 1101 PL_comppad_name_fill = 0;
1010 PL_comppad_name_floor = 0; 1102 PL_comppad_name_floor = 0;
1011 PL_curpm = 0; 1103 PL_curpm = 0;
1012 PL_curpad = 0; 1104 PL_curpad = 0;
1013 PL_localizing = 0; 1105 PL_localizing = 0;
1014 PL_dirty = 0;
1015 PL_restartop = 0; 1106 PL_restartop = 0;
1016#if PERL_VERSION_ATLEAST (5,10,0) 1107#if PERL_VERSION_ATLEAST (5,10,0)
1017 PL_parser = 0; 1108 PL_parser = 0;
1018#endif 1109#endif
1019 PL_hints = 0; 1110 PL_hints = 0;
1020 1111
1021 /* recreate the die/warn hooks */ 1112 /* recreate the die/warn hooks */
1022 PL_diehook = 0; SvSetMagicSV (*hv_fetch (hv_sig, "__DIE__" , sizeof ("__DIE__" ) - 1, 1), rv_diehook ); 1113 PL_diehook = SvREFCNT_inc (rv_diehook);
1023 PL_warnhook = 0; SvSetMagicSV (*hv_fetch (hv_sig, "__WARN__", sizeof ("__WARN__") - 1, 1), rv_warnhook); 1114 PL_warnhook = SvREFCNT_inc (rv_warnhook);
1024 1115
1025 GvSV (PL_defgv) = newSV (0); 1116 GvSV (PL_defgv) = newSV (0);
1026 GvAV (PL_defgv) = coro->args; coro->args = 0; 1117 GvAV (PL_defgv) = coro->args; coro->args = 0;
1027 GvSV (PL_errgv) = newSV (0); 1118 GvSV (PL_errgv) = newSV (0);
1028 GvSV (irsgv) = newSVpvn ("\n", 1); sv_magic (GvSV (irsgv), (SV *)irsgv, PERL_MAGIC_sv, "/", 0); 1119 GvSV (irsgv) = newSVpvn ("\n", 1); sv_magic (GvSV (irsgv), (SV *)irsgv, PERL_MAGIC_sv, "/", 0);
… …
1049 /* this newly created coroutine might be run on an existing cctx which most 1140 /* this newly created coroutine might be run on an existing cctx which most
1050 * likely was suspended in pp_slf, so we have to emulate entering pp_slf here. 1141 * likely was suspended in pp_slf, so we have to emulate entering pp_slf here.
1051 */ 1142 */
1052 slf_frame.prepare = prepare_nop; /* provide a nop function for an eventual pp_slf */ 1143 slf_frame.prepare = prepare_nop; /* provide a nop function for an eventual pp_slf */
1053 slf_frame.check = slf_check_nop; /* signal pp_slf to not repeat */ 1144 slf_frame.check = slf_check_nop; /* signal pp_slf to not repeat */
1145 slf_frame.destroy = 0;
1054 1146
1055 /* and we have to provide the pp_slf op in any case, so pp_slf can skip it */ 1147 /* and we have to provide the pp_slf op in any case, so pp_slf can skip it */
1056 init_perl_op.op_next = PL_op; 1148 init_perl_op.op_next = PL_op;
1057 init_perl_op.op_type = OP_ENTERSUB; 1149 init_perl_op.op_type = OP_ENTERSUB;
1058 init_perl_op.op_ppaddr = pp_slf; 1150 init_perl_op.op_ppaddr = pp_slf;
… …
1063 /* copy throw, in case it was set before init_perl */ 1155 /* copy throw, in case it was set before init_perl */
1064 CORO_THROW = coro->except; 1156 CORO_THROW = coro->except;
1065 1157
1066 SWAP_SVS (coro); 1158 SWAP_SVS (coro);
1067 1159
1068 if (expect_false (enable_times)) 1160 if (ecb_expect_false (enable_times))
1069 { 1161 {
1070 coro_times_update (); 1162 coro_times_update ();
1071 coro_times_sub (coro); 1163 coro_times_sub (coro);
1072 } 1164 }
1073} 1165}
… …
1097destroy_perl (pTHX_ struct coro *coro) 1189destroy_perl (pTHX_ struct coro *coro)
1098{ 1190{
1099 SV *svf [9]; 1191 SV *svf [9];
1100 1192
1101 { 1193 {
1194 SV *old_current = SvRV (coro_current);
1102 struct coro *current = SvSTATE_current; 1195 struct coro *current = SvSTATE (old_current);
1103 1196
1104 assert (("FATAL: tried to destroy currently running coroutine", coro->mainstack != PL_mainstack)); 1197 assert (("FATAL: tried to destroy currently running coroutine", coro->mainstack != PL_mainstack));
1105 1198
1106 save_perl (aTHX_ current); 1199 save_perl (aTHX_ current);
1200
1201 /* this will cause transfer_check to croak on block*/
1202 SvRV_set (coro_current, (SV *)coro->hv);
1203
1107 load_perl (aTHX_ coro); 1204 load_perl (aTHX_ coro);
1108 1205
1109 coro_unwind_stacks (aTHX); 1206 coro_unwind_stacks (aTHX);
1110 coro_destruct_stacks (aTHX);
1111 1207
1112 /* restore swapped sv's */ 1208 /* restore swapped sv's */
1113 SWAP_SVS (coro); 1209 SWAP_SVS (coro);
1114 1210
1211 coro_destruct_stacks (aTHX);
1212
1115 // now save some sv's to be free'd later 1213 /* now save some sv's to be free'd later */
1116 svf [0] = GvSV (PL_defgv); 1214 svf [0] = GvSV (PL_defgv);
1117 svf [1] = (SV *)GvAV (PL_defgv); 1215 svf [1] = (SV *)GvAV (PL_defgv);
1118 svf [2] = GvSV (PL_errgv); 1216 svf [2] = GvSV (PL_errgv);
1119 svf [3] = (SV *)PL_defoutgv; 1217 svf [3] = (SV *)PL_defoutgv;
1120 svf [4] = PL_rs; 1218 svf [4] = PL_rs;
… …
1122 svf [6] = (SV *)GvHV (PL_hintgv); 1220 svf [6] = (SV *)GvHV (PL_hintgv);
1123 svf [7] = PL_diehook; 1221 svf [7] = PL_diehook;
1124 svf [8] = PL_warnhook; 1222 svf [8] = PL_warnhook;
1125 assert (9 == sizeof (svf) / sizeof (*svf)); 1223 assert (9 == sizeof (svf) / sizeof (*svf));
1126 1224
1225 SvRV_set (coro_current, old_current);
1226
1127 load_perl (aTHX_ current); 1227 load_perl (aTHX_ current);
1128 } 1228 }
1129 1229
1130 { 1230 {
1131 unsigned int i; 1231 unsigned int i;
… …
1135 1235
1136 SvREFCNT_dec (coro->saved_deffh); 1236 SvREFCNT_dec (coro->saved_deffh);
1137 SvREFCNT_dec (coro->rouse_cb); 1237 SvREFCNT_dec (coro->rouse_cb);
1138 SvREFCNT_dec (coro->invoke_cb); 1238 SvREFCNT_dec (coro->invoke_cb);
1139 SvREFCNT_dec (coro->invoke_av); 1239 SvREFCNT_dec (coro->invoke_av);
1140 SvREFCNT_dec (coro->swap_sv);
1141 } 1240 }
1142} 1241}
1143 1242
1144INLINE void 1243ecb_inline void
1145free_coro_mortal (pTHX) 1244free_coro_mortal (pTHX)
1146{ 1245{
1147 if (expect_true (coro_mortal)) 1246 if (ecb_expect_true (coro_mortal))
1148 { 1247 {
1149 SvREFCNT_dec (coro_mortal); 1248 SvREFCNT_dec ((SV *)coro_mortal);
1150 coro_mortal = 0; 1249 coro_mortal = 0;
1151 } 1250 }
1152} 1251}
1153 1252
1154static int 1253static int
… …
1287 1386
1288 return frame->check (aTHX_ frame); /* execute the restored frame - there must be one */ 1387 return frame->check (aTHX_ frame); /* execute the restored frame - there must be one */
1289} 1388}
1290 1389
1291/* initialises PL_top_env and injects a pseudo-slf-call to set the stacklevel */ 1390/* initialises PL_top_env and injects a pseudo-slf-call to set the stacklevel */
1292static void NOINLINE 1391static void ecb_noinline
1293cctx_prepare (pTHX) 1392cctx_prepare (pTHX)
1294{ 1393{
1295 PL_top_env = &PL_start_env; 1394 PL_top_env = &PL_start_env;
1296 1395
1297 if (cctx_current->flags & CC_TRACE) 1396 if (cctx_current->flags & CC_TRACE)
… …
1308 slf_frame.prepare = slf_prepare_set_stacklevel; 1407 slf_frame.prepare = slf_prepare_set_stacklevel;
1309 slf_frame.check = slf_check_set_stacklevel; 1408 slf_frame.check = slf_check_set_stacklevel;
1310} 1409}
1311 1410
1312/* the tail of transfer: execute stuff we can only do after a transfer */ 1411/* the tail of transfer: execute stuff we can only do after a transfer */
1313INLINE void 1412ecb_inline void
1314transfer_tail (pTHX) 1413transfer_tail (pTHX)
1315{ 1414{
1316 free_coro_mortal (aTHX); 1415 free_coro_mortal (aTHX);
1416}
1417
1418/* try to exit the same way perl's main function would do */
1419/* we do not bother resetting the environment or other things *7
1420/* that are not, uhm, essential */
1421/* this obviously also doesn't work when perl is embedded */
1422static void ecb_noinline ecb_cold
1423perlish_exit (pTHX)
1424{
1425 int exitstatus = perl_destruct (PL_curinterp);
1426 perl_free (PL_curinterp);
1427 exit (exitstatus);
1317} 1428}
1318 1429
1319/* 1430/*
1320 * this is a _very_ stripped down perl interpreter ;) 1431 * this is a _very_ stripped down perl interpreter ;)
1321 */ 1432 */
… …
1350 */ 1461 */
1351 1462
1352 /* 1463 /*
1353 * If perl-run returns we assume exit() was being called or the coro 1464 * If perl-run returns we assume exit() was being called or the coro
1354 * fell off the end, which seems to be the only valid (non-bug) 1465 * fell off the end, which seems to be the only valid (non-bug)
1355 * reason for perl_run to return. We try to exit by jumping to the 1466 * reason for perl_run to return. We try to mimic whatever perl is normally
1356 * bootstrap-time "top" top_env, as we cannot restore the "main" 1467 * doing in that case. YMMV.
1357 * coroutine as Coro has no such concept.
1358 * This actually isn't valid with the pthread backend, but OSes requiring
1359 * that backend are too broken to do it in a standards-compliant way.
1360 */ 1468 */
1361 PL_top_env = main_top_env; 1469 perlish_exit (aTHX);
1362 JMPENV_JUMP (2); /* I do not feel well about the hardcoded 2 at all */
1363 } 1470 }
1364} 1471}
1365 1472
1366static coro_cctx * 1473static coro_cctx *
1367cctx_new () 1474cctx_new (void)
1368{ 1475{
1369 coro_cctx *cctx; 1476 coro_cctx *cctx;
1370 1477
1371 ++cctx_count; 1478 ++cctx_count;
1372 New (0, cctx, 1, coro_cctx); 1479 New (0, cctx, 1, coro_cctx);
… …
1378 return cctx; 1485 return cctx;
1379} 1486}
1380 1487
1381/* create a new cctx only suitable as source */ 1488/* create a new cctx only suitable as source */
1382static coro_cctx * 1489static coro_cctx *
1383cctx_new_empty () 1490cctx_new_empty (void)
1384{ 1491{
1385 coro_cctx *cctx = cctx_new (); 1492 coro_cctx *cctx = cctx_new ();
1386 1493
1387 cctx->sptr = 0; 1494 cctx->sptr = 0;
1388 coro_create (&cctx->cctx, 0, 0, 0, 0); 1495 coro_create (&cctx->cctx, 0, 0, 0, 0);
… …
1390 return cctx; 1497 return cctx;
1391} 1498}
1392 1499
1393/* create a new cctx suitable as destination/running a perl interpreter */ 1500/* create a new cctx suitable as destination/running a perl interpreter */
1394static coro_cctx * 1501static coro_cctx *
1395cctx_new_run () 1502cctx_new_run (void)
1396{ 1503{
1397 coro_cctx *cctx = cctx_new (); 1504 coro_cctx *cctx = cctx_new ();
1398 void *stack_start; 1505 void *stack_start;
1399 size_t stack_size; 1506 size_t stack_size;
1400 1507
1401#if HAVE_MMAP 1508#if HAVE_MMAP
1402 cctx->ssize = ((cctx_stacksize * sizeof (long) + PAGESIZE - 1) / PAGESIZE + CORO_STACKGUARD) * PAGESIZE; 1509 cctx->ssize = ((cctx_stacksize * sizeof (long) + PAGESIZE - 1) / PAGESIZE + CORO_STACKGUARD) * PAGESIZE;
1403 /* mmap supposedly does allocate-on-write for us */ 1510 /* mmap supposedly does allocate-on-write for us */
1404 cctx->sptr = mmap (0, cctx->ssize, PROT_EXEC|PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, 0, 0); 1511 cctx->sptr = mmap (0, cctx->ssize, PROT_READ | PROT_WRITE | PROT_EXEC, MAP_ANONYMOUS, -1, 0);
1405 1512
1406 if (cctx->sptr != (void *)-1) 1513 if (cctx->sptr != (void *)-1)
1407 { 1514 {
1408 #if CORO_STACKGUARD 1515 #if CORO_STACKGUARD
1409 mprotect (cctx->sptr, CORO_STACKGUARD * PAGESIZE, PROT_NONE); 1516 mprotect (cctx->sptr, CORO_STACKGUARD * PAGESIZE, PROT_NONE);
… …
1441cctx_destroy (coro_cctx *cctx) 1548cctx_destroy (coro_cctx *cctx)
1442{ 1549{
1443 if (!cctx) 1550 if (!cctx)
1444 return; 1551 return;
1445 1552
1446 assert (("FATAL: tried to destroy current cctx", cctx != cctx_current));//D temporary? 1553 assert (("FATAL: tried to destroy current cctx", cctx != cctx_current));
1447 1554
1448 --cctx_count; 1555 --cctx_count;
1449 coro_destroy (&cctx->cctx); 1556 coro_destroy (&cctx->cctx);
1450 1557
1451 /* coro_transfer creates new, empty cctx's */ 1558 /* coro_transfer creates new, empty cctx's */
… …
1470#define CCTX_EXPIRED(cctx) ((cctx)->gen != cctx_gen || ((cctx)->flags & CC_NOREUSE)) 1577#define CCTX_EXPIRED(cctx) ((cctx)->gen != cctx_gen || ((cctx)->flags & CC_NOREUSE))
1471 1578
1472static coro_cctx * 1579static coro_cctx *
1473cctx_get (pTHX) 1580cctx_get (pTHX)
1474{ 1581{
1475 while (expect_true (cctx_first)) 1582 while (ecb_expect_true (cctx_first))
1476 { 1583 {
1477 coro_cctx *cctx = cctx_first; 1584 coro_cctx *cctx = cctx_first;
1478 cctx_first = cctx->next; 1585 cctx_first = cctx->next;
1479 --cctx_idle; 1586 --cctx_idle;
1480 1587
1481 if (expect_true (!CCTX_EXPIRED (cctx))) 1588 if (ecb_expect_true (!CCTX_EXPIRED (cctx)))
1482 return cctx; 1589 return cctx;
1483 1590
1484 cctx_destroy (cctx); 1591 cctx_destroy (cctx);
1485 } 1592 }
1486 1593
… …
1491cctx_put (coro_cctx *cctx) 1598cctx_put (coro_cctx *cctx)
1492{ 1599{
1493 assert (("FATAL: cctx_put called on non-initialised cctx in Coro (please report)", cctx->sptr)); 1600 assert (("FATAL: cctx_put called on non-initialised cctx in Coro (please report)", cctx->sptr));
1494 1601
1495 /* free another cctx if overlimit */ 1602 /* free another cctx if overlimit */
1496 if (expect_false (cctx_idle >= cctx_max_idle)) 1603 if (ecb_expect_false (cctx_idle >= cctx_max_idle))
1497 { 1604 {
1498 coro_cctx *first = cctx_first; 1605 coro_cctx *first = cctx_first;
1499 cctx_first = first->next; 1606 cctx_first = first->next;
1500 --cctx_idle; 1607 --cctx_idle;
1501 1608
… …
1512static void 1619static void
1513transfer_check (pTHX_ struct coro *prev, struct coro *next) 1620transfer_check (pTHX_ struct coro *prev, struct coro *next)
1514{ 1621{
1515 /* TODO: throwing up here is considered harmful */ 1622 /* TODO: throwing up here is considered harmful */
1516 1623
1517 if (expect_true (prev != next)) 1624 if (ecb_expect_true (prev != next))
1518 { 1625 {
1519 if (expect_false (!(prev->flags & (CF_RUNNING | CF_NEW)))) 1626 if (ecb_expect_false (!(prev->flags & (CF_RUNNING | CF_NEW))))
1520 croak ("Coro::State::transfer called with a blocked prev Coro::State, but can only transfer from running or new states,"); 1627 croak ("Coro::State::transfer called with a blocked prev Coro::State, but can only transfer from running or new states,");
1521 1628
1522 if (expect_false (next->flags & (CF_RUNNING | CF_DESTROYED | CF_SUSPENDED))) 1629 if (ecb_expect_false (next->flags & (CF_RUNNING | CF_ZOMBIE | CF_SUSPENDED)))
1523 croak ("Coro::State::transfer called with running, destroyed or suspended next Coro::State, but can only transfer to inactive states,"); 1630 croak ("Coro::State::transfer called with running, destroyed or suspended next Coro::State, but can only transfer to inactive states,");
1524 1631
1525#if !PERL_VERSION_ATLEAST (5,10,0) 1632#if !PERL_VERSION_ATLEAST (5,10,0)
1526 if (expect_false (PL_lex_state != LEX_NOTPARSING)) 1633 if (ecb_expect_false (PL_lex_state != LEX_NOTPARSING))
1527 croak ("Coro::State::transfer called while parsing, but this is not supported in your perl version,"); 1634 croak ("Coro::State::transfer called while parsing, but this is not supported in your perl version,");
1528#endif 1635#endif
1529 } 1636 }
1530} 1637}
1531 1638
1532/* always use the TRANSFER macro */ 1639/* always use the TRANSFER macro */
1533static void NOINLINE /* noinline so we have a fixed stackframe */ 1640static void ecb_noinline /* noinline so we have a fixed stackframe */
1534transfer (pTHX_ struct coro *prev, struct coro *next, int force_cctx) 1641transfer (pTHX_ struct coro *prev, struct coro *next, int force_cctx)
1535{ 1642{
1536 dSTACKLEVEL; 1643 dSTACKLEVEL;
1537 1644
1538 /* sometimes transfer is only called to set idle_sp */ 1645 /* sometimes transfer is only called to set idle_sp */
1539 if (expect_false (!prev)) 1646 if (ecb_expect_false (!prev))
1540 { 1647 {
1541 cctx_current->idle_sp = STACKLEVEL; 1648 cctx_current->idle_sp = STACKLEVEL;
1542 assert (cctx_current->idle_te = PL_top_env); /* just for the side-effect when asserts are enabled */ 1649 assert (cctx_current->idle_te = PL_top_env); /* just for the side-effect when asserts are enabled */
1543 } 1650 }
1544 else if (expect_true (prev != next)) 1651 else if (ecb_expect_true (prev != next))
1545 { 1652 {
1546 coro_cctx *cctx_prev; 1653 coro_cctx *cctx_prev;
1547 1654
1548 if (expect_false (prev->flags & CF_NEW)) 1655 if (ecb_expect_false (prev->flags & CF_NEW))
1549 { 1656 {
1550 /* create a new empty/source context */ 1657 /* create a new empty/source context */
1551 prev->flags &= ~CF_NEW; 1658 prev->flags &= ~CF_NEW;
1552 prev->flags |= CF_RUNNING; 1659 prev->flags |= CF_RUNNING;
1553 } 1660 }
… …
1556 next->flags |= CF_RUNNING; 1663 next->flags |= CF_RUNNING;
1557 1664
1558 /* first get rid of the old state */ 1665 /* first get rid of the old state */
1559 save_perl (aTHX_ prev); 1666 save_perl (aTHX_ prev);
1560 1667
1561 if (expect_false (next->flags & CF_NEW)) 1668 if (ecb_expect_false (next->flags & CF_NEW))
1562 { 1669 {
1563 /* need to start coroutine */ 1670 /* need to start coroutine */
1564 next->flags &= ~CF_NEW; 1671 next->flags &= ~CF_NEW;
1565 /* setup coroutine call */ 1672 /* setup coroutine call */
1566 init_perl (aTHX_ next); 1673 init_perl (aTHX_ next);
1567 } 1674 }
1568 else 1675 else
1569 load_perl (aTHX_ next); 1676 load_perl (aTHX_ next);
1570 1677
1571 /* possibly untie and reuse the cctx */ 1678 /* possibly untie and reuse the cctx */
1572 if (expect_true ( 1679 if (ecb_expect_true (
1573 cctx_current->idle_sp == STACKLEVEL 1680 cctx_current->idle_sp == STACKLEVEL
1574 && !(cctx_current->flags & CC_TRACE) 1681 && !(cctx_current->flags & CC_TRACE)
1575 && !force_cctx 1682 && !force_cctx
1576 )) 1683 ))
1577 { 1684 {
1578 /* I assume that stacklevel is a stronger indicator than PL_top_env changes */ 1685 /* I assume that stacklevel is a stronger indicator than PL_top_env changes */
1579 assert (("FATAL: current top_env must equal previous top_env in Coro (please report)", PL_top_env == cctx_current->idle_te)); 1686 assert (("FATAL: current top_env must equal previous top_env in Coro (please report)", PL_top_env == cctx_current->idle_te));
1580 1687
1581 /* if the cctx is about to be destroyed we need to make sure we won't see it in cctx_get. */ 1688 /* if the cctx is about to be destroyed we need to make sure we won't see it in cctx_get. */
1582 /* without this the next cctx_get might destroy the running cctx while still in use */ 1689 /* without this the next cctx_get might destroy the running cctx while still in use */
1583 if (expect_false (CCTX_EXPIRED (cctx_current))) 1690 if (ecb_expect_false (CCTX_EXPIRED (cctx_current)))
1584 if (expect_true (!next->cctx)) 1691 if (ecb_expect_true (!next->cctx))
1585 next->cctx = cctx_get (aTHX); 1692 next->cctx = cctx_get (aTHX);
1586 1693
1587 cctx_put (cctx_current); 1694 cctx_put (cctx_current);
1588 } 1695 }
1589 else 1696 else
1590 prev->cctx = cctx_current; 1697 prev->cctx = cctx_current;
1591 1698
1592 ++next->usecount; 1699 ++next->usecount;
1593 1700
1594 cctx_prev = cctx_current; 1701 cctx_prev = cctx_current;
1595 cctx_current = expect_false (next->cctx) ? next->cctx : cctx_get (aTHX); 1702 cctx_current = ecb_expect_false (next->cctx) ? next->cctx : cctx_get (aTHX);
1596 1703
1597 next->cctx = 0; 1704 next->cctx = 0;
1598 1705
1599 if (expect_false (cctx_prev != cctx_current)) 1706 if (ecb_expect_false (cctx_prev != cctx_current))
1600 { 1707 {
1601 cctx_prev->top_env = PL_top_env; 1708 cctx_prev->top_env = PL_top_env;
1602 PL_top_env = cctx_current->top_env; 1709 PL_top_env = cctx_current->top_env;
1603 coro_transfer (&cctx_prev->cctx, &cctx_current->cctx); 1710 coro_transfer (&cctx_prev->cctx, &cctx_current->cctx);
1604 } 1711 }
… …
1610#define TRANSFER(ta, force_cctx) transfer (aTHX_ (ta).prev, (ta).next, (force_cctx)) 1717#define TRANSFER(ta, force_cctx) transfer (aTHX_ (ta).prev, (ta).next, (force_cctx))
1611#define TRANSFER_CHECK(ta) transfer_check (aTHX_ (ta).prev, (ta).next) 1718#define TRANSFER_CHECK(ta) transfer_check (aTHX_ (ta).prev, (ta).next)
1612 1719
1613/** high level stuff ********************************************************/ 1720/** high level stuff ********************************************************/
1614 1721
1722/* this function is actually Coro, not Coro::State, but we call it from here */
1723/* because it is convenient - but it hasn't been declared yet for that reason */
1615static int 1724static void
1725coro_call_on_destroy (pTHX_ struct coro *coro);
1726
1727static void
1616coro_state_destroy (pTHX_ struct coro *coro) 1728coro_state_destroy (pTHX_ struct coro *coro)
1617{ 1729{
1618 if (coro->flags & CF_DESTROYED) 1730 if (coro->flags & CF_ZOMBIE)
1619 return 0; 1731 return;
1620 1732
1621 if (coro->on_destroy && !PL_dirty)
1622 coro->on_destroy (aTHX_ coro); 1733 slf_destroy (aTHX_ coro);
1623 1734
1624 coro->flags |= CF_DESTROYED; 1735 coro->flags |= CF_ZOMBIE;
1625 1736
1626 if (coro->flags & CF_READY) 1737 if (coro->flags & CF_READY)
1627 { 1738 {
1628 /* reduce nready, as destroying a ready coro effectively unreadies it */ 1739 /* reduce nready, as destroying a ready coro effectively unreadies it */
1629 /* alternative: look through all ready queues and remove the coro */ 1740 /* alternative: look through all ready queues and remove the coro */
1630 --coro_nready; 1741 --coro_nready;
1631 } 1742 }
1632 else 1743 else
1633 coro->flags |= CF_READY; /* make sure it is NOT put into the readyqueue */ 1744 coro->flags |= CF_READY; /* make sure it is NOT put into the readyqueue */
1745
1746 if (coro->next) coro->next->prev = coro->prev;
1747 if (coro->prev) coro->prev->next = coro->next;
1748 if (coro == coro_first) coro_first = coro->next;
1634 1749
1635 if (coro->mainstack 1750 if (coro->mainstack
1636 && coro->mainstack != main_mainstack 1751 && coro->mainstack != main_mainstack
1637 && coro->slot 1752 && coro->slot
1638 && !PL_dirty) 1753 && !PL_dirty)
1639 destroy_perl (aTHX_ coro); 1754 destroy_perl (aTHX_ coro);
1640 1755
1641 cctx_destroy (coro->cctx); 1756 cctx_destroy (coro->cctx);
1642 SvREFCNT_dec (coro->startcv); 1757 SvREFCNT_dec (coro->startcv);
1643 SvREFCNT_dec (coro->args); 1758 SvREFCNT_dec (coro->args);
1759 SvREFCNT_dec (coro->swap_sv);
1644 SvREFCNT_dec (CORO_THROW); 1760 SvREFCNT_dec (CORO_THROW);
1645 1761
1646 if (coro->next) coro->next->prev = coro->prev; 1762 coro_call_on_destroy (aTHX_ coro);
1647 if (coro->prev) coro->prev->next = coro->next;
1648 if (coro == coro_first) coro_first = coro->next;
1649 1763
1650 return 1; 1764 /* more destruction mayhem in coro_state_free */
1651} 1765}
1652 1766
1653static int 1767static int
1654coro_state_free (pTHX_ SV *sv, MAGIC *mg) 1768coro_state_free (pTHX_ SV *sv, MAGIC *mg)
1655{ 1769{
1656 struct coro *coro = (struct coro *)mg->mg_ptr; 1770 struct coro *coro = (struct coro *)mg->mg_ptr;
1657 mg->mg_ptr = 0; 1771 mg->mg_ptr = 0;
1658 1772
1659 coro->hv = 0;
1660
1661 if (--coro->refcnt < 0)
1662 {
1663 coro_state_destroy (aTHX_ coro); 1773 coro_state_destroy (aTHX_ coro);
1774 SvREFCNT_dec (coro->on_destroy);
1775 SvREFCNT_dec (coro->status);
1776
1664 Safefree (coro); 1777 Safefree (coro);
1665 }
1666 1778
1667 return 0; 1779 return 0;
1668} 1780}
1669 1781
1670static int 1782static int ecb_cold
1671coro_state_dup (pTHX_ MAGIC *mg, CLONE_PARAMS *params) 1783coro_state_dup (pTHX_ MAGIC *mg, CLONE_PARAMS *params)
1672{ 1784{
1673 struct coro *coro = (struct coro *)mg->mg_ptr; 1785 /* called when perl clones the current process the slow way (windows process emulation) */
1674 1786 /* WE SIMply nuke the pointers in the copy, causing perl to croak */
1675 ++coro->refcnt; 1787 mg->mg_ptr = 0;
1788 mg->mg_virtual = 0;
1676 1789
1677 return 0; 1790 return 0;
1678} 1791}
1679 1792
1680static MGVTBL coro_state_vtbl = { 1793static MGVTBL coro_state_vtbl = {
… …
1705 TRANSFER (ta, 1); 1818 TRANSFER (ta, 1);
1706} 1819}
1707 1820
1708/** Coro ********************************************************************/ 1821/** Coro ********************************************************************/
1709 1822
1710INLINE void 1823ecb_inline void
1711coro_enq (pTHX_ struct coro *coro) 1824coro_enq (pTHX_ struct coro *coro)
1712{ 1825{
1713 struct coro **ready = coro_ready [coro->prio - CORO_PRIO_MIN]; 1826 struct coro **ready = coro_ready [coro->prio - CORO_PRIO_MIN];
1714 1827
1715 SvREFCNT_inc_NN (coro->hv); 1828 SvREFCNT_inc_NN (coro->hv);
… …
1717 coro->next_ready = 0; 1830 coro->next_ready = 0;
1718 *(ready [0] ? &ready [1]->next_ready : &ready [0]) = coro; 1831 *(ready [0] ? &ready [1]->next_ready : &ready [0]) = coro;
1719 ready [1] = coro; 1832 ready [1] = coro;
1720} 1833}
1721 1834
1722INLINE struct coro * 1835ecb_inline struct coro *
1723coro_deq (pTHX) 1836coro_deq (pTHX)
1724{ 1837{
1725 int prio; 1838 int prio;
1726 1839
1727 for (prio = CORO_PRIO_MAX - CORO_PRIO_MIN + 1; --prio >= 0; ) 1840 for (prio = CORO_PRIO_MAX - CORO_PRIO_MIN + 1; --prio >= 0; )
… …
1780{ 1893{
1781 return !!(SvSTATE (coro_sv)->flags & CF_READY); 1894 return !!(SvSTATE (coro_sv)->flags & CF_READY);
1782} 1895}
1783 1896
1784/* expects to own a reference to next->hv */ 1897/* expects to own a reference to next->hv */
1785INLINE void 1898ecb_inline void
1786prepare_schedule_to (pTHX_ struct coro_transfer_args *ta, struct coro *next) 1899prepare_schedule_to (pTHX_ struct coro_transfer_args *ta, struct coro *next)
1787{ 1900{
1788 SV *prev_sv = SvRV (coro_current); 1901 SV *prev_sv = SvRV (coro_current);
1789 1902
1790 ta->prev = SvSTATE_hv (prev_sv); 1903 ta->prev = SvSTATE_hv (prev_sv);
… …
1803{ 1916{
1804 for (;;) 1917 for (;;)
1805 { 1918 {
1806 struct coro *next = coro_deq (aTHX); 1919 struct coro *next = coro_deq (aTHX);
1807 1920
1808 if (expect_true (next)) 1921 if (ecb_expect_true (next))
1809 { 1922 {
1810 /* cannot transfer to destroyed coros, skip and look for next */ 1923 /* cannot transfer to destroyed coros, skip and look for next */
1811 if (expect_false (next->flags & (CF_DESTROYED | CF_SUSPENDED))) 1924 if (ecb_expect_false (next->flags & (CF_ZOMBIE | CF_SUSPENDED)))
1812 SvREFCNT_dec (next->hv); /* coro_nready has already been taken care of by destroy */ 1925 SvREFCNT_dec (next->hv); /* coro_nready has already been taken care of by destroy */
1813 else 1926 else
1814 { 1927 {
1815 next->flags &= ~CF_READY; 1928 next->flags &= ~CF_READY;
1816 --coro_nready; 1929 --coro_nready;
… …
1823 { 1936 {
1824 /* nothing to schedule: call the idle handler */ 1937 /* nothing to schedule: call the idle handler */
1825 if (SvROK (sv_idle) 1938 if (SvROK (sv_idle)
1826 && SvOBJECT (SvRV (sv_idle))) 1939 && SvOBJECT (SvRV (sv_idle)))
1827 { 1940 {
1941 if (SvRV (sv_idle) == SvRV (coro_current))
1942 croak ("FATAL: $Coro::IDLE blocked itself - did you try to block inside an event loop callback? Caught");
1943
1828 ++coro_nready; /* hack so that api_ready doesn't invoke ready hook */ 1944 ++coro_nready; /* hack so that api_ready doesn't invoke ready hook */
1829 api_ready (aTHX_ SvRV (sv_idle)); 1945 api_ready (aTHX_ SvRV (sv_idle));
1830 --coro_nready; 1946 --coro_nready;
1831 } 1947 }
1832 else 1948 else
… …
1846 } 1962 }
1847 } 1963 }
1848 } 1964 }
1849} 1965}
1850 1966
1851INLINE void 1967ecb_inline void
1852prepare_cede (pTHX_ struct coro_transfer_args *ta) 1968prepare_cede (pTHX_ struct coro_transfer_args *ta)
1853{ 1969{
1854 api_ready (aTHX_ coro_current); 1970 api_ready (aTHX_ coro_current);
1855 prepare_schedule (aTHX_ ta); 1971 prepare_schedule (aTHX_ ta);
1856} 1972}
1857 1973
1858INLINE void 1974ecb_inline void
1859prepare_cede_notself (pTHX_ struct coro_transfer_args *ta) 1975prepare_cede_notself (pTHX_ struct coro_transfer_args *ta)
1860{ 1976{
1861 SV *prev = SvRV (coro_current); 1977 SV *prev = SvRV (coro_current);
1862 1978
1863 if (coro_nready) 1979 if (coro_nready)
… …
1893{ 2009{
1894 struct coro_transfer_args ta; 2010 struct coro_transfer_args ta;
1895 2011
1896 prepare_cede (aTHX_ &ta); 2012 prepare_cede (aTHX_ &ta);
1897 2013
1898 if (expect_true (ta.prev != ta.next)) 2014 if (ecb_expect_true (ta.prev != ta.next))
1899 { 2015 {
1900 TRANSFER (ta, 1); 2016 TRANSFER (ta, 1);
1901 return 1; 2017 return 1;
1902 } 2018 }
1903 else 2019 else
… …
1946 coro->slot->runops = RUNOPS_DEFAULT; 2062 coro->slot->runops = RUNOPS_DEFAULT;
1947 } 2063 }
1948} 2064}
1949 2065
1950static void 2066static void
2067coro_push_av (pTHX_ AV *av, I32 gimme_v)
2068{
2069 if (AvFILLp (av) >= 0 && gimme_v != G_VOID)
2070 {
2071 dSP;
2072
2073 if (gimme_v == G_SCALAR)
2074 XPUSHs (AvARRAY (av)[AvFILLp (av)]);
2075 else
2076 {
2077 int i;
2078 EXTEND (SP, AvFILLp (av) + 1);
2079
2080 for (i = 0; i <= AvFILLp (av); ++i)
2081 PUSHs (AvARRAY (av)[i]);
2082 }
2083
2084 PUTBACK;
2085 }
2086}
2087
2088static void
2089coro_push_on_destroy (pTHX_ struct coro *coro, SV *cb)
2090{
2091 if (!coro->on_destroy)
2092 coro->on_destroy = newAV ();
2093
2094 av_push (coro->on_destroy, cb);
2095}
2096
2097static void
2098slf_destroy_join (pTHX_ struct CoroSLF *frame)
2099{
2100 SvREFCNT_dec ((SV *)((struct coro *)frame->data)->hv);
2101}
2102
2103static int
2104slf_check_join (pTHX_ struct CoroSLF *frame)
2105{
2106 struct coro *coro = (struct coro *)frame->data;
2107
2108 if (!coro->status)
2109 return 1;
2110
2111 frame->destroy = 0;
2112
2113 coro_push_av (aTHX_ coro->status, GIMME_V);
2114
2115 SvREFCNT_dec ((SV *)coro->hv);
2116
2117 return 0;
2118}
2119
2120static void
2121slf_init_join (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2122{
2123 struct coro *coro = SvSTATE (items > 0 ? arg [0] : &PL_sv_undef);
2124
2125 if (items > 1)
2126 croak ("join called with too many arguments");
2127
2128 if (coro->status)
2129 frame->prepare = prepare_nop;
2130 else
2131 {
2132 coro_push_on_destroy (aTHX_ coro, SvREFCNT_inc_NN (SvRV (coro_current)));
2133 frame->prepare = prepare_schedule;
2134 }
2135
2136 frame->check = slf_check_join;
2137 frame->destroy = slf_destroy_join;
2138 frame->data = (void *)coro;
2139 SvREFCNT_inc (coro->hv);
2140}
2141
2142static void
1951coro_call_on_destroy (pTHX_ struct coro *coro) 2143coro_call_on_destroy (pTHX_ struct coro *coro)
1952{ 2144{
1953 SV **on_destroyp = hv_fetch (coro->hv, "_on_destroy", sizeof ("_on_destroy") - 1, 0); 2145 AV *od = coro->on_destroy;
1954 SV **statusp = hv_fetch (coro->hv, "_status", sizeof ("_status") - 1, 0);
1955 2146
1956 if (on_destroyp) 2147 if (!od)
1957 { 2148 return;
1958 AV *on_destroy = (AV *)SvRV (*on_destroyp);
1959 2149
1960 while (AvFILLp (on_destroy) >= 0) 2150 while (AvFILLp (od) >= 0)
2151 {
2152 SV *cb = sv_2mortal (av_pop (od));
2153
2154 /* coro hv's (and only hv's at the moment) are supported as well */
2155 if (SvSTATEhv_p (aTHX_ cb))
2156 api_ready (aTHX_ cb);
2157 else
1961 { 2158 {
1962 dSP; /* don't disturb outer sp */ 2159 dSP; /* don't disturb outer sp */
1963 SV *cb = av_pop (on_destroy);
1964
1965 PUSHMARK (SP); 2160 PUSHMARK (SP);
1966 2161
1967 if (statusp) 2162 if (coro->status)
1968 { 2163 {
1969 int i; 2164 PUTBACK;
1970 AV *status = (AV *)SvRV (*statusp); 2165 coro_push_av (aTHX_ coro->status, G_ARRAY);
1971 EXTEND (SP, AvFILLp (status) + 1); 2166 SPAGAIN;
1972
1973 for (i = 0; i <= AvFILLp (status); ++i)
1974 PUSHs (AvARRAY (status)[i]);
1975 } 2167 }
1976 2168
1977 PUTBACK; 2169 PUTBACK;
1978 call_sv (sv_2mortal (cb), G_VOID | G_DISCARD); 2170 call_sv (cb, G_VOID | G_DISCARD);
1979 } 2171 }
1980 } 2172 }
1981} 2173}
1982 2174
1983static void 2175static void
1984slf_init_terminate (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2176coro_set_status (pTHX_ struct coro *coro, SV **arg, int items)
1985{ 2177{
1986 int i; 2178 AV *av;
1987 HV *hv = (HV *)SvRV (coro_current); 2179
1988 AV *av = newAV (); 2180 if (coro->status)
2181 {
2182 av = coro->status;
2183 av_clear (av);
2184 }
2185 else
2186 av = coro->status = newAV ();
1989 2187
1990 /* items are actually not so common, so optimise for this case */ 2188 /* items are actually not so common, so optimise for this case */
1991 if (items) 2189 if (items)
1992 { 2190 {
2191 int i;
2192
1993 av_extend (av, items - 1); 2193 av_extend (av, items - 1);
1994 2194
1995 for (i = 0; i < items; ++i) 2195 for (i = 0; i < items; ++i)
1996 av_push (av, SvREFCNT_inc_NN (arg [i])); 2196 av_push (av, SvREFCNT_inc_NN (arg [i]));
1997 } 2197 }
2198}
1998 2199
1999 hv_store (hv, "_status", sizeof ("_status") - 1, newRV_noinc ((SV *)av), 0); 2200static void
2000 2201slf_init_terminate_cancel_common (pTHX_ struct CoroSLF *frame, HV *coro_hv)
2202{
2001 av_push (av_destroy, (SV *)newRV_inc ((SV *)hv)); /* RVinc for perl */ 2203 av_push (av_destroy, (SV *)newRV_inc ((SV *)coro_hv)); /* RVinc for perl */
2002 api_ready (aTHX_ sv_manager); 2204 api_ready (aTHX_ sv_manager);
2003 2205
2004 frame->prepare = prepare_schedule; 2206 frame->prepare = prepare_schedule;
2005 frame->check = slf_check_repeat; 2207 frame->check = slf_check_repeat;
2006 2208
2007 /* as a minor optimisation, we could unwind all stacks here */ 2209 /* as a minor optimisation, we could unwind all stacks here */
2008 /* but that puts extra pressure on pp_slf, and is not worth much */ 2210 /* but that puts extra pressure on pp_slf, and is not worth much */
2009 /*coro_unwind_stacks (aTHX);*/ 2211 /*coro_unwind_stacks (aTHX);*/
2212}
2213
2214static void
2215slf_init_terminate (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2216{
2217 HV *coro_hv = (HV *)SvRV (coro_current);
2218
2219 coro_set_status (aTHX_ SvSTATE ((SV *)coro_hv), arg, items);
2220 slf_init_terminate_cancel_common (aTHX_ frame, coro_hv);
2221}
2222
2223static void
2224slf_init_cancel (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2225{
2226 HV *coro_hv;
2227 struct coro *coro;
2228
2229 if (items <= 0)
2230 croak ("Coro::cancel called without coro object,");
2231
2232 coro = SvSTATE (arg [0]);
2233 coro_hv = coro->hv;
2234
2235 coro_set_status (aTHX_ coro, arg + 1, items - 1);
2236
2237 if (ecb_expect_false (coro->flags & CF_NOCANCEL))
2238 {
2239 /* coro currently busy cancelling something, so just notify it */
2240 coro->slf_frame.data = (void *)coro;
2241
2242 frame->prepare = prepare_nop;
2243 frame->check = slf_check_nop;
2244 }
2245 else if (coro_hv == (HV *)SvRV (coro_current))
2246 {
2247 /* cancelling the current coro is allowed, and equals terminate */
2248 slf_init_terminate_cancel_common (aTHX_ frame, coro_hv);
2249 }
2250 else
2251 {
2252 struct coro *self = SvSTATE_current;
2253
2254 /* otherwise we cancel directly, purely for speed reasons
2255 * unfortunately, this requires some magic trickery, as
2256 * somebody else could cancel us, so we have to fight the cancellation.
2257 * this is ugly, and hopefully fully worth the extra speed.
2258 * besides, I can't get the slow-but-safe version working...
2259 */
2260 slf_frame.data = 0;
2261 self->flags |= CF_NOCANCEL;
2262 coro_state_destroy (aTHX_ coro);
2263 self->flags &= ~CF_NOCANCEL;
2264
2265 if (slf_frame.data)
2266 {
2267 /* while we were busy we have been cancelled, so terminate */
2268 slf_init_terminate_cancel_common (aTHX_ frame, self->hv);
2269 }
2270 else
2271 {
2272 frame->prepare = prepare_nop;
2273 frame->check = slf_check_nop;
2274 }
2275 }
2276}
2277
2278static int
2279slf_check_safe_cancel (pTHX_ struct CoroSLF *frame)
2280{
2281 frame->prepare = 0;
2282 coro_unwind_stacks (aTHX);
2283
2284 slf_init_terminate_cancel_common (aTHX_ frame, (HV *)SvRV (coro_current));
2285
2286 return 1;
2287}
2288
2289static int
2290safe_cancel (pTHX_ struct coro *coro, SV **arg, int items)
2291{
2292 if (coro->cctx)
2293 croak ("coro inside C callback, unable to cancel at this time, caught");
2294
2295 if (coro->flags & CF_NEW)
2296 {
2297 coro_set_status (aTHX_ coro, arg, items);
2298 coro_state_destroy (aTHX_ coro);
2299 }
2300 else
2301 {
2302 if (!coro->slf_frame.prepare)
2303 croak ("coro outside an SLF function, unable to cancel at this time, caught");
2304
2305 slf_destroy (aTHX_ coro);
2306
2307 coro_set_status (aTHX_ coro, arg, items);
2308 coro->slf_frame.prepare = prepare_nop;
2309 coro->slf_frame.check = slf_check_safe_cancel;
2310
2311 api_ready (aTHX_ (SV *)coro->hv);
2312 }
2313
2314 return 1;
2010} 2315}
2011 2316
2012/*****************************************************************************/ 2317/*****************************************************************************/
2013/* async pool handler */ 2318/* async pool handler */
2014 2319
… …
2045slf_init_pool_handler (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2350slf_init_pool_handler (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2046{ 2351{
2047 HV *hv = (HV *)SvRV (coro_current); 2352 HV *hv = (HV *)SvRV (coro_current);
2048 struct coro *coro = SvSTATE_hv ((SV *)hv); 2353 struct coro *coro = SvSTATE_hv ((SV *)hv);
2049 2354
2050 if (expect_true (coro->saved_deffh)) 2355 if (ecb_expect_true (coro->saved_deffh))
2051 { 2356 {
2052 /* subsequent iteration */ 2357 /* subsequent iteration */
2053 SvREFCNT_dec ((SV *)PL_defoutgv); PL_defoutgv = (GV *)coro->saved_deffh; 2358 SvREFCNT_dec ((SV *)PL_defoutgv); PL_defoutgv = (GV *)coro->saved_deffh;
2054 coro->saved_deffh = 0; 2359 coro->saved_deffh = 0;
2055 2360
2056 if (coro_rss (aTHX_ coro) > SvUV (sv_pool_rss) 2361 if (coro_rss (aTHX_ coro) > SvUV (sv_pool_rss)
2057 || av_len (av_async_pool) + 1 >= SvIV (sv_pool_size)) 2362 || av_len (av_async_pool) + 1 >= SvIV (sv_pool_size))
2058 { 2363 {
2059 coro->invoke_cb = SvREFCNT_inc_NN ((SV *)cv_coro_terminate); 2364 slf_init_terminate_cancel_common (aTHX_ frame, hv);
2060 coro->invoke_av = newAV (); 2365 return;
2061
2062 frame->prepare = prepare_nop;
2063 } 2366 }
2064 else 2367 else
2065 { 2368 {
2066 av_clear (GvAV (PL_defgv)); 2369 av_clear (GvAV (PL_defgv));
2067 hv_store (hv, "desc", sizeof ("desc") - 1, SvREFCNT_inc_NN (sv_async_pool_idle), 0); 2370 hv_store (hv, "desc", sizeof ("desc") - 1, SvREFCNT_inc_NN (sv_async_pool_idle), 0);
… …
2290static void 2593static void
2291slf_init_cede_notself (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 2594slf_init_cede_notself (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
2292{ 2595{
2293 frame->prepare = prepare_cede_notself; 2596 frame->prepare = prepare_cede_notself;
2294 frame->check = slf_check_nop; 2597 frame->check = slf_check_nop;
2598}
2599
2600/* "undo"/cancel a running slf call - used when cancelling a coro, mainly */
2601static void
2602slf_destroy (pTHX_ struct coro *coro)
2603{
2604 /* this callback is reserved for slf functions needing to do cleanup */
2605 if (coro->slf_frame.destroy && coro->slf_frame.prepare && !PL_dirty)
2606 coro->slf_frame.destroy (aTHX_ &coro->slf_frame);
2607
2608 /*
2609 * The on_destroy above most likely is from an SLF call.
2610 * Since by definition the SLF call will not finish when we destroy
2611 * the coro, we will have to force-finish it here, otherwise
2612 * cleanup functions cannot call SLF functions.
2613 */
2614 coro->slf_frame.prepare = 0;
2295} 2615}
2296 2616
2297/* 2617/*
2298 * these not obviously related functions are all rolled into one 2618 * these not obviously related functions are all rolled into one
2299 * function to increase chances that they all will call transfer with the same 2619 * function to increase chances that they all will call transfer with the same
… …
2306 I32 checkmark; /* mark SP to see how many elements check has pushed */ 2626 I32 checkmark; /* mark SP to see how many elements check has pushed */
2307 2627
2308 /* set up the slf frame, unless it has already been set-up */ 2628 /* set up the slf frame, unless it has already been set-up */
2309 /* the latter happens when a new coro has been started */ 2629 /* the latter happens when a new coro has been started */
2310 /* or when a new cctx was attached to an existing coroutine */ 2630 /* or when a new cctx was attached to an existing coroutine */
2311 if (expect_true (!slf_frame.prepare)) 2631 if (ecb_expect_true (!slf_frame.prepare))
2312 { 2632 {
2313 /* first iteration */ 2633 /* first iteration */
2314 dSP; 2634 dSP;
2315 SV **arg = PL_stack_base + TOPMARK + 1; 2635 SV **arg = PL_stack_base + TOPMARK + 1;
2316 int items = SP - arg; /* args without function object */ 2636 int items = SP - arg; /* args without function object */
… …
2357 while (slf_frame.check (aTHX_ &slf_frame)); 2677 while (slf_frame.check (aTHX_ &slf_frame));
2358 2678
2359 slf_frame.prepare = 0; /* invalidate the frame, we are done processing it */ 2679 slf_frame.prepare = 0; /* invalidate the frame, we are done processing it */
2360 2680
2361 /* exception handling */ 2681 /* exception handling */
2362 if (expect_false (CORO_THROW)) 2682 if (ecb_expect_false (CORO_THROW))
2363 { 2683 {
2364 SV *exception = sv_2mortal (CORO_THROW); 2684 SV *exception = sv_2mortal (CORO_THROW);
2365 2685
2366 CORO_THROW = 0; 2686 CORO_THROW = 0;
2367 sv_setsv (ERRSV, exception); 2687 sv_setsv (ERRSV, exception);
2368 croak (0); 2688 croak (0);
2369 } 2689 }
2370 2690
2371 /* return value handling - mostly like entersub */ 2691 /* return value handling - mostly like entersub */
2372 /* make sure we put something on the stack in scalar context */ 2692 /* make sure we put something on the stack in scalar context */
2373 if (GIMME_V == G_SCALAR) 2693 if (GIMME_V == G_SCALAR
2694 && ecb_expect_false (PL_stack_sp != PL_stack_base + checkmark + 1))
2374 { 2695 {
2375 dSP; 2696 dSP;
2376 SV **bot = PL_stack_base + checkmark; 2697 SV **bot = PL_stack_base + checkmark;
2377 2698
2378 if (sp == bot) /* too few, push undef */ 2699 if (sp == bot) /* too few, push undef */
2379 bot [1] = &PL_sv_undef; 2700 bot [1] = &PL_sv_undef;
2380 else if (sp != bot + 1) /* too many, take last one */ 2701 else /* too many, take last one */
2381 bot [1] = *sp; 2702 bot [1] = *sp;
2382 2703
2383 SP = bot + 1; 2704 SP = bot + 1;
2384 2705
2385 PUTBACK; 2706 PUTBACK;
… …
2418 if (PL_op->op_flags & OPf_STACKED) 2739 if (PL_op->op_flags & OPf_STACKED)
2419 { 2740 {
2420 if (items > slf_arga) 2741 if (items > slf_arga)
2421 { 2742 {
2422 slf_arga = items; 2743 slf_arga = items;
2423 free (slf_argv); 2744 Safefree (slf_argv);
2424 slf_argv = malloc (slf_arga * sizeof (SV *)); 2745 New (0, slf_argv, slf_arga, SV *);
2425 } 2746 }
2426 2747
2427 slf_argc = items; 2748 slf_argc = items;
2428 2749
2429 for (i = 0; i < items; ++i) 2750 for (i = 0; i < items; ++i)
… …
2492{ 2813{
2493 PerlIOBuf base; 2814 PerlIOBuf base;
2494 NV next, every; 2815 NV next, every;
2495} PerlIOCede; 2816} PerlIOCede;
2496 2817
2497static IV 2818static IV ecb_cold
2498PerlIOCede_pushed (pTHX_ PerlIO *f, const char *mode, SV *arg, PerlIO_funcs *tab) 2819PerlIOCede_pushed (pTHX_ PerlIO *f, const char *mode, SV *arg, PerlIO_funcs *tab)
2499{ 2820{
2500 PerlIOCede *self = PerlIOSelf (f, PerlIOCede); 2821 PerlIOCede *self = PerlIOSelf (f, PerlIOCede);
2501 2822
2502 self->every = SvCUR (arg) ? SvNV (arg) : 0.01; 2823 self->every = SvCUR (arg) ? SvNV (arg) : 0.01;
2503 self->next = nvtime () + self->every; 2824 self->next = nvtime () + self->every;
2504 2825
2505 return PerlIOBuf_pushed (aTHX_ f, mode, Nullsv, tab); 2826 return PerlIOBuf_pushed (aTHX_ f, mode, Nullsv, tab);
2506} 2827}
2507 2828
2508static SV * 2829static SV * ecb_cold
2509PerlIOCede_getarg (pTHX_ PerlIO *f, CLONE_PARAMS *param, int flags) 2830PerlIOCede_getarg (pTHX_ PerlIO *f, CLONE_PARAMS *param, int flags)
2510{ 2831{
2511 PerlIOCede *self = PerlIOSelf (f, PerlIOCede); 2832 PerlIOCede *self = PerlIOSelf (f, PerlIOCede);
2512 2833
2513 return newSVnv (self->every); 2834 return newSVnv (self->every);
… …
2625 SvREFCNT_dec (cb); 2946 SvREFCNT_dec (cb);
2626 } 2947 }
2627} 2948}
2628 2949
2629static void 2950static void
2630coro_semaphore_on_destroy (pTHX_ struct coro *coro) 2951coro_semaphore_destroy (pTHX_ struct CoroSLF *frame)
2631{ 2952{
2632 /* call $sem->adjust (0) to possibly wake up some other waiters */ 2953 /* call $sem->adjust (0) to possibly wake up some other waiters */
2633 coro_semaphore_adjust (aTHX_ (AV *)coro->slf_frame.data, 0); 2954 coro_semaphore_adjust (aTHX_ (AV *)frame->data, 0);
2634} 2955}
2635 2956
2636static int 2957static int
2637slf_check_semaphore_down_or_wait (pTHX_ struct CoroSLF *frame, int acquire) 2958slf_check_semaphore_down_or_wait (pTHX_ struct CoroSLF *frame, int acquire)
2638{ 2959{
2639 AV *av = (AV *)frame->data; 2960 AV *av = (AV *)frame->data;
2640 SV *count_sv = AvARRAY (av)[0]; 2961 SV *count_sv = AvARRAY (av)[0];
2962 SV *coro_hv = SvRV (coro_current);
2641 2963
2642 /* if we are about to throw, don't actually acquire the lock, just throw */ 2964 /* if we are about to throw, don't actually acquire the lock, just throw */
2643 if (CORO_THROW) 2965 if (CORO_THROW)
2644 return 0; 2966 return 0;
2645 else if (SvIVX (count_sv) > 0) 2967 else if (SvIVX (count_sv) > 0)
2646 { 2968 {
2647 SvSTATE_current->on_destroy = 0; 2969 frame->destroy = 0;
2648 2970
2649 if (acquire) 2971 if (acquire)
2650 SvIVX (count_sv) = SvIVX (count_sv) - 1; 2972 SvIVX (count_sv) = SvIVX (count_sv) - 1;
2651 else 2973 else
2652 coro_semaphore_adjust (aTHX_ av, 0); 2974 coro_semaphore_adjust (aTHX_ av, 0);
… …
2657 { 2979 {
2658 int i; 2980 int i;
2659 /* if we were woken up but can't down, we look through the whole */ 2981 /* if we were woken up but can't down, we look through the whole */
2660 /* waiters list and only add us if we aren't in there already */ 2982 /* waiters list and only add us if we aren't in there already */
2661 /* this avoids some degenerate memory usage cases */ 2983 /* this avoids some degenerate memory usage cases */
2662 2984 for (i = AvFILLp (av); i > 0; --i) /* i > 0 is not an off-by-one bug */
2663 for (i = 1; i <= AvFILLp (av); ++i)
2664 if (AvARRAY (av)[i] == SvRV (coro_current)) 2985 if (AvARRAY (av)[i] == coro_hv)
2665 return 1; 2986 return 1;
2666 2987
2667 av_push (av, SvREFCNT_inc (SvRV (coro_current))); 2988 av_push (av, SvREFCNT_inc (coro_hv));
2668 return 1; 2989 return 1;
2669 } 2990 }
2670} 2991}
2671 2992
2672static int 2993static int
… …
2695 { 3016 {
2696 av_push (av, SvREFCNT_inc (SvRV (coro_current))); 3017 av_push (av, SvREFCNT_inc (SvRV (coro_current)));
2697 3018
2698 frame->data = (void *)sv_2mortal (SvREFCNT_inc ((SV *)av)); 3019 frame->data = (void *)sv_2mortal (SvREFCNT_inc ((SV *)av));
2699 frame->prepare = prepare_schedule; 3020 frame->prepare = prepare_schedule;
2700
2701 /* to avoid race conditions when a woken-up coro gets terminated */ 3021 /* to avoid race conditions when a woken-up coro gets terminated */
2702 /* we arrange for a temporary on_destroy that calls adjust (0) */ 3022 /* we arrange for a temporary on_destroy that calls adjust (0) */
2703 SvSTATE_current->on_destroy = coro_semaphore_on_destroy; 3023 frame->destroy = coro_semaphore_destroy;
2704 } 3024 }
2705} 3025}
2706 3026
2707static void 3027static void
2708slf_init_semaphore_down (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items) 3028slf_init_semaphore_down (pTHX_ struct CoroSLF *frame, CV *cv, SV **arg, int items)
… …
2790 { 3110 {
2791 SV *cb_cv = s_get_cv_croak (arg [1]); 3111 SV *cb_cv = s_get_cv_croak (arg [1]);
2792 av_push (av, SvREFCNT_inc_NN (cb_cv)); 3112 av_push (av, SvREFCNT_inc_NN (cb_cv));
2793 3113
2794 if (SvIVX (AvARRAY (av)[0])) 3114 if (SvIVX (AvARRAY (av)[0]))
2795 coro_signal_wake (aTHX_ av, 1); /* ust be the only waiter */ 3115 coro_signal_wake (aTHX_ av, 1); /* must be the only waiter */
2796 3116
2797 frame->prepare = prepare_nop; 3117 frame->prepare = prepare_nop;
2798 frame->check = slf_check_nop; 3118 frame->check = slf_check_nop;
2799 } 3119 }
2800 else if (SvIVX (AvARRAY (av)[0])) 3120 else if (SvIVX (AvARRAY (av)[0]))
… …
2926 dSP; 3246 dSP;
2927 3247
2928 static SV *prio_cv; 3248 static SV *prio_cv;
2929 static SV *prio_sv; 3249 static SV *prio_sv;
2930 3250
2931 if (expect_false (!prio_cv)) 3251 if (ecb_expect_false (!prio_cv))
2932 { 3252 {
2933 prio_cv = (SV *)get_cv ("IO::AIO::aioreq_pri", 0); 3253 prio_cv = (SV *)get_cv ("IO::AIO::aioreq_pri", 0);
2934 prio_sv = newSViv (0); 3254 prio_sv = newSViv (0);
2935 } 3255 }
2936 3256
… …
2962 /* now call the AIO function - we assume our request is uncancelable */ 3282 /* now call the AIO function - we assume our request is uncancelable */
2963 PUTBACK; 3283 PUTBACK;
2964 call_sv ((SV *)req, G_VOID | G_DISCARD); 3284 call_sv ((SV *)req, G_VOID | G_DISCARD);
2965 } 3285 }
2966 3286
2967 /* now that the requets is going, we loop toll we have a result */ 3287 /* now that the request is going, we loop till we have a result */
2968 frame->data = (void *)state; 3288 frame->data = (void *)state;
2969 frame->prepare = prepare_schedule; 3289 frame->prepare = prepare_schedule;
2970 frame->check = slf_check_aio_req; 3290 frame->check = slf_check_aio_req;
2971} 3291}
2972 3292
… …
3042 } 3362 }
3043 3363
3044 return coro_sv; 3364 return coro_sv;
3045} 3365}
3046 3366
3367#ifndef __cplusplus
3368ecb_cold XS(boot_Coro__State);
3369#endif
3370
3371#if CORO_JIT
3372
3373static void ecb_noinline ecb_cold
3374pushav_4uv (pTHX_ UV a, UV b, UV c, UV d)
3375{
3376 dSP;
3377 AV *av = newAV ();
3378
3379 av_store (av, 3, newSVuv (d));
3380 av_store (av, 2, newSVuv (c));
3381 av_store (av, 1, newSVuv (b));
3382 av_store (av, 0, newSVuv (a));
3383
3384 XPUSHs (sv_2mortal (newRV_noinc ((SV *)av)));
3385
3386 PUTBACK;
3387}
3388
3389static void ecb_noinline ecb_cold
3390jit_init (pTHX)
3391{
3392 dSP;
3393 SV *load, *save;
3394 char *map_base;
3395 char *load_ptr, *save_ptr;
3396 STRLEN load_len, save_len, map_len;
3397 int count;
3398
3399 eval_pv ("require 'Coro/jit-" CORO_JIT_TYPE ".pl'", 1);
3400
3401 PUSHMARK (SP);
3402 #define VARx(name,expr,type) pushav_4uv (aTHX_ (UV)&(expr), sizeof (expr), offsetof (perl_slots, name), sizeof (type));
3403 #include "state.h"
3404 count = call_pv ("Coro::State::_jit", G_ARRAY);
3405 SPAGAIN;
3406
3407 save = POPs; save_ptr = SvPVbyte (save, save_len);
3408 load = POPs; load_ptr = SvPVbyte (load, load_len);
3409
3410 map_len = load_len + save_len + 16;
3411
3412 map_base = mmap (0, map_len, PROT_READ | PROT_WRITE | PROT_EXEC, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
3413
3414 assert (("Coro: unable to mmap jit code page, cannot continue.", map_base != (char *)MAP_FAILED));
3415
3416 load_perl_slots = (load_save_perl_slots_type)map_base;
3417 memcpy (map_base, load_ptr, load_len);
3418
3419 map_base += (load_len + 15) & ~15;
3420
3421 save_perl_slots = (load_save_perl_slots_type)map_base;
3422 memcpy (map_base, save_ptr, save_len);
3423
3424 /* we are good citizens and try to make the page read-only, so the evil evil */
3425 /* hackers might have it a bit more difficult */
3426 mprotect (map_base, map_len, PROT_READ | PROT_EXEC);
3427
3428 PUTBACK;
3429 eval_pv ("undef &Coro::State::_jit", 1);
3430}
3431
3432#endif
3433
3047MODULE = Coro::State PACKAGE = Coro::State PREFIX = api_ 3434MODULE = Coro::State PACKAGE = Coro::State PREFIX = api_
3048 3435
3049PROTOTYPES: DISABLE 3436PROTOTYPES: DISABLE
3050 3437
3051BOOT: 3438BOOT:
… …
3054# if CORO_PTHREAD 3441# if CORO_PTHREAD
3055 coro_thx = PERL_GET_CONTEXT; 3442 coro_thx = PERL_GET_CONTEXT;
3056# endif 3443# endif
3057#endif 3444#endif
3058 BOOT_PAGESIZE; 3445 BOOT_PAGESIZE;
3446
3447 /* perl defines these to check for existance first, but why it doesn't */
3448 /* just create them one at init time is not clear to me, except for */
3449 /* programs trying to delete them, but... */
3450 /* anyway, we declare this as invalid and make sure they are initialised here */
3451 DEFSV;
3452 ERRSV;
3059 3453
3060 cctx_current = cctx_new_empty (); 3454 cctx_current = cctx_new_empty ();
3061 3455
3062 irsgv = gv_fetchpv ("/" , GV_ADD|GV_NOTQUAL, SVt_PV); 3456 irsgv = gv_fetchpv ("/" , GV_ADD|GV_NOTQUAL, SVt_PV);
3063 stdoutgv = gv_fetchpv ("STDOUT", GV_ADD|GV_NOTQUAL, SVt_PVIO); 3457 stdoutgv = gv_fetchpv ("STDOUT", GV_ADD|GV_NOTQUAL, SVt_PVIO);
… …
3103 coroapi.prepare_nop = prepare_nop; 3497 coroapi.prepare_nop = prepare_nop;
3104 coroapi.prepare_schedule = prepare_schedule; 3498 coroapi.prepare_schedule = prepare_schedule;
3105 coroapi.prepare_cede = prepare_cede; 3499 coroapi.prepare_cede = prepare_cede;
3106 coroapi.prepare_cede_notself = prepare_cede_notself; 3500 coroapi.prepare_cede_notself = prepare_cede_notself;
3107 3501
3108 { 3502 time_init (aTHX);
3109 SV **svp = hv_fetch (PL_modglobal, "Time::NVtime", 12, 0);
3110
3111 if (!svp) croak ("Time::HiRes is required");
3112 if (!SvIOK (*svp)) croak ("Time::NVtime isn't a function pointer");
3113
3114 nvtime = INT2PTR (double (*)(), SvIV (*svp));
3115
3116 svp = hv_fetch (PL_modglobal, "Time::U2time", 12, 0);
3117 u2time = INT2PTR (void (*)(pTHX_ UV ret[2]), SvIV (*svp));
3118 }
3119 3503
3120 assert (("PRIO_NORMAL must be 0", !CORO_PRIO_NORMAL)); 3504 assert (("PRIO_NORMAL must be 0", !CORO_PRIO_NORMAL));
3505#if CORO_JIT
3506 PUTBACK;
3507 jit_init (aTHX);
3508 SPAGAIN;
3509#endif
3121} 3510}
3122 3511
3123SV * 3512SV *
3124new (SV *klass, ...) 3513new (SV *klass, ...)
3125 ALIAS: 3514 ALIAS:
… …
3132void 3521void
3133transfer (...) 3522transfer (...)
3134 PROTOTYPE: $$ 3523 PROTOTYPE: $$
3135 CODE: 3524 CODE:
3136 CORO_EXECUTE_SLF_XS (slf_init_transfer); 3525 CORO_EXECUTE_SLF_XS (slf_init_transfer);
3137
3138bool
3139_destroy (SV *coro_sv)
3140 CODE:
3141 RETVAL = coro_state_destroy (aTHX_ SvSTATE (coro_sv));
3142 OUTPUT:
3143 RETVAL
3144 3526
3145void 3527void
3146_exit (int code) 3528_exit (int code)
3147 PROTOTYPE: $ 3529 PROTOTYPE: $
3148 CODE: 3530 CODE:
… …
3224 CODE: 3606 CODE:
3225{ 3607{
3226 if (coro->mainstack && ((coro->flags & CF_RUNNING) || coro->slot)) 3608 if (coro->mainstack && ((coro->flags & CF_RUNNING) || coro->slot))
3227 { 3609 {
3228 struct coro *current = SvSTATE_current; 3610 struct coro *current = SvSTATE_current;
3611 struct CoroSLF slf_save;
3229 3612
3230 if (current != coro) 3613 if (current != coro)
3231 { 3614 {
3232 PUTBACK; 3615 PUTBACK;
3233 save_perl (aTHX_ current); 3616 save_perl (aTHX_ current);
3234 load_perl (aTHX_ coro); 3617 load_perl (aTHX_ coro);
3618 /* the coro is most likely in an active SLF call.
3619 * while not strictly required (the code we execute is
3620 * not allowed to call any SLF functions), it's cleaner
3621 * to reinitialise the slf_frame and restore it later.
3622 * This might one day allow us to actually do SLF calls
3623 * from code executed here.
3624 */
3625 slf_save = slf_frame;
3626 slf_frame.prepare = 0;
3235 SPAGAIN; 3627 SPAGAIN;
3236 } 3628 }
3237 3629
3238 PUSHSTACK; 3630 PUSHSTACK;
3239 3631
… …
3249 SPAGAIN; 3641 SPAGAIN;
3250 3642
3251 if (current != coro) 3643 if (current != coro)
3252 { 3644 {
3253 PUTBACK; 3645 PUTBACK;
3646 slf_frame = slf_save;
3254 save_perl (aTHX_ coro); 3647 save_perl (aTHX_ coro);
3255 load_perl (aTHX_ current); 3648 load_perl (aTHX_ current);
3256 SPAGAIN; 3649 SPAGAIN;
3257 } 3650 }
3258 } 3651 }
… …
3263 PROTOTYPE: $ 3656 PROTOTYPE: $
3264 ALIAS: 3657 ALIAS:
3265 is_ready = CF_READY 3658 is_ready = CF_READY
3266 is_running = CF_RUNNING 3659 is_running = CF_RUNNING
3267 is_new = CF_NEW 3660 is_new = CF_NEW
3268 is_destroyed = CF_DESTROYED 3661 is_destroyed = CF_ZOMBIE
3662 is_zombie = CF_ZOMBIE
3269 is_suspended = CF_SUSPENDED 3663 is_suspended = CF_SUSPENDED
3270 CODE: 3664 CODE:
3271 RETVAL = boolSV (coro->flags & ix); 3665 RETVAL = boolSV (coro->flags & ix);
3272 OUTPUT: 3666 OUTPUT:
3273 RETVAL 3667 RETVAL
3274 3668
3275void 3669void
3276throw (Coro::State self, SV *throw = &PL_sv_undef) 3670throw (SV *self, SV *exception = &PL_sv_undef)
3277 PROTOTYPE: $;$ 3671 PROTOTYPE: $;$
3278 CODE: 3672 CODE:
3279{ 3673{
3674 struct coro *coro = SvSTATE (self);
3280 struct coro *current = SvSTATE_current; 3675 struct coro *current = SvSTATE_current;
3281 SV **throwp = self == current ? &CORO_THROW : &self->except; 3676 SV **exceptionp = coro == current ? &CORO_THROW : &coro->except;
3282 SvREFCNT_dec (*throwp); 3677 SvREFCNT_dec (*exceptionp);
3283 SvGETMAGIC (throw); 3678 SvGETMAGIC (exception);
3284 *throwp = SvOK (throw) ? newSVsv (throw) : 0; 3679 *exceptionp = SvOK (exception) ? newSVsv (exception) : 0;
3680
3681 api_ready (aTHX_ self);
3285} 3682}
3286 3683
3287void 3684void
3288api_trace (SV *coro, int flags = CC_TRACE | CC_TRACE_SUB) 3685api_trace (SV *coro, int flags = CC_TRACE | CC_TRACE_SUB)
3289 PROTOTYPE: $;$ 3686 PROTOTYPE: $;$
… …
3344 3741
3345void 3742void
3346cancel (Coro::State self) 3743cancel (Coro::State self)
3347 CODE: 3744 CODE:
3348 coro_state_destroy (aTHX_ self); 3745 coro_state_destroy (aTHX_ self);
3349 coro_call_on_destroy (aTHX_ self); /* actually only for Coro objects */
3350
3351 3746
3352SV * 3747SV *
3353enable_times (int enabled = enable_times) 3748enable_times (int enabled = enable_times)
3354 CODE: 3749 CODE:
3355{ 3750{
… …
3370times (Coro::State self) 3765times (Coro::State self)
3371 PPCODE: 3766 PPCODE:
3372{ 3767{
3373 struct coro *current = SvSTATE (coro_current); 3768 struct coro *current = SvSTATE (coro_current);
3374 3769
3375 if (expect_false (current == self)) 3770 if (ecb_expect_false (current == self))
3376 { 3771 {
3377 coro_times_update (); 3772 coro_times_update ();
3378 coro_times_add (SvSTATE (coro_current)); 3773 coro_times_add (SvSTATE (coro_current));
3379 } 3774 }
3380 3775
3381 EXTEND (SP, 2); 3776 EXTEND (SP, 2);
3382 PUSHs (sv_2mortal (newSVnv (self->t_real [0] + self->t_real [1] * 1e-9))); 3777 PUSHs (sv_2mortal (newSVnv (self->t_real [0] + self->t_real [1] * 1e-9)));
3383 PUSHs (sv_2mortal (newSVnv (self->t_cpu [0] + self->t_cpu [1] * 1e-9))); 3778 PUSHs (sv_2mortal (newSVnv (self->t_cpu [0] + self->t_cpu [1] * 1e-9)));
3384 3779
3385 if (expect_false (current == self)) 3780 if (ecb_expect_false (current == self))
3386 coro_times_sub (SvSTATE (coro_current)); 3781 coro_times_sub (SvSTATE (coro_current));
3387} 3782}
3388 3783
3389void 3784void
3390swap_sv (Coro::State coro, SV *sv, SV *swapsv) 3785swap_sv (Coro::State coro, SV *sv, SV *swapsv)
… …
3411BOOT: 3806BOOT:
3412{ 3807{
3413 sv_pool_rss = coro_get_sv (aTHX_ "Coro::POOL_RSS" , TRUE); 3808 sv_pool_rss = coro_get_sv (aTHX_ "Coro::POOL_RSS" , TRUE);
3414 sv_pool_size = coro_get_sv (aTHX_ "Coro::POOL_SIZE" , TRUE); 3809 sv_pool_size = coro_get_sv (aTHX_ "Coro::POOL_SIZE" , TRUE);
3415 cv_coro_run = get_cv ( "Coro::_coro_run" , GV_ADD); 3810 cv_coro_run = get_cv ( "Coro::_coro_run" , GV_ADD);
3416 cv_coro_terminate = get_cv ( "Coro::terminate" , GV_ADD);
3417 coro_current = coro_get_sv (aTHX_ "Coro::current" , FALSE); SvREADONLY_on (coro_current); 3811 coro_current = coro_get_sv (aTHX_ "Coro::current" , FALSE); SvREADONLY_on (coro_current);
3418 av_async_pool = coro_get_av (aTHX_ "Coro::async_pool", TRUE); 3812 av_async_pool = coro_get_av (aTHX_ "Coro::async_pool", TRUE);
3419 av_destroy = coro_get_av (aTHX_ "Coro::destroy" , TRUE); 3813 av_destroy = coro_get_av (aTHX_ "Coro::destroy" , TRUE);
3420 sv_manager = coro_get_sv (aTHX_ "Coro::manager" , TRUE); 3814 sv_manager = coro_get_sv (aTHX_ "Coro::manager" , TRUE);
3421 sv_idle = coro_get_sv (aTHX_ "Coro::idle" , TRUE); 3815 sv_idle = coro_get_sv (aTHX_ "Coro::idle" , TRUE);
… …
3460 api_ready (aTHX_ RETVAL); 3854 api_ready (aTHX_ RETVAL);
3461 OUTPUT: 3855 OUTPUT:
3462 RETVAL 3856 RETVAL
3463 3857
3464void 3858void
3859_destroy (Coro::State coro)
3860 CODE:
3861 /* used by the manager thread */
3862 coro_state_destroy (aTHX_ coro);
3863
3864void
3865on_destroy (Coro::State coro, SV *cb)
3866 CODE:
3867 coro_push_on_destroy (aTHX_ coro, newSVsv (cb));
3868
3869void
3870join (...)
3871 CODE:
3872 CORO_EXECUTE_SLF_XS (slf_init_join);
3873
3874void
3465terminate (...) 3875terminate (...)
3466 CODE: 3876 CODE:
3467 CORO_EXECUTE_SLF_XS (slf_init_terminate); 3877 CORO_EXECUTE_SLF_XS (slf_init_terminate);
3878
3879void
3880cancel (...)
3881 CODE:
3882 CORO_EXECUTE_SLF_XS (slf_init_cancel);
3883
3884int
3885safe_cancel (Coro::State self, ...)
3886 C_ARGS: aTHX_ self, &ST (1), items - 1
3468 3887
3469void 3888void
3470schedule (...) 3889schedule (...)
3471 CODE: 3890 CODE:
3472 CORO_EXECUTE_SLF_XS (slf_init_schedule); 3891 CORO_EXECUTE_SLF_XS (slf_init_schedule);
… …
3748} 4167}
3749 4168
3750MODULE = Coro::State PACKAGE = Coro::SemaphoreSet 4169MODULE = Coro::State PACKAGE = Coro::SemaphoreSet
3751 4170
3752void 4171void
3753_may_delete (SV *sem, int count, int extra_refs) 4172_may_delete (SV *sem, int count, unsigned int extra_refs)
3754 PPCODE: 4173 PPCODE:
3755{ 4174{
3756 AV *av = (AV *)SvRV (sem); 4175 AV *av = (AV *)SvRV (sem);
3757 4176
3758 if (SvREFCNT ((SV *)av) == 1 + extra_refs 4177 if (SvREFCNT ((SV *)av) == 1 + extra_refs
… …
3869 { 4288 {
3870 PL_ppaddr [OP_SSELECT] = coro_old_pp_sselect; 4289 PL_ppaddr [OP_SSELECT] = coro_old_pp_sselect;
3871 coro_old_pp_sselect = 0; 4290 coro_old_pp_sselect = 0;
3872 } 4291 }
3873 4292
3874

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines