[ViewVC] Diff of: cvs/Coro/Coro/State.xs

Comparing Coro/Coro/State.xs (file contents):
Revision 1.430 by root, Wed Dec 19 23:36:16 2012 UTC vs.
Revision 1.462 by root, Wed Jun 22 20:24:38 2016 UTC

…		…
14	#include "perliol.h"	14	#include "perliol.h"
15		15
16	#include "schmorp.h"	16	#include "schmorp.h"
17		17
18	#define ECB_NO_THREADS 1	18	#define ECB_NO_THREADS 1
		19	#define ECB_NO_LIBM 1
19	#include "ecb.h"	20	#include "ecb.h"
20		21
21	#include <stddef.h>	22	#include <stddef.h>
22	#include <stdio.h>	23	#include <stdio.h>
23	#include <errno.h>	24	#include <errno.h>
24	#include <assert.h>	25	#include <assert.h>
25		26
		27	#ifndef SvREFCNT_dec_NN
		28	#define SvREFCNT_dec_NN(sv) SvREFCNT_dec (sv)
		29	#endif
		30
		31	#ifndef SvREFCNT_inc_NN
		32	#define SvREFCNT_inc_NN(sv) SvREFCNT_inc (sv)
		33	#endif
		34
26	#ifndef SVs_PADSTALE	35	#ifndef SVs_PADSTALE
27	# define SVs_PADSTALE 0	36	# define SVs_PADSTALE 0
28	#endif	37	#endif
29		38
30	#ifdef PadARRAY	39	#ifdef PadARRAY
31	# define NEWPADAPI	40	# define NEWPADAPI 1
32	# define newPADLIST(var) (Newz (0, var, 1, PADLIST), Newx (PadlistARRAY (var), 2, PAD *))	41	# define newPADLIST(var) (Newz (0, var, 1, PADLIST), Newx (PadlistARRAY (var), 2, PAD *))
33	#else	42	#else
34	typedef AV PADNAMELIST;	43	typedef AV PADNAMELIST;
35	# if !PERL_VERSION_ATLEAST(5,8,0)	44	# if !PERL_VERSION_ATLEAST(5,8,0)
36	typedef AV PADLIST;	45	typedef AV PADLIST;
…		…
41	# define PadlistNAMES(pl) (*PadlistARRAY (pl))	50	# define PadlistNAMES(pl) (*PadlistARRAY (pl))
42	# define PadARRAY AvARRAY	51	# define PadARRAY AvARRAY
43	# define PadMAX AvFILLp	52	# define PadMAX AvFILLp
44	# define newPADLIST(var) ((var) = newAV (), av_extend (var, 1))	53	# define newPADLIST(var) ((var) = newAV (), av_extend (var, 1))
45	#endif	54	#endif
		55	#ifndef PadnamelistREFCNT
		56	# define PadnamelistREFCNT(pnl) SvREFCNT (pnl)
		57	#endif
		58	#ifndef PadnamelistREFCNT_dec
		59	# define PadnamelistREFCNT_dec(pnl) SvREFCNT_dec (pnl)
		60	#endif
		61
		62	/* 5.19.something has replaced SVt_BIND by SVt_INVLIST */
		63	/* we just alias it to SVt_IV, as that is sufficient for swap_sv for now */
		64	#if PERL_VERSION_ATLEAST(5,19,0)
		65	# define SVt_BIND SVt_IV
		66	#endif
46		67
47	#if defined(_WIN32)	68	#if defined(_WIN32)
48	# undef HAS_GETTIMEOFDAY	69	# undef HAS_GETTIMEOFDAY
49	# undef setjmp	70	# undef setjmp
50	# undef longjmp	71	# undef longjmp
…		…
119		140
120	static GV irsgv; / $/ */	141	static GV irsgv; / $/ */
121	static GV stdoutgv; / STDOUT /	142	static GV stdoutgv; / STDOUT /
122	static SV *rv_diehook;	143	static SV *rv_diehook;
123	static SV *rv_warnhook;	144	static SV *rv_warnhook;
124	static HV hv_sig; / %SIG */
125		145
126	/* async_pool helper stuff */	146	/* async_pool helper stuff */
127	static SV *sv_pool_rss;	147	static SV *sv_pool_rss;
128	static SV *sv_pool_size;	148	static SV *sv_pool_size;
129	static SV sv_async_pool_idle; / description string */	149	static SV sv_async_pool_idle; / description string */
…		…
235	SV *saved_deffh;	255	SV *saved_deffh;
236	SV *invoke_cb;	256	SV *invoke_cb;
237	AV *invoke_av;	257	AV *invoke_av;
238		258
239	/* on_enter/on_leave */	259	/* on_enter/on_leave */
240	AV *on_enter;	260	AV on_enter; AV on_enter_xs;
241	AV *on_leave;	261	AV on_leave; AV on_leave_xs;
242		262
243	/* swap_sv */	263	/* swap_sv */
244	AV *swap_sv;	264	AV *swap_sv;
245		265
246	/* times */	266	/* times */
…		…
482		502
483	return 0;	503	return 0;
484	}	504	}
485		505
486	ecb_inline struct coro *	506	ecb_inline struct coro *
487	SvSTATE_ (pTHX_ SV *coro)	507	SvSTATE_ (pTHX_ SV *coro_sv)
488	{	508	{
489	MAGIC *mg;	509	MAGIC *mg;
490		510
491	if (SvROK (coro))	511	if (SvROK (coro_sv))
492	coro = SvRV (coro);	512	coro_sv = SvRV (coro_sv);
493		513
494	mg = SvSTATEhv_p (aTHX_ coro);	514	mg = SvSTATEhv_p (aTHX_ coro_sv);
495	if (!mg)	515	if (!mg)
496	croak ("Coro::State object required");	516	croak ("Coro::State object required");
497		517
498	return (struct coro *)mg->mg_ptr;	518	return (struct coro *)mg->mg_ptr;
499	}	519	}
…		…
510	ecb_inline PADLIST *	530	ecb_inline PADLIST *
511	coro_derive_padlist (pTHX_ CV *cv)	531	coro_derive_padlist (pTHX_ CV *cv)
512	{	532	{
513	PADLIST *padlist = CvPADLIST (cv);	533	PADLIST *padlist = CvPADLIST (cv);
514	PADLIST *newpadlist;	534	PADLIST *newpadlist;
		535	PADNAMELIST *padnames;
515	PAD *newpad;	536	PAD *newpad;
516	PADOFFSET const off = PadlistMAX (padlist) + 1;	537	PADOFFSET off = PadlistMAX (padlist) + 1;
517		538
518	newPADLIST(newpadlist);	539	#if NEWPADAPI
519	#if !PERL_VERSION_ATLEAST(5,15,3)	540
520	/* Padlists are AvREAL as of 5.15.3. See perl bug #98092 and perl commit 7d953ba. */	541	/* if we had the original CvDEPTH, we might be able to steal the CvDEPTH+1 entry instead */
521	AvREAL_off (newpadlist);	542	/* 20131102194744.GA6705@schmorp.de, 20131102195825.2013.qmail@lists-nntp.develooper.com */
522	#endif	543	while (!PadlistARRAY (padlist)[off - 1])
		544	--off;
		545
		546	Perl_pad_push (aTHX_ padlist, off);
		547
		548	newpad = PadlistARRAY (padlist)[off];
		549	PadlistARRAY (padlist)[off] = 0;
		550
		551	#else
		552
523	#if PERL_VERSION_ATLEAST (5,10,0)	553	#if PERL_VERSION_ATLEAST (5,10,0)
524	Perl_pad_push (aTHX_ padlist, off);	554	Perl_pad_push (aTHX_ padlist, off);
525	#else	555	#else
526	Perl_pad_push (aTHX_ padlist, off, 1);	556	Perl_pad_push (aTHX_ padlist, off, 1);
527	#endif	557	#endif
		558
528	newpad = PadlistARRAY (padlist)[off];	559	newpad = PadlistARRAY (padlist)[off];
529	PadlistMAX (padlist) = off - 1;	560	PadlistMAX (padlist) = off - 1;
530		561
		562	#endif
		563
		564	newPADLIST (newpadlist);
		565	#if !PERL_VERSION_ATLEAST(5,15,3)
		566	/* Padlists are AvREAL as of 5.15.3. See perl bug #98092 and perl commit 7d953ba. */
		567	AvREAL_off (newpadlist);
		568	#endif
		569
531	/* Already extended to 2 elements by newPADLIST. */	570	/* Already extended to 2 elements by newPADLIST. */
532	PadlistMAX (newpadlist) = 1;	571	PadlistMAX (newpadlist) = 1;
533	PadlistNAMES (newpadlist) = (PADNAMELIST *)SvREFCNT_inc_NN (PadlistNAMES (padlist));	572
		573	padnames = PadlistNAMES (padlist);
		574	++PadnamelistREFCNT (padnames);
		575	PadlistNAMES (newpadlist) = padnames;
		576
534	PadlistARRAY (newpadlist)[1] = newpad;	577	PadlistARRAY (newpadlist)[1] = newpad;
535		578
536	return newpadlist;	579	return newpadlist;
537	}	580	}
538		581
…		…
546		589
547	while (i > 0) /* special-case index 0 */	590	while (i > 0) /* special-case index 0 */
548	{	591	{
549	/* we try to be extra-careful here */	592	/* we try to be extra-careful here */
550	PAD *pad = PadlistARRAY (padlist)[i--];	593	PAD *pad = PadlistARRAY (padlist)[i--];
		594
		595	if (pad)
		596	{
551	I32 j = PadMAX (pad);	597	I32 j = PadMAX (pad);
552		598
553	while (j >= 0)	599	while (j >= 0)
554	SvREFCNT_dec (PadARRAY (pad)[j--]);	600	SvREFCNT_dec (PadARRAY (pad)[j--]);
555		601
556	PadMAX (pad) = -1;	602	PadMAX (pad) = -1;
557	SvREFCNT_dec (pad);	603	SvREFCNT_dec (pad);
		604	}
558	}	605	}
559		606
560	SvREFCNT_dec (PadlistNAMES (padlist));	607	PadnamelistREFCNT_dec (PadlistNAMES (padlist));
561		608
562	#ifdef NEWPADAPI	609	#if NEWPADAPI
563	Safefree (PadlistARRAY (padlist));	610	Safefree (PadlistARRAY (padlist));
564	Safefree (padlist);	611	Safefree (padlist);
565	#else	612	#else
566	AvFILLp (padlist) = -1;	613	AvFILLp (padlist) = -1;
567	AvREAL_off (padlist);	614	AvREAL_off (padlist);
…		…
661	tmp.sv_u = a->sv_u; a->sv_u = b->sv_u; b->sv_u = tmp.sv_u;	708	tmp.sv_u = a->sv_u; a->sv_u = b->sv_u; b->sv_u = tmp.sv_u;
662		709
663	/* if SvANY points to the head, we need to adjust the pointers,	710	/* if SvANY points to the head, we need to adjust the pointers,
664	* as the pointer for a still points to b, and maybe vice versa.	711	* as the pointer for a still points to b, and maybe vice versa.
665	*/	712	*/
666	#define svany_in_head(type) \	713	U32 svany_in_head_set = (1 << SVt_NULL) \| (1 << SVt_BIND) \| (1 << SVt_IV) \| (1 << SVt_RV);
667	(((1 << SVt_NULL) \| (1 << SVt_BIND) \| (1 << SVt_IV) \| (1 << SVt_RV)) & (1 << (type)))	714	#if NVSIZE <= IVSIZE && PERL_VERSION_ATLEAST(5,22,0)
		715	svany_in_head_set \|= 1 << SVt_NV;
		716	#endif
		717
		718	#define svany_in_head(type) (svany_in_head_set & (1 << (type)))
668		719
669	if (svany_in_head (SvTYPE (a)))	720	if (svany_in_head (SvTYPE (a)))
670	SvANY (a) = (void *)((PTRV)SvANY (a) - (PTRV)b + (PTRV)a);	721	SvANY (a) = (void *)((PTRV)SvANY (a) - (PTRV)b + (PTRV)a);
671		722
672	if (svany_in_head (SvTYPE (b)))	723	if (svany_in_head (SvTYPE (b)))
…		…
675	#endif	726	#endif
676	}	727	}
677		728
678	/* swap sv heads, at least logically */	729	/* swap sv heads, at least logically */
679	static void	730	static void
680	swap_svs (pTHX_ Coro__State c)	731	swap_svs_enter (pTHX_ Coro__State c)
681	{	732	{
682	int i;	733	int i;
683		734
684	for (i = 0; i <= AvFILLp (c->swap_sv); i += 2)	735	for (i = 0; i <= AvFILLp (c->swap_sv); i += 2)
685	swap_sv (AvARRAY (c->swap_sv)[i], AvARRAY (c->swap_sv)[i + 1]);	736	swap_sv (AvARRAY (c->swap_sv)[i], AvARRAY (c->swap_sv)[i + 1]);
686	}	737	}
687		738
		739	static void
		740	swap_svs_leave (pTHX_ Coro__State c)
		741	{
		742	int i;
		743
		744	for (i = AvFILLp (c->swap_sv) - 1; i >= 0; i -= 2)
		745	swap_sv (AvARRAY (c->swap_sv)[i], AvARRAY (c->swap_sv)[i + 1]);
		746	}
		747
688	#define SWAP_SVS(coro) \	748	#define SWAP_SVS_ENTER(coro) \
689	if (ecb_expect_false ((coro)->swap_sv)) \	749	if (ecb_expect_false ((coro)->swap_sv)) \
690	swap_svs (aTHX_ (coro))	750	swap_svs_enter (aTHX_ (coro))
		751
		752	#define SWAP_SVS_LEAVE(coro) \
		753	if (ecb_expect_false ((coro)->swap_sv)) \
		754	swap_svs_leave (aTHX_ (coro))
691		755
692	static void	756	static void
693	on_enterleave_call (pTHX_ SV *cb);	757	on_enterleave_call (pTHX_ SV *cb);
694		758
695	static void	759	static void
…		…
740		804
741	for (i = 0; i <= AvFILLp (c->on_enter); ++i)	805	for (i = 0; i <= AvFILLp (c->on_enter); ++i)
742	on_enterleave_call (aTHX_ AvARRAY (c->on_enter)[i]);	806	on_enterleave_call (aTHX_ AvARRAY (c->on_enter)[i]);
743	}	807	}
744		808
		809	if (ecb_expect_false (c->on_enter_xs))
		810	{
		811	int i;
		812
		813	for (i = 0; i <= AvFILLp (c->on_enter_xs); i += 2)
		814	((coro_enterleave_hook)AvARRAY (c->on_enter_xs)[i]) (aTHX_ AvARRAY (c->on_enter_xs)[i + 1]);
		815	}
		816
745	SWAP_SVS (c);	817	SWAP_SVS_ENTER (c);
746	}	818	}
747		819
748	static void	820	static void
749	save_perl (pTHX_ Coro__State c)	821	save_perl (pTHX_ Coro__State c)
750	{	822	{
751	SWAP_SVS (c);	823	SWAP_SVS_LEAVE (c);
		824
		825	if (ecb_expect_false (c->on_leave_xs))
		826	{
		827	int i;
		828
		829	for (i = AvFILLp (c->on_leave_xs) - 1; i >= 0; i -= 2)
		830	((coro_enterleave_hook)AvARRAY (c->on_leave_xs)[i]) (aTHX_ AvARRAY (c->on_leave_xs)[i + 1]);
		831	}
752		832
753	if (ecb_expect_false (c->on_leave))	833	if (ecb_expect_false (c->on_leave))
754	{	834	{
755	int i;	835	int i;
756		836
…		…
883	#endif	963	#endif
884		964
885	New(54,PL_savestack,24,ANY);	965	New(54,PL_savestack,24,ANY);
886	PL_savestack_ix = 0;	966	PL_savestack_ix = 0;
887	PL_savestack_max = 24;	967	PL_savestack_max = 24;
		968	#if !PERL_VERSION_ATLEAST (5,24,0)
		969	/* perl 5.24 moves SS_MAXPUSH optimisation from */
		970	/* the header macros to PL_savestack_max */
		971	PL_savestack_max -= SS_MAXPUSH;
		972	#endif
888		973
889	#if !PERL_VERSION_ATLEAST (5,10,0)	974	#if !PERL_VERSION_ATLEAST (5,10,0)
890	New(54,PL_retstack,4,OP*);	975	New(54,PL_retstack,4,OP*);
891	PL_retstack_ix = 0;	976	PL_retstack_ix = 0;
892	PL_retstack_max = 4;	977	PL_retstack_max = 4;
…		…
1109		1194
1110	GvSV (PL_defgv) = newSV (0);	1195	GvSV (PL_defgv) = newSV (0);
1111	GvAV (PL_defgv) = coro->args; coro->args = 0;	1196	GvAV (PL_defgv) = coro->args; coro->args = 0;
1112	GvSV (PL_errgv) = newSV (0);	1197	GvSV (PL_errgv) = newSV (0);
1113	GvSV (irsgv) = newSVpvn ("\n", 1); sv_magic (GvSV (irsgv), (SV *)irsgv, PERL_MAGIC_sv, "/", 0);	1198	GvSV (irsgv) = newSVpvn ("\n", 1); sv_magic (GvSV (irsgv), (SV *)irsgv, PERL_MAGIC_sv, "/", 0);
1114	GvHV (PL_hintgv) = 0;	1199	GvHV (PL_hintgv) = newHV ();
		1200	#if PERL_VERSION_ATLEAST (5,10,0)
		1201	hv_magic (GvHV (PL_hintgv), 0, PERL_MAGIC_hints);
		1202	#endif
1115	PL_rs = newSVsv (GvSV (irsgv));	1203	PL_rs = newSVsv (GvSV (irsgv));
1116	PL_defoutgv = (GV *)SvREFCNT_inc_NN (stdoutgv);	1204	PL_defoutgv = (GV *)SvREFCNT_inc_NN (stdoutgv);
1117		1205
1118	{	1206	{
1119	dSP;	1207	dSP;
…		…
1147	PL_op = (OP *)&init_perl_op;	1235	PL_op = (OP *)&init_perl_op;
1148		1236
1149	/* copy throw, in case it was set before init_perl */	1237	/* copy throw, in case it was set before init_perl */
1150	CORO_THROW = coro->except;	1238	CORO_THROW = coro->except;
1151		1239
1152	SWAP_SVS (coro);	1240	SWAP_SVS_ENTER (coro);
1153		1241
1154	if (ecb_expect_false (enable_times))	1242	if (ecb_expect_false (enable_times))
1155	{	1243	{
1156	coro_times_update ();	1244	coro_times_update ();
1157	coro_times_sub (coro);	1245	coro_times_sub (coro);
…		…
1195	/* this will cause transfer_check to croak on block*/	1283	/* this will cause transfer_check to croak on block*/
1196	SvRV_set (coro_current, (SV *)coro->hv);	1284	SvRV_set (coro_current, (SV *)coro->hv);
1197		1285
1198	load_perl (aTHX_ coro);	1286	load_perl (aTHX_ coro);
1199		1287
		1288	/* restore swapped sv's */
		1289	SWAP_SVS_LEAVE (coro);
		1290
1200	coro_unwind_stacks (aTHX);	1291	coro_unwind_stacks (aTHX);
1201
1202	/* restore swapped sv's */
1203	SWAP_SVS (coro);
1204		1292
1205	coro_destruct_stacks (aTHX);	1293	coro_destruct_stacks (aTHX);
1206		1294
1207	/* now save some sv's to be free'd later */	1295	/* now save some sv's to be free'd later */
1208	svf [0] = GvSV (PL_defgv);	1296	svf [0] = GvSV (PL_defgv);
…		…
1229		1317
1230	SvREFCNT_dec (coro->saved_deffh);	1318	SvREFCNT_dec (coro->saved_deffh);
1231	SvREFCNT_dec (coro->rouse_cb);	1319	SvREFCNT_dec (coro->rouse_cb);
1232	SvREFCNT_dec (coro->invoke_cb);	1320	SvREFCNT_dec (coro->invoke_cb);
1233	SvREFCNT_dec (coro->invoke_av);	1321	SvREFCNT_dec (coro->invoke_av);
		1322	SvREFCNT_dec (coro->on_enter_xs);
		1323	SvREFCNT_dec (coro->on_leave_xs);
1234	}	1324	}
1235	}	1325	}
1236		1326
1237	ecb_inline void	1327	ecb_inline void
1238	free_coro_mortal (pTHX)	1328	free_coro_mortal (pTHX)
…		…
1301		1391
1302	if (PL_curcop != &PL_compiling)	1392	if (PL_curcop != &PL_compiling)
1303	{	1393	{
1304	SV **cb;	1394	SV **cb;
1305		1395
1306	if (oldcxix != cxstack_ix && cctx_current->flags & CC_TRACE_SUB)	1396	if (oldcxix != cxstack_ix && cctx_current->flags & CC_TRACE_SUB && cxstack_ix >= 0)
1307	{	1397	{
1308	PERL_CONTEXT *cx = &cxstack[cxstack_ix];	1398	PERL_CONTEXT *cx = &cxstack[cxstack_ix];
1309		1399
1310	if (CxTYPE (cx) == CXt_SUB && oldcxix < cxstack_ix)	1400	if (CxTYPE (cx) == CXt_SUB && oldcxix < cxstack_ix)
1311	{	1401	{
…		…
1888	/* nothing to schedule: call the idle handler */	1978	/* nothing to schedule: call the idle handler */
1889	if (SvROK (sv_idle)	1979	if (SvROK (sv_idle)
1890	&& SvOBJECT (SvRV (sv_idle)))	1980	&& SvOBJECT (SvRV (sv_idle)))
1891	{	1981	{
1892	if (SvRV (sv_idle) == SvRV (coro_current))	1982	if (SvRV (sv_idle) == SvRV (coro_current))
		1983	{
		1984	require_pv ("Carp");
		1985
		1986	{
		1987	dSP;
		1988
		1989	ENTER;
		1990	SAVETMPS;
		1991
		1992	PUSHMARK (SP);
1893	croak ("FATAL: $Coro::IDLE blocked itself - did you try to block inside an event loop callback? Caught");	1993	XPUSHs (sv_2mortal (newSVpv ("FATAL: $Coro::idle blocked itself - did you try to block inside an event loop callback? Caught", 0)));
		1994	PUTBACK;
		1995	call_pv ("Carp::confess", G_VOID \| G_DISCARD);
		1996
		1997	FREETMPS;
		1998	LEAVE;
		1999	}
		2000	}
1894		2001
1895	++coro_nready; /* hack so that api_ready doesn't invoke ready hook */	2002	++coro_nready; /* hack so that api_ready doesn't invoke ready hook */
1896	api_ready (aTHX_ SvRV (sv_idle));	2003	api_ready (aTHX_ SvRV (sv_idle));
1897	--coro_nready;	2004	--coro_nready;
1898	}	2005	}
…		…
2096	AV *od = coro->on_destroy;	2203	AV *od = coro->on_destroy;
2097		2204
2098	if (!od)	2205	if (!od)
2099	return;	2206	return;
2100		2207
		2208	coro->on_destroy = 0;
		2209	sv_2mortal ((SV *)od);
		2210
2101	while (AvFILLp (od) >= 0)	2211	while (AvFILLp (od) >= 0)
2102	{	2212	{
2103	SV *cb = sv_2mortal (av_pop (od));	2213	SV *cb = sv_2mortal (av_pop (od));
2104		2214
2105	/* coro hv's (and only hv's at the moment) are supported as well */	2215	/* coro hv's (and only hv's at the moment) are supported as well */
…		…
2199	slf_init_terminate_cancel_common (aTHX_ frame, coro_hv);	2309	slf_init_terminate_cancel_common (aTHX_ frame, coro_hv);
2200	}	2310	}
2201	else	2311	else
2202	{	2312	{
2203	struct coro *self = SvSTATE_current;	2313	struct coro *self = SvSTATE_current;
		2314
		2315	if (!self)
		2316	croak ("Coro::cancel called outside of thread content,");
2204		2317
2205	/* otherwise we cancel directly, purely for speed reasons	2318	/* otherwise we cancel directly, purely for speed reasons
2206	* unfortunately, this requires some magic trickery, as	2319	* unfortunately, this requires some magic trickery, as
2207	* somebody else could cancel us, so we have to fight the cancellation.	2320	* somebody else could cancel us, so we have to fight the cancellation.
2208	* this is ugly, and hopefully fully worth the extra speed.	2321	* this is ugly, and hopefully fully worth the extra speed.
…		…
2318	else	2431	else
2319	{	2432	{
2320	av_clear (GvAV (PL_defgv));	2433	av_clear (GvAV (PL_defgv));
2321	hv_store (hv, "desc", sizeof ("desc") - 1, SvREFCNT_inc_NN (sv_async_pool_idle), 0);	2434	hv_store (hv, "desc", sizeof ("desc") - 1, SvREFCNT_inc_NN (sv_async_pool_idle), 0);
2322		2435
		2436	if (ecb_expect_false (coro->swap_sv))
		2437	{
		2438	swap_svs_leave (coro);
		2439	SvREFCNT_dec_NN (coro->swap_sv);
		2440	coro->swap_sv = 0;
		2441	}
		2442
2323	coro->prio = 0;	2443	coro->prio = 0;
2324		2444
2325	if (coro->cctx && (coro->cctx->flags & CC_TRACE))	2445	if (ecb_expect_false (coro->cctx) && ecb_expect_false (coro->cctx->flags & CC_TRACE))
2326	api_trace (aTHX_ coro_current, 0);	2446	api_trace (aTHX_ coro_current, 0);
2327		2447
2328	frame->prepare = prepare_schedule;	2448	frame->prepare = prepare_schedule;
2329	av_push (av_async_pool, SvREFCNT_inc (hv));	2449	av_push (av_async_pool, SvREFCNT_inc (hv));
2330	}	2450	}
…		…
2550		2670
2551	/* "undo"/cancel a running slf call - used when cancelling a coro, mainly */	2671	/* "undo"/cancel a running slf call - used when cancelling a coro, mainly */
2552	static void	2672	static void
2553	slf_destroy (pTHX_ struct coro *coro)	2673	slf_destroy (pTHX_ struct coro *coro)
2554	{	2674	{
2555	/* this callback is reserved for slf functions needing to do cleanup */	2675	struct CoroSLF frame = coro->slf_frame;
2556	if (coro->slf_frame.destroy && coro->slf_frame.prepare && !PL_dirty)
2557	coro->slf_frame.destroy (aTHX_ &coro->slf_frame);
2558		2676
2559	/*	2677	/*
2560	* The on_destroy above most likely is from an SLF call.	2678	* The on_destroy below most likely is from an SLF call.
2561	* Since by definition the SLF call will not finish when we destroy	2679	* Since by definition the SLF call will not finish when we destroy
2562	* the coro, we will have to force-finish it here, otherwise	2680	* the coro, we will have to force-finish it here, otherwise
2563	* cleanup functions cannot call SLF functions.	2681	* cleanup functions cannot call SLF functions.
2564	*/	2682	*/
2565	coro->slf_frame.prepare = 0;	2683	coro->slf_frame.prepare = 0;
		2684
		2685	/* this callback is reserved for slf functions needing to do cleanup */
		2686	if (frame.destroy && frame.prepare && !PL_dirty)
		2687	frame.destroy (aTHX_ &frame);
2566	}	2688	}
2567		2689
2568	/*	2690	/*
2569	* these not obviously related functions are all rolled into one	2691	* these not obviously related functions are all rolled into one
2570	* function to increase chances that they all will call transfer with the same	2692	* function to increase chances that they all will call transfer with the same
…		…
2753	static void	2875	static void
2754	coro_pop_on_leave (pTHX_ void *coro)	2876	coro_pop_on_leave (pTHX_ void *coro)
2755	{	2877	{
2756	SV cb = coro_avp_pop_and_free (aTHX_ &((struct coro )coro)->on_leave);	2878	SV cb = coro_avp_pop_and_free (aTHX_ &((struct coro )coro)->on_leave);
2757	on_enterleave_call (aTHX_ sv_2mortal (cb));	2879	on_enterleave_call (aTHX_ sv_2mortal (cb));
		2880	}
		2881
		2882	static void
		2883	enterleave_hook_xs (pTHX_ struct coro coro, AV avp, coro_enterleave_hook hook, void arg)
		2884	{
		2885	if (!hook)
		2886	return;
		2887
		2888	if (!*avp)
		2889	{
		2890	*avp = newAV ();
		2891	AvREAL_off (*avp);
		2892	}
		2893
		2894	av_push (avp, (SV )hook);
		2895	av_push (avp, (SV )arg);
		2896	}
		2897
		2898	static void
		2899	enterleave_unhook_xs (pTHX_ struct coro coro, AV *avp, coro_enterleave_hook hook, int execute)
		2900	{
		2901	AV av = avp;
		2902	int i;
		2903
		2904	if (!av)
		2905	return;
		2906
		2907	for (i = AvFILLp (av) - 1; i >= 0; i -= 2)
		2908	if (AvARRAY (av)[i] == (SV *)hook)
		2909	{
		2910	if (execute)
		2911	hook (aTHX_ (void *)AvARRAY (av)[i + 1]);
		2912
		2913	memmove (AvARRAY (av) + i, AvARRAY (av) + i + 2, AvFILLp (av) - i - 1);
		2914	av_pop (av);
		2915	av_pop (av);
		2916	break;
		2917	}
		2918
		2919	if (AvFILLp (av) >= 0)
		2920	{
		2921	*avp = 0;
		2922	SvREFCNT_dec_NN (av);
		2923	}
		2924	}
		2925
		2926	static void
		2927	api_enterleave_hook (pTHX_ SV coro_sv, coro_enterleave_hook enter, void enter_arg, coro_enterleave_hook leave, void *leave_arg)
		2928	{
		2929	struct coro *coro = SvSTATE (coro_sv);
		2930
		2931	if (SvSTATE_current == coro)
		2932	if (enter)
		2933	enter (aTHX_ enter_arg);
		2934
		2935	enterleave_hook_xs (aTHX_ coro, &coro->on_enter_xs, enter, enter_arg);
		2936	enterleave_hook_xs (aTHX_ coro, &coro->on_leave_xs, leave, leave_arg);
		2937	}
		2938
		2939	static void
		2940	api_enterleave_unhook (pTHX_ SV *coro_sv, coro_enterleave_hook enter, coro_enterleave_hook leave)
		2941	{
		2942	struct coro *coro = SvSTATE (coro_sv);
		2943
		2944	enterleave_unhook_xs (aTHX_ coro, &coro->on_enter_xs, enter, 0);
		2945	enterleave_unhook_xs (aTHX_ coro, &coro->on_leave_xs, leave, SvSTATE_current == coro);
		2946	}
		2947
		2948	static void
		2949	savedestructor_unhook_enter (pTHX_ coro_enterleave_hook enter)
		2950	{
		2951	struct coro *coro = SvSTATE_current;
		2952
		2953	enterleave_unhook_xs (aTHX_ coro, &coro->on_enter_xs, enter, 0);
		2954	}
		2955
		2956	static void
		2957	savedestructor_unhook_leave (pTHX_ coro_enterleave_hook leave)
		2958	{
		2959	struct coro *coro = SvSTATE_current;
		2960
		2961	enterleave_unhook_xs (aTHX_ coro, &coro->on_leave_xs, leave, 1);
		2962	}
		2963
		2964	static void
		2965	api_enterleave_scope_hook (pTHX_ coro_enterleave_hook enter, void enter_arg, coro_enterleave_hook leave, void leave_arg)
		2966	{
		2967	api_enterleave_hook (aTHX_ coro_current, enter, enter_arg, leave, leave_arg);
		2968
		2969	/* this ought to be much cheaper than malloc + a single destructor call */
		2970	if (enter) SAVEDESTRUCTOR_X (savedestructor_unhook_enter, enter);
		2971	if (leave) SAVEDESTRUCTOR_X (savedestructor_unhook_leave, leave);
2758	}	2972	}
2759		2973
2760	/*****************************************************************************/	2974	/*****************************************************************************/
2761	/* PerlIO::cede */	2975	/* PerlIO::cede */
2762		2976
…		…
2892	XPUSHs (sv_2mortal (newRV_inc ((SV *)av)));	3106	XPUSHs (sv_2mortal (newRV_inc ((SV *)av)));
2893	PUTBACK;	3107	PUTBACK;
2894	call_sv (cb, G_VOID \| G_DISCARD \| G_EVAL \| G_KEEPERR);	3108	call_sv (cb, G_VOID \| G_DISCARD \| G_EVAL \| G_KEEPERR);
2895	}	3109	}
2896		3110
2897	SvREFCNT_dec (cb);	3111	SvREFCNT_dec_NN (cb);
2898	}	3112	}
2899	}	3113	}
2900		3114
2901	static void	3115	static void
2902	coro_semaphore_destroy (pTHX_ struct CoroSLF *frame)	3116	coro_semaphore_destroy (pTHX_ struct CoroSLF *frame)
…		…
2910	{	3124	{
2911	AV av = (AV )frame->data;	3125	AV av = (AV )frame->data;
2912	SV *count_sv = AvARRAY (av)[0];	3126	SV *count_sv = AvARRAY (av)[0];
2913	SV *coro_hv = SvRV (coro_current);	3127	SV *coro_hv = SvRV (coro_current);
2914		3128
		3129	frame->destroy = 0;
		3130
2915	/* if we are about to throw, don't actually acquire the lock, just throw */	3131	/* if we are about to throw, don't actually acquire the lock, just throw */
2916	if (CORO_THROW)	3132	if (ecb_expect_false (CORO_THROW))
		3133	{
		3134	/* we still might be responsible for the semaphore, so wake up others */
		3135	coro_semaphore_adjust (aTHX_ av, 0);
		3136
2917	return 0;	3137	return 0;
		3138	}
2918	else if (SvIVX (count_sv) > 0)	3139	else if (SvIVX (count_sv) > 0)
2919	{	3140	{
2920	frame->destroy = 0;
2921
2922	if (acquire)	3141	if (acquire)
2923	SvIVX (count_sv) = SvIVX (count_sv) - 1;	3142	SvIVX (count_sv) = SvIVX (count_sv) - 1;
2924	else	3143	else
2925	coro_semaphore_adjust (aTHX_ av, 0);	3144	coro_semaphore_adjust (aTHX_ av, 0);
2926		3145
…		…
3037	{	3256	{
3038	api_ready (aTHX_ cb);	3257	api_ready (aTHX_ cb);
3039	sv_setiv (cb, 0); /* signal waiter */	3258	sv_setiv (cb, 0); /* signal waiter */
3040	}	3259	}
3041		3260
3042	SvREFCNT_dec (cb);	3261	SvREFCNT_dec_NN (cb);
3043		3262
3044	--count;	3263	--count;
3045	}	3264	}
3046	}	3265	}
3047		3266
…		…
3132	}	3351	}
3133		3352
3134	av_push (state, data_sv);	3353	av_push (state, data_sv);
3135		3354
3136	api_ready (aTHX_ coro);	3355	api_ready (aTHX_ coro);
3137	SvREFCNT_dec (coro);	3356	SvREFCNT_dec_NN (coro);
3138	SvREFCNT_dec ((AV *)state);	3357	SvREFCNT_dec_NN ((AV *)state);
3139	}	3358	}
3140		3359
3141	static int	3360	static int
3142	slf_check_aio_req (pTHX_ struct CoroSLF *frame)	3361	slf_check_aio_req (pTHX_ struct CoroSLF *frame)
3143	{	3362	{
…		…
3148	/* it quickly returns */	3367	/* it quickly returns */
3149	if (CORO_THROW)	3368	if (CORO_THROW)
3150	return 0;	3369	return 0;
3151		3370
3152	/* one element that is an RV? repeat! */	3371	/* one element that is an RV? repeat! */
3153	if (AvFILLp (state) == 0 && SvROK (AvARRAY (state)[0]))	3372	if (AvFILLp (state) == 0 && SvTYPE (AvARRAY (state)[0]) != SVt_PV)
3154	return 1;	3373	return 1;
3155		3374
3156	/* restore status */	3375	/* restore status */
3157	{	3376	{
3158	SV *data_sv = av_pop (state);	3377	SV *data_sv = av_pop (state);
…		…
3161	errno = data->errorno;	3380	errno = data->errorno;
3162	PL_laststype = data->laststype;	3381	PL_laststype = data->laststype;
3163	PL_laststatval = data->laststatval;	3382	PL_laststatval = data->laststatval;
3164	PL_statcache = data->statcache;	3383	PL_statcache = data->statcache;
3165		3384
3166	SvREFCNT_dec (data_sv);	3385	SvREFCNT_dec_NN (data_sv);
3167	}	3386	}
3168		3387
3169	/* push result values */	3388	/* push result values */
3170	{	3389	{
3171	dSP;	3390	dSP;
…		…
3386		3605
3387	PROTOTYPES: DISABLE	3606	PROTOTYPES: DISABLE
3388		3607
3389	BOOT:	3608	BOOT:
3390	{	3609	{
		3610	#define VARx(name,expr,type) if (sizeof (type) < sizeof (expr)) croak ("FATAL: Coro thread context slot '" # name "' too small for this version of perl.");
		3611	#include "state.h"
3391	#ifdef USE_ITHREADS	3612	#ifdef USE_ITHREADS
3392	# if CORO_PTHREAD	3613	# if CORO_PTHREAD
3393	coro_thx = PERL_GET_CONTEXT;	3614	coro_thx = PERL_GET_CONTEXT;
3394	# endif	3615	# endif
3395	#endif	3616	#endif
…		…
3407		3628
3408	orig_sigelem_get = PL_vtbl_sigelem.svt_get; PL_vtbl_sigelem.svt_get = coro_sigelem_get;	3629	orig_sigelem_get = PL_vtbl_sigelem.svt_get; PL_vtbl_sigelem.svt_get = coro_sigelem_get;
3409	orig_sigelem_set = PL_vtbl_sigelem.svt_set; PL_vtbl_sigelem.svt_set = coro_sigelem_set;	3630	orig_sigelem_set = PL_vtbl_sigelem.svt_set; PL_vtbl_sigelem.svt_set = coro_sigelem_set;
3410	orig_sigelem_clr = PL_vtbl_sigelem.svt_clear; PL_vtbl_sigelem.svt_clear = coro_sigelem_clr;	3631	orig_sigelem_clr = PL_vtbl_sigelem.svt_clear; PL_vtbl_sigelem.svt_clear = coro_sigelem_clr;
3411		3632
3412	hv_sig = coro_get_hv (aTHX_ "SIG", TRUE);
3413	rv_diehook = newRV_inc ((SV *)gv_fetchpv ("Coro::State::diehook" , 0, SVt_PVCV));	3633	rv_diehook = newRV_inc ((SV *)gv_fetchpv ("Coro::State::diehook" , 0, SVt_PVCV));
3414	rv_warnhook = newRV_inc ((SV *)gv_fetchpv ("Coro::State::warnhook", 0, SVt_PVCV));	3634	rv_warnhook = newRV_inc ((SV *)gv_fetchpv ("Coro::State::warnhook", 0, SVt_PVCV));
3415		3635
3416	coro_state_stash = gv_stashpv ("Coro::State", TRUE);	3636	coro_state_stash = gv_stashpv ("Coro::State", TRUE);
3417		3637
…		…
3470	void	3690	void
3471	transfer (...)	3691	transfer (...)
3472	PROTOTYPE: $$	3692	PROTOTYPE: $$
3473	CODE:	3693	CODE:
3474	CORO_EXECUTE_SLF_XS (slf_init_transfer);	3694	CORO_EXECUTE_SLF_XS (slf_init_transfer);
3475
3476	void
3477	_exit (int code)
3478	PROTOTYPE: $
3479	CODE:
3480	_exit (code);
3481		3695
3482	SV *	3696	SV *
3483	clone (Coro::State coro)	3697	clone (Coro::State coro)
3484	CODE:	3698	CODE:
3485	{	3699	{
…		…
3729	if (ecb_expect_false (current == self))	3943	if (ecb_expect_false (current == self))
3730	coro_times_sub (SvSTATE (coro_current));	3944	coro_times_sub (SvSTATE (coro_current));
3731	}	3945	}
3732		3946
3733	void	3947	void
3734	swap_sv (Coro::State coro, SV sv, SV swapsv)	3948	swap_sv (Coro::State coro, SV sva, SV svb)
3735	CODE:	3949	CODE:
3736	{	3950	{
3737	struct coro *current = SvSTATE_current;	3951	struct coro *current = SvSTATE_current;
		3952	AV *swap_sv;
		3953	int i;
		3954
		3955	sva = SvRV (sva);
		3956	svb = SvRV (svb);
3738		3957
3739	if (current == coro)	3958	if (current == coro)
3740	SWAP_SVS (current);	3959	SWAP_SVS_LEAVE (current);
3741		3960
3742	if (!coro->swap_sv)	3961	if (!coro->swap_sv)
3743	coro->swap_sv = newAV ();	3962	coro->swap_sv = newAV ();
3744		3963
		3964	swap_sv = coro->swap_sv;
		3965
		3966	for (i = AvFILLp (swap_sv) - 1; i >= 0; i -= 2)
		3967	{
		3968	SV *a = AvARRAY (swap_sv)[i ];
		3969	SV *b = AvARRAY (swap_sv)[i + 1];
		3970
		3971	if (a == sva && b == svb)
		3972	{
		3973	SvREFCNT_dec_NN (a);
		3974	SvREFCNT_dec_NN (b);
		3975
		3976	for (; i <= AvFILLp (swap_sv) - 2; i++)
		3977	AvARRAY (swap_sv)[i] = AvARRAY (swap_sv)[i + 2];
		3978
		3979	AvFILLp (swap_sv) -= 2;
		3980
		3981	goto removed;
		3982	}
		3983	}
		3984
3745	av_push (coro->swap_sv, SvREFCNT_inc_NN (SvRV (sv )));	3985	av_push (swap_sv, SvREFCNT_inc_NN (sva));
3746	av_push (coro->swap_sv, SvREFCNT_inc_NN (SvRV (swapsv)));	3986	av_push (swap_sv, SvREFCNT_inc_NN (svb));
		3987
		3988	removed:
3747		3989
3748	if (current == coro)	3990	if (current == coro)
3749	SWAP_SVS (current);	3991	SWAP_SVS_ENTER (current);
3750	}	3992	}
3751		3993
3752		3994
3753	MODULE = Coro::State PACKAGE = Coro	3995	MODULE = Coro::State PACKAGE = Coro
3754		3996
3755	BOOT:	3997	BOOT:
3756	{	3998	{
		3999	if (SVt_LAST > 32)
		4000	croak ("Coro internal error: SVt_LAST > 32, swap_sv might need adjustment");
		4001
3757	sv_pool_rss = coro_get_sv (aTHX_ "Coro::POOL_RSS" , TRUE);	4002	sv_pool_rss = coro_get_sv (aTHX_ "Coro::POOL_RSS" , TRUE);
3758	sv_pool_size = coro_get_sv (aTHX_ "Coro::POOL_SIZE" , TRUE);	4003	sv_pool_size = coro_get_sv (aTHX_ "Coro::POOL_SIZE" , TRUE);
3759	cv_coro_run = get_cv ( "Coro::_coro_run" , GV_ADD);	4004	cv_coro_run = get_cv ( "Coro::_coro_run" , GV_ADD);
3760	coro_current = coro_get_sv (aTHX_ "Coro::current" , FALSE); SvREADONLY_on (coro_current);	4005	coro_current = coro_get_sv (aTHX_ "Coro::current" , FALSE); SvREADONLY_on (coro_current);
3761	av_async_pool = coro_get_av (aTHX_ "Coro::async_pool", TRUE);	4006	av_async_pool = coro_get_av (aTHX_ "Coro::async_pool", TRUE);
…		…
3787	coroapi.ready = api_ready;	4032	coroapi.ready = api_ready;
3788	coroapi.is_ready = api_is_ready;	4033	coroapi.is_ready = api_is_ready;
3789	coroapi.nready = coro_nready;	4034	coroapi.nready = coro_nready;
3790	coroapi.current = coro_current;	4035	coroapi.current = coro_current;
3791		4036
		4037	coroapi.enterleave_hook = api_enterleave_hook;
		4038	coroapi.enterleave_unhook = api_enterleave_unhook;
		4039	coroapi.enterleave_scope_hook = api_enterleave_scope_hook;
		4040
3792	/GCoroAPI = &coroapi;/	4041	/GCoroAPI = &coroapi;/
3793	sv_setiv (sv, (IV)&coroapi);	4042	sv_setiv (sv, (IV)&coroapi);
3794	SvREADONLY_on (sv);	4043	SvREADONLY_on (sv);
3795	}	4044	}
3796	}	4045	}
…		…
3861		4110
3862	void	4111	void
3863	_set_current (SV *current)	4112	_set_current (SV *current)
3864	PROTOTYPE: $	4113	PROTOTYPE: $
3865	CODE:	4114	CODE:
3866	SvREFCNT_dec (SvRV (coro_current));	4115	SvREFCNT_dec_NN (SvRV (coro_current));
3867	SvRV_set (coro_current, SvREFCNT_inc_NN (SvRV (current)));	4116	SvRV_set (coro_current, SvREFCNT_inc_NN (SvRV (current)));
3868		4117
3869	void	4118	void
3870	_set_readyhook (SV *hook)	4119	_set_readyhook (SV *hook)
3871	PROTOTYPE: $	4120	PROTOTYPE: $
…		…
3955		4204
3956	if ((SV *)hv == &PL_sv_undef)	4205	if ((SV *)hv == &PL_sv_undef)
3957	{	4206	{
3958	SV sv = coro_new (aTHX_ coro_stash, (SV *)&cv_pool_handler, 1, 1);	4207	SV sv = coro_new (aTHX_ coro_stash, (SV *)&cv_pool_handler, 1, 1);
3959	hv = (HV *)SvREFCNT_inc_NN (SvRV (sv));	4208	hv = (HV *)SvREFCNT_inc_NN (SvRV (sv));
3960	SvREFCNT_dec (sv);	4209	SvREFCNT_dec_NN (sv);
3961	}	4210	}
3962		4211
3963	{	4212	{
3964	struct coro *coro = SvSTATE_hv (hv);	4213	struct coro *coro = SvSTATE_hv (hv);
3965		4214
…		…
3972	api_ready (aTHX_ (SV *)hv);	4221	api_ready (aTHX_ (SV *)hv);
3973		4222
3974	if (GIMME_V != G_VOID)	4223	if (GIMME_V != G_VOID)
3975	XPUSHs (sv_2mortal (newRV_noinc ((SV *)hv)));	4224	XPUSHs (sv_2mortal (newRV_noinc ((SV *)hv)));
3976	else	4225	else
3977	SvREFCNT_dec (hv);	4226	SvREFCNT_dec_NN (hv);
3978	}	4227	}
3979		4228
3980	SV *	4229	SV *
3981	rouse_cb ()	4230	rouse_cb ()
3982	PROTOTYPE:	4231	PROTOTYPE:
…		…
4061	RETVAL = newSVsv (AvARRAY ((AV *)SvRV (self))[0]);	4310	RETVAL = newSVsv (AvARRAY ((AV *)SvRV (self))[0]);
4062	OUTPUT:	4311	OUTPUT:
4063	RETVAL	4312	RETVAL
4064		4313
4065	void	4314	void
4066	up (SV *self, int adjust = 1)	4315	up (SV *self)
4067	ALIAS:
4068	adjust = 1
4069	CODE:	4316	CODE:
		4317	coro_semaphore_adjust (aTHX_ (AV *)SvRV (self), 1);
		4318
		4319	void
		4320	adjust (SV *self, int adjust)
		4321	CODE:
4070	coro_semaphore_adjust (aTHX_ (AV *)SvRV (self), ix ? adjust : 1);	4322	coro_semaphore_adjust (aTHX_ (AV *)SvRV (self), adjust);
4071		4323
4072	void	4324	void
4073	down (...)	4325	down (...)
4074	CODE:	4326	CODE:
4075	CORO_EXECUTE_SLF_XS (slf_init_semaphore_down);	4327	CORO_EXECUTE_SLF_XS (slf_init_semaphore_down);
…		…
4237	{	4489	{
4238	PL_ppaddr [OP_SSELECT] = coro_old_pp_sselect;	4490	PL_ppaddr [OP_SSELECT] = coro_old_pp_sselect;
4239	coro_old_pp_sselect = 0;	4491	coro_old_pp_sselect = 0;
4240	}	4492	}
4241		4493
		4494	MODULE = Coro::State PACKAGE = Coro::Util
		4495
		4496	void
		4497	_exit (int code)
		4498	CODE:
		4499	_exit (code);
		4500
		4501	NV
		4502	time ()
		4503	CODE:
		4504	RETVAL = nvtime (aTHX);
		4505	OUTPUT:
		4506	RETVAL
		4507
		4508	NV
		4509	gettimeofday ()
		4510	PPCODE:
		4511	{
		4512	UV tv [2];
		4513	u2time (aTHX_ tv);
		4514	EXTEND (SP, 2);
		4515	PUSHs (sv_2mortal (newSVuv (tv [0])));
		4516	PUSHs (sv_2mortal (newSVuv (tv [1])));
		4517	}
		4518

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing Coro/Coro/State.xs (file contents): Revision 1.430 by root, Wed Dec 19 23:36:16 2012 UTC vs. Revision 1.462 by root, Wed Jun 22 20:24:38 2016 UTC

Diff Legend

Comparing Coro/Coro/State.xs (file contents):
Revision 1.430 by root, Wed Dec 19 23:36:16 2012 UTC vs.
Revision 1.462 by root, Wed Jun 22 20:24:38 2016 UTC