ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/Coro/myhttpd/httpd.pl
(Generate patch)

Comparing Coro/myhttpd/httpd.pl (file contents):
Revision 1.16 by root, Tue Aug 14 19:38:25 2001 UTC vs.
Revision 1.40 by root, Mon Sep 3 00:06:06 2001 UTC

1use Coro; 1use Coro;
2use Coro::Semaphore; 2use Coro::Semaphore;
3use Coro::Event; 3use Coro::Event;
4use Coro::Socket; 4use Coro::Socket;
5 5
6use HTTP::Date;
7
6no utf8; 8no utf8;
7use bytes; 9use bytes;
8 10
9# at least on my machine, this thingy serves files 11# at least on my machine, this thingy serves files
10# quite a bit faster than apache, ;) 12# quite a bit faster than apache, ;)
11# and quite a bit slower than thttpd :( 13# and quite a bit slower than thttpd :(
12 14
13$SIG{PIPE} = 'IGNORE'; 15$SIG{PIPE} = 'IGNORE';
14 16
17our $accesslog;
18
19if ($ACCESS_LOG) {
20 use IO::Handle;
21 open $accesslog, ">>$ACCESS_LOG"
22 or die "$ACCESS_LOG: $!";
23 $accesslog->autoflush(1);
24}
25
15sub slog { 26sub slog {
16 my $level = shift; 27 my $level = shift;
17 my $format = shift; 28 my $format = shift;
18 printf "---: $format\n", @_; 29 printf "---: $format\n", @_;
19} 30}
20 31
21my $connections = new Coro::Semaphore $MAX_CONNECTS; 32our $connections = new Coro::Semaphore $MAX_CONNECTS || 250;
33
34our $wait_factor = 0.95;
35
36our @transfers = (
37 [(new Coro::Semaphore $MAX_TRANSFERS_SMALL || 50), 1],
38 [(new Coro::Semaphore $MAX_TRANSFERS_LARGE || 50), 1],
39);
22 40
23my @newcons; 41my @newcons;
24my @pool; 42my @pool;
25 43
26# one "execution thread" 44# one "execution thread"
27sub handler { 45sub handler {
28 while () { 46 while () {
29 my $new = pop @newcons;
30 if ($new) { 47 if (@newcons) {
31 eval { 48 eval {
32 conn->new(@$new)->handle; 49 conn->new(@{pop @newcons})->handle;
33 }; 50 };
34 slog 1, "$@" if $@ && !ref $@; 51 slog 1, "$@" if $@ && !ref $@;
35 $connections->up; 52 $connections->up;
36 } else { 53 } else {
37 last if @pool >= $MAX_POOL; 54 last if @pool >= $MAX_POOL;
… …
39 schedule; 56 schedule;
40 } 57 }
41 } 58 }
42} 59}
43 60
61sub listen_on {
62 my $listen = $_[0];
63
64 push @listen_sockets, $listen;
65
66 # the "main thread"
67 async {
68 slog 1, "accepting connections";
69 while () {
70 $connections->down;
71 push @newcons, [$listen->accept];
72 #slog 3, "accepted @$connections ".scalar(@pool);
73 if (@pool) {
74 (pop @pool)->ready;
75 } else {
76 async \&handler;
77 }
78
79 }
80 };
81}
82
44my $http_port = new Coro::Socket 83my $http_port = new Coro::Socket
45 LocalAddr => $SERVER_HOST, 84 LocalAddr => $SERVER_HOST,
46 LocalPort => $SERVER_PORT, 85 LocalPort => $SERVER_PORT,
47 ReuseAddr => 1, 86 ReuseAddr => 1,
48 Listen => 50, 87 Listen => 50,
49 or die "unable to start server"; 88 or die "unable to start server";
50 89
51push @listen_sockets, $http_port; 90listen_on $http_port;
52 91
53# the "main thread" 92my $http_port = new Coro::Socket
54async { 93 LocalAddr => $SERVER_HOST,
55 slog 1, "accepting connections"; 94 LocalPort => $SERVER_PORT2,
56 while () { 95 ReuseAddr => 1,
57 $connections->down; 96 Listen => 50,
58 push @newcons, [$http_port->accept]; 97 or die "unable to start server";
59 #slog 3, "accepted @$connections ".scalar(@pool); 98
99listen_on $http_port;
100
101our $NOW;
102our $HTTP_NOW;
103
104Event->timer(interval => 1, hard => 1, cb => sub {
60 $::NOW = time; 105 $NOW = time;
61 if (@pool) { 106 $HTTP_NOW = time2str $NOW;
62 (pop @pool)->ready; 107})->now;
63 } else {
64 async \&handler;
65 }
66
67 }
68};
69 108
70package conn; 109package conn;
71 110
72use Socket; 111use Socket;
73use HTTP::Date; 112use HTTP::Date;
… …
75use Linux::AIO; 114use Linux::AIO;
76 115
77Linux::AIO::min_parallel $::AIO_PARALLEL; 116Linux::AIO::min_parallel $::AIO_PARALLEL;
78 117
79Event->io(fd => Linux::AIO::poll_fileno, 118Event->io(fd => Linux::AIO::poll_fileno,
80 poll => 'r', 119 poll => 'r', async => 1,
81 async => 1,
82 cb => \&Linux::AIO::poll_cb ); 120 cb => \&Linux::AIO::poll_cb);
83 121
84Event->add_hooks(prepare => sub {
85 &Coro::cede while &Coro::nready;
86 1e6;
87});
88
89our %conn; # $conn{ip}{fh} => connobj 122our %conn; # $conn{ip}{self} => connobj
123our %uri; # $uri{ip}{uri}{self}
90our %blocked; 124our %blocked;
91our %mimetype; 125our %mimetype;
92 126
93sub read_mimetypes { 127sub read_mimetypes {
94 local *M; 128 local *M;
… …
114 or $self->err(500, "unable to decode peername"); 148 or $self->err(500, "unable to decode peername");
115 149
116 $self->{remote_addr} = inet_ntoa $iaddr; 150 $self->{remote_addr} = inet_ntoa $iaddr;
117 $self->{time} = $::NOW; 151 $self->{time} = $::NOW;
118 152
119 # enter ourselves into various lists
120 weaken ($conn{$self->{remote_addr}}{$self*1} = $self);
121
122 $::conns++; 153 $::conns++;
123 154
124 $self; 155 $self;
125} 156}
126 157
127sub DESTROY { 158sub DESTROY {
128 my $self = shift; 159 my $self = shift;
129
130 $::conns--; 160 $::conns--;
161 $self->eoconn;
162}
131 163
164# end of connection
165sub eoconn {
166 my $self = shift;
167
168 # clean up hints
132 delete $conn{$self->{remote_addr}}{$self*1}; 169 delete $conn{$self->{remote_id}}{$self*1};
133 delete $uri{$self->{remote_addr}}{$self->{uri}}{$self*1}; 170 delete $uri{$self->{remote_id}}{$self->{uri}}{$self*1};
134} 171}
135 172
136sub slog { 173sub slog {
137 my $self = shift; 174 my $self = shift;
138 main::slog($_[0], "$self->{remote_addr}> $_[1]"); 175 main::slog($_[0], ($self->{remote_id} || $self->{remote_addr}) ."> $_[1]");
139} 176}
140 177
141sub response { 178sub response {
142 my ($self, $code, $msg, $hdr, $content) = @_; 179 my ($self, $code, $msg, $hdr, $content) = @_;
143 my $res = "HTTP/1.0 $code $msg\015\012"; 180 my $res = "HTTP/1.1 $code $msg\015\012";
144 181
145 $res .= "Connection: close\015\012"; 182 $self->{h}{connection} ||= $hdr->{Connection};
146 $res .= "Date: ".(time2str $::NOW)."\015\012"; # slow? nah. :( 183
184 $res .= "Date: $HTTP_NOW\015\012";
147 185
148 while (my ($h, $v) = each %$hdr) { 186 while (my ($h, $v) = each %$hdr) {
149 $res .= "$h: $v\015\012" 187 $res .= "$h: $v\015\012"
150 } 188 }
151 $res .= "\015\012"; 189 $res .= "\015\012";
152 190
153 $res .= $content if defined $content and $self->{method} ne "HEAD"; 191 $res .= $content if defined $content and $self->{method} ne "HEAD";
154 192
155 print STDERR "$self->{remote_addr} \"$self->{uri}\" $code ".$hdr->{"Content-Length"}." \"$self->{h}{referer}\"\n";#d# 193 my $log = "$self->{remote_addr} \"$self->{uri}\" $code ".$hdr->{"Content-Length"}." \"$self->{h}{referer}\"\n";
194
195 print $accesslog $log if $accesslog;
196 print STDERR $log;
156 197
157 $self->{written} += 198 $self->{written} +=
158 print {$self->{fh}} $res; 199 print {$self->{fh}} $res;
159} 200}
160 201
161sub err { 202sub err {
162 my $self = shift; 203 my $self = shift;
163 my ($code, $msg, $hdr, $content) = @_; 204 my ($code, $msg, $hdr, $content) = @_;
164 205
165 unless (defined $content) { 206 unless (defined $content) {
166 $content = "$code $msg"; 207 $content = "$code $msg\n";
167 $hdr->{"Content-Type"} = "text/plain"; 208 $hdr->{"Content-Type"} = "text/plain";
168 $hdr->{"Content-Length"} = length $content; 209 $hdr->{"Content-Length"} = length $content;
169 } 210 }
211 $hdr->{"Connection"} = "close";
170 212
171 $self->response($code, $msg, $hdr, $content); 213 $self->response($code, $msg, $hdr, $content);
172 214
173 die bless {}, err::; 215 die bless {}, err::;
174} 216}
175 217
176sub err_blocked {
177 my $self = shift;
178 my $ip = $self->{remote_addr};
179 my $time = time2str $blocked{$ip} = $::NOW + $::BLOCKTIME;
180
181 Coro::Event::do_timer(after => 15);
182
183 $self->err(401, "too many connections",
184 {
185 "Content-Type" => "text/html",
186 "Retry-After" => $::BLOCKTIME
187 },
188 <<EOF);
189<html><p>
190You have been blocked because you opened too many connections. You
191may retry at</p>
192
193 <p><blockquote>$time.</blockquote></p>
194
195<p>Until then, each new access will renew the block. You might want to have a
196look at the <a href="http://www.goof.com/pcg/marc/animefaq.html">FAQ</a>.</p>
197</html>
198EOF
199}
200
201sub handle { 218sub handle {
202 my $self = shift; 219 my $self = shift;
203 my $fh = $self->{fh}; 220 my $fh = $self->{fh};
204 221
222 my $host;
223
224 $fh->timeout($::REQ_TIMEOUT);
205 #while() { 225 while() {
226 $self->{reqs}++;
227
228 # read request and parse first line
229 my $req = $fh->readline("\015\012\015\012");
230
231 unless (defined $req) {
232 if (exists $self->{version}) {
233 last;
234 } else {
235 $self->err(408, "request timeout");
236 }
237 }
238
206 $self->{h} = {}; 239 $self->{h} = {};
207 240
208 # read request and parse first line
209 $fh->timeout($::REQ_TIMEOUT);
210 my $req = $fh->readline("\015\012\015\012");
211 $fh->timeout($::RES_TIMEOUT); 241 $fh->timeout($::RES_TIMEOUT);
212
213 defined $req or
214 $self->err(408, "request timeout");
215
216 my $ip = $self->{remote_addr};
217
218 if ($blocked{$ip}) {
219 $self->err_blocked($blocked{$ip})
220 if $blocked{$ip} > $::NOW;
221
222 delete $blocked{$ip};
223 }
224
225 if (%{$conn{$ip}} > $::MAX_CONN_IP) {
226 $self->slog(2, "blocked ip $ip");
227 $self->err_blocked;
228 }
229 242
230 $req =~ /^(?:\015\012)? 243 $req =~ /^(?:\015\012)?
231 (GET|HEAD) \040+ 244 (GET|HEAD) \040+
232 ([^\040]+) \040+ 245 ([^\040]+) \040+
233 HTTP\/([0-9]+\.[0-9]+) 246 HTTP\/([0-9]+\.[0-9]+)
234 \015\012/gx 247 \015\012/gx
235 or $self->err(405, "method not allowed", { Allow => "GET,HEAD" }); 248 or $self->err(405, "method not allowed", { Allow => "GET,HEAD" });
236 249
237 $2 ne "1.0"
238 or $self->err(506, "http protocol version not supported");
239
240 $self->{method} = $1; 250 $self->{method} = $1;
241 $self->{uri} = $2; 251 $self->{uri} = $2;
252 $self->{version} = $3;
253
254 $3 =~ /^1\./
255 or $self->err(506, "http protocol version $3 not supported");
242 256
243 # parse headers 257 # parse headers
244 { 258 {
245 my (%hdr, $h, $v); 259 my (%hdr, $h, $v);
246 260
… …
257 271
258 $self->{h}{$h} = substr $v, 1 272 $self->{h}{$h} = substr $v, 1
259 while ($h, $v) = each %hdr; 273 while ($h, $v) = each %hdr;
260 } 274 }
261 275
276 # remote id should be unique per user
277 my $id = $self->{remote_addr};
278
279 if (exists $self->{h}{"client-ip"}) {
280 $id .= "[".$self->{h}{"client-ip"}."]";
281 } elsif (exists $self->{h}{"x-forwarded-for"}) {
282 $id .= "[".$self->{h}{"x-forwarded-for"}."]";
283 }
284
285 $self->{remote_id} = $id;
286
287 if ($blocked{$id}) {
288 $self->err_blocked($blocked{$id})
289 if $blocked{$id} > $::NOW;
290
291 delete $blocked{$id};
292 }
293
294 if (%{$conn{$id}} >= $::MAX_CONN_IP) {
295 my $delay = $::PER_TIMEOUT + 15;
296 while (%{$conn{$id}} >= $::MAX_CONN_IP) {
297 if ($delay <= 0) {
298 $self->slog(2, "blocked ip $id");
299 $self->err_blocked;
300 } else {
301 Coro::Event::do_timer(after => 4); $delay -= 4;
302 }
303 }
304 }
305
306 # find out server name and port
307 if ($self->{uri} =~ s/^http:\/\/([^\/?#]*)//i) {
308 $host = $1;
309 } else {
310 $host = $self->{h}{host};
311 }
312
313 if (defined $host) {
262 $self->{server_port} = $self->{h}{host} =~ s/:([0-9]+)$// ? $1 : 80; 314 $self->{server_port} = $host =~ s/:([0-9]+)$// ? $1 : 80;
315 } else {
316 ($self->{server_port}, $host)
317 = unpack_sockaddr_in $self->{fh}->getsockname
318 or $self->err(500, "unable to get socket name");
319 $host = inet_ntoa $host;
320 }
263 321
322 $self->{server_name} = $host;
323
324 # enter ourselves into various lists
325 weaken ($conn{$id}{$self*1} = $self);
264 weaken ($uri{$self->{remote_addr}}{$self->{uri}}{$self*1} = $self); 326 weaken ($uri{$id}{$self->{uri}}{$self*1} = $self);
265 327
328 eval {
266 $self->map_uri; 329 $self->map_uri;
267 $self->respond; 330 $self->respond;
331 };
332
333 $self->eoconn;
334
335 die if $@ && !ref $@;
336
337 last if $self->{h}{connection} =~ /close/ || $self->{version} < 1.1;
338
339 $fh->timeout($::PER_TIMEOUT);
268 #} 340 }
269} 341}
270 342
271# uri => path mapping 343# uri => path mapping
272sub map_uri { 344sub map_uri {
273 my $self = shift; 345 my $self = shift;
274 my $host = $self->{h}{host} || "default"; 346 my $host = $self->{server_name};
275 my $uri = $self->{uri}; 347 my $uri = $self->{uri};
276 348
277 # some massaging, also makes it more secure 349 # some massaging, also makes it more secure
278 $uri =~ s/%([0-9a-fA-F][0-9a-fA-F])/chr hex $1/ge; 350 $uri =~ s/%([0-9a-fA-F][0-9a-fA-F])/chr hex $1/ge;
279 $uri =~ s%//+%/%g; 351 $uri =~ s%//+%/%g;
… …
289 $self->{path} = "$::DOCROOT/$host$uri"; 361 $self->{path} = "$::DOCROOT/$host$uri";
290 362
291 $self->access_check; 363 $self->access_check;
292} 364}
293 365
294sub server_address {
295 my $self = shift;
296 my ($port, $iaddr) = unpack_sockaddr_in $self->{fh}->getsockname
297 or $self->err(500, "unable to get socket name");
298 ((inet_ntoa $iaddr), $port);
299}
300
301sub server_host {
302 my $self = shift;
303 if (exists $self->{h}{host}) {
304 return $self->{h}{host};
305 } else {
306 return (($self->server_address)[0]);
307 }
308}
309
310sub server_hostport {
311 my $self = shift;
312 my ($host, $port);
313 if (exists $self->{h}{host}) {
314 ($host, $port) = ($self->{h}{host}, $self->{server_port});
315 } else {
316 ($host, $port) = $self->server_address;
317 }
318 $port = $port == 80 ? "" : ":$port";
319 $host.$port;
320}
321
322sub _cgi { 366sub _cgi {
323 my $self = shift; 367 my $self = shift;
324 my $path = shift; 368 my $path = shift;
325 my $fh; 369 my $fh;
326 370
327 # no two-way xxx supported 371 # no two-way xxx supported
328 if (0 == fork) { 372 if (0 == fork) {
329 open STDOUT, ">&".fileno($self->{fh}); 373 open STDOUT, ">&".fileno($self->{fh});
330 if (chdir $::DOCROOT) { 374 if (chdir $::DOCROOT) {
331 $ENV{SERVER_SOFTWARE} = "thttpd-myhttpd"; # we are thttpd-alike 375 $ENV{SERVER_SOFTWARE} = "thttpd-myhttpd"; # we are thttpd-alike
332 $ENV{HTTP_HOST} = $self->server_host; 376 $ENV{HTTP_HOST} = $self->{server_name};
333 $ENV{HTTP_PORT} = $self->{server_host}; 377 $ENV{HTTP_PORT} = $self->{server_port};
334 $ENV{SCRIPT_NAME} = $self->{name}; 378 $ENV{SCRIPT_NAME} = $self->{name};
335 exec $path; 379 exec $path;
336 } 380 }
337 Coro::State::_exit(0); 381 Coro::State::_exit(0);
338 } else { 382 } else {
383 die;
339 } 384 }
385}
386
387sub server_hostport {
388 $_[0]{server_port} == 80
389 ? $_[0]{server_name}
390 : "$_[0]{server_name}:$_[0]{server_port}";
340} 391}
341 392
342sub respond { 393sub respond {
343 my $self = shift; 394 my $self = shift;
344 my $path = $self->{path}; 395 my $path = $self->{path};
… …
354 405
355 if (-d _ && -r _) { 406 if (-d _ && -r _) {
356 # directory 407 # directory
357 if ($path !~ /\/$/) { 408 if ($path !~ /\/$/) {
358 # create a redirect to get the trailing "/" 409 # create a redirect to get the trailing "/"
359 my $host = $self->server_hostport; 410 # we don't try to avoid the :80
360 $self->err(301, "moved permanently", { Location => "http://$host$self->{uri}/" }); 411 $self->err(301, "moved permanently", { Location => "http://".$self->server_hostport."$self->{uri}/" });
361 } else { 412 } else {
362 $ims < $self->{stat}[9] 413 $ims < $self->{stat}[9]
363 or $self->err(304, "not modified"); 414 or $self->err(304, "not modified");
364 415
365 if ($self->{method} eq "GET") {
366 if (-r "$path/index.html") { 416 if (-r "$path/index.html") {
367 $self->{path} .= "/index.html"; 417 $self->{path} .= "/index.html";
368 $self->handle_file; 418 $self->handle_file;
369 } else { 419 } else {
370 $self->handle_dir; 420 $self->handle_dir;
371 }
372 } 421 }
373 } 422 }
374 } elsif (-f _ && -r _) { 423 } elsif (-f _ && -r _) {
375 -x _ and $self->err(403, "forbidden"); 424 -x _ and $self->err(403, "forbidden");
376 $self->handle_file; 425 $self->handle_file;
… …
391 $idx); 440 $idx);
392} 441}
393 442
394sub handle_file { 443sub handle_file {
395 my $self = shift; 444 my $self = shift;
396 my $length = -s _; 445 my $length = $self->{stat}[7];
446 my $queue = $::transfers[$length >= $::TRANSFER_SMALL];
397 my $hdr = { 447 my $hdr = {
398 "Last-Modified" => time2str ((stat _)[9]), 448 "Last-Modified" => time2str ((stat _)[9]),
399 }; 449 };
400 450
401 my @code = (200, "ok"); 451 my @code = (200, "ok");
… …
409 ($l, $h) = ($1, ($2 ne "" || $2 >= $length) ? $2 : $length - 1); 459 ($l, $h) = ($1, ($2 ne "" || $2 >= $length) ? $2 : $length - 1);
410 } else { 460 } else {
411 ($l, $h) = (0, $length - 1); 461 ($l, $h) = (0, $length - 1);
412 goto ignore; 462 goto ignore;
413 } 463 }
414 goto satisfiable if $l >= 0 && $l < $length && $h >= 0 && $h > $l; 464 goto satisfiable if $l >= 0 && $l < $length && $h >= 0 && $h >= $l;
415 } 465 }
416 $hdr->{"Content-Range"} = "bytes */$length"; 466 $hdr->{"Content-Range"} = "bytes */$length";
467 $hdr->{"Content-Length"} = $length;
417 $self->err(416, "not satisfiable", $hdr); 468 $self->err(416, "not satisfiable", $hdr, "");
418 469
419satisfiable: 470satisfiable:
420 # check for segmented downloads 471 # check for segmented downloads
421 if ($l && $::NO_SEGMENTED) { 472 if ($l && $::NO_SEGMENTED) {
473 my $delay = $::PER_TIMEOUT + 15;
422 if (%{$uri{$self->{remote_addr}}{$self->{uri}}} > 1) { 474 while (%{$uri{$self->{remote_id}}{$self->{uri}}} > 1) {
475 if ($delay <= 0) {
476 $self->err_segmented_download;
477 } else {
423 Coro::Event::do_timer(after => 15); 478 Coro::Event::do_timer(after => 4); $delay -= 4;
424 479 }
425 $self->err(400, "segmented downloads are not allowed");
426 } 480 }
427 } 481 }
428 482
429 $hdr->{"Content-Range"} = "bytes $l-$h/$length"; 483 $hdr->{"Content-Range"} = "bytes $l-$h/$length";
430 @code = (206, "partial content"); 484 @code = (206, "partial content");
… …
440 $hdr->{"Content-Length"} = $length; 494 $hdr->{"Content-Length"} = $length;
441 495
442 $self->response(@code, $hdr, ""); 496 $self->response(@code, $hdr, "");
443 497
444 if ($self->{method} eq "GET") { 498 if ($self->{method} eq "GET") {
499 $self->{time} = $::NOW;
500
501 my $fudge = $queue->[0]->waiters;
502 $fudge = $fudge ? ($fudge+1)/$fudge : 1;
503
504 $queue->[1] *= $fudge;
505 my $transfer = $queue->[0]->guard;
506
507 if ($fudge != 1) {
508 $queue->[1] /= $fudge;
509 $queue->[1] = $queue->[1] * $::wait_factor
510 + ($::NOW - $self->{time}) * (1 - $::wait_factor);
511 }
512 $self->{time} = $::NOW;
513
514 $self->{fh}->writable or return;
515
445 my ($fh, $buf, $r); 516 my ($fh, $buf, $r);
446 my $current = $Coro::current; 517 my $current = $Coro::current;
447 open $fh, "<", $self->{path} 518 open $fh, "<", $self->{path}
448 or die "$self->{path}: late open failure ($!)"; 519 or die "$self->{path}: late open failure ($!)";
449 520
450 $h -= $l - 1; 521 $h -= $l - 1;
451 522
523 if (0) {
524 if ($l) {
525 sysseek $fh, $l, 0;
526 }
527 }
528
452 while ($h > 0) { 529 while ($h > 0) {
530 if (0) {
531 sysread $fh, $buf, $h > $::BUFSIZE ? $::BUFSIZE : $h
532 or last;
533 } else {
453 aio_read($fh, $l, ($h > $::BUFSIZE ? $::BUFSIZE : $h), 534 aio_read($fh, $l, ($h > $::BUFSIZE ? $::BUFSIZE : $h),
454 $buf, 0, sub { 535 $buf, 0, sub {
455 $r = $_[0]; 536 $r = $_[0];
456 $current->ready; 537 Coro::ready($current);
457 }); 538 });
458 &Coro::schedule; 539 &Coro::schedule;
459 last unless $r; 540 last unless $r;
460 my $w = $self->{fh}->syswrite($buf) 541 }
542 my $w = syswrite $self->{fh}, $buf
461 or last; 543 or last;
462 $::written += $w; 544 $::written += $w;
463 $self->{written} += $w; 545 $self->{written} += $w;
464 $l += $r; 546 $l += $r;
465 } 547 }
466 }
467 548
468 close $fh; 549 close $fh;
550 }
469} 551}
470 552
4711; 5531;

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines