[ViewVC] Diff of: cvs/EV/Makefile.PL

Comparing EV/Makefile.PL (file contents):
Revision 1.58 by root, Sat Jun 22 15:50:36 2019 UTC vs.
Revision 1.65 by root, Fri Nov 22 14:43:49 2019 UTC

    scalar grep -r "$_/$_[0]", $Config{usrinc}, split / /, $Config{incpth}
 }
 my $DEFINE;
-unless (-e "libev/ev_epoll.c") {
+unless (-e "libev/ev_iouring.c") {
    print <<EOF;
 ***
 *** ERROR: libev is missing or damaged. If you used a CVS check-out of EV,
 *** you also have to check-out the "libev" module from the same CVS
 The second very portable backend is poll(2). It does not exist on windows
 and various versions of Mac OS X (and on the other versions it simply
 doesn't work), but works basically everywhere else. It is recommended to use
-the default here unless you run into compile problems in ev_poll.c.
+the default here unless you run into compilation problems in ev_poll.c.
 EOF
 $DEFINE .= " -DEV_USE_POLL=" . (0 + (prompt ("Enable poll backend (y/n)?", (have_inc "poll.h") ? "y" : "n") =~ /[yY]/));
 default.
 EOF
 my $can_linuxaio = have_inc "linux/aio_abi.h";
-$can_linuxaio or die;
 $can_linuxaio = $ENV{EV_LINUXAIO} if exists $ENV{EV_LINUXAIO};
-$DEFINE .= " -DEV_USE_LINUXAIO=" . (0 + (prompt ("Enable linux aio backend (y/n)?", $can_linuxaio ? "y" : "n") =~ /[yY]/));
+$can_linuxaio = 0 + (prompt ("Enable linux aio backend (y/n)?", $can_linuxaio ? "y" : "n") =~ /[yY]/);
+$DEFINE .= " -DEV_USE_LINUXAIO=$can_linuxaio";
+if ($can_linuxaio) {
 print <<EOF;
 *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
-Similarly to the epoll backend above, EV can take advantage of kqueue on
+The previously mentioned Linux AIO backend is experimental and will not
-many BSD systems. Support for kqueue will be detected at runtime, with a
+be used unless requested explicitly. You can, howeer, choose to make ti a
-safe fallback to other methods when it cannot be used.
+recommended basckend, which means it will be chosen if available even when
+not explicitly asked for, in preference to epoll on GNU/Linux. This option
+is likely temporary. When unsure, accept the default.
+EOF
+my $recommend_linuxaio = 0;
+$recommend_linuxaio = $ENV{EV_RECOMMEND_LINUXAIO} if exists $ENV{EV_RECOMMEND_LINUXAIO};
+$recommend_linuxaio = 0 + (prompt ("Treat linux aio as a recommended backend (y/n)?", $recommend_linuxaio ? "y" : "n") =~ /[yY]/);
+$DEFINE .= " -DEV_RECOMMEND_LINUXAIO=$recommend_linuxaio";
+}
+print <<EOF;
+*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
+Linux 4.19 introduced another event polling interface, "io_uring". While
+this API is far superior to epoll and almost rivals linuxaio, it also
+suffers from the same issues as kqueue typically does: only a subset of
+file types are supported (as of 5.2). It is also very buggy still, and
+most importantly, very very slow for most workloads.  Therefore, this
+backend is not used by default, even when it is compiled in, and you have
+to request it explicitly, e.g. with LIBEV_FLAGS=128. If unsure, accept the
+default.
+EOF
+my $can_iouring = have_inc "linux/fs.h";
+$can_iouring = $ENV{EV_IOURING} if exists $ENV{EV_IOURING};
+$can_iouring = 0 + (prompt ("Enable linux io_uring backend (y/n)?", $can_iouring ? "y" : "n") =~ /[yY]/);
+$DEFINE .= " -DEV_USE_IOURING=$can_iouring";
+if ($can_iouring) {
+print <<EOF;
+*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
+The previously mentioned Linux io_uring is experimental and will not be
+used unless requested explicitly. You can, howeer, choose to make ti a
+recommended basckend, which means it will be chosen if available even when
+not explicitly asked for, in preference to epoll on GNU/Linux. This option
+is likely temporary. When unsure, accept the default.
+EOF
+my $recommend_iouring = 0;
+$recommend_iouring = $ENV{EV_RECOMMEND_IOURING} if exists $ENV{EV_RECOMMEND_IOURING};
+$recommend_iouring = 0 + (prompt ("Treat io_uring as a recommended backend (y/n)?", $recommend_iouring ? "y" : "n") =~ /[yY]/);
+$DEFINE .= " -DEV_RECOMMEND_IOURING=$recommend_iouring";
+}
+print <<EOF;
+*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
+EV can take advantage of kqueue on many BSD systems. Support for kqueue
+will be detected at runtime, with a safe fallback to other methods when it
+cannot be used.
-Note that kqueue is broken on most operating systems, so by default it
+Note that kqueue is subtly broken on most operating systems, so by default
-won't be used on many platforms, but you can still create your own event
+it won't be used on many platforms, but you can still create your own
-loop with kqueue backend if you ask specifically for it.
+event loop with kqueue backend if you ask specifically for it.
 Here is what we know:
 NetBSD:  partially working in at least 3.1 and later. Yeah! :)
 FreeBSD: broken on at least 6.2-STABLE, spotty in later versions,
          (similar problems as on FreeBSD).
 OS X:    completely, utterly broken on at least <= 10.6.
 EOF
+# minix has all the header files, but no implementation. won-der-ful.
-my $can_kqueue = have_inc "sys/event.h";
+my $can_kqueue = have_inc "sys/event.h" && $^O ne "minix";
 $can_kqueue = $ENV{EV_KQUEUE} if exists $ENV{EV_KQUEUE};
 $DEFINE .= " -DEV_USE_KQUEUE=" . (0 + (prompt ("Enable kqueue backend (y/n)?", $can_kqueue ? "y" : "n") =~ /[yY]/));
 print <<EOF;
 print <<EOF;
 *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
+Libev contains numerous internal assert() invocations to check for
+consistency and user errors. These are normally enabled, but most
+perl builds disable this error reporting mechanism by default. You
+can re-enable these asserts here. Enabling them might help you catch
+programming bugs earlier, but might cause a small slowdown. Also, failures
+will be reported by aboritng your program, instead of throwing a perl
+exception.
+If unsure, enable this if you only use this perl installation for
+development, and leave it off for use in production environments.
+EOF
+my $enable_assertions = 0;
+$enable_assertions = 0 + (prompt ("Make sure assertions are enabled? (y/n)?", $enable_assertions ? "y" : "n") =~ /[yY]/);
+$DEFINE .= " -DEV_ENABLE_ASERTIONS=1" if $enable_assertions;
+print <<EOF;
+*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
 Very rarely, people want to tweak EV even more, e.g. to exclude
 or include certain watcher types or backends. This can be done by adding
 extra -D options here, or via the EV_EXTRA_DEFS environment variable.
-For example, if you run into compile problems because of missing memory
+For example, if you run into compilation problems because of missing memory
 fences (or you just want extra performance), you can tell EV to not support
 smp and threads via -DEV_NO_THREADS.
 Normal persons just press enter.
 	            COMPRESS	=> 'gzip -9v',
 	            SUFFIX	=> '.gz',
 	           },
     depend => {
        "EV.c" => "EV/EVAPI.h "
-               . "libev/ev.c libev/ev.h libev/ev_epoll.c libev/ev_select.c libev/ev_kqueue.c libev/ev_poll.c "
+               . "libev/ev.c libev/ev.h libev/ev_epoll.c libev/ev_select.c libev/ev_kqueue.c libev/ev_poll.c libev/ev_linuxaio.c "
                . "libev/ev_vars.h libev/ev_wrap.h",
     },
     INC       => "-Ilibev",
     DEFINE    => "$DEFINE",
     NAME => "EV",
                     'EV/MakeMaker.pm' => '$(INST_MAN3DIR)/EV::MakeMaker.$(MAN3EXT)',
                     'libev/ev.pod'    => '$(INST_MAN3DIR)/EV::libev.$(MAN3EXT)',
                 },
 );

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing EV/Makefile.PL (file contents): Revision 1.58 by root, Sat Jun 22 15:50:36 2019 UTC vs. Revision 1.65 by root, Fri Nov 22 14:43:49 2019 UTC

Diff Legend

Comparing EV/Makefile.PL (file contents):
Revision 1.58 by root, Sat Jun 22 15:50:36 2019 UTC vs.
Revision 1.65 by root, Fri Nov 22 14:43:49 2019 UTC