ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/IO-AIO/AIO.xs
(Generate patch)

Comparing IO-AIO/AIO.xs (file contents):
Revision 1.13 by root, Fri Jul 22 08:25:22 2005 UTC vs.
Revision 1.29 by root, Wed Aug 17 06:12:10 2005 UTC

1#define _XOPEN_SOURCE 500 1#define _REENTRANT 1
2#include <errno.h>
2 3
3#include "EXTERN.h" 4#include "EXTERN.h"
4#include "perl.h" 5#include "perl.h"
5#include "XSUB.h" 6#include "XSUB.h"
7
8#include "autoconf/config.h"
6 9
7#include <sys/types.h> 10#include <sys/types.h>
8#include <sys/stat.h> 11#include <sys/stat.h>
9 12
10#include <unistd.h> 13#include <unistd.h>
11#include <fcntl.h> 14#include <fcntl.h>
12#include <signal.h> 15#include <signal.h>
13#include <sched.h> 16#include <sched.h>
14#if __linux
15#include <sys/syscall.h>
16#endif
17 17
18#include <pthread.h> 18#include <pthread.h>
19 19
20typedef void *InputStream; /* hack, but 5.6.1 is simply toooo old ;) */ 20typedef void *InputStream; /* hack, but 5.6.1 is simply toooo old ;) */
21typedef void *OutputStream; /* hack, but 5.6.1 is simply toooo old ;) */ 21typedef void *OutputStream; /* hack, but 5.6.1 is simply toooo old ;) */
… …
29 29
30enum { 30enum {
31 REQ_QUIT, 31 REQ_QUIT,
32 REQ_OPEN, REQ_CLOSE, 32 REQ_OPEN, REQ_CLOSE,
33 REQ_READ, REQ_WRITE, REQ_READAHEAD, 33 REQ_READ, REQ_WRITE, REQ_READAHEAD,
34 REQ_STAT, REQ_LSTAT, REQ_FSTAT, REQ_UNLINK, 34 REQ_STAT, REQ_LSTAT, REQ_FSTAT,
35 REQ_FSYNC, REQ_FDATASYNC, 35 REQ_FSYNC, REQ_FDATASYNC,
36 REQ_UNLINK, REQ_RMDIR,
37 REQ_SYMLINK,
36}; 38};
37 39
38typedef struct aio_cb { 40typedef struct aio_cb {
39 struct aio_cb *volatile next; 41 struct aio_cb *volatile next;
40 42
… …
45 size_t length; 47 size_t length;
46 ssize_t result; 48 ssize_t result;
47 mode_t mode; /* open */ 49 mode_t mode; /* open */
48 int errorno; 50 int errorno;
49 SV *data, *callback, *fh; 51 SV *data, *callback, *fh;
50 void *dataptr; 52 void *dataptr, *data2ptr;
51 STRLEN dataoffset; 53 STRLEN dataoffset;
52 54
53 Stat_t *statdata; 55 Stat_t *statdata;
54} aio_cb; 56} aio_cb;
55 57
… …
64static pthread_mutex_t reqlock = PTHREAD_MUTEX_INITIALIZER; 66static pthread_mutex_t reqlock = PTHREAD_MUTEX_INITIALIZER;
65static pthread_cond_t reqwait = PTHREAD_COND_INITIALIZER; 67static pthread_cond_t reqwait = PTHREAD_COND_INITIALIZER;
66 68
67static volatile aio_req reqs, reqe; /* queue start, queue end */ 69static volatile aio_req reqs, reqe; /* queue start, queue end */
68static volatile aio_req ress, rese; /* queue start, queue end */ 70static volatile aio_req ress, rese; /* queue start, queue end */
71
72static void free_req (aio_req req)
73{
74 if (req->data)
75 SvREFCNT_dec (req->data);
76
77 if (req->fh)
78 SvREFCNT_dec (req->fh);
79
80 if (req->statdata)
81 Safefree (req->statdata);
82
83 if (req->callback)
84 SvREFCNT_dec (req->callback);
85
86 Safefree (req);
87}
69 88
70static void 89static void
71poll_wait () 90poll_wait ()
72{ 91{
73 if (nreqs && !ress) 92 if (nreqs && !ress)
… …
83static int 102static int
84poll_cb () 103poll_cb ()
85{ 104{
86 dSP; 105 dSP;
87 int count = 0; 106 int count = 0;
107 int do_croak = 0;
88 aio_req req, prv; 108 aio_req req;
89 109
90 pthread_mutex_lock (&reslock); 110 for (;;)
91
92 {
93 /* read any signals sent by the worker threads */
94 char buf [32];
95 while (read (respipe [0], buf, 32) > 0)
96 ;
97 }
98
99 req = ress;
100 ress = rese = 0;
101
102 pthread_mutex_unlock (&reslock);
103
104 while (req)
105 { 111 {
112 pthread_mutex_lock (&reslock);
113 req = ress;
114
115 if (req)
116 {
117 ress = req->next;
118
119 if (!ress)
120 {
121 rese = 0;
122
123 /* read any signals sent by the worker threads */
124 char buf [32];
125 while (read (respipe [0], buf, 32) == 32)
126 ;
127 }
128 }
129
130 pthread_mutex_unlock (&reslock);
131
132 if (!req)
133 break;
134
106 nreqs--; 135 nreqs--;
107 136
108 if (req->type == REQ_QUIT) 137 if (req->type == REQ_QUIT)
109 started--; 138 started--;
110 else 139 else
111 { 140 {
112 int errorno = errno; 141 int errorno = errno;
113 errno = req->errorno; 142 errno = req->errorno;
114 143
115 if (req->type == REQ_READ) 144 if (req->type == REQ_READ)
116 SvCUR_set (req->data, req->dataoffset 145 SvCUR_set (req->data, req->dataoffset + (req->result > 0 ? req->result : 0));
117 + req->result > 0 ? req->result : 0);
118 146
147 if (req->data2ptr && (req->type == REQ_READ || req->type == REQ_WRITE))
148 SvREADONLY_off (req->data);
149
119 if (req->data) 150 if (req->statdata)
120 SvREFCNT_dec (req->data);
121
122 if (req->fh)
123 SvREFCNT_dec (req->fh);
124
125 if (req->type == REQ_STAT || req->type == REQ_LSTAT || req->type == REQ_FSTAT)
126 { 151 {
127 PL_laststype = req->type == REQ_LSTAT ? OP_LSTAT : OP_STAT; 152 PL_laststype = req->type == REQ_LSTAT ? OP_LSTAT : OP_STAT;
128 PL_laststatval = req->result; 153 PL_laststatval = req->result;
129 PL_statcache = *(req->statdata); 154 PL_statcache = *(req->statdata);
130
131 Safefree (req->statdata);
132 } 155 }
133 156
134 ENTER; 157 ENTER;
135 PUSHMARK (SP); 158 PUSHMARK (SP);
136 XPUSHs (sv_2mortal (newSViv (req->result))); 159 XPUSHs (sv_2mortal (newSViv (req->result)));
… …
153 if (SvOK (req->callback)) 176 if (SvOK (req->callback))
154 { 177 {
155 PUTBACK; 178 PUTBACK;
156 call_sv (req->callback, G_VOID | G_EVAL); 179 call_sv (req->callback, G_VOID | G_EVAL);
157 SPAGAIN; 180 SPAGAIN;
181
182 if (SvTRUE (ERRSV))
183 {
184 free_req (req);
185 croak (0);
186 }
158 } 187 }
159 188
160 LEAVE; 189 LEAVE;
161
162 if (req->callback)
163 SvREFCNT_dec (req->callback);
164 190
165 errno = errorno; 191 errno = errorno;
166 count++; 192 count++;
167 } 193 }
168 194
169 prv = req; 195 free_req (req);
170 req = req->next;
171 Safefree (prv);
172
173 /* TODO: croak on errors? */
174 } 196 }
175 197
176 return count; 198 return count;
177} 199}
178 200
… …
216 reqe = reqs = req; 238 reqe = reqs = req;
217 239
218 pthread_cond_signal (&reqwait); 240 pthread_cond_signal (&reqwait);
219 pthread_mutex_unlock (&reqlock); 241 pthread_mutex_unlock (&reqlock);
220 242
221 while (nreqs > max_outstanding) 243 if (nreqs > max_outstanding)
244 for (;;)
245 {
246 poll_cb ();
247
248 if (nreqs <= max_outstanding)
249 break;
250
251 poll_wait ();
252 }
253}
254
255static void
256end_thread (void)
257{
258 aio_req req;
259 Newz (0, req, 1, aio_cb);
260 req->type = REQ_QUIT;
261
262 send_req (req);
263}
264
265static void min_parallel (int nthreads)
266{
267 while (nthreads > started)
268 start_thread ();
269}
270
271static void max_parallel (int nthreads)
272{
273 int cur = started;
274
275 while (cur > nthreads)
276 {
277 end_thread ();
278 cur--;
279 }
280
281 while (started > nthreads)
222 { 282 {
223 poll_wait (); 283 poll_wait ();
224 poll_cb (); 284 poll_cb ();
225 } 285 }
226} 286}
227 287
228static void 288static void create_pipe ()
229end_thread (void)
230{ 289{
290 if (pipe (respipe))
291 croak ("unable to initialize result pipe");
292
293 if (fcntl (respipe [0], F_SETFL, O_NONBLOCK))
294 croak ("cannot set result pipe to nonblocking mode");
295
296 if (fcntl (respipe [1], F_SETFL, O_NONBLOCK))
297 croak ("cannot set result pipe to nonblocking mode");
298}
299
300static void atfork_prepare (void)
301{
302 pthread_mutex_lock (&reqlock);
303 pthread_mutex_lock (&reslock);
304}
305
306static void atfork_parent (void)
307{
308 pthread_mutex_unlock (&reslock);
309 pthread_mutex_unlock (&reqlock);
310}
311
312static void atfork_child (void)
313{
231 aio_req req; 314 aio_req prv;
232 New (0, req, 1, aio_cb);
233 req->type = REQ_QUIT;
234 315
235 send_req (req); 316 int restart = started;
317 started = 0;
318
319 while (reqs)
320 {
321 prv = reqs;
322 reqs = prv->next;
323 free_req (prv);
324 }
325
326 reqs = reqe = 0;
327
328 while (ress)
329 {
330 prv = ress;
331 ress = prv->next;
332 free_req (prv);
333 }
334
335 ress = rese = 0;
336
337 close (respipe [0]);
338 close (respipe [1]);
339 create_pipe ();
340
341 atfork_parent ();
342
343 min_parallel (restart);
236} 344}
345
346/*****************************************************************************/
347/* work around various missing functions */
348
349#if !HAVE_PREADWRITE
350# define pread aio_pread
351# define pwrite aio_pwrite
352
353/*
354 * make our pread/pwrite safe against themselves, but not against
355 * normal read/write by using a mutex. slows down execution a lot,
356 * but that's your problem, not mine.
357 */
358static pthread_mutex_t iolock = PTHREAD_MUTEX_INITIALIZER;
359
360static ssize_t
361pread (int fd, void *buf, size_t count, off_t offset)
362{
363 ssize_t res;
364 off_t ooffset;
365
366 pthread_mutex_lock (&iolock);
367 ooffset = lseek (fd, 0, SEEK_CUR);
368 lseek (fd, offset, SEEK_SET);
369 res = read (fd, buf, count);
370 lseek (fd, ooffset, SEEK_SET);
371 pthread_mutex_unlock (&iolock);
372
373 return res;
374}
375
376static ssize_t
377pwrite (int fd, void *buf, size_t count, off_t offset)
378{
379 ssize_t res;
380 off_t ooffset;
381
382 pthread_mutex_lock (&iolock);
383 ooffset = lseek (fd, 0, SEEK_CUR);
384 lseek (fd, offset, SEEK_SET);
385 res = write (fd, buf, count);
386 lseek (fd, offset, SEEK_SET);
387 pthread_mutex_unlock (&iolock);
388
389 return res;
390}
391#endif
392
393#if !HAVE_FDATASYNC
394# define fdatasync fsync
395#endif
396
397#if !HAVE_READAHEAD
398# define readahead aio_readahead
399
400static char readahead_buf[4096];
401
402static ssize_t
403readahead (int fd, off_t offset, size_t count)
404{
405 while (count > 0)
406 {
407 size_t len = count < sizeof (readahead_buf) ? count : sizeof (readahead_buf);
408
409 pread (fd, readahead_buf, len, offset);
410 offset += len;
411 count -= len;
412 }
413
414 errno = 0;
415}
416#endif
417
418/*****************************************************************************/
237 419
238static void * 420static void *
239aio_proc (void *thr_arg) 421aio_proc (void *thr_arg)
240{ 422{
241 aio_req req; 423 aio_req req;
… …
269 451
270 switch (type) 452 switch (type)
271 { 453 {
272 case REQ_READ: req->result = pread (req->fd, req->dataptr, req->length, req->offset); break; 454 case REQ_READ: req->result = pread (req->fd, req->dataptr, req->length, req->offset); break;
273 case REQ_WRITE: req->result = pwrite (req->fd, req->dataptr, req->length, req->offset); break; 455 case REQ_WRITE: req->result = pwrite (req->fd, req->dataptr, req->length, req->offset); break;
274#if SYS_readahead 456
275 case REQ_READAHEAD: req->result = readahead (req->fd, req->offset, req->length); break; 457 case REQ_READAHEAD: req->result = readahead (req->fd, req->offset, req->length); break;
276#else
277 case REQ_READAHEAD: req->result = -1; errno = ENOSYS; break;
278#endif
279 458
280 case REQ_STAT: req->result = stat (req->dataptr, req->statdata); break; 459 case REQ_STAT: req->result = stat (req->dataptr, req->statdata); break;
281 case REQ_LSTAT: req->result = lstat (req->dataptr, req->statdata); break; 460 case REQ_LSTAT: req->result = lstat (req->dataptr, req->statdata); break;
282 case REQ_FSTAT: req->result = fstat (req->fd , req->statdata); break; 461 case REQ_FSTAT: req->result = fstat (req->fd , req->statdata); break;
283 462
284 case REQ_OPEN: req->result = open (req->dataptr, req->fd, req->mode); break; 463 case REQ_OPEN: req->result = open (req->dataptr, req->fd, req->mode); break;
285 case REQ_CLOSE: req->result = close (req->fd); break; 464 case REQ_CLOSE: req->result = close (req->fd); break;
286 case REQ_UNLINK: req->result = unlink (req->dataptr); break; 465 case REQ_UNLINK: req->result = unlink (req->dataptr); break;
466 case REQ_RMDIR: req->result = rmdir (req->dataptr); break;
467 case REQ_SYMLINK: req->result = symlink (req->data2ptr, req->dataptr); break;
287 468
469 case REQ_FDATASYNC: req->result = fdatasync (req->fd); break;
288 case REQ_FSYNC: req->result = fsync (req->fd); break; 470 case REQ_FSYNC: req->result = fsync (req->fd); break;
289 case REQ_FDATASYNC: req->result = fdatasync (req->fd); break;
290 471
291 case REQ_QUIT: 472 case REQ_QUIT:
292 break; 473 break;
293 474
294 default: 475 default:
… …
320 while (type != REQ_QUIT); 501 while (type != REQ_QUIT);
321 502
322 return 0; 503 return 0;
323} 504}
324 505
506#define dREQ \
507 aio_req req; \
508 \
509 if (SvOK (callback) && !SvROK (callback)) \
510 croak ("clalback must be undef or of reference type"); \
511 \
512 Newz (0, req, 1, aio_cb); \
513 if (!req) \
514 croak ("out of memory during aio_req allocation"); \
515 \
516 req->callback = newSVsv (callback);
517
325MODULE = IO::AIO PACKAGE = IO::AIO 518MODULE = IO::AIO PACKAGE = IO::AIO
326 519
327PROTOTYPES: ENABLE 520PROTOTYPES: ENABLE
328 521
329BOOT: 522BOOT:
330{ 523{
331 if (pipe (respipe)) 524 create_pipe ();
332 croak ("unable to initialize result pipe"); 525 pthread_atfork (atfork_prepare, atfork_parent, atfork_child);
333
334 if (fcntl (respipe [0], F_SETFL, O_NONBLOCK))
335 croak ("cannot set result pipe to nonblocking mode");
336
337 if (fcntl (respipe [1], F_SETFL, O_NONBLOCK))
338 croak ("cannot set result pipe to nonblocking mode");
339} 526}
340 527
341void 528void
342min_parallel(nthreads) 529min_parallel(nthreads)
343 int nthreads 530 int nthreads
344 PROTOTYPE: $ 531 PROTOTYPE: $
345 CODE:
346 while (nthreads > started)
347 start_thread ();
348 532
349void 533void
350max_parallel(nthreads) 534max_parallel(nthreads)
351 int nthreads 535 int nthreads
352 PROTOTYPE: $ 536 PROTOTYPE: $
353 CODE:
354{
355 int cur = started;
356 while (cur > nthreads)
357 {
358 end_thread ();
359 cur--;
360 }
361
362 while (started > nthreads)
363 {
364 poll_wait ();
365 poll_cb ();
366 }
367}
368 537
369int 538int
370max_outstanding(nreqs) 539max_outstanding(nreqs)
371 int nreqs 540 int nreqs
372 PROTOTYPE: $ 541 PROTOTYPE: $
… …
381 int mode 550 int mode
382 SV * callback 551 SV * callback
383 PROTOTYPE: $$$;$ 552 PROTOTYPE: $$$;$
384 CODE: 553 CODE:
385{ 554{
386 aio_req req; 555 dREQ;
387
388 Newz (0, req, 1, aio_cb);
389
390 if (!req)
391 croak ("out of memory during aio_req allocation");
392 556
393 req->type = REQ_OPEN; 557 req->type = REQ_OPEN;
394 req->data = newSVsv (pathname); 558 req->data = newSVsv (pathname);
395 req->dataptr = SvPV_nolen (req->data); 559 req->dataptr = SvPVbyte_nolen (req->data);
396 req->fd = flags; 560 req->fd = flags;
397 req->mode = mode; 561 req->mode = mode;
398 req->callback = SvREFCNT_inc (callback);
399 562
400 send_req (req); 563 send_req (req);
401} 564}
402 565
403void 566void
… …
409 aio_close = REQ_CLOSE 572 aio_close = REQ_CLOSE
410 aio_fsync = REQ_FSYNC 573 aio_fsync = REQ_FSYNC
411 aio_fdatasync = REQ_FDATASYNC 574 aio_fdatasync = REQ_FDATASYNC
412 CODE: 575 CODE:
413{ 576{
414 aio_req req; 577 dREQ;
415
416 Newz (0, req, 1, aio_cb);
417
418 if (!req)
419 croak ("out of memory during aio_req allocation");
420 578
421 req->type = ix; 579 req->type = ix;
422 req->fh = newSVsv (fh); 580 req->fh = newSVsv (fh);
423 req->fd = PerlIO_fileno (IoIFP (sv_2io (fh))); 581 req->fd = PerlIO_fileno (IoIFP (sv_2io (fh)));
424 req->callback = SvREFCNT_inc (callback);
425 582
426 send_req (req); 583 send_req (req);
427} 584}
428 585
429void 586void
… …
440 PROTOTYPE: $$$$$;$ 597 PROTOTYPE: $$$$$;$
441 CODE: 598 CODE:
442{ 599{
443 aio_req req; 600 aio_req req;
444 STRLEN svlen; 601 STRLEN svlen;
445 char *svptr = SvPV (data, svlen); 602 char *svptr = SvPVbyte (data, svlen);
446 603
447 SvUPGRADE (data, SVt_PV); 604 SvUPGRADE (data, SVt_PV);
448 SvPOK_on (data); 605 SvPOK_on (data);
449 606
450 if (dataoffset < 0) 607 if (dataoffset < 0)
… …
466 } 623 }
467 624
468 if (length < 0) 625 if (length < 0)
469 croak ("length must not be negative"); 626 croak ("length must not be negative");
470 627
471 Newz (0, req, 1, aio_cb); 628 {
629 dREQ;
472 630
473 if (!req)
474 croak ("out of memory during aio_req allocation");
475
476 req->type = ix; 631 req->type = ix;
477 req->fh = newSVsv (fh); 632 req->fh = newSVsv (fh);
478 req->fd = PerlIO_fileno (ix == REQ_READ ? IoIFP (sv_2io (fh)) 633 req->fd = PerlIO_fileno (ix == REQ_READ ? IoIFP (sv_2io (fh))
479 : IoOFP (sv_2io (fh))); 634 : IoOFP (sv_2io (fh)));
480 req->offset = offset; 635 req->offset = offset;
481 req->length = length; 636 req->length = length;
482 req->data = SvREFCNT_inc (data); 637 req->data = SvREFCNT_inc (data);
483 req->dataptr = (char *)svptr + dataoffset; 638 req->dataptr = (char *)svptr + dataoffset;
484 req->callback = SvREFCNT_inc (callback);
485 639
640 if (!SvREADONLY (data))
641 {
642 SvREADONLY_on (data);
643 req->data2ptr = (void *)data;
644 }
645
486 send_req (req); 646 send_req (req);
647 }
487} 648}
488 649
489void 650void
490aio_readahead(fh,offset,length,callback=&PL_sv_undef) 651aio_readahead(fh,offset,length,callback=&PL_sv_undef)
491 SV * fh 652 SV * fh
… …
493 IV length 654 IV length
494 SV * callback 655 SV * callback
495 PROTOTYPE: $$$;$ 656 PROTOTYPE: $$$;$
496 CODE: 657 CODE:
497{ 658{
498 aio_req req; 659 dREQ;
499
500 if (length < 0)
501 croak ("length must not be negative");
502
503 Newz (0, req, 1, aio_cb);
504
505 if (!req)
506 croak ("out of memory during aio_req allocation");
507 660
508 req->type = REQ_READAHEAD; 661 req->type = REQ_READAHEAD;
509 req->fh = newSVsv (fh); 662 req->fh = newSVsv (fh);
510 req->fd = PerlIO_fileno (IoIFP (sv_2io (fh))); 663 req->fd = PerlIO_fileno (IoIFP (sv_2io (fh)));
511 req->offset = offset; 664 req->offset = offset;
512 req->length = length; 665 req->length = length;
513 req->callback = SvREFCNT_inc (callback);
514 666
515 send_req (req); 667 send_req (req);
516} 668}
517 669
518void 670void
… …
522 ALIAS: 674 ALIAS:
523 aio_stat = REQ_STAT 675 aio_stat = REQ_STAT
524 aio_lstat = REQ_LSTAT 676 aio_lstat = REQ_LSTAT
525 CODE: 677 CODE:
526{ 678{
527 aio_req req; 679 dREQ;
528
529 Newz (0, req, 1, aio_cb);
530
531 if (!req)
532 croak ("out of memory during aio_req allocation");
533 680
534 New (0, req->statdata, 1, Stat_t); 681 New (0, req->statdata, 1, Stat_t);
535
536 if (!req->statdata) 682 if (!req->statdata)
683 {
684 free_req (req);
537 croak ("out of memory during aio_req->statdata allocation"); 685 croak ("out of memory during aio_req->statdata allocation");
686 }
538 687
539 if (SvPOK (fh_or_path)) 688 if (SvPOK (fh_or_path))
540 { 689 {
541 req->type = ix; 690 req->type = ix;
542 req->data = newSVsv (fh_or_path); 691 req->data = newSVsv (fh_or_path);
543 req->dataptr = SvPV_nolen (req->data); 692 req->dataptr = SvPVbyte_nolen (req->data);
544 } 693 }
545 else 694 else
546 { 695 {
547 req->type = REQ_FSTAT; 696 req->type = REQ_FSTAT;
548 req->fh = newSVsv (fh_or_path); 697 req->fh = newSVsv (fh_or_path);
549 req->fd = PerlIO_fileno (IoIFP (sv_2io (fh_or_path))); 698 req->fd = PerlIO_fileno (IoIFP (sv_2io (fh_or_path)));
550 } 699 }
551 700
552 req->callback = SvREFCNT_inc (callback);
553
554 send_req (req); 701 send_req (req);
555} 702}
556 703
557void 704void
558aio_unlink(pathname,callback=&PL_sv_undef) 705aio_unlink(pathname,callback=&PL_sv_undef)
559 SV * pathname 706 SV * pathname
560 SV * callback 707 SV * callback
708 ALIAS:
709 aio_unlink = REQ_UNLINK
710 aio_rmdir = REQ_RMDIR
561 CODE: 711 CODE:
562{ 712{
563 aio_req req; 713 dREQ;
564 714
565 Newz (0, req, 1, aio_cb); 715 req->type = ix;
716 req->data = newSVsv (pathname);
717 req->dataptr = SvPVbyte_nolen (req->data);
566 718
567 if (!req) 719 send_req (req);
568 croak ("out of memory during aio_req allocation"); 720}
721
722void
723aio_symlink(oldpath,newpath,callback=&PL_sv_undef)
724 SV * oldpath
725 SV * newpath
726 SV * callback
727 CODE:
728{
729 dREQ;
569 730
570 req->type = REQ_UNLINK; 731 req->type = REQ_SYMLINK;
732 req->fh = newSVsv (oldpath);
733 req->data2ptr = SvPVbyte_nolen (req->fh);
571 req->data = newSVsv (pathname); 734 req->data = newSVsv (newpath);
572 req->dataptr = SvPV_nolen (req->data); 735 req->dataptr = SvPVbyte_nolen (req->data);
573 req->callback = SvREFCNT_inc (callback);
574 736
575 send_req (req); 737 send_req (req);
576} 738}
577 739
578void 740void

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines