ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/IO-AIO/AIO.xs
(Generate patch)

Comparing IO-AIO/AIO.xs (file contents):
Revision 1.134 by root, Sun Apr 19 13:05:06 2009 UTC vs.
Revision 1.148 by root, Wed Jun 17 01:14:48 2009 UTC

75 75
76#define EIO_STRUCT_STAT Stat_t 76#define EIO_STRUCT_STAT Stat_t
77 77
78/* use NV for 32 bit perls as it allows larger offsets */ 78/* use NV for 32 bit perls as it allows larger offsets */
79#if IVSIZE >= 8 79#if IVSIZE >= 8
80# define VAL64 IV
80# define SvVAL64 SvIV 81# define SvVAL64 SvIV
82# define newSVval64 newSViv
81#else 83#else
84# define VAL64 NV
82# define SvVAL64 SvNV 85# define SvVAL64 SvNV
86# define newSVval64 newSVnv
83#endif 87#endif
84 88
85/*****************************************************************************/ 89/*****************************************************************************/
86 90
87#if __GNUC__ >= 3 91#if __GNUC__ >= 3
95 99
96/*****************************************************************************/ 100/*****************************************************************************/
97 101
98static HV *stash; 102static HV *stash;
99typedef SV SV8; /* byte-sv, used for argument-checking */ 103typedef SV SV8; /* byte-sv, used for argument-checking */
104typedef int aio_rfd; /* read file desriptor */
105typedef int aio_wfd; /* write file descriptor */
100 106
101#define AIO_REQ_KLASS "IO::AIO::REQ" 107#define AIO_REQ_KLASS "IO::AIO::REQ"
102#define AIO_GRP_KLASS "IO::AIO::GRP" 108#define AIO_GRP_KLASS "IO::AIO::GRP"
103 109
104#define EIO_REQ_MEMBERS \ 110#define EIO_REQ_MEMBERS \
108 SV *self; 114 SV *self;
109 115
110#define EIO_NO_WRAPPERS 1 116#define EIO_NO_WRAPPERS 1
111 117
112#include "libeio/eio.h" 118#include "libeio/eio.h"
119
120#ifndef POSIX_FADV_NORMAL
121# define POSIX_FADV_NORMAL 0
122#endif
123
124#ifndef POSIX_FADV_SEQUENTIAL
125# define POSIX_FADV_SEQUENTIAL 0
126#endif
127
128#ifndef POSIX_FADV_RANDOM
129# define POSIX_FADV_RANDOM 0
130#endif
131
132#ifndef POSIX_FADV_NOREUSE
133# define POSIX_FADV_NOREUSE 0
134#endif
135
136#ifndef POSIX_FADV_WILLNEED
137# define POSIX_FADV_WILLNEED 0
138#endif
139
140#ifndef POSIX_FADV_DONTNEED
141# define POSIX_FADV_DONTNEED 0
142#endif
113 143
114static int req_invoke (eio_req *req); 144static int req_invoke (eio_req *req);
115#define EIO_FINISH(req) req_invoke (req) 145#define EIO_FINISH(req) req_invoke (req)
116static void req_destroy (eio_req *grp); 146static void req_destroy (eio_req *grp);
117#define EIO_DESTROY(req) req_destroy (req) 147#define EIO_DESTROY(req) req_destroy (req)
228 SV *rv = &PL_sv_undef; 258 SV *rv = &PL_sv_undef;
229 259
230 if (req->result >= 0) 260 if (req->result >= 0)
231 { 261 {
232 int i; 262 int i;
233 char *buf = req->ptr2; 263 char *names = (char *)req->ptr2;
264 eio_dirent *ent = (eio_dirent *)req->ptr1; /* might be 0 */
234 AV *av = newAV (); 265 AV *av = newAV ();
235 266
236 av_extend (av, req->result - 1); 267 av_extend (av, req->result - 1);
237 268
238 for (i = 0; i < req->result; ++i) 269 for (i = 0; i < req->result; ++i)
239 { 270 {
240 SV *sv = newSVpv (buf, 0); 271 if (req->int1 & EIO_READDIR_DENTS)
272 {
273 SV *namesv = newSVpvn (names + ent->nameofs, ent->namelen);
241 274
275 if (req->int1 & EIO_READDIR_CUSTOM2)
276 {
277 static SV *sv_type [EIO_DT_MAX + 1]; /* type sv cache */
278 AV *avent = newAV ();
279
280 av_extend (avent, 2);
281
282 if (!sv_type [ent->type])
283 {
284 sv_type [ent->type] = newSViv (ent->type);
285 SvREADONLY_on (sv_type [ent->type]);
286 }
287
288 av_store (avent, 0, namesv);
289 av_store (avent, 1, SvREFCNT_inc (sv_type [ent->type]));
290 av_store (avent, 2, IVSIZE >= 8 ? newSVuv (ent->inode) : newSVnv (ent->inode));
291
292 av_store (av, i, newRV_noinc ((SV *)avent));
293 }
294 else
242 av_store (av, i, sv); 295 av_store (av, i, namesv);
296
297 ++ent;
298 }
299 else
300 {
301 SV *name = newSVpv (names, 0);
302 av_store (av, i, name);
243 buf += SvCUR (sv) + 1; 303 names += SvCUR (name) + 1;
304 }
244 } 305 }
245 306
246 rv = sv_2mortal (newRV_noinc ((SV *)av)); 307 rv = sv_2mortal (newRV_noinc ((SV *)av));
247 } 308 }
248 309
249 PUSHs (rv); 310 PUSHs (rv);
311
312 if (req->int1 & EIO_READDIR_CUSTOM1)
313 XPUSHs (sv_2mortal (newSViv (req->int1 & ~(EIO_READDIR_CUSTOM1 | EIO_READDIR_CUSTOM2))));
250 } 314 }
251 break; 315 break;
252 316
253 case EIO_OPEN: 317 case EIO_OPEN:
254 { 318 {
260 GV *gv = (GV *)sv_newmortal (); 324 GV *gv = (GV *)sv_newmortal ();
261 int flags = req->int1 & (O_RDONLY | O_WRONLY | O_RDWR); 325 int flags = req->int1 & (O_RDONLY | O_WRONLY | O_RDWR);
262 char sym [64]; 326 char sym [64];
263 int symlen; 327 int symlen;
264 328
265 symlen = snprintf (sym, sizeof (sym), "fd#%d", req->result); 329 symlen = snprintf (sym, sizeof (sym), "fd#%d", (int)req->result);
266 gv_init (gv, stash, sym, symlen, 0); 330 gv_init (gv, stash, sym, symlen, 0);
267 331
268 symlen = snprintf ( 332 symlen = snprintf (
269 sym, 333 sym,
270 sizeof (sym), 334 sizeof (sym),
271 "%s&=%d", 335 "%s&=%d",
272 flags == O_RDONLY ? "<" : flags == O_WRONLY ? ">" : "+<", 336 flags == O_RDONLY ? "<" : flags == O_WRONLY ? ">" : "+<",
273 req->result 337 (int)req->result
274 ); 338 );
275 339
276 if (do_open (gv, sym, symlen, 0, 0, 0, 0)) 340 if (do_open (gv, sym, symlen, 0, 0, 0, 0))
277 fh = (SV *)gv; 341 fh = (SV *)gv;
278 } 342 }
312 PL_statcache = *(EIO_STRUCT_STAT *)(req->ptr2); 376 PL_statcache = *(EIO_STRUCT_STAT *)(req->ptr2);
313 PUSHs (sv_2mortal (newSViv (req->result))); 377 PUSHs (sv_2mortal (newSViv (req->result)));
314 break; 378 break;
315 379
316 case EIO_READ: 380 case EIO_READ:
381 {
317 SvCUR_set (req->sv2, req->stroffset + (req->result > 0 ? req->result : 0)); 382 SvCUR_set (req->sv2, req->stroffset + (req->result > 0 ? req->result : 0));
318 *SvEND (req->sv2) = 0; 383 *SvEND (req->sv2) = 0;
384 SvPOK_only (req->sv2);
385 SvSETMAGIC (req->sv2);
319 PUSHs (sv_2mortal (newSViv (req->result))); 386 PUSHs (sv_2mortal (newSViv (req->result)));
387 }
320 break; 388 break;
321 389
322 case EIO_DUP2: 390 case EIO_DUP2:
323 if (req->result > 0) 391 if (req->result > 0)
324 req->result = 0; 392 req->result = 0;
499 req_submit (req); \ 567 req_submit (req); \
500 SPAGAIN; \ 568 SPAGAIN; \
501 \ 569 \
502 if (GIMME_V != G_VOID) \ 570 if (GIMME_V != G_VOID) \
503 XPUSHs (req_sv (req, AIO_REQ_KLASS)); 571 XPUSHs (req_sv (req, AIO_REQ_KLASS));
504 572
573static int
574extract_fd (SV *fh, int wr)
575{
576 int fd = PerlIO_fileno (wr ? IoOFP (sv_2io (fh)) : IoIFP (sv_2io (fh)));
577
578 if (fd < 0)
579 croak ("illegal fh argument, either not an OS file or read/write mode mismatch");
580
581 return fd;
582}
583
505MODULE = IO::AIO PACKAGE = IO::AIO 584MODULE = IO::AIO PACKAGE = IO::AIO
506 585
507PROTOTYPES: ENABLE 586PROTOTYPES: ENABLE
508 587
509BOOT: 588BOOT:
510{ 589{
511 stash = gv_stashpv ("IO::AIO", 1); 590 static const struct {
512 591 const char *name;
513 newCONSTSUB (stash, "EXDEV", newSViv (EXDEV)); 592 IV iv;
514 newCONSTSUB (stash, "O_RDONLY", newSViv (O_RDONLY)); 593 } *civ, const_iv[] = {
515 newCONSTSUB (stash, "O_WRONLY", newSViv (O_WRONLY)); 594# define const_iv(name, value) { # name, (IV) value },
516 newCONSTSUB (stash, "O_CREAT", newSViv (O_CREAT)); 595# define const_eio(name) { # name, (IV) EIO_ ## name },
517 newCONSTSUB (stash, "O_TRUNC", newSViv (O_TRUNC)); 596 const_iv (EXDEV , EXDEV)
597 const_iv (ENOSYS , ENOSYS)
598 const_iv (O_RDONLY, O_RDONLY)
599 const_iv (O_WRONLY, O_WRONLY)
600 const_iv (O_CREAT , O_CREAT)
601 const_iv (O_TRUNC , O_TRUNC)
518#ifndef _WIN32 602#ifndef _WIN32
519 newCONSTSUB (stash, "S_IFIFO", newSViv (S_IFIFO)); 603 const_iv (S_IFIFO , S_IFIFO)
520#endif 604#endif
521 newCONSTSUB (stash, "S_IFIFO", newSViv (S_IFIFO)); 605 const_iv (FADV_NORMAL , POSIX_FADV_NORMAL)
522 newCONSTSUB (stash, "SYNC_FILE_RANGE_WAIT_BEFORE", newSViv (EIO_SYNC_FILE_RANGE_WAIT_BEFORE)); 606 const_iv (FADV_SEQUENTIAL, POSIX_FADV_SEQUENTIAL)
523 newCONSTSUB (stash, "SYNC_FILE_RANGE_WRITE" , newSViv (EIO_SYNC_FILE_RANGE_WRITE)); 607 const_iv (FADV_RANDOM , POSIX_FADV_RANDOM)
524 newCONSTSUB (stash, "SYNC_FILE_RANGE_WAIT_AFTER" , newSViv (EIO_SYNC_FILE_RANGE_WAIT_AFTER)); 608 const_iv (FADV_NOREUSE , POSIX_FADV_NOREUSE)
609 const_iv (FADV_WILLNEED , POSIX_FADV_WILLNEED)
610 const_iv (FADV_DONTNEED , POSIX_FADV_DONTNEED)
525 611
612 const_eio (SYNC_FILE_RANGE_WAIT_BEFORE)
613 const_eio (SYNC_FILE_RANGE_WRITE)
614 const_eio (SYNC_FILE_RANGE_WAIT_AFTER)
615
616 const_eio (READDIR_DENTS)
617 const_eio (READDIR_DIRS_FIRST)
618 const_eio (READDIR_STAT_ORDER)
619 const_eio (READDIR_FOUND_UNKNOWN)
620
621 const_eio (DT_UNKNOWN)
622 const_eio (DT_FIFO)
623 const_eio (DT_CHR)
624 const_eio (DT_DIR)
625 const_eio (DT_BLK)
626 const_eio (DT_REG)
627 const_eio (DT_LNK)
628 const_eio (DT_SOCK)
629 const_eio (DT_WHT)
630 };
631
632 stash = gv_stashpv ("IO::AIO", 1);
633
634 for (civ = const_iv + sizeof (const_iv) / sizeof (const_iv [0]); civ-- > const_iv; )
635 newCONSTSUB (stash, (char *)civ->name, newSViv (civ->iv));
636
526 create_respipe (); 637 create_respipe ();
527 638
528 if (eio_init (want_poll, done_poll) < 0) 639 if (eio_init (want_poll, done_poll) < 0)
529 croak ("IO::AIO: unable to initialise eio library"); 640 croak ("IO::AIO: unable to initialise eio library");
530 641
531 /* atfork child called in fifo order, so before eio's handler */ 642 /* atfork child called in fifo order, so before eio's handler */
532 X_THREAD_ATFORK (0, 0, atfork_child); 643 X_THREAD_ATFORK (0, 0, atfork_child);
533} 644}
534 645
535void 646void
536max_poll_reqs (int nreqs) 647max_poll_reqs (int nreqs)
537 PROTOTYPE: $ 648 PROTOTYPE: $
590 ALIAS: 701 ALIAS:
591 aio_fsync = EIO_FSYNC 702 aio_fsync = EIO_FSYNC
592 aio_fdatasync = EIO_FDATASYNC 703 aio_fdatasync = EIO_FDATASYNC
593 PPCODE: 704 PPCODE:
594{ 705{
706 int fd = extract_fd (fh, 0);
595 dREQ; 707 dREQ;
596 708
597 req->type = ix; 709 req->type = ix;
598 req->sv1 = newSVsv (fh); 710 req->sv1 = newSVsv (fh);
599 req->int1 = PerlIO_fileno (IoIFP (sv_2io (fh))); 711 req->int1 = fd;
600 712
601 REQ_SEND (req); 713 REQ_SEND (req);
602} 714}
603 715
604void 716void
605aio_sync_file_range (SV *fh, SV *offset, SV *nbytes, IV flags, SV *callback=&PL_sv_undef) 717aio_sync_file_range (SV *fh, off_t offset, size_t nbytes, UV flags, SV *callback=&PL_sv_undef)
606 PROTOTYPE: $$$$;$ 718 PROTOTYPE: $$$$;$
607 PPCODE: 719 PPCODE:
608{ 720{
721 int fd = extract_fd (fh, 0);
609 dREQ; 722 dREQ;
610 723
611 req->type = EIO_SYNC_FILE_RANGE; 724 req->type = EIO_SYNC_FILE_RANGE;
612 req->sv1 = newSVsv (fh); 725 req->sv1 = newSVsv (fh);
613 req->int1 = PerlIO_fileno (IoIFP (sv_2io (fh))); 726 req->int1 = fd;
614 req->offs = SvVAL64 (offset); 727 req->offs = offset;
615 req->size = SvVAL64 (nbytes); 728 req->size = nbytes;
616 req->int2 = flags; 729 req->int2 = flags;
617 730
618 REQ_SEND (req); 731 REQ_SEND (req);
619} 732}
620 733
622aio_close (SV *fh, SV *callback=&PL_sv_undef) 735aio_close (SV *fh, SV *callback=&PL_sv_undef)
623 PROTOTYPE: $;$ 736 PROTOTYPE: $;$
624 PPCODE: 737 PPCODE:
625{ 738{
626 static int close_pipe = -1; /* dummy fd to close fds via dup2 */ 739 static int close_pipe = -1; /* dummy fd to close fds via dup2 */
740 int fd = extract_fd (fh, 0);
627 dREQ; 741 dREQ;
628 742
629 if (close_pipe < 0) 743 if (close_pipe < 0)
630 { 744 {
631 int pipefd [2]; 745 int pipefd [2];
639 } 753 }
640 754
641 req->type = EIO_DUP2; 755 req->type = EIO_DUP2;
642 req->int1 = close_pipe; 756 req->int1 = close_pipe;
643 req->sv2 = newSVsv (fh); 757 req->sv2 = newSVsv (fh);
644 req->int2 = PerlIO_fileno (IoIFP (sv_2io (fh))); 758 req->int2 = fd;
645 759
646 REQ_SEND (req); 760 REQ_SEND (req);
647} 761}
648 762
649void 763void
653 aio_write = EIO_WRITE 767 aio_write = EIO_WRITE
654 PROTOTYPE: $$$$$;$ 768 PROTOTYPE: $$$$$;$
655 PPCODE: 769 PPCODE:
656{ 770{
657 STRLEN svlen; 771 STRLEN svlen;
772 int fd = extract_fd (fh, ix == EIO_WRITE);
658 char *svptr = SvPVbyte (data, svlen); 773 char *svptr = SvPVbyte (data, svlen);
659 UV len = SvUV (length); 774 UV len = SvUV (length);
660 int fd;
661
662 if (SvTYPE (data) > SVt_PVMG)
663 croak ("illegal data argument '%s', must be plain scalar string", SvPV_nolen (data));
664
665 SvUPGRADE (data, SVt_PV);
666 SvPOK_only (data);
667 775
668 if (dataoffset < 0) 776 if (dataoffset < 0)
669 dataoffset += svlen; 777 dataoffset += svlen;
670 778
671 if (dataoffset < 0 || dataoffset > svlen) 779 if (dataoffset < 0 || dataoffset > svlen)
677 if (!SvOK (length) || len + dataoffset > svlen) 785 if (!SvOK (length) || len + dataoffset > svlen)
678 len = svlen - dataoffset; 786 len = svlen - dataoffset;
679 } 787 }
680 else 788 else
681 { 789 {
682 /* read: grow scalar as necessary */ 790 /* read: check type and grow scalar as necessary */
791 SvUPGRADE (data, SVt_PV);
683 svptr = SvGROW (data, len + dataoffset + 1); 792 svptr = SvGROW (data, len + dataoffset + 1);
684 } 793 }
685
686 if (len < 0)
687 croak ("length must not be negative");
688
689 fd = PerlIO_fileno (ix == EIO_READ ? IoIFP (sv_2io (fh))
690 : IoOFP (sv_2io (fh)));
691
692 if (fd < 0)
693 croak ("illegal fh argument, either not an OS file or read/write mode mismatch");
694 794
695 { 795 {
696 dREQ; 796 dREQ;
697 797
698 req->type = ix; 798 req->type = ix;
699 req->sv1 = newSVsv (fh); 799 req->sv1 = newSVsv (fh);
700 req->int1 = df; 800 req->int1 = fd;
701 req->offs = SvOK (offset) ? SvVAL64 (offset) : -1; 801 req->offs = SvOK (offset) ? SvVAL64 (offset) : -1;
702 req->size = len; 802 req->size = len;
703 req->sv2 = SvREFCNT_inc (data); 803 req->sv2 = SvREFCNT_inc (data);
704 req->ptr2 = (char *)svptr + dataoffset; 804 req->ptr2 = (char *)svptr + dataoffset;
705 req->stroffset = dataoffset; 805 req->stroffset = dataoffset;
728 828
729 REQ_SEND; 829 REQ_SEND;
730} 830}
731 831
732void 832void
733aio_sendfile (SV *out_fh, SV *in_fh, SV *in_offset, UV length, SV *callback=&PL_sv_undef) 833aio_sendfile (SV *out_fh, SV *in_fh, off_t in_offset, size_t length, SV *callback=&PL_sv_undef)
734 PROTOTYPE: $$$$;$ 834 PROTOTYPE: $$$$;$
735 PPCODE: 835 PPCODE:
736{ 836{
837 int ifd = extract_fd (in_fh , 0);
838 int ofd = extract_fd (out_fh, 0);
737 dREQ; 839 dREQ;
738 840
739 req->type = EIO_SENDFILE; 841 req->type = EIO_SENDFILE;
740 req->sv1 = newSVsv (out_fh); 842 req->sv1 = newSVsv (out_fh);
741 req->int1 = PerlIO_fileno (IoIFP (sv_2io (out_fh))); 843 req->int1 = ofd;
742 req->sv2 = newSVsv (in_fh); 844 req->sv2 = newSVsv (in_fh);
743 req->int2 = PerlIO_fileno (IoIFP (sv_2io (in_fh))); 845 req->int2 = ifd;
744 req->offs = SvVAL64 (in_offset); 846 req->offs = in_offset;
745 req->size = length; 847 req->size = length;
746 848
747 REQ_SEND; 849 REQ_SEND;
748} 850}
749 851
750void 852void
751aio_readahead (SV *fh, SV *offset, IV length, SV *callback=&PL_sv_undef) 853aio_readahead (SV *fh, off_t offset, size_t length, SV *callback=&PL_sv_undef)
752 PROTOTYPE: $$$;$ 854 PROTOTYPE: $$$;$
753 PPCODE: 855 PPCODE:
754{ 856{
857 int fd = extract_fd (fh, 0);
755 dREQ; 858 dREQ;
756 859
757 req->type = EIO_READAHEAD; 860 req->type = EIO_READAHEAD;
758 req->sv1 = newSVsv (fh); 861 req->sv1 = newSVsv (fh);
759 req->int1 = PerlIO_fileno (IoIFP (sv_2io (fh))); 862 req->int1 = fd;
760 req->offs = SvVAL64 (offset); 863 req->offs = offset;
761 req->size = length; 864 req->size = length;
762 865
763 REQ_SEND; 866 REQ_SEND;
764} 867}
765 868
881 req->type = EIO_FCHOWN; 984 req->type = EIO_FCHOWN;
882 req->int1 = PerlIO_fileno (IoIFP (sv_2io (fh_or_path))); 985 req->int1 = PerlIO_fileno (IoIFP (sv_2io (fh_or_path)));
883 } 986 }
884 987
885 REQ_SEND; 988 REQ_SEND;
989}
990
991void
992aio_readdirx (SV8 *pathname, IV flags, SV *callback=&PL_sv_undef)
993 PPCODE:
994{
995 dREQ;
996
997 req->type = EIO_READDIR;
998 req->sv1 = newSVsv (pathname);
999 req->ptr1 = SvPVbyte_nolen (req->sv1);
1000 req->int1 = flags | EIO_READDIR_DENTS | EIO_READDIR_CUSTOM1;
1001
1002 if (flags & EIO_READDIR_DENTS)
1003 req->int1 |= EIO_READDIR_CUSTOM2;
1004
1005 REQ_SEND;
886} 1006}
887 1007
888void 1008void
889aio_unlink (SV8 *pathname, SV *callback=&PL_sv_undef) 1009aio_unlink (SV8 *pathname, SV *callback=&PL_sv_undef)
890 ALIAS: 1010 ALIAS:
1068 CODE: 1188 CODE:
1069 RETVAL = eio_nthreads (); 1189 RETVAL = eio_nthreads ();
1070 OUTPUT: 1190 OUTPUT:
1071 RETVAL 1191 RETVAL
1072 1192
1193int
1194fadvise (aio_rfd fh, off_t offset, off_t length, IV advice)
1195 PROTOTYPE: $$$$
1196 CODE:
1197{
1198 #if _XOPEN_SOURCE >= 600
1199 RETVAL = posix_fadvise (fh, offset, length, advice);
1200 #else
1201 RETVAL = errno = ENOSYS;
1202 #endif
1203}
1204 OUTPUT:
1205 RETVAL
1206
1207ssize_t
1208sendfile (aio_wfd ofh, aio_rfd ifh, off_t offset, size_t count)
1209 PROTOTYPE: $$$$
1210 CODE:
1211 eio_sendfile_sync (ofh, ifh, offset, count);
1212
1073void _on_next_submit (SV *cb) 1213void _on_next_submit (SV *cb)
1074 CODE: 1214 CODE:
1075 SvREFCNT_dec (on_next_submit); 1215 SvREFCNT_dec (on_next_submit);
1076 on_next_submit = SvOK (cb) ? newSVsv (cb) : 0; 1216 on_next_submit = SvOK (cb) ? newSVsv (cb) : 0;
1077 1217
1138 AV *av; 1278 AV *av;
1139 1279
1140 grp->errorno = errno; 1280 grp->errorno = errno;
1141 1281
1142 av = newAV (); 1282 av = newAV ();
1283 av_extend (av, items - 1);
1143 1284
1144 for (i = 1; i < items; ++i ) 1285 for (i = 1; i < items; ++i )
1145 av_push (av, newSVsv (ST (i))); 1286 av_push (av, newSVsv (ST (i)));
1146 1287
1147 SvREFCNT_dec (grp->sv1); 1288 SvREFCNT_dec (grp->sv1);

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines