ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/IO-AIO/AIO.xs
(Generate patch)

Comparing IO-AIO/AIO.xs (file contents):
Revision 1.142 by root, Sat Jun 6 18:19:35 2009 UTC vs.
Revision 1.153 by root, Wed Jul 15 01:36:04 2009 UTC

… …
3#include <errno.h> 3#include <errno.h>
4 4
5#include "EXTERN.h" 5#include "EXTERN.h"
6#include "perl.h" 6#include "perl.h"
7#include "XSUB.h" 7#include "XSUB.h"
8
9#include "schmorp.h"
8 10
9#include <stddef.h> 11#include <stddef.h>
10#include <stdlib.h> 12#include <stdlib.h>
11#include <errno.h> 13#include <errno.h>
12#include <sys/types.h> 14#include <sys/types.h>
… …
75 77
76#define EIO_STRUCT_STAT Stat_t 78#define EIO_STRUCT_STAT Stat_t
77 79
78/* use NV for 32 bit perls as it allows larger offsets */ 80/* use NV for 32 bit perls as it allows larger offsets */
79#if IVSIZE >= 8 81#if IVSIZE >= 8
82# define VAL64 IV
80# define SvVAL64 SvIV 83# define SvVAL64 SvIV
84# define newSVval64 newSViv
81#else 85#else
86# define VAL64 NV
82# define SvVAL64 SvNV 87# define SvVAL64 SvNV
88# define newSVval64 newSVnv
83#endif 89#endif
84 90
85/*****************************************************************************/ 91/*****************************************************************************/
86 92
87#if __GNUC__ >= 3 93#if __GNUC__ >= 3
… …
95 101
96/*****************************************************************************/ 102/*****************************************************************************/
97 103
98static HV *stash; 104static HV *stash;
99typedef SV SV8; /* byte-sv, used for argument-checking */ 105typedef SV SV8; /* byte-sv, used for argument-checking */
106typedef int aio_rfd; /* read file desriptor */
107typedef int aio_wfd; /* write file descriptor */
100 108
101#define AIO_REQ_KLASS "IO::AIO::REQ" 109#define AIO_REQ_KLASS "IO::AIO::REQ"
102#define AIO_GRP_KLASS "IO::AIO::GRP" 110#define AIO_GRP_KLASS "IO::AIO::GRP"
103 111
104#define EIO_REQ_MEMBERS \ 112#define EIO_REQ_MEMBERS \
… …
109 117
110#define EIO_NO_WRAPPERS 1 118#define EIO_NO_WRAPPERS 1
111 119
112#include "libeio/eio.h" 120#include "libeio/eio.h"
113 121
122#ifndef POSIX_FADV_NORMAL
123# define POSIX_FADV_NORMAL 0
124# define NO_FADVISE 1
125#endif
126
127#ifndef POSIX_FADV_SEQUENTIAL
128# define POSIX_FADV_SEQUENTIAL 0
129#endif
130
131#ifndef POSIX_FADV_RANDOM
132# define POSIX_FADV_RANDOM 0
133#endif
134
135#ifndef POSIX_FADV_NOREUSE
136# define POSIX_FADV_NOREUSE 0
137#endif
138
139#ifndef POSIX_FADV_WILLNEED
140# define POSIX_FADV_WILLNEED 0
141#endif
142
143#ifndef POSIX_FADV_DONTNEED
144# define POSIX_FADV_DONTNEED 0
145#endif
146
114static int req_invoke (eio_req *req); 147static int req_invoke (eio_req *req);
115#define EIO_FINISH(req) req_invoke (req) 148#define EIO_FINISH(req) req_invoke (req)
116static void req_destroy (eio_req *grp); 149static void req_destroy (eio_req *grp);
117#define EIO_DESTROY(req) req_destroy (req) 150#define EIO_DESTROY(req) req_destroy (req)
118 151
… …
127 160
128static SV *on_next_submit; 161static SV *on_next_submit;
129static int next_pri = EIO_PRI_DEFAULT; 162static int next_pri = EIO_PRI_DEFAULT;
130static int max_outstanding; 163static int max_outstanding;
131 164
132static int respipe_osf [2], respipe [2] = { -1, -1 }; 165static int respipe_osf [2];
166static s_epipe respipe;
133 167
134static void req_destroy (aio_req req); 168static void req_destroy (aio_req req);
135static void req_cancel (aio_req req); 169static void req_cancel (aio_req req);
136 170
137static void want_poll (void) 171static void want_poll (void)
138{ 172{
139 /* write a dummy byte to the pipe so fh becomes ready */ 173 /* write a dummy byte to the pipe so fh becomes ready */
140 respipe_write (respipe_osf [1], (const void *)&respipe_osf, 1); 174 s_epipe_signal (&respipe);
141} 175}
142 176
143static void done_poll (void) 177static void done_poll (void)
144{ 178{
145 /* read any signals sent by the worker threads */ 179 /* read any signals sent by the worker threads */
146 char buf [4]; 180 s_epipe_drain (&respipe);
147 while (respipe_read (respipe [0], buf, 4) == 4)
148 ;
149} 181}
150 182
151/* must be called at most once */ 183/* must be called at most once */
152static SV *req_sv (aio_req req, const char *klass) 184static SV *req_sv (aio_req req, const char *klass)
153{ 185{
… …
228 SV *rv = &PL_sv_undef; 260 SV *rv = &PL_sv_undef;
229 261
230 if (req->result >= 0) 262 if (req->result >= 0)
231 { 263 {
232 int i; 264 int i;
233 char *buf = req->ptr2; 265 char *names = (char *)req->ptr2;
266 eio_dirent *ent = (eio_dirent *)req->ptr1; /* might be 0 */
234 AV *av = newAV (); 267 AV *av = newAV ();
235 268
236 av_extend (av, req->result - 1); 269 av_extend (av, req->result - 1);
237 270
238 for (i = 0; i < req->result; ++i) 271 for (i = 0; i < req->result; ++i)
239 { 272 {
240 if (req->int1 & EIO_READDIR_DENTS) 273 if (req->int1 & EIO_READDIR_DENTS)
241 { 274 {
242 eio_dirent *ent = (eio_dirent *)buf;
243 SV *namesv = newSVpvn (ent->name, ent->namelen); 275 SV *namesv = newSVpvn (names + ent->nameofs, ent->namelen);
244 276
245 if (req->int1 & EIO_READDIR_CUSTOM2) 277 if (req->int1 & EIO_READDIR_CUSTOM2)
246 { 278 {
247 static SV *sv_type [EIO_DT_MAX + 1]; /* type sv cache */ 279 static SV *sv_type [EIO_DT_MAX + 1]; /* type sv cache */
248 AV *avent = newAV (); 280 AV *avent = newAV ();
… …
254 sv_type [ent->type] = newSViv (ent->type); 286 sv_type [ent->type] = newSViv (ent->type);
255 SvREADONLY_on (sv_type [ent->type]); 287 SvREADONLY_on (sv_type [ent->type]);
256 } 288 }
257 289
258 av_store (avent, 0, namesv); 290 av_store (avent, 0, namesv);
291 av_store (avent, 1, SvREFCNT_inc (sv_type [ent->type]));
259 av_store (avent, 1, IVSIZE >= 8 ? newSVuv (ent->inode) : newSVnv (ent->inode)); 292 av_store (avent, 2, IVSIZE >= 8 ? newSVuv (ent->inode) : newSVnv (ent->inode));
260 av_store (avent, 2, SvREFCNT_inc (sv_type [ent->type]));
261 293
262 av_store (av, i, newRV_noinc ((SV *)avent)); 294 av_store (av, i, newRV_noinc ((SV *)avent));
263 } 295 }
264 else 296 else
265 av_store (av, i, namesv); 297 av_store (av, i, namesv);
266 298
267 buf += sizeof (eio_dirent); 299 ++ent;
268 } 300 }
269 else 301 else
270 { 302 {
271 SV *name = newSVpv (buf, 0); 303 SV *name = newSVpv (names, 0);
272 av_store (av, i, name); 304 av_store (av, i, name);
273 buf += SvCUR (name) + 1; 305 names += SvCUR (name) + 1;
274 } 306 }
275 } 307 }
276 308
277 rv = sv_2mortal (newRV_noinc ((SV *)av)); 309 rv = sv_2mortal (newRV_noinc ((SV *)av));
278 } 310 }
… …
294 GV *gv = (GV *)sv_newmortal (); 326 GV *gv = (GV *)sv_newmortal ();
295 int flags = req->int1 & (O_RDONLY | O_WRONLY | O_RDWR); 327 int flags = req->int1 & (O_RDONLY | O_WRONLY | O_RDWR);
296 char sym [64]; 328 char sym [64];
297 int symlen; 329 int symlen;
298 330
299 symlen = snprintf (sym, sizeof (sym), "fd#%d", req->result); 331 symlen = snprintf (sym, sizeof (sym), "fd#%d", (int)req->result);
300 gv_init (gv, stash, sym, symlen, 0); 332 gv_init (gv, stash, sym, symlen, 0);
301 333
302 symlen = snprintf ( 334 symlen = snprintf (
303 sym, 335 sym,
304 sizeof (sym), 336 sizeof (sym),
305 "%s&=%d", 337 "%s&=%d",
306 flags == O_RDONLY ? "<" : flags == O_WRONLY ? ">" : "+<", 338 flags == O_RDONLY ? "<" : flags == O_WRONLY ? ">" : "+<",
307 req->result 339 (int)req->result
308 ); 340 );
309 341
310 if (do_open (gv, sym, symlen, 0, 0, 0, 0)) 342 if (do_open (gv, sym, symlen, 0, 0, 0, 0))
311 fh = (SV *)gv; 343 fh = (SV *)gv;
312 } 344 }
… …
408 grp->sv2 = 0; 440 grp->sv2 = 0;
409 441
410 eio_grp_cancel (grp); 442 eio_grp_cancel (grp);
411} 443}
412 444
413#ifdef USE_SOCKETS_AS_HANDLES
414# define TO_SOCKET(x) (win32_get_osfhandle (x))
415#else
416# define TO_SOCKET(x) (x)
417#endif
418
419static void 445static void
420create_respipe (void) 446create_respipe (void)
421{ 447{
422 int old_readfd = respipe [0];
423
424 if (respipe [1] >= 0)
425 respipe_close (TO_SOCKET (respipe [1]));
426
427#ifdef _WIN32
428 if (PerlSock_socketpair (AF_UNIX, SOCK_STREAM, 0, respipe))
429#else
430 if (pipe (respipe)) 448 if (s_epipe_renew (&respipe))
431#endif
432 croak ("unable to initialize result pipe"); 449 croak ("unable to initialize result pipe");
433 450
434 if (old_readfd >= 0)
435 {
436 if (dup2 (TO_SOCKET (respipe [0]), TO_SOCKET (old_readfd)) < 0)
437 croak ("unable to initialize result pipe(2)");
438
439 respipe_close (respipe [0]);
440 respipe [0] = old_readfd;
441 }
442
443#ifdef _WIN32
444 int arg = 1;
445 if (ioctlsocket (TO_SOCKET (respipe [0]), FIONBIO, &arg)
446 || ioctlsocket (TO_SOCKET (respipe [1]), FIONBIO, &arg))
447#else
448 if (fcntl (respipe [0], F_SETFL, O_NONBLOCK)
449 || fcntl (respipe [1], F_SETFL, O_NONBLOCK))
450#endif
451 croak ("unable to initialize result pipe(3)");
452
453 respipe_osf [0] = TO_SOCKET (respipe [0]); 451 respipe_osf [0] = S_TO_SOCKET (respipe.fd [0]);
454 respipe_osf [1] = TO_SOCKET (respipe [1]); 452 respipe_osf [1] = S_TO_SOCKET (respipe.fd [1]);
455} 453}
456 454
457static void poll_wait (void) 455static void poll_wait (void)
458{ 456{
459 fd_set rfd;
460
461 while (eio_nreqs ()) 457 while (eio_nreqs ())
462 { 458 {
463 int size; 459 int size;
464 460
465 X_LOCK (reslock); 461 X_LOCK (reslock);
… …
469 if (size) 465 if (size)
470 return; 466 return;
471 467
472 etp_maybe_start_thread (); 468 etp_maybe_start_thread ();
473 469
474 FD_ZERO (&rfd); 470 s_epipe_wait (&respipe);
475 FD_SET (respipe [0], &rfd);
476
477 PerlSock_select (respipe [0] + 1, &rfd, 0, 0, 0);
478 } 471 }
479} 472}
480 473
481static int poll_cb (void) 474static int poll_cb (void)
482{ 475{
… …
500} 493}
501 494
502static SV * 495static SV *
503get_cb (SV *cb_sv) 496get_cb (SV *cb_sv)
504{ 497{
505 HV *st; 498 SvGETMAGIC (cb_sv);
506 GV *gvp; 499 return SvOK (cb_sv) ? s_get_cv_croak (cb_sv) : 0;
507 CV *cv;
508
509 if (!SvOK (cb_sv))
510 return 0;
511
512 cv = sv_2cv (cb_sv, &st, &gvp, 0);
513
514 if (!cv)
515 croak ("IO::AIO callback must be undef or a CODE reference");
516
517 return (SV *)cv;
518} 500}
519 501
520#define dREQ \ 502#define dREQ \
521 SV *cb_cv; \ 503 SV *cb_cv; \
522 aio_req req; \ 504 aio_req req; \
… …
538 SPAGAIN; \ 520 SPAGAIN; \
539 \ 521 \
540 if (GIMME_V != G_VOID) \ 522 if (GIMME_V != G_VOID) \
541 XPUSHs (req_sv (req, AIO_REQ_KLASS)); 523 XPUSHs (req_sv (req, AIO_REQ_KLASS));
542 524
543static int
544extract_fd (SV *fh, int wr)
545{
546 int fd = PerlIO_fileno (wr ? IoOFP (sv_2io (fh)) : IoIFP (sv_2io (fh)));
547
548 if (fd < 0)
549 croak ("illegal fh argument, either not an OS file or read/write mode mismatch");
550
551 return fd;
552}
553
554MODULE = IO::AIO PACKAGE = IO::AIO 525MODULE = IO::AIO PACKAGE = IO::AIO
555 526
556PROTOTYPES: ENABLE 527PROTOTYPES: ENABLE
557 528
558BOOT: 529BOOT:
559{ 530{
560 stash = gv_stashpv ("IO::AIO", 1);
561
562 static const struct { 531 static const struct {
563 const char *name; 532 const char *name;
564 IV iv; 533 IV iv;
565 } *civ, const_iv[] = { 534 } *civ, const_iv[] = {
566# define const_iv(name, value) { # name, (IV) value }, 535# define const_iv(name, value) { # name, (IV) value },
… …
572 const_iv (O_CREAT , O_CREAT) 541 const_iv (O_CREAT , O_CREAT)
573 const_iv (O_TRUNC , O_TRUNC) 542 const_iv (O_TRUNC , O_TRUNC)
574#ifndef _WIN32 543#ifndef _WIN32
575 const_iv (S_IFIFO , S_IFIFO) 544 const_iv (S_IFIFO , S_IFIFO)
576#endif 545#endif
546 const_iv (FADV_NORMAL , POSIX_FADV_NORMAL)
547 const_iv (FADV_SEQUENTIAL, POSIX_FADV_SEQUENTIAL)
548 const_iv (FADV_RANDOM , POSIX_FADV_RANDOM)
549 const_iv (FADV_NOREUSE , POSIX_FADV_NOREUSE)
550 const_iv (FADV_WILLNEED , POSIX_FADV_WILLNEED)
551 const_iv (FADV_DONTNEED , POSIX_FADV_DONTNEED)
552
577 const_eio (SYNC_FILE_RANGE_WAIT_BEFORE) 553 const_eio (SYNC_FILE_RANGE_WAIT_BEFORE)
578 const_eio (SYNC_FILE_RANGE_WRITE) 554 const_eio (SYNC_FILE_RANGE_WRITE)
579 const_eio (SYNC_FILE_RANGE_WAIT_AFTER) 555 const_eio (SYNC_FILE_RANGE_WAIT_AFTER)
580 556
581 const_eio (READDIR_DENTS) 557 const_eio (READDIR_DENTS)
… …
592 const_eio (DT_LNK) 568 const_eio (DT_LNK)
593 const_eio (DT_SOCK) 569 const_eio (DT_SOCK)
594 const_eio (DT_WHT) 570 const_eio (DT_WHT)
595 }; 571 };
596 572
573 stash = gv_stashpv ("IO::AIO", 1);
574
597 for (civ = const_iv + sizeof (const_iv) / sizeof (const_iv [0]); civ-- > const_iv; ) 575 for (civ = const_iv + sizeof (const_iv) / sizeof (const_iv [0]); civ-- > const_iv; )
598 newCONSTSUB (stash, (char *)civ->name, newSViv (civ->iv)); 576 newCONSTSUB (stash, (char *)civ->name, newSViv (civ->iv));
599 577
600 create_respipe (); 578 create_respipe ();
601 579
… …
664 ALIAS: 642 ALIAS:
665 aio_fsync = EIO_FSYNC 643 aio_fsync = EIO_FSYNC
666 aio_fdatasync = EIO_FDATASYNC 644 aio_fdatasync = EIO_FDATASYNC
667 PPCODE: 645 PPCODE:
668{ 646{
669 int fd = extract_fd (fh, 0); 647 int fd = s_fileno_croak (fh, 0);
670 dREQ; 648 dREQ;
671 649
672 req->type = ix; 650 req->type = ix;
673 req->sv1 = newSVsv (fh); 651 req->sv1 = newSVsv (fh);
674 req->int1 = fd; 652 req->int1 = fd;
675 653
676 REQ_SEND (req); 654 REQ_SEND (req);
677} 655}
678 656
679void 657void
680aio_sync_file_range (SV *fh, SV *offset, SV *nbytes, IV flags, SV *callback=&PL_sv_undef) 658aio_sync_file_range (SV *fh, off_t offset, size_t nbytes, UV flags, SV *callback=&PL_sv_undef)
681 PROTOTYPE: $$$$;$ 659 PROTOTYPE: $$$$;$
682 PPCODE: 660 PPCODE:
683{ 661{
684 int fd = extract_fd (fh, 0); 662 int fd = s_fileno_croak (fh, 0);
685 dREQ; 663 dREQ;
686 664
687 req->type = EIO_SYNC_FILE_RANGE; 665 req->type = EIO_SYNC_FILE_RANGE;
688 req->sv1 = newSVsv (fh); 666 req->sv1 = newSVsv (fh);
689 req->int1 = fd; 667 req->int1 = fd;
690 req->offs = SvVAL64 (offset); 668 req->offs = offset;
691 req->size = SvVAL64 (nbytes); 669 req->size = nbytes;
692 req->int2 = flags; 670 req->int2 = flags;
693 671
694 REQ_SEND (req); 672 REQ_SEND (req);
695} 673}
696 674
… …
698aio_close (SV *fh, SV *callback=&PL_sv_undef) 676aio_close (SV *fh, SV *callback=&PL_sv_undef)
699 PROTOTYPE: $;$ 677 PROTOTYPE: $;$
700 PPCODE: 678 PPCODE:
701{ 679{
702 static int close_pipe = -1; /* dummy fd to close fds via dup2 */ 680 static int close_pipe = -1; /* dummy fd to close fds via dup2 */
703 int fd = extract_fd (fh, 0); 681 int fd = s_fileno_croak (fh, 0);
704 dREQ; 682 dREQ;
705 683
706 if (close_pipe < 0) 684 if (close_pipe < 0)
707 { 685 {
708 int pipefd [2]; 686 int pipefd [2];
… …
730 aio_write = EIO_WRITE 708 aio_write = EIO_WRITE
731 PROTOTYPE: $$$$$;$ 709 PROTOTYPE: $$$$$;$
732 PPCODE: 710 PPCODE:
733{ 711{
734 STRLEN svlen; 712 STRLEN svlen;
735 int fd = extract_fd (fh, ix == EIO_WRITE); 713 int fd = s_fileno_croak (fh, ix == EIO_WRITE);
736 char *svptr = SvPVbyte (data, svlen); 714 char *svptr = SvPVbyte (data, svlen);
737 UV len = SvUV (length); 715 UV len = SvUV (length);
738 716
739 if (dataoffset < 0) 717 if (dataoffset < 0)
740 dataoffset += svlen; 718 dataoffset += svlen;
… …
791 769
792 REQ_SEND; 770 REQ_SEND;
793} 771}
794 772
795void 773void
796aio_sendfile (SV *out_fh, SV *in_fh, SV *in_offset, UV length, SV *callback=&PL_sv_undef) 774aio_sendfile (SV *out_fh, SV *in_fh, off_t in_offset, size_t length, SV *callback=&PL_sv_undef)
797 PROTOTYPE: $$$$;$ 775 PROTOTYPE: $$$$;$
798 PPCODE: 776 PPCODE:
799{ 777{
800 int ifd = extract_fd (in_fh , 0); 778 int ifd = s_fileno_croak (in_fh , 0);
801 int ofd = extract_fd (out_fh, 0); 779 int ofd = s_fileno_croak (out_fh, 1);
802 dREQ; 780 dREQ;
803 781
804 req->type = EIO_SENDFILE; 782 req->type = EIO_SENDFILE;
805 req->sv1 = newSVsv (out_fh); 783 req->sv1 = newSVsv (out_fh);
806 req->int1 = ofd; 784 req->int1 = ofd;
807 req->sv2 = newSVsv (in_fh); 785 req->sv2 = newSVsv (in_fh);
808 req->int2 = ifd; 786 req->int2 = ifd;
809 req->offs = SvVAL64 (in_offset); 787 req->offs = in_offset;
810 req->size = length; 788 req->size = length;
811 789
812 REQ_SEND; 790 REQ_SEND;
813} 791}
814 792
815void 793void
816aio_readahead (SV *fh, SV *offset, IV length, SV *callback=&PL_sv_undef) 794aio_readahead (SV *fh, off_t offset, size_t length, SV *callback=&PL_sv_undef)
817 PROTOTYPE: $$$;$ 795 PROTOTYPE: $$$;$
818 PPCODE: 796 PPCODE:
819{ 797{
820 int fd = extract_fd (fh, 0); 798 int fd = s_fileno_croak (fh, 0);
821 dREQ; 799 dREQ;
822 800
823 req->type = EIO_READAHEAD; 801 req->type = EIO_READAHEAD;
824 req->sv1 = newSVsv (fh); 802 req->sv1 = newSVsv (fh);
825 req->int1 = fd; 803 req->int1 = fd;
826 req->offs = SvVAL64 (offset); 804 req->offs = offset;
827 req->size = length; 805 req->size = length;
828 806
829 REQ_SEND; 807 REQ_SEND;
830} 808}
831 809
… …
1101 1079
1102int 1080int
1103poll_fileno() 1081poll_fileno()
1104 PROTOTYPE: 1082 PROTOTYPE:
1105 CODE: 1083 CODE:
1106 RETVAL = respipe [0]; 1084 RETVAL = s_epipe_fd (&respipe);
1107 OUTPUT: 1085 OUTPUT:
1108 RETVAL 1086 RETVAL
1109 1087
1110int 1088int
1111poll_cb(...) 1089poll_cb(...)
… …
1151 CODE: 1129 CODE:
1152 RETVAL = eio_nthreads (); 1130 RETVAL = eio_nthreads ();
1153 OUTPUT: 1131 OUTPUT:
1154 RETVAL 1132 RETVAL
1155 1133
1134int
1135fadvise (aio_rfd fh, off_t offset, off_t length, IV advice)
1136 PROTOTYPE: $$$$
1137 CODE:
1138#if _XOPEN_SOURCE >= 600 && !NO_FADVISE
1139 RETVAL = posix_fadvise (fh, offset, length, advice);
1140#else
1141 RETVAL = errno = ENOSYS;
1142#endif
1143 OUTPUT:
1144 RETVAL
1145
1146ssize_t
1147sendfile (aio_wfd ofh, aio_rfd ifh, off_t offset, size_t count)
1148 PROTOTYPE: $$$$
1149 CODE:
1150 eio_sendfile_sync (ofh, ifh, offset, count);
1151
1156void _on_next_submit (SV *cb) 1152void _on_next_submit (SV *cb)
1157 CODE: 1153 CODE:
1158 SvREFCNT_dec (on_next_submit); 1154 SvREFCNT_dec (on_next_submit);
1159 on_next_submit = SvOK (cb) ? newSVsv (cb) : 0; 1155 on_next_submit = SvOK (cb) ? newSVsv (cb) : 0;
1160 1156
… …
1174 if (GIMME_V != G_VOID) 1170 if (GIMME_V != G_VOID)
1175 XPUSHs (req->callback ? sv_2mortal (newRV_inc (req->callback)) : &PL_sv_undef); 1171 XPUSHs (req->callback ? sv_2mortal (newRV_inc (req->callback)) : &PL_sv_undef);
1176 1172
1177 if (items > 1) 1173 if (items > 1)
1178 { 1174 {
1179 SV *cb_cv = get_cb (callback); 1175 SV *cb_cv =get_cb (callback);
1180 1176
1181 SvREFCNT_dec (req->callback); 1177 SvREFCNT_dec (req->callback);
1182 req->callback = SvREFCNT_inc (cb_cv); 1178 req->callback = SvREFCNT_inc (cb_cv);
1183 } 1179 }
1184} 1180}

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines