[ViewVC] Diff of: cvs/IO-AIO/AIO.xs

Comparing IO-AIO/AIO.xs (file contents):
Revision 1.4 by root, Sun Jul 10 20:57:00 2005 UTC vs.
Revision 1.20 by root, Sun Jul 31 19:08:39 2005 UTC

…		…
1	#define PERL_NO_GET_CONTEXT	1	#define _REENTRANT 1
		2	#include <errno.h>
2		3
3	#include "EXTERN.h"	4	#include "EXTERN.h"
4	#include "perl.h"	5	#include "perl.h"
5	#include "XSUB.h"	6	#include "XSUB.h"
6		7
		8	#include "autoconf/config.h"
		9
7	#include <sys/types.h>	10	#include <sys/types.h>
8	#include <sys/stat.h>	11	#include <sys/stat.h>
		12
9	#include <unistd.h>	13	#include <unistd.h>
10	#include <fcntl.h>	14	#include <fcntl.h>
11	#include <signal.h>	15	#include <signal.h>
12	#include <sched.h>	16	#include <sched.h>
13	#include <endian.h>
14		17
15	#include <pthread.h>	18	#include <pthread.h>
16	#include <sys/syscall.h>
17		19
18	typedef void InputStream; / hack, but 5.6.1 is simply toooo old ;) */	20	typedef void InputStream; / hack, but 5.6.1 is simply toooo old ;) */
19	typedef void OutputStream; / hack, but 5.6.1 is simply toooo old ;) */	21	typedef void OutputStream; / hack, but 5.6.1 is simply toooo old ;) */
20	typedef void InOutStream; / hack, but 5.6.1 is simply toooo old ;) */	22	typedef void InOutStream; / hack, but 5.6.1 is simply toooo old ;) */
21		23
42	off_t offset;	44	off_t offset;
43	size_t length;	45	size_t length;
44	ssize_t result;	46	ssize_t result;
45	mode_t mode; /* open */	47	mode_t mode; /* open */
46	int errorno;	48	int errorno;
47	SV data, callback;	49	SV data, callback, *fh;
48	void *dataptr;	50	void *dataptr;
49	STRLEN dataoffset;	51	STRLEN dataoffset;
50		52
51	Stat_t *statdata;	53	Stat_t *statdata;
52	} aio_cb;	54	} aio_cb;
53		55
54	typedef aio_cb *aio_req;	56	typedef aio_cb *aio_req;
55		57
56	static int started;	58	static int started;
57	static int nreqs;	59	static volatile int nreqs;
58	static int max_outstanding = 1<<30;	60	static int max_outstanding = 1<<30;
59	static int respipe [2];	61	static int respipe [2];
60		62
61	static pthread_mutex_t reslock = PTHREAD_MUTEX_INITIALIZER;	63	static pthread_mutex_t reslock = PTHREAD_MUTEX_INITIALIZER;
62	static pthread_mutex_t reqlock = PTHREAD_MUTEX_INITIALIZER;	64	static pthread_mutex_t reqlock = PTHREAD_MUTEX_INITIALIZER;
…		…
66	static volatile aio_req ress, rese; /* queue start, queue end */	68	static volatile aio_req ress, rese; /* queue start, queue end */
67		69
68	static void	70	static void
69	poll_wait ()	71	poll_wait ()
70	{	72	{
71	if (!nreqs)	73	if (nreqs && !ress)
72	return;	74	{
73
74	fd_set rfd;	75	fd_set rfd;
75	FD_ZERO(&rfd);	76	FD_ZERO(&rfd);
76	FD_SET(respipe [0], &rfd);	77	FD_SET(respipe [0], &rfd);
77		78
78	select (respipe [0] + 1, &rfd, 0, 0, 0);	79	select (respipe [0] + 1, &rfd, 0, 0, 0);
		80	}
79	}	81	}
80		82
81	static int	83	static int
82	poll_cb (pTHX)	84	poll_cb ()
83	{	85	{
84	dSP;	86	dSP;
85	int count = 0;	87	int count = 0;
86	aio_req req;	88	aio_req req, prv;
87		89
		90	pthread_mutex_lock (&reslock);
		91
88	{	92	{
89	/* read and signals sent by the worker threads */	93	/* read any signals sent by the worker threads */
90	char buf [32];	94	char buf [32];
91	while (read (respipe [0], buf, 32) > 0)	95	while (read (respipe [0], buf, 32) > 0)
92	;	96	;
93	}	97	}
94		98
95	for (;;)	99	req = ress;
		100	ress = rese = 0;
		101
		102	pthread_mutex_unlock (&reslock);
		103
		104	while (req)
96	{	105	{
97	pthread_mutex_lock (&reslock);
98
99	req = ress;
100
101	if (ress)
102	{
103	ress = ress->next;
104	if (!ress) rese = 0;
105	}
106
107	pthread_mutex_unlock (&reslock);
108
109	if (!req)
110	break;
111
112	nreqs--;	106	nreqs--;
113		107
114	if (req->type == REQ_QUIT)	108	if (req->type == REQ_QUIT)
115	started--;	109	started--;
116	else	110	else
…		…
123	+ req->result > 0 ? req->result : 0);	117	+ req->result > 0 ? req->result : 0);
124		118
125	if (req->data)	119	if (req->data)
126	SvREFCNT_dec (req->data);	120	SvREFCNT_dec (req->data);
127		121
		122	if (req->fh)
		123	SvREFCNT_dec (req->fh);
		124
128	if (req->type == REQ_STAT \|\| req->type == REQ_LSTAT \|\| req->type == REQ_FSTAT)	125	if (req->type == REQ_STAT \|\| req->type == REQ_LSTAT \|\| req->type == REQ_FSTAT)
129	{	126	{
130	PL_laststype = req->type == REQ_LSTAT ? OP_LSTAT : OP_STAT;	127	PL_laststype = req->type == REQ_LSTAT ? OP_LSTAT : OP_STAT;
131	PL_laststatval = req->result;	128	PL_laststatval = req->result;
132	PL_statcache = *(req->statdata);	129	PL_statcache = *(req->statdata);
133		130
134	Safefree (req->statdata);	131	Safefree (req->statdata);
135	}	132	}
136		133
		134	ENTER;
137	PUSHMARK (SP);	135	PUSHMARK (SP);
138	XPUSHs (sv_2mortal (newSViv (req->result)));	136	XPUSHs (sv_2mortal (newSViv (req->result)));
139		137
140	if (req->type == REQ_OPEN)	138	if (req->type == REQ_OPEN)
141	{	139	{
…		…
144		142
145	PUTBACK;	143	PUTBACK;
146	call_pv ("IO::AIO::_fd2fh", G_SCALAR \| G_EVAL);	144	call_pv ("IO::AIO::_fd2fh", G_SCALAR \| G_EVAL);
147	SPAGAIN;	145	SPAGAIN;
148		146
149	fh = POPs;	147	fh = SvREFCNT_inc (POPs);
150		148
151	PUSHMARK (SP);	149	PUSHMARK (SP);
152	XPUSHs (fh);	150	XPUSHs (sv_2mortal (fh));
153	}	151	}
154		152
		153	if (SvOK (req->callback))
		154	{
155	PUTBACK;	155	PUTBACK;
156	call_sv (req->callback, G_VOID \| G_EVAL);	156	call_sv (req->callback, G_VOID \| G_EVAL);
157	SPAGAIN;	157	SPAGAIN;
		158	}
		159
		160	LEAVE;
158		161
159	if (req->callback)	162	if (req->callback)
160	SvREFCNT_dec (req->callback);	163	SvREFCNT_dec (req->callback);
161		164
162	errno = errorno;	165	errno = errorno;
163	count++;	166	count++;
164	}	167	}
165		168
		169	prv = req;
		170	req = req->next;
166	Safefree (req);	171	Safefree (prv);
		172
		173	/* TODO: croak on errors? */
167	}	174	}
168		175
169	return count;	176	return count;
170	}	177	}
171		178
…		…
226	req->type = REQ_QUIT;	233	req->type = REQ_QUIT;
227		234
228	send_req (req);	235	send_req (req);
229	}	236	}
230		237
231	static void	238	/* work around various missing functions */
232	read_write (pTHX_
233	int dowrite, int fd, off_t offset, size_t length,
234	SV data, STRLEN dataoffset, SV callback)
235	{
236	aio_req req;
237	STRLEN svlen;
238	char *svptr = SvPV (data, svlen);
239		239
240	SvUPGRADE (data, SVt_PV);	240	#if !HAVE_PREADWRITE
241	SvPOK_on (data);	241	# define pread aio_pread
		242	# define pwrite aio_pwrite
242		243
243	if (dataoffset < 0)	244	/*
244	dataoffset += svlen;	245	* make our pread/pwrite safe against themselves, but not against
		246	* normal read/write by using a mutex. slows down execution a lot,
		247	* but that's your problem, not mine.
		248	*/
		249	static pthread_mutex_t iolock = PTHREAD_MUTEX_INITIALIZER;
245		250
246	if (dataoffset < 0 \|\| dataoffset > svlen)	251	static ssize_t
247	croak ("data offset outside of string");	252	pread (int fd, void *buf, size_t count, off_t offset)
		253	{
		254	ssize_t res;
		255	off_t ooffset;
248		256
249	if (dowrite)	257	pthread_mutex_lock (&iolock);
		258	ooffset = lseek (fd, 0, SEEK_CUR);
		259	lseek (fd, offset, SEEK_SET);
		260	res = read (fd, buf, count);
		261	lseek (fd, ooffset, SEEK_SET);
		262	pthread_mutex_unlock (&iolock);
		263
		264	return res;
		265	}
		266
		267	static ssize_t
		268	pwrite (int fd, void *buf, size_t count, off_t offset)
		269	{
		270	ssize_t res;
		271	off_t ooffset;
		272
		273	pthread_mutex_lock (&iolock);
		274	ooffset = lseek (fd, 0, SEEK_CUR);
		275	lseek (fd, offset, SEEK_SET);
		276	res = write (fd, buf, count);
		277	lseek (fd, offset, SEEK_SET);
		278	pthread_mutex_unlock (&iolock);
		279
		280	return res;
		281	}
		282	#endif
		283
		284	#if !HAVE_FDATASYNC
		285	# define fdatasync fsync
		286	#endif
		287
		288	#if !HAVE_READAHEAD
		289	# define readahead aio_readahead
		290
		291	static char readahead_buf[4096];
		292
		293	static ssize_t
		294	readahead (int fd, off_t offset, size_t count)
		295	{
		296	while (count > 0)
250	{	297	{
251	/* write: check length and adjust. */	298	size_t len = count < sizeof (readahead_buf) ? count : sizeof (readahead_buf);
252	if (length < 0 \|\| length + dataoffset > svlen)	299
253	length = svlen - dataoffset;	300	pread (fd, readahead_buf, len, offset);
		301	offset += len;
		302	count -= len;
254	}	303	}
255	else
256	{
257	/* read: grow scalar as necessary */
258	svptr = SvGROW (data, length + dataoffset);
259	}
260		304
261	if (length < 0)	305	errno = 0;
262	croak ("length must not be negative");
263
264	Newz (0, req, 1, aio_cb);
265
266	if (!req)
267	croak ("out of memory during aio_req allocation");
268
269	req->type = dowrite ? REQ_WRITE : REQ_READ;
270	req->fd = fd;
271	req->offset = offset;
272	req->length = length;
273	req->data = SvREFCNT_inc (data);
274	req->dataptr = (char *)svptr + dataoffset;
275	req->callback = SvREFCNT_inc (callback);
276
277	send_req (req);
278	}	306	}
		307	#endif
279		308
280	static void *	309	static void *
281	aio_proc (void *thr_arg)	310	aio_proc (void *thr_arg)
282	{	311	{
283	aio_req req;	312	aio_req req;
…		…
309		338
310	type = req->type;	339	type = req->type;
311		340
312	switch (type)	341	switch (type)
313	{	342	{
314	case REQ_READ: req->result = pread64 (req->fd, req->dataptr, req->length, req->offset); break;	343	case REQ_READ: req->result = pread (req->fd, req->dataptr, req->length, req->offset); break;
315	case REQ_WRITE: req->result = pwrite64 (req->fd, req->dataptr, req->length, req->offset); break;	344	case REQ_WRITE: req->result = pwrite (req->fd, req->dataptr, req->length, req->offset); break;
316	#if SYS_readahead	345
317	case REQ_READAHEAD: req->result = readahead (req->fd, req->offset, req->length); break;	346	case REQ_READAHEAD: req->result = readahead (req->fd, req->offset, req->length); break;
318	#else
319	case REQ_READAHEAD: req->result = -1; errno = ENOSYS; break;
320	#endif
321		347
322	case REQ_STAT: req->result = stat (req->dataptr, req->statdata); break;	348	case REQ_STAT: req->result = stat (req->dataptr, req->statdata); break;
323	case REQ_LSTAT: req->result = lstat (req->dataptr, req->statdata); break;	349	case REQ_LSTAT: req->result = lstat (req->dataptr, req->statdata); break;
324	case REQ_FSTAT: req->result = fstat (req->fd , req->statdata); break;	350	case REQ_FSTAT: req->result = fstat (req->fd , req->statdata); break;
325		351
326	case REQ_OPEN: req->result = open (req->dataptr, req->fd, req->mode); break;	352	case REQ_OPEN: req->result = open (req->dataptr, req->fd, req->mode); break;
327	case REQ_CLOSE: req->result = close (req->fd); break;	353	case REQ_CLOSE: req->result = close (req->fd); break;
328	case REQ_UNLINK: req->result = unlink (req->dataptr); break;	354	case REQ_UNLINK: req->result = unlink (req->dataptr); break;
329		355
		356	case REQ_FDATASYNC: req->result = fdatasync (req->fd); break;
330	case REQ_FSYNC: req->result = fsync (req->fd); break;	357	case REQ_FSYNC: req->result = fsync (req->fd); break;
331	case REQ_FDATASYNC: req->result = fdatasync (req->fd); break;
332		358
333	case REQ_QUIT:	359	case REQ_QUIT:
334	break;	360	break;
335		361
336	default:	362	default:
…		…
364	return 0;	390	return 0;
365	}	391	}
366		392
367	MODULE = IO::AIO PACKAGE = IO::AIO	393	MODULE = IO::AIO PACKAGE = IO::AIO
368		394
		395	PROTOTYPES: ENABLE
		396
369	BOOT:	397	BOOT:
370	{	398	{
371	if (pipe (respipe))	399	if (pipe (respipe))
372	croak ("unable to initialize result pipe");	400	croak ("unable to initialize result pipe");
373		401
…		…
400	}	428	}
401		429
402	while (started > nthreads)	430	while (started > nthreads)
403	{	431	{
404	poll_wait ();	432	poll_wait ();
405	poll_cb (aTHX);	433	poll_cb ();
406	}	434	}
407	}	435	}
408		436
409	int	437	int
410	max_outstanding(nreqs)	438	max_outstanding(nreqs)
…		…
413	CODE:	441	CODE:
414	RETVAL = max_outstanding;	442	RETVAL = max_outstanding;
415	max_outstanding = nreqs;	443	max_outstanding = nreqs;
416		444
417	void	445	void
418	aio_open(pathname,flags,mode,callback)	446	aio_open(pathname,flags,mode,callback=&PL_sv_undef)
419	SV * pathname	447	SV * pathname
420	int flags	448	int flags
421	int mode	449	int mode
422	SV * callback	450	SV * callback
423	PROTOTYPE: $$$$	451	PROTOTYPE: $$$;$
424	CODE:	452	CODE:
425	{	453	{
426	aio_req req;	454	aio_req req;
427		455
428	Newz (0, req, 1, aio_cb);	456	Newz (0, req, 1, aio_cb);
…		…
439		467
440	send_req (req);	468	send_req (req);
441	}	469	}
442		470
443	void	471	void
444	aio_close(fh,callback)	472	aio_close(fh,callback=&PL_sv_undef)
445	InputStream fh	473	SV * fh
446	SV * callback	474	SV * callback
447	PROTOTYPE: $$	475	PROTOTYPE: $;$
448	ALIAS:	476	ALIAS:
449	aio_close = REQ_CLOSE	477	aio_close = REQ_CLOSE
450	aio_fsync = REQ_FSYNC	478	aio_fsync = REQ_FSYNC
451	aio_fdatasync = REQ_FDATASYNC	479	aio_fdatasync = REQ_FDATASYNC
452	CODE:	480	CODE:
…		…
457		485
458	if (!req)	486	if (!req)
459	croak ("out of memory during aio_req allocation");	487	croak ("out of memory during aio_req allocation");
460		488
461	req->type = ix;	489	req->type = ix;
		490	req->fh = newSVsv (fh);
462	req->fd = PerlIO_fileno (fh);	491	req->fd = PerlIO_fileno (IoIFP (sv_2io (fh)));
463	req->callback = SvREFCNT_inc (callback);	492	req->callback = SvREFCNT_inc (callback);
464		493
465	send_req (req);	494	send_req (req);
466	}	495	}
467		496
468	void	497	void
469	aio_read(fh,offset,length,data,dataoffset,callback)	498	aio_read(fh,offset,length,data,dataoffset,callback=&PL_sv_undef)
470	InputStream fh	499	SV * fh
471	UV offset	500	UV offset
472	IV length	501	IV length
473	SV * data	502	SV * data
474	IV dataoffset	503	IV dataoffset
475	SV * callback	504	SV * callback
		505	ALIAS:
		506	aio_read = REQ_READ
		507	aio_write = REQ_WRITE
476	PROTOTYPE: $$$$$$	508	PROTOTYPE: $$$$$;$
477	CODE:	509	CODE:
478	read_write (aTHX_ 0, PerlIO_fileno (fh), offset, length, data, dataoffset, callback);
479
480	void
481	aio_write(fh,offset,length,data,dataoffset,callback)
482	OutputStream fh
483	UV offset
484	IV length
485	SV * data
486	IV dataoffset
487	SV * callback
488	PROTOTYPE: $$$$$$
489	CODE:
490	read_write (aTHX_ 1, PerlIO_fileno (fh), offset, length, data, dataoffset, callback);
491
492	void
493	aio_readahead(fh,offset,length,callback)
494	InputStream fh
495	UV offset
496	IV length
497	SV * callback
498	PROTOTYPE: $$$$
499	CODE:
500	{	510	{
501	aio_req req;	511	aio_req req;
		512	STRLEN svlen;
		513	char *svptr = SvPV (data, svlen);
		514
		515	SvUPGRADE (data, SVt_PV);
		516	SvPOK_on (data);
		517
		518	if (dataoffset < 0)
		519	dataoffset += svlen;
		520
		521	if (dataoffset < 0 \|\| dataoffset > svlen)
		522	croak ("data offset outside of string");
		523
		524	if (ix == REQ_WRITE)
		525	{
		526	/* write: check length and adjust. */
		527	if (length < 0 \|\| length + dataoffset > svlen)
		528	length = svlen - dataoffset;
		529	}
		530	else
		531	{
		532	/* read: grow scalar as necessary */
		533	svptr = SvGROW (data, length + dataoffset);
		534	}
502		535
503	if (length < 0)	536	if (length < 0)
504	croak ("length must not be negative");	537	croak ("length must not be negative");
505		538
506	Newz (0, req, 1, aio_cb);	539	Newz (0, req, 1, aio_cb);
507		540
508	if (!req)	541	if (!req)
509	croak ("out of memory during aio_req allocation");	542	croak ("out of memory during aio_req allocation");
510		543
		544	req->type = ix;
		545	req->fh = newSVsv (fh);
		546	req->fd = PerlIO_fileno (ix == REQ_READ ? IoIFP (sv_2io (fh))
		547	: IoOFP (sv_2io (fh)));
		548	req->offset = offset;
		549	req->length = length;
		550	req->data = SvREFCNT_inc (data);
		551	req->dataptr = (char *)svptr + dataoffset;
		552	req->callback = SvREFCNT_inc (callback);
		553
		554	send_req (req);
		555	}
		556
		557	void
		558	aio_readahead(fh,offset,length,callback=&PL_sv_undef)
		559	SV * fh
		560	UV offset
		561	IV length
		562	SV * callback
		563	PROTOTYPE: $$$;$
		564	CODE:
		565	{
		566	aio_req req;
		567
		568	if (length < 0)
		569	croak ("length must not be negative");
		570
		571	Newz (0, req, 1, aio_cb);
		572
		573	if (!req)
		574	croak ("out of memory during aio_req allocation");
		575
511	req->type = REQ_READAHEAD;	576	req->type = REQ_READAHEAD;
		577	req->fh = newSVsv (fh);
512	req->fd = PerlIO_fileno (fh);	578	req->fd = PerlIO_fileno (IoIFP (sv_2io (fh)));
513	req->offset = offset;	579	req->offset = offset;
514	req->length = length;	580	req->length = length;
515	req->callback = SvREFCNT_inc (callback);	581	req->callback = SvREFCNT_inc (callback);
516		582
517	send_req (req);	583	send_req (req);
518	}	584	}
519		585
520	void	586	void
521	aio_stat(fh_or_path,callback)	587	aio_stat(fh_or_path,callback=&PL_sv_undef)
522	SV * fh_or_path	588	SV * fh_or_path
523	SV * callback	589	SV * callback
524	PROTOTYPE: $$
525	ALIAS:	590	ALIAS:
		591	aio_stat = REQ_STAT
526	aio_lstat = 1	592	aio_lstat = REQ_LSTAT
527	CODE:	593	CODE:
528	{	594	{
529	aio_req req;	595	aio_req req;
530		596
531	Newz (0, req, 1, aio_cb);	597	Newz (0, req, 1, aio_cb);
…		…
538	if (!req->statdata)	604	if (!req->statdata)
539	croak ("out of memory during aio_req->statdata allocation");	605	croak ("out of memory during aio_req->statdata allocation");
540		606
541	if (SvPOK (fh_or_path))	607	if (SvPOK (fh_or_path))
542	{	608	{
543	req->type = ix ? REQ_LSTAT : REQ_STAT;	609	req->type = ix;
544	req->data = newSVsv (fh_or_path);	610	req->data = newSVsv (fh_or_path);
545	req->dataptr = SvPV_nolen (req->data);	611	req->dataptr = SvPV_nolen (req->data);
546	}	612	}
547	else	613	else
548	{	614	{
549	req->type = REQ_FSTAT;	615	req->type = REQ_FSTAT;
		616	req->fh = newSVsv (fh_or_path);
550	req->fd = PerlIO_fileno (IoIFP (sv_2io (fh_or_path)));	617	req->fd = PerlIO_fileno (IoIFP (sv_2io (fh_or_path)));
551	}	618	}
552		619
553	req->callback = SvREFCNT_inc (callback);	620	req->callback = SvREFCNT_inc (callback);
554		621
555	send_req (req);	622	send_req (req);
556	}	623	}
557		624
558	void	625	void
559	aio_unlink(pathname,callback)	626	aio_unlink(pathname,callback=&PL_sv_undef)
560	SV * pathname	627	SV * pathname
561	SV * callback	628	SV * callback
562	PROTOTYPE: $$
563	CODE:	629	CODE:
564	{	630	{
565	aio_req req;	631	aio_req req;
566		632
567	Newz (0, req, 1, aio_cb);	633	Newz (0, req, 1, aio_cb);
…		…
575	req->callback = SvREFCNT_inc (callback);	641	req->callback = SvREFCNT_inc (callback);
576		642
577	send_req (req);	643	send_req (req);
578	}	644	}
579		645
		646	void
		647	flush()
		648	PROTOTYPE:
		649	CODE:
		650	while (nreqs)
		651	{
		652	poll_wait ();
		653	poll_cb ();
		654	}
		655
		656	void
		657	poll()
		658	PROTOTYPE:
		659	CODE:
		660	if (nreqs)
		661	{
		662	poll_wait ();
		663	poll_cb ();
		664	}
		665
580	int	666	int
581	poll_fileno()	667	poll_fileno()
582	PROTOTYPE:	668	PROTOTYPE:
583	CODE:	669	CODE:
584	RETVAL = respipe [0];	670	RETVAL = respipe [0];
…		…
587		673
588	int	674	int
589	poll_cb(...)	675	poll_cb(...)
590	PROTOTYPE:	676	PROTOTYPE:
591	CODE:	677	CODE:
592	RETVAL = poll_cb (aTHX);	678	RETVAL = poll_cb ();
593	OUTPUT:	679	OUTPUT:
594	RETVAL	680	RETVAL
595		681
596	void	682	void
597	poll_wait()	683	poll_wait()

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing IO-AIO/AIO.xs (file contents): Revision 1.4 by root, Sun Jul 10 20:57:00 2005 UTC vs. Revision 1.20 by root, Sun Jul 31 19:08:39 2005 UTC

Diff Legend

Comparing IO-AIO/AIO.xs (file contents):
Revision 1.4 by root, Sun Jul 10 20:57:00 2005 UTC vs.
Revision 1.20 by root, Sun Jul 31 19:08:39 2005 UTC