ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/IO-AIO/AIO.xs
(Generate patch)

Comparing IO-AIO/AIO.xs (file contents):
Revision 1.81 by root, Fri Oct 27 20:10:06 2006 UTC vs.
Revision 1.86 by root, Mon Oct 30 23:30:00 2006 UTC

… …
43# else 43# else
44# error sendfile support requested but not available 44# error sendfile support requested but not available
45# endif 45# endif
46#endif 46#endif
47 47
48/* number of seconds after which idle threads exit */
49#define IDLE_TIMEOUT 10
50
48/* used for struct dirent, AIX doesn't provide it */ 51/* used for struct dirent, AIX doesn't provide it */
49#ifndef NAME_MAX 52#ifndef NAME_MAX
50# define NAME_MAX 4096 53# define NAME_MAX 4096
51#endif 54#endif
52 55
… …
65 68
66/* wether word reads are potentially non-atomic. 69/* wether word reads are potentially non-atomic.
67 * this is conservatice, likely most arches this runs 70 * this is conservatice, likely most arches this runs
68 * on have atomic word read/writes. 71 * on have atomic word read/writes.
69 */ 72 */
70#ifndef WORDREAD_UNSAFE 73#ifndef WORDACCESS_UNSAFE
71# if __i386 || __x86_64 74# if __i386 || __x86_64
72# define WORDREAD_UNSAFE 0 75# define WORDACCESS_UNSAFE 0
73# else 76# else
74# define WORDREAD_UNSAFE 1 77# define WORDACCESS_UNSAFE 1
75# endif 78# endif
76#endif 79#endif
77 80
78/* buffer size for various temporary buffers */ 81/* buffer size for various temporary buffers */
79#define AIO_BUFSIZE 65536 82#define AIO_BUFSIZE 65536
… …
93 REQ_SENDFILE, 96 REQ_SENDFILE,
94 REQ_STAT, REQ_LSTAT, REQ_FSTAT, 97 REQ_STAT, REQ_LSTAT, REQ_FSTAT,
95 REQ_FSYNC, REQ_FDATASYNC, 98 REQ_FSYNC, REQ_FDATASYNC,
96 REQ_UNLINK, REQ_RMDIR, REQ_RENAME, 99 REQ_UNLINK, REQ_RMDIR, REQ_RENAME,
97 REQ_MKNOD, REQ_READDIR, 100 REQ_MKNOD, REQ_READDIR,
98 REQ_LINK, REQ_SYMLINK, 101 REQ_LINK, REQ_SYMLINK, REQ_READLINK,
99 REQ_GROUP, REQ_NOP, 102 REQ_GROUP, REQ_NOP,
100 REQ_BUSY, 103 REQ_BUSY,
101}; 104};
102 105
103#define AIO_REQ_KLASS "IO::AIO::REQ" 106#define AIO_REQ_KLASS "IO::AIO::REQ"
… …
105 108
106typedef struct aio_cb 109typedef struct aio_cb
107{ 110{
108 struct aio_cb *volatile next; 111 struct aio_cb *volatile next;
109 112
110 SV *data, *callback; 113 SV *callback, *fh;
111 SV *fh, *fh2; 114 SV *sv1, *sv2;
112 void *dataptr, *data2ptr; 115 void *ptr1, *ptr2;
113 Stat_t *statdata; 116 Stat_t *statdata;
114 off_t offset; 117 off_t offs;
115 size_t length; 118 size_t size;
116 ssize_t result; 119 ssize_t result;
117 120
118 STRLEN dataoffset; 121 STRLEN stroffset;
119 int type; 122 int type;
120 int fd, fd2; 123 int int1, int2;
121 int errorno; 124 int errorno;
122 mode_t mode; /* open */ 125 mode_t mode; /* open */
123 126
124 unsigned char flags; 127 unsigned char flags;
125 unsigned char pri; 128 unsigned char pri;
… …
127 SV *self; /* the perl counterpart of this request, if any */ 130 SV *self; /* the perl counterpart of this request, if any */
128 struct aio_cb *grp, *grp_prev, *grp_next, *grp_first; 131 struct aio_cb *grp, *grp_prev, *grp_next, *grp_first;
129} aio_cb; 132} aio_cb;
130 133
131enum { 134enum {
132 FLAG_CANCELLED = 0x01, 135 FLAG_CANCELLED = 0x01,
136 FLAG_DATA_RO_OFF = 0x80, /* data was set readonly */
133}; 137};
134 138
135typedef aio_cb *aio_req; 139typedef aio_cb *aio_req;
136typedef aio_cb *aio_req_ornot; 140typedef aio_cb *aio_req_ornot;
137 141
… …
142 DEFAULT_PRI = 0, 146 DEFAULT_PRI = 0,
143 PRI_BIAS = -PRI_MIN, 147 PRI_BIAS = -PRI_MIN,
144 NUM_PRI = PRI_MAX + PRI_BIAS + 1, 148 NUM_PRI = PRI_MAX + PRI_BIAS + 1,
145}; 149};
146 150
151#define AIO_TICKS ((1000000 + 1023) >> 10)
152
153static unsigned int max_poll_time = 0;
154static unsigned int max_poll_reqs = 0;
155
156/* calculcate time difference in ~1/AIO_TICKS of a second */
157static int tvdiff (struct timeval *tv1, struct timeval *tv2)
158{
159 return (tv2->tv_sec - tv1->tv_sec ) * AIO_TICKS
160 + ((tv2->tv_usec - tv1->tv_usec) >> 10);
161}
162
147static int next_pri = DEFAULT_PRI + PRI_BIAS; 163static int next_pri = DEFAULT_PRI + PRI_BIAS;
148 164
149static unsigned int started, wanted; 165static unsigned int started, idle, wanted;
150 166
151#if __linux && defined (PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP) 167#if __linux && defined (PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP)
152# define AIO_MUTEX_INIT PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP 168# define AIO_MUTEX_INIT PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP
153#else 169#else
154# define AIO_MUTEX_INIT PTHREAD_MUTEX_INITIALIZER 170# define AIO_MUTEX_INIT PTHREAD_MUTEX_INITIALIZER
… …
196 212
197 free (wrk); 213 free (wrk);
198} 214}
199 215
200static volatile unsigned int nreqs, nready, npending; 216static volatile unsigned int nreqs, nready, npending;
217static volatile unsigned int max_idle = 4;
201static volatile unsigned int max_outstanding = 0xffffffff; 218static volatile unsigned int max_outstanding = 0xffffffff;
202static int respipe [2]; 219static int respipe [2];
203 220
204static pthread_mutex_t reslock = AIO_MUTEX_INIT; 221static pthread_mutex_t reslock = AIO_MUTEX_INIT;
205static pthread_mutex_t reqlock = AIO_MUTEX_INIT; 222static pthread_mutex_t reqlock = AIO_MUTEX_INIT;
206static pthread_cond_t reqwait = PTHREAD_COND_INITIALIZER; 223static pthread_cond_t reqwait = PTHREAD_COND_INITIALIZER;
207 224
208#if WORDREAD_UNSAFE 225#if WORDACCESS_UNSAFE
209 226
210static unsigned int get_nready () 227static unsigned int get_nready ()
211{ 228{
212 unsigned int retval; 229 unsigned int retval;
213 230
… …
227 UNLOCK (reslock); 244 UNLOCK (reslock);
228 245
229 return retval; 246 return retval;
230} 247}
231 248
249static unsigned int get_nthreads ()
250{
251 unsigned int retval;
252
253 LOCK (wrklock);
254 retval = started;
255 UNLOCK (wrklock);
256
257 return retval;
258}
259
232#else 260#else
233 261
234# define get_nready() nready 262# define get_nready() nready
235# define get_npending() npending 263# define get_npending() npending
264# define get_nthreads() started
236 265
237#endif 266#endif
238 267
239/* 268/*
240 * a somewhat faster data structure might be nice, but 269 * a somewhat faster data structure might be nice, but
… …
288 } 317 }
289 318
290 abort (); 319 abort ();
291} 320}
292 321
293static int poll_cb (int max); 322static int poll_cb ();
294static void req_invoke (aio_req req); 323static void req_invoke (aio_req req);
295static void req_free (aio_req req); 324static void req_free (aio_req req);
296static void req_cancel (aio_req req); 325static void req_cancel (aio_req req);
297 326
298/* must be called at most once */ 327/* must be called at most once */
… …
319 return mg ? (aio_req)mg->mg_ptr : 0; 348 return mg ? (aio_req)mg->mg_ptr : 0;
320} 349}
321 350
322static void aio_grp_feed (aio_req grp) 351static void aio_grp_feed (aio_req grp)
323{ 352{
324 while (grp->length < grp->fd2 && !(grp->flags & FLAG_CANCELLED)) 353 while (grp->size < grp->int2 && !(grp->flags & FLAG_CANCELLED))
325 { 354 {
326 int old_len = grp->length; 355 int old_len = grp->size;
327 356
328 if (grp->fh2 && SvOK (grp->fh2)) 357 if (grp->sv2 && SvOK (grp->sv2))
329 { 358 {
330 dSP; 359 dSP;
331 360
332 ENTER; 361 ENTER;
333 SAVETMPS; 362 SAVETMPS;
334 PUSHMARK (SP); 363 PUSHMARK (SP);
335 XPUSHs (req_sv (grp, AIO_GRP_KLASS)); 364 XPUSHs (req_sv (grp, AIO_GRP_KLASS));
336 PUTBACK; 365 PUTBACK;
337 call_sv (grp->fh2, G_VOID | G_EVAL | G_KEEPERR); 366 call_sv (grp->sv2, G_VOID | G_EVAL | G_KEEPERR);
338 SPAGAIN; 367 SPAGAIN;
339 FREETMPS; 368 FREETMPS;
340 LEAVE; 369 LEAVE;
341 } 370 }
342 371
343 /* stop if no progress has been made */ 372 /* stop if no progress has been made */
344 if (old_len == grp->length) 373 if (old_len == grp->size)
345 { 374 {
346 SvREFCNT_dec (grp->fh2); 375 SvREFCNT_dec (grp->sv2);
347 grp->fh2 = 0; 376 grp->sv2 = 0;
348 break; 377 break;
349 } 378 }
350 } 379 }
351} 380}
352 381
353static void aio_grp_dec (aio_req grp) 382static void aio_grp_dec (aio_req grp)
354{ 383{
355 --grp->length; 384 --grp->size;
356 385
357 /* call feeder, if applicable */ 386 /* call feeder, if applicable */
358 aio_grp_feed (grp); 387 aio_grp_feed (grp);
359 388
360 /* finish, if done */ 389 /* finish, if done */
361 if (!grp->length && grp->fd) 390 if (!grp->size && grp->int1)
362 { 391 {
363 req_invoke (grp); 392 req_invoke (grp);
364 req_free (grp); 393 req_free (grp);
365 } 394 }
366} 395}
367 396
368static void req_invoke (aio_req req) 397static void req_invoke (aio_req req)
369{ 398{
370 dSP; 399 dSP;
400
401 if (req->flags & FLAG_DATA_RO_OFF)
402 SvREADONLY_off (req->sv1);
403
404 if (req->statdata)
405 {
406 PL_laststype = req->type == REQ_LSTAT ? OP_LSTAT : OP_STAT;
407 PL_laststatval = req->result;
408 PL_statcache = *(req->statdata);
409 }
371 410
372 if (!(req->flags & FLAG_CANCELLED) && SvOK (req->callback)) 411 if (!(req->flags & FLAG_CANCELLED) && SvOK (req->callback))
373 { 412 {
374 ENTER; 413 ENTER;
375 SAVETMPS; 414 SAVETMPS;
… …
383 SV *rv = &PL_sv_undef; 422 SV *rv = &PL_sv_undef;
384 423
385 if (req->result >= 0) 424 if (req->result >= 0)
386 { 425 {
387 int i; 426 int i;
388 char *buf = req->data2ptr; 427 char *buf = req->ptr2;
389 AV *av = newAV (); 428 AV *av = newAV ();
390 429
391 av_extend (av, req->result - 1); 430 av_extend (av, req->result - 1);
392 431
393 for (i = 0; i < req->result; ++i) 432 for (i = 0; i < req->result; ++i)
… …
421 XPUSHs (sv_2mortal (fh)); 460 XPUSHs (sv_2mortal (fh));
422 } 461 }
423 break; 462 break;
424 463
425 case REQ_GROUP: 464 case REQ_GROUP:
426 req->fd = 2; /* mark group as finished */ 465 req->int1 = 2; /* mark group as finished */
427 466
428 if (req->data) 467 if (req->sv1)
429 { 468 {
430 int i; 469 int i;
431 AV *av = (AV *)req->data; 470 AV *av = (AV *)req->sv1;
432 471
433 EXTEND (SP, AvFILL (av) + 1); 472 EXTEND (SP, AvFILL (av) + 1);
434 for (i = 0; i <= AvFILL (av); ++i) 473 for (i = 0; i <= AvFILL (av); ++i)
435 PUSHs (*av_fetch (av, i, 0)); 474 PUSHs (*av_fetch (av, i, 0));
436 } 475 }
… …
438 477
439 case REQ_NOP: 478 case REQ_NOP:
440 case REQ_BUSY: 479 case REQ_BUSY:
441 break; 480 break;
442 481
482 case REQ_READLINK:
483 if (req->result > 0)
484 {
485 SvCUR_set (req->sv1, req->result);
486 *SvEND (req->sv1) = 0;
487 PUSHs (req->sv1);
488 }
489 break;
490
491 case REQ_READ:
492 SvCUR_set (req->sv1, req->stroffset + (req->result > 0 ? req->result : 0));
493 *SvEND (req->sv1) = 0;
494 /* fall through */
443 default: 495 default:
444 PUSHs (sv_2mortal (newSViv (req->result))); 496 PUSHs (sv_2mortal (newSViv (req->result)));
445 break; 497 break;
446 } 498 }
447 499
… …
482 { 534 {
483 sv_unmagic (req->self, PERL_MAGIC_ext); 535 sv_unmagic (req->self, PERL_MAGIC_ext);
484 SvREFCNT_dec (req->self); 536 SvREFCNT_dec (req->self);
485 } 537 }
486 538
487 SvREFCNT_dec (req->data);
488 SvREFCNT_dec (req->fh); 539 SvREFCNT_dec (req->fh);
540 SvREFCNT_dec (req->sv1);
489 SvREFCNT_dec (req->fh2); 541 SvREFCNT_dec (req->sv2);
490 SvREFCNT_dec (req->callback); 542 SvREFCNT_dec (req->callback);
491 Safefree (req->statdata); 543 Safefree (req->statdata);
492 544
493 if (req->type == REQ_READDIR) 545 if (req->type == REQ_READDIR)
494 free (req->data2ptr); 546 free (req->ptr2);
495 547
496 Safefree (req); 548 Safefree (req);
497} 549}
498 550
499static void req_cancel_subs (aio_req grp) 551static void req_cancel_subs (aio_req grp)
… …
501 aio_req sub; 553 aio_req sub;
502 554
503 if (grp->type != REQ_GROUP) 555 if (grp->type != REQ_GROUP)
504 return; 556 return;
505 557
506 SvREFCNT_dec (grp->fh2); 558 SvREFCNT_dec (grp->sv2);
507 grp->fh2 = 0; 559 grp->sv2 = 0;
508 560
509 for (sub = grp->grp_first; sub; sub = sub->grp_next) 561 for (sub = grp->grp_first; sub; sub = sub->grp_next)
510 req_cancel (sub); 562 req_cancel (sub);
511} 563}
512 564
… …
556 UNLOCK (wrklock); 608 UNLOCK (wrklock);
557} 609}
558 610
559static void maybe_start_thread () 611static void maybe_start_thread ()
560{ 612{
561#if 0 613 if (get_nthreads () >= wanted)
562 static struct timeval last;
563 struct timeval diff, now;
564#endif
565
566 if (started >= wanted)
567 return; 614 return;
568 615
569 if (nready <= nreqs - get_nready () - get_npending ()) 616 /* todo: maybe use idle here, but might be less exact */
617 if (0 <= (int)get_nthreads () + (int)get_npending () - (int)nreqs)
570 return; 618 return;
571
572#if 0
573 gettimeofday (&now, 0);
574
575 diff.tv_sec = now.tv_sec - last.tv_sec;
576 diff.tv_usec = now.tv_usec - last.tv_usec;
577
578 if (diff.tv_usec < 0)
579 {
580 --diff.tv_sec;
581 diff.tv_usec += 1000000;
582 }
583
584 if (!diff.tv_sec && diff.tv_usec < 10000)
585 return;
586
587 last = now;
588#endif
589 619
590 start_thread (); 620 start_thread ();
591} 621}
592 622
593static void req_send (aio_req req) 623static void req_send (aio_req req)
… …
610 Newz (0, req, 1, aio_cb); 640 Newz (0, req, 1, aio_cb);
611 641
612 req->type = REQ_QUIT; 642 req->type = REQ_QUIT;
613 req->pri = PRI_MAX + PRI_BIAS; 643 req->pri = PRI_MAX + PRI_BIAS;
614 644
615 req_send (req); 645 LOCK (reqlock);
646 reqq_push (&req_queue, req);
647 pthread_cond_signal (&reqwait);
648 UNLOCK (reqlock);
616 649
617 LOCK (wrklock); 650 LOCK (wrklock);
618 --started; 651 --started;
619 UNLOCK (wrklock); 652 UNLOCK (wrklock);
620} 653}
621 654
655static void set_max_idle (int nthreads)
656{
657 if (WORDACCESS_UNSAFE) LOCK (reqlock);
658 max_idle = nthreads <= 0 ? 1 : nthreads;
659 if (WORDACCESS_UNSAFE) UNLOCK (reqlock);
660}
661
622static void min_parallel (int nthreads) 662static void min_parallel (int nthreads)
623{ 663{
624 if (wanted < nthreads) 664 if (wanted < nthreads)
625 wanted = nthreads; 665 wanted = nthreads;
626} 666}
… …
639 fd_set rfd; 679 fd_set rfd;
640 680
641 while (nreqs) 681 while (nreqs)
642 { 682 {
643 int size; 683 int size;
644 if (WORDREAD_UNSAFE) LOCK (reslock); 684 if (WORDACCESS_UNSAFE) LOCK (reslock);
645 size = res_queue.size; 685 size = res_queue.size;
646 if (WORDREAD_UNSAFE) UNLOCK (reslock); 686 if (WORDACCESS_UNSAFE) UNLOCK (reslock);
647 687
648 if (size) 688 if (size)
649 return; 689 return;
650 690
651 maybe_start_thread (); 691 maybe_start_thread ();
… …
655 695
656 select (respipe [0] + 1, &rfd, 0, 0, 0); 696 select (respipe [0] + 1, &rfd, 0, 0, 0);
657 } 697 }
658} 698}
659 699
660static int poll_cb (int max) 700static int poll_cb ()
661{ 701{
662 dSP; 702 dSP;
663 int count = 0; 703 int count = 0;
704 int maxreqs = max_poll_reqs;
664 int do_croak = 0; 705 int do_croak = 0;
706 struct timeval tv_start, tv_now;
665 aio_req req; 707 aio_req req;
666 708
709 if (max_poll_time)
710 gettimeofday (&tv_start, 0);
711
667 for (;;) 712 for (;;)
668 { 713 {
669 while (max <= 0 || count < max) 714 for (;;)
670 { 715 {
671 maybe_start_thread (); 716 maybe_start_thread ();
672 717
673 LOCK (reslock); 718 LOCK (reslock);
674 req = reqq_shift (&res_queue); 719 req = reqq_shift (&res_queue);
… …
691 if (!req) 736 if (!req)
692 break; 737 break;
693 738
694 --nreqs; 739 --nreqs;
695 740
696 if (req->type == REQ_GROUP && req->length) 741 if (req->type == REQ_GROUP && req->size)
697 { 742 {
698 req->fd = 1; /* mark request as delayed */ 743 req->int1 = 1; /* mark request as delayed */
699 continue; 744 continue;
700 } 745 }
701 else 746 else
702 { 747 {
703 if (req->type == REQ_READ)
704 SvCUR_set (req->data, req->dataoffset + (req->result > 0 ? req->result : 0));
705
706 if (req->data2ptr && (req->type == REQ_READ || req->type == REQ_WRITE))
707 SvREADONLY_off (req->data);
708
709 if (req->statdata)
710 {
711 PL_laststype = req->type == REQ_LSTAT ? OP_LSTAT : OP_STAT;
712 PL_laststatval = req->result;
713 PL_statcache = *(req->statdata);
714 }
715
716 req_invoke (req); 748 req_invoke (req);
717 749
718 count++; 750 count++;
719 } 751 }
720 752
721 req_free (req); 753 req_free (req);
754
755 if (maxreqs && !--maxreqs)
756 break;
757
758 if (max_poll_time)
759 {
760 gettimeofday (&tv_now, 0);
761
762 if (tvdiff (&tv_start, &tv_now) >= max_poll_time)
763 break;
764 }
722 } 765 }
723 766
724 if (nreqs <= max_outstanding) 767 if (nreqs <= max_outstanding)
725 break; 768 break;
726 769
727 poll_wait (); 770 poll_wait ();
728 771
729 max = 0; 772 ++maxreqs;
730 } 773 }
731 774
732 return count; 775 return count;
733} 776}
734 777
… …
952 int memofs = 0; 995 int memofs = 0;
953 int res = 0; 996 int res = 0;
954 int errorno; 997 int errorno;
955 998
956 LOCK (wrklock); 999 LOCK (wrklock);
957 self->dirp = dirp = opendir (req->dataptr); 1000 self->dirp = dirp = opendir (req->ptr1);
958 self->dbuf = u = malloc (sizeof (*u)); 1001 self->dbuf = u = malloc (sizeof (*u));
959 req->data2ptr = names = malloc (memlen); 1002 req->ptr2 = names = malloc (memlen);
960 UNLOCK (wrklock); 1003 UNLOCK (wrklock);
961 1004
962 if (dirp && u && names) 1005 if (dirp && u && names)
963 for (;;) 1006 for (;;)
964 { 1007 {
… …
978 1021
979 while (memofs + len > memlen) 1022 while (memofs + len > memlen)
980 { 1023 {
981 memlen *= 2; 1024 memlen *= 2;
982 LOCK (wrklock); 1025 LOCK (wrklock);
983 req->data2ptr = names = realloc (names, memlen); 1026 req->ptr2 = names = realloc (names, memlen);
984 UNLOCK (wrklock); 1027 UNLOCK (wrklock);
985 1028
986 if (!names) 1029 if (!names)
987 break; 1030 break;
988 } 1031 }
… …
1001/*****************************************************************************/ 1044/*****************************************************************************/
1002 1045
1003static void *aio_proc (void *thr_arg) 1046static void *aio_proc (void *thr_arg)
1004{ 1047{
1005 aio_req req; 1048 aio_req req;
1049 struct timespec ts;
1006 worker *self = (worker *)thr_arg; 1050 worker *self = (worker *)thr_arg;
1007 1051
1052 /* try to distribute timeouts somewhat evenly */
1053 ts.tv_nsec = (((unsigned long)self + (unsigned long)ts.tv_sec) & 1023UL)
1054 * (1000000000UL / 1024UL);
1055
1008 for (;;) 1056 for (;;)
1009 { 1057 {
1058 ts.tv_sec = time (0) + IDLE_TIMEOUT;
1059
1010 LOCK (reqlock); 1060 LOCK (reqlock);
1011 1061
1012 for (;;) 1062 for (;;)
1013 { 1063 {
1014 self->req = req = reqq_shift (&req_queue); 1064 self->req = req = reqq_shift (&req_queue);
1015 1065
1016 if (req) 1066 if (req)
1017 break; 1067 break;
1018 1068
1069 ++idle;
1070
1071 if (pthread_cond_timedwait (&reqwait, &reqlock, &ts)
1072 == ETIMEDOUT)
1073 {
1074 if (idle > max_idle)
1075 {
1076 --idle;
1077 UNLOCK (reqlock);
1078 LOCK (wrklock);
1079 --started;
1080 UNLOCK (wrklock);
1081 goto quit;
1082 }
1083
1084 /* we are allowed to idle, so do so without any timeout */
1019 pthread_cond_wait (&reqwait, &reqlock); 1085 pthread_cond_wait (&reqwait, &reqlock);
1086 ts.tv_sec = time (0) + IDLE_TIMEOUT;
1087 }
1088
1089 --idle;
1020 } 1090 }
1021 1091
1022 --nready; 1092 --nready;
1023 1093
1024 UNLOCK (reqlock); 1094 UNLOCK (reqlock);
… …
1026 errno = 0; /* strictly unnecessary */ 1096 errno = 0; /* strictly unnecessary */
1027 1097
1028 if (!(req->flags & FLAG_CANCELLED)) 1098 if (!(req->flags & FLAG_CANCELLED))
1029 switch (req->type) 1099 switch (req->type)
1030 { 1100 {
1031 case REQ_READ: req->result = pread (req->fd, req->dataptr, req->length, req->offset); break; 1101 case REQ_READ: req->result = pread (req->int1, req->ptr1, req->size, req->offs); break;
1032 case REQ_WRITE: req->result = pwrite (req->fd, req->dataptr, req->length, req->offset); break; 1102 case REQ_WRITE: req->result = pwrite (req->int1, req->ptr1, req->size, req->offs); break;
1033 1103
1034 case REQ_READAHEAD: req->result = readahead (req->fd, req->offset, req->length); break; 1104 case REQ_READAHEAD: req->result = readahead (req->int1, req->offs, req->size); break;
1035 case REQ_SENDFILE: req->result = sendfile_ (req->fd, req->fd2, req->offset, req->length, self); break; 1105 case REQ_SENDFILE: req->result = sendfile_ (req->int1, req->int2, req->offs, req->size, self); break;
1036 1106
1037 case REQ_STAT: req->result = stat (req->dataptr, req->statdata); break; 1107 case REQ_STAT: req->result = stat (req->ptr1, req->statdata); break;
1038 case REQ_LSTAT: req->result = lstat (req->dataptr, req->statdata); break; 1108 case REQ_LSTAT: req->result = lstat (req->ptr1, req->statdata); break;
1039 case REQ_FSTAT: req->result = fstat (req->fd , req->statdata); break; 1109 case REQ_FSTAT: req->result = fstat (req->int1, req->statdata); break;
1040 1110
1041 case REQ_OPEN: req->result = open (req->dataptr, req->fd, req->mode); break; 1111 case REQ_OPEN: req->result = open (req->ptr1, req->int1, req->mode); break;
1042 case REQ_CLOSE: req->result = close (req->fd); break; 1112 case REQ_CLOSE: req->result = close (req->int1); break;
1043 case REQ_UNLINK: req->result = unlink (req->dataptr); break; 1113 case REQ_UNLINK: req->result = unlink (req->ptr1); break;
1044 case REQ_RMDIR: req->result = rmdir (req->dataptr); break; 1114 case REQ_RMDIR: req->result = rmdir (req->ptr1); break;
1045 case REQ_RENAME: req->result = rename (req->data2ptr, req->dataptr); break; 1115 case REQ_RENAME: req->result = rename (req->ptr2, req->ptr1); break;
1046 case REQ_LINK: req->result = link (req->data2ptr, req->dataptr); break; 1116 case REQ_LINK: req->result = link (req->ptr2, req->ptr1); break;
1047 case REQ_SYMLINK: req->result = symlink (req->data2ptr, req->dataptr); break; 1117 case REQ_SYMLINK: req->result = symlink (req->ptr2, req->ptr1); break;
1048 case REQ_MKNOD: req->result = mknod (req->data2ptr, req->mode, (dev_t)req->offset); break; 1118 case REQ_MKNOD: req->result = mknod (req->ptr2, req->mode, (dev_t)req->offs); break;
1119 case REQ_READLINK: req->result = readlink (req->ptr2, req->ptr1, NAME_MAX); break;
1049 1120
1050 case REQ_FDATASYNC: req->result = fdatasync (req->fd); break; 1121 case REQ_FDATASYNC: req->result = fdatasync (req->int1); break;
1051 case REQ_FSYNC: req->result = fsync (req->fd); break; 1122 case REQ_FSYNC: req->result = fsync (req->int1); break;
1052 case REQ_READDIR: scandir_ (req, self); break; 1123 case REQ_READDIR: scandir_ (req, self); break;
1053 1124
1054 case REQ_BUSY: 1125 case REQ_BUSY:
1055 { 1126 {
1056 struct timeval tv; 1127 struct timeval tv;
1057 1128
1058 tv.tv_sec = req->fd; 1129 tv.tv_sec = req->int1;
1059 tv.tv_usec = req->fd2; 1130 tv.tv_usec = req->int2;
1060 1131
1061 req->result = select (0, 0, 0, 0, &tv); 1132 req->result = select (0, 0, 0, 0, &tv);
1062 } 1133 }
1063 1134
1064 case REQ_GROUP: 1135 case REQ_GROUP:
1065 case REQ_NOP: 1136 case REQ_NOP:
1066 break; 1137 break;
1067 1138
1068 case REQ_QUIT: 1139 case REQ_QUIT:
1069 LOCK (wrklock); 1140 goto quit;
1070 worker_free (self);
1071 --started;
1072 UNLOCK (wrklock);
1073 return 0;
1074 1141
1075 default: 1142 default:
1076 req->result = ENOSYS; 1143 req->result = ENOSYS;
1077 break; 1144 break;
1078 } 1145 }
… …
1090 self->req = 0; 1157 self->req = 0;
1091 worker_clear (self); 1158 worker_clear (self);
1092 1159
1093 UNLOCK (reslock); 1160 UNLOCK (reslock);
1094 } 1161 }
1162
1163quit:
1164 LOCK (wrklock);
1165 worker_free (self);
1166 UNLOCK (wrklock);
1167
1168 return 0;
1095} 1169}
1096 1170
1097/*****************************************************************************/ 1171/*****************************************************************************/
1098 1172
1099static void atfork_prepare (void) 1173static void atfork_prepare (void)
… …
1141 1215
1142 worker_clear (wrk); 1216 worker_clear (wrk);
1143 worker_free (wrk); 1217 worker_free (wrk);
1144 } 1218 }
1145 1219
1146 started = 0; 1220 started = 0;
1221 idle = 0;
1147 nreqs = 0; 1222 nreqs = 0;
1223 nready = 0;
1224 npending = 0;
1148 1225
1149 close (respipe [0]); 1226 close (respipe [0]);
1150 close (respipe [1]); 1227 close (respipe [1]);
1151 create_pipe (); 1228 create_pipe ();
1152 1229
… …
1179PROTOTYPES: ENABLE 1256PROTOTYPES: ENABLE
1180 1257
1181BOOT: 1258BOOT:
1182{ 1259{
1183 HV *stash = gv_stashpv ("IO::AIO", 1); 1260 HV *stash = gv_stashpv ("IO::AIO", 1);
1261
1184 newCONSTSUB (stash, "EXDEV", newSViv (EXDEV)); 1262 newCONSTSUB (stash, "EXDEV", newSViv (EXDEV));
1185 newCONSTSUB (stash, "O_RDONLY", newSViv (O_RDONLY)); 1263 newCONSTSUB (stash, "O_RDONLY", newSViv (O_RDONLY));
1186 newCONSTSUB (stash, "O_WRONLY", newSViv (O_WRONLY)); 1264 newCONSTSUB (stash, "O_WRONLY", newSViv (O_WRONLY));
1187 newCONSTSUB (stash, "O_CREAT", newSViv (O_CREAT)); 1265 newCONSTSUB (stash, "O_CREAT", newSViv (O_CREAT));
1188 newCONSTSUB (stash, "O_TRUNC", newSViv (O_TRUNC)); 1266 newCONSTSUB (stash, "O_TRUNC", newSViv (O_TRUNC));
1267 newCONSTSUB (stash, "S_IFIFO", newSViv (S_IFIFO));
1189 1268
1190 create_pipe (); 1269 create_pipe ();
1191 pthread_atfork (atfork_prepare, atfork_parent, atfork_child); 1270 pthread_atfork (atfork_prepare, atfork_parent, atfork_child);
1192
1193 start_thread ();
1194} 1271}
1272
1273void
1274max_poll_reqs (int nreqs)
1275 PROTOTYPE: $
1276 CODE:
1277 max_poll_reqs = nreqs;
1278
1279void
1280max_poll_time (double nseconds)
1281 PROTOTYPE: $
1282 CODE:
1283 max_poll_time = nseconds * AIO_TICKS;
1195 1284
1196void 1285void
1197min_parallel (int nthreads) 1286min_parallel (int nthreads)
1198 PROTOTYPE: $ 1287 PROTOTYPE: $
1199 1288
1200void 1289void
1201max_parallel (int nthreads) 1290max_parallel (int nthreads)
1202 PROTOTYPE: $ 1291 PROTOTYPE: $
1292
1293void
1294max_idle (int nthreads)
1295 PROTOTYPE: $
1296 CODE:
1297 set_max_idle (nthreads);
1203 1298
1204int 1299int
1205max_outstanding (int maxreqs) 1300max_outstanding (int maxreqs)
1206 PROTOTYPE: $ 1301 PROTOTYPE: $
1207 CODE: 1302 CODE:
… …
1220 PPCODE: 1315 PPCODE:
1221{ 1316{
1222 dREQ; 1317 dREQ;
1223 1318
1224 req->type = REQ_OPEN; 1319 req->type = REQ_OPEN;
1225 req->data = newSVsv (pathname); 1320 req->sv1 = newSVsv (pathname);
1226 req->dataptr = SvPVbyte_nolen (req->data); 1321 req->ptr1 = SvPVbyte_nolen (pathname);
1227 req->fd = flags; 1322 req->int1 = flags;
1228 req->mode = mode; 1323 req->mode = mode;
1229 1324
1230 REQ_SEND; 1325 REQ_SEND;
1231} 1326}
1232 1327
… …
1242 PPCODE: 1337 PPCODE:
1243{ 1338{
1244 dREQ; 1339 dREQ;
1245 1340
1246 req->type = ix; 1341 req->type = ix;
1247 req->fh = newSVsv (fh); 1342 req->fh = newSVsv (fh);
1248 req->fd = PerlIO_fileno (IoIFP (sv_2io (fh))); 1343 req->int1 = PerlIO_fileno (IoIFP (sv_2io (fh)));
1249 1344
1250 REQ_SEND (req); 1345 REQ_SEND (req);
1251} 1346}
1252 1347
1253void 1348void
… …
1262 aio_read = REQ_READ 1357 aio_read = REQ_READ
1263 aio_write = REQ_WRITE 1358 aio_write = REQ_WRITE
1264 PROTOTYPE: $$$$$;$ 1359 PROTOTYPE: $$$$$;$
1265 PPCODE: 1360 PPCODE:
1266{ 1361{
1267 aio_req req;
1268 STRLEN svlen; 1362 STRLEN svlen;
1269 char *svptr = SvPVbyte (data, svlen); 1363 char *svptr = SvPVbyte (data, svlen);
1270 1364
1271 SvUPGRADE (data, SVt_PV); 1365 SvUPGRADE (data, SVt_PV);
1272 SvPOK_on (data); 1366 SvPOK_on (data);
… …
1294 1388
1295 { 1389 {
1296 dREQ; 1390 dREQ;
1297 1391
1298 req->type = ix; 1392 req->type = ix;
1299 req->fh = newSVsv (fh); 1393 req->fh = newSVsv (fh);
1300 req->fd = PerlIO_fileno (ix == REQ_READ ? IoIFP (sv_2io (fh)) 1394 req->int1 = PerlIO_fileno (ix == REQ_READ ? IoIFP (sv_2io (fh))
1301 : IoOFP (sv_2io (fh))); 1395 : IoOFP (sv_2io (fh)));
1302 req->offset = offset; 1396 req->offs = offset;
1303 req->length = length; 1397 req->size = length;
1304 req->data = SvREFCNT_inc (data); 1398 req->sv1 = SvREFCNT_inc (data);
1305 req->dataptr = (char *)svptr + dataoffset; 1399 req->ptr1 = (char *)svptr + dataoffset;
1400 req->stroffset = dataoffset;
1306 1401
1307 if (!SvREADONLY (data)) 1402 if (!SvREADONLY (data))
1308 { 1403 {
1309 SvREADONLY_on (data); 1404 SvREADONLY_on (data);
1310 req->data2ptr = (void *)data; 1405 req->flags |= FLAG_DATA_RO_OFF;
1311 } 1406 }
1312 1407
1313 REQ_SEND; 1408 REQ_SEND;
1314 } 1409 }
1410}
1411
1412void
1413aio_readlink (path,callback=&PL_sv_undef)
1414 SV * path
1415 SV * callback
1416 PROTOTYPE: $$;$
1417 PPCODE:
1418{
1419 SV *data;
1420 dREQ;
1421
1422 data = newSV (NAME_MAX);
1423 SvPOK_on (data);
1424
1425 req->type = REQ_READLINK;
1426 req->fh = newSVsv (path);
1427 req->ptr2 = SvPVbyte_nolen (path);
1428 req->sv1 = data;
1429 req->ptr1 = SvPVbyte_nolen (data);
1430
1431 REQ_SEND;
1315} 1432}
1316 1433
1317void 1434void
1318aio_sendfile (out_fh,in_fh,in_offset,length,callback=&PL_sv_undef) 1435aio_sendfile (out_fh,in_fh,in_offset,length,callback=&PL_sv_undef)
1319 SV * out_fh 1436 SV * out_fh
… …
1325 PPCODE: 1442 PPCODE:
1326{ 1443{
1327 dREQ; 1444 dREQ;
1328 1445
1329 req->type = REQ_SENDFILE; 1446 req->type = REQ_SENDFILE;
1330 req->fh = newSVsv (out_fh); 1447 req->fh = newSVsv (out_fh);
1331 req->fd = PerlIO_fileno (IoIFP (sv_2io (out_fh))); 1448 req->int1 = PerlIO_fileno (IoIFP (sv_2io (out_fh)));
1332 req->fh2 = newSVsv (in_fh); 1449 req->sv2 = newSVsv (in_fh);
1333 req->fd2 = PerlIO_fileno (IoIFP (sv_2io (in_fh))); 1450 req->int2 = PerlIO_fileno (IoIFP (sv_2io (in_fh)));
1334 req->offset = in_offset; 1451 req->offs = in_offset;
1335 req->length = length; 1452 req->size = length;
1336 1453
1337 REQ_SEND; 1454 REQ_SEND;
1338} 1455}
1339 1456
1340void 1457void
… …
1347 PPCODE: 1464 PPCODE:
1348{ 1465{
1349 dREQ; 1466 dREQ;
1350 1467
1351 req->type = REQ_READAHEAD; 1468 req->type = REQ_READAHEAD;
1352 req->fh = newSVsv (fh); 1469 req->fh = newSVsv (fh);
1353 req->fd = PerlIO_fileno (IoIFP (sv_2io (fh))); 1470 req->int1 = PerlIO_fileno (IoIFP (sv_2io (fh)));
1354 req->offset = offset; 1471 req->offs = offset;
1355 req->length = length; 1472 req->size = length;
1356 1473
1357 REQ_SEND; 1474 REQ_SEND;
1358} 1475}
1359 1476
1360void 1477void
… …
1376 } 1493 }
1377 1494
1378 if (SvPOK (fh_or_path)) 1495 if (SvPOK (fh_or_path))
1379 { 1496 {
1380 req->type = ix; 1497 req->type = ix;
1381 req->data = newSVsv (fh_or_path); 1498 req->sv1 = newSVsv (fh_or_path);
1382 req->dataptr = SvPVbyte_nolen (req->data); 1499 req->ptr1 = SvPVbyte_nolen (fh_or_path);
1383 } 1500 }
1384 else 1501 else
1385 { 1502 {
1386 req->type = REQ_FSTAT; 1503 req->type = REQ_FSTAT;
1387 req->fh = newSVsv (fh_or_path); 1504 req->fh = newSVsv (fh_or_path);
1388 req->fd = PerlIO_fileno (IoIFP (sv_2io (fh_or_path))); 1505 req->int1 = PerlIO_fileno (IoIFP (sv_2io (fh_or_path)));
1389 } 1506 }
1390 1507
1391 REQ_SEND; 1508 REQ_SEND;
1392} 1509}
1393 1510
1394void 1511void
1395aio_unlink (pathname,callback=&PL_sv_undef) 1512aio_unlink (pathname,callback=&PL_sv_undef)
1396 SV * pathname 1513 SV * pathname
1397 SV * callback 1514 SV * callback
1398 ALIAS: 1515 ALIAS:
1399 aio_unlink = REQ_UNLINK 1516 aio_unlink = REQ_UNLINK
1400 aio_rmdir = REQ_RMDIR 1517 aio_rmdir = REQ_RMDIR
1401 aio_readdir = REQ_READDIR 1518 aio_readdir = REQ_READDIR
1402 PPCODE: 1519 PPCODE:
1403{ 1520{
1404 dREQ; 1521 dREQ;
1405 1522
1406 req->type = ix; 1523 req->type = ix;
1407 req->data = newSVsv (pathname); 1524 req->sv1 = newSVsv (pathname);
1408 req->dataptr = SvPVbyte_nolen (req->data); 1525 req->ptr1 = SvPVbyte_nolen (pathname);
1409 1526
1410 REQ_SEND; 1527 REQ_SEND;
1411} 1528}
1412 1529
1413void 1530void
1414aio_link (oldpath,newpath,callback=&PL_sv_undef) 1531aio_link (oldpath,newpath,callback=&PL_sv_undef)
1415 SV * oldpath 1532 SV * oldpath
1416 SV * newpath 1533 SV * newpath
1417 SV * callback 1534 SV * callback
1418 ALIAS: 1535 ALIAS:
1419 aio_link = REQ_LINK 1536 aio_link = REQ_LINK
1420 aio_symlink = REQ_SYMLINK 1537 aio_symlink = REQ_SYMLINK
1421 aio_rename = REQ_RENAME 1538 aio_rename = REQ_RENAME
1422 PPCODE: 1539 PPCODE:
1423{ 1540{
1424 dREQ; 1541 dREQ;
1425 1542
1426 req->type = ix; 1543 req->type = ix;
1427 req->fh = newSVsv (oldpath); 1544 req->fh = newSVsv (oldpath);
1428 req->data2ptr = SvPVbyte_nolen (req->fh); 1545 req->ptr2 = SvPVbyte_nolen (req->fh);
1429 req->data = newSVsv (newpath); 1546 req->sv1 = newSVsv (newpath);
1430 req->dataptr = SvPVbyte_nolen (req->data); 1547 req->ptr1 = SvPVbyte_nolen (newpath);
1431 1548
1432 REQ_SEND; 1549 REQ_SEND;
1433} 1550}
1434 1551
1435void 1552void
1436aio_mknod (pathname,mode,dev,callback=&PL_sv_undef) 1553aio_mknod (pathname,mode,dev,callback=&PL_sv_undef)
1437 SV * pathname 1554 SV * pathname
1438 SV * callback 1555 SV * callback
1439 UV mode 1556 UV mode
1440 UV dev 1557 UV dev
1441 PPCODE: 1558 PPCODE:
1442{ 1559{
1443 dREQ; 1560 dREQ;
1444 1561
1445 req->type = REQ_MKNOD; 1562 req->type = REQ_MKNOD;
1446 req->data = newSVsv (pathname); 1563 req->sv1 = newSVsv (pathname);
1447 req->dataptr = SvPVbyte_nolen (req->data); 1564 req->ptr1 = SvPVbyte_nolen (pathname);
1448 req->mode = (mode_t)mode; 1565 req->mode = (mode_t)mode;
1449 req->offset = dev; 1566 req->offs = dev;
1450 1567
1451 REQ_SEND; 1568 REQ_SEND;
1452} 1569}
1453 1570
1454void 1571void
1455aio_busy (delay,callback=&PL_sv_undef) 1572aio_busy (delay,callback=&PL_sv_undef)
1456 double delay 1573 double delay
1457 SV * callback 1574 SV * callback
1458 PPCODE: 1575 PPCODE:
1459{ 1576{
1460 dREQ; 1577 dREQ;
1461 1578
1462 req->type = REQ_BUSY; 1579 req->type = REQ_BUSY;
1463 req->fd = delay < 0. ? 0 : delay; 1580 req->int1 = delay < 0. ? 0 : delay;
1464 req->fd2 = delay < 0. ? 0 : 1000. * (delay - req->fd); 1581 req->int2 = delay < 0. ? 0 : 1000. * (delay - req->int1);
1465 1582
1466 REQ_SEND; 1583 REQ_SEND;
1467} 1584}
1468 1585
1469void 1586void
… …
1473 PPCODE: 1590 PPCODE:
1474{ 1591{
1475 dREQ; 1592 dREQ;
1476 1593
1477 req->type = REQ_GROUP; 1594 req->type = REQ_GROUP;
1595
1478 req_send (req); 1596 req_send (req);
1479
1480 XPUSHs (req_sv (req, AIO_GRP_KLASS)); 1597 XPUSHs (req_sv (req, AIO_GRP_KLASS));
1481} 1598}
1482 1599
1483void 1600void
1484aio_nop (callback=&PL_sv_undef) 1601aio_nop (callback=&PL_sv_undef)
1485 SV * callback 1602 SV * callback
1486 PPCODE: 1603 PPCODE:
1487{ 1604{
1488 dREQ; 1605 dREQ;
1489 1606
1490 req->type = REQ_NOP; 1607 req->type = REQ_NOP;
… …
1544 1661
1545int 1662int
1546poll_cb(...) 1663poll_cb(...)
1547 PROTOTYPE: 1664 PROTOTYPE:
1548 CODE: 1665 CODE:
1549 RETVAL = poll_cb (0); 1666 RETVAL = poll_cb ();
1550 OUTPUT:
1551 RETVAL
1552
1553int
1554poll_some(int max = 0)
1555 PROTOTYPE: $
1556 CODE:
1557 RETVAL = poll_cb (max);
1558 OUTPUT: 1667 OUTPUT:
1559 RETVAL 1668 RETVAL
1560 1669
1561void 1670void
1562poll_wait() 1671poll_wait()
… …
1587 CODE: 1696 CODE:
1588 RETVAL = get_npending (); 1697 RETVAL = get_npending ();
1589 OUTPUT: 1698 OUTPUT:
1590 RETVAL 1699 RETVAL
1591 1700
1701int
1702nthreads()
1703 PROTOTYPE:
1704 CODE:
1705 if (WORDACCESS_UNSAFE) LOCK (wrklock);
1706 RETVAL = started;
1707 if (WORDACCESS_UNSAFE) UNLOCK (wrklock);
1708 OUTPUT:
1709 RETVAL
1710
1592PROTOTYPES: DISABLE 1711PROTOTYPES: DISABLE
1593 1712
1594MODULE = IO::AIO PACKAGE = IO::AIO::REQ 1713MODULE = IO::AIO PACKAGE = IO::AIO::REQ
1595 1714
1596void 1715void
… …
1611 PPCODE: 1730 PPCODE:
1612{ 1731{
1613 int i; 1732 int i;
1614 aio_req req; 1733 aio_req req;
1615 1734
1616 if (grp->fd == 2) 1735 if (grp->int1 == 2)
1617 croak ("cannot add requests to IO::AIO::GRP after the group finished"); 1736 croak ("cannot add requests to IO::AIO::GRP after the group finished");
1618 1737
1619 for (i = 1; i < items; ++i ) 1738 for (i = 1; i < items; ++i )
1620 { 1739 {
1621 if (GIMME_V != G_VOID) 1740 if (GIMME_V != G_VOID)
… …
1623 1742
1624 req = SvAIO_REQ (ST (i)); 1743 req = SvAIO_REQ (ST (i));
1625 1744
1626 if (req) 1745 if (req)
1627 { 1746 {
1628 ++grp->length; 1747 ++grp->size;
1629 req->grp = grp; 1748 req->grp = grp;
1630 1749
1631 req->grp_prev = 0; 1750 req->grp_prev = 0;
1632 req->grp_next = grp->grp_first; 1751 req->grp_next = grp->grp_first;
1633 1752
… …
1656 av = newAV (); 1775 av = newAV ();
1657 1776
1658 for (i = 1; i < items; ++i ) 1777 for (i = 1; i < items; ++i )
1659 av_push (av, newSVsv (ST (i))); 1778 av_push (av, newSVsv (ST (i)));
1660 1779
1661 SvREFCNT_dec (grp->data); 1780 SvREFCNT_dec (grp->sv1);
1662 grp->data = (SV *)av; 1781 grp->sv1 = (SV *)av;
1663} 1782}
1664 1783
1665void 1784void
1666errno (aio_req grp, int errorno = errno) 1785errno (aio_req grp, int errorno = errno)
1667 CODE: 1786 CODE:
1668 grp->errorno = errorno; 1787 grp->errorno = errorno;
1669 1788
1670void 1789void
1671limit (aio_req grp, int limit) 1790limit (aio_req grp, int limit)
1672 CODE: 1791 CODE:
1673 grp->fd2 = limit; 1792 grp->int2 = limit;
1674 aio_grp_feed (grp); 1793 aio_grp_feed (grp);
1675 1794
1676void 1795void
1677feed (aio_req grp, SV *callback=&PL_sv_undef) 1796feed (aio_req grp, SV *callback=&PL_sv_undef)
1678 CODE: 1797 CODE:
1679{ 1798{
1680 SvREFCNT_dec (grp->fh2); 1799 SvREFCNT_dec (grp->sv2);
1681 grp->fh2 = newSVsv (callback); 1800 grp->sv2 = newSVsv (callback);
1682 1801
1683 if (grp->fd2 <= 0) 1802 if (grp->int2 <= 0)
1684 grp->fd2 = 2; 1803 grp->int2 = 2;
1685 1804
1686 aio_grp_feed (grp); 1805 aio_grp_feed (grp);
1687} 1806}
1688 1807

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines