ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/JSON-XS/XS.xs
(Generate patch)

Comparing JSON-XS/XS.xs (file contents):
Revision 1.43 by root, Sat Jun 23 23:49:29 2007 UTC vs.
Revision 1.64 by root, Mon Aug 27 02:03:23 2007 UTC

1#include "EXTERN.h" 1#include "EXTERN.h"
2#include "perl.h" 2#include "perl.h"
3#include "XSUB.h" 3#include "XSUB.h"
4 4
5#include "assert.h" 5#include <assert.h>
6#include "string.h" 6#include <string.h>
7#include "stdlib.h" 7#include <stdlib.h>
8#include "stdio.h" 8#include <stdio.h>
9#include <float.h>
9 10
10#if defined(__BORLANDC__) || defined(_MSC_VER) 11#if defined(__BORLANDC__) || defined(_MSC_VER)
11# define snprintf _snprintf // C compilers have this in stdio.h 12# define snprintf _snprintf // C compilers have this in stdio.h
12#endif 13#endif
13 14
15// guarentees, though. if it breaks, you get to keep the pieces. 16// guarentees, though. if it breaks, you get to keep the pieces.
16#ifndef UTF8_MAXBYTES 17#ifndef UTF8_MAXBYTES
17# define UTF8_MAXBYTES 13 18# define UTF8_MAXBYTES 13
18#endif 19#endif
19 20
20#define F_ASCII 0x00000001UL 21#define F_ASCII 0x00000001UL
21#define F_LATIN1 0x00000002UL 22#define F_LATIN1 0x00000002UL
22#define F_UTF8 0x00000004UL 23#define F_UTF8 0x00000004UL
23#define F_INDENT 0x00000008UL 24#define F_INDENT 0x00000008UL
24#define F_CANONICAL 0x00000010UL 25#define F_CANONICAL 0x00000010UL
25#define F_SPACE_BEFORE 0x00000020UL 26#define F_SPACE_BEFORE 0x00000020UL
26#define F_SPACE_AFTER 0x00000040UL 27#define F_SPACE_AFTER 0x00000040UL
27#define F_ALLOW_NONREF 0x00000100UL 28#define F_ALLOW_NONREF 0x00000100UL
28#define F_SHRINK 0x00000200UL 29#define F_SHRINK 0x00000200UL
30#define F_ALLOW_BLESSED 0x00000400UL
31#define F_CONV_BLESSED 0x00000800UL
32#define F_RELAXED 0x00001000UL
33
29#define F_MAXDEPTH 0xf8000000UL 34#define F_MAXDEPTH 0xf8000000UL
30#define S_MAXDEPTH 27 35#define S_MAXDEPTH 27
36#define F_MAXSIZE 0x01f00000UL
37#define S_MAXSIZE 20
38#define F_HOOK 0x00080000UL // some hooks exist, so slow-path processing
31 39
32#define DEC_DEPTH(flags) (1UL << ((flags & F_MAXDEPTH) >> S_MAXDEPTH)) 40#define DEC_DEPTH(flags) (1UL << ((flags & F_MAXDEPTH) >> S_MAXDEPTH))
33 41#define DEC_SIZE(flags) (1UL << ((flags & F_MAXSIZE ) >> S_MAXSIZE ))
34// F_SELFCONVERT? <=> to_json/toJson
35// F_BLESSED? <=> { $__class__$ => }
36 42
37#define F_PRETTY F_INDENT | F_SPACE_BEFORE | F_SPACE_AFTER 43#define F_PRETTY F_INDENT | F_SPACE_BEFORE | F_SPACE_AFTER
38#define F_DEFAULT (9UL << S_MAXDEPTH) 44#define F_DEFAULT (9UL << S_MAXDEPTH)
39 45
40#define INIT_SIZE 32 // initial scalar size to be allocated 46#define INIT_SIZE 32 // initial scalar size to be allocated
54#endif 60#endif
55 61
56#define expect_false(expr) expect ((expr) != 0, 0) 62#define expect_false(expr) expect ((expr) != 0, 0)
57#define expect_true(expr) expect ((expr) != 0, 1) 63#define expect_true(expr) expect ((expr) != 0, 1)
58 64
65#ifdef USE_ITHREADS
66# define JSON_SLOW 1
67# define JSON_STASH (json_stash ? json_stash : gv_stashpv ("JSON::XS", 1))
68#else
69# define JSON_SLOW 0
70# define JSON_STASH json_stash
71#endif
72
59static HV *json_stash; // JSON::XS:: 73static HV *json_stash, *json_boolean_stash; // JSON::XS::
60static SV *json_true, *json_false; 74static SV *json_true, *json_false;
75
76typedef struct {
77 U32 flags;
78 SV *cb_object;
79 HV *cb_sk_object;
80} JSON;
61 81
62///////////////////////////////////////////////////////////////////////////// 82/////////////////////////////////////////////////////////////////////////////
63// utility functions 83// utility functions
64 84
65static UV * 85inline void
66SvJSON (SV *sv)
67{
68 if (!(SvROK (sv) && SvOBJECT (SvRV (sv)) && SvSTASH (SvRV (sv)) == json_stash))
69 croak ("object is not of type JSON::XS");
70
71 return &SvUVX (SvRV (sv));
72}
73
74static void
75shrink (SV *sv) 86shrink (SV *sv)
76{ 87{
77 sv_utf8_downgrade (sv, 1); 88 sv_utf8_downgrade (sv, 1);
78 if (SvLEN (sv) > SvCUR (sv) + 1) 89 if (SvLEN (sv) > SvCUR (sv) + 1)
79 { 90 {
114typedef struct 125typedef struct
115{ 126{
116 char *cur; // SvPVX (sv) + current output position 127 char *cur; // SvPVX (sv) + current output position
117 char *end; // SvEND (sv) 128 char *end; // SvEND (sv)
118 SV *sv; // result scalar 129 SV *sv; // result scalar
119 U32 flags; // F_* 130 JSON json;
120 U32 indent; // indentation level 131 U32 indent; // indentation level
121 U32 maxdepth; // max. indentation/recursion level 132 U32 maxdepth; // max. indentation/recursion level
122} enc_t; 133} enc_t;
123 134
124inline void 135inline void
198 } 209 }
199 210
200 if (uch > 0x10FFFFUL) 211 if (uch > 0x10FFFFUL)
201 croak ("out of range codepoint (0x%lx) encountered, unrepresentable in JSON", (unsigned long)uch); 212 croak ("out of range codepoint (0x%lx) encountered, unrepresentable in JSON", (unsigned long)uch);
202 213
203 if (uch < 0x80 || enc->flags & F_ASCII || (enc->flags & F_LATIN1 && uch > 0xFF)) 214 if (uch < 0x80 || enc->json.flags & F_ASCII || (enc->json.flags & F_LATIN1 && uch > 0xFF))
204 { 215 {
205 if (uch > 0xFFFFUL) 216 if (uch > 0xFFFFUL)
206 { 217 {
207 need (enc, len += 11); 218 need (enc, len += 11);
208 sprintf (enc->cur, "\\u%04x\\u%04x", 219 sprintf (enc->cur, "\\u%04x\\u%04x",
222 *enc->cur++ = hexdigit [(uch >> 0) & 15]; 233 *enc->cur++ = hexdigit [(uch >> 0) & 15];
223 } 234 }
224 235
225 str += clen; 236 str += clen;
226 } 237 }
227 else if (enc->flags & F_LATIN1) 238 else if (enc->json.flags & F_LATIN1)
228 { 239 {
229 *enc->cur++ = uch; 240 *enc->cur++ = uch;
230 str += clen; 241 str += clen;
231 } 242 }
232 else if (is_utf8) 243 else if (is_utf8)
253} 264}
254 265
255inline void 266inline void
256encode_indent (enc_t *enc) 267encode_indent (enc_t *enc)
257{ 268{
258 if (enc->flags & F_INDENT) 269 if (enc->json.flags & F_INDENT)
259 { 270 {
260 int spaces = enc->indent * INDENT_STEP; 271 int spaces = enc->indent * INDENT_STEP;
261 272
262 need (enc, spaces); 273 need (enc, spaces);
263 memset (enc->cur, ' ', spaces); 274 memset (enc->cur, ' ', spaces);
273} 284}
274 285
275inline void 286inline void
276encode_nl (enc_t *enc) 287encode_nl (enc_t *enc)
277{ 288{
278 if (enc->flags & F_INDENT) 289 if (enc->json.flags & F_INDENT)
279 { 290 {
280 need (enc, 1); 291 need (enc, 1);
281 encode_ch (enc, '\n'); 292 encode_ch (enc, '\n');
282 } 293 }
283} 294}
285inline void 296inline void
286encode_comma (enc_t *enc) 297encode_comma (enc_t *enc)
287{ 298{
288 encode_ch (enc, ','); 299 encode_ch (enc, ',');
289 300
290 if (enc->flags & F_INDENT) 301 if (enc->json.flags & F_INDENT)
291 encode_nl (enc); 302 encode_nl (enc);
292 else if (enc->flags & F_SPACE_AFTER) 303 else if (enc->json.flags & F_SPACE_AFTER)
293 encode_space (enc); 304 encode_space (enc);
294} 305}
295 306
296static void encode_sv (enc_t *enc, SV *sv); 307static void encode_sv (enc_t *enc, SV *sv);
297 308
306 encode_ch (enc, '['); encode_nl (enc); 317 encode_ch (enc, '['); encode_nl (enc);
307 ++enc->indent; 318 ++enc->indent;
308 319
309 for (i = 0; i <= len; ++i) 320 for (i = 0; i <= len; ++i)
310 { 321 {
322 SV **svp = av_fetch (av, i, 0);
323
311 encode_indent (enc); 324 encode_indent (enc);
312 encode_sv (enc, *av_fetch (av, i, 0)); 325
326 if (svp)
327 encode_sv (enc, *svp);
328 else
329 encode_str (enc, "null", 4, 0);
313 330
314 if (i < len) 331 if (i < len)
315 encode_comma (enc); 332 encode_comma (enc);
316 } 333 }
317 334
320 --enc->indent; 337 --enc->indent;
321 encode_indent (enc); encode_ch (enc, ']'); 338 encode_indent (enc); encode_ch (enc, ']');
322} 339}
323 340
324static void 341static void
325encode_he (enc_t *enc, HE *he) 342encode_hk (enc_t *enc, HE *he)
326{ 343{
327 encode_ch (enc, '"'); 344 encode_ch (enc, '"');
328 345
329 if (HeKLEN (he) == HEf_SVKEY) 346 if (HeKLEN (he) == HEf_SVKEY)
330 { 347 {
340 else 357 else
341 encode_str (enc, HeKEY (he), HeKLEN (he), HeKUTF8 (he)); 358 encode_str (enc, HeKEY (he), HeKLEN (he), HeKUTF8 (he));
342 359
343 encode_ch (enc, '"'); 360 encode_ch (enc, '"');
344 361
345 if (enc->flags & F_SPACE_BEFORE) encode_space (enc); 362 if (enc->json.flags & F_SPACE_BEFORE) encode_space (enc);
346 encode_ch (enc, ':'); 363 encode_ch (enc, ':');
347 if (enc->flags & F_SPACE_AFTER ) encode_space (enc); 364 if (enc->json.flags & F_SPACE_AFTER ) encode_space (enc);
348 encode_sv (enc, HeVAL (he));
349} 365}
350 366
351// compare hash entries, used when all keys are bytestrings 367// compare hash entries, used when all keys are bytestrings
352static int 368static int
353he_cmp_fast (const void *a_, const void *b_) 369he_cmp_fast (const void *a_, const void *b_)
358 HE *b = *(HE **)b_; 374 HE *b = *(HE **)b_;
359 375
360 STRLEN la = HeKLEN (a); 376 STRLEN la = HeKLEN (a);
361 STRLEN lb = HeKLEN (b); 377 STRLEN lb = HeKLEN (b);
362 378
363 if (!(cmp = memcmp (HeKEY (a), HeKEY (b), la < lb ? la : lb))) 379 if (!(cmp = memcmp (HeKEY (b), HeKEY (a), lb < la ? lb : la)))
364 cmp = la - lb; 380 cmp = lb - la;
365 381
366 return cmp; 382 return cmp;
367} 383}
368 384
369// compare hash entries, used when some keys are sv's or utf-x 385// compare hash entries, used when some keys are sv's or utf-x
370static int 386static int
371he_cmp_slow (const void *a, const void *b) 387he_cmp_slow (const void *a, const void *b)
372{ 388{
373 return sv_cmp (HeSVKEY_force (*(HE **)a), HeSVKEY_force (*(HE **)b)); 389 return sv_cmp (HeSVKEY_force (*(HE **)b), HeSVKEY_force (*(HE **)a));
374} 390}
375 391
376static void 392static void
377encode_hv (enc_t *enc, HV *hv) 393encode_hv (enc_t *enc, HV *hv)
378{ 394{
395 HE *he;
379 int count, i; 396 int count;
380 397
381 if (enc->indent >= enc->maxdepth) 398 if (enc->indent >= enc->maxdepth)
382 croak ("data structure too deep (hit recursion limit)"); 399 croak ("data structure too deep (hit recursion limit)");
383 400
384 encode_ch (enc, '{'); encode_nl (enc); ++enc->indent; 401 encode_ch (enc, '{'); encode_nl (enc); ++enc->indent;
385 402
386 if ((count = hv_iterinit (hv)))
387 {
388 // for canonical output we have to sort by keys first 403 // for canonical output we have to sort by keys first
389 // actually, this is mostly due to the stupid so-called 404 // actually, this is mostly due to the stupid so-called
390 // security workaround added somewhere in 5.8.x. 405 // security workaround added somewhere in 5.8.x.
391 // that randomises hash orderings 406 // that randomises hash orderings
392 if (enc->flags & F_CANONICAL) 407 if (enc->json.flags & F_CANONICAL)
408 {
409 int count = hv_iterinit (hv);
410
411 if (SvMAGICAL (hv))
393 { 412 {
413 // need to count by iterating. could improve by dynamically building the vector below
414 // but I don't care for the speed of this special case.
415 // note also that we will run into undefined behaviour when the two iterations
416 // do not result in the same count, something I might care for in some later release.
417
418 count = 0;
419 while (hv_iternext (hv))
420 ++count;
421
422 hv_iterinit (hv);
423 }
424
425 if (count)
426 {
394 int fast = 1; 427 int i, fast = 1;
395 HE *he;
396#if defined(__BORLANDC__) || defined(_MSC_VER) 428#if defined(__BORLANDC__) || defined(_MSC_VER)
397 HE **hes = _alloca (count * sizeof (HE)); 429 HE **hes = _alloca (count * sizeof (HE));
398#else 430#else
399 HE *hes [count]; // if your compiler dies here, you need to enable C99 mode 431 HE *hes [count]; // if your compiler dies here, you need to enable C99 mode
400#endif 432#endif
427 459
428 FREETMPS; 460 FREETMPS;
429 LEAVE; 461 LEAVE;
430 } 462 }
431 463
432 for (i = 0; i < count; ++i) 464 while (count--)
433 { 465 {
434 encode_indent (enc); 466 encode_indent (enc);
467 he = hes [count];
435 encode_he (enc, hes [i]); 468 encode_hk (enc, he);
469 encode_sv (enc, expect_false (SvMAGICAL (hv)) ? hv_iterval (hv, he) : HeVAL (he));
436 470
437 if (i < count - 1) 471 if (count)
438 encode_comma (enc); 472 encode_comma (enc);
439 } 473 }
440 474 }
475 }
476 else
477 {
478 if (hv_iterinit (hv) || SvMAGICAL (hv))
479 if ((he = hv_iternext (hv)))
480 for (;;)
481 {
441 encode_nl (enc); 482 encode_indent (enc);
483 encode_hk (enc, he);
484 encode_sv (enc, expect_false (SvMAGICAL (hv)) ? hv_iterval (hv, he) : HeVAL (he));
485
486 if (!(he = hv_iternext (hv)))
487 break;
488
489 encode_comma (enc);
490 }
491 }
492
493 encode_nl (enc);
494
495 --enc->indent; encode_indent (enc); encode_ch (enc, '}');
496}
497
498// encode objects, arrays and special \0=false and \1=true values.
499static void
500encode_rv (enc_t *enc, SV *sv)
501{
502 svtype svt;
503
504 SvGETMAGIC (sv);
505 svt = SvTYPE (sv);
506
507 if (expect_false (SvOBJECT (sv)))
508 {
509 HV *stash = !JSON_SLOW || json_boolean_stash
510 ? json_boolean_stash
511 : gv_stashpv ("JSON::XS::Boolean", 1);
512
513 if (SvSTASH (sv) == stash)
514 {
515 if (SvIV (sv))
516 encode_str (enc, "true", 4, 0);
517 else
518 encode_str (enc, "false", 5, 0);
442 } 519 }
443 else 520 else
444 { 521 {
445 HE *he = hv_iternext (hv); 522#if 0
446 523 if (0 && sv_derived_from (rv, "JSON::Literal"))
447 for (;;)
448 {
449 encode_indent (enc);
450 encode_he (enc, he);
451
452 if (!(he = hv_iternext (hv)))
453 break;
454
455 encode_comma (enc);
456 } 524 {
525 // not yet
526 }
527#endif
528 if (enc->json.flags & F_CONV_BLESSED)
529 {
530 // we re-bless the reference to get overload and other niceties right
531 GV *to_json = gv_fetchmethod_autoload (SvSTASH (sv), "TO_JSON", 0);
457 532
533 if (to_json)
534 {
535 dSP;
536
537 ENTER; SAVETMPS; PUSHMARK (SP);
538 XPUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), SvSTASH (sv)));
539
540 // calling with G_SCALAR ensures that we always get a 1 return value
541 PUTBACK;
542 call_sv ((SV *)GvCV (to_json), G_SCALAR);
543 SPAGAIN;
544
545 // catch this surprisingly common error
546 if (SvROK (TOPs) && SvRV (TOPs) == sv)
547 croak ("%s::TO_JSON method returned same object as was passed instead of a new one", HvNAME (SvSTASH (sv)));
548
549 sv = POPs;
550 PUTBACK;
551
458 encode_nl (enc); 552 encode_sv (enc, sv);
553
554 FREETMPS; LEAVE;
555 }
556 else if (enc->json.flags & F_ALLOW_BLESSED)
557 encode_str (enc, "null", 4, 0);
558 else
559 croak ("encountered object '%s', but neither allow_blessed enabled nor TO_JSON method available on it",
560 SvPV_nolen (sv_2mortal (newRV_inc (sv))));
561 }
562 else if (enc->json.flags & F_ALLOW_BLESSED)
563 encode_str (enc, "null", 4, 0);
564 else
565 croak ("encountered object '%s', but neither allow_blessed nor convert_blessed settings are enabled",
566 SvPV_nolen (sv_2mortal (newRV_inc (sv))));
459 } 567 }
460 } 568 }
461
462 --enc->indent; encode_indent (enc); encode_ch (enc, '}');
463}
464
465// encode objects, arrays and special \0=false and \1=true values.
466static void
467encode_rv (enc_t *enc, SV *sv)
468{
469 svtype svt;
470
471 SvGETMAGIC (sv);
472 svt = SvTYPE (sv);
473
474 if (svt == SVt_PVHV) 569 else if (svt == SVt_PVHV)
475 encode_hv (enc, (HV *)sv); 570 encode_hv (enc, (HV *)sv);
476 else if (svt == SVt_PVAV) 571 else if (svt == SVt_PVAV)
477 encode_av (enc, (AV *)sv); 572 encode_av (enc, (AV *)sv);
478 else if (svt < SVt_PVAV) 573 else if (svt < SVt_PVAV)
479 { 574 {
480 if (SvNIOK (sv) && SvIV (sv) == 0) 575 STRLEN len = 0;
576 char *pv = svt ? SvPV (sv, len) : 0;
577
578 if (len == 1 && *pv == '1')
579 encode_str (enc, "true", 4, 0);
580 else if (len == 1 && *pv == '0')
481 encode_str (enc, "false", 5, 0); 581 encode_str (enc, "false", 5, 0);
482 else if (SvNIOK (sv) && SvIV (sv) == 1)
483 encode_str (enc, "true", 4, 0);
484 else 582 else
485 croak ("cannot encode reference to scalar '%s' unless the scalar is 0 or 1", 583 croak ("cannot encode reference to scalar '%s' unless the scalar is 0 or 1",
486 SvPV_nolen (sv_2mortal (newRV_inc (sv)))); 584 SvPV_nolen (sv_2mortal (newRV_inc (sv))));
487 } 585 }
488 else 586 else
558 croak ("encountered perl type (%s,0x%x) that JSON cannot handle, you might want to report this", 656 croak ("encountered perl type (%s,0x%x) that JSON cannot handle, you might want to report this",
559 SvPV_nolen (sv), SvFLAGS (sv)); 657 SvPV_nolen (sv), SvFLAGS (sv));
560} 658}
561 659
562static SV * 660static SV *
563encode_json (SV *scalar, U32 flags) 661encode_json (SV *scalar, JSON *json)
564{ 662{
565 enc_t enc; 663 enc_t enc;
566 664
567 if (!(flags & F_ALLOW_NONREF) && !SvROK (scalar)) 665 if (!(json->flags & F_ALLOW_NONREF) && !SvROK (scalar))
568 croak ("hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this)"); 666 croak ("hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this)");
569 667
570 enc.flags = flags; 668 enc.json = *json;
571 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE)); 669 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE));
572 enc.cur = SvPVX (enc.sv); 670 enc.cur = SvPVX (enc.sv);
573 enc.end = SvEND (enc.sv); 671 enc.end = SvEND (enc.sv);
574 enc.indent = 0; 672 enc.indent = 0;
575 enc.maxdepth = DEC_DEPTH (flags); 673 enc.maxdepth = DEC_DEPTH (enc.json.flags);
576 674
577 SvPOK_only (enc.sv); 675 SvPOK_only (enc.sv);
578 encode_sv (&enc, scalar); 676 encode_sv (&enc, scalar);
579 677
580 SvCUR_set (enc.sv, enc.cur - SvPVX (enc.sv)); 678 SvCUR_set (enc.sv, enc.cur - SvPVX (enc.sv));
581 *SvEND (enc.sv) = 0; // many xs functions expect a trailing 0 for text strings 679 *SvEND (enc.sv) = 0; // many xs functions expect a trailing 0 for text strings
582 680
583 if (!(flags & (F_ASCII | F_LATIN1 | F_UTF8))) 681 if (!(enc.json.flags & (F_ASCII | F_LATIN1 | F_UTF8)))
584 SvUTF8_on (enc.sv); 682 SvUTF8_on (enc.sv);
585 683
586 if (enc.flags & F_SHRINK) 684 if (enc.json.flags & F_SHRINK)
587 shrink (enc.sv); 685 shrink (enc.sv);
588 686
589 return enc.sv; 687 return enc.sv;
590} 688}
591 689
596typedef struct 694typedef struct
597{ 695{
598 char *cur; // current parser pointer 696 char *cur; // current parser pointer
599 char *end; // end of input string 697 char *end; // end of input string
600 const char *err; // parse error, if != 0 698 const char *err; // parse error, if != 0
601 U32 flags; // F_* 699 JSON json;
602 U32 depth; // recursion depth 700 U32 depth; // recursion depth
603 U32 maxdepth; // recursion depth limit 701 U32 maxdepth; // recursion depth limit
604} dec_t; 702} dec_t;
605 703
606inline void 704inline void
705decode_comment (dec_t *dec)
706{
707 // only '#'-style comments allowed a.t.m.
708
709 while (*dec->cur && *dec->cur != 0x0a && *dec->cur != 0x0d)
710 ++dec->cur;
711}
712
713inline void
607decode_ws (dec_t *dec) 714decode_ws (dec_t *dec)
608{ 715{
609 for (;;) 716 for (;;)
610 { 717 {
611 char ch = *dec->cur; 718 char ch = *dec->cur;
612 719
613 if (ch > 0x20 720 if (ch > 0x20)
721 {
722 if (expect_false (ch == '#'))
723 {
724 if (dec->json.flags & F_RELAXED)
725 decode_comment (dec);
726 else
727 break;
728 }
729 else
730 break;
731 }
614 || (ch != 0x20 && ch != 0x0a && ch != 0x0d && ch != 0x09)) 732 else if (ch != 0x20 && ch != 0x0a && ch != 0x0d && ch != 0x09)
615 break; 733 break; // parse error, but let higher level handle it, gives better error messages
616 734
617 ++dec->cur; 735 ++dec->cur;
618 } 736 }
619} 737}
620 738
869 is_nv = 1; 987 is_nv = 1;
870 } 988 }
871 989
872 if (!is_nv) 990 if (!is_nv)
873 { 991 {
992 int len = dec->cur - start;
993
874 // special case the rather common 1..4-digit-int case, assumes 32 bit ints or so 994 // special case the rather common 1..4-digit-int case, assumes 32 bit ints or so
875 if (*start == '-') 995 if (*start == '-')
876 switch (dec->cur - start) 996 switch (len)
877 { 997 {
878 case 2: return newSViv (-( start [1] - '0' * 1)); 998 case 2: return newSViv (-( start [1] - '0' * 1));
879 case 3: return newSViv (-( start [1] * 10 + start [2] - '0' * 11)); 999 case 3: return newSViv (-( start [1] * 10 + start [2] - '0' * 11));
880 case 4: return newSViv (-( start [1] * 100 + start [2] * 10 + start [3] - '0' * 111)); 1000 case 4: return newSViv (-( start [1] * 100 + start [2] * 10 + start [3] - '0' * 111));
881 case 5: return newSViv (-(start [1] * 1000 + start [2] * 100 + start [3] * 10 + start [4] - '0' * 1111)); 1001 case 5: return newSViv (-(start [1] * 1000 + start [2] * 100 + start [3] * 10 + start [4] - '0' * 1111));
882 } 1002 }
883 else 1003 else
884 switch (dec->cur - start) 1004 switch (len)
885 { 1005 {
886 case 1: return newSViv ( start [0] - '0' * 1); 1006 case 1: return newSViv ( start [0] - '0' * 1);
887 case 2: return newSViv ( start [0] * 10 + start [1] - '0' * 11); 1007 case 2: return newSViv ( start [0] * 10 + start [1] - '0' * 11);
888 case 3: return newSViv ( start [0] * 100 + start [1] * 10 + start [2] - '0' * 111); 1008 case 3: return newSViv ( start [0] * 100 + start [1] * 10 + start [2] - '0' * 111);
889 case 4: return newSViv ( start [0] * 1000 + start [1] * 100 + start [2] * 10 + start [3] - '0' * 1111); 1009 case 4: return newSViv ( start [0] * 1000 + start [1] * 100 + start [2] * 10 + start [3] - '0' * 1111);
890 } 1010 }
891 1011
892 { 1012 {
893 UV uv; 1013 UV uv;
894 int numtype = grok_number (start, dec->cur - start, &uv); 1014 int numtype = grok_number (start, len, &uv);
895 if (numtype & IS_NUMBER_IN_UV) 1015 if (numtype & IS_NUMBER_IN_UV)
896 if (numtype & IS_NUMBER_NEG) 1016 if (numtype & IS_NUMBER_NEG)
897 { 1017 {
898 if (uv < (UV)IV_MIN) 1018 if (uv < (UV)IV_MIN)
899 return newSViv (-(IV)uv); 1019 return newSViv (-(IV)uv);
900 } 1020 }
901 else 1021 else
902 return newSVuv (uv); 1022 return newSVuv (uv);
903
904 // here would likely be the place for bigint support
905 } 1023 }
906 }
907 1024
908 // if we ever support bigint or bigfloat, this is the place for bigfloat 1025 len -= *start == '-' ? 1 : 0;
1026
1027 // does not fit into IV or UV, try NV
1028 if ((sizeof (NV) == sizeof (double) && DBL_DIG >= len)
1029 #if defined (LDBL_DIG)
1030 || (sizeof (NV) == sizeof (long double) && LDBL_DIG >= len)
1031 #endif
1032 )
1033 // fits into NV without loss of precision
1034 return newSVnv (Atof (start));
1035
1036 // everything else fails, convert it to a string
1037 return newSVpvn (start, dec->cur - start);
1038 }
1039
1040 // loss of precision here
909 return newSVnv (Atof (start)); 1041 return newSVnv (Atof (start));
910 1042
911fail: 1043fail:
912 return 0; 1044 return 0;
913} 1045}
943 1075
944 if (*dec->cur != ',') 1076 if (*dec->cur != ',')
945 ERR (", or ] expected while parsing array"); 1077 ERR (", or ] expected while parsing array");
946 1078
947 ++dec->cur; 1079 ++dec->cur;
1080
1081 decode_ws (dec);
1082
1083 if (*dec->cur == ']' && dec->json.flags & F_RELAXED)
1084 {
1085 ++dec->cur;
1086 break;
1087 }
948 } 1088 }
949 1089
950 DEC_DEC_DEPTH; 1090 DEC_DEC_DEPTH;
951 return newRV_noinc ((SV *)av); 1091 return newRV_noinc ((SV *)av);
952 1092
957} 1097}
958 1098
959static SV * 1099static SV *
960decode_hv (dec_t *dec) 1100decode_hv (dec_t *dec)
961{ 1101{
1102 SV *sv;
962 HV *hv = newHV (); 1103 HV *hv = newHV ();
963 1104
964 DEC_INC_DEPTH; 1105 DEC_INC_DEPTH;
965 decode_ws (dec); 1106 decode_ws (dec);
966 1107
967 if (*dec->cur == '}') 1108 if (*dec->cur == '}')
968 ++dec->cur; 1109 ++dec->cur;
969 else 1110 else
970 for (;;) 1111 for (;;)
971 { 1112 {
1113 EXPECT_CH ('"');
1114
1115 // heuristic: assume that
1116 // a) decode_str + hv_store_ent are abysmally slow.
1117 // b) most hash keys are short, simple ascii text.
1118 // => try to "fast-match" such strings to avoid
1119 // the overhead of decode_str + hv_store_ent.
1120 {
972 SV *key, *value; 1121 SV *value;
1122 char *p = dec->cur;
1123 char *e = p + 24; // only try up to 24 bytes
973 1124
974 decode_ws (dec); EXPECT_CH ('"'); 1125 for (;;)
975
976 key = decode_str (dec);
977 if (!key)
978 goto fail;
979
980 decode_ws (dec); EXPECT_CH (':');
981
982 value = decode_sv (dec);
983 if (!value)
984 { 1126 {
1127 // the >= 0x80 is true on most architectures
1128 if (p == e || *p < 0x20 || *p >= 0x80 || *p == '\\')
1129 {
1130 // slow path, back up and use decode_str
1131 SV *key = decode_str (dec);
1132 if (!key)
1133 goto fail;
1134
1135 decode_ws (dec); EXPECT_CH (':');
1136
1137 decode_ws (dec);
1138 value = decode_sv (dec);
1139 if (!value)
1140 {
1141 SvREFCNT_dec (key);
1142 goto fail;
1143 }
1144
1145 hv_store_ent (hv, key, value, 0);
985 SvREFCNT_dec (key); 1146 SvREFCNT_dec (key);
1147
1148 break;
1149 }
1150 else if (*p == '"')
1151 {
1152 // fast path, got a simple key
1153 char *key = dec->cur;
1154 int len = p - key;
1155 dec->cur = p + 1;
1156
1157 decode_ws (dec); EXPECT_CH (':');
1158
1159 decode_ws (dec);
1160 value = decode_sv (dec);
1161 if (!value)
986 goto fail; 1162 goto fail;
1163
1164 hv_store (hv, key, len, value, 0);
1165
1166 break;
1167 }
1168
1169 ++p;
987 } 1170 }
988 1171 }
989 hv_store_ent (hv, key, value, 0);
990 SvREFCNT_dec (key);
991 1172
992 decode_ws (dec); 1173 decode_ws (dec);
993 1174
994 if (*dec->cur == '}') 1175 if (*dec->cur == '}')
995 { 1176 {
999 1180
1000 if (*dec->cur != ',') 1181 if (*dec->cur != ',')
1001 ERR (", or } expected while parsing object/hash"); 1182 ERR (", or } expected while parsing object/hash");
1002 1183
1003 ++dec->cur; 1184 ++dec->cur;
1185
1186 decode_ws (dec);
1187
1188 if (*dec->cur == '}' && dec->json.flags & F_RELAXED)
1189 {
1190 ++dec->cur;
1191 break;
1192 }
1004 } 1193 }
1005 1194
1006 DEC_DEC_DEPTH; 1195 DEC_DEC_DEPTH;
1007 return newRV_noinc ((SV *)hv); 1196 sv = newRV_noinc ((SV *)hv);
1197
1198 // check filter callbacks
1199 if (dec->json.flags & F_HOOK)
1200 {
1201 if (dec->json.cb_sk_object && HvKEYS (hv) == 1)
1202 {
1203 HE *cb, *he;
1204
1205 hv_iterinit (hv);
1206 he = hv_iternext (hv);
1207 hv_iterinit (hv);
1208
1209 // the next line creates a mortal sv each time its called.
1210 // might want to optimise this for common cases.
1211 cb = hv_fetch_ent (dec->json.cb_sk_object, hv_iterkeysv (he), 0, 0);
1212
1213 if (cb)
1214 {
1215 dSP;
1216 int count;
1217
1218 ENTER; SAVETMPS; PUSHMARK (SP);
1219 XPUSHs (HeVAL (he));
1220
1221 PUTBACK; count = call_sv (HeVAL (cb), G_ARRAY); SPAGAIN;
1222
1223 if (count == 1)
1224 {
1225 sv = newSVsv (POPs);
1226 FREETMPS; LEAVE;
1227 return sv;
1228 }
1229
1230 FREETMPS; LEAVE;
1231 }
1232 }
1233
1234 if (dec->json.cb_object)
1235 {
1236 dSP;
1237 int count;
1238
1239 ENTER; SAVETMPS; PUSHMARK (SP);
1240 XPUSHs (sv_2mortal (sv));
1241
1242 PUTBACK; count = call_sv (dec->json.cb_object, G_ARRAY); SPAGAIN;
1243
1244 if (count == 1)
1245 {
1246 sv = newSVsv (POPs);
1247 FREETMPS; LEAVE;
1248 return sv;
1249 }
1250
1251 SvREFCNT_inc (sv);
1252 FREETMPS; LEAVE;
1253 }
1254 }
1255
1256 return sv;
1008 1257
1009fail: 1258fail:
1010 SvREFCNT_dec (hv); 1259 SvREFCNT_dec (hv);
1011 DEC_DEC_DEPTH; 1260 DEC_DEC_DEPTH;
1012 return 0; 1261 return 0;
1013} 1262}
1014 1263
1015static SV * 1264static SV *
1016decode_sv (dec_t *dec) 1265decode_sv (dec_t *dec)
1017{ 1266{
1018 decode_ws (dec);
1019
1020 // the beauty of JSON: you need exactly one character lookahead 1267 // the beauty of JSON: you need exactly one character lookahead
1021 // to parse anything. 1268 // to parse anything.
1022 switch (*dec->cur) 1269 switch (*dec->cur)
1023 { 1270 {
1024 case '"': ++dec->cur; return decode_str (dec); 1271 case '"': ++dec->cur; return decode_str (dec);
1032 1279
1033 case 't': 1280 case 't':
1034 if (dec->end - dec->cur >= 4 && !memcmp (dec->cur, "true", 4)) 1281 if (dec->end - dec->cur >= 4 && !memcmp (dec->cur, "true", 4))
1035 { 1282 {
1036 dec->cur += 4; 1283 dec->cur += 4;
1284#if JSON_SLOW
1285 json_true = get_sv ("JSON::XS::true", 1); SvREADONLY_on (json_true);
1286#endif
1037 return SvREFCNT_inc (json_true); 1287 return SvREFCNT_inc (json_true);
1038 } 1288 }
1039 else 1289 else
1040 ERR ("'true' expected"); 1290 ERR ("'true' expected");
1041 1291
1043 1293
1044 case 'f': 1294 case 'f':
1045 if (dec->end - dec->cur >= 5 && !memcmp (dec->cur, "false", 5)) 1295 if (dec->end - dec->cur >= 5 && !memcmp (dec->cur, "false", 5))
1046 { 1296 {
1047 dec->cur += 5; 1297 dec->cur += 5;
1298#if JSON_SLOW
1299 json_false = get_sv ("JSON::XS::false", 1); SvREADONLY_on (json_false);
1300#endif
1048 return SvREFCNT_inc (json_false); 1301 return SvREFCNT_inc (json_false);
1049 } 1302 }
1050 else 1303 else
1051 ERR ("'false' expected"); 1304 ERR ("'false' expected");
1052 1305
1071fail: 1324fail:
1072 return 0; 1325 return 0;
1073} 1326}
1074 1327
1075static SV * 1328static SV *
1076decode_json (SV *string, U32 flags, UV *offset_return) 1329decode_json (SV *string, JSON *json, UV *offset_return)
1077{ 1330{
1078 dec_t dec; 1331 dec_t dec;
1079 UV offset; 1332 UV offset;
1080 SV *sv; 1333 SV *sv;
1081 1334
1082 SvGETMAGIC (string); 1335 SvGETMAGIC (string);
1083 SvUPGRADE (string, SVt_PV); 1336 SvUPGRADE (string, SVt_PV);
1084 1337
1338 if (json->flags & F_MAXSIZE && SvCUR (string) > DEC_SIZE (json->flags))
1339 croak ("attempted decode of JSON text of %lu bytes size, but max_size is set to %lu",
1340 (unsigned long)SvCUR (string), (unsigned long)DEC_SIZE (json->flags));
1341
1085 if (flags & F_UTF8) 1342 if (json->flags & F_UTF8)
1086 sv_utf8_downgrade (string, 0); 1343 sv_utf8_downgrade (string, 0);
1087 else 1344 else
1088 sv_utf8_upgrade (string); 1345 sv_utf8_upgrade (string);
1089 1346
1090 SvGROW (string, SvCUR (string) + 1); // should basically be a NOP 1347 SvGROW (string, SvCUR (string) + 1); // should basically be a NOP
1091 1348
1092 dec.flags = flags; 1349 dec.json = *json;
1093 dec.cur = SvPVX (string); 1350 dec.cur = SvPVX (string);
1094 dec.end = SvEND (string); 1351 dec.end = SvEND (string);
1095 dec.err = 0; 1352 dec.err = 0;
1096 dec.depth = 0; 1353 dec.depth = 0;
1097 dec.maxdepth = DEC_DEPTH (dec.flags); 1354 dec.maxdepth = DEC_DEPTH (dec.json.flags);
1355
1356 if (dec.json.cb_object || dec.json.cb_sk_object)
1357 dec.json.flags |= F_HOOK;
1098 1358
1099 *dec.end = 0; // this should basically be a nop, too, but make sure it's there 1359 *dec.end = 0; // this should basically be a nop, too, but make sure it's there
1360
1361 decode_ws (&dec);
1100 sv = decode_sv (&dec); 1362 sv = decode_sv (&dec);
1101 1363
1102 if (!(offset_return || !sv)) 1364 if (!(offset_return || !sv))
1103 { 1365 {
1104 // check for trailing garbage 1366 // check for trailing garbage
1112 } 1374 }
1113 } 1375 }
1114 1376
1115 if (offset_return || !sv) 1377 if (offset_return || !sv)
1116 { 1378 {
1117 offset = dec.flags & F_UTF8 1379 offset = dec.json.flags & F_UTF8
1118 ? dec.cur - SvPVX (string) 1380 ? dec.cur - SvPVX (string)
1119 : utf8_distance (dec.cur, SvPVX (string)); 1381 : utf8_distance (dec.cur, SvPVX (string));
1120 1382
1121 if (offset_return) 1383 if (offset_return)
1122 *offset_return = offset; 1384 *offset_return = offset;
1141 dec.cur != dec.end ? SvPV_nolen (uni) : "(end of string)"); 1403 dec.cur != dec.end ? SvPV_nolen (uni) : "(end of string)");
1142 } 1404 }
1143 1405
1144 sv = sv_2mortal (sv); 1406 sv = sv_2mortal (sv);
1145 1407
1146 if (!(dec.flags & F_ALLOW_NONREF) && !SvROK (sv)) 1408 if (!(dec.json.flags & F_ALLOW_NONREF) && !SvROK (sv))
1147 croak ("JSON text must be an object or array (but found number, string, true, false or null, use allow_nonref to allow this)"); 1409 croak ("JSON text must be an object or array (but found number, string, true, false or null, use allow_nonref to allow this)");
1148 1410
1149 return sv; 1411 return sv;
1150} 1412}
1151 1413
1163 i >= '0' && i <= '9' ? i - '0' 1425 i >= '0' && i <= '9' ? i - '0'
1164 : i >= 'a' && i <= 'f' ? i - 'a' + 10 1426 : i >= 'a' && i <= 'f' ? i - 'a' + 10
1165 : i >= 'A' && i <= 'F' ? i - 'A' + 10 1427 : i >= 'A' && i <= 'F' ? i - 'A' + 10
1166 : -1; 1428 : -1;
1167 1429
1168 json_stash = gv_stashpv ("JSON::XS", 1); 1430 json_stash = gv_stashpv ("JSON::XS" , 1);
1431 json_boolean_stash = gv_stashpv ("JSON::XS::Boolean", 1);
1169 1432
1170 json_true = get_sv ("JSON::XS::true" , 1); SvREADONLY_on (json_true ); 1433 json_true = get_sv ("JSON::XS::true" , 1); SvREADONLY_on (json_true );
1171 json_false = get_sv ("JSON::XS::false", 1); SvREADONLY_on (json_false); 1434 json_false = get_sv ("JSON::XS::false", 1); SvREADONLY_on (json_false);
1172} 1435}
1173 1436
1174PROTOTYPES: DISABLE 1437PROTOTYPES: DISABLE
1175 1438
1176SV *new (char *dummy) 1439void CLONE (...)
1177 CODE: 1440 CODE:
1178 RETVAL = sv_bless (newRV_noinc (newSVuv (F_DEFAULT)), json_stash); 1441 json_stash = 0;
1179 OUTPUT: 1442 json_boolean_stash = 0;
1180 RETVAL
1181 1443
1444void new (char *klass)
1445 PPCODE:
1446{
1447 SV *pv = NEWSV (0, sizeof (JSON));
1448 SvPOK_only (pv);
1449 Zero (SvPVX (pv), 1, JSON);
1450 ((JSON *)SvPVX (pv))->flags = F_DEFAULT;
1451 XPUSHs (sv_2mortal (sv_bless (newRV_noinc (pv), JSON_STASH)));
1452}
1453
1182SV *ascii (SV *self, int enable = 1) 1454void ascii (JSON *self, int enable = 1)
1183 ALIAS: 1455 ALIAS:
1184 ascii = F_ASCII 1456 ascii = F_ASCII
1185 latin1 = F_LATIN1 1457 latin1 = F_LATIN1
1186 utf8 = F_UTF8 1458 utf8 = F_UTF8
1187 indent = F_INDENT 1459 indent = F_INDENT
1188 canonical = F_CANONICAL 1460 canonical = F_CANONICAL
1189 space_before = F_SPACE_BEFORE 1461 space_before = F_SPACE_BEFORE
1190 space_after = F_SPACE_AFTER 1462 space_after = F_SPACE_AFTER
1191 pretty = F_PRETTY 1463 pretty = F_PRETTY
1192 allow_nonref = F_ALLOW_NONREF 1464 allow_nonref = F_ALLOW_NONREF
1193 shrink = F_SHRINK 1465 shrink = F_SHRINK
1466 allow_blessed = F_ALLOW_BLESSED
1467 convert_blessed = F_CONV_BLESSED
1468 relaxed = F_RELAXED
1194 CODE: 1469 PPCODE:
1195{ 1470{
1196 UV *uv = SvJSON (self);
1197 if (enable) 1471 if (enable)
1198 *uv |= ix; 1472 self->flags |= ix;
1199 else 1473 else
1200 *uv &= ~ix; 1474 self->flags &= ~ix;
1201 1475
1202 RETVAL = newSVsv (self); 1476 XPUSHs (ST (0));
1203} 1477}
1204 OUTPUT:
1205 RETVAL
1206 1478
1207SV *max_depth (SV *self, UV max_depth = 0x80000000UL) 1479void max_depth (JSON *self, UV max_depth = 0x80000000UL)
1208 CODE: 1480 PPCODE:
1209{ 1481{
1210 UV *uv = SvJSON (self);
1211 UV log2 = 0; 1482 UV log2 = 0;
1212 1483
1213 if (max_depth > 0x80000000UL) max_depth = 0x80000000UL; 1484 if (max_depth > 0x80000000UL) max_depth = 0x80000000UL;
1214 1485
1215 while ((1UL << log2) < max_depth) 1486 while ((1UL << log2) < max_depth)
1216 ++log2; 1487 ++log2;
1217 1488
1218 *uv = *uv & ~F_MAXDEPTH | (log2 << S_MAXDEPTH); 1489 self->flags = self->flags & ~F_MAXDEPTH | (log2 << S_MAXDEPTH);
1219 1490
1220 RETVAL = newSVsv (self); 1491 XPUSHs (ST (0));
1221} 1492}
1222 OUTPUT:
1223 RETVAL
1224 1493
1225void encode (SV *self, SV *scalar) 1494void max_size (JSON *self, UV max_size = 0)
1226 PPCODE: 1495 PPCODE:
1227 XPUSHs (encode_json (scalar, *SvJSON (self))); 1496{
1497 UV log2 = 0;
1228 1498
1229void decode (SV *self, SV *jsonstr) 1499 if (max_size > 0x80000000UL) max_size = 0x80000000UL;
1500 if (max_size == 1) max_size = 2;
1501
1502 while ((1UL << log2) < max_size)
1503 ++log2;
1504
1505 self->flags = self->flags & ~F_MAXSIZE | (log2 << S_MAXSIZE);
1506
1507 XPUSHs (ST (0));
1508}
1509
1510void filter_json_object (JSON *self, SV *cb = &PL_sv_undef)
1230 PPCODE: 1511 PPCODE:
1512{
1513 SvREFCNT_dec (self->cb_object);
1514 self->cb_object = SvOK (cb) ? newSVsv (cb) : 0;
1515
1516 XPUSHs (ST (0));
1517}
1518
1519void filter_json_single_key_object (JSON *self, SV *key, SV *cb = &PL_sv_undef)
1520 PPCODE:
1521{
1522 if (!self->cb_sk_object)
1523 self->cb_sk_object = newHV ();
1524
1525 if (SvOK (cb))
1526 hv_store_ent (self->cb_sk_object, key, newSVsv (cb), 0);
1527 else
1528 {
1529 hv_delete_ent (self->cb_sk_object, key, G_DISCARD, 0);
1530
1531 if (!HvKEYS (self->cb_sk_object))
1532 {
1533 SvREFCNT_dec (self->cb_sk_object);
1534 self->cb_sk_object = 0;
1535 }
1536 }
1537
1538 XPUSHs (ST (0));
1539}
1540
1541void encode (JSON *self, SV *scalar)
1542 PPCODE:
1543 XPUSHs (encode_json (scalar, self));
1544
1545void decode (JSON *self, SV *jsonstr)
1546 PPCODE:
1231 XPUSHs (decode_json (jsonstr, *SvJSON (self), 0)); 1547 XPUSHs (decode_json (jsonstr, self, 0));
1232 1548
1233void decode_prefix (SV *self, SV *jsonstr) 1549void decode_prefix (JSON *self, SV *jsonstr)
1234 PPCODE: 1550 PPCODE:
1235{ 1551{
1236 UV offset; 1552 UV offset;
1237 EXTEND (SP, 2); 1553 EXTEND (SP, 2);
1238 PUSHs (decode_json (jsonstr, *SvJSON (self), &offset)); 1554 PUSHs (decode_json (jsonstr, self, &offset));
1239 PUSHs (sv_2mortal (newSVuv (offset))); 1555 PUSHs (sv_2mortal (newSVuv (offset)));
1240} 1556}
1241 1557
1558void DESTROY (JSON *self)
1559 CODE:
1560 SvREFCNT_dec (self->cb_sk_object);
1561 SvREFCNT_dec (self->cb_object);
1562
1242PROTOTYPES: ENABLE 1563PROTOTYPES: ENABLE
1243 1564
1244void to_json (SV *scalar) 1565void to_json (SV *scalar)
1245 ALIAS:
1246 objToJson = 0
1247 PPCODE: 1566 PPCODE:
1567{
1568 JSON json = { F_DEFAULT | F_UTF8 };
1248 XPUSHs (encode_json (scalar, F_DEFAULT | F_UTF8)); 1569 XPUSHs (encode_json (scalar, &json));
1570}
1249 1571
1250void from_json (SV *jsonstr) 1572void from_json (SV *jsonstr)
1251 ALIAS:
1252 jsonToObj = 0
1253 PPCODE: 1573 PPCODE:
1574{
1575 JSON json = { F_DEFAULT | F_UTF8 };
1254 XPUSHs (decode_json (jsonstr, F_DEFAULT | F_UTF8, 0)); 1576 XPUSHs (decode_json (jsonstr, &json, 0));
1577}
1255 1578

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines