--- JSON-XS/XS.xs	2007/04/03 23:34:17	1.23
+++ JSON-XS/XS.xs	2007/04/11 12:23:02	1.28
@@ -5,6 +5,11 @@
 #include "assert.h"
 #include "string.h"
 #include "stdlib.h"
+#include "stdio.h"
+
+#if defined(__BORLANDC__) || defined(_MSC_VER)
+# define snprintf _snprintf // C compilers have this in stdio.h
+#endif
 
 #define F_ASCII        0x00000001UL
 #define F_UTF8         0x00000002UL
@@ -23,12 +28,11 @@
 // F_BLESSED?     <=> { $__class__$ => }
 
 #define F_PRETTY    F_INDENT | F_SPACE_BEFORE | F_SPACE_AFTER
-#define F_DEFAULT   (12UL << S_MAXDEPTH)
+#define F_DEFAULT   (9UL << S_MAXDEPTH)
 
 #define INIT_SIZE   32 // initial scalar size to be allocated
 #define INDENT_STEP 3  // spaces per indentation level
 
-#define UTF8_MAX_LEN      11 // for perls UTF-X: max. number of octets per character
 #define SHORT_STRING_LEN 512 // special-case strings of up to this size
 
 #define SB do {
@@ -106,7 +110,7 @@
       STRLEN cur = enc->cur - SvPVX (enc->sv);
       SvGROW (enc->sv, cur + len + 1);
       enc->cur = SvPVX (enc->sv) + cur;
-      enc->end = SvPVX (enc->sv) + SvLEN (enc->sv);
+      enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1;
     }
 }
 
@@ -213,7 +217,7 @@
                     }
                   else
                     {
-                      need (enc, len += UTF8_MAX_LEN - 1); // never more than 11 bytes needed
+                      need (enc, len += UTF8_MAXBYTES - 1); // never more than 11 bytes needed
                       enc->cur = uvuni_to_utf8_flags (enc->cur, uch, 0);
                       ++str;
                     }
@@ -410,7 +414,6 @@
         }
       else
         {
-          SV *sv;
           HE *he = hv_iternext (hv);
 
           for (;;)
@@ -435,9 +438,10 @@
 static void
 encode_rv (enc_t *enc, SV *sv)
 {
-  SvGETMAGIC (sv);
+  svtype svt;
 
-  svtype svt = SvTYPE (sv);
+  SvGETMAGIC (sv);
+  svt = SvTYPE (sv);
 
   if (svt == SVt_PVHV)
     encode_hv (enc, (HV *)sv);
@@ -497,10 +501,11 @@
 static SV *
 encode_json (SV *scalar, U32 flags)
 {
+  enc_t enc;
+
   if (!(flags & F_ALLOW_NONREF) && !SvROK (scalar))
     croak ("hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this)");
 
-  enc_t enc;
   enc.flags     = flags;
   enc.sv        = sv_2mortal (NEWSV (0, INIT_SIZE));
   enc.cur       = SvPVX (enc.sv);
@@ -515,6 +520,7 @@
     SvUTF8_on (enc.sv);
 
   SvCUR_set (enc.sv, enc.cur - SvPVX (enc.sv));
+  *SvEND (enc.sv) = 0; // many xs functions expect a trailing 0 for text strings
 
   if (enc.flags & F_SHRINK)
     shrink (enc.sv);
@@ -596,7 +602,7 @@
 
   do
     {
-      char buf [SHORT_STRING_LEN + UTF8_MAX_LEN];
+      char buf [SHORT_STRING_LEN + UTF8_MAXBYTES];
       char *cur = buf;
 
       do
@@ -672,10 +678,12 @@
             *cur++ = ch;
           else if (ch >= 0x80)
             {
+              STRLEN clen;
+              UV uch;
+
               --dec->cur;
 
-              STRLEN clen;
-              UV uch = decode_utf8 (dec->cur, dec->end - dec->cur, &clen);
+              uch = decode_utf8 (dec->cur, dec->end - dec->cur, &clen);
               if (clen == (STRLEN)-1)
                 ERR ("malformed UTF-8 character in JSON string");
 
@@ -690,23 +698,25 @@
               --dec->cur;
 
               if (!ch)
-                ERR ("unexpected end of string while parsing json string");
+                ERR ("unexpected end of string while parsing JSON string");
               else
-                ERR ("invalid character encountered while parsing json string");
+                ERR ("invalid character encountered while parsing JSON string");
             }
         }
       while (cur < buf + SHORT_STRING_LEN);
 
-      STRLEN len = cur - buf;
+      {
+        STRLEN len = cur - buf;
 
-      if (sv)
-        {
-          SvGROW (sv, SvCUR (sv) + len + 1);
-          memcpy (SvPVX (sv) + SvCUR (sv), buf, len);
-          SvCUR_set (sv, SvCUR (sv) + len);
-        }
-      else
-        sv = newSVpvn (buf, len);
+        if (sv)
+          {
+            SvGROW (sv, SvCUR (sv) + len + 1);
+            memcpy (SvPVX (sv) + SvCUR (sv), buf, len);
+            SvCUR_set (sv, SvCUR (sv) + len);
+          }
+        else
+          sv = newSVpvn (buf, len);
+      }
     }
   while (*dec->cur != '"');
 
@@ -960,7 +970,7 @@
         break;
 
       default:
-        ERR ("malformed json string, neither array, object, number, string or atom");
+        ERR ("malformed JSON string, neither array, object, number, string or atom");
         break;
     }
 
@@ -971,6 +981,7 @@
 static SV *
 decode_json (SV *string, U32 flags)
 {
+  dec_t dec;
   SV *sv;
 
   SvUPGRADE (string, SVt_PV);
@@ -982,7 +993,6 @@
 
   SvGROW (string, SvCUR (string) + 1); // should basically be a NOP
 
-  dec_t dec;
   dec.flags    = flags;
   dec.cur      = SvPVX (string);
   dec.end      = SvEND (string);
@@ -1076,7 +1086,7 @@
 	OUTPUT:
         RETVAL
 
-SV *max_depth (SV *self, int max_depth = 0x80000000UL)
+SV *max_depth (SV *self, UV max_depth = 0x80000000UL)
 	CODE:
 {
   	UV *uv = SvJSON (self);