ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/JSON-XS/XS.xs
(Generate patch)

Comparing JSON-XS/XS.xs (file contents):
Revision 1.90 by root, Sun Jul 20 17:55:19 2008 UTC vs.
Revision 1.113 by root, Thu Aug 11 21:37:41 2011 UTC

… …
12#if defined(__BORLANDC__) || defined(_MSC_VER) 12#if defined(__BORLANDC__) || defined(_MSC_VER)
13# define snprintf _snprintf // C compilers have this in stdio.h 13# define snprintf _snprintf // C compilers have this in stdio.h
14#endif 14#endif
15 15
16// some old perls do not have this, try to make it work, no 16// some old perls do not have this, try to make it work, no
17// guarentees, though. if it breaks, you get to keep the pieces. 17// guarantees, though. if it breaks, you get to keep the pieces.
18#ifndef UTF8_MAXBYTES 18#ifndef UTF8_MAXBYTES
19# define UTF8_MAXBYTES 13 19# define UTF8_MAXBYTES 13
20#endif 20#endif
21 21
22// three extra for rounding, sign, and end of string
22#define IVUV_MAXCHARS (sizeof (UV) * CHAR_BIT * 28 / 93 + 2) 23#define IVUV_MAXCHARS (sizeof (UV) * CHAR_BIT * 28 / 93 + 3)
23 24
24#define F_ASCII 0x00000001UL 25#define F_ASCII 0x00000001UL
25#define F_LATIN1 0x00000002UL 26#define F_LATIN1 0x00000002UL
26#define F_UTF8 0x00000004UL 27#define F_UTF8 0x00000004UL
27#define F_INDENT 0x00000008UL 28#define F_INDENT 0x00000008UL
… …
41#define INIT_SIZE 32 // initial scalar size to be allocated 42#define INIT_SIZE 32 // initial scalar size to be allocated
42#define INDENT_STEP 3 // spaces per indentation level 43#define INDENT_STEP 3 // spaces per indentation level
43 44
44#define SHORT_STRING_LEN 16384 // special-case strings of up to this size 45#define SHORT_STRING_LEN 16384 // special-case strings of up to this size
45 46
47#define DECODE_WANTS_OCTETS(json) ((json)->flags & F_UTF8)
48
46#define SB do { 49#define SB do {
47#define SE } while (0) 50#define SE } while (0)
48 51
49#if __GNUC__ >= 3 52#if __GNUC__ >= 3
50# define expect(expr,value) __builtin_expect ((expr), (value)) 53# define expect(expr,value) __builtin_expect ((expr), (value))
… …
76 79
77enum { 80enum {
78 INCR_M_WS = 0, // initial whitespace skipping, must be 0 81 INCR_M_WS = 0, // initial whitespace skipping, must be 0
79 INCR_M_STR, // inside string 82 INCR_M_STR, // inside string
80 INCR_M_BS, // inside backslash 83 INCR_M_BS, // inside backslash
84 INCR_M_C0, // inside comment in initial whitespace sequence
85 INCR_M_C1, // inside comment in other places
81 INCR_M_JSON // outside anything, count nesting 86 INCR_M_JSON // outside anything, count nesting
82}; 87};
83 88
84#define INCR_DONE(json) ((json)->incr_nest <= 0 && (json)->incr_mode == INCR_M_JSON) 89#define INCR_DONE(json) ((json)->incr_nest <= 0 && (json)->incr_mode == INCR_M_JSON)
85 90
… …
175 *s++ = 0x80 | ( ch & 0x3f); 180 *s++ = 0x80 | ( ch & 0x3f);
176 181
177 return s; 182 return s;
178} 183}
179 184
185// convert offset pointer to character index, sv must be string
186static STRLEN
187ptr_to_index (SV *sv, char *offset)
188{
189 return SvUTF8 (sv)
190 ? utf8_distance (offset, SvPVX (sv))
191 : offset - SvPVX (sv);
192}
193
194/////////////////////////////////////////////////////////////////////////////
195// fp hell
196
197// scan a group of digits, and a trailing exponent
198static void
199json_atof_scan1 (const char *s, NV *accum, int *expo, int postdp, int maxdepth)
200{
201 UV uaccum = 0;
202 int eaccum = 0;
203
204 // if we recurse too deep, skip all remaining digits
205 // to avoid a stack overflow attack
206 if (expect_false (--maxdepth <= 0))
207 while (((U8)*s - '0') < 10)
208 ++s;
209
210 for (;;)
211 {
212 U8 dig = (U8)*s - '0';
213
214 if (expect_false (dig >= 10))
215 {
216 if (dig == (U8)((U8)'.' - (U8)'0'))
217 {
218 ++s;
219 json_atof_scan1 (s, accum, expo, 1, maxdepth);
220 }
221 else if ((dig | ' ') == 'e' - '0')
222 {
223 int exp2 = 0;
224 int neg = 0;
225
226 ++s;
227
228 if (*s == '-')
229 {
230 ++s;
231 neg = 1;
232 }
233 else if (*s == '+')
234 ++s;
235
236 while ((dig = (U8)*s - '0') < 10)
237 exp2 = exp2 * 10 + *s++ - '0';
238
239 *expo += neg ? -exp2 : exp2;
240 }
241
242 break;
243 }
244
245 ++s;
246
247 uaccum = uaccum * 10 + dig;
248 ++eaccum;
249
250 // if we have too many digits, then recurse for more
251 // we actually do this for rather few digits
252 if (uaccum >= (UV_MAX - 9) / 10)
253 {
254 if (postdp) *expo -= eaccum;
255 json_atof_scan1 (s, accum, expo, postdp, maxdepth);
256 if (postdp) *expo += eaccum;
257
258 break;
259 }
260 }
261
262 // this relies greatly on the quality of the pow ()
263 // implementation of the platform, but a good
264 // implementation is hard to beat.
265 // (IEEE 754 conformant ones are required to be exact)
266 if (postdp) *expo -= eaccum;
267 *accum += uaccum * Perl_pow (10., *expo);
268 *expo += eaccum;
269}
270
271static NV
272json_atof (const char *s)
273{
274 NV accum = 0.;
275 int expo = 0;
276 int neg = 0;
277
278 if (*s == '-')
279 {
280 ++s;
281 neg = 1;
282 }
283
284 // a recursion depth of ten gives us >>500 bits
285 json_atof_scan1 (s, &accum, &expo, 0, 10);
286
287 return neg ? -accum : accum;
288}
180///////////////////////////////////////////////////////////////////////////// 289/////////////////////////////////////////////////////////////////////////////
181// encoder 290// encoder
182 291
183// structure used for encoding JSON 292// structure used for encoding JSON
184typedef struct 293typedef struct
… …
194INLINE void 303INLINE void
195need (enc_t *enc, STRLEN len) 304need (enc_t *enc, STRLEN len)
196{ 305{
197 if (expect_false (enc->cur + len >= enc->end)) 306 if (expect_false (enc->cur + len >= enc->end))
198 { 307 {
199 STRLEN cur = enc->cur - SvPVX (enc->sv); 308 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv);
200 SvGROW (enc->sv, cur + len + 1); 309 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1);
201 enc->cur = SvPVX (enc->sv) + cur; 310 enc->cur = SvPVX (enc->sv) + cur;
202 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1; 311 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1;
203 } 312 }
204} 313}
205 314
… …
280 (int)((uch - 0x10000) % 0x400 + 0xDC00)); 389 (int)((uch - 0x10000) % 0x400 + 0xDC00));
281 enc->cur += 12; 390 enc->cur += 12;
282 } 391 }
283 else 392 else
284 { 393 {
285 static char hexdigit [16] = "0123456789abcdef";
286 need (enc, len += 5); 394 need (enc, len += 5);
287 *enc->cur++ = '\\'; 395 *enc->cur++ = '\\';
288 *enc->cur++ = 'u'; 396 *enc->cur++ = 'u';
289 *enc->cur++ = hexdigit [ uch >> 12 ]; 397 *enc->cur++ = PL_hexdigit [ uch >> 12 ];
290 *enc->cur++ = hexdigit [(uch >> 8) & 15]; 398 *enc->cur++ = PL_hexdigit [(uch >> 8) & 15];
291 *enc->cur++ = hexdigit [(uch >> 4) & 15]; 399 *enc->cur++ = PL_hexdigit [(uch >> 4) & 15];
292 *enc->cur++ = hexdigit [(uch >> 0) & 15]; 400 *enc->cur++ = PL_hexdigit [(uch >> 0) & 15];
293 } 401 }
294 402
295 str += clen; 403 str += clen;
296 } 404 }
297 else if (enc->json.flags & F_LATIN1) 405 else if (enc->json.flags & F_LATIN1)
… …
461 569
462 encode_ch (enc, '{'); 570 encode_ch (enc, '{');
463 571
464 // for canonical output we have to sort by keys first 572 // for canonical output we have to sort by keys first
465 // actually, this is mostly due to the stupid so-called 573 // actually, this is mostly due to the stupid so-called
466 // security workaround added somewhere in 5.8.x. 574 // security workaround added somewhere in 5.8.x
467 // that randomises hash orderings 575 // that randomises hash orderings
468 if (enc->json.flags & F_CANONICAL) 576 if (enc->json.flags & F_CANONICAL && !SvRMAGICAL (hv))
469 { 577 {
470 int count = hv_iterinit (hv); 578 int count = hv_iterinit (hv);
471 579
472 if (SvMAGICAL (hv)) 580 if (SvMAGICAL (hv))
473 { 581 {
… …
729 encode_rv (enc, SvRV (sv)); 837 encode_rv (enc, SvRV (sv));
730 else if (!SvOK (sv) || enc->json.flags & F_ALLOW_UNKNOWN) 838 else if (!SvOK (sv) || enc->json.flags & F_ALLOW_UNKNOWN)
731 encode_str (enc, "null", 4, 0); 839 encode_str (enc, "null", 4, 0);
732 else 840 else
733 croak ("encountered perl type (%s,0x%x) that JSON cannot handle, you might want to report this", 841 croak ("encountered perl type (%s,0x%x) that JSON cannot handle, you might want to report this",
734 SvPV_nolen (sv), SvFLAGS (sv)); 842 SvPV_nolen (sv), (unsigned int)SvFLAGS (sv));
735} 843}
736 844
737static SV * 845static SV *
738encode_json (SV *scalar, JSON *json) 846encode_json (SV *scalar, JSON *json)
739{ 847{
… …
751 : enc.json.flags & F_LATIN1 ? 0x000100UL 859 : enc.json.flags & F_LATIN1 ? 0x000100UL
752 : 0x110000UL; 860 : 0x110000UL;
753 861
754 SvPOK_only (enc.sv); 862 SvPOK_only (enc.sv);
755 encode_sv (&enc, scalar); 863 encode_sv (&enc, scalar);
864 encode_nl (&enc);
756 865
757 SvCUR_set (enc.sv, enc.cur - SvPVX (enc.sv)); 866 SvCUR_set (enc.sv, enc.cur - SvPVX (enc.sv));
758 *SvEND (enc.sv) = 0; // many xs functions expect a trailing 0 for text strings 867 *SvEND (enc.sv) = 0; // many xs functions expect a trailing 0 for text strings
759 868
760 if (!(enc.json.flags & (F_ASCII | F_LATIN1 | F_UTF8))) 869 if (!(enc.json.flags & (F_ASCII | F_LATIN1 | F_UTF8)))
… …
940 else if (expect_true (ch >= 0x20 && ch < 0x80)) 1049 else if (expect_true (ch >= 0x20 && ch < 0x80))
941 *cur++ = ch; 1050 *cur++ = ch;
942 else if (ch >= 0x80) 1051 else if (ch >= 0x80)
943 { 1052 {
944 STRLEN clen; 1053 STRLEN clen;
945 UV uch;
946 1054
947 --dec_cur; 1055 --dec_cur;
948 1056
949 uch = decode_utf8 (dec_cur, dec->end - dec_cur, &clen); 1057 decode_utf8 (dec_cur, dec->end - dec_cur, &clen);
950 if (clen == (STRLEN)-1) 1058 if (clen == (STRLEN)-1)
951 ERR ("malformed UTF-8 character in JSON string"); 1059 ERR ("malformed UTF-8 character in JSON string");
952 1060
953 do 1061 do
954 *cur++ = *dec_cur++; 1062 *cur++ = *dec_cur++;
… …
971 { 1079 {
972 STRLEN len = cur - buf; 1080 STRLEN len = cur - buf;
973 1081
974 if (sv) 1082 if (sv)
975 { 1083 {
976 SvGROW (sv, SvCUR (sv) + len + 1); 1084 STRLEN cur = SvCUR (sv);
1085
1086 if (SvLEN (sv) <= cur + len)
1087 SvGROW (sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1);
1088
977 memcpy (SvPVX (sv) + SvCUR (sv), buf, len); 1089 memcpy (SvPVX (sv) + SvCUR (sv), buf, len);
978 SvCUR_set (sv, SvCUR (sv) + len); 1090 SvCUR_set (sv, SvCUR (sv) + len);
979 } 1091 }
980 else 1092 else
981 sv = newSVpvn (buf, len); 1093 sv = newSVpvn (buf, len);
… …
1072 1184
1073 // special case the rather common 1..5-digit-int case 1185 // special case the rather common 1..5-digit-int case
1074 if (*start == '-') 1186 if (*start == '-')
1075 switch (len) 1187 switch (len)
1076 { 1188 {
1077 case 2: return newSViv (-( start [1] - '0' * 1)); 1189 case 2: return newSViv (-(IV)( start [1] - '0' * 1));
1078 case 3: return newSViv (-( start [1] * 10 + start [2] - '0' * 11)); 1190 case 3: return newSViv (-(IV)( start [1] * 10 + start [2] - '0' * 11));
1079 case 4: return newSViv (-( start [1] * 100 + start [2] * 10 + start [3] - '0' * 111)); 1191 case 4: return newSViv (-(IV)( start [1] * 100 + start [2] * 10 + start [3] - '0' * 111));
1080 case 5: return newSViv (-( start [1] * 1000 + start [2] * 100 + start [3] * 10 + start [4] - '0' * 1111)); 1192 case 5: return newSViv (-(IV)( start [1] * 1000 + start [2] * 100 + start [3] * 10 + start [4] - '0' * 1111));
1081 case 6: return newSViv (-(start [1] * 10000 + start [2] * 1000 + start [3] * 100 + start [4] * 10 + start [5] - '0' * 11111)); 1193 case 6: return newSViv (-(IV)(start [1] * 10000 + start [2] * 1000 + start [3] * 100 + start [4] * 10 + start [5] - '0' * 11111));
1082 } 1194 }
1083 else 1195 else
1084 switch (len) 1196 switch (len)
1085 { 1197 {
1086 case 1: return newSViv ( start [0] - '0' * 1); 1198 case 1: return newSViv ( start [0] - '0' * 1);
1087 case 2: return newSViv ( start [0] * 10 + start [1] - '0' * 11); 1199 case 2: return newSViv ( start [0] * 10 + start [1] - '0' * 11);
1088 case 3: return newSViv ( start [0] * 100 + start [1] * 10 + start [2] - '0' * 111); 1200 case 3: return newSViv ( start [0] * 100 + start [1] * 10 + start [2] - '0' * 111);
1089 case 4: return newSViv ( start [0] * 1000 + start [1] * 100 + start [2] * 10 + start [3] - '0' * 1111); 1201 case 4: return newSViv ( start [0] * 1000 + start [1] * 100 + start [2] * 10 + start [3] - '0' * 1111);
1090 case 5: return newSViv ( start [0] * 10000 + start [1] * 1000 + start [2] * 100 + start [3] * 10 + start [4] - '0' * 11111); 1202 case 5: return newSViv ( start [0] * 10000 + start [1] * 1000 + start [2] * 100 + start [3] * 10 + start [4] - '0' * 11111);
1091 } 1203 }
1092 1204
1093 { 1205 {
1094 UV uv; 1206 UV uv;
1095 int numtype = grok_number (start, len, &uv); 1207 int numtype = grok_number (start, len, &uv);
… …
1104 } 1216 }
1105 1217
1106 len -= *start == '-' ? 1 : 0; 1218 len -= *start == '-' ? 1 : 0;
1107 1219
1108 // does not fit into IV or UV, try NV 1220 // does not fit into IV or UV, try NV
1109 if ((sizeof (NV) == sizeof (double) && DBL_DIG >= len) 1221 if (len <= NV_DIG)
1110 #if defined (LDBL_DIG)
1111 || (sizeof (NV) == sizeof (long double) && LDBL_DIG >= len)
1112 #endif
1113 )
1114 // fits into NV without loss of precision 1222 // fits into NV without loss of precision
1115 return newSVnv (Atof (start)); 1223 return newSVnv (json_atof (start));
1116 1224
1117 // everything else fails, convert it to a string 1225 // everything else fails, convert it to a string
1118 return newSVpvn (start, dec->cur - start); 1226 return newSVpvn (start, dec->cur - start);
1119 } 1227 }
1120 1228
1121 // loss of precision here 1229 // loss of precision here
1122 return newSVnv (Atof (start)); 1230 return newSVnv (json_atof (start));
1123 1231
1124fail: 1232fail:
1125 return 0; 1233 return 0;
1126} 1234}
1127 1235
… …
1296 dSP; 1404 dSP;
1297 int count; 1405 int count;
1298 1406
1299 ENTER; SAVETMPS; PUSHMARK (SP); 1407 ENTER; SAVETMPS; PUSHMARK (SP);
1300 XPUSHs (HeVAL (he)); 1408 XPUSHs (HeVAL (he));
1409 sv_2mortal (sv);
1301 1410
1302 PUTBACK; count = call_sv (HeVAL (cb), G_ARRAY); SPAGAIN; 1411 PUTBACK; count = call_sv (HeVAL (cb), G_ARRAY); SPAGAIN;
1303 1412
1304 if (count == 1) 1413 if (count == 1)
1305 { 1414 {
1306 sv = newSVsv (POPs); 1415 sv = newSVsv (POPs);
1307 FREETMPS; LEAVE; 1416 FREETMPS; LEAVE;
1308 return sv; 1417 return sv;
1309 } 1418 }
1310 1419
1420 SvREFCNT_inc (sv);
1311 FREETMPS; LEAVE; 1421 FREETMPS; LEAVE;
1312 } 1422 }
1313 } 1423 }
1314 1424
1315 if (dec->json.cb_object) 1425 if (dec->json.cb_object)
… …
1405fail: 1515fail:
1406 return 0; 1516 return 0;
1407} 1517}
1408 1518
1409static SV * 1519static SV *
1410decode_json (SV *string, JSON *json, STRLEN *offset_return) 1520decode_json (SV *string, JSON *json, char **offset_return)
1411{ 1521{
1412 dec_t dec; 1522 dec_t dec;
1413 STRLEN offset;
1414 SV *sv; 1523 SV *sv;
1415 1524
1525 /* work around bugs in 5.10 where manipulating magic values
1526 * will perl ignore the magic in subsequent accesses.
1527 * also make a copy of non-PV values, to get them into a clean
1528 * state (SvPV should do that, but it's buggy, see below).
1529 */
1416 SvGETMAGIC (string); 1530 /*SvGETMAGIC (string);*/
1531 if (SvMAGICAL (string) || !SvPOK (string))
1532 string = sv_2mortal (newSVsv (string));
1533
1417 SvUPGRADE (string, SVt_PV); 1534 SvUPGRADE (string, SVt_PV);
1418 1535
1419 /* work around a bug in perl 5.10, which causes SvCUR to fail an 1536 /* work around a bug in perl 5.10, which causes SvCUR to fail an
1420 * assertion with -DDEBUGGING, although SvCUR is documented to 1537 * assertion with -DDEBUGGING, although SvCUR is documented to
1421 * return the xpv_cur field which certainly exists after upgrading. 1538 * return the xpv_cur field which certainly exists after upgrading.
… …
1424 * and hope for the best. 1541 * and hope for the best.
1425 * Damnit, SvPV_nolen still trips over yet another assertion. This 1542 * Damnit, SvPV_nolen still trips over yet another assertion. This
1426 * assertion business is seriously broken, try yet another workaround 1543 * assertion business is seriously broken, try yet another workaround
1427 * for the broken -DDEBUGGING. 1544 * for the broken -DDEBUGGING.
1428 */ 1545 */
1546 {
1429#ifdef DEBUGGING 1547#ifdef DEBUGGING
1430 offset = SvOK (string) ? sv_len (string) : 0; 1548 STRLEN offset = SvOK (string) ? sv_len (string) : 0;
1431#else 1549#else
1432 offset = SvCUR (string); 1550 STRLEN offset = SvCUR (string);
1433#endif 1551#endif
1434 1552
1435 if (offset > json->max_size && json->max_size) 1553 if (offset > json->max_size && json->max_size)
1436 croak ("attempted decode of JSON text of %lu bytes size, but max_size is set to %lu", 1554 croak ("attempted decode of JSON text of %lu bytes size, but max_size is set to %lu",
1437 (unsigned long)SvCUR (string), (unsigned long)json->max_size); 1555 (unsigned long)SvCUR (string), (unsigned long)json->max_size);
1556 }
1438 1557
1439 if (json->flags & F_UTF8) 1558 if (DECODE_WANTS_OCTETS (json))
1440 sv_utf8_downgrade (string, 0); 1559 sv_utf8_downgrade (string, 0);
1441 else 1560 else
1442 sv_utf8_upgrade (string); 1561 sv_utf8_upgrade (string);
1443 1562
1444 SvGROW (string, SvCUR (string) + 1); // should basically be a NOP 1563 SvGROW (string, SvCUR (string) + 1); // should basically be a NOP
… …
1454 1573
1455 *dec.end = 0; // this should basically be a nop, too, but make sure it's there 1574 *dec.end = 0; // this should basically be a nop, too, but make sure it's there
1456 1575
1457 decode_ws (&dec); 1576 decode_ws (&dec);
1458 sv = decode_sv (&dec); 1577 sv = decode_sv (&dec);
1578
1579 if (offset_return)
1580 *offset_return = dec.cur;
1459 1581
1460 if (!(offset_return || !sv)) 1582 if (!(offset_return || !sv))
1461 { 1583 {
1462 // check for trailing garbage 1584 // check for trailing garbage
1463 decode_ws (&dec); 1585 decode_ws (&dec);
… …
1466 { 1588 {
1467 dec.err = "garbage after JSON object"; 1589 dec.err = "garbage after JSON object";
1468 SvREFCNT_dec (sv); 1590 SvREFCNT_dec (sv);
1469 sv = 0; 1591 sv = 0;
1470 } 1592 }
1471 }
1472
1473 if (offset_return || !sv)
1474 {
1475 offset = dec.json.flags & F_UTF8
1476 ? dec.cur - SvPVX (string)
1477 : utf8_distance (dec.cur, SvPVX (string));
1478
1479 if (offset_return)
1480 *offset_return = offset;
1481 } 1593 }
1482 1594
1483 if (!sv) 1595 if (!sv)
1484 { 1596 {
1485 SV *uni = sv_newmortal (); 1597 SV *uni = sv_newmortal ();
… …
1491 SAVEVPTR (PL_curcop); 1603 SAVEVPTR (PL_curcop);
1492 PL_curcop = &cop; 1604 PL_curcop = &cop;
1493 pv_uni_display (uni, dec.cur, dec.end - dec.cur, 20, UNI_DISPLAY_QQ); 1605 pv_uni_display (uni, dec.cur, dec.end - dec.cur, 20, UNI_DISPLAY_QQ);
1494 LEAVE; 1606 LEAVE;
1495 1607
1496 croak ("%s, at character offset %d [\"%s\"]", 1608 croak ("%s, at character offset %d (before \"%s\")",
1497 dec.err, 1609 dec.err,
1498 (int)offset, 1610 (int)ptr_to_index (string, dec.cur),
1499 dec.cur != dec.end ? SvPV_nolen (uni) : "(end of string)"); 1611 dec.cur != dec.end ? SvPV_nolen (uni) : "(end of string)");
1500 } 1612 }
1501 1613
1502 sv = sv_2mortal (sv); 1614 sv = sv_2mortal (sv);
1503 1615
… …
1512 1624
1513static void 1625static void
1514incr_parse (JSON *self) 1626incr_parse (JSON *self)
1515{ 1627{
1516 const char *p = SvPVX (self->incr_text) + self->incr_pos; 1628 const char *p = SvPVX (self->incr_text) + self->incr_pos;
1629
1630 // the state machine here is a bit convoluted and could be simplified a lot
1631 // but this would make it slower, so...
1517 1632
1518 for (;;) 1633 for (;;)
1519 { 1634 {
1520 //printf ("loop pod %d *p<%c><%s>, mode %d nest %d\n", p - SvPVX (self->incr_text), *p, p, self->incr_mode, self->incr_nest);//D 1635 //printf ("loop pod %d *p<%c><%s>, mode %d nest %d\n", p - SvPVX (self->incr_text), *p, p, self->incr_mode, self->incr_nest);//D
1521 switch (self->incr_mode) 1636 switch (self->incr_mode)
1522 { 1637 {
1523 // only used for intiial whitespace skipping 1638 // only used for initial whitespace skipping
1524 case INCR_M_WS: 1639 case INCR_M_WS:
1525 for (;;) 1640 for (;;)
1526 { 1641 {
1527 if (*p > 0x20) 1642 if (*p > 0x20)
1528 { 1643 {
1644 if (*p == '#')
1645 {
1646 self->incr_mode = INCR_M_C0;
1647 goto incr_m_c;
1648 }
1649 else
1650 {
1529 self->incr_mode = INCR_M_JSON; 1651 self->incr_mode = INCR_M_JSON;
1530 goto incr_m_json; 1652 goto incr_m_json;
1653 }
1531 } 1654 }
1532 else if (!*p) 1655 else if (!*p)
1533 goto interrupt; 1656 goto interrupt;
1534 1657
1535 ++p; 1658 ++p;
… …
1541 goto interrupt; 1664 goto interrupt;
1542 1665
1543 ++p; 1666 ++p;
1544 self->incr_mode = INCR_M_STR; 1667 self->incr_mode = INCR_M_STR;
1545 goto incr_m_str; 1668 goto incr_m_str;
1669
1670 // inside #-style comments
1671 case INCR_M_C0:
1672 case INCR_M_C1:
1673 incr_m_c:
1674 for (;;)
1675 {
1676 if (*p == '\n')
1677 {
1678 self->incr_mode = self->incr_mode == INCR_M_C0 ? INCR_M_WS : INCR_M_JSON;
1679 break;
1680 }
1681 else if (!*p)
1682 goto interrupt;
1683
1684 ++p;
1685 }
1686
1687 break;
1546 1688
1547 // inside a string 1689 // inside a string
1548 case INCR_M_STR: 1690 case INCR_M_STR:
1549 incr_m_str: 1691 incr_m_str:
1550 for (;;) 1692 for (;;)
… …
1609 1751
1610 case ']': 1752 case ']':
1611 case '}': 1753 case '}':
1612 if (--self->incr_nest <= 0) 1754 if (--self->incr_nest <= 0)
1613 goto interrupt; 1755 goto interrupt;
1756 break;
1757
1758 case '#':
1759 self->incr_mode = INCR_M_C1;
1760 goto incr_m_c;
1614 } 1761 }
1615 } 1762 }
1616 } 1763 }
1617 1764
1618 modechange: 1765 modechange:
1619 ; 1766 ;
1620 } 1767 }
1621 1768
1622interrupt: 1769interrupt:
1623 self->incr_pos = p - SvPVX (self->incr_text); 1770 self->incr_pos = p - SvPVX (self->incr_text);
1771 //printf ("interrupt<%.*s>\n", self->incr_pos, SvPVX(self->incr_text));//D
1624 //printf ("return pos %d mode %d nest %d\n", self->incr_pos, self->incr_mode, self->incr_nest);//D 1772 //printf ("return pos %d mode %d nest %d\n", self->incr_pos, self->incr_mode, self->incr_nest);//D
1625} 1773}
1626 1774
1627///////////////////////////////////////////////////////////////////////////// 1775/////////////////////////////////////////////////////////////////////////////
1628// XS interface functions 1776// XS interface functions
… …
1643 json_stash = gv_stashpv ("JSON::XS" , 1); 1791 json_stash = gv_stashpv ("JSON::XS" , 1);
1644 json_boolean_stash = gv_stashpv ("JSON::XS::Boolean", 1); 1792 json_boolean_stash = gv_stashpv ("JSON::XS::Boolean", 1);
1645 1793
1646 json_true = get_bool ("JSON::XS::true"); 1794 json_true = get_bool ("JSON::XS::true");
1647 json_false = get_bool ("JSON::XS::false"); 1795 json_false = get_bool ("JSON::XS::false");
1796
1797 CvNODEBUG_on (get_cv ("JSON::XS::incr_text", 0)); /* the debugger completely breaks lvalue subs */
1648} 1798}
1649 1799
1650PROTOTYPES: DISABLE 1800PROTOTYPES: DISABLE
1651 1801
1652void CLONE (...) 1802void CLONE (...)
… …
1772 XPUSHs (decode_json (jsonstr, self, 0)); 1922 XPUSHs (decode_json (jsonstr, self, 0));
1773 1923
1774void decode_prefix (JSON *self, SV *jsonstr) 1924void decode_prefix (JSON *self, SV *jsonstr)
1775 PPCODE: 1925 PPCODE:
1776{ 1926{
1777 STRLEN offset; 1927 char *offset;
1778 EXTEND (SP, 2); 1928 EXTEND (SP, 2);
1779 PUSHs (decode_json (jsonstr, self, &offset)); 1929 PUSHs (decode_json (jsonstr, self, &offset));
1780 PUSHs (sv_2mortal (newSVuv (offset))); 1930 PUSHs (sv_2mortal (newSVuv (ptr_to_index (jsonstr, offset))));
1781} 1931}
1782 1932
1783void incr_parse (JSON *self, SV *jsonstr = 0) 1933void incr_parse (JSON *self, SV *jsonstr = 0)
1784 PPCODE: 1934 PPCODE:
1785{ 1935{
1786 if (!self->incr_text) 1936 if (!self->incr_text)
1787 self->incr_text = newSVpvn ("", 0); 1937 self->incr_text = newSVpvn ("", 0);
1938
1939 /* if utf8-ness doesn't match the decoder, need to upgrade/downgrade */
1940 if (!DECODE_WANTS_OCTETS (self) == !SvUTF8 (self->incr_text))
1941 if (DECODE_WANTS_OCTETS (self))
1942 {
1943 if (self->incr_pos)
1944 self->incr_pos = utf8_length ((U8 *)SvPVX (self->incr_text),
1945 (U8 *)SvPVX (self->incr_text) + self->incr_pos);
1946
1947 sv_utf8_downgrade (self->incr_text, 0);
1948 }
1949 else
1950 {
1951 sv_utf8_upgrade (self->incr_text);
1952
1953 if (self->incr_pos)
1954 self->incr_pos = utf8_hop ((U8 *)SvPVX (self->incr_text), self->incr_pos)
1955 - (U8 *)SvPVX (self->incr_text);
1956 }
1788 1957
1789 // append data, if any 1958 // append data, if any
1790 if (jsonstr) 1959 if (jsonstr)
1791 { 1960 {
1961 /* make sure both strings have same encoding */
1792 if (SvUTF8 (jsonstr) && !SvUTF8 (self->incr_text)) 1962 if (SvUTF8 (jsonstr) != SvUTF8 (self->incr_text))
1963 if (SvUTF8 (jsonstr))
1964 sv_utf8_downgrade (jsonstr, 0);
1793 { 1965 else
1794 /* utf-8-ness differs, need to upgrade */
1795 sv_utf8_upgrade (self->incr_text); 1966 sv_utf8_upgrade (jsonstr);
1796 1967
1797 if (self->incr_pos) 1968 /* and then just blindly append */
1798 self->incr_pos = utf8_hop ((U8 *)SvPVX (self->incr_text), self->incr_pos)
1799 - (U8 *)SvPVX (self->incr_text);
1800 }
1801
1802 { 1969 {
1803 STRLEN len; 1970 STRLEN len;
1804 const char *str = SvPV (jsonstr, len); 1971 const char *str = SvPV (jsonstr, len);
1805 SvGROW (self->incr_text, SvCUR (self->incr_text) + len + 1); 1972 STRLEN cur = SvCUR (self->incr_text);
1973
1974 if (SvLEN (self->incr_text) <= cur + len)
1975 SvGROW (self->incr_text, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1);
1976
1806 Move (str, SvEND (self->incr_text), len, char); 1977 Move (str, SvEND (self->incr_text), len, char);
1807 SvCUR_set (self->incr_text, SvCUR (self->incr_text) + len); 1978 SvCUR_set (self->incr_text, SvCUR (self->incr_text) + len);
1808 *SvEND (self->incr_text) = 0; // this should basically be a nop, too, but make sure it's there 1979 *SvEND (self->incr_text) = 0; // this should basically be a nop, too, but make sure it's there
1809 } 1980 }
1810 } 1981 }
1811 1982
1812 if (GIMME_V != G_VOID) 1983 if (GIMME_V != G_VOID)
1813 do 1984 do
1814 { 1985 {
1815 STRLEN offset; 1986 char *offset;
1816 1987
1817 if (!INCR_DONE (self)) 1988 if (!INCR_DONE (self))
1818 { 1989 {
1819 incr_parse (self); 1990 incr_parse (self);
1820 1991
1821 if (self->incr_pos > self->max_size && self->max_size) 1992 if (self->incr_pos > self->max_size && self->max_size)
1822 croak ("attempted decode of JSON text of %lu bytes size, but max_size is set to %lu", 1993 croak ("attempted decode of JSON text of %lu bytes size, but max_size is set to %lu",
1823 (unsigned long)self->incr_pos, (unsigned long)self->max_size); 1994 (unsigned long)self->incr_pos, (unsigned long)self->max_size);
1824 1995
1825 if (!INCR_DONE (self)) 1996 if (!INCR_DONE (self))
1997 {
1998 // as an optimisation, do not accumulate white space in the incr buffer
1999 if (self->incr_mode == INCR_M_WS && self->incr_pos)
2000 {
2001 self->incr_pos = 0;
2002 SvCUR_set (self->incr_text, 0);
2003 }
2004
1826 break; 2005 break;
2006 }
1827 } 2007 }
1828 2008
1829 XPUSHs (decode_json (self->incr_text, self, &offset)); 2009 XPUSHs (decode_json (self->incr_text, self, &offset));
1830 2010
1831 sv_chop (self->incr_text, SvPV_nolen (self->incr_text) + offset);
1832 self->incr_pos -= offset; 2011 self->incr_pos -= offset - SvPVX (self->incr_text);
1833 self->incr_nest = 0; 2012 self->incr_nest = 0;
1834 self->incr_mode = 0; 2013 self->incr_mode = 0;
2014
2015 sv_chop (self->incr_text, offset);
1835 } 2016 }
1836 while (GIMME_V == G_ARRAY); 2017 while (GIMME_V == G_ARRAY);
1837} 2018}
1838 2019
1839SV *incr_text (JSON *self) 2020SV *incr_text (JSON *self)
… …
1900 json_init (&json); 2081 json_init (&json);
1901 json.flags |= ix; 2082 json.flags |= ix;
1902 XPUSHs (decode_json (jsonstr, &json, 0)); 2083 XPUSHs (decode_json (jsonstr, &json, 0));
1903} 2084}
1904 2085
1905

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines