ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/JSON-XS/XS.xs
(Generate patch)

Comparing JSON-XS/XS.xs (file contents):
Revision 1.119 by root, Mon Oct 28 23:19:54 2013 UTC vs.
Revision 1.142 by root, Mon Jun 21 00:12:57 2021 UTC

… …
6#include <string.h> 6#include <string.h>
7#include <stdlib.h> 7#include <stdlib.h>
8#include <stdio.h> 8#include <stdio.h>
9#include <limits.h> 9#include <limits.h>
10#include <float.h> 10#include <float.h>
11#include <inttypes.h>
11 12
12#if defined(__BORLANDC__) || defined(_MSC_VER) 13#if defined(__BORLANDC__) || defined(_MSC_VER)
13# define snprintf _snprintf // C compilers have this in stdio.h 14# define snprintf _snprintf // C compilers have this in stdio.h
14#endif 15#endif
15 16
16// some old perls do not have this, try to make it work, no 17// some old perls do not have this, try to make it work, no
17// guarantees, though. if it breaks, you get to keep the pieces. 18// guarantees, though. if it breaks, you get to keep the pieces.
18#ifndef UTF8_MAXBYTES 19#ifndef UTF8_MAXBYTES
19# define UTF8_MAXBYTES 13 20# define UTF8_MAXBYTES 13
21#endif
22
23// compatibility with perl <5.18
24#ifndef HvNAMELEN_get
25# define HvNAMELEN_get(hv) strlen (HvNAME (hv))
26#endif
27#ifndef HvNAMELEN
28# define HvNAMELEN(hv) HvNAMELEN_get (hv)
29#endif
30#ifndef HvNAMEUTF8
31# define HvNAMEUTF8(hv) 0
20#endif 32#endif
21 33
22// three extra for rounding, sign, and end of string 34// three extra for rounding, sign, and end of string
23#define IVUV_MAXCHARS (sizeof (UV) * CHAR_BIT * 28 / 93 + 3) 35#define IVUV_MAXCHARS (sizeof (UV) * CHAR_BIT * 28 / 93 + 3)
24 36
… …
38#define F_ALLOW_TAGS 0x00004000UL 50#define F_ALLOW_TAGS 0x00004000UL
39#define F_HOOK 0x00080000UL // some hooks exist, so slow-path processing 51#define F_HOOK 0x00080000UL // some hooks exist, so slow-path processing
40 52
41#define F_PRETTY F_INDENT | F_SPACE_BEFORE | F_SPACE_AFTER 53#define F_PRETTY F_INDENT | F_SPACE_BEFORE | F_SPACE_AFTER
42 54
43#define INIT_SIZE 32 // initial scalar size to be allocated 55#define INIT_SIZE 64 // initial scalar size to be allocated
44#define INDENT_STEP 3 // spaces per indentation level 56#define INDENT_STEP 3 // spaces per indentation level
45 57
46#define SHORT_STRING_LEN 16384 // special-case strings of up to this size 58#define SHORT_STRING_LEN 16384 // special-case strings of up to this size
47 59
48#define DECODE_WANTS_OCTETS(json) ((json)->flags & F_UTF8) 60#define DECODE_WANTS_OCTETS(json) ((json)->flags & F_UTF8)
… …
66 <= (unsigned type)((unsigned type)(end) - (unsigned type)(beg))) 78 <= (unsigned type)((unsigned type)(end) - (unsigned type)(beg)))
67 79
68#define ERR_NESTING_EXCEEDED "json text or perl structure exceeds maximum nesting level (max_depth set too low?)" 80#define ERR_NESTING_EXCEEDED "json text or perl structure exceeds maximum nesting level (max_depth set too low?)"
69 81
70#ifdef USE_ITHREADS 82#ifdef USE_ITHREADS
71# define JSON_SLOW 1
72# define JSON_STASH (json_stash ? json_stash : gv_stashpv ("JSON::XS", 1)) 83# define JSON_STASH (expect_true (json_stash) ? json_stash : gv_stashpv ("JSON::XS", 1))
84# define BOOL_STASH (expect_true (bool_stash) ? bool_stash : gv_stashpv ("Types::Serialiser::Boolean", 1))
85# define GET_BOOL(value) (expect_true (bool_ ## value) ? bool_ ## value : get_bool ("Types::Serialiser::" # value))
73#else 86#else
74# define JSON_SLOW 0
75# define JSON_STASH json_stash 87# define JSON_STASH json_stash
88# define BOOL_STASH bool_stash
89# define GET_BOOL(value) bool_ ## value
76#endif 90#endif
77 91
78// the amount of HEs to allocate on the stack, when sorting keys 92// the amount of HEs to allocate on the stack, when sorting keys
79#define STACK_HES 64 93#define STACK_HES 64
80 94
81static HV *json_stash, *types_boolean_stash; // JSON::XS:: 95static HV *json_stash, *bool_stash; // JSON::XS::, Types::Serialiser::Boolean::
82static SV *types_true, *types_false, *sv_json; 96static SV *bool_false, *bool_true;
97static SV *sv_json;
83 98
84enum { 99enum {
85 INCR_M_WS = 0, // initial whitespace skipping, must be 0 100 INCR_M_WS = 0, // initial whitespace skipping, must be 0
101 INCR_M_TFN, // inside true/false/null
102 INCR_M_NUM, // inside number
86 INCR_M_STR, // inside string 103 INCR_M_STR, // inside string
87 INCR_M_BS, // inside backslash 104 INCR_M_BS, // inside backslash
88 INCR_M_C0, // inside comment in initial whitespace sequence 105 INCR_M_C0, // inside comment in initial whitespace sequence
89 INCR_M_C1, // inside comment in other places 106 INCR_M_C1, // inside comment in other places
90 INCR_M_JSON // outside anything, count nesting 107 INCR_M_JSON // outside anything, count nesting
… …
103 // for the incremental parser 120 // for the incremental parser
104 SV *incr_text; // the source text so far 121 SV *incr_text; // the source text so far
105 STRLEN incr_pos; // the current offset into the text 122 STRLEN incr_pos; // the current offset into the text
106 int incr_nest; // {[]}-nesting level 123 int incr_nest; // {[]}-nesting level
107 unsigned char incr_mode; 124 unsigned char incr_mode;
125
126 SV *v_false, *v_true;
108} JSON; 127} JSON;
109 128
110INLINE void 129INLINE void
111json_init (JSON *json) 130json_init (JSON *json)
112{ 131{
113 Zero (json, 1, JSON); 132 static const JSON init = { F_ALLOW_NONREF, 512 };
114 json->max_depth = 512; 133
134 *json = init;
115} 135}
116 136
117///////////////////////////////////////////////////////////////////////////// 137/////////////////////////////////////////////////////////////////////////////
118// utility functions 138// utility functions
119 139
… …
141 SvPV_renew (sv, SvCUR (sv) + 1); 161 SvPV_renew (sv, SvCUR (sv) + 1);
142#endif 162#endif
143 } 163 }
144} 164}
145 165
166/* adds two STRLENs together, slow, and with paranoia */
167static STRLEN
168strlen_sum (STRLEN l1, STRLEN l2)
169{
170 size_t sum = l1 + l2;
171
172 if (sum < (size_t)l2 || sum != (size_t)(STRLEN)sum)
173 croak ("JSON::XS: string size overflow");
174
175 return sum;
176}
177
178/* similar to SvGROW, but somewhat safer and guarantees exponential realloc strategy */
179static char *
180json_sv_grow (SV *sv, size_t len1, size_t len2)
181{
182 len1 = strlen_sum (len1, len2);
183 len1 = strlen_sum (len1, len1 >> 1);
184
185 if (len1 > 4096 - 24)
186 len1 = (len1 | 4095) - 24;
187
188 return SvGROW (sv, len1);
189}
190
146// decode an utf-8 character and return it, or (UV)-1 in 191// decode a utf-8 character and return it, or (UV)-1 in
147// case of an error. 192// case of an error.
148// we special-case "safe" characters from U+80 .. U+7FF, 193// we special-case "safe" characters from U+80 .. U+7FF,
149// but use the very good perl function to parse anything else. 194// but use the very good perl function to parse anything else.
150// note that we never call this function for a ascii codepoints 195// note that we never call this function for a ascii codepoints
151INLINE UV 196INLINE UV
… …
288 // a recursion depth of ten gives us >>500 bits 333 // a recursion depth of ten gives us >>500 bits
289 json_atof_scan1 (s, &accum, &expo, 0, 10); 334 json_atof_scan1 (s, &accum, &expo, 0, 10);
290 335
291 return neg ? -accum : accum; 336 return neg ? -accum : accum;
292} 337}
338
339// target of scalar reference is bool? -1 == nope, 0 == false, 1 == true
340static int
341ref_bool_type (SV *sv)
342{
343 svtype svt = SvTYPE (sv);
344
345 if (svt < SVt_PVAV)
346 {
347 STRLEN len = 0;
348 char *pv = svt ? SvPV (sv, len) : 0;
349
350 if (len == 1)
351 if (*pv == '1')
352 return 1;
353 else if (*pv == '0')
354 return 0;
355 }
356
357 return -1;
358}
359
360// returns whether scalar is not a reference in the sense of allow_nonref
361static int
362json_nonref (SV *scalar)
363{
364 if (!SvROK (scalar))
365 return 1;
366
367 scalar = SvRV (scalar);
368
369 if (SvTYPE (scalar) >= SVt_PVMG)
370 {
371 if (SvSTASH (scalar) == bool_stash)
372 return 1;
373
374 if (!SvOBJECT (scalar) && ref_bool_type (scalar) >= 0)
375 return 1;
376 }
377
378 return 0;
379}
380
293///////////////////////////////////////////////////////////////////////////// 381/////////////////////////////////////////////////////////////////////////////
294// encoder 382// encoder
295 383
296// structure used for encoding JSON 384// structure used for encoding JSON
297typedef struct 385typedef struct
… …
305} enc_t; 393} enc_t;
306 394
307INLINE void 395INLINE void
308need (enc_t *enc, STRLEN len) 396need (enc_t *enc, STRLEN len)
309{ 397{
310 if (expect_false (enc->cur + len >= enc->end)) 398 if (expect_false ((uintptr_t)(enc->end - enc->cur) < len))
311 { 399 {
312 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv); 400 STRLEN cur = enc->cur - (char *)SvPVX (enc->sv);
313 SvGROW (enc->sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1); 401 char *buf = json_sv_grow (enc->sv, cur, len);
314 enc->cur = SvPVX (enc->sv) + cur; 402 enc->cur = buf + cur;
315 enc->end = SvPVX (enc->sv) + SvLEN (enc->sv) - 1; 403 enc->end = buf + SvLEN (enc->sv) - 1;
316 } 404 }
317} 405}
318 406
319INLINE void 407INLINE void
320encode_ch (enc_t *enc, char ch) 408encode_ch (enc_t *enc, char ch)
… …
336 424
337 if (expect_true (ch >= 0x20 && ch < 0x80)) // most common case 425 if (expect_true (ch >= 0x20 && ch < 0x80)) // most common case
338 { 426 {
339 if (expect_false (ch == '"')) // but with slow exceptions 427 if (expect_false (ch == '"')) // but with slow exceptions
340 { 428 {
341 need (enc, len += 1); 429 need (enc, len + 1);
342 *enc->cur++ = '\\'; 430 *enc->cur++ = '\\';
343 *enc->cur++ = '"'; 431 *enc->cur++ = '"';
344 } 432 }
345 else if (expect_false (ch == '\\')) 433 else if (expect_false (ch == '\\'))
346 { 434 {
347 need (enc, len += 1); 435 need (enc, len + 1);
348 *enc->cur++ = '\\'; 436 *enc->cur++ = '\\';
349 *enc->cur++ = '\\'; 437 *enc->cur++ = '\\';
350 } 438 }
351 else 439 else
352 *enc->cur++ = ch; 440 *enc->cur++ = ch;
… …
355 } 443 }
356 else 444 else
357 { 445 {
358 switch (ch) 446 switch (ch)
359 { 447 {
360 case '\010': need (enc, len += 1); *enc->cur++ = '\\'; *enc->cur++ = 'b'; ++str; break; 448 case '\010': need (enc, len + 1); *enc->cur++ = '\\'; *enc->cur++ = 'b'; ++str; break;
361 case '\011': need (enc, len += 1); *enc->cur++ = '\\'; *enc->cur++ = 't'; ++str; break; 449 case '\011': need (enc, len + 1); *enc->cur++ = '\\'; *enc->cur++ = 't'; ++str; break;
362 case '\012': need (enc, len += 1); *enc->cur++ = '\\'; *enc->cur++ = 'n'; ++str; break; 450 case '\012': need (enc, len + 1); *enc->cur++ = '\\'; *enc->cur++ = 'n'; ++str; break;
363 case '\014': need (enc, len += 1); *enc->cur++ = '\\'; *enc->cur++ = 'f'; ++str; break; 451 case '\014': need (enc, len + 1); *enc->cur++ = '\\'; *enc->cur++ = 'f'; ++str; break;
364 case '\015': need (enc, len += 1); *enc->cur++ = '\\'; *enc->cur++ = 'r'; ++str; break; 452 case '\015': need (enc, len + 1); *enc->cur++ = '\\'; *enc->cur++ = 'r'; ++str; break;
365 453
366 default: 454 default:
367 { 455 {
368 STRLEN clen; 456 STRLEN clen;
369 UV uch; 457 UV uch;
… …
385 if (uch >= 0x10000UL) 473 if (uch >= 0x10000UL)
386 { 474 {
387 if (uch >= 0x110000UL) 475 if (uch >= 0x110000UL)
388 croak ("out of range codepoint (0x%lx) encountered, unrepresentable in JSON", (unsigned long)uch); 476 croak ("out of range codepoint (0x%lx) encountered, unrepresentable in JSON", (unsigned long)uch);
389 477
390 need (enc, len += 11); 478 need (enc, len + 11);
391 sprintf (enc->cur, "\\u%04x\\u%04x", 479 sprintf (enc->cur, "\\u%04x\\u%04x",
392 (int)((uch - 0x10000) / 0x400 + 0xD800), 480 (int)((uch - 0x10000) / 0x400 + 0xD800),
393 (int)((uch - 0x10000) % 0x400 + 0xDC00)); 481 (int)((uch - 0x10000) % 0x400 + 0xDC00));
394 enc->cur += 12; 482 enc->cur += 12;
395 } 483 }
396 else 484 else
397 { 485 {
398 need (enc, len += 5); 486 need (enc, len + 5);
399 *enc->cur++ = '\\'; 487 *enc->cur++ = '\\';
400 *enc->cur++ = 'u'; 488 *enc->cur++ = 'u';
401 *enc->cur++ = PL_hexdigit [ uch >> 12 ]; 489 *enc->cur++ = PL_hexdigit [ uch >> 12 ];
402 *enc->cur++ = PL_hexdigit [(uch >> 8) & 15]; 490 *enc->cur++ = PL_hexdigit [(uch >> 8) & 15];
403 *enc->cur++ = PL_hexdigit [(uch >> 4) & 15]; 491 *enc->cur++ = PL_hexdigit [(uch >> 4) & 15];
… …
411 *enc->cur++ = uch; 499 *enc->cur++ = uch;
412 str += clen; 500 str += clen;
413 } 501 }
414 else if (is_utf8) 502 else if (is_utf8)
415 { 503 {
416 need (enc, len += clen); 504 need (enc, len + clen);
417 do 505 do
418 { 506 {
419 *enc->cur++ = *str++; 507 *enc->cur++ = *str++;
420 } 508 }
421 while (--clen); 509 while (--clen);
422 } 510 }
423 else 511 else
424 { 512 {
425 need (enc, len += UTF8_MAXBYTES - 1); // never more than 11 bytes needed 513 need (enc, len + UTF8_MAXBYTES - 1); // never more than 11 bytes needed
426 enc->cur = encode_utf8 (enc->cur, uch); 514 enc->cur = encode_utf8 (enc->cur, uch);
427 ++str; 515 ++str;
428 } 516 }
429 } 517 }
430 } 518 }
… …
683// encode objects, arrays and special \0=false and \1=true values. 771// encode objects, arrays and special \0=false and \1=true values.
684static void 772static void
685encode_rv (enc_t *enc, SV *sv) 773encode_rv (enc_t *enc, SV *sv)
686{ 774{
687 svtype svt; 775 svtype svt;
776 GV *method;
688 777
689 SvGETMAGIC (sv); 778 SvGETMAGIC (sv);
690 svt = SvTYPE (sv); 779 svt = SvTYPE (sv);
691 780
692 if (expect_false (SvOBJECT (sv))) 781 if (expect_false (SvOBJECT (sv)))
693 { 782 {
694 HV *boolean_stash = !JSON_SLOW || types_boolean_stash
695 ? types_boolean_stash
696 : gv_stashpv ("Types::Serialiser::Boolean", 1);
697 HV *stash = SvSTASH (sv); 783 HV *stash = SvSTASH (sv);
698 784
699 if (stash == boolean_stash) 785 if (stash == bool_stash)
700 { 786 {
701 if (SvIV (sv))
702 encode_str (enc, "true", 4, 0); 787 if (SvIV (sv)) encode_str (enc, "true" , 4, 0);
703 else
704 encode_str (enc, "false", 5, 0); 788 else encode_str (enc, "false", 5, 0);
705 } 789 }
706 else if (enc->json.flags & F_CONV_BLESSED) 790 else if ((enc->json.flags & F_ALLOW_TAGS) && (method = gv_fetchmethod_autoload (stash, "FREEZE", 0)))
707 { 791 {
708 GV *to_json = gv_fetchmethod_autoload (stash, "TO_JSON", 0); 792 int count;
793 dSP;
709 794
795 ENTER; SAVETMPS;
796 PUSHMARK (SP);
797 EXTEND (SP, 2);
798 // we re-bless the reference to get overload and other niceties right
799 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash));
800 PUSHs (sv_json);
801
802 PUTBACK;
803 count = call_sv ((SV *)GvCV (method), G_ARRAY);
804 SPAGAIN;
805
806 // catch this surprisingly common error
807 if (SvROK (TOPs) && SvRV (TOPs) == sv)
808 croak ("%s::FREEZE method returned same object as was passed instead of a new one", HvNAME (SvSTASH (sv)));
809
810 encode_ch (enc, '(');
811 encode_ch (enc, '"');
812 encode_str (enc, HvNAME (stash), HvNAMELEN (stash), HvNAMEUTF8 (stash));
813 encode_ch (enc, '"');
814 encode_ch (enc, ')');
815 encode_ch (enc, '[');
816
710 if (to_json) 817 if (count)
711 { 818 {
819 int i;
820
821 for (i = 0; i < count - 1; ++i)
712 dSP; 822 {
823 encode_sv (enc, SP[i + 1 - count]);
824 encode_ch (enc, ',');
825 }
713 826
714 ENTER; SAVETMPS; PUSHMARK (SP);
715 // we re-bless the reference to get overload and other niceties right
716 XPUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash));
717
718 // calling with G_SCALAR ensures that we always get a 1 return value
719 PUTBACK;
720 call_sv ((SV *)GvCV (to_json), G_SCALAR);
721 SPAGAIN;
722
723 // catch this surprisingly common error
724 if (SvROK (TOPs) && SvRV (TOPs) == sv)
725 croak ("%s::TO_JSON method returned same object as was passed instead of a new one", HvNAME (SvSTASH (sv)));
726
727 sv = POPs;
728 PUTBACK;
729
730 encode_sv (enc, sv); 827 encode_sv (enc, TOPs);
731 828 SP -= count;
732 FREETMPS; LEAVE;
733 } 829 }
734 else if (enc->json.flags & F_ALLOW_BLESSED) 830
735 encode_str (enc, "null", 4, 0); 831 PUTBACK;
736 else 832
737 croak ("encountered object '%s' when conv_object is enabled, but TO_JSON is missing and allow_blessed disabled", 833 encode_ch (enc, ']');
738 SvPV_nolen (sv_2mortal (newRV_inc (sv)))); 834
835 FREETMPS; LEAVE;
739 } 836 }
740 else if (enc->json.flags & F_ALLOW_TAGS) 837 else if ((enc->json.flags & F_CONV_BLESSED) && (method = gv_fetchmethod_autoload (stash, "TO_JSON", 0)))
741 { 838 {
742 GV *method = gv_fetchmethod_autoload (stash, "FREEZE", 0);
743
744 if (method)
745 {
746 int count;
747 dSP; 839 dSP;
748 840
749 ENTER; SAVETMPS; PUSHMARK (SP); 841 ENTER; SAVETMPS;
750 EXTEND (SP, 2); 842 PUSHMARK (SP);
751 // we re-bless the reference to get overload and other niceties right 843 // we re-bless the reference to get overload and other niceties right
752 PUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash)); 844 XPUSHs (sv_bless (sv_2mortal (newRV_inc (sv)), stash));
753 PUSHs (sv_json);
754 845
846 // calling with G_SCALAR ensures that we always get a 1 return value
755 PUTBACK; 847 PUTBACK;
756 count = call_sv ((SV *)GvCV (method), G_ARRAY); 848 call_sv ((SV *)GvCV (method), G_SCALAR);
757 SPAGAIN; 849 SPAGAIN;
758 850
759 // catch this surprisingly common error 851 // catch this surprisingly common error
760 if (SvROK (TOPs) && SvRV (TOPs) == sv) 852 if (SvROK (TOPs) && SvRV (TOPs) == sv)
761 croak ("%s::TO_JSON method returned same object as was passed instead of a new one", HvNAME (SvSTASH (sv))); 853 croak ("%s::TO_JSON method returned same object as was passed instead of a new one", HvNAME (SvSTASH (sv)));
762 854
763 encode_ch (enc, '('); 855 sv = POPs;
764 encode_ch (enc, '"');
765 encode_str (enc, HvNAME (stash), HvNAMELEN (stash), HvNAMEUTF8 (stash));
766 encode_ch (enc, '"');
767 encode_ch (enc, ')');
768 encode_ch (enc, '[');
769
770 while (count)
771 {
772 encode_sv (enc, SP[1 - count--]);
773
774 if (count)
775 encode_ch (enc, ',');
776 }
777
778 encode_ch (enc, ']');
779
780 PUTBACK; 856 PUTBACK;
781 857
858 encode_sv (enc, sv);
859
782 FREETMPS; LEAVE; 860 FREETMPS; LEAVE;
783 }
784 else if (enc->json.flags & F_ALLOW_BLESSED)
785 encode_str (enc, "null", 4, 0);
786 else
787 croak ("encountered object '%s' when allow_tags is enabled, but FREEZE is missing and allow_blessed disabled",
788 SvPV_nolen (sv_2mortal (newRV_inc (sv))));
789 } 861 }
790 else if (enc->json.flags & F_ALLOW_BLESSED) 862 else if (enc->json.flags & F_ALLOW_BLESSED)
791 encode_str (enc, "null", 4, 0); 863 encode_str (enc, "null", 4, 0);
792 else 864 else
793 croak ("encountered object '%s', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled", 865 croak ("encountered object '%s', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing)",
794 SvPV_nolen (sv_2mortal (newRV_inc (sv)))); 866 SvPV_nolen (sv_2mortal (newRV_inc (sv))));
795 } 867 }
796 else if (svt == SVt_PVHV) 868 else if (svt == SVt_PVHV)
797 encode_hv (enc, (HV *)sv); 869 encode_hv (enc, (HV *)sv);
798 else if (svt == SVt_PVAV) 870 else if (svt == SVt_PVAV)
799 encode_av (enc, (AV *)sv); 871 encode_av (enc, (AV *)sv);
800 else if (svt < SVt_PVAV) 872 else if (svt < SVt_PVAV)
801 { 873 {
802 STRLEN len = 0; 874 int bool_type = ref_bool_type (sv);
803 char *pv = svt ? SvPV (sv, len) : 0;
804 875
805 if (len == 1 && *pv == '1') 876 if (bool_type == 1)
806 encode_str (enc, "true", 4, 0); 877 encode_str (enc, "true", 4, 0);
807 else if (len == 1 && *pv == '0') 878 else if (bool_type == 0)
808 encode_str (enc, "false", 5, 0); 879 encode_str (enc, "false", 5, 0);
809 else if (enc->json.flags & F_ALLOW_UNKNOWN) 880 else if (enc->json.flags & F_ALLOW_UNKNOWN)
810 encode_str (enc, "null", 4, 0); 881 encode_str (enc, "null", 4, 0);
811 else 882 else
812 croak ("cannot encode reference to scalar '%s' unless the scalar is 0 or 1", 883 croak ("cannot encode reference to scalar '%s' unless the scalar is 0 or 1",
… …
847 if (SvIsUV (sv) ? SvUVX (sv) <= 59000 918 if (SvIsUV (sv) ? SvUVX (sv) <= 59000
848 : SvIVX (sv) <= 59000 && SvIVX (sv) >= -59000) 919 : SvIVX (sv) <= 59000 && SvIVX (sv) >= -59000)
849 { 920 {
850 // optimise the "small number case" 921 // optimise the "small number case"
851 // code will likely be branchless and use only a single multiplication 922 // code will likely be branchless and use only a single multiplication
852 // works for numbers up to 59074 923 // 4.28 works for numbers up to 59074, 4.29 works up to 59076
853 I32 i = SvIVX (sv); 924 I32 i = SvIVX (sv);
854 U32 u; 925 U32 u;
855 char digit, nz = 0; 926 char digit, nz = 0;
856 927
857 need (enc, 6); 928 need (enc, 6);
… …
895static SV * 966static SV *
896encode_json (SV *scalar, JSON *json) 967encode_json (SV *scalar, JSON *json)
897{ 968{
898 enc_t enc; 969 enc_t enc;
899 970
900 if (!(json->flags & F_ALLOW_NONREF) && !SvROK (scalar)) 971 if (!(json->flags & F_ALLOW_NONREF) && json_nonref (scalar))
901 croak ("hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this)"); 972 croak ("hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this)");
902 973
903 enc.json = *json; 974 enc.json = *json;
904 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE)); 975 enc.sv = sv_2mortal (NEWSV (0, INIT_SIZE));
905 enc.cur = SvPVX (enc.sv); 976 enc.cur = SvPVX (enc.sv);
… …
967 else 1038 else
968 break; 1039 break;
969 } 1040 }
970 else if (ch != 0x20 && ch != 0x0a && ch != 0x0d && ch != 0x09) 1041 else if (ch != 0x20 && ch != 0x0a && ch != 0x0d && ch != 0x09)
971 break; // parse error, but let higher level handle it, gives better error messages 1042 break; // parse error, but let higher level handle it, gives better error messages
972 1043 else
973 ++dec->cur; 1044 ++dec->cur;
974 } 1045 }
975} 1046}
976 1047
977#define ERR(reason) SB dec->err = reason; goto fail; SE 1048#define ERR(reason) SB dec->err = reason; goto fail; SE
978 1049
… …
1112 *cur++ = *dec_cur++; 1183 *cur++ = *dec_cur++;
1113 while (--clen); 1184 while (--clen);
1114 1185
1115 utf8 = 1; 1186 utf8 = 1;
1116 } 1187 }
1188 else if (ch == '\t' && dec->json.flags & F_RELAXED)
1189 *cur++ = ch;
1117 else 1190 else
1118 { 1191 {
1119 --dec_cur; 1192 --dec_cur;
1120 1193
1121 if (!ch) 1194 if (!ch)
… …
1131 1204
1132 if (sv) 1205 if (sv)
1133 { 1206 {
1134 STRLEN cur = SvCUR (sv); 1207 STRLEN cur = SvCUR (sv);
1135 1208
1136 if (SvLEN (sv) <= cur + len) 1209 if (SvLEN (sv) - cur <= len)
1137 SvGROW (sv, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1); 1210 json_sv_grow (sv, cur, len);
1138 1211
1139 memcpy (SvPVX (sv) + SvCUR (sv), buf, len); 1212 memcpy (SvPVX (sv) + SvCUR (sv), buf, len);
1140 SvCUR_set (sv, SvCUR (sv) + len); 1213 SvCUR_set (sv, SvCUR (sv) + len);
1141 } 1214 }
1142 else 1215 else
… …
1433 1506
1434 DEC_DEC_DEPTH; 1507 DEC_DEC_DEPTH;
1435 sv = newRV_noinc ((SV *)hv); 1508 sv = newRV_noinc ((SV *)hv);
1436 1509
1437 // check filter callbacks 1510 // check filter callbacks
1438 if (dec->json.flags & F_HOOK) 1511 if (expect_false (dec->json.flags & F_HOOK))
1439 { 1512 {
1440 if (dec->json.cb_sk_object && HvKEYS (hv) == 1) 1513 if (dec->json.cb_sk_object && HvKEYS (hv) == 1)
1441 { 1514 {
1442 HE *cb, *he; 1515 HE *cb, *he;
1443 1516
1444 hv_iterinit (hv); 1517 hv_iterinit (hv);
1445 he = hv_iternext (hv); 1518 he = hv_iternext (hv);
1446 hv_iterinit (hv); 1519 hv_iterinit (hv);
1447 1520
1448 // the next line creates a mortal sv each time its called. 1521 // the next line creates a mortal sv each time it's called.
1449 // might want to optimise this for common cases. 1522 // might want to optimise this for common cases.
1450 cb = hv_fetch_ent (dec->json.cb_sk_object, hv_iterkeysv (he), 0, 0); 1523 cb = hv_fetch_ent (dec->json.cb_sk_object, hv_iterkeysv (he), 0, 0);
1451 1524
1452 if (cb) 1525 if (cb)
1453 { 1526 {
1454 dSP; 1527 dSP;
1455 int count; 1528 int count;
1456 1529
1457 ENTER; SAVETMPS; PUSHMARK (SP); 1530 ENTER; SAVETMPS;
1531 PUSHMARK (SP);
1458 XPUSHs (HeVAL (he)); 1532 XPUSHs (HeVAL (he));
1459 sv_2mortal (sv); 1533 sv_2mortal (sv);
1460 1534
1461 PUTBACK; count = call_sv (HeVAL (cb), G_ARRAY); SPAGAIN; 1535 PUTBACK; count = call_sv (HeVAL (cb), G_ARRAY); SPAGAIN;
1462 1536
1463 if (count == 1) 1537 if (count == 1)
1464 { 1538 {
1465 sv = newSVsv (POPs); 1539 sv = newSVsv (POPs);
1540 PUTBACK;
1466 FREETMPS; LEAVE; 1541 FREETMPS; LEAVE;
1467 return sv; 1542 return sv;
1468 } 1543 }
1544 else if (count)
1545 croak ("filter_json_single_key_object callbacks must not return more than one scalar");
1546
1547 PUTBACK;
1469 1548
1470 SvREFCNT_inc (sv); 1549 SvREFCNT_inc (sv);
1550
1471 FREETMPS; LEAVE; 1551 FREETMPS; LEAVE;
1472 } 1552 }
1473 } 1553 }
1474 1554
1475 if (dec->json.cb_object) 1555 if (dec->json.cb_object)
1476 { 1556 {
1477 dSP; 1557 dSP;
1478 int count; 1558 int count;
1479 1559
1480 ENTER; SAVETMPS; PUSHMARK (SP); 1560 ENTER; SAVETMPS;
1561 PUSHMARK (SP);
1481 XPUSHs (sv_2mortal (sv)); 1562 XPUSHs (sv_2mortal (sv));
1482 1563
1483 PUTBACK; count = call_sv (dec->json.cb_object, G_ARRAY); SPAGAIN; 1564 PUTBACK; count = call_sv (dec->json.cb_object, G_ARRAY); SPAGAIN;
1484 1565
1485 if (count == 1) 1566 if (count == 1)
1486 {
1487 sv = newSVsv (POPs); 1567 sv = newSVsv (POPs);
1488 FREETMPS; LEAVE; 1568 else if (count == 0)
1489 return sv;
1490 }
1491
1492 SvREFCNT_inc (sv); 1569 SvREFCNT_inc (sv);
1570 else
1571 croak ("filter_json_object callbacks must not return more than one scalar");
1572
1573 PUTBACK;
1574
1493 FREETMPS; LEAVE; 1575 FREETMPS; LEAVE;
1494 } 1576 }
1495 } 1577 }
1496 1578
1497 return sv; 1579 return sv;
… …
1511 if (!(dec->json.flags & F_ALLOW_TAGS)) 1593 if (!(dec->json.flags & F_ALLOW_TAGS))
1512 ERR ("malformed JSON string, neither array, object, number, string or atom"); 1594 ERR ("malformed JSON string, neither array, object, number, string or atom");
1513 1595
1514 ++dec->cur; 1596 ++dec->cur;
1515 1597
1598 decode_ws (dec);
1599
1516 tag = decode_sv (dec); 1600 tag = decode_sv (dec);
1517 if (!tag) 1601 if (!tag)
1518 goto fail; 1602 goto fail;
1519 1603
1520 if (!SvPOK (tag)) 1604 if (!SvPOK (tag))
1521 ERR ("malformed JSON string, (tag) must be a string"); 1605 ERR ("malformed JSON string, (tag) must be a string");
1522 1606
1607 decode_ws (dec);
1608
1523 if (*dec->cur != ')') 1609 if (*dec->cur != ')')
1524 ERR (") expected after tag"); 1610 ERR (") expected after tag");
1525 1611
1526 ++dec->cur; 1612 ++dec->cur;
1613
1614 decode_ws (dec);
1527 1615
1528 val = decode_sv (dec); 1616 val = decode_sv (dec);
1529 if (!val) 1617 if (!val)
1530 goto fail; 1618 goto fail;
1531 1619
… …
1546 if (!method) 1634 if (!method)
1547 ERR ("cannot decode perl-object (package does not have a THAW method)"); 1635 ERR ("cannot decode perl-object (package does not have a THAW method)");
1548 1636
1549 dSP; 1637 dSP;
1550 1638
1551 ENTER; SAVETMPS; PUSHMARK (SP); 1639 ENTER; SAVETMPS;
1640 PUSHMARK (SP);
1552 EXTEND (SP, len + 2); 1641 EXTEND (SP, len + 2);
1553 // we re-bless the reference to get overload and other niceties right 1642 // we re-bless the reference to get overload and other niceties right
1554 PUSHs (tag); 1643 PUSHs (tag);
1555 PUSHs (sv_json); 1644 PUSHs (sv_json);
1556 1645
… …
1593 case '-': 1682 case '-':
1594 case '0': case '1': case '2': case '3': case '4': 1683 case '0': case '1': case '2': case '3': case '4':
1595 case '5': case '6': case '7': case '8': case '9': 1684 case '5': case '6': case '7': case '8': case '9':
1596 return decode_num (dec); 1685 return decode_num (dec);
1597 1686
1687 case 'f':
1688 if (dec->end - dec->cur >= 5 && !memcmp (dec->cur, "false", 5))
1689 {
1690 dec->cur += 5;
1691
1692 if (expect_false (!dec->json.v_false))
1693 dec->json.v_false = GET_BOOL (false);
1694
1695 return newSVsv (dec->json.v_false);
1696 }
1697 else
1698 ERR ("'false' expected");
1699
1700 break;
1701
1598 case 't': 1702 case 't':
1599 if (dec->end - dec->cur >= 4 && !memcmp (dec->cur, "true", 4)) 1703 if (dec->end - dec->cur >= 4 && !memcmp (dec->cur, "true", 4))
1600 { 1704 {
1601 dec->cur += 4; 1705 dec->cur += 4;
1602#if JSON_SLOW 1706
1603 types_true = get_bool ("Types::Serialiser::true"); 1707 if (expect_false (!dec->json.v_true))
1604#endif 1708 dec->json.v_true = GET_BOOL (true);
1709
1605 return newSVsv (types_true); 1710 return newSVsv (dec->json.v_true);
1606 } 1711 }
1607 else 1712 else
1608 ERR ("'true' expected"); 1713 ERR ("'true' expected");
1609
1610 break;
1611
1612 case 'f':
1613 if (dec->end - dec->cur >= 5 && !memcmp (dec->cur, "false", 5))
1614 {
1615 dec->cur += 5;
1616#if JSON_SLOW
1617 types_false = get_bool ("Types::Serialiser::false");
1618#endif
1619 return newSVsv (types_false);
1620 }
1621 else
1622 ERR ("'false' expected");
1623 1714
1624 break; 1715 break;
1625 1716
1626 case 'n': 1717 case 'n':
1627 if (dec->end - dec->cur >= 4 && !memcmp (dec->cur, "null", 4)) 1718 if (dec->end - dec->cur >= 4 && !memcmp (dec->cur, "null", 4))
… …
1642fail: 1733fail:
1643 return 0; 1734 return 0;
1644} 1735}
1645 1736
1646static SV * 1737static SV *
1647decode_json (SV *string, JSON *json, char **offset_return) 1738decode_json (SV *string, JSON *json, STRLEN *offset_return)
1648{ 1739{
1649 dec_t dec; 1740 dec_t dec;
1650 SV *sv; 1741 SV *sv;
1651 1742
1652 /* work around bugs in 5.10 where manipulating magic values 1743 /* work around bugs in 5.10 where manipulating magic values
1653 * makes perl ignore the magic in subsequent accesses. 1744 * makes perl ignore the magic in subsequent accesses.
1654 * also make a copy of non-PV values, to get them into a clean 1745 * also make a copy of non-PV values, to get them into a clean
1655 * state (SvPV should do that, but it's buggy, see below). 1746 * state (SvPV should do that, but it's buggy, see below).
1747 *
1748 * SvIsCOW_shared_hash works around a bug in perl (possibly 5.16),
1749 * as reported by Reini Urban.
1656 */ 1750 */
1657 /*SvGETMAGIC (string);*/ 1751 /*SvGETMAGIC (string);*/
1658 if (SvMAGICAL (string) || !SvPOK (string)) 1752 if (SvMAGICAL (string) || !SvPOK (string) || SvIsCOW_shared_hash (string))
1659 string = sv_2mortal (newSVsv (string)); 1753 string = sv_2mortal (newSVsv (string));
1660 1754
1661 SvUPGRADE (string, SVt_PV); 1755 SvUPGRADE (string, SVt_PV);
1662 1756
1663 /* work around a bug in perl 5.10, which causes SvCUR to fail an 1757 /* work around a bug in perl 5.10, which causes SvCUR to fail an
… …
1702 1796
1703 decode_ws (&dec); 1797 decode_ws (&dec);
1704 sv = decode_sv (&dec); 1798 sv = decode_sv (&dec);
1705 1799
1706 if (offset_return) 1800 if (offset_return)
1707 *offset_return = dec.cur; 1801 *offset_return = dec.cur - SvPVX (string);
1708 1802 else if (sv)
1709 if (!(offset_return || !sv))
1710 { 1803 {
1711 // check for trailing garbage 1804 // check for trailing garbage
1712 decode_ws (&dec); 1805 decode_ws (&dec);
1713 1806
1714 if (*dec.cur) 1807 if (dec.cur != dec.end)
1715 { 1808 {
1716 dec.err = "garbage after JSON object"; 1809 dec.err = "garbage after JSON object";
1717 SvREFCNT_dec (sv); 1810 SvREFCNT_dec (sv);
1718 sv = 0; 1811 sv = 0;
1719 } 1812 }
… …
1738 dec.cur != dec.end ? SvPV_nolen (uni) : "(end of string)"); 1831 dec.cur != dec.end ? SvPV_nolen (uni) : "(end of string)");
1739 } 1832 }
1740 1833
1741 sv = sv_2mortal (sv); 1834 sv = sv_2mortal (sv);
1742 1835
1743 if (!(dec.json.flags & F_ALLOW_NONREF) && !SvROK (sv)) 1836 if (!(dec.json.flags & F_ALLOW_NONREF) && json_nonref (sv))
1744 croak ("JSON text must be an object or array (but found number, string, true, false or null, use allow_nonref to allow this)"); 1837 croak ("JSON text must be an object or array (but found number, string, true, false or null, use allow_nonref to allow this)");
1745 1838
1746 return sv; 1839 return sv;
1747} 1840}
1748 1841
… …
1757 // the state machine here is a bit convoluted and could be simplified a lot 1850 // the state machine here is a bit convoluted and could be simplified a lot
1758 // but this would make it slower, so... 1851 // but this would make it slower, so...
1759 1852
1760 for (;;) 1853 for (;;)
1761 { 1854 {
1762 //printf ("loop pod %d *p<%c><%s>, mode %d nest %d\n", p - SvPVX (self->incr_text), *p, p, self->incr_mode, self->incr_nest);//D
1763 switch (self->incr_mode) 1855 switch (self->incr_mode)
1764 { 1856 {
1857 // reached end of a scalar, see if we are inside a nested structure or not
1858 end_of_scalar:
1859 self->incr_mode = INCR_M_JSON;
1860
1861 if (self->incr_nest) // end of a scalar inside array, object or tag
1862 goto incr_m_json;
1863 else // end of scalar outside structure, json text ends here
1864 goto interrupt;
1865
1765 // only used for initial whitespace skipping 1866 // only used for initial whitespace skipping
1766 case INCR_M_WS: 1867 case INCR_M_WS:
1767 for (;;) 1868 for (;;)
1768 { 1869 {
1769 if (*p > 0x20) 1870 if (*p > 0x20)
… …
1811 ++p; 1912 ++p;
1812 } 1913 }
1813 1914
1814 break; 1915 break;
1815 1916
1917 // inside true/false/null
1918 case INCR_M_TFN:
1919 incr_m_tfn:
1920 for (;;)
1921 switch (*p++)
1922 {
1923 case 'r': case 'u': case 'e': // tRUE, falsE, nUll
1924 case 'a': case 'l': case 's': // fALSe, nuLL
1925 // allowed
1926 break;
1927
1928 default:
1929 --p;
1930 goto end_of_scalar;
1931 }
1932
1933 // inside a number
1934 case INCR_M_NUM:
1935 incr_m_num:
1936 for (;;)
1937 switch (*p++)
1938 {
1939 case 'e': case 'E': case '.': case '+':
1940 case '-':
1941 case '0': case '1': case '2': case '3': case '4':
1942 case '5': case '6': case '7': case '8': case '9':
1943 // allowed
1944 break;
1945
1946 default:
1947 --p;
1948 goto end_of_scalar;
1949 }
1950
1816 // inside a string 1951 // inside a string
1817 case INCR_M_STR: 1952 case INCR_M_STR:
1818 incr_m_str: 1953 incr_m_str:
1819 for (;;) 1954 for (;;)
1820 { 1955 {
1821 if (*p == '"') 1956 if (*p == '"')
1822 { 1957 {
1823 ++p; 1958 ++p;
1824 self->incr_mode = INCR_M_JSON;
1825
1826 if (!self->incr_nest)
1827 goto interrupt;
1828
1829 goto incr_m_json; 1959 goto end_of_scalar;
1830 } 1960 }
1831 else if (*p == '\\') 1961 else if (*p == '\\')
1832 { 1962 {
1833 ++p; // "virtually" consumes character after \ 1963 ++p; // "virtually" consumes character after \
1834 1964
… …
1864 --p; // do not eat the whitespace, let the next round do it 1994 --p; // do not eat the whitespace, let the next round do it
1865 goto interrupt; 1995 goto interrupt;
1866 } 1996 }
1867 break; 1997 break;
1868 1998
1999 // the following three blocks handle scalars. this makes the parser
2000 // more strict than required inside arrays or objects, and could
2001 // be moved to a special case on the toplevel (except strings)
2002 case 't':
2003 case 'f':
2004 case 'n':
2005 self->incr_mode = INCR_M_TFN;
2006 goto incr_m_tfn;
2007
2008 case '-':
2009 case '0': case '1': case '2': case '3': case '4':
2010 case '5': case '6': case '7': case '8': case '9':
2011 self->incr_mode = INCR_M_NUM;
2012 goto incr_m_num;
2013
1869 case '"': 2014 case '"':
1870 self->incr_mode = INCR_M_STR; 2015 self->incr_mode = INCR_M_STR;
1871 goto incr_m_str; 2016 goto incr_m_str;
1872 2017
1873 case '[': 2018 case '[':
… …
1918 i >= '0' && i <= '9' ? i - '0' 2063 i >= '0' && i <= '9' ? i - '0'
1919 : i >= 'a' && i <= 'f' ? i - 'a' + 10 2064 : i >= 'a' && i <= 'f' ? i - 'a' + 10
1920 : i >= 'A' && i <= 'F' ? i - 'A' + 10 2065 : i >= 'A' && i <= 'F' ? i - 'A' + 10
1921 : -1; 2066 : -1;
1922 2067
1923 json_stash = gv_stashpv ("JSON::XS" , 1); 2068 json_stash = gv_stashpv ("JSON::XS" , 1);
1924 types_boolean_stash = gv_stashpv ("Types::Serialiser::Boolean", 1); 2069 bool_stash = gv_stashpv ("Types::Serialiser::Boolean", 1);
1925
1926 types_true = get_bool ("Types::Serialiser::true");
1927 types_false = get_bool ("Types::Serialiser::false"); 2070 bool_false = get_bool ("Types::Serialiser::false");
2071 bool_true = get_bool ("Types::Serialiser::true");
1928 2072
1929 sv_json = newSVpv ("JSON", 0); 2073 sv_json = newSVpv ("JSON", 0);
1930 SvREADONLY_on (sv_json); 2074 SvREADONLY_on (sv_json);
1931 2075
1932 CvNODEBUG_on (get_cv ("JSON::XS::incr_text", 0)); /* the debugger completely breaks lvalue subs */ 2076 CvNODEBUG_on (get_cv ("JSON::XS::incr_text", 0)); /* the debugger completely breaks lvalue subs */
… …
1934 2078
1935PROTOTYPES: DISABLE 2079PROTOTYPES: DISABLE
1936 2080
1937void CLONE (...) 2081void CLONE (...)
1938 CODE: 2082 CODE:
2083 // as long as these writes are atomic, the race should not matter
2084 // as existing threads either already use 0, or use the old value,
2085 // which is sitll correct for the initial thread.
1939 json_stash = 0; 2086 json_stash = 0;
1940 types_boolean_stash = 0; 2087 bool_stash = 0;
2088 bool_false = 0;
2089 bool_true = 0;
1941 2090
1942void new (char *klass) 2091void new (char *klass)
1943 PPCODE: 2092 PPCODE:
1944{ 2093{
1945 SV *pv = NEWSV (0, sizeof (JSON)); 2094 SV *pv = NEWSV (0, sizeof (JSON));
… …
1948 XPUSHs (sv_2mortal (sv_bless ( 2097 XPUSHs (sv_2mortal (sv_bless (
1949 newRV_noinc (pv), 2098 newRV_noinc (pv),
1950 strEQ (klass, "JSON::XS") ? JSON_STASH : gv_stashpv (klass, 1) 2099 strEQ (klass, "JSON::XS") ? JSON_STASH : gv_stashpv (klass, 1)
1951 ))); 2100 )));
1952} 2101}
2102
2103void boolean_values (JSON *self, SV *v_false = 0, SV *v_true = 0)
2104 PPCODE:
2105 self->v_false = newSVsv (v_false);
2106 self->v_true = newSVsv (v_true);
2107 XPUSHs (ST (0));
2108
2109void get_boolean_values (JSON *self)
2110 PPCODE:
2111 if (self->v_false && self->v_true)
2112 {
2113 EXTEND (SP, 2);
2114 PUSHs (self->v_false);
2115 PUSHs (self->v_true);
2116 }
1953 2117
1954void ascii (JSON *self, int enable = 1) 2118void ascii (JSON *self, int enable = 1)
1955 ALIAS: 2119 ALIAS:
1956 ascii = F_ASCII 2120 ascii = F_ASCII
1957 latin1 = F_LATIN1 2121 latin1 = F_LATIN1
… …
2062 2226
2063void decode_prefix (JSON *self, SV *jsonstr) 2227void decode_prefix (JSON *self, SV *jsonstr)
2064 PPCODE: 2228 PPCODE:
2065{ 2229{
2066 SV *sv; 2230 SV *sv;
2067 char *offset; 2231 STRLEN offset;
2068 PUTBACK; sv = decode_json (jsonstr, self, &offset); SPAGAIN; 2232 PUTBACK; sv = decode_json (jsonstr, self, &offset); SPAGAIN;
2069 EXTEND (SP, 2); 2233 EXTEND (SP, 2);
2070 PUSHs (sv); 2234 PUSHs (sv);
2071 PUSHs (sv_2mortal (newSVuv (ptr_to_index (jsonstr, offset)))); 2235 PUSHs (sv_2mortal (newSVuv (ptr_to_index (jsonstr, SvPV_nolen (jsonstr) + offset))));
2072} 2236}
2073 2237
2074void incr_parse (JSON *self, SV *jsonstr = 0) 2238void incr_parse (JSON *self, SV *jsonstr = 0)
2075 PPCODE: 2239 PPCODE:
2076{ 2240{
… …
2110 { 2274 {
2111 STRLEN len; 2275 STRLEN len;
2112 const char *str = SvPV (jsonstr, len); 2276 const char *str = SvPV (jsonstr, len);
2113 STRLEN cur = SvCUR (self->incr_text); 2277 STRLEN cur = SvCUR (self->incr_text);
2114 2278
2115 if (SvLEN (self->incr_text) <= cur + len) 2279 if (SvLEN (self->incr_text) - cur <= len)
2116 SvGROW (self->incr_text, cur + (len < (cur >> 2) ? cur >> 2 : len) + 1); 2280 json_sv_grow (self->incr_text, cur, len);
2117 2281
2118 Move (str, SvEND (self->incr_text), len, char); 2282 Move (str, SvEND (self->incr_text), len, char);
2119 SvCUR_set (self->incr_text, SvCUR (self->incr_text) + len); 2283 SvCUR_set (self->incr_text, SvCUR (self->incr_text) + len);
2120 *SvEND (self->incr_text) = 0; // this should basically be a nop, too, but make sure it's there 2284 *SvEND (self->incr_text) = 0; // this should basically be a nop, too, but make sure it's there
2121 } 2285 }
… …
2123 2287
2124 if (GIMME_V != G_VOID) 2288 if (GIMME_V != G_VOID)
2125 do 2289 do
2126 { 2290 {
2127 SV *sv; 2291 SV *sv;
2128 char *offset; 2292 STRLEN offset;
2129 2293
2130 if (!INCR_DONE (self)) 2294 if (!INCR_DONE (self))
2131 { 2295 {
2132 incr_parse (self); 2296 incr_parse (self);
2133 2297
… …
2149 } 2313 }
2150 2314
2151 PUTBACK; sv = decode_json (self->incr_text, self, &offset); SPAGAIN; 2315 PUTBACK; sv = decode_json (self->incr_text, self, &offset); SPAGAIN;
2152 XPUSHs (sv); 2316 XPUSHs (sv);
2153 2317
2154 self->incr_pos -= offset - SvPVX (self->incr_text); 2318 self->incr_pos -= offset;
2155 self->incr_nest = 0; 2319 self->incr_nest = 0;
2156 self->incr_mode = 0; 2320 self->incr_mode = 0;
2157 2321
2158 sv_chop (self->incr_text, offset); 2322 sv_chop (self->incr_text, SvPVX (self->incr_text) + offset);
2159 } 2323 }
2160 while (GIMME_V == G_ARRAY); 2324 while (GIMME_V == G_ARRAY);
2161} 2325}
2162 2326
2163SV *incr_text (JSON *self) 2327SV *incr_text (JSON *self)
… …
2194 self->incr_mode = 0; 2358 self->incr_mode = 0;
2195} 2359}
2196 2360
2197void DESTROY (JSON *self) 2361void DESTROY (JSON *self)
2198 CODE: 2362 CODE:
2363 SvREFCNT_dec (self->v_false);
2364 SvREFCNT_dec (self->v_true);
2199 SvREFCNT_dec (self->cb_sk_object); 2365 SvREFCNT_dec (self->cb_sk_object);
2200 SvREFCNT_dec (self->cb_object); 2366 SvREFCNT_dec (self->cb_object);
2201 SvREFCNT_dec (self->incr_text); 2367 SvREFCNT_dec (self->incr_text);
2202 2368
2203PROTOTYPES: ENABLE 2369PROTOTYPES: ENABLE

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines