--- Net-SNMP-XS/XS.pm	2009/04/08 10:39:32	1.2
+++ Net-SNMP-XS/XS.pm	2009/04/09 05:56:36	1.5
@@ -15,16 +15,19 @@
 It does this by overriding a few selected internal method by (almost)
 equivalent XS methods.
 
-This currently reduces decode time by some 70%.
+This currently reduces decode time by a factor of ten for typical bulk
+responses.
 
 There are currently the following limitations when using this module:
 
 =over 4
 
-=item leading dots are required for iods
+=item only leading dots for oids are supported
 
 =item error handling is currently broken (but parse errors will be detected)
 
+=item error messages will be simpler/different
+
 =item oid components are limited to unsigned 32 bit integers
 
 =item translation will be ignored (all values will be delivered "raw")
@@ -35,6 +38,10 @@
 
 =item only tested with 5.10
 
+=item duplicate OIDs are not supported
+
+=item REPORT PDUs are not supported
+
 =back
 
 =cut
@@ -71,58 +78,32 @@
    &$old_prepare
 }
 
-# almost direct copy from Net::SNMP::Message, as we cannot access $process_methods
 {
    package Net::SNMP::Message;
 
-   my @process_methods;
-
-   $process_methods [INTEGER          ] = \&_process_integer32;
-   $process_methods [OCTET_STRING     ] = \&_process_octet_string;
-   $process_methods [NULL             ] = \&_process_null;
-   $process_methods [OBJECT_IDENTIFIER] = \&_process_object_identifier;
-   $process_methods [SEQUENCE         ] = \&_process_sequence;
-   $process_methods [IPADDRESS        ] = \&_process_ipaddress;
-   $process_methods [COUNTER          ] = \&_process_counter;
-   $process_methods [GAUGE            ] = \&_process_gauge;
-   $process_methods [TIMETICKS        ] = \&_process_timeticks;
-   $process_methods [OPAQUE           ] = \&_process_opaque;
-   $process_methods [COUNTER64        ] = \&_process_counter64;
-   $process_methods [NOSUCHOBJECT     ] = \&_process_nosuchobject;
-   $process_methods [NOSUCHINSTANCE   ] = \&_process_nosuchinstance;
-   $process_methods [ENDOFMIBVIEW     ] = \&_process_endofmibview;
-   $process_methods [GET_REQUEST      ] = \&_process_get_request;
-   $process_methods [GET_NEXT_REQUEST ] = \&_process_get_next_request;
-   $process_methods [GET_RESPONSE     ] = \&_process_get_response;
-   $process_methods [SET_REQUEST      ] = \&_process_set_request;
-   $process_methods [TRAP             ] = \&_process_trap;
-   $process_methods [GET_BULK_REQUEST ] = \&_process_get_bulk_request;
-   $process_methods [INFORM_REQUEST   ] = \&_process_inform_request;
-   $process_methods [SNMPV2_TRAP      ] = \&_process_v2_trap;
-   $process_methods [REPORT           ] = \&_process_report;
-
-   # should be done in XS
-   sub process 
-   {
-#     my ($this, $expected, $found) = @_;
-
-      return $_[0]->_error if defined($_[0]->{_error});
-      return $_[0]->_error unless defined(my $type = _buffer_get($_[0], 1));
-
-      $type = unpack 'C', $type;
-
-      if ($process_methods[$type]) {
-         if (@_ >= 2 && (defined $_[1]) && $type != $_[1]) {
-            return $_[0]->_error(
-               'Expected %s, but found %s', asn1_itoa($_[1]), asn1_itoa($type)
-            );
-         }
-         $_[2] = $type if (@_ == 3);
-         $process_methods[$type]->($_[0], $type);
-      } else {
-         $_[0]->_error('Unknown ASN.1 type [0x%02x]', $type);
-      }
-   }
+   Net::SNMP::XS::set_type INTEGER          , \&_process_integer32;
+   Net::SNMP::XS::set_type OCTET_STRING     , \&_process_octet_string;
+   Net::SNMP::XS::set_type NULL             , \&_process_null;
+   Net::SNMP::XS::set_type OBJECT_IDENTIFIER, \&_process_object_identifier;
+   Net::SNMP::XS::set_type SEQUENCE         , \&_process_sequence;
+   Net::SNMP::XS::set_type IPADDRESS        , \&_process_ipaddress;
+   Net::SNMP::XS::set_type COUNTER          , \&_process_counter;
+   Net::SNMP::XS::set_type GAUGE            , \&_process_gauge;
+   Net::SNMP::XS::set_type TIMETICKS        , \&_process_timeticks;
+   Net::SNMP::XS::set_type OPAQUE           , \&_process_opaque;
+   Net::SNMP::XS::set_type COUNTER64        , \&_process_counter64;
+   Net::SNMP::XS::set_type NOSUCHOBJECT     , \&_process_nosuchobject;
+   Net::SNMP::XS::set_type NOSUCHINSTANCE   , \&_process_nosuchinstance;
+   Net::SNMP::XS::set_type ENDOFMIBVIEW     , \&_process_endofmibview;
+   Net::SNMP::XS::set_type GET_REQUEST      , \&_process_get_request;
+   Net::SNMP::XS::set_type GET_NEXT_REQUEST , \&_process_get_next_request;
+   Net::SNMP::XS::set_type GET_RESPONSE     , \&_process_get_response;
+   Net::SNMP::XS::set_type SET_REQUEST      , \&_process_set_request;
+   Net::SNMP::XS::set_type TRAP             , \&_process_trap;
+   Net::SNMP::XS::set_type GET_BULK_REQUEST , \&_process_get_bulk_request;
+   Net::SNMP::XS::set_type INFORM_REQUEST   , \&_process_inform_request;
+   Net::SNMP::XS::set_type SNMPV2_TRAP      , \&_process_v2_trap;
+   Net::SNMP::XS::set_type REPORT           , \&_process_report;
 }
 
 1;