ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/cvsroot/Coro/myhttpd/httpd.pl
(Generate patch)

Comparing cvsroot/Coro/myhttpd/httpd.pl (file contents):
Revision 1.35 by root, Thu Aug 30 12:35:28 2001 UTC vs.
Revision 1.65 by root, Fri Jan 25 09:26:13 2002 UTC

1use Coro; 1use Coro;
2use Coro::Semaphore; 2use Coro::Semaphore;
3use Coro::Event; 3use Coro::Event;
4use Coro::Socket; 4use Coro::Socket;
5use Coro::Signal;
5 6
6use HTTP::Date; 7use HTTP::Date;
8use POSIX ();
9
10use Compress::Zlib ();
7 11
8no utf8; 12no utf8;
9use bytes; 13use bytes;
10 14
11# at least on my machine, this thingy serves files 15# at least on my machine, this thingy serves files
13# and quite a bit slower than thttpd :( 17# and quite a bit slower than thttpd :(
14 18
15$SIG{PIPE} = 'IGNORE'; 19$SIG{PIPE} = 'IGNORE';
16 20
17our $accesslog; 21our $accesslog;
22our $errorlog;
23
24our $NOW;
25our $HTTP_NOW;
26
27Event->timer(interval => 1, hard => 1, cb => sub {
28 $NOW = time;
29 $HTTP_NOW = time2str $NOW;
30})->now;
31
32if ($ERROR_LOG) {
33 use IO::Handle;
34 open $errorlog, ">>$ERROR_LOG"
35 or die "$ERROR_LOG: $!";
36 $errorlog->autoflush(1);
37}
18 38
19if ($ACCESS_LOG) { 39if ($ACCESS_LOG) {
20 use IO::Handle; 40 use IO::Handle;
21 open $accesslog, ">>$ACCESS_LOG" 41 open $accesslog, ">>$ACCESS_LOG"
22 or die "$ACCESS_LOG: $!"; 42 or die "$ACCESS_LOG: $!";
24} 44}
25 45
26sub slog { 46sub slog {
27 my $level = shift; 47 my $level = shift;
28 my $format = shift; 48 my $format = shift;
49 my $NOW = (POSIX::strftime "%Y-%m-%d %H:%M:%S", gmtime $::NOW);
29 printf "---: $format\n", @_; 50 printf "$NOW: $format\n", @_;
51 printf $errorlog "$NOW: $format\n", @_ if $errorlog;
30} 52}
31 53
32our $connections = new Coro::Semaphore $MAX_CONNECTS || 250; 54our $connections = new Coro::Semaphore $MAX_CONNECTS || 250;
55our $httpevent = new Coro::Signal;
33 56
34our $wait_factor = 0.95; 57our $queue_file = new transferqueue $MAX_TRANSFERS;
35 58our $queue_index = new transferqueue 10;
36our @transfers = (
37 [(new Coro::Semaphore $MAX_TRANSFERS_SMALL || 50), 1],
38 [(new Coro::Semaphore $MAX_TRANSFERS_LARGE || 50), 1],
39);
40 59
41my @newcons; 60my @newcons;
42my @pool; 61my @pool;
43 62
44# one "execution thread" 63# one "execution thread"
45sub handler { 64sub handler {
46 while () { 65 while () {
47 my $new = pop @newcons;
48 if ($new) { 66 if (@newcons) {
49 eval { 67 eval {
50 conn->new(@$new)->handle; 68 conn->new(@{pop @newcons})->handle;
51 }; 69 };
52 slog 1, "$@" if $@ && !ref $@; 70 slog 1, "$@" if $@ && !ref $@;
71
72 $httpevent->broadcast; # only for testing, but doesn't matter much
73
53 $connections->up; 74 $connections->up;
54 } else { 75 } else {
55 last if @pool >= $MAX_POOL; 76 last if @pool >= $MAX_POOL;
56 push @pool, $Coro::current; 77 push @pool, $Coro::current;
57 schedule; 78 schedule;
58 } 79 }
59 } 80 }
81}
82
83sub listen_on {
84 my $listen = $_[0];
85
86 push @listen_sockets, $listen;
87
88 # the "main thread"
89 async {
90 slog 1, "accepting connections";
91 while () {
92 $connections->down;
93 push @newcons, [$listen->accept];
94 #slog 3, "accepted @$connections ".scalar(@pool);
95 if (@pool) {
96 (pop @pool)->ready;
97 } else {
98 async \&handler;
99 }
100
101 }
102 };
60} 103}
61 104
62my $http_port = new Coro::Socket 105my $http_port = new Coro::Socket
63 LocalAddr => $SERVER_HOST, 106 LocalAddr => $SERVER_HOST,
64 LocalPort => $SERVER_PORT, 107 LocalPort => $SERVER_PORT,
65 ReuseAddr => 1, 108 ReuseAddr => 1,
66 Listen => 50, 109 Listen => 50,
67 or die "unable to start server"; 110 or die "unable to start server";
68 111
69push @listen_sockets, $http_port; 112listen_on $http_port;
70 113
71our $NOW; 114if ($SERVER_PORT2) {
72our $HTTP_NOW; 115 my $http_port = new Coro::Socket
116 LocalAddr => $SERVER_HOST,
117 LocalPort => $SERVER_PORT2,
118 ReuseAddr => 1,
119 Listen => 50,
120 or die "unable to start server";
73 121
74Event->timer(interval => 1, hard => 1, cb => sub { 122 listen_on $http_port;
75 $NOW = time; 123}
76 $HTTP_NOW = time2str $NOW;
77})->now;
78
79# the "main thread"
80async {
81 slog 1, "accepting connections";
82 while () {
83 $connections->down;
84 push @newcons, [$http_port->accept];
85 #slog 3, "accepted @$connections ".scalar(@pool);
86 if (@pool) {
87 (pop @pool)->ready;
88 } else {
89 async \&handler;
90 }
91
92 }
93};
94 124
95package conn; 125package conn;
96 126
97use Socket; 127use Socket;
98use HTTP::Date; 128use HTTP::Date;
99use Convert::Scalar 'weaken'; 129use Convert::Scalar 'weaken';
100use Linux::AIO; 130use Linux::AIO;
101 131
102Linux::AIO::min_parallel $::AIO_PARALLEL; 132Linux::AIO::min_parallel $::AIO_PARALLEL;
103
104my $aio_requests = new Coro::Semaphore $::AIO_PARALLEL * 4;
105 133
106Event->io(fd => Linux::AIO::poll_fileno, 134Event->io(fd => Linux::AIO::poll_fileno,
107 poll => 'r', async => 1, 135 poll => 'r', async => 1,
108 cb => \&Linux::AIO::poll_cb); 136 cb => \&Linux::AIO::poll_cb);
109 137
127 155
128read_mimetypes; 156read_mimetypes;
129 157
130sub new { 158sub new {
131 my $class = shift; 159 my $class = shift;
160 my $fh = shift;
132 my $peername = shift; 161 my $peername = shift;
133 my $fh = shift;
134 my $self = bless { fh => $fh }, $class; 162 my $self = bless { fh => $fh }, $class;
135 my (undef, $iaddr) = unpack_sockaddr_in $peername 163 my (undef, $iaddr) = unpack_sockaddr_in $peername
136 or $self->err(500, "unable to decode peername"); 164 or $self->err(500, "unable to decode peername");
137 165
166 $self->{remote_addr} =
138 $self->{remote_addr} = inet_ntoa $iaddr; 167 $self->{remote_id} = inet_ntoa $iaddr;
168
139 $self->{time} = $::NOW; 169 $self->{time} = $::NOW;
140 170
141 # enter ourselves into various lists 171 weaken ($Coro::current->{conn} = $self);
142 weaken ($conn{$self->{remote_addr}}{$self*1} = $self);
143 172
144 $::conns++; 173 $::conns++;
174 $::maxconns = $::conns if $::conns > $::maxconns;
145 175
146 $self; 176 $self;
147} 177}
148 178
149sub DESTROY { 179sub DESTROY {
150 my $self = shift; 180 #my $self = shift;
151
152 $::conns--; 181 $::conns--;
153
154 $self->eoconn;
155 delete $conn{$self->{remote_addr}}{$self*1};
156}
157
158# end of connection
159sub eoconn {
160 my $self = shift;
161 delete $uri{$self->{remote_addr}}{$self->{uri}}{$self*1};
162} 182}
163 183
164sub slog { 184sub slog {
165 my $self = shift; 185 my $self = shift;
166 main::slog($_[0], ($self->{remote_id} || $self->{remote_addr}) ."> $_[1]"); 186 main::slog($_[0], "$self->{remote_id}> $_[1]");
167} 187}
168 188
169sub response { 189sub response {
170 my ($self, $code, $msg, $hdr, $content) = @_; 190 my ($self, $code, $msg, $hdr, $content) = @_;
171 my $res = "HTTP/1.1 $code $msg\015\012"; 191 my $res = "HTTP/1.1 $code $msg\015\012";
192 my $GZ = "";
172 193
173 $self->{h}{connection} ||= $hdr->{Connection}; 194 if (exists $hdr->{Connection}) {
195 if ($hdr->{Connection} =~ /close/) {
196 $self->{h}{connection} = "close"
197 }
198 } else {
199 if ($self->{version} < 1.1) {
200 if ($self->{h}{connection} =~ /keep-alive/i) {
201 $hdr->{Connection} = "Keep-Alive";
202 } else {
203 $self->{h}{connection} = "close"
204 }
205 }
206 }
207
208 if ($self->{method} ne "HEAD"
209 && $self->{h}{"accept-encoding"} =~ /\bgzip\b/
210 && 400 < length $content
211 && $hdr->{"Content-Length"} == length $content
212 && !exists $hdr->{"Content-Encoding"}
213 ) {
214 my $orig = length $content;
215 $hdr->{"Content-Encoding"} = "gzip";
216 $content = Compress::Zlib::memGzip(\$content);
217 $hdr->{"Content-Length"} = length $content;
218 $GZ = sprintf "GZ%02d", 100 - 100*((length $content) / $orig);
219 }
174 220
175 $res .= "Date: $HTTP_NOW\015\012"; 221 $res .= "Date: $HTTP_NOW\015\012";
176 222
177 while (my ($h, $v) = each %$hdr) { 223 while (my ($h, $v) = each %$hdr) {
178 $res .= "$h: $v\015\012" 224 $res .= "$h: $v\015\012"
179 } 225 }
180 $res .= "\015\012"; 226 $res .= "\015\012";
181 227
182 $res .= $content if defined $content and $self->{method} ne "HEAD"; 228 $res .= $content if defined $content and $self->{method} ne "HEAD";
183 229
184 my $log = "$self->{remote_addr} \"$self->{uri}\" $code ".$hdr->{"Content-Length"}." \"$self->{h}{referer}\"\n"; 230 my $log = (POSIX::strftime "%Y-%m-%d %H:%M:%S", gmtime $::NOW).
231 " $self->{remote_id} \"$self->{uri}\" $code ".$hdr->{"Content-Length"}.$GZ.
232 " \"$self->{h}{referer}\"\n";
185 233
186 print $accesslog $log if $accesslog; 234 print $::accesslog $log if $::accesslog;
187 print STDERR $log; 235 print STDERR $log;
188 236
189 $self->{written} += 237 $self->{written} +=
190 print {$self->{fh}} $res; 238 print {$self->{fh}} $res;
191} 239}
228 } 276 }
229 277
230 $self->{h} = {}; 278 $self->{h} = {};
231 279
232 $fh->timeout($::RES_TIMEOUT); 280 $fh->timeout($::RES_TIMEOUT);
233 my $ip = $self->{remote_addr};
234
235 if ($blocked{$ip}) {
236 $self->err_blocked($blocked{$ip})
237 if $blocked{$ip} > $::NOW;
238
239 delete $blocked{$ip};
240 }
241
242 if (%{$conn{$ip}} > $::MAX_CONN_IP) {
243 my $delay = 120;
244 while (%{$conn{$ip}} > $::MAX_CONN_IP) {
245 if ($delay <= 0) {
246 $self->slog(2, "blocked ip $ip");
247 $self->err_blocked;
248 } else {
249 Coro::Event::do_timer(after => 3);
250 $delay -= 3;
251 }
252 }
253 }
254 281
255 $req =~ /^(?:\015\012)? 282 $req =~ /^(?:\015\012)?
256 (GET|HEAD) \040+ 283 (GET|HEAD) \040+
257 ([^\040]+) \040+ 284 ([^\040]+) \040+
258 HTTP\/([0-9]+\.[0-9]+) 285 HTTP\/([0-9]+\.[0-9]+)
271 my (%hdr, $h, $v); 298 my (%hdr, $h, $v);
272 299
273 $hdr{lc $1} .= ",$2" 300 $hdr{lc $1} .= ",$2"
274 while $req =~ /\G 301 while $req =~ /\G
275 ([^:\000-\040]+): 302 ([^:\000-\040]+):
276 [\008\040]* 303 [\010\040]*
277 ((?: [^\015\012]+ | \015\012[\008\040] )*) 304 ((?: [^\015\012]+ | \015\012[\010\040] )*)
278 \015\012 305 \015\012
279 /gxc; 306 /gxc;
280 307
281 $req =~ /\G\015\012$/ 308 $req =~ /\G\015\012$/
282 or $self->err(400, "bad request"); 309 or $self->err(400, "bad request");
283 310
284 $self->{h}{$h} = substr $v, 1 311 $self->{h}{$h} = substr $v, 1
285 while ($h, $v) = each %hdr; 312 while ($h, $v) = each %hdr;
313 }
314
315 # remote id should be unique per user
316 my $id = $self->{remote_addr};
317
318 if (exists $self->{h}{"client-ip"}) {
319 $id .= "[".$self->{h}{"client-ip"}."]";
320 } elsif (exists $self->{h}{"x-forwarded-for"}) {
321 $id .= "[".$self->{h}{"x-forwarded-for"}."]";
322 }
323
324 $self->{remote_id} = $id;
325
326 weaken (local $conn{$id}{$self*1} = $self);
327
328 if ($blocked{$id}) {
329 $self->err_blocked
330 if $blocked{$id}[0] > $::NOW;
331
332 delete $blocked{$id};
286 } 333 }
287 334
288 # find out server name and port 335 # find out server name and port
289 if ($self->{uri} =~ s/^http:\/\/([^\/?#]*)//i) { 336 if ($self->{uri} =~ s/^http:\/\/([^\/?#]*)//i) {
290 $host = $1; 337 $host = $1;
294 341
295 if (defined $host) { 342 if (defined $host) {
296 $self->{server_port} = $host =~ s/:([0-9]+)$// ? $1 : 80; 343 $self->{server_port} = $host =~ s/:([0-9]+)$// ? $1 : 80;
297 } else { 344 } else {
298 ($self->{server_port}, $host) 345 ($self->{server_port}, $host)
299 = unpack_sockaddr_in $self->{fh}->getsockname 346 = unpack_sockaddr_in $self->{fh}->sockname
300 or $self->err(500, "unable to get socket name"); 347 or $self->err(500, "unable to get socket name");
301 $host = inet_ntoa $host; 348 $host = inet_ntoa $host;
302 } 349 }
303 350
304 $self->{server_name} = $host; 351 $self->{server_name} = $host;
305 352
306 # remote id should be unique per user
307 $self->{remote_id} = $self->{remote_addr};
308
309 if (exists $self->{h}{"client-ip"}) {
310 $self->{remote_id} .= "[".$self->{h}{"client-ip"}."]";
311 } elsif (exists $self->{h}{"x-forwarded-for"}) {
312 $self->{remote_id} .= "[".$self->{h}{"x-forwarded-for"}."]";
313 }
314
315 weaken ($uri{$self->{remote_addr}}{$self->{uri}}{$self*1} = $self); 353 weaken (local $uri{$id}{$self->{uri}}{$self*1} = $self);
316 354
317 eval { 355 eval {
318 $self->map_uri; 356 $self->map_uri;
319 $self->respond; 357 $self->respond;
320 }; 358 };
321 359
322 $self->eoconn;
323
324 die if $@ && !ref $@; 360 die if $@ && !ref $@;
325 361
326 last if $self->{h}{connection} =~ /close/ || $self->{version} < 1.1; 362 last if $self->{h}{connection} =~ /close/i;
363
364 $httpevent->broadcast;
327 365
328 $fh->timeout($::PER_TIMEOUT); 366 $fh->timeout($::PER_TIMEOUT);
329 } 367 }
368}
369
370sub block {
371 my $self = shift;
372
373 $blocked{$self->{remote_id}} = [$::NOW + $_[0], $_[1]];
374 $self->slog(2, "blocked ip $self->{remote_id}");
375 $self->err_blocked;
330} 376}
331 377
332# uri => path mapping 378# uri => path mapping
333sub map_uri { 379sub map_uri {
334 my $self = shift; 380 my $self = shift;
381 427
382sub respond { 428sub respond {
383 my $self = shift; 429 my $self = shift;
384 my $path = $self->{path}; 430 my $path = $self->{path};
385 431
386 stat $path 432 if ($self->{name} =~ s%^/internal/([^/]+)%%) {
387 or $self->err(404, "not found"); 433 if ($::internal{$1}) {
388 434 $::internal{$1}->($self);
389 $self->{stat} = [stat _];
390
391 # idiotic netscape sends idiotic headers AGAIN
392 my $ims = $self->{h}{"if-modified-since"} =~ /^([^;]+)/
393 ? str2time $1 : 0;
394
395 if (-d _ && -r _) {
396 # directory
397 if ($path !~ /\/$/) {
398 # create a redirect to get the trailing "/"
399 # we don't try to avoid the :80
400 $self->err(301, "moved permanently", { Location => "http://".$self->server_hostport."$self->{uri}/" });
401 } else { 435 } else {
402 $ims < $self->{stat}[9] 436 $self->err(404, "not found");
437 }
438 } else {
439
440 stat $path
403 or $self->err(304, "not modified"); 441 or $self->err(404, "not found");
404 442
405 if (-r "$path/index.html") { 443 $self->{stat} = [stat _];
406 $self->{path} .= "/index.html"; 444
407 $self->handle_file; 445 # idiotic netscape sends idiotic headers AGAIN
446 my $ims = $self->{h}{"if-modified-since"} =~ /^([^;]+)/
447 ? str2time $1 : 0;
448
449 if (-d _ && -r _) {
450 # directory
451 if ($path !~ /\/$/) {
452 # create a redirect to get the trailing "/"
453 # we don't try to avoid the :80
454 $self->err(301, "moved permanently", { Location => "http://".$self->server_hostport."$self->{uri}/" });
408 } else { 455 } else {
456 $ims < $self->{stat}[9]
457 or $self->err(304, "not modified");
458
459 if (-r "$path/index.html") {
460 # replace directory "size" by index.html filesize
461 $self->{stat} = [stat ($self->{path} .= "/index.html")];
462 $self->handle_file($queue_index);
463 } else {
409 $self->handle_dir; 464 $self->handle_dir;
410 } 465 }
411 } 466 }
412 } elsif (-f _ && -r _) { 467 } elsif (-f _ && -r _) {
413 -x _ and $self->err(403, "forbidden"); 468 -x _ and $self->err(403, "forbidden");
469
470 if (keys %{$conn{$self->{remote_id}}} > $::MAX_TRANSFERS_IP) {
471 my $timeout = $::NOW + 10;
472 while (keys %{$conn{$self->{remote_id}}} > $::MAX_TRANSFERS_IP) {
473 if ($timeout < $::NOW) {
474 $self->block($::BLOCKTIME, "too many connections");
475 } else {
476 $httpevent->wait;
477 }
478 }
479 }
480
414 $self->handle_file; 481 $self->handle_file($queue_file);
415 } else { 482 } else {
416 $self->err(404, "not found"); 483 $self->err(404, "not found");
484 }
417 } 485 }
418} 486}
419 487
420sub handle_dir { 488sub handle_dir {
421 my $self = shift; 489 my $self = shift;
423 491
424 $self->response(200, "ok", 492 $self->response(200, "ok",
425 { 493 {
426 "Content-Type" => "text/html", 494 "Content-Type" => "text/html",
427 "Content-Length" => length $idx, 495 "Content-Length" => length $idx,
496 "Last-Modified" => time2str ($self->{stat}[9]),
428 }, 497 },
429 $idx); 498 $idx);
430} 499}
431 500
432sub handle_file { 501sub handle_file {
433 my $self = shift; 502 my ($self, $queue) = @_;
434 my $length = $self->{stat}[7]; 503 my $length = $self->{stat}[7];
435 my $queue = $::transfers[$length >= $::TRANSFER_SMALL];
436 my $hdr = { 504 my $hdr = {
437 "Last-Modified" => time2str ((stat _)[9]), 505 "Last-Modified" => time2str ((stat _)[9]),
438 }; 506 };
439 507
440 my @code = (200, "ok"); 508 my @code = (200, "ok");
457 $self->err(416, "not satisfiable", $hdr, ""); 525 $self->err(416, "not satisfiable", $hdr, "");
458 526
459satisfiable: 527satisfiable:
460 # check for segmented downloads 528 # check for segmented downloads
461 if ($l && $::NO_SEGMENTED) { 529 if ($l && $::NO_SEGMENTED) {
462 my $delay = 180; 530 my $timeout = $::NOW + 15;
463 while (%{$uri{$self->{remote_addr}}{$self->{uri}}} > 1) { 531 while (keys %{$uri{$self->{remote_id}}{$self->{uri}}} > 1) {
464 if ($delay <= 0) { 532 if ($timeout <= $::NOW) {
533 $self->block($::BLOCKTIME, "segmented downloads are forbidden");
465 $self->err_segmented_download; 534 #$self->err_segmented_download;
466 } else { 535 } else {
467 Coro::Event::do_timer(after => 3); $delay -= 3; 536 $httpevent->wait;
468 } 537 }
469 } 538 }
470 } 539 }
471 540
472 $hdr->{"Content-Range"} = "bytes $l-$h/$length"; 541 $hdr->{"Content-Range"} = "bytes $l-$h/$length";
485 $self->response(@code, $hdr, ""); 554 $self->response(@code, $hdr, "");
486 555
487 if ($self->{method} eq "GET") { 556 if ($self->{method} eq "GET") {
488 $self->{time} = $::NOW; 557 $self->{time} = $::NOW;
489 558
490 my $fudge = $queue->[0]->waiters; 559 my $current = $Coro::current;
491 $fudge = $fudge ? ($fudge+1)/$fudge : 1;
492
493 $queue->[1] *= $fudge;
494 my $transfer = $queue->[0]->guard;
495
496 if ($fudge != 1) {
497 $queue->[1] /= $fudge;
498 $queue->[1] = $queue->[1] * $::wait_factor
499 + ($::NOW - $self->{time}) * (1 - $::wait_factor);
500 }
501 $self->{time} = $::NOW;
502
503 $self->{fh}->writable or return;
504 560
505 my ($fh, $buf, $r); 561 my ($fh, $buf, $r);
506 my $current = $Coro::current; 562
507 open $fh, "<", $self->{path} 563 open $fh, "<", $self->{path}
508 or die "$self->{path}: late open failure ($!)"; 564 or die "$self->{path}: late open failure ($!)";
509 565
510 $h -= $l - 1; 566 $h -= $l - 1;
511 567
512 if (0) { 568 if (0) { # !AIO
513 if ($l) { 569 if ($l) {
514 sysseek $fh, $l, 0; 570 sysseek $fh, $l, 0;
515 } 571 }
516 } 572 }
573
574 my $transfer = $queue->start_transfer($h);
575 my $locked;
576 my $bufsize = $::WAIT_BUFSIZE; # initial buffer size
517 577
518 while ($h > 0) { 578 while ($h > 0) {
579 unless ($locked) {
580 if ($locked ||= $transfer->try($::WAIT_INTERVAL)) {
581 $bufsize = $::BUFSIZE;
582 $self->{time} = $::NOW;
583 }
584 }
585
586 if ($blocked{$self->{remote_id}}) {
587 $self->{h}{connection} = "close";
588 die bless {}, err::;
589 }
590
519 if (0) { 591 if (0) { # !AIO
520 sysread $fh, $buf, $h > $::BUFSIZE ? $::BUFSIZE : $h 592 sysread $fh, $buf, $h > $bufsize ? $bufsize : $h
521 or last; 593 or last;
522 } else { 594 } else {
523 undef $buf; 595 aio_read($fh, $l, ($h > $bufsize ? $bufsize : $h),
524 $aio_requests->down;
525 aio_read($fh, $l, ($h > $::BUFSIZE ? $::BUFSIZE : $h),
526 $buf, 0, sub { 596 $buf, 0, sub {
527 $r = $_[0]; 597 $r = $_[0];
528 $current->ready; 598 Coro::ready($current);
529 }); 599 });
530 &Coro::schedule; 600 &Coro::schedule;
531 $aio_requests->up;
532 last unless $r; 601 last unless $r;
533 } 602 }
534 my $w = $self->{fh}->syswrite($buf) 603 my $w = syswrite $self->{fh}, $buf
535 or last; 604 or last;
536 $::written += $w; 605 $::written += $w;
537 $self->{written} += $w; 606 $self->{written} += $w;
538 $l += $r; 607 $l += $r;
539 } 608 }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines