ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/Deliantra-Client/DC.pm
(Generate patch)

Comparing deliantra/Deliantra-Client/DC.pm (file contents):
Revision 1.64 by elmex, Thu May 25 18:48:45 2006 UTC vs.
Revision 1.83 by root, Wed May 31 07:40:33 2006 UTC

… …
24use utf8; 24use utf8;
25 25
26use Carp (); 26use Carp ();
27use AnyEvent (); 27use AnyEvent ();
28use BerkeleyDB; 28use BerkeleyDB;
29
30use CFClient::OpenGL;
31
32our %GL_EXT;
33our $GL_VERSION;
34
35our $GL_NPOT;
36our $GL_DEBUG = 1;
37
38sub gl_init {
39 $GL_VERSION = gl_version * 1;
40 %GL_EXT = map +($_ => 1), split /\s+/, gl_extensions;
41
42 $GL_NPOT = $GL_EXT{GL_ARB_texture_non_power_of_two} || $GL_VERSION >= 2;
43 $GL_NPOT = 0 if gl_vendor =~ /ATI Technologies/; # ATI doesn't get it right...
44
45 glDisable GL_COLOR_MATERIAL;
46 glShadeModel GL_FLAT;
47 glDisable GL_DITHER;
48 glDisable GL_DEPTH_TEST;
49 glDepthMask 0;
50 glHint GL_PERSPECTIVE_CORRECTION_HINT, GL_FASTEST;
51
52 CFClient::Texture::restore_state ();
53}
54
55sub gl_check {
56 return unless $GL_DEBUG;
57
58 if (my $error = glGetError) {
59 my ($format, @args) = @_;
60 Carp::cluck sprintf "opengl error %x while $format", $error, @args;
61 }
62}
63 29
64sub find_rcfile($) { 30sub find_rcfile($) {
65 my $path; 31 my $path;
66 32
67 for (grep !ref, @INC) { 33 for (grep !ref, @INC) {
… …
102 } 68 }
103 69
104 close CFG; 70 close CFG;
105} 71}
106 72
107mkdir "$Crossfire::VARDIR/pclient", 0777; 73mkdir "$Crossfire::VARDIR/cfplus", 0777;
108 74
75our $DB_ENV;
76
77{
78 use strict;
79
80 my $recover = $BerkeleyDB::db_version >= 4.4
81 ? eval "DB_REGISTER | DB_RECOVER"
82 : 0;
83
109our $DB_ENV = new BerkeleyDB::Env 84 $DB_ENV = new BerkeleyDB::Env
110 -Home => "$Crossfire::VARDIR/pclient", 85 -Home => "$Crossfire::VARDIR/cfplus",
111 -Cachesize => 1_000_000, 86 -Cachesize => 1_000_000,
112 -ErrFile => "$Crossfire::VARDIR/pclient/errorlog.txt", 87 -ErrFile => "$Crossfire::VARDIR/cfplus/errorlog.txt",
113# -ErrPrefix => "DATABASE", 88# -ErrPrefix => "DATABASE",
114 -Verbose => 1, 89 -Verbose => 1,
115 -Flags => DB_CREATE | DB_RECOVER | DB_INIT_MPOOL | DB_INIT_LOCK | DB_INIT_TXN, 90 -Flags => DB_CREATE | DB_RECOVER | DB_INIT_MPOOL | DB_INIT_LOCK | DB_INIT_TXN | $recover,
91 -SetFlags => DB_AUTO_COMMIT | DB_LOG_AUTOREMOVE,
116 or die "unable to create/open database home $Crossfire::VARDIR/pclient: $BerkeleyDB::Error"; 92 or die "unable to create/open database home $Crossfire::VARDIR/cfplus: $BerkeleyDB::Error";
93}
117 94
118sub db_table($) { 95sub db_table($) {
119 my ($table) = @_; 96 my ($table) = @_;
120 97
121 $table =~ s/([^a-zA-Z0-9_\-])/sprintf "=%x=", ord $1/ge; 98 $table =~ s/([^a-zA-Z0-9_\-])/sprintf "=%x=", ord $1/ge;
122 99
123 new CFClient::Database 100 new CFClient::Database
124 -Env => $DB_ENV, 101 -Env => $DB_ENV,
125 -Filename => $table, 102 -Filename => $table,
126# -Filename => "database", 103# -Filename => "database",
127# -Subname => $table, 104# -Subname => $table,
128 -Property => DB_CHKSUM, 105 -Property => DB_CHKSUM,
129 -Flags => DB_CREATE | DB_UPGRADE, 106 -Flags => DB_CREATE | DB_UPGRADE,
130 or die "unable to create/open database table $_[0]: $BerkeleyDB::Error"; 107 or die "unable to create/open database table $_[0]: $BerkeleyDB::Error"
131} 108}
132 109
133sub pod_to_pango($) { 110sub pod_to_pango($) {
134 my ($pom) = @_; 111 my ($pom) = @_;
135 112
… …
171 . $_[1]->content->present ($_[0]) 148 . $_[1]->content->present ($_[0])
172} 149}
173 150
174sub view_verbatim { 151sub view_verbatim {
175 (join "", 152 (join "",
176 map +("\t" x ($indent / 2)) . "$_\n", 153 map +("\t" x ($indent / 2)) . "<tt>$_</tt>\n",
177 split /\n/, CFClient::UI::Label::escape ($_[1])) 154 split /\n/, CFClient::UI::Label::escape ($_[1]))
178 . "\n" 155 . "\n"
179} 156}
180 157
181sub view_textblock { 158sub view_textblock {
182 ("\t" x ($indent / 2)) . "$_[1]\n\n" 159 ("\t" x ($indent / 2)) . "$_[1]\n\n"
183} 160}
184 161
185sub view_head1 { 162sub view_head1 {
186 "<span foreground='#ffff00' size='x-large'>" . $_[1]->title->present ($_[0]) . "</span>\n\n" 163 "\n\n<span foreground='#ffff00' size='x-large'>" . $_[1]->title->present ($_[0]) . "</span>\n\n"
187 . $_[1]->content->present ($_[0]) 164 . $_[1]->content->present ($_[0])
188}; 165};
189 166
190sub view_head2 { 167sub view_head2 {
191 "<span foreground='#ccccff' size='large'>" . $_[1]->title->present ($_[0]) . "</span>\n\n" 168 "\n<span foreground='#ccccff' size='large'>" . $_[1]->title->present ($_[0]) . "</span>\n\n"
169 . $_[1]->content->present ($_[0])
170};
171
172sub view_head3 {
173 "\n<span size='large'>" . $_[1]->title->present ($_[0]) . "</span>\n\n"
192 . $_[1]->content->present ($_[0]) 174 . $_[1]->content->present ($_[0])
193}; 175};
194 176
195sub view_over { 177sub view_over {
196 local $indent = $indent + $_[1]->indent; 178 local $indent = $indent + $_[1]->indent;
… …
218 200
219 $db->db_put ($key => $data) 201 $db->db_put ($key => $data)
220} 202}
221 203
222package CFClient::Item; 204package CFClient::Item;
205
206use strict;
207use Crossfire::Protocol::Constants;
223 208
224sub desc_string { 209sub desc_string {
225 my ($self) = @_; 210 my ($self) = @_;
226 211
227 my $desc = 212 my $desc =
228 $self->{nrof} < 2 213 $self->{nrof} < 2
229 ? $self->{name} 214 ? $self->{name}
230 : "$self->{nrof} × $self->{name_pl}"; 215 : "$self->{nrof} × $self->{name_pl}";
231 216
232 $self->{flags} & Crossfire::Protocol::F_OPEN 217 $self->{flags} & F_OPEN
233 and $desc .= " (open)"; 218 and $desc .= " (open)";
234 $self->{flags} & Crossfire::Protocol::F_APPLIED 219 $self->{flags} & F_APPLIED
235 and $desc .= " (applied)"; 220 and $desc .= " (applied)";
236 $self->{flags} & Crossfire::Protocol::F_UNPAID 221 $self->{flags} & F_UNPAID
237 and $desc .= " (unpaid)"; 222 and $desc .= " (unpaid)";
238 $self->{flags} & Crossfire::Protocol::F_MAGIC 223 $self->{flags} & F_MAGIC
239 and $desc .= " (magic)"; 224 and $desc .= " (magic)";
240 $self->{flags} & Crossfire::Protocol::F_CURSED 225 $self->{flags} & F_CURSED
241 and $desc .= " (cursed)"; 226 and $desc .= " (cursed)";
242 $self->{flags} & Crossfire::Protocol::F_DAMNED 227 $self->{flags} & F_DAMNED
243 and $desc .= " (damned)"; 228 and $desc .= " (damned)";
244 $self->{flags} & Crossfire::Protocol::F_LOCKED 229 $self->{flags} & F_LOCKED
245 and $desc .= " *"; 230 and $desc .= " *";
246 231
247 $desc 232 $desc
248} 233}
249 234
… …
266 251
267 if ($self->{container} == $::CONN->{player}{tag}) { 252 if ($self->{container} == $::CONN->{player}{tag}) {
268 $targ = $::CONN->{open_container}; 253 $targ = $::CONN->{open_container};
269 } 254 }
270 255
271 $::CONN->send ("move $targ $self->{tag} 0"); 256 $::CONN->send ("move $targ $self->{tag} 0")
257 if $targ || !($self->{flags} & F_LOCKED);
272 } elsif ($ev->{button} == 1) { 258 } elsif ($ev->{button} == 1) {
273 $::CONN->send ("examine $self->{tag}"); 259 $::CONN->send ("examine $self->{tag}");
274 } elsif ($ev->{button} == 2) { 260 } elsif ($ev->{button} == 2) {
275 $::CONN->send ("apply $self->{tag}"); 261 $::CONN->send ("apply $self->{tag}");
276 } elsif ($ev->{button} == 3) { 262 } elsif ($ev->{button} == 3) {
277 my @menu_items = ( 263 my @menu_items = (
278 ["examine", sub { $::CONN->send ("examine $self->{tag}") }], 264 ["examine", sub { $::CONN->send ("examine $self->{tag}") }],
279 ["mark", sub { $::CONN->send ("mark ". pack "N", $self->{tag}) }], 265 ["mark", sub { $::CONN->send ("mark ". pack "N", $self->{tag}) }],
280 ["apply", sub { $::CONN->send ("apply $self->{tag}") }], 266 ["apply", sub { $::CONN->send ("apply $self->{tag}") }],
281 ( 267 (
282 $self->{flags} & Crossfire::Protocol::F_LOCKED 268 $self->{flags} & F_LOCKED
283 ? ( 269 ? (
284 ["unlock", sub { $::CONN->send ("lock " . pack "CN", 0, $self->{tag}) }], 270 ["unlock", sub { $::CONN->send ("lock " . pack "CN", 0, $self->{tag}) }],
285 ) 271 )
286 : ( 272 : (
287 ["lock", sub { $::CONN->send ("lock " . pack "CN", 1, $self->{tag}) }], 273 ["lock", sub { $::CONN->send ("lock " . pack "CN", 1, $self->{tag}) }],
… …
304 . "</small>\n"; 290 . "</small>\n";
305 291
306 $self->{face_widget} ||= new CFClient::UI::Face 292 $self->{face_widget} ||= new CFClient::UI::Face
307 can_events => 1, 293 can_events => 1,
308 can_hover => 1, 294 can_hover => 1,
295 anim => $self->{anim},
296 animspeed => $self->{animspeed}, # TODO# must be set at creation time
309 connect_button_down => $button_cb, 297 on_button_down => $button_cb,
310 ; 298 ;
311 $self->{face_widget}{face} = $self->{face}; 299 $self->{face_widget}{face} = $self->{face};
312 $self->{face_widget}{anim} = $self->{anim}; 300 $self->{face_widget}{anim} = $self->{anim};
313 $self->{face_widget}{animspeed} = $self->{animespeed}; 301 $self->{face_widget}{animspeed} = $self->{animspeed};
314 $self->{face_widget}->set_tooltip ( 302 $self->{face_widget}->set_tooltip (
315 "<b>Face/Animation.</b>\n" 303 "<b>Face/Animation.</b>\n"
316 . "Item uses face #$self->{face}. " 304 . "Item uses face #$self->{face}. "
317 . ($self->{animspeed} ? "Item uses animation #$self->{anim} at " . (1 / $self->{animspeed}) . "fps. " : "Item is not animated. ") 305 . ($self->{animspeed} ? "Item uses animation #$self->{anim} at " . (1 / $self->{animspeed}) . "fps. " : "Item is not animated. ")
318 . "\n\n$tooltip_std" 306 . "\n\n$tooltip_std"
… …
320 308
321 $self->{desc_widget} ||= new CFClient::UI::Label 309 $self->{desc_widget} ||= new CFClient::UI::Label
322 can_events => 1, 310 can_events => 1,
323 can_hover => 1, 311 can_hover => 1,
324 ellipsise => 2, 312 ellipsise => 2,
325 xalign => 0, 313 align => -1,
326 connect_button_down => $button_cb, 314 on_button_down => $button_cb,
327 ; 315 ;
328 my $desc = CFClient::Item::desc_string $self; 316 my $desc = CFClient::Item::desc_string $self;
329 $self->{desc_widget}->set_text ($desc); 317 $self->{desc_widget}->set_text ($desc);
330 $self->{desc_widget}->set_tooltip ("<b>$desc</b>.\n$tooltip_std"); 318 $self->{desc_widget}->set_tooltip ("<b>$desc</b>.\n$tooltip_std");
331 319
332 $self->{weight_widget} ||= new CFClient::UI::Label 320 $self->{weight_widget} ||= new CFClient::UI::Label
333 can_events => 1, 321 can_events => 1,
334 can_hover => 1, 322 can_hover => 1,
335 ellipsise => 0, 323 ellipsise => 0,
336 xalign => 0.5, 324 align => 0,
337 connect_button_down => $button_cb, 325 on_button_down => $button_cb,
338 ; 326 ;
339 $self->{weight_widget}->set_text (CFClient::Item::weight_string $self); 327 $self->{weight_widget}->set_text (CFClient::Item::weight_string $self);
340 328
341 $self->{weight_widget}->set_tooltip ( 329 $self->{weight_widget}->set_tooltip (
342 "<b>Weight</b>.\n" 330 "<b>Weight</b>.\n"
… …
344 . ($self->{nrof} ? "You have $self->{nrof} of it. " : "Item cannot stack with others of it's kind. ") 332 . ($self->{nrof} ? "You have $self->{nrof} of it. " : "Item cannot stack with others of it's kind. ")
345 . "\n\n$tooltip_std" 333 . "\n\n$tooltip_std"
346 ); 334 );
347} 335}
348 336
349package CFClient::Texture; 337package CFClient::Binder;
350 338
351use strict; 339my @ALLOWED_MODIFIER_KEYS = (
340 (CFClient::SDLK_LSHIFT),
341 (CFClient::SDLK_LCTRL ),
342 (CFClient::SDLK_LALT ),
343 (CFClient::SDLK_LMETA ),
352 344
353use Scalar::Util; 345 (CFClient::SDLK_RSHIFT),
346 (CFClient::SDLK_RCTRL ),
347 (CFClient::SDLK_RALT ),
348 (CFClient::SDLK_RMETA ),
349);
354 350
355use CFClient::OpenGL; 351my %ALLOWED_MODIFIERS = (
352 (CFClient::KMOD_LSHIFT) => "LSHIFT",
353 (CFClient::KMOD_LCTRL ) => "LCTRL",
354 (CFClient::KMOD_LALT ) => "LALT",
355 (CFClient::KMOD_LMETA ) => "LMETA",
356 356
357my %TEXTURES; 357 (CFClient::KMOD_RSHIFT) => "RSHIFT",
358 (CFClient::KMOD_RCTRL ) => "RCTRL",
359 (CFClient::KMOD_RALT ) => "RALT",
360 (CFClient::KMOD_RMETA ) => "RMETA",
361);
358 362
359sub new { 363my %DIRECT_BIND_CHARS = map { $_ => 1 } qw/0 1 2 3 4 5 6 7 8 9/;
360 my ($class, %data) = @_; 364my @DIRECT_BIND_KEYS = (
365 CFClient::SDLK_F1,
366 CFClient::SDLK_F2,
367 CFClient::SDLK_F3,
368 CFClient::SDLK_F4,
369 CFClient::SDLK_F5,
370 CFClient::SDLK_F6,
371 CFClient::SDLK_F7,
372 CFClient::SDLK_F8,
373 CFClient::SDLK_F9,
374 CFClient::SDLK_F10,
375 CFClient::SDLK_F11,
376 CFClient::SDLK_F12,
377 CFClient::SDLK_F13,
378 CFClient::SDLK_F14,
379 CFClient::SDLK_F15,
380);
361 381
362 my $self = bless { 382# this binding dialog asks for a key-combo to be pressed
363 internalformat => GL_RGBA, 383# and if successful it calls the $cb with $mod and $sym as args.
364 format => GL_RGBA, 384sub open_binding_dialog {
365 type => GL_UNSIGNED_BYTE, 385 my ($cb) = @_;
366 %data,
367 }, $class;
368 386
369 Scalar::Util::weaken ($TEXTURES{$self+0} = $self); 387 my $w = new CFClient::UI::FancyFrame
388 title => "Bind Action",
389 x => "center",
390 y => "center";
370 391
371 $self->upload; 392 $w->add (my $vb = new CFClient::UI::VBox);
372 393 $vb->add (new CFClient::UI::Label
373 $self 394 text => "Press a modifier (CTRL, ALT and/or SHIFT) and a key."
374} 395 ."You can only bind 0-9 and F1-F15 without modifiers."
375
376sub new_from_image {
377 my ($class, $image, %arg) = @_;
378
379 $class->new (image => $image, %arg)
380}
381
382sub new_from_file {
383 my ($class, $path, %arg) = @_;
384
385 open my $fh, "<:raw", $path
386 or die "$path: $!";
387
388 local $/;
389 $class->new_from_image (<$fh>, %arg)
390}
391
392#sub new_from_surface {
393# my ($class, $surface) = @_;
394#
395# $surface->rgba;
396#
397# $class->new (
398# data => $surface->pixels,
399# w => $surface->width,
400# h => $surface->height,
401# )
402#}
403
404sub new_from_layout {
405 my ($class, $layout, %arg) = @_;
406
407 my ($w, $h, $data, $format, $internalformat) = $layout->render;
408
409 $class->new (
410 w => $w,
411 h => $h,
412 data => $data,
413 format => $format,
414 internalformat => $format,
415 type => GL_UNSIGNED_BYTE,
416 %arg,
417 ) 396 );
418} 397 $vb->add (my $entry = new CFClient::UI::Entry
398 text => "",
399 on_key_down => sub {
400 my ($entry, $ev) = @_;
419 401
420sub new_from_opengl { 402 my $mod = $ev->{mod};
421 my ($class, $w, $h, $cb) = @_; 403 my $sym = $ev->{sym};
422 404
423 $class->new (w => $w || 1, h => $h || 1, render_cb => $cb) 405 # XXX: This seems a little bit hackisch to me, but i have to ignore them
424} 406 if (grep { $_ == $sym } @ALLOWED_MODIFIER_KEYS) {
407 return;
408 }
425 409
426sub topot { 410 if ($mod == CFClient::KMOD_NONE
427 (grep $_ >= $_[0], 1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16384, 32768)[0] 411 and not $DIRECT_BIND_CHARS{chr ($ev->{unicode})}
428} 412 and not grep { $sym == $_ } @DIRECT_BIND_KEYS)
413 {
414 $::STATUSBOX->add (
415 "Can't bind key ".CFClient::SDL_GetKeyName ($sym)
416 ." directly without modifier! It would damage the completer handling."
417 );
418 return;
419 }
429 420
430sub upload { 421 $entry->focus_out;
431 my ($self) = @_;
432 422
433 return unless $GL_VERSION; 423 $cb->($mod, $sym);
434 424
435 my $data; 425 $w->destroy
436
437 if (exists $self->{data}) {
438 $data = $self->{data};
439
440 } elsif (exists $self->{render_cb}) {
441 glViewport 0, 0, $self->{w}, $self->{h};
442 glMatrixMode GL_PROJECTION;
443 glLoadIdentity;
444 glOrtho 0, $self->{w}, 0, $self->{h}, -10000, 10000;
445 glMatrixMode GL_MODELVIEW;
446 glLoadIdentity;
447 $self->{render_cb}->($self, $self->{w}, $self->{h});
448
449 } else {
450 ($self->{w}, $self->{h}, $data, $self->{internalformat}, $self->{format}, $self->{type})
451 = CFClient::load_image_inline $self->{image};
452 }
453
454 my ($tw, $th) = @$self{qw(w h)};
455
456 unless ($tw > 0 && $th > 0) {
457 $tw = $th = 1;
458 $data = "\x00" x 64;
459 }
460
461 $self->{minified} = [CFClient::average $tw, $th, $data]
462 if $self->{minify};
463
464 unless ($GL_NPOT) {
465 # TODO: does not work for zero-sized textures
466 $tw = topot $tw;
467 $th = topot $th;
468
469 if (($tw != $self->{w} || $th != $self->{h}) && defined $data) {
470 my $bpp = (length $data) / ($self->{w} * $self->{h});
471 $data = pack "(a" . ($tw * $bpp) . ")*",
472 unpack "(a" . ($self->{w} * $bpp) . ")*", $data;
473 $data .= ("\x00" x ($tw * $bpp)) x ($th - $self->{h});
474 } 426 });
475 }
476 427
477 $self->{s} = $self->{w} / $tw; 428 $entry->focus_in;
478 $self->{t} = $self->{h} / $th; 429 $w->show;
479
480 $self->{name} ||= glGenTexture;
481
482 glBindTexture GL_TEXTURE_2D, $self->{name};
483
484 glTexParameter GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP;
485 glTexParameter GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP;
486
487 if ($::FAST) {
488 glTexParameter GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST;
489 glTexParameter GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST;
490 } elsif ($self->{mipmap} && $GL_VERSION >= 1.4) {
491 # alternatively check for 0x8191
492 glTexParameter GL_TEXTURE_2D, GL_GENERATE_MIPMAP, 1;
493 glTexParameter GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR;
494 glTexParameter GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR_MIPMAP_LINEAR;
495 } else {
496 glTexParameter GL_TEXTURE_2D, GL_GENERATE_MIPMAP, $self->{mipmap};
497 glTexParameter GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR;
498 glTexParameter GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR;
499 }
500
501 glGetError;
502
503 if (defined $data) {
504 glTexImage2D GL_TEXTURE_2D, 0,
505 $self->{internalformat},
506 $tw, $th,
507 0,
508 $self->{format},
509 $self->{type},
510 $data;
511 CFClient::gl_check "uploading texture %dx%d if=%x f=%x t=%x",
512 $tw, $th, $self->{internalformat}, $self->{format}, $self->{type};
513 } else {
514 glCopyTexImage2D GL_TEXTURE_2D, 0,
515 $self->{internalformat},
516 0, 0,
517 $tw, $th,
518 0;
519 CFClient::gl_check "copying to texture %dx%d if=%x",
520 $tw, $th, $self->{internalformat};
521 }
522
523 glBindTexture GL_TEXTURE_2D, 0; # just to be on the safe side
524} 430}
525 431
526sub DESTROY { 432sub keycombo_to_name {
527 my ($self) = @_; 433 my ($mod, $sym) = @_;
528 434
529 delete $TEXTURES{$self+0}; 435 my $mods = join '+',
436 map { $ALLOWED_MODIFIERS{$_} }
437 grep { ($_ + 0) & ($mod + 0) }
438 keys %ALLOWED_MODIFIERS;
439 $mods .= "+" if $mods ne '';
530 440
531 glDeleteTexture delete $self->{name} 441 return $mods . CFClient::SDL_GetKeyName ($sym);
532 if $self->{name};
533}
534
535sub restore_state {
536 $_->upload
537 for values %TEXTURES;
538} 442}
539 443
5401; 4441;
541 445
542=back 446=back

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines