--- deliantra/Deliantra-Client/DC/UI.pm 2006/06/03 22:50:48 1.275 +++ deliantra/Deliantra-Client/DC/UI.pm 2006/06/06 09:19:28 1.295 @@ -5,6 +5,7 @@ use Scalar::Util (); use List::Util (); +use Event; use CFClient; use CFClient::Texture; @@ -18,32 +19,7 @@ our %WIDGET; # all widgets, weak-referenced -sub get_layout { - my $layout; - - for (grep { $_->{name} } values %WIDGET) { - my $win = $layout->{$_->{name}} = { }; - - $win->{x} = ($_->{x} + $_->{w} * 0.5) / $::WIDTH if $_->{x} =~ /^[0-9.]+$/; - $win->{y} = ($_->{y} + $_->{h} * 0.5) / $::HEIGHT if $_->{y} =~ /^[0-9.]+$/; - $win->{w} = $_->{w} / $::WIDTH if defined $_->{w}; - $win->{h} = $_->{h} / $::HEIGHT if defined $_->{h}; - - $win->{show} = $_->{visible} && $_->{is_toplevel}; - } - - $layout -} - -sub set_layout { - my ($layout) = @_; - - $LAYOUT = $layout; -} - -sub check_tooltip { - return if $ENV{CFPLUS_DEBUG} & 8; - +our $TOOLTIP_WATCHER = Event->idle (min => 1/60, cb => sub { if (!$GRAB) { for (my $widget = $HOVER; $widget; $widget = $widget->{parent}) { if (length $widget->{tooltip}) { @@ -52,6 +28,8 @@ $TOOLTIP->{owner} = $widget; + return if $ENV{CFPLUS_DEBUG} & 8; + my $tip = $widget->{tooltip}; $tip = $tip->($widget) if CODE:: eq ref $tip; @@ -67,6 +45,29 @@ $TOOLTIP->hide; delete $TOOLTIP->{owner}; +}); + +sub get_layout { + my $layout; + + for (grep { $_->{name} } values %WIDGET) { + my $win = $layout->{$_->{name}} = { }; + + $win->{x} = ($_->{x} + $_->{w} * 0.5) / $::WIDTH if $_->{x} =~ /^[0-9.]+$/; + $win->{y} = ($_->{y} + $_->{h} * 0.5) / $::HEIGHT if $_->{y} =~ /^[0-9.]+$/; + $win->{w} = $_->{w} / $::WIDTH if defined $_->{w}; + $win->{h} = $_->{h} / $::HEIGHT if defined $_->{h}; + + $win->{show} = $_->{visible} && $_->{is_toplevel}; + } + + $layout +} + +sub set_layout { + my ($layout) = @_; + + $LAYOUT = $layout; } # class methods for events @@ -90,7 +91,7 @@ $GRAB = $widget; $GRAB->update if $GRAB; - check_tooltip; + $TOOLTIP_WATCHER->cb->(); } $BUTTON_STATE |= 1 << ($ev->{button} - 1); @@ -115,7 +116,7 @@ $grab->update if $grab; $GRAB->update if $GRAB; - check_tooltip; + $TOOLTIP_WATCHER->cb->(); } } @@ -131,7 +132,7 @@ $hover->update if $hover && $hover->{can_hover}; $HOVER->update if $HOVER && $HOVER->{can_hover}; - check_tooltip; + $TOOLTIP_WATCHER->start; } $HOVER->emit (mouse_motion => $ev, $HOVER->coord2local ($x, $y)) @@ -279,7 +280,7 @@ undef $GRAB if $GRAB == $self; undef $HOVER if $HOVER == $self; - CFClient::UI::check_tooltip + $CFClient::UI::TOOLTIP_WATCHER->cb->() if $TOOLTIP->{owner} == $self; $self->focus_out; @@ -383,8 +384,10 @@ sub set_max_size { my ($self, $w, $h) = @_; - delete $self->{max_w}; $self->{max_w} = $w if $w; - delete $self->{max_h}; $self->{max_h} = $h if $h; + $self->{max_w} = int $w if defined $w; + $self->{max_h} = int $h if defined $h; + + $self->realloc; } sub set_tooltip { @@ -399,7 +402,7 @@ if ($CFClient::UI::TOOLTIP->{owner} == $self) { delete $CFClient::UI::TOOLTIP->{owner}; - CFClient::UI::check_tooltip; + $CFClient::UI::TOOLTIP_WATCHER->cb->(); } } @@ -550,20 +553,16 @@ glPushMatrix; glTranslate $self->{x}, $self->{y}, 0; - $self->_draw; - glPopMatrix; if ($self == $HOVER && $self->{can_hover}) { - my ($x, $y) = @$self{qw(x y)}; - - glColor 1, 0.8, 0.5, 0.2; + glColor 1*0.2, 0.8*0.2, 0.5*0.2, 0.2; glEnable GL_BLEND; - glBlendFunc GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA; + glBlendFunc GL_ONE, GL_ONE_MINUS_SRC_ALPHA; glBegin GL_QUADS; - glVertex $x , $y; - glVertex $x + $self->{w}, $y; - glVertex $x + $self->{w}, $y + $self->{h}; - glVertex $x , $y + $self->{h}; + glVertex 0 , 0; + glVertex $self->{w}, 0; + glVertex $self->{w}, $self->{h}; + glVertex 0 , $self->{h}; glEnd; glDisable GL_BLEND; } @@ -571,7 +570,7 @@ if ($ENV{CFPLUS_DEBUG} & 1) { glPushMatrix; glColor 1, 1, 0, 1; - glTranslate $self->{x} + 0.375, $self->{y} + 0.375; + glTranslate 0.375, 0.375; glBegin GL_LINE_LOOP; glVertex 0 , 0; glVertex $self->{w} - 1, 0; @@ -581,6 +580,9 @@ glPopMatrix; #CFClient::UI::Label->new (w => $self->{w}, h => $self->{h}, text => $self, fontsize => 0)->_draw; } + + $self->_draw; + glPopMatrix; } sub _draw { @@ -628,8 +630,8 @@ my ($w, $h) = @$self{qw(w h)}; glEnable GL_BLEND; - glBlendFunc GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA; - glColor @$color; + glBlendFunc GL_ONE, GL_ONE_MINUS_SRC_ALPHA; + glColor_premultiply @$color; glBegin GL_QUADS; glVertex 0 , 0; @@ -858,7 +860,7 @@ glEnable GL_TEXTURE_2D; glTexEnv GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE; - glColor 1, 1, 1, 1; + glColor 0, 0, 0, 1; $tex->draw_quad_alpha_premultiplied (0, 0, $w, $h); @@ -1037,8 +1039,8 @@ my ($w, $h) = @$self{qw(w h)}; glEnable GL_BLEND; - glBlendFunc GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA; - glColor @{ $self->{bg} }; + glBlendFunc GL_ONE, GL_ONE_MINUS_SRC_ALPHA; + glColor_premultiply @{ $self->{bg} }; glBegin GL_QUADS; glVertex 0 , 0; @@ -1162,8 +1164,8 @@ $self->{force_w} = $bw + $dx * ($mx ? -1 : 1); $self->{force_h} = $bh + $dy * ($my ? -1 : 1); - $self->realloc; $self->move_abs ($wx + $dx * $mx, $wy + $dy * $my); + $self->realloc; }; } elsif ($lr ^ $td) { @@ -1176,6 +1178,8 @@ ($x, $y) = ($ev->{x}, $ev->{y}); $self->move_abs ($bx + $x - $ox, $by + $y - $oy); + # HACK: the next line is required to enforce placement + $self->{parent}->size_allocate ($self->{parent}{w}, $self->{parent}{h}); }; } else { return 0; @@ -1537,6 +1541,13 @@ $self->SUPER::update; } +sub realloc { + my ($self) = @_; + + delete $self->{ox}; + $self->SUPER::realloc; +} + sub set_text { my ($self, $text) = @_; @@ -1546,6 +1557,7 @@ $self->{layout} = new CFClient::Layout if $self->{layout}->is_rgba; $self->{layout}->set_text ($text); + delete $self->{size_req}; $self->realloc; $self->update; } @@ -1561,6 +1573,7 @@ $self->{layout} = new CFClient::Layout $rgba if $self->{layout}->is_rgba != $rgba; $self->{layout}->set_markup ($markup); + delete $self->{size_req}; $self->realloc; $self->update; } @@ -1568,25 +1581,29 @@ sub size_request { my ($self) = @_; - $self->{layout}->set_font ($self->{font}) if $self->{font}; - $self->{layout}->set_width ($self->{max_w} || -1); - $self->{layout}->set_ellipsise ($self->{ellipsise}); - $self->{layout}->set_single_paragraph_mode ($self->{ellipsise}); - $self->{layout}->set_height ($self->{fontsize} * $::FONTSIZE); + $self->{size_req} ||= do { + $self->{layout}->set_font ($self->{font}) if $self->{font}; + $self->{layout}->set_width ($self->{max_w} || -1); + $self->{layout}->set_ellipsise ($self->{ellipsise}); + $self->{layout}->set_single_paragraph_mode ($self->{ellipsise}); + $self->{layout}->set_height ($self->{fontsize} * $::FONTSIZE); - my ($w, $h) = $self->{layout}->size; + my ($w, $h) = $self->{layout}->size; - if (exists $self->{template}) { - $self->{template}->set_font ($self->{font}) if $self->{font}; - $self->{template}->set_height ($self->{fontsize} * $::FONTSIZE); + if (exists $self->{template}) { + $self->{template}->set_font ($self->{font}) if $self->{font}; + $self->{template}->set_height ($self->{fontsize} * $::FONTSIZE); - my ($w2, $h2) = $self->{template}->size; + my ($w2, $h2) = $self->{template}->size; - $w = List::Util::max $w, $w2; - $h = List::Util::max $h, $h2; - } + $w = List::Util::max $w, $w2; + $h = List::Util::max $h, $h2; + } - ($w, $h) + [$w, $h] + }; + + @{ $self->{size_req} } } sub size_allocate { @@ -1607,6 +1624,14 @@ $self->realloc; } +sub reconfigure { + my ($self) = @_; + + delete $self->{size_req}; + + $self->SUPER::reconfigure; +} + sub _draw { my ($self) = @_; @@ -1634,13 +1659,17 @@ }; glEnable GL_TEXTURE_2D; - glTexEnv GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE; + + my $w = List::Util::min $self->{w} + 4, $tex->{w}; + my $h = List::Util::min $self->{h} + 2, $tex->{h}; if ($tex->{format} == GL_ALPHA) { + glTexEnv GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE; glColor @{$self->{fg}}; - $tex->draw_quad_alpha ($self->{ox}, $self->{oy}); + $tex->draw_quad_alpha ($self->{ox}, $self->{oy}, $w, $h); } else { - $tex->draw_quad_alpha_premultiplied ($self->{ox}, $self->{oy}); + glTexEnv GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE; + $tex->draw_quad_alpha_premultiplied ($self->{ox}, $self->{oy}, $w, $h); } glDisable GL_TEXTURE_2D; @@ -1667,6 +1696,7 @@ valign => 0, can_events => 1, #text => ... + #hidden => "*", @_ ) } @@ -1678,15 +1708,17 @@ return if $self->{text} eq $text; - delete $self->{texture}; - $self->{last_activity} = $::NOW; $self->{text} = $text; $text =~ s/./*/g if $self->{hidden}; $self->{layout}->set_text ("$text "); + delete $self->{size_req}; $self->_emit (changed => $self->{text}); + + $self->realloc; + $self->update; } sub set_text { @@ -1694,8 +1726,6 @@ $self->{cursor} = length $text; $self->_set_text ($text); - - $self->realloc; } sub get_text { @@ -1785,14 +1815,14 @@ local $self->{fg} = $self->{fg}; if ($FOCUS == $self) { - glColor @{$self->{active_bg}}; + glColor_premultiply @{$self->{active_bg}}; $self->{fg} = $self->{active_fg}; } else { - glColor @{$self->{bg}}; + glColor_premultiply @{$self->{bg}}; } glEnable GL_BLEND; - glBlendFunc GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA; + glBlendFunc GL_ONE, GL_ONE_MINUS_SRC_ALPHA; glBegin GL_QUADS; glVertex 0 , 0; glVertex 0 , $self->{h}; @@ -1912,11 +1942,7 @@ sub _draw { my ($self) = @_; - local $self->{fg} = $self->{fg}; - - if ($GRAB == $self) { - $self->{fg} = $self->{active_fg}; - } + local $self->{fg} = $GRAB == $self ? $self->{active_fg} : $self->{fg}; glEnable GL_TEXTURE_2D; glTexEnv GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE; @@ -2151,7 +2177,8 @@ my $h2 = $self->{h} * (1 - $ycut2); glEnable GL_BLEND; - glBlendFunc GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA; + glBlendFuncSeparate GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, + GL_ONE, GL_ONE_MINUS_SRC_ALPHA; glEnable GL_TEXTURE_2D; glTexEnv GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE; @@ -2282,8 +2309,10 @@ ($range, $self->{range}) = ($self->{range}, $range); - $self->update - if "@$range" ne "@{$self->{range}}"; + if ("@$range" ne "@{$self->{range}}") { + $self->update; + $self->set_value ($self->{range}[0]); + } } sub set_value { @@ -2452,6 +2481,7 @@ my $self = $class->SUPER::new ( fontsize => 1, can_events => 0, + indent => 0, #font => default_font @_, @@ -2484,6 +2514,7 @@ $self->{layout}->set_font ($self->{font}) if $self->{font}; $self->{layout}->set_height ($self->{fontsize} * $::FONTSIZE); $self->{layout}->set_width ($self->{children}[0]{w}); + $self->{layout}->set_indent ($self->{fontsize} * $::FONTSIZE * $self->{indent}); $self->reflow; } @@ -2495,6 +2526,7 @@ $layout->set_height ($self->{fontsize} * $::FONTSIZE); $layout->set_width ($self->{children}[0]{w} - $indent); + $layout->set_indent ($self->{fontsize} * $::FONTSIZE * $self->{indent}); $layout->set_markup ($text); $layout->size @@ -2543,7 +2575,7 @@ delete $self->{texture}; - $ROOT->on_post_alloc ($self, sub { + $ROOT->on_post_alloc ($self => sub { my ($W, $H) = @{$self->{children}[0]}{qw(w h)}; if (delete $self->{need_reflow}) { @@ -2556,6 +2588,7 @@ for (@{$self->{par}}) { if (1 || $_->[0] >= $W) { # TODO: works,but needs reconfigure etc. support $layout->set_width ($W - $_->[3]); + $layout->set_indent ($self->{fontsize} * $::FONTSIZE * $self->{indent}); $layout->set_markup ($_->[4]); my ($w, $h) = $layout->size; $_->[0] = $w + $_->[3]; @@ -2568,12 +2601,12 @@ $self->{height} = $height; $self->{children}[1]->set_range ([$height, 0, $height, $H, 1]); - + delete $self->{texture}; } $self->{texture} ||= new_from_opengl CFClient::Texture $W, $H, sub { - glClearColor 0.5, 0.5, 0.5, 0; + glClearColor 0, 0, 0, 0; glClear GL_COLOR_BUFFER_BIT; my $top = int $self->{children}[1]{range}[0]; @@ -2597,6 +2630,7 @@ if ($y0 < $y + $h && $y < $y1) { $layout->set_foreground (@{ $par->[2] }); $layout->set_width ($W - $par->[3]); + $layout->set_indent ($self->{fontsize} * $::FONTSIZE * $self->{indent}); $layout->set_markup ($par->[4]); my ($w, $h, $data, $format, $internalformat) = $layout->render; @@ -2618,8 +2652,8 @@ glEnable GL_TEXTURE_2D; glTexEnv GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE; - glColor 1, 1, 1, 1; - $self->{texture}->draw_quad_alpha (0, 0, $self->{children}[0]{w}, $self->{children}[0]{h}); + glColor 0, 0, 0, 1; + $self->{texture}->draw_quad_alpha_premultiplied (0, 0, $self->{children}[0]{w}, $self->{children}[0]{h}); glDisable GL_TEXTURE_2D; $self->{children}[1]->draw; @@ -2856,7 +2890,7 @@ if ($tex) { glEnable GL_TEXTURE_2D; glTexEnv GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE; - glColor 1, 1, 1, 1; + glColor 0, 0, 0, 1; $tex->draw_quad_alpha (0, 0, $self->{w}, $self->{h}); glDisable GL_TEXTURE_2D; } @@ -2899,14 +2933,15 @@ $self->add ($self->{vbox} = new CFClient::UI::VBox); for my $item (@{ $self->{items} }) { - my ($widget, $cb) = @$item; + my ($widget, $cb, $tooltip) = @$item; # handle various types of items, only text for now if (!ref $widget) { $widget = new CFClient::UI::Label can_hover => 1, can_events => 1, - text => $widget; + text => $widget, + tooltip => $tooltip } $self->{item}{$widget} = $item; @@ -3067,6 +3102,62 @@ ############################################################################# +package CFClient::UI::Combobox; + +use utf8; + +our @ISA = CFClient::UI::Button::; + +sub new { + my $class = shift; + + my $self = $class->SUPER::new ( + options => [], # [title, value, tooltip], ... + value => undef, + @_, + ); + + $self->_set_value ($self->{value}); + + $self +} + +sub button_down { + my ($self, $ev) = @_; + + my @menu_items; + + for (@{ $self->{options} }) { + my ($title, $value, $tooltip) = @$_; + + push @menu_items, [$tooltip, sub { $self->set_value ($value) }]; + } + + CFClient::UI::Menu->new (items => \@menu_items)->popup ($ev); +} + +sub _set_value { + my ($self, $value) = @_; + + my ($item) = grep $_->[1] eq $value, @{ $self->{options} } + or return; + + $self->{value} = $item->[1]; + $self->set_markup ("$item->[0] ⇓"); + $self->set_tooltip ($item->[2]); +} + +sub set_value { + my ($self, $value) = @_; + + return unless $self->{value} ne $value; + + $self->_set_value ($value); + $self->_emit (changed => $value); +} + +############################################################################# + package CFClient::UI::Statusbox; our @ISA = CFClient::UI::VBox::; @@ -3074,15 +3165,26 @@ sub new { my $class = shift; - $class->SUPER::new ( + my $self = $class->SUPER::new ( fontsize => 0.8, @_, - ) + ); + + Scalar::Util::weaken (my $this = $self); + + $self->{timer} = Event->timer (after => 1, interval => 1, cb => sub { $this->reorder }); + + $self } sub reorder { my ($self) = @_; - my $NOW = time; + my $NOW = Time::HiRes::time; + + # freeze display when hovering over any label + return if $CFClient::UI::TOOLTIP->{owner} + && grep $CFClient::UI::TOOLTIP->{owner} == $_->{label}, + values %{ $self->{item} }; while (my ($k, $v) = each %{ $self->{item} }) { delete $self->{item}{$k} if $v->{timeout} < $NOW; @@ -3095,11 +3197,13 @@ or $b->{id} <=> $a->{id} } values %{ $self->{item} }; + $self->{timer}->interval (1); + my $count = 10 + 1; for my $item (@items) { last unless --$count; - push @widgets, $item->{label} ||= do { + my $label = $item->{label} ||= do { # TODO: doesn't handle markup well (read as: at all) my $short = $item->{count} > 1 ? "$item->{count} × $item->{text}" @@ -3117,10 +3221,22 @@ tooltip_width => 0.67, fontsize => $item->{fontsize} || $self->{fontsize}, max_w => $::WIDTH * 0.44, - fg => $item->{fg}, + fg => [@{ $item->{fg} }], can_events => 1, can_hover => 1 }; + + if ((my $diff = $item->{timeout} - $NOW) < 2) { + $label->{fg}[3] = ($item->{fg}[3] || 1) * $diff / 2; + $label->update; + $label->set_max_size (undef, $label->{req_h} * $diff) + if $diff < 1; + $self->{timer}->interval (1/30); + } else { + $label->{fg}[3] = $item->{fg}[3] || 1; + } + + push @widgets, $label; } $self->clear; @@ -3135,7 +3251,7 @@ return unless $text; - my $timeout = time + ((delete $arg{timeout}) || 60); + my $timeout = (int time) + ((delete $arg{timeout}) || 60); my $group = exists $arg{group} ? $arg{group} : ++$self->{id}; @@ -3175,6 +3291,14 @@ $self->SUPER::reconfigure; } +sub DESTROY { + my ($self) = @_; + + $self->{timer}->cancel; + + $self->SUPER::DESTROY; +} + ############################################################################# package CFClient::UI::Inventory; @@ -3430,43 +3554,71 @@ ) } -# XXX: Do sorting? Argl... -sub add_spell { - my ($self, $spell) = @_; - $self->{spells}->{$spell->{name}} = $spell; +my @TOOLTIP_LVL = (align => 1, can_events => 1, can_hover => 1, tooltip => + "Level. Minimum level the caster needs in the associated skill to be able to attempt casting this spell."); +my @TOOLTIP_SP = (align => 1, can_events => 1, can_hover => 1, tooltip => + "Spell points / Grace points. Amount of spell or grace points used by each invocation."); +my @TOOLTIP_DMG = (align => 1, can_events => 1, can_hover => 1, tooltip => + "Damage. The amount of damage the spell deals when it hits."); - $self->add (0, $self->{tbl_idx}, new CFClient::UI::Face - face => $spell->{face}, - can_hover => 1, - can_events => 1, - tooltip => $spell->{message}); +sub rebuild_spell_list { + my ($self) = @_; - $self->add (1, $self->{tbl_idx}, new CFClient::UI::Label - text => $spell->{name}, - can_hover => 1, - can_events => 1, - tooltip => $spell->{message}, - expand => 1); + $CFClient::UI::ROOT->on_refresh ($self => sub { + $self->clear; + + $self->add (1, 0, new CFClient::UI::Label text => "Spell Name"); + $self->add (2, 0, new CFClient::UI::Label text => "Lvl" , @TOOLTIP_LVL); + $self->add (3, 0, new CFClient::UI::Label text => "Sp/Gp", @TOOLTIP_SP); + $self->add (4, 0, new CFClient::UI::Label text => "Dmg" , @TOOLTIP_DMG); + + my $row = 0; + + for (sort { $a cmp $b } keys %{ $self->{spell} }) { + my $spell = $self->{spell}{$_}; + + $row++; + + $self->add (0, $row, new CFClient::UI::Face + face => $spell->{face}, + can_hover => 1, + can_events => 1, + tooltip => $spell->{message}, + ); + + $self->add (1, $row, new CFClient::UI::Label + expand => 1, + text => $spell->{name}, + can_hover => 1, + can_events => 1, + tooltip => $spell->{message}, + ); - $self->add (2, $self->{tbl_idx}, new CFClient::UI::Label - text => (sprintf "lvl: %2d sp: %2d dmg: %2d", - $spell->{level}, ($spell->{mana} || $spell->{grace}), $spell->{damage}), - expand => 1); - - $self->add (3, $self->{tbl_idx}++, new CFClient::UI::Button - text => "bind to key", - on_activate => sub { $::BIND_EDITOR->do_quick_binding (["cast $spell->{name}"]) }); + $self->add (2, $row, new CFClient::UI::Label text => $spell->{level}, @TOOLTIP_LVL); + $self->add (3, $row, new CFClient::UI::Label text => $spell->{mana} || $spell->{grace}, @TOOLTIP_SP); + $self->add (4, $row, new CFClient::UI::Label text => $spell->{damage}, @TOOLTIP_DMG); + + # TODO: should be done via popup + $self->add (5, $row, new CFClient::UI::Button + text => "bind", + tooltip => "bind spell readying (cast command) to key", + on_activate => sub { $::BIND_EDITOR->do_quick_binding (["cast $spell->{name}"]) }, + ); + } + }); } -sub rebuild_spell_list { - my ($self) = @_; - $self->{tbl_idx} = 0; - $self->add_spell ($_) for values %{$self->{spells}}; +sub add_spell { + my ($self, $spell) = @_; + + $self->{spell}->{$spell->{name}} = $spell; + $self->rebuild_spell_list; } sub remove_spell { my ($self, $spell) = @_; - delete $self->{spells}->{$spell->{name}}; + + delete $self->{spell}->{$spell->{name}}; $self->rebuild_spell_list; } @@ -3476,6 +3628,8 @@ our @ISA = CFClient::UI::Container::; +use List::Util qw(min max); + use CFClient::OpenGL; sub new { @@ -3619,8 +3773,11 @@ my ($w, $h) = $widget->size_request; - $w = List::Util::max $widget->{min_w}, $w + $widget->{padding_x} * 2; - $h = List::Util::max $widget->{min_h}, $h + $widget->{padding_y} * 2; + $w = max $widget->{min_w}, $w + $widget->{padding_x} * 2; + $h = max $widget->{min_h}, $h + $widget->{padding_y} * 2; + + $w = min $widget->{max_w}, $w if exists $widget->{max_w}; + $h = min $widget->{max_h}, $h if exists $widget->{max_h}; $w = $widget->{force_w} if exists $widget->{force_w}; $h = $widget->{force_h} if exists $widget->{force_h};