--- deliantra/Deliantra-Client/bin/cfplus	2007/07/31 00:30:16	1.193
+++ deliantra/Deliantra-Client/bin/cfplus	2007/07/31 02:03:13	1.196
@@ -163,14 +163,15 @@
 
 our $SDL_MIXER;
 our $MUSIC_DEFAULT = "in_a_heartbeat.ogg";
-our @MUSIC_WANT;
+our $MUSIC_WANT; # arryref of ambient music
+our @MUSIC_HAVE; # ambient music we want now
 our $MUSIC_START;
 our $MUSIC_PLAYING_DATA;
 our $MUSIC_PLAYING_META;
 our $MUSIC_PLAYER;
 our $MUSIC_RESUME = 30; # resume music when players less than these many seconds before
 our @SOUNDS;       # event => file mapping
-our %AUDIO_CHUNKS; # audio files
+our %AUDIO_CHUNK;  # audio files
 
 our $ALT_ENTER_MESSAGE;
 our $STATUSBOX;
@@ -182,6 +183,171 @@
 
 our $PICKUP_CFG;
 
+#############################################################################
+#TODO: maybe move into own audio module...
+
+sub audio_channel_finished {
+   my ($channel) = @_;
+
+#   warn "channel $channel finished\n";#d#
+}
+
+our %AUDIO_PLAY;
+our %AUDIO_CHUNK;
+
+sub audio_sound_push($) {
+   my ($face) = @_;
+
+   if (my $chunk = $AUDIO_CHUNK{$face}) {
+      for (grep $_->[0] >= Event::time, @{(delete $AUDIO_PLAY{$face}) || []}) {
+         my (undef, $dx, $dy, $vol) = @$_;
+
+         my $channel = CFPlus::Channel::find;
+         $channel->volume ($vol * 128 / 255);
+         $dx = $dx / 10 * 255;
+         $channel->set_panning (255 - $dx, 255 + $dx);
+
+#         my $angle = $dx ? : $dx < 0 ? 
+#         my $distance = -$vol;
+#         $channel->set_position ($angle, $distance);
+
+         $chunk->play ($channel);
+      }
+   } else {
+      # sound_meta not set means data is in flight either way
+      my $meta = $CONN->{sound_meta}{$face}
+         or return;
+
+      # fetch from database
+      CFPlus::DB::get res_data => $meta->{name}, sub {
+         my $rwops = new CFPlus::RW $_[0];
+         my $chunk = new CFPlus::MixChunk $rwops;
+         $chunk->volume (($meta->{meta}{volume} || 1) * 128);
+         $AUDIO_CHUNK{$face} = $chunk;
+
+         audio_sound_push ($face);
+      };
+   }
+}
+
+sub audio_sound_play {
+   my ($face, $dx, $dy, $vol) = @_;
+
+   $SDL_MIXER
+      or return;
+
+   my $queue = $AUDIO_PLAY{$face} ||= [];
+   push @$queue, [Event::time + 0.2, $dx, $dy, $vol]; # delay sound by max. 0.2s
+   audio_sound_push $face
+      unless @$queue > 1;
+}
+
+sub audio_music_update_volume {
+   return unless $MUSIC_PLAYING_META;
+   my $volume = $MUSIC_PLAYING_META->{meta}{volume} || 1;
+   my $base   = $CFG->{bgm_volume};
+   CFPlus::MixMusic::volume $base * $volume * 128;
+}
+
+sub audio_music_push {
+   my @have =
+      grep $_,
+         map $CONN->{music_meta}{$_},
+            @$MUSIC_WANT;
+
+   if (@have) {
+      @MUSIC_HAVE = @have;
+      &audio_music_changed ();
+   }
+}
+
+sub audio_music_set_ambient {
+   my ($songs) = @_;
+
+   $MUSIC_WANT = $songs;
+
+   audio_music_push;
+}
+
+sub audio_music_start {
+   my $meta = $MUSIC_PLAYING_META;
+
+   CFPlus::DB::get res_data => $meta->{name}, sub {
+      return unless $SDL_MIXER;
+
+      # music might have changed...
+      $meta eq $MUSIC_PLAYING_META
+         or return &audio_music_start ();
+
+      audio_music_update_volume;
+
+      $MUSIC_PLAYING_DATA = \$_[0];
+
+      my $rwops = $meta->{path}
+         ? new_from_file CFPlus::RW $meta->{path}
+         : new CFPlus::RW $$MUSIC_PLAYING_DATA;
+
+      $MUSIC_PLAYER = new CFPlus::MixMusic $rwops
+         or ((warn CFPlus::Mix_GetError), return); # pretty fatal error
+
+      my $NOW = time;
+
+      if ($MUSIC_PLAYING_META->{stop_time} > $NOW - $MUSIC_RESUME) {
+         my $pos = $MUSIC_PLAYING_META->{stop_pos};
+         $MUSIC_PLAYER->fade_in_pos (0, 1000, $pos);
+         $MUSIC_START = time - $pos;
+      } else {
+         $MUSIC_PLAYER->play (0);
+         $MUSIC_START = time;
+      }
+
+      delete $MUSIC_PLAYING_META->{stop_time};
+      delete $MUSIC_PLAYING_META->{stop_pos};
+   }
+}
+
+sub audio_music_changed {
+   return unless $CFG->{bgm_enable};
+   return unless $SDL_MIXER;
+
+   # default MUSIC_HAVE == MUSIC_DEFAULT
+   @MUSIC_HAVE = { path => CFPlus::find_rcfile "music/$MUSIC_DEFAULT" } unless @MUSIC_HAVE;
+   
+   # if the currently playing song is acceptable, let it continue
+   return if $MUSIC_PLAYING_META
+             && grep $MUSIC_PLAYING_META == $_, @MUSIC_HAVE;
+
+   my $NOW = time;
+
+   if ($MUSIC_PLAYING_META) {
+      $MUSIC_PLAYING_META->{stop_time} = $NOW;
+      $MUSIC_PLAYING_META->{stop_pos}  = $NOW - $MUSIC_START;
+      CFPlus::MixMusic::fade_out 1000;
+   } else {
+      # sort by stop time, oldest first
+      @MUSIC_HAVE = sort { $a->{stop_time} <=> $b->{stop_time} } @MUSIC_HAVE;
+
+      # if the most recently-played piece played very recently,
+      # resume it, else choose the oldest piece for rotation.
+      $MUSIC_PLAYING_META =
+         $MUSIC_HAVE[-1]{stop_time} > $NOW - $MUSIC_RESUME
+            ? $MUSIC_HAVE[-1]
+            : $MUSIC_HAVE[0];
+
+      audio_music_start;
+   }
+}
+
+sub audio_music_finished {
+   undef $MUSIC_PLAYER;
+   undef $MUSIC_PLAYING_META;
+   undef $MUSIC_PLAYING_DATA;
+
+   audio_music_changed;
+}
+
+#############################################################################
+
 sub status {
    $STATUSBOX->add (CFPlus::asxml $_[0], pri => -10, group => "status", timeout => 10, fg => [1, 1, 0, 1]);
 }
@@ -483,7 +649,7 @@
    $SPELL_LIST->clear_spells;
    $CFPlus::UI::ROOT->emit (stop_game => ! ! $CONN);
 
-   &audio_music_set ([]);
+   &audio_music_set_ambient ([]);
 
    return unless $CONN;
 
@@ -650,7 +816,7 @@
    $hbox->add (new CFPlus::UI::Slider
       expand => 1, range => [$CFG->{bgm_volume}, 0, 1, 0, 1/128],
       tooltip => "The volume of the background music. Changes are instant.",
-      on_changed => sub { $CFG->{bgm_volume} = $_[1]; CFPlus::MixMusic::volume $_[1] * 128; 0 }
+      on_changed => sub { $CFG->{bgm_volume} = $_[1]; audio_music_update_volume; 0 }
    );
 
    $table->add_at (1, $row++, new CFPlus::UI::Button
@@ -1789,151 +1955,6 @@
    undef $SDL_ACTIVE;
 }
 
-sub audio_channel_finished {
-   my ($channel) = @_;
-
-#   warn "channel $channel finished\n";#d#
-}
-
-our %AUDIO_PLAY;
-our %AUDIO_CHUNK;
-
-sub audio_sound_push($) {
-   my ($face) = @_;
-
-   if (my $chunk = $AUDIO_CHUNK{$face}) {
-      for (grep $_->[0] >= Event::time, @{(delete $AUDIO_PLAY{$face}) || []}) {
-         my (undef, $dx, $dy, $vol) = @$_;
-
-         my $channel = $chunk->play
-            or return;
-
-         $channel->volume (128 + $vol);
-         $dx = $dx / 10 * 255;
-         $channel->set_panning ((min 255, 255 - $dx), (min 255, 255 + $dx));
-#         my $angle = $dx ? : $dx < 0 ? 
-#         my $distance = -$vol;
-#         $channel->set_position ($angle, $distance);
-      }
-   } else {
-      # sound_meta not set means data is in flight either way
-      my $meta = $CONN->{sound_meta}{$face}
-         or return;
-
-      # fetch from database
-      CFPlus::DB::get res_data => $meta->{name}, sub {
-         my $vol = $meta->{meta}{volume} || 1;
-         my $rwops = new CFPlus::RW $_[0];
-         my $chunk = new CFPlus::MixChunk $rwops;
-         $chunk->volume ($vol * 128);
-         $AUDIO_CHUNK{$face} = $chunk;
-
-         audio_sound_push ($face);
-      };
-   }
-}
-
-sub audio_sound_play {
-   my ($face, $dx, $dy, $vol) = @_;
-
-   $SDL_MIXER
-      or return;
-
-   my $queue = $AUDIO_PLAY{$face} ||= [];
-   push @$queue, [Event::time + 0.2, $dx, $dy, $vol]; # delay sound by max. 0.2s
-   audio_sound_push $face
-      unless @$queue > 1;
-}
-
-sub audio_music_set {
-   my ($songs) = @_;
-
-   my @want =
-      grep $_,
-         map $CONN->{music_meta}{$_},
-            @$songs;
-
-   if (@want) {
-      @MUSIC_WANT = @want;
-      &audio_music_changed ();
-   }
-}
-
-sub audio_music_start {
-   my $meta = $MUSIC_PLAYING_META;
-
-   CFPlus::DB::get res_data => $meta->{name}, sub {
-      return unless $SDL_MIXER;
-
-      # music might have changed...
-      $meta eq $MUSIC_PLAYING_META
-         or return &audio_music_start ();
-
-      $MUSIC_PLAYING_DATA = \$_[0];
-
-      my $rwops = $meta->{path}
-         ? new_from_file CFPlus::RW $meta->{path}
-         : new CFPlus::RW $$MUSIC_PLAYING_DATA;
-
-      $MUSIC_PLAYER = new CFPlus::MixMusic $rwops
-         or ((warn CFPlus::Mix_GetError), return); # pretty fatal error
-
-      my $NOW = time;
-
-      if ($MUSIC_PLAYING_META->{stop_time} > $NOW - $MUSIC_RESUME) {
-         my $pos = $MUSIC_PLAYING_META->{stop_pos};
-         $MUSIC_PLAYER->fade_in_pos (0, 1000, $pos);
-         $MUSIC_START = time - $pos;
-      } else {
-         $MUSIC_PLAYER->play (0);
-         $MUSIC_START = time;
-      }
-
-      delete $MUSIC_PLAYING_META->{stop_time};
-      delete $MUSIC_PLAYING_META->{stop_pos};
-   }
-}
-
-sub audio_music_changed {
-   return unless $CFG->{bgm_enable};
-   return unless $SDL_MIXER;
-
-   # default MUSIC_WANT == MUSIC_DEFAULT
-   @MUSIC_WANT = { path => CFPlus::find_rcfile "music/$MUSIC_DEFAULT" } unless @MUSIC_WANT;
-   
-   # if the currently playing song is acceptable, let it continue
-   return if $MUSIC_PLAYING_META
-             && grep $MUSIC_PLAYING_META == $_, @MUSIC_WANT;
-
-   my $NOW = time;
-
-   if ($MUSIC_PLAYING_META) {
-      $MUSIC_PLAYING_META->{stop_time} = $NOW;
-      $MUSIC_PLAYING_META->{stop_pos}  = $NOW - $MUSIC_START;
-      CFPlus::MixMusic::fade_out 1000;
-   } else {
-      # sort by stop time, oldest first
-      @MUSIC_WANT = sort { $a->{stop_time} <=> $b->{stop_time} } @MUSIC_WANT;
-
-      # if the most recently-played piece played very recently,
-      # resume it, else choose the oldest piece for rotation.
-      $MUSIC_PLAYING_META =
-         $MUSIC_WANT[-1]{stop_time} > $NOW - $MUSIC_RESUME
-            ? $MUSIC_WANT[-1]
-            : $MUSIC_WANT[0];
-
-      audio_music_start;
-   }
-}
-
-sub audio_music_finished {
-   undef $MUSIC_PLAYER;
-   undef $MUSIC_PLAYING_META;
-   undef $MUSIC_PLAYING_DATA;
-
-   audio_music_changed;
-}
-
 sub audio_init {
    if ($CFG->{audio_enable}) {
       $ENV{MIX_EFFECTSMAXSPEED} = 1;
@@ -1945,7 +1966,6 @@
       }
 
       CFPlus::Mix_AllocateChannels 16;
-      CFPlus::MixMusic::volume $CFG->{bgm_volume} * 128;
 
       audio_music_finished;
    } else {
@@ -1957,7 +1977,7 @@
    CFPlus::Mix_CloseAudio if $SDL_MIXER;
    undef $SDL_MIXER;
    @SOUNDS = ();
-   %AUDIO_CHUNKS = ();
+   %AUDIO_CHUNK = ();
 }
 
 my %animate_object;