[ViewVC] Diff of: cvs/deliantra/server/common/arch.C

Comparing deliantra/server/common/arch.C (file contents):
Revision 1.76 by root, Wed Apr 30 06:40:28 2008 UTC vs.
Revision 1.85 by root, Mon Sep 29 10:32:50 2008 UTC

 {
   shstr_cmp skill_cmp (skill);
   for_all_archetypes (at)
     if (at->skill == skill_cmp && (type == -1 || type == at->type))
-      return arch_to_object (at);
+      return at->instance ();
   return 0;
 }
 /* similiar to above - this returns the first archetype
  * - name: The name we're searching for (ex: "writing pen");
  * Return value:
  * - a corresponding object if found; a singularity object if not found.
  * Note by MSW - it appears that it takes the full name and keeps
  * shortening it until it finds a match.  I re-wrote this so that it
- * doesn't malloc it each time - not that this function is used much,
+ * doesn't allocate it each time - not that this function is used much,
  * but it otherwise had a big memory leak.
  */
 object *
 get_archetype_by_object_name (const char *name)
 {
   for (i = strlen (tmpname); i > 0; i--)
     {
       tmpname[i] = 0;
       if (archetype *at = find_archetype_by_object_name (tmpname))
-        return arch_to_object (at);
+        return at->instance ();
     }
   return create_singularity (name);
 }
     return new_head;
   }
 fail:
   for (auto (p, parts.begin ()); p != parts.end (); ++p)
-    (*p)->destroy (true);
+    (*p)->destroy ();
   return 0;
 }
 void
       if (at->refcnt_cnt () > 1) // all arches have ONE refcount from their object
         ++idx;
       else
         {
           LOG (llevDebug, "garbage collect arch %s", at->debug_desc ());
-          assert (at->arch == at); // verify that refcnt == 1 is truely valid
+          assert (at->arch == at); // verify that refcnt == 1 is truly valid
           allarch.erase (idx);
+          // break chain
+          for (object *op = at->head_ (); op; )
+            {
+              object *next = op->more;
+              op->head = 0;
+              op->more = 0;
+              op = next;
+            }
+          at->destroy ();
           at->arch = 0;
-          at->more = 0;
-          at->destroy ();
         }
     }
   while (--cnt);
 }
-/*
- * Creates and returns a new object which is a copy of the given archetype.
- * This function returns NULL on failure.
- */
 object *
-arch_to_object (archetype *at)
+archetype::instance ()
 {
-  if (!at)
-    {
-      LOG (llevError, "Couldn't find archetype.\n");
-      return 0;
-    }
-  object *op = at->clone ();
+  object *op = clone ();
-  op->arch = at;
   op->instantiate ();
   return op;
-}
-object *
-archetype::instance ()
-{
-  return arch_to_object (this);
 }
 /*
  * Creates an object.  This function is called by get_archetype()
  * if it fails to find the appropriate archetype.
   LOG (llevError | logBacktrace, "FATAL: creating singularity for '%s'.\n", name);
   if (!strcmp (name, "bug"))
     abort ();
-  char buf[MAX_BUF];
-  sprintf (buf, "bug, please report (%s)", name);
-  object *op = get_archetype ("bug");
+  object *op = archetype::get (shstr_bug);
-  op->name = op->name_pl = buf;
+  op->name = op->name_pl = format ("bug, please report (missing archetype %s)", name);
   return op;
 }
 /*
  * object containing a copy of the archetype.
  */
 object *
 get_archetype (const char *name)
 {
+  return archetype::get (name);
+}
+object *
+archetype::get (const char *name)
+{
-  archetype *at = archetype::find (name);
+  archetype *at = find (name);
   if (!at)
     return create_singularity (name);
-  return arch_to_object (at);
+  return at->instance ();
-}
-object *
-archetype::get (const char *name)
-{
-  return get_archetype (name);
 }
 /*
  * Returns the first archetype using the given type.
  * Used in treasure-generation.
  * Used in treasure-generation.
  */
 object *
 clone_arch (int type)
 {
-  archetype *at;
+  archetype *at = type_to_archetype (type);
-  if ((at = type_to_archetype (type)) == NULL)
+  if (!at)
     {
       LOG (llevError, "Can't clone archetype %d\n", type);
       return 0;
     }
-  object *op = at->clone ();
+  return at->instance ();
-  op->instantiate ();
-  return op;
 }
 /*
  * member: make instance from class
  */
 {
   object *op, *prev = 0, *head = 0;
   while (at)
     {
-      op = arch_to_object (at);
+      op = at->instance ();
       op->x = at->x;
       op->y = at->y;
       if (head)

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/arch.C (file contents): Revision 1.76 by root, Wed Apr 30 06:40:28 2008 UTC vs. Revision 1.85 by root, Mon Sep 29 10:32:50 2008 UTC

Diff Legend

Comparing deliantra/server/common/arch.C (file contents):
Revision 1.76 by root, Wed Apr 30 06:40:28 2008 UTC vs.
Revision 1.85 by root, Mon Sep 29 10:32:50 2008 UTC