[ViewVC] Diff of: cvs/deliantra/server/common/item.C

Comparing deliantra/server/common/item.C (file contents):
Revision 1.54 by elmex, Mon Jan 12 00:17:22 2009 UTC vs.
Revision 1.55 by root, Wed Sep 16 22:50:50 2009 UTC

         enc -= 2;
       else if (op->path_repelled & (1 << i))
         enc--;
     }
-  if (QUERY_FLAG (op, FLAG_LIFESAVE))
+  if (op->flag [FLAG_LIFESAVE    ]) enc += 5;
-    enc += 5;
+  if (op->flag [FLAG_REFL_SPELL  ]) enc += 3;
-  if (QUERY_FLAG (op, FLAG_REFL_SPELL))
+  if (op->flag [FLAG_REFL_MISSILE]) enc += 2;
-    enc += 3;
+  if (op->flag [FLAG_XRAYS       ]) enc += 2;
-  if (QUERY_FLAG (op, FLAG_REFL_MISSILE))
+  if (op->flag [FLAG_STEALTH     ]) enc += 1;
-    enc += 2;
+  if (op->flag [FLAG_SEE_IN_DARK ]) enc += 1;
-  if (QUERY_FLAG (op, FLAG_STEALTH))
+  if (op->flag [FLAG_MAKE_INVIS  ]) enc += 1;
-    enc += 1;
-  if (QUERY_FLAG (op, FLAG_XRAYS))
-    enc += 2;
-  if (QUERY_FLAG (op, FLAG_SEE_IN_DARK))
-    enc += 1;
-  if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
-    enc += 1;
   return get_power_from_ench (enc);
 }
 /* returns the typedata that has a number equal to itemtype, if there
  * isn't one, returns NULL */
 const typedata *
 get_typedata (int itemtype)
 {
-  int i;
-  for (i = 0; i < item_types_size; i++)
+  for (int i = 0; i < item_types_size; i++)
     if (item_types[i].number == itemtype)
       return &item_types[i];
   return NULL;
 }
  * isn't one, return the plural name that matches, if there still isn't
  * one return NULL */
 const typedata *
 get_typedata_by_name (const char *name)
 {
-  int i;
-  for (i = 0; i < item_types_size; i++)
+  for (int i = 0; i < item_types_size; i++)
     if (!strcmp (item_types[i].name, name))
       return &item_types[i];
-  for (i = 0; i < item_types_size; i++)
+  for (int i = 0; i < item_types_size; i++)
     if (!strcmp (item_types[i].name_pl, name))
       {
         LOG (llevInfo,
              "get_typedata_by_name: I have been sent the plural %s, the singular form %s is prefered\n", name, item_types[i].name);
         return &item_types[i];
       }
-  return NULL;
+  return 0;
 }
 /* describe_resistance generates the visible naming for resistances.
  * returns a static array of the description.  This can return
  * a big buffer.
             sprintf (buf1, "%s %d\n", resist_plus[tmpvar], op->resist[tmpvar]);
           strcat (buf, buf1);
         }
     }
   return buf;
 }
 /*
  * query_weight(object) returns a character pointer to a static buffer
  * containing the text-representation of the weight of the given object.
  * The buffer will be overwritten by the next call to query_weight().
+ *
+ * Seems to be used only by unimportant stuff. Remove?
  */
 const char *
 query_weight (const object *op)
 {
   static char buf[10];
       return buf;
     }
   if (i < 21)
     return levelnumbers[i];
   if (!(i % 10))
     return levelnumbers_10[i / 10];
   strcpy (buf, numbers_10[i / 10]);
   strcat (buf, levelnumbers[i % 10]);
 }
 /*
  * query_short_name(object) is similar to query_name, but doesn't
  * contain any information about object status (worn/cursed/etc.)
+ *
+ * It is sometimes used when printing messages, so should fit well into a sentence.
  */
 const char *
 query_short_name (const object *op)
 {
   if (!op->name)
  * you can make several calls to query_name before the bufs start getting
  * overwritten.  This may be a bad thing (it may be easier to assume the value
  * returned is good forever.)  However, it makes printing statements that
  * use several names much easier (don't need to store them to temp variables.)
  *
+ * It is used extensively within messages, so should return only a prose
+ * and short description of the item.
  */
 const char *
 query_name (const object *op)
 {
   int len = 0;
    */
   if (QUERY_FLAG (op, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (op, FLAG_IDENTIFIED))
     buf << " (magic)";
 #if 0
-  /* item_power will be returned in desribe_item - it shouldn't really
+  /* item_power will be returned in describe_item - it shouldn't really
    * be returned in the name.
    */
   if (op->item_power)
     sprintf (buf[use_buf] + strlen (buf[use_buf]), "(item_power %+d)", op->item_power);
  * of the given object.  The buffer will be overwritten at the next
  * call to query_base_name().   This is a lot like query_name, but we
  * don't include the item count or item status.  Used for inventory sorting
  * and sending to client.
  * If plural is set, we generate the plural name of this.
+ *
+ * It is sometimes used to display messages, and usually only used to match stuff,
+ * so maybe this function should be removed.
  */
 const char *
 query_base_name (const object *op, int plural)
 {
   if ((!plural && !op->name) || (plural && !op->name_pl))
  * wouldn't need to use the SEE_INVISIBLE flag to know it is
  * a dragon player examining food.  Could have things like
  * a dwarven axe, in which the full abilities are only known to
  * dwarves, etc.
  *
- * This function is really much more complicated than it should
- * be, because different objects have different meanings
- * for the same field (eg, wands use 'food' for charges).  This
- * means these special cases need to be worked out.
- *
  * Add 'owner' who is the person examining this object.
  * owner can be null if no one is being associated with this
  * item (eg, debug dump or the like)
  */
 const char *
 void
 examine (object *op, object *tmp)
 {
   std::string info = tmp->describe (op);
   op->contr->infobox (MSG_CHANNEL ("examine"), info.c_str ());
 }
 /*
  * inventory prints object's inventory. If inv==NULL then print player's

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/item.C (file contents): Revision 1.54 by elmex, Mon Jan 12 00:17:22 2009 UTC vs. Revision 1.55 by root, Wed Sep 16 22:50:50 2009 UTC

Diff Legend

Comparing deliantra/server/common/item.C (file contents):
Revision 1.54 by elmex, Mon Jan 12 00:17:22 2009 UTC vs.
Revision 1.55 by root, Wed Sep 16 22:50:50 2009 UTC