--- deliantra/server/common/loader.C 2006/09/15 00:31:36 1.18 +++ deliantra/server/common/loader.C 2007/02/10 01:52:25 1.57 @@ -1,36 +1,195 @@ /* - CrossFire, A Multiplayer game for X-windows - - Copyright (C) 2002 Mark Wedel & Crossfire Development Team - Copyright (C) 1992 Frank Tore Johansen - - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 2 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. - - The authors can be reached via e-mail at -*/ + * CrossFire, A Multiplayer game for X-windows + * + * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team + * Copyright (C) 2002 Mark Wedel & Crossfire Development Team + * Copyright (C) 1992 Frank Tore Johansen + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + * + * The authors can be reached via e-mail at + */ /* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. sub/add_weight will transcend the environment updating the carrying variable. */ - #include #include -#include #include +///////////////////////////////////////////////////////////////////////////// + +loader_base::~loader_base () +{ +} + +// the base class warns about and skips everything +archetype * +loader_base::get_arch (const char *name) +{ + LOG (llevError, "%s: found archetype definition '%s', which is not allowed in files of this type.\n", + filename, name); + + return new archetype; +} + +object * +loader_base::get_object (const char *name) +{ + LOG (llevError, "%s: found object definition '%s', which is not allowed in files of this type.\n", + filename, name); + + return object::create (); +} + +player * +loader_base::get_player () +{ + LOG (llevError, "%s: found player definition, which is not allowed in files of this type.\n", + filename); + + return player::create (); +} + +region * +loader_base::get_region (const char *name) +{ + LOG (llevError, "%s: found region definition '%s', which is not allowed in files of this type.\n", + filename, name); + + return new region; +} + +facetile * +loader_base::get_face (const char *name) +{ + LOG (llevError, "%s: found face definition '%s', which is not allowed in files of this type.\n", + filename, name); + + return new facetile; +} + +treasurelist * +loader_base::get_treasure (const char *name, bool one) +{ + LOG (llevError, "%s: found treasure definition '%s', which is not allowed in files of this type.\n", + filename, name); + + return new treasurelist;//D +} + +animation * +loader_base::get_animation (const char *name) +{ + LOG (llevError, "%s: found animation definition '%s', which is not allowed in files of this type.\n", + filename, name); + + return new animation; +} + +void +loader_base::put_arch (archetype *arch) +{ + delete arch; +} + +void +loader_base::put_object (object *op) +{ + op->destroy (); +} + +void +loader_base::put_player (player *pl) +{ + delete pl; +} + +void +loader_base::put_region (region *region) +{ + delete region; +} + +void +loader_base::put_face (facetile *face) +{ + delete face; +} + +void +loader_base::put_treasure (treasurelist *treasure) +{ + delete treasure; +} + +void +loader_base::put_animation (animation *anim) +{ + delete anim; +} + +///////////////////////////////////////////////////////////////////////////// + +bool loader_base::parse (object_thawer &thawer) +{ + for (;;) + { + keyword kw = thawer.get_kv (); + + switch (kw) + { + case KW_region: + { + region *rgn = get_region (thawer.get_str ()); + + if (!parse_region (thawer, rgn)) + { + delete rgn; + return false; + } + + put_region (rgn); + } + break; + + case KW_EOF: + return true; + + default: + if (!thawer.parse_error (kw, "resource file")) + return false; + } + } +} + +bool loader_base::load (const char *filename) +{ + this->filename = filename; + + object_thawer fp (filename); + + if (!fp) + return false; + + return parse (fp); +} + +///////////////////////////////////////////////////////////////////////////// + /* Maps the MOVE_* values to names */ static const char *const move_name[] = { "walk", "fly_low", "fly_high", "swim", "boat", NULL }; @@ -264,11 +423,9 @@ static void check_loaded_object (object *op) { - int ip; - - /* We do some specialized handling to handle legacy cases of name_pl. + /* We do some specialised handling to handle legacy cases of name_pl. * If the object doesn't have a name_pl, we just use the object name - - * this isn't perfect (things won't be properly pluralized), but works to + * this isn't perfect (things won't be properly pluralised), but works to * that degree (5 heart is still quite understandable). But the case we * also have to catch is if this object is not using the normal name for * the object. In that case, we also want to use the loaded name. @@ -276,19 +433,20 @@ * information (appear as just 'hearts' and not 'goblins heart') */ if (op->arch && op->name != op->arch->clone.name && op->name_pl == op->arch->clone.name_pl) - op->name_pl = NULL; + op->name_pl = 0; if (!op->name_pl) op->name_pl = op->name; /* objects now have a materialname. try to patch it in */ - if (!(IS_WEAPON (op) && op->level > 0)) + if (!(op->is_weapon () && op->level > 0)) { if (op->map != NULL) set_materialname (op, op->map->difficulty, NULL); else set_materialname (op, 5, NULL); } + /* only do these when program is first run - a bit * excessive to do this at every run - most of this is * really just to catch any errors - program will still run, but @@ -297,25 +455,22 @@ if ((op->type == WEAPON || op->type == BOW) && arch_init) { if (!op->skill) - { - LOG (llevError, "Weapon %s lacks a skill.\n", op->debug_desc ()); - } + LOG (llevError, "Weapon %s lacks a skill.\n", op->debug_desc ()); else if ((!strcmp (op->skill, "one handed weapons") && op->body_info[1] != -1) || (!strcmp (op->skill, "two handed weapons") && op->body_info[1] != -2)) - { - LOG (llevError, "weapon %s arm usage does not match skill: %d, %s\n", op->debug_desc (), op->body_info[1], &op->skill); - } + LOG (llevError, "weapon %s arm usage does not match skill: %d, %s\n", op->debug_desc (), op->body_info[1], &op->skill); } /* We changed last_heal to gen_sp_armour, which is what it * really does for many objects. Need to catch any in maps * that may have an old value. */ - if ((op->type == WEAPON) || - (op->type == ARMOUR) || (op->type == HELMET) || - (op->type == SHIELD) || (op->type == RING) || - (op->type == BOOTS) || (op->type == GLOVES) || - (op->type == AMULET) || (op->type == GIRDLE) || (op->type == BRACERS) || (op->type == CLOAK)) + if (op->type == WEAPON + || op->type == ARMOUR || op->type == HELMET + || op->type == SHIELD || op->type == RING + || op->type == BOOTS || op->type == GLOVES + || op->type == AMULET || op->type == GIRDLE + || op->type == BRACERS || op->type == CLOAK) { if (op->last_heal) { @@ -323,19 +478,18 @@ op->gen_sp_armour = op->last_heal; op->last_heal = 0; } - if (editor) - ip = 0; - else - ip = calc_item_power (op, 0); + + int ip = calc_item_power (op, 0); + /* Legacy objects from before item power was in the game */ if (!op->item_power && ip) { if (ip > 3) - { - LOG (llevDebug, "Object %s had no item power, using %d\n", op->debug_desc (), ip); - } + LOG (llevDebug, "Object %s had no item power, using %d\n", op->debug_desc (), ip); + op->item_power = ip; } + /* Check for possibly bogus values. Has to meet both these criteria - * something that has item_power 1 is probably just fine if our calculated * value is 1 or 2 - these values are small enough that hard to be precise. @@ -343,32 +497,26 @@ * but not the second one. */ if (ip > 2 * op->item_power && ip > (op->item_power + 3)) - { - LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", op->debug_desc (), ip, op->item_power); - } - + LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", op->debug_desc (), ip, op->item_power); } + /* Old spellcasting object - need to load in the appropiate object */ if ((op->type == ROD || op->type == WAND || op->type == SCROLL || op->type == HORN || op->type == FIREWALL || /* POTIONS and ALTARS don't always cast spells, but if they do, update them */ ((op->type == POTION || op->type == ALTAR) && op->stats.sp)) && !op->inv && !arch_init) { - object *tmp; - /* Fireall is bizarre in that spell type was stored in dam. Rest are 'normal' * in that spell was stored in sp. */ - tmp = get_archetype (spell_mapping[op->type == FIREWALL ? op->stats.dam : op->stats.sp]); + object *tmp = get_archetype (spell_mapping[op->type == FIREWALL ? op->stats.dam : op->stats.sp]); insert_ob_in_ob (tmp, op); op->randomitems = NULL; /* So another spell isn't created for this object */ } - /* spellbooks & runes use slaying. But not to arch name, but to spell name */ + /* spellbooks & runes use slaying. But not to arch name, but to spell name */ if ((op->type == SPELLBOOK || op->type == RUNE) && op->slaying && !op->inv && !arch_init) { - object *tmp; - - tmp = get_archetype_by_object_name (op->slaying); + object *tmp = get_archetype_by_object_name (op->slaying); insert_ob_in_ob (tmp, op); op->randomitems = NULL; /* So another spell isn't created for this object */ /* without this, value is all screwed up */ @@ -378,7 +526,10 @@ if (QUERY_FLAG (op, FLAG_MONSTER)) { if (op->stats.hp > op->stats.maxhp) - LOG (llevDebug, "Monster %s has hp set higher than maxhp (%d>%d)\n", op->debug_desc (), op->stats.hp, op->stats.maxhp); + { + LOG (llevDebug, "Monster %s has hp set higher than maxhp (%d>%d)\n", op->debug_desc (), op->stats.hp, op->stats.maxhp); + op->stats.maxhp = op->stats.hp; + } /* The archs just need to be updated for this */ if (op->move_type == 0) @@ -411,9 +562,7 @@ op->stats.maxhp = 0; } else - { - op->move_type = MOVE_WALK; - } + op->move_type = MOVE_WALK; } } @@ -490,7 +639,7 @@ CLEAR_FLAG (op, flag) \ int -parse_object (object *op, object_thawer & thawer, int map_flags) +parse_object (object *op, object_thawer &thawer, int map_flags) { bool ismore = 0; object *op_inv = op->inv; @@ -505,7 +654,7 @@ case KW_object: thawer.get (op->name); - if (op->arch != NULL) + if (op->arch) op->arch->name = op->name; break; @@ -554,15 +703,21 @@ object *tmp; - if (arch != NULL) + if (arch) tmp = arch_to_object (arch); else { - tmp = get_object (); + tmp = object::create (); /* record the name of the broken object */ + //TODO: but do not log??? tmp->name = str; } + // decativate the object we, as we are still going + // to read the speed value. Objects should be activated + // when the map, object or player is completly loaded. + tmp->deactivate (); + parse_object (tmp, thawer, map_flags); if (tmp->arch) @@ -595,7 +750,7 @@ else { LOG (llevDebug, "Discarding object without arch: %s\n", tmp->name ? (const char *) tmp->name : "(null)"); - free_object (tmp); + tmp->destroy (); } } else @@ -603,8 +758,12 @@ /* This is the actual archetype definition then */ op->arch = archetype::find (str); - if (op->arch != NULL) - copy_object (&op->arch->clone, op); + if (op->arch) + { + op->arch->clone.copy_to (op); + // copy_to activates, this should be fixed properly + op->deactivate (); + } else if (!arch_init) /* record the name of the broken object */ op->name = str; @@ -618,20 +777,13 @@ case KW_animation: { - const char *str = thawer.get_str (); + CLEAR_FLAG (op, FLAG_ANIMATE); + op->animation_id = 0; - if (!str) - { - op->animation_id = 0; - CLEAR_FLAG (op, FLAG_ANIMATE); - } - else - { - op->animation_id = find_animation (str); - SET_FLAG (op, FLAG_ANIMATE); - } + const char *str = thawer.get_str (); + if (str && (op->animation_id = find_animation (str))) + SET_FLAG (op, FLAG_ANIMATE); } - break; case KW_last_heal: thawer.get (op->last_heal); break; @@ -644,13 +796,9 @@ thawer.get (op->speed); //TODO: maybe do in check_object - if (!(map_flags & MAP_STYLE)) - { - if (op->speed < 0) - op->speed_left = op->speed_left - RANDOM () % 100 / 100.0; - - update_ob_speed (op); - } + // removed check for style maps + if (op->speed < 0) + op->speed_left = op->speed_left - rndm (); break; @@ -710,7 +858,7 @@ case KW_magic: thawer.get (op->magic); break; case KW_state: thawer.get (op->state); break; case KW_move_slow_penalty: thawer.get (op->move_slow_penalty); break; - case KW_material: thawer.get (op->material); break; + case KW_material: thawer.get (op->materials); break; //TODO: nuke case KW_materialname: thawer.get (op->materialname); break; /* These are the new values */ @@ -814,21 +962,21 @@ break; case KW_friendly: - GET_FLAG (op, FLAG_FRIENDLY); - //TODO: move to check_object or so - if (op->type != PLAYER && QUERY_FLAG (op, FLAG_FRIENDLY)) - add_friendly_object (op); + if (thawer.get_sint32 ()) + if (op->type != PLAYER) + add_friendly_object (op); + break; case KW_monster: GET_FLAG (op, FLAG_MONSTER); break; case KW_neutral: GET_FLAG (op, FLAG_NEUTRAL); break; case KW_no_attack: GET_FLAG (op, FLAG_NO_ATTACK); break; case KW_no_damage: GET_FLAG (op, FLAG_NO_DAMAGE); break; + case KW_obj_original: GET_FLAG (op, FLAG_OBJ_ORIGINAL); break; case KW_generator: GET_FLAG (op, FLAG_GENERATOR); break; case KW_use_content_on_gen: GET_FLAG (op, FLAG_CONTENT_ON_GEN); break; case KW_is_thrown: GET_FLAG (op, FLAG_IS_THROWN); break; case KW_auto_apply: GET_FLAG (op, FLAG_AUTO_APPLY); break; - case KW_treasure: GET_FLAG (op, FLAG_TREASURE); break; case KW_see_invisible: GET_FLAG (op, FLAG_SEE_INVISIBLE); break; case KW_can_roll: GET_FLAG (op, FLAG_CAN_ROLL); break; case KW_overlay_floor: GET_FLAG (op, FLAG_OVERLAY_FLOOR); break; @@ -866,6 +1014,7 @@ case KW_can_use_weapon: GET_FLAG (op, FLAG_USE_WEAPON); break; case KW_can_use_ring: GET_FLAG (op, FLAG_USE_RING); break; case KW_has_ready_bow: GET_FLAG (op, FLAG_READY_BOW); break; + case KW_has_ready_range: GET_FLAG (op, FLAG_READY_RANGE); break; case KW_xrays: GET_FLAG (op, FLAG_XRAYS); break; case KW_is_floor: GET_FLAG (op, FLAG_IS_FLOOR); break; case KW_lifesave: GET_FLAG (op, FLAG_LIFESAVE); break; @@ -904,6 +1053,7 @@ case KW_one_hit: GET_FLAG (op, FLAG_ONE_HIT); break; case KW_berserk: GET_FLAG (op, FLAG_BERSERK); break; case KW_is_buildable: GET_FLAG (op, FLAG_IS_BUILDABLE); break; + case KW_destroy_on_death: GET_FLAG (op, FLAG_DESTROY_ON_DEATH); break; case KW_armour: thawer.get (op->resist[ATNR_PHYSICAL]); break; case KW_resist_physical: thawer.get (op->resist[ATNR_PHYSICAL]); break; @@ -980,33 +1130,29 @@ case KW_randomitems: op->randomitems = find_treasurelist (thawer.get_str ()); + //if (!op->randomitems) + // LOG (llevError, "%s uses unknown randomitems '%s'.\n", op->debug_desc (), thawer.get_str ()); break; case KW_msg: - { - thawer.get_ml (KW_endmsg, op->msg); - //TODO: allow longer messages - if (strlen (op->msg) >= HUGE_BUF) - { - LOG (llevDebug, "\n\tError message length >= %d: %d\n>%.80s<\n", HUGE_BUF, strlen (op->msg), &op->msg); - op->msg = "ERROR, please report: string too long, winged.\n"; - } - } + thawer.get_ml (KW_endmsg, op->msg); + //TODO: allow longer messages + if (strlen (op->msg) >= HUGE_BUF) + { + LOG (llevDebug, "\tError message length >= %d: %d\n>%.80s<\n", HUGE_BUF, strlen (op->msg), &op->msg); + op->msg = "ERROR, please report: string too long, winged.\n"; + } break; case KW_lore: - { - shstr msgbuf; - - thawer.get_ml (KW_endlore, op->lore); - //TODO: allow longer messages - /* Just print a warning so we can be reasonably safe - * about not overflowing the buffer. - */ - if (strlen (op->lore) > (HUGE_BUF / 2)) - LOG (llevDebug, "\n\tWarning lore length > %d (max allowed=%d): %d\n>%.80s<\n", - HUGE_BUF / 2, HUGE_BUF, strlen (op->lore), &op->lore); - } + thawer.get_ml (KW_endlore, op->lore); + //TODO: allow longer messages + /* Just print a warning so we can be reasonably safe + * about not overflowing the buffer. + */ + if (strlen (op->lore) > (HUGE_BUF / 2)) + LOG (llevDebug, "\tWarning lore length > %d (max allowed=%d): %d\n>%.80s<\n", + HUGE_BUF / 2, HUGE_BUF, strlen (op->lore), &op->lore); break; case KW_editable: @@ -1033,19 +1179,13 @@ return LL_EOF; case KW_ERROR: - set_ob_key_value (op, thawer.line, thawer.last_value, true); - //printf ("addkv(%s,%s)\n", thawer.line, thawer.get_str());//D - - //TODO: skip line, ugly, factor parsing better - if (thawer.last_value) - thawer.line = thawer.last_value; - - thawer.line += strlen (thawer.line) + 1; - + set_ob_key_value (op, thawer.last_keyword, thawer.last_value, true); + //fprintf (stderr, "addkv(%s,%s)\n", thawer.last_keyword, thawer.last_value);//D break; default: - LOG (llevError, "UNSUPPORTED KEYWORD IN MAP: \"%s\", bug in normaliser. skipping.\n", keyword_str[kw]); + if (!thawer.parse_error (kw, "object", op->name)) + return false; break; } } @@ -1065,14 +1205,14 @@ * LO_NOREAD (3): Reset the buffers, but don't read from it. (op can be null) * */ - int -load_object (object_thawer & fp, object *op, int map_flags) +load_object (object_thawer &fp, object *op, int map_flags) { + coroapi::cede_every (1000); // cede once in a while + return parse_object (op, fp, map_flags); } - /* This takes a buffer, scans it for variables, and sets those variables * as appropriate in op. * @@ -1082,65 +1222,11 @@ int set_variable (object *op, char *buf) { - return 0; -#if 0 - int retval; - object_thawer thawer (0); + object_thawer thawer (buf, (AV *)0); - strcpy (msgbuf, ""); - strcpy (lorebuf, ""); - retval = parse_object (op, thawer, 0); - yy_switch_to_buffer (yycurbuf); - yy_delete_buffer (yybufstate); - yy_pop_state (); - return retval; -#endif + return parse_object (op, thawer, 0); } -/* This array equates the FLAG_ values with the V_ values. Use -1 to - * put gaps in the array that should not be processed. - * The order matches the order of the define values in 'define.h'. - */ - -/* This is a list of pointers that correspond to the FLAG_.. values. - * This is a simple 1:1 mapping - if FLAG_FRIENDLY is 15, then - * the 15'th element of this array should match that name. - * If an entry is NULL, that is a flag not to loaded/saved. - */ -static const char *const flag_names[NUM_FLAGS + 1] = { - "alive", "wiz", NULL, NULL, "was_wiz", "applied", "unpaid", - "can_use_shield", "no_pick", NULL /* walk_on */ , NULL /* no_pass */ , /* 10 */ - "is_animated", NULL /* slow_move */ , - NULL /* flying */ , "monster", "friendly", "generator", - "is_thrown", "auto_apply", "treasure", "player sold", /* 20 */ - "see_invisible", "can_roll", "overlay_floor", - "is_turnable", NULL /* walk_off */ , NULL /* fly_on */ , - NULL /*fly_off */ , "is_used_up", "identified", "reflecting", /* 30 */ - "changing", "splitting", "hitback", "startequip", - "blocksview", "undead", "scared", "unaggressive", - "reflect_missile", "reflect_spell", /* 40 */ - "no_magic", "no_fix_player", "is_lightable", "tear_down", - "run_away", NULL /*pass_thru */ , NULL /*can_pass_thru */ , - "pick_up", "unique", "no_drop", /* 50 */ - NULL /* wizcast */ , "can_cast_spell", "can_use_scroll", "can_use_range", - "can_use_bow", "can_use_armour", "can_use_weapon", - "can_use_ring", "has_ready_range", "has_ready_bow", /* 60 */ - "xrays", NULL, "is_floor", "lifesave", "no_strength", "sleep", - "stand_still", "random_move", "only_attack", "confused", /* 70 */ - "stealth", NULL, NULL, "cursed", "damned", - "see_anywhere", "known_magical", "known_cursed", - "can_use_skill", "been_applied", /* 80 */ - "has_ready_scroll", "can_use_rod", NULL, - "can_use_horn", "make_invisible", "inv_locked", "is_wooded", - "is_hilly", "has_ready_skill", "has_ready_weapon", /* 90 */ - "no_skill_ident", "is_blind", "can_see_in_dark", "is_cauldron", - "is_dust", "no_steal", "one_hit", NULL, "berserk", "neutral", /* 100 */ - "no_attack", "no_damage", NULL, NULL, "activate_on_push", - "activate_on_release", "is_water", "use_content_on_gen", NULL, "is_buildable", /* 110 */ - NULL -}; - - /* * Initialises the array of variable-names. Needed before any * objects can be loaded. Called by init_library(). @@ -1206,23 +1292,161 @@ void put (object_freezer &f, object *op, object *tmp) { + static const keyword resist_save[NROFATTACKS] = { +# define def(uc, lc, name, plus, change) KW_resist_ ## lc, +# include "attackinc.h" +# undef def + }; + + /* This is a list of keywords that correspond to the FLAG_.. values. + * This is a simple 1:1 mapping - if FLAG_FRIENDLY is 15, then + * the 15'th element of this array should match that name. + * If an entry is NULL, that is a flag not to loaded/saved. + */ + static const keyword flag_names [NUM_FLAGS] = { + KW_alive, + KW_wiz, + KW_NULL, + KW_NULL, + KW_was_wiz, + KW_applied, + KW_unpaid, + KW_can_use_shield, + KW_no_pick, + KW_NULL, // walk_on + KW_NULL, // no_pass + /* 10 */ + KW_is_animated, + KW_NULL, // slow_move + KW_NULL, // flying + KW_monster, + KW_friendly, + KW_generator, + KW_is_thrown, + KW_auto_apply, + KW_NULL, // was KW_treasure + KW_player_sold, + /* 20 */ + KW_see_invisible, + KW_can_roll, + KW_overlay_floor, + KW_is_turnable, + KW_NULL, // walk_off + KW_NULL, // fly_on + KW_NULL, // fly_off + KW_is_used_up, + KW_identified, + KW_reflecting, + /* 30 */ + KW_changing, + KW_splitting, + KW_hitback, + KW_startequip, + KW_blocksview, + KW_undead, + KW_scared, + KW_unaggressive, + KW_reflect_missile, + KW_reflect_spell, + /* 40 */ + KW_no_magic, + KW_no_fix_player, + KW_is_lightable, + KW_tear_down, + KW_run_away, + KW_NULL, // pass_thru + KW_NULL, // an_pass_thru + KW_pick_up, + KW_unique, + KW_no_drop, + /* 50 */ + KW_NULL, // wizcast + KW_can_cast_spell, + KW_can_use_scroll, + KW_can_use_range, + KW_can_use_bow, + KW_can_use_armour, + KW_can_use_weapon, + KW_can_use_ring, + KW_has_ready_range, + KW_has_ready_bow, + /* 60 */ + KW_xrays, + KW_NULL, + KW_is_floor, + KW_lifesave, + KW_no_strength, + KW_sleep, + KW_stand_still, + KW_random_move, + KW_only_attack, + KW_confused, + /* 70 */ + KW_stealth, + KW_NULL, + KW_NULL, + KW_cursed, + KW_damned, + KW_see_anywhere, + KW_known_magical, + KW_known_cursed, + KW_can_use_skill, + KW_been_applied, + /* 80 */ + KW_has_ready_scroll, + KW_can_use_rod, + KW_NULL, + KW_can_use_horn, + KW_make_invisible, + KW_inv_locked, + KW_is_wooded, + KW_is_hilly, + KW_has_ready_skill, + KW_has_ready_weapon, + /* 90 */ + KW_no_skill_ident, + KW_is_blind, + KW_can_see_in_dark, + KW_is_cauldron, + KW_NULL, + KW_no_steal, + KW_one_hit, + KW_NULL, + KW_berserk, + KW_neutral, + /* 100 */ + KW_no_attack, + KW_no_damage, + KW_obj_original, + KW_NULL, + KW_activate_on_push, + KW_activate_on_release, + KW_is_water, + KW_use_content_on_gen, + KW_NULL, + KW_is_buildable, + /* 110 */ + KW_destroy_on_death, + KW_NULL, + }; + int i; /* This saves the key/value lists. We do it first so that any * keys that match field names will be overwritten by the loader. */ - for (key_value *my_field = op->key_values; my_field != NULL; my_field = my_field->next) + for (key_value *my_field = op->key_values; my_field; my_field = my_field->next) { /* Find the field in the opposing member. */ key_value *arch_field = get_ob_key_link (tmp, my_field->key); /* If there's no partnering field, or it's got a different value, save our field. */ - if (arch_field == NULL || my_field->value != arch_field->value) + if (!arch_field || my_field->value != arch_field->value) f.put (my_field->key, my_field->value); } /* We don't need to worry about the arch's extra fields - they - * will get taken care of the copy_object function. + * will get taken care of the copy_to method. */ { @@ -1249,9 +1473,6 @@ CMP_OUT (other_arch); CMP_OUT (face); - if (!op->face || !op->face->name) - printf ("ERRFACE<%s,%s, face %p,%p, fname%s>\n", &tmp->name, &op->name, tmp->face, op->face, op->face ? &op->face->name : ""); //D - if (op->animation_id != tmp->animation_id) if (op->animation_id) { @@ -1308,7 +1529,7 @@ CMP_OUT (path_attuned); CMP_OUT (path_repelled); CMP_OUT (path_denied); - CMP_OUT (material); + CMP_OUT2 (material, materials);//TODO: nuke CMP_OUT (materialname); CMP_OUT (value); CMP_OUT (carrying); @@ -1352,10 +1573,10 @@ CMP_OUT (move_slow); CMP_OUT (move_slow_penalty); - if (!COMPARE_FLAGS (op, tmp)) + if (op->flag != tmp->flag) for (i = 0; i <= NUM_FLAGS; i++) - if (flag_names[i] && (QUERY_FLAG (op, i) != QUERY_FLAG (tmp, i))) - f.put (flag_names[i], QUERY_FLAG (op, i) ? "1" : "0"); + if (flag_names [i] && op->flag [i] != tmp->flag [i]) + f.put (flag_names [i], op->flag [i] ? "1" : "0"); /* Save body locations */ for (i = 0; i < NUM_BODY_LOCATIONS; i++) @@ -1367,16 +1588,10 @@ * Dumps all variables in an object to a file. * If bit 0 of flag is set, unpaid objects will be saved. As of now, * the only place this is not set is when saving the player. - * If bit 1 of flag is set, don't remove the object after save. As of now, - * all of the callers are setting this. */ - void -save_object (object_freezer & fp, object *op, int flag) +save_object (object_freezer &fp, object *op, int flag) { - archetype *at; - object *tmp, *old; - /* Even if the object does have an owner, it would seem that we should * still save it. */ @@ -1384,48 +1599,20 @@ return; /* If it is unpaid and we don't want to save those, just return. */ - if (!(flag & 1) && (QUERY_FLAG (op, FLAG_UNPAID))) + if (!(flag & 1) && op->flag [FLAG_UNPAID]) return; - if ((at = op->arch) == NULL) - at = empty_archetype; + archetype *at = op->arch ? (archetype *)op->arch : empty_archetype; fp.put (KW_arch, at->name); - put (fp, op, &at->clone); /* Eneq(@csd.uu.se): Added this to allow containers being saved with contents */ - old = NULL; - - if (flag & 2) - for (tmp = op->inv; tmp != NULL; tmp = tmp->below) - save_object (fp, tmp, flag); - else - /* Slightly different logic because tmp/op will be removed by - * the save_object we call. So we just keep looking at op->inv - * until there is nothing left. In theory, the variable old - * should not be needed, as recursive loops shouldn't happen. - */ - while ((tmp = op->inv) != NULL) - { - if (old == tmp) - { - LOG (llevError, " Recursive loop in inventory\n"); - break; - } - - save_object (fp, tmp, flag); - old = tmp; - } - - if (!(flag & 2)) - { - remove_ob (op); - free_object (op); - } + for (object *tmp = op->inv; tmp; tmp = tmp->below) + save_object (fp, tmp, flag); fp.put (op); - fprintf (fp, "end\n"); + fp.put (KW_end); }