--- deliantra/server/common/loader.C 2008/08/31 15:49:13 1.118 +++ deliantra/server/common/loader.C 2008/09/29 10:32:50 1.123 @@ -387,7 +387,8 @@ #endif } - /* Old spellcasting object - need to load in the appropiate object */ + /* old style spellcasting object (pretty common) - need to load in the appropiate object */ + /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */ if ((type == ROD || type == WAND || type == SCROLL @@ -397,16 +398,17 @@ || ((type == POTION || type == ALTAR) && stats.sp)) // watchout: sp = 0 is still magic bullet. && !inv && !loading_arch - && !randomitems) // by elmex: not _any_ rod or horn we find on a map, which has randomitems is an old spellcasting - // object. For instance lythanders pipe got it's spell in the treasurelist in the randomitems, - // same goes for normal rods. + && stats.sp) // watchout: old magic bullet stuff directly on the map is going to break here! + // TODO: at least one watchout-comments is redundant - investigate/remove { + // TODO: fix firewall object on map /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal' * in that spell was stored in sp. */ - LOG (llevError, "old spellcasting object found: %s", debug_desc ()); + //LOG (llevError, "old spellcasting object found: %s", debug_desc ()); object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]); insert_ob_in_ob (tmp, this); + randomitems = 0; } /* spellbooks & runes use slaying. But not to arch name, but to spell name */ @@ -560,11 +562,10 @@ case KW_tag: f.get_ornull (tag); break; case KW_arch: - { - object *tmp = object::read (f); - tmp->deactivate (); - + if (object *tmp = object::read (f)) { + tmp->deactivate (); + // was: insert_ob_in_ob (tmp, op); // but manually adding it can improve map loading times a lot // also, appending instead of prepending keeps the @@ -591,7 +592,9 @@ tmp->env = this; op_inv = tmp; } - } + else + LOG (llevError, "ERROR: couldn't load inventory object, file corrupted?\n"); + continue; case KW_other_arch: @@ -1058,7 +1061,7 @@ if (!op->parse_kv (f)) { - op->destroy (true); + op->destroy (); return 0; }