--- deliantra/server/common/loader.C 2009/11/29 09:41:27 1.150 +++ deliantra/server/common/loader.C 2011/05/07 17:14:41 1.170 @@ -1,9 +1,9 @@ /* * This file is part of Deliantra, the Roguelike Realtime MMORPG. * - * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team - * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team - * Copyright (©) 1992,2007 Frank Tore Johansen + * Copyright (©) 2005,2006,2007,2008,2009,2010,2011 Marc Alexander Lehmann / Robin Redeker / the Deliantra team + * Copyright (©) 2002 Mark Wedel & Crossfire Development Team + * Copyright (©) 1992 Frank Tore Johansen * * Deliantra is free software: you can redistribute it and/or modify it under * the terms of the Affero GNU General Public License as published by the @@ -23,7 +23,6 @@ */ #include -#include #include ///////////////////////////////////////////////////////////////////////////// @@ -268,6 +267,7 @@ switch (type) { + case RANGED: case BOW: case WAND: case ROD: @@ -397,7 +397,7 @@ #endif } - /* old style spellcasting object (pretty common) - need to load in the appropiate object */ + /* old style spellcasting object (pretty common) - need to load in the appropriate object */ /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */ if ((type == ROD || type == WAND @@ -416,7 +416,7 @@ * in that spell was stored in sp. */ //LOG (llevError, "old spellcasting object found: %s", debug_desc ()); - object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]); + object *tmp = archetype::get (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]); insert_ob_in_ob (tmp, this); randomitems = 0; } @@ -432,7 +432,7 @@ value = arch->value * inv->value; } - if (QUERY_FLAG (this, FLAG_MONSTER)) + if (this->flag [FLAG_MONSTER]) { if (stats.hp > stats.maxhp) { @@ -445,7 +445,7 @@ move_type = MOVE_WALK; } - if ((QUERY_FLAG (this, FLAG_GENERATOR) && QUERY_FLAG (this, FLAG_CONTENT_ON_GEN)) || type == CREATOR || type == CONVERTER) + if ((this->flag [FLAG_GENERATOR] && this->flag [FLAG_CONTENT_ON_GEN]) || type == CREATOR || type == CONVERTER) /* Object will duplicate it's content as part of the * generation process. To do this, we must flag inventory * so it remains unevaluated concerning the randomitems and @@ -525,7 +525,7 @@ str++; } - for (const flagstr *f = move_flags; f < move_flags + sizeof (move_flags) / sizeof (move_flags [0]); ++f) + for (const flagstr *f = move_flags; f < move_flags + array_length (move_flags); ++f) { if (!strcmp (f->name, str)) { @@ -552,7 +552,7 @@ object::parse_kv (object_thawer &f) { object *op_inv = inv; - key_value *last_kv = key_values; + key_value *last_kv = kv.first; for (;;) { @@ -591,8 +591,8 @@ // also, appending instead of prepending keeps the // save ordering the same between repeated load/saves. // and finally we do not want any funny effects - CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL); - CLEAR_FLAG (tmp, FLAG_REMOVED); + tmp->clr_flag (FLAG_OBJ_ORIGINAL); + tmp->clr_flag (FLAG_REMOVED); if (!op_inv) { @@ -635,11 +635,11 @@ case KW_animation: { - CLEAR_FLAG (this, FLAG_ANIMATE); + this->clr_flag (FLAG_ANIMATE); animation_id = 0; if (f.has_value () && (animation_id = find_animation (f.get_str ()))) - SET_FLAG (this, FLAG_ANIMATE); //TODO: should not be forced to true here + this->set_flag (FLAG_ANIMATE); //TODO: should not be forced to true here } break; @@ -739,14 +739,7 @@ case KW_state: f.get (state); break; case KW_move_slow_penalty: f.get (move_slow_penalty); break; case KW_material: f.get (materials); break; //TODO: nuke - - case KW_materialname: - { - shstr sh; - f.get (sh); - material = name_to_material (sh); - } - break; + case KW_materialname: f.get (material); break; /* These are the new values */ case KW_move_block: set_move (move_block, f); break; @@ -756,79 +749,16 @@ case KW_move_off: set_move (move_off , f); break; case KW_move_slow: set_move (move_slow , f); break; - /* These are all legacy - any new objects should use the move_ .. values */ - case KW_no_pass: - { - if (f.get_sint32 ()) - move_block = MOVE_ALL; - else - move_block = 0; - } - - break; - - /* These are all legacy - any new objects should use the move_ .. values */ - case KW_walk_on: - { - if (f.get_sint32 ()) - move_on |= MOVE_WALK; - else - move_on &= ~MOVE_WALK; - } - - break; - - /* These are all legacy - any new objects should use the move_ .. values */ - case KW_walk_off: - { - if (f.get_sint32 ()) - move_off |= MOVE_WALK; - else - move_off &= ~MOVE_WALK; - } - break; - - /* These are all legacy - any new objects should use the move_ .. values */ - case KW_fly_on: - { - if (f.get_sint32 ()) - move_on |= MOVE_FLY_LOW; - else - move_on &= ~MOVE_FLY_LOW; - } - break; - - /* These are all legacy - any new objects should use the move_ .. values */ - case KW_fly_off: - { - if (f.get_sint32 ()) - move_off |= MOVE_FLY_LOW; - else - move_off &= ~MOVE_FLY_LOW; - } - break; - //TODO: remove these after converting archetypes case KW_can_use_wand: GET_FLAG (this, FLAG_USE_RANGE); break; - /* These are all legacy - any new objects should use the move_ .. values */ - case KW_flying: - { - if (f.get_sint32 ()) - move_type |= MOVE_FLY_LOW; - else - move_type &= ~MOVE_FLY_LOW; - } - break; - - case KW_identified: GET_FLAG (this, FLAG_IDENTIFIED); //TODO: move to check_object or so - if (QUERY_FLAG (this, FLAG_IDENTIFIED)) - CLEAR_FLAG (this, FLAG_KNOWN_MAGICAL); + if (this->flag [FLAG_IDENTIFIED]) + this->clr_flag (FLAG_KNOWN_MAGICAL); break; @@ -927,6 +857,7 @@ case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break; case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break; case KW_random_speed: GET_FLAG (this, FLAG_RANDOM_SPEED); break; + case KW_is_quad: GET_FLAG (this, FLAG_IS_QUAD); break; case KW_armour: f.get (resist[ATNR_PHYSICAL]); break; case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break; @@ -1048,27 +979,9 @@ return true; case KW_ERROR: - // append as key value pair (do not use kv_set as it prepends) - // we also do not even try to find old values, duplicate keys stay duplicate - { - key_value *kv = new key_value; - - kv->next = 0; - kv->key = shstr (f.kw_str); - kv->value = shstr (f.value); - - if (!last_kv) - key_values = last_kv = kv; - else - { - while (last_kv->next) - last_kv = last_kv->next; - - last_kv->next = kv; - last_kv = kv; - } - } - //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D + // we do not even try to find old values, duplicate keys stay duplicate + // the list gets reversed after loading + kv.add (shstr (f.kw_str), shstr (f.value)); break; default: @@ -1090,7 +1003,7 @@ if (!arch) { - LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ()); + LOG (llevError, "object referring to nonexistent archetype '%s'.\n", f.get_str ()); arch = archetype::find (shstr_earthwall); } @@ -1109,6 +1022,10 @@ return 0; } + // the loader reverses the ordering of kv-pairs, so we reverse it again after loading + // that greatly simplifies the loading code. + op->kv.reverse (); + op->post_load_check (); return op; } @@ -1122,7 +1039,7 @@ int set_variable (object *op, char *buf) { - object_thawer f (buf, (AV *)0); + object_thawer f (format ("%s\nend", buf), (AV *)0); return op->parse_kv (f); } @@ -1284,8 +1201,8 @@ /* This saves the key/value lists. We do it first so that any * keys that match field names will be overwritten by the loader. */ - for (key_value *kv = op->key_values; kv; kv = kv->next) - if (!arch->key_values || arch->kv (kv->key) != kv->value) + for (key_value *kv = op->kv.first; kv; kv = kv->next) + if (arch->kv.empty () || arch->kv [kv->key] != kv->value) f.put (kv->key, kv->value); if (op->uuid) @@ -1343,7 +1260,8 @@ CMP_OUT (custom_name); if (object *owner = op->owner) - f.put (KW(owner), static_cast(owner->ref ())); + if (const char *ref = owner->ref ()) + f.put (KW(owner), ref); // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved @@ -1453,6 +1371,7 @@ object::flags_t diff = (op->flag ^ arch->flag) & flagmask; +#if stdcpp // we need gcc, sorry if (diff [FLAG_OBJ_ORIGINAL]) f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? CS(1) : CS(0)); @@ -1463,11 +1382,16 @@ for (int i = 0; i < NUM_FLAGS; i++) if (expect_false (diff [i])) f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0)); +#else + // use sgi extensions + for (int i = diff._Find_first (); i < diff.size (); i = diff._Find_next (i)) + f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0)); +#endif // save body locations. gcc's memcmp does an abysmal job when used for (int i = 0; i < NUM_BODY_LOCATIONS; i++) if (expect_false (op->slot[i].info != arch->slot[i].info)) - f.put (body_locations[i].save_name, op->slot[i].info); + f.put (body_locations[i].kw, op->slot[i].info); } /* @@ -1509,6 +1433,8 @@ for (;;) { + coroapi::cede_to_tick (); + switch (f.kw) { case KW_region: