ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/loader.C
(Generate patch)

Comparing deliantra/server/common/loader.C (file contents):
Revision 1.83 by root, Sat May 19 00:08:11 2007 UTC vs.
Revision 1.139 by root, Sun Nov 8 22:28:10 2009 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
21 * 21 *
22 * The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 23 */
24
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying
27 variable. */
28 24
29#include <global.h> 25#include <global.h>
30#include <loader.h> 26#include <loader.h>
31#include <sproto.h> 27#include <sproto.h>
32 28
33///////////////////////////////////////////////////////////////////////////// 29/////////////////////////////////////////////////////////////////////////////
30
31extern archetype *loading_arch;
32
33//+GPL
34 34
35/* This table is only necessary to convert objects that existed before the 35/* This table is only necessary to convert objects that existed before the
36 * spell object conversion to the new object. It was not practical 36 * spell object conversion to the new object. It was not practical
37 * to go through every mapping looking for every potion, rod, wand, etc 37 * to go through every mapping looking for every potion, rod, wand, etc
38 * that had a sp set and update to the new value. So this maps the 38 * that had a sp set and update to the new value. So this maps the
168 "spell_magic_drain", /* 122 */ 168 "spell_magic_drain", /* 122 */
169 "spell_counterspell", /* 123 */ 169 "spell_counterspell", /* 123 */
170 "spell_disarm", /* 124 */ 170 "spell_disarm", /* 124 */
171 "spell_cure_confusion", /* 125 */ 171 "spell_cure_confusion", /* 125 */
172 "spell_restoration", /* 126 */ 172 "spell_restoration", /* 126 */
173 "was summon evil monster", /* 127 *//* Not implenented as nothing used it */ 173 "spell_summon_devil", /* 127 *//* Not implenented as nothing used it */
174 "spell_counterwall", /* 128 */ 174 "spell_counterwall", /* 128 */
175 "spell_cause_light_wounds", /* 129 */ 175 "spell_cause_light_wounds", /* 129 */
176 "spell_cause_medium_wounds", /* 130 */ 176 "spell_cause_medium_wounds", /* 130 */
177 "spell_cause_heavy_wounds", /* 131 */ 177 "spell_cause_heavy_wounds", /* 131 */
178 "spell_charm_monsters", /* 132 */ 178 "spell_charm_monsters", /* 132 */
250 "spell_cause_rabies", /* 204 */ 250 "spell_cause_rabies", /* 204 */
251 "spell_glyph", /* 205 */ 251 "spell_glyph", /* 205 */
252 NULL 252 NULL
253}; 253};
254 254
255extern bool loading_arch;
256
257/* This function checks the object after it has been loaded (when we 255/* This function checks the object after it has been loaded (when we
258 * get the 'end' in the input stream). This function can be used to 256 * get the 'end' in the input stream). This function can be used to
259 * deal with legacy objects where fields may have changed. It can also be used 257 * deal with legacy objects where fields may have changed. It can also be used
260 * to check for objects to make sure there are no common errors. 258 * to check for objects to make sure there are no common errors.
261 */ 259 */
262void 260void
263object::post_load_check () 261object::post_load_check ()
264{ 262{
265 if (type >= NUM_TYPES) 263 if (type >= NUM_TYPES)
266 { 264 {
267 LOG (llevError, "%s: type out of range, resetting to 0.\n", debug_desc ()); 265 LOG (llevError, "ITEMBUG: %s: type out of range, resetting to 0.\n", debug_desc ());
268 type = 0; 266 type = 0;
269 } 267 }
270 268
271 switch (type) 269 switch (type)
272 { 270 {
274 case WAND: 272 case WAND:
275 case ROD: 273 case ROD:
276 case HORN: 274 case HORN:
277 if (slot [body_range].info != -1) 275 if (slot [body_range].info != -1)
278 { 276 {
279 LOG (llevError, "%s: body_range %d != -1\n", debug_desc (), slot [body_range].info); 277 LOG (llevError, "ITEMBUG: %s: body_range %d != -1\n", debug_desc (), slot [body_range].info);
280 slot [body_range].info = -1; 278 slot [body_range].info = -1;
281 } 279 }
282 break; 280 break;
283 281
284 case WEAPON: 282 case WEAPON:
285 if (slot [body_combat].info != -1) 283 if (slot [body_combat].info != -1)
286 { 284 {
287 LOG (llevError, "%s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info); 285 LOG (llevError, "ITEMBUG: %s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info);
288 slot [body_combat].info = -1; 286 slot [body_combat].info = -1;
289 } 287 }
290 break; 288 break;
291 289
292 case SHIELD: 290 case SHIELD:
293 if (slot [body_shield].info != -1) 291 if (slot [body_shield].info != -1)
294 { 292 {
295 LOG (llevError, "%s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info); 293 LOG (llevError, "ITEMBUG: %s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info);
296 slot [body_shield].info = -1; 294 slot [body_shield].info = -1;
297 } 295 }
298 break; 296 break;
299 297
300 case PLAYER: 298 case PLAYER:
301 if (slot [body_shield].info != 1) 299 if (slot [body_shield].info != 1)
302 { 300 {
303 LOG (llevError, "%s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info); 301 LOG (llevError, "ITEMBUG: %s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info);
304 slot [body_shield].info = 1; 302 slot [body_shield].info = 1;
305 } 303 }
306 304
307 if (slot [body_combat].info != 1) 305 if (slot [body_combat].info != 1)
308 { 306 {
309 LOG (llevError, "%s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info); 307 LOG (llevError, "ITEMBUG: %s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info);
310 slot [body_combat].info = 1; 308 slot [body_combat].info = 1;
311 } 309 }
312 310
313 if (slot [body_range].info != 1) 311 if (slot [body_range].info != 1)
314 { 312 {
315 LOG (llevError, "%s: body_range %d != 1\n", debug_desc (), slot [body_range].info); 313 LOG (llevError, "ITEMBUG: %s: body_range %d != 1\n", debug_desc (), slot [body_range].info);
316 slot [body_range].info = 1; 314 slot [body_range].info = 1;
317 } 315 }
318 break; 316 break;
319 } 317 }
320 318
325 * also have to catch is if this object is not using the normal name for 323 * also have to catch is if this object is not using the normal name for
326 * the object. In that case, we also want to use the loaded name. 324 * the object. In that case, we also want to use the loaded name.
327 * Otherwise, what happens is that the the plural name will lose 325 * Otherwise, what happens is that the the plural name will lose
328 * information (appear as just 'hearts' and not 'goblins heart') 326 * information (appear as just 'hearts' and not 'goblins heart')
329 */ 327 */
330 if (arch && name != arch->clone.name && name_pl == arch->clone.name_pl) 328 if (arch && name != arch->object::name && name_pl == arch->object::name_pl)
331 name_pl = 0; 329 name_pl = 0;
332 330
333 if (!name_pl) 331 if (!name_pl)
334 name_pl = name; 332 name_pl = name;
335 333
343 * not in the ideal fashion. 341 * not in the ideal fashion.
344 */ 342 */
345 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND)) 343 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND))
346 { 344 {
347 if (!skill) 345 if (!skill)
348 LOG (llevError, "Weapon %s lacks a skill.\n", debug_desc ()); 346 LOG (llevError, "ITEMBUG: weapon %s lacks a skill.\n", debug_desc ());
349 else if ((!strcmp (skill, "one handed weapons") && slot[body_arm].info != -1) || 347 else if ((skill == shstr_one_handed_weapons && slot[body_arm].info != -1) ||
350 (!strcmp (skill, "two handed weapons") && slot[body_arm].info != -2)) 348 (skill == shstr_two_handed_weapons && slot[body_arm].info != -2))
351 LOG (llevError, "weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill); 349 LOG (llevError, "ITEMBUG: weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill);
352 } 350 }
353 351
354 /* We changed last_heal to gen_sp_armour, which is what it 352 /* We changed last_heal to gen_sp_armour, which is what it
355 * really does for many objects. Need to catch any in maps 353 * really does for many objects. Need to catch any in maps
356 * that may have an old value. 354 * that may have an old value.
362 || type == AMULET || type == GIRDLE 360 || type == AMULET || type == GIRDLE
363 || type == BRACERS || type == CLOAK) 361 || type == BRACERS || type == CLOAK)
364 { 362 {
365 if (last_heal) 363 if (last_heal)
366 { 364 {
367 LOG (llevDebug, "Object %s still has last_heal set, not gen_sp_armour\n", debug_desc ()); 365 LOG (llevError, "ITEMBUG: object %s still has last_heal set, not gen_sp_armour\n", debug_desc ());
368 gen_sp_armour = last_heal; 366 gen_sp_armour = last_heal;
369 last_heal = 0; 367 last_heal = 0;
370 } 368 }
371 369
372 int ip = calc_item_power (this, 0); 370 int ip = calc_item_power (this, 0);
373 371
374 /* Legacy objects from before item power was in the game */ 372 /* Legacy objects from before item power was in the game */
375 if (!item_power && ip) 373 if (!item_power && ip)
376 { 374 {
377 if (ip > 3) 375 if (ip > 3)
378 LOG (llevDebug, "Object %s had no item power, using %d\n", debug_desc (), ip); 376 LOG (llevDebug, "ITEMBUG: Object %s had no item power, using %d\n", debug_desc (), ip);
379 377
380 item_power = ip; 378 item_power = ip;
381 } 379 }
382 380
383 /* Check for possibly bogus values. Has to meet both these criteria - 381 /* Check for possibly bogus values. Has to meet both these criteria -
384 * something that has item_power 1 is probably just fine if our calculated 382 * something that has item_power 1 is probably just fine if our calculated
385 * value is 1 or 2 - these values are small enough that hard to be precise. 383 * value is 1 or 2 - these values are small enough that hard to be precise.
386 * similarly, it item_power is 0, the first check will always pass, 384 * similarly, it item_power is 0, the first check will always pass,
387 * but not the second one. 385 * but not the second one.
388 */ 386 */
387#if 0 //TODO
389 if (ip > 2 * item_power && ip > (item_power + 3)) 388 if (ip > 2 * item_power && ip > (item_power + 3))
390 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power); 389 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power);
390#endif
391 } 391 }
392 392
393 /* Old spellcasting object - need to load in the appropiate object */ 393 /* old style spellcasting object (pretty common) - need to load in the appropiate object */
394 if ((type == ROD || type == WAND || type == SCROLL || type == HORN || type == FIREWALL || 394 /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */
395 if ((type == ROD
396 || type == WAND
397 || type == SCROLL
398 || type == HORN
399 || type == FIREWALL
395 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */ 400 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */
396 ((type == POTION || type == ALTAR) && stats.sp)) && !inv && !loading_arch) 401 || ((type == POTION || type == ALTAR) && stats.sp)) // watchout: sp = 0 is still magic bullet.
402 && !inv
403 && !loading_arch
404 && stats.sp) // watchout: old magic bullet stuff directly on the map is going to break here!
405 // TODO: at least one watchout-comments is redundant - investigate/remove
397 { 406 {
407 // TODO: fix firewall object on map
398 /* Fireall is bizarre in that spell type was stored in dam. Rest are 'normal' 408 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal'
399 * in that spell was stored in sp. 409 * in that spell was stored in sp.
400 */ 410 */
411 //LOG (llevError, "old spellcasting object found: %s", debug_desc ());
401 object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]); 412 object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]);
402 insert_ob_in_ob (tmp, this); 413 insert_ob_in_ob (tmp, this);
403 randomitems = NULL; /* So another spell isn't created for this object */ 414 randomitems = 0;
404 } 415 }
405 416
406 /* spellbooks & runes use slaying. But not to arch name, but to spell name */ 417 /* spellbooks & runes use slaying. But not to arch name, but to spell name */
407 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch) 418 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch)
408 { 419 {
420 LOG (llevError, "ITEMBUG: spellbook/rune found without inv but slaying: %s", debug_desc ());
409 object *tmp = get_archetype_by_object_name (slaying); 421 object *tmp = get_archetype_by_object_name (slaying);
410 insert_ob_in_ob (tmp, this); 422 insert_ob_in_ob (tmp, this);
411 randomitems = NULL; /* So another spell isn't created for this object */ 423 randomitems = 0; /* So another spell isn't created for this object */
412 /* without this, value is all screwed up */ 424 /* without this, value is all screwed up */
413 value = arch->clone.value * inv->value; 425 value = arch->value * inv->value;
414 } 426 }
415 427
416 if (QUERY_FLAG (this, FLAG_MONSTER)) 428 if (QUERY_FLAG (this, FLAG_MONSTER))
417 { 429 {
418 if (stats.hp > stats.maxhp) 430 if (stats.hp > stats.maxhp)
419 { 431 {
420 LOG (llevDebug, "Monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp); 432 LOG (llevInfo, "ITEMBUG: monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp);
421 stats.maxhp = stats.hp; 433 stats.maxhp = stats.hp;
422 } 434 }
423 435
424 /* The archs just need to be updated for this */ 436 /* The archs just need to be updated for this */
425 if (move_type == 0) 437 if (move_type == 0)
426 move_type = MOVE_WALK; 438 move_type = MOVE_WALK;
427 } 439 }
428 440
429 if ((QUERY_FLAG (this, FLAG_GENERATOR) && QUERY_FLAG (this, FLAG_CONTENT_ON_GEN)) || type == CREATOR || type == CONVERTER) 441 if ((QUERY_FLAG (this, FLAG_GENERATOR) && QUERY_FLAG (this, FLAG_CONTENT_ON_GEN)) || type == CREATOR || type == CONVERTER)
430 {
431 /* Object will duplicate it's content as part of the 442 /* Object will duplicate it's content as part of the
432 * generation process. To do this, we must flag inventory 443 * generation process. To do this, we must flag inventory
433 * so it remains unevaluated concerning the randomitems and 444 * so it remains unevaluated concerning the randomitems and
434 * the living (a demonlord shouldn't cast from inside generator!) 445 * the living (a demonlord shouldn't cast from inside generator!)
435 */ 446 */
447 /* ??? this *should* be done elsewhere, e.g. after map loading etc. */
436 flag_inv (this, FLAG_IS_A_TEMPLATE); 448 flag_inv (this, FLAG_IS_A_TEMPLATE);
437 }
438 449
439 /* Handle player movers. We use move_type for player movers 450 /* Handle player movers. We use move_type for player movers
440 * because they operate on their own time (move_on 451 * because they operate on their own time (move_on
441 * would potentially cause them to be triggered when someone steps 452 * would potentially cause them to be triggered when someone steps
442 * on them). If move_type is set, presume person knows what they 453 * on them). If move_type is set, presume person knows what they
443 * are doing, otherwise, set move_type based on maxhp value. 454 * are doing, otherwise, set move_type based on maxhp value.
444 */ 455 */
445 if (type == PLAYERMOVER) 456 if (type == PLAYERMOVER)
446 { 457 {
447 if (!move_type) 458 if (!move_type)
452 stats.maxhp = 0; 463 stats.maxhp = 0;
453 } 464 }
454 else 465 else
455 move_type = MOVE_WALK; 466 move_type = MOVE_WALK;
456 } 467 }
468 }
469
470 // if the object has an animation, try to provide a default face
471 if (has_anim ())
472 {
473 const animation &anim_ob = anim ();
474
475 if (anim_speed)
476 // if this item is time-animated, force the last frame
477 animate_object (this, 0);
478 else if (flag [FLAG_MONSTER])
479 // if it is a monster, set appropriate facing
480 animate_object (this, direction);
457 } 481 }
458} 482}
459 483
460static void 484static void
461set_move (MoveType &mt, const char *str) 485set_move (MoveType &mt, const char *str)
509 533
510 goto next; 534 goto next;
511 } 535 }
512 } 536 }
513 537
514 LOG (llevDebug, "common/loader.C: set_move - unknown move string '%s'\n", str); 538 LOG (llevError, "common/loader.C: set_move - unknown move string '%s'\n", str);
515 539
516next: ; 540next: ;
517 } 541 }
518} 542}
519 543
520#define GET_FLAG(op,flag) \ 544//-GPL
521 if (f.get_sint32 ()) \ 545
522 SET_FLAG (op, flag); \ 546#define GET_FLAG(op,flg) op->flag [flg] = f.get_bool ()
523 else \
524 CLEAR_FLAG (op, flag) \
525 547
526bool 548bool
527object::parse_kv (object_thawer &f) 549object::parse_kv (object_thawer &f)
528{ 550{
529 object *op_inv = inv; 551 object *op_inv = inv;
552 key_value *last_kv = key_values;
530 553
531 for (;;) 554 for (;;)
532 { 555 {
533 switch (f.kw) 556 switch (f.kw)
534 { 557 {
535 case KW_uuid: 558 case KW_uuid:
536 if (const char *s = f.get_str ()) 559 if (const char *s = f.get_str ())
537 { 560 if (!uuid.parse (s))
538 unsigned int version;
539 unsigned long long seq;
540
541 if (2 == sscanf (s, "<%d.%llx>", &version, &seq) && version == 1)
542 { 561 {
543 uuid.seq = seq; 562 f.parse_warn ("unparseable uuid");
544 break; 563 uuid = UUID::gen ();
545 } 564 }
546 }
547
548 uuid = gen_uuid ();
549 break; 565 break;
550 566
551 case KW_oid: 567 case KW_oid:
552 f.get (this, f.get_sint32 ()); 568 f.get (this, f.get_sint32 ());
553 break; 569 break;
559 575
560 case KW_attach: f.get_ornull (attach); break; 576 case KW_attach: f.get_ornull (attach); break;
561 case KW_skill: f.get_ornull (skill); break; 577 case KW_skill: f.get_ornull (skill); break;
562 case KW_race: f.get_ornull (race); break; 578 case KW_race: f.get_ornull (race); break;
563 case KW_slaying: f.get_ornull (slaying); break; 579 case KW_slaying: f.get_ornull (slaying); break;
580 case KW_tag: f.get_ornull (tag); break;
564 581
565 case KW_arch: 582 case KW_arch:
566 {
567 object *tmp = object::read (f); 583 if (object *tmp = object::read (f))
568 tmp->deactivate ();
569
570 { 584 {
585 tmp->deactivate ();
586
571 // was: insert_ob_in_ob (tmp, op); 587 // was: insert_ob_in_ob (tmp, op);
572 // but manually adding it can improve map loading times a lot 588 // but manually adding it can improve map loading times a lot
573 // also, appending instead of prepending keeps the 589 // also, appending instead of prepending keeps the
574 // save ordering the same between repeated load/saves. 590 // save ordering the same between repeated load/saves.
591 // and finally we do not want any funny effects
575 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL); 592 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL);
576 CLEAR_FLAG (tmp, FLAG_REMOVED); 593 CLEAR_FLAG (tmp, FLAG_REMOVED);
577 594
578 if (!op_inv) 595 if (!op_inv)
579 { 596 {
591 608
592 tmp->below = 0; 609 tmp->below = 0;
593 tmp->env = this; 610 tmp->env = this;
594 op_inv = tmp; 611 op_inv = tmp;
595 } 612 }
596 } 613 else
614 LOG (llevError, "ERROR: couldn't load inventory object, file corrupted?\n");
615
597 continue; 616 continue;
598 617
599 case KW_other_arch: 618 case KW_other_arch:
600 other_arch =
601 loading_arch 619 if (loading_arch == this)
602 ? archetype::get (f.get_str ()) 620 archetype::postpone_arch_ref (loading_arch->other_arch, f.get_str ());
621 else
622 {
603 : archetype::find (f.get_str ()); 623 other_arch = archetype::find (f.get_str ());
604 624
605 if (!other_arch) 625 if (!other_arch)
606 LOG (llevError, "%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()); 626 f.parse_warn (format ("%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()));
627 }
628 break;
629
630 case KW_owner:
631 f.delayed_deref (this, owner, f.get_str ());
607 break; 632 break;
608 633
609 case KW_animation: 634 case KW_animation:
610 { 635 {
611 CLEAR_FLAG (this, FLAG_ANIMATE); 636 CLEAR_FLAG (this, FLAG_ANIMATE);
612 animation_id = 0; 637 animation_id = 0;
613 638
614 const char *str = f.get_str (); 639 const char *str = f.get_str ();
615 if (str && (animation_id = find_animation (str))) 640 if (str && (animation_id = find_animation (str)))
616 SET_FLAG (this, FLAG_ANIMATE); 641 SET_FLAG (this, FLAG_ANIMATE); //TODO: should not be forced to true here
617 } 642 }
618 break; 643 break;
619 644
620 case KW_last_heal: f.get (last_heal); break; 645 case KW_last_heal: f.get (last_heal); break;
621 case KW_last_sp: f.get (last_sp); break; 646 case KW_last_sp: f.get (last_sp); break;
638 f.get (move_slow_penalty); 663 f.get (move_slow_penalty);
639 break; 664 break;
640 665
641 case KW_face: 666 case KW_face:
642 face = face_find (f.get_str ()); 667 face = face_find (f.get_str ());
668 break;
669
670 case KW_sound:
671 sound = sound_find (f.get_str ());
672 if (!sound)
673 f.parse_warn ("sound not found");
674 break;
675
676 case KW_sound_destroy:
677 sound_destroy = sound_find (f.get_str ());
678 if (!sound_destroy)
679 f.parse_warn ("sound not found");
643 break; 680 break;
644 681
645 case KW_x: f.get (x); break; 682 case KW_x: f.get (x); break;
646 case KW_y: f.get (y); break; 683 case KW_y: f.get (y); break;
647 684
775 CLEAR_FLAG (this, FLAG_KNOWN_MAGICAL); 812 CLEAR_FLAG (this, FLAG_KNOWN_MAGICAL);
776 813
777 break; 814 break;
778 815
779 case KW_friendly: 816 case KW_friendly:
780 if (f.get_sint32 ()) 817 if (f.get_bool ())
781 if (type != PLAYER) 818 if (type != PLAYER)
782 add_friendly_object (this); 819 add_friendly_object (this);
783 820
784 break; 821 break;
785 822
798 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break; 835 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break;
799 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break; 836 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break;
800 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break; 837 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break;
801 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break; 838 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break;
802 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break; 839 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break;
840 case KW_player_sold: GET_FLAG (this, FLAG_PLAYER_SOLD); break;
803 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break; 841 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break;
804 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break; 842 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break;
805 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break; 843 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break;
806 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break; 844 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break;
807 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break; 845 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break;
907 case KW_anim_speed: f.get (anim_speed); break; 945 case KW_anim_speed: f.get (anim_speed); break;
908 case KW_container: f.get (weight_limit); break; 946 case KW_container: f.get (weight_limit); break;
909 case KW_will_apply: f.get (will_apply); break; 947 case KW_will_apply: f.get (will_apply); break;
910 case KW_attack_movement: f.get (attack_movement); break; 948 case KW_attack_movement: f.get (attack_movement); break;
911 case KW_move_state: f.get (move_status); break; 949 case KW_move_state: f.get (move_status); break;
912 case KW_expmul: f.get (expmul); break; 950 //case KW_expmul: f.get (expmul); break;//D declared const for the time being
913 case KW_glow_radius: f.get (glow_radius); break; 951 case KW_glow_radius: f.get (glow_radius); break;
914 case KW_weapontype: f.get (weapontype); break; 952 case KW_weapontype: f.get (weapontype); break;
915 case KW_tooltype: f.get (tooltype); break;
916 case KW_casting_time: f.get (casting_time); break; 953 case KW_casting_time: f.get (casting_time); break;
954
955 // elevation is deprecated
917 case KW_elevation: f.get (elevation); break; 956 case KW_elevation: break;
957
918 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break; 958 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break;
919 case KW_client_type: f.get (client_type); break; 959 case KW_client_type: f.get (client_type); break;
920 case KW_duration: f.get (duration); break; 960 case KW_duration: f.get (duration); break;
921 case KW_range: f.get (range); break; 961 case KW_range: f.get (range); break;
922 case KW_range_modifier: f.get (range_modifier); break; 962 case KW_range_modifier: f.get (range_modifier); break;
941 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break; 981 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break;
942 case KW_can_apply: 982 case KW_can_apply:
943 break; 983 break;
944 984
945 case KW_connected: 985 case KW_connected:
946 add_button_link (this, map, f.get_sint32 ()); 986 {
987 shstr connected;
988
989 f.get (connected);
990 add_link (map, connected);
991 }
947 break; 992 break;
948 993
949 case KW_randomitems: 994 case KW_randomitems:
950 if (f.get_str ()) 995 if (f.get_str ())
951 { 996 {
953 loading_arch 998 loading_arch
954 ? treasurelist::get (f.get_str ()) 999 ? treasurelist::get (f.get_str ())
955 : treasurelist::find (f.get_str ()); 1000 : treasurelist::find (f.get_str ());
956 1001
957 if (!randomitems) 1002 if (!randomitems)
1003 {
958 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ()); 1004 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ());
1005 randomitems = treasurelist::get (shstr_none); // avoid crashes
1006 }
959 } 1007 }
960 else 1008 else
961 randomitems = 0; 1009 randomitems = 0;
962 break; 1010 break;
963 1011
964 case KW_msg: 1012 case KW_msg:
965 f.get_ml (KW_endmsg, msg); 1013 f.get_ml (KW_endmsg, msg);
966 //TODO: allow longer messages
967 if (strlen (msg) >= HUGE_BUF)
968 {
969 LOG (llevDebug, "\tError message length >= %d: %d\n>%.80s<\n", HUGE_BUF, strlen (msg), &msg);
970 msg = "ERROR, please report: string too long, winged.\n";
971 }
972 break; 1014 break;
973 1015
974 case KW_lore: 1016 case KW_lore:
975 f.get_ml (KW_endlore, lore); 1017 f.get_ml (KW_endlore, lore);
976 //TODO: allow longer messages
977 /* Just print a warning so we can be reasonably safe
978 * about not overflowing the buffer.
979 */
980 if (strlen (lore) > (HUGE_BUF / 2))
981 LOG (llevDebug, "\tWarning lore length > %d (max allowed=%d): %d\n>%.80s<\n",
982 HUGE_BUF / 2, HUGE_BUF, strlen (lore), &lore);
983 break; 1018 break;
984 1019
985 case KW_editable: 1020 case KW_editable:
986 case KW_editor_folder: 1021 case KW_editor_folder:
987 break; 1022 break;
992 1027
993 f.next (); 1028 f.next ();
994 return true; 1029 return true;
995 1030
996 case KW_ERROR: 1031 case KW_ERROR:
997 set_ob_key_value (this, f.kw_str, f.value, true); 1032 // append as key value pair (do not use kv_set as it prepends)
1033 // we also do not even try to find old values, duplicate keys stay duplicate
1034 {
1035 key_value *kv = new key_value;
1036
1037 kv->next = 0;
1038 kv->key = shstr (f.kw_str);
1039 kv->value = shstr (f.value);
1040
1041 if (!last_kv)
1042 key_values = last_kv = kv;
1043 else
1044 {
1045 while (last_kv->next)
1046 last_kv = last_kv->next;
1047
1048 last_kv->next = kv;
1049 last_kv = kv;
1050 }
1051 }
998 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D 1052 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D
999 break; 1053 break;
1000 1054
1001 default: 1055 default:
1002 if (!f.parse_error ("object", name)) 1056 if (!f.parse_error ("object", name))
1016 archetype *arch = archetype::find (f.get_str ()); 1070 archetype *arch = archetype::find (f.get_str ());
1017 1071
1018 if (!arch) 1072 if (!arch)
1019 { 1073 {
1020 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ()); 1074 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ());
1021 arch = archetype::find ("earthwall"); 1075 arch = archetype::find (shstr_earthwall);
1022 } 1076 }
1023 1077
1024 assert (arch); //D maybe use exception handling of sorts? 1078 assert (arch); //D maybe use exception handling of sorts?
1025 1079
1026 f.next (); 1080 f.next ();
1027 1081
1028 object *op = object::create (); 1082 object *op = arch->instance ();
1029
1030 op->map = map; 1083 op->map = map;
1031 arch->clone.copy_to (op);
1032 // copy_to activates, this should be fixed properly 1084 // instance() activates, this should be fixed properly
1033 op->deactivate (); 1085 op->deactivate ();
1034 1086
1035 if (!op->parse_kv (f)) 1087 if (!op->parse_kv (f))
1036 { 1088 {
1037 op->destroy (true); 1089 op->destroy ();
1038 return 0; 1090 return 0;
1039 } 1091 }
1040 1092
1041 op->post_load_check (); 1093 op->post_load_check ();
1042 return op; 1094 return op;
1051int 1103int
1052set_variable (object *op, char *buf) 1104set_variable (object *op, char *buf)
1053{ 1105{
1054 object_thawer f (buf, (AV *)0); 1106 object_thawer f (buf, (AV *)0);
1055 1107
1056 f.next ();
1057 return op->parse_kv (f); 1108 return op->parse_kv (f);
1058} 1109}
1059 1110
1060/* This returns a string of the integer movement type */
1061#if 0
1062// unused function
1063static char *
1064get_string_move_type (MoveType mt)
1065{
1066 static char retbuf[MAX_BUF], retbuf_all[MAX_BUF];
1067 int i, all_count = 0, count;
1068
1069 strcpy (retbuf, "");
1070 strcpy (retbuf_all, " all");
1071
1072 /* Quick check, and probably fairly common */
1073 if (mt == MOVE_ALL)
1074 return retbuf_all + 1;
1075 if (mt == 0)
1076 {
1077 strcpy (retbuf, "0");
1078 return retbuf;
1079 }
1080
1081 /* We basically slide the bits down. Why look at MOVE_ALL?
1082 * because we may want to return a string like 'all -swim',
1083 * and if we just looked at mt, we couldn't get that.
1084 */
1085 for (i = MOVE_ALL, count = 0; i != 0; i >>= 1, count++)
1086 {
1087 if (mt & (1 << count))
1088 {
1089 strcat (retbuf, " ");
1090 strcat (retbuf, move_name[count]);
1091 }
1092 else
1093 {
1094 strcat (retbuf_all, " -");
1095 strcat (retbuf_all, move_name[count]);
1096 all_count++;
1097 }
1098 }
1099 /* Basically, if there is a single negation, return it, eg
1100 * 'all -swim'. But more than that, just return the
1101 * enumerated values. It doesn't make sense to return
1102 * 'all -walk -fly_low' - it is shorter to return 'fly_high swim'
1103 */
1104 if (all_count <= 1)
1105 return retbuf_all + 1;
1106 else
1107 return retbuf + 1;
1108}
1109#endif
1110
1111// compare *op against *tmp and output differences 1111// compare *op against *arch and output differences
1112static void 1112static void
1113write_diff (object_freezer &f, object *op, object *tmp) 1113write_diff (object_freezer &f, object *op, object *arch)
1114{ 1114{
1115 static const keyword resist_save[NROFATTACKS] = { 1115 static const keyword resist_save[NROFATTACKS] = {
1116# define def(uc, lc, name, plus, change) KW_resist_ ## lc, 1116# define def(uc, lc, name, plus, change) KW_resist_ ## lc,
1117# include "attackinc.h" 1117# include "attackinc.h"
1118# undef def 1118# undef def
1248 /* 110 */ 1248 /* 110 */
1249 KW_destroy_on_death, 1249 KW_destroy_on_death,
1250 KW_NULL, 1250 KW_NULL,
1251 }; 1251 };
1252 1252
1253 int i;
1254
1255 /* This saves the key/value lists. We do it first so that any 1253 /* This saves the key/value lists. We do it first so that any
1256 * keys that match field names will be overwritten by the loader. 1254 * keys that match field names will be overwritten by the loader.
1257 */ 1255 */
1258 for (key_value *my_field = op->key_values; my_field; my_field = my_field->next) 1256 for (key_value *kv = op->key_values; kv; kv = kv->next)
1259 { 1257 if (!arch->key_values || arch->kv (kv->key) != kv->value)
1260 /* Find the field in the opposing member. */ 1258 f.put (kv->key, kv->value);
1261 key_value *arch_field = get_ob_key_link (tmp, my_field->key);
1262 1259
1263 /* If there's no partnering field, or it's got a different value, save our field. */ 1260 if (op->uuid)
1264 if (!arch_field || my_field->value != arch_field->value) 1261 f.put (KW_uuid, op->uuid.c_str ());
1265 f.put (my_field->key, my_field->value);
1266 }
1267 1262
1268 /* We don't need to worry about the arch's extra fields - they
1269 * will get taken care of the copy_to method.
1270 */
1271
1272 {
1273 char uids[64];
1274 snprintf (uids, sizeof (uids), "<1.%llx>", (unsigned long long)op->uuid.seq);
1275 f.put (KW_uuid, (const char *)uids);
1276 }
1277
1278#define CMP_OUT(v) if (op->v != tmp->v) f.put (KW_ ## v, op->v) 1263#define CMP_OUT(v) if (expect_false (op->v != arch->v)) f.put (KW_ ## v, op->v)
1279#define CMP_OUT2(k,v) if (op->v != tmp->v) f.put (KW_ ## k, op->v) 1264#define CMP_OUT2(k,v) if (expect_false (op->v != arch->v)) f.put (KW_ ## k, op->v)
1265
1266 CMP_OUT (x);
1267 CMP_OUT (y);
1268
1269 CMP_OUT (type);
1270 CMP_OUT (subtype);
1271 CMP_OUT (direction);
1280 1272
1281 CMP_OUT (name); 1273 CMP_OUT (name);
1282 CMP_OUT (name_pl); 1274 CMP_OUT (name_pl);
1283 CMP_OUT (custom_name); 1275
1276 CMP_OUT (speed);
1277 CMP_OUT (speed_left);
1278
1284 CMP_OUT (title); 1279 CMP_OUT (title);
1285 CMP_OUT (race); 1280 CMP_OUT (race);
1286 CMP_OUT (slaying); 1281 CMP_OUT (slaying);
1282 CMP_OUT (skill);
1287 1283
1288 if (op->msg != tmp->msg) 1284 CMP_OUT (tag);
1289 f.put (KW_msg, KW_endmsg, op->msg); 1285 CMP_OUT (custom_name);
1290 if (op->lore != tmp->lore) 1286
1291 f.put (KW_lore, KW_endlore, op->lore); 1287 if (object *owner = op->owner)
1288 f.put (KW_owner, static_cast<const char *>(owner->ref ()));
1289
1290 // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved
1292 1291
1293 CMP_OUT (other_arch); 1292 CMP_OUT (other_arch);
1294 1293
1295 if (op->face != tmp->face) f.put (KW_face, op->face ? &faces [op->face] : 0); 1294 if (op->msg != arch->msg ) f.put (KW_msg , KW_endmsg , op->msg );
1295 if (op->lore != arch->lore) f.put (KW_lore, KW_endlore, op->lore);
1296 1296
1297 if (op->face != arch->face ) f.put (KW_face , op->face ? &faces [op->face ] : 0);
1298 if (op->sound != arch->sound ) f.put (KW_sound , op->sound ? &faces [op->sound ] : 0);
1299 if (op->sound_destroy != arch->sound_destroy) f.put (KW_sound_destroy, op->sound_destroy ? &faces [op->sound_destroy] : 0);
1300
1297 if (op->animation_id != tmp->animation_id) 1301 if (op->animation_id != arch->animation_id)
1298 if (op->animation_id) 1302 if (op->has_anim ())
1303 f.put (KW_animation, op->anim ().name);
1304 else
1299 { 1305 {
1300 f.put (KW_animation, animations[GET_ANIM_ID (op)].name); 1306 f.put (KW_animation, (const char *)0);
1301 1307 op->flag [FLAG_ANIMATE] = false; // TODO: why force to false here?
1302 if (!QUERY_FLAG (op, FLAG_ANIMATE))
1303 f.put (KW_is_animated, (sint32) 0);
1304 } 1308 }
1305 else
1306 f.put (KW_animation, (const char *) 0);
1307 1309
1308 CMP_OUT2 (str, stats.Str); 1310 CMP_OUT2 (str, stats.Str);
1309 CMP_OUT2 (dex, stats.Dex); 1311 CMP_OUT2 (dex, stats.Dex);
1310 CMP_OUT2 (con, stats.Con); 1312 CMP_OUT2 (con, stats.Con);
1311 CMP_OUT2 (wis, stats.Wis); 1313 CMP_OUT2 (wis, stats.Wis);
1320 CMP_OUT2 (grace, stats.grace); 1322 CMP_OUT2 (grace, stats.grace);
1321 CMP_OUT2 (maxgrace, stats.maxgrace); 1323 CMP_OUT2 (maxgrace, stats.maxgrace);
1322 CMP_OUT2 (exp, stats.exp); 1324 CMP_OUT2 (exp, stats.exp);
1323 1325
1324 CMP_OUT (perm_exp); 1326 CMP_OUT (perm_exp);
1325 CMP_OUT (expmul); 1327 //CMP_OUT (expmul);
1326 1328
1327 CMP_OUT2 (food, stats.food); 1329 CMP_OUT2 (food, stats.food);
1328 CMP_OUT2 (dam, stats.dam); 1330 CMP_OUT2 (dam, stats.dam);
1329 CMP_OUT2 (luck, stats.luck); 1331 CMP_OUT2 (luck, stats.luck);
1330 CMP_OUT2 (wc, stats.wc); 1332 CMP_OUT2 (wc, stats.wc);
1331 CMP_OUT2 (ac, stats.ac); 1333 CMP_OUT2 (ac, stats.ac);
1332 1334
1333 CMP_OUT (x);
1334 CMP_OUT (y);
1335 CMP_OUT (speed);
1336 CMP_OUT (speed_left);
1337 CMP_OUT2 (move_state, move_status); 1335 CMP_OUT2 (move_state, move_status);
1338 CMP_OUT (attack_movement); 1336 CMP_OUT (attack_movement);
1339 CMP_OUT (nrof); 1337 CMP_OUT (nrof);
1340 CMP_OUT (level); 1338 CMP_OUT (level);
1341 CMP_OUT (direction);
1342 CMP_OUT (type);
1343 CMP_OUT (subtype);
1344 CMP_OUT (attacktype); 1339 CMP_OUT (attacktype);
1345 1340
1341 // using memcmp here seems to be a loss - us gcc vectorising?
1346 for (i = 0; i < NROFATTACKS; i++) 1342 for (int i = 0; i < NROFATTACKS; i++)
1347 if (op->resist[i] != tmp->resist[i]) 1343 if (expect_false (op->resist[i] != arch->resist[i]))
1348 f.put (resist_save[i], op->resist[i]); 1344 f.put (resist_save[i], op->resist[i]);
1349 1345
1350 CMP_OUT (path_attuned); 1346 CMP_OUT (path_attuned);
1351 CMP_OUT (path_repelled); 1347 CMP_OUT (path_repelled);
1352 CMP_OUT (path_denied); 1348 CMP_OUT (path_denied);
1362 CMP_OUT (last_sp); 1358 CMP_OUT (last_sp);
1363 CMP_OUT (last_grace); 1359 CMP_OUT (last_grace);
1364 CMP_OUT (last_eat); 1360 CMP_OUT (last_eat);
1365 CMP_OUT (glow_radius); 1361 CMP_OUT (glow_radius);
1366 1362
1367 if (QUERY_FLAG (op, FLAG_IS_LINKED) && (i = get_button_value (op))) 1363 if (op->flag [FLAG_IS_LINKED])
1364 if (auto (ol, op->find_link ()))
1368 f.put (KW_connected, i); 1365 f.put (KW_connected, ol->id);
1369 1366
1370 CMP_OUT (randomitems); 1367 CMP_OUT (randomitems);
1371 CMP_OUT2 (container, weight_limit); 1368 CMP_OUT2 (container, weight_limit);
1372 1369
1373 CMP_OUT (run_away); 1370 CMP_OUT (run_away);
1374 CMP_OUT (pick_up); 1371 CMP_OUT (pick_up);
1375 CMP_OUT (will_apply); 1372 CMP_OUT (will_apply);
1376 CMP_OUT (smoothlevel); 1373 CMP_OUT (smoothlevel);
1377 CMP_OUT (weapontype); 1374 CMP_OUT (weapontype);
1378 CMP_OUT (tooltype);
1379 CMP_OUT (elevation);
1380 CMP_OUT (client_type); 1375 CMP_OUT (client_type);
1381 CMP_OUT (item_power); 1376 CMP_OUT (item_power);
1382 CMP_OUT (duration); 1377 CMP_OUT (duration);
1383 CMP_OUT (range); 1378 CMP_OUT (range);
1384 CMP_OUT (range_modifier); 1379 CMP_OUT (range_modifier);
1392 CMP_OUT (move_on); 1387 CMP_OUT (move_on);
1393 CMP_OUT (move_off); 1388 CMP_OUT (move_off);
1394 CMP_OUT (move_slow); 1389 CMP_OUT (move_slow);
1395 CMP_OUT (move_slow_penalty); 1390 CMP_OUT (move_slow_penalty);
1396 1391
1392 // obj_original is the only commonly differing flag between archetype
1393 // and object, so special-case it here to be able to skip the loop
1394 object::flags_t diff = op->flags ^ arch->flags;
1395
1396 if (expect_true (diff.any ()))
1397 {
1398 if (expect_false (diff.reset (FLAG_OBJ_ORIGINAL).any ()))
1399 {
1400 // some other flags differ, too
1397 if (op->flag != tmp->flag) 1401 if (op->flag != arch->flag)
1398 for (i = 0; i <= NUM_FLAGS; i++) 1402 for (int i = 0; i <= NUM_FLAGS; i++)
1399 if (flag_names [i] && op->flag [i] != tmp->flag [i]) 1403 if (expect_false (flag_names [i] && op->flag [i] != arch->flag [i]))
1400 f.put (flag_names [i], op->flag [i] ? "1" : "0"); 1404 f.put (flag_names [i], op->flag [i] ? "1" : "0");
1405 }
1406 else
1407 {
1408 // only obj_original differs
1409 f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? "1" : "0");
1410 }
1411 }
1401 1412
1402 // save body locations 1413 // save body locations. gcc's memcmp does an abysmal job when used
1403 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 1414 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
1404 if (op->slot[i].info != tmp->slot[i].info) 1415 if (expect_false (op->slot[i].info != arch->slot[i].info))
1405 f.put (body_locations[i].save_name, op->slot[i].info); 1416 f.put (body_locations[i].save_name, op->slot[i].info);
1406} 1417}
1407 1418
1408/* 1419/*
1409 * Dumps all variables in an object to a file. 1420 * Dumps all variables in an object to a file.
1411 * the only place this is not set is when saving the player. 1422 * the only place this is not set is when saving the player.
1412 */ 1423 */
1413bool 1424bool
1414object::write (object_freezer &f) 1425object::write (object_freezer &f)
1415{ 1426{
1416 /* Even if the object does have an owner, it would seem that we should 1427 if (is_arch ())
1417 * still save it. 1428 {
1418 */ 1429 f.put (KW_object, arch->archname);
1419 if (owner) 1430 write_diff (f, this, archetype::empty);
1420 return true; 1431 }
1421 1432 else
1422 archetype *at = arch ? (archetype *)arch : empty_archetype; 1433 {
1423
1424 f.put (KW_arch, at->name); 1434 f.put (KW_arch, arch->archname);
1425 write_diff (f, this, &at->clone); 1435 write_diff (f, this, arch);
1436 }
1426 1437
1427 for (object *tmp = inv; tmp; tmp = tmp->below) 1438 for (object *tmp = inv; tmp; tmp = tmp->below)
1428 tmp->write (f); 1439 tmp->write (f);
1429 1440
1430 f.put (this); 1441 f.put (this);
1435 1446
1436///////////////////////////////////////////////////////////////////////////// 1447/////////////////////////////////////////////////////////////////////////////
1437 1448
1438// generic resource file load, 1449// generic resource file load,
1439// currently supports: region, treasures, archetypes 1450// currently supports: region, treasures, archetypes
1451bool
1440bool load_resource_file (const char *filename) 1452load_resource_file_ (const char *filename)
1441{ 1453{
1442 object_thawer f (filename); 1454 object_thawer f (filename);
1443
1444 bool success = false;
1445 bool seen_arch = false;
1446
1447 f.next ();
1448 1455
1449 for (;;) 1456 for (;;)
1450 { 1457 {
1451 switch (f.kw) 1458 switch (f.kw)
1452 { 1459 {
1453 case KW_region: 1460 case KW_region:
1454 if (!region::read (f)) 1461 if (!region::read (f))
1455 goto finish; 1462 return false;
1456 break; 1463 break;
1457 1464
1458 case KW_treasure: 1465 case KW_treasure:
1459 case KW_treasureone: 1466 case KW_treasureone:
1460 if (!treasurelist::read (f)) 1467 if (!treasurelist::read (f))
1461 goto finish; 1468 return false;
1462 break; 1469 break;
1463 1470
1464 case KW_object: 1471 case KW_object:
1465 seen_arch = true;
1466 if (!archetype::read (f)) 1472 if (!archetype::read (f))
1467 goto finish; 1473 return false;
1468 break; 1474 break;
1469 1475
1470 case KW_EOF: 1476 case KW_EOF:
1471 success = true; 1477 return true;
1472 goto finish;
1473 1478
1474 default: 1479 default:
1475 if (!f.parse_error ("resource file")) 1480 if (!f.parse_error ("resource file"))
1476 goto finish; 1481 return false;
1477 1482
1478 f.next (); 1483 f.next ();
1479 break; 1484 break;
1480 } 1485 }
1481 } 1486 }
1482
1483finish:
1484 if (seen_arch)
1485 init_archetype_pointers ();
1486
1487 return success;
1488} 1487}
1489 1488

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines