ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/loader.C
(Generate patch)

Comparing deliantra/server/common/loader.C (file contents):
Revision 1.74 by root, Sat Apr 28 18:18:04 2007 UTC vs.
Revision 1.156 by root, Sun Apr 18 12:37:07 2010 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
21 * 21 *
22 * The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 23 */
24 24
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying
27 variable. */
28
29#include <global.h> 25#include <global.h>
30#include <loader.h>
31#include <sproto.h> 26#include <sproto.h>
32 27
33///////////////////////////////////////////////////////////////////////////// 28/////////////////////////////////////////////////////////////////////////////
29
30extern archetype *loading_arch;
31
32//+GPL
34 33
35/* This table is only necessary to convert objects that existed before the 34/* This table is only necessary to convert objects that existed before the
36 * spell object conversion to the new object. It was not practical 35 * spell object conversion to the new object. It was not practical
37 * to go through every mapping looking for every potion, rod, wand, etc 36 * to go through every mapping looking for every potion, rod, wand, etc
38 * that had a sp set and update to the new value. So this maps the 37 * that had a sp set and update to the new value. So this maps the
… …
168 "spell_magic_drain", /* 122 */ 167 "spell_magic_drain", /* 122 */
169 "spell_counterspell", /* 123 */ 168 "spell_counterspell", /* 123 */
170 "spell_disarm", /* 124 */ 169 "spell_disarm", /* 124 */
171 "spell_cure_confusion", /* 125 */ 170 "spell_cure_confusion", /* 125 */
172 "spell_restoration", /* 126 */ 171 "spell_restoration", /* 126 */
173 "was summon evil monster", /* 127 *//* Not implenented as nothing used it */ 172 "spell_summon_devil", /* 127 *//* Not implenented as nothing used it */
174 "spell_counterwall", /* 128 */ 173 "spell_counterwall", /* 128 */
175 "spell_cause_light_wounds", /* 129 */ 174 "spell_cause_light_wounds", /* 129 */
176 "spell_cause_medium_wounds", /* 130 */ 175 "spell_cause_medium_wounds", /* 130 */
177 "spell_cause_heavy_wounds", /* 131 */ 176 "spell_cause_heavy_wounds", /* 131 */
178 "spell_charm_monsters", /* 132 */ 177 "spell_charm_monsters", /* 132 */
… …
250 "spell_cause_rabies", /* 204 */ 249 "spell_cause_rabies", /* 204 */
251 "spell_glyph", /* 205 */ 250 "spell_glyph", /* 205 */
252 NULL 251 NULL
253}; 252};
254 253
255extern bool loading_arch;
256
257/* This function checks the object after it has been loaded (when we 254/* This function checks the object after it has been loaded (when we
258 * get the 'end' in the input stream). This function can be used to 255 * get the 'end' in the input stream). This function can be used to
259 * deal with legacy objects where fields may have changed. It can also be used 256 * deal with legacy objects where fields may have changed. It can also be used
260 * to check for objects to make sure there are no common errors. 257 * to check for objects to make sure there are no common errors.
261 */ 258 */
262static void 259void
263check_loaded_object (object *op) 260object::post_load_check ()
264{ 261{
262 if (type >= NUM_TYPES)
263 {
264 LOG (llevError, "ITEMBUG: %s: type out of range, resetting to 0.\n", debug_desc ());
265 type = 0;
266 }
267
268 switch (type)
269 {
270 case BOW:
271 case WAND:
272 case ROD:
273 case HORN:
274 if (slot [body_range].info != -1)
275 {
276 LOG (llevError, "ITEMBUG: %s: body_range %d != -1\n", debug_desc (), slot [body_range].info);
277 slot [body_range].info = -1;
278 }
279 break;
280
281 case WEAPON:
282 if (slot [body_combat].info != -1)
283 {
284 LOG (llevError, "ITEMBUG: %s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info);
285 slot [body_combat].info = -1;
286 }
287 break;
288
289 case SHIELD:
290 if (slot [body_shield].info != -1)
291 {
292 LOG (llevError, "ITEMBUG: %s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info);
293 slot [body_shield].info = -1;
294 }
295 break;
296
297 case PLAYER:
298 if (slot [body_shield].info != 1)
299 {
300 LOG (llevError, "ITEMBUG: %s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info);
301 slot [body_shield].info = 1;
302 }
303
304 if (slot [body_combat].info != 1)
305 {
306 LOG (llevError, "ITEMBUG: %s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info);
307 slot [body_combat].info = 1;
308 }
309
310 if (slot [body_range].info != 1)
311 {
312 LOG (llevError, "ITEMBUG: %s: body_range %d != 1\n", debug_desc (), slot [body_range].info);
313 slot [body_range].info = 1;
314 }
315 break;
316 }
317
265 /* We do some specialised handling to handle legacy cases of name_pl. 318 /* We do some specialised handling to handle legacy cases of name_pl.
266 * If the object doesn't have a name_pl, we just use the object name - 319 * If the object doesn't have a name_pl, we just use the object name -
267 * this isn't perfect (things won't be properly pluralised), but works to 320 * this isn't perfect (things won't be properly pluralised), but works to
268 * that degree (5 heart is still quite understandable). But the case we 321 * that degree (5 heart is still quite understandable). But the case we
269 * also have to catch is if this object is not using the normal name for 322 * also have to catch is if this object is not using the normal name for
270 * the object. In that case, we also want to use the loaded name. 323 * the object. In that case, we also want to use the loaded name.
271 * Otherwise, what happens is that the the plural name will lose 324 * Otherwise, what happens is that the the plural name will lose
272 * information (appear as just 'hearts' and not 'goblins heart') 325 * information (appear as just 'hearts' and not 'goblins heart')
273 */ 326 */
274 if (op->arch && op->name != op->arch->clone.name && op->name_pl == op->arch->clone.name_pl) 327 if (arch && name != arch->object::name && name_pl == arch->object::name_pl)
275 op->name_pl = 0; 328 name_pl = 0;
276 329
277 if (!op->name_pl) 330 if (!name_pl)
278 op->name_pl = op->name; 331 name_pl = name;
279 332
280 /* objects now have a materialname. try to patch it in */ 333 /* objects now have a materialname. try to patch it in */
281 if (!(op->is_weapon () && op->level > 0)) 334 if (material == MATERIAL_NULL && !(is_weapon () && level > 0))
335 select_material (this, map ? map->difficulty : 5);
336
337 if (speed < 0.)
282 { 338 {
283 if (op->map != NULL) 339 flag [FLAG_RANDOM_SPEED] = true;
284 set_materialname (op, op->map->difficulty, NULL); 340 speed = -speed;
285 else 341 // speed_left will be randomised in instantiate () and copy_to ()
286 set_materialname (op, 5, NULL);
287 } 342 }
288 343
289 /* only do these when program is first run - a bit 344 /* only do these when program is first run - a bit
290 * excessive to do this at every run - most of this is 345 * excessive to do this at every run - most of this is
291 * really just to catch any errors - program will still run, but 346 * really just to catch any errors - program will still run, but
292 * not in the ideal fashion. 347 * not in the ideal fashion.
293 */ 348 */
294 if ((op->type == WEAPON || op->type == BOW) && loading_arch) 349 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND))
295 { 350 {
296 if (!op->skill) 351 if (!skill)
297 LOG (llevError, "Weapon %s lacks a skill.\n", op->debug_desc ()); 352 LOG (llevError, "ITEMBUG: weapon %s lacks a skill.\n", debug_desc ());
298 else if ((!strcmp (op->skill, "one handed weapons") && op->body_info[1] != -1) || 353 else if ((skill == shstr_one_handed_weapons && slot[body_arm].info != -1) ||
299 (!strcmp (op->skill, "two handed weapons") && op->body_info[1] != -2)) 354 (skill == shstr_two_handed_weapons && slot[body_arm].info != -2))
300 LOG (llevError, "weapon %s arm usage does not match skill: %d, %s\n", op->debug_desc (), op->body_info[1], &op->skill); 355 LOG (llevError, "ITEMBUG: weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill);
301 } 356 }
302 357
303 /* We changed last_heal to gen_sp_armour, which is what it 358 /* We changed last_heal to gen_sp_armour, which is what it
304 * really does for many objects. Need to catch any in maps 359 * really does for many objects. Need to catch any in maps
305 * that may have an old value. 360 * that may have an old value.
306 */ 361 */
307 if (op->type == WEAPON 362 if (type == WEAPON
308 || op->type == ARMOUR || op->type == HELMET 363 || type == ARMOUR || type == HELMET
309 || op->type == SHIELD || op->type == RING 364 || type == SHIELD || type == RING
310 || op->type == BOOTS || op->type == GLOVES 365 || type == BOOTS || type == GLOVES
311 || op->type == AMULET || op->type == GIRDLE 366 || type == AMULET || type == GIRDLE
312 || op->type == BRACERS || op->type == CLOAK) 367 || type == BRACERS || type == CLOAK)
313 { 368 {
314 if (op->last_heal) 369 if (last_heal)
315 { 370 {
316 LOG (llevDebug, "Object %s still has last_heal set, not gen_sp_armour\n", op->debug_desc ()); 371 LOG (llevError, "ITEMBUG: object %s still has last_heal set, not gen_sp_armour\n", debug_desc ());
317 op->gen_sp_armour = op->last_heal; 372 gen_sp_armour = last_heal;
318 op->last_heal = 0; 373 last_heal = 0;
319 } 374 }
320 375
321 int ip = calc_item_power (op, 0); 376 int ip = calc_item_power (this, 0);
322 377
323 /* Legacy objects from before item power was in the game */ 378 /* Legacy objects from before item power was in the game */
324 if (!op->item_power && ip) 379 if (!item_power && ip)
325 { 380 {
326 if (ip > 3) 381 if (ip > 3)
327 LOG (llevDebug, "Object %s had no item power, using %d\n", op->debug_desc (), ip); 382 LOG (llevDebug, "ITEMBUG: Object %s had no item power, using %d\n", debug_desc (), ip);
328 383
329 op->item_power = ip; 384 item_power = ip;
330 } 385 }
331 386
332 /* Check for possibly bogus values. Has to meet both these criteria - 387 /* Check for possibly bogus values. Has to meet both these criteria -
333 * something that has item_power 1 is probably just fine if our calculated 388 * something that has item_power 1 is probably just fine if our calculated
334 * value is 1 or 2 - these values are small enough that hard to be precise. 389 * value is 1 or 2 - these values are small enough that hard to be precise.
335 * similarly, it item_power is 0, the first check will always pass, 390 * similarly, it item_power is 0, the first check will always pass,
336 * but not the second one. 391 * but not the second one.
337 */ 392 */
393#if 0 //TODO
338 if (ip > 2 * op->item_power && ip > (op->item_power + 3)) 394 if (ip > 2 * item_power && ip > (item_power + 3))
339 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", op->debug_desc (), ip, op->item_power); 395 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power);
396#endif
340 } 397 }
341 398
342 /* Old spellcasting object - need to load in the appropiate object */ 399 /* old style spellcasting object (pretty common) - need to load in the appropriate object */
343 if ((op->type == ROD || op->type == WAND || op->type == SCROLL || op->type == HORN || op->type == FIREWALL || 400 /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */
401 if ((type == ROD
402 || type == WAND
403 || type == SCROLL
404 || type == HORN
405 || type == FIREWALL
344 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */ 406 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */
345 ((op->type == POTION || op->type == ALTAR) && op->stats.sp)) && !op->inv && !loading_arch) 407 || ((type == POTION || type == ALTAR) && stats.sp)) // watchout: sp = 0 is still magic bullet.
408 && !inv
409 && !loading_arch
410 && stats.sp) // watchout: old magic bullet stuff directly on the map is going to break here!
411 // TODO: at least one watchout-comments is redundant - investigate/remove
346 { 412 {
413 // TODO: fix firewall object on map
347 /* Fireall is bizarre in that spell type was stored in dam. Rest are 'normal' 414 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal'
348 * in that spell was stored in sp. 415 * in that spell was stored in sp.
349 */ 416 */
417 //LOG (llevError, "old spellcasting object found: %s", debug_desc ());
350 object *tmp = get_archetype (spell_mapping[op->type == FIREWALL ? op->stats.dam : op->stats.sp]); 418 object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]);
351 insert_ob_in_ob (tmp, op); 419 insert_ob_in_ob (tmp, this);
352 op->randomitems = NULL; /* So another spell isn't created for this object */ 420 randomitems = 0;
353 } 421 }
354 422
355 /* spellbooks & runes use slaying. But not to arch name, but to spell name */ 423 /* spellbooks & runes use slaying. But not to arch name, but to spell name */
356 if ((op->type == SPELLBOOK || op->type == RUNE) && op->slaying && !op->inv && !loading_arch) 424 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch)
357 { 425 {
426 LOG (llevError, "ITEMBUG: spellbook/rune found without inv but slaying: %s", debug_desc ());
358 object *tmp = get_archetype_by_object_name (op->slaying); 427 object *tmp = get_archetype_by_object_name (slaying);
359 insert_ob_in_ob (tmp, op); 428 insert_ob_in_ob (tmp, this);
360 op->randomitems = NULL; /* So another spell isn't created for this object */ 429 randomitems = 0; /* So another spell isn't created for this object */
361 /* without this, value is all screwed up */ 430 /* without this, value is all screwed up */
362 op->value = op->arch->clone.value * op->inv->value; 431 value = arch->value * inv->value;
363 }
364
365 if (QUERY_FLAG (op, FLAG_MONSTER))
366 { 432 }
433
434 if (this->flag [FLAG_MONSTER])
435 {
367 if (op->stats.hp > op->stats.maxhp) 436 if (stats.hp > stats.maxhp)
368 { 437 {
369 LOG (llevDebug, "Monster %s has hp set higher than maxhp (%d>%d)\n", op->debug_desc (), op->stats.hp, op->stats.maxhp); 438 LOG (llevInfo, "ITEMBUG: monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp);
370 op->stats.maxhp = op->stats.hp; 439 stats.maxhp = stats.hp;
371 } 440 }
372 441
373 /* The archs just need to be updated for this */ 442 /* The archs just need to be updated for this */
374 if (op->move_type == 0) 443 if (move_type == 0)
375 op->move_type = MOVE_WALK; 444 move_type = MOVE_WALK;
376 }
377
378 if ((QUERY_FLAG (op, FLAG_GENERATOR) && QUERY_FLAG (op, FLAG_CONTENT_ON_GEN)) || op->type == CREATOR || op->type == CONVERTER)
379 { 445 }
446
447 if ((this->flag [FLAG_GENERATOR] && this->flag [FLAG_CONTENT_ON_GEN]) || type == CREATOR || type == CONVERTER)
380 /* Object will duplicate it's content as part of the 448 /* Object will duplicate it's content as part of the
381 * generation process. To do this, we must flag inventory 449 * generation process. To do this, we must flag inventory
382 * so it remains unevaluated concerning the randomitems and 450 * so it remains unevaluated concerning the randomitems and
383 * the living (a demonlord shouldn't cast from inside generator!) 451 * the living (a demonlord shouldn't cast from inside generator!)
384 */ 452 */
453 /* ??? this *should* be done elsewhere, e.g. after map loading etc. */
385 flag_inv (op, FLAG_IS_A_TEMPLATE); 454 flag_inv (this, FLAG_IS_A_TEMPLATE);
386 }
387 455
388 /* Handle player movers. We use move_type for player movers 456 /* Handle player movers. We use move_type for player movers
389 * because they operate on their own time (move_on 457 * because they operate on their own time (move_on
390 * would potentially cause them to be triggered when someone steps 458 * would potentially cause them to be triggered when someone steps
391 * on them). If move_type is set, presume person knows what they 459 * on them). If move_type is set, presume person knows what they
392 * are doing, otherwise, set move_type based on maxhp value. 460 * are doing, otherwise, set move_type based on maxhp value.
393 */ 461 */
394 if (op->type == PLAYERMOVER) 462 if (type == PLAYERMOVER)
395 { 463 {
396 if (!op->move_type) 464 if (!move_type)
397 { 465 {
398 if (op->stats.maxhp) 466 if (stats.maxhp)
399 { 467 {
400 op->move_type = MOVE_ALL; 468 move_type = MOVE_ALL;
401 op->stats.maxhp = 0; 469 stats.maxhp = 0;
402 } 470 }
403 else 471 else
404 op->move_type = MOVE_WALK; 472 move_type = MOVE_WALK;
405 } 473 }
406 } 474 }
407 475
476 // if the object has an animation, try to provide a default face
477 if (has_anim ())
478 {
479 const animation &anim_ob = anim ();
480
481 if (anim_speed)
482 // if this item is time-animated, force the last frame
483 animate_object (this, 0);
484 else if (flag [FLAG_MONSTER])
485 // if it is a monster, set appropriate facing
486 animate_object (this, direction);
487 }
408} 488}
409 489
410static void 490static void
411set_move (MoveType &mt, const char *str) 491set_move (MoveType &mt, object_thawer &f)
412{ 492{
413 static const struct flagstr { 493 static const struct flagstr {
414 const char *name; 494 const char *name;
415 MoveType flags; 495 MoveType flags;
416 } move_flags[] = { 496 } move_flags[] = {
… …
422 { "boat" , MOVE_BOAT }, 502 { "boat" , MOVE_BOAT },
423 { "ship" , MOVE_SHIP }, 503 { "ship" , MOVE_SHIP },
424 { "all" , MOVE_ALL }, 504 { "all" , MOVE_ALL },
425 }; 505 };
426 506
427 if (!str) 507 const char *str = f.get_str ();
428 {
429 mt = 0;
430 return;
431 }
432 508
433 if (isdigit (*str)) 509 if (!*str || isdigit (*str))
434 { 510 {
435 mt = atoi (str); 511 mt = atoi (str);
436 return; 512 return;
437 } 513 }
438 514
439 mt = 0; 515 mt = 0;
440 516
441 for (str = strtok ((char *) str, " "); str; str = strtok (0, " ")) 517 for (str = strtok ((char *)str, " "); str; str = strtok (0, " "))
442 { 518 {
443 bool negate = 0; 519 bool negate = 0;
444 520
445 if (*str == '-') 521 if (*str == '-')
446 { 522 {
… …
459 535
460 goto next; 536 goto next;
461 } 537 }
462 } 538 }
463 539
464 LOG (llevDebug, "common/loader.C: set_move - unknown move string '%s'\n", str); 540 LOG (llevError, "common/loader.C: set_move - unknown move string '%s'\n", str);
465 541
466next: ; 542next: ;
467 } 543 }
468} 544}
469 545
470#define GET_FLAG(op,flag) \ 546//-GPL
471 if (f.get_sint32 ()) \ 547
472 SET_FLAG (op, flag); \ 548#define GET_FLAG(op,flg) op->flag [flg] = f.get_bool ()
473 else \
474 CLEAR_FLAG (op, flag) \
475 549
476bool 550bool
477object::parse_kv (object_thawer &f) 551object::parse_kv (object_thawer &f)
478{ 552{
479 object *op_inv = inv; 553 object *op_inv = inv;
554 key_value *last_kv = key_values;
480 555
481 for (;;) 556 for (;;)
482 { 557 {
483 switch (f.kw) 558 switch (f.kw)
484 { 559 {
485 case KW_uuid: 560 case KW_uuid:
486 if (const char *s = f.get_str ()) 561 if (!uuid.parse (f.get_str ()))
487 { 562 {
488 unsigned int version; 563 f.parse_warn ("unparseable uuid");
489 unsigned long long seq; 564 uuid = UUID::gen ();
490
491 if (2 == sscanf (s, "<%d.%llx>", &version, &seq) && version == 1)
492 {
493 uuid.seq = seq;
494 break;
495 }
496 } 565 }
497
498 uuid = gen_uuid ();
499 break; 566 break;
500 567
501 case KW_oid: 568 case KW_oid:
502 f.get (this, f.get_sint32 ()); 569 f.get (this, f.get_sint32 ());
503 break; 570 break;
… …
509 576
510 case KW_attach: f.get_ornull (attach); break; 577 case KW_attach: f.get_ornull (attach); break;
511 case KW_skill: f.get_ornull (skill); break; 578 case KW_skill: f.get_ornull (skill); break;
512 case KW_race: f.get_ornull (race); break; 579 case KW_race: f.get_ornull (race); break;
513 case KW_slaying: f.get_ornull (slaying); break; 580 case KW_slaying: f.get_ornull (slaying); break;
581 case KW_tag: f.get_ornull (tag); break;
514 582
515 case KW_arch: 583 case KW_arch:
516 {
517 object *tmp = object::read (f); 584 if (object *tmp = object::read (f))
518 tmp->deactivate ();
519
520 { 585 {
586 tmp->deactivate ();
587
521 // was: insert_ob_in_ob (tmp, op); 588 // was: insert_ob_in_ob (tmp, op);
522 // but manually adding it can improve map loading times a lot 589 // but manually adding it can improve map loading times a lot
523 // also, appending instead of prepending keeps the 590 // also, appending instead of prepending keeps the
524 // save ordering the same between repeated load/saves. 591 // save ordering the same between repeated load/saves.
525 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL); 592 // and finally we do not want any funny effects
526 CLEAR_FLAG (tmp, FLAG_REMOVED); 593 tmp->clr_flag (FLAG_OBJ_ORIGINAL);
594 tmp->clr_flag (FLAG_REMOVED);
527 595
528 if (!op_inv) 596 if (!op_inv)
529 { 597 {
530 inv = tmp; 598 inv = tmp;
531 tmp->above = 0; 599 tmp->above = 0;
… …
541 609
542 tmp->below = 0; 610 tmp->below = 0;
543 tmp->env = this; 611 tmp->env = this;
544 op_inv = tmp; 612 op_inv = tmp;
545 } 613 }
546 } 614 else
615 LOG (llevError, "ERROR: couldn't load inventory object, file corrupted?\n");
616
547 continue; 617 continue;
548 618
549 case KW_other_arch: 619 case KW_other_arch:
550 other_arch =
551 loading_arch 620 if (loading_arch == this)
552 ? archetype::get (f.get_str ()) 621 archetype::postpone_arch_ref (loading_arch->other_arch, f.get_str ());
622 else
623 {
553 : archetype::find (f.get_str ()); 624 other_arch = archetype::find (f.get_str ());
554 625
555 if (!other_arch) 626 if (!other_arch)
556 LOG (llevError, "%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()); 627 f.parse_warn (format ("%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()));
628 }
629 break;
630
631 case KW_owner:
632 f.delayed_deref (this, owner, f.get_str ());
557 break; 633 break;
558 634
559 case KW_animation: 635 case KW_animation:
560 { 636 {
561 CLEAR_FLAG (this, FLAG_ANIMATE); 637 this->clr_flag (FLAG_ANIMATE);
562 animation_id = 0; 638 animation_id = 0;
563 639
564 const char *str = f.get_str ();
565 if (str && (animation_id = find_animation (str))) 640 if (f.has_value () && (animation_id = find_animation (f.get_str ())))
566 SET_FLAG (this, FLAG_ANIMATE); 641 this->set_flag (FLAG_ANIMATE); //TODO: should not be forced to true here
567 } 642 }
568 break; 643 break;
569 644
570 case KW_last_heal: f.get (last_heal); break; 645 case KW_last_heal: f.get (last_heal); break;
571 case KW_last_sp: f.get (last_sp); break; 646 case KW_last_sp: f.get (last_sp); break;
572 case KW_last_grace: f.get (last_grace); break; 647 case KW_last_grace: f.get (last_grace); break;
573 case KW_last_eat: f.get (last_eat); break; 648 case KW_last_eat: f.get (last_eat); break;
649 case KW_sl:
574 case KW_speed_left: f.get (speed_left); break; 650 case KW_speed_left: f.get (speed_left); break;
575 651
576 case KW_speed: 652 case KW_speed:
577 f.get (speed); 653 f.get (speed);
578 654
… …
587 move_slow |= MOVE_WALK; 663 move_slow |= MOVE_WALK;
588 f.get (move_slow_penalty); 664 f.get (move_slow_penalty);
589 break; 665 break;
590 666
591 case KW_face: 667 case KW_face:
668 face = f.has_value () ? face_find (f.get_str ()) : blank_face;
669 break;
670
671 case KW_sound:
672 if (f.has_value ())
673 {
592 face = face_find (f.get_str ()); 674 sound = sound_find (f.get_str ());
675 if (!sound)
676 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
677 }
678 else
679 sound = 0;
680 break;
681
682 case KW_sound_destroy:
683 if (f.has_value ())
684 {
685 sound_destroy = sound_find (f.get_str ());
686 if (!sound_destroy)
687 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
688 }
689 else
690 sound_destroy = 0;
593 break; 691 break;
594 692
595 case KW_x: f.get (x); break; 693 case KW_x: f.get (x); break;
596 case KW_y: f.get (y); break; 694 case KW_y: f.get (y); break;
597 695
… …
638 case KW_invisible: f.get (invisible); break; 736 case KW_invisible: f.get (invisible); break;
639 case KW_magic: f.get (magic); break; 737 case KW_magic: f.get (magic); break;
640 case KW_state: f.get (state); break; 738 case KW_state: f.get (state); break;
641 case KW_move_slow_penalty: f.get (move_slow_penalty); break; 739 case KW_move_slow_penalty: f.get (move_slow_penalty); break;
642 case KW_material: f.get (materials); break; //TODO: nuke 740 case KW_material: f.get (materials); break; //TODO: nuke
643 case KW_materialname: f.get (materialname); break; 741
742 case KW_materialname:
743 {
744 shstr sh;
745 f.get (sh);
746 material = name_to_material (sh);
747 }
748 break;
644 749
645 /* These are the new values */ 750 /* These are the new values */
646 case KW_move_block: set_move (move_block, f.get_str ()); break; 751 case KW_move_block: set_move (move_block, f); break;
647 case KW_move_allow: set_move (move_allow, f.get_str ()); break; 752 case KW_move_allow: set_move (move_allow, f); break;
648 case KW_move_type: set_move (move_type, f.get_str ()); break; 753 case KW_move_type: set_move (move_type , f); break;
649 case KW_move_on: set_move (move_on, f.get_str ()); break; 754 case KW_move_on: set_move (move_on , f); break;
650 case KW_move_off: set_move (move_off, f.get_str ()); break; 755 case KW_move_off: set_move (move_off , f); break;
651 case KW_move_slow: set_move (move_slow, f.get_str ()); break; 756 case KW_move_slow: set_move (move_slow , f); break;
652 757
653 /* These are all legacy - any new objects should use the move_ .. values */ 758 /* These are all legacy - any new objects should use the move_ .. values */
654 case KW_no_pass: 759 case KW_no_pass:
655 { 760 {
656 if (f.get_sint32 ()) 761 if (f.get_sint32 ())
… …
719 824
720 825
721 case KW_identified: 826 case KW_identified:
722 GET_FLAG (this, FLAG_IDENTIFIED); 827 GET_FLAG (this, FLAG_IDENTIFIED);
723 //TODO: move to check_object or so 828 //TODO: move to check_object or so
724 if (QUERY_FLAG (this, FLAG_IDENTIFIED)) 829 if (this->flag [FLAG_IDENTIFIED])
725 CLEAR_FLAG (this, FLAG_KNOWN_MAGICAL); 830 this->clr_flag (FLAG_KNOWN_MAGICAL);
726 831
727 break;
728
729 case KW_wiz:
730 GET_FLAG (this, FLAG_WIZ);
731 //TODO: move to check_object
732 if (QUERY_FLAG (this, FLAG_WIZ))
733 {
734 SET_FLAG (this, FLAG_WAS_WIZ);
735 SET_FLAG (this, FLAG_WIZPASS);
736 SET_FLAG (this, FLAG_WIZCAST);
737 }
738 else
739 {
740 CLEAR_FLAG (this, FLAG_WIZPASS);
741 CLEAR_FLAG (this, FLAG_WIZCAST);
742 }
743 break; 832 break;
744 833
745 case KW_friendly: 834 case KW_friendly:
746 if (f.get_sint32 ()) 835 if (f.get_bool ())
747 if (type != PLAYER) 836 if (type != PLAYER)
748 add_friendly_object (this); 837 add_friendly_object (this);
749 838
750 break; 839 break;
751 840
… …
764 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break; 853 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break;
765 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break; 854 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break;
766 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break; 855 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break;
767 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break; 856 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break;
768 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break; 857 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break;
858 case KW_player_sold: GET_FLAG (this, FLAG_PLAYER_SOLD); break;
769 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break; 859 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break;
770 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break; 860 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break;
771 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break; 861 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break;
772 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break; 862 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break;
773 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break; 863 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break;
… …
780 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break; 870 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break;
781 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break; 871 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break;
782 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break; 872 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break;
783 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break; 873 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break;
784 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break; 874 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break;
785 case KW_was_wiz: GET_FLAG (this, FLAG_WAS_WIZ); break;
786 case KW_no_fix_player: GET_FLAG (this, FLAG_NO_FIX_PLAYER); break;
787 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break; 875 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break;
788 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break; 876 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break;
789 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break; 877 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break;
790 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break; 878 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break;
791 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break; 879 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break;
… …
835 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break; 923 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break;
836 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break; 924 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break;
837 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break; 925 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break;
838 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break; 926 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break;
839 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break; 927 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break;
928 case KW_random_speed: GET_FLAG (this, FLAG_RANDOM_SPEED); break;
840 929
841 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break; 930 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break;
842 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break; 931 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break;
843 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break; 932 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break;
844 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break; 933 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break;
… …
874 case KW_anim_speed: f.get (anim_speed); break; 963 case KW_anim_speed: f.get (anim_speed); break;
875 case KW_container: f.get (weight_limit); break; 964 case KW_container: f.get (weight_limit); break;
876 case KW_will_apply: f.get (will_apply); break; 965 case KW_will_apply: f.get (will_apply); break;
877 case KW_attack_movement: f.get (attack_movement); break; 966 case KW_attack_movement: f.get (attack_movement); break;
878 case KW_move_state: f.get (move_status); break; 967 case KW_move_state: f.get (move_status); break;
879 case KW_expmul: f.get (expmul); break; 968 //case KW_expmul: f.get (expmul); break;//D declared const for the time being
880 case KW_glow_radius: f.get (glow_radius); break; 969 case KW_glow_radius: f.get (glow_radius); break;
881 case KW_weapontype: f.get (weapontype); break; 970 case KW_weapontype: f.get (weapontype); break;
882 case KW_tooltype: f.get (tooltype); break;
883 case KW_casting_time: f.get (casting_time); break; 971 case KW_casting_time: f.get (casting_time); break;
972
973 // elevation is deprecated
884 case KW_elevation: f.get (elevation); break; 974 case KW_elevation: break;
975
885 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break; 976 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break;
886 case KW_client_type: f.get (client_type); break; 977 case KW_client_type: f.get (client_type); break;
887 case KW_duration: f.get (duration); break; 978 case KW_duration: f.get (duration); break;
888 case KW_range: f.get (range); break; 979 case KW_range: f.get (range); break;
889 case KW_range_modifier: f.get (range_modifier); break; 980 case KW_range_modifier: f.get (range_modifier); break;
890 case KW_dam_modifier: f.get (dam_modifier); break; 981 case KW_dam_modifier: f.get (dam_modifier); break;
891 case KW_duration_modifier: f.get (duration_modifier); break; 982 case KW_duration_modifier: f.get (duration_modifier); break;
892 983
893 //TODO: mechanism to ensure that KW_xxx is consecutive needed from include/preprocess 984 //TODO: mechanism to ensure that KW_xxx is consecutive needed from include/preprocess
894 //TODO: parse from other include files 985 //TODO: parse from other include files
895 case KW_body_range: f.get (body_info[0]); break; 986 case KW_body_range: slot[body_range] .info = f.get_sint32 (); break;
896 case KW_body_arm: f.get (body_info[1]); break; 987 case KW_body_shield: slot[body_shield] .info = f.get_sint32 (); break;
897 case KW_body_torso: f.get (body_info[2]); break; 988 case KW_body_combat: slot[body_combat] .info = f.get_sint32 (); break;
898 case KW_body_head: f.get (body_info[3]); break; 989 case KW_body_arm: slot[body_arm] .info = f.get_sint32 (); break;
899 case KW_body_neck: f.get (body_info[4]); break; 990 case KW_body_torso: slot[body_torso] .info = f.get_sint32 (); break;
900 case KW_body_skill: f.get (body_info[5]); break; 991 case KW_body_head: slot[body_head] .info = f.get_sint32 (); break;
901 case KW_body_finger: f.get (body_info[6]); break; 992 case KW_body_neck: slot[body_neck] .info = f.get_sint32 (); break;
902 case KW_body_shoulder: f.get (body_info[7]); break; 993 case KW_body_skill: slot[body_skill] .info = f.get_sint32 (); break;
903 case KW_body_foot: f.get (body_info[8]); break; 994 case KW_body_finger: slot[body_finger] .info = f.get_sint32 (); break;
904 case KW_body_hand: f.get (body_info[9]); break; 995 case KW_body_shoulder: slot[body_shoulder].info = f.get_sint32 (); break;
905 case KW_body_wrist: f.get (body_info[10]); break; 996 case KW_body_foot: slot[body_foot] .info = f.get_sint32 (); break;
906 case KW_body_waist: f.get (body_info[11]); break; 997 case KW_body_hand: slot[body_hand] .info = f.get_sint32 (); break;
998 case KW_body_wrist: slot[body_wrist] .info = f.get_sint32 (); break;
999 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break;
907 case KW_can_apply: 1000 case KW_can_apply:
908 break; 1001 break;
909 1002
910 case KW_connected: 1003 case KW_connected:
911 add_button_link (this, map, f.get_sint32 ()); 1004 {
1005 shstr connected;
1006
1007 f.get (connected);
1008 add_link (map, connected);
1009 }
912 break; 1010 break;
913 1011
914 case KW_randomitems: 1012 case KW_randomitems:
915 if (f.get_str ()) 1013 if (f.has_value ())
916 { 1014 {
917 randomitems = 1015 randomitems =
918 loading_arch 1016 loading_arch
919 ? treasurelist::get (f.get_str ()) 1017 ? treasurelist::get (f.get_str ())
920 : treasurelist::find (f.get_str ()); 1018 : treasurelist::find (f.get_str ());
921 1019
922 if (!randomitems) 1020 if (!randomitems)
1021 {
923 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ()); 1022 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ());
1023 randomitems = treasurelist::get (shstr_none); // avoid crashes
1024 }
924 } 1025 }
1026 else
1027 randomitems = 0;
925 break; 1028 break;
926 1029
927 case KW_msg: 1030 case KW_msg:
928 f.get_ml (KW_endmsg, msg); 1031 f.get_ml (KW_endmsg, msg);
929 //TODO: allow longer messages
930 if (strlen (msg) >= HUGE_BUF)
931 {
932 LOG (llevDebug, "\tError message length >= %d: %d\n>%.80s<\n", HUGE_BUF, strlen (msg), &msg);
933 msg = "ERROR, please report: string too long, winged.\n";
934 }
935 break; 1032 break;
936 1033
937 case KW_lore: 1034 case KW_lore:
938 f.get_ml (KW_endlore, lore); 1035 f.get_ml (KW_endlore, lore);
939 //TODO: allow longer messages
940 /* Just print a warning so we can be reasonably safe
941 * about not overflowing the buffer.
942 */
943 if (strlen (lore) > (HUGE_BUF / 2))
944 LOG (llevDebug, "\tWarning lore length > %d (max allowed=%d): %d\n>%.80s<\n",
945 HUGE_BUF / 2, HUGE_BUF, strlen (lore), &lore);
946 break; 1036 break;
947 1037
948 case KW_editable: 1038 case KW_editable:
949 case KW_editor_folder: 1039 case KW_editor_folder:
950 break; 1040 break;
951 1041
952 case KW_end: 1042 case KW_end:
953 check_loaded_object (this);
954
955 if (!loading_arch) 1043 if (!loading_arch)
956 instantiate (); 1044 instantiate ();
957 1045
958 f.next (); 1046 f.next ();
959 return true; 1047 return true;
960 1048
961 case KW_ERROR: 1049 case KW_ERROR:
962 set_ob_key_value (this, f.kw_str, f.value, true); 1050 // append as key value pair (do not use kv_set as it prepends)
1051 // we also do not even try to find old values, duplicate keys stay duplicate
1052 {
1053 key_value *kv = new key_value;
1054
1055 kv->next = 0;
1056 kv->key = shstr (f.kw_str);
1057 kv->value = shstr (f.value);
1058
1059 if (!last_kv)
1060 key_values = last_kv = kv;
1061 else
1062 {
1063 while (last_kv->next)
1064 last_kv = last_kv->next;
1065
1066 last_kv->next = kv;
1067 last_kv = kv;
1068 }
1069 }
963 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D 1070 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D
964 break; 1071 break;
965 1072
966 default: 1073 default:
967 if (!f.parse_error ("object", name)) 1074 if (!f.parse_error ("object", name))
… …
981 archetype *arch = archetype::find (f.get_str ()); 1088 archetype *arch = archetype::find (f.get_str ());
982 1089
983 if (!arch) 1090 if (!arch)
984 { 1091 {
985 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ()); 1092 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ());
986 arch = archetype::find ("earthwall"); 1093 arch = archetype::find (shstr_earthwall);
987 } 1094 }
988 1095
989 assert (arch); //D maybe use exception handling of sorts? 1096 assert (arch); //D maybe use exception handling of sorts?
990 1097
991 f.next (); 1098 f.next ();
992 1099
993 object *op = object::create (); 1100 object *op = arch->instance ();
994
995 op->map = map; 1101 op->map = map;
996 arch->clone.copy_to (op);
997 // copy_to activates, this should be fixed properly 1102 // instance() activates, this should be fixed properly
998 op->deactivate (); 1103 op->deactivate ();
999 1104
1000 if (!op->parse_kv (f)) 1105 if (!op->parse_kv (f))
1001 { 1106 {
1002 op->destroy (true); 1107 op->destroy ();
1003 return 0; 1108 return 0;
1004 } 1109 }
1005 1110
1111 op->post_load_check ();
1006 return op; 1112 return op;
1007} 1113}
1008 1114
1009/* This takes a buffer, scans it for variables, and sets those variables 1115/* This takes a buffer, scans it for variables, and sets those variables
1010 * as appropriate in op. 1116 * as appropriate in op.
… …
1015int 1121int
1016set_variable (object *op, char *buf) 1122set_variable (object *op, char *buf)
1017{ 1123{
1018 object_thawer f (buf, (AV *)0); 1124 object_thawer f (buf, (AV *)0);
1019 1125
1020 f.next ();
1021 return op->parse_kv (f); 1126 return op->parse_kv (f);
1022} 1127}
1023 1128
1024/* This returns a string of the integer movement type */
1025#if 0
1026// unused function
1027static char *
1028get_string_move_type (MoveType mt)
1029{
1030 static char retbuf[MAX_BUF], retbuf_all[MAX_BUF];
1031 int i, all_count = 0, count;
1032
1033 strcpy (retbuf, "");
1034 strcpy (retbuf_all, " all");
1035
1036 /* Quick check, and probably fairly common */
1037 if (mt == MOVE_ALL)
1038 return retbuf_all + 1;
1039 if (mt == 0)
1040 {
1041 strcpy (retbuf, "0");
1042 return retbuf;
1043 }
1044
1045 /* We basically slide the bits down. Why look at MOVE_ALL?
1046 * because we may want to return a string like 'all -swim',
1047 * and if we just looked at mt, we couldn't get that.
1048 */
1049 for (i = MOVE_ALL, count = 0; i != 0; i >>= 1, count++)
1050 {
1051 if (mt & (1 << count))
1052 {
1053 strcat (retbuf, " ");
1054 strcat (retbuf, move_name[count]);
1055 }
1056 else
1057 {
1058 strcat (retbuf_all, " -");
1059 strcat (retbuf_all, move_name[count]);
1060 all_count++;
1061 }
1062 }
1063 /* Basically, if there is a single negation, return it, eg
1064 * 'all -swim'. But more than that, just return the
1065 * enumerated values. It doesn't make sense to return
1066 * 'all -walk -fly_low' - it is shorter to return 'fly_high swim'
1067 */
1068 if (all_count <= 1)
1069 return retbuf_all + 1;
1070 else
1071 return retbuf + 1;
1072}
1073#endif
1074
1075// compare *op against *tmp and output differences 1129// compare *op against *arch and output differences
1076static void 1130static void
1077write_diff (object_freezer &f, object *op, object *tmp) 1131write_diff (object_freezer &f, object *op, object *arch)
1078{ 1132{
1079 static const keyword resist_save[NROFATTACKS] = { 1133 static const keyword resist_save[NROFATTACKS] = {
1080# define def(uc, lc, name, plus, change) KW_resist_ ## lc, 1134# define def(uc, lc, name, plus, change) KW_resist_ ## lc,
1081# include "attackinc.h" 1135# include "attackinc.h"
1082# undef def 1136# undef def
… …
1087 * the 15'th element of this array should match that name. 1141 * the 15'th element of this array should match that name.
1088 * If an entry is NULL, that is a flag not to loaded/saved. 1142 * If an entry is NULL, that is a flag not to loaded/saved.
1089 */ 1143 */
1090 static const keyword flag_names [NUM_FLAGS] = { 1144 static const keyword flag_names [NUM_FLAGS] = {
1091 KW_alive, 1145 KW_alive,
1092 KW_wiz,
1093 KW_NULL, 1146 KW_NULL,
1094 KW_NULL, 1147 KW_NULL,
1095 KW_was_wiz, 1148 KW_NULL,
1149 KW_NULL,
1096 KW_applied, 1150 KW_applied,
1097 KW_unpaid, 1151 KW_unpaid,
1098 KW_can_use_shield, 1152 KW_can_use_shield,
1099 KW_no_pick, 1153 KW_no_pick,
1100 KW_NULL, // walk_on 1154 KW_NULL, // walk_on
1155 /* 10 */
1101 KW_NULL, // no_pass 1156 KW_NULL, // no_pass
1102 /* 10 */
1103 KW_is_animated, 1157 KW_is_animated,
1104 KW_NULL, // slow_move 1158 KW_NULL, // slow_move
1105 KW_NULL, // flying 1159 KW_NULL, // flying
1106 KW_monster, 1160 KW_monster,
1107 KW_friendly, 1161 KW_friendly,
1108 KW_generator, 1162 KW_generator,
1109 KW_is_thrown, 1163 KW_is_thrown,
1110 KW_auto_apply, 1164 KW_auto_apply,
1111 KW_treasure_env, 1165 KW_treasure_env,
1166 /* 20 */
1112 KW_player_sold, 1167 KW_player_sold,
1113 /* 20 */
1114 KW_see_invisible, 1168 KW_see_invisible,
1115 KW_can_roll, 1169 KW_can_roll,
1116 KW_overlay_floor, 1170 KW_overlay_floor,
1117 KW_is_turnable, 1171 KW_is_turnable,
1118 KW_NULL, // walk_off 1172 KW_NULL, // walk_off
1119 KW_NULL, // fly_on 1173 KW_NULL, // fly_on
1120 KW_NULL, // fly_off 1174 KW_NULL, // fly_off
1121 KW_is_used_up, 1175 KW_is_used_up,
1122 KW_identified, 1176 KW_identified,
1177 /* 30 */
1123 KW_reflecting, 1178 KW_reflecting,
1124 /* 30 */
1125 KW_changing, 1179 KW_changing,
1126 KW_splitting, 1180 KW_splitting,
1127 KW_hitback, 1181 KW_hitback,
1128 KW_startequip, 1182 KW_startequip,
1129 KW_blocksview, 1183 KW_blocksview,
1130 KW_undead, 1184 KW_undead,
1131 KW_scared, 1185 KW_scared,
1132 KW_unaggressive, 1186 KW_unaggressive,
1133 KW_reflect_missile, 1187 KW_reflect_missile,
1188 /* 40 */
1134 KW_reflect_spell, 1189 KW_reflect_spell,
1135 /* 40 */
1136 KW_no_magic, 1190 KW_no_magic,
1137 KW_no_fix_player, 1191 KW_NULL,
1138 KW_is_lightable, 1192 KW_is_lightable,
1139 KW_tear_down, 1193 KW_tear_down,
1140 KW_run_away, 1194 KW_run_away,
1141 KW_NULL, // pass_thru 1195 KW_NULL, // pass_thru
1142 KW_NULL, // an_pass_thru 1196 KW_NULL, // an_pass_thru
1143 KW_pick_up, 1197 KW_pick_up,
1144 KW_unique, 1198 KW_unique,
1199 /* 50 */
1145 KW_no_drop, 1200 KW_no_drop,
1146 /* 50 */
1147 KW_NULL, // wizcast 1201 KW_NULL, // wizcast
1148 KW_can_cast_spell, 1202 KW_can_cast_spell,
1149 KW_can_use_scroll, 1203 KW_can_use_scroll,
1150 KW_can_use_range, 1204 KW_can_use_range,
1151 KW_can_use_bow, 1205 KW_can_use_bow,
1152 KW_can_use_armour, 1206 KW_can_use_armour,
1153 KW_can_use_weapon, 1207 KW_can_use_weapon,
1154 KW_can_use_ring, 1208 KW_can_use_ring,
1155 KW_has_ready_range, 1209 KW_has_ready_range,
1210 /* 60 */
1156 KW_has_ready_bow, 1211 KW_has_ready_bow,
1157 /* 60 */
1158 KW_xrays, 1212 KW_xrays,
1159 KW_NULL, 1213 KW_NULL,
1160 KW_is_floor, 1214 KW_is_floor,
1161 KW_lifesave, 1215 KW_lifesave,
1162 KW_no_strength, 1216 KW_no_strength,
1163 KW_sleep, 1217 KW_sleep,
1164 KW_stand_still, 1218 KW_stand_still,
1165 KW_random_move, 1219 KW_random_move,
1166 KW_only_attack, 1220 KW_only_attack,
1221 /* 70 */
1167 KW_confused, 1222 KW_confused,
1168 /* 70 */
1169 KW_stealth, 1223 KW_stealth,
1170 KW_NULL, 1224 KW_NULL,
1171 KW_NULL, 1225 KW_NULL,
1172 KW_cursed, 1226 KW_cursed,
1173 KW_damned, 1227 KW_damned,
1174 KW_see_anywhere, 1228 KW_see_anywhere,
1175 KW_known_magical, 1229 KW_known_magical,
1176 KW_known_cursed, 1230 KW_known_cursed,
1177 KW_can_use_skill, 1231 KW_can_use_skill,
1232 /* 80 */
1178 KW_been_applied, 1233 KW_been_applied,
1179 /* 80 */
1180 KW_has_ready_scroll, 1234 KW_has_ready_scroll,
1181 KW_can_use_rod, 1235 KW_can_use_rod,
1182 KW_precious, 1236 KW_precious,
1183 KW_can_use_horn, 1237 KW_can_use_horn,
1184 KW_make_invisible, 1238 KW_make_invisible,
1185 KW_inv_locked, 1239 KW_inv_locked,
1186 KW_is_wooded, 1240 KW_is_wooded,
1187 KW_is_hilly, 1241 KW_is_hilly,
1188 KW_has_ready_skill, 1242 KW_has_ready_skill,
1243 /* 90 */
1189 KW_has_ready_weapon, 1244 KW_has_ready_weapon,
1190 /* 90 */
1191 KW_no_skill_ident, 1245 KW_no_skill_ident,
1192 KW_is_blind, 1246 KW_is_blind,
1193 KW_can_see_in_dark, 1247 KW_can_see_in_dark,
1194 KW_is_cauldron, 1248 KW_is_cauldron,
1195 KW_NULL, 1249 KW_NULL,
1196 KW_no_steal, 1250 KW_no_steal,
1197 KW_one_hit, 1251 KW_one_hit,
1198 KW_NULL, 1252 KW_NULL,
1199 KW_berserk, 1253 KW_berserk,
1254 /* 100 */
1200 KW_neutral, 1255 KW_neutral,
1201 /* 100 */
1202 KW_no_attack, 1256 KW_no_attack,
1203 KW_no_damage, 1257 KW_no_damage,
1204 KW_obj_original, 1258 KW_obj_original,
1205 KW_NULL, 1259 KW_random_speed,
1206 KW_activate_on_push, 1260 KW_activate_on_push,
1207 KW_activate_on_release, 1261 KW_activate_on_release,
1208 KW_is_water, 1262 KW_is_water,
1209 KW_use_content_on_gen, 1263 KW_use_content_on_gen,
1210 KW_NULL, 1264 KW_NULL,
1265 /* 110 */
1211 KW_is_buildable, 1266 KW_is_buildable,
1212 /* 110 */
1213 KW_destroy_on_death, 1267 KW_destroy_on_death,
1214 KW_NULL, 1268 KW_NULL,
1215 }; 1269 };
1216 1270
1217 int i; 1271 // obj_original is the only commonly differing flag between archetype
1272 // and object, so special-case it here to be able to skip the loop
1273 static const struct flagmask : object::flags_t
1274 {
1275 flagmask ()
1276 {
1277 for (int i = 0; i < NUM_FLAGS; i++)
1278 if (flag_names [i])
1279 set (i);
1280 }
1281 } flagmask;
1218 1282
1219 /* This saves the key/value lists. We do it first so that any 1283 /* This saves the key/value lists. We do it first so that any
1220 * keys that match field names will be overwritten by the loader. 1284 * keys that match field names will be overwritten by the loader.
1221 */ 1285 */
1222 for (key_value *my_field = op->key_values; my_field; my_field = my_field->next) 1286 for (key_value *kv = op->key_values; kv; kv = kv->next)
1223 { 1287 if (!arch->key_values || arch->kv (kv->key) != kv->value)
1224 /* Find the field in the opposing member. */ 1288 f.put (kv->key, kv->value);
1225 key_value *arch_field = get_ob_key_link (tmp, my_field->key);
1226 1289
1227 /* If there's no partnering field, or it's got a different value, save our field. */ 1290 if (op->uuid)
1228 if (!arch_field || my_field->value != arch_field->value)
1229 f.put (my_field->key, my_field->value);
1230 } 1291 {
1292 // highly optimised - this is often 25% of all data written
1293 char *cur = f.force (sizeof ("uuid ") + UUID::MAX_LEN + 1);
1294 char *ptr = cur;
1231 1295
1232 /* We don't need to worry about the arch's extra fields - they 1296 memcpy (ptr, "uuid ", sizeof ("uuid ") - 1);
1233 * will get taken care of the copy_to method. 1297 ptr += sizeof ("uuid ") - 1;
1234 */ 1298 ptr = op->uuid.append (ptr);
1299 *ptr++ = '\n';
1235 1300
1236 { 1301 f.alloc (ptr - cur);
1237 char uids[64];
1238 snprintf (uids, sizeof (uids), "<1.%llx>", (unsigned long long)op->uuid.seq);
1239 f.put (KW_uuid, (const char *)uids);
1240 } 1302 }
1241 1303
1242#define CMP_OUT(v) if (op->v != tmp->v) f.put (KW_ ## v, op->v) 1304#define CMP_OUT(v) if (expect_false (op->v != arch->v)) f.put (KW (v), op->v)
1243#define CMP_OUT2(k,v) if (op->v != tmp->v) f.put (KW_ ## k, op->v) 1305#define CMP_OUT2(k,v) if (expect_false (op->v != arch->v)) f.put (KW (k), op->v)
1306
1307 CMP_OUT (x);
1308 CMP_OUT (y);
1309
1310 CMP_OUT (type);
1311 CMP_OUT (subtype);
1312 CMP_OUT (direction);
1244 1313
1245 CMP_OUT (name); 1314 CMP_OUT (name);
1246 CMP_OUT (name_pl); 1315 CMP_OUT (name_pl);
1247 CMP_OUT (custom_name); 1316 CMP_OUT (speed);
1317
1318 // speed_left is a major time-burner, and has good locality, so
1319 // we use a simple lookup-cache to avoid the very slow printf.
1320 if (op->speed_left != arch->speed_left)
1321 {
1322 static double last_speed_left = 0.;
1323 static char last_speed_left_str [256] = "sl 0\n";
1324 static int last_speed_left_len = sizeof ("sl 0\n") - 1;
1325
1326 if (last_speed_left != op->speed_left)
1327 {
1328 last_speed_left = op->speed_left;
1329 last_speed_left_len = sizeof ("sl ") - 1
1330 + sprintf (last_speed_left_str + sizeof ("sl ") - 1, "%.7g\n", last_speed_left);
1331 }
1332
1333 f.add (last_speed_left_str, last_speed_left_len);
1334 }
1335
1248 CMP_OUT (title); 1336 CMP_OUT (title);
1249 CMP_OUT (race); 1337 CMP_OUT (race);
1250 CMP_OUT (slaying); 1338 CMP_OUT (slaying);
1339 CMP_OUT (skill);
1251 1340
1252 if (op->msg != tmp->msg) 1341 CMP_OUT (tag);
1253 f.put (KW_msg, KW_endmsg, op->msg); 1342 CMP_OUT (custom_name);
1254 if (op->lore != tmp->lore) 1343
1255 f.put (KW_lore, KW_endlore, op->lore); 1344 if (object *owner = op->owner)
1345 if (const char *ref = owner->ref ())
1346 f.put (KW(owner), ref);
1347
1348 // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved
1256 1349
1257 CMP_OUT (other_arch); 1350 CMP_OUT (other_arch);
1258 1351
1259 if (op->face != tmp->face) f.put (KW_face, op->face ? &faces [op->face] : 0); 1352 if (op->msg != arch->msg ) f.put (KW(msg) , KW(endmsg) , op->msg );
1353 if (op->lore != arch->lore) f.put (KW(lore), KW(endlore), op->lore);
1260 1354
1355 if (op->face != arch->face ) f.put (KW(face) , op->face ? &faces [op->face ] : 0);
1356 if (op->sound != arch->sound ) f.put (KW(sound) , op->sound ? &faces [op->sound ] : 0);
1357 if (op->sound_destroy != arch->sound_destroy) f.put (KW(sound_destroy), op->sound_destroy ? &faces [op->sound_destroy] : 0);
1358
1261 if (op->animation_id != tmp->animation_id) 1359 if (op->animation_id != arch->animation_id)
1262 if (op->animation_id) 1360 if (op->has_anim ())
1361 f.put (KW(animation), op->anim ().name);
1362 else
1263 { 1363 {
1264 f.put (KW_animation, animations[GET_ANIM_ID (op)].name); 1364 f.put (KW(animation));
1265 1365 op->flag [FLAG_ANIMATE] = false; // TODO: why force to false here?
1266 if (!QUERY_FLAG (op, FLAG_ANIMATE))
1267 f.put (KW_is_animated, (sint32) 0);
1268 } 1366 }
1269 else
1270 f.put (KW_animation, (const char *) 0);
1271 1367
1272 CMP_OUT2 (str, stats.Str); 1368 CMP_OUT2 (str, stats.Str);
1273 CMP_OUT2 (dex, stats.Dex); 1369 CMP_OUT2 (dex, stats.Dex);
1274 CMP_OUT2 (con, stats.Con); 1370 CMP_OUT2 (con, stats.Con);
1275 CMP_OUT2 (wis, stats.Wis); 1371 CMP_OUT2 (wis, stats.Wis);
… …
1284 CMP_OUT2 (grace, stats.grace); 1380 CMP_OUT2 (grace, stats.grace);
1285 CMP_OUT2 (maxgrace, stats.maxgrace); 1381 CMP_OUT2 (maxgrace, stats.maxgrace);
1286 CMP_OUT2 (exp, stats.exp); 1382 CMP_OUT2 (exp, stats.exp);
1287 1383
1288 CMP_OUT (perm_exp); 1384 CMP_OUT (perm_exp);
1289 CMP_OUT (expmul); 1385 //CMP_OUT (expmul);
1290 1386
1291 CMP_OUT2 (food, stats.food); 1387 CMP_OUT2 (food, stats.food);
1292 CMP_OUT2 (dam, stats.dam); 1388 CMP_OUT2 (dam, stats.dam);
1293 CMP_OUT2 (luck, stats.luck); 1389 CMP_OUT2 (luck, stats.luck);
1294 CMP_OUT2 (wc, stats.wc); 1390 CMP_OUT2 (wc, stats.wc);
1295 CMP_OUT2 (ac, stats.ac); 1391 CMP_OUT2 (ac, stats.ac);
1296 1392
1297 CMP_OUT (x);
1298 CMP_OUT (y);
1299 CMP_OUT (speed);
1300 CMP_OUT (speed_left);
1301 CMP_OUT2 (move_state, move_status); 1393 CMP_OUT2 (move_state, move_status);
1302 CMP_OUT (attack_movement); 1394 CMP_OUT (attack_movement);
1303 CMP_OUT (nrof); 1395 CMP_OUT (nrof);
1304 CMP_OUT (level); 1396 CMP_OUT (level);
1305 CMP_OUT (direction);
1306 CMP_OUT (type);
1307 CMP_OUT (subtype);
1308 CMP_OUT (attacktype); 1397 CMP_OUT (attacktype);
1309 1398
1399 // using memcmp here seems to be a loss - is gcc vectorising?
1310 for (i = 0; i < NROFATTACKS; i++) 1400 for (int i = 0; i < NROFATTACKS; i++)
1311 if (op->resist[i] != tmp->resist[i]) 1401 if (expect_false (op->resist[i] != arch->resist[i]))
1312 f.put (resist_save[i], op->resist[i]); 1402 f.put (resist_save[i], op->resist[i]);
1313 1403
1314 CMP_OUT (path_attuned); 1404 CMP_OUT (path_attuned);
1315 CMP_OUT (path_repelled); 1405 CMP_OUT (path_repelled);
1316 CMP_OUT (path_denied); 1406 CMP_OUT (path_denied);
1407
1317 CMP_OUT2 (material, materials);//TODO: nuke 1408 CMP_OUT2 (material, materials);//TODO: nuke
1318 CMP_OUT (materialname); 1409 if (op->material != arch->material)
1410 f.put (KW(materialname), op->material->name);
1411
1319 CMP_OUT (value); 1412 CMP_OUT (value);
1320 CMP_OUT (carrying); 1413 CMP_OUT (carrying);
1321 CMP_OUT (weight); 1414 CMP_OUT (weight);
1322 CMP_OUT (invisible); 1415 CMP_OUT (invisible);
1323 CMP_OUT (state); 1416 CMP_OUT (state);
… …
1326 CMP_OUT (last_sp); 1419 CMP_OUT (last_sp);
1327 CMP_OUT (last_grace); 1420 CMP_OUT (last_grace);
1328 CMP_OUT (last_eat); 1421 CMP_OUT (last_eat);
1329 CMP_OUT (glow_radius); 1422 CMP_OUT (glow_radius);
1330 1423
1331 if (QUERY_FLAG (op, FLAG_IS_LINKED) && (i = get_button_value (op))) 1424 if (op->flag [FLAG_IS_LINKED])
1425 if (auto (ol, op->find_link ()))
1332 f.put (KW_connected, i); 1426 f.put (KW(connected), ol->id);
1333 1427
1334 CMP_OUT (randomitems); 1428 CMP_OUT (randomitems);
1429
1335 CMP_OUT2 (container, weight_limit); 1430 CMP_OUT2 (container, weight_limit);
1336 1431
1337 CMP_OUT (run_away); 1432 CMP_OUT (run_away);
1338 CMP_OUT (pick_up); 1433 CMP_OUT (pick_up);
1339 CMP_OUT (will_apply); 1434 CMP_OUT (will_apply);
1340 CMP_OUT (smoothlevel); 1435 CMP_OUT (smoothlevel);
1341 CMP_OUT (weapontype); 1436 CMP_OUT (weapontype);
1342 CMP_OUT (tooltype);
1343 CMP_OUT (elevation);
1344 CMP_OUT (client_type); 1437 CMP_OUT (client_type);
1345 CMP_OUT (item_power); 1438 CMP_OUT (item_power);
1346 CMP_OUT (duration); 1439 CMP_OUT (duration);
1347 CMP_OUT (range); 1440 CMP_OUT (range);
1348 CMP_OUT (range_modifier); 1441 CMP_OUT (range_modifier);
… …
1356 CMP_OUT (move_on); 1449 CMP_OUT (move_on);
1357 CMP_OUT (move_off); 1450 CMP_OUT (move_off);
1358 CMP_OUT (move_slow); 1451 CMP_OUT (move_slow);
1359 CMP_OUT (move_slow_penalty); 1452 CMP_OUT (move_slow_penalty);
1360 1453
1361 if (op->flag != tmp->flag) 1454 object::flags_t diff = (op->flag ^ arch->flag) & flagmask;
1455
1456#if stdcpp // we need gcc, sorry
1457 if (diff [FLAG_OBJ_ORIGINAL])
1458 f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? CS(1) : CS(0));
1459
1460 diff.reset (FLAG_OBJ_ORIGINAL);
1461
1462 // quickly test whether any other flags differ
1463 if (expect_true (diff.any ()))
1362 for (i = 0; i <= NUM_FLAGS; i++) 1464 for (int i = 0; i < NUM_FLAGS; i++)
1363 if (flag_names [i] && op->flag [i] != tmp->flag [i]) 1465 if (expect_false (diff [i]))
1364 f.put (flag_names [i], op->flag [i] ? "1" : "0"); 1466 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1467#else
1468 // use sgi extensions
1469 for (int i = diff._Find_first (); i < diff.size (); i = diff._Find_next (i))
1470 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1471#endif
1365 1472
1366 /* Save body locations */ 1473 // save body locations. gcc's memcmp does an abysmal job when used
1367 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 1474 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
1368 if (op->body_info[i] != tmp->body_info[i]) 1475 if (expect_false (op->slot[i].info != arch->slot[i].info))
1369 f.put (body_locations[i].save_name, op->body_info[i]); 1476 f.put (body_locations[i].save_name, op->slot[i].info);
1370} 1477}
1371 1478
1372/* 1479/*
1373 * Dumps all variables in an object to a file. 1480 * Dumps all variables in an object to a file.
1374 * If bit 0 of flag is set, unpaid objects will be saved. As of now, 1481 * If bit 0 of flag is set, unpaid objects will be saved. As of now,
1375 * the only place this is not set is when saving the player. 1482 * the only place this is not set is when saving the player.
1376 */ 1483 */
1377bool 1484bool
1378object::write (object_freezer &f) 1485object::write (object_freezer &f)
1379{ 1486{
1380 /* Even if the object does have an owner, it would seem that we should 1487 if (expect_false (is_arch ()))
1381 * still save it. 1488 {
1382 */ 1489 f.put (KW(object), arch->archname);
1383 if (owner) 1490 write_diff (f, this, archetype::empty);
1384 return true; 1491 }
1385 1492 else
1386 archetype *at = arch ? (archetype *)arch : empty_archetype; 1493 {
1387
1388 f.put (KW_arch, at->name); 1494 f.put (KW(arch), arch->archname);
1389 write_diff (f, this, &at->clone); 1495 write_diff (f, this, arch);
1496 }
1390 1497
1391 for (object *tmp = inv; tmp; tmp = tmp->below) 1498 for (object *tmp = inv; tmp; tmp = tmp->below)
1392 tmp->write (f); 1499 tmp->write (f);
1393 1500
1394 f.put (this); 1501 f.put (this);
1395 f.put (KW_end); 1502 f.put (KW(end));
1396 1503
1397 return true; 1504 return true;
1398} 1505}
1399 1506
1400///////////////////////////////////////////////////////////////////////////// 1507/////////////////////////////////////////////////////////////////////////////
1401 1508
1402// generic resource file load, 1509// generic resource file load,
1403// currently supports: region, treasures, archetypes 1510// currently supports: region, treasures, archetypes
1511bool
1404bool load_resource_file (const char *filename) 1512load_resource_file_ (const char *filename)
1405{ 1513{
1406 object_thawer f (filename); 1514 object_thawer f (filename);
1407
1408 bool success = false;
1409 bool seen_arch = false;
1410
1411 f.next ();
1412 1515
1413 for (;;) 1516 for (;;)
1414 { 1517 {
1415 switch (f.kw) 1518 switch (f.kw)
1416 { 1519 {
1417 case KW_region: 1520 case KW_region:
1418 if (!region::read (f)) 1521 if (!region::read (f))
1419 goto finish; 1522 return false;
1420 break; 1523 break;
1421 1524
1422 case KW_treasure: 1525 case KW_treasure:
1423 case KW_treasureone: 1526 case KW_treasureone:
1424 if (!treasurelist::read (f)) 1527 if (!treasurelist::read (f))
1425 goto finish; 1528 return false;
1426 break; 1529 break;
1427 1530
1428 case KW_object: 1531 case KW_object:
1429 seen_arch = true;
1430 if (!archetype::read (f)) 1532 if (!archetype::read (f))
1431 goto finish; 1533 return false;
1432 break; 1534 break;
1433 1535
1434 case KW_EOF: 1536 case KW_EOF:
1435 success = true; 1537 return true;
1436 goto finish;
1437 1538
1438 default: 1539 default:
1439 if (!f.parse_error ("resource file")) 1540 if (!f.parse_error ("resource file"))
1440 goto finish; 1541 return false;
1441 1542
1442 f.next (); 1543 f.next ();
1443 break; 1544 break;
1444 } 1545 }
1445 } 1546 }
1446
1447finish:
1448 if (seen_arch)
1449 init_archetype_pointers ();
1450
1451 return success;
1452} 1547}
1453 1548

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines