ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/loader.C
(Generate patch)

Comparing deliantra/server/common/loader.C (file contents):
Revision 1.114 by root, Sat May 3 11:14:50 2008 UTC vs.
Revision 1.157 by root, Thu Apr 29 12:24:03 2010 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
25#include <loader.h>
26#include <sproto.h> 26#include <sproto.h>
27 27
28///////////////////////////////////////////////////////////////////////////// 28/////////////////////////////////////////////////////////////////////////////
29 29
30extern archetype *loading_arch; 30extern archetype *loading_arch;
31
32//+GPL
31 33
32/* This table is only necessary to convert objects that existed before the 34/* This table is only necessary to convert objects that existed before the
33 * spell object conversion to the new object. It was not practical 35 * spell object conversion to the new object. It was not practical
34 * to go through every mapping looking for every potion, rod, wand, etc 36 * to go through every mapping looking for every potion, rod, wand, etc
35 * that had a sp set and update to the new value. So this maps the 37 * that had a sp set and update to the new value. So this maps the
… …
257void 259void
258object::post_load_check () 260object::post_load_check ()
259{ 261{
260 if (type >= NUM_TYPES) 262 if (type >= NUM_TYPES)
261 { 263 {
262 LOG (llevError, "%s: type out of range, resetting to 0.\n", debug_desc ()); 264 LOG (llevError, "ITEMBUG: %s: type out of range, resetting to 0.\n", debug_desc ());
263 type = 0; 265 type = 0;
264 } 266 }
265 267
266 switch (type) 268 switch (type)
267 { 269 {
… …
269 case WAND: 271 case WAND:
270 case ROD: 272 case ROD:
271 case HORN: 273 case HORN:
272 if (slot [body_range].info != -1) 274 if (slot [body_range].info != -1)
273 { 275 {
274 LOG (llevError, "%s: body_range %d != -1\n", debug_desc (), slot [body_range].info); 276 LOG (llevError, "ITEMBUG: %s: body_range %d != -1\n", debug_desc (), slot [body_range].info);
275 slot [body_range].info = -1; 277 slot [body_range].info = -1;
276 } 278 }
277 break; 279 break;
278 280
279 case WEAPON: 281 case WEAPON:
280 if (slot [body_combat].info != -1) 282 if (slot [body_combat].info != -1)
281 { 283 {
282 LOG (llevError, "%s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info); 284 LOG (llevError, "ITEMBUG: %s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info);
283 slot [body_combat].info = -1; 285 slot [body_combat].info = -1;
284 } 286 }
285 break; 287 break;
286 288
287 case SHIELD: 289 case SHIELD:
288 if (slot [body_shield].info != -1) 290 if (slot [body_shield].info != -1)
289 { 291 {
290 LOG (llevError, "%s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info); 292 LOG (llevError, "ITEMBUG: %s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info);
291 slot [body_shield].info = -1; 293 slot [body_shield].info = -1;
292 } 294 }
293 break; 295 break;
294 296
295 case PLAYER: 297 case PLAYER:
296 if (slot [body_shield].info != 1) 298 if (slot [body_shield].info != 1)
297 { 299 {
298 LOG (llevError, "%s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info); 300 LOG (llevError, "ITEMBUG: %s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info);
299 slot [body_shield].info = 1; 301 slot [body_shield].info = 1;
300 } 302 }
301 303
302 if (slot [body_combat].info != 1) 304 if (slot [body_combat].info != 1)
303 { 305 {
304 LOG (llevError, "%s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info); 306 LOG (llevError, "ITEMBUG: %s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info);
305 slot [body_combat].info = 1; 307 slot [body_combat].info = 1;
306 } 308 }
307 309
308 if (slot [body_range].info != 1) 310 if (slot [body_range].info != 1)
309 { 311 {
310 LOG (llevError, "%s: body_range %d != 1\n", debug_desc (), slot [body_range].info); 312 LOG (llevError, "ITEMBUG: %s: body_range %d != 1\n", debug_desc (), slot [body_range].info);
311 slot [body_range].info = 1; 313 slot [body_range].info = 1;
312 } 314 }
313 break; 315 break;
314 } 316 }
315 317
… …
327 329
328 if (!name_pl) 330 if (!name_pl)
329 name_pl = name; 331 name_pl = name;
330 332
331 /* objects now have a materialname. try to patch it in */ 333 /* objects now have a materialname. try to patch it in */
332 if (!(is_weapon () && level > 0)) 334 if (material == MATERIAL_NULL && !(is_weapon () && level > 0))
333 set_materialname (this, map ? map->difficulty : 5, 0); 335 select_material (this, map ? map->difficulty : 5);
336
337 if (speed < 0.)
338 {
339 flag [FLAG_RANDOM_SPEED] = true;
340 speed = -speed;
341 // speed_left will be randomised in instantiate () and copy_to ()
342 }
334 343
335 /* only do these when program is first run - a bit 344 /* only do these when program is first run - a bit
336 * excessive to do this at every run - most of this is 345 * excessive to do this at every run - most of this is
337 * really just to catch any errors - program will still run, but 346 * really just to catch any errors - program will still run, but
338 * not in the ideal fashion. 347 * not in the ideal fashion.
339 */ 348 */
340 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND)) 349 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND))
341 { 350 {
342 if (!skill) 351 if (!skill)
343 LOG (llevError, "Weapon %s lacks a skill.\n", debug_desc ()); 352 LOG (llevError, "ITEMBUG: weapon %s lacks a skill.\n", debug_desc ());
344 else if ((!strcmp (skill, "one handed weapons") && slot[body_arm].info != -1) || 353 else if ((skill == shstr_one_handed_weapons && slot[body_arm].info != -1) ||
345 (!strcmp (skill, "two handed weapons") && slot[body_arm].info != -2)) 354 (skill == shstr_two_handed_weapons && slot[body_arm].info != -2))
346 LOG (llevError, "weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill); 355 LOG (llevError, "ITEMBUG: weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill);
347 } 356 }
348 357
349 /* We changed last_heal to gen_sp_armour, which is what it 358 /* We changed last_heal to gen_sp_armour, which is what it
350 * really does for many objects. Need to catch any in maps 359 * really does for many objects. Need to catch any in maps
351 * that may have an old value. 360 * that may have an old value.
… …
357 || type == AMULET || type == GIRDLE 366 || type == AMULET || type == GIRDLE
358 || type == BRACERS || type == CLOAK) 367 || type == BRACERS || type == CLOAK)
359 { 368 {
360 if (last_heal) 369 if (last_heal)
361 { 370 {
362 LOG (llevError, "Object %s still has last_heal set, not gen_sp_armour\n", debug_desc ()); 371 LOG (llevError, "ITEMBUG: object %s still has last_heal set, not gen_sp_armour\n", debug_desc ());
363 gen_sp_armour = last_heal; 372 gen_sp_armour = last_heal;
364 last_heal = 0; 373 last_heal = 0;
365 } 374 }
366 375
367 int ip = calc_item_power (this, 0); 376 int ip = calc_item_power (this, 0);
368 377
369 /* Legacy objects from before item power was in the game */ 378 /* Legacy objects from before item power was in the game */
370 if (!item_power && ip) 379 if (!item_power && ip)
371 { 380 {
372 if (ip > 3) 381 if (ip > 3)
373 LOG (llevDebug, "Object %s had no item power, using %d\n", debug_desc (), ip); 382 LOG (llevDebug, "ITEMBUG: Object %s had no item power, using %d\n", debug_desc (), ip);
374 383
375 item_power = ip; 384 item_power = ip;
376 } 385 }
377 386
378 /* Check for possibly bogus values. Has to meet both these criteria - 387 /* Check for possibly bogus values. Has to meet both these criteria -
… …
385 if (ip > 2 * item_power && ip > (item_power + 3)) 394 if (ip > 2 * item_power && ip > (item_power + 3))
386 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power); 395 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power);
387#endif 396#endif
388 } 397 }
389 398
390 /* Old spellcasting object - need to load in the appropiate object */ 399 /* old style spellcasting object (pretty common) - need to load in the appropriate object */
391 if ((type == ROD || type == WAND || type == SCROLL || type == HORN || type == FIREWALL || 400 /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */
401 if ((type == ROD
402 || type == WAND
403 || type == SCROLL
404 || type == HORN
405 || type == FIREWALL
392 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */ 406 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */
393 ((type == POTION || type == ALTAR) && stats.sp)) && !inv && !loading_arch) 407 || ((type == POTION || type == ALTAR) && stats.sp)) // watchout: sp = 0 is still magic bullet.
408 && !inv
409 && !loading_arch
410 && stats.sp) // watchout: old magic bullet stuff directly on the map is going to break here!
411 // TODO: at least one watchout-comments is redundant - investigate/remove
394 { 412 {
413 // TODO: fix firewall object on map
395 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal' 414 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal'
396 * in that spell was stored in sp. 415 * in that spell was stored in sp.
397 */ 416 */
398 LOG (llevError, "old spellcasting object found: %s", debug_desc ()); 417 //LOG (llevError, "old spellcasting object found: %s", debug_desc ());
399 object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]); 418 object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]);
400 insert_ob_in_ob (tmp, this); 419 insert_ob_in_ob (tmp, this);
401 randomitems = NULL; /* So another spell isn't created for this object */ 420 randomitems = 0;
402 } 421 }
403 422
404 /* spellbooks & runes use slaying. But not to arch name, but to spell name */ 423 /* spellbooks & runes use slaying. But not to arch name, but to spell name */
405 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch) 424 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch)
406 { 425 {
407 LOG (llevError, "spellbook/rune found without inv but slaying: %s", debug_desc ()); 426 LOG (llevError, "ITEMBUG: spellbook/rune found without inv but slaying: %s", debug_desc ());
408 object *tmp = get_archetype_by_object_name (slaying); 427 object *tmp = get_archetype_by_object_name (slaying);
409 insert_ob_in_ob (tmp, this); 428 insert_ob_in_ob (tmp, this);
410 randomitems = NULL; /* So another spell isn't created for this object */ 429 randomitems = 0; /* So another spell isn't created for this object */
411 /* without this, value is all screwed up */ 430 /* without this, value is all screwed up */
412 value = arch->value * inv->value; 431 value = arch->value * inv->value;
413 } 432 }
414 433
415 if (QUERY_FLAG (this, FLAG_MONSTER)) 434 if (this->flag [FLAG_MONSTER])
416 { 435 {
417 if (stats.hp > stats.maxhp) 436 if (stats.hp > stats.maxhp)
418 { 437 {
419 LOG (llevInfo, "Monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp); 438 LOG (llevInfo, "ITEMBUG: monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp);
420 stats.maxhp = stats.hp; 439 stats.maxhp = stats.hp;
421 } 440 }
422 441
423 /* The archs just need to be updated for this */ 442 /* The archs just need to be updated for this */
424 if (move_type == 0) 443 if (move_type == 0)
425 move_type = MOVE_WALK; 444 move_type = MOVE_WALK;
426 } 445 }
427 446
428 if ((QUERY_FLAG (this, FLAG_GENERATOR) && QUERY_FLAG (this, FLAG_CONTENT_ON_GEN)) || type == CREATOR || type == CONVERTER) 447 if ((this->flag [FLAG_GENERATOR] && this->flag [FLAG_CONTENT_ON_GEN]) || type == CREATOR || type == CONVERTER)
429 /* Object will duplicate it's content as part of the 448 /* Object will duplicate it's content as part of the
430 * generation process. To do this, we must flag inventory 449 * generation process. To do this, we must flag inventory
431 * so it remains unevaluated concerning the randomitems and 450 * so it remains unevaluated concerning the randomitems and
432 * the living (a demonlord shouldn't cast from inside generator!) 451 * the living (a demonlord shouldn't cast from inside generator!)
433 */ 452 */
… …
451 } 470 }
452 else 471 else
453 move_type = MOVE_WALK; 472 move_type = MOVE_WALK;
454 } 473 }
455 } 474 }
475
476 // if the object has an animation, try to provide a default face
477 if (has_anim ())
478 {
479 const animation &anim_ob = anim ();
480
481 if (anim_speed)
482 // if this item is time-animated, force the last frame
483 animate_object (this, 0);
484 else if (flag [FLAG_MONSTER])
485 // if it is a monster, set appropriate facing
486 animate_object (this, direction);
487 }
456} 488}
457 489
458static void 490static void
459set_move (MoveType &mt, const char *str) 491set_move (MoveType &mt, object_thawer &f)
460{ 492{
461 static const struct flagstr { 493 static const struct flagstr {
462 const char *name; 494 const char *name;
463 MoveType flags; 495 MoveType flags;
464 } move_flags[] = { 496 } move_flags[] = {
… …
470 { "boat" , MOVE_BOAT }, 502 { "boat" , MOVE_BOAT },
471 { "ship" , MOVE_SHIP }, 503 { "ship" , MOVE_SHIP },
472 { "all" , MOVE_ALL }, 504 { "all" , MOVE_ALL },
473 }; 505 };
474 506
475 if (!str) 507 const char *str = f.get_str ();
476 {
477 mt = 0;
478 return;
479 }
480 508
481 if (isdigit (*str)) 509 if (!*str || isdigit (*str))
482 { 510 {
483 mt = atoi (str); 511 mt = atoi (str);
484 return; 512 return;
485 } 513 }
486 514
487 mt = 0; 515 mt = 0;
488 516
489 for (str = strtok ((char *) str, " "); str; str = strtok (0, " ")) 517 for (str = strtok ((char *)str, " "); str; str = strtok (0, " "))
490 { 518 {
491 bool negate = 0; 519 bool negate = 0;
492 520
493 if (*str == '-') 521 if (*str == '-')
494 { 522 {
… …
513 541
514next: ; 542next: ;
515 } 543 }
516} 544}
517 545
546//-GPL
547
518#define GET_FLAG(op,flg) op->flag [flg] = f.get_bool () 548#define GET_FLAG(op,flg) op->flag [flg] = f.get_bool ()
519 549
520bool 550bool
521object::parse_kv (object_thawer &f) 551object::parse_kv (object_thawer &f)
522{ 552{
… …
526 for (;;) 556 for (;;)
527 { 557 {
528 switch (f.kw) 558 switch (f.kw)
529 { 559 {
530 case KW_uuid: 560 case KW_uuid:
531 if (const char *s = f.get_str ())
532 if (!uuid.parse (s)) 561 if (!uuid.parse (f.get_str ()))
533 { 562 {
534 f.parse_warn ("unparseable uuid"); 563 f.parse_warn ("unparseable uuid");
535 uuid = UUID::gen (); 564 uuid = UUID::gen ();
536 } 565 }
537 break; 566 break;
538 567
539 case KW_oid: 568 case KW_oid:
540 f.get (this, f.get_sint32 ()); 569 f.get (this, f.get_sint32 ());
541 break; 570 break;
… …
550 case KW_race: f.get_ornull (race); break; 579 case KW_race: f.get_ornull (race); break;
551 case KW_slaying: f.get_ornull (slaying); break; 580 case KW_slaying: f.get_ornull (slaying); break;
552 case KW_tag: f.get_ornull (tag); break; 581 case KW_tag: f.get_ornull (tag); break;
553 582
554 case KW_arch: 583 case KW_arch:
555 {
556 object *tmp = object::read (f); 584 if (object *tmp = object::read (f))
557 tmp->deactivate ();
558
559 { 585 {
586 tmp->deactivate ();
587
560 // was: insert_ob_in_ob (tmp, op); 588 // was: insert_ob_in_ob (tmp, op);
561 // but manually adding it can improve map loading times a lot 589 // but manually adding it can improve map loading times a lot
562 // also, appending instead of prepending keeps the 590 // also, appending instead of prepending keeps the
563 // save ordering the same between repeated load/saves. 591 // save ordering the same between repeated load/saves.
564 // and finally we do not want any funny effects 592 // and finally we do not want any funny effects
565 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL); 593 tmp->clr_flag (FLAG_OBJ_ORIGINAL);
566 CLEAR_FLAG (tmp, FLAG_REMOVED); 594 tmp->clr_flag (FLAG_REMOVED);
567 595
568 if (!op_inv) 596 if (!op_inv)
569 { 597 {
570 inv = tmp; 598 inv = tmp;
571 tmp->above = 0; 599 tmp->above = 0;
… …
581 609
582 tmp->below = 0; 610 tmp->below = 0;
583 tmp->env = this; 611 tmp->env = this;
584 op_inv = tmp; 612 op_inv = tmp;
585 } 613 }
586 } 614 else
615 LOG (llevError, "ERROR: couldn't load inventory object, file corrupted?\n");
616
587 continue; 617 continue;
588 618
589 case KW_other_arch: 619 case KW_other_arch:
590 if (loading_arch == this) 620 if (loading_arch == this)
591 archetype::postpone_arch_ref (loading_arch->other_arch, f.get_str ()); 621 archetype::postpone_arch_ref (loading_arch->other_arch, f.get_str ());
… …
602 f.delayed_deref (this, owner, f.get_str ()); 632 f.delayed_deref (this, owner, f.get_str ());
603 break; 633 break;
604 634
605 case KW_animation: 635 case KW_animation:
606 { 636 {
607 CLEAR_FLAG (this, FLAG_ANIMATE); 637 this->clr_flag (FLAG_ANIMATE);
608 animation_id = 0; 638 animation_id = 0;
609 639
610 const char *str = f.get_str ();
611 if (str && (animation_id = find_animation (str))) 640 if (f.has_value () && (animation_id = find_animation (f.get_str ())))
612 SET_FLAG (this, FLAG_ANIMATE); 641 this->set_flag (FLAG_ANIMATE); //TODO: should not be forced to true here
613 } 642 }
614 break; 643 break;
615 644
616 case KW_last_heal: f.get (last_heal); break; 645 case KW_last_heal: f.get (last_heal); break;
617 case KW_last_sp: f.get (last_sp); break; 646 case KW_last_sp: f.get (last_sp); break;
618 case KW_last_grace: f.get (last_grace); break; 647 case KW_last_grace: f.get (last_grace); break;
619 case KW_last_eat: f.get (last_eat); break; 648 case KW_last_eat: f.get (last_eat); break;
649 case KW_sl:
620 case KW_speed_left: f.get (speed_left); break; 650 case KW_speed_left: f.get (speed_left); break;
621 651
622 case KW_speed: 652 case KW_speed:
623 f.get (speed); 653 f.get (speed);
624 654
… …
633 move_slow |= MOVE_WALK; 663 move_slow |= MOVE_WALK;
634 f.get (move_slow_penalty); 664 f.get (move_slow_penalty);
635 break; 665 break;
636 666
637 case KW_face: 667 case KW_face:
638 face = face_find (f.get_str ()); 668 face = f.has_value () ? face_find (f.get_str ()) : blank_face;
639 break; 669 break;
640 670
641 case KW_sound: 671 case KW_sound:
672 if (f.has_value ())
673 {
642 sound = sound_find (f.get_str ()); 674 sound = sound_find (f.get_str ());
643 if (!sound) 675 if (!sound)
644 f.parse_warn ("sound not found"); 676 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
677 }
678 else
679 sound = 0;
645 break; 680 break;
646 681
647 case KW_sound_destroy: 682 case KW_sound_destroy:
683 if (f.has_value ())
684 {
648 sound_destroy = sound_find (f.get_str ()); 685 sound_destroy = sound_find (f.get_str ());
649 if (!sound_destroy) 686 if (!sound_destroy)
650 f.parse_warn ("sound not found"); 687 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
688 }
689 else
690 sound_destroy = 0;
651 break; 691 break;
652 692
653 case KW_x: f.get (x); break; 693 case KW_x: f.get (x); break;
654 case KW_y: f.get (y); break; 694 case KW_y: f.get (y); break;
655 695
… …
696 case KW_invisible: f.get (invisible); break; 736 case KW_invisible: f.get (invisible); break;
697 case KW_magic: f.get (magic); break; 737 case KW_magic: f.get (magic); break;
698 case KW_state: f.get (state); break; 738 case KW_state: f.get (state); break;
699 case KW_move_slow_penalty: f.get (move_slow_penalty); break; 739 case KW_move_slow_penalty: f.get (move_slow_penalty); break;
700 case KW_material: f.get (materials); break; //TODO: nuke 740 case KW_material: f.get (materials); break; //TODO: nuke
701 case KW_materialname: f.get (materialname); break; 741 case KW_materialname: f.get (material); break;
702 742
703 /* These are the new values */ 743 /* These are the new values */
704 case KW_move_block: set_move (move_block, f.get_str ()); break; 744 case KW_move_block: set_move (move_block, f); break;
705 case KW_move_allow: set_move (move_allow, f.get_str ()); break; 745 case KW_move_allow: set_move (move_allow, f); break;
706 case KW_move_type: set_move (move_type, f.get_str ()); break; 746 case KW_move_type: set_move (move_type , f); break;
707 case KW_move_on: set_move (move_on, f.get_str ()); break; 747 case KW_move_on: set_move (move_on , f); break;
708 case KW_move_off: set_move (move_off, f.get_str ()); break; 748 case KW_move_off: set_move (move_off , f); break;
709 case KW_move_slow: set_move (move_slow, f.get_str ()); break; 749 case KW_move_slow: set_move (move_slow , f); break;
710 750
711 /* These are all legacy - any new objects should use the move_ .. values */ 751 /* These are all legacy - any new objects should use the move_ .. values */
712 case KW_no_pass: 752 case KW_no_pass:
713 { 753 {
714 if (f.get_sint32 ()) 754 if (f.get_sint32 ())
… …
777 817
778 818
779 case KW_identified: 819 case KW_identified:
780 GET_FLAG (this, FLAG_IDENTIFIED); 820 GET_FLAG (this, FLAG_IDENTIFIED);
781 //TODO: move to check_object or so 821 //TODO: move to check_object or so
782 if (QUERY_FLAG (this, FLAG_IDENTIFIED)) 822 if (this->flag [FLAG_IDENTIFIED])
783 CLEAR_FLAG (this, FLAG_KNOWN_MAGICAL); 823 this->clr_flag (FLAG_KNOWN_MAGICAL);
784 824
785 break; 825 break;
786 826
787 case KW_friendly: 827 case KW_friendly:
788 if (f.get_bool ()) 828 if (f.get_bool ())
… …
823 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break; 863 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break;
824 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break; 864 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break;
825 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break; 865 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break;
826 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break; 866 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break;
827 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break; 867 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break;
828 case KW_no_fix_player: GET_FLAG (this, FLAG_NO_FIX_PLAYER); break;
829 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break; 868 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break;
830 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break; 869 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break;
831 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break; 870 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break;
832 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break; 871 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break;
833 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break; 872 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break;
… …
877 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break; 916 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break;
878 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break; 917 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break;
879 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break; 918 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break;
880 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break; 919 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break;
881 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break; 920 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break;
921 case KW_random_speed: GET_FLAG (this, FLAG_RANDOM_SPEED); break;
882 922
883 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break; 923 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break;
884 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break; 924 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break;
885 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break; 925 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break;
886 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break; 926 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break;
… …
916 case KW_anim_speed: f.get (anim_speed); break; 956 case KW_anim_speed: f.get (anim_speed); break;
917 case KW_container: f.get (weight_limit); break; 957 case KW_container: f.get (weight_limit); break;
918 case KW_will_apply: f.get (will_apply); break; 958 case KW_will_apply: f.get (will_apply); break;
919 case KW_attack_movement: f.get (attack_movement); break; 959 case KW_attack_movement: f.get (attack_movement); break;
920 case KW_move_state: f.get (move_status); break; 960 case KW_move_state: f.get (move_status); break;
921 case KW_expmul: f.get (expmul); break; 961 //case KW_expmul: f.get (expmul); break;//D declared const for the time being
922 case KW_glow_radius: f.get (glow_radius); break; 962 case KW_glow_radius: f.get (glow_radius); break;
923 case KW_weapontype: f.get (weapontype); break; 963 case KW_weapontype: f.get (weapontype); break;
924 case KW_tooltype: f.get (tooltype); break;
925 case KW_casting_time: f.get (casting_time); break; 964 case KW_casting_time: f.get (casting_time); break;
965
966 // elevation is deprecated
926 case KW_elevation: f.get (elevation); break; 967 case KW_elevation: break;
968
927 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break; 969 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break;
928 case KW_client_type: f.get (client_type); break; 970 case KW_client_type: f.get (client_type); break;
929 case KW_duration: f.get (duration); break; 971 case KW_duration: f.get (duration); break;
930 case KW_range: f.get (range); break; 972 case KW_range: f.get (range); break;
931 case KW_range_modifier: f.get (range_modifier); break; 973 case KW_range_modifier: f.get (range_modifier); break;
… …
950 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break; 992 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break;
951 case KW_can_apply: 993 case KW_can_apply:
952 break; 994 break;
953 995
954 case KW_connected: 996 case KW_connected:
955 add_button_link (this, map, f.get_sint32 ()); 997 {
998 shstr connected;
999
1000 f.get (connected);
1001 add_link (map, connected);
1002 }
956 break; 1003 break;
957 1004
958 case KW_randomitems: 1005 case KW_randomitems:
959 if (f.get_str ()) 1006 if (f.has_value ())
960 { 1007 {
961 randomitems = 1008 randomitems =
962 loading_arch 1009 loading_arch
963 ? treasurelist::get (f.get_str ()) 1010 ? treasurelist::get (f.get_str ())
964 : treasurelist::find (f.get_str ()); 1011 : treasurelist::find (f.get_str ());
965 1012
966 if (!randomitems) 1013 if (!randomitems)
1014 {
967 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ()); 1015 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ());
1016 randomitems = treasurelist::get (shstr_none); // avoid crashes
1017 }
968 } 1018 }
969 else 1019 else
970 randomitems = 0; 1020 randomitems = 0;
971 break; 1021 break;
972 1022
… …
1031 archetype *arch = archetype::find (f.get_str ()); 1081 archetype *arch = archetype::find (f.get_str ());
1032 1082
1033 if (!arch) 1083 if (!arch)
1034 { 1084 {
1035 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ()); 1085 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ());
1036 arch = archetype::find ("earthwall"); 1086 arch = archetype::find (shstr_earthwall);
1037 } 1087 }
1038 1088
1039 assert (arch); //D maybe use exception handling of sorts? 1089 assert (arch); //D maybe use exception handling of sorts?
1040 1090
1041 f.next (); 1091 f.next ();
… …
1045 // instance() activates, this should be fixed properly 1095 // instance() activates, this should be fixed properly
1046 op->deactivate (); 1096 op->deactivate ();
1047 1097
1048 if (!op->parse_kv (f)) 1098 if (!op->parse_kv (f))
1049 { 1099 {
1050 op->destroy (true); 1100 op->destroy ();
1051 return 0; 1101 return 0;
1052 } 1102 }
1053 1103
1054 op->post_load_check (); 1104 op->post_load_check ();
1055 return op; 1105 return op;
… …
1067 object_thawer f (buf, (AV *)0); 1117 object_thawer f (buf, (AV *)0);
1068 1118
1069 return op->parse_kv (f); 1119 return op->parse_kv (f);
1070} 1120}
1071 1121
1072/* This returns a string of the integer movement type */
1073#if 0
1074// unused function
1075static char *
1076get_string_move_type (MoveType mt)
1077{
1078 static char retbuf[MAX_BUF], retbuf_all[MAX_BUF];
1079 int i, all_count = 0, count;
1080
1081 strcpy (retbuf, "");
1082 strcpy (retbuf_all, " all");
1083
1084 /* Quick check, and probably fairly common */
1085 if (mt == MOVE_ALL)
1086 return retbuf_all + 1;
1087 if (mt == 0)
1088 {
1089 strcpy (retbuf, "0");
1090 return retbuf;
1091 }
1092
1093 /* We basically slide the bits down. Why look at MOVE_ALL?
1094 * because we may want to return a string like 'all -swim',
1095 * and if we just looked at mt, we couldn't get that.
1096 */
1097 for (i = MOVE_ALL, count = 0; i != 0; i >>= 1, count++)
1098 {
1099 if (mt & (1 << count))
1100 {
1101 strcat (retbuf, " ");
1102 strcat (retbuf, move_name[count]);
1103 }
1104 else
1105 {
1106 strcat (retbuf_all, " -");
1107 strcat (retbuf_all, move_name[count]);
1108 all_count++;
1109 }
1110 }
1111 /* Basically, if there is a single negation, return it, eg
1112 * 'all -swim'. But more than that, just return the
1113 * enumerated values. It doesn't make sense to return
1114 * 'all -walk -fly_low' - it is shorter to return 'fly_high swim'
1115 */
1116 if (all_count <= 1)
1117 return retbuf_all + 1;
1118 else
1119 return retbuf + 1;
1120}
1121#endif
1122
1123// compare *op against *tmp and output differences 1122// compare *op against *arch and output differences
1124static void 1123static void
1125write_diff (object_freezer &f, object *op, object *tmp) 1124write_diff (object_freezer &f, object *op, object *arch)
1126{ 1125{
1127 static const keyword resist_save[NROFATTACKS] = { 1126 static const keyword resist_save[NROFATTACKS] = {
1128# define def(uc, lc, name, plus, change) KW_resist_ ## lc, 1127# define def(uc, lc, name, plus, change) KW_resist_ ## lc,
1129# include "attackinc.h" 1128# include "attackinc.h"
1130# undef def 1129# undef def
… …
1144 KW_applied, 1143 KW_applied,
1145 KW_unpaid, 1144 KW_unpaid,
1146 KW_can_use_shield, 1145 KW_can_use_shield,
1147 KW_no_pick, 1146 KW_no_pick,
1148 KW_NULL, // walk_on 1147 KW_NULL, // walk_on
1148 /* 10 */
1149 KW_NULL, // no_pass 1149 KW_NULL, // no_pass
1150 /* 10 */
1151 KW_is_animated, 1150 KW_is_animated,
1152 KW_NULL, // slow_move 1151 KW_NULL, // slow_move
1153 KW_NULL, // flying 1152 KW_NULL, // flying
1154 KW_monster, 1153 KW_monster,
1155 KW_friendly, 1154 KW_friendly,
1156 KW_generator, 1155 KW_generator,
1157 KW_is_thrown, 1156 KW_is_thrown,
1158 KW_auto_apply, 1157 KW_auto_apply,
1159 KW_treasure_env, 1158 KW_treasure_env,
1159 /* 20 */
1160 KW_player_sold, 1160 KW_player_sold,
1161 /* 20 */
1162 KW_see_invisible, 1161 KW_see_invisible,
1163 KW_can_roll, 1162 KW_can_roll,
1164 KW_overlay_floor, 1163 KW_overlay_floor,
1165 KW_is_turnable, 1164 KW_is_turnable,
1166 KW_NULL, // walk_off 1165 KW_NULL, // walk_off
1167 KW_NULL, // fly_on 1166 KW_NULL, // fly_on
1168 KW_NULL, // fly_off 1167 KW_NULL, // fly_off
1169 KW_is_used_up, 1168 KW_is_used_up,
1170 KW_identified, 1169 KW_identified,
1170 /* 30 */
1171 KW_reflecting, 1171 KW_reflecting,
1172 /* 30 */
1173 KW_changing, 1172 KW_changing,
1174 KW_splitting, 1173 KW_splitting,
1175 KW_hitback, 1174 KW_hitback,
1176 KW_startequip, 1175 KW_startequip,
1177 KW_blocksview, 1176 KW_blocksview,
1178 KW_undead, 1177 KW_undead,
1179 KW_scared, 1178 KW_scared,
1180 KW_unaggressive, 1179 KW_unaggressive,
1181 KW_reflect_missile, 1180 KW_reflect_missile,
1181 /* 40 */
1182 KW_reflect_spell, 1182 KW_reflect_spell,
1183 /* 40 */
1184 KW_no_magic, 1183 KW_no_magic,
1185 KW_no_fix_player, 1184 KW_NULL,
1186 KW_is_lightable, 1185 KW_is_lightable,
1187 KW_tear_down, 1186 KW_tear_down,
1188 KW_run_away, 1187 KW_run_away,
1189 KW_NULL, // pass_thru 1188 KW_NULL, // pass_thru
1190 KW_NULL, // an_pass_thru 1189 KW_NULL, // an_pass_thru
1191 KW_pick_up, 1190 KW_pick_up,
1192 KW_unique, 1191 KW_unique,
1192 /* 50 */
1193 KW_no_drop, 1193 KW_no_drop,
1194 /* 50 */
1195 KW_NULL, // wizcast 1194 KW_NULL, // wizcast
1196 KW_can_cast_spell, 1195 KW_can_cast_spell,
1197 KW_can_use_scroll, 1196 KW_can_use_scroll,
1198 KW_can_use_range, 1197 KW_can_use_range,
1199 KW_can_use_bow, 1198 KW_can_use_bow,
1200 KW_can_use_armour, 1199 KW_can_use_armour,
1201 KW_can_use_weapon, 1200 KW_can_use_weapon,
1202 KW_can_use_ring, 1201 KW_can_use_ring,
1203 KW_has_ready_range, 1202 KW_has_ready_range,
1203 /* 60 */
1204 KW_has_ready_bow, 1204 KW_has_ready_bow,
1205 /* 60 */
1206 KW_xrays, 1205 KW_xrays,
1207 KW_NULL, 1206 KW_NULL,
1208 KW_is_floor, 1207 KW_is_floor,
1209 KW_lifesave, 1208 KW_lifesave,
1210 KW_no_strength, 1209 KW_no_strength,
1211 KW_sleep, 1210 KW_sleep,
1212 KW_stand_still, 1211 KW_stand_still,
1213 KW_random_move, 1212 KW_random_move,
1214 KW_only_attack, 1213 KW_only_attack,
1214 /* 70 */
1215 KW_confused, 1215 KW_confused,
1216 /* 70 */
1217 KW_stealth, 1216 KW_stealth,
1218 KW_NULL, 1217 KW_NULL,
1219 KW_NULL, 1218 KW_NULL,
1220 KW_cursed, 1219 KW_cursed,
1221 KW_damned, 1220 KW_damned,
1222 KW_see_anywhere, 1221 KW_see_anywhere,
1223 KW_known_magical, 1222 KW_known_magical,
1224 KW_known_cursed, 1223 KW_known_cursed,
1225 KW_can_use_skill, 1224 KW_can_use_skill,
1225 /* 80 */
1226 KW_been_applied, 1226 KW_been_applied,
1227 /* 80 */
1228 KW_has_ready_scroll, 1227 KW_has_ready_scroll,
1229 KW_can_use_rod, 1228 KW_can_use_rod,
1230 KW_precious, 1229 KW_precious,
1231 KW_can_use_horn, 1230 KW_can_use_horn,
1232 KW_make_invisible, 1231 KW_make_invisible,
1233 KW_inv_locked, 1232 KW_inv_locked,
1234 KW_is_wooded, 1233 KW_is_wooded,
1235 KW_is_hilly, 1234 KW_is_hilly,
1236 KW_has_ready_skill, 1235 KW_has_ready_skill,
1236 /* 90 */
1237 KW_has_ready_weapon, 1237 KW_has_ready_weapon,
1238 /* 90 */
1239 KW_no_skill_ident, 1238 KW_no_skill_ident,
1240 KW_is_blind, 1239 KW_is_blind,
1241 KW_can_see_in_dark, 1240 KW_can_see_in_dark,
1242 KW_is_cauldron, 1241 KW_is_cauldron,
1243 KW_NULL, 1242 KW_NULL,
1244 KW_no_steal, 1243 KW_no_steal,
1245 KW_one_hit, 1244 KW_one_hit,
1246 KW_NULL, 1245 KW_NULL,
1247 KW_berserk, 1246 KW_berserk,
1247 /* 100 */
1248 KW_neutral, 1248 KW_neutral,
1249 /* 100 */
1250 KW_no_attack, 1249 KW_no_attack,
1251 KW_no_damage, 1250 KW_no_damage,
1252 KW_obj_original, 1251 KW_obj_original,
1253 KW_NULL, 1252 KW_random_speed,
1254 KW_activate_on_push, 1253 KW_activate_on_push,
1255 KW_activate_on_release, 1254 KW_activate_on_release,
1256 KW_is_water, 1255 KW_is_water,
1257 KW_use_content_on_gen, 1256 KW_use_content_on_gen,
1258 KW_NULL, 1257 KW_NULL,
1258 /* 110 */
1259 KW_is_buildable, 1259 KW_is_buildable,
1260 /* 110 */
1261 KW_destroy_on_death, 1260 KW_destroy_on_death,
1262 KW_NULL, 1261 KW_NULL,
1263 }; 1262 };
1263
1264 // obj_original is the only commonly differing flag between archetype
1265 // and object, so special-case it here to be able to skip the loop
1266 static const struct flagmask : object::flags_t
1267 {
1268 flagmask ()
1269 {
1270 for (int i = 0; i < NUM_FLAGS; i++)
1271 if (flag_names [i])
1272 set (i);
1273 }
1274 } flagmask;
1264 1275
1265 /* This saves the key/value lists. We do it first so that any 1276 /* This saves the key/value lists. We do it first so that any
1266 * keys that match field names will be overwritten by the loader. 1277 * keys that match field names will be overwritten by the loader.
1267 */ 1278 */
1268 for (key_value *kv = op->key_values; kv; kv = kv->next) 1279 for (key_value *kv = op->key_values; kv; kv = kv->next)
1269 if (!tmp->key_values || tmp->kv (kv->key) != kv->value) 1280 if (!arch->key_values || arch->kv (kv->key) != kv->value)
1270 f.put (kv->key, kv->value); 1281 f.put (kv->key, kv->value);
1271 1282
1272 /* We don't need to worry about the arch's extra fields - they 1283 if (op->uuid)
1273 * will get taken care of the copy_to method. 1284 {
1274 */ 1285 // highly optimised - this is often 25% of all data written
1286 char *cur = f.force (sizeof ("uuid ") + UUID::MAX_LEN + 1);
1287 char *ptr = cur;
1275 1288
1276 f.put (KW_uuid, op->uuid.c_str ()); 1289 memcpy (ptr, "uuid ", sizeof ("uuid ") - 1);
1290 ptr += sizeof ("uuid ") - 1;
1291 ptr = op->uuid.append (ptr);
1292 *ptr++ = '\n';
1277 1293
1294 f.alloc (ptr - cur);
1295 }
1296
1278#define CMP_OUT(v) if (expect_false (op->v != tmp->v)) f.put (KW_ ## v, op->v) 1297#define CMP_OUT(v) if (expect_false (op->v != arch->v)) f.put (KW (v), op->v)
1279#define CMP_OUT2(k,v) if (expect_false (op->v != tmp->v)) f.put (KW_ ## k, op->v) 1298#define CMP_OUT2(k,v) if (expect_false (op->v != arch->v)) f.put (KW (k), op->v)
1280 1299
1281 if (object *owner = op->owner) 1300 CMP_OUT (x);
1282 f.put (KW_owner, static_cast<const char *>(owner->ref ())); 1301 CMP_OUT (y);
1302
1303 CMP_OUT (type);
1304 CMP_OUT (subtype);
1305 CMP_OUT (direction);
1283 1306
1284 CMP_OUT (name); 1307 CMP_OUT (name);
1285 CMP_OUT (name_pl); 1308 CMP_OUT (name_pl);
1286 CMP_OUT (custom_name); 1309 CMP_OUT (speed);
1310
1311 // speed_left is a major time-burner, and has good locality, so
1312 // we use a simple lookup-cache to avoid the very slow printf.
1313 if (op->speed_left != arch->speed_left)
1314 {
1315 static double last_speed_left = 0.;
1316 static char last_speed_left_str [256] = "sl 0\n";
1317 static int last_speed_left_len = sizeof ("sl 0\n") - 1;
1318
1319 if (last_speed_left != op->speed_left)
1320 {
1321 last_speed_left = op->speed_left;
1322 last_speed_left_len = sizeof ("sl ") - 1
1323 + sprintf (last_speed_left_str + sizeof ("sl ") - 1, "%.7g\n", last_speed_left);
1324 }
1325
1326 f.add (last_speed_left_str, last_speed_left_len);
1327 }
1328
1287 CMP_OUT (title); 1329 CMP_OUT (title);
1288 CMP_OUT (race); 1330 CMP_OUT (race);
1331 CMP_OUT (slaying);
1289 CMP_OUT (skill); 1332 CMP_OUT (skill);
1290 CMP_OUT (slaying); 1333
1291 CMP_OUT (tag); 1334 CMP_OUT (tag);
1335 CMP_OUT (custom_name);
1336
1337 if (object *owner = op->owner)
1338 if (const char *ref = owner->ref ())
1339 f.put (KW(owner), ref);
1340
1341 // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved
1342
1292 CMP_OUT (other_arch); 1343 CMP_OUT (other_arch);
1293 1344
1294 if (op->msg != tmp->msg ) f.put (KW_msg , KW_endmsg , op->msg ); 1345 if (op->msg != arch->msg ) f.put (KW(msg) , KW(endmsg) , op->msg );
1295 if (op->lore != tmp->lore) f.put (KW_lore, KW_endlore, op->lore); 1346 if (op->lore != arch->lore) f.put (KW(lore), KW(endlore), op->lore);
1296 1347
1297 if (op->face != tmp->face ) f.put (KW_face , op->face ? &faces [op->face ] : 0); 1348 if (op->face != arch->face ) f.put (KW(face) , op->face ? &faces [op->face ] : 0);
1298 if (op->sound != tmp->sound ) f.put (KW_sound , op->sound ? &faces [op->sound ] : 0); 1349 if (op->sound != arch->sound ) f.put (KW(sound) , op->sound ? &faces [op->sound ] : 0);
1299 if (op->sound_destroy != tmp->sound_destroy) f.put (KW_sound_destroy, op->sound_destroy ? &faces [op->sound_destroy] : 0); 1350 if (op->sound_destroy != arch->sound_destroy) f.put (KW(sound_destroy), op->sound_destroy ? &faces [op->sound_destroy] : 0);
1300 1351
1301 if (op->animation_id != tmp->animation_id) 1352 if (op->animation_id != arch->animation_id)
1302 if (op->animation_id) 1353 if (op->has_anim ())
1354 f.put (KW(animation), op->anim ().name);
1355 else
1303 { 1356 {
1304 f.put (KW_animation, animations[GET_ANIM_ID (op)].name);
1305
1306 if (!QUERY_FLAG (op, FLAG_ANIMATE))
1307 f.put (KW_is_animated, (sint32)0); 1357 f.put (KW(animation));
1358 op->flag [FLAG_ANIMATE] = false; // TODO: why force to false here?
1308 } 1359 }
1309 else
1310 f.put (KW_animation, (const char *)0);
1311 1360
1312 CMP_OUT2 (str, stats.Str); 1361 CMP_OUT2 (str, stats.Str);
1313 CMP_OUT2 (dex, stats.Dex); 1362 CMP_OUT2 (dex, stats.Dex);
1314 CMP_OUT2 (con, stats.Con); 1363 CMP_OUT2 (con, stats.Con);
1315 CMP_OUT2 (wis, stats.Wis); 1364 CMP_OUT2 (wis, stats.Wis);
… …
1324 CMP_OUT2 (grace, stats.grace); 1373 CMP_OUT2 (grace, stats.grace);
1325 CMP_OUT2 (maxgrace, stats.maxgrace); 1374 CMP_OUT2 (maxgrace, stats.maxgrace);
1326 CMP_OUT2 (exp, stats.exp); 1375 CMP_OUT2 (exp, stats.exp);
1327 1376
1328 CMP_OUT (perm_exp); 1377 CMP_OUT (perm_exp);
1329 CMP_OUT (expmul); 1378 //CMP_OUT (expmul);
1330 1379
1331 CMP_OUT2 (food, stats.food); 1380 CMP_OUT2 (food, stats.food);
1332 CMP_OUT2 (dam, stats.dam); 1381 CMP_OUT2 (dam, stats.dam);
1333 CMP_OUT2 (luck, stats.luck); 1382 CMP_OUT2 (luck, stats.luck);
1334 CMP_OUT2 (wc, stats.wc); 1383 CMP_OUT2 (wc, stats.wc);
1335 CMP_OUT2 (ac, stats.ac); 1384 CMP_OUT2 (ac, stats.ac);
1336 1385
1337 CMP_OUT (x);
1338 CMP_OUT (y);
1339 CMP_OUT (speed);
1340 CMP_OUT (speed_left);
1341 CMP_OUT2 (move_state, move_status); 1386 CMP_OUT2 (move_state, move_status);
1342 CMP_OUT (attack_movement); 1387 CMP_OUT (attack_movement);
1343 CMP_OUT (nrof); 1388 CMP_OUT (nrof);
1344 CMP_OUT (level); 1389 CMP_OUT (level);
1345 CMP_OUT (direction);
1346 CMP_OUT (type);
1347 CMP_OUT (subtype);
1348 CMP_OUT (attacktype); 1390 CMP_OUT (attacktype);
1349 1391
1392 // using memcmp here seems to be a loss - is gcc vectorising?
1350 for (int i = 0; i < NROFATTACKS; i++) 1393 for (int i = 0; i < NROFATTACKS; i++)
1351 if (expect_false (op->resist[i] != tmp->resist[i])) 1394 if (expect_false (op->resist[i] != arch->resist[i]))
1352 f.put (resist_save[i], op->resist[i]); 1395 f.put (resist_save[i], op->resist[i]);
1353 1396
1354 CMP_OUT (path_attuned); 1397 CMP_OUT (path_attuned);
1355 CMP_OUT (path_repelled); 1398 CMP_OUT (path_repelled);
1356 CMP_OUT (path_denied); 1399 CMP_OUT (path_denied);
1400
1357 CMP_OUT2 (material, materials);//TODO: nuke 1401 CMP_OUT2 (material, materials);//TODO: nuke
1358 CMP_OUT (materialname); 1402 if (op->material != arch->material)
1403 f.put (KW(materialname), op->material->name);
1404
1359 CMP_OUT (value); 1405 CMP_OUT (value);
1360 CMP_OUT (carrying); 1406 CMP_OUT (carrying);
1361 CMP_OUT (weight); 1407 CMP_OUT (weight);
1362 CMP_OUT (invisible); 1408 CMP_OUT (invisible);
1363 CMP_OUT (state); 1409 CMP_OUT (state);
… …
1367 CMP_OUT (last_grace); 1413 CMP_OUT (last_grace);
1368 CMP_OUT (last_eat); 1414 CMP_OUT (last_eat);
1369 CMP_OUT (glow_radius); 1415 CMP_OUT (glow_radius);
1370 1416
1371 if (op->flag [FLAG_IS_LINKED]) 1417 if (op->flag [FLAG_IS_LINKED])
1372 if (int i = get_button_value (op)) 1418 if (auto (ol, op->find_link ()))
1373 f.put (KW_connected, i); 1419 f.put (KW(connected), ol->id);
1374 1420
1375 CMP_OUT (randomitems); 1421 CMP_OUT (randomitems);
1422
1376 CMP_OUT2 (container, weight_limit); 1423 CMP_OUT2 (container, weight_limit);
1377 1424
1378 CMP_OUT (run_away); 1425 CMP_OUT (run_away);
1379 CMP_OUT (pick_up); 1426 CMP_OUT (pick_up);
1380 CMP_OUT (will_apply); 1427 CMP_OUT (will_apply);
1381 CMP_OUT (smoothlevel); 1428 CMP_OUT (smoothlevel);
1382 CMP_OUT (weapontype); 1429 CMP_OUT (weapontype);
1383 CMP_OUT (tooltype);
1384 CMP_OUT (elevation);
1385 CMP_OUT (client_type); 1430 CMP_OUT (client_type);
1386 CMP_OUT (item_power); 1431 CMP_OUT (item_power);
1387 CMP_OUT (duration); 1432 CMP_OUT (duration);
1388 CMP_OUT (range); 1433 CMP_OUT (range);
1389 CMP_OUT (range_modifier); 1434 CMP_OUT (range_modifier);
… …
1397 CMP_OUT (move_on); 1442 CMP_OUT (move_on);
1398 CMP_OUT (move_off); 1443 CMP_OUT (move_off);
1399 CMP_OUT (move_slow); 1444 CMP_OUT (move_slow);
1400 CMP_OUT (move_slow_penalty); 1445 CMP_OUT (move_slow_penalty);
1401 1446
1402 if (op->flag != tmp->flag) 1447 object::flags_t diff = (op->flag ^ arch->flag) & flagmask;
1448
1449#if stdcpp // we need gcc, sorry
1450 if (diff [FLAG_OBJ_ORIGINAL])
1451 f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? CS(1) : CS(0));
1452
1453 diff.reset (FLAG_OBJ_ORIGINAL);
1454
1455 // quickly test whether any other flags differ
1456 if (expect_true (diff.any ()))
1403 for (int i = 0; i <= NUM_FLAGS; i++) 1457 for (int i = 0; i < NUM_FLAGS; i++)
1404 if (expect_false (flag_names [i] && op->flag [i] != tmp->flag [i])) 1458 if (expect_false (diff [i]))
1405 f.put (flag_names [i], op->flag [i] ? "1" : "0"); 1459 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1460#else
1461 // use sgi extensions
1462 for (int i = diff._Find_first (); i < diff.size (); i = diff._Find_next (i))
1463 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1464#endif
1406 1465
1407 // save body locations 1466 // save body locations. gcc's memcmp does an abysmal job when used
1408 for (int i = 0; i < NUM_BODY_LOCATIONS; i++) 1467 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
1409 if (expect_false (op->slot[i].info != tmp->slot[i].info)) 1468 if (expect_false (op->slot[i].info != arch->slot[i].info))
1410 f.put (body_locations[i].save_name, op->slot[i].info); 1469 f.put (body_locations[i].save_name, op->slot[i].info);
1411} 1470}
1412 1471
1413/* 1472/*
1414 * Dumps all variables in an object to a file. 1473 * Dumps all variables in an object to a file.
… …
1416 * the only place this is not set is when saving the player. 1475 * the only place this is not set is when saving the player.
1417 */ 1476 */
1418bool 1477bool
1419object::write (object_freezer &f) 1478object::write (object_freezer &f)
1420{ 1479{
1421 archetype *at = arch ? arch : archetype::empty; 1480 if (expect_false (is_arch ()))
1422 1481 {
1482 f.put (KW(object), arch->archname);
1483 write_diff (f, this, archetype::empty);
1484 }
1485 else
1486 {
1423 f.put (KW_arch, at->archname); 1487 f.put (KW(arch), arch->archname);
1424 write_diff (f, this, at); 1488 write_diff (f, this, arch);
1489 }
1425 1490
1426 for (object *tmp = inv; tmp; tmp = tmp->below) 1491 for (object *tmp = inv; tmp; tmp = tmp->below)
1427 tmp->write (f); 1492 tmp->write (f);
1428 1493
1429 f.put (this); 1494 f.put (this);
1430 f.put (KW_end); 1495 f.put (KW(end));
1431 1496
1432 return true; 1497 return true;
1433} 1498}
1434 1499
1435///////////////////////////////////////////////////////////////////////////// 1500/////////////////////////////////////////////////////////////////////////////

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines