ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/loader.C
(Generate patch)

Comparing deliantra/server/common/loader.C (file contents):
Revision 1.62 by root, Mon Feb 19 19:10:31 2007 UTC vs.
Revision 1.177 by root, Wed Nov 16 23:41:59 2016 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 *
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 17 *
18 * You should have received a copy of the Affero GNU General Public License
19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
21 *
22 * The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 23 */
24 24
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying
27 variable. */
28
29#include <global.h> 25#include <global.h>
30#include <loader.h>
31#include <sproto.h> 26#include <sproto.h>
32 27
33///////////////////////////////////////////////////////////////////////////// 28/////////////////////////////////////////////////////////////////////////////
34 29
35/* Maps the MOVE_* values to names */ 30extern archetype *loading_arch;
36static const char *const move_name[] = { "walk", "fly_low", "fly_high", "swim", "boat", NULL }; 31
32//+GPL
37 33
38/* This table is only necessary to convert objects that existed before the 34/* This table is only necessary to convert objects that existed before the
39 * spell object conversion to the new object. It was not practical 35 * spell object conversion to the new object. It was not practical
40 * to go through every mapping looking for every potion, rod, wand, etc 36 * to go through every mapping looking for every potion, rod, wand, etc
41 * that had a sp set and update to the new value. So this maps the 37 * that had a sp set and update to the new value. So this maps the
… …
171 "spell_magic_drain", /* 122 */ 167 "spell_magic_drain", /* 122 */
172 "spell_counterspell", /* 123 */ 168 "spell_counterspell", /* 123 */
173 "spell_disarm", /* 124 */ 169 "spell_disarm", /* 124 */
174 "spell_cure_confusion", /* 125 */ 170 "spell_cure_confusion", /* 125 */
175 "spell_restoration", /* 126 */ 171 "spell_restoration", /* 126 */
176 "was summon evil monster", /* 127 *//* Not implenented as nothing used it */ 172 "spell_summon_devil", /* 127 *//* Not implenented as nothing used it */
177 "spell_counterwall", /* 128 */ 173 "spell_counterwall", /* 128 */
178 "spell_cause_light_wounds", /* 129 */ 174 "spell_cause_light_wounds", /* 129 */
179 "spell_cause_medium_wounds", /* 130 */ 175 "spell_cause_medium_wounds", /* 130 */
180 "spell_cause_heavy_wounds", /* 131 */ 176 "spell_cause_heavy_wounds", /* 131 */
181 "spell_charm_monsters", /* 132 */ 177 "spell_charm_monsters", /* 132 */
… …
253 "spell_cause_rabies", /* 204 */ 249 "spell_cause_rabies", /* 204 */
254 "spell_glyph", /* 205 */ 250 "spell_glyph", /* 205 */
255 NULL 251 NULL
256}; 252};
257 253
258extern int arch_init;
259
260/* This function checks the object after it has been loaded (when we 254/* This function checks the object after it has been loaded (when we
261 * get the 'end' in the input stream). This function can be used to 255 * get the 'end' in the input stream). This function can be used to
262 * deal with legacy objects where fields may have changed. It can also be used 256 * deal with legacy objects where fields may have changed. It can also be used
263 * to check for objects to make sure there are no common errors. 257 * to check for objects to make sure there are no common errors.
264 */ 258 */
265static void 259void
266check_loaded_object (object *op) 260object::post_load_check ()
267{ 261{
262 if (type >= NUM_TYPES)
263 {
264 LOG (llevError, "ITEMBUG: %s: type out of range, resetting to 0.\n", debug_desc ());
265 type = 0;
266 }
267
268 switch (type)
269 {
270 case RANGED:
271 case BOW:
272 case WAND:
273 case ROD:
274 case HORN:
275 if (slot [body_range].info != -1)
276 {
277 LOG (llevError, "ITEMBUG: %s: body_range %d != -1\n", debug_desc (), slot [body_range].info);
278 slot [body_range].info = -1;
279 }
280 break;
281
282 case WEAPON:
283 if (slot [body_combat].info != -1)
284 {
285 LOG (llevError, "ITEMBUG: %s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info);
286 slot [body_combat].info = -1;
287 }
288 break;
289
290 case SHIELD:
291 if (slot [body_shield].info != -1)
292 {
293 LOG (llevError, "ITEMBUG: %s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info);
294 slot [body_shield].info = -1;
295 }
296 break;
297
298 case PLAYER:
299 if (slot [body_shield].info != 1)
300 {
301 LOG (llevError, "ITEMBUG: %s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info);
302 slot [body_shield].info = 1;
303 }
304
305 if (slot [body_combat].info != 1)
306 {
307 LOG (llevError, "ITEMBUG: %s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info);
308 slot [body_combat].info = 1;
309 }
310
311 if (slot [body_range].info != 1)
312 {
313 LOG (llevError, "ITEMBUG: %s: body_range %d != 1\n", debug_desc (), slot [body_range].info);
314 slot [body_range].info = 1;
315 }
316 break;
317 }
318
268 /* We do some specialised handling to handle legacy cases of name_pl. 319 /* We do some specialised handling to handle legacy cases of name_pl.
269 * If the object doesn't have a name_pl, we just use the object name - 320 * If the object doesn't have a name_pl, we just use the object name -
270 * this isn't perfect (things won't be properly pluralised), but works to 321 * this isn't perfect (things won't be properly pluralised), but works to
271 * that degree (5 heart is still quite understandable). But the case we 322 * that degree (5 heart is still quite understandable). But the case we
272 * also have to catch is if this object is not using the normal name for 323 * also have to catch is if this object is not using the normal name for
273 * the object. In that case, we also want to use the loaded name. 324 * the object. In that case, we also want to use the loaded name.
274 * Otherwise, what happens is that the the plural name will lose 325 * Otherwise, what happens is that the the plural name will lose
275 * information (appear as just 'hearts' and not 'goblins heart') 326 * information (appear as just 'hearts' and not 'goblins heart')
276 */ 327 */
277 if (op->arch && op->name != op->arch->clone.name && op->name_pl == op->arch->clone.name_pl) 328 if (arch && name != arch->object::name && name_pl == arch->object::name_pl)
278 op->name_pl = 0; 329 name_pl = 0;
279 330
280 if (!op->name_pl) 331 if (!name_pl)
281 op->name_pl = op->name; 332 name_pl = name;
282 333
283 /* objects now have a materialname. try to patch it in */ 334 /* objects now have a materialname. try to patch it in */
284 if (!(op->is_weapon () && op->level > 0)) 335 if (material == MATERIAL_NULL && !(is_weapon () && level > 0))
336 select_material (this, map ? map->difficulty : 5);
337
338 if (speed < 0.)
285 { 339 {
286 if (op->map != NULL) 340 flag [FLAG_RANDOM_SPEED] = true;
287 set_materialname (op, op->map->difficulty, NULL); 341 speed = -speed;
288 else 342 // speed_left will be randomised in instantiate () and copy_to ()
289 set_materialname (op, 5, NULL);
290 } 343 }
291 344
292 /* only do these when program is first run - a bit 345 /* only do these when program is first run - a bit
293 * excessive to do this at every run - most of this is 346 * excessive to do this at every run - most of this is
294 * really just to catch any errors - program will still run, but 347 * really just to catch any errors - program will still run, but
295 * not in the ideal fashion. 348 * not in the ideal fashion.
296 */ 349 */
297 if ((op->type == WEAPON || op->type == BOW) && arch_init) 350 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND))
298 { 351 {
299 if (!op->skill) 352 if (!skill)
300 LOG (llevError, "Weapon %s lacks a skill.\n", op->debug_desc ()); 353 LOG (llevError, "ITEMBUG: weapon %s lacks a skill.\n", debug_desc ());
301 else if ((!strcmp (op->skill, "one handed weapons") && op->body_info[1] != -1) || 354 else if ((skill == shstr_one_handed_weapons && slot[body_arm].info != -1) ||
302 (!strcmp (op->skill, "two handed weapons") && op->body_info[1] != -2)) 355 (skill == shstr_two_handed_weapons && slot[body_arm].info != -2))
303 LOG (llevError, "weapon %s arm usage does not match skill: %d, %s\n", op->debug_desc (), op->body_info[1], &op->skill); 356 LOG (llevError, "ITEMBUG: weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill);
304 } 357 }
305 358
306 /* We changed last_heal to gen_sp_armour, which is what it 359 /* We changed last_heal to gen_sp_armour, which is what it
307 * really does for many objects. Need to catch any in maps 360 * really does for many objects. Need to catch any in maps
308 * that may have an old value. 361 * that may have an old value.
309 */ 362 */
310 if (op->type == WEAPON 363 if (type == WEAPON
311 || op->type == ARMOUR || op->type == HELMET 364 || type == ARMOUR || type == HELMET
312 || op->type == SHIELD || op->type == RING 365 || type == SHIELD || type == RING
313 || op->type == BOOTS || op->type == GLOVES 366 || type == BOOTS || type == GLOVES
314 || op->type == AMULET || op->type == GIRDLE 367 || type == AMULET || type == GIRDLE
315 || op->type == BRACERS || op->type == CLOAK) 368 || type == BRACERS || type == CLOAK)
316 { 369 {
317 if (op->last_heal) 370 if (last_heal)
318 { 371 {
319 LOG (llevDebug, "Object %s still has last_heal set, not gen_sp_armour\n", op->debug_desc ()); 372 LOG (llevError, "ITEMBUG: object %s still has last_heal set, not gen_sp_armour\n", debug_desc ());
320 op->gen_sp_armour = op->last_heal; 373 gen_sp_armour = last_heal;
321 op->last_heal = 0; 374 last_heal = 0;
322 } 375 }
323 376
324 int ip = calc_item_power (op, 0); 377 int ip = calc_item_power (this, 0);
325 378
326 /* Legacy objects from before item power was in the game */ 379 /* Legacy objects from before item power was in the game */
327 if (!op->item_power && ip) 380 if (!item_power && ip)
328 { 381 {
329 if (ip > 3) 382 if (ip > 3)
330 LOG (llevDebug, "Object %s had no item power, using %d\n", op->debug_desc (), ip); 383 LOG (llevDebug, "ITEMBUG: Object %s had no item power, using %d\n", debug_desc (), ip);
331 384
332 op->item_power = ip; 385 item_power = ip;
333 } 386 }
334 387
335 /* Check for possibly bogus values. Has to meet both these criteria - 388 /* Check for possibly bogus values. Has to meet both these criteria -
336 * something that has item_power 1 is probably just fine if our calculated 389 * something that has item_power 1 is probably just fine if our calculated
337 * value is 1 or 2 - these values are small enough that hard to be precise. 390 * value is 1 or 2 - these values are small enough that hard to be precise.
338 * similarly, it item_power is 0, the first check will always pass, 391 * similarly, it item_power is 0, the first check will always pass,
339 * but not the second one. 392 * but not the second one.
340 */ 393 */
394#if 0 //TODO
341 if (ip > 2 * op->item_power && ip > (op->item_power + 3)) 395 if (ip > 2 * item_power && ip > (item_power + 3))
342 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", op->debug_desc (), ip, op->item_power); 396 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power);
397#endif
343 } 398 }
344 399
345 /* Old spellcasting object - need to load in the appropiate object */ 400 /* old style spellcasting object (pretty common) - need to load in the appropriate object */
346 if ((op->type == ROD || op->type == WAND || op->type == SCROLL || op->type == HORN || op->type == FIREWALL || 401 /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */
402 if ((type == ROD
403 || type == WAND
404 || type == SCROLL
405 || type == HORN
406 || type == FIREWALL
347 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */ 407 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */
348 ((op->type == POTION || op->type == ALTAR) && op->stats.sp)) && !op->inv && !arch_init) 408 || ((type == POTION || type == ALTAR) && stats.sp)) // watchout: sp = 0 is still magic bullet.
409 && !inv
410 && !loading_arch
411 && stats.sp) // watchout: old magic bullet stuff directly on the map is going to break here!
412 // TODO: at least one watchout-comments is redundant - investigate/remove
349 { 413 {
414 // TODO: fix firewall object on map
350 /* Fireall is bizarre in that spell type was stored in dam. Rest are 'normal' 415 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal'
351 * in that spell was stored in sp. 416 * in that spell was stored in sp.
352 */ 417 */
418 //LOG (llevError, "old spellcasting object found: %s", debug_desc ());
353 object *tmp = get_archetype (spell_mapping[op->type == FIREWALL ? op->stats.dam : op->stats.sp]); 419 object *tmp = archetype::get (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]);
354 insert_ob_in_ob (tmp, op); 420 insert_ob_in_ob (tmp, this);
355 op->randomitems = NULL; /* So another spell isn't created for this object */ 421 randomitems = 0;
356 } 422 }
357 423
358 /* spellbooks & runes use slaying. But not to arch name, but to spell name */ 424 /* spellbooks & runes use slaying. But not to arch name, but to spell name */
359 if ((op->type == SPELLBOOK || op->type == RUNE) && op->slaying && !op->inv && !arch_init) 425 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch)
360 { 426 {
427 LOG (llevError, "ITEMBUG: spellbook/rune found without inv but slaying: %s", debug_desc ());
361 object *tmp = get_archetype_by_object_name (op->slaying); 428 object *tmp = get_archetype_by_object_name (slaying);
362 insert_ob_in_ob (tmp, op); 429 insert_ob_in_ob (tmp, this);
363 op->randomitems = NULL; /* So another spell isn't created for this object */ 430 randomitems = 0; /* So another spell isn't created for this object */
364 /* without this, value is all screwed up */ 431 /* without this, value is all screwed up */
365 op->value = op->arch->clone.value * op->inv->value; 432 value = arch->value * inv->value;
366 }
367
368 if (QUERY_FLAG (op, FLAG_MONSTER))
369 { 433 }
434
435 if (this->flag [FLAG_MONSTER])
436 {
370 if (op->stats.hp > op->stats.maxhp) 437 if (stats.hp > stats.maxhp)
371 { 438 {
372 LOG (llevDebug, "Monster %s has hp set higher than maxhp (%d>%d)\n", op->debug_desc (), op->stats.hp, op->stats.maxhp); 439 LOG (llevInfo, "ITEMBUG: monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp);
373 op->stats.maxhp = op->stats.hp; 440 stats.maxhp = stats.hp;
374 } 441 }
375 442
376 /* The archs just need to be updated for this */ 443 /* The archs just need to be updated for this */
377 if (op->move_type == 0) 444 if (move_type == 0)
378 op->move_type = MOVE_WALK; 445 move_type = MOVE_WALK;
379 }
380
381 if ((QUERY_FLAG (op, FLAG_GENERATOR) && QUERY_FLAG (op, FLAG_CONTENT_ON_GEN)) || op->type == CREATOR || op->type == CONVERTER)
382 { 446 }
447
448 if ((this->flag [FLAG_GENERATOR] && this->flag [FLAG_CONTENT_ON_GEN]) || type == CREATOR || type == CONVERTER)
383 /* Object will duplicate it's content as part of the 449 /* Object will duplicate it's content as part of the
384 * generation process. To do this, we must flag inventory 450 * generation process. To do this, we must flag inventory
385 * so it remains unevaluated concerning the randomitems and 451 * so it remains unevaluated concerning the randomitems and
386 * the living (a demonlord shouldn't cast from inside generator!) 452 * the living (a demonlord shouldn't cast from inside generator!)
387 */ 453 */
454 /* ??? this *should* be done elsewhere, e.g. after map loading etc. */
388 flag_inv (op, FLAG_IS_A_TEMPLATE); 455 flag_inv (this, FLAG_IS_A_TEMPLATE);
389 }
390 456
391 /* Handle player movers. We use move_type for player movers 457 /* Handle player movers. We use move_type for player movers
392 * because they operate on their own time (move_on 458 * because they operate on their own time (move_on
393 * would potentially cause them to be triggered when someone steps 459 * would potentially cause them to be triggered when someone steps
394 * on them). If move_type is set, presume person knows what they 460 * on them). If move_type is set, presume person knows what they
395 * are doing, otherwise, set move_type based on maxhp value. 461 * are doing, otherwise, set move_type based on maxhp value.
396 */ 462 */
397 if (op->type == PLAYERMOVER) 463 if (type == PLAYERMOVER)
398 { 464 {
399 if (!op->move_type) 465 if (!move_type)
400 { 466 {
401 if (op->stats.maxhp) 467 if (stats.maxhp)
402 { 468 {
403 op->move_type = MOVE_ALL; 469 move_type = MOVE_ALL;
404 op->stats.maxhp = 0; 470 stats.maxhp = 0;
405 } 471 }
406 else 472 else
407 op->move_type = MOVE_WALK; 473 move_type = MOVE_WALK;
408 } 474 }
409 } 475 }
410 476
477 // if the object has an animation, try to provide a default face
478 if (has_anim ())
479 {
480 if (anim_speed)
481 // if this item is time-animated, force the last frame
482 animate_object (this, 0);
483 else if (flag [FLAG_MONSTER])
484 // if it is a monster, set appropriate facing
485 animate_object (this, direction);
486 }
411} 487}
412 488
413static void 489static void
414set_move (MoveType & mt, const char *str) 490set_move (MoveType &mt, object_thawer &f)
415{ 491{
416 if (!str) 492 static const struct flagstr {
417 { 493 const char *name;
418 mt = 0; 494 MoveType flags;
419 return; 495 } move_flags[] = {
420 } 496 { "walk" , MOVE_WALK },
497 { "flying" , MOVE_FLY_LOW | MOVE_FLY_HIGH },
498 { "fly_low" , MOVE_FLY_LOW },
499 { "fly_high", MOVE_FLY_HIGH },
500 { "swim" , MOVE_SWIM },
501 { "boat" , MOVE_BOAT },
502 { "ship" , MOVE_SHIP },
503 { "all" , MOVE_ALL },
504 };
421 505
506 const char *str = f.get_str ();
507
422 if (isdigit (*str)) 508 if (!*str || isdigit (*str))
423 { 509 {
424 mt = atoi (str); 510 mt = atoi (str);
425 return; 511 return;
426 } 512 }
427 513
428 mt = 0; 514 mt = 0;
429 515
430 for (str = strtok ((char *) str, " "); str; str = strtok (0, " ")) 516 for (str = strtok ((char *)str, " "); str; str = strtok (0, " "))
431 { 517 {
432 if (!strcasecmp (str, "all")) 518 bool negate = 0;
433 mt |= MOVE_ALL; 519
434 else 520 if (*str == '-')
435 { 521 {
436 int i, negate = 0; 522 negate = 1;
523 str++;
524 }
437 525
438 if (*str == '-') 526 for (const flagstr *f = move_flags; f < move_flags + array_length (move_flags); ++f)
527 {
528 if (!strcmp (f->name, str))
439 { 529 {
440 negate = 1;
441 str++;
442 }
443
444 for (i = 0; move_name[i]; i++)
445 {
446 if (!strcasecmp (move_name[i], str))
447 {
448 if (negate) 530 if (negate)
449 mt &= ~(1 << i); 531 mt &= ~f->flags;
450 else
451 mt |= (1 << i);
452
453 break;
454 }
455 }
456
457 if (!move_name[i])
458 {
459 /* fly is a special case - covers both fly_low and
460 * fly_high - since it doesn't match to a specific
461 * single bit, have to special case it.
462 */
463 if (!strcasecmp (str, "flying"))
464 {
465 if (negate)
466 mt &= ~MOVE_FLYING;
467 else
468 mt |= MOVE_FLYING;
469 }
470 else 532 else
471 LOG (llevDebug, "common/loader.l: set_move - unknown move string '%s'\n", str); 533 mt |= f->flags;
534
535 goto next;
472 } 536 }
473 } 537 }
538
539 LOG (llevError, "common/loader.C: set_move - unknown move string '%s'\n", str);
540
541next: ;
474 } 542 }
475} 543}
476 544
477#define GET_FLAG(op,flag) \ 545//-GPL
478 if (f.get_sint32 ()) \ 546
479 SET_FLAG (op, flag); \ 547#define GET_FLAG(op,flg) op->flag [flg] = f.get_bool ()
480 else \
481 CLEAR_FLAG (op, flag) \
482 548
483bool 549bool
484object::parse_kv (object_thawer &f) 550object::parse_kv (object_thawer &f)
485{ 551{
486 assert (f.kw == KW_object || f.kw == KW_arch);
487
488 if (f.kw == KW_object)
489 f.get (name); // preset name from object name
490
491 f.next ();
492
493 object *op_inv = inv; 552 object *op_inv = inv;
494 553
495 for (;;) 554 for (;;)
496 { 555 {
497 switch (f.kw) 556 switch (f.kw)
498 { 557 {
499 case KW_uuid: 558 case KW_uuid:
500 if (const char *s = f.get_str ()) 559 if (!uuid.parse (f.get_str ()))
501 { 560 {
502 unsigned int version; 561 f.parse_warn ("unparseable uuid");
503 unsigned long long seq; 562 uuid = UUID::gen ();
504
505 if (2 == sscanf (s, "<%d.%llx>", &version, &seq) && version == 1)
506 {
507 uuid.seq = seq;
508 break;
509 }
510 } 563 }
511
512 uuid = gen_uuid ();
513 break; 564 break;
514 565
515 case KW_oid: 566 case KW_oid:
516 f.get (this, f.get_sint32 ()); 567 f.get (this, f.get_sint32 ());
517 break; 568 break;
… …
523 574
524 case KW_attach: f.get_ornull (attach); break; 575 case KW_attach: f.get_ornull (attach); break;
525 case KW_skill: f.get_ornull (skill); break; 576 case KW_skill: f.get_ornull (skill); break;
526 case KW_race: f.get_ornull (race); break; 577 case KW_race: f.get_ornull (race); break;
527 case KW_slaying: f.get_ornull (slaying); break; 578 case KW_slaying: f.get_ornull (slaying); break;
579 case KW_tag: f.get_ornull (tag); break;
528 580
529 case KW_arch: 581 case KW_arch:
530 {
531 object *tmp = object::read (f); 582 if (object *tmp = object::read (f))
532 tmp->deactivate ();
533
534 { 583 {
584 tmp->deactivate ();
585
535 // was: insert_ob_in_ob (tmp, op); 586 // was: insert_ob_in_ob (tmp, op);
536 // but manually adding it can improve map loading times a lot 587 // but manually adding it can improve map loading times a lot
537 // also, appending instead of prepending keeps the 588 // also, appending instead of prepending keeps the
538 // save ordering the same between repeated load/saves. 589 // save ordering the same between repeated load/saves.
539 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL); 590 // and finally we do not want any funny effects
540 CLEAR_FLAG (tmp, FLAG_REMOVED); 591 tmp->clr_flag (FLAG_OBJ_ORIGINAL);
592 tmp->clr_flag (FLAG_REMOVED);
541 593
542 if (!op_inv) 594 if (!op_inv)
543 { 595 {
544 inv = tmp; 596 inv = tmp;
545 tmp->above = 0; 597 tmp->above = 0;
… …
555 607
556 tmp->below = 0; 608 tmp->below = 0;
557 tmp->env = this; 609 tmp->env = this;
558 op_inv = tmp; 610 op_inv = tmp;
559 } 611 }
560 } 612 else
613 LOG (llevError, "ERROR: couldn't load inventory object, file corrupted?\n");
614
561 continue; 615 continue;
562 616
563 case KW_other_arch: 617 case KW_other_arch:
618 if (loading_arch == this)
619 archetype::postpone_arch_ref (loading_arch->other_arch, f.get_str ());
620 else
621 {
564 other_arch = archetype::find (f.get_str ()); 622 other_arch = archetype::find (f.get_str ());
623
624 if (!other_arch)
625 f.parse_warn (format ("%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()));
626 }
627 break;
628
629 case KW_owner:
630 f.delayed_deref (this, owner, f.get_str ());
565 break; 631 break;
566 632
567 case KW_animation: 633 case KW_animation:
568 { 634 {
569 CLEAR_FLAG (this, FLAG_ANIMATE); 635 clr_flag (FLAG_ANIMATE);
570 animation_id = 0; 636 animation_id = 0;
571 637
572 const char *str = f.get_str (); 638 if (f.has_value () && (animation_id = animation::find (f.get_str ()).number))
573 if (str && (animation_id = find_animation (str))) 639 set_flag (FLAG_ANIMATE); //TODO: should not be forced to true here
574 SET_FLAG (this, FLAG_ANIMATE);
575 } 640 }
576 break; 641 break;
577 642
578 case KW_last_heal: f.get (last_heal); break; 643 case KW_last_heal: f.get (last_heal); break;
579 case KW_last_sp: f.get (last_sp); break; 644 case KW_last_sp: f.get (last_sp); break;
580 case KW_last_grace: f.get (last_grace); break; 645 case KW_last_grace: f.get (last_grace); break;
581 case KW_last_eat: f.get (last_eat); break; 646 case KW_last_eat: f.get (last_eat); break;
647 case KW_sl:
582 case KW_speed_left: f.get (speed_left); break; 648 case KW_speed_left: f.get (speed_left); break;
583 649
584 case KW_speed: 650 case KW_speed:
585 f.get (speed); 651 f.get (speed);
586 652
… …
595 move_slow |= MOVE_WALK; 661 move_slow |= MOVE_WALK;
596 f.get (move_slow_penalty); 662 f.get (move_slow_penalty);
597 break; 663 break;
598 664
599 case KW_face: 665 case KW_face:
600 face = &new_faces[FindFace (f.get_str (), 0)]; 666 face = f.has_value () ? face_find (f.get_str ()) : blank_face;
667 break;
668
669 case KW_sound:
670 if (f.has_value ())
671 {
672 sound = sound_find (f.get_str ());
673 if (!sound)
674 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
675 }
676 else
677 sound = 0;
678 break;
679
680 case KW_sound_destroy:
681 if (f.has_value ())
682 {
683 sound_destroy = sound_find (f.get_str ());
684 if (!sound_destroy)
685 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
686 }
687 else
688 sound_destroy = 0;
601 break; 689 break;
602 690
603 case KW_x: f.get (x); break; 691 case KW_x: f.get (x); break;
604 case KW_y: f.get (y); break; 692 case KW_y: f.get (y); break;
605 693
… …
646 case KW_invisible: f.get (invisible); break; 734 case KW_invisible: f.get (invisible); break;
647 case KW_magic: f.get (magic); break; 735 case KW_magic: f.get (magic); break;
648 case KW_state: f.get (state); break; 736 case KW_state: f.get (state); break;
649 case KW_move_slow_penalty: f.get (move_slow_penalty); break; 737 case KW_move_slow_penalty: f.get (move_slow_penalty); break;
650 case KW_material: f.get (materials); break; //TODO: nuke 738 case KW_material: f.get (materials); break; //TODO: nuke
651 case KW_materialname: f.get (materialname); break; 739 case KW_materialname: f.get (material); break;
652 740
653 /* These are the new values */ 741 /* These are the new values */
654 case KW_move_block: set_move (move_block, f.get_str ()); break; 742 case KW_move_block: set_move (move_block, f); break;
655 case KW_move_allow: set_move (move_allow, f.get_str ()); break; 743 case KW_move_allow: set_move (move_allow, f); break;
656 case KW_move_type: set_move (move_type, f.get_str ()); break; 744 case KW_move_type: set_move (move_type , f); break;
657 case KW_move_on: set_move (move_on, f.get_str ()); break; 745 case KW_move_on: set_move (move_on , f); break;
658 case KW_move_off: set_move (move_off, f.get_str ()); break; 746 case KW_move_off: set_move (move_off , f); break;
659 case KW_move_slow: set_move (move_slow, f.get_str ()); break; 747 case KW_move_slow: set_move (move_slow , f); break;
660
661 /* These are all legacy - any new objects should use the move_ .. values */
662 case KW_no_pass:
663 {
664 if (f.get_sint32 ())
665 move_block = MOVE_ALL;
666 else
667 move_block = 0;
668 }
669
670 break;
671
672 /* These are all legacy - any new objects should use the move_ .. values */
673 case KW_walk_on:
674 {
675 if (f.get_sint32 ())
676 move_on |= MOVE_WALK;
677 else
678 move_on &= ~MOVE_WALK;
679 }
680
681 break;
682
683 /* These are all legacy - any new objects should use the move_ .. values */
684 case KW_walk_off:
685 {
686 if (f.get_sint32 ())
687 move_off |= MOVE_WALK;
688 else
689 move_off &= ~MOVE_WALK;
690 }
691 break;
692
693 /* These are all legacy - any new objects should use the move_ .. values */
694 case KW_fly_on:
695 {
696 if (f.get_sint32 ())
697 move_on |= MOVE_FLY_LOW;
698 else
699 move_on &= ~MOVE_FLY_LOW;
700 }
701 break;
702
703 /* These are all legacy - any new objects should use the move_ .. values */
704 case KW_fly_off:
705 {
706 if (f.get_sint32 ())
707 move_off |= MOVE_FLY_LOW;
708 else
709 move_off &= ~MOVE_FLY_LOW;
710 }
711 break;
712 748
713 //TODO: remove these after converting archetypes 749 //TODO: remove these after converting archetypes
714 case KW_can_use_wand: 750 case KW_can_use_wand:
715 GET_FLAG (this, FLAG_USE_RANGE); 751 GET_FLAG (this, FLAG_USE_RANGE);
716 break; 752 break;
717 753
718 /* These are all legacy - any new objects should use the move_ .. values */
719 case KW_flying:
720 {
721 if (f.get_sint32 ())
722 move_type |= MOVE_FLY_LOW;
723 else
724 move_type &= ~MOVE_FLY_LOW;
725 }
726 break;
727
728
729 case KW_identified: 754 case KW_identified:
730 GET_FLAG (this, FLAG_IDENTIFIED); 755 GET_FLAG (this, FLAG_IDENTIFIED);
731 //TODO: move to check_object or so 756 //TODO: move to check_object or so
732 if (QUERY_FLAG (this, FLAG_IDENTIFIED)) 757 if (this->flag [FLAG_IDENTIFIED])
733 CLEAR_FLAG (this, FLAG_KNOWN_MAGICAL); 758 this->clr_flag (FLAG_KNOWN_MAGICAL);
734 759
735 break;
736
737 case KW_wiz:
738 GET_FLAG (this, FLAG_WIZ);
739 //TODO: move to check_object
740 if (QUERY_FLAG (this, FLAG_WIZ))
741 {
742 SET_FLAG (this, FLAG_WAS_WIZ);
743 SET_FLAG (this, FLAG_WIZPASS);
744 SET_FLAG (this, FLAG_WIZCAST);
745 }
746 else
747 {
748 CLEAR_FLAG (this, FLAG_WIZPASS);
749 CLEAR_FLAG (this, FLAG_WIZCAST);
750 }
751 break; 760 break;
752 761
753 case KW_friendly: 762 case KW_friendly:
754 if (f.get_sint32 ()) 763 if (f.get_bool ())
755 if (type != PLAYER) 764 if (type != PLAYER)
756 add_friendly_object (this); 765 add_friendly_object (this);
757 766
758 break; 767 break;
759 768
… …
772 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break; 781 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break;
773 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break; 782 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break;
774 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break; 783 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break;
775 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break; 784 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break;
776 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break; 785 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break;
786 case KW_player_sold: GET_FLAG (this, FLAG_PLAYER_SOLD); break;
777 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break; 787 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break;
778 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break; 788 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break;
779 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break; 789 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break;
780 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break; 790 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break;
781 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break; 791 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break;
782 case KW_hitback: GET_FLAG (this, FLAG_HITBACK); break; 792 case KW_hitback: GET_FLAG (this, FLAG_HITBACK); break;
783 case KW_startequip: GET_FLAG (this, FLAG_STARTEQUIP); break; 793 case KW_startequip: GET_FLAG (this, FLAG_STARTEQUIP); break;
784 case KW_blocksview: GET_FLAG (this, FLAG_BLOCKSVIEW); break; 794 case KW_blocksview: GET_FLAG (this, FLAG_BLOCKSVIEW); break;
795 case KW_is_transparent_floor: GET_FLAG (this, FLAG_IS_TRANSPARENT_FLOOR); break;
785 case KW_undead: GET_FLAG (this, FLAG_UNDEAD); break; 796 case KW_undead: GET_FLAG (this, FLAG_UNDEAD); break;
786 case KW_scared: GET_FLAG (this, FLAG_SCARED); break; 797 case KW_scared: GET_FLAG (this, FLAG_SCARED); break;
787 case KW_unaggressive: GET_FLAG (this, FLAG_UNAGGRESSIVE); break; 798 case KW_unaggressive: GET_FLAG (this, FLAG_UNAGGRESSIVE); break;
788 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break; 799 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break;
789 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break; 800 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break;
790 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break; 801 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break;
791 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break; 802 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break;
792 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break; 803 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break;
793 case KW_was_wiz: GET_FLAG (this, FLAG_WAS_WIZ); break;
794 case KW_no_fix_player: GET_FLAG (this, FLAG_NO_FIX_PLAYER); break;
795 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break; 804 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break;
796 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break; 805 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break;
797 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break; 806 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break;
798 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break; 807 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break;
799 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break; 808 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break;
… …
841 case KW_no_steal: GET_FLAG (this, FLAG_NO_STEAL); break; 850 case KW_no_steal: GET_FLAG (this, FLAG_NO_STEAL); break;
842 case KW_one_hit: GET_FLAG (this, FLAG_ONE_HIT); break; 851 case KW_one_hit: GET_FLAG (this, FLAG_ONE_HIT); break;
843 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break; 852 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break;
844 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break; 853 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break;
845 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break; 854 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break;
855 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break;
856 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break;
857 case KW_random_speed: GET_FLAG (this, FLAG_RANDOM_SPEED); break;
858 case KW_is_quad: GET_FLAG (this, FLAG_IS_QUAD); break;
846 859
847 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break; 860 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break;
848 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break; 861 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break;
849 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break; 862 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break;
850 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break; 863 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break;
… …
880 case KW_anim_speed: f.get (anim_speed); break; 893 case KW_anim_speed: f.get (anim_speed); break;
881 case KW_container: f.get (weight_limit); break; 894 case KW_container: f.get (weight_limit); break;
882 case KW_will_apply: f.get (will_apply); break; 895 case KW_will_apply: f.get (will_apply); break;
883 case KW_attack_movement: f.get (attack_movement); break; 896 case KW_attack_movement: f.get (attack_movement); break;
884 case KW_move_state: f.get (move_status); break; 897 case KW_move_state: f.get (move_status); break;
885 case KW_expmul: f.get (expmul); break; 898 //case KW_expmul: f.get (expmul); break;//D declared const for the time being
886 case KW_glow_radius: f.get (glow_radius); break; 899 case KW_glow_radius: f.get (glow_radius); break;
887 case KW_weapontype: f.get (weapontype); break; 900 case KW_weapontype: f.get (weapontype); break;
888 case KW_tooltype: f.get (tooltype); break;
889 case KW_casting_time: f.get (casting_time); break; 901 case KW_casting_time: f.get (casting_time); break;
902
903 // elevation is deprecated
890 case KW_elevation: f.get (elevation); break; 904 case KW_elevation: break;
905
891 case KW_smoothlevel: f.get (smoothlevel); break; 906 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break;
892 case KW_client_type: f.get (client_type); break; 907 case KW_client_type: f.get (client_type); break;
893 case KW_duration: f.get (duration); break; 908 case KW_duration: f.get (duration); break;
894 case KW_range: f.get (range); break; 909 case KW_range: f.get (range); break;
895 case KW_range_modifier: f.get (range_modifier); break; 910 case KW_range_modifier: f.get (range_modifier); break;
896 case KW_dam_modifier: f.get (dam_modifier); break; 911 case KW_dam_modifier: f.get (dam_modifier); break;
897 case KW_duration_modifier: f.get (duration_modifier); break; 912 case KW_duration_modifier: f.get (duration_modifier); break;
898 913
899 //TODO: mechanism to ensure that KW_xxx is consecutive needed from include/preprocess 914 //TODO: mechanism to ensure that KW_xxx is consecutive needed from include/preprocess
900 //TODO: parse from other include files 915 //TODO: parse from other include files
901 case KW_body_range: f.get (body_info[0]); break; 916 case KW_body_range: slot[body_range] .info = f.get_sint32 (); break;
902 case KW_body_arm: f.get (body_info[1]); break; 917 case KW_body_shield: slot[body_shield] .info = f.get_sint32 (); break;
903 case KW_body_torso: f.get (body_info[2]); break; 918 case KW_body_combat: slot[body_combat] .info = f.get_sint32 (); break;
904 case KW_body_head: f.get (body_info[3]); break; 919 case KW_body_arm: slot[body_arm] .info = f.get_sint32 (); break;
905 case KW_body_neck: f.get (body_info[4]); break; 920 case KW_body_torso: slot[body_torso] .info = f.get_sint32 (); break;
906 case KW_body_skill: f.get (body_info[5]); break; 921 case KW_body_head: slot[body_head] .info = f.get_sint32 (); break;
907 case KW_body_finger: f.get (body_info[6]); break; 922 case KW_body_neck: slot[body_neck] .info = f.get_sint32 (); break;
908 case KW_body_shoulder: f.get (body_info[7]); break; 923 case KW_body_skill: slot[body_skill] .info = f.get_sint32 (); break;
909 case KW_body_foot: f.get (body_info[8]); break; 924 case KW_body_finger: slot[body_finger] .info = f.get_sint32 (); break;
910 case KW_body_hand: f.get (body_info[9]); break; 925 case KW_body_shoulder: slot[body_shoulder].info = f.get_sint32 (); break;
911 case KW_body_wrist: f.get (body_info[10]); break; 926 case KW_body_foot: slot[body_foot] .info = f.get_sint32 (); break;
912 case KW_body_waist: f.get (body_info[11]); break; 927 case KW_body_hand: slot[body_hand] .info = f.get_sint32 (); break;
928 case KW_body_wrist: slot[body_wrist] .info = f.get_sint32 (); break;
929 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break;
913 case KW_can_apply: 930 case KW_can_apply:
914 break; 931 break;
915 932
916 case KW_connected: 933 case KW_connected:
917 add_button_link (this, map, f.get_sint32 ()); 934 {
935 shstr connected;
936
937 f.get (connected);
938 add_link (map, connected);
939 }
918 break; 940 break;
919 941
920 case KW_randomitems: 942 case KW_randomitems:
921 randomitems = find_treasurelist (f.get_str ()); 943 if (f.has_value ())
944 {
945 randomitems =
946 loading_arch
947 ? treasurelist::get (f.get_str ())
948 : treasurelist::find (f.get_str ());
949
922 //if (!randomitems) 950 if (!randomitems)
951 {
923 // LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ()); 952 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ());
953 randomitems = treasurelist::get (shstr_none); // avoid crashes
954 }
955 }
956 else
957 randomitems = 0;
924 break; 958 break;
925 959
926 case KW_msg: 960 case KW_msg:
927 f.get_ml (KW_endmsg, msg); 961 f.get_ml (KW_endmsg, msg);
928 //TODO: allow longer messages
929 if (strlen (msg) >= HUGE_BUF)
930 {
931 LOG (llevDebug, "\tError message length >= %d: %d\n>%.80s<\n", HUGE_BUF, strlen (msg), &msg);
932 msg = "ERROR, please report: string too long, winged.\n";
933 }
934 break; 962 break;
935 963
936 case KW_lore: 964 case KW_lore:
937 f.get_ml (KW_endlore, lore); 965 f.get_ml (KW_endlore, lore);
938 //TODO: allow longer messages
939 /* Just print a warning so we can be reasonably safe
940 * about not overflowing the buffer.
941 */
942 if (strlen (lore) > (HUGE_BUF / 2))
943 LOG (llevDebug, "\tWarning lore length > %d (max allowed=%d): %d\n>%.80s<\n",
944 HUGE_BUF / 2, HUGE_BUF, strlen (lore), &lore);
945 break; 966 break;
946 967
947 case KW_editable: 968 case KW_editable:
948 case KW_editor_folder: 969 case KW_editor_folder:
949 break; 970 break;
950 971
951 case KW_end: 972 case KW_end:
952 check_loaded_object (this);
953
954 if (!arch_init) 973 if (!loading_arch)
955 instantiate (); 974 instantiate ();
956 975
957 f.next (); 976 f.next ();
958 return true; 977 return true;
959 978
960 case KW_ERROR: 979 case KW_ERROR:
961 set_ob_key_value (this, f.kw_str, f.value, true); 980 // we do not even try to find old values, duplicate keys stay duplicate
962 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D 981 // the list gets reversed after loading
982 kv.add (shstr (f.kw_str), shstr (f.value));
963 break; 983 break;
964 984
965 default: 985 default:
966 if (!f.parse_error ("object", name)) 986 if (!f.parse_error ("object", name))
967 return false; 987 return false;
… …
979 999
980 archetype *arch = archetype::find (f.get_str ()); 1000 archetype *arch = archetype::find (f.get_str ());
981 1001
982 if (!arch) 1002 if (!arch)
983 { 1003 {
984 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ()); 1004 LOG (llevError, "object referring to nonexistent archetype '%s'.\n", f.get_str ());
985 arch = archetype::find ("earthwall"); 1005 arch = archetype::find (shstr_earthwall);
986 } 1006 }
987 1007
988 assert (arch); //D maybe use exception handling of sorts? 1008 assert (arch); //D maybe use exception handling of sorts?
989 1009
990 object *op = object::create (); 1010 f.next ();
991 1011
1012 object *op = arch->instance ();
992 op->map = map; 1013 op->map = map;
993 op->arch = arch;
994 arch->clone.copy_to (op);
995 // copy_to activates, this should be fixed properly 1014 // instance() activates, this should be fixed properly
996 op->deactivate (); 1015 op->deactivate ();
997 1016
998 if (!op->parse_kv (f)) 1017 if (!op->parse_kv (f))
999 { 1018 {
1000 delete op; 1019 op->destroy ();
1001 return 0; 1020 return 0;
1002 } 1021 }
1003 1022
1023 // the loader reverses the ordering of kv-pairs, so we reverse it again after loading
1024 // that greatly simplifies the loading code.
1025 op->kv.reverse ();
1026
1027 op->post_load_check ();
1004 return op; 1028 return op;
1005} 1029}
1006 1030
1007/* This takes a buffer, scans it for variables, and sets those variables 1031/* This takes a buffer, scans it for variables, and sets those variables
1008 * as appropriate in op. 1032 * as appropriate in op.
… …
1011 * override values and in c_wiz to mutate values. 1035 * override values and in c_wiz to mutate values.
1012 */ 1036 */
1013int 1037int
1014set_variable (object *op, char *buf) 1038set_variable (object *op, char *buf)
1015{ 1039{
1016 object_thawer f (buf, (AV *)0); 1040 object_thawer f (format ("%s\nend", buf), (AV *)0);
1017 1041
1018 f.kw = KW_arch; // special hack so that parse_kv skips
1019 return op->parse_kv (f); 1042 return op->parse_kv (f);
1020} 1043}
1021 1044
1022/* This returns a string of the integer movement type */
1023#if 0
1024// unused function
1025static char *
1026get_string_move_type (MoveType mt)
1027{
1028 static char retbuf[MAX_BUF], retbuf_all[MAX_BUF];
1029 int i, all_count = 0, count;
1030
1031 strcpy (retbuf, "");
1032 strcpy (retbuf_all, " all");
1033
1034 /* Quick check, and probably fairly common */
1035 if (mt == MOVE_ALL)
1036 return retbuf_all + 1;
1037 if (mt == 0)
1038 {
1039 strcpy (retbuf, "0");
1040 return retbuf;
1041 }
1042
1043 /* We basically slide the bits down. Why look at MOVE_ALL?
1044 * because we may want to return a string like 'all -swim',
1045 * and if we just looked at mt, we couldn't get that.
1046 */
1047 for (i = MOVE_ALL, count = 0; i != 0; i >>= 1, count++)
1048 {
1049 if (mt & (1 << count))
1050 {
1051 strcat (retbuf, " ");
1052 strcat (retbuf, move_name[count]);
1053 }
1054 else
1055 {
1056 strcat (retbuf_all, " -");
1057 strcat (retbuf_all, move_name[count]);
1058 all_count++;
1059 }
1060 }
1061 /* Basically, if there is a single negation, return it, eg
1062 * 'all -swim'. But more than that, just return the
1063 * enumerated values. It doesn't make sense to return
1064 * 'all -walk -fly_low' - it is shorter to return 'fly_high swim'
1065 */
1066 if (all_count <= 1)
1067 return retbuf_all + 1;
1068 else
1069 return retbuf + 1;
1070}
1071#endif
1072
1073// compare *op against *tmp and output differences 1045// compare *op against *arch and output differences
1074static void 1046static void
1075write_diff (object_freezer &f, object *op, object *tmp) 1047write_diff (object_freezer &f, object *op, object *arch)
1076{ 1048{
1077 static const keyword resist_save[NROFATTACKS] = { 1049 static const keyword resist_save[NROFATTACKS] = {
1078# define def(uc, lc, name, plus, change) KW_resist_ ## lc, 1050# define def(uc, lc, name, plus, change) KW_resist_ ## lc,
1079# include "attackinc.h" 1051# include "attackinc.h"
1080# undef def 1052# undef def
… …
1085 * the 15'th element of this array should match that name. 1057 * the 15'th element of this array should match that name.
1086 * If an entry is NULL, that is a flag not to loaded/saved. 1058 * If an entry is NULL, that is a flag not to loaded/saved.
1087 */ 1059 */
1088 static const keyword flag_names [NUM_FLAGS] = { 1060 static const keyword flag_names [NUM_FLAGS] = {
1089 KW_alive, 1061 KW_alive,
1090 KW_wiz,
1091 KW_NULL, 1062 KW_NULL,
1092 KW_NULL, 1063 KW_NULL,
1093 KW_was_wiz, 1064 KW_NULL,
1065 KW_NULL,
1094 KW_applied, 1066 KW_applied,
1095 KW_unpaid, 1067 KW_unpaid,
1096 KW_can_use_shield, 1068 KW_can_use_shield,
1097 KW_no_pick, 1069 KW_no_pick,
1098 KW_NULL, // walk_on 1070 KW_is_transparent_floor,
1071 /* 10 */
1099 KW_NULL, // no_pass 1072 KW_NULL, // no_pass
1100 /* 10 */
1101 KW_is_animated, 1073 KW_is_animated,
1102 KW_NULL, // slow_move 1074 KW_NULL, // slow_move
1103 KW_NULL, // flying 1075 KW_NULL, // flying
1104 KW_monster, 1076 KW_monster,
1105 KW_friendly, 1077 KW_friendly,
1106 KW_generator, 1078 KW_generator,
1107 KW_is_thrown, 1079 KW_is_thrown,
1108 KW_auto_apply, 1080 KW_auto_apply,
1109 KW_NULL, // was KW_treasure 1081 KW_treasure_env,
1082 /* 20 */
1110 KW_player_sold, 1083 KW_player_sold,
1111 /* 20 */
1112 KW_see_invisible, 1084 KW_see_invisible,
1113 KW_can_roll, 1085 KW_can_roll,
1114 KW_overlay_floor, 1086 KW_overlay_floor,
1115 KW_is_turnable, 1087 KW_is_turnable,
1116 KW_NULL, // walk_off 1088 KW_NULL, // walk_off
1117 KW_NULL, // fly_on 1089 KW_NULL, // fly_on
1118 KW_NULL, // fly_off 1090 KW_NULL, // fly_off
1119 KW_is_used_up, 1091 KW_is_used_up,
1120 KW_identified, 1092 KW_identified,
1093 /* 30 */
1121 KW_reflecting, 1094 KW_reflecting,
1122 /* 30 */
1123 KW_changing, 1095 KW_changing,
1124 KW_splitting, 1096 KW_splitting,
1125 KW_hitback, 1097 KW_hitback,
1126 KW_startequip, 1098 KW_startequip,
1127 KW_blocksview, 1099 KW_blocksview,
1128 KW_undead, 1100 KW_undead,
1129 KW_scared, 1101 KW_scared,
1130 KW_unaggressive, 1102 KW_unaggressive,
1131 KW_reflect_missile, 1103 KW_reflect_missile,
1104 /* 40 */
1132 KW_reflect_spell, 1105 KW_reflect_spell,
1133 /* 40 */
1134 KW_no_magic, 1106 KW_no_magic,
1135 KW_no_fix_player, 1107 KW_NULL,
1136 KW_is_lightable, 1108 KW_is_lightable,
1137 KW_tear_down, 1109 KW_tear_down,
1138 KW_run_away, 1110 KW_run_away,
1139 KW_NULL, // pass_thru 1111 KW_NULL, // pass_thru
1140 KW_NULL, // an_pass_thru 1112 KW_NULL, // an_pass_thru
1141 KW_pick_up, 1113 KW_pick_up,
1142 KW_unique, 1114 KW_unique,
1115 /* 50 */
1143 KW_no_drop, 1116 KW_no_drop,
1144 /* 50 */
1145 KW_NULL, // wizcast 1117 KW_NULL, // wizcast
1146 KW_can_cast_spell, 1118 KW_can_cast_spell,
1147 KW_can_use_scroll, 1119 KW_can_use_scroll,
1148 KW_can_use_range, 1120 KW_can_use_range,
1149 KW_can_use_bow, 1121 KW_can_use_bow,
1150 KW_can_use_armour, 1122 KW_can_use_armour,
1151 KW_can_use_weapon, 1123 KW_can_use_weapon,
1152 KW_can_use_ring, 1124 KW_can_use_ring,
1153 KW_has_ready_range, 1125 KW_has_ready_range,
1126 /* 60 */
1154 KW_has_ready_bow, 1127 KW_has_ready_bow,
1155 /* 60 */
1156 KW_xrays, 1128 KW_xrays,
1157 KW_NULL, 1129 KW_NULL,
1158 KW_is_floor, 1130 KW_is_floor,
1159 KW_lifesave, 1131 KW_lifesave,
1160 KW_no_strength, 1132 KW_no_strength,
1161 KW_sleep, 1133 KW_sleep,
1162 KW_stand_still, 1134 KW_stand_still,
1163 KW_random_move, 1135 KW_random_move,
1164 KW_only_attack, 1136 KW_only_attack,
1137 /* 70 */
1165 KW_confused, 1138 KW_confused,
1166 /* 70 */
1167 KW_stealth, 1139 KW_stealth,
1168 KW_NULL, 1140 KW_NULL,
1169 KW_NULL, 1141 KW_NULL,
1170 KW_cursed, 1142 KW_cursed,
1171 KW_damned, 1143 KW_damned,
1172 KW_see_anywhere, 1144 KW_see_anywhere,
1173 KW_known_magical, 1145 KW_known_magical,
1174 KW_known_cursed, 1146 KW_known_cursed,
1175 KW_can_use_skill, 1147 KW_can_use_skill,
1148 /* 80 */
1176 KW_been_applied, 1149 KW_been_applied,
1177 /* 80 */
1178 KW_has_ready_scroll, 1150 KW_has_ready_scroll,
1179 KW_can_use_rod, 1151 KW_can_use_rod,
1180 KW_NULL, 1152 KW_precious,
1181 KW_can_use_horn, 1153 KW_can_use_horn,
1182 KW_make_invisible, 1154 KW_make_invisible,
1183 KW_inv_locked, 1155 KW_inv_locked,
1184 KW_is_wooded, 1156 KW_is_wooded,
1185 KW_is_hilly, 1157 KW_is_hilly,
1186 KW_has_ready_skill, 1158 KW_has_ready_skill,
1159 /* 90 */
1187 KW_has_ready_weapon, 1160 KW_has_ready_weapon,
1188 /* 90 */
1189 KW_no_skill_ident, 1161 KW_no_skill_ident,
1190 KW_is_blind, 1162 KW_is_blind,
1191 KW_can_see_in_dark, 1163 KW_can_see_in_dark,
1192 KW_is_cauldron, 1164 KW_is_cauldron,
1193 KW_NULL, 1165 KW_NULL,
1194 KW_no_steal, 1166 KW_no_steal,
1195 KW_one_hit, 1167 KW_one_hit,
1196 KW_NULL, 1168 KW_NULL,
1197 KW_berserk, 1169 KW_berserk,
1170 /* 100 */
1198 KW_neutral, 1171 KW_neutral,
1199 /* 100 */
1200 KW_no_attack, 1172 KW_no_attack,
1201 KW_no_damage, 1173 KW_no_damage,
1202 KW_obj_original, 1174 KW_obj_original,
1203 KW_NULL, 1175 KW_random_speed,
1204 KW_activate_on_push, 1176 KW_activate_on_push,
1205 KW_activate_on_release, 1177 KW_activate_on_release,
1206 KW_is_water, 1178 KW_is_water,
1207 KW_use_content_on_gen, 1179 KW_use_content_on_gen,
1208 KW_NULL, 1180 KW_NULL,
1181 /* 110 */
1209 KW_is_buildable, 1182 KW_is_buildable,
1210 /* 110 */
1211 KW_destroy_on_death, 1183 KW_destroy_on_death,
1212 KW_NULL, 1184 KW_NULL,
1213 }; 1185 };
1214 1186
1215 int i; 1187 // obj_original is the only commonly differing flag between archetype
1188 // and object, so special-case it here to be able to skip the loop
1189 static const struct flagmask : object::flags_t
1190 {
1191 flagmask ()
1192 {
1193 for (int i = 0; i < NUM_FLAGS; i++)
1194 if (flag_names [i])
1195 set (i);
1196 }
1197 } flagmask;
1216 1198
1217 /* This saves the key/value lists. We do it first so that any 1199 /* This saves the key/value lists. We do it first so that any
1218 * keys that match field names will be overwritten by the loader. 1200 * keys that match field names will be overwritten by the loader.
1219 */ 1201 */
1220 for (key_value *my_field = op->key_values; my_field; my_field = my_field->next) 1202 for (key_value *kv = op->kv.first; kv; kv = kv->next)
1221 { 1203 if (arch->kv.empty () || arch->kv [kv->key] != kv->value)
1222 /* Find the field in the opposing member. */ 1204 f.put (kv->key, kv->value);
1223 key_value *arch_field = get_ob_key_link (tmp, my_field->key);
1224 1205
1225 /* If there's no partnering field, or it's got a different value, save our field. */ 1206 if (op->uuid)
1226 if (!arch_field || my_field->value != arch_field->value)
1227 f.put (my_field->key, my_field->value);
1228 } 1207 {
1208 // highly optimised - this is often 25% of all data written
1209 char *cur = f.force (sizeof ("uuid ") + UUID::MAX_LEN + 1);
1210 char *ptr = cur;
1229 1211
1230 /* We don't need to worry about the arch's extra fields - they 1212 memcpy (ptr, "uuid ", sizeof ("uuid ") - 1);
1231 * will get taken care of the copy_to method. 1213 ptr += sizeof ("uuid ") - 1;
1232 */ 1214 ptr = op->uuid.append (ptr);
1215 *ptr++ = '\n';
1233 1216
1234 { 1217 f.alloc (ptr - cur);
1235 char uids[64];
1236 snprintf (uids, sizeof (uids), "<1.%llx>", (unsigned long long)op->uuid.seq);
1237 f.put (KW_uuid, (const char *)uids);
1238 } 1218 }
1239 1219
1240#define CMP_OUT(v) if (op->v != tmp->v) f.put (KW_ ## v, op->v) 1220#define CMP_OUT(v) if (expect_false (op->v != arch->v)) f.put (KW (v), op->v)
1241#define CMP_OUT2(k,v) if (op->v != tmp->v) f.put (KW_ ## k, op->v) 1221#define CMP_OUT2(k,v) if (expect_false (op->v != arch->v)) f.put (KW (k), op->v)
1222
1223 CMP_OUT (x);
1224 CMP_OUT (y);
1225
1226 CMP_OUT (type);
1227 CMP_OUT (subtype);
1228 CMP_OUT (direction);
1242 1229
1243 CMP_OUT (name); 1230 CMP_OUT (name);
1244 CMP_OUT (name_pl); 1231 CMP_OUT (name_pl);
1245 CMP_OUT (custom_name); 1232 CMP_OUT (speed);
1233
1234 // speed_left is a major time-burner, and has good locality, so
1235 // we use a simple lookup-cache to avoid the very slow printf.
1236 if (op->speed_left != arch->speed_left)
1237 {
1238 static double last_speed_left = 0.;
1239 static char last_speed_left_str [256] = "sl 0\n";
1240 static int last_speed_left_len = sizeof ("sl 0\n") - 1;
1241
1242 if (last_speed_left != op->speed_left)
1243 {
1244 last_speed_left = op->speed_left;
1245 last_speed_left_len = sizeof ("sl ") - 1
1246 + sprintf (last_speed_left_str + sizeof ("sl ") - 1, "%.7g\n", last_speed_left);
1247 }
1248
1249 f.add (last_speed_left_str, last_speed_left_len);
1250 }
1251
1246 CMP_OUT (title); 1252 CMP_OUT (title);
1247 CMP_OUT (race); 1253 CMP_OUT (race);
1248 CMP_OUT (slaying); 1254 CMP_OUT (slaying);
1255 CMP_OUT (skill);
1249 1256
1250 if (op->msg != tmp->msg) 1257 CMP_OUT (tag);
1251 f.put (KW_msg, KW_endmsg, op->msg); 1258 CMP_OUT (custom_name);
1252 if (op->lore != tmp->lore) 1259
1253 f.put (KW_lore, KW_endlore, op->lore); 1260 if (object *owner = op->owner)
1261 if (const char *ref = owner->ref ())
1262 f.put (KW(owner), ref);
1263
1264 // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved
1254 1265
1255 CMP_OUT (other_arch); 1266 CMP_OUT (other_arch);
1256 CMP_OUT (face);
1257 1267
1268 if (op->msg != arch->msg ) f.put (KW(msg) , KW(endmsg) , op->msg );
1269 if (op->lore != arch->lore) f.put (KW(lore), KW(endlore), op->lore);
1270
1271 if (op->face != arch->face ) f.put (KW(face) , op->face ? &faces [op->face ] : 0);
1272 if (op->sound != arch->sound ) f.put (KW(sound) , op->sound ? &faces [op->sound ] : 0);
1273 if (op->sound_destroy != arch->sound_destroy) f.put (KW(sound_destroy), op->sound_destroy ? &faces [op->sound_destroy] : 0);
1274
1258 if (op->animation_id != tmp->animation_id) 1275 if (op->animation_id != arch->animation_id)
1259 if (op->animation_id) 1276 if (op->has_anim ())
1277 f.put (KW(animation), op->anim ().name);
1278 else
1260 { 1279 {
1261 f.put (KW_animation, animations[GET_ANIM_ID (op)].name); 1280 f.put (KW(animation));
1262 1281 op->flag [FLAG_ANIMATE] = false; // TODO: why force to false here?
1263 if (!QUERY_FLAG (op, FLAG_ANIMATE))
1264 f.put (KW_is_animated, (sint32) 0);
1265 } 1282 }
1266 else
1267 f.put (KW_animation, (const char *) 0);
1268 1283
1269 CMP_OUT2 (str, stats.Str); 1284 CMP_OUT2 (str, stats.Str);
1270 CMP_OUT2 (dex, stats.Dex); 1285 CMP_OUT2 (dex, stats.Dex);
1271 CMP_OUT2 (con, stats.Con); 1286 CMP_OUT2 (con, stats.Con);
1272 CMP_OUT2 (wis, stats.Wis); 1287 CMP_OUT2 (wis, stats.Wis);
… …
1281 CMP_OUT2 (grace, stats.grace); 1296 CMP_OUT2 (grace, stats.grace);
1282 CMP_OUT2 (maxgrace, stats.maxgrace); 1297 CMP_OUT2 (maxgrace, stats.maxgrace);
1283 CMP_OUT2 (exp, stats.exp); 1298 CMP_OUT2 (exp, stats.exp);
1284 1299
1285 CMP_OUT (perm_exp); 1300 CMP_OUT (perm_exp);
1286 CMP_OUT (expmul); 1301 //CMP_OUT (expmul);
1287 1302
1288 CMP_OUT2 (food, stats.food); 1303 CMP_OUT2 (food, stats.food);
1289 CMP_OUT2 (dam, stats.dam); 1304 CMP_OUT2 (dam, stats.dam);
1290 CMP_OUT2 (luck, stats.luck); 1305 CMP_OUT2 (luck, stats.luck);
1291 CMP_OUT2 (wc, stats.wc); 1306 CMP_OUT2 (wc, stats.wc);
1292 CMP_OUT2 (ac, stats.ac); 1307 CMP_OUT2 (ac, stats.ac);
1293 1308
1294 CMP_OUT (x);
1295 CMP_OUT (y);
1296 CMP_OUT (speed);
1297 CMP_OUT (speed_left);
1298 CMP_OUT2 (move_state, move_status); 1309 CMP_OUT2 (move_state, move_status);
1299 CMP_OUT (attack_movement); 1310 CMP_OUT (attack_movement);
1300 CMP_OUT (nrof); 1311 CMP_OUT (nrof);
1301 CMP_OUT (level); 1312 CMP_OUT (level);
1302 CMP_OUT (direction);
1303 CMP_OUT (type);
1304 CMP_OUT (subtype);
1305 CMP_OUT (attacktype); 1313 CMP_OUT (attacktype);
1306 1314
1315 // using memcmp here seems to be a loss - is gcc vectorising?
1307 for (i = 0; i < NROFATTACKS; i++) 1316 for (int i = 0; i < NROFATTACKS; i++)
1308 if (op->resist[i] != tmp->resist[i]) 1317 if (expect_false (op->resist[i] != arch->resist[i]))
1309 f.put (resist_save[i], op->resist[i]); 1318 f.put (resist_save[i], op->resist[i]);
1310 1319
1311 CMP_OUT (path_attuned); 1320 CMP_OUT (path_attuned);
1312 CMP_OUT (path_repelled); 1321 CMP_OUT (path_repelled);
1313 CMP_OUT (path_denied); 1322 CMP_OUT (path_denied);
1323
1314 CMP_OUT2 (material, materials);//TODO: nuke 1324 CMP_OUT2 (material, materials);//TODO: nuke
1315 CMP_OUT (materialname); 1325 if (op->material != arch->material)
1326 f.put (KW(materialname), op->material->name);
1327
1316 CMP_OUT (value); 1328 CMP_OUT (value);
1317 CMP_OUT (carrying); 1329 CMP_OUT (carrying);
1318 CMP_OUT (weight); 1330 CMP_OUT (weight);
1319 CMP_OUT (invisible); 1331 CMP_OUT (invisible);
1320 CMP_OUT (state); 1332 CMP_OUT (state);
… …
1323 CMP_OUT (last_sp); 1335 CMP_OUT (last_sp);
1324 CMP_OUT (last_grace); 1336 CMP_OUT (last_grace);
1325 CMP_OUT (last_eat); 1337 CMP_OUT (last_eat);
1326 CMP_OUT (glow_radius); 1338 CMP_OUT (glow_radius);
1327 1339
1328 if (QUERY_FLAG (op, FLAG_IS_LINKED) && (i = get_button_value (op))) 1340 if (op->flag [FLAG_IS_LINKED])
1341 if (auto (ol, op->find_link ()))
1329 f.put (KW_connected, i); 1342 f.put (KW(connected), ol->id);
1330 1343
1331 CMP_OUT (randomitems); 1344 CMP_OUT (randomitems);
1345
1332 CMP_OUT2 (container, weight_limit); 1346 CMP_OUT2 (container, weight_limit);
1333 1347
1334 CMP_OUT (run_away); 1348 CMP_OUT (run_away);
1335 CMP_OUT (pick_up); 1349 CMP_OUT (pick_up);
1336 CMP_OUT (will_apply); 1350 CMP_OUT (will_apply);
1337 CMP_OUT (smoothlevel); 1351 CMP_OUT (smoothlevel);
1338 CMP_OUT (weapontype); 1352 CMP_OUT (weapontype);
1339 CMP_OUT (tooltype);
1340 CMP_OUT (elevation);
1341 CMP_OUT (client_type); 1353 CMP_OUT (client_type);
1342 CMP_OUT (item_power); 1354 CMP_OUT (item_power);
1343 CMP_OUT (duration); 1355 CMP_OUT (duration);
1344 CMP_OUT (range); 1356 CMP_OUT (range);
1345 CMP_OUT (range_modifier); 1357 CMP_OUT (range_modifier);
… …
1353 CMP_OUT (move_on); 1365 CMP_OUT (move_on);
1354 CMP_OUT (move_off); 1366 CMP_OUT (move_off);
1355 CMP_OUT (move_slow); 1367 CMP_OUT (move_slow);
1356 CMP_OUT (move_slow_penalty); 1368 CMP_OUT (move_slow_penalty);
1357 1369
1358 if (op->flag != tmp->flag) 1370 object::flags_t diff = (op->flag ^ arch->flag) & flagmask;
1371
1372#if stdcpp // we need gcc, sorry
1373 if (diff [FLAG_OBJ_ORIGINAL])
1374 f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? CS(1) : CS(0));
1375
1376 diff.reset (FLAG_OBJ_ORIGINAL);
1377
1378 // quickly test whether any other flags differ
1379 if (expect_true (diff.any ()))
1359 for (i = 0; i <= NUM_FLAGS; i++) 1380 for (int i = 0; i < NUM_FLAGS; i++)
1360 if (flag_names [i] && op->flag [i] != tmp->flag [i]) 1381 if (expect_false (diff [i]))
1361 f.put (flag_names [i], op->flag [i] ? "1" : "0"); 1382 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1383#else
1384 // use sgi extensions
1385 for (int i = diff._Find_first (); i < diff.size (); i = diff._Find_next (i))
1386 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1387#endif
1362 1388
1363 /* Save body locations */ 1389 // save body locations. gcc's memcmp does an abysmal job when used
1364 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 1390 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
1365 if (op->body_info[i] != tmp->body_info[i]) 1391 if (expect_false (op->slot[i].info != arch->slot[i].info))
1366 f.put (body_locations[i].save_name, op->body_info[i]); 1392 f.put (body_locations[i].kw, op->slot[i].info);
1367} 1393}
1368 1394
1369/* 1395/*
1370 * Dumps all variables in an object to a file. 1396 * Dumps all variables in an object to a file.
1371 * If bit 0 of flag is set, unpaid objects will be saved. As of now, 1397 * If bit 0 of flag is set, unpaid objects will be saved. As of now,
1372 * the only place this is not set is when saving the player. 1398 * the only place this is not set is when saving the player.
1373 */ 1399 */
1374bool 1400bool
1375object::write (object_freezer &f) 1401object::write (object_freezer &f)
1376{ 1402{
1377 /* Even if the object does have an owner, it would seem that we should 1403 if (expect_false (is_arch ()))
1378 * still save it. 1404 {
1379 */ 1405 f.put (KW(object), arch->archname);
1380 if (owner) 1406 write_diff (f, this, archetype::empty);
1381 return true; 1407 }
1382 1408 else
1383 archetype *at = arch ? (archetype *)arch : empty_archetype; 1409 {
1384
1385 f.put (KW_arch, at->name); 1410 f.put (KW(arch), arch->archname);
1386 write_diff (f, this, &at->clone); 1411 write_diff (f, this, arch);
1412 }
1387 1413
1388 for (object *tmp = inv; tmp; tmp = tmp->below) 1414 for (object *tmp = inv; tmp; tmp = tmp->below)
1389 tmp->write (f); 1415 tmp->write (f);
1390 1416
1391 f.put (this); 1417 f.put (this);
1392 f.put (KW_end); 1418 f.put (KW(end));
1393 1419
1394 return true; 1420 return true;
1395} 1421}
1396 1422
1397///////////////////////////////////////////////////////////////////////////// 1423/////////////////////////////////////////////////////////////////////////////
1398 1424
1425// generic resource file load,
1426// currently supports: region, treasures, archetypes
1427bool
1399bool load_resource_file (const char *filename) 1428load_resource_file_ (const char *filename)
1400{ 1429{
1401 object_thawer f (filename); 1430 object_thawer f (filename);
1402 1431
1403 f.next ();
1404
1405 for (;;) 1432 for (;;)
1406 { 1433 {
1434 coroapi::cede_to_tick ();
1435
1407 switch (f.kw) 1436 switch (f.kw)
1408 { 1437 {
1409 case KW_region: 1438 case KW_region:
1410 if (!region::read (f)) 1439 if (!region::read (f))
1411 return false; 1440 return false;
1412 break; 1441 break;
1413 1442
1443 case KW_treasure:
1444 case KW_treasureone:
1445 if (!treasurelist::read (f))
1446 return false;
1447 break;
1448
1449 case KW_object:
1450 if (!archetype::read (f))
1451 return false;
1452 break;
1453
1414 case KW_EOF: 1454 case KW_EOF:
1415 return true; 1455 return true;
1416 1456
1417 default: 1457 default:
1418 if (!f.parse_error ("resource file")) 1458 if (!f.parse_error ("resource file"))
1419 return false; 1459 return false;
1460
1461 f.next ();
1462 break;
1420 } 1463 }
1421
1422 f.next ();
1423 } 1464 }
1424} 1465}
1425 1466

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines