ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/loader.C
(Generate patch)

Comparing deliantra/server/common/loader.C (file contents):
Revision 1.63 by root, Mon Mar 5 15:36:29 2007 UTC vs.
Revision 1.180 by root, Wed Nov 14 19:40:44 2018 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 *
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 17 *
18 * You should have received a copy of the Affero GNU General Public License
19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
21 *
22 * The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 23 */
24 24
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying
27 variable. */
28
29#include <global.h> 25#include <global.h>
30#include <loader.h>
31#include <sproto.h> 26#include <sproto.h>
32 27
33///////////////////////////////////////////////////////////////////////////// 28/////////////////////////////////////////////////////////////////////////////
29
30extern archetype *loading_arch;
31
32//+GPL
34 33
35/* This table is only necessary to convert objects that existed before the 34/* This table is only necessary to convert objects that existed before the
36 * spell object conversion to the new object. It was not practical 35 * spell object conversion to the new object. It was not practical
37 * to go through every mapping looking for every potion, rod, wand, etc 36 * to go through every mapping looking for every potion, rod, wand, etc
38 * that had a sp set and update to the new value. So this maps the 37 * that had a sp set and update to the new value. So this maps the
… …
168 "spell_magic_drain", /* 122 */ 167 "spell_magic_drain", /* 122 */
169 "spell_counterspell", /* 123 */ 168 "spell_counterspell", /* 123 */
170 "spell_disarm", /* 124 */ 169 "spell_disarm", /* 124 */
171 "spell_cure_confusion", /* 125 */ 170 "spell_cure_confusion", /* 125 */
172 "spell_restoration", /* 126 */ 171 "spell_restoration", /* 126 */
173 "was summon evil monster", /* 127 *//* Not implenented as nothing used it */ 172 "spell_summon_devil", /* 127 *//* Not implenented as nothing used it */
174 "spell_counterwall", /* 128 */ 173 "spell_counterwall", /* 128 */
175 "spell_cause_light_wounds", /* 129 */ 174 "spell_cause_light_wounds", /* 129 */
176 "spell_cause_medium_wounds", /* 130 */ 175 "spell_cause_medium_wounds", /* 130 */
177 "spell_cause_heavy_wounds", /* 131 */ 176 "spell_cause_heavy_wounds", /* 131 */
178 "spell_charm_monsters", /* 132 */ 177 "spell_charm_monsters", /* 132 */
… …
250 "spell_cause_rabies", /* 204 */ 249 "spell_cause_rabies", /* 204 */
251 "spell_glyph", /* 205 */ 250 "spell_glyph", /* 205 */
252 NULL 251 NULL
253}; 252};
254 253
255extern int arch_init;
256
257/* This function checks the object after it has been loaded (when we 254/* This function checks the object after it has been loaded (when we
258 * get the 'end' in the input stream). This function can be used to 255 * get the 'end' in the input stream). This function can be used to
259 * deal with legacy objects where fields may have changed. It can also be used 256 * deal with legacy objects where fields may have changed. It can also be used
260 * to check for objects to make sure there are no common errors. 257 * to check for objects to make sure there are no common errors.
261 */ 258 */
262static void 259void
263check_loaded_object (object *op) 260object::post_load_check ()
264{ 261{
262 if (type >= NUM_TYPES)
263 {
264 LOG (llevError, "ITEMBUG: %s: type out of range, resetting to 0.\n", debug_desc ());
265 type = 0;
266 }
267
268 switch (type)
269 {
270 case RANGED:
271 case BOW:
272 case WAND:
273 case ROD:
274 case HORN:
275 if (slot [body_range].info != -1)
276 {
277 LOG (llevError, "ITEMBUG: %s: body_range %d != -1\n", debug_desc (), slot [body_range].info);
278 slot [body_range].info = -1;
279 }
280 break;
281
282 case WEAPON:
283 if (slot [body_combat].info != -1)
284 {
285 LOG (llevError, "ITEMBUG: %s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info);
286 slot [body_combat].info = -1;
287 }
288 break;
289
290 case SHIELD:
291 if (slot [body_shield].info != -1)
292 {
293 LOG (llevError, "ITEMBUG: %s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info);
294 slot [body_shield].info = -1;
295 }
296 break;
297
298 case CONTAINER:
299 if (nrof)
300 {
301 LOG (llevError, "ITEMBUG: %s: stackable container\n", debug_desc ());
302 nrof = 0;
303 }
304 break;
305
306 case PLAYER:
307 if (slot [body_shield].info != 1)
308 {
309 LOG (llevError, "ITEMBUG: %s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info);
310 slot [body_shield].info = 1;
311 }
312
313 if (slot [body_combat].info != 1)
314 {
315 LOG (llevError, "ITEMBUG: %s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info);
316 slot [body_combat].info = 1;
317 }
318
319 if (slot [body_range].info != 1)
320 {
321 LOG (llevError, "ITEMBUG: %s: body_range %d != 1\n", debug_desc (), slot [body_range].info);
322 slot [body_range].info = 1;
323 }
324 break;
325 }
326
265 /* We do some specialised handling to handle legacy cases of name_pl. 327 /* We do some specialised handling to handle legacy cases of name_pl.
266 * If the object doesn't have a name_pl, we just use the object name - 328 * If the object doesn't have a name_pl, we just use the object name -
267 * this isn't perfect (things won't be properly pluralised), but works to 329 * this isn't perfect (things won't be properly pluralised), but works to
268 * that degree (5 heart is still quite understandable). But the case we 330 * that degree (5 heart is still quite understandable). But the case we
269 * also have to catch is if this object is not using the normal name for 331 * also have to catch is if this object is not using the normal name for
270 * the object. In that case, we also want to use the loaded name. 332 * the object. In that case, we also want to use the loaded name.
271 * Otherwise, what happens is that the the plural name will lose 333 * Otherwise, what happens is that the the plural name will lose
272 * information (appear as just 'hearts' and not 'goblins heart') 334 * information (appear as just 'hearts' and not 'goblins heart')
273 */ 335 */
274 if (op->arch && op->name != op->arch->clone.name && op->name_pl == op->arch->clone.name_pl) 336 if (arch && name != arch->object::name && name_pl == arch->object::name_pl)
275 op->name_pl = 0; 337 name_pl = 0;
276 338
277 if (!op->name_pl) 339 if (!name_pl)
278 op->name_pl = op->name; 340 name_pl = name;
279 341
280 /* objects now have a materialname. try to patch it in */ 342 /* objects now have a materialname. try to patch it in */
281 if (!(op->is_weapon () && op->level > 0)) 343 if (material == MATERIAL_NULL && !(is_weapon () && level > 0))
344 select_material (this, map ? map->difficulty : 5);
345
346 if (speed < 0.)
282 { 347 {
283 if (op->map != NULL) 348 flag [FLAG_RANDOM_SPEED] = true;
284 set_materialname (op, op->map->difficulty, NULL); 349 speed = -speed;
285 else 350 // speed_left will be randomised in instantiate () and copy_to ()
286 set_materialname (op, 5, NULL);
287 } 351 }
288 352
289 /* only do these when program is first run - a bit 353 /* only do these when program is first run - a bit
290 * excessive to do this at every run - most of this is 354 * excessive to do this at every run - most of this is
291 * really just to catch any errors - program will still run, but 355 * really just to catch any errors - program will still run, but
292 * not in the ideal fashion. 356 * not in the ideal fashion.
293 */ 357 */
294 if ((op->type == WEAPON || op->type == BOW) && arch_init) 358 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND))
295 { 359 {
296 if (!op->skill) 360 if (!skill)
297 LOG (llevError, "Weapon %s lacks a skill.\n", op->debug_desc ()); 361 LOG (llevError, "ITEMBUG: weapon %s lacks a skill.\n", debug_desc ());
298 else if ((!strcmp (op->skill, "one handed weapons") && op->body_info[1] != -1) || 362 else if ((skill == shstr_one_handed_weapons && slot[body_arm].info != -1) ||
299 (!strcmp (op->skill, "two handed weapons") && op->body_info[1] != -2)) 363 (skill == shstr_two_handed_weapons && slot[body_arm].info != -2))
300 LOG (llevError, "weapon %s arm usage does not match skill: %d, %s\n", op->debug_desc (), op->body_info[1], &op->skill); 364 LOG (llevError, "ITEMBUG: weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill);
301 } 365 }
302 366
303 /* We changed last_heal to gen_sp_armour, which is what it 367 /* We changed last_heal to gen_sp_armour, which is what it
304 * really does for many objects. Need to catch any in maps 368 * really does for many objects. Need to catch any in maps
305 * that may have an old value. 369 * that may have an old value.
306 */ 370 */
307 if (op->type == WEAPON 371 if (type == WEAPON
308 || op->type == ARMOUR || op->type == HELMET 372 || type == ARMOUR || type == HELMET
309 || op->type == SHIELD || op->type == RING 373 || type == SHIELD || type == RING
310 || op->type == BOOTS || op->type == GLOVES 374 || type == BOOTS || type == GLOVES
311 || op->type == AMULET || op->type == GIRDLE 375 || type == AMULET || type == GIRDLE
312 || op->type == BRACERS || op->type == CLOAK) 376 || type == BRACERS || type == CLOAK)
313 { 377 {
314 if (op->last_heal) 378 if (last_heal)
315 { 379 {
316 LOG (llevDebug, "Object %s still has last_heal set, not gen_sp_armour\n", op->debug_desc ()); 380 LOG (llevError, "ITEMBUG: object %s still has last_heal set, not gen_sp_armour\n", debug_desc ());
317 op->gen_sp_armour = op->last_heal; 381 gen_sp_armour = last_heal;
318 op->last_heal = 0; 382 last_heal = 0;
319 } 383 }
320 384
321 int ip = calc_item_power (op, 0); 385 int ip = calc_item_power (this, 0);
322 386
323 /* Legacy objects from before item power was in the game */ 387 /* Legacy objects from before item power was in the game */
324 if (!op->item_power && ip) 388 if (!item_power && ip)
325 { 389 {
326 if (ip > 3) 390 if (ip > 3)
327 LOG (llevDebug, "Object %s had no item power, using %d\n", op->debug_desc (), ip); 391 LOG (llevDebug, "ITEMBUG: Object %s had no item power, using %d\n", debug_desc (), ip);
328 392
329 op->item_power = ip; 393 item_power = ip;
330 } 394 }
331 395
332 /* Check for possibly bogus values. Has to meet both these criteria - 396 /* Check for possibly bogus values. Has to meet both these criteria -
333 * something that has item_power 1 is probably just fine if our calculated 397 * something that has item_power 1 is probably just fine if our calculated
334 * value is 1 or 2 - these values are small enough that hard to be precise. 398 * value is 1 or 2 - these values are small enough that hard to be precise.
335 * similarly, it item_power is 0, the first check will always pass, 399 * similarly, it item_power is 0, the first check will always pass,
336 * but not the second one. 400 * but not the second one.
337 */ 401 */
402#if 0 //TODO
338 if (ip > 2 * op->item_power && ip > (op->item_power + 3)) 403 if (ip > 2 * item_power && ip > (item_power + 3))
339 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", op->debug_desc (), ip, op->item_power); 404 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power);
405#endif
340 } 406 }
341 407
342 /* Old spellcasting object - need to load in the appropiate object */ 408 /* old style spellcasting object (pretty common) - need to load in the appropriate object */
343 if ((op->type == ROD || op->type == WAND || op->type == SCROLL || op->type == HORN || op->type == FIREWALL || 409 /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */
410 if ((type == ROD
411 || type == WAND
412 || type == SCROLL
413 || type == HORN
414 || type == FIREWALL
344 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */ 415 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */
345 ((op->type == POTION || op->type == ALTAR) && op->stats.sp)) && !op->inv && !arch_init) 416 || ((type == POTION || type == ALTAR) && stats.sp)) // watchout: sp = 0 is still magic bullet.
417 && !inv
418 && !loading_arch
419 && stats.sp) // watchout: old magic bullet stuff directly on the map is going to break here!
420 // TODO: at least one watchout-comments is redundant - investigate/remove
346 { 421 {
422 // TODO: fix firewall object on map
347 /* Fireall is bizarre in that spell type was stored in dam. Rest are 'normal' 423 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal'
348 * in that spell was stored in sp. 424 * in that spell was stored in sp.
349 */ 425 */
426 //LOG (llevError, "old spellcasting object found: %s", debug_desc ());
350 object *tmp = get_archetype (spell_mapping[op->type == FIREWALL ? op->stats.dam : op->stats.sp]); 427 object *tmp = archetype::get (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]);
351 insert_ob_in_ob (tmp, op); 428 insert_ob_in_ob (tmp, this);
352 op->randomitems = NULL; /* So another spell isn't created for this object */ 429 randomitems = 0;
353 } 430 }
354 431
355 /* spellbooks & runes use slaying. But not to arch name, but to spell name */ 432 /* spellbooks & runes use slaying. But not to arch name, but to spell name */
356 if ((op->type == SPELLBOOK || op->type == RUNE) && op->slaying && !op->inv && !arch_init) 433 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch)
357 { 434 {
435 LOG (llevError, "ITEMBUG: spellbook/rune found without inv but slaying: %s", debug_desc ());
358 object *tmp = get_archetype_by_object_name (op->slaying); 436 object *tmp = get_archetype_by_object_name (slaying);
359 insert_ob_in_ob (tmp, op); 437 insert_ob_in_ob (tmp, this);
360 op->randomitems = NULL; /* So another spell isn't created for this object */ 438 randomitems = 0; /* So another spell isn't created for this object */
361 /* without this, value is all screwed up */ 439 /* without this, value is all screwed up */
362 op->value = op->arch->clone.value * op->inv->value; 440 value = arch->value * inv->value;
363 }
364
365 if (QUERY_FLAG (op, FLAG_MONSTER))
366 { 441 }
442
443 if (this->flag [FLAG_MONSTER])
444 {
367 if (op->stats.hp > op->stats.maxhp) 445 if (stats.hp > stats.maxhp)
368 { 446 {
369 LOG (llevDebug, "Monster %s has hp set higher than maxhp (%d>%d)\n", op->debug_desc (), op->stats.hp, op->stats.maxhp); 447 LOG (llevInfo, "ITEMBUG: monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp);
370 op->stats.maxhp = op->stats.hp; 448 stats.maxhp = stats.hp;
371 } 449 }
372 450
373 /* The archs just need to be updated for this */ 451 /* The archs just need to be updated for this */
374 if (op->move_type == 0) 452 if (move_type == 0)
375 op->move_type = MOVE_WALK; 453 move_type = MOVE_WALK;
376 }
377
378 if ((QUERY_FLAG (op, FLAG_GENERATOR) && QUERY_FLAG (op, FLAG_CONTENT_ON_GEN)) || op->type == CREATOR || op->type == CONVERTER)
379 { 454 }
455
456 if ((this->flag [FLAG_GENERATOR] && this->flag [FLAG_CONTENT_ON_GEN]) || type == CREATOR || type == CONVERTER)
380 /* Object will duplicate it's content as part of the 457 /* Object will duplicate it's content as part of the
381 * generation process. To do this, we must flag inventory 458 * generation process. To do this, we must flag inventory
382 * so it remains unevaluated concerning the randomitems and 459 * so it remains unevaluated concerning the randomitems and
383 * the living (a demonlord shouldn't cast from inside generator!) 460 * the living (a demonlord shouldn't cast from inside generator!)
384 */ 461 */
462 /* ??? this *should* be done elsewhere, e.g. after map loading etc. */
385 flag_inv (op, FLAG_IS_A_TEMPLATE); 463 flag_inv (this, FLAG_IS_A_TEMPLATE);
386 }
387 464
388 /* Handle player movers. We use move_type for player movers 465 /* Handle player movers. We use move_type for player movers
389 * because they operate on their own time (move_on 466 * because they operate on their own time (move_on
390 * would potentially cause them to be triggered when someone steps 467 * would potentially cause them to be triggered when someone steps
391 * on them). If move_type is set, presume person knows what they 468 * on them). If move_type is set, presume person knows what they
392 * are doing, otherwise, set move_type based on maxhp value. 469 * are doing, otherwise, set move_type based on maxhp value.
393 */ 470 */
394 if (op->type == PLAYERMOVER) 471 if (type == PLAYERMOVER)
395 { 472 {
396 if (!op->move_type) 473 if (!move_type)
397 { 474 {
398 if (op->stats.maxhp) 475 if (stats.maxhp)
399 { 476 {
400 op->move_type = MOVE_ALL; 477 move_type = MOVE_ALL;
401 op->stats.maxhp = 0; 478 stats.maxhp = 0;
402 } 479 }
403 else 480 else
404 op->move_type = MOVE_WALK; 481 move_type = MOVE_WALK;
405 } 482 }
406 } 483 }
407 484
485 // if the object has an animation, try to provide a default face
486 if (has_anim ())
487 {
488 if (anim_speed)
489 // if this item is time-animated, force the last frame
490 animate_object (this, 0);
491 else if (flag [FLAG_MONSTER])
492 // if it is a monster, set appropriate facing
493 animate_object (this, direction);
494 }
408} 495}
409 496
410static void 497static void
411set_move (MoveType &mt, const char *str) 498set_move (MoveType &mt, object_thawer &f)
412{ 499{
413 static const struct flagstr { 500 static const struct flagstr {
414 char *name; 501 const char *name;
415 MoveType flags; 502 MoveType flags;
416 } move_flags[] = { 503 } move_flags[] = {
417 { "walk" , MOVE_WALK }, 504 { "walk" , MOVE_WALK },
418 { "flying" , MOVE_FLY_LOW | MOVE_FLY_HIGH }, 505 { "flying" , MOVE_FLY_LOW | MOVE_FLY_HIGH },
419 { "fly_low" , MOVE_FLY_LOW }, 506 { "fly_low" , MOVE_FLY_LOW },
420 { "fly_high", MOVE_FLY_HIGH }, 507 { "fly_high", MOVE_FLY_HIGH },
421 { "swim" , MOVE_SWIM }, 508 { "swim" , MOVE_SWIM },
422 { "boat" , MOVE_BOAT }, 509 { "boat" , MOVE_BOAT },
510 { "ship" , MOVE_SHIP },
423 { "all" , MOVE_ALL }, 511 { "all" , MOVE_ALL },
424 }; 512 };
425 513
426 if (!str) 514 const char *str = f.get_str ();
427 {
428 mt = 0;
429 return;
430 }
431 515
432 if (isdigit (*str)) 516 if (!*str || isdigit (*str))
433 { 517 {
434 mt = atoi (str); 518 mt = atoi (str);
435 return; 519 return;
436 } 520 }
437 521
438 mt = 0; 522 mt = 0;
439 523
440 for (str = strtok ((char *) str, " "); str; str = strtok (0, " ")) 524 for (str = strtok ((char *)str, " "); str; str = strtok (0, " "))
441 { 525 {
442 bool negate = 0; 526 bool negate = 0;
443 527
444 if (*str == '-') 528 if (*str == '-')
445 { 529 {
446 negate = 1; 530 negate = 1;
447 str++; 531 str++;
448 } 532 }
449 533
450 for (const flagstr *f = move_flags; f < move_flags + sizeof (move_flags) / sizeof (move_flags [0]); ++f) 534 for (const flagstr *f = move_flags; f < move_flags + array_length (move_flags); ++f)
451 { 535 {
452 if (!strcmp (f->name, str)) 536 if (!strcmp (f->name, str))
453 { 537 {
454 if (negate) 538 if (negate)
455 mt &= ~f->flags; 539 mt &= ~f->flags;
… …
458 542
459 goto next; 543 goto next;
460 } 544 }
461 } 545 }
462 546
463 LOG (llevDebug, "common/loader.C: set_move - unknown move string '%s'\n", str); 547 LOG (llevError, "common/loader.C: set_move - unknown move string '%s'\n", str);
464 548
465next: ; 549next: ;
466 } 550 }
467} 551}
468 552
469#define GET_FLAG(op,flag) \ 553//-GPL
470 if (f.get_sint32 ()) \ 554
471 SET_FLAG (op, flag); \ 555#define GET_FLAG(op,flg) op->flag [flg] = f.get_bool ()
472 else \
473 CLEAR_FLAG (op, flag) \
474 556
475bool 557bool
476object::parse_kv (object_thawer &f) 558object::parse_kv (object_thawer &f)
477{ 559{
478 assert (f.kw == KW_object || f.kw == KW_arch);
479
480 if (f.kw == KW_object)
481 f.get (name); // preset name from object name
482
483 f.next ();
484
485 object *op_inv = inv; 560 object *op_inv = inv;
486 561
487 for (;;) 562 for (;;)
488 { 563 {
489 switch (f.kw) 564 switch (f.kw)
490 { 565 {
491 case KW_uuid: 566 case KW_uuid:
492 if (const char *s = f.get_str ()) 567 if (!uuid.parse (f.get_str ()))
493 { 568 {
494 unsigned int version; 569 f.parse_warn ("unparseable uuid");
495 unsigned long long seq; 570 uuid = UUID::gen ();
496
497 if (2 == sscanf (s, "<%d.%llx>", &version, &seq) && version == 1)
498 {
499 uuid.seq = seq;
500 break;
501 }
502 } 571 }
503
504 uuid = gen_uuid ();
505 break; 572 break;
506 573
507 case KW_oid: 574 case KW_oid:
508 f.get (this, f.get_sint32 ()); 575 f.get (this, f.get_sint32 ());
509 break; 576 break;
… …
515 582
516 case KW_attach: f.get_ornull (attach); break; 583 case KW_attach: f.get_ornull (attach); break;
517 case KW_skill: f.get_ornull (skill); break; 584 case KW_skill: f.get_ornull (skill); break;
518 case KW_race: f.get_ornull (race); break; 585 case KW_race: f.get_ornull (race); break;
519 case KW_slaying: f.get_ornull (slaying); break; 586 case KW_slaying: f.get_ornull (slaying); break;
587 case KW_tag: f.get_ornull (tag); break;
520 588
521 case KW_arch: 589 case KW_arch:
522 {
523 object *tmp = object::read (f); 590 if (object *tmp = object::read (f))
524 tmp->deactivate ();
525
526 { 591 {
592 tmp->deactivate ();
593
527 // was: insert_ob_in_ob (tmp, op); 594 // was: insert_ob_in_ob (tmp, op);
528 // but manually adding it can improve map loading times a lot 595 // but manually adding it can improve map loading times a lot
529 // also, appending instead of prepending keeps the 596 // also, appending instead of prepending keeps the
530 // save ordering the same between repeated load/saves. 597 // save ordering the same between repeated load/saves.
531 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL); 598 // and finally we do not want any funny effects
532 CLEAR_FLAG (tmp, FLAG_REMOVED); 599 tmp->clr_flag (FLAG_OBJ_ORIGINAL);
600 tmp->clr_flag (FLAG_REMOVED);
533 601
534 if (!op_inv) 602 if (!op_inv)
535 { 603 {
536 inv = tmp; 604 inv = tmp;
537 tmp->above = 0; 605 tmp->above = 0;
… …
547 615
548 tmp->below = 0; 616 tmp->below = 0;
549 tmp->env = this; 617 tmp->env = this;
550 op_inv = tmp; 618 op_inv = tmp;
551 } 619 }
552 } 620 else
621 LOG (llevError, "ERROR: couldn't load inventory object, file corrupted?\n");
622
553 continue; 623 continue;
554 624
555 case KW_other_arch: 625 case KW_other_arch:
626 if (loading_arch == this)
627 archetype::postpone_arch_ref (loading_arch->other_arch, f.get_str ());
628 else
629 {
556 other_arch = archetype::find (f.get_str ()); 630 other_arch = archetype::find (f.get_str ());
631
632 if (!other_arch)
633 f.parse_warn (format ("%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()));
634 }
635 break;
636
637 case KW_owner:
638 f.delayed_deref (this, owner, f.get_str ());
557 break; 639 break;
558 640
559 case KW_animation: 641 case KW_animation:
560 { 642 {
561 CLEAR_FLAG (this, FLAG_ANIMATE); 643 clr_flag (FLAG_ANIMATE);
562 animation_id = 0; 644 animation_id = 0;
563 645
564 const char *str = f.get_str (); 646 if (f.has_value () && (animation_id = animation::find (f.get_str ()).number))
565 if (str && (animation_id = find_animation (str))) 647 set_flag (FLAG_ANIMATE); //TODO: should not be forced to true here
566 SET_FLAG (this, FLAG_ANIMATE);
567 } 648 }
568 break; 649 break;
569 650
570 case KW_last_heal: f.get (last_heal); break; 651 case KW_last_heal: f.get (last_heal); break;
571 case KW_last_sp: f.get (last_sp); break; 652 case KW_last_sp: f.get (last_sp); break;
572 case KW_last_grace: f.get (last_grace); break; 653 case KW_last_grace: f.get (last_grace); break;
573 case KW_last_eat: f.get (last_eat); break; 654 case KW_last_eat: f.get (last_eat); break;
655 case KW_sl:
574 case KW_speed_left: f.get (speed_left); break; 656 case KW_speed_left: f.get (speed_left); break;
575 657
576 case KW_speed: 658 case KW_speed:
577 f.get (speed); 659 f.get (speed);
578 660
… …
587 move_slow |= MOVE_WALK; 669 move_slow |= MOVE_WALK;
588 f.get (move_slow_penalty); 670 f.get (move_slow_penalty);
589 break; 671 break;
590 672
591 case KW_face: 673 case KW_face:
592 face = &new_faces[FindFace (f.get_str (), 0)]; 674 face = f.has_value () ? face_find (f.get_str ()) : blank_face;
675 break;
676
677 case KW_sound:
678 if (f.has_value ())
679 {
680 sound = sound_find (f.get_str ());
681 if (!sound)
682 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
683 }
684 else
685 sound = 0;
686 break;
687
688 case KW_sound_destroy:
689 if (f.has_value ())
690 {
691 sound_destroy = sound_find (f.get_str ());
692 if (!sound_destroy)
693 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
694 }
695 else
696 sound_destroy = 0;
593 break; 697 break;
594 698
595 case KW_x: f.get (x); break; 699 case KW_x: f.get (x); break;
596 case KW_y: f.get (y); break; 700 case KW_y: f.get (y); break;
597 701
… …
638 case KW_invisible: f.get (invisible); break; 742 case KW_invisible: f.get (invisible); break;
639 case KW_magic: f.get (magic); break; 743 case KW_magic: f.get (magic); break;
640 case KW_state: f.get (state); break; 744 case KW_state: f.get (state); break;
641 case KW_move_slow_penalty: f.get (move_slow_penalty); break; 745 case KW_move_slow_penalty: f.get (move_slow_penalty); break;
642 case KW_material: f.get (materials); break; //TODO: nuke 746 case KW_material: f.get (materials); break; //TODO: nuke
643 case KW_materialname: f.get (materialname); break; 747 case KW_materialname: f.get (material); break;
644 748
645 /* These are the new values */ 749 /* These are the new values */
646 case KW_move_block: set_move (move_block, f.get_str ()); break; 750 case KW_move_block: set_move (move_block, f); break;
647 case KW_move_allow: set_move (move_allow, f.get_str ()); break; 751 case KW_move_allow: set_move (move_allow, f); break;
648 case KW_move_type: set_move (move_type, f.get_str ()); break; 752 case KW_move_type: set_move (move_type , f); break;
649 case KW_move_on: set_move (move_on, f.get_str ()); break; 753 case KW_move_on: set_move (move_on , f); break;
650 case KW_move_off: set_move (move_off, f.get_str ()); break; 754 case KW_move_off: set_move (move_off , f); break;
651 case KW_move_slow: set_move (move_slow, f.get_str ()); break; 755 case KW_move_slow: set_move (move_slow , f); break;
652
653 /* These are all legacy - any new objects should use the move_ .. values */
654 case KW_no_pass:
655 {
656 if (f.get_sint32 ())
657 move_block = MOVE_ALL;
658 else
659 move_block = 0;
660 }
661
662 break;
663
664 /* These are all legacy - any new objects should use the move_ .. values */
665 case KW_walk_on:
666 {
667 if (f.get_sint32 ())
668 move_on |= MOVE_WALK;
669 else
670 move_on &= ~MOVE_WALK;
671 }
672
673 break;
674
675 /* These are all legacy - any new objects should use the move_ .. values */
676 case KW_walk_off:
677 {
678 if (f.get_sint32 ())
679 move_off |= MOVE_WALK;
680 else
681 move_off &= ~MOVE_WALK;
682 }
683 break;
684
685 /* These are all legacy - any new objects should use the move_ .. values */
686 case KW_fly_on:
687 {
688 if (f.get_sint32 ())
689 move_on |= MOVE_FLY_LOW;
690 else
691 move_on &= ~MOVE_FLY_LOW;
692 }
693 break;
694
695 /* These are all legacy - any new objects should use the move_ .. values */
696 case KW_fly_off:
697 {
698 if (f.get_sint32 ())
699 move_off |= MOVE_FLY_LOW;
700 else
701 move_off &= ~MOVE_FLY_LOW;
702 }
703 break;
704 756
705 //TODO: remove these after converting archetypes 757 //TODO: remove these after converting archetypes
706 case KW_can_use_wand: 758 case KW_can_use_wand:
707 GET_FLAG (this, FLAG_USE_RANGE); 759 GET_FLAG (this, FLAG_USE_RANGE);
708 break; 760 break;
709 761
710 /* These are all legacy - any new objects should use the move_ .. values */
711 case KW_flying:
712 {
713 if (f.get_sint32 ())
714 move_type |= MOVE_FLY_LOW;
715 else
716 move_type &= ~MOVE_FLY_LOW;
717 }
718 break;
719
720
721 case KW_identified: 762 case KW_identified:
722 GET_FLAG (this, FLAG_IDENTIFIED); 763 GET_FLAG (this, FLAG_IDENTIFIED);
723 //TODO: move to check_object or so 764 //TODO: move to check_object or so
724 if (QUERY_FLAG (this, FLAG_IDENTIFIED)) 765 if (this->flag [FLAG_IDENTIFIED])
725 CLEAR_FLAG (this, FLAG_KNOWN_MAGICAL); 766 this->clr_flag (FLAG_KNOWN_MAGICAL);
726 767
727 break;
728
729 case KW_wiz:
730 GET_FLAG (this, FLAG_WIZ);
731 //TODO: move to check_object
732 if (QUERY_FLAG (this, FLAG_WIZ))
733 {
734 SET_FLAG (this, FLAG_WAS_WIZ);
735 SET_FLAG (this, FLAG_WIZPASS);
736 SET_FLAG (this, FLAG_WIZCAST);
737 }
738 else
739 {
740 CLEAR_FLAG (this, FLAG_WIZPASS);
741 CLEAR_FLAG (this, FLAG_WIZCAST);
742 }
743 break; 768 break;
744 769
745 case KW_friendly: 770 case KW_friendly:
746 if (f.get_sint32 ()) 771 if (f.get_bool ())
747 if (type != PLAYER) 772 if (type != PLAYER)
748 add_friendly_object (this); 773 add_friendly_object (this);
749 774
750 break; 775 break;
751 776
… …
764 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break; 789 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break;
765 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break; 790 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break;
766 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break; 791 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break;
767 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break; 792 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break;
768 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break; 793 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break;
794 case KW_player_sold: GET_FLAG (this, FLAG_PLAYER_SOLD); break;
769 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break; 795 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break;
770 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break; 796 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break;
771 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break; 797 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break;
772 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break; 798 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break;
773 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break; 799 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break;
774 case KW_hitback: GET_FLAG (this, FLAG_HITBACK); break; 800 case KW_hitback: GET_FLAG (this, FLAG_HITBACK); break;
775 case KW_startequip: GET_FLAG (this, FLAG_STARTEQUIP); break; 801 case KW_startequip: GET_FLAG (this, FLAG_STARTEQUIP); break;
776 case KW_blocksview: GET_FLAG (this, FLAG_BLOCKSVIEW); break; 802 case KW_blocksview: GET_FLAG (this, FLAG_BLOCKSVIEW); break;
803 case KW_is_transparent_floor: GET_FLAG (this, FLAG_IS_TRANSPARENT_FLOOR); break;
777 case KW_undead: GET_FLAG (this, FLAG_UNDEAD); break; 804 case KW_undead: GET_FLAG (this, FLAG_UNDEAD); break;
778 case KW_scared: GET_FLAG (this, FLAG_SCARED); break; 805 case KW_scared: GET_FLAG (this, FLAG_SCARED); break;
779 case KW_unaggressive: GET_FLAG (this, FLAG_UNAGGRESSIVE); break; 806 case KW_unaggressive: GET_FLAG (this, FLAG_UNAGGRESSIVE); break;
780 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break; 807 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break;
781 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break; 808 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break;
782 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break; 809 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break;
783 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break; 810 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break;
784 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break; 811 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break;
785 case KW_was_wiz: GET_FLAG (this, FLAG_WAS_WIZ); break;
786 case KW_no_fix_player: GET_FLAG (this, FLAG_NO_FIX_PLAYER); break;
787 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break; 812 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break;
788 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break; 813 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break;
789 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break; 814 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break;
790 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break; 815 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break;
791 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break; 816 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break;
… …
833 case KW_no_steal: GET_FLAG (this, FLAG_NO_STEAL); break; 858 case KW_no_steal: GET_FLAG (this, FLAG_NO_STEAL); break;
834 case KW_one_hit: GET_FLAG (this, FLAG_ONE_HIT); break; 859 case KW_one_hit: GET_FLAG (this, FLAG_ONE_HIT); break;
835 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break; 860 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break;
836 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break; 861 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break;
837 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break; 862 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break;
863 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break;
864 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break;
865 case KW_random_speed: GET_FLAG (this, FLAG_RANDOM_SPEED); break;
866 case KW_is_quad: GET_FLAG (this, FLAG_IS_QUAD); break;
838 867
839 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break; 868 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break;
840 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break; 869 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break;
841 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break; 870 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break;
842 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break; 871 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break;
… …
872 case KW_anim_speed: f.get (anim_speed); break; 901 case KW_anim_speed: f.get (anim_speed); break;
873 case KW_container: f.get (weight_limit); break; 902 case KW_container: f.get (weight_limit); break;
874 case KW_will_apply: f.get (will_apply); break; 903 case KW_will_apply: f.get (will_apply); break;
875 case KW_attack_movement: f.get (attack_movement); break; 904 case KW_attack_movement: f.get (attack_movement); break;
876 case KW_move_state: f.get (move_status); break; 905 case KW_move_state: f.get (move_status); break;
877 case KW_expmul: f.get (expmul); break; 906 //case KW_expmul: f.get (expmul); break;//D declared const for the time being
878 case KW_glow_radius: f.get (glow_radius); break; 907 case KW_glow_radius: f.get (glow_radius); break;
879 case KW_weapontype: f.get (weapontype); break; 908 case KW_weapontype: f.get (weapontype); break;
880 case KW_tooltype: f.get (tooltype); break;
881 case KW_casting_time: f.get (casting_time); break; 909 case KW_casting_time: f.get (casting_time); break;
910
911 // elevation is deprecated
882 case KW_elevation: f.get (elevation); break; 912 case KW_elevation: break;
913
883 case KW_smoothlevel: f.get (smoothlevel); break; 914 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break;
884 case KW_client_type: f.get (client_type); break; 915 case KW_client_type: f.get (client_type); break;
885 case KW_duration: f.get (duration); break; 916 case KW_duration: f.get (duration); break;
886 case KW_range: f.get (range); break; 917 case KW_range: f.get (range); break;
887 case KW_range_modifier: f.get (range_modifier); break; 918 case KW_range_modifier: f.get (range_modifier); break;
888 case KW_dam_modifier: f.get (dam_modifier); break; 919 case KW_dam_modifier: f.get (dam_modifier); break;
889 case KW_duration_modifier: f.get (duration_modifier); break; 920 case KW_duration_modifier: f.get (duration_modifier); break;
890 921
891 //TODO: mechanism to ensure that KW_xxx is consecutive needed from include/preprocess 922 //TODO: mechanism to ensure that KW_xxx is consecutive needed from include/preprocess
892 //TODO: parse from other include files 923 //TODO: parse from other include files
893 case KW_body_range: f.get (body_info[0]); break; 924 case KW_body_range: slot[body_range] .info = f.get_sint32 (); break;
894 case KW_body_arm: f.get (body_info[1]); break; 925 case KW_body_shield: slot[body_shield] .info = f.get_sint32 (); break;
895 case KW_body_torso: f.get (body_info[2]); break; 926 case KW_body_combat: slot[body_combat] .info = f.get_sint32 (); break;
896 case KW_body_head: f.get (body_info[3]); break; 927 case KW_body_arm: slot[body_arm] .info = f.get_sint32 (); break;
897 case KW_body_neck: f.get (body_info[4]); break; 928 case KW_body_torso: slot[body_torso] .info = f.get_sint32 (); break;
898 case KW_body_skill: f.get (body_info[5]); break; 929 case KW_body_head: slot[body_head] .info = f.get_sint32 (); break;
899 case KW_body_finger: f.get (body_info[6]); break; 930 case KW_body_neck: slot[body_neck] .info = f.get_sint32 (); break;
900 case KW_body_shoulder: f.get (body_info[7]); break; 931 case KW_body_skill: slot[body_skill] .info = f.get_sint32 (); break;
901 case KW_body_foot: f.get (body_info[8]); break; 932 case KW_body_finger: slot[body_finger] .info = f.get_sint32 (); break;
902 case KW_body_hand: f.get (body_info[9]); break; 933 case KW_body_shoulder: slot[body_shoulder].info = f.get_sint32 (); break;
903 case KW_body_wrist: f.get (body_info[10]); break; 934 case KW_body_foot: slot[body_foot] .info = f.get_sint32 (); break;
904 case KW_body_waist: f.get (body_info[11]); break; 935 case KW_body_hand: slot[body_hand] .info = f.get_sint32 (); break;
936 case KW_body_wrist: slot[body_wrist] .info = f.get_sint32 (); break;
937 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break;
905 case KW_can_apply: 938 case KW_can_apply:
906 break; 939 break;
907 940
908 case KW_connected: 941 case KW_connected:
909 add_button_link (this, map, f.get_sint32 ()); 942 {
943 shstr connected;
944
945 f.get (connected);
946 add_link (map, connected);
947 }
910 break; 948 break;
911 949
912 case KW_randomitems: 950 case KW_randomitems:
913 randomitems = find_treasurelist (f.get_str ()); 951 if (f.has_value ())
952 {
953 randomitems =
954 loading_arch
955 ? treasurelist::get (f.get_str ())
956 : treasurelist::find (f.get_str ());
957
914 //if (!randomitems) 958 if (!randomitems)
959 {
915 // LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ()); 960 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ());
961 randomitems = treasurelist::get (shstr_none); // avoid crashes
962 }
963 }
964 else
965 randomitems = 0;
916 break; 966 break;
917 967
918 case KW_msg: 968 case KW_msg:
919 f.get_ml (KW_endmsg, msg); 969 f.get_ml (KW_endmsg, msg);
920 //TODO: allow longer messages
921 if (strlen (msg) >= HUGE_BUF)
922 {
923 LOG (llevDebug, "\tError message length >= %d: %d\n>%.80s<\n", HUGE_BUF, strlen (msg), &msg);
924 msg = "ERROR, please report: string too long, winged.\n";
925 }
926 break; 970 break;
927 971
928 case KW_lore: 972 case KW_lore:
929 f.get_ml (KW_endlore, lore); 973 f.get_ml (KW_endlore, lore);
930 //TODO: allow longer messages
931 /* Just print a warning so we can be reasonably safe
932 * about not overflowing the buffer.
933 */
934 if (strlen (lore) > (HUGE_BUF / 2))
935 LOG (llevDebug, "\tWarning lore length > %d (max allowed=%d): %d\n>%.80s<\n",
936 HUGE_BUF / 2, HUGE_BUF, strlen (lore), &lore);
937 break; 974 break;
938 975
939 case KW_editable: 976 case KW_editable:
940 case KW_editor_folder: 977 case KW_editor_folder:
941 break; 978 break;
942 979
943 case KW_end: 980 case KW_end:
944 check_loaded_object (this);
945
946 if (!arch_init) 981 if (!loading_arch)
947 instantiate (); 982 instantiate ();
948 983
949 f.next (); 984 f.next ();
950 return true; 985 return true;
951 986
952 case KW_ERROR: 987 case KW_ERROR:
953 set_ob_key_value (this, f.kw_str, f.value, true); 988 // we do not even try to find old values, duplicate keys stay duplicate
954 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D 989 // the list gets reversed after loading
990 kv.add (shstr (f.kw_str), shstr (f.value));
955 break; 991 break;
956 992
957 default: 993 default:
958 if (!f.parse_error ("object", name)) 994 if (!f.parse_error ("object", name))
959 return false; 995 return false;
… …
971 1007
972 archetype *arch = archetype::find (f.get_str ()); 1008 archetype *arch = archetype::find (f.get_str ());
973 1009
974 if (!arch) 1010 if (!arch)
975 { 1011 {
976 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ()); 1012 LOG (llevError, "object referring to nonexistent archetype '%s'.\n", f.get_str ());
977 arch = archetype::find ("earthwall"); 1013 arch = archetype::find (shstr_earthwall);
978 } 1014 }
979 1015
980 assert (arch); //D maybe use exception handling of sorts? 1016 assert (arch); //D maybe use exception handling of sorts?
981 1017
982 object *op = object::create (); 1018 f.next ();
983 1019
1020 object *op = arch->instance ();
984 op->map = map; 1021 op->map = map;
985 op->arch = arch;
986 arch->clone.copy_to (op);
987 // copy_to activates, this should be fixed properly 1022 // instance() activates, this should be fixed properly
988 op->deactivate (); 1023 op->deactivate ();
989 1024
990 if (!op->parse_kv (f)) 1025 if (!op->parse_kv (f))
991 { 1026 {
992 delete op; 1027 op->destroy ();
993 return 0; 1028 return 0;
994 } 1029 }
995 1030
1031 // the loader reverses the ordering of kv-pairs, so we reverse it again after loading
1032 // that greatly simplifies the loading code.
1033 op->kv.reverse ();
1034
1035 op->post_load_check ();
996 return op; 1036 return op;
997} 1037}
998 1038
999/* This takes a buffer, scans it for variables, and sets those variables 1039/* This takes a buffer, scans it for variables, and sets those variables
1000 * as appropriate in op. 1040 * as appropriate in op.
… …
1003 * override values and in c_wiz to mutate values. 1043 * override values and in c_wiz to mutate values.
1004 */ 1044 */
1005int 1045int
1006set_variable (object *op, char *buf) 1046set_variable (object *op, char *buf)
1007{ 1047{
1008 object_thawer f (buf, (AV *)0); 1048 object_thawer f (format ("%s\nend", buf), (AV *)0);
1009 1049
1010 f.kw = KW_arch; // special hack so that parse_kv skips
1011 return op->parse_kv (f); 1050 return op->parse_kv (f);
1012} 1051}
1013 1052
1014/* This returns a string of the integer movement type */
1015#if 0
1016// unused function
1017static char *
1018get_string_move_type (MoveType mt)
1019{
1020 static char retbuf[MAX_BUF], retbuf_all[MAX_BUF];
1021 int i, all_count = 0, count;
1022
1023 strcpy (retbuf, "");
1024 strcpy (retbuf_all, " all");
1025
1026 /* Quick check, and probably fairly common */
1027 if (mt == MOVE_ALL)
1028 return retbuf_all + 1;
1029 if (mt == 0)
1030 {
1031 strcpy (retbuf, "0");
1032 return retbuf;
1033 }
1034
1035 /* We basically slide the bits down. Why look at MOVE_ALL?
1036 * because we may want to return a string like 'all -swim',
1037 * and if we just looked at mt, we couldn't get that.
1038 */
1039 for (i = MOVE_ALL, count = 0; i != 0; i >>= 1, count++)
1040 {
1041 if (mt & (1 << count))
1042 {
1043 strcat (retbuf, " ");
1044 strcat (retbuf, move_name[count]);
1045 }
1046 else
1047 {
1048 strcat (retbuf_all, " -");
1049 strcat (retbuf_all, move_name[count]);
1050 all_count++;
1051 }
1052 }
1053 /* Basically, if there is a single negation, return it, eg
1054 * 'all -swim'. But more than that, just return the
1055 * enumerated values. It doesn't make sense to return
1056 * 'all -walk -fly_low' - it is shorter to return 'fly_high swim'
1057 */
1058 if (all_count <= 1)
1059 return retbuf_all + 1;
1060 else
1061 return retbuf + 1;
1062}
1063#endif
1064
1065// compare *op against *tmp and output differences 1053// compare *op against *arch and output differences
1066static void 1054static void
1067write_diff (object_freezer &f, object *op, object *tmp) 1055write_diff (object_freezer &f, object *op, object *arch)
1068{ 1056{
1069 static const keyword resist_save[NROFATTACKS] = { 1057 static const keyword resist_save[NROFATTACKS] = {
1070# define def(uc, lc, name, plus, change) KW_resist_ ## lc, 1058# define def(uc, lc, name, plus, change) KW_resist_ ## lc,
1071# include "attackinc.h" 1059# include "attackinc.h"
1072# undef def 1060# undef def
… …
1077 * the 15'th element of this array should match that name. 1065 * the 15'th element of this array should match that name.
1078 * If an entry is NULL, that is a flag not to loaded/saved. 1066 * If an entry is NULL, that is a flag not to loaded/saved.
1079 */ 1067 */
1080 static const keyword flag_names [NUM_FLAGS] = { 1068 static const keyword flag_names [NUM_FLAGS] = {
1081 KW_alive, 1069 KW_alive,
1082 KW_wiz,
1083 KW_NULL, 1070 KW_NULL,
1084 KW_NULL, 1071 KW_NULL,
1085 KW_was_wiz, 1072 KW_NULL,
1073 KW_NULL,
1086 KW_applied, 1074 KW_applied,
1087 KW_unpaid, 1075 KW_unpaid,
1088 KW_can_use_shield, 1076 KW_can_use_shield,
1089 KW_no_pick, 1077 KW_no_pick,
1090 KW_NULL, // walk_on 1078 KW_is_transparent_floor,
1079 /* 10 */
1091 KW_NULL, // no_pass 1080 KW_NULL, // no_pass
1092 /* 10 */
1093 KW_is_animated, 1081 KW_is_animated,
1094 KW_NULL, // slow_move 1082 KW_NULL, // slow_move
1095 KW_NULL, // flying 1083 KW_NULL, // flying
1096 KW_monster, 1084 KW_monster,
1097 KW_friendly, 1085 KW_friendly,
1098 KW_generator, 1086 KW_generator,
1099 KW_is_thrown, 1087 KW_is_thrown,
1100 KW_auto_apply, 1088 KW_auto_apply,
1101 KW_NULL, // was KW_treasure 1089 KW_treasure_env,
1090 /* 20 */
1102 KW_player_sold, 1091 KW_player_sold,
1103 /* 20 */
1104 KW_see_invisible, 1092 KW_see_invisible,
1105 KW_can_roll, 1093 KW_can_roll,
1106 KW_overlay_floor, 1094 KW_overlay_floor,
1107 KW_is_turnable, 1095 KW_is_turnable,
1108 KW_NULL, // walk_off 1096 KW_NULL, // walk_off
1109 KW_NULL, // fly_on 1097 KW_NULL, // fly_on
1110 KW_NULL, // fly_off 1098 KW_NULL, // fly_off
1111 KW_is_used_up, 1099 KW_is_used_up,
1112 KW_identified, 1100 KW_identified,
1101 /* 30 */
1113 KW_reflecting, 1102 KW_reflecting,
1114 /* 30 */
1115 KW_changing, 1103 KW_changing,
1116 KW_splitting, 1104 KW_splitting,
1117 KW_hitback, 1105 KW_hitback,
1118 KW_startequip, 1106 KW_startequip,
1119 KW_blocksview, 1107 KW_blocksview,
1120 KW_undead, 1108 KW_undead,
1121 KW_scared, 1109 KW_scared,
1122 KW_unaggressive, 1110 KW_unaggressive,
1123 KW_reflect_missile, 1111 KW_reflect_missile,
1112 /* 40 */
1124 KW_reflect_spell, 1113 KW_reflect_spell,
1125 /* 40 */
1126 KW_no_magic, 1114 KW_no_magic,
1127 KW_no_fix_player, 1115 KW_NULL,
1128 KW_is_lightable, 1116 KW_is_lightable,
1129 KW_tear_down, 1117 KW_tear_down,
1130 KW_run_away, 1118 KW_run_away,
1131 KW_NULL, // pass_thru 1119 KW_NULL, // pass_thru
1132 KW_NULL, // an_pass_thru 1120 KW_NULL, // an_pass_thru
1133 KW_pick_up, 1121 KW_pick_up,
1134 KW_unique, 1122 KW_unique,
1123 /* 50 */
1135 KW_no_drop, 1124 KW_no_drop,
1136 /* 50 */
1137 KW_NULL, // wizcast 1125 KW_NULL, // wizcast
1138 KW_can_cast_spell, 1126 KW_can_cast_spell,
1139 KW_can_use_scroll, 1127 KW_can_use_scroll,
1140 KW_can_use_range, 1128 KW_can_use_range,
1141 KW_can_use_bow, 1129 KW_can_use_bow,
1142 KW_can_use_armour, 1130 KW_can_use_armour,
1143 KW_can_use_weapon, 1131 KW_can_use_weapon,
1144 KW_can_use_ring, 1132 KW_can_use_ring,
1145 KW_has_ready_range, 1133 KW_has_ready_range,
1134 /* 60 */
1146 KW_has_ready_bow, 1135 KW_has_ready_bow,
1147 /* 60 */
1148 KW_xrays, 1136 KW_xrays,
1149 KW_NULL, 1137 KW_NULL,
1150 KW_is_floor, 1138 KW_is_floor,
1151 KW_lifesave, 1139 KW_lifesave,
1152 KW_no_strength, 1140 KW_no_strength,
1153 KW_sleep, 1141 KW_sleep,
1154 KW_stand_still, 1142 KW_stand_still,
1155 KW_random_move, 1143 KW_random_move,
1156 KW_only_attack, 1144 KW_only_attack,
1145 /* 70 */
1157 KW_confused, 1146 KW_confused,
1158 /* 70 */
1159 KW_stealth, 1147 KW_stealth,
1160 KW_NULL, 1148 KW_NULL,
1161 KW_NULL, 1149 KW_NULL,
1162 KW_cursed, 1150 KW_cursed,
1163 KW_damned, 1151 KW_damned,
1164 KW_see_anywhere, 1152 KW_see_anywhere,
1165 KW_known_magical, 1153 KW_known_magical,
1166 KW_known_cursed, 1154 KW_known_cursed,
1167 KW_can_use_skill, 1155 KW_can_use_skill,
1156 /* 80 */
1168 KW_been_applied, 1157 KW_been_applied,
1169 /* 80 */
1170 KW_has_ready_scroll, 1158 KW_has_ready_scroll,
1171 KW_can_use_rod, 1159 KW_can_use_rod,
1172 KW_NULL, 1160 KW_precious,
1173 KW_can_use_horn, 1161 KW_can_use_horn,
1174 KW_make_invisible, 1162 KW_make_invisible,
1175 KW_inv_locked, 1163 KW_inv_locked,
1176 KW_is_wooded, 1164 KW_is_wooded,
1177 KW_is_hilly, 1165 KW_is_hilly,
1178 KW_has_ready_skill, 1166 KW_has_ready_skill,
1167 /* 90 */
1179 KW_has_ready_weapon, 1168 KW_has_ready_weapon,
1180 /* 90 */
1181 KW_no_skill_ident, 1169 KW_no_skill_ident,
1182 KW_is_blind, 1170 KW_is_blind,
1183 KW_can_see_in_dark, 1171 KW_can_see_in_dark,
1184 KW_is_cauldron, 1172 KW_is_cauldron,
1185 KW_NULL, 1173 KW_NULL,
1186 KW_no_steal, 1174 KW_no_steal,
1187 KW_one_hit, 1175 KW_one_hit,
1188 KW_NULL, 1176 KW_NULL,
1189 KW_berserk, 1177 KW_berserk,
1178 /* 100 */
1190 KW_neutral, 1179 KW_neutral,
1191 /* 100 */
1192 KW_no_attack, 1180 KW_no_attack,
1193 KW_no_damage, 1181 KW_no_damage,
1194 KW_obj_original, 1182 KW_obj_original,
1195 KW_NULL, 1183 KW_random_speed,
1196 KW_activate_on_push, 1184 KW_activate_on_push,
1197 KW_activate_on_release, 1185 KW_activate_on_release,
1198 KW_is_water, 1186 KW_is_water,
1199 KW_use_content_on_gen, 1187 KW_use_content_on_gen,
1200 KW_NULL, 1188 KW_NULL,
1189 /* 110 */
1201 KW_is_buildable, 1190 KW_is_buildable,
1202 /* 110 */
1203 KW_destroy_on_death, 1191 KW_destroy_on_death,
1204 KW_NULL, 1192 KW_NULL,
1205 }; 1193 };
1206 1194
1207 int i; 1195 // obj_original is the only commonly differing flag between archetype
1196 // and object, so special-case it here to be able to skip the loop
1197 static const struct flagmask : object::flags_t
1198 {
1199 flagmask ()
1200 {
1201 for (int i = 0; i < NUM_FLAGS; i++)
1202 if (flag_names [i])
1203 set (i);
1204 }
1205 } flagmask;
1208 1206
1209 /* This saves the key/value lists. We do it first so that any 1207 /* This saves the key/value lists. We do it first so that any
1210 * keys that match field names will be overwritten by the loader. 1208 * keys that match field names will be overwritten by the loader.
1211 */ 1209 */
1212 for (key_value *my_field = op->key_values; my_field; my_field = my_field->next) 1210 for (key_value *kv = op->kv.first; kv; kv = kv->next)
1213 { 1211 if (arch->kv.empty () || arch->kv [kv->key] != kv->value)
1214 /* Find the field in the opposing member. */ 1212 f.put (kv->key, kv->value);
1215 key_value *arch_field = get_ob_key_link (tmp, my_field->key);
1216 1213
1217 /* If there's no partnering field, or it's got a different value, save our field. */ 1214 if (op->uuid)
1218 if (!arch_field || my_field->value != arch_field->value)
1219 f.put (my_field->key, my_field->value);
1220 } 1215 {
1216 // highly optimised - this is often 25% of all data written
1217 char *cur = f.force (sizeof ("uuid ") + UUID::MAX_LEN + 1);
1218 char *ptr = cur;
1221 1219
1222 /* We don't need to worry about the arch's extra fields - they 1220 memcpy (ptr, "uuid ", sizeof ("uuid ") - 1);
1223 * will get taken care of the copy_to method. 1221 ptr += sizeof ("uuid ") - 1;
1224 */ 1222 ptr = op->uuid.append (ptr);
1223 *ptr++ = '\n';
1225 1224
1226 { 1225 f.alloc (ptr - cur);
1227 char uids[64];
1228 snprintf (uids, sizeof (uids), "<1.%llx>", (unsigned long long)op->uuid.seq);
1229 f.put (KW_uuid, (const char *)uids);
1230 } 1226 }
1231 1227
1232#define CMP_OUT(v) if (op->v != tmp->v) f.put (KW_ ## v, op->v) 1228#define CMP_OUT(v) if (expect_false (op->v != arch->v)) f.put (KW (v), op->v)
1233#define CMP_OUT2(k,v) if (op->v != tmp->v) f.put (KW_ ## k, op->v) 1229#define CMP_OUT2(k,v) if (expect_false (op->v != arch->v)) f.put (KW (k), op->v)
1230
1231 CMP_OUT (x);
1232 CMP_OUT (y);
1233
1234 CMP_OUT (type);
1235 CMP_OUT (subtype);
1236 CMP_OUT (direction);
1234 1237
1235 CMP_OUT (name); 1238 CMP_OUT (name);
1236 CMP_OUT (name_pl); 1239 CMP_OUT (name_pl);
1237 CMP_OUT (custom_name); 1240 CMP_OUT (speed);
1241
1242 // speed_left is a major time-burner, and has good locality, so
1243 // we use a simple lookup-cache to avoid the very slow printf.
1244 if (op->speed_left != arch->speed_left)
1245 {
1246 static double last_speed_left = 0.;
1247 static char last_speed_left_str [256] = "sl 0\n";
1248 static int last_speed_left_len = sizeof ("sl 0\n") - 1;
1249
1250 if (last_speed_left != op->speed_left)
1251 {
1252 last_speed_left = op->speed_left;
1253 // .7g loses precision even for float, but gives nice round numbers and smaller files
1254 // maybe hex format or a raw binary dump of the float is good enough, more exact, and much faster?
1255 // (printf is typically very slow)
1256 last_speed_left_len = sizeof ("sl ") - 1
1257 + sprintf (last_speed_left_str + sizeof ("sl ") - 1, "%.7g\n", last_speed_left);
1258 }
1259
1260 f.add (last_speed_left_str, last_speed_left_len);
1261 }
1262
1238 CMP_OUT (title); 1263 CMP_OUT (title);
1239 CMP_OUT (race); 1264 CMP_OUT (race);
1240 CMP_OUT (slaying); 1265 CMP_OUT (slaying);
1266 CMP_OUT (skill);
1241 1267
1242 if (op->msg != tmp->msg) 1268 CMP_OUT (tag);
1243 f.put (KW_msg, KW_endmsg, op->msg); 1269 CMP_OUT (custom_name);
1244 if (op->lore != tmp->lore) 1270
1245 f.put (KW_lore, KW_endlore, op->lore); 1271 if (object *owner = op->owner)
1272 if (const char *ref = owner->ref ())
1273 f.put (KW(owner), ref);
1274
1275 // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved
1246 1276
1247 CMP_OUT (other_arch); 1277 CMP_OUT (other_arch);
1248 CMP_OUT (face);
1249 1278
1279 if (op->msg != arch->msg ) f.put (KW(msg) , KW(endmsg) , op->msg );
1280 if (op->lore != arch->lore) f.put (KW(lore), KW(endlore), op->lore);
1281
1282 if (op->face != arch->face ) f.put (KW(face) , op->face ? &faces [op->face ] : 0);
1283 if (op->sound != arch->sound ) f.put (KW(sound) , op->sound ? &faces [op->sound ] : 0);
1284 if (op->sound_destroy != arch->sound_destroy) f.put (KW(sound_destroy), op->sound_destroy ? &faces [op->sound_destroy] : 0);
1285
1250 if (op->animation_id != tmp->animation_id) 1286 if (op->animation_id != arch->animation_id)
1251 if (op->animation_id) 1287 if (op->has_anim ())
1288 f.put (KW(animation), op->anim ().name);
1289 else
1252 { 1290 {
1253 f.put (KW_animation, animations[GET_ANIM_ID (op)].name); 1291 f.put (KW(animation));
1254 1292 op->flag [FLAG_ANIMATE] = false; // TODO: why force to false here?
1255 if (!QUERY_FLAG (op, FLAG_ANIMATE))
1256 f.put (KW_is_animated, (sint32) 0);
1257 } 1293 }
1258 else
1259 f.put (KW_animation, (const char *) 0);
1260 1294
1261 CMP_OUT2 (str, stats.Str); 1295 CMP_OUT2 (str, stats.Str);
1262 CMP_OUT2 (dex, stats.Dex); 1296 CMP_OUT2 (dex, stats.Dex);
1263 CMP_OUT2 (con, stats.Con); 1297 CMP_OUT2 (con, stats.Con);
1264 CMP_OUT2 (wis, stats.Wis); 1298 CMP_OUT2 (wis, stats.Wis);
… …
1273 CMP_OUT2 (grace, stats.grace); 1307 CMP_OUT2 (grace, stats.grace);
1274 CMP_OUT2 (maxgrace, stats.maxgrace); 1308 CMP_OUT2 (maxgrace, stats.maxgrace);
1275 CMP_OUT2 (exp, stats.exp); 1309 CMP_OUT2 (exp, stats.exp);
1276 1310
1277 CMP_OUT (perm_exp); 1311 CMP_OUT (perm_exp);
1278 CMP_OUT (expmul); 1312 //CMP_OUT (expmul);
1279 1313
1280 CMP_OUT2 (food, stats.food); 1314 CMP_OUT2 (food, stats.food);
1281 CMP_OUT2 (dam, stats.dam); 1315 CMP_OUT2 (dam, stats.dam);
1282 CMP_OUT2 (luck, stats.luck); 1316 CMP_OUT2 (luck, stats.luck);
1283 CMP_OUT2 (wc, stats.wc); 1317 CMP_OUT2 (wc, stats.wc);
1284 CMP_OUT2 (ac, stats.ac); 1318 CMP_OUT2 (ac, stats.ac);
1285 1319
1286 CMP_OUT (x);
1287 CMP_OUT (y);
1288 CMP_OUT (speed);
1289 CMP_OUT (speed_left);
1290 CMP_OUT2 (move_state, move_status); 1320 CMP_OUT2 (move_state, move_status);
1291 CMP_OUT (attack_movement); 1321 CMP_OUT (attack_movement);
1292 CMP_OUT (nrof); 1322 CMP_OUT (nrof);
1293 CMP_OUT (level); 1323 CMP_OUT (level);
1294 CMP_OUT (direction);
1295 CMP_OUT (type);
1296 CMP_OUT (subtype);
1297 CMP_OUT (attacktype); 1324 CMP_OUT (attacktype);
1298 1325
1326 // using memcmp here seems to be a loss - is gcc vectorising?
1299 for (i = 0; i < NROFATTACKS; i++) 1327 for (int i = 0; i < NROFATTACKS; i++)
1300 if (op->resist[i] != tmp->resist[i]) 1328 if (expect_false (op->resist[i] != arch->resist[i]))
1301 f.put (resist_save[i], op->resist[i]); 1329 f.put (resist_save[i], op->resist[i]);
1302 1330
1303 CMP_OUT (path_attuned); 1331 CMP_OUT (path_attuned);
1304 CMP_OUT (path_repelled); 1332 CMP_OUT (path_repelled);
1305 CMP_OUT (path_denied); 1333 CMP_OUT (path_denied);
1334
1306 CMP_OUT2 (material, materials);//TODO: nuke 1335 CMP_OUT2 (material, materials);//TODO: nuke
1307 CMP_OUT (materialname); 1336 if (op->material != arch->material)
1337 f.put (KW(materialname), op->material->name);
1338
1308 CMP_OUT (value); 1339 CMP_OUT (value);
1309 CMP_OUT (carrying); 1340 CMP_OUT (carrying);
1310 CMP_OUT (weight); 1341 CMP_OUT (weight);
1311 CMP_OUT (invisible); 1342 CMP_OUT (invisible);
1312 CMP_OUT (state); 1343 CMP_OUT (state);
… …
1315 CMP_OUT (last_sp); 1346 CMP_OUT (last_sp);
1316 CMP_OUT (last_grace); 1347 CMP_OUT (last_grace);
1317 CMP_OUT (last_eat); 1348 CMP_OUT (last_eat);
1318 CMP_OUT (glow_radius); 1349 CMP_OUT (glow_radius);
1319 1350
1320 if (QUERY_FLAG (op, FLAG_IS_LINKED) && (i = get_button_value (op))) 1351 if (op->flag [FLAG_IS_LINKED])
1352 if (auto (ol, op->find_link ()))
1321 f.put (KW_connected, i); 1353 f.put (KW(connected), ol->id);
1322 1354
1323 CMP_OUT (randomitems); 1355 CMP_OUT (randomitems);
1356
1324 CMP_OUT2 (container, weight_limit); 1357 CMP_OUT2 (container, weight_limit);
1325 1358
1326 CMP_OUT (run_away); 1359 CMP_OUT (run_away);
1327 CMP_OUT (pick_up); 1360 CMP_OUT (pick_up);
1328 CMP_OUT (will_apply); 1361 CMP_OUT (will_apply);
1329 CMP_OUT (smoothlevel); 1362 CMP_OUT (smoothlevel);
1330 CMP_OUT (weapontype); 1363 CMP_OUT (weapontype);
1331 CMP_OUT (tooltype);
1332 CMP_OUT (elevation);
1333 CMP_OUT (client_type); 1364 CMP_OUT (client_type);
1334 CMP_OUT (item_power); 1365 CMP_OUT (item_power);
1335 CMP_OUT (duration); 1366 CMP_OUT (duration);
1336 CMP_OUT (range); 1367 CMP_OUT (range);
1337 CMP_OUT (range_modifier); 1368 CMP_OUT (range_modifier);
… …
1345 CMP_OUT (move_on); 1376 CMP_OUT (move_on);
1346 CMP_OUT (move_off); 1377 CMP_OUT (move_off);
1347 CMP_OUT (move_slow); 1378 CMP_OUT (move_slow);
1348 CMP_OUT (move_slow_penalty); 1379 CMP_OUT (move_slow_penalty);
1349 1380
1350 if (op->flag != tmp->flag) 1381 object::flags_t diff = (op->flag ^ arch->flag) & flagmask;
1382
1383#if stdcpp // we need gcc, sorry
1384 if (diff [FLAG_OBJ_ORIGINAL])
1385 f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? CS(1) : CS(0));
1386
1387 diff.reset (FLAG_OBJ_ORIGINAL);
1388
1389 // quickly test whether any other flags differ
1390 if (expect_true (diff.any ()))
1351 for (i = 0; i <= NUM_FLAGS; i++) 1391 for (int i = 0; i < NUM_FLAGS; i++)
1352 if (flag_names [i] && op->flag [i] != tmp->flag [i]) 1392 if (expect_false (diff [i]))
1353 f.put (flag_names [i], op->flag [i] ? "1" : "0"); 1393 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1394#else
1395 // use sgi extensions
1396 for (int i = diff._Find_first (); i < diff.size (); i = diff._Find_next (i))
1397 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1398#endif
1354 1399
1355 /* Save body locations */ 1400 // save body locations. gcc's memcmp does an abysmal job when used
1356 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 1401 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
1357 if (op->body_info[i] != tmp->body_info[i]) 1402 if (expect_false (op->slot[i].info != arch->slot[i].info))
1358 f.put (body_locations[i].save_name, op->body_info[i]); 1403 f.put (body_locations[i].kw, op->slot[i].info);
1359} 1404}
1360 1405
1361/* 1406/*
1362 * Dumps all variables in an object to a file. 1407 * Dumps all variables in an object to a file.
1363 * If bit 0 of flag is set, unpaid objects will be saved. As of now, 1408 * If bit 0 of flag is set, unpaid objects will be saved. As of now,
1364 * the only place this is not set is when saving the player. 1409 * the only place this is not set is when saving the player.
1365 */ 1410 */
1366bool 1411bool
1367object::write (object_freezer &f) 1412object::write (object_freezer &f)
1368{ 1413{
1369 /* Even if the object does have an owner, it would seem that we should 1414 if (expect_false (is_arch ()))
1370 * still save it. 1415 {
1371 */ 1416 f.put (KW(object), arch->archname);
1372 if (owner) 1417 write_diff (f, this, archetype::empty);
1373 return true; 1418 }
1374 1419 else
1375 archetype *at = arch ? (archetype *)arch : empty_archetype; 1420 {
1376
1377 f.put (KW_arch, at->name); 1421 f.put (KW(arch), arch->archname);
1378 write_diff (f, this, &at->clone); 1422 write_diff (f, this, arch);
1423 }
1379 1424
1380 for (object *tmp = inv; tmp; tmp = tmp->below) 1425 for (object *tmp = inv; tmp; tmp = tmp->below)
1381 tmp->write (f); 1426 tmp->write (f);
1382 1427
1383 f.put (this); 1428 f.put (this);
1384 f.put (KW_end); 1429 f.put (KW(end));
1385 1430
1386 return true; 1431 return true;
1387} 1432}
1388 1433
1389///////////////////////////////////////////////////////////////////////////// 1434/////////////////////////////////////////////////////////////////////////////
1390 1435
1436// generic resource file load,
1437// currently supports: region, treasures, archetypes
1438bool
1391bool load_resource_file (const char *filename) 1439load_resource_file_ (const char *filename)
1392{ 1440{
1393 object_thawer f (filename); 1441 object_thawer f (filename);
1394 1442
1395 f.next ();
1396
1397 for (;;) 1443 for (;;)
1398 { 1444 {
1445 coroapi::cede_to_tick ();
1446
1399 switch (f.kw) 1447 switch (f.kw)
1400 { 1448 {
1401 case KW_region: 1449 case KW_region:
1402 if (!region::read (f)) 1450 if (!region::read (f))
1403 return false; 1451 return false;
1404 break; 1452 break;
1405 1453
1454 case KW_treasure:
1455 case KW_treasureone:
1456 if (!treasurelist::read (f))
1457 return false;
1458 break;
1459
1460 case KW_object:
1461 if (!archetype::read (f))
1462 return false;
1463 break;
1464
1406 case KW_EOF: 1465 case KW_EOF:
1407 return true; 1466 return true;
1408 1467
1409 default: 1468 default:
1410 if (!f.parse_error ("resource file")) 1469 if (!f.parse_error ("resource file"))
1411 return false; 1470 return false;
1471
1472 f.next ();
1473 break;
1412 } 1474 }
1413
1414 f.next ();
1415 } 1475 }
1416} 1476}
1417 1477

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines