ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/loader.C
(Generate patch)

Comparing deliantra/server/common/loader.C (file contents):
Revision 1.142 by root, Mon Nov 9 17:39:05 2009 UTC vs.
Revision 1.182 by root, Wed Nov 14 21:19:41 2018 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2018 Marc Alexander Lehmann / the Deliantra team
4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 5 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team 6 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 7 * Copyright (©) 1992 Frank Tore Johansen
7 * 8 *
8 * Deliantra is free software: you can redistribute it and/or modify it under 9 * Deliantra is free software: you can redistribute it and/or modify it under
9 * the terms of the Affero GNU General Public License as published by the 10 * the terms of the Affero GNU General Public License as published by the
10 * Free Software Foundation, either version 3 of the License, or (at your 11 * Free Software Foundation, either version 3 of the License, or (at your
11 * option) any later version. 12 * option) any later version.
12 * 13 *
13 * This program is distributed in the hope that it will be useful, 14 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 17 * GNU General Public License for more details.
17 * 18 *
18 * You should have received a copy of the Affero GNU General Public License 19 * You should have received a copy of the Affero GNU General Public License
19 * and the GNU General Public License along with this program. If not, see 20 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>. 21 * <http://www.gnu.org/licenses/>.
21 * 22 *
22 * The authors can be reached via e-mail to <support@deliantra.net> 23 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 24 */
24 25
25#include <global.h> 26#include <global.h>
26#include <loader.h>
27#include <sproto.h> 27#include <sproto.h>
28 28
29///////////////////////////////////////////////////////////////////////////// 29/////////////////////////////////////////////////////////////////////////////
30 30
31extern archetype *loading_arch; 31extern archetype *loading_arch;
… …
251 "spell_glyph", /* 205 */ 251 "spell_glyph", /* 205 */
252 NULL 252 NULL
253}; 253};
254 254
255/* This function checks the object after it has been loaded (when we 255/* This function checks the object after it has been loaded (when we
256 * get the 'end' in the input stream). This function can be used to 256 * get the 'end' in the input stream). This function can be used to
257 * deal with legacy objects where fields may have changed. It can also be used 257 * deal with legacy objects where fields may have changed. It can also be used
258 * to check for objects to make sure there are no common errors. 258 * to check for objects to make sure there are no common errors.
259 */ 259 */
260void 260void
261object::post_load_check () 261object::post_load_check ()
… …
266 type = 0; 266 type = 0;
267 } 267 }
268 268
269 switch (type) 269 switch (type)
270 { 270 {
271 case RANGED:
271 case BOW: 272 case BOW:
272 case WAND: 273 case WAND:
273 case ROD: 274 case ROD:
274 case HORN: 275 case HORN:
275 if (slot [body_range].info != -1) 276 if (slot [body_range].info != -1)
… …
293 LOG (llevError, "ITEMBUG: %s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info); 294 LOG (llevError, "ITEMBUG: %s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info);
294 slot [body_shield].info = -1; 295 slot [body_shield].info = -1;
295 } 296 }
296 break; 297 break;
297 298
299 case CONTAINER:
300 if (nrof)
301 {
302 LOG (llevError, "ITEMBUG: %s: stackable container (nrof %d)\n", debug_desc (), (int)nrof);
303 nrof = 0;
304 }
305 break;
306
298 case PLAYER: 307 case PLAYER:
299 if (slot [body_shield].info != 1) 308 if (slot [body_shield].info != 1)
300 { 309 {
301 LOG (llevError, "ITEMBUG: %s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info); 310 LOG (llevError, "ITEMBUG: %s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info);
302 slot [body_shield].info = 1; 311 slot [body_shield].info = 1;
… …
321 * this isn't perfect (things won't be properly pluralised), but works to 330 * this isn't perfect (things won't be properly pluralised), but works to
322 * that degree (5 heart is still quite understandable). But the case we 331 * that degree (5 heart is still quite understandable). But the case we
323 * also have to catch is if this object is not using the normal name for 332 * also have to catch is if this object is not using the normal name for
324 * the object. In that case, we also want to use the loaded name. 333 * the object. In that case, we also want to use the loaded name.
325 * Otherwise, what happens is that the the plural name will lose 334 * Otherwise, what happens is that the the plural name will lose
326 * information (appear as just 'hearts' and not 'goblins heart') 335 * information (appear as just 'hearts' and not 'goblins heart')
327 */ 336 */
328 if (arch && name != arch->object::name && name_pl == arch->object::name_pl) 337 if (arch && name != arch->object::name && name_pl == arch->object::name_pl)
329 name_pl = 0; 338 name_pl = 0;
330 339
331 if (!name_pl) 340 if (!name_pl)
332 name_pl = name; 341 name_pl = name;
333 342
334 /* objects now have a materialname. try to patch it in */ 343 /* objects now have a materialname. try to patch it in */
335 if (!(is_weapon () && level > 0)) 344 if (material == MATERIAL_NULL && !(is_weapon () && level > 0))
336 set_materialname (this, map ? map->difficulty : 5, 0); 345 select_material (this, map ? map->difficulty : 5);
346
347 if (speed < 0.)
348 {
349 flag [FLAG_RANDOM_SPEED] = true;
350 speed = -speed;
351 // speed_left will be randomised in instantiate () and copy_to ()
352 }
337 353
338 /* only do these when program is first run - a bit 354 /* only do these when program is first run - a bit
339 * excessive to do this at every run - most of this is 355 * excessive to do this at every run - most of this is
340 * really just to catch any errors - program will still run, but 356 * really just to catch any errors - program will still run, but
341 * not in the ideal fashion. 357 * not in the ideal fashion.
… …
388 if (ip > 2 * item_power && ip > (item_power + 3)) 404 if (ip > 2 * item_power && ip > (item_power + 3))
389 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power); 405 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power);
390#endif 406#endif
391 } 407 }
392 408
393 /* old style spellcasting object (pretty common) - need to load in the appropiate object */ 409 /* old style spellcasting object (pretty common) - need to load in the appropriate object */
394 /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */ 410 /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */
395 if ((type == ROD 411 if ((type == ROD
396 || type == WAND 412 || type == WAND
397 || type == SCROLL 413 || type == SCROLL
398 || type == HORN 414 || type == HORN
… …
407 // TODO: fix firewall object on map 423 // TODO: fix firewall object on map
408 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal' 424 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal'
409 * in that spell was stored in sp. 425 * in that spell was stored in sp.
410 */ 426 */
411 //LOG (llevError, "old spellcasting object found: %s", debug_desc ()); 427 //LOG (llevError, "old spellcasting object found: %s", debug_desc ());
412 object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]); 428 object *tmp = archetype::get (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]);
413 insert_ob_in_ob (tmp, this); 429 insert_ob_in_ob (tmp, this);
414 randomitems = 0; 430 randomitems = 0;
415 } 431 }
416 432
417 /* spellbooks & runes use slaying. But not to arch name, but to spell name */ 433 /* spellbooks & runes use slaying. But not to arch name, but to spell name */
… …
423 randomitems = 0; /* So another spell isn't created for this object */ 439 randomitems = 0; /* So another spell isn't created for this object */
424 /* without this, value is all screwed up */ 440 /* without this, value is all screwed up */
425 value = arch->value * inv->value; 441 value = arch->value * inv->value;
426 } 442 }
427 443
428 if (QUERY_FLAG (this, FLAG_MONSTER)) 444 if (this->flag [FLAG_MONSTER])
429 { 445 {
430 if (stats.hp > stats.maxhp) 446 if (stats.hp > stats.maxhp)
431 { 447 {
432 LOG (llevInfo, "ITEMBUG: monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp); 448 LOG (llevInfo, "ITEMBUG: monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp);
433 stats.maxhp = stats.hp; 449 stats.maxhp = stats.hp;
… …
436 /* The archs just need to be updated for this */ 452 /* The archs just need to be updated for this */
437 if (move_type == 0) 453 if (move_type == 0)
438 move_type = MOVE_WALK; 454 move_type = MOVE_WALK;
439 } 455 }
440 456
441 if ((QUERY_FLAG (this, FLAG_GENERATOR) && QUERY_FLAG (this, FLAG_CONTENT_ON_GEN)) || type == CREATOR || type == CONVERTER) 457 if ((this->flag [FLAG_GENERATOR] && this->flag [FLAG_CONTENT_ON_GEN]) || type == CREATOR || type == CONVERTER)
442 /* Object will duplicate it's content as part of the 458 /* Object will duplicate it's content as part of the
443 * generation process. To do this, we must flag inventory 459 * generation process. To do this, we must flag inventory
444 * so it remains unevaluated concerning the randomitems and 460 * so it remains unevaluated concerning the randomitems and
445 * the living (a demonlord shouldn't cast from inside generator!) 461 * the living (a demonlord shouldn't cast from inside generator!)
446 */ 462 */
… …
468 } 484 }
469 485
470 // if the object has an animation, try to provide a default face 486 // if the object has an animation, try to provide a default face
471 if (has_anim ()) 487 if (has_anim ())
472 { 488 {
473 const animation &anim_ob = anim ();
474
475 if (anim_speed) 489 if (anim_speed)
476 // if this item is time-animated, force the last frame 490 // if this item is time-animated, force the last frame
477 animate_object (this, 0); 491 animate_object (this, 0);
478 else if (flag [FLAG_MONSTER]) 492 else if (flag [FLAG_MONSTER])
479 // if it is a monster, set appropriate facing 493 // if it is a monster, set appropriate facing
480 animate_object (this, direction); 494 animate_object (this, direction);
481 } 495 }
482} 496}
483 497
484static void 498static void
485set_move (MoveType &mt, const char *str) 499set_move (MoveType &mt, object_thawer &f)
486{ 500{
487 static const struct flagstr { 501 static const struct flagstr {
488 const char *name; 502 const char *name;
489 MoveType flags; 503 MoveType flags;
490 } move_flags[] = { 504 } move_flags[] = {
… …
496 { "boat" , MOVE_BOAT }, 510 { "boat" , MOVE_BOAT },
497 { "ship" , MOVE_SHIP }, 511 { "ship" , MOVE_SHIP },
498 { "all" , MOVE_ALL }, 512 { "all" , MOVE_ALL },
499 }; 513 };
500 514
501 if (!str) 515 const char *str = f.get_str ();
502 {
503 mt = 0;
504 return;
505 }
506 516
507 if (isdigit (*str)) 517 if (!*str || isdigit (*str))
508 { 518 {
509 mt = atoi (str); 519 mt = atoi (str);
510 return; 520 return;
511 } 521 }
512 522
513 mt = 0; 523 mt = 0;
514 524
515 for (str = strtok ((char *) str, " "); str; str = strtok (0, " ")) 525 for (str = strtok ((char *)str, " "); str; str = strtok (0, " "))
516 { 526 {
517 bool negate = 0; 527 bool negate = 0;
518 528
519 if (*str == '-') 529 if (*str == '-')
520 { 530 {
521 negate = 1; 531 negate = 1;
522 str++; 532 str++;
523 } 533 }
524 534
525 for (const flagstr *f = move_flags; f < move_flags + sizeof (move_flags) / sizeof (move_flags [0]); ++f) 535 for (const flagstr *f = move_flags; f < move_flags + array_length (move_flags); ++f)
526 { 536 {
527 if (!strcmp (f->name, str)) 537 if (!strcmp (f->name, str))
528 { 538 {
529 if (negate) 539 if (negate)
530 mt &= ~f->flags; 540 mt &= ~f->flags;
… …
547 557
548bool 558bool
549object::parse_kv (object_thawer &f) 559object::parse_kv (object_thawer &f)
550{ 560{
551 object *op_inv = inv; 561 object *op_inv = inv;
552 key_value *last_kv = key_values;
553 562
554 for (;;) 563 for (;;)
555 { 564 {
556 switch (f.kw) 565 switch (f.kw)
557 { 566 {
558 case KW_uuid: 567 case KW_uuid:
559 if (const char *s = f.get_str ())
560 if (!uuid.parse (s)) 568 if (!uuid.parse (f.get_str ()))
561 { 569 {
562 f.parse_warn ("unparseable uuid"); 570 f.parse_warn ("unparseable uuid");
563 uuid = UUID::gen (); 571 uuid = UUID::gen ();
564 } 572 }
565 break; 573 break;
566 574
567 case KW_oid: 575 case KW_oid:
568 f.get (this, f.get_sint32 ()); 576 f.get (this, f.get_sint32 ());
569 break; 577 break;
… …
587 // was: insert_ob_in_ob (tmp, op); 595 // was: insert_ob_in_ob (tmp, op);
588 // but manually adding it can improve map loading times a lot 596 // but manually adding it can improve map loading times a lot
589 // also, appending instead of prepending keeps the 597 // also, appending instead of prepending keeps the
590 // save ordering the same between repeated load/saves. 598 // save ordering the same between repeated load/saves.
591 // and finally we do not want any funny effects 599 // and finally we do not want any funny effects
592 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL); 600 tmp->clr_flag (FLAG_OBJ_ORIGINAL);
593 CLEAR_FLAG (tmp, FLAG_REMOVED); 601 tmp->clr_flag (FLAG_REMOVED);
594 602
595 if (!op_inv) 603 if (!op_inv)
596 { 604 {
597 inv = tmp; 605 inv = tmp;
598 tmp->above = 0; 606 tmp->above = 0;
… …
631 f.delayed_deref (this, owner, f.get_str ()); 639 f.delayed_deref (this, owner, f.get_str ());
632 break; 640 break;
633 641
634 case KW_animation: 642 case KW_animation:
635 { 643 {
636 CLEAR_FLAG (this, FLAG_ANIMATE); 644 clr_flag (FLAG_ANIMATE);
637 animation_id = 0; 645 animation_id = 0;
638 646
639 const char *str = f.get_str (); 647 if (f.has_value () && (animation_id = animation::find (f.get_str ()).number))
640 if (str && (animation_id = find_animation (str)))
641 SET_FLAG (this, FLAG_ANIMATE); //TODO: should not be forced to true here 648 set_flag (FLAG_ANIMATE); //TODO: should not be forced to true here
642 } 649 }
643 break; 650 break;
644 651
645 case KW_last_heal: f.get (last_heal); break; 652 case KW_last_heal: f.get (last_heal); break;
646 case KW_last_sp: f.get (last_sp); break; 653 case KW_last_sp: f.get (last_sp); break;
647 case KW_last_grace: f.get (last_grace); break; 654 case KW_last_grace: f.get (last_grace); break;
648 case KW_last_eat: f.get (last_eat); break; 655 case KW_last_eat: f.get (last_eat); break;
656 case KW_sl:
649 case KW_speed_left: f.get (speed_left); break; 657 case KW_speed_left: f.get (speed_left); break;
650 658
651 case KW_speed: 659 case KW_speed:
652 f.get (speed); 660 f.get (speed);
653 661
… …
662 move_slow |= MOVE_WALK; 670 move_slow |= MOVE_WALK;
663 f.get (move_slow_penalty); 671 f.get (move_slow_penalty);
664 break; 672 break;
665 673
666 case KW_face: 674 case KW_face:
667 face = face_find (f.get_str ()); 675 face = f.has_value () ? face_find (f.get_str ()) : blank_face;
668 break; 676 break;
669 677
670 case KW_sound: 678 case KW_sound:
679 if (f.has_value ())
680 {
671 sound = sound_find (f.get_str ()); 681 sound = sound_find (f.get_str ());
672 if (!sound) 682 if (!sound)
673 f.parse_warn ("sound not found"); 683 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
684 }
685 else
686 sound = 0;
674 break; 687 break;
675 688
676 case KW_sound_destroy: 689 case KW_sound_destroy:
690 if (f.has_value ())
691 {
677 sound_destroy = sound_find (f.get_str ()); 692 sound_destroy = sound_find (f.get_str ());
678 if (!sound_destroy) 693 if (!sound_destroy)
679 f.parse_warn ("sound not found"); 694 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
695 }
696 else
697 sound_destroy = 0;
680 break; 698 break;
681 699
682 case KW_x: f.get (x); break; 700 case KW_x: f.get (x); break;
683 case KW_y: f.get (y); break; 701 case KW_y: f.get (y); break;
684 702
… …
725 case KW_invisible: f.get (invisible); break; 743 case KW_invisible: f.get (invisible); break;
726 case KW_magic: f.get (magic); break; 744 case KW_magic: f.get (magic); break;
727 case KW_state: f.get (state); break; 745 case KW_state: f.get (state); break;
728 case KW_move_slow_penalty: f.get (move_slow_penalty); break; 746 case KW_move_slow_penalty: f.get (move_slow_penalty); break;
729 case KW_material: f.get (materials); break; //TODO: nuke 747 case KW_material: f.get (materials); break; //TODO: nuke
730 case KW_materialname: f.get (materialname); break; 748 case KW_materialname: f.get (material); break;
731 749
732 /* These are the new values */ 750 /* These are the new values */
733 case KW_move_block: set_move (move_block, f.get_str ()); break; 751 case KW_move_block: set_move (move_block, f); break;
734 case KW_move_allow: set_move (move_allow, f.get_str ()); break; 752 case KW_move_allow: set_move (move_allow, f); break;
735 case KW_move_type: set_move (move_type, f.get_str ()); break; 753 case KW_move_type: set_move (move_type , f); break;
736 case KW_move_on: set_move (move_on, f.get_str ()); break; 754 case KW_move_on: set_move (move_on , f); break;
737 case KW_move_off: set_move (move_off, f.get_str ()); break; 755 case KW_move_off: set_move (move_off , f); break;
738 case KW_move_slow: set_move (move_slow, f.get_str ()); break; 756 case KW_move_slow: set_move (move_slow , f); break;
739
740 /* These are all legacy - any new objects should use the move_ .. values */
741 case KW_no_pass:
742 {
743 if (f.get_sint32 ())
744 move_block = MOVE_ALL;
745 else
746 move_block = 0;
747 }
748
749 break;
750
751 /* These are all legacy - any new objects should use the move_ .. values */
752 case KW_walk_on:
753 {
754 if (f.get_sint32 ())
755 move_on |= MOVE_WALK;
756 else
757 move_on &= ~MOVE_WALK;
758 }
759
760 break;
761
762 /* These are all legacy - any new objects should use the move_ .. values */
763 case KW_walk_off:
764 {
765 if (f.get_sint32 ())
766 move_off |= MOVE_WALK;
767 else
768 move_off &= ~MOVE_WALK;
769 }
770 break;
771
772 /* These are all legacy - any new objects should use the move_ .. values */
773 case KW_fly_on:
774 {
775 if (f.get_sint32 ())
776 move_on |= MOVE_FLY_LOW;
777 else
778 move_on &= ~MOVE_FLY_LOW;
779 }
780 break;
781
782 /* These are all legacy - any new objects should use the move_ .. values */
783 case KW_fly_off:
784 {
785 if (f.get_sint32 ())
786 move_off |= MOVE_FLY_LOW;
787 else
788 move_off &= ~MOVE_FLY_LOW;
789 }
790 break;
791 757
792 //TODO: remove these after converting archetypes 758 //TODO: remove these after converting archetypes
793 case KW_can_use_wand: 759 case KW_can_use_wand:
794 GET_FLAG (this, FLAG_USE_RANGE); 760 GET_FLAG (this, FLAG_USE_RANGE);
795 break; 761 break;
796 762
797 /* These are all legacy - any new objects should use the move_ .. values */
798 case KW_flying:
799 {
800 if (f.get_sint32 ())
801 move_type |= MOVE_FLY_LOW;
802 else
803 move_type &= ~MOVE_FLY_LOW;
804 }
805 break;
806
807
808 case KW_identified: 763 case KW_identified:
809 GET_FLAG (this, FLAG_IDENTIFIED); 764 GET_FLAG (this, FLAG_IDENTIFIED);
810 //TODO: move to check_object or so 765 //TODO: move to check_object or so
811 if (QUERY_FLAG (this, FLAG_IDENTIFIED)) 766 if (this->flag [FLAG_IDENTIFIED])
812 CLEAR_FLAG (this, FLAG_KNOWN_MAGICAL); 767 this->clr_flag (FLAG_KNOWN_MAGICAL);
813 768
814 break; 769 break;
815 770
816 case KW_friendly: 771 case KW_friendly:
817 if (f.get_bool ()) 772 if (f.get_bool ())
… …
844 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break; 799 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break;
845 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break; 800 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break;
846 case KW_hitback: GET_FLAG (this, FLAG_HITBACK); break; 801 case KW_hitback: GET_FLAG (this, FLAG_HITBACK); break;
847 case KW_startequip: GET_FLAG (this, FLAG_STARTEQUIP); break; 802 case KW_startequip: GET_FLAG (this, FLAG_STARTEQUIP); break;
848 case KW_blocksview: GET_FLAG (this, FLAG_BLOCKSVIEW); break; 803 case KW_blocksview: GET_FLAG (this, FLAG_BLOCKSVIEW); break;
804 case KW_is_transparent_floor: GET_FLAG (this, FLAG_IS_TRANSPARENT_FLOOR); break;
849 case KW_undead: GET_FLAG (this, FLAG_UNDEAD); break; 805 case KW_undead: GET_FLAG (this, FLAG_UNDEAD); break;
850 case KW_scared: GET_FLAG (this, FLAG_SCARED); break; 806 case KW_scared: GET_FLAG (this, FLAG_SCARED); break;
851 case KW_unaggressive: GET_FLAG (this, FLAG_UNAGGRESSIVE); break; 807 case KW_unaggressive: GET_FLAG (this, FLAG_UNAGGRESSIVE); break;
852 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break; 808 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break;
853 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break; 809 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break;
854 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break; 810 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break;
855 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break; 811 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break;
856 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break; 812 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break;
857 case KW_no_fix_player: GET_FLAG (this, FLAG_NO_FIX_PLAYER); break;
858 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break; 813 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break;
859 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break; 814 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break;
860 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break; 815 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break;
861 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break; 816 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break;
862 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break; 817 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break;
… …
906 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break; 861 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break;
907 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break; 862 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break;
908 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break; 863 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break;
909 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break; 864 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break;
910 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break; 865 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break;
866 case KW_random_speed: GET_FLAG (this, FLAG_RANDOM_SPEED); break;
867 case KW_is_quad: GET_FLAG (this, FLAG_IS_QUAD); break;
911 868
912 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break; 869 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break;
913 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break; 870 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break;
914 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break; 871 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break;
915 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break; 872 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break;
… …
990 add_link (map, connected); 947 add_link (map, connected);
991 } 948 }
992 break; 949 break;
993 950
994 case KW_randomitems: 951 case KW_randomitems:
995 if (f.get_str ()) 952 if (f.has_value ())
996 { 953 {
997 randomitems = 954 randomitems =
998 loading_arch 955 loading_arch
999 ? treasurelist::get (f.get_str ()) 956 ? treasurelist::get (f.get_str ())
1000 : treasurelist::find (f.get_str ()); 957 : treasurelist::find (f.get_str ());
… …
1027 984
1028 f.next (); 985 f.next ();
1029 return true; 986 return true;
1030 987
1031 case KW_ERROR: 988 case KW_ERROR:
1032 // append as key value pair (do not use kv_set as it prepends)
1033 // we also do not even try to find old values, duplicate keys stay duplicate 989 // we do not even try to find old values, duplicate keys stay duplicate
1034 { 990 // the list gets reversed after loading
1035 key_value *kv = new key_value; 991 kv.add (shstr (f.kw_str), shstr (f.value));
1036
1037 kv->next = 0;
1038 kv->key = shstr (f.kw_str);
1039 kv->value = shstr (f.value);
1040
1041 if (!last_kv)
1042 key_values = last_kv = kv;
1043 else
1044 {
1045 while (last_kv->next)
1046 last_kv = last_kv->next;
1047
1048 last_kv->next = kv;
1049 last_kv = kv;
1050 }
1051 }
1052 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D
1053 break; 992 break;
1054 993
1055 default: 994 default:
1056 if (!f.parse_error ("object", name)) 995 if (!f.parse_error ("object", name))
1057 return false; 996 return false;
… …
1069 1008
1070 archetype *arch = archetype::find (f.get_str ()); 1009 archetype *arch = archetype::find (f.get_str ());
1071 1010
1072 if (!arch) 1011 if (!arch)
1073 { 1012 {
1074 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ()); 1013 LOG (llevError, "object referring to nonexistent archetype '%s'.\n", f.get_str ());
1075 arch = archetype::find (shstr_earthwall); 1014 arch = archetype::find (shstr_earthwall);
1076 } 1015 }
1077 1016
1078 assert (arch); //D maybe use exception handling of sorts? 1017 assert (arch); //D maybe use exception handling of sorts?
1079 1018
… …
1087 if (!op->parse_kv (f)) 1026 if (!op->parse_kv (f))
1088 { 1027 {
1089 op->destroy (); 1028 op->destroy ();
1090 return 0; 1029 return 0;
1091 } 1030 }
1031
1032 // the loader reverses the ordering of kv-pairs, so we reverse it again after loading
1033 // that greatly simplifies the loading code.
1034 op->kv.reverse ();
1092 1035
1093 op->post_load_check (); 1036 op->post_load_check ();
1094 return op; 1037 return op;
1095} 1038}
1096 1039
… …
1101 * override values and in c_wiz to mutate values. 1044 * override values and in c_wiz to mutate values.
1102 */ 1045 */
1103int 1046int
1104set_variable (object *op, char *buf) 1047set_variable (object *op, char *buf)
1105{ 1048{
1106 object_thawer f (buf, (AV *)0); 1049 object_thawer f (format ("%s\nend", buf), (AV *)0);
1107 1050
1108 return op->parse_kv (f); 1051 return op->parse_kv (f);
1109} 1052}
1110 1053
1111// compare *op against *arch and output differences 1054// compare *op against *arch and output differences
… …
1131 KW_NULL, 1074 KW_NULL,
1132 KW_applied, 1075 KW_applied,
1133 KW_unpaid, 1076 KW_unpaid,
1134 KW_can_use_shield, 1077 KW_can_use_shield,
1135 KW_no_pick, 1078 KW_no_pick,
1136 KW_NULL, // walk_on 1079 KW_is_transparent_floor,
1080 /* 10 */
1137 KW_NULL, // no_pass 1081 KW_NULL, // no_pass
1138 /* 10 */
1139 KW_is_animated, 1082 KW_is_animated,
1140 KW_NULL, // slow_move 1083 KW_NULL, // slow_move
1141 KW_NULL, // flying 1084 KW_NULL, // flying
1142 KW_monster, 1085 KW_monster,
1143 KW_friendly, 1086 KW_friendly,
1144 KW_generator, 1087 KW_generator,
1145 KW_is_thrown, 1088 KW_is_thrown,
1146 KW_auto_apply, 1089 KW_auto_apply,
1147 KW_treasure_env, 1090 KW_treasure_env,
1091 /* 20 */
1148 KW_player_sold, 1092 KW_player_sold,
1149 /* 20 */
1150 KW_see_invisible, 1093 KW_see_invisible,
1151 KW_can_roll, 1094 KW_can_roll,
1152 KW_overlay_floor, 1095 KW_overlay_floor,
1153 KW_is_turnable, 1096 KW_is_turnable,
1154 KW_NULL, // walk_off 1097 KW_NULL, // walk_off
1155 KW_NULL, // fly_on 1098 KW_NULL, // fly_on
1156 KW_NULL, // fly_off 1099 KW_NULL, // fly_off
1157 KW_is_used_up, 1100 KW_is_used_up,
1158 KW_identified, 1101 KW_identified,
1102 /* 30 */
1159 KW_reflecting, 1103 KW_reflecting,
1160 /* 30 */
1161 KW_changing, 1104 KW_changing,
1162 KW_splitting, 1105 KW_splitting,
1163 KW_hitback, 1106 KW_hitback,
1164 KW_startequip, 1107 KW_startequip,
1165 KW_blocksview, 1108 KW_blocksview,
1166 KW_undead, 1109 KW_undead,
1167 KW_scared, 1110 KW_scared,
1168 KW_unaggressive, 1111 KW_unaggressive,
1169 KW_reflect_missile, 1112 KW_reflect_missile,
1113 /* 40 */
1170 KW_reflect_spell, 1114 KW_reflect_spell,
1171 /* 40 */
1172 KW_no_magic, 1115 KW_no_magic,
1173 KW_no_fix_player, 1116 KW_NULL,
1174 KW_is_lightable, 1117 KW_is_lightable,
1175 KW_tear_down, 1118 KW_tear_down,
1176 KW_run_away, 1119 KW_run_away,
1177 KW_NULL, // pass_thru 1120 KW_NULL, // pass_thru
1178 KW_NULL, // an_pass_thru 1121 KW_NULL, // an_pass_thru
1179 KW_pick_up, 1122 KW_pick_up,
1180 KW_unique, 1123 KW_unique,
1124 /* 50 */
1181 KW_no_drop, 1125 KW_no_drop,
1182 /* 50 */
1183 KW_NULL, // wizcast 1126 KW_NULL, // wizcast
1184 KW_can_cast_spell, 1127 KW_can_cast_spell,
1185 KW_can_use_scroll, 1128 KW_can_use_scroll,
1186 KW_can_use_range, 1129 KW_can_use_range,
1187 KW_can_use_bow, 1130 KW_can_use_bow,
1188 KW_can_use_armour, 1131 KW_can_use_armour,
1189 KW_can_use_weapon, 1132 KW_can_use_weapon,
1190 KW_can_use_ring, 1133 KW_can_use_ring,
1191 KW_has_ready_range, 1134 KW_has_ready_range,
1135 /* 60 */
1192 KW_has_ready_bow, 1136 KW_has_ready_bow,
1193 /* 60 */
1194 KW_xrays, 1137 KW_xrays,
1195 KW_NULL, 1138 KW_NULL,
1196 KW_is_floor, 1139 KW_is_floor,
1197 KW_lifesave, 1140 KW_lifesave,
1198 KW_no_strength, 1141 KW_no_strength,
1199 KW_sleep, 1142 KW_sleep,
1200 KW_stand_still, 1143 KW_stand_still,
1201 KW_random_move, 1144 KW_random_move,
1202 KW_only_attack, 1145 KW_only_attack,
1146 /* 70 */
1203 KW_confused, 1147 KW_confused,
1204 /* 70 */
1205 KW_stealth, 1148 KW_stealth,
1206 KW_NULL, 1149 KW_NULL,
1207 KW_NULL, 1150 KW_NULL,
1208 KW_cursed, 1151 KW_cursed,
1209 KW_damned, 1152 KW_damned,
1210 KW_see_anywhere, 1153 KW_see_anywhere,
1211 KW_known_magical, 1154 KW_known_magical,
1212 KW_known_cursed, 1155 KW_known_cursed,
1213 KW_can_use_skill, 1156 KW_can_use_skill,
1157 /* 80 */
1214 KW_been_applied, 1158 KW_been_applied,
1215 /* 80 */
1216 KW_has_ready_scroll, 1159 KW_has_ready_scroll,
1217 KW_can_use_rod, 1160 KW_can_use_rod,
1218 KW_precious, 1161 KW_precious,
1219 KW_can_use_horn, 1162 KW_can_use_horn,
1220 KW_make_invisible, 1163 KW_make_invisible,
1221 KW_inv_locked, 1164 KW_inv_locked,
1222 KW_is_wooded, 1165 KW_is_wooded,
1223 KW_is_hilly, 1166 KW_is_hilly,
1224 KW_has_ready_skill, 1167 KW_has_ready_skill,
1168 /* 90 */
1225 KW_has_ready_weapon, 1169 KW_has_ready_weapon,
1226 /* 90 */
1227 KW_no_skill_ident, 1170 KW_no_skill_ident,
1228 KW_is_blind, 1171 KW_is_blind,
1229 KW_can_see_in_dark, 1172 KW_can_see_in_dark,
1230 KW_is_cauldron, 1173 KW_is_cauldron,
1231 KW_NULL, 1174 KW_NULL,
1232 KW_no_steal, 1175 KW_no_steal,
1233 KW_one_hit, 1176 KW_one_hit,
1234 KW_NULL, 1177 KW_NULL,
1235 KW_berserk, 1178 KW_berserk,
1179 /* 100 */
1236 KW_neutral, 1180 KW_neutral,
1237 /* 100 */
1238 KW_no_attack, 1181 KW_no_attack,
1239 KW_no_damage, 1182 KW_no_damage,
1240 KW_obj_original, 1183 KW_obj_original,
1241 KW_NULL, 1184 KW_random_speed,
1242 KW_activate_on_push, 1185 KW_activate_on_push,
1243 KW_activate_on_release, 1186 KW_activate_on_release,
1244 KW_is_water, 1187 KW_is_water,
1245 KW_use_content_on_gen, 1188 KW_use_content_on_gen,
1246 KW_NULL, 1189 KW_NULL,
1190 /* 110 */
1247 KW_is_buildable, 1191 KW_is_buildable,
1248 /* 110 */
1249 KW_destroy_on_death, 1192 KW_destroy_on_death,
1250 KW_NULL, 1193 KW_NULL,
1251 }; 1194 };
1252 1195
1196 // obj_original is the only commonly differing flag between archetype
1197 // and object, so special-case it here to be able to skip the loop
1198 static const struct flagmask : object::flags_t
1199 {
1200 flagmask ()
1201 {
1202 for (int i = 0; i < NUM_FLAGS; i++)
1203 if (flag_names [i])
1204 set (i);
1205 }
1206 } flagmask;
1207
1253 /* This saves the key/value lists. We do it first so that any 1208 /* This saves the key/value lists. We do it first so that any
1254 * keys that match field names will be overwritten by the loader. 1209 * keys that match field names will be overwritten by the loader.
1255 */ 1210 */
1256 for (key_value *kv = op->key_values; kv; kv = kv->next) 1211 for (key_value *kv = op->kv.first; kv; kv = kv->next)
1257 if (!arch->key_values || arch->kv (kv->key) != kv->value) 1212 if (arch->kv.empty () || arch->kv [kv->key] != kv->value)
1258 f.put (kv->key, kv->value); 1213 f.put (kv->key, kv->value);
1259 1214
1260 if (op->uuid) 1215 if (op->uuid)
1261 { 1216 {
1262 // highly optimised - this is often 25% of all data written 1217 // highly optimised - this is often 25% of all data written
… …
1269 *ptr++ = '\n'; 1224 *ptr++ = '\n';
1270 1225
1271 f.alloc (ptr - cur); 1226 f.alloc (ptr - cur);
1272 } 1227 }
1273 1228
1274#define CMP_OUT(v) if (expect_false (op->v != arch->v)) f.put (KW_ ## v, op->v) 1229#define CMP_OUT(v) if (expect_false (op->v != arch->v)) f.put (KW (v), op->v)
1275#define CMP_OUT2(k,v) if (expect_false (op->v != arch->v)) f.put (KW_ ## k, op->v) 1230#define CMP_OUT2(k,v) if (expect_false (op->v != arch->v)) f.put (KW (k), op->v)
1276 1231
1277 CMP_OUT (x); 1232 CMP_OUT (x);
1278 CMP_OUT (y); 1233 CMP_OUT (y);
1279 1234
1280 CMP_OUT (type); 1235 CMP_OUT (type);
1281 CMP_OUT (subtype); 1236 CMP_OUT (subtype);
1282 CMP_OUT (direction); 1237 CMP_OUT (direction);
1283 1238
1284 CMP_OUT (name); 1239 CMP_OUT (name);
1285 CMP_OUT (name_pl); 1240 CMP_OUT (name_pl);
1286
1287 CMP_OUT (speed); 1241 CMP_OUT (speed);
1288 CMP_OUT (speed_left); 1242
1243 // speed_left is a major time-burner, and has good locality, so
1244 // we use a simple lookup-cache to avoid the very slow printf.
1245 if (op->speed_left != arch->speed_left)
1246 {
1247 static double last_speed_left = 0.;
1248 static char last_speed_left_str [256] = "sl 0\n";
1249 static int last_speed_left_len = sizeof ("sl 0\n") - 1;
1250
1251 if (last_speed_left != op->speed_left)
1252 {
1253 last_speed_left = op->speed_left;
1254 // .7g loses precision even for float, but gives nice round numbers and smaller files
1255 // maybe hex format or a raw binary dump of the float is good enough, more exact, and much faster?
1256 // (printf is typically very slow)
1257 last_speed_left_len = sizeof ("sl ") - 1
1258 + sprintf (last_speed_left_str + sizeof ("sl ") - 1, "%.7g\n", last_speed_left);
1259 }
1260
1261 f.add (last_speed_left_str, last_speed_left_len);
1262 }
1289 1263
1290 CMP_OUT (title); 1264 CMP_OUT (title);
1291 CMP_OUT (race); 1265 CMP_OUT (race);
1292 CMP_OUT (slaying); 1266 CMP_OUT (slaying);
1293 CMP_OUT (skill); 1267 CMP_OUT (skill);
1294 1268
1295 CMP_OUT (tag); 1269 CMP_OUT (tag);
1296 CMP_OUT (custom_name); 1270 CMP_OUT (custom_name);
1297 1271
1298 if (object *owner = op->owner) 1272 if (object *owner = op->owner)
1299 f.put (KW_owner, static_cast<const char *>(owner->ref ())); 1273 if (const char *ref = owner->ref ())
1274 f.put (KW(owner), ref);
1300 1275
1301 // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved 1276 // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved
1302 1277
1303 CMP_OUT (other_arch); 1278 CMP_OUT (other_arch);
1304 1279
1305 if (op->msg != arch->msg ) f.put (KW_msg , KW_endmsg , op->msg ); 1280 if (op->msg != arch->msg ) f.put (KW(msg) , KW(endmsg) , op->msg );
1306 if (op->lore != arch->lore) f.put (KW_lore, KW_endlore, op->lore); 1281 if (op->lore != arch->lore) f.put (KW(lore), KW(endlore), op->lore);
1307 1282
1308 if (op->face != arch->face ) f.put (KW_face , op->face ? &faces [op->face ] : 0); 1283 if (op->face != arch->face ) f.put (KW(face) , op->face ? &faces [op->face ] : 0);
1309 if (op->sound != arch->sound ) f.put (KW_sound , op->sound ? &faces [op->sound ] : 0); 1284 if (op->sound != arch->sound ) f.put (KW(sound) , op->sound ? &faces [op->sound ] : 0);
1310 if (op->sound_destroy != arch->sound_destroy) f.put (KW_sound_destroy, op->sound_destroy ? &faces [op->sound_destroy] : 0); 1285 if (op->sound_destroy != arch->sound_destroy) f.put (KW(sound_destroy), op->sound_destroy ? &faces [op->sound_destroy] : 0);
1311 1286
1312 if (op->animation_id != arch->animation_id) 1287 if (op->animation_id != arch->animation_id)
1313 if (op->has_anim ()) 1288 if (op->has_anim ())
1314 f.put (KW_animation, op->anim ().name); 1289 f.put (KW(animation), op->anim ().name);
1315 else 1290 else
1316 { 1291 {
1317 f.put (KW_animation, (const char *)0); 1292 f.put (KW(animation));
1318 op->flag [FLAG_ANIMATE] = false; // TODO: why force to false here? 1293 op->flag [FLAG_ANIMATE] = false; // TODO: why force to false here?
1319 } 1294 }
1320 1295
1321 CMP_OUT2 (str, stats.Str); 1296 CMP_OUT2 (str, stats.Str);
1322 CMP_OUT2 (dex, stats.Dex); 1297 CMP_OUT2 (dex, stats.Dex);
… …
1347 CMP_OUT (attack_movement); 1322 CMP_OUT (attack_movement);
1348 CMP_OUT (nrof); 1323 CMP_OUT (nrof);
1349 CMP_OUT (level); 1324 CMP_OUT (level);
1350 CMP_OUT (attacktype); 1325 CMP_OUT (attacktype);
1351 1326
1352 // using memcmp here seems to be a loss - us gcc vectorising? 1327 // using memcmp here seems to be a loss - is gcc vectorising?
1353 for (int i = 0; i < NROFATTACKS; i++) 1328 for (int i = 0; i < NROFATTACKS; i++)
1354 if (expect_false (op->resist[i] != arch->resist[i])) 1329 if (expect_false (op->resist[i] != arch->resist[i]))
1355 f.put (resist_save[i], op->resist[i]); 1330 f.put (resist_save[i], op->resist[i]);
1356 1331
1357 CMP_OUT (path_attuned); 1332 CMP_OUT (path_attuned);
1358 CMP_OUT (path_repelled); 1333 CMP_OUT (path_repelled);
1359 CMP_OUT (path_denied); 1334 CMP_OUT (path_denied);
1335
1360 CMP_OUT2 (material, materials);//TODO: nuke 1336 CMP_OUT2 (material, materials);//TODO: nuke
1361 CMP_OUT (materialname); 1337 if (op->material != arch->material)
1338 f.put (KW(materialname), op->material->name);
1339
1362 CMP_OUT (value); 1340 CMP_OUT (value);
1363 CMP_OUT (carrying); 1341 CMP_OUT (carrying);
1364 CMP_OUT (weight); 1342 CMP_OUT (weight);
1365 CMP_OUT (invisible); 1343 CMP_OUT (invisible);
1366 CMP_OUT (state); 1344 CMP_OUT (state);
… …
1371 CMP_OUT (last_eat); 1349 CMP_OUT (last_eat);
1372 CMP_OUT (glow_radius); 1350 CMP_OUT (glow_radius);
1373 1351
1374 if (op->flag [FLAG_IS_LINKED]) 1352 if (op->flag [FLAG_IS_LINKED])
1375 if (auto (ol, op->find_link ())) 1353 if (auto (ol, op->find_link ()))
1376 f.put (KW_connected, ol->id); 1354 f.put (KW(connected), ol->id);
1377 1355
1378 CMP_OUT (randomitems); 1356 CMP_OUT (randomitems);
1357
1379 CMP_OUT2 (container, weight_limit); 1358 CMP_OUT2 (container, weight_limit);
1380 1359
1381 CMP_OUT (run_away); 1360 CMP_OUT (run_away);
1382 CMP_OUT (pick_up); 1361 CMP_OUT (pick_up);
1383 CMP_OUT (will_apply); 1362 CMP_OUT (will_apply);
… …
1398 CMP_OUT (move_on); 1377 CMP_OUT (move_on);
1399 CMP_OUT (move_off); 1378 CMP_OUT (move_off);
1400 CMP_OUT (move_slow); 1379 CMP_OUT (move_slow);
1401 CMP_OUT (move_slow_penalty); 1380 CMP_OUT (move_slow_penalty);
1402 1381
1403 // obj_original is the only commonly differing flag between archetype
1404 // and object, so special-case it here to be able to skip the loop
1405 object::flags_t diff = op->flag ^ arch->flag; 1382 object::flags_t diff = (op->flag ^ arch->flag) & flagmask;
1406 1383
1384#if stdcpp // we need gcc, sorry
1385 if (diff [FLAG_OBJ_ORIGINAL])
1386 f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? CS(1) : CS(0));
1387
1388 diff.reset (FLAG_OBJ_ORIGINAL);
1389
1390 // quickly test whether any other flags differ
1407 if (expect_true (diff.any ())) 1391 if (expect_true (diff.any ()))
1408 {
1409 if (expect_false (diff.reset (FLAG_OBJ_ORIGINAL).any ()) || 1)
1410 {
1411 // some other flags differ, too
1412 for (int i = 0; i < NUM_FLAGS; i++) 1392 for (int i = 0; i < NUM_FLAGS; i++)
1413 if (expect_false (flag_names [i] && op->flag [i] != arch->flag [i])) 1393 if (expect_false (diff [i]))
1414 f.put (flag_names [i], op->flag [i] ? "1" : "0"); 1394 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1415 } 1395#else
1416 else 1396 // use sgi extensions
1417 { 1397 for (int i = diff._Find_first (); i < diff.size (); i = diff._Find_next (i))
1418 // only obj_original differs 1398 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1419 f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? "1" : "0"); 1399#endif
1420 }
1421 }
1422 1400
1423 // save body locations. gcc's memcmp does an abysmal job when used 1401 // save body locations. gcc's memcmp does an abysmal job when used
1424 for (int i = 0; i < NUM_BODY_LOCATIONS; i++) 1402 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
1425 if (expect_false (op->slot[i].info != arch->slot[i].info)) 1403 if (expect_false (op->slot[i].info != arch->slot[i].info))
1426 f.put (body_locations[i].save_name, op->slot[i].info); 1404 f.put (body_locations[i].kw, op->slot[i].info);
1427} 1405}
1428 1406
1429/* 1407/*
1430 * Dumps all variables in an object to a file. 1408 * Dumps all variables in an object to a file.
1431 * If bit 0 of flag is set, unpaid objects will be saved. As of now, 1409 * If bit 0 of flag is set, unpaid objects will be saved. As of now,
1432 * the only place this is not set is when saving the player. 1410 * the only place this is not set is when saving the player.
1433 */ 1411 */
1434bool 1412bool
1435object::write (object_freezer &f) 1413object::write (object_freezer &f)
1436{ 1414{
1437 if (is_arch ()) 1415 if (expect_false (is_arch ()))
1438 { 1416 {
1439 f.put (KW_object, arch->archname); 1417 f.put (KW(object), arch->archname);
1440 write_diff (f, this, archetype::empty); 1418 write_diff (f, this, archetype::empty);
1441 } 1419 }
1442 else 1420 else
1443 { 1421 {
1444 f.put (KW_arch, arch->archname); 1422 f.put (KW(arch), arch->archname);
1445 write_diff (f, this, arch); 1423 write_diff (f, this, arch);
1446 } 1424 }
1447 1425
1448 for (object *tmp = inv; tmp; tmp = tmp->below) 1426 for (object *tmp = inv; tmp; tmp = tmp->below)
1449 tmp->write (f); 1427 tmp->write (f);
1450 1428
1451 f.put (this); 1429 f.put (this);
1452 f.put (KW_end); 1430 f.put (KW(end));
1453 1431
1454 return true; 1432 return true;
1455} 1433}
1456 1434
1457///////////////////////////////////////////////////////////////////////////// 1435/////////////////////////////////////////////////////////////////////////////
… …
1463{ 1441{
1464 object_thawer f (filename); 1442 object_thawer f (filename);
1465 1443
1466 for (;;) 1444 for (;;)
1467 { 1445 {
1446 coroapi::cede_to_tick ();
1447
1468 switch (f.kw) 1448 switch (f.kw)
1469 { 1449 {
1470 case KW_region: 1450 case KW_region:
1471 if (!region::read (f)) 1451 if (!region::read (f))
1472 return false; 1452 return false;

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines