ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/loader.C
(Generate patch)

Comparing deliantra/server/common/loader.C (file contents):
Revision 1.83 by root, Sat May 19 00:08:11 2007 UTC vs.
Revision 1.182 by root, Wed Nov 14 21:19:41 2018 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2018 Marc Alexander Lehmann / the Deliantra team
5 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 6 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 7 * Copyright (©) 1992 Frank Tore Johansen
7 * 8 *
8 * This program is free software; you can redistribute it and/or modify 9 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 10 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation; either version 2 of the License, or 11 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 12 * option) any later version.
12 * 13 *
13 * This program is distributed in the hope that it will be useful, 14 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 17 * GNU General Public License for more details.
17 *
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 18 *
19 * You should have received a copy of the Affero GNU General Public License
20 * and the GNU General Public License along with this program. If not, see
21 * <http://www.gnu.org/licenses/>.
22 *
22 * The authors can be reached via e-mail at <crossfire@schmorp.de> 23 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 24 */
24 25
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying
27 variable. */
28
29#include <global.h> 26#include <global.h>
30#include <loader.h>
31#include <sproto.h> 27#include <sproto.h>
32 28
33///////////////////////////////////////////////////////////////////////////// 29/////////////////////////////////////////////////////////////////////////////
30
31extern archetype *loading_arch;
32
33//+GPL
34 34
35/* This table is only necessary to convert objects that existed before the 35/* This table is only necessary to convert objects that existed before the
36 * spell object conversion to the new object. It was not practical 36 * spell object conversion to the new object. It was not practical
37 * to go through every mapping looking for every potion, rod, wand, etc 37 * to go through every mapping looking for every potion, rod, wand, etc
38 * that had a sp set and update to the new value. So this maps the 38 * that had a sp set and update to the new value. So this maps the
… …
168 "spell_magic_drain", /* 122 */ 168 "spell_magic_drain", /* 122 */
169 "spell_counterspell", /* 123 */ 169 "spell_counterspell", /* 123 */
170 "spell_disarm", /* 124 */ 170 "spell_disarm", /* 124 */
171 "spell_cure_confusion", /* 125 */ 171 "spell_cure_confusion", /* 125 */
172 "spell_restoration", /* 126 */ 172 "spell_restoration", /* 126 */
173 "was summon evil monster", /* 127 *//* Not implenented as nothing used it */ 173 "spell_summon_devil", /* 127 *//* Not implenented as nothing used it */
174 "spell_counterwall", /* 128 */ 174 "spell_counterwall", /* 128 */
175 "spell_cause_light_wounds", /* 129 */ 175 "spell_cause_light_wounds", /* 129 */
176 "spell_cause_medium_wounds", /* 130 */ 176 "spell_cause_medium_wounds", /* 130 */
177 "spell_cause_heavy_wounds", /* 131 */ 177 "spell_cause_heavy_wounds", /* 131 */
178 "spell_charm_monsters", /* 132 */ 178 "spell_charm_monsters", /* 132 */
… …
250 "spell_cause_rabies", /* 204 */ 250 "spell_cause_rabies", /* 204 */
251 "spell_glyph", /* 205 */ 251 "spell_glyph", /* 205 */
252 NULL 252 NULL
253}; 253};
254 254
255extern bool loading_arch;
256
257/* This function checks the object after it has been loaded (when we 255/* This function checks the object after it has been loaded (when we
258 * get the 'end' in the input stream). This function can be used to 256 * get the 'end' in the input stream). This function can be used to
259 * deal with legacy objects where fields may have changed. It can also be used 257 * deal with legacy objects where fields may have changed. It can also be used
260 * to check for objects to make sure there are no common errors. 258 * to check for objects to make sure there are no common errors.
261 */ 259 */
262void 260void
263object::post_load_check () 261object::post_load_check ()
264{ 262{
265 if (type >= NUM_TYPES) 263 if (type >= NUM_TYPES)
266 { 264 {
267 LOG (llevError, "%s: type out of range, resetting to 0.\n", debug_desc ()); 265 LOG (llevError, "ITEMBUG: %s: type out of range, resetting to 0.\n", debug_desc ());
268 type = 0; 266 type = 0;
269 } 267 }
270 268
271 switch (type) 269 switch (type)
272 { 270 {
271 case RANGED:
273 case BOW: 272 case BOW:
274 case WAND: 273 case WAND:
275 case ROD: 274 case ROD:
276 case HORN: 275 case HORN:
277 if (slot [body_range].info != -1) 276 if (slot [body_range].info != -1)
278 { 277 {
279 LOG (llevError, "%s: body_range %d != -1\n", debug_desc (), slot [body_range].info); 278 LOG (llevError, "ITEMBUG: %s: body_range %d != -1\n", debug_desc (), slot [body_range].info);
280 slot [body_range].info = -1; 279 slot [body_range].info = -1;
281 } 280 }
282 break; 281 break;
283 282
284 case WEAPON: 283 case WEAPON:
285 if (slot [body_combat].info != -1) 284 if (slot [body_combat].info != -1)
286 { 285 {
287 LOG (llevError, "%s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info); 286 LOG (llevError, "ITEMBUG: %s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info);
288 slot [body_combat].info = -1; 287 slot [body_combat].info = -1;
289 } 288 }
290 break; 289 break;
291 290
292 case SHIELD: 291 case SHIELD:
293 if (slot [body_shield].info != -1) 292 if (slot [body_shield].info != -1)
294 { 293 {
295 LOG (llevError, "%s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info); 294 LOG (llevError, "ITEMBUG: %s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info);
296 slot [body_shield].info = -1; 295 slot [body_shield].info = -1;
297 } 296 }
298 break; 297 break;
299 298
299 case CONTAINER:
300 if (nrof)
301 {
302 LOG (llevError, "ITEMBUG: %s: stackable container (nrof %d)\n", debug_desc (), (int)nrof);
303 nrof = 0;
304 }
305 break;
306
300 case PLAYER: 307 case PLAYER:
301 if (slot [body_shield].info != 1) 308 if (slot [body_shield].info != 1)
302 { 309 {
303 LOG (llevError, "%s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info); 310 LOG (llevError, "ITEMBUG: %s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info);
304 slot [body_shield].info = 1; 311 slot [body_shield].info = 1;
305 } 312 }
306 313
307 if (slot [body_combat].info != 1) 314 if (slot [body_combat].info != 1)
308 { 315 {
309 LOG (llevError, "%s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info); 316 LOG (llevError, "ITEMBUG: %s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info);
310 slot [body_combat].info = 1; 317 slot [body_combat].info = 1;
311 } 318 }
312 319
313 if (slot [body_range].info != 1) 320 if (slot [body_range].info != 1)
314 { 321 {
315 LOG (llevError, "%s: body_range %d != 1\n", debug_desc (), slot [body_range].info); 322 LOG (llevError, "ITEMBUG: %s: body_range %d != 1\n", debug_desc (), slot [body_range].info);
316 slot [body_range].info = 1; 323 slot [body_range].info = 1;
317 } 324 }
318 break; 325 break;
319 } 326 }
320 327
… …
323 * this isn't perfect (things won't be properly pluralised), but works to 330 * this isn't perfect (things won't be properly pluralised), but works to
324 * that degree (5 heart is still quite understandable). But the case we 331 * that degree (5 heart is still quite understandable). But the case we
325 * also have to catch is if this object is not using the normal name for 332 * also have to catch is if this object is not using the normal name for
326 * the object. In that case, we also want to use the loaded name. 333 * the object. In that case, we also want to use the loaded name.
327 * Otherwise, what happens is that the the plural name will lose 334 * Otherwise, what happens is that the the plural name will lose
328 * information (appear as just 'hearts' and not 'goblins heart') 335 * information (appear as just 'hearts' and not 'goblins heart')
329 */ 336 */
330 if (arch && name != arch->clone.name && name_pl == arch->clone.name_pl) 337 if (arch && name != arch->object::name && name_pl == arch->object::name_pl)
331 name_pl = 0; 338 name_pl = 0;
332 339
333 if (!name_pl) 340 if (!name_pl)
334 name_pl = name; 341 name_pl = name;
335 342
336 /* objects now have a materialname. try to patch it in */ 343 /* objects now have a materialname. try to patch it in */
337 if (!(is_weapon () && level > 0)) 344 if (material == MATERIAL_NULL && !(is_weapon () && level > 0))
338 set_materialname (this, map ? map->difficulty : 5, 0); 345 select_material (this, map ? map->difficulty : 5);
346
347 if (speed < 0.)
348 {
349 flag [FLAG_RANDOM_SPEED] = true;
350 speed = -speed;
351 // speed_left will be randomised in instantiate () and copy_to ()
352 }
339 353
340 /* only do these when program is first run - a bit 354 /* only do these when program is first run - a bit
341 * excessive to do this at every run - most of this is 355 * excessive to do this at every run - most of this is
342 * really just to catch any errors - program will still run, but 356 * really just to catch any errors - program will still run, but
343 * not in the ideal fashion. 357 * not in the ideal fashion.
344 */ 358 */
345 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND)) 359 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND))
346 { 360 {
347 if (!skill) 361 if (!skill)
348 LOG (llevError, "Weapon %s lacks a skill.\n", debug_desc ()); 362 LOG (llevError, "ITEMBUG: weapon %s lacks a skill.\n", debug_desc ());
349 else if ((!strcmp (skill, "one handed weapons") && slot[body_arm].info != -1) || 363 else if ((skill == shstr_one_handed_weapons && slot[body_arm].info != -1) ||
350 (!strcmp (skill, "two handed weapons") && slot[body_arm].info != -2)) 364 (skill == shstr_two_handed_weapons && slot[body_arm].info != -2))
351 LOG (llevError, "weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill); 365 LOG (llevError, "ITEMBUG: weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill);
352 } 366 }
353 367
354 /* We changed last_heal to gen_sp_armour, which is what it 368 /* We changed last_heal to gen_sp_armour, which is what it
355 * really does for many objects. Need to catch any in maps 369 * really does for many objects. Need to catch any in maps
356 * that may have an old value. 370 * that may have an old value.
… …
362 || type == AMULET || type == GIRDLE 376 || type == AMULET || type == GIRDLE
363 || type == BRACERS || type == CLOAK) 377 || type == BRACERS || type == CLOAK)
364 { 378 {
365 if (last_heal) 379 if (last_heal)
366 { 380 {
367 LOG (llevDebug, "Object %s still has last_heal set, not gen_sp_armour\n", debug_desc ()); 381 LOG (llevError, "ITEMBUG: object %s still has last_heal set, not gen_sp_armour\n", debug_desc ());
368 gen_sp_armour = last_heal; 382 gen_sp_armour = last_heal;
369 last_heal = 0; 383 last_heal = 0;
370 } 384 }
371 385
372 int ip = calc_item_power (this, 0); 386 int ip = calc_item_power (this, 0);
373 387
374 /* Legacy objects from before item power was in the game */ 388 /* Legacy objects from before item power was in the game */
375 if (!item_power && ip) 389 if (!item_power && ip)
376 { 390 {
377 if (ip > 3) 391 if (ip > 3)
378 LOG (llevDebug, "Object %s had no item power, using %d\n", debug_desc (), ip); 392 LOG (llevDebug, "ITEMBUG: Object %s had no item power, using %d\n", debug_desc (), ip);
379 393
380 item_power = ip; 394 item_power = ip;
381 } 395 }
382 396
383 /* Check for possibly bogus values. Has to meet both these criteria - 397 /* Check for possibly bogus values. Has to meet both these criteria -
384 * something that has item_power 1 is probably just fine if our calculated 398 * something that has item_power 1 is probably just fine if our calculated
385 * value is 1 or 2 - these values are small enough that hard to be precise. 399 * value is 1 or 2 - these values are small enough that hard to be precise.
386 * similarly, it item_power is 0, the first check will always pass, 400 * similarly, it item_power is 0, the first check will always pass,
387 * but not the second one. 401 * but not the second one.
388 */ 402 */
403#if 0 //TODO
389 if (ip > 2 * item_power && ip > (item_power + 3)) 404 if (ip > 2 * item_power && ip > (item_power + 3))
390 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power); 405 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power);
406#endif
391 } 407 }
392 408
393 /* Old spellcasting object - need to load in the appropiate object */ 409 /* old style spellcasting object (pretty common) - need to load in the appropriate object */
394 if ((type == ROD || type == WAND || type == SCROLL || type == HORN || type == FIREWALL || 410 /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */
411 if ((type == ROD
412 || type == WAND
413 || type == SCROLL
414 || type == HORN
415 || type == FIREWALL
395 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */ 416 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */
396 ((type == POTION || type == ALTAR) && stats.sp)) && !inv && !loading_arch) 417 || ((type == POTION || type == ALTAR) && stats.sp)) // watchout: sp = 0 is still magic bullet.
418 && !inv
419 && !loading_arch
420 && stats.sp) // watchout: old magic bullet stuff directly on the map is going to break here!
421 // TODO: at least one watchout-comments is redundant - investigate/remove
397 { 422 {
423 // TODO: fix firewall object on map
398 /* Fireall is bizarre in that spell type was stored in dam. Rest are 'normal' 424 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal'
399 * in that spell was stored in sp. 425 * in that spell was stored in sp.
400 */ 426 */
427 //LOG (llevError, "old spellcasting object found: %s", debug_desc ());
401 object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]); 428 object *tmp = archetype::get (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]);
402 insert_ob_in_ob (tmp, this); 429 insert_ob_in_ob (tmp, this);
403 randomitems = NULL; /* So another spell isn't created for this object */ 430 randomitems = 0;
404 } 431 }
405 432
406 /* spellbooks & runes use slaying. But not to arch name, but to spell name */ 433 /* spellbooks & runes use slaying. But not to arch name, but to spell name */
407 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch) 434 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch)
408 { 435 {
436 LOG (llevError, "ITEMBUG: spellbook/rune found without inv but slaying: %s", debug_desc ());
409 object *tmp = get_archetype_by_object_name (slaying); 437 object *tmp = get_archetype_by_object_name (slaying);
410 insert_ob_in_ob (tmp, this); 438 insert_ob_in_ob (tmp, this);
411 randomitems = NULL; /* So another spell isn't created for this object */ 439 randomitems = 0; /* So another spell isn't created for this object */
412 /* without this, value is all screwed up */ 440 /* without this, value is all screwed up */
413 value = arch->clone.value * inv->value; 441 value = arch->value * inv->value;
414 } 442 }
415 443
416 if (QUERY_FLAG (this, FLAG_MONSTER)) 444 if (this->flag [FLAG_MONSTER])
417 { 445 {
418 if (stats.hp > stats.maxhp) 446 if (stats.hp > stats.maxhp)
419 { 447 {
420 LOG (llevDebug, "Monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp); 448 LOG (llevInfo, "ITEMBUG: monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp);
421 stats.maxhp = stats.hp; 449 stats.maxhp = stats.hp;
422 } 450 }
423 451
424 /* The archs just need to be updated for this */ 452 /* The archs just need to be updated for this */
425 if (move_type == 0) 453 if (move_type == 0)
426 move_type = MOVE_WALK; 454 move_type = MOVE_WALK;
427 } 455 }
428 456
429 if ((QUERY_FLAG (this, FLAG_GENERATOR) && QUERY_FLAG (this, FLAG_CONTENT_ON_GEN)) || type == CREATOR || type == CONVERTER) 457 if ((this->flag [FLAG_GENERATOR] && this->flag [FLAG_CONTENT_ON_GEN]) || type == CREATOR || type == CONVERTER)
430 {
431 /* Object will duplicate it's content as part of the 458 /* Object will duplicate it's content as part of the
432 * generation process. To do this, we must flag inventory 459 * generation process. To do this, we must flag inventory
433 * so it remains unevaluated concerning the randomitems and 460 * so it remains unevaluated concerning the randomitems and
434 * the living (a demonlord shouldn't cast from inside generator!) 461 * the living (a demonlord shouldn't cast from inside generator!)
435 */ 462 */
463 /* ??? this *should* be done elsewhere, e.g. after map loading etc. */
436 flag_inv (this, FLAG_IS_A_TEMPLATE); 464 flag_inv (this, FLAG_IS_A_TEMPLATE);
437 }
438 465
439 /* Handle player movers. We use move_type for player movers 466 /* Handle player movers. We use move_type for player movers
440 * because they operate on their own time (move_on 467 * because they operate on their own time (move_on
441 * would potentially cause them to be triggered when someone steps 468 * would potentially cause them to be triggered when someone steps
442 * on them). If move_type is set, presume person knows what they 469 * on them). If move_type is set, presume person knows what they
443 * are doing, otherwise, set move_type based on maxhp value. 470 * are doing, otherwise, set move_type based on maxhp value.
444 */ 471 */
445 if (type == PLAYERMOVER) 472 if (type == PLAYERMOVER)
446 { 473 {
447 if (!move_type) 474 if (!move_type)
… …
453 } 480 }
454 else 481 else
455 move_type = MOVE_WALK; 482 move_type = MOVE_WALK;
456 } 483 }
457 } 484 }
485
486 // if the object has an animation, try to provide a default face
487 if (has_anim ())
488 {
489 if (anim_speed)
490 // if this item is time-animated, force the last frame
491 animate_object (this, 0);
492 else if (flag [FLAG_MONSTER])
493 // if it is a monster, set appropriate facing
494 animate_object (this, direction);
495 }
458} 496}
459 497
460static void 498static void
461set_move (MoveType &mt, const char *str) 499set_move (MoveType &mt, object_thawer &f)
462{ 500{
463 static const struct flagstr { 501 static const struct flagstr {
464 const char *name; 502 const char *name;
465 MoveType flags; 503 MoveType flags;
466 } move_flags[] = { 504 } move_flags[] = {
… …
472 { "boat" , MOVE_BOAT }, 510 { "boat" , MOVE_BOAT },
473 { "ship" , MOVE_SHIP }, 511 { "ship" , MOVE_SHIP },
474 { "all" , MOVE_ALL }, 512 { "all" , MOVE_ALL },
475 }; 513 };
476 514
477 if (!str) 515 const char *str = f.get_str ();
478 {
479 mt = 0;
480 return;
481 }
482 516
483 if (isdigit (*str)) 517 if (!*str || isdigit (*str))
484 { 518 {
485 mt = atoi (str); 519 mt = atoi (str);
486 return; 520 return;
487 } 521 }
488 522
489 mt = 0; 523 mt = 0;
490 524
491 for (str = strtok ((char *) str, " "); str; str = strtok (0, " ")) 525 for (str = strtok ((char *)str, " "); str; str = strtok (0, " "))
492 { 526 {
493 bool negate = 0; 527 bool negate = 0;
494 528
495 if (*str == '-') 529 if (*str == '-')
496 { 530 {
497 negate = 1; 531 negate = 1;
498 str++; 532 str++;
499 } 533 }
500 534
501 for (const flagstr *f = move_flags; f < move_flags + sizeof (move_flags) / sizeof (move_flags [0]); ++f) 535 for (const flagstr *f = move_flags; f < move_flags + array_length (move_flags); ++f)
502 { 536 {
503 if (!strcmp (f->name, str)) 537 if (!strcmp (f->name, str))
504 { 538 {
505 if (negate) 539 if (negate)
506 mt &= ~f->flags; 540 mt &= ~f->flags;
… …
509 543
510 goto next; 544 goto next;
511 } 545 }
512 } 546 }
513 547
514 LOG (llevDebug, "common/loader.C: set_move - unknown move string '%s'\n", str); 548 LOG (llevError, "common/loader.C: set_move - unknown move string '%s'\n", str);
515 549
516next: ; 550next: ;
517 } 551 }
518} 552}
519 553
520#define GET_FLAG(op,flag) \ 554//-GPL
521 if (f.get_sint32 ()) \ 555
522 SET_FLAG (op, flag); \ 556#define GET_FLAG(op,flg) op->flag [flg] = f.get_bool ()
523 else \
524 CLEAR_FLAG (op, flag) \
525 557
526bool 558bool
527object::parse_kv (object_thawer &f) 559object::parse_kv (object_thawer &f)
528{ 560{
529 object *op_inv = inv; 561 object *op_inv = inv;
… …
531 for (;;) 563 for (;;)
532 { 564 {
533 switch (f.kw) 565 switch (f.kw)
534 { 566 {
535 case KW_uuid: 567 case KW_uuid:
536 if (const char *s = f.get_str ()) 568 if (!uuid.parse (f.get_str ()))
537 { 569 {
538 unsigned int version; 570 f.parse_warn ("unparseable uuid");
539 unsigned long long seq; 571 uuid = UUID::gen ();
540
541 if (2 == sscanf (s, "<%d.%llx>", &version, &seq) && version == 1)
542 {
543 uuid.seq = seq;
544 break;
545 }
546 } 572 }
547
548 uuid = gen_uuid ();
549 break; 573 break;
550 574
551 case KW_oid: 575 case KW_oid:
552 f.get (this, f.get_sint32 ()); 576 f.get (this, f.get_sint32 ());
553 break; 577 break;
… …
559 583
560 case KW_attach: f.get_ornull (attach); break; 584 case KW_attach: f.get_ornull (attach); break;
561 case KW_skill: f.get_ornull (skill); break; 585 case KW_skill: f.get_ornull (skill); break;
562 case KW_race: f.get_ornull (race); break; 586 case KW_race: f.get_ornull (race); break;
563 case KW_slaying: f.get_ornull (slaying); break; 587 case KW_slaying: f.get_ornull (slaying); break;
588 case KW_tag: f.get_ornull (tag); break;
564 589
565 case KW_arch: 590 case KW_arch:
566 {
567 object *tmp = object::read (f); 591 if (object *tmp = object::read (f))
568 tmp->deactivate ();
569
570 { 592 {
593 tmp->deactivate ();
594
571 // was: insert_ob_in_ob (tmp, op); 595 // was: insert_ob_in_ob (tmp, op);
572 // but manually adding it can improve map loading times a lot 596 // but manually adding it can improve map loading times a lot
573 // also, appending instead of prepending keeps the 597 // also, appending instead of prepending keeps the
574 // save ordering the same between repeated load/saves. 598 // save ordering the same between repeated load/saves.
575 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL); 599 // and finally we do not want any funny effects
576 CLEAR_FLAG (tmp, FLAG_REMOVED); 600 tmp->clr_flag (FLAG_OBJ_ORIGINAL);
601 tmp->clr_flag (FLAG_REMOVED);
577 602
578 if (!op_inv) 603 if (!op_inv)
579 { 604 {
580 inv = tmp; 605 inv = tmp;
581 tmp->above = 0; 606 tmp->above = 0;
… …
591 616
592 tmp->below = 0; 617 tmp->below = 0;
593 tmp->env = this; 618 tmp->env = this;
594 op_inv = tmp; 619 op_inv = tmp;
595 } 620 }
596 } 621 else
622 LOG (llevError, "ERROR: couldn't load inventory object, file corrupted?\n");
623
597 continue; 624 continue;
598 625
599 case KW_other_arch: 626 case KW_other_arch:
600 other_arch =
601 loading_arch 627 if (loading_arch == this)
602 ? archetype::get (f.get_str ()) 628 archetype::postpone_arch_ref (loading_arch->other_arch, f.get_str ());
629 else
630 {
603 : archetype::find (f.get_str ()); 631 other_arch = archetype::find (f.get_str ());
604 632
605 if (!other_arch) 633 if (!other_arch)
606 LOG (llevError, "%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()); 634 f.parse_warn (format ("%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()));
635 }
636 break;
637
638 case KW_owner:
639 f.delayed_deref (this, owner, f.get_str ());
607 break; 640 break;
608 641
609 case KW_animation: 642 case KW_animation:
610 { 643 {
611 CLEAR_FLAG (this, FLAG_ANIMATE); 644 clr_flag (FLAG_ANIMATE);
612 animation_id = 0; 645 animation_id = 0;
613 646
614 const char *str = f.get_str (); 647 if (f.has_value () && (animation_id = animation::find (f.get_str ()).number))
615 if (str && (animation_id = find_animation (str))) 648 set_flag (FLAG_ANIMATE); //TODO: should not be forced to true here
616 SET_FLAG (this, FLAG_ANIMATE);
617 } 649 }
618 break; 650 break;
619 651
620 case KW_last_heal: f.get (last_heal); break; 652 case KW_last_heal: f.get (last_heal); break;
621 case KW_last_sp: f.get (last_sp); break; 653 case KW_last_sp: f.get (last_sp); break;
622 case KW_last_grace: f.get (last_grace); break; 654 case KW_last_grace: f.get (last_grace); break;
623 case KW_last_eat: f.get (last_eat); break; 655 case KW_last_eat: f.get (last_eat); break;
656 case KW_sl:
624 case KW_speed_left: f.get (speed_left); break; 657 case KW_speed_left: f.get (speed_left); break;
625 658
626 case KW_speed: 659 case KW_speed:
627 f.get (speed); 660 f.get (speed);
628 661
… …
637 move_slow |= MOVE_WALK; 670 move_slow |= MOVE_WALK;
638 f.get (move_slow_penalty); 671 f.get (move_slow_penalty);
639 break; 672 break;
640 673
641 case KW_face: 674 case KW_face:
675 face = f.has_value () ? face_find (f.get_str ()) : blank_face;
676 break;
677
678 case KW_sound:
679 if (f.has_value ())
680 {
642 face = face_find (f.get_str ()); 681 sound = sound_find (f.get_str ());
682 if (!sound)
683 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
684 }
685 else
686 sound = 0;
687 break;
688
689 case KW_sound_destroy:
690 if (f.has_value ())
691 {
692 sound_destroy = sound_find (f.get_str ());
693 if (!sound_destroy)
694 f.parse_warn (format ("sound '%s' not found", f.get_str ()));
695 }
696 else
697 sound_destroy = 0;
643 break; 698 break;
644 699
645 case KW_x: f.get (x); break; 700 case KW_x: f.get (x); break;
646 case KW_y: f.get (y); break; 701 case KW_y: f.get (y); break;
647 702
… …
688 case KW_invisible: f.get (invisible); break; 743 case KW_invisible: f.get (invisible); break;
689 case KW_magic: f.get (magic); break; 744 case KW_magic: f.get (magic); break;
690 case KW_state: f.get (state); break; 745 case KW_state: f.get (state); break;
691 case KW_move_slow_penalty: f.get (move_slow_penalty); break; 746 case KW_move_slow_penalty: f.get (move_slow_penalty); break;
692 case KW_material: f.get (materials); break; //TODO: nuke 747 case KW_material: f.get (materials); break; //TODO: nuke
693 case KW_materialname: f.get (materialname); break; 748 case KW_materialname: f.get (material); break;
694 749
695 /* These are the new values */ 750 /* These are the new values */
696 case KW_move_block: set_move (move_block, f.get_str ()); break; 751 case KW_move_block: set_move (move_block, f); break;
697 case KW_move_allow: set_move (move_allow, f.get_str ()); break; 752 case KW_move_allow: set_move (move_allow, f); break;
698 case KW_move_type: set_move (move_type, f.get_str ()); break; 753 case KW_move_type: set_move (move_type , f); break;
699 case KW_move_on: set_move (move_on, f.get_str ()); break; 754 case KW_move_on: set_move (move_on , f); break;
700 case KW_move_off: set_move (move_off, f.get_str ()); break; 755 case KW_move_off: set_move (move_off , f); break;
701 case KW_move_slow: set_move (move_slow, f.get_str ()); break; 756 case KW_move_slow: set_move (move_slow , f); break;
702
703 /* These are all legacy - any new objects should use the move_ .. values */
704 case KW_no_pass:
705 {
706 if (f.get_sint32 ())
707 move_block = MOVE_ALL;
708 else
709 move_block = 0;
710 }
711
712 break;
713
714 /* These are all legacy - any new objects should use the move_ .. values */
715 case KW_walk_on:
716 {
717 if (f.get_sint32 ())
718 move_on |= MOVE_WALK;
719 else
720 move_on &= ~MOVE_WALK;
721 }
722
723 break;
724
725 /* These are all legacy - any new objects should use the move_ .. values */
726 case KW_walk_off:
727 {
728 if (f.get_sint32 ())
729 move_off |= MOVE_WALK;
730 else
731 move_off &= ~MOVE_WALK;
732 }
733 break;
734
735 /* These are all legacy - any new objects should use the move_ .. values */
736 case KW_fly_on:
737 {
738 if (f.get_sint32 ())
739 move_on |= MOVE_FLY_LOW;
740 else
741 move_on &= ~MOVE_FLY_LOW;
742 }
743 break;
744
745 /* These are all legacy - any new objects should use the move_ .. values */
746 case KW_fly_off:
747 {
748 if (f.get_sint32 ())
749 move_off |= MOVE_FLY_LOW;
750 else
751 move_off &= ~MOVE_FLY_LOW;
752 }
753 break;
754 757
755 //TODO: remove these after converting archetypes 758 //TODO: remove these after converting archetypes
756 case KW_can_use_wand: 759 case KW_can_use_wand:
757 GET_FLAG (this, FLAG_USE_RANGE); 760 GET_FLAG (this, FLAG_USE_RANGE);
758 break; 761 break;
759 762
760 /* These are all legacy - any new objects should use the move_ .. values */
761 case KW_flying:
762 {
763 if (f.get_sint32 ())
764 move_type |= MOVE_FLY_LOW;
765 else
766 move_type &= ~MOVE_FLY_LOW;
767 }
768 break;
769
770
771 case KW_identified: 763 case KW_identified:
772 GET_FLAG (this, FLAG_IDENTIFIED); 764 GET_FLAG (this, FLAG_IDENTIFIED);
773 //TODO: move to check_object or so 765 //TODO: move to check_object or so
774 if (QUERY_FLAG (this, FLAG_IDENTIFIED)) 766 if (this->flag [FLAG_IDENTIFIED])
775 CLEAR_FLAG (this, FLAG_KNOWN_MAGICAL); 767 this->clr_flag (FLAG_KNOWN_MAGICAL);
776 768
777 break; 769 break;
778 770
779 case KW_friendly: 771 case KW_friendly:
780 if (f.get_sint32 ()) 772 if (f.get_bool ())
781 if (type != PLAYER) 773 if (type != PLAYER)
782 add_friendly_object (this); 774 add_friendly_object (this);
783 775
784 break; 776 break;
785 777
… …
798 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break; 790 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break;
799 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break; 791 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break;
800 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break; 792 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break;
801 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break; 793 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break;
802 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break; 794 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break;
795 case KW_player_sold: GET_FLAG (this, FLAG_PLAYER_SOLD); break;
803 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break; 796 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break;
804 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break; 797 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break;
805 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break; 798 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break;
806 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break; 799 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break;
807 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break; 800 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break;
808 case KW_hitback: GET_FLAG (this, FLAG_HITBACK); break; 801 case KW_hitback: GET_FLAG (this, FLAG_HITBACK); break;
809 case KW_startequip: GET_FLAG (this, FLAG_STARTEQUIP); break; 802 case KW_startequip: GET_FLAG (this, FLAG_STARTEQUIP); break;
810 case KW_blocksview: GET_FLAG (this, FLAG_BLOCKSVIEW); break; 803 case KW_blocksview: GET_FLAG (this, FLAG_BLOCKSVIEW); break;
804 case KW_is_transparent_floor: GET_FLAG (this, FLAG_IS_TRANSPARENT_FLOOR); break;
811 case KW_undead: GET_FLAG (this, FLAG_UNDEAD); break; 805 case KW_undead: GET_FLAG (this, FLAG_UNDEAD); break;
812 case KW_scared: GET_FLAG (this, FLAG_SCARED); break; 806 case KW_scared: GET_FLAG (this, FLAG_SCARED); break;
813 case KW_unaggressive: GET_FLAG (this, FLAG_UNAGGRESSIVE); break; 807 case KW_unaggressive: GET_FLAG (this, FLAG_UNAGGRESSIVE); break;
814 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break; 808 case KW_reflect_missile: GET_FLAG (this, FLAG_REFL_MISSILE); break;
815 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break; 809 case KW_reflect_spell: GET_FLAG (this, FLAG_REFL_SPELL); break;
816 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break; 810 case KW_no_magic: GET_FLAG (this, FLAG_NO_MAGIC); break;
817 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break; 811 case KW_no_drop: GET_FLAG (this, FLAG_NO_DROP); break;
818 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break; 812 case KW_random_movement: GET_FLAG (this, FLAG_RANDOM_MOVE); break;
819 case KW_no_fix_player: GET_FLAG (this, FLAG_NO_FIX_PLAYER); break;
820 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break; 813 case KW_is_lightable: GET_FLAG (this, FLAG_IS_LIGHTABLE); break;
821 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break; 814 case KW_tear_down: GET_FLAG (this, FLAG_TEAR_DOWN); break;
822 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break; 815 case KW_can_use_shield: GET_FLAG (this, FLAG_USE_SHIELD); break;
823 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break; 816 case KW_can_cast_spell: GET_FLAG (this, FLAG_CAST_SPELL); break;
824 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break; 817 case KW_can_use_scroll: GET_FLAG (this, FLAG_USE_SCROLL); break;
… …
868 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break; 861 case KW_berserk: GET_FLAG (this, FLAG_BERSERK); break;
869 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break; 862 case KW_is_buildable: GET_FLAG (this, FLAG_IS_BUILDABLE); break;
870 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break; 863 case KW_destroy_on_death: GET_FLAG (this, FLAG_DESTROY_ON_DEATH); break;
871 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break; 864 case KW_treasure_env: GET_FLAG (this, FLAG_TREASURE_ENV); break;
872 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break; 865 case KW_precious: GET_FLAG (this, FLAG_PRECIOUS); break;
866 case KW_random_speed: GET_FLAG (this, FLAG_RANDOM_SPEED); break;
867 case KW_is_quad: GET_FLAG (this, FLAG_IS_QUAD); break;
873 868
874 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break; 869 case KW_armour: f.get (resist[ATNR_PHYSICAL]); break;
875 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break; 870 case KW_resist_physical: f.get (resist[ATNR_PHYSICAL]); break;
876 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break; 871 case KW_resist_magic: f.get (resist[ATNR_MAGIC]); break;
877 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break; 872 case KW_resist_fire: f.get (resist[ATNR_FIRE]); break;
… …
907 case KW_anim_speed: f.get (anim_speed); break; 902 case KW_anim_speed: f.get (anim_speed); break;
908 case KW_container: f.get (weight_limit); break; 903 case KW_container: f.get (weight_limit); break;
909 case KW_will_apply: f.get (will_apply); break; 904 case KW_will_apply: f.get (will_apply); break;
910 case KW_attack_movement: f.get (attack_movement); break; 905 case KW_attack_movement: f.get (attack_movement); break;
911 case KW_move_state: f.get (move_status); break; 906 case KW_move_state: f.get (move_status); break;
912 case KW_expmul: f.get (expmul); break; 907 //case KW_expmul: f.get (expmul); break;//D declared const for the time being
913 case KW_glow_radius: f.get (glow_radius); break; 908 case KW_glow_radius: f.get (glow_radius); break;
914 case KW_weapontype: f.get (weapontype); break; 909 case KW_weapontype: f.get (weapontype); break;
915 case KW_tooltype: f.get (tooltype); break;
916 case KW_casting_time: f.get (casting_time); break; 910 case KW_casting_time: f.get (casting_time); break;
911
912 // elevation is deprecated
917 case KW_elevation: f.get (elevation); break; 913 case KW_elevation: break;
914
918 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break; 915 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break;
919 case KW_client_type: f.get (client_type); break; 916 case KW_client_type: f.get (client_type); break;
920 case KW_duration: f.get (duration); break; 917 case KW_duration: f.get (duration); break;
921 case KW_range: f.get (range); break; 918 case KW_range: f.get (range); break;
922 case KW_range_modifier: f.get (range_modifier); break; 919 case KW_range_modifier: f.get (range_modifier); break;
… …
941 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break; 938 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break;
942 case KW_can_apply: 939 case KW_can_apply:
943 break; 940 break;
944 941
945 case KW_connected: 942 case KW_connected:
946 add_button_link (this, map, f.get_sint32 ()); 943 {
944 shstr connected;
945
946 f.get (connected);
947 add_link (map, connected);
948 }
947 break; 949 break;
948 950
949 case KW_randomitems: 951 case KW_randomitems:
950 if (f.get_str ()) 952 if (f.has_value ())
951 { 953 {
952 randomitems = 954 randomitems =
953 loading_arch 955 loading_arch
954 ? treasurelist::get (f.get_str ()) 956 ? treasurelist::get (f.get_str ())
955 : treasurelist::find (f.get_str ()); 957 : treasurelist::find (f.get_str ());
956 958
957 if (!randomitems) 959 if (!randomitems)
960 {
958 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ()); 961 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ());
962 randomitems = treasurelist::get (shstr_none); // avoid crashes
963 }
959 } 964 }
960 else 965 else
961 randomitems = 0; 966 randomitems = 0;
962 break; 967 break;
963 968
964 case KW_msg: 969 case KW_msg:
965 f.get_ml (KW_endmsg, msg); 970 f.get_ml (KW_endmsg, msg);
966 //TODO: allow longer messages
967 if (strlen (msg) >= HUGE_BUF)
968 {
969 LOG (llevDebug, "\tError message length >= %d: %d\n>%.80s<\n", HUGE_BUF, strlen (msg), &msg);
970 msg = "ERROR, please report: string too long, winged.\n";
971 }
972 break; 971 break;
973 972
974 case KW_lore: 973 case KW_lore:
975 f.get_ml (KW_endlore, lore); 974 f.get_ml (KW_endlore, lore);
976 //TODO: allow longer messages
977 /* Just print a warning so we can be reasonably safe
978 * about not overflowing the buffer.
979 */
980 if (strlen (lore) > (HUGE_BUF / 2))
981 LOG (llevDebug, "\tWarning lore length > %d (max allowed=%d): %d\n>%.80s<\n",
982 HUGE_BUF / 2, HUGE_BUF, strlen (lore), &lore);
983 break; 975 break;
984 976
985 case KW_editable: 977 case KW_editable:
986 case KW_editor_folder: 978 case KW_editor_folder:
987 break; 979 break;
… …
992 984
993 f.next (); 985 f.next ();
994 return true; 986 return true;
995 987
996 case KW_ERROR: 988 case KW_ERROR:
997 set_ob_key_value (this, f.kw_str, f.value, true); 989 // we do not even try to find old values, duplicate keys stay duplicate
998 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D 990 // the list gets reversed after loading
991 kv.add (shstr (f.kw_str), shstr (f.value));
999 break; 992 break;
1000 993
1001 default: 994 default:
1002 if (!f.parse_error ("object", name)) 995 if (!f.parse_error ("object", name))
1003 return false; 996 return false;
… …
1015 1008
1016 archetype *arch = archetype::find (f.get_str ()); 1009 archetype *arch = archetype::find (f.get_str ());
1017 1010
1018 if (!arch) 1011 if (!arch)
1019 { 1012 {
1020 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ()); 1013 LOG (llevError, "object referring to nonexistent archetype '%s'.\n", f.get_str ());
1021 arch = archetype::find ("earthwall"); 1014 arch = archetype::find (shstr_earthwall);
1022 } 1015 }
1023 1016
1024 assert (arch); //D maybe use exception handling of sorts? 1017 assert (arch); //D maybe use exception handling of sorts?
1025 1018
1026 f.next (); 1019 f.next ();
1027 1020
1028 object *op = object::create (); 1021 object *op = arch->instance ();
1029
1030 op->map = map; 1022 op->map = map;
1031 arch->clone.copy_to (op);
1032 // copy_to activates, this should be fixed properly 1023 // instance() activates, this should be fixed properly
1033 op->deactivate (); 1024 op->deactivate ();
1034 1025
1035 if (!op->parse_kv (f)) 1026 if (!op->parse_kv (f))
1036 { 1027 {
1037 op->destroy (true); 1028 op->destroy ();
1038 return 0; 1029 return 0;
1039 } 1030 }
1031
1032 // the loader reverses the ordering of kv-pairs, so we reverse it again after loading
1033 // that greatly simplifies the loading code.
1034 op->kv.reverse ();
1040 1035
1041 op->post_load_check (); 1036 op->post_load_check ();
1042 return op; 1037 return op;
1043} 1038}
1044 1039
… …
1049 * override values and in c_wiz to mutate values. 1044 * override values and in c_wiz to mutate values.
1050 */ 1045 */
1051int 1046int
1052set_variable (object *op, char *buf) 1047set_variable (object *op, char *buf)
1053{ 1048{
1054 object_thawer f (buf, (AV *)0); 1049 object_thawer f (format ("%s\nend", buf), (AV *)0);
1055 1050
1056 f.next ();
1057 return op->parse_kv (f); 1051 return op->parse_kv (f);
1058} 1052}
1059 1053
1060/* This returns a string of the integer movement type */
1061#if 0
1062// unused function
1063static char *
1064get_string_move_type (MoveType mt)
1065{
1066 static char retbuf[MAX_BUF], retbuf_all[MAX_BUF];
1067 int i, all_count = 0, count;
1068
1069 strcpy (retbuf, "");
1070 strcpy (retbuf_all, " all");
1071
1072 /* Quick check, and probably fairly common */
1073 if (mt == MOVE_ALL)
1074 return retbuf_all + 1;
1075 if (mt == 0)
1076 {
1077 strcpy (retbuf, "0");
1078 return retbuf;
1079 }
1080
1081 /* We basically slide the bits down. Why look at MOVE_ALL?
1082 * because we may want to return a string like 'all -swim',
1083 * and if we just looked at mt, we couldn't get that.
1084 */
1085 for (i = MOVE_ALL, count = 0; i != 0; i >>= 1, count++)
1086 {
1087 if (mt & (1 << count))
1088 {
1089 strcat (retbuf, " ");
1090 strcat (retbuf, move_name[count]);
1091 }
1092 else
1093 {
1094 strcat (retbuf_all, " -");
1095 strcat (retbuf_all, move_name[count]);
1096 all_count++;
1097 }
1098 }
1099 /* Basically, if there is a single negation, return it, eg
1100 * 'all -swim'. But more than that, just return the
1101 * enumerated values. It doesn't make sense to return
1102 * 'all -walk -fly_low' - it is shorter to return 'fly_high swim'
1103 */
1104 if (all_count <= 1)
1105 return retbuf_all + 1;
1106 else
1107 return retbuf + 1;
1108}
1109#endif
1110
1111// compare *op against *tmp and output differences 1054// compare *op against *arch and output differences
1112static void 1055static void
1113write_diff (object_freezer &f, object *op, object *tmp) 1056write_diff (object_freezer &f, object *op, object *arch)
1114{ 1057{
1115 static const keyword resist_save[NROFATTACKS] = { 1058 static const keyword resist_save[NROFATTACKS] = {
1116# define def(uc, lc, name, plus, change) KW_resist_ ## lc, 1059# define def(uc, lc, name, plus, change) KW_resist_ ## lc,
1117# include "attackinc.h" 1060# include "attackinc.h"
1118# undef def 1061# undef def
… …
1131 KW_NULL, 1074 KW_NULL,
1132 KW_applied, 1075 KW_applied,
1133 KW_unpaid, 1076 KW_unpaid,
1134 KW_can_use_shield, 1077 KW_can_use_shield,
1135 KW_no_pick, 1078 KW_no_pick,
1136 KW_NULL, // walk_on 1079 KW_is_transparent_floor,
1080 /* 10 */
1137 KW_NULL, // no_pass 1081 KW_NULL, // no_pass
1138 /* 10 */
1139 KW_is_animated, 1082 KW_is_animated,
1140 KW_NULL, // slow_move 1083 KW_NULL, // slow_move
1141 KW_NULL, // flying 1084 KW_NULL, // flying
1142 KW_monster, 1085 KW_monster,
1143 KW_friendly, 1086 KW_friendly,
1144 KW_generator, 1087 KW_generator,
1145 KW_is_thrown, 1088 KW_is_thrown,
1146 KW_auto_apply, 1089 KW_auto_apply,
1147 KW_treasure_env, 1090 KW_treasure_env,
1091 /* 20 */
1148 KW_player_sold, 1092 KW_player_sold,
1149 /* 20 */
1150 KW_see_invisible, 1093 KW_see_invisible,
1151 KW_can_roll, 1094 KW_can_roll,
1152 KW_overlay_floor, 1095 KW_overlay_floor,
1153 KW_is_turnable, 1096 KW_is_turnable,
1154 KW_NULL, // walk_off 1097 KW_NULL, // walk_off
1155 KW_NULL, // fly_on 1098 KW_NULL, // fly_on
1156 KW_NULL, // fly_off 1099 KW_NULL, // fly_off
1157 KW_is_used_up, 1100 KW_is_used_up,
1158 KW_identified, 1101 KW_identified,
1102 /* 30 */
1159 KW_reflecting, 1103 KW_reflecting,
1160 /* 30 */
1161 KW_changing, 1104 KW_changing,
1162 KW_splitting, 1105 KW_splitting,
1163 KW_hitback, 1106 KW_hitback,
1164 KW_startequip, 1107 KW_startequip,
1165 KW_blocksview, 1108 KW_blocksview,
1166 KW_undead, 1109 KW_undead,
1167 KW_scared, 1110 KW_scared,
1168 KW_unaggressive, 1111 KW_unaggressive,
1169 KW_reflect_missile, 1112 KW_reflect_missile,
1113 /* 40 */
1170 KW_reflect_spell, 1114 KW_reflect_spell,
1171 /* 40 */
1172 KW_no_magic, 1115 KW_no_magic,
1173 KW_no_fix_player, 1116 KW_NULL,
1174 KW_is_lightable, 1117 KW_is_lightable,
1175 KW_tear_down, 1118 KW_tear_down,
1176 KW_run_away, 1119 KW_run_away,
1177 KW_NULL, // pass_thru 1120 KW_NULL, // pass_thru
1178 KW_NULL, // an_pass_thru 1121 KW_NULL, // an_pass_thru
1179 KW_pick_up, 1122 KW_pick_up,
1180 KW_unique, 1123 KW_unique,
1124 /* 50 */
1181 KW_no_drop, 1125 KW_no_drop,
1182 /* 50 */
1183 KW_NULL, // wizcast 1126 KW_NULL, // wizcast
1184 KW_can_cast_spell, 1127 KW_can_cast_spell,
1185 KW_can_use_scroll, 1128 KW_can_use_scroll,
1186 KW_can_use_range, 1129 KW_can_use_range,
1187 KW_can_use_bow, 1130 KW_can_use_bow,
1188 KW_can_use_armour, 1131 KW_can_use_armour,
1189 KW_can_use_weapon, 1132 KW_can_use_weapon,
1190 KW_can_use_ring, 1133 KW_can_use_ring,
1191 KW_has_ready_range, 1134 KW_has_ready_range,
1135 /* 60 */
1192 KW_has_ready_bow, 1136 KW_has_ready_bow,
1193 /* 60 */
1194 KW_xrays, 1137 KW_xrays,
1195 KW_NULL, 1138 KW_NULL,
1196 KW_is_floor, 1139 KW_is_floor,
1197 KW_lifesave, 1140 KW_lifesave,
1198 KW_no_strength, 1141 KW_no_strength,
1199 KW_sleep, 1142 KW_sleep,
1200 KW_stand_still, 1143 KW_stand_still,
1201 KW_random_move, 1144 KW_random_move,
1202 KW_only_attack, 1145 KW_only_attack,
1146 /* 70 */
1203 KW_confused, 1147 KW_confused,
1204 /* 70 */
1205 KW_stealth, 1148 KW_stealth,
1206 KW_NULL, 1149 KW_NULL,
1207 KW_NULL, 1150 KW_NULL,
1208 KW_cursed, 1151 KW_cursed,
1209 KW_damned, 1152 KW_damned,
1210 KW_see_anywhere, 1153 KW_see_anywhere,
1211 KW_known_magical, 1154 KW_known_magical,
1212 KW_known_cursed, 1155 KW_known_cursed,
1213 KW_can_use_skill, 1156 KW_can_use_skill,
1157 /* 80 */
1214 KW_been_applied, 1158 KW_been_applied,
1215 /* 80 */
1216 KW_has_ready_scroll, 1159 KW_has_ready_scroll,
1217 KW_can_use_rod, 1160 KW_can_use_rod,
1218 KW_precious, 1161 KW_precious,
1219 KW_can_use_horn, 1162 KW_can_use_horn,
1220 KW_make_invisible, 1163 KW_make_invisible,
1221 KW_inv_locked, 1164 KW_inv_locked,
1222 KW_is_wooded, 1165 KW_is_wooded,
1223 KW_is_hilly, 1166 KW_is_hilly,
1224 KW_has_ready_skill, 1167 KW_has_ready_skill,
1168 /* 90 */
1225 KW_has_ready_weapon, 1169 KW_has_ready_weapon,
1226 /* 90 */
1227 KW_no_skill_ident, 1170 KW_no_skill_ident,
1228 KW_is_blind, 1171 KW_is_blind,
1229 KW_can_see_in_dark, 1172 KW_can_see_in_dark,
1230 KW_is_cauldron, 1173 KW_is_cauldron,
1231 KW_NULL, 1174 KW_NULL,
1232 KW_no_steal, 1175 KW_no_steal,
1233 KW_one_hit, 1176 KW_one_hit,
1234 KW_NULL, 1177 KW_NULL,
1235 KW_berserk, 1178 KW_berserk,
1179 /* 100 */
1236 KW_neutral, 1180 KW_neutral,
1237 /* 100 */
1238 KW_no_attack, 1181 KW_no_attack,
1239 KW_no_damage, 1182 KW_no_damage,
1240 KW_obj_original, 1183 KW_obj_original,
1241 KW_NULL, 1184 KW_random_speed,
1242 KW_activate_on_push, 1185 KW_activate_on_push,
1243 KW_activate_on_release, 1186 KW_activate_on_release,
1244 KW_is_water, 1187 KW_is_water,
1245 KW_use_content_on_gen, 1188 KW_use_content_on_gen,
1246 KW_NULL, 1189 KW_NULL,
1190 /* 110 */
1247 KW_is_buildable, 1191 KW_is_buildable,
1248 /* 110 */
1249 KW_destroy_on_death, 1192 KW_destroy_on_death,
1250 KW_NULL, 1193 KW_NULL,
1251 }; 1194 };
1252 1195
1253 int i; 1196 // obj_original is the only commonly differing flag between archetype
1197 // and object, so special-case it here to be able to skip the loop
1198 static const struct flagmask : object::flags_t
1199 {
1200 flagmask ()
1201 {
1202 for (int i = 0; i < NUM_FLAGS; i++)
1203 if (flag_names [i])
1204 set (i);
1205 }
1206 } flagmask;
1254 1207
1255 /* This saves the key/value lists. We do it first so that any 1208 /* This saves the key/value lists. We do it first so that any
1256 * keys that match field names will be overwritten by the loader. 1209 * keys that match field names will be overwritten by the loader.
1257 */ 1210 */
1258 for (key_value *my_field = op->key_values; my_field; my_field = my_field->next) 1211 for (key_value *kv = op->kv.first; kv; kv = kv->next)
1259 { 1212 if (arch->kv.empty () || arch->kv [kv->key] != kv->value)
1260 /* Find the field in the opposing member. */ 1213 f.put (kv->key, kv->value);
1261 key_value *arch_field = get_ob_key_link (tmp, my_field->key);
1262 1214
1263 /* If there's no partnering field, or it's got a different value, save our field. */ 1215 if (op->uuid)
1264 if (!arch_field || my_field->value != arch_field->value)
1265 f.put (my_field->key, my_field->value);
1266 } 1216 {
1217 // highly optimised - this is often 25% of all data written
1218 char *cur = f.force (sizeof ("uuid ") + UUID::MAX_LEN + 1);
1219 char *ptr = cur;
1267 1220
1268 /* We don't need to worry about the arch's extra fields - they 1221 memcpy (ptr, "uuid ", sizeof ("uuid ") - 1);
1269 * will get taken care of the copy_to method. 1222 ptr += sizeof ("uuid ") - 1;
1270 */ 1223 ptr = op->uuid.append (ptr);
1224 *ptr++ = '\n';
1271 1225
1272 { 1226 f.alloc (ptr - cur);
1273 char uids[64];
1274 snprintf (uids, sizeof (uids), "<1.%llx>", (unsigned long long)op->uuid.seq);
1275 f.put (KW_uuid, (const char *)uids);
1276 } 1227 }
1277 1228
1278#define CMP_OUT(v) if (op->v != tmp->v) f.put (KW_ ## v, op->v) 1229#define CMP_OUT(v) if (expect_false (op->v != arch->v)) f.put (KW (v), op->v)
1279#define CMP_OUT2(k,v) if (op->v != tmp->v) f.put (KW_ ## k, op->v) 1230#define CMP_OUT2(k,v) if (expect_false (op->v != arch->v)) f.put (KW (k), op->v)
1231
1232 CMP_OUT (x);
1233 CMP_OUT (y);
1234
1235 CMP_OUT (type);
1236 CMP_OUT (subtype);
1237 CMP_OUT (direction);
1280 1238
1281 CMP_OUT (name); 1239 CMP_OUT (name);
1282 CMP_OUT (name_pl); 1240 CMP_OUT (name_pl);
1283 CMP_OUT (custom_name); 1241 CMP_OUT (speed);
1242
1243 // speed_left is a major time-burner, and has good locality, so
1244 // we use a simple lookup-cache to avoid the very slow printf.
1245 if (op->speed_left != arch->speed_left)
1246 {
1247 static double last_speed_left = 0.;
1248 static char last_speed_left_str [256] = "sl 0\n";
1249 static int last_speed_left_len = sizeof ("sl 0\n") - 1;
1250
1251 if (last_speed_left != op->speed_left)
1252 {
1253 last_speed_left = op->speed_left;
1254 // .7g loses precision even for float, but gives nice round numbers and smaller files
1255 // maybe hex format or a raw binary dump of the float is good enough, more exact, and much faster?
1256 // (printf is typically very slow)
1257 last_speed_left_len = sizeof ("sl ") - 1
1258 + sprintf (last_speed_left_str + sizeof ("sl ") - 1, "%.7g\n", last_speed_left);
1259 }
1260
1261 f.add (last_speed_left_str, last_speed_left_len);
1262 }
1263
1284 CMP_OUT (title); 1264 CMP_OUT (title);
1285 CMP_OUT (race); 1265 CMP_OUT (race);
1286 CMP_OUT (slaying); 1266 CMP_OUT (slaying);
1267 CMP_OUT (skill);
1287 1268
1288 if (op->msg != tmp->msg) 1269 CMP_OUT (tag);
1289 f.put (KW_msg, KW_endmsg, op->msg); 1270 CMP_OUT (custom_name);
1290 if (op->lore != tmp->lore) 1271
1291 f.put (KW_lore, KW_endlore, op->lore); 1272 if (object *owner = op->owner)
1273 if (const char *ref = owner->ref ())
1274 f.put (KW(owner), ref);
1275
1276 // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved
1292 1277
1293 CMP_OUT (other_arch); 1278 CMP_OUT (other_arch);
1294 1279
1295 if (op->face != tmp->face) f.put (KW_face, op->face ? &faces [op->face] : 0); 1280 if (op->msg != arch->msg ) f.put (KW(msg) , KW(endmsg) , op->msg );
1281 if (op->lore != arch->lore) f.put (KW(lore), KW(endlore), op->lore);
1296 1282
1283 if (op->face != arch->face ) f.put (KW(face) , op->face ? &faces [op->face ] : 0);
1284 if (op->sound != arch->sound ) f.put (KW(sound) , op->sound ? &faces [op->sound ] : 0);
1285 if (op->sound_destroy != arch->sound_destroy) f.put (KW(sound_destroy), op->sound_destroy ? &faces [op->sound_destroy] : 0);
1286
1297 if (op->animation_id != tmp->animation_id) 1287 if (op->animation_id != arch->animation_id)
1298 if (op->animation_id) 1288 if (op->has_anim ())
1289 f.put (KW(animation), op->anim ().name);
1290 else
1299 { 1291 {
1300 f.put (KW_animation, animations[GET_ANIM_ID (op)].name); 1292 f.put (KW(animation));
1301 1293 op->flag [FLAG_ANIMATE] = false; // TODO: why force to false here?
1302 if (!QUERY_FLAG (op, FLAG_ANIMATE))
1303 f.put (KW_is_animated, (sint32) 0);
1304 } 1294 }
1305 else
1306 f.put (KW_animation, (const char *) 0);
1307 1295
1308 CMP_OUT2 (str, stats.Str); 1296 CMP_OUT2 (str, stats.Str);
1309 CMP_OUT2 (dex, stats.Dex); 1297 CMP_OUT2 (dex, stats.Dex);
1310 CMP_OUT2 (con, stats.Con); 1298 CMP_OUT2 (con, stats.Con);
1311 CMP_OUT2 (wis, stats.Wis); 1299 CMP_OUT2 (wis, stats.Wis);
… …
1320 CMP_OUT2 (grace, stats.grace); 1308 CMP_OUT2 (grace, stats.grace);
1321 CMP_OUT2 (maxgrace, stats.maxgrace); 1309 CMP_OUT2 (maxgrace, stats.maxgrace);
1322 CMP_OUT2 (exp, stats.exp); 1310 CMP_OUT2 (exp, stats.exp);
1323 1311
1324 CMP_OUT (perm_exp); 1312 CMP_OUT (perm_exp);
1325 CMP_OUT (expmul); 1313 //CMP_OUT (expmul);
1326 1314
1327 CMP_OUT2 (food, stats.food); 1315 CMP_OUT2 (food, stats.food);
1328 CMP_OUT2 (dam, stats.dam); 1316 CMP_OUT2 (dam, stats.dam);
1329 CMP_OUT2 (luck, stats.luck); 1317 CMP_OUT2 (luck, stats.luck);
1330 CMP_OUT2 (wc, stats.wc); 1318 CMP_OUT2 (wc, stats.wc);
1331 CMP_OUT2 (ac, stats.ac); 1319 CMP_OUT2 (ac, stats.ac);
1332 1320
1333 CMP_OUT (x);
1334 CMP_OUT (y);
1335 CMP_OUT (speed);
1336 CMP_OUT (speed_left);
1337 CMP_OUT2 (move_state, move_status); 1321 CMP_OUT2 (move_state, move_status);
1338 CMP_OUT (attack_movement); 1322 CMP_OUT (attack_movement);
1339 CMP_OUT (nrof); 1323 CMP_OUT (nrof);
1340 CMP_OUT (level); 1324 CMP_OUT (level);
1341 CMP_OUT (direction);
1342 CMP_OUT (type);
1343 CMP_OUT (subtype);
1344 CMP_OUT (attacktype); 1325 CMP_OUT (attacktype);
1345 1326
1327 // using memcmp here seems to be a loss - is gcc vectorising?
1346 for (i = 0; i < NROFATTACKS; i++) 1328 for (int i = 0; i < NROFATTACKS; i++)
1347 if (op->resist[i] != tmp->resist[i]) 1329 if (expect_false (op->resist[i] != arch->resist[i]))
1348 f.put (resist_save[i], op->resist[i]); 1330 f.put (resist_save[i], op->resist[i]);
1349 1331
1350 CMP_OUT (path_attuned); 1332 CMP_OUT (path_attuned);
1351 CMP_OUT (path_repelled); 1333 CMP_OUT (path_repelled);
1352 CMP_OUT (path_denied); 1334 CMP_OUT (path_denied);
1335
1353 CMP_OUT2 (material, materials);//TODO: nuke 1336 CMP_OUT2 (material, materials);//TODO: nuke
1354 CMP_OUT (materialname); 1337 if (op->material != arch->material)
1338 f.put (KW(materialname), op->material->name);
1339
1355 CMP_OUT (value); 1340 CMP_OUT (value);
1356 CMP_OUT (carrying); 1341 CMP_OUT (carrying);
1357 CMP_OUT (weight); 1342 CMP_OUT (weight);
1358 CMP_OUT (invisible); 1343 CMP_OUT (invisible);
1359 CMP_OUT (state); 1344 CMP_OUT (state);
… …
1362 CMP_OUT (last_sp); 1347 CMP_OUT (last_sp);
1363 CMP_OUT (last_grace); 1348 CMP_OUT (last_grace);
1364 CMP_OUT (last_eat); 1349 CMP_OUT (last_eat);
1365 CMP_OUT (glow_radius); 1350 CMP_OUT (glow_radius);
1366 1351
1367 if (QUERY_FLAG (op, FLAG_IS_LINKED) && (i = get_button_value (op))) 1352 if (op->flag [FLAG_IS_LINKED])
1353 if (auto (ol, op->find_link ()))
1368 f.put (KW_connected, i); 1354 f.put (KW(connected), ol->id);
1369 1355
1370 CMP_OUT (randomitems); 1356 CMP_OUT (randomitems);
1357
1371 CMP_OUT2 (container, weight_limit); 1358 CMP_OUT2 (container, weight_limit);
1372 1359
1373 CMP_OUT (run_away); 1360 CMP_OUT (run_away);
1374 CMP_OUT (pick_up); 1361 CMP_OUT (pick_up);
1375 CMP_OUT (will_apply); 1362 CMP_OUT (will_apply);
1376 CMP_OUT (smoothlevel); 1363 CMP_OUT (smoothlevel);
1377 CMP_OUT (weapontype); 1364 CMP_OUT (weapontype);
1378 CMP_OUT (tooltype);
1379 CMP_OUT (elevation);
1380 CMP_OUT (client_type); 1365 CMP_OUT (client_type);
1381 CMP_OUT (item_power); 1366 CMP_OUT (item_power);
1382 CMP_OUT (duration); 1367 CMP_OUT (duration);
1383 CMP_OUT (range); 1368 CMP_OUT (range);
1384 CMP_OUT (range_modifier); 1369 CMP_OUT (range_modifier);
… …
1392 CMP_OUT (move_on); 1377 CMP_OUT (move_on);
1393 CMP_OUT (move_off); 1378 CMP_OUT (move_off);
1394 CMP_OUT (move_slow); 1379 CMP_OUT (move_slow);
1395 CMP_OUT (move_slow_penalty); 1380 CMP_OUT (move_slow_penalty);
1396 1381
1397 if (op->flag != tmp->flag) 1382 object::flags_t diff = (op->flag ^ arch->flag) & flagmask;
1383
1384#if stdcpp // we need gcc, sorry
1385 if (diff [FLAG_OBJ_ORIGINAL])
1386 f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? CS(1) : CS(0));
1387
1388 diff.reset (FLAG_OBJ_ORIGINAL);
1389
1390 // quickly test whether any other flags differ
1391 if (expect_true (diff.any ()))
1398 for (i = 0; i <= NUM_FLAGS; i++) 1392 for (int i = 0; i < NUM_FLAGS; i++)
1399 if (flag_names [i] && op->flag [i] != tmp->flag [i]) 1393 if (expect_false (diff [i]))
1400 f.put (flag_names [i], op->flag [i] ? "1" : "0"); 1394 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1395#else
1396 // use sgi extensions
1397 for (int i = diff._Find_first (); i < diff.size (); i = diff._Find_next (i))
1398 f.put (flag_names [i], op->flag [i] ? CS(1) : CS(0));
1399#endif
1401 1400
1402 // save body locations 1401 // save body locations. gcc's memcmp does an abysmal job when used
1403 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 1402 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
1404 if (op->slot[i].info != tmp->slot[i].info) 1403 if (expect_false (op->slot[i].info != arch->slot[i].info))
1405 f.put (body_locations[i].save_name, op->slot[i].info); 1404 f.put (body_locations[i].kw, op->slot[i].info);
1406} 1405}
1407 1406
1408/* 1407/*
1409 * Dumps all variables in an object to a file. 1408 * Dumps all variables in an object to a file.
1410 * If bit 0 of flag is set, unpaid objects will be saved. As of now, 1409 * If bit 0 of flag is set, unpaid objects will be saved. As of now,
1411 * the only place this is not set is when saving the player. 1410 * the only place this is not set is when saving the player.
1412 */ 1411 */
1413bool 1412bool
1414object::write (object_freezer &f) 1413object::write (object_freezer &f)
1415{ 1414{
1416 /* Even if the object does have an owner, it would seem that we should 1415 if (expect_false (is_arch ()))
1417 * still save it. 1416 {
1418 */ 1417 f.put (KW(object), arch->archname);
1419 if (owner) 1418 write_diff (f, this, archetype::empty);
1420 return true; 1419 }
1421 1420 else
1422 archetype *at = arch ? (archetype *)arch : empty_archetype; 1421 {
1423
1424 f.put (KW_arch, at->name); 1422 f.put (KW(arch), arch->archname);
1425 write_diff (f, this, &at->clone); 1423 write_diff (f, this, arch);
1424 }
1426 1425
1427 for (object *tmp = inv; tmp; tmp = tmp->below) 1426 for (object *tmp = inv; tmp; tmp = tmp->below)
1428 tmp->write (f); 1427 tmp->write (f);
1429 1428
1430 f.put (this); 1429 f.put (this);
1431 f.put (KW_end); 1430 f.put (KW(end));
1432 1431
1433 return true; 1432 return true;
1434} 1433}
1435 1434
1436///////////////////////////////////////////////////////////////////////////// 1435/////////////////////////////////////////////////////////////////////////////
1437 1436
1438// generic resource file load, 1437// generic resource file load,
1439// currently supports: region, treasures, archetypes 1438// currently supports: region, treasures, archetypes
1439bool
1440bool load_resource_file (const char *filename) 1440load_resource_file_ (const char *filename)
1441{ 1441{
1442 object_thawer f (filename); 1442 object_thawer f (filename);
1443 1443
1444 bool success = false;
1445 bool seen_arch = false;
1446
1447 f.next ();
1448
1449 for (;;) 1444 for (;;)
1450 { 1445 {
1446 coroapi::cede_to_tick ();
1447
1451 switch (f.kw) 1448 switch (f.kw)
1452 { 1449 {
1453 case KW_region: 1450 case KW_region:
1454 if (!region::read (f)) 1451 if (!region::read (f))
1455 goto finish; 1452 return false;
1456 break; 1453 break;
1457 1454
1458 case KW_treasure: 1455 case KW_treasure:
1459 case KW_treasureone: 1456 case KW_treasureone:
1460 if (!treasurelist::read (f)) 1457 if (!treasurelist::read (f))
1461 goto finish; 1458 return false;
1462 break; 1459 break;
1463 1460
1464 case KW_object: 1461 case KW_object:
1465 seen_arch = true;
1466 if (!archetype::read (f)) 1462 if (!archetype::read (f))
1467 goto finish; 1463 return false;
1468 break; 1464 break;
1469 1465
1470 case KW_EOF: 1466 case KW_EOF:
1471 success = true; 1467 return true;
1472 goto finish;
1473 1468
1474 default: 1469 default:
1475 if (!f.parse_error ("resource file")) 1470 if (!f.parse_error ("resource file"))
1476 goto finish; 1471 return false;
1477 1472
1478 f.next (); 1473 f.next ();
1479 break; 1474 break;
1480 } 1475 }
1481 } 1476 }
1482
1483finish:
1484 if (seen_arch)
1485 init_archetype_pointers ();
1486
1487 return success;
1488} 1477}
1489 1478

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines